text stringlengths 19 585k | label stringclasses 2
values | category stringclasses 2
values | language stringclasses 14
values | repo stringclasses 932
values | sha stringlengths 40 40 |
|---|---|---|---|---|---|
@@ -352,19 +352,41 @@ Then each socket is used for its intended purpose.
### Video and audio
-On the _video_ and _audio_ sockets, the device first sends some [codec
-metadata]:
- - On the _video_ socket, 12 bytes:
- - the codec id (`u32`) (H264, H265 or AV1)
- - the initial video width (`u32`)
- - the initia... | bad | review | Genymobile/scrcpy | 6235289e77411d0a0a4bf67dfdad8ef7adedf5e8 | |
diff --git a/doc/develop.md b/doc/develop.md
index 002ec4b9ef..3bf69caa98 100644
--- a/doc/develop.md
+++ b/doc/develop.md
@@ -29,7 +29,7 @@ Similarly, if audio is enabled, then the server sends a raw audio stream (OPUS
by default) of the device audio output (or the microphone if
`--audio-source=mic` is specified), w... | good | review_fixed | Genymobile/scrcpy | 6235289e77411d0a0a4bf67dfdad8ef7adedf5e8 | |
@@ -447,6 +447,16 @@ sc_input_manager_process_key(struct sc_input_manager *im,
}
}
+ // Shortcuts that do not involve the MOD key
+ switch (sdl_keycode) {
+ case SDLK_F11:
+ if (video && !shift && !repeat && down) {
+ sc_screen_toggle_fullscreen(im->screen);
+ ... | bad | review | c | Genymobile/scrcpy | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be |
diff --git a/app/src/input_manager.c b/app/src/input_manager.c
index 3ed26f11e8..b55ad591f4 100644
--- a/app/src/input_manager.c
+++ b/app/src/input_manager.c
@@ -447,6 +447,19 @@ sc_input_manager_process_key(struct sc_input_manager *im,
}
}
+ // Shortcuts that do not involve the MOD key
+ switch ... | good | review_fixed | c | Genymobile/scrcpy | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be |
@@ -23,7 +23,7 @@ _<kbd>[Super]</kbd> is typically the <kbd>Windows</kbd> or <kbd>Cmd</kbd> key._
| Action | Shortcut
| ------------------------------------------- |:-----------------------------
- | Switch fullscreen mode | <kbd>MOD</kbd>+<kbd>f</kbd>
+... | bad | review | Genymobile/scrcpy | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be | |
diff --git a/doc/shortcuts.md b/doc/shortcuts.md
index 3a439d17ba..9fe1c0d28c 100644
--- a/doc/shortcuts.md
+++ b/doc/shortcuts.md
@@ -23,7 +23,7 @@ _<kbd>[Super]</kbd> is typically the <kbd>Windows</kbd> or <kbd>Cmd</kbd> key._
| Action | Shortcut
| ------------------------... | good | review_fixed | Genymobile/scrcpy | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be | |
@@ -97,38 +96,38 @@ public void stopAndRelease() {
}
}
- private synchronized Size getAndSetSessionDisplaySize(Size sessionDisplaySize) {
- Size oldDisplaySize = this.sessionDisplaySize;
- this.sessionDisplaySize = sessionDisplaySize;
- return oldDisplaySize;
+ private synchro... | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -14,7 +13,7 @@
import android.os.HandlerThread;
import android.view.IDisplayWindowListener;
-public class DisplaySizeMonitor {
+public class DisplayMonitor {
public interface Listener {
void onDisplaySizeChanged(); | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -97,38 +96,38 @@ public void stopAndRelease() {
}
}
- private synchronized Size getAndSetSessionDisplaySize(Size sessionDisplaySize) {
- Size oldDisplaySize = this.sessionDisplaySize;
- this.sessionDisplaySize = sessionDisplaySize;
- return oldDisplaySize;
+ private synchro... | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -97,38 +96,38 @@ public void stopAndRelease() {
}
}
- private synchronized Size getAndSetSessionDisplaySize(Size sessionDisplaySize) {
- Size oldDisplaySize = this.sessionDisplaySize;
- this.sessionDisplaySize = sessionDisplaySize;
- return oldDisplaySize;
+ private synchro... | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -113,7 +114,7 @@ public void prepare() {
displayRotation = 0;
// Set the current display size to avoid an unnecessary call to invalidate() | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
index ae72877236..5608d13103 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
+++ b/server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -42,7 +43,7 @@ public class NewDisplayCapture extends SurfaceCapture {
private final VirtualDisplayListener vdListener;
private final NewDisplay newDisplay;
- private final DisplaySizeMonitor displaySizeMonitor = new DisplaySizeMonitor();
+ private final DisplayMonitor displaySizeMonitor = new Disp... | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
index ae72877236..5608d13103 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
+++ b/server/src/main/java/com/genymobile/scrcp... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -38,7 +39,7 @@ public class ScreenCapture extends SurfaceCapture {
private DisplayInfo displayInfo;
private Size videoSize;
- private final DisplaySizeMonitor displaySizeMonitor = new DisplaySizeMonitor();
+ private final DisplayMonitor displaySizeMonitor = new DisplayMonitor(); | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
index 77d2eb1706..adabdfb09b 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/Scre... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -76,7 +77,7 @@ public void prepare() throws ConfigurationException {
}
Size displaySize = displayInfo.getSize();
- displaySizeMonitor.setSessionDisplaySize(displaySize);
+ displaySizeMonitor.setSessionDisplayProperties(new DisplayProperties(displaySize, displayInfo.getRotation())); | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
index 77d2eb1706..adabdfb09b 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/Scre... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -0,0 +1,36 @@
+package com.genymobile.scrcpy.display;
+
+import com.genymobile.scrcpy.model.Size;
+
+public final class DisplayProperties {
+ private Size size;
+ private int rotation; | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
new file mode 100644
index 0000000000..d3658334e3
--- /dev/null
+++ b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
@@ -0,0 +1,52... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -0,0 +1,52 @@
+package com.genymobile.scrcpy.display;
+
+import com.genymobile.scrcpy.model.Size;
+
+import java.util.Objects;
+
+public final class DisplayProperties {
+ private Size size;
+ private int rotation;
+
+ public DisplayProperties(Size size, int rotation) {
+ assert size != null;
+ ... | bad | review | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
new file mode 100644
index 0000000000..d3658334e3
--- /dev/null
+++ b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
@@ -0,0 +1,52... | good | review_fixed | java | Genymobile/scrcpy | 03878083fb8e5af806a78a3ad99f401edac47a95 |
@@ -59,18 +58,18 @@ public Size limit(int maxSize) {
*
* @return The current size rounded.
*/
- public Size round8() {
- if (isMultipleOf8()) {
- // Already a multiple of 8
+ public Size round(int alignment) { | bad | review | java | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c |
diff --git a/server/src/main/java/com/genymobile/scrcpy/device/Size.java b/server/src/main/java/com/genymobile/scrcpy/device/Size.java
index b448273de6..b684a54e60 100644
--- a/server/src/main/java/com/genymobile/scrcpy/device/Size.java
+++ b/server/src/main/java/com/genymobile/scrcpy/device/Size.java
@@ -31,7 +31,6 @@... | good | review_fixed | java | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c |
@@ -86,4 +88,15 @@ public void stop() {
public boolean isClosed() {
return false;
}
+
+ /**
+ * Return the video alignment
+ * <p>
+ * This a power-of-2 value that the video width and height must be a multiple of. | bad | review | java | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c |
diff --git a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java
index 3144dc511f..81da337b77 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/S... | good | review_fixed | java | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c |
@@ -30,6 +30,17 @@ If encoding fails, scrcpy automatically tries again with a lower definition
For camera mirroring, the `--max-size` value is used to select the camera source
size instead (among the available resolutions).
+The size is rounded to a multiple of the _alignment_ required by the encoder, a
+power-of-2... | bad | review | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c | |
diff --git a/doc/video.md b/doc/video.md
index 4de6814a76..8cea0373e8 100644
--- a/doc/video.md
+++ b/doc/video.md
@@ -30,6 +30,17 @@ If encoding fails, scrcpy automatically tries again with a lower definition
For camera mirroring, the `--max-size` value is used to select the camera source
size instead (among the ava... | good | review_fixed | Genymobile/scrcpy | de3db4299793450b6d28648852c70ba18ff7887c | |
@@ -198,19 +198,31 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *screen, bool update_content_rect) {
- assert(!screen->video || screen->has_video_window);
+ assert(screen->window_shown);
... | bad | review | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | good | review_fixed | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
@@ -292,6 +304,19 @@ sc_screen_frame_sink_open(struct sc_frame_sink *sink,
return false;
}
+ // content_size can be written from this thread, because it is never read
+ // from the main thread before handling SC_EVENT_OPEN_WINDOW (which acts as
+ // a synchronization point) when video is enable... | bad | review | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | good | review_fixed | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
@@ -292,6 +304,19 @@ sc_screen_frame_sink_open(struct sc_frame_sink *sink,
return false;
}
+ // content_size can be written from this thread, because it is never read
+ // from the main thread before handling SC_EVENT_OPEN_WINDOW (which acts as
+ // a synchronization point) when video is enable... | bad | review | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | good | review_fixed | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
@@ -854,9 +863,18 @@ sc_screen_resize_to_pixel_perfect(struct sc_screen *screen) {
void
sc_screen_handle_event(struct sc_screen *screen, const SDL_Event *event) {
- // !video implies !has_video_window
- assert(screen->video || !screen->has_video_window);
switch (event->type) {
+ case SC_EVENT_OPEN... | bad | review | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | good | review_fixed | c | Genymobile/scrcpy | e17a885f32fcc90337c9719ad3908cecaf03f8f1 |
@@ -92,9 +80,17 @@ example:
scrcpy --prefer-text --turn-screen-off --stay-awake
```
+Add `--pause-on-exit=if-error` if you want the console to remain open when
+scrcpy fails:
+
+```bash
+scrcpy --prefer-text --turn-screen-off --stay-awake --pause-on-exit=if-error
+```
+
[show file extensions]: https://www.howtogee... | bad | review | Genymobile/scrcpy | 8b0206f7bea4929829da09d1ebe0492bcb60e57f | |
diff --git a/doc/windows.md b/doc/windows.md
index cdc30bdce9..b0c4c5ca98 100644
--- a/doc/windows.md
+++ b/doc/windows.md
@@ -72,18 +72,6 @@ Documentation for command line arguments is available:
- `scrcpy --help`
- on [github](/README.md)
-To start scrcpy directly without opening a terminal, double-click on one... | good | review_fixed | Genymobile/scrcpy | 8b0206f7bea4929829da09d1ebe0492bcb60e57f | |
@@ -25,64 +50,54 @@ sc_adb_parse_device(char *line, struct sc_adb_device *device) {
return false;
}
- char *s = line; // cursor in the line
+ size_t len = strlen(line);
+
+ size_t start;
+ size_t end;
+
+ // The serial (the first token) may contain spaces, which are also token
+ // sep... | bad | review | c | Genymobile/scrcpy | 82e102e036c7b983ea8a1af418213fd0c31bd7d0 |
diff --git a/app/src/adb/adb_parser.c b/app/src/adb/adb_parser.c
index 90a1b30b9a..72fd141d60 100644
--- a/app/src/adb/adb_parser.c
+++ b/app/src/adb/adb_parser.c
@@ -8,6 +8,49 @@
#include "util/log.h"
#include "util/str.h"
+static size_t
+rstrip_len(const char *s, size_t len) {
+ size_t i = len;
+
+ // Ignor... | good | review_fixed | c | Genymobile/scrcpy | 82e102e036c7b983ea8a1af418213fd0c31bd7d0 |
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.gz
+PROJECT_DIR=libusb-$VERSION
+SHA256SUM=e8f18a7a36ecbb11fb820bd71540350d8f61bcd9db0d2e8c18a6fb80b214a3de
+
+cd "$SOURCES_DIR"
+
+if [[ -d "$PROJECT_DIR" ]]
+... | bad | review | Genymobile/scrcpy | 8d87b91f692914ada1c146bd911ab4623552174b | |
diff --git a/app/deps/libusb.sh b/app/deps/libusb.sh
new file mode 100755
index 0000000000..97fc3c72fb
--- /dev/null
+++ b/app/deps/libusb.sh
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.bz2
+PROJECT_DIR=l... | good | review_fixed | Genymobile/scrcpy | 8d87b91f692914ada1c146bd911ab4623552174b | |
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.gz
+PROJECT_DIR=libusb-$VERSION
+SHA256SUM=e8f18a7a36ecbb11fb820bd71540350d8f61bcd9db0d2e8c18a6fb80b214a3de
+
+cd "$SOURCES_DIR"
+
+if [[ -d "$PROJECT_DIR" ]]
+... | bad | review | Genymobile/scrcpy | 8d87b91f692914ada1c146bd911ab4623552174b | |
diff --git a/app/deps/libusb.sh b/app/deps/libusb.sh
new file mode 100755
index 0000000000..97fc3c72fb
--- /dev/null
+++ b/app/deps/libusb.sh
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.bz2
+PROJECT_DIR=l... | good | review_fixed | Genymobile/scrcpy | 8d87b91f692914ada1c146bd911ab4623552174b | |
@@ -92,10 +91,26 @@ class Canonical extends Audit {
// Links that had an hrefRaw but didn't have a valid href were invalid, flag them
if (!link.href) invalidCanonicalLink = link;
- // Links that had a valid href but didn't have a valid hrefRaw must have been relatively resolved, flag them
- ... | bad | review | javascript | GoogleChrome/lighthouse | 2e91947a64f6622f1c6f2ea5f43d65bd9b90418e |
diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js
index 1a1868188e4b..2c615422a355 100644
--- a/core/audits/seo/canonical.js
+++ b/core/audits/seo/canonical.js
@@ -5,7 +5,6 @@
*/
import {Audit} from '../audit.js';
-import UrlUtils from '../../lib/url-utils.js';
import {MainResource} from '.... | good | review_fixed | javascript | GoogleChrome/lighthouse | 2e91947a64f6622f1c6f2ea5f43d65bd9b90418e |
@@ -0,0 +1,111 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+ /** Title shown when all agent accessibility checks pass. */
+ title: 'Agentic accessibility tr... | bad | review | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | good | review_fixed | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
@@ -0,0 +1,111 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+ /** Title shown when all agent accessibility checks pass. */
+ title: 'Agentic accessibility tr... | bad | review | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | good | review_fixed | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
@@ -0,0 +1,111 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+ /** Title shown when all agent accessibility checks pass. */
+ title: 'Agentic accessibility tr... | bad | review | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | good | review_fixed | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
@@ -0,0 +1,111 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+ /** Title shown when all agent accessibility checks pass. */
+ title: 'Agentic accessibility tr... | bad | review | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | good | review_fixed | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import {Audit} from '../audit.js';
+import * as i18n from '../../lib/i18n/i18n.js';
+
+const UIStrings = {
+ /** Title shown when all agent accessibility checks pass. */
+ title: 'Accessibility tree is we... | bad | review | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | good | review_fixed | javascript | GoogleChrome/lighthouse | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 |
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons:commons-text:1.10.0',
- JACKSON_BOM: 'com.fasterxml.jackson:jackson-bom:2.15.2',
+ JACKSON_BOM: 'com.fasterxml.j... | bad | review | GoogleContainerTools/jib | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | |
diff --git a/build.gradle b/build.gradle
index e83cba6046..fadc71dd8c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons... | good | review_fixed | GoogleContainerTools/jib | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | |
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons:commons-text:1.10.0',
- JACKSON_BOM: 'com.fasterxml.jackson:jackson-bom:2.15.2',
+ JACKSON_BOM: 'com.fasterxml.j... | bad | review | GoogleContainerTools/jib | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | |
diff --git a/build.gradle b/build.gradle
index e83cba6046..fadc71dd8c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons... | good | review_fixed | GoogleContainerTools/jib | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | |
@@ -88,6 +89,12 @@ $ ./gradlew jib-cli:installDist
$ ./jib-cli/build/install/jib/bin/jib
```
+## Jib CLI JVM options
+
+Jib CLI is a Java application built with the [Gradle application plugin](https://docs.gradle.org/current/userguide/application_plugin.html).
+To configure JVM options for the Jib CLI process itse... | bad | review | GoogleContainerTools/jib | 6e2ca49d3d0c110badef3db4de01709676875ff6 | |
diff --git a/jib-cli/README.md b/jib-cli/README.md
index e23985cade..a81b1d58a4 100644
--- a/jib-cli/README.md
+++ b/jib-cli/README.md
@@ -28,6 +28,7 @@ The CLI tool is powered by [Jib Core](https://github.com/GoogleContainerTools/ji
* [Download a Java Application](#download-a-java-application)
* [Windows: Instal... | good | review_fixed | GoogleContainerTools/jib | 6e2ca49d3d0c110badef3db4de01709676875ff6 | |
@@ -1 +1 @@
-version = 3.5.2-SNAPSHOT
+version = 3.5.4-SNAPSHOT | bad | review | GoogleContainerTools/jib | 0d6e77984ad224b7c300bf082da522097a706df1 | |
diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index f5645169c5..b453e55ba5 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.5.2-SNAPSHOT
+version = 3.5.4-SNAPSHOT
| good | review_fixed | GoogleContainerTools/jib | 0d6e77984ad224b7c300bf082da522097a706df1 | |
@@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.3
+
+### Fixed
+- fix: _jibSkaffoldFilesV2 task fails on Gradle 9.0 [#4469](https://github.com/GoogleContainerTools/jib/issues/4469) | bad | review | GoogleContainerTools/jib | 5f047751314741a7b73a42d4cd126529b0740088 | |
diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index 1a85151213..eb38168488 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.3
+
+### Fixed
+- fix: _... | good | review_fixed | GoogleContainerTools/jib | 5f047751314741a7b73a42d4cd126529b0740088 | |
@@ -222,4 +243,34 @@ private Set<ProjectDependency> findProjectDependencies(Project project) {
}
return projectDependencies;
}
+
+ /**
+ * Resolves a {@link ProjectDependency} to its corresponding {@link Project} instance.
+ *
+ * <p>Uses reflection to handle both Gradle 6 (getDependencyProject()) a... | bad | review | java | GoogleContainerTools/jib | 8a52c51674a514984606259971d3b13c3a432661 |
diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index e5e482d355..6a72637225 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | good | review_fixed | java | GoogleContainerTools/jib | 8a52c51674a514984606259971d3b13c3a432661 |
@@ -139,7 +140,7 @@ private void addGradleFiles(Project project) {
skaffoldFilesOutput.addBuild(project.getBuildFile().toPath());
// Add settings.gradle
- if (project.getGradle().getStartParameter().getSettingsFile() != null) {
+ if (GradleVersion.current().compareTo(GradleVersion.version("9.0")) < 0 ... | bad | review | java | GoogleContainerTools/jib | 560b8c8e9dcb21c6500bf6b4d8828d12930a4db8 |
diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index fc15b021cf..e5e482d355 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | good | review_fixed | java | GoogleContainerTools/jib | 560b8c8e9dcb21c6500bf6b4d8828d12930a4db8 |
@@ -498,6 +520,15 @@ public boolean getAlwaysCacheBaseImage() {
return layerConfigurations;
}
+ /**
+ * Gets the registry mirrors.
+ *
+ * @return the registry mirrors
+ */
+ public ImmutableMap<String, ImmutableList<String>> getRegistryMirrors() { | bad | review | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java b/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
index eb53da3dfa..25ba6dab25 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
+++ b/jib-core/sr... | good | review_fixed | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
@@ -136,6 +141,7 @@ public static Containerizer to(TarImage tarImage) {
private String toolName = DEFAULT_TOOL_NAME;
@Nullable private String toolVersion = DEFAULT_TOOL_VERSION;
private boolean alwaysCacheBaseImage = false;
+ private ListMultimap<String, String> registryMirrors = ArrayListMultimap.create(); | bad | review | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
index 1bd06d11a3..e2747d2a33 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
+++ b/jib-core/src/main/java/com/google/clou... | good | review_fixed | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
@@ -83,7 +84,7 @@ public void testBuilder() throws Exception {
List<String> expectedEntrypoint = Arrays.asList("some", "entrypoint");
List<String> expectedProgramArguments = Arrays.asList("arg1", "arg2");
Map<String, String> expectedEnvironment = ImmutableMap.of("key", "value");
- ImmutableSet<Port> e... | bad | review | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java
index 5ee3359c41..98a365b013 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java
+++ b... | good | review_fixed | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
@@ -303,8 +309,25 @@ public Containerizer setAlwaysCacheBaseImage(boolean alwaysCacheBaseImage) {
return this;
}
+ /**
+ * Sets mirrors for a base image registry. Jib will try its mirrors in the given order before
+ * finally trying the registry.
+ *
+ * @param registry base image registry for which ... | bad | review | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
index 1bd06d11a3..e2747d2a33 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
+++ b/jib-core/src/main/java/com/google/clou... | good | review_fixed | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
@@ -81,21 +83,24 @@ public void setTargetImage(String targetImage) {
* @throws BuildStepsExecutionException if an error occurs while executing build steps
* @throws CacheDirectoryCreationException if a new cache directory could not be created
* @throws MainClassInferenceException if a main class could not b... | bad | review | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java
index 2e9ac562a8..1527849cab 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java
+++ b... | good | review_fixed | java | GoogleContainerTools/jib | e36544461b9a77022364100606e03ff067afcf59 |
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 0.28.0
+
+### Added
+- feat: add default base image for Java 25 (#4436)
+
+### Changed
+- deps: deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support | bad | review | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
diff --git a/jib-core/CHANGELOG.md b/jib-core/CHANGELOG.md
index 40ddbd1f7d..2eb26154f5 100644
--- a/jib-core/CHANGELOG.md
+++ b/jib-core/CHANGELOG.md
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 0.28.0
+
+### Added
+- feat: add default base image for Java 25 ... | good | review_fixed | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: add default base image for Java 25 (#4436)
+
+### Changed
+- deps: deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support | bad | review | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index bea060996b..8e371af50d 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: ... | good | review_fixed | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
@@ -9,6 +9,16 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: add default base image for Java 25 (#4436)
+
+### Changed
+- deps: deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support | bad | review | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md
index 4a569e0289..be4a0caf62 100644
--- a/jib-maven-plugin/CHANGELOG.md
+++ b/jib-maven-plugin/CHANGELOG.md
@@ -9,6 +9,16 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: add ... | good | review_fixed | GoogleContainerTools/jib | 379587813f098905ae015c17e80accffd2df4254 | |
@@ -106,36 +118,85 @@ public List<String> getFoundMainClasses() {
/** {@link ClassVisitor} that keeps track of whether or not it has visited a main class. */
private static class MainClassVisitor extends ClassVisitor {
- /** The return/argument types for main. */
- private static final String MAIN_DESCRIP... | bad | review | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java
index edd452ef54..a3708b6307 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java
+++ b/jib-core/src/main/java/com/googl... | good | review_fixed | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
@@ -149,4 +149,98 @@ public void testMainClass_synthetic() throws URISyntaxException, IOException {
MatcherAssert.assertThat(
mainClassFinderResult.getFoundMainClass(), CoreMatchers.containsString("HelloWorldKt"));
}
+
+ @Test
+ public void testMainClass_java25StaticNoArgs() throws URISyntaxException... | bad | review | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
index e787a4b6f4..f61cfaf09d 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
+++ b/jib-core/src/test/ja... | good | review_fixed | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
@@ -149,4 +149,98 @@ public void testMainClass_synthetic() throws URISyntaxException, IOException {
MatcherAssert.assertThat(
mainClassFinderResult.getFoundMainClass(), CoreMatchers.containsString("HelloWorldKt"));
}
+
+ @Test
+ public void testMainClass_java25StaticNoArgs() throws URISyntaxException... | bad | review | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
index e787a4b6f4..f61cfaf09d 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
+++ b/jib-core/src/test/ja... | good | review_fixed | java | GoogleContainerTools/jib | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 |
@@ -132,23 +132,27 @@ public static MavenProjectProperties getForProject(
}
/**
- * Gets a system property with the given name. First checks for a -D commandline argument, then
- * checks for a property defined in the POM, then returns null if neither are defined.
+ * Gets a property with the given name. ... | bad | review | java | GoogleContainerTools/jib | 0cca78c0eb445536cdaa166ab0e99df6132324cf |
diff --git a/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java b/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java
index 7b457951c6..1bc6cbe1b0 100644
--- a/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectPro... | good | review_fixed | java | GoogleContainerTools/jib | 0cca78c0eb445536cdaa166ab0e99df6132324cf |
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
## [unreleased]
### Added
+- Check Maven user properties with highest precedence when fetching a property value ([#4344](https://github.com/GoogleContainerTools/jib/issues/4344)) | bad | review | GoogleContainerTools/jib | 0cca78c0eb445536cdaa166ab0e99df6132324cf | |
diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md
index 94750aa3c2..367a6a6f66 100644
--- a/jib-maven-plugin/CHANGELOG.md
+++ b/jib-maven-plugin/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
### Added
### Changed
+- Update retrieval of Mav... | good | review_fixed | GoogleContainerTools/jib | 0cca78c0eb445536cdaa166ab0e99df6132324cf |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.