text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,569 @@ +use std::collections::HashMap; + +use core_types::Context; +use core_types::context::ContextDependencies; +use core_types::uuid::NodeId as RuntimeNodeId; +use graph_craft::concrete; +use graph_craft::document::value::TaggedValue; +use graph_craft::document::{DocumentNode, DocumentNodeImplementation, ...
bad
review
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs new file mode 100644 index 0000000000..0c2cd26f41 --- /dev/null +++ b/document/graph-storage/src/from_runtime.rs @@ -0,0 +1,573 @@ +use std::collections::HashMap; + +use core_types::Context; +use core_types::context::Co...
good
review_fixed
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
@@ -0,0 +1,569 @@ +use std::collections::HashMap; + +use core_types::Context; +use core_types::context::ContextDependencies; +use core_types::uuid::NodeId as RuntimeNodeId; +use graph_craft::concrete; +use graph_craft::document::value::TaggedValue; +use graph_craft::document::{DocumentNode, DocumentNodeImplementation, ...
bad
review
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs new file mode 100644 index 0000000000..0c2cd26f41 --- /dev/null +++ b/document/graph-storage/src/from_runtime.rs @@ -0,0 +1,573 @@ +use std::collections::HashMap; + +use core_types::Context; +use core_types::context::Co...
good
review_fixed
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
@@ -0,0 +1,328 @@ +use std::borrow::Cow; +use std::collections::HashMap; + +use core_types::memo::MemoHash; +use core_types::uuid::NodeId as RuntimeNodeId; +use graph_craft::document::value::TaggedValue; +use graph_craft::document::{DocumentNode, DocumentNodeImplementation, NodeInput as GraphCraftNodeInput, NodeNetwork...
bad
review
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs new file mode 100644 index 0000000000..d9f19852ae --- /dev/null +++ b/document/graph-storage/src/to_runtime.rs @@ -0,0 +1,380 @@ +use std::borrow::Cow; +use std::collections::HashMap; + +use core_types::memo::MemoHash; +use...
good
review_fixed
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
@@ -0,0 +1,458 @@ +use crate::{ + CrdtError, Delta, ExportSlot, HotOp, LamportClock, MAX_EXPORT_SLOTS, NetworkId, NodeId, NodeInput, PeerId, Registry, RegistryDelta, ResourceEntry, Rev, SourceValue, TimeStamp, + apply_attribute_delta, reverse_attribute_delta, +}; +use std::collections::HashMap; + +#[derive(Clone, Debug...
bad
review
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
diff --git a/document/graph-storage/src/document.rs b/document/graph-storage/src/document.rs new file mode 100644 index 0000000000..d93bc9a032 --- /dev/null +++ b/document/graph-storage/src/document.rs @@ -0,0 +1,459 @@ +use crate::{ + CrdtError, Delta, ExportSlot, HotOp, LamportClock, MAX_EXPORT_SLOTS, NetworkId, Node...
good
review_fixed
rust
GraphiteEditor/Graphite
fdcd63d9db43cd8fef91b929d90740c835cf12f8
@@ -68,9 +68,9 @@ The Editor's frontend web code lives in `/frontend/src` and the backend Rust cod ### Frontend/backend communication. -Frontend (JS) -> backend (Rust/wasm) communication is achieved through a thin Rust translation layer in `/frontend/wasm/editor_api.rs` which wraps the Editor backend's complex Rus...
bad
review
GraphiteEditor/Graphite
37a06745eca3821fc5c221984e41d260c5b50d07
diff --git a/website/content/contribute/_index.md b/website/content/contribute/_index.md index 06cdd22a79..4edd0f7c69 100644 --- a/website/content/contribute/_index.md +++ b/website/content/contribute/_index.md @@ -68,9 +68,9 @@ The Editor's frontend web code lives in `/frontend/src` and the backend Rust cod ### Fro...
good
review_fixed
GraphiteEditor/Graphite
37a06745eca3821fc5c221984e41d260c5b50d07
@@ -1125,6 +1125,9 @@ impl DocumentMessageHandler { pub fn is_saved(&self) -> bool { self.current_hash() == self.saved_hash } + pub fn is_graph_overlay_open(&self) -> bool {
bad
review
rust
GraphiteEditor/Graphite
06a8e81c41e117aec74f00885cc674816c5f9bd0
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index 15c9958acb..b8873247a7 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
good
review_fixed
rust
GraphiteEditor/Graphite
06a8e81c41e117aec74f00885cc674816c5f9bd0
@@ -430,13 +430,15 @@ impl MessageHandler<PortfolioMessage, (&InputPreprocessorMessageHandler, &Prefer } PortfolioMessage::SelectDocument { document_id } => { // Auto-save the document we are leaving + let mut send_overlay = false;
bad
review
rust
GraphiteEditor/Graphite
06a8e81c41e117aec74f00885cc674816c5f9bd0
diff --git a/editor/src/messages/portfolio/portfolio_message_handler.rs b/editor/src/messages/portfolio/portfolio_message_handler.rs index 8c4d14e82d..5f166b8fb0 100644 --- a/editor/src/messages/portfolio/portfolio_message_handler.rs +++ b/editor/src/messages/portfolio/portfolio_message_handler.rs @@ -430,6 +430,7 @@ i...
good
review_fixed
rust
GraphiteEditor/Graphite
06a8e81c41e117aec74f00885cc674816c5f9bd0
@@ -149,6 +152,15 @@ impl PointDomain { self.positions[index] = position; } + pub fn set_position_by_id(&mut self, id: PointId, position: DVec2) {
bad
review
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs index 57c5289f8a..bb7ed2ae88 100644 --- a/node-graph/gcore/src/vector/vector_data/attributes.rs +++ b/node-graph/gcore/src/vector/vector_data/attributes.rs @@ -1,4 +1,6 @@ use crate::vector::vecto...
good
review_fixed
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
@@ -504,6 +542,12 @@ impl RegionDomain { } } +pub struct Region {
bad
review
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs index 57c5289f8a..bb7ed2ae88 100644 --- a/node-graph/gcore/src/vector/vector_data/attributes.rs +++ b/node-graph/gcore/src/vector/vector_data/attributes.rs @@ -1,4 +1,6 @@ use crate::vector::vecto...
good
review_fixed
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
@@ -653,6 +697,13 @@ impl VectorData { self.segment_domain.map_ids(&id_map); self.region_domain.map_ids(&id_map); } +
bad
review
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs index 57c5289f8a..bb7ed2ae88 100644 --- a/node-graph/gcore/src/vector/vector_data/attributes.rs +++ b/node-graph/gcore/src/vector/vector_data/attributes.rs @@ -1,4 +1,6 @@ use crate::vector::vecto...
good
review_fixed
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
@@ -0,0 +1,146 @@ +use std::borrow::Cow; + +use bezier_rs::BezierHandles; +use glam::DVec2; +use petgraph::graph::{EdgeIndex, NodeIndex, UnGraph}; +use rustc_hash::FxHashMap; + +use super::{PointId, SegmentId, VectorData}; + +pub struct IndexedVectorData<'a> { + /// This structure owns the data to allow convenient modi...
bad
review
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
diff --git a/node-graph/gcore/src/vector/vector_data/indexed.rs b/node-graph/gcore/src/vector/vector_data/indexed.rs new file mode 100644 index 0000000000..e3e1c3cdf9 --- /dev/null +++ b/node-graph/gcore/src/vector/vector_data/indexed.rs @@ -0,0 +1,90 @@ +use super::{PointId, SegmentId, VectorData}; +use glam::DVec2; +...
good
review_fixed
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
@@ -0,0 +1,146 @@ +use std::borrow::Cow; + +use bezier_rs::BezierHandles; +use glam::DVec2; +use petgraph::graph::{EdgeIndex, NodeIndex, UnGraph}; +use rustc_hash::FxHashMap; + +use super::{PointId, SegmentId, VectorData}; + +pub struct IndexedVectorData<'a> { + /// This structure owns the data to allow convenient modi...
bad
review
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
diff --git a/node-graph/gcore/src/vector/vector_data/indexed.rs b/node-graph/gcore/src/vector/vector_data/indexed.rs new file mode 100644 index 0000000000..e3e1c3cdf9 --- /dev/null +++ b/node-graph/gcore/src/vector/vector_data/indexed.rs @@ -0,0 +1,90 @@ +use super::{PointId, SegmentId, VectorData}; +use glam::DVec2; +...
good
review_fixed
rust
GraphiteEditor/Graphite
9a96551b6bd601b9f91249c611a44147350ae982
@@ -1913,6 +1913,51 @@ fn static_nodes() -> Vec<DocumentNodeType> { properties: node_properties::no_properties, ..Default::default() }, + DocumentNodeType { + name: "OR", + category: "Logic", + identifier: NodeImplementation::proto("graphene_core::logic::LogicOrNode<_>"), + inputs: vec![ + Docume...
bad
review
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs index f3d360e9eb..265219c687 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_graph_me...
good
review_fixed
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
@@ -1913,6 +1913,51 @@ fn static_nodes() -> Vec<DocumentNodeType> { properties: node_properties::no_properties, ..Default::default() }, + DocumentNodeType { + name: "OR", + category: "Logic", + identifier: NodeImplementation::proto("graphene_core::logic::LogicOrNode<_>"), + inputs: vec![ + Docume...
bad
review
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs index f3d360e9eb..265219c687 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_graph_me...
good
review_fixed
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
@@ -1913,6 +1913,51 @@ fn static_nodes() -> Vec<DocumentNodeType> { properties: node_properties::no_properties, ..Default::default() }, + DocumentNodeType { + name: "OR", + category: "Logic", + identifier: NodeImplementation::proto("graphene_core::logic::LogicOrNode<_>"), + inputs: vec![ + Docume...
bad
review
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs index f3d360e9eb..265219c687 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_graph_me...
good
review_fixed
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
@@ -7,3 +7,38 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T { debug!("{:#?}", value); value } + +pub struct LogicOrNode<Second> { + second: Second, +} + +#[node_macro::node_fn(LogicOrNode)] +fn logic_or(first: bool, second: bool) -> bool { + first || second +} + +pub struct LogicAndNode<Second> { + seco...
bad
review
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
diff --git a/node-graph/gcore/src/logic.rs b/node-graph/gcore/src/logic.rs index 2d56e313fb..88619ae693 100644 --- a/node-graph/gcore/src/logic.rs +++ b/node-graph/gcore/src/logic.rs @@ -7,3 +7,37 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T { debug!("{:#?}", value); value } + +pub struct LogicOrNode<S...
good
review_fixed
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
@@ -7,3 +7,38 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T { debug!("{:#?}", value); value } + +pub struct LogicOrNode<Second> { + second: Second, +} + +#[node_macro::node_fn(LogicOrNode)] +fn logic_or(first: bool, second: bool) -> bool { + first || second +} + +pub struct LogicAndNode<Second> { + seco...
bad
review
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
diff --git a/node-graph/gcore/src/logic.rs b/node-graph/gcore/src/logic.rs index 2d56e313fb..88619ae693 100644 --- a/node-graph/gcore/src/logic.rs +++ b/node-graph/gcore/src/logic.rs @@ -7,3 +7,37 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T { debug!("{:#?}", value); value } + +pub struct LogicOrNode<S...
good
review_fixed
rust
GraphiteEditor/Graphite
c5799da97b1518ee72dc9930b88e04df7f84cf4b
@@ -297,7 +297,8 @@ impl MessageHandler<DocumentMessage, DocumentMessageData<'_>> for DocumentMessag .collect(); let id = NodeId(generate_uuid()); - let insert_index = -1; + let selected_layer_index = parent.children(self.metadata()).collect::<Vec<_>>().iter().position(|&sibling| sibling == layer)...
bad
review
rust
GraphiteEditor/Graphite
ee9e5ccb05a2e11385e936a4102ddc1bd544e08b
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index cabadff703..8873720962 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
good
review_fixed
rust
GraphiteEditor/Graphite
ee9e5ccb05a2e11385e936a4102ddc1bd544e08b
@@ -297,7 +297,8 @@ impl MessageHandler<DocumentMessage, DocumentMessageData<'_>> for DocumentMessag .collect(); let id = NodeId(generate_uuid()); - let insert_index = -1; + let selected_layer_index = parent.children(self.metadata()).collect::<Vec<_>>().iter().position(|&sibling| sibling == layer)...
bad
review
rust
GraphiteEditor/Graphite
ee9e5ccb05a2e11385e936a4102ddc1bd544e08b
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index cabadff703..8873720962 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
good
review_fixed
rust
GraphiteEditor/Graphite
ee9e5ccb05a2e11385e936a4102ddc1bd544e08b
@@ -407,7 +407,11 @@ fn unwrap<T: Default>(_: (), #[implementations(Option<f64>, Option<f32>, Option< fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: &'i T) -> T { value.clone() } - +#[node_macro::node(category("Math: Vector"))] +fn dot_product(#[implementations(DVec2)] vector_a: gl...
bad
review
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs index 117053616d..807156664b 100644 --- a/node-graph/gcore/src/ops.rs +++ b/node-graph/gcore/src/ops.rs @@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: value.clone() } +#[node_macro::node(ca...
good
review_fixed
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
@@ -476,4 +480,11 @@ mod test { let fnn = FnNode::new(|(a, b)| (b, a)); assert_eq!(fnn.eval((1u32, 2u32)), (2, 1)); } + + #[test] + pub fn dot_product_function() { + let vector_a = glam::DVec2::new(1.0, 2.0); + let vector_b = glam::DVec2::new(3.0, 4.0); + assert_eq!(dot_product(vector_a, vector_b), 11.0); //...
bad
review
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs index 117053616d..807156664b 100644 --- a/node-graph/gcore/src/ops.rs +++ b/node-graph/gcore/src/ops.rs @@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: value.clone() } +#[node_macro::node(ca...
good
review_fixed
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
@@ -408,6 +408,16 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: value.clone() } +#[node_macro::node(category("Math: Vector"))] +fn dot_product(#[implementations(DVec2)] vector_a: glam::DVec2, #[implementations(DVec2)] vector_b: glam::DVec2) -> f64 { + vector_a.dot(vector_b) +}...
bad
review
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs index 117053616d..807156664b 100644 --- a/node-graph/gcore/src/ops.rs +++ b/node-graph/gcore/src/ops.rs @@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: value.clone() } +#[node_macro::node(ca...
good
review_fixed
rust
GraphiteEditor/Graphite
ce3e19df322da069dcb3a2243b71269a4003e292
@@ -12,22 +12,31 @@ Graphite is built with Rust and web technologies. Install the latest LTS version ## Installing Clone the project: + ```sh git clone https://github.com/GraphiteEditor/Graphite.git ``` -On Debian-based Linux distributions, you may need to install the following packages: +On Debian-based(Ubunt...
bad
review
GraphiteEditor/Graphite
64a0e42af265a66fb90754a2c2ea9cc8721e8391
diff --git a/website/content/volunteer/guide/getting-started/_index.md b/website/content/volunteer/guide/getting-started/_index.md index 7e1ec7efd6..921e7c76f5 100644 --- a/website/content/volunteer/guide/getting-started/_index.md +++ b/website/content/volunteer/guide/getting-started/_index.md @@ -12,22 +12,31 @@ Graph...
good
review_fixed
GraphiteEditor/Graphite
64a0e42af265a66fb90754a2c2ea9cc8721e8391
@@ -12,22 +12,31 @@ Graphite is built with Rust and web technologies. Install the latest LTS version ## Installing Clone the project: + ```sh git clone https://github.com/GraphiteEditor/Graphite.git ``` -On Debian-based Linux distributions, you may need to install the following packages: +On Debian-based(Ubunt...
bad
review
GraphiteEditor/Graphite
64a0e42af265a66fb90754a2c2ea9cc8721e8391
diff --git a/website/content/volunteer/guide/getting-started/_index.md b/website/content/volunteer/guide/getting-started/_index.md index 7e1ec7efd6..921e7c76f5 100644 --- a/website/content/volunteer/guide/getting-started/_index.md +++ b/website/content/volunteer/guide/getting-started/_index.md @@ -12,22 +12,31 @@ Graph...
good
review_fixed
GraphiteEditor/Graphite
64a0e42af265a66fb90754a2c2ea9cc8721e8391
@@ -100,29 +100,91 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { } CloseDocument(id) => { assert!(id < self.documents.len(), "Tried to select a document that was not initialized"); - self.active_document = id - 1; - self.documents.pop(); - let lp = self.active_document_m...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -157,9 +158,21 @@ export default defineComponent({ }, methods: { async handleTabClick(tabIndex: number) { + console.log(`TAB IDX: ${tabIndex}`);
bad
review
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue index dc167abf79..5b59705a3c 100644 --- a/client/web/src/components/workspace/Panel.vue +++ b/client/web/src/components/workspace/Panel.vue @@ -4,7 +4,7 @@ <div class="tab-group"> <div class="tab" :class=...
good
review_fixed
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -157,9 +158,21 @@ export default defineComponent({ }, methods: { async handleTabClick(tabIndex: number) { + console.log(`TAB IDX: ${tabIndex}`); const { select_document } = await wasm; select_document(tabIndex); }, + async closeTab(tabIndex: number) { + const { close_document } = await wasm; +...
bad
review
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue index dc167abf79..5b59705a3c 100644 --- a/client/web/src/components/workspace/Panel.vue +++ b/client/web/src/components/workspace/Panel.vue @@ -4,7 +4,7 @@ <div class="tab-group"> <div class="tab" :class=...
good
review_fixed
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -157,9 +158,21 @@ export default defineComponent({ }, methods: { async handleTabClick(tabIndex: number) { + console.log(`TAB IDX: ${tabIndex}`); const { select_document } = await wasm; select_document(tabIndex); }, + async closeTab(tabIndex: number) { + const { close_document } = await wasm; +...
bad
review
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue index dc167abf79..5b59705a3c 100644 --- a/client/web/src/components/workspace/Panel.vue +++ b/client/web/src/components/workspace/Panel.vue @@ -4,7 +4,7 @@ <div class="tab-group"> <div class="tab" :class=...
good
review_fixed
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -58,19 +60,30 @@ function parseResponse(responseType: string, data: any): Response { return newSetActiveDocument(data.SetActiveDocument); case "NewDocument": return newNewDocument(data.NewDocument); + case "CloseDocument": + return newCloseDocument(data.CloseDocument); case "UpdateCanvas": retur...
bad
review
typescript
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/src/response-handler.ts b/client/web/src/response-handler.ts index 5f842644ad..11c05191b5 100644 --- a/client/web/src/response-handler.ts +++ b/client/web/src/response-handler.ts @@ -18,7 +18,9 @@ export enum ResponseType { SetActiveTool = "SetActiveTool", SetActiveDocument = "SetActiveDocum...
good
review_fixed
typescript
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -23,9 +23,16 @@ pub fn select_tool(tool: String) -> Result<(), JsValue> { #[wasm_bindgen] pub fn select_document(document: usize) -> Result<(), JsValue> { + log::debug!("SELECT_TOOL");
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/wasm/src/document.rs b/client/web/wasm/src/document.rs index bf12008ee5..70cdf049db 100644 --- a/client/web/wasm/src/document.rs +++ b/client/web/wasm/src/document.rs @@ -26,6 +26,11 @@ pub fn select_document(document: usize) -> Result<(), JsValue> { EDITOR_STATE.with(|editor| editor.borrow_mu...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -23,9 +23,16 @@ pub fn select_tool(tool: String) -> Result<(), JsValue> { #[wasm_bindgen] pub fn select_document(document: usize) -> Result<(), JsValue> { + log::debug!("SELECT_TOOL"); EDITOR_STATE.with(|editor| editor.borrow_mut().handle_message(DocumentMessage::SelectDocument(document)).map_err(convert_error...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/client/web/wasm/src/document.rs b/client/web/wasm/src/document.rs index bf12008ee5..70cdf049db 100644 --- a/client/web/wasm/src/document.rs +++ b/client/web/wasm/src/document.rs @@ -26,6 +26,11 @@ pub fn select_document(document: usize) -> Result<(), JsValue> { EDITOR_STATE.with(|editor| editor.borrow_mu...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { .into(), ); } + CloseActiveDocument => { + responses.push_back(FrontendMessage::ShowConfirmationBox.into()); + /* + log::debug!("CLOSE ACTIVE"); + self.documents.remove(self.active_document); + res...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { .into(), ); } + CloseActiveDocument => { + responses.push_back(FrontendMessage::ShowConfirmationBox.into()); + /* + log::debug!("CLOSE ACTIVE"); + self.documents.remove(self.active_document); + res...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { .into(), ); } + CloseActiveDocument => { + responses.push_back(FrontendMessage::ShowConfirmationBox.into()); + /* + log::debug!("CLOSE ACTIVE"); + self.documents.remove(self.active_document); + res...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { .into(), ); } + CloseActiveDocument => { + responses.push_back(FrontendMessage::ShowConfirmationBox.into()); + /* + log::debug!("CLOSE ACTIVE"); + self.documents.remove(self.active_document); + res...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -163,37 +163,34 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler { } } NewDocument => { - /* - let mut acc = Vec::new(); - let digits = vec!['0', '1', '2', '3', '4', '5', '6', '7', '8', '9']; - for d in &self.documents { - let name = &d.name; - log::de...
bad
review
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs index 269a1f9e4f..8247434bd8 100644 --- a/core/editor/src/document/document_message_handler.rs +++ b/core/editor/src/document/document_message_handler.rs @@ -17,6 +17,8 @@ pub enum DocumentMessage { ...
good
review_fixed
rust
GraphiteEditor/Graphite
01cfc9ec739efd5fbe28cc7e469b20f63841eebe
@@ -186,6 +186,117 @@ fn star<T: AsU64>( Table::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::splat(-diameter), points, diameter, inner_diameter))) } +/// Generates a QR code from the input text. +#[node_macro::node(category("Vector: Shape"))]
bad
review
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs index 098b1782ac..2d1b1a26de 100644 --- a/node-graph/nodes/vector/src/generator_nodes.rs +++ b/node-graph/nodes/vector/src/generator_nodes.rs @@ -186,6 +186,51 @@ fn star<T: AsU64>( Table::new_from_element(Vec...
good
review_fixed
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
@@ -186,6 +186,117 @@ fn star<T: AsU64>( Table::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::splat(-diameter), points, diameter, inner_diameter))) } +/// Generates a QR code from the input text. +#[node_macro::node(category("Vector: Shape"))] +fn qr_code( + _: impl Ctx, + _primar...
bad
review
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs index 098b1782ac..2d1b1a26de 100644 --- a/node-graph/nodes/vector/src/generator_nodes.rs +++ b/node-graph/nodes/vector/src/generator_nodes.rs @@ -186,6 +186,51 @@ fn star<T: AsU64>( Table::new_from_element(Vec...
good
review_fixed
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
@@ -186,6 +186,117 @@ fn star<T: AsU64>( Table::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::splat(-diameter), points, diameter, inner_diameter))) } +/// Generates a QR code from the input text. +#[node_macro::node(category("Vector: Shape"))] +fn qr_code( + _: impl Ctx, + _primar...
bad
review
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs index 098b1782ac..2d1b1a26de 100644 --- a/node-graph/nodes/vector/src/generator_nodes.rs +++ b/node-graph/nodes/vector/src/generator_nodes.rs @@ -186,6 +186,51 @@ fn star<T: AsU64>( Table::new_from_element(Vec...
good
review_fixed
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
@@ -0,0 +1,118 @@ +use glam::DVec2; +use graphic_types::Vector; +use std::collections::VecDeque; +use vector_types::subpath; + +pub fn merge_qr_squares(qr_code: &qrcodegen::QrCode, vector: &mut Vector) { + let size = qr_code.size() as usize; + + // 0 = empty + // 1 = black, unvisited + // 2 = black, current island + le...
bad
review
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
diff --git a/node-graph/nodes/vector/src/merge_qr_squares.rs b/node-graph/nodes/vector/src/merge_qr_squares.rs new file mode 100644 index 0000000000..ea2ac61372 --- /dev/null +++ b/node-graph/nodes/vector/src/merge_qr_squares.rs @@ -0,0 +1,118 @@ +use glam::DVec2; +use graphic_types::Vector; +use std::collections::VecD...
good
review_fixed
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
@@ -186,6 +186,51 @@ fn star<T: AsU64>( Table::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::splat(-diameter), points, diameter, inner_diameter))) } +/// Generates a QR code from the input text. +#[node_macro::node(category("Vector: Shape"), name("QR Code"))] +fn qr_code( + _: imp...
bad
review
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs index 098b1782ac..2d1b1a26de 100644 --- a/node-graph/nodes/vector/src/generator_nodes.rs +++ b/node-graph/nodes/vector/src/generator_nodes.rs @@ -186,6 +186,51 @@ fn star<T: AsU64>( Table::new_from_element(Vec...
good
review_fixed
rust
GraphiteEditor/Graphite
fb4891207439be1dbef67bf61a477ae4ed3365ad
@@ -2397,6 +2399,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> { }), ), Into::<PropertiesRow>::into(("Adaptive Spacing", "Round 'Spacing' to a nearby value that divides into the path length evenly.")), + Into::<PropertiesRow>::into(("Count points", "Calculate the distance between poin...
bad
review
rust
GraphiteEditor/Graphite
5be3a43037a05a946d4ca1fa4be43697a9ea8eb8
diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs b/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs index af8f6bd130..729334dc52 100644 --- a/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs +++ b/editor/src/messages/...
good
review_fixed
rust
GraphiteEditor/Graphite
5be3a43037a05a946d4ca1fa4be43697a9ea8eb8
@@ -34,17 +34,21 @@ pub fn sample_points_on_bezpath(bezpath: BezPath, spacing: f64, start_offset: f6 } // Determine the number of points to generate along the path. - let sample_count = if adaptive_spacing { - // Calculate point count to evenly distribute points while covering the entire path. - // With adaptiv...
bad
review
rust
GraphiteEditor/Graphite
5be3a43037a05a946d4ca1fa4be43697a9ea8eb8
diff --git a/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs b/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs index fa7682e63b..fa8af0f6d5 100644 --- a/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs +++ b/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs @@ -1,5 +1,5 ...
good
review_fixed
rust
GraphiteEditor/Graphite
5be3a43037a05a946d4ca1fa4be43697a9ea8eb8
@@ -334,6 +334,27 @@ impl GradientStops { } } +#[repr(C)] +#[cfg_attr(feature = "wasm", derive(tsify::Tsify))] +#[derive(Default, PartialEq, Eq, Clone, Copy, Debug, Hash, serde::Serialize, serde::Deserialize, DynAny, node_macro::ChoiceType)] +#[widget(Radio)] +pub enum GradientSpreadMethod { + #[default] + Pad, + ...
bad
review
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
diff --git a/node-graph/libraries/vector-types/src/gradient.rs b/node-graph/libraries/vector-types/src/gradient.rs index 653ca6bc5d..f5c241c2f0 100644 --- a/node-graph/libraries/vector-types/src/gradient.rs +++ b/node-graph/libraries/vector-types/src/gradient.rs @@ -334,6 +334,27 @@ impl GradientStops { } } +#[rep...
good
review_fixed
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
@@ -53,6 +54,7 @@ pub enum GradientOptionsUpdate { Type(GradientType), ReverseStops, ReverseDirection, + SpreadMethod(GradientSpreadMethod),
bad
review
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs index f1823618e5..f6b8f49be9 100644 --- a/editor/src/messages/tool/tool_messages/gradient_tool.rs +++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs @@ -9,7 +9,7 @@ use crate::messag...
good
review_fixed
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
@@ -345,6 +366,8 @@ pub struct Gradient { pub gradient_type: GradientType, pub start: DVec2, pub end: DVec2, + #[serde(default)] + pub spread_method: GradientSpreadMethod,
bad
review
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
diff --git a/node-graph/libraries/vector-types/src/gradient.rs b/node-graph/libraries/vector-types/src/gradient.rs index 653ca6bc5d..f5c241c2f0 100644 --- a/node-graph/libraries/vector-types/src/gradient.rs +++ b/node-graph/libraries/vector-types/src/gradient.rs @@ -334,6 +334,27 @@ impl GradientStops { } } +#[rep...
good
review_fixed
rust
GraphiteEditor/Graphite
4d3eb14895716d4de90368e39975bb6e08a675cd
@@ -193,6 +194,22 @@ fn flatten_graphic_table<T>(content: Table<Graphic>, extract_variant: fn(Graphic output } +fn fill_to_paint(fill: Fill) -> Option<Table<Graphic>> { + match fill { + Fill::None => None, + Fill::Solid(color) => Some(Table::new_from_element(color.into())), + Fill::Gradient(gradient) => { + l...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs index 13bd8b7150..e70153a389 100644 --- a/node-graph/libraries/graphic-types/src/graphic.rs +++ b/node-graph/libraries/graphic-types/src/graphic.rs @@ -1,17 +1,17 @@ use core_types::bounds::{BoundingBox, ...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -950,32 +1066,46 @@ impl Render for List<Vector> { MaskType::Mask }; + let fill_graphic_list = self + .attribute::<List<Graphic>>(ATTR_FILL_GRAPHIC, index) + .filter(|list| !list.is_empty()) + .cloned() + .or_else(|| fill_to_graphic_list(vector.style.fill()));
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs index 7cae299753..c04d787592 100644 --- a/node-graph/libraries/rendering/src/renderer.rs +++ b/node-graph/libraries/rendering/src/renderer.rs @@ -1,4 +1,4 @@ -use crate::render_ext::RenderExt; +use crate::render...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -1179,88 +1339,114 @@ impl Render for List<Vector> { let use_layer = can_draw_aligned_stroke; let wants_stroke_below = stroke.as_ref().is_some_and(|s| s.paint_order == vector::style::PaintOrder::StrokeBelow); - // Closures to avoid duplicated fill/stroke drawing logic - let do_fill_path = |scene: &mut ...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs index 7cae299753..c04d787592 100644 --- a/node-graph/libraries/rendering/src/renderer.rs +++ b/node-graph/libraries/rendering/src/renderer.rs @@ -1,4 +1,4 @@ -use crate::render_ext::RenderExt; +use crate::render...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -327,6 +328,121 @@ fn draw_raster_outline(scene: &mut Scene, outline_transform: &DAffine2, render_p scene.stroke(&outline_stroke, Affine::IDENTITY, outline_color_peniko, None, &outline_path); } +/// Returns true if the resolved fill graphic fully and opaquely covers the path interior. +fn fill_covers_opaquely(f...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs index 7cae299753..c04d787592 100644 --- a/node-graph/libraries/rendering/src/renderer.rs +++ b/node-graph/libraries/rendering/src/renderer.rs @@ -1,4 +1,4 @@ -use crate::render_ext::RenderExt; +use crate::render...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9