text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -987,38 +1117,51 @@ impl Render for List<Vector> { // The mask must draw at full alpha so the SVG `<mask>`/`<clipPath>` fully zeroes the path interior. // The wrapping SVG group (above) handles the user-set opacity. - let vector_item = List::new_from_item(Item::new_from_element(cloned_vector).with_att...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs index 7cae299753..c04d787592 100644 --- a/node-graph/libraries/rendering/src/renderer.rs +++ b/node-graph/libraries/rendering/src/renderer.rs @@ -1,4 +1,4 @@ -use crate::render_ext::RenderExt; +use crate::render...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -1,24 +1,78 @@ use crate::renderer::{RenderParams, format_transform_matrix}; +use crate::{Render, RenderSvgSegmentList, SvgRender}; use core_types::color::SRGBA8; +use core_types::list::List; use core_types::uuid::generate_uuid; -use glam::DAffine2; -use graphic_types::vector_types::gradient::{Gradient, GradientT...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/render_ext.rs b/node-graph/libraries/rendering/src/render_ext.rs index 883640d05d..197887add0 100644 --- a/node-graph/libraries/rendering/src/render_ext.rs +++ b/node-graph/libraries/rendering/src/render_ext.rs @@ -1,24 +1,104 @@ use crate::renderer::{RenderParams, forma...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -332,11 +439,57 @@ impl Graphic { Graphic::Vector(vector) => (0..vector.len()).all(|index| { let Some(element) = vector.element(index) else { return false }; let opacity: f64 = vector.attribute_cloned_or(ATTR_OPACITY, index, 1.); - opacity > 1. - f64::EPSILON && element.style.fill().is_opaque() && e...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs index 13bd8b7150..e70153a389 100644 --- a/node-graph/libraries/graphic-types/src/graphic.rs +++ b/node-graph/libraries/graphic-types/src/graphic.rs @@ -1,17 +1,17 @@ use core_types::bounds::{BoundingBox, ...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -169,6 +172,110 @@ fn flatten_graphic_list<T>(content: List<Graphic>, extract_variant: fn(Graphic) output } +/// Converts a `Fill` enum into the `List<Graphic>` representation used as paint storage. +/// TODO: Remove once all fill paint sources flow through `List<Graphic>` directly without going through the `Fi...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs index 13bd8b7150..e70153a389 100644 --- a/node-graph/libraries/graphic-types/src/graphic.rs +++ b/node-graph/libraries/graphic-types/src/graphic.rs @@ -1,17 +1,17 @@ use core_types::bounds::{BoundingBox, ...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -329,6 +336,103 @@ fn draw_raster_outline(scene: &mut Scene, outline_transform: &DAffine2, render_p scene.stroke(&outline_stroke, Affine::IDENTITY, outline_color_peniko, None, &outline_path); } +/// Emits an SVG `<path>` element with the resolved fill attribute corresponding to the given fill_graphic. +#[allow(...
bad
review
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs index 7cae299753..c04d787592 100644 --- a/node-graph/libraries/rendering/src/renderer.rs +++ b/node-graph/libraries/rendering/src/renderer.rs @@ -1,4 +1,4 @@ -use crate::render_ext::RenderExt; +use crate::render...
good
review_fixed
rust
GraphiteEditor/Graphite
46b987404452c427b9014d451d9c95af08dc18d9
@@ -154,6 +154,13 @@ impl ProtoNodeIdentifier { pub fn as_str(&self) -> &str { self.name.as_ref() } + + pub const fn as_static_str(&self) -> &'static str {
bad
review
rust
GraphiteEditor/Graphite
2bc7bfdae4cba601871fa09ddb6b97578e8b2a19
diff --git a/node-graph/libraries/core-types/src/types.rs b/node-graph/libraries/core-types/src/types.rs index cd4f6700e3..5e70dcbced 100644 --- a/node-graph/libraries/core-types/src/types.rs +++ b/node-graph/libraries/core-types/src/types.rs @@ -154,6 +154,13 @@ impl ProtoNodeIdentifier { pub fn as_str(&self) -> &st...
good
review_fixed
rust
GraphiteEditor/Graphite
2bc7bfdae4cba601871fa09ddb6b97578e8b2a19
@@ -0,0 +1,59 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_request_handler_t, cef_base_ref_counted_t}; +use cef::{Browser, Callback, CefString, Frame, ImplRequest, ImplResourceRequestHandler, Request, ReturnValue, WrapResourceRequestHandler}; + +use crate::cef::consts::{RESOURCE_DOMAIN, RESOURCE_SCHEME}...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs new file mode 100644 index 0000000000..94d8ec47e3 --- /dev/null +++ b/desktop/src/cef/internal/resource_request_handler.rs @@ -0,0 +1,60 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_r...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_counted_t}; +use cef::{AuthCallback, Browser, CefString, Frame, ImplRequest, ImplRequestHandler, Request, ResourceRequestHandler, WrapRequestHandler}; +use std::ffi::c_int; + +use super::resource_request_handler::ResourceR...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs new file mode 100644 index 0000000000..c77147ff15 --- /dev/null +++ b/desktop/src/cef/internal/request_handler.rs @@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_count...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_counted_t}; +use cef::{AuthCallback, Browser, CefString, Frame, ImplRequest, ImplRequestHandler, Request, ResourceRequestHandler, WrapRequestHandler}; +use std::ffi::c_int; + +use super::resource_request_handler::ResourceR...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs new file mode 100644 index 0000000000..c77147ff15 --- /dev/null +++ b/desktop/src/cef/internal/request_handler.rs @@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_count...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,59 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_request_handler_t, cef_base_ref_counted_t}; +use cef::{Browser, Callback, CefString, Frame, ImplRequest, ImplResourceRequestHandler, Request, ReturnValue, WrapResourceRequestHandler}; + +use crate::cef::consts::{RESOURCE_DOMAIN, RESOURCE_SCHEME}...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs new file mode 100644 index 0000000000..94d8ec47e3 --- /dev/null +++ b/desktop/src/cef/internal/resource_request_handler.rs @@ -0,0 +1,60 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_r...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_counted_t}; +use cef::{AuthCallback, Browser, CefString, Frame, ImplRequest, ImplRequestHandler, Request, ResourceRequestHandler, WrapRequestHandler}; +use std::ffi::c_int; + +use super::resource_request_handler::ResourceR...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs new file mode 100644 index 0000000000..c77147ff15 --- /dev/null +++ b/desktop/src/cef/internal/request_handler.rs @@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_count...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_counted_t}; +use cef::{AuthCallback, Browser, CefString, Frame, ImplRequest, ImplRequestHandler, Request, ResourceRequestHandler, WrapRequestHandler}; +use std::ffi::c_int; + +use super::resource_request_handler::ResourceR...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs new file mode 100644 index 0000000000..c77147ff15 --- /dev/null +++ b/desktop/src/cef/internal/request_handler.rs @@ -0,0 +1,84 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_request_handler_t, cef_base_ref_count...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -0,0 +1,59 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_request_handler_t, cef_base_ref_counted_t}; +use cef::{Browser, Callback, CefString, Frame, ImplRequest, ImplResourceRequestHandler, Request, ReturnValue, WrapResourceRequestHandler}; + +use crate::cef::consts::{RESOURCE_DOMAIN, RESOURCE_SCHEME}...
bad
review
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs new file mode 100644 index 0000000000..94d8ec47e3 --- /dev/null +++ b/desktop/src/cef/internal/resource_request_handler.rs @@ -0,0 +1,60 @@ +use cef::rc::{Rc, RcImpl}; +use cef::sys::{_cef_resource_r...
good
review_fixed
rust
GraphiteEditor/Graphite
48f12882f0b1ec583f4619730c1e134a8f977834
@@ -283,9 +283,11 @@ pub fn gradient_chain_target_input(layer: LayerNodeIdentifier, network_interface /// Try to find a "Gradient Value" node that is connected to a "Fill" node, or to a layer directly. pub fn get_upstream_gradient_value_node_id(layer: LayerNodeIdentifier, network_interface: &NodeNetworkInterface) -...
bad
review
rust
GraphiteEditor/Graphite
33dcec00934669a1baed719186f9e797da008409
diff --git a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs b/editor/src/messages/tool/common_functionality/graph_modification_utils.rs index 709f3fa1da..266564c713 100644 --- a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs +++ b/editor/src/messages/tool/common_fun...
good
review_fixed
rust
GraphiteEditor/Graphite
33dcec00934669a1baed719186f9e797da008409
@@ -192,14 +192,21 @@ impl<'a> MessageHandler<ToolMessage, &mut ToolActionMessageContext<'a>> for Grad } } - advertise_actions!(GradientToolMessageDiscriminant; - PointerDown, - PointerUp, - PointerMove, - DoubleClick, - Abort, - DeleteStop, - ); + fn actions(&self) -> ActionList { + let mut common = acti...
bad
review
rust
GraphiteEditor/Graphite
c7745298043ab413381fe79089b131017d43f624
diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs index 32ce0c9e0b..fdb4aec4ae 100644 --- a/editor/src/messages/tool/tool_messages/gradient_tool.rs +++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs @@ -192,14 +192,22 @@ impl<'a> Me...
good
review_fixed
rust
GraphiteEditor/Graphite
c7745298043ab413381fe79089b131017d43f624
@@ -192,14 +192,21 @@ impl<'a> MessageHandler<ToolMessage, &mut ToolActionMessageContext<'a>> for Grad } } - advertise_actions!(GradientToolMessageDiscriminant; - PointerDown, - PointerUp, - PointerMove, - DoubleClick, - Abort, - DeleteStop, - ); + fn actions(&self) -> ActionList { + let mut common = acti...
bad
review
rust
GraphiteEditor/Graphite
c7745298043ab413381fe79089b131017d43f624
diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs index 32ce0c9e0b..fdb4aec4ae 100644 --- a/editor/src/messages/tool/tool_messages/gradient_tool.rs +++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs @@ -192,14 +192,22 @@ impl<'a> Me...
good
review_fixed
rust
GraphiteEditor/Graphite
c7745298043ab413381fe79089b131017d43f624
@@ -77,6 +77,34 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method"; /// Gradient's `GradientType` (`Linear` or `Radial`). pub const ATTR_GRADIENT_TYPE: &str = "gradient_type"; +// =========================== +// Implicit attribute defaults +// =========================== + +/// Overrides the type's default val...
bad
review
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs index 61f54597b4..76d1b75ede 100644 --- a/node-graph/libraries/core-types/src/list.rs +++ b/node-graph/libraries/core-types/src/list.rs @@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method"; /// Gra...
good
review_fixed
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
@@ -129,11 +157,12 @@ impl<T: Clone + Send + Sync + Default + Sized + Debug + PartialEq + CacheHash + format!("{:?}", self) } - /// Wraps this scalar value into a new attribute, padded with `preceding_defaults` default values before it. - fn into_attribute(self: Box<Self>, preceding_defaults: usize) -> Box<dyn A...
bad
review
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs index 61f54597b4..76d1b75ede 100644 --- a/node-graph/libraries/core-types/src/list.rs +++ b/node-graph/libraries/core-types/src/list.rs @@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method"; /// Gra...
good
review_fixed
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
@@ -723,22 +749,31 @@ impl Attributes { } } + /// Creates a new attribute of type `T` filled with `key`'s implicit default for all existing items. + fn new_attribute_padded<T: Clone + Send + Sync + Default + Debug + PartialEq + CacheHash + 'static>(&self, key: &str) -> Box<dyn AnyAttribute> { + let mut attribut...
bad
review
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs index 61f54597b4..76d1b75ede 100644 --- a/node-graph/libraries/core-types/src/list.rs +++ b/node-graph/libraries/core-types/src/list.rs @@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method"; /// Gra...
good
review_fixed
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
@@ -129,11 +157,12 @@ impl<T: Clone + Send + Sync + Default + Sized + Debug + PartialEq + CacheHash + format!("{:?}", self) } - /// Wraps this scalar value into a new attribute, padded with `preceding_defaults` default values before it. - fn into_attribute(self: Box<Self>, preceding_defaults: usize) -> Box<dyn A...
bad
review
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs index 61f54597b4..76d1b75ede 100644 --- a/node-graph/libraries/core-types/src/list.rs +++ b/node-graph/libraries/core-types/src/list.rs @@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method"; /// Gra...
good
review_fixed
rust
GraphiteEditor/Graphite
06903590bd4cbafda3847882cf09cf29cfa701ec
@@ -70,66 +96,200 @@ function initializeRipples() { goingUp: true, // Set to non-zero, but very old times (1ms after epoch), so the math works out as if the animation has already completed animationStartTime: 1, - animationEndTime: 1 + RIPPLE_ANIMATION_MILLISECONDS, + animationEndTime: 1 + BUMP_RAISE_MI...
bad
review
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js index c96bf00cc2..54f112a7d7 100644 --- a/website/static/js/navbar.js +++ b/website/static/js/navbar.js @@ -1,24 +1,61 @@ -const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss -const RIPPLE_ANIM...
good
review_fixed
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
@@ -70,66 +96,200 @@ function initializeRipples() { goingUp: true, // Set to non-zero, but very old times (1ms after epoch), so the math works out as if the animation has already completed animationStartTime: 1, - animationEndTime: 1 + RIPPLE_ANIMATION_MILLISECONDS, + animationEndTime: 1 + BUMP_RAISE_MI...
bad
review
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js index c96bf00cc2..54f112a7d7 100644 --- a/website/static/js/navbar.js +++ b/website/static/js/navbar.js @@ -1,24 +1,61 @@ -const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss -const RIPPLE_ANIM...
good
review_fixed
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
@@ -227,23 +227,34 @@ body > .page { .ripple {
bad
review
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
diff --git a/website/sass/base.scss b/website/sass/base.scss index 3ad0985807..9a5749459d 100644 --- a/website/sass/base.scss +++ b/website/sass/base.scss @@ -227,23 +227,34 @@ body > .page { .ripple { display: block; background: none; - // Covers up content that extends up underneath the header - fill: ...
good
review_fixed
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
@@ -43,21 +80,23 @@ function initializeRipples() { return location.startsWith(link); }); - ripples.forEach((ripple) => { + ripples.forEach((ripple, index) => { const updateTimings = (/** @type {boolean} **/ goingUp) => { const start = ripple.animationStartTime; const now = Date.now(); - const stop =...
bad
review
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js index c96bf00cc2..54f112a7d7 100644 --- a/website/static/js/navbar.js +++ b/website/static/js/navbar.js @@ -1,24 +1,61 @@ -const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss -const RIPPLE_ANIM...
good
review_fixed
javascript
GraphiteEditor/Graphite
fdb86e8073eb27c168b061fb7fd071b96e5ea16a
@@ -449,34 +449,71 @@ impl MessageHandler<DocumentMessage, DocumentMessageContext<'_>> for DocumentMes DocumentMessageHandler::get_calculated_insert_index(self.metadata(), &SelectedNodes(vec![layer.to_node()]), parent) }); - for layer in layers.into_iter().rev() { - let Some(parent) = layer.parent(s...
bad
review
rust
GraphiteEditor/Graphite
1743254c3a93f936982063bc31e05c9d66d8fe4c
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index fed421a143..7ffceb9f5a 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
good
review_fixed
rust
GraphiteEditor/Graphite
1743254c3a93f936982063bc31e05c9d66d8fe4c
@@ -2218,6 +2255,27 @@ impl DocumentMessageHandler { .unwrap_or(0) } + /// Copies `layer` together with its full upstream node chain, queueing the new nodes with freshly minted IDs. + /// Returns the new layer's identifier; the caller places it into the stack with a `MoveLayerToStack` response. + fn duplicate_l...
bad
review
rust
GraphiteEditor/Graphite
1743254c3a93f936982063bc31e05c9d66d8fe4c
diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index fed421a143..7ffceb9f5a 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_...
good
review_fixed
rust
GraphiteEditor/Graphite
1743254c3a93f936982063bc31e05c9d66d8fe4c
@@ -454,9 +458,55 @@ impl PenToolData { self.handle_end = None; self.latest_points.clear(); self.point_index = 0; + self.suppress_lock_angle = false; + self.suppress_snap_angle = false; self.snap_manager.cleanup(responses); } + /// Reads the modifier key states, applying the post-undo/redo angle-lock ...
bad
review
rust
GraphiteEditor/Graphite
e9d13c83f719923a509dc957dd1416a0bd0c83e9
diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs index 4a2a65a623..3e953818bb 100644 --- a/editor/src/messages/tool/tool_messages/pen_tool.rs +++ b/editor/src/messages/tool/tool_messages/pen_tool.rs @@ -418,6 +418,10 @@ struct PenToolData { /// avoid...
good
review_fixed
rust
GraphiteEditor/Graphite
e9d13c83f719923a509dc957dd1416a0bd0c83e9
@@ -2185,9 +2185,26 @@ impl Fsm for PenToolFsmState { (PenToolFsmState::DraggingHandle(..) | PenToolFsmState::PlacingAnchor, PenToolMessage::Undo) => { if tool_data.point_index > 0 { tool_data.point_index -= 1; - tool_data - .place_anchor(SnapData::new(document, input, viewport), transform, inpu...
bad
review
rust
GraphiteEditor/Graphite
fcc3fed743ba43002cb069f8b35bccc9e1589886
diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs index 529404b120..4a2a65a623 100644 --- a/editor/src/messages/tool/tool_messages/pen_tool.rs +++ b/editor/src/messages/tool/tool_messages/pen_tool.rs @@ -1133,16 +1133,22 @@ impl PenToolData { let sel...
good
review_fixed
rust
GraphiteEditor/Graphite
fcc3fed743ba43002cb069f8b35bccc9e1589886
@@ -2185,9 +2185,26 @@ impl Fsm for PenToolFsmState { (PenToolFsmState::DraggingHandle(..) | PenToolFsmState::PlacingAnchor, PenToolMessage::Undo) => { if tool_data.point_index > 0 {
bad
review
rust
GraphiteEditor/Graphite
fcc3fed743ba43002cb069f8b35bccc9e1589886
diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs index 529404b120..4a2a65a623 100644 --- a/editor/src/messages/tool/tool_messages/pen_tool.rs +++ b/editor/src/messages/tool/tool_messages/pen_tool.rs @@ -1133,16 +1133,22 @@ impl PenToolData { let sel...
good
review_fixed
rust
GraphiteEditor/Graphite
fcc3fed743ba43002cb069f8b35bccc9e1589886
@@ -2483,35 +2483,38 @@ pub(crate) fn fill_properties(node_id: NodeId, context: &mut NodePropertiesConte widgets_first_row.push( ColorInput::default() .value(FillChoiceUI::from(&FillChoice::from(fill.clone()))) - .on_update(move |x: &ColorInput| Message::Batched { - messages: Box::new([ - match &fill2...
bad
review
rust
GraphiteEditor/Graphite
4ce016036df8cc25c30f83e396f1827799ff21f1
diff --git a/editor/src/messages/portfolio/document/node_graph/node_properties.rs b/editor/src/messages/portfolio/document/node_graph/node_properties.rs index 01cc4fc8bb..031fdafc6e 100644 --- a/editor/src/messages/portfolio/document/node_graph/node_properties.rs +++ b/editor/src/messages/portfolio/document/node_graph/...
good
review_fixed
rust
GraphiteEditor/Graphite
4ce016036df8cc25c30f83e396f1827799ff21f1
@@ -97,7 +97,7 @@ await tick(); const flattened = filteredEntries.flat(); - const highlightedFound = highlighted?.label && flattened.map((entry) => entry.label).includes(highlighted.label); + const highlightedFound = highlighted?.value && flattened.map((entry) => entry.value).includes(highlighted.value);
bad
review
GraphiteEditor/Graphite
e81031bec56c158f4a804d9300edb609bc7b0f11
diff --git a/frontend/src/components/floating-menus/MenuList.svelte b/frontend/src/components/floating-menus/MenuList.svelte index 1a8e0279a6..09dcb5664c 100644 --- a/frontend/src/components/floating-menus/MenuList.svelte +++ b/frontend/src/components/floating-menus/MenuList.svelte @@ -97,7 +97,7 @@ await tick(); ...
good
review_fixed
GraphiteEditor/Graphite
e81031bec56c158f4a804d9300edb609bc7b0f11
@@ -0,0 +1,25 @@ +from setuptools import find_namespace_packages, setup + + +setup( + name="cli-anything-openrefine", + version="1.0.0", + description="CLI-Anything harness for OpenRefine data wrangling workflows", + long_description="Agent-native Click CLI for OpenRefine's local HTTP API, operation histori...
bad
review
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
diff --git a/openrefine/agent-harness/setup.py b/openrefine/agent-harness/setup.py new file mode 100644 index 000000000..3e779ef0c --- /dev/null +++ b/openrefine/agent-harness/setup.py @@ -0,0 +1,29 @@ +from setuptools import find_namespace_packages, setup + + +setup( + name="cli-anything-openrefine", + version="...
good
review_fixed
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
@@ -0,0 +1,192 @@ +from __future__ import annotations + +import json +import shutil +import subprocess +import time +from pathlib import Path +from typing import Any +from urllib.parse import parse_qs, urlparse + +import requests + + +INSTALL_INSTRUCTIONS = """OpenRefine backend is not reachable. + +Install OpenRefine ...
bad
review
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
diff --git a/openrefine/agent-harness/cli_anything/openrefine/utils/openrefine_backend.py b/openrefine/agent-harness/cli_anything/openrefine/utils/openrefine_backend.py new file mode 100644 index 000000000..1e66258da --- /dev/null +++ b/openrefine/agent-harness/cli_anything/openrefine/utils/openrefine_backend.py @@ -0,...
good
review_fixed
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
@@ -0,0 +1,299 @@ +from __future__ import annotations + +import json +import os +import shlex +import sys +from pathlib import Path +from typing import Any + +import click + +from . import __version__ +from .core.operations import column_addition, column_removal, mass_edit, save_operations, text_transform +from .core.p...
bad
review
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
diff --git a/openrefine/agent-harness/cli_anything/openrefine/openrefine_cli.py b/openrefine/agent-harness/cli_anything/openrefine/openrefine_cli.py new file mode 100644 index 000000000..4b0ac449a --- /dev/null +++ b/openrefine/agent-harness/cli_anything/openrefine/openrefine_cli.py @@ -0,0 +1,351 @@ +from __future__ i...
good
review_fixed
python
HKUDS/CLI-Anything
a1b4313f8b01d0d39b326e3e81f38ad16670a67b
@@ -0,0 +1,716 @@ +"""CC Switch CLI — command-line interface for CC Switch configuration manager. + +Usage: + ccswitch providers list [--app claude] [--json] + ccswitch providers set-current <provider-id> --app claude + ccswitch proxy status [--app claude] [--json] + ccswitch proxy config get [--app claude]...
bad
review
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
diff --git a/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py new file mode 100644 index 000000000..2b9a0e3d5 --- /dev/null +++ b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py @@ -0,0 +1,988 @@ +"""CC Switch CLI — command-line ...
good
review_fixed
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
@@ -0,0 +1,716 @@ +"""CC Switch CLI — command-line interface for CC Switch configuration manager. + +Usage: + ccswitch providers list [--app claude] [--json] + ccswitch providers set-current <provider-id> --app claude + ccswitch proxy status [--app claude] [--json] + ccswitch proxy config get [--app claude]...
bad
review
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
diff --git a/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py new file mode 100644 index 000000000..2b9a0e3d5 --- /dev/null +++ b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py @@ -0,0 +1,988 @@ +"""CC Switch CLI — command-line ...
good
review_fixed
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
@@ -0,0 +1,716 @@ +"""CC Switch CLI — command-line interface for CC Switch configuration manager. + +Usage: + ccswitch providers list [--app claude] [--json] + ccswitch providers set-current <provider-id> --app claude + ccswitch proxy status [--app claude] [--json] + ccswitch proxy config get [--app claude]...
bad
review
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
diff --git a/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py new file mode 100644 index 000000000..2b9a0e3d5 --- /dev/null +++ b/cc-switch/agent-harness/cli_anything/ccswitch/ccswitch_cli.py @@ -0,0 +1,988 @@ +"""CC Switch CLI — command-line ...
good
review_fixed
python
HKUDS/CLI-Anything
9f5f873d0f5d43a1f515ea60e8952ccb4d54f3d7
@@ -0,0 +1,146 @@ +--- +name: cli-anything +description: Use when the user wants Reasonix to build, refine, test, or validate a CLI-Anything harness for a GUI application or source repository. Adapts the CLI-Anything methodology to Reasonix without changing the generated Python harness format. +---
bad
review
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
diff --git a/reasonix-skill/SKILL.md b/reasonix-skill/SKILL.md new file mode 100644 index 000000000..f24056e91 --- /dev/null +++ b/reasonix-skill/SKILL.md @@ -0,0 +1,164 @@ +--- +name: cli-anything +description: Use when the user wants Reasonix to build, refine, test, or validate a CLI-Anything harness for a GUI applic...
good
review_fixed
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
@@ -0,0 +1,155 @@ +--- +name: cli-anything +description: Use when the user wants Reasonix to build, refine, test, or validate a CLI-Anything harness for a GUI application or source repository. Adapts the CLI-Anything methodology to Reasonix without changing the generated Python harness format. +runAs: subagent +--- + +...
bad
review
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
diff --git a/reasonix-skill/SKILL.md b/reasonix-skill/SKILL.md new file mode 100644 index 000000000..f24056e91 --- /dev/null +++ b/reasonix-skill/SKILL.md @@ -0,0 +1,164 @@ +--- +name: cli-anything +description: Use when the user wants Reasonix to build, refine, test, or validate a CLI-Anything harness for a GUI applic...
good
review_fixed
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
@@ -0,0 +1,107 @@ +# CLI-Anything for Reasonix + +An adapter that brings the [CLI-Anything](https://github.com/HKUDS/CLI-Anything) harness methodology to the [Reasonix](https://github.com/esengine/DeepSeek-Reasonix) coding agent. + +CLI-Anything is a methodology for making **any GUI software agent-native** by generatin...
bad
review
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
diff --git a/reasonix-skill/README.md b/reasonix-skill/README.md new file mode 100644 index 000000000..6233720ff --- /dev/null +++ b/reasonix-skill/README.md @@ -0,0 +1,116 @@ +# CLI-Anything for Reasonix + +An adapter that brings the [CLI-Anything](https://github.com/HKUDS/CLI-Anything) harness methodology to the [Rea...
good
review_fixed
HKUDS/CLI-Anything
d1eedc958e829593f6578739c6d0d4855913a523
@@ -61,12 +61,29 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, cliTokensPath, specDir) { const defaultTokensPath = path.resolve(__dirname, '..', 'tokens', 'default.json'); + const tokensDir = path.resolve(__dirname, '..', 'tokens'); let tokensPath = defaultTokensP...
bad
review
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
diff --git a/sketch/agent-harness/src/builder.js b/sketch/agent-harness/src/builder.js index 9f4dc8d814..af8081163f 100644 --- a/sketch/agent-harness/src/builder.js +++ b/sketch/agent-harness/src/builder.js @@ -61,12 +61,53 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, c...
good
review_fixed
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
@@ -61,12 +61,30 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, cliTokensPath, specDir) { const defaultTokensPath = path.resolve(__dirname, '..', 'tokens', 'default.json'); + const tokensDir = path.resolve(__dirname, '..', 'tokens'); let tokensPath = defaultTokensP...
bad
review
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
diff --git a/sketch/agent-harness/src/builder.js b/sketch/agent-harness/src/builder.js index 9f4dc8d814..af8081163f 100644 --- a/sketch/agent-harness/src/builder.js +++ b/sketch/agent-harness/src/builder.js @@ -61,12 +61,53 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, c...
good
review_fixed
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
@@ -61,12 +61,47 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, cliTokensPath, specDir) { const defaultTokensPath = path.resolve(__dirname, '..', 'tokens', 'default.json'); + const tokensDir = path.resolve(__dirname, '..', 'tokens'); let tokensPath = defaultTokensP...
bad
review
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
diff --git a/sketch/agent-harness/src/builder.js b/sketch/agent-harness/src/builder.js index 9f4dc8d814..af8081163f 100644 --- a/sketch/agent-harness/src/builder.js +++ b/sketch/agent-harness/src/builder.js @@ -61,12 +61,53 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, c...
good
review_fixed
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
@@ -61,12 +61,48 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, cliTokensPath, specDir) { const defaultTokensPath = path.resolve(__dirname, '..', 'tokens', 'default.json'); + const tokensDir = path.resolve(__dirname, '..', 'tokens'); let tokensPath = defaultTokensP...
bad
review
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
diff --git a/sketch/agent-harness/src/builder.js b/sketch/agent-harness/src/builder.js index 9f4dc8d814..af8081163f 100644 --- a/sketch/agent-harness/src/builder.js +++ b/sketch/agent-harness/src/builder.js @@ -61,12 +61,53 @@ async function buildSketchFile(sketch, outputPath) { function loadTokens(specTokensPath, c...
good
review_fixed
javascript
HKUDS/CLI-Anything
1b3d90d32765286121254d3379998fe09c70d015
@@ -362,6 +362,27 @@ "url": "https://github.com/MartaKar" } ] + }, + { + "name": "arcgis-pro", + "display_name": "ArcGIS Pro", + "version": "0.1.0", + "description": "Agent-native CLI for ArcGIS Pro (ArcPy): professional cartography (layouts + map series), geoprocess...
bad
review
HKUDS/CLI-Anything
4158feee6891dc75f5e664c0e5db4d75c2d19505
diff --git a/public_registry.json b/public_registry.json index e76d4ed1a..90c458577 100644 --- a/public_registry.json +++ b/public_registry.json @@ -381,6 +381,27 @@ "name": "ProxyLandLLC" } ] + }, + { + "name": "arcgis-pro", + "display_name": "ArcGIS Pro", + "version": "...
good
review_fixed
HKUDS/CLI-Anything
4158feee6891dc75f5e664c0e5db4d75c2d19505
@@ -381,6 +381,27 @@ "name": "ProxyLandLLC" } ] + }, + { + "name": "arcgis-pro", + "display_name": "ArcGIS Pro", + "version": "0.1.0", + "description": "Agent-native CLI for ArcGIS Pro (ArcPy): professional cartography (layouts + map series), geoprocessing, and featu...
bad
review
HKUDS/CLI-Anything
4158feee6891dc75f5e664c0e5db4d75c2d19505
diff --git a/public_registry.json b/public_registry.json index e76d4ed1a..90c458577 100644 --- a/public_registry.json +++ b/public_registry.json @@ -381,6 +381,27 @@ "name": "ProxyLandLLC" } ] + }, + { + "name": "arcgis-pro", + "display_name": "ArcGIS Pro", + "version": "...
good
review_fixed
HKUDS/CLI-Anything
4158feee6891dc75f5e664c0e5db4d75c2d19505
@@ -0,0 +1,201 @@ +# CLI-Anything for Hermes Agent
bad
review
HKUDS/CLI-Anything
a639c3c11038d694955771a586cd98dcf84ae4d1
diff --git a/hermes-skill/SKILL.md b/hermes-skill/SKILL.md new file mode 100644 index 000000000..042455155 --- /dev/null +++ b/hermes-skill/SKILL.md @@ -0,0 +1,213 @@ +--- +name: cli-anything-hermes +description: Hermes Agent skill for CLI-Anything — enables AI agents to build CLI harnesses for any GUI application. Bas...
good
review_fixed
HKUDS/CLI-Anything
a639c3c11038d694955771a586cd98dcf84ae4d1
@@ -0,0 +1,213 @@ +--- +name: cli-anything-hermes +description: Hermes Agent skill for CLI-Anything — enables AI agents to build CLI harnesses for any GUI application. Based on HKUDS/CLI-Anything's HARNESS.md methodology. +version: 1.0.0 +author: ligl0325 (based on HKUDS/CLI-Anything) +license: Apache 2.0 +metadata: + ...
bad
review
HKUDS/CLI-Anything
a639c3c11038d694955771a586cd98dcf84ae4d1
diff --git a/hermes-skill/SKILL.md b/hermes-skill/SKILL.md new file mode 100644 index 000000000..042455155 --- /dev/null +++ b/hermes-skill/SKILL.md @@ -0,0 +1,213 @@ +--- +name: cli-anything-hermes +description: Hermes Agent skill for CLI-Anything — enables AI agents to build CLI harnesses for any GUI application. Bas...
good
review_fixed
HKUDS/CLI-Anything
a639c3c11038d694955771a586cd98dcf84ae4d1
@@ -0,0 +1,73 @@ +import json +import shutil +import subprocess +from dataclasses import dataclass +from typing import Optional + + +@dataclass +class BackendConfig: + binary: str = "joplin" + profile: Optional[str] = None + + +def find_joplin(binary: str = "joplin") -> str: + path = shutil.which(binary) + ...
bad
review
python
HKUDS/CLI-Anything
190bd89dc4a9d402ace862f4d20d23a798eb93cb
diff --git a/joplin/agent-harness/cli_anything/joplin/utils/joplin_backend.py b/joplin/agent-harness/cli_anything/joplin/utils/joplin_backend.py new file mode 100644 index 000000000..1f21e5765 --- /dev/null +++ b/joplin/agent-harness/cli_anything/joplin/utils/joplin_backend.py @@ -0,0 +1,192 @@ +import json +import shu...
good
review_fixed
python
HKUDS/CLI-Anything
190bd89dc4a9d402ace862f4d20d23a798eb93cb
@@ -0,0 +1,970 @@ +#!/usr/bin/env python3 + +import json +import os +import shlex +import sys +from typing import Optional + +import click + +from cli_anything.joplin.core import attach as attach_mod +from cli_anything.joplin.core import backend as backend_mod +from cli_anything.joplin.core import config as config_mod ...
bad
review
python
HKUDS/CLI-Anything
190bd89dc4a9d402ace862f4d20d23a798eb93cb
diff --git a/joplin/agent-harness/cli_anything/joplin/joplin_cli.py b/joplin/agent-harness/cli_anything/joplin/joplin_cli.py new file mode 100644 index 000000000..48fad89dc --- /dev/null +++ b/joplin/agent-harness/cli_anything/joplin/joplin_cli.py @@ -0,0 +1,992 @@ +#!/usr/bin/env python3 + +import json +import os +imp...
good
review_fixed
python
HKUDS/CLI-Anything
190bd89dc4a9d402ace862f4d20d23a798eb93cb