text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl +# BOOL Impl +type Bool: + True + False -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T))...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl +# BOOL Impl +type Bool: + True + False -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T))...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl +# BOOL Impl +type Bool: + True + False -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T))...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl +# BOOL Impl +type Bool: + True + False -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T))...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -1,9 +1,7 @@ -type Maybe = (Some val) | None
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/tests/golden_tests/compile_file_o_all/match_adt_non_exhaustive.bend b/tests/golden_tests/compile_file_o_all/match_adt_non_exhaustive.bend index 8a97cad1d..97c526753 100644 --- a/tests/golden_tests/compile_file_o_all/match_adt_non_exhaustive.bend +++ b/tests/golden_tests/compile_file_o_all/match_adt_non_exh...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -2,28 +2,7 @@ source: tests/golden_tests.rs input_file: tests/golden_tests/encode_pattern_match/match_adt_unscoped_lambda.bend --- -Scott -unchecked main: Any -(main) = (Maybe/Some 1 λ$x * λa a $x) - -Maybe/None: Maybe -(Maybe/None) = λa λ* a - -Maybe/Some: (Any -> Maybe) -(Maybe/Some) = λa λ* λc (c a) - -NumScot...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/tests/snapshots/encode_pattern_match__match_adt_unscoped_lambda.bend.snap b/tests/snapshots/encode_pattern_match__match_adt_unscoped_lambda.bend.snap index d53c30f3c..9deb7b068 100644 --- a/tests/snapshots/encode_pattern_match__match_adt_unscoped_lambda.bend.snap +++ b/tests/snapshots/encode_pattern_match_...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -4,5 +4,5 @@ input_file: tests/golden_tests/run_file/unbound_wrap.bend --- Errors: In tests/golden_tests/run_file/unbound_wrap.bend : -In definition 'main': - Reference to undefined function 'Maybe/wrap' +In definition 'Maybe/bind': + ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/tests/snapshots/run_file__unbound_wrap.bend.snap b/tests/snapshots/run_file__unbound_wrap.bend.snap index 552967160..1fb44adf2 100644 --- a/tests/snapshots/run_file__unbound_wrap.bend.snap +++ b/tests/snapshots/run_file__unbound_wrap.bend.snap @@ -5,4 +5,4 @@ input_file: tests/golden_tests/run_file/unbound...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,110 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T)) (key: u24) : (T, (Map T)) = - match map ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,110 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T)) (key: u24) : (T, (Map T)) = - match map ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -170,62 +170,110 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: T) ~(left: (Map T)) ~(right: (Map T))) | (Leaf) - -Map/empty : (Map T) = Map/Leaf - -Map/get (map: (Map T)) (key: u24) : (T, (Map T)) = - match map ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 29d94f0e7..8b188bef2 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -170,62 +170,111 @@ def Tree/reverse(tree: Tree(T)) -> Tree(T): case Tree/Node: return ![tree.right, tree.left] -# MAP Impl - -type Map T = (Node (value: ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -471,6 +471,21 @@ fn io() { }) } +/// Runs a file that uses the prelude. +#[test] +fn prelude() { + run_golden_test_dir(function_name!(), &|code, path| { + let _guard = RUN_MUTEX.lock().unwrap(); + let book = parse_book_single_file(code, path)?; + let compile_opts = CompileOpts::default(); + let d...
bad
review
rust
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/tests/golden_tests.rs b/tests/golden_tests.rs index 52bd8eddf..316f32698 100644 --- a/tests/golden_tests.rs +++ b/tests/golden_tests.rs @@ -471,6 +471,21 @@ fn io() { }) } +/// Runs a file that uses the prelude. +#[test] +fn prelude() { + run_golden_test_dir(function_name!(), &|code, path| { + le...
good
review_fixed
rust
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -0,0 +1,3 @@ +def main(): + m1 = {0: 42, 1: 7, 2: 13, 3: 255, 4: 100} + return Map/contains(m1, 3)
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/tests/golden_tests/prelude/map_contains_test.bend b/tests/golden_tests/prelude/map_contains_test.bend new file mode 100644 index 000000000..ca8c6abfb --- /dev/null +++ b/tests/golden_tests/prelude/map_contains_test.bend @@ -0,0 +1,3 @@ +def main() -> _: + m1 = {0: 23} + return Map/contains(m1, 3)
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -173,7 +198,7 @@ type Map: **`Map`** represents a tree with values stored in the branches. It is meant to be used as an efficient map data structure with integer keys and O(log n) read and write operations. -- **Node { value ~left ~right }**: Represents a map node with a `value` and `left` and `right` subtrees. ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/docs/builtins.md b/docs/builtins.md index fc4733411..ee6f4c170 100644 --- a/docs/builtins.md +++ b/docs/builtins.md @@ -161,19 +161,44 @@ tree = ![![!1, !2],![!3, !4]] ``` Technically your trees don't need to end with leaves, but if you don't, your program will be very hard to reason about. +## Maybe ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -173,7 +198,7 @@ type Map: **`Map`** represents a tree with values stored in the branches. It is meant to be used as an efficient map data structure with integer keys and O(log n) read and write operations. -- **Node { value ~left ~right }**: Represents a map node with a `value` and `left` and `right` subtrees. ...
bad
review
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
diff --git a/docs/builtins.md b/docs/builtins.md index fc4733411..ee6f4c170 100644 --- a/docs/builtins.md +++ b/docs/builtins.md @@ -161,19 +161,44 @@ tree = ![![!1, !2],![!3, !4]] ``` Technically your trees don't need to end with leaves, but if you don't, your program will be very hard to reason about. +## Maybe ...
good
review_fixed
HigherOrderCO/Bend
88db4e4589c55ac1a530084b325067cc12b87c98
@@ -316,8 +316,13 @@ def IO/FS/read_line.read_chunks(fd, chunks): return wrap(bytes) case Result/Err:
bad
review
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index c6e830b8d..cca33de52 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -307,6 +307,7 @@ def IO/FS/read_line.read_chunks(fd, chunks): # Read line in 1kB chunks chunk <- IO/done_on_err(IO/FS/read(fd, 1024)) match res = List/sp...
good
review_fixed
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
@@ -307,17 +307,26 @@ def IO/FS/read_line.read_chunks(fd, chunks): # Read line in 1kB chunks chunk <- IO/done_on_err(IO/FS/read(fd, 1024)) match res = List/split_once(chunk, '\n'): + # Found a newline, backtract and join chunks case Result/Ok: (line, rest) = res.val (length,...
bad
review
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index c6e830b8d..cca33de52 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -307,6 +307,7 @@ def IO/FS/read_line.read_chunks(fd, chunks): # Read line in 1kB chunks chunk <- IO/done_on_err(IO/FS/read(fd, 1024)) match res = List/sp...
good
review_fixed
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
@@ -307,17 +307,26 @@ def IO/FS/read_line.read_chunks(fd, chunks): # Read line in 1kB chunks chunk <- IO/done_on_err(IO/FS/read(fd, 1024)) match res = List/split_once(chunk, '\n'): + # Found a newline, backtract and join chunks
bad
review
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index c6e830b8d..cca33de52 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -307,6 +307,7 @@ def IO/FS/read_line.read_chunks(fd, chunks): # Read line in 1kB chunks chunk <- IO/done_on_err(IO/FS/read(fd, 1024)) match res = List/sp...
good
review_fixed
HigherOrderCO/Bend
17e3cfe4e85f9011333954a922dfb1cc89135213
@@ -28,16 +31,21 @@ pub struct DiagnosticsConfig { #[derive(Debug, Clone)] pub struct Diagnostic { - message: String, - severity: Severity, + pub message: String, + pub severity: Severity, + pub span: Option<FileSpan>, } #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord)] pub enum DiagnosticOrigin { +...
bad
review
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/src/diagnostics.rs b/src/diagnostics.rs index 2b436e9c3..c8264ae37 100644 --- a/src/diagnostics.rs +++ b/src/diagnostics.rs @@ -1,7 +1,10 @@ -use crate::fun::{display::DisplayFn, Name}; +use TSPL::ParseError; + +use crate::fun::{display::DisplayFn, Name, Source}; use std::{ collections::BTreeMap, fm...
good
review_fixed
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -83,7 +99,7 @@ fn wrap(nxt: Option<fun::Pattern>, term: fun::Term, ask: bool) -> StmtToFun { } impl Stmt { - fn into_fun(self) -> Result<StmtToFun, String> { + fn into_fun(self) -> Result<StmtToFun, Diagnostics> {
bad
review
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/src/imp/to_fun.rs b/src/imp/to_fun.rs index 1c419c1ec..114427e79 100644 --- a/src/imp/to_fun.rs +++ b/src/imp/to_fun.rs @@ -1,13 +1,17 @@ use super::{AssignPattern, Definition, Expr, InPlaceOp, Stmt}; -use crate::fun::{ - self, - builtins::{LCONS, LNIL}, - parser::ParseBook, - Book, Name, +use crate::...
good
review_fixed
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -4,4 +4,8 @@ input_file: tests/golden_tests/parse_file/repeated_datatype_name.bend --- Errors: In tests/golden_tests/parse_file/repeated_datatype_name.bend : -Found a repeated field 'Expr' in constructor Expr/Plus. +- information: Found a repeated field 'Expr' in constructor Expr/Plus. +...
bad
review
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/tests/snapshots/parse_file__repeated_datatype_name.bend.snap b/tests/snapshots/parse_file__repeated_datatype_name.bend.snap index ea0a83853..8e23b5667 100644 --- a/tests/snapshots/parse_file__repeated_datatype_name.bend.snap +++ b/tests/snapshots/parse_file__repeated_datatype_name.bend.snap @@ -3,5 +3,8 @@...
good
review_fixed
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -24,10 +24,10 @@ default = ["cli"] cli = ["dep:clap"] [dependencies] -TSPL = "0.0.12" +TSPL = "0.0.13" clap = { version = "4.4.1", features = ["derive"], optional = true } highlight_error = "0.1.1" -hvm = "=2.0.19" +hvm = "2.0.22"
bad
review
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/Cargo.toml b/Cargo.toml index ddcbb601f..aa4bdce81 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -24,10 +24,10 @@ default = ["cli"] cli = ["dep:clap"] [dependencies] -TSPL = "0.0.12" +TSPL = "0.0.13" clap = { version = "4.4.1", features = ["derive"], optional = true } highlight_error = "0.1.1" -hvm = "...
good
review_fixed
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -78,7 +74,7 @@ pub enum Source { /// Was generated by the compiler. Generated, /// Source code location from the current book. - Local(Range<usize>), + Local(TextSpan),
bad
review
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/src/fun/mod.rs b/src/fun/mod.rs index 5d7c687e6..b88b5c246 100644 --- a/src/fun/mod.rs +++ b/src/fun/mod.rs @@ -1,16 +1,12 @@ use crate::{ - diagnostics::{Diagnostics, DiagnosticsConfig}, + diagnostics::{Diagnostics, DiagnosticsConfig, TextSpan}, imports::Import, maybe_grow, multi_iterator, ENTRY_...
good
review_fixed
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -1026,7 +1032,8 @@ impl Definition { } pub fn new_gen(name: Name, rules: Vec<Rule>, builtin: bool) -> Self {
bad
review
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/src/fun/mod.rs b/src/fun/mod.rs index 5d7c687e6..b88b5c246 100644 --- a/src/fun/mod.rs +++ b/src/fun/mod.rs @@ -1,16 +1,12 @@ use crate::{ - diagnostics::{Diagnostics, DiagnosticsConfig}, + diagnostics::{Diagnostics, DiagnosticsConfig, TextSpan}, imports::Import, maybe_grow, multi_iterator, ENTRY_...
good
review_fixed
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -1093,6 +1127,15 @@ impl<'a> Parser<'a> for TermParser<'a> { self.expected_spanned(exp, ini_idx..end_idx) } + /// Generates an error message with an additional custom message. + /// + /// Override to have our own error message.
bad
review
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
diff --git a/src/fun/parser.rs b/src/fun/parser.rs index 97c9e8267..fadea7430 100644 --- a/src/fun/parser.rs +++ b/src/fun/parser.rs @@ -1,6 +1,7 @@ use std::ops::Range; use crate::{ + diagnostics::{TextLocation, TextSpan}, fun::{ display::DisplayFn, Adt, Adts, Constructors, CtrField, FanKind, HvmDefinitio...
good
review_fixed
rust
HigherOrderCO/Bend
cd268fafee6066a6e5564d6ab571b8dc572270ed
@@ -482,6 +482,10 @@ impl<'a> TermParser<'a> { return Ok(Term::Fan { fan: FanKind::Tup, tag: tag.unwrap_or(Tag::Static), els }); } + if self.try_consume(")") {
bad
review
rust
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
diff --git a/src/fun/parser.rs b/src/fun/parser.rs index 3046070f3..97c9e8267 100644 --- a/src/fun/parser.rs +++ b/src/fun/parser.rs @@ -482,6 +482,10 @@ impl<'a> TermParser<'a> { return Ok(Term::Fan { fan: FanKind::Tup, tag: tag.unwrap_or(Tag::Static), els }); } + if opr == Op::MUL &...
good
review_fixed
rust
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
@@ -161,6 +161,7 @@ impl ParseBook { let adts = std::mem::take(&mut self.adts); let mut new_adts = IndexMap::new(); let mut ctrs_map = IndexMap::new(); + let mut new_ctrs = IndexMap::new();
bad
review
rust
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
diff --git a/src/imports/book.rs b/src/imports/book.rs index 10ad64c8e..3c2c7b7b8 100644 --- a/src/imports/book.rs +++ b/src/imports/book.rs @@ -161,6 +161,7 @@ impl ParseBook { let adts = std::mem::take(&mut self.adts); let mut new_adts = IndexMap::new(); let mut ctrs_map = IndexMap::new(); + let mut...
good
review_fixed
rust
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
@@ -0,0 +1,5 @@ +type Ctr:
bad
review
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
diff --git a/tests/golden_tests/import_system/lib/ctr_type.bend b/tests/golden_tests/import_system/lib/ctr_type.bend new file mode 100644 index 000000000..649bad49a --- /dev/null +++ b/tests/golden_tests/import_system/lib/ctr_type.bend @@ -0,0 +1,6 @@ +# Test issue #674 +type Ctr: + Foo { x, y } + +def Ctr/wrap(x): + ...
good
review_fixed
HigherOrderCO/Bend
1daf6c5f5889bad8ff3d07f56f4c072f93352780
@@ -279,7 +279,7 @@ if you are interested in some other algorithms, you can check our [examples fold ### Additional Resources - - To understand the technology behind Bend, check out the HVM2 [paper](https://docs.google.com/viewer?url=https://raw.githubusercontent.com/HigherOrderCO/HVM/main/paper/PAPER.pdf). + - To...
bad
review
HigherOrderCO/Bend
60efe8df3b73d11a66548a35737d3ca50e064bae
diff --git a/README.md b/README.md index 836ccfb71..64a2cdbba 100644 --- a/README.md +++ b/README.md @@ -279,7 +279,7 @@ if you are interested in some other algorithms, you can check our [examples fold ### Additional Resources - - To understand the technology behind Bend, check out the HVM2 [paper](https://docs.go...
good
review_fixed
HigherOrderCO/Bend
60efe8df3b73d11a66548a35737d3ca50e064bae
@@ -2,16 +2,22 @@ use super::tree_children; use crate::{diagnostics::Diagnostics, fun::Name}; use hvm::ast::{Book, Net, Tree}; -pub const MAX_NET_SIZE: usize = 64; +pub const MAX_NET_SIZE_C: usize = 4095; +pub const MAX_NET_SIZE_CUDA: usize = 64; + +pub fn check_net_sizes(book: &Book, diagnostics: &mut Diagnostics,...
bad
review
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/src/hvm/check_net_size.rs b/src/hvm/check_net_size.rs index ff733be60..f524ff121 100644 --- a/src/hvm/check_net_size.rs +++ b/src/hvm/check_net_size.rs @@ -1,17 +1,27 @@ use super::tree_children; -use crate::{diagnostics::Diagnostics, fun::Name}; +use crate::{diagnostics::Diagnostics, fun::Name, CompilerT...
good
review_fixed
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -1,17 +1,27 @@ use super::tree_children; -use crate::{diagnostics::Diagnostics, fun::Name}; +use crate::{diagnostics::Diagnostics, fun::Name, CompileOpts}; use hvm::ast::{Book, Net, Tree}; -pub const MAX_NET_SIZE: usize = 64; +pub const MAX_NET_SIZE_C: usize = 4095; +pub const MAX_NET_SIZE_CUDA: usize = 64; + +p...
bad
review
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/src/hvm/check_net_size.rs b/src/hvm/check_net_size.rs index ff733be60..f524ff121 100644 --- a/src/hvm/check_net_size.rs +++ b/src/hvm/check_net_size.rs @@ -1,17 +1,27 @@ use super::tree_children; -use crate::{diagnostics::Diagnostics, fun::Name}; +use crate::{diagnostics::Diagnostics, fun::Name, CompilerT...
good
review_fixed
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -331,6 +331,9 @@ impl OptLevel { #[derive(Clone, Debug)] pub struct CompileOpts { + /// The Bend command + pub command: String,
bad
review
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/src/lib.rs b/src/lib.rs index 2af6bf988..209d32bf2 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -2,7 +2,7 @@ use crate::{ fun::{book_to_hvm, net_to_term::net_to_term, term_to_net::Labels, Book, Ctx, Term}, hvm::{ add_recursive_priority::add_recursive_priority, - check_net_size::{check_net_size...
good
review_fixed
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -1,17 +1,27 @@ use super::tree_children; -use crate::{diagnostics::Diagnostics, fun::Name}; +use crate::{diagnostics::Diagnostics, fun::Name, CompileOpts}; use hvm::ast::{Book, Net, Tree}; -pub const MAX_NET_SIZE: usize = 64; +pub const MAX_NET_SIZE_C: usize = 4095; +pub const MAX_NET_SIZE_CUDA: usize = 64; + +p...
bad
review
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/src/hvm/check_net_size.rs b/src/hvm/check_net_size.rs index ff733be60..f524ff121 100644 --- a/src/hvm/check_net_size.rs +++ b/src/hvm/check_net_size.rs @@ -1,17 +1,27 @@ use super::tree_children; -use crate::{diagnostics::Diagnostics, fun::Name}; +use crate::{diagnostics::Diagnostics, fun::Name, CompilerT...
good
review_fixed
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -406,13 +418,14 @@ impl Default for CompileOpts { /// Uses num-scott ADT encoding. fn default() -> Self { Self { + target_architecture: CompilerTarget::Cuda,
bad
review
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/src/lib.rs b/src/lib.rs index 2af6bf988..209d32bf2 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -2,7 +2,7 @@ use crate::{ fun::{book_to_hvm, net_to_term::net_to_term, term_to_net::Labels, Book, Ctx, Term}, hvm::{ add_recursive_priority::add_recursive_priority, - check_net_size::{check_net_size...
good
review_fixed
rust
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -2,4 +2,6 @@ source: tests/golden_tests.rs input_file: tests/golden_tests/compile_long/huge_tree.bend --- -Compiled +Errors: +In definition 'main': + Definition is too large for hvm (size=120002, max size=4095). Please break it into smaller pieces.
bad
review
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
diff --git a/tests/snapshots/compile_long__huge_tree.bend.snap b/tests/snapshots/compile_long__huge_tree.bend.snap index d5a8a014d..ee6c230f5 100644 --- a/tests/snapshots/compile_long__huge_tree.bend.snap +++ b/tests/snapshots/compile_long__huge_tree.bend.snap @@ -2,4 +2,6 @@ source: tests/golden_tests.rs input_file:...
good
review_fixed
HigherOrderCO/Bend
305c9446192f30f615645d7e5e1a501ed1af1b19
@@ -118,6 +118,22 @@ Splits a list into two lists at the first occurrence of a value. List/split_once(xs: List(T), val: T) -> (Result(List(T), List(T))) ``` +## Result + +```python +type Result<A, B>: + Ok { val: A } + Err { val: B } +``` + +### Result/unwrap + +Returns the inner value of `Result/Ok` or `Result/E...
bad
review
HigherOrderCO/Bend
2a1f0774d753f5df309bb4a46a4ce83269b92742
diff --git a/docs/builtins.md b/docs/builtins.md index b5be28ce2..fc4733411 100644 --- a/docs/builtins.md +++ b/docs/builtins.md @@ -118,6 +118,24 @@ Splits a list into two lists at the first occurrence of a value. List/split_once(xs: List(T), val: T) -> (Result(List(T), List(T))) ``` +## Result + +```python +type ...
good
review_fixed
HigherOrderCO/Bend
2a1f0774d753f5df309bb4a46a4ce83269b92742
@@ -96,7 +106,22 @@ type Tree: Node { ~left, ~right } Leaf { value } - +# Returns a List converted from a Tree. +def Tree/to_list(tree): + fold tree: + case Tree/Leaf: + list = DiffList/wrap(tree.value) + case Tree/Node: + list = DiffList/concat(tree.left, tree.right) + return DiffList/to_list...
bad
review
HigherOrderCO/Bend
63ba5d22755e85f715651be18d2a8fd0f66035e2
diff --git a/src/fun/builtins.bend b/src/fun/builtins.bend index 89c04fd15..2a5f90cc1 100644 --- a/src/fun/builtins.bend +++ b/src/fun/builtins.bend @@ -76,10 +76,20 @@ String/split s delim = (String/split.go s delim (List/Cons String/Nil List/Nil)) # Create a new difference list DiffList/new = λx x +# DiffList/wra...
good
review_fixed
HigherOrderCO/Bend
63ba5d22755e85f715651be18d2a8fd0f66035e2
@@ -10,8 +10,10 @@ and this project does not currently adhere to a particular versioning scheme. ### Fixed - Fix variable binding in pattern matching when the irrefutable pattern optimization occurs. ([#618][gh-618]) -- Don't warn on unused generated definitions. ([#514][gh-514]) +- Don't warn on unused generated d...
bad
review
HigherOrderCO/Bend
b3ccb756069526a7369c3d582bf99e172aa1465d
diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b340dcca..4596a183e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ and this project does not currently adhere to a particular versioning scheme. - Fix variable binding in pattern matching when the irrefutable pattern optimization occurs. ([#618][gh-618]) ...
good
review_fixed
HigherOrderCO/Bend
b3ccb756069526a7369c3d582bf99e172aa1465d
@@ -1518,80 +1518,85 @@ pub trait ParserCommons<'a>: Parser<'a> { let radix = match self.peek_many(2) { Some("0x") => { self.advance_many(2); - 16 + Radix::Hex } Some("0b") => { self.advance_many(2); - 2 + Radix::Bin } - _ => 10, + ...
bad
review
rust
HigherOrderCO/Bend
696ad66487d2ae331c30b55b76768c736176b75e
diff --git a/src/fun/parser.rs b/src/fun/parser.rs index 904c94044..3046070f3 100644 --- a/src/fun/parser.rs +++ b/src/fun/parser.rs @@ -1518,80 +1518,85 @@ pub trait ParserCommons<'a>: Parser<'a> { let radix = match self.peek_many(2) { Some("0x") => { self.advance_many(2); - 16 + Rad...
good
review_fixed
rust
HigherOrderCO/Bend
696ad66487d2ae331c30b55b76768c736176b75e
@@ -1518,80 +1518,87 @@ pub trait ParserCommons<'a>: Parser<'a> { let radix = match self.peek_many(2) { Some("0x") => { self.advance_many(2); - 16 + Radix::Hex } Some("0b") => { self.advance_many(2); - 2 + Radix::Bin } - _ => 10, + ...
bad
review
rust
HigherOrderCO/Bend
696ad66487d2ae331c30b55b76768c736176b75e
diff --git a/src/fun/parser.rs b/src/fun/parser.rs index 904c94044..3046070f3 100644 --- a/src/fun/parser.rs +++ b/src/fun/parser.rs @@ -1518,80 +1518,85 @@ pub trait ParserCommons<'a>: Parser<'a> { let radix = match self.peek_many(2) { Some("0x") => { self.advance_many(2); - 16 + Rad...
good
review_fixed
rust
HigherOrderCO/Bend
696ad66487d2ae331c30b55b76768c736176b75e
@@ -496,10 +496,18 @@ impl<'a> PyParser<'a> { let val = self.parse_expr(true, true)?; self.skip_trivia_inline()?; self.try_consume_exactly(";"); - self.consume_indent_exactly(*indent)?; - let (nxt, nxt_indent) = self.parse_statement(indent)?; - let stmt = Stmt::Ask { pat, val: Box::n...
bad
review
rust
HigherOrderCO/Bend
e8d3782615d4e1aad92fb23b01d36143a8f47a97
diff --git a/src/imp/parser.rs b/src/imp/parser.rs index c757a5142..fe6b94bbc 100644 --- a/src/imp/parser.rs +++ b/src/imp/parser.rs @@ -496,10 +496,15 @@ impl<'a> PyParser<'a> { let val = self.parse_expr(true, true)?; self.skip_trivia_inline()?; self.try_consume_exactly(";"); - self.consume_i...
good
review_fixed
rust
HigherOrderCO/Bend
e8d3782615d4e1aad92fb23b01d36143a8f47a97
@@ -14,6 +14,7 @@ use diagnostics::{Diagnostics, DiagnosticsConfig, ERR_INDENT_SIZE}; use net::hvm_to_net::hvm_to_net; pub mod diagnostics; +#[allow(clippy::mutable_key_type)]
bad
review
rust
HigherOrderCO/Bend
477f143077971b9deb2d9b53da6146d19314c4eb
diff --git a/src/lib.rs b/src/lib.rs index e5dfe9a33..2af6bf988 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,6 +14,8 @@ use diagnostics::{Diagnostics, DiagnosticsConfig, ERR_INDENT_SIZE}; use net::hvm_to_net::hvm_to_net; pub mod diagnostics; +// `Name` triggers this warning, but it's safe because we're not using...
good
review_fixed
rust
HigherOrderCO/Bend
477f143077971b9deb2d9b53da6146d19314c4eb
@@ -728,7 +732,9 @@ impl<'a> PyParser<'a> { let mut expected_num = 1; while should_continue { if nxt_indent != *indent { - return self.expected_indent(*indent, nxt_indent); + return self + .expected_indent(*indent, nxt_indent) + .or(self.expected_spanned("case", self.ind...
bad
review
rust
HigherOrderCO/Bend
477f143077971b9deb2d9b53da6146d19314c4eb
diff --git a/src/imp/parser.rs b/src/imp/parser.rs index 82f9dc92a..c757a5142 100644 --- a/src/imp/parser.rs +++ b/src/imp/parser.rs @@ -575,7 +575,9 @@ impl<'a> PyParser<'a> { indent.exit_level(); if nxt_indent != *indent { - return self.expected_indent(*indent, nxt_indent); + return self + ...
good
review_fixed
rust
HigherOrderCO/Bend
477f143077971b9deb2d9b53da6146d19314c4eb
@@ -0,0 +1,213 @@ +# Dynamically linked libraries and foreign functions + +We can add new IO functions to Bend during runtime by loading dynamic libraries. + +## Using IO dynamic libraries in Bend + +Here is an example of how we could load a Bend library that contains functions for working with directories. + +```py +d...
bad
review
HigherOrderCO/Bend
3c042d4b0cc4cf20c28e68668b195dd2dd693975
diff --git a/docs/ffi.md b/docs/ffi.md new file mode 100644 index 000000000..0c770b6ad --- /dev/null +++ b/docs/ffi.md @@ -0,0 +1,213 @@ +# Dynamically linked libraries and foreign functions + +We can add new IO functions to Bend during runtime by loading dynamic libraries. + +## Using IO dynamic libraries in Bend + +H...
good
review_fixed
HigherOrderCO/Bend
3c042d4b0cc4cf20c28e68668b195dd2dd693975
@@ -0,0 +1,213 @@ +# Dynamically linked libraries and foreign functions + +We can add new IO functions to Bend during runtime by loading dynamic libraries. + +## Using IO dynamic libraries in Bend + +Here is an example of how we could load a Bend library that contains functions for working with directories. + +```py +d...
bad
review
HigherOrderCO/Bend
3c042d4b0cc4cf20c28e68668b195dd2dd693975
diff --git a/docs/ffi.md b/docs/ffi.md new file mode 100644 index 000000000..0c770b6ad --- /dev/null +++ b/docs/ffi.md @@ -0,0 +1,213 @@ +# Dynamically linked libraries and foreign functions + +We can add new IO functions to Bend during runtime by loading dynamic libraries. + +## Using IO dynamic libraries in Bend + +H...
good
review_fixed
HigherOrderCO/Bend
3c042d4b0cc4cf20c28e68668b195dd2dd693975
@@ -48,9 +48,11 @@ enum Mode { path: PathBuf, }, /// Compiles the program and runs it with the Rust HVM implementation. - Run(RunArgs), + RunRs(RunArgs), /// Compiles the program and runs it with the C HVM implementation. RunC(RunArgs), + /// Compiles the program and runs it with the C HVM implement...
bad
review
rust
HigherOrderCO/Bend
6380803dae279d388300b3bc0524d86a11c604ae
diff --git a/src/main.rs b/src/main.rs index b6fdcd315..82f3cc230 100644 --- a/src/main.rs +++ b/src/main.rs @@ -48,8 +48,9 @@ enum Mode { path: PathBuf, }, /// Compiles the program and runs it with the Rust HVM implementation. - Run(RunArgs), + RunRs(RunArgs), /// Compiles the program and runs it with ...
good
review_fixed
rust
HigherOrderCO/Bend
6380803dae279d388300b3bc0524d86a11c604ae
@@ -199,9 +199,11 @@ pub enum Term { nam: Name, }, Def { - nam: Name, - rules: Vec<Rule>, + def: Definition, nxt: Box<Term>, + // nam: Name,
bad
review
rust
HigherOrderCO/Bend
6020fbac8e0054a471c31cc956a34f77c03dc500
diff --git a/src/fun/mod.rs b/src/fun/mod.rs index 04a14d1b8..5d7c687e6 100644 --- a/src/fun/mod.rs +++ b/src/fun/mod.rs @@ -65,14 +65,14 @@ pub type Adts = IndexMap<Name, Adt>; pub type Constructors = IndexMap<Name, Name>; /// A pattern matching function definition. -#[derive(Debug, Clone)] +#[derive(Debug, Clone,...
good
review_fixed
rust
HigherOrderCO/Bend
6020fbac8e0054a471c31cc956a34f77c03dc500
@@ -0,0 +1,150 @@ +# Import System + +## Case Sensitivity +All import paths are case-sensitive. Ensure that the case used in import statements matches exactly with the file and directory names. + +## Syntax +Imports can be declared two ways: + +```py +from path import name +# or +import path/name +``` + +## Project Str...
bad
review
HigherOrderCO/Bend
cd2a58b36ae2d3b1c9e69a7913c762158a503c97
diff --git a/docs/imports.md b/docs/imports.md new file mode 100644 index 000000000..ada25cd6f --- /dev/null +++ b/docs/imports.md @@ -0,0 +1,181 @@ +# Import System + +## Case Sensitivity +All import paths are case-sensitive. Ensure that the case used in import statements matches exactly with the file and directory na...
good
review_fixed
HigherOrderCO/Bend
cd2a58b36ae2d3b1c9e69a7913c762158a503c97
@@ -0,0 +1,150 @@ +# Import System + +## Case Sensitivity +All import paths are case-sensitive. Ensure that the case used in import statements matches exactly with the file and directory names. + +## Syntax +Imports can be declared two ways: + +```py +from path import name +# or +import path/name +``` + +## Project Str...
bad
review
HigherOrderCO/Bend
cd2a58b36ae2d3b1c9e69a7913c762158a503c97
diff --git a/docs/imports.md b/docs/imports.md new file mode 100644 index 000000000..ada25cd6f --- /dev/null +++ b/docs/imports.md @@ -0,0 +1,181 @@ +# Import System + +## Case Sensitivity +All import paths are case-sensitive. Ensure that the case used in import statements matches exactly with the file and directory na...
good
review_fixed
HigherOrderCO/Bend
cd2a58b36ae2d3b1c9e69a7913c762158a503c97
@@ -207,122 +209,102 @@ impl ApiProvider { #[must_use] pub fn parse(value: &str) -> Option<Self> { - match value.trim().to_ascii_lowercase().as_str() { - "deepseek" | "deep-seek" => Some(Self::Deepseek), - "deepseek-cn" | "deepseek_china" | "deepseekcn" | "deepseek-china" => { -...
bad
review
rust
Hmbown/CodeWhale
f64cf6f0ff79bbfcfc53600e2922e3a077c90e73
diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs index 140c8f803..fdca413bc 100644 --- a/crates/tui/src/config.rs +++ b/crates/tui/src/config.rs @@ -212,126 +212,105 @@ impl ApiProvider { #[must_use] pub fn parse(value: &str) -> Option<Self> { - match value.trim().to_ascii_lowercase()...
good
review_fixed
rust
Hmbown/CodeWhale
f64cf6f0ff79bbfcfc53600e2922e3a077c90e73
@@ -180,61 +180,19 @@ impl ProviderKind { #[must_use] pub fn as_str(self) -> &'static str { - match self { - Self::Deepseek => "deepseek", - Self::NvidiaNim => "nvidia-nim", - Self::Openai => "openai", - Self::Atlascloud => "atlascloud", - Self::...
bad
review
rust
Hmbown/CodeWhale
f64cf6f0ff79bbfcfc53600e2922e3a077c90e73
diff --git a/crates/config/src/lib.rs b/crates/config/src/lib.rs index be1824bdd..5cf52cc5b 100644 --- a/crates/config/src/lib.rs +++ b/crates/config/src/lib.rs @@ -171,8 +171,8 @@ impl ProviderKind { Self::Novita, Self::Fireworks, Self::Siliconflow, - Self::SiliconflowCN, Sel...
good
review_fixed
rust
Hmbown/CodeWhale
f64cf6f0ff79bbfcfc53600e2922e3a077c90e73