text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -455,6 +455,113 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure that Java versions are consistent. + class JavaVersions < FormulaCop + extend AutoCorrector + + sig { override.params(formula_nodes: FormulaNodes).void } + def audit_formula(formula_no...
bad
review
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index eacd0fee9d3f0..ebaa42871c75c 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure t...
good
review_fixed
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
@@ -455,6 +455,113 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure that Java versions are consistent. + class JavaVersions < FormulaCop + extend AutoCorrector + + sig { override.params(formula_nodes: FormulaNodes).void } + def audit_formula(formula_no...
bad
review
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index eacd0fee9d3f0..ebaa42871c75c 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure t...
good
review_fixed
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
@@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure that Java versions are consistent. + class JavaVersions < FormulaCop + extend AutoCorrector + + sig { override.params(formula_nodes: FormulaNodes).void } + def audit_formula(formula_no...
bad
review
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index eacd0fee9d3f0..ebaa42871c75c 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure t...
good
review_fixed
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
@@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure that Java versions are consistent. + class JavaVersions < FormulaCop + extend AutoCorrector + + sig { override.params(formula_nodes: FormulaNodes).void } + def audit_formula(formula_no...
bad
review
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index eacd0fee9d3f0..ebaa42871c75c 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -455,6 +455,127 @@ def audit_formula(formula_nodes) EOS end + # This cop makes sure t...
good
review_fixed
ruby
Homebrew/brew
1e8a93f20cd939263cd0c892f181f688cdb36899
@@ -96,20 +85,20 @@ def run! private - sig { returns(T::Hash[String, T::Set[String]]) } - def build_dependency_map + sig { params(entries: T::Array[Installer::InstallableEntry]).returns(T::Hash[String, T::Set[String]]) } + def build_dependency_map(entries) installed_taps = Homebr...
bad
review
ruby
Homebrew/brew
ec8a25cb0d2c65528fba99eac46bf7b852ef3322
diff --git a/Library/Homebrew/bundle/parallel_installer.rb b/Library/Homebrew/bundle/parallel_installer.rb index 03ae23b89217f..84ef54ad65e8e 100644 --- a/Library/Homebrew/bundle/parallel_installer.rb +++ b/Library/Homebrew/bundle/parallel_installer.rb @@ -37,13 +37,19 @@ def initialize(entries, jobs:, no_upgrade:, ver...
good
review_fixed
ruby
Homebrew/brew
ec8a25cb0d2c65528fba99eac46bf7b852ef3322
@@ -71,6 +71,7 @@ def install!(name, preinstall: true, no_upgrade: false, verbose: false, force: f return false end + ::Tap.fetch(name).clear_cache installed_taps << name true
bad
review
ruby
Homebrew/brew
ec8a25cb0d2c65528fba99eac46bf7b852ef3322
diff --git a/Library/Homebrew/bundle/tap.rb b/Library/Homebrew/bundle/tap.rb index 5e80459815f94..1def0b0bcbece 100644 --- a/Library/Homebrew/bundle/tap.rb +++ b/Library/Homebrew/bundle/tap.rb @@ -71,6 +71,8 @@ def install!(name, preinstall: true, no_upgrade: false, verbose: false, force: f return false ...
good
review_fixed
ruby
Homebrew/brew
ec8a25cb0d2c65528fba99eac46bf7b852ef3322
@@ -83,8 +83,16 @@ def cask(name, options = {}) @entries << Entry.new(:cask, name, options) end - sig { params(name: String, clone_target: T.nilable(String), options: Homebrew::Bundle::EntryOptions).void } - def tap(name, clone_target = nil, options = {}) + sig { + params( + ...
bad
review
ruby
Homebrew/brew
720dfe1cd2494bbeab3e0aaa045f20bb76af7e54
diff --git a/Library/Homebrew/bundle/dsl.rb b/Library/Homebrew/bundle/dsl.rb index bf4c6072435cc..b00a462ddf211 100644 --- a/Library/Homebrew/bundle/dsl.rb +++ b/Library/Homebrew/bundle/dsl.rb @@ -83,8 +83,16 @@ def cask(name, options = {}) @entries << Entry.new(:cask, name, options) end - sig { ...
good
review_fixed
ruby
Homebrew/brew
720dfe1cd2494bbeab3e0aaa045f20bb76af7e54
@@ -86,16 +89,19 @@ def bubblewrap_dependency_needed? ::Sandbox.executable.blank? end - sig { params(name: String).returns(T::Array[String]) } - def global_deps_for(name) - @global_deps_for ||= T.let({}, T.nilable(T::Hash[String, T::Array[String]])) + sig { params(name: String, i...
bad
review
ruby
Homebrew/brew
a25274ac8b18ab75372e9eadb9910d0eb8fbf656
diff --git a/Library/Homebrew/extend/os/linux/dependency_collector.rb b/Library/Homebrew/extend/os/linux/dependency_collector.rb index ff72bb205a4de..90cef201fb518 100644 --- a/Library/Homebrew/extend/os/linux/dependency_collector.rb +++ b/Library/Homebrew/extend/os/linux/dependency_collector.rb @@ -59,7 +59,10 @@ def ...
good
review_fixed
ruby
Homebrew/brew
a25274ac8b18ab75372e9eadb9910d0eb8fbf656
@@ -807,14 +807,6 @@ def install_dependencies(deps) "#{deps.map { Formatter.identifier(it) }.to_sentence}", truncate: false end - bubblewrap_dependency_index = deps.index { |dep| dep.name == "bubblewrap" && dep.implicit? } - deps.each_with_index do |dep, index| - if for...
bad
review
ruby
Homebrew/brew
a25274ac8b18ab75372e9eadb9910d0eb8fbf656
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index e92d8f6fd05e8..8c7e6f0cb3171 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -435,7 +435,20 @@ def check_install_sanity if Homebrew::EnvConfig.developer? # `recu...
good
review_fixed
ruby
Homebrew/brew
a25274ac8b18ab75372e9eadb9910d0eb8fbf656
@@ -748,6 +748,14 @@ def auto_updates_bundle_outdated? installed_short_version = nil if AUTO_UPDATES_BAD_BUNDLE_VERSIONS.include?(installed_short_version) return false if installed_short_version.nil? && installed_bundle_version.nil? + # Some apps split a cask version like 2.61-2057 across the short...
bad
review
ruby
Homebrew/brew
e4cd53e9e6c06a8bc17dfbd70a8c2860f7abb626
diff --git a/Library/Homebrew/cask/cask.rb b/Library/Homebrew/cask/cask.rb index 3cd4a246c84ad..6d5a05b9aebbb 100644 --- a/Library/Homebrew/cask/cask.rb +++ b/Library/Homebrew/cask/cask.rb @@ -748,6 +748,16 @@ def auto_updates_bundle_outdated? installed_short_version = nil if AUTO_UPDATES_BAD_BUNDLE_VERSIONS.inc...
good
review_fixed
ruby
Homebrew/brew
e4cd53e9e6c06a8bc17dfbd70a8c2860f7abb626
@@ -333,6 +333,15 @@ def write_auto_updates_cask(path, version:, artifacts:, token: "auto-updates-bun expect(cask.outdated_version).to be_nil end + it "is not outdated when the installed short and bundle versions combine to the tap version" do + tap_version = "2.61-2057" + cask = wr...
bad
review
ruby
Homebrew/brew
e4cd53e9e6c06a8bc17dfbd70a8c2860f7abb626
diff --git a/Library/Homebrew/test/cask/cask_spec.rb b/Library/Homebrew/test/cask/cask_spec.rb index b4257f7b11d55..6becad87758a2 100644 --- a/Library/Homebrew/test/cask/cask_spec.rb +++ b/Library/Homebrew/test/cask/cask_spec.rb @@ -333,6 +333,24 @@ def write_auto_updates_cask(path, version:, artifacts:, token: "auto-u...
good
review_fixed
ruby
Homebrew/brew
e4cd53e9e6c06a8bc17dfbd70a8c2860f7abb626
@@ -0,0 +1,205 @@ +# typed: strict +# frozen_string_literal: true + +require "fileutils" +require "env_config" + +module OS + module Linux + module Sandbox + extend T::Helpers + + requires_ancestor { ::Sandbox } + + BUBBLEWRAP = "bwrap" + TIOCSCTTY = 0x540E + READ_ONLY_PATHS = T.let(%w[ + ...
bad
review
ruby
Homebrew/brew
936f0b2a02e77c9ef17c094c082fe5622fe3aa32
diff --git a/Library/Homebrew/extend/os/linux/sandbox.rb b/Library/Homebrew/extend/os/linux/sandbox.rb new file mode 100644 index 0000000000000..2e6d03aea0d3b --- /dev/null +++ b/Library/Homebrew/extend/os/linux/sandbox.rb @@ -0,0 +1,306 @@ +# typed: strict +# frozen_string_literal: true + +require "fileutils" +require...
good
review_fixed
ruby
Homebrew/brew
936f0b2a02e77c9ef17c094c082fe5622fe3aa32
@@ -378,10 +378,10 @@ expect(env_config.use_internal_api?).to be(true) end - it "returns false if HOMEBREW_NO_INSTALL_FROM_API is set" do + it "returns true if HOMEBREW_NO_INSTALL_FROM_API is set" do ENV["HOMEBREW_USE_INTERNAL_API"] = "1" ENV["HOMEBREW_NO_INSTALL_FROM_API"] = "1" - ...
bad
review
ruby
Homebrew/brew
745385a90a7838d2c6647043f504add861488ac5
diff --git a/Library/Homebrew/test/env_config_spec.rb b/Library/Homebrew/test/env_config_spec.rb index b608636a2ab4c..46aa07f1cfa48 100644 --- a/Library/Homebrew/test/env_config_spec.rb +++ b/Library/Homebrew/test/env_config_spec.rb @@ -360,34 +360,4 @@ expect(env_config.no_require_tap_trust?).to be(true) e...
good
review_fixed
ruby
Homebrew/brew
745385a90a7838d2c6647043f504add861488ac5
@@ -46,9 +46,6 @@ brew install hello If you're using an older distribution of Linux, installing your first package will also install a recent version of *glibc* and *gcc*. Use `brew doctor` to troubleshoot common issues. -> [!NOTE] -> Please note that unlike macOS, Homebrew does not use a sandbox when building on ...
bad
review
Homebrew/brew
edd968e27512484b6b753e0dfd6d34b59684fbc3
diff --git a/docs/Homebrew-on-Linux.md b/docs/Homebrew-on-Linux.md index 5bf0090b0193d..a71e76d763521 100644 --- a/docs/Homebrew-on-Linux.md +++ b/docs/Homebrew-on-Linux.md @@ -46,9 +46,6 @@ brew install hello If you're using an older distribution of Linux, installing your first package will also install a recent ve...
good
review_fixed
Homebrew/brew
edd968e27512484b6b753e0dfd6d34b59684fbc3
@@ -21,21 +21,24 @@ def initialize(version) # to `DEPRECATED_MACOS_VERSIONS` in `MacOSRequirement`. # NOTE: Changes to this list must match `macos_version_name` in `cmd/update.sh`. SYMBOLS = T.let({ - tahoe: "26", - sequoia: "15", - sonoma: "14", - ventura: "13", - monterey: "12", +...
bad
review
ruby
Homebrew/brew
7750fa03645dc7b72f35dfde2d766bea3b006866
diff --git a/Library/Homebrew/macos_version.rb b/Library/Homebrew/macos_version.rb index 19506bdc1ab7a..257468a7aba70 100644 --- a/Library/Homebrew/macos_version.rb +++ b/Library/Homebrew/macos_version.rb @@ -21,21 +21,24 @@ def initialize(version) # to `DEPRECATED_MACOS_VERSIONS` in `MacOSRequirement`. # N...
good
review_fixed
ruby
Homebrew/brew
7750fa03645dc7b72f35dfde2d766bea3b006866
@@ -66,8 +76,16 @@ def self.cached_packages_json_file_path } def self.fetch_packages_api!(download_queue: Homebrew.default_download_queue, stale_seconds: nil, enqueue: false) - json_contents, updated = Homebrew::API.fetch_json_api_file(packages_endpoint, stale_se...
bad
review
ruby
Homebrew/brew
7750fa03645dc7b72f35dfde2d766bea3b006866
diff --git a/Library/Homebrew/api/internal.rb b/Library/Homebrew/api/internal.rb index 28e44fe02499c..a366886d73234 100644 --- a/Library/Homebrew/api/internal.rb +++ b/Library/Homebrew/api/internal.rb @@ -20,9 +20,19 @@ module Internal private_class_method :cache + sig { returns(Utils::Bottles::Tag) } +...
good
review_fixed
ruby
Homebrew/brew
7750fa03645dc7b72f35dfde2d766bea3b006866
@@ -134,12 +134,12 @@ def self.forbidden_taps # Whether an allow/forbid/trust list reference is a remote URL or local path rather than a # `user/repository` tap name (which can only match a tap on its default GitHub remote). - # A genuine remote reference is a URL (contains `://`), scp-like syntax (`user@host:...
bad
review
ruby
Homebrew/brew
40577817fd7824170796a491648275585b20b0ab
diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb index 392c923b059e1..4d1ab4b1fea90 100644 --- a/Library/Homebrew/tap.rb +++ b/Library/Homebrew/tap.rb @@ -134,12 +134,12 @@ def self.forbidden_taps # Whether an allow/forbid/trust list reference is a remote URL or local path rather than a # `user/re...
good
review_fixed
ruby
Homebrew/brew
40577817fd7824170796a491648275585b20b0ab
@@ -172,6 +172,24 @@ def setup_completion(link:) end end + describe "::remote_reference?" do + it "recognises scp-like syntax without a `user@`" do + expect(described_class.remote_reference?("ssh_host:/srv/git/homebrew-custom_tap")).to be true + end + + it "recognises scp-like syntax with a `us...
bad
review
ruby
Homebrew/brew
40577817fd7824170796a491648275585b20b0ab
diff --git a/Library/Homebrew/test/tap_spec.rb b/Library/Homebrew/test/tap_spec.rb index 9979e433f2c66..58f764eace248 100644 --- a/Library/Homebrew/test/tap_spec.rb +++ b/Library/Homebrew/test/tap_spec.rb @@ -172,6 +172,28 @@ def setup_completion(link:) end end + describe "::remote_reference?" do + it "re...
good
review_fixed
ruby
Homebrew/brew
40577817fd7824170796a491648275585b20b0ab
@@ -61,6 +61,7 @@ task test: :build do "https://metacpan.org/pod/local::lib", "https://www.gnu.org/software/bash/", %r{https://www\.virustotal\.com/?}, + %r{https://pypi.org/?},
bad
review
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
diff --git a/docs/Rakefile b/docs/Rakefile index 1ebc8a746a62f..c280f1412e760 100644 --- a/docs/Rakefile +++ b/docs/Rakefile @@ -61,6 +61,7 @@ task test: :build do "https://metacpan.org/pod/local::lib", "https://www.gnu.org/software/bash/", %r{https://www\.virustotal\.com/?}, + %r{https://pypi...
good
review_fixed
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
@@ -135,7 +135,7 @@ Homebrew refuses to work using sudo. You should only ever sudo a tool you trust. Of course, you can trust Homebrew 😉 — but do you trust the multi-megabyte Makefile that Homebrew runs? Developers often understand C++ far better than they understand `make` syntax. It’s too high a risk to sudo such...
bad
review
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
diff --git a/docs/FAQ.md b/docs/FAQ.md index e3389ae6f4fa9..cde04c48c5ade 100644 --- a/docs/FAQ.md +++ b/docs/FAQ.md @@ -1,5 +1,5 @@ --- -last_review_date: "2026-04-10" +last_review_date: "2026-06-10" --- # FAQ (Frequently Asked Questions) @@ -136,6 +136,7 @@ Homebrew refuses to work using sudo. You should only e...
good
review_fixed
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
@@ -29,6 +29,9 @@ commands that are loaded just because their tap is present. It also makes automation clearer: scripts can trust exactly the tap, formula, cask or command they intend to use instead of relying on every tapped repository being loaded. +Tap trust is one part of Homebrew's wider approach to +[Software...
bad
review
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
diff --git a/docs/Tap-Trust.md b/docs/Tap-Trust.md index cc9f77b70d4e1..9ebdf84f5bd94 100644 --- a/docs/Tap-Trust.md +++ b/docs/Tap-Trust.md @@ -1,5 +1,5 @@ --- -last_review_date: "2026-06-01" +last_review_date: "2026-06-10" --- # Tap Trust @@ -29,6 +29,8 @@ commands that are loaded just because their tap is prese...
good
review_fixed
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
@@ -10,6 +10,8 @@ Homebrew has the capability to add (and remove) multiple taps to your local inst Your taps are Git repositories located at `$(brew --repository)/Library/Taps`. As a normal user, you usually won't see `homebrew/core` here anymore and that's OK - [normal usage is via the JSON API](https://brew.sh/202...
bad
review
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
diff --git a/docs/Interesting-Taps-and-Forks.md b/docs/Interesting-Taps-and-Forks.md index d91a329bce841..8e5dc202dace1 100644 --- a/docs/Interesting-Taps-and-Forks.md +++ b/docs/Interesting-Taps-and-Forks.md @@ -1,5 +1,5 @@ --- -last_review_date: "2025-02-08" +last_review_date: "2026-06-10" --- # Interesting Taps...
good
review_fixed
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
@@ -15,6 +15,18 @@ These instructions apply when working in `docs/`. - Install or refresh the docs Ruby environment with `brew bundle exec bundle install`. +## Markdown style + +- Write prose with one sentence per line (semantic line breaks) rather than + wrapping paragraphs at a fixed column. This keeps diffs s...
bad
review
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
diff --git a/docs/AGENTS.md b/docs/AGENTS.md index 686affe28443a..8f605042455e5 100644 --- a/docs/AGENTS.md +++ b/docs/AGENTS.md @@ -1,5 +1,5 @@ --- -last_review_date: "2026-04-05" +last_review_date: "2026-06-10" --- # Agent Instructions for Homebrew/brew docs @@ -15,6 +15,17 @@ These instructions apply when worki...
good
review_fixed
Homebrew/brew
6f0d765be48cbfcaaeef92f1cd6e31400ba60ae2
@@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use "Artificial Intelligence"/Large Language Model (AI/LLM) tools when working on Homebrew. +It expands on the [AI/LLM usage rules in our Contributing guide](https://github.com/Home...
bad
review
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
diff --git a/docs/Responsible-AI-Usage.md b/docs/Responsible-AI-Usage.md new file mode 100644 index 0000000000000..5c260fd33b4dc --- /dev/null +++ b/docs/Responsible-AI-Usage.md @@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use...
good
review_fixed
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
@@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use "Artificial Intelligence"/Large Language Model (AI/LLM) tools when working on Homebrew. +It expands on the [AI/LLM usage rules in our Contributing guide](https://github.com/Home...
bad
review
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
diff --git a/docs/Responsible-AI-Usage.md b/docs/Responsible-AI-Usage.md new file mode 100644 index 0000000000000..5c260fd33b4dc --- /dev/null +++ b/docs/Responsible-AI-Usage.md @@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use...
good
review_fixed
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
@@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use "Artificial Intelligence"/Large Language Model (AI/LLM) tools when working on Homebrew. +It expands on the [AI/LLM usage rules in our Contributing guide](https://github.com/Home...
bad
review
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
diff --git a/docs/Responsible-AI-Usage.md b/docs/Responsible-AI-Usage.md new file mode 100644 index 0000000000000..5c260fd33b4dc --- /dev/null +++ b/docs/Responsible-AI-Usage.md @@ -0,0 +1,65 @@ +--- +last_review_date: "2026-06-10" +--- + +# Responsible AI Usage + +This guide is for maintainers and contributors who use...
good
review_fixed
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
@@ -44,6 +44,7 @@ Relatedly: If you don't have time or can't be bothered: you probably don't have the time to review the PR properly. - We're a globally distributed team and this helps us move faster. - The PR review process is primarily a security measure, not a way to get consensus on the perfect code style befo...
bad
review
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
diff --git a/docs/Maintainer-Guidelines.md b/docs/Maintainer-Guidelines.md index bdca191000fb2..b206eea3a231b 100644 --- a/docs/Maintainer-Guidelines.md +++ b/docs/Maintainer-Guidelines.md @@ -44,6 +44,7 @@ Relatedly: If you don't have time or can't be bothered: you probably don't have the time to review the PR prop...
good
review_fixed
Homebrew/brew
9569699c928bfa1669a2a728dba2fe06cf7864eb
@@ -1,22 +1,31 @@ cask "ubports-installer" do arch arm: "arm64", intel: "x64" - version "0.11.2" - sha256 arm: "21f40396f8f8d1b0da9b3b7b029cd6d15988603c64cdfceb5d9ba1eb4232cd3c", - intel: "cd5532fff5c2a35e04f55b6b0ad03918404bfbaa1065e54a87cf9fb69609807b" + on_arm do + version "0.11.1" + sha256 ...
bad
review
ruby
Homebrew/homebrew-cask
3a5a53089070b9654b2cbd215f82099379cd617e
diff --git a/Casks/u/ubports-installer.rb b/Casks/u/ubports-installer.rb index 3182450c4bd6f..b03dbe8c933a9 100644 --- a/Casks/u/ubports-installer.rb +++ b/Casks/u/ubports-installer.rb @@ -1,9 +1,14 @@ cask "ubports-installer" do arch arm: "arm64", intel: "x64" - version "0.11.2" - sha256 arm: "21f40396f8f8d1...
good
review_fixed
ruby
Homebrew/homebrew-cask
3a5a53089070b9654b2cbd215f82099379cd617e
@@ -13,8 +18,19 @@ livecheck do url :url - regex(/v?(\d+(?:\.\d+)+(?:-beta)?)/i) - strategy :github_latest + regex(/^ubports-installer_(\d+(?:\.\d+)+)_mac_#{arch}\.dmg$/i)
bad
review
ruby
Homebrew/homebrew-cask
3a5a53089070b9654b2cbd215f82099379cd617e
diff --git a/Casks/u/ubports-installer.rb b/Casks/u/ubports-installer.rb index 3182450c4bd6f..b03dbe8c933a9 100644 --- a/Casks/u/ubports-installer.rb +++ b/Casks/u/ubports-installer.rb @@ -1,9 +1,14 @@ cask "ubports-installer" do arch arm: "arm64", intel: "x64" - version "0.11.2" - sha256 arm: "21f40396f8f8d1...
good
review_fixed
ruby
Homebrew/homebrew-cask
3a5a53089070b9654b2cbd215f82099379cd617e
@@ -37,15 +37,15 @@ def install include.install "glm" lib.install "cmake" - (lib/"pkgconfig/glm.pc").write <<~EOS + (lib/"pkgconfig/glm.pc").write <<~PKGCONF
bad
review
ruby
Homebrew/homebrew-core
9a53ffe712dd3de8eeb23a3ec827ba7e69152607
diff --git a/Formula/g/glm.rb b/Formula/g/glm.rb index 5f6606f779f4..a525d3a3ef9c 100644 --- a/Formula/g/glm.rb +++ b/Formula/g/glm.rb @@ -37,7 +37,7 @@ def install include.install "glm" lib.install "cmake" - (lib/"pkgconfig/glm.pc").write <<~EOS + (lib/"pkgconfig/glm.pc").write <<~PC prefix=#{...
good
review_fixed
ruby
Homebrew/homebrew-core
9a53ffe712dd3de8eeb23a3ec827ba7e69152607
@@ -34,6 +34,44 @@ let ``Actor computation try-with should generate tail call`` () = testDefault < ref <! i complete.Task.Wait() + +[<Fact>] +let ``Actor computation try-finally should generate tail call`` () = testDefault <| fun tck -> + let complete = TaskCompletionSource<_>() + let ref = spa...
bad
review
fsharp
Horusiath/Akkling
b48c2488f0ac0f612129f66f1ed721a581ab7b5c
diff --git a/tests/Akkling.Tests/ComputationExpressions.fs b/tests/Akkling.Tests/ComputationExpressions.fs index 8c85be5..b0a442d 100644 --- a/tests/Akkling.Tests/ComputationExpressions.fs +++ b/tests/Akkling.Tests/ComputationExpressions.fs @@ -10,12 +10,13 @@ module Akkling.Tests.ComputationExpression open Akkling ...
good
review_fixed
fsharp
Horusiath/Akkling
b48c2488f0ac0f612129f66f1ed721a581ab7b5c
@@ -22,9 +22,11 @@ abstract class AbstractDecoder implements DecoderInterface */ protected function isGifFormat(string $input): bool { + $head = substr($input, 0, 6); + return 1 === preg_match( "/^47494638(37|39)61/", - strtoupper(substr(bin2hex($input), 0, 32)) +...
bad
review
php
Intervention/image
423a8f296d4b37995b835bf6f73d83be44e15f72
diff --git a/src/Drivers/AbstractDecoder.php b/src/Drivers/AbstractDecoder.php index 46567171a..029761ba0 100644 --- a/src/Drivers/AbstractDecoder.php +++ b/src/Drivers/AbstractDecoder.php @@ -22,9 +22,11 @@ abstract class AbstractDecoder implements DecoderInterface */ protected function isGifFormat(string $...
good
review_fixed
php
Intervention/image
423a8f296d4b37995b835bf6f73d83be44e15f72
@@ -12,9 +12,13 @@ class AvifEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/AvifEncoder.php b/src/Encoders/AvifEncoder.php index 7799950da..8a724247e 100644 --- a/src/Encoders/AvifEncoder.php +++ b/src/Encoders/AvifEncoder.php @@ -12,9 +12,13 @@ class AvifEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + *...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -12,9 +12,13 @@ class HeicEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/HeicEncoder.php b/src/Encoders/HeicEncoder.php index 2d129a355..965d07fa7 100644 --- a/src/Encoders/HeicEncoder.php +++ b/src/Encoders/HeicEncoder.php @@ -12,9 +12,13 @@ class HeicEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + *...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -12,9 +12,13 @@ class Jpeg2000Encoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/Jpeg2000Encoder.php b/src/Encoders/Jpeg2000Encoder.php index dea11ef26..8d89a070e 100644 --- a/src/Encoders/Jpeg2000Encoder.php +++ b/src/Encoders/Jpeg2000Encoder.php @@ -12,9 +12,13 @@ class Jpeg2000Encoder extends SpecializableEncoder * Create new encoder object * * @param ...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -13,11 +13,14 @@ class JpegEncoder extends SpecializableEncoder * * @param int $quality * @param bool $progressive + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/JpegEncoder.php b/src/Encoders/JpegEncoder.php index eaf520e1a..cbc5bc3e2 100644 --- a/src/Encoders/JpegEncoder.php +++ b/src/Encoders/JpegEncoder.php @@ -13,11 +13,14 @@ class JpegEncoder extends SpecializableEncoder * * @param int $quality * @param bool $progressive + *...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -12,9 +12,13 @@ class TiffEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/TiffEncoder.php b/src/Encoders/TiffEncoder.php index 203baf8c7..a5fe0c82b 100644 --- a/src/Encoders/TiffEncoder.php +++ b/src/Encoders/TiffEncoder.php @@ -12,9 +12,13 @@ class TiffEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + *...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -12,9 +12,12 @@ class WebpEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + * @param null|bool $strip
bad
review
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
diff --git a/src/Encoders/WebpEncoder.php b/src/Encoders/WebpEncoder.php index 5530b6e6a..7a9b570b5 100644 --- a/src/Encoders/WebpEncoder.php +++ b/src/Encoders/WebpEncoder.php @@ -12,9 +12,12 @@ class WebpEncoder extends SpecializableEncoder * Create new encoder object * * @param int $quality + *...
good
review_fixed
php
Intervention/image
61315da116d3a10428fd8865765dd8b5f5ea6a43
@@ -21,7 +21,10 @@ public function encode(ImageInterface $image): EncodedImage $imagick = $image->core()->native(); $imagick->setImageBackgroundColor(new ImagickPixel('transparent')); - $imagick = $imagick->mergeImageLayers(Imagick::LAYERMETHOD_MERGE); + if(! $image->isAnimated()) {
bad
review
php
Intervention/image
bd1cbb8565dfda2c42d43721af122325faab6da0
diff --git a/src/Drivers/Imagick/Encoders/WebpEncoder.php b/src/Drivers/Imagick/Encoders/WebpEncoder.php index 552b23ab7..93a26fd9a 100644 --- a/src/Drivers/Imagick/Encoders/WebpEncoder.php +++ b/src/Drivers/Imagick/Encoders/WebpEncoder.php @@ -21,7 +21,10 @@ public function encode(ImageInterface $image): EncodedImage ...
good
review_fixed
php
Intervention/image
bd1cbb8565dfda2c42d43721af122325faab6da0
@@ -0,0 +1 @@ +/* do nothing */
bad
review
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/drizzle/0002_daffy_wrecker.sql b/drizzle/0002_daffy_wrecker.sql new file mode 100644 index 000000000..1520a6578 --- /dev/null +++ b/drizzle/0002_daffy_wrecker.sql @@ -0,0 +1,1 @@ +/* do nothing */ \ No newline at end of file
good
review_fixed
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,105 @@ +import { Tool, ToolCall } from '@/lib/models/types'; +import { + ActionOutput, + AdditionalConfig, + ClassifierOutput, + ResearchAction, + SearchAgentConfig, + SearchSources, +} from '../../types'; + +class ActionRegistry { + private static actions: Map<string, ResearchAction> = new Map(); + +...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/lib/agents/search/researcher/actions/registry.ts b/src/lib/agents/search/researcher/actions/registry.ts new file mode 100644 index 000000000..a8de51329 --- /dev/null +++ b/src/lib/agents/search/researcher/actions/registry.ts @@ -0,0 +1,105 @@ +import { Tool, ToolCall } from '@/lib/models/types'; +impor...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -107,8 +114,167 @@ fs.readdirSync(migrationsFolder) db.exec('DROP TABLE messages;'); db.exec('ALTER TABLE messages_with_sources RENAME TO messages;'); + } else if (migrationName === '0002') { + /* Migrate chat */ + db.exec(` + CREATE TABLE IF NOT EXISTS chats_new ( + ...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/lib/db/migrate.ts b/src/lib/db/migrate.ts index e4c698714..e0efb7c9e 100644 --- a/src/lib/db/migrate.ts +++ b/src/lib/db/migrate.ts @@ -18,12 +18,18 @@ db.exec(` `); function sanitizeSql(content: string) { - return content - .split(/\r?\n/) - .filter( - (l) => !l.trim().startsWith('-->'...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -46,21 +41,30 @@ export const POST = async (req: Request) => { ), ]); - const searchHandler: MetaSearchAgentType = searchHandlers[body.focusMode]; + const history: ChatTurnMessage[] = body.history.map((msg) => { + return msg[0] === 'human' + ? { role: 'user', content: msg[1] } + ...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/app/api/search/route.ts b/src/app/api/search/route.ts index bc7255f72..099126840 100644 --- a/src/app/api/search/route.ts +++ b/src/app/api/search/route.ts @@ -1,12 +1,13 @@ -import { AIMessage, BaseMessage, HumanMessage } from '@langchain/core/messages'; -import { MetaSearchAgentType } from '@/lib/sea...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,132 @@ +{ + "version": "6", + "dialect": "sqlite", + "id": "1c5eb804-d6b4-48ec-9a8f-75fb729c8e52", + "prevId": "6dedf55f-0e44-478f-82cf-14a21ac686f8", + "tables": { + "chats": { + "name": "chats", + "columns": { + "id": { + "name": "id", + "type": "text", + ...
bad
review
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/drizzle/meta/0002_snapshot.json b/drizzle/meta/0002_snapshot.json new file mode 100644 index 000000000..feb820c83 --- /dev/null +++ b/drizzle/meta/0002_snapshot.json @@ -0,0 +1,132 @@ +{ + "version": "6", + "dialect": "sqlite", + "id": "1c5eb804-d6b4-48ec-9a8f-75fb729c8e52", + "prevId": "6dedf55f-0e44-...
good
review_fixed
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,99 @@ +import { ResearcherOutput, SearchAgentInput } from './types'; +import SessionManager from '@/lib/session'; +import { classify } from './classifier'; +import Researcher from './researcher'; +import { getWriterPrompt } from '@/lib/prompts/search/writer'; +import { WidgetExecutor } from './widgets'; + +c...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/lib/agents/search/api.ts b/src/lib/agents/search/api.ts new file mode 100644 index 000000000..924bc68f4 --- /dev/null +++ b/src/lib/agents/search/api.ts @@ -0,0 +1,99 @@ +import { ResearcherOutput, SearchAgentInput } from './types'; +import SessionManager from '@/lib/session'; +import { classify } from...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,102 @@ +import z from 'zod'; +import { ResearchAction } from '../../types'; +import UploadStore from '@/lib/uploads/store'; + +const schema = z.object({ + queries: z + .array(z.string()) + .describe( + 'A list of queries to search in user uploaded files. Can be a maximum of 3 queries.', + ), +...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/lib/agents/search/researcher/actions/uploadsSearch.ts b/src/lib/agents/search/researcher/actions/uploadsSearch.ts new file mode 100644 index 000000000..819506395 --- /dev/null +++ b/src/lib/agents/search/researcher/actions/uploadsSearch.ts @@ -0,0 +1,102 @@ +import z from 'zod'; +import { ResearchActio...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,64 @@ +'use client'; + +import { CheckIcon, CopyIcon } from '@phosphor-icons/react'; +import React, { useEffect, useMemo, useState } from 'react'; +import { useTheme } from 'next-themes'; +import SyntaxHighlighter from 'react-syntax-highlighter'; +import darkTheme from './CodeBlockDarkTheme'; +import lightTh...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/components/MessageRenderer/CodeBlock/index.tsx b/src/components/MessageRenderer/CodeBlock/index.tsx new file mode 100644 index 000000000..493a0d025 --- /dev/null +++ b/src/components/MessageRenderer/CodeBlock/index.tsx @@ -0,0 +1,64 @@ +'use client'; + +import { CheckIcon, CopyIcon } from '@phosphor-ic...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,67 @@ +import z from 'zod'; +import { Widget } from '../types'; +import formatChatHistoryAsString from '@/lib/utils/formatHistory'; +import { exp, evaluate as mathEval } from 'mathjs'; + +const schema = z.object({ + expression: z + .string() + .describe('Mathematical expression to calculate or evaluat...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/lib/agents/search/widgets/calculationWidget.ts b/src/lib/agents/search/widgets/calculationWidget.ts new file mode 100644 index 000000000..3e280152e --- /dev/null +++ b/src/lib/agents/search/widgets/calculationWidget.ts @@ -0,0 +1,71 @@ +import z from 'zod'; +import { Widget } from '../types'; +import f...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -28,35 +29,41 @@ const downloadFile = (filename: string, content: string, type: string) => { const exportAsMarkdown = (sections: Section[], title: string) => { const date = new Date( - sections[0]?.userMessage?.createdAt || Date.now(), + sections[0].message.createdAt || Date.now(),
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/components/Navbar.tsx b/src/components/Navbar.tsx index bbcd470a4..6d3e77c25 100644 --- a/src/components/Navbar.tsx +++ b/src/components/Navbar.tsx @@ -11,6 +11,7 @@ import { } from '@headlessui/react'; import jsPDF from 'jspdf'; import { useChat, Section } from '@/lib/hooks/useChat'; +import { Sour...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
@@ -0,0 +1,266 @@ +'use client'; + +import { + Brain, + Search, + FileText, + ChevronDown, + ChevronUp, + BookSearch, +} from 'lucide-react'; +import { motion, AnimatePresence } from 'framer-motion'; +import { useEffect, useState } from 'react'; +import { ResearchBlock, ResearchBlockSubStep } from '@/lib/types'; ...
bad
review
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431
diff --git a/src/components/AssistantSteps.tsx b/src/components/AssistantSteps.tsx new file mode 100644 index 000000000..c715a9248 --- /dev/null +++ b/src/components/AssistantSteps.tsx @@ -0,0 +1,266 @@ +'use client'; + +import { + Brain, + Search, + FileText, + ChevronDown, + ChevronUp, + BookSearch, +} from 'lu...
good
review_fixed
typescript
ItzCrazyKns/Vane
7f3f88196412ddd3a2d28e0aff13063bcadf0431