text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -2332,18 +2332,19 @@ Some of yt-dlp's default options are different from that of youtube-dl and youtu * `certifi` will be used for SSL root certificates, if installed. If you want to use system certificates (e.g. self-signed), use `--compat-options no-certifi` * yt-dlp's sanitization of invalid characters in filen...
bad
review
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
diff --git a/README.md b/README.md index 09e290b89dbc..e334bec8ed41 100644 --- a/README.md +++ b/README.md @@ -2332,8 +2332,8 @@ Some of yt-dlp's default options are different from that of youtube-dl and youtu * `certifi` will be used for SSL root certificates, if installed. If you want to use system certificates (e.g...
good
review_fixed
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
@@ -91,6 +94,54 @@ def test_parse_cmd(self): self.assertEqual(pp.parse_cmd('echo {}', info), cmd) self.assertEqual(pp.parse_cmd('echo %(filepath)q', info), cmd) + def test_unsafe_exec_expansion(self): + def test(exec_cmd): + return ExecPP(ydl, exec_cmd)
bad
review
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
diff --git a/test/test_postprocessors.py b/test/test_postprocessors.py index d58a97fc6ee9..ad595d6b70c6 100644 --- a/test/test_postprocessors.py +++ b/test/test_postprocessors.py @@ -11,7 +11,10 @@ import subprocess from yt_dlp import YoutubeDL -from yt_dlp.utils import shell_quote +from yt_dlp.utils import ( + ...
good
review_fixed
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
@@ -8,6 +8,16 @@ def __init__(self, downloader, exec_cmd): PostProcessor.__init__(self, downloader) self.exec_cmd = variadic(exec_cmd) + if ( + self._downloader is None + or 'allow-unsafe-exec-expansion' in self._downloader.params['compat_opts'] + ): + ...
bad
review
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
diff --git a/yt_dlp/postprocessor/exec.py b/yt_dlp/postprocessor/exec.py index 243487dd25a4..ac5708b10e2d 100644 --- a/yt_dlp/postprocessor/exec.py +++ b/yt_dlp/postprocessor/exec.py @@ -5,8 +5,17 @@ class ExecPP(PostProcessor): def __init__(self, downloader, exec_cmd): - PostProcessor.__init__(self, dow...
good
review_fixed
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
@@ -91,6 +94,54 @@ def test_parse_cmd(self): self.assertEqual(pp.parse_cmd('echo {}', info), cmd) self.assertEqual(pp.parse_cmd('echo %(filepath)q', info), cmd) + def test_unsafe_exec_expansion(self): + def test(exec_cmd): + return ExecPP(ydl, exec_cmd) + + # Test unsafe ...
bad
review
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
diff --git a/test/test_postprocessors.py b/test/test_postprocessors.py index d58a97fc6ee9..ad595d6b70c6 100644 --- a/test/test_postprocessors.py +++ b/test/test_postprocessors.py @@ -11,7 +11,10 @@ import subprocess from yt_dlp import YoutubeDL -from yt_dlp.utils import shell_quote +from yt_dlp.utils import ( + ...
good
review_fixed
python
yt-dlp/yt-dlp
4431ce9d64b78b4cbdf94fc3420201e81b28220d
@@ -0,0 +1,127 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ExtractorError, try_get, unified_strdate + + +class OpenRecBaseIE(InfoExtractor): + pass + + +class OpenRecIE(OpenRecBaseIE): + IE_NAME = 'openrec' + _VALID_URL = r'https?://(?:...
bad
review
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
diff --git a/yt_dlp/extractor/openrec.py b/yt_dlp/extractor/openrec.py new file mode 100644 index 000000000000..d7073ab445bc --- /dev/null +++ b/yt_dlp/extractor/openrec.py @@ -0,0 +1,126 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + Extrac...
good
review_fixed
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
@@ -0,0 +1,127 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ExtractorError, try_get, unified_strdate + + +class OpenRecBaseIE(InfoExtractor): + pass + + +class OpenRecIE(OpenRecBaseIE): + IE_NAME = 'openrec' + _VALID_URL = r'https?://(?:...
bad
review
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
diff --git a/yt_dlp/extractor/openrec.py b/yt_dlp/extractor/openrec.py new file mode 100644 index 000000000000..d7073ab445bc --- /dev/null +++ b/yt_dlp/extractor/openrec.py @@ -0,0 +1,126 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + Extrac...
good
review_fixed
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
@@ -0,0 +1,130 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ExtractorError, + traverse_obj, + try_get, + unified_strdate +) +from ..compat import compat_str + + +class OpenRecBaseIE(InfoExtractor): + pass + +
bad
review
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
diff --git a/yt_dlp/extractor/openrec.py b/yt_dlp/extractor/openrec.py new file mode 100644 index 000000000000..d7073ab445bc --- /dev/null +++ b/yt_dlp/extractor/openrec.py @@ -0,0 +1,126 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + Extrac...
good
review_fixed
python
yt-dlp/yt-dlp
867c7a3c32093b1dd197beba21ca62a6ad08ba37
@@ -138,6 +138,14 @@ curl -L https://github.com/yt-dlp/yt-dlp/raw/master/public.key | gpg --import gpg --verify SHA2-256SUMS.sig SHA2-256SUMS gpg --verify SHA2-512SUMS.sig SHA2-512SUMS ``` + +#### Licensing + +While yt-dlp is licensed under the [Unlicense](LICENSE), most release files contain code from other project...
bad
review
yt-dlp/yt-dlp
cc6bf1c384de37365160ca50eee03d6e652fd06b
diff --git a/README.md b/README.md index e582e1e53cbe..7be3266ea54c 100644 --- a/README.md +++ b/README.md @@ -138,6 +138,17 @@ curl -L https://github.com/yt-dlp/yt-dlp/raw/master/public.key | gpg --import gpg --verify SHA2-256SUMS.sig SHA2-256SUMS gpg --verify SHA2-512SUMS.sig SHA2-512SUMS ``` + +#### Licensing + +...
good
review_fixed
yt-dlp/yt-dlp
cc6bf1c384de37365160ca50eee03d6e652fd06b
@@ -0,0 +1,316 @@ +import requests +from dataclasses import dataclass +from pathlib import Path +import hashlib + +DEFAULT_OUTPUT = 'THIRD_PARTY_LICENSES.txt' +CACHE_LOCATION = '.license_cache' +HEADER = '''THIRD-PARTY LICENSES + +This file aggregates license texts of third-party components included with the yt-dlp PyI...
bad
review
python
yt-dlp/yt-dlp
cc6bf1c384de37365160ca50eee03d6e652fd06b
diff --git a/devscripts/generate_third_party_licenses.py b/devscripts/generate_third_party_licenses.py new file mode 100644 index 000000000000..db615d2e352e --- /dev/null +++ b/devscripts/generate_third_party_licenses.py @@ -0,0 +1,316 @@ +import requests +from dataclasses import dataclass +from pathlib import Path +im...
good
review_fixed
python
yt-dlp/yt-dlp
cc6bf1c384de37365160ca50eee03d6e652fd06b
@@ -2713,7 +2714,7 @@ def manifest_url(manifest): def _find_jwplayer_data(self, webpage, video_id=None, transform_source=js_to_json): mobj = re.search( - r'(?s)jwplayer\((?P<quote>[\'"])[^\'" ]+(?P=quote)\)(?!</script>).*?\.setup\s*\((?P<options>[^)]+)\)', + r'''(?s)jwplayer\s*\(\s...
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -2847,6 +2853,9 @@ def _parse_jwplayer_formats(self, jwplayer_sources_data, video_id=None, 'tbr': int_or_none(source.get('bitrate')),
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -2734,6 +2735,10 @@ def _extract_jwplayer_data(self, webpage, video_id, *args, **kwargs): def _parse_jwplayer_data(self, jwplayer_data, video_id=None, require_title=True, m3u8_id=None, mpd_id=None, rtmp_params=None, base_url=None): + if try_get(jwplayer_data, lambda x: x.g...
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -2833,20 +2848,25 @@ def _parse_jwplayer_formats(self, jwplayer_sources_data, video_id=None, 'ext': ext, }) else: + format_id = str_or_none(source.get('label')) height = int_or_none(source.get('height')) - if height is ...
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -2833,20 +2848,25 @@ def _parse_jwplayer_formats(self, jwplayer_sources_data, video_id=None, 'ext': ext, }) else: + format_id = str_or_none(source.get('label')) height = int_or_none(source.get('height')) - if height is ...
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -2713,7 +2714,7 @@ def manifest_url(manifest): def _find_jwplayer_data(self, webpage, video_id=None, transform_source=js_to_json): mobj = re.search( - r'(?s)jwplayer\((?P<quote>[\'"])[^\'" ]+(?P=quote)\)(?!</script>).*?\.setup\s*\((?P<options>[^)]+)\)', + r'''(?s)jwplayer\s*\(\s...
bad
review
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py index 1f33a1e06da..a0a796d7b40 100644 --- a/youtube_dl/extractor/common.py +++ b/youtube_dl/extractor/common.py @@ -70,6 +70,7 @@ str_or_none, str_to_int, strip_or_none, + try_get, unescapeHTML, unified_strdate, ...
good
review_fixed
python
ytdl-org/youtube-dl
1087725db08c0ffdd1f8012ff4dba60d16f98bd9
@@ -426,6 +426,10 @@ from .gamestar import GameStarIE from .gaskrank import GaskrankIE from .gazeta import GazetaIE +from .gbnews import ( + GBNewsIE, + GBNewsLiveIE, +)
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/extractors.py b/youtube_dl/extractor/extractors.py index 402e542ae96..bee3ba22c78 100644 --- a/youtube_dl/extractor/extractors.py +++ b/youtube_dl/extractor/extractors.py @@ -426,6 +426,7 @@ from .gamestar import GameStarIE from .gaskrank import GaskrankIE from .gazeta import Gazeta...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +)
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features'''
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -0,0 +1,152 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..compat import ( + compat_str, +) +from ..utils import ( + extract_attributes, + ExtractorError, + try_get, +) + + +class GBNewsIE(InfoExtractor): + '''GB News clips and features''' + +...
bad
review
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
diff --git a/youtube_dl/extractor/gbnews.py b/youtube_dl/extractor/gbnews.py new file mode 100644 index 00000000000..f04f30e5afb --- /dev/null +++ b/youtube_dl/extractor/gbnews.py @@ -0,0 +1,139 @@ +# coding: utf-8 +from __future__ import unicode_literals + +from .common import InfoExtractor +from ..utils import ( + ...
good
review_fixed
python
ytdl-org/youtube-dl
320f89ef892f6bc3681492f5ff1c176a3433108e
@@ -424,6 +511,16 @@ def test_split(self): self._test(jsi, test_result, args=['t-e-s-t', '-']) self._test(jsi, [''], args=['', '-']) self._test(jsi, [], args=['', '']) + # RegExp split + self._test('function f(){return "test".split(/(?:)/)}', + ['t'...
bad
review
python
ytdl-org/youtube-dl
12bc3775d963039efaf4a36b0ea124a6b5e5ca8a
diff --git a/test/test_jsinterp.py b/test/test_jsinterp.py index c7a4f2cbf23..12e7b9b9485 100644 --- a/test/test_jsinterp.py +++ b/test/test_jsinterp.py @@ -1,4 +1,5 @@ #!/usr/bin/env python +# coding: utf-8 from __future__ import unicode_literals @@ -11,7 +12,7 @@ import math import re -from youtube_dl.compa...
good
review_fixed
python
ytdl-org/youtube-dl
12bc3775d963039efaf4a36b0ea124a6b5e5ca8a
@@ -424,6 +511,17 @@ def test_split(self): self._test(jsi, test_result, args=['t-e-s-t', '-']) self._test(jsi, [''], args=['', '-']) self._test(jsi, [], args=['', '']) + # RegExp split + self._test('function f(){return "test".split(/(?:)/)}', + ['t'...
bad
review
python
ytdl-org/youtube-dl
12bc3775d963039efaf4a36b0ea124a6b5e5ca8a
diff --git a/test/test_jsinterp.py b/test/test_jsinterp.py index c7a4f2cbf23..12e7b9b9485 100644 --- a/test/test_jsinterp.py +++ b/test/test_jsinterp.py @@ -1,4 +1,5 @@ #!/usr/bin/env python +# coding: utf-8 from __future__ import unicode_literals @@ -11,7 +12,7 @@ import math import re -from youtube_dl.compa...
good
review_fixed
python
ytdl-org/youtube-dl
12bc3775d963039efaf4a36b0ea124a6b5e5ca8a
@@ -877,12 +884,35 @@ def eval_method(): self.interpret_expression(v, local_vars, allow_recursion) for v in self._separate(arg_str)] - if obj == compat_str: + # Fixup prototype call + if isinstance(obj, type): + ...
bad
review
python
ytdl-org/youtube-dl
e40a428fc2cb8dff4cdbbd6bf692e1b5bf35e2c6
diff --git a/youtube_dl/jsinterp.py b/youtube_dl/jsinterp.py index 02adf667846..949f77775e8 100644 --- a/youtube_dl/jsinterp.py +++ b/youtube_dl/jsinterp.py @@ -20,7 +20,9 @@ compat_basestring, compat_chr, compat_collections_chain_map as ChainMap, + compat_filter as filter, compat_itertools_zip_l...
good
review_fixed
python
ytdl-org/youtube-dl
e40a428fc2cb8dff4cdbbd6bf692e1b5bf35e2c6
@@ -6604,27 +6604,53 @@ class _UnsafeExtensionError(Exception): ), # video MEDIA_EXTENSIONS.video, ( - 'avif',
bad
review
python
ytdl-org/youtube-dl
e40a428fc2cb8dff4cdbbd6bf692e1b5bf35e2c6
diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py index 3ec9d381190..ac1e78002b3 100644 --- a/youtube_dl/utils.py +++ b/youtube_dl/utils.py @@ -6604,27 +6604,53 @@ class _UnsafeExtensionError(Exception): ), # video MEDIA_EXTENSIONS.video, ( - 'avif', + 'asx', ...
good
review_fixed
python
ytdl-org/youtube-dl
e40a428fc2cb8dff4cdbbd6bf692e1b5bf35e2c6
@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate): url = 'https://interface3.music.163.com/eapi/song/enhance/player/url' data, headers = self.make_player_api_request_data_and_headers(song_id, bitrate) try: - return self._download_json( + msg = 'empty resul...
bad
review
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py index fad22a2cd0b..2bbfc78585f 100644 --- a/youtube_dl/extractor/neteasemusic.py +++ b/youtube_dl/extractor/neteasemusic.py @@ -20,6 +20,7 @@ from ..utils import ( ExtractorError, bytes_to_intlist, + error_to_compat_s...
good
review_fixed
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate): url = 'https://interface3.music.163.com/eapi/song/enhance/player/url' data, headers = self.make_player_api_request_data_and_headers(song_id, bitrate) try: - return self._download_json( + msg = 'empty resul...
bad
review
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py index fad22a2cd0b..2bbfc78585f 100644 --- a/youtube_dl/extractor/neteasemusic.py +++ b/youtube_dl/extractor/neteasemusic.py @@ -20,6 +20,7 @@ from ..utils import ( ExtractorError, bytes_to_intlist, + error_to_compat_s...
good
review_fixed
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate): url = 'https://interface3.music.163.com/eapi/song/enhance/player/url' data, headers = self.make_player_api_request_data_and_headers(song_id, bitrate) try: - return self._download_json( + msg = 'empty resul...
bad
review
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py index fad22a2cd0b..2bbfc78585f 100644 --- a/youtube_dl/extractor/neteasemusic.py +++ b/youtube_dl/extractor/neteasemusic.py @@ -20,6 +20,7 @@ from ..utils import ( ExtractorError, bytes_to_intlist, + error_to_compat_s...
good
review_fixed
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
@@ -125,6 +133,8 @@ def extract_formats(self, info): 'filesize': int_or_none(song.get('size')), 'asr': int_or_none(details.get('sr')), }) + if not formats: + self.report_warning('Maybe you should use a proper proxy server located i...
bad
review
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py index fad22a2cd0b..2bbfc78585f 100644 --- a/youtube_dl/extractor/neteasemusic.py +++ b/youtube_dl/extractor/neteasemusic.py @@ -20,6 +20,7 @@ from ..utils import ( ExtractorError, bytes_to_intlist, + error_to_compat_s...
good
review_fixed
python
ytdl-org/youtube-dl
58a57949484c837965ba91ad26f28200ced416de
@@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id, note): class NetEaseMusicIE(NetEaseMusicBaseIE): IE_NAME = 'netease:song' IE_DESC = '网易云音乐' - _VALID_URL = r'https?://music\.163\.com/(#/)?song\?id=(?P<id>[0-9]+)' + _VALID_URL = r'https?://(y\.)?music\.163\.com/(#/|m/)?song\?.*?\bid=(?P<id>[0...
bad
review
python
ytdl-org/youtube-dl
dd7994e6db8c1bbdff6d7b35acf389178b2de6ae
diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py index fad22a2cd0b..6413b4aba9f 100644 --- a/youtube_dl/extractor/neteasemusic.py +++ b/youtube_dl/extractor/neteasemusic.py @@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id, note): class NetEaseMusicIE(NetEaseMusicBaseIE...
good
review_fixed
python
ytdl-org/youtube-dl
dd7994e6db8c1bbdff6d7b35acf389178b2de6ae
@@ -1659,15 +1659,24 @@ def _decrypt_nsig(self, n, video_id, player_url): def _extract_n_function_name(self, jscode): func_name, idx = self._search_regex( # new: (b=String.fromCharCode(110),c=a.get(b))&&c=nfunc[idx](c) - # or: (b="nn"[+a.D],c=a.get(b))&&(c=nfunc[idx](c)s + ...
bad
review
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py index 84371ff063d..509e374a4d7 100644 --- a/youtube_dl/extractor/youtube.py +++ b/youtube_dl/extractor/youtube.py @@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url): def _extract_n_function_name(self, jscode): ...
good
review_fixed
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
@@ -174,6 +174,10 @@ 'https://www.youtube.com/s/player/5604538d/player_ias.vflset/en_US/base.js', '7X-he4jjvMx7BCX', 'sViSydX8IHtdWA', ), + ( + 'https://www.youtube.com/s/player/20dfca59/player_ias.vflset/en_US/base.js', + '-fLCxedkAk4LUTK2', 'O8kfRq1y1eyHGw',
bad
review
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
diff --git a/test/test_youtube_signature.py b/test/test_youtube_signature.py index 5b4aa3aa05b..1c5f667f57a 100644 --- a/test/test_youtube_signature.py +++ b/test/test_youtube_signature.py @@ -174,6 +174,10 @@ 'https://www.youtube.com/s/player/5604538d/player_ias.vflset/en_US/base.js', '7X-he4jjvMx7BC...
good
review_fixed
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
@@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url): def _extract_n_function_name(self, jscode): func_name, idx = self._search_regex( # new: (b=String.fromCharCode(110),c=a.get(b))&&c=nfunc[idx](c) - # or: (b="nn"[+a.D],c=a.get(b))&&(c=nfunc[idx](c)s + ...
bad
review
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py index 84371ff063d..509e374a4d7 100644 --- a/youtube_dl/extractor/youtube.py +++ b/youtube_dl/extractor/youtube.py @@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url): def _extract_n_function_name(self, jscode): ...
good
review_fixed
python
ytdl-org/youtube-dl
8765808cd22c712b0dc22f8ccffa2e9c0b365e85
@@ -1164,12 +1170,20 @@ def parse_media(media): continue formats, subtitles = self._download_media_selector(item_id) self._sort_formats(formats) + item_desc = try_get(media, lambda x: x['summary']['blocks'][0]['model']['text'], compat...
bad
review
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py index e8d000bbb51..71ea25881c9 100644 --- a/youtube_dl/extractor/bbc.py +++ b/youtube_dl/extractor/bbc.py @@ -11,6 +11,7 @@ compat_etree_Element, compat_HTTPError, compat_parse_qs, + compat_str, compat_urllib_parse_urlparse, ...
good
review_fixed
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
@@ -1164,12 +1170,20 @@ def parse_media(media): continue formats, subtitles = self._download_media_selector(item_id) self._sort_formats(formats) + item_desc = try_get(media, lambda x: x['summary']['blocks'][0]['model']['text'], compat...
bad
review
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py index e8d000bbb51..71ea25881c9 100644 --- a/youtube_dl/extractor/bbc.py +++ b/youtube_dl/extractor/bbc.py @@ -11,6 +11,7 @@ compat_etree_Element, compat_HTTPError, compat_parse_qs, + compat_str, compat_urllib_parse_urlparse, ...
good
review_fixed
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
@@ -761,8 +762,13 @@ class BBCIE(BBCCoUkIE): 'only_matching': True, }, { # custom redirection to www.bbc.com + # video with window.__INITIAL_DATA__ 'url': 'http://www.bbc.co.uk/news/science-environment-33661876', - 'only_matching': True, + 'id': 'p02xzws1', + ...
bad
review
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py index e8d000bbb51..71ea25881c9 100644 --- a/youtube_dl/extractor/bbc.py +++ b/youtube_dl/extractor/bbc.py @@ -11,6 +11,7 @@ compat_etree_Element, compat_HTTPError, compat_parse_qs, + compat_str, compat_urllib_parse_urlparse, ...
good
review_fixed
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
@@ -761,8 +762,13 @@ class BBCIE(BBCCoUkIE): 'only_matching': True, }, { # custom redirection to www.bbc.com + # video with window.__INITIAL_DATA__ 'url': 'http://www.bbc.co.uk/news/science-environment-33661876', - 'only_matching': True, + 'id': 'p02xzws1', + ...
bad
review
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f
diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py index e8d000bbb51..71ea25881c9 100644 --- a/youtube_dl/extractor/bbc.py +++ b/youtube_dl/extractor/bbc.py @@ -11,6 +11,7 @@ compat_etree_Element, compat_HTTPError, compat_parse_qs, + compat_str, compat_urllib_parse_urlparse, ...
good
review_fixed
python
ytdl-org/youtube-dl
5ffb321d019c90d89d7e58a46b5b5494a6a1614f