text stringlengths 19 585k | label stringclasses 2
values | category stringclasses 2
values | language stringclasses 14
values | repo stringclasses 932
values | sha stringlengths 40 40 |
|---|---|---|---|---|---|
@@ -0,0 +1,96 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ txt_or_none,
+ unified_timestamp,
+ url_or_none,
+ traverse_obj,
+ T, | bad | review | python | ytdl-org/youtube-dl | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 |
diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | good | review_fixed | python | ytdl-org/youtube-dl | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 |
@@ -0,0 +1,96 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ txt_or_none,
+ unified_timestamp,
+ url_or_none,
+ traverse_obj,
+ T,
+)
+
+
+class EpidemicSoundIE(InfoExtractor):
+ _VALID_URL = r'https?://(?:... | bad | review | python | ytdl-org/youtube-dl | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 |
diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | good | review_fixed | python | ytdl-org/youtube-dl | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 |
@@ -717,4 +717,9 @@
<string name="action_debug_info">Foutopsporingsinformatie</string>
<string name="player_time_stretching">Audio-tijdverlenging</string>
<string name="player_time_stretching_desc">Behoudt de natuurlijke stem bij het veranderen van de snelheid. Kan de prestaties op sommige apparaten aanzienlij... | bad | review | yuliskov/SmartTube | 27b336185d3d8e9b859496ec621a2bc7744f5f15 | |
diff --git a/common/src/main/res/values-nl/strings.xml b/common/src/main/res/values-nl/strings.xml
index e08c677829..34f3cfc7ee 100644
--- a/common/src/main/res/values-nl/strings.xml
+++ b/common/src/main/res/values-nl/strings.xml
@@ -43,7 +43,7 @@
<string name="update_changelog">Wijzigingslog</string>
<string na... | good | review_fixed | yuliskov/SmartTube | 27b336185d3d8e9b859496ec621a2bc7744f5f15 | |
@@ -99,7 +99,7 @@ public function boot()
*/
protected function ensureHttps()
{
- if (config('admin.https') || config('admin.secure')) {
+ if ((config('admin.https') || config('admin.secure')) && \Str::startsWith(request()->getRequestUri(), '/admin')) { | bad | review | php | z-song/laravel-admin | 6f5e80adb9d519b00579291452bf15cd2d7fd2a9 |
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php
index 233bba360d..2d7e07719b 100644
--- a/src/AdminServiceProvider.php
+++ b/src/AdminServiceProvider.php
@@ -99,7 +99,8 @@ public function boot()
*/
protected function ensureHttps()
{
- if (config('admin.https') || config('... | good | review_fixed | php | z-song/laravel-admin | 6f5e80adb9d519b00579291452bf15cd2d7fd2a9 |
@@ -80,8 +80,4 @@ private static void showAboutDialog() {
private static void showOptionsDialog() {
Control.getSingleton().getMenuToolsControl().options();
}
-
- private static void exitZap() {
- Control.getSingleton().getMenuFileControl().exit(); | bad | review | java | zaproxy/zaproxy | 5e88926d1a63d55f0121f9cc40c20f7fdc724218 |
diff --git a/zap/src/main/java/org/zaproxy/zap/OsXGui.java b/zap/src/main/java/org/zaproxy/zap/OsXGui.java
index 4e1305c8ebb..e6f1348bdbe 100644
--- a/zap/src/main/java/org/zaproxy/zap/OsXGui.java
+++ b/zap/src/main/java/org/zaproxy/zap/OsXGui.java
@@ -22,6 +22,7 @@
import java.awt.Desktop;
import java.awt.Image;
im... | good | review_fixed | java | zaproxy/zaproxy | 5e88926d1a63d55f0121f9cc40c20f7fdc724218 |
@@ -2259,7 +2259,7 @@ params.table.header.values = Values
params.toolbar.site.label = Site:
params.toolbar.site.select = --Select Site--
params.type.cookie = Cookie
-params.type.form = FORM
+params.type.form = Form | bad | review | zaproxy/zaproxy | 1d6a45ff4aa811b7e17f02013d36afa9c1ef65f6 | |
diff --git a/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties b/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties
index 948ffe96301..48c7cd329c0 100644
--- a/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties
+++ b/zap/src/main/resources/org/zaproxy/zap/resources... | good | review_fixed | zaproxy/zaproxy | 1d6a45ff4aa811b7e17f02013d36afa9c1ef65f6 | |
@@ -106,11 +106,14 @@
// ZAP: 2022/09/21 Use format specifiers instead of concatenation when logging.
// ZAP: 2023/01/10 Tidy up logger.
// ZAP: 2023/05/17 Skip rules that reach the maximum number of alerts.
+// ZAP: 2026/05/28 From now on we will not be recording changes here as the files have changed so
+// much. | bad | review | java | zaproxy/zaproxy | a4e6bd594fe8bb2d371f0701b448316fcb8ec8f7 |
diff --git a/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java b/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java
index aeecba86efc..84b2ce19117 100644
--- a/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java
+++ b/zap/src/main/java/org/parosproxy/paros/core/scan... | good | review_fixed | java | zaproxy/zaproxy | a4e6bd594fe8bb2d371f0701b448316fcb8ec8f7 |
@@ -330,6 +333,16 @@ public void addStartNode(StructuralNode startNode) {
this.startNodes.add(startNode);
}
+ /**
+ * Gets the start nodes.
+ *
+ * @return the start nodes
+ * @since 2.18.0
+ */
+ public List<StructuralNode> getStartNodes() {
+ return Collections.unmodif... | bad | review | java | zaproxy/zaproxy | a4e6bd594fe8bb2d371f0701b448316fcb8ec8f7 |
diff --git a/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java b/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java
index aeecba86efc..84b2ce19117 100644
--- a/zap/src/main/java/org/parosproxy/paros/core/scanner/HostProcess.java
+++ b/zap/src/main/java/org/parosproxy/paros/core/scan... | good | review_fixed | java | zaproxy/zaproxy | a4e6bd594fe8bb2d371f0701b448316fcb8ec8f7 |
@@ -2901,9 +2901,9 @@ users.table.header.id = ID
users.table.header.name = Name
variant.options.excludedparam.dialog.token.add.button.confirm = Add
-variant.options.excludedparam.dialog.token.add.title = Add a parameter that needs to be excluded
+variant.options.excludedparam.dialog.token.add.title = Add a Paramete... | bad | review | zaproxy/zaproxy | 1d00e1e8b29f768e6fc1a71ed5a4f3b986e78668 | |
diff --git a/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties b/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties
index 27e83d872d2..948ffe96301 100644
--- a/zap/src/main/resources/org/zaproxy/zap/resources/Messages.properties
+++ b/zap/src/main/resources/org/zaproxy/zap/resources... | good | review_fixed | zaproxy/zaproxy | 1d00e1e8b29f768e6fc1a71ed5a4f3b986e78668 | |
@@ -9,3 +9,19 @@ updates:
applies-to: version-updates
patterns:
- "*"
+ - package-ecosystem: "gradle"
+ directory: "/"
+ exclude-paths:
+ - "buildSrc"
+ schedule:
+ interval: "weekly"
+ groups:
+ gradle:
+ applies-to: version-updates
+ patterns:
+ ... | bad | review | zaproxy/zaproxy | 54f82c5a54d54ccf95953ac58ab57bfb296085f4 | |
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 1b52049975f..e945d01abfb 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -9,3 +9,19 @@ updates:
applies-to: version-updates
patterns:
- "*"
+ - package-ecosystem: "gradle"
+ directory: "/"
+ exclude-... | good | review_fixed | zaproxy/zaproxy | 54f82c5a54d54ccf95953ac58ab57bfb296085f4 | |
@@ -50,9 +50,16 @@ public void flush() throws IOException {
@Override
public void close() throws IOException {
+ IOException first = null;
for (Writer writer : writers) {
- writer.close();
+ try {
+ writer.close();
+ } catch (IOException e) {
+... | bad | review | java | zaproxy/zaproxy | dfb0d168908218e344714695798845aaa295a1fe |
diff --git a/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java b/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java
index 394bf8358fa..70f97a11a87 100644
--- a/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java
+++ b/zap/src/main/java/org/zaproxy/zap/exten... | good | review_fixed | java | zaproxy/zaproxy | dfb0d168908218e344714695798845aaa295a1fe |
@@ -36,22 +36,58 @@ public class MultipleWriters extends Writer {
@Override
public void write(char[] cbuf, int off, int len) throws IOException {
String str = new String(cbuf, off, len);
+ IOException first = null;
for (Writer writer : writers) {
- writer.append(str);
+ ... | bad | review | java | zaproxy/zaproxy | dfb0d168908218e344714695798845aaa295a1fe |
diff --git a/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java b/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java
index 394bf8358fa..70f97a11a87 100644
--- a/zap/src/main/java/org/zaproxy/zap/extension/script/MultipleWriters.java
+++ b/zap/src/main/java/org/zaproxy/zap/exten... | good | review_fixed | java | zaproxy/zaproxy | dfb0d168908218e344714695798845aaa295a1fe |
@@ -32,7 +32,6 @@ and subject to their respective licenses.
| Library | License |
|-------------------------------------|---------------------------|
| commons-beanutils-1.11.0.jar | Apache 2.0 |
-| commons-codec-1.20.0.jar | Apache 2.0 ... | bad | review | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
diff --git a/LEGALNOTICE.md b/LEGALNOTICE.md
index ee05ff2a85c..2f8bfd62877 100644
--- a/LEGALNOTICE.md
+++ b/LEGALNOTICE.md
@@ -32,7 +32,6 @@ and subject to their respective licenses.
| Library | License |
|-------------------------------------|--------------------------... | good | review_fixed | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
@@ -24,7 +24,6 @@ tasks.withType<JavaCompile>().configureEach {
dependencies {
implementation("com.github.javaparser:javaparser-core:3.15.21")
implementation("com.github.zafarkhaja:java-semver:0.9.0")
- implementation("commons-codec:commons-codec:1.17.1") | bad | review | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
diff --git a/buildSrc/build.gradle.kts b/buildSrc/build.gradle.kts
index 16abd3db875..2ac59570ccb 100644
--- a/buildSrc/build.gradle.kts
+++ b/buildSrc/build.gradle.kts
@@ -24,7 +24,6 @@ tasks.withType<JavaCompile>().configureEach {
dependencies {
implementation("com.github.javaparser:javaparser-core:3.15.21")
... | good | review_fixed | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
@@ -227,14 +228,21 @@ private void appendChecksumsTable(StringBuilder body) throws IOException {
.collect(Collectors.toList());
for (File file : files) {
String fileName = file.getName();
- body.append("| [")
- .append(fileName)
- ... | bad | review | java | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 |
diff --git a/buildSrc/src/main/java/org/zaproxy/zap/tasks/CreateGitHubRelease.java b/buildSrc/src/main/java/org/zaproxy/zap/tasks/CreateGitHubRelease.java
index ff941c74305..b469c974096 100644
--- a/buildSrc/src/main/java/org/zaproxy/zap/tasks/CreateGitHubRelease.java
+++ b/buildSrc/src/main/java/org/zaproxy/zap/tasks/... | good | review_fixed | java | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 |
@@ -1703,7 +1702,50 @@ public URI(URI base, URI relative) throws URIException {
* @return URI character sequence
* @throws URIException null component or unsupported character encoding
*/
-
+ private static byte[] encodeUrl(BitSet urlsafe, byte[] bytes) { | bad | review | java | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 |
diff --git a/zap/src/main/java/org/apache/commons/httpclient/URI.java b/zap/src/main/java/org/apache/commons/httpclient/URI.java
index 27657b1fd48..f8363194f61 100644
--- a/zap/src/main/java/org/apache/commons/httpclient/URI.java
+++ b/zap/src/main/java/org/apache/commons/httpclient/URI.java
@@ -39,8 +39,7 @@
import j... | good | review_fixed | java | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 |
@@ -65,13 +65,19 @@ tasks.named<JacocoReport>("jacocoTestReport") {
spotless {
java {
- bumpThisNumberIfACustomStepChanges(1)
+ bumpThisNumberIfACustomStepChanges(2)
custom(
"validateImports",
ValidateImports(
mapOf(
"import ... | bad | review | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
diff --git a/zap/zap.gradle.kts b/zap/zap.gradle.kts
index 284781f2961..54aaf3a61b7 100644
--- a/zap/zap.gradle.kts
+++ b/zap/zap.gradle.kts
@@ -65,13 +65,19 @@ tasks.named<JacocoReport>("jacocoTestReport") {
spotless {
java {
- bumpThisNumberIfACustomStepChanges(1)
+ bumpThisNumberIfACustomStepCh... | good | review_fixed | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
@@ -90,7 +96,6 @@ dependencies {
api("com.fifesoft:rsyntaxtextarea:3.6.0")
api("com.github.zafarkhaja:java-semver:0.10.2")
implementation("commons-beanutils:commons-beanutils:1.11.0")
- api("commons-codec:commons-codec:1.20.0") | bad | review | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
diff --git a/zap/zap.gradle.kts b/zap/zap.gradle.kts
index 284781f2961..54aaf3a61b7 100644
--- a/zap/zap.gradle.kts
+++ b/zap/zap.gradle.kts
@@ -65,13 +65,19 @@ tasks.named<JacocoReport>("jacocoTestReport") {
spotless {
java {
- bumpThisNumberIfACustomStepChanges(1)
+ bumpThisNumberIfACustomStepCh... | good | review_fixed | zaproxy/zaproxy | ace1b87ba350463041029de68dfa9b72fa265865 | |
@@ -82,6 +82,7 @@ function responseReceived(msg, initiator, helper) {
"This may indicate that the application is failing to handle unexpected input correctly.\n" +
"Raised by the 'Alert on HTTP Response Code Error' script");
alert.setEvidence(code.toString())
+ alert.setReference("https://www.zaproxy.or... | bad | review | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | good | review_fixed | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
@@ -82,6 +82,7 @@ function responseReceived(msg, initiator, helper) {
"This may indicate that the application is failing to handle unexpected input correctly.\n" +
"Raised by the 'Alert on HTTP Response Code Error' script");
alert.setEvidence(code.toString())
+ alert.setAlertRef(pluginid + "-" + code) | bad | review | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | good | review_fixed | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-03-09
+- Fix duplicate alert references in "Alert on HTTP Response Code Errors" script. | bad | review | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | |
diff --git a/docker/CHANGELOG.md b/docker/CHANGELOG.md
index 2af08fccb2e..df977bfedb2 100644
--- a/docker/CHANGELOG.md
+++ b/docker/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
All notable changes to the docker containers will be documented in this file.
+### 2026-03-10
+- Use alert references in "Alert on HTTP Respons... | good | review_fixed | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 | |
@@ -82,6 +82,12 @@ function responseReceived(msg, initiator, helper) {
"This may indicate that the application is failing to handle unexpected input correctly.\n" +
"Raised by the 'Alert on HTTP Response Code Error' script");
alert.setEvidence(code.toString())
+ var alertRef = 1
+ if (code >= 500)
+ ... | bad | review | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | good | review_fixed | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
@@ -29,12 +29,16 @@ function responseReceived(msg, initiator, helper) {
// Do nothing
} else {
var risk = 0 // Info
+ var alertRef = 1
var title = "A Client Error response code was returned by the server"
+
if (code >= 500) {
// Server error
risk = 1 // Low
title = "A Server Error re... | bad | review | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
diff --git a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js b/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
index 10594bd1e01..d421b38ffb5 100644
--- a/docker/scripts/scripts/httpsender/Alert_on_HTTP_Response_Code_Errors.js
+++ b/docker/scripts/scripts/httpsender/Alert... | good | review_fixed | javascript | zaproxy/zaproxy | f6f3ebe6de5e34d043732e92be5c6410b29b6a36 |
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and its related class files.
+ *
+ * ZAP is an HTTP/HTTPS proxy for assessing web application security.
+ *
+ * Copyright 2026 The ZAP Development Team
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in complia... | bad | review | java | zaproxy/zaproxy | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 |
diff --git a/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
new file mode 100644
index 00000000000..f3d4b16700f
--- /dev/null
+++ b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and ... | good | review_fixed | java | zaproxy/zaproxy | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 |
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and its related class files.
+ *
+ * ZAP is an HTTP/HTTPS proxy for assessing web application security.
+ *
+ * Copyright 2026 The ZAP Development Team
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in complia... | bad | review | java | zaproxy/zaproxy | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 |
diff --git a/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
new file mode 100644
index 00000000000..f3d4b16700f
--- /dev/null
+++ b/zap/src/test/java/org/zaproxy/zap/ZapBootstrapUnitTest.java
@@ -0,0 +1,106 @@
+/*
+ * Zed Attack Proxy (ZAP) and ... | good | review_fixed | java | zaproxy/zaproxy | 2437ffd8dcfa4cd3c4a64045ece972f52e8e8e22 |
@@ -88,7 +88,7 @@ Scan rules:
10097 Hash Disclosure
10098 Cross-Domain Misconfiguration
10099 Source Code Disclosure
-
+10100 Web Cache Deception [script] | bad | review | zaproxy/zaproxy | 4fd075516f0d5e321dc82b6f50d275971f0491ce | |
diff --git a/docs/scanners.md b/docs/scanners.md
index aed6da1e10c..3ebc438ffec 100644
--- a/docs/scanners.md
+++ b/docs/scanners.md
@@ -272,6 +272,7 @@ Scan rules:
100043 Swagger Secret Disclosure and Vulnerable Version [Script]
100044 Suspicious Input Transformation [Script]
100045 Open MCP Server Detection [Sc... | good | review_fixed | zaproxy/zaproxy | 4fd075516f0d5e321dc82b6f50d275971f0491ce | |
@@ -620,7 +620,7 @@ impl State {
self.renaming_session_name = None;
should_render = true;
} else if !self.is_welcome_screen {
- hide_self();
+ close_self();
} | bad | review | rust | zellij-org/zellij | 729e7b2b89b8acffc336003cf8a9c3a5dc6666f5 |
diff --git a/default-plugins/session-manager/src/main.rs b/default-plugins/session-manager/src/main.rs
index afade742ed..849ae26370 100644
--- a/default-plugins/session-manager/src/main.rs
+++ b/default-plugins/session-manager/src/main.rs
@@ -607,7 +607,7 @@ impl State {
self.reset_selected_ind... | good | review_fixed | rust | zellij-org/zellij | 729e7b2b89b8acffc336003cf8a9c3a5dc6666f5 |
@@ -99,7 +99,9 @@ class ZenStartup {
this.promiseInitializedResolve();
delete this.promiseInitializedResolve;
- setTimeout(() => {
+ setTimeout(async () => {
+ // Avoid interleaving with the natural PlacesToolbar rebuild.
+ await document.getElementById("PlacesToolbar")?._placesV... | bad | review | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | good | review_fixed | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
@@ -100,7 +100,12 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeout(() => {
- gZenWorkspaces._invalidateBookmarkContainers();
+ // Avoid interleaving with the natural PlacesToolbar rebuild.
+ Promise.resolve( | bad | review | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | good | review_fixed | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
@@ -100,7 +100,12 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeout(() => {
- gZenWorkspaces._invalidateBookmarkContainers();
+ // Avoid interleaving with the natural PlacesToolbar rebuild.
+ Promise.resolve(
+ document.getElementById("PlacesToolbar")?... | bad | review | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | good | review_fixed | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
@@ -100,7 +100,12 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeout(() => {
- gZenWorkspaces._invalidateBookmarkContainers();
+ // Wait for the natural PlacesToolbar rebuild before invalidating, so
+ // the two async rebuilds don't interleave and duplicate book... | bad | review | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | good | review_fixed | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeout(() => {
- gZenWorkspaces._invalidateBookmarkContainers();
+ // Wait for the natural PlacesToolbar rebuild before invalidating, so
+ // the two async rebuilds don't interleave and duplicate book... | bad | review | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
diff --git a/src/zen/common/modules/ZenStartup.mjs b/src/zen/common/modules/ZenStartup.mjs
index 93e549f5634..307fa0dbfbc 100644
--- a/src/zen/common/modules/ZenStartup.mjs
+++ b/src/zen/common/modules/ZenStartup.mjs
@@ -100,7 +100,16 @@ class ZenStartup {
delete this.promiseInitializedResolve;
setTimeo... | good | review_fixed | javascript | zen-browser/desktop | 1a3210e8243270b64dd3809129b6bdd255c3f7e7 |
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+// A small threshold to allow for minor mouse jitter during a normal click.
+// Anything beyond this is likely an intentional drag (like selecting text).
+const CLICK_DRAG_THRESHOLD_PX = 4; | bad | review | javascript | zen-browser/desktop | 0769759f5403afe387355321c8dd16d5a8750519 |
diff --git a/src/zen/glance/actors/ZenGlanceChild.sys.mjs b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
index 10d9fff1408..f31b83e6115 100644
--- a/src/zen/glance/actors/ZenGlanceChild.sys.mjs
+++ b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+//... | good | review_fixed | javascript | zen-browser/desktop | 0769759f5403afe387355321c8dd16d5a8750519 |
@@ -121,9 +127,23 @@ export class ZenGlanceChild extends JSWindowActorChild {
// The problem is that at that stage we don't know the rect or even what
// element has been clicked, so we send the data here.
this.#sendClickDataToParent(node, event.target);
+
+ this.#mouseDownX = event.clientX;
+ this... | bad | review | javascript | zen-browser/desktop | 0769759f5403afe387355321c8dd16d5a8750519 |
diff --git a/src/zen/glance/actors/ZenGlanceChild.sys.mjs b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
index 10d9fff1408..f31b83e6115 100644
--- a/src/zen/glance/actors/ZenGlanceChild.sys.mjs
+++ b/src/zen/glance/actors/ZenGlanceChild.sys.mjs
@@ -17,8 +17,14 @@ XPCOMUtils.defineLazyPreferenceGetter(
true
);
+//... | good | review_fixed | javascript | zen-browser/desktop | 0769759f5403afe387355321c8dd16d5a8750519 |
@@ -138,7 +138,7 @@ index d6615ec5a29f3e3327ac4171f3fc5d9a69bd09fe..c166b7de23c35716bf8c51b6b9c72f77
+ if (this._zenHandleUrlbarClose) {
+ this._zenHandleUrlbarClose();
-+ } else if (!this._untrimmedValue || this.searchMode || this.window.gZenVerticalTabsManager._hasSetSingleToolbar) {
++ } else if (... | bad | review | zen-browser/desktop | a80244472da2ae2089f377d4557d5f4673ae1145 | |
diff --git a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
index 43314bcc02f..1b36d9852fd 100644
--- a/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
+++ b/src/browser/components/urlbar/content/UrlbarInput-mjs.patch
@@ -138,7 +138,... | good | review_fixed | zen-browser/desktop | a80244472da2ae2089f377d4557d5f4673ae1145 | |
@@ -2290,6 +2290,11 @@ class nsZenWorkspaces {
}
onBeforeTabSelect(aTab) {
+ if (this.#inChangingWorkspace) {
+ // Just in case, Let's not do these checks while we are
+ // in the middle of changing workspace, | bad | review | javascript | zen-browser/desktop | 8f92c59fdbc10306b61a34175d78132821cbcd16 |
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index 5f2f403f1ee..928d634dcba 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -2290,6 +2290,11 @@ class nsZenWorkspaces {
}
onBeforeTabSelect(aTab) {
+ if (this.#inChangingWorkspa... | good | review_fixed | javascript | zen-browser/desktop | 8f92c59fdbc10306b61a34175d78132821cbcd16 |
@@ -2297,8 +2297,14 @@ class nsZenWorkspaces {
!aTab.hasAttribute("zen-empty-tab") &&
!aTab.hasAttribute("zen-essential")
) {
- this.changeWorkspaceWithID(tabSpace);
+ this.changeWorkspaceWithID(tabSpace)
+ .catch(console.error)
+ .then(() => {
+ gBrowser.selectedTab ... | bad | review | javascript | zen-browser/desktop | 7804021f094892dc2e189b0cef06279043580203 |
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index cfb60c004ca..5f2f403f1ee 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -2297,8 +2297,14 @@ class nsZenWorkspaces {
!aTab.hasAttribute("zen-empty-tab") &&
!aTab.hasAttrib... | good | review_fixed | javascript | zen-browser/desktop | 7804021f094892dc2e189b0cef06279043580203 |
@@ -227,6 +239,10 @@ export class nsZenBoostEditor {
editor.refresh();
editor.on("change", this.onCodeEditorChange.bind(this));
+ const editorEl =
+ container.querySelector("iframe").contentDocument.documentElement;
+ editorEl.className = "theme-" + this.isDarkMode ? "dark" : "light";
+ | bad | review | javascript | zen-browser/desktop | aabdf574fa797fca712769b9f65d7294f15b1099 |
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 2b224690c82..b74964fca48 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -59,6 +59,18 @@ export class nsZenBoostEditor {
this.loadBoost(domain);
}
+ /**
+ * Returns the Zen... | good | review_fixed | javascript | zen-browser/desktop | aabdf574fa797fca712769b9f65d7294f15b1099 |
@@ -649,6 +649,12 @@ ${cssSelector} {
this.currentBoostData.sizeOverride = 0.9;
} else if (this.currentBoostData.sizeOverride == 0.9) {
this.currentBoostData.sizeOverride = 1;
+
+ const linkedBrowser =
+ this.openerWindow.gBrowser.selectedTab.linkedBrowser;
+ const actor =
+ l... | bad | review | javascript | zen-browser/desktop | c0877391da7a4cdbea7963bcd358e5e17e437eb0 |
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs
index 7254ac3fdad..2b224690c82 100644
--- a/src/zen/boosts/ZenBoostsEditor.mjs
+++ b/src/zen/boosts/ZenBoostsEditor.mjs
@@ -638,7 +638,7 @@ ${cssSelector} {
/**
* Handles the size toggle button press, cycling through size overri... | good | review_fixed | javascript | zen-browser/desktop | c0877391da7a4cdbea7963bcd358e5e17e437eb0 |
@@ -41,6 +41,7 @@
fill-opacity: 0.6;
-moz-context-properties: fill-opacity, fill;
fill: currentColor;
+ scroll-margin: 0 20px; | bad | review | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | |
diff --git a/src/zen/spaces/zen-workspaces.css b/src/zen/spaces/zen-workspaces.css
index d9fa560af46..f5d7e91a9f9 100644
--- a/src/zen/spaces/zen-workspaces.css
+++ b/src/zen/spaces/zen-workspaces.css
@@ -20,7 +20,6 @@
display: none !important;
}
- border-radius: var(--button-border-radius) !important;
ba... | good | review_fixed | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | |
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventListener("mouseover", e => {
- if (this.isReorderMode) {
+ if (e.shiftKey || this.isReorderMode) {
return;
}
const target = e.target.closest("toolbarbutton[zen-workspac... | bad | review | javascript | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 |
diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs
index a15bcc083eb..b8bfb67440e 100644
--- a/src/zen/spaces/ZenSpaceIcons.mjs
+++ b/src/zen/spaces/ZenSpaceIcons.mjs
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventList... | good | review_fixed | javascript | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 |
@@ -178,7 +178,7 @@ class nsZenWorkspaceIcons extends MozXULElement {
return;
}
buttons[selected].setAttribute("active", true);
- this.scrollLeft = buttons[selected].offsetLeft - 10;
+ buttons[selected].scrollIntoView({ behavior: "smooth", inline: "nearest" }); | bad | review | javascript | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 |
diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs
index a15bcc083eb..b8bfb67440e 100644
--- a/src/zen/spaces/ZenSpaceIcons.mjs
+++ b/src/zen/spaces/ZenSpaceIcons.mjs
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventList... | good | review_fixed | javascript | zen-browser/desktop | c7f5634bd1c899b65209d06db4deefab0b8f2de5 |
@@ -17,16 +17,6 @@ disable = [
source = "browser/components/safebrowsing/content/test"
is_direct_path = true
-[sandbox]
-source = "security/sandbox/test"
-is_direct_path = true
-disable = [
- "browser_bug1393259.js",
-]
-
-[sandbox.replace-manifest]
-"../../../" = "../../../../"
-
[shell] | bad | review | zen-browser/desktop | 442ea54faca95640e44dd1292201a9f13f3b914d | |
diff --git a/src/zen/tests/manifest.toml b/src/zen/tests/manifest.toml
index fa3d7c84ff1..c3f44415712 100644
--- a/src/zen/tests/manifest.toml
+++ b/src/zen/tests/manifest.toml
@@ -17,16 +17,6 @@ disable = [
source = "browser/components/safebrowsing/content/test"
is_direct_path = true
-[sandbox]
-source = "security... | good | review_fixed | zen-browser/desktop | 442ea54faca95640e44dd1292201a9f13f3b914d | |
@@ -10,7 +10,6 @@
BROWSER_CHROME_MANIFESTS += [
"readermode/browser.toml",
"safebrowsing/browser.toml",
- "sandbox/browser.toml",
"shell/browser.toml",
"tabMediaIndicator/browser.toml", | bad | review | zen-browser/desktop | 442ea54faca95640e44dd1292201a9f13f3b914d | |
diff --git a/src/zen/tests/mochitests/moz.build b/src/zen/tests/mochitests/moz.build
index 9aed50afd40..bbf85269c1e 100644
--- a/src/zen/tests/mochitests/moz.build
+++ b/src/zen/tests/mochitests/moz.build
@@ -10,7 +10,6 @@
BROWSER_CHROME_MANIFESTS += [
"readermode/browser.toml",
"safebrowsing/browser.toml",
- "san... | good | review_fixed | zen-browser/desktop | 442ea54faca95640e44dd1292201a9f13f3b914d | |
@@ -389,9 +389,14 @@ class nsZenSpaceRoutingManager {
}
/**
- * Saves all routes
+ * Saves all routes. The list of
+ * routes is stripped of empty routes
+ * before being saved
*/
saveRoutes() {
+ this.#file.data.routes = this.#file.data.routes.filter(
+ route => route.reference.trim() !=... | bad | review | javascript | zen-browser/desktop | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a |
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index e9cf24438eb..8454fb48887 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -389,9 +389,14 @@ class nsZenSpaceRoutin... | good | review_fixed | javascript | zen-browser/desktop | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a |
@@ -389,9 +389,14 @@ class nsZenSpaceRoutingManager {
}
/**
- * Saves all routes
+ * Saves all routes. The list of
+ * routes is stripped of empty routes
+ * before being saved
*/
saveRoutes() {
+ this.#file.data.routes = this.#file.data.routes.filter(
+ route => route.reference.trim() !=... | bad | review | javascript | zen-browser/desktop | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a |
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index e9cf24438eb..8454fb48887 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -389,9 +389,14 @@ class nsZenSpaceRoutin... | good | review_fixed | javascript | zen-browser/desktop | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a |
@@ -1049,6 +1050,7 @@ var gZenCKSSettings = {
input.classList.remove(`${ZEN_CKS_INPUT_FIELD_CLASS}-not-set`);
input.classList.remove(`${ZEN_CKS_INPUT_FIELD_CLASS}-editing`);
this._latestValidKey = null;
+ this._currentActionID = null; | bad | review | javascript | zen-browser/desktop | d83572ac6b33dca2795a654dd5cc5ec9179f126f |
diff --git a/src/browser/components/preferences/zen-settings.js b/src/browser/components/preferences/zen-settings.js
index 288b342d63e..c048ecffaf7 100644
--- a/src/browser/components/preferences/zen-settings.js
+++ b/src/browser/components/preferences/zen-settings.js
@@ -945,6 +945,7 @@ var gZenCKSSettings = {
... | good | review_fixed | javascript | zen-browser/desktop | d83572ac6b33dca2795a654dd5cc5ec9179f126f |
@@ -1010,6 +1010,14 @@ class nsZenWorkspaces {
return null;
}
+ // Closing a glance tab tears down the overlay and restores selection
+ // to its parent tab. Don't run the last-tab handling here:
+ // in a pinned-only window the glance child is the only unpinned tab,
+ // so this would switch ... | bad | review | javascript | zen-browser/desktop | 9da0f4595dab54066b24e1e20e5f5e2d98bf8f5f |
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index 43dcb6dda6a..caeee405fc0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1010,6 +1010,14 @@ class nsZenWorkspaces {
return null;
}
+ // Closing a glance tab tears down... | good | review_fixed | javascript | zen-browser/desktop | 9da0f4595dab54066b24e1e20e5f5e2d98bf8f5f |
@@ -2282,6 +2281,13 @@ class nsZenWorkspaces {
);
}
+ onBeforeTabSelect(aTab) {
+ const tabSpace = aTab?.getAttribute("zen-workspace-id");
+ if (tabSpace && tabSpace !== this.activeWorkspace) {
+ this.changeWorkspaceWithID(tabSpace);
+ }
+ } | bad | review | javascript | zen-browser/desktop | 3692a5047f9fcc46b6051d738be3587c15e82747 |
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index b75733b8109..43dcb6dda6a 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1498,7 +1498,6 @@ class nsZenWorkspaces {
continue;
}
- tab.owner = null;
if (con... | good | review_fixed | javascript | zen-browser/desktop | 3692a5047f9fcc46b6051d738be3587c15e82747 |
@@ -94,3 +94,8 @@
# See gh-12985 for details on the following preferences
- name: browser.search.widget.new
value: true
+
+# Disable from https://searchfox.org/firefox-main/rev/d6bfff43852356ca98af848b4705d37f8d41856f/modules/libpref/init/StaticPrefList.yaml#2008
+# Only enabled for windows, doesn't really fit ins... | bad | review | zen-browser/desktop | 3692a5047f9fcc46b6051d738be3587c15e82747 | |
diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml
index 341577cac76..4545795c628 100644
--- a/prefs/firefox/browser.yaml
+++ b/prefs/firefox/browser.yaml
@@ -94,3 +94,8 @@
# See gh-12985 for details on the following preferences
- name: browser.search.widget.new
value: true
+
+# Disabled from htt... | good | review_fixed | zen-browser/desktop | 3692a5047f9fcc46b6051d738be3587c15e82747 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.