text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,32 @@ +# SPDX-FileCopyrightText: <text>Copyright (c) 2026 Infineon Technologies AG, +# or an affiliate of Infineon Technologies AG. All rights reserved.</text> +# +# SPDX-License-Identifier: Apache-2.0 + +sample: + name: AutAnalog ADC FIR+FIFO sample +common: + tags: + - adc + depends_on:
bad
review
zephyrproject-rtos/zephyr
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/samples/boards/infineon/autanalog/fir_fifo/sample.yaml b/samples/boards/infineon/autanalog/fir_fifo/sample.yaml new file mode 100644 index 0000000000000..c6984dc740937 --- /dev/null +++ b/samples/boards/infineon/autanalog/fir_fifo/sample.yaml @@ -0,0 +1,30 @@ +# SPDX-FileCopyrightText: <text>Copyright (c) ...
good
review_fixed
zephyrproject-rtos/zephyr
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
@@ -0,0 +1,9 @@ +.. SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors +.. SPDX-License-Identifier: Apache-2.0 + +.. zephyr:code-sample-category:: infineon + :name: Infineon + :show-listing: + :glob: **/* + + These samples showcase board-specific Infineon features in Zephyr.
bad
review
zephyrproject-rtos/zephyr
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/samples/boards/infineon/index.rst b/samples/boards/infineon/index.rst new file mode 100644 index 0000000000000..957efc1a8054a --- /dev/null +++ b/samples/boards/infineon/index.rst @@ -0,0 +1,9 @@ +.. SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors +.. SPDX-License-Identifier: Apache-2.0 +...
good
review_fixed
zephyrproject-rtos/zephyr
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct device *dev, *layout_size = stm32_flash_layout_size; } + +int flash_stm32_option_bytes_write(const struct device *dev, uint32_t mask, uint32_t value) +{ + FLASH_TypeDef *regs = FLASH_STM32_REGS(dev); + int rc; + + if (regs->NSCR & FLASH_NSCR_OPTLOCK) {...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct device *dev, *layout_size = stm32_flash_layout_size; } + +int flash_stm32_option_bytes_write(const struct device *dev, uint32_t mask, uint32_t value) +{ + FLASH_TypeDef *regs = FLASH_STM32_REGS(dev); + int rc; + + if (regs->NSCR & FLASH_NSCR_OPTLOCK) {...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -335,7 +335,8 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM32F7_FLASH_CONTROLLER_ENABLED) || \ defined(CONFIG_DT_HAS_ST_STM32G0_FLASH_CONTROLLER_ENABLED) || \ defined(CONFIG_DT_HAS_ST_STM32G4_FLASH_CONTROLLER_ENABLED) || \ - defined(CONFIG_DT_HAS_ST_STM32L4_...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct device *dev, *layout_size = stm32_flash_layout_size; } + +int flash_stm32_option_bytes_write(const struct device *dev, uint32_t mask, uint32_t value) +{ + FLASH_TypeDef *regs = FLASH_STM32_REGS(dev); + int rc; + + if (regs->NSCR & FLASH_NSCR_OPTLOCK) {
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -382,3 +358,43 @@ void flash_stm32_page_layout(const struct device *dev, *layout_size = stm32_flash_layout_size; } + +#if defined(CONFIG_SOC_SERIES_STM32L5X) || defined(CONFIG_SOC_SERIES_STM32U5X) +int flash_stm32_option_bytes_write(const struct device *dev, uint32_t mask, uint32_t value) +{ + FLASH_TypeDef *re...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM32G0_FLASH_CONTROLLER_ENABLED) || \ defined(CONFIG_DT_HAS_ST_STM32G4_FLASH_CONTROLLER_ENABLED) || \ defined(CONFIG_DT_HAS_ST_STM32L4_FLASH_CONTROLLER_ENABLED) || \ - defined(CONFIG_DT_HAS_ST_STM32U3...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -382,3 +358,43 @@ void flash_stm32_page_layout(const struct device *dev, *layout_size = stm32_flash_layout_size; } + +#if defined(CONFIG_SOC_SERIES_STM32L5X) || defined(CONFIG_SOC_SERIES_STM32U5X) +int flash_stm32_option_bytes_write(const struct device *dev, uint32_t mask, uint32_t value) +{ + FLASH_TypeDef *re...
bad
review
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
@@ -109,7 +109,7 @@ struct mpl_search { /** Half playback speed, resulting in 50 % speed */ #define MEDIA_PROXY_PLAYBACK_SPEED_HALF -64 /** Unity playback speed, resulting in 100 % speed */ -#define MEDIA_PROXY_PLAYBACK_SPEED_UNITY 0 +#define MEDIA_PROXY_PLAYBACK_SPEED_UNITY 0U
bad
review
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
diff --git a/include/zephyr/bluetooth/audio/media_proxy.h b/include/zephyr/bluetooth/audio/media_proxy.h index d4c28433c2e32..06b2e978be29d 100644 --- a/include/zephyr/bluetooth/audio/media_proxy.h +++ b/include/zephyr/bluetooth/audio/media_proxy.h @@ -137,25 +137,25 @@ struct mpl_search { * @{ */ /** A single tra...
good
review_fixed
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
@@ -1401,7 +1401,7 @@ static void ase_init(struct bt_ascs_ase *ase, struct bt_conn *conn, uint8_t id) ase->conn = bt_conn_ref(conn); /* Lookup ASE characteristic */ - bt_gatt_foreach_attr_type(0x0001, 0xffff, ASE_UUID(id), NULL, 0, ase_attr_cb, ase); + bt_gatt_foreach_attr_type(0x0001U, 0xffffU, ASE_UUID(id), NUL...
bad
review
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
diff --git a/subsys/bluetooth/audio/ascs.c b/subsys/bluetooth/audio/ascs.c index eff7235c95c0d..80804e8d5bcae 100644 --- a/subsys/bluetooth/audio/ascs.c +++ b/subsys/bluetooth/audio/ascs.c @@ -758,7 +758,7 @@ static int ascs_iso_accept(const struct bt_iso_accept_info *info, struct bt_iso_ { LOG_DBG("conn %p", (void ...
good
review_fixed
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
@@ -21,13 +21,13 @@ #include <zephyr/sys/atomic.h> /* VCS opcodes */ -#define BT_VCP_OPCODE_REL_VOL_DOWN 0x00 -#define BT_VCP_OPCODE_REL_VOL_UP 0x01 -#define BT_VCP_OPCODE_UNMUTE_REL_VOL_DOWN 0x02 -#define BT_VCP_OPCODE_UNMUTE_REL_VOL_UP 0x03...
bad
review
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
diff --git a/subsys/bluetooth/audio/vcp_internal.h b/subsys/bluetooth/audio/vcp_internal.h index f28c65626c258..a3a6d755a3133 100644 --- a/subsys/bluetooth/audio/vcp_internal.h +++ b/subsys/bluetooth/audio/vcp_internal.h @@ -21,13 +21,13 @@ #include <zephyr/sys/atomic.h> /* VCS opcodes */ -#define BT_VCP_OPCODE_REL...
good
review_fixed
c
zephyrproject-rtos/zephyr
e0c80c5ddee84ce1354165e2c02562fb4f1e11c5
@@ -984,13 +984,19 @@ static bool unicast_client_ep_qos_state(struct bt_bap_ep *ep, struct net_buf_sim ep->receiver_ready = false; if (buf->len < sizeof(*qos)) { - LOG_ERR("QoS status too short"); + LOG_DBG("QoS status too short"); return false; } stream = ep->stream; if (stream == NULL) { - LOG_ERR...
bad
review
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
diff --git a/subsys/bluetooth/audio/bap_unicast_client.c b/subsys/bluetooth/audio/bap_unicast_client.c index d4e6d992d2445..f3680ea5a6632 100644 --- a/subsys/bluetooth/audio/bap_unicast_client.c +++ b/subsys/bluetooth/audio/bap_unicast_client.c @@ -984,13 +984,18 @@ static bool unicast_client_ep_qos_state(struct bt_bap...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
@@ -984,13 +984,18 @@ static bool unicast_client_ep_qos_state(struct bt_bap_ep *ep, struct net_buf_sim ep->receiver_ready = false; if (buf->len < sizeof(*qos)) { - LOG_ERR("QoS status too short"); + LOG_DBG("QoS status too short"); return false;
bad
review
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
diff --git a/subsys/bluetooth/audio/bap_unicast_client.c b/subsys/bluetooth/audio/bap_unicast_client.c index d4e6d992d2445..f3680ea5a6632 100644 --- a/subsys/bluetooth/audio/bap_unicast_client.c +++ b/subsys/bluetooth/audio/bap_unicast_client.c @@ -984,13 +984,18 @@ static bool unicast_client_ep_qos_state(struct bt_bap...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
@@ -984,13 +984,18 @@ static bool unicast_client_ep_qos_state(struct bt_bap_ep *ep, struct net_buf_sim ep->receiver_ready = false; if (buf->len < sizeof(*qos)) { - LOG_ERR("QoS status too short"); + LOG_DBG("QoS status too short"); return false; } stream = ep->stream; if (stream == NULL) { - LOG_ERR...
bad
review
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
diff --git a/subsys/bluetooth/audio/bap_unicast_client.c b/subsys/bluetooth/audio/bap_unicast_client.c index d4e6d992d2445..f3680ea5a6632 100644 --- a/subsys/bluetooth/audio/bap_unicast_client.c +++ b/subsys/bluetooth/audio/bap_unicast_client.c @@ -984,13 +984,18 @@ static bool unicast_client_ep_qos_state(struct bt_bap...
good
review_fixed
c
zephyrproject-rtos/zephyr
e5856499f162d09029c025ddd0f0973d09154e85
@@ -0,0 +1,756 @@ +//! The agent turn engine, decomposed into single-purpose step modules. +//! +//! Public paths are unchanged: external code keeps importing via +//! `crate::agent::loop_::*` (re-export block there). Full contract manifest: +//! `/opt/notes/work/zeroclaw/unification_modular/RUN_SHEET.md` (condensed +/...
bad
review
rust
zeroclaw-labs/zeroclaw
bef597a39e765e1b30b05452074a90a3a11eac91
diff --git a/crates/zeroclaw-runtime/src/agent/turn/mod.rs b/crates/zeroclaw-runtime/src/agent/turn/mod.rs new file mode 100644 index 00000000000..630335eb688 --- /dev/null +++ b/crates/zeroclaw-runtime/src/agent/turn/mod.rs @@ -0,0 +1,756 @@ +//! The agent turn engine, decomposed into single-purpose step modules. +//!...
good
review_fixed
rust
zeroclaw-labs/zeroclaw
bef597a39e765e1b30b05452074a90a3a11eac91
@@ -0,0 +1,16 @@ +//! Mid-turn steering: non-blocking drain of caller-pushed messages between
bad
review
rust
zeroclaw-labs/zeroclaw
bef597a39e765e1b30b05452074a90a3a11eac91
diff --git a/crates/zeroclaw-runtime/src/agent/turn/steering.rs b/crates/zeroclaw-runtime/src/agent/turn/steering.rs new file mode 100644 index 00000000000..f4ae519617d --- /dev/null +++ b/crates/zeroclaw-runtime/src/agent/turn/steering.rs @@ -0,0 +1,16 @@ +//! Mid-turn steering: non-blocking drain of caller-pushed mes...
good
review_fixed
rust
zeroclaw-labs/zeroclaw
bef597a39e765e1b30b05452074a90a3a11eac91
@@ -20,10 +21,18 @@ type mcpServerImpl struct { conf McpConf httpServer *rest.Server mcpServer *sdkmcp.Server + options serverOptions } // NewMcpServer creates a new MCP server using the official SDK -func NewMcpServer(c McpConf) McpServer { +func NewMcpServer(c McpConf, opts ...McpOption) McpServer...
bad
review
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
diff --git a/mcp/server.go b/mcp/server.go index fe7e1e8c0ae1..32a10ddc7762 100644 --- a/mcp/server.go +++ b/mcp/server.go @@ -1,6 +1,7 @@ package mcp import ( + "context" "net/http" sdkmcp "github.com/modelcontextprotocol/go-sdk/mcp" @@ -20,10 +21,23 @@ type mcpServerImpl struct { conf McpConf http...
good
review_fixed
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
@@ -0,0 +1,127 @@ +package mcp + +import ( + "context" + "net/http" + + "github.com/zeromicro/go-zero/rest/pathvar" +) + +// RequestMetadata carries selected request-scoped values into MCP handlers. +type RequestMetadata struct { + Headers map[string][]string + Query map[string][]string + Path map[string]string +}...
bad
review
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
diff --git a/mcp/request_metadata.go b/mcp/request_metadata.go new file mode 100644 index 000000000000..eeb1a48ca863 --- /dev/null +++ b/mcp/request_metadata.go @@ -0,0 +1,150 @@ +package mcp + +import ( + "context" + "net/http" + + "github.com/zeromicro/go-zero/rest/pathvar" +) + +// RequestMetadata carries selected r...
good
review_fixed
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
@@ -391,3 +393,102 @@ func TestAddToolWithCustomServer(t *testing.T) { return nil, nil, nil }) } + +func TestRequestMetadataIntegrationSSEToolCall(t *testing.T) { + c := McpConf{} + c.Host = "127.0.0.1" + c.Port = 19082 + c.Mcp.Name = "metadata-integration-test" + c.Mcp.UseStreamable = false + c.Mcp.SseEndpoint =...
bad
review
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
diff --git a/mcp/server_test.go b/mcp/server_test.go index 171d07fe62b1..37870b4c812e 100644 --- a/mcp/server_test.go +++ b/mcp/server_test.go @@ -3,11 +3,14 @@ package mcp import ( "bytes" "context" + "fmt" + "net" "net/http" "net/http/httptest" "testing" "time" + sdkmcp "github.com/modelcontextprotocol...
good
review_fixed
go
zeromicro/go-zero
89720f60120a93c9bb2f28fb9c8839b2ff7c6200
@@ -17,3 +17,15 @@ func GetAuthority(target resolver.Target) string { func GetEndpoints(target resolver.Target) string { return strings.Trim(target.URL.Path, slashSeparator) } + +// GetHosts returns the comma-separated etcd hosts from the target URL path. +// Used for etcd/discov targets where hosts are encoded in ...
bad
review
go
zeromicro/go-zero
e6d974f62e591c36dd06878295cbab26be10ab36
diff --git a/zrpc/resolver/internal/targets/endpoints.go b/zrpc/resolver/internal/targets/endpoints.go index 2685f6d2be14..3cd02c5e2bb0 100644 --- a/zrpc/resolver/internal/targets/endpoints.go +++ b/zrpc/resolver/internal/targets/endpoints.go @@ -17,3 +17,29 @@ func GetAuthority(target resolver.Target) string { func G...
good
review_fixed
go
zeromicro/go-zero
e6d974f62e591c36dd06878295cbab26be10ab36
@@ -17,3 +17,15 @@ func GetAuthority(target resolver.Target) string { func GetEndpoints(target resolver.Target) string { return strings.Trim(target.URL.Path, slashSeparator) } + +// GetHosts returns the comma-separated etcd hosts from the target URL path. +// Used for etcd/discov targets where hosts are encoded in ...
bad
review
go
zeromicro/go-zero
e6d974f62e591c36dd06878295cbab26be10ab36
diff --git a/zrpc/resolver/internal/targets/endpoints.go b/zrpc/resolver/internal/targets/endpoints.go index 2685f6d2be14..3cd02c5e2bb0 100644 --- a/zrpc/resolver/internal/targets/endpoints.go +++ b/zrpc/resolver/internal/targets/endpoints.go @@ -17,3 +17,29 @@ func GetAuthority(target resolver.Target) string { func G...
good
review_fixed
go
zeromicro/go-zero
e6d974f62e591c36dd06878295cbab26be10ab36
@@ -84,8 +84,11 @@ func buildRequest(ctx context.Context, method, url string, data any) (*http.Requ var reader io.Reader jsonVars, hasJsonBody := val[jsonKey] if hasJsonBody { - if method == http.MethodGet { + switch method { + case http.MethodGet: return nil, ErrGetWithBody + case http.MethodHead: + re...
bad
review
go
zeromicro/go-zero
4679756c9f35d7bb1df85f725b448a6a5e77e500
diff --git a/rest/httpc/requests.go b/rest/httpc/requests.go index 3692eaae03fa..5dd8fb12aa00 100644 --- a/rest/httpc/requests.go +++ b/rest/httpc/requests.go @@ -84,8 +84,11 @@ func buildRequest(ctx context.Context, method, url string, data any) (*http.Requ var reader io.Reader jsonVars, hasJsonBody := val[jsonKey...
good
review_fixed
go
zeromicro/go-zero
4679756c9f35d7bb1df85f725b448a6a5e77e500
@@ -1,8 +1,194 @@ package parser -import "github.com/emicklei/proto" +import ( + "fmt" + "os" + "path/filepath" + "strings" + + "github.com/emicklei/proto" +) // Import embeds proto.Import type Import struct { *proto.Import } + +// ImportedProto holds the package information of a transitively imported proto f...
bad
review
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
diff --git a/tools/goctl/rpc/parser/import.go b/tools/goctl/rpc/parser/import.go index bb9591f56949..bd53f095ac3d 100644 --- a/tools/goctl/rpc/parser/import.go +++ b/tools/goctl/rpc/parser/import.go @@ -1,8 +1,194 @@ package parser -import "github.com/emicklei/proto" +import ( + "fmt" + "os" + "path/filepath" + "str...
good
review_fixed
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
@@ -159,3 +166,29 @@ func (g *Generator) genLogicFunction(serviceName, goPackage, logicName string, functions = append(functions, buffer.String()) return strings.Join(functions, pathx.NL), nil } + +// addLogicImports adds the correct import paths to imports for a single RPC's +// logic file. The main pb package is...
bad
review
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
diff --git a/tools/goctl/rpc/generator/genlogic.go b/tools/goctl/rpc/generator/genlogic.go index 4a51d4fb7340..b2e65ee4437e 100644 --- a/tools/goctl/rpc/generator/genlogic.go +++ b/tools/goctl/rpc/generator/genlogic.go @@ -40,6 +40,7 @@ func (g *Generator) genLogicInCompatibility(ctx DirContext, proto parser.Proto, c...
good
review_fixed
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
@@ -290,3 +326,18 @@ func (g *Generator) getInterfaceFuncs(goPackage string, service parser.Service, return functions, nil } + +// buildExtraImportLines converts a set of import paths into quoted import lines +// for use in the call.tpl {{.extraImports}} placeholder. +func buildExtraImportLines(extraImports *colle...
bad
review
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
diff --git a/tools/goctl/rpc/generator/gencall.go b/tools/goctl/rpc/generator/gencall.go index 8381ad065d77..5a7bc3a8efc4 100644 --- a/tools/goctl/rpc/generator/gencall.go +++ b/tools/goctl/rpc/generator/gencall.go @@ -47,6 +47,7 @@ func (g *Generator) GenCall(ctx DirContext, proto parser.Proto, cfg *conf.Config func ...
good
review_fixed
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
@@ -0,0 +1,115 @@ +package generator + +import ( + "fmt" + "strings" + + "github.com/zeromicro/go-zero/tools/goctl/rpc/parser" +) + +// rpcTypeRef holds the resolved Go type reference for an RPC request/response type. +type rpcTypeRef struct { + // GoRef is the qualified Go type name, e.g. "pb.GetReq", "common.TypesReq...
bad
review
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
diff --git a/tools/goctl/rpc/generator/typeref.go b/tools/goctl/rpc/generator/typeref.go new file mode 100644 index 000000000000..453972702cd7 --- /dev/null +++ b/tools/goctl/rpc/generator/typeref.go @@ -0,0 +1,115 @@ +package generator + +import ( + "fmt" + "strings" + + "github.com/zeromicro/go-zero/tools/goctl/rpc/p...
good
review_fixed
go
zeromicro/go-zero
bfe63a7a6939df5ea5a7ad122a186cb6ab734ebe
@@ -92,6 +92,24 @@ func TestFilter(t *testing.T) { } } +func BenchmarkFilter(b *testing.B) { + b.Run("true", func(b *testing.B) { + b.ResetTimer() + b.ReportAllocs() + for i := 0; i < b.N; i++ { + Filter(`ab,cd,ef`, func(r rune) bool { return r == ',' }) + }
bad
review
go
zeromicro/go-zero
db6140049965ae307671dc959154a5ee851ec0e4
diff --git a/core/stringx/strings_test.go b/core/stringx/strings_test.go index 3fb3e7bcec1e..b4681fe5c592 100644 --- a/core/stringx/strings_test.go +++ b/core/stringx/strings_test.go @@ -92,6 +92,24 @@ func TestFilter(t *testing.T) { } } +func BenchmarkFilter(b *testing.B) { + b.Run("true", func(b *testing.B) { + ...
good
review_fixed
go
zeromicro/go-zero
db6140049965ae307671dc959154a5ee851ec0e4
@@ -21,20 +22,14 @@ func Contains(list []string, str string) bool { return slices.Contains(list, str) } -// Filter filters chars from s with given filter function. -func Filter(s string, filter func(r rune) bool) string { - var n int - chars := []rune(s) - for i, x := range chars { - if n < i { - chars[n] = x +...
bad
review
go
zeromicro/go-zero
db6140049965ae307671dc959154a5ee851ec0e4
diff --git a/core/stringx/strings.go b/core/stringx/strings.go index 5a9554a7b752..dadf2c52c157 100644 --- a/core/stringx/strings.go +++ b/core/stringx/strings.go @@ -3,6 +3,7 @@ package stringx import ( "errors" "slices" + "strings" "unicode" "github.com/zeromicro/go-zero/core/lang" @@ -21,20 +22,14 @@ func...
good
review_fixed
go
zeromicro/go-zero
db6140049965ae307671dc959154a5ee851ec0e4
@@ -0,0 +1,125 @@ +package generator + +import ( + "os" + "path/filepath" + "strings" + "testing" + + "github.com/emicklei/proto" + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" + conf "github.com/zeromicro/go-zero/tools/goctl/config" + "github.com/zeromicro/go-zero/tools/goctl/rpc/parser...
bad
review
go
zeromicro/go-zero
6e648b3add274e70a56443089a854278f40850ba
diff --git a/tools/goctl/rpc/generator/gencall_test.go b/tools/goctl/rpc/generator/gencall_test.go new file mode 100644 index 000000000000..deb773a287cb --- /dev/null +++ b/tools/goctl/rpc/generator/gencall_test.go @@ -0,0 +1,125 @@ +package generator + +import ( + "os" + "path/filepath" + "strings" + "testing" + + "gi...
good
review_fixed
go
zeromicro/go-zero
6e648b3add274e70a56443089a854278f40850ba
@@ -0,0 +1,125 @@ +package generator + +import ( + "os" + "path/filepath" + "strings" + "testing" + + "github.com/emicklei/proto" + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" + conf "github.com/zeromicro/go-zero/tools/goctl/config" + "github.com/zeromicro/go-zero/tools/goctl/rpc/parser...
bad
review
go
zeromicro/go-zero
6e648b3add274e70a56443089a854278f40850ba
diff --git a/tools/goctl/rpc/generator/gencall_test.go b/tools/goctl/rpc/generator/gencall_test.go new file mode 100644 index 000000000000..deb773a287cb --- /dev/null +++ b/tools/goctl/rpc/generator/gencall_test.go @@ -0,0 +1,125 @@ +package generator + +import ( + "os" + "path/filepath" + "strings" + "testing" + + "gi...
good
review_fixed
go
zeromicro/go-zero
6e648b3add274e70a56443089a854278f40850ba
@@ -96,6 +96,7 @@ require ( github.com/prometheus/procfs v0.16.1 // indirect github.com/rivo/uniseg v0.2.0 // indirect github.com/stretchr/objx v0.5.2 // indirect + github.com/titanous/json5 v1.0.0 // indirect
bad
review
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/go.mod b/go.mod index 369fb936f43e..c04ac1b896c7 100644 --- a/go.mod +++ b/go.mod @@ -20,6 +20,7 @@ require ( github.com/redis/go-redis/v9 v9.18.0 github.com/spaolacci/murmur3 v1.1.0 github.com/stretchr/testify v1.11.1 + github.com/titanous/json5 v1.0.0 go.etcd.io/etcd/api/v3 v3.5.15 go.etcd.io/e...
good
review_fixed
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -5,10 +5,21 @@ import ( "encoding/json" "github.com/pelletier/go-toml/v2" + "github.com/titanous/json5" "github.com/zeromicro/go-zero/core/lang" "gopkg.in/yaml.v2" ) +// Json5ToJson converts JSON5 data into its JSON representation. +func Json5ToJson(data []byte) ([]byte, error) { + var val any + if err ...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/internal/encoding/encoding.go b/internal/encoding/encoding.go index e1f82fb0380c..a9fe2723764d 100644 --- a/internal/encoding/encoding.go +++ b/internal/encoding/encoding.go @@ -3,12 +3,63 @@ package encoding import ( "bytes" "encoding/json" + "fmt" + "math" "github.com/pelletier/go-toml/v2" + "gi...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, any) error{ - ".json": LoadFromJsonBytes, - ".toml": LoadFromTomlBytes, - ".yaml": LoadFromYamlBytes, - ".yml": LoadFromYamlBytes, + ".json": ...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/core/conf/config.go b/core/conf/config.go index 481b8ac12733..7f7f920c0719 100644 --- a/core/conf/config.go +++ b/core/conf/config.go @@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, an...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -3,12 +3,70 @@ package encoding import ( "bytes" "encoding/json" + "fmt" + "math" "github.com/pelletier/go-toml/v2" + "github.com/titanous/json5" "github.com/zeromicro/go-zero/core/lang" "gopkg.in/yaml.v2" ) +// Json5ToJson converts JSON5 data into its JSON representation. +func Json5ToJson(data []by...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/internal/encoding/encoding.go b/internal/encoding/encoding.go index e1f82fb0380c..a9fe2723764d 100644 --- a/internal/encoding/encoding.go +++ b/internal/encoding/encoding.go @@ -3,12 +3,63 @@ package encoding import ( "bytes" "encoding/json" + "fmt" + "math" "github.com/pelletier/go-toml/v2" + "gi...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, any) error{ - ".json": LoadFromJsonBytes, - ".toml": LoadFromTomlBytes, - ".yaml": LoadFromYamlBytes, - ".yml": LoadFromYamlBytes, + ".json": ...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/core/conf/config.go b/core/conf/config.go index 481b8ac12733..7f7f920c0719 100644 --- a/core/conf/config.go +++ b/core/conf/config.go @@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, an...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -116,3 +116,105 @@ func TestYamlToJsonSlice(t *testing.T) { assert.Equal(t, `{"foo":["bar","baz"]} `, string(b)) } + +func TestJson5ToJson(t *testing.T) { + tests := []struct { + name string + input string + expect string + }{ + { + name: "standard json", + input: `{"a":"foo","b":1,"c":"${FOO}","d"...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/internal/encoding/encoding_test.go b/internal/encoding/encoding_test.go index b7f8b858d2fb..4cefe65327cb 100644 --- a/internal/encoding/encoding_test.go +++ b/internal/encoding/encoding_test.go @@ -1,6 +1,7 @@ package encoding import ( + "math" "testing" "github.com/stretchr/testify/assert" @@ -1...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -75,6 +75,118 @@ func TestLoadFromJsonBytesArray(t *testing.T) { assert.EqualValues(t, []string{"foo", "bar"}, expect) } +func TestConfigJson5(t *testing.T) { + // JSON5 with comments, trailing commas, and unquoted keys + text := `{ + // This is a comment + a: 'foo', // single quotes + b: 1, + c: "${FOO}", + d...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/core/conf/config_test.go b/core/conf/config_test.go index 7eae5964c30a..7c26a64933b3 100644 --- a/core/conf/config_test.go +++ b/core/conf/config_test.go @@ -75,6 +75,160 @@ func TestLoadFromJsonBytesArray(t *testing.T) { assert.EqualValues(t, []string{"foo", "bar"}, expect) } +func TestConfigJson5(t ...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -3,12 +3,70 @@ package encoding import ( "bytes" "encoding/json" + "fmt" + "math" "github.com/pelletier/go-toml/v2" + "github.com/titanous/json5" "github.com/zeromicro/go-zero/core/lang" "gopkg.in/yaml.v2" ) +// Json5ToJson converts JSON5 data into its JSON representation. +func Json5ToJson(data []by...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/internal/encoding/encoding.go b/internal/encoding/encoding.go index e1f82fb0380c..a9fe2723764d 100644 --- a/internal/encoding/encoding.go +++ b/internal/encoding/encoding.go @@ -3,12 +3,63 @@ package encoding import ( "bytes" "encoding/json" + "fmt" + "math" "github.com/pelletier/go-toml/v2" + "gi...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, any) error{ - ".json": LoadFromJsonBytes, - ".toml": LoadFromTomlBytes, - ".yaml": LoadFromYamlBytes, - ".yml": LoadFromYamlBytes, + ".json": ...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/core/conf/config.go b/core/conf/config.go index 481b8ac12733..7f7f920c0719 100644 --- a/core/conf/config.go +++ b/core/conf/config.go @@ -21,10 +21,11 @@ const ( var ( fillDefaultUnmarshaler = mapping.NewUnmarshaler(jsonTagKey, mapping.WithDefault()) loaders = map[string]func([]byte, an...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -75,6 +75,159 @@ func TestLoadFromJsonBytesArray(t *testing.T) { assert.EqualValues(t, []string{"foo", "bar"}, expect) } +func TestConfigJson5(t *testing.T) { + // JSON5 with comments, trailing commas, and unquoted keys + text := `{ + // This is a comment + a: 'foo', // single quotes + b: 1, + c: "${FOO}", + d...
bad
review
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
diff --git a/core/conf/config_test.go b/core/conf/config_test.go index 7eae5964c30a..7c26a64933b3 100644 --- a/core/conf/config_test.go +++ b/core/conf/config_test.go @@ -75,6 +75,160 @@ func TestLoadFromJsonBytesArray(t *testing.T) { assert.EqualValues(t, []string{"foo", "bar"}, expect) } +func TestConfigJson5(t ...
good
review_fixed
go
zeromicro/go-zero
17d190f75b3eb72a6b2d1def5389939f86c74138
@@ -66,7 +66,7 @@ ZMQ_ORIG_CXXFLAGS="${CXXFLAGS:-none}" # Checks for programs. AC_PROG_CC -AX_CHECK_COMPILE_FLAG([-std=c11], [CFLAGS+=" -std=c11"], [AC_PROG_CC_C99]) +AX_CHECK_COMPILE_FLAG([-std=c11], [CFLAGS+=" -std=c11 -D_DEFAULT_SOURCE"], [AC_PROG_CC_C99])
bad
review
zeromq/libzmq
77e32bf41f8b40e9182ebc5c15708b74d162e450
diff --git a/configure.ac b/configure.ac index b9e13d4f97..ffcc145b9f 100644 --- a/configure.ac +++ b/configure.ac @@ -66,7 +66,7 @@ ZMQ_ORIG_CXXFLAGS="${CXXFLAGS:-none}" # Checks for programs. AC_PROG_CC -AX_CHECK_COMPILE_FLAG([-std=c11], [CFLAGS+=" -std=c11"], [AC_PROG_CC_C99]) +AX_CHECK_COMPILE_FLAG([-std=c11], ...
good
review_fixed
zeromq/libzmq
77e32bf41f8b40e9182ebc5c15708b74d162e450
@@ -395,15 +395,14 @@ static bool is_multicast_available (int ipv6_) msleep (SETTLE_TIME); - rc = sendto (send_sock, msg, static_cast<socklen_t> (strlen (msg)), 0,
bad
review
cpp
zeromq/libzmq
0761bb13e61a844c15ee8e07607fd010c399fc47
diff --git a/tests/test_radio_dish.cpp b/tests/test_radio_dish.cpp index 7bfa722d6f..b84b1b1448 100644 --- a/tests/test_radio_dish.cpp +++ b/tests/test_radio_dish.cpp @@ -321,7 +321,7 @@ static bool is_multicast_available (int ipv6_) struct sockaddr_in *mcast_ipv4 = &mcast.ipv4; any_ipv4->sin_family...
good
review_fixed
cpp
zeromq/libzmq
0761bb13e61a844c15ee8e07607fd010c399fc47
@@ -395,15 +395,14 @@ static bool is_multicast_available (int ipv6_) msleep (SETTLE_TIME); - rc = sendto (send_sock, msg, static_cast<socklen_t> (strlen (msg)), 0, - &mcast.generic, sl); + rc = sendto (send_sock, msg, strlen (msg), 0, &mcast.generic, sl); if (rc < 0) { goto ...
bad
review
cpp
zeromq/libzmq
0761bb13e61a844c15ee8e07607fd010c399fc47
diff --git a/tests/test_radio_dish.cpp b/tests/test_radio_dish.cpp index 7bfa722d6f..b84b1b1448 100644 --- a/tests/test_radio_dish.cpp +++ b/tests/test_radio_dish.cpp @@ -321,7 +321,7 @@ static bool is_multicast_available (int ipv6_) struct sockaddr_in *mcast_ipv4 = &mcast.ipv4; any_ipv4->sin_family...
good
review_fixed
cpp
zeromq/libzmq
0761bb13e61a844c15ee8e07607fd010c399fc47
@@ -1915,3 +1915,9 @@ if(ENABLE_NO_EXPORT) message(STATUS "Building with empty ZMQ_EXPORT macro") add_definitions(-DZMQ_NO_EXPORT) endif() + +if (ENABLE_CURVE) + add_executable(curve_keygen tools/curve_keygen.cpp) + target_link_libraries(curve_keygen libzmq) + #target_include_directories(curve_keygen PUBLIC "...
bad
review
zeromq/libzmq
dacde1f11aa4fcbf7571ea520e7b1b8ccee154ec
diff --git a/CMakeLists.txt b/CMakeLists.txt index 3ab2259e6f..7caf2c8763 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1915,3 +1915,9 @@ if(ENABLE_NO_EXPORT) message(STATUS "Building with empty ZMQ_EXPORT macro") add_definitions(-DZMQ_NO_EXPORT) endif() + +if (ENABLE_CURVE) + add_executable(curve_keygen...
good
review_fixed
zeromq/libzmq
dacde1f11aa4fcbf7571ea520e7b1b8ccee154ec
@@ -585,7 +585,9 @@ else() check_cxx_symbol_exists(SO_BUSY_POLL sys/socket.h ZMQ_HAVE_BUSY_POLL) endif() -if(NOT MINGW) +if(MINGW)
bad
review
zeromq/libzmq
d5c3bc42b2352f853d6d7a15cfe41b8610e6872a
diff --git a/CMakeLists.txt b/CMakeLists.txt index 36f4876901..5ad2cc106f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -567,12 +567,18 @@ if(ZMQ_HAVE_WINDOWS) # Cannot use check_library_exists because the symbol is always declared as char(*)(void) set(CMAKE_REQUIRED_LIBRARIES "ws2_32.lib") check_cxx_sym...
good
review_fixed
zeromq/libzmq
d5c3bc42b2352f853d6d7a15cfe41b8610e6872a
@@ -0,0 +1,101 @@ +package com.zhisheng.state.metadata; + +import org.apache.flink.core.fs.Path; +import org.apache.flink.runtime.checkpoint.Checkpoints; +import org.apache.flink.runtime.checkpoint.OperatorState; +import org.apache.flink.runtime.checkpoint.OperatorSubtaskState; +import org.apache.flink.runtime.checkpoi...
bad
review
java
zhisheng17/flink-learning
eb26f93b4cfb187c2a78d29f04fe8cac58aebf03
diff --git a/flink-learning-state/src/main/java/com/zhisheng/state/metadata/MetadataSerializer.java b/flink-learning-state/src/main/java/com/zhisheng/state/metadata/MetadataSerializer.java new file mode 100644 index 00000000..1a48d771 --- /dev/null +++ b/flink-learning-state/src/main/java/com/zhisheng/state/metadata/Me...
good
review_fixed
java
zhisheng17/flink-learning
eb26f93b4cfb187c2a78d29f04fe8cac58aebf03
@@ -951,6 +951,73 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result of an effect or function computation, preventing redundant calculations when the same input is requested multiple times. ZIO provides two memoization strategies: `ZIO#memoize` for effects and `...
bad
review
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7
diff --git a/docs/reference/core/zio/zio.md b/docs/reference/core/zio/zio.md index 49867635cda6..50490e1e3859 100644 --- a/docs/reference/core/zio/zio.md +++ b/docs/reference/core/zio/zio.md @@ -951,6 +951,155 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result o...
good
review_fixed
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7
@@ -951,6 +951,73 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result of an effect or function computation, preventing redundant calculations when the same input is requested multiple times. ZIO provides two memoization strategies: `ZIO#memoize` for effects and `...
bad
review
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7
diff --git a/docs/reference/core/zio/zio.md b/docs/reference/core/zio/zio.md index 49867635cda6..50490e1e3859 100644 --- a/docs/reference/core/zio/zio.md +++ b/docs/reference/core/zio/zio.md @@ -951,6 +951,155 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result o...
good
review_fixed
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7
@@ -951,6 +951,155 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result of an effect or function computation, preventing redundant calculations when the same input is requested multiple times. ZIO provides two memoization strategies: `ZIO#memoize` for effects and ...
bad
review
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7
diff --git a/docs/reference/core/zio/zio.md b/docs/reference/core/zio/zio.md index 49867635cda6..50490e1e3859 100644 --- a/docs/reference/core/zio/zio.md +++ b/docs/reference/core/zio/zio.md @@ -951,6 +951,155 @@ object Main extends ZIOAppDefault { ``` +## Caching and Memoization + +Memoization caches the result o...
good
review_fixed
zio/zio
8c786e7470cae71f8a065ede1dc8dc9faefba0b7