text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,171 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -622,6 +625,24 @@ export class nsZenSessionManager { this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`); } + getSidebarData() { + const sidebar = this.#sidebar; + if (!sidebar) {
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs index 39f2d0eb269..bccec81c60a 100644 --- a/src/zen/sessionstore/ZenSessionManager.sys.mjs +++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs @@ -10,6 +10,7 @@ const lazy = {}; ChromeUtils.defineESModuleGette...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -622,6 +625,24 @@ export class nsZenSessionManager { this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`); } + getSidebarData() { + const sidebar = this.#sidebar; + if (!sidebar) { + return {}; + } + return sidebar; + } + + replaceSidebarData(sidebar, soon = true) ...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs index 39f2d0eb269..bccec81c60a 100644 --- a/src/zen/sessionstore/ZenSessionManager.sys.mjs +++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs @@ -10,6 +10,7 @@ const lazy = {}; ChromeUtils.defineESModuleGette...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,366 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,171 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,171 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -29,19 +29,19 @@ class ZenSyncManager { for (const [uuid, hash] of snapshot.spaces) { if (prev.spaces.get(uuid) !== hash) { Services.obs.notifyObservers( - null, + { wrappedJSObject: { type: "s", id: uuid } }, "zen-workspace-item-changed", - `s...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,369 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,369 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,386 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,386 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,386 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,113 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ContextualIdentityService:...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -1367,30 +1435,57 @@ class nsZenWorkspaces { if (this.privateWindowOrDisabled) { return; } - const workspaces = this._workspaceCache; + + // track the previous positions of workspaces so that we can notify observers for only the reordered workspace + const previousPositions = new Map( + ...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,30 @@ +diff --git a/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs b/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs +index 5702ff28cc22206f5ce16584dac8a78d816562ce..1cd7f0fd222f5b6d2a98d7b5b76c22063d81894f 100644 +--- a/toolkit/components/contextualidentity/C...
bad
review
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch new file mode 100644 index 00000000000..1b108254d1f --- /dev/null +++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s...
good
review_fixed
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,146 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ContextualIdentityService:...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -622,6 +624,14 @@ export class nsZenSessionManager { this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`); } + /** + * Returns the sidebar data object. + * @returns {object} + */ + getSidebarData() { + return this.#sidebar;
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs index 39f2d0eb269..bccec81c60a 100644 --- a/src/zen/sessionstore/ZenSessionManager.sys.mjs +++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs @@ -10,6 +10,7 @@ const lazy = {}; ChromeUtils.defineESModuleGette...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,163 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,163 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,400 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,400 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,159 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,30 @@ +diff --git a/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs b/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs +index 5702ff28cc22206f5ce16584dac8a78d816562ce..1cd7f0fd222f5b6d2a98d7b5b76c22063d81894f 100644 +--- a/toolkit/components/contextualidentity/C...
bad
review
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch new file mode 100644 index 00000000000..1b108254d1f --- /dev/null +++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s...
good
review_fixed
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -170,6 +171,63 @@ class nsZenWorkspaces { } } + /** + * Applies live sync changes: updates workspace cache, removes deleted items, + * then creates/updates pulled items. + * + * @param {{ spaces: Array}} pulled Reconcile-pulled items. + * @param {{ spaces: Array}} removals Items to remove. + ...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -722,8 +780,7 @@ class nsZenWorkspaces { ]); this._workspaceBookmarksCache = { bookmarks, lastChangeTimestamp }; - - return this._workspaceCache; + return this._workspaceBookmarksCache;
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -1367,30 +1434,51 @@ class nsZenWorkspaces { if (this.privateWindowOrDisabled) { return; } - const workspaces = this._workspaceCache; + + // Track previous positions so we only notify observers for workspaces whose + // position changed during the reorder. + const previousPositions = new...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -1767,9 +1855,11 @@ class nsZenWorkspaces { workspaces[workspaceIndex + (offsetPixels > 0 ? -1 : 1)]?.containerTabId; for (const otherWorkspace of workspaces) { const element = this.workspaceElement(otherWorkspace.uuid); - const newTransform = - -(workspaceIndex - workspaces.indexOf(ot...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,159 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,159 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -170,6 +171,63 @@ class nsZenWorkspaces { } } + /** + * Applies live sync changes: updates workspace cache, removes deleted items, + * then creates/updates pulled items. + * + * @param {{ spaces: Array}} pulled Reconcile-pulled items. + * @param {{ spaces: Array}} removals Items to remove. + ...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -1367,30 +1433,50 @@ class nsZenWorkspaces { if (this.privateWindowOrDisabled) { return; } - const workspaces = this._workspaceCache; + const workspaces = this.getWorkspaces(); + // Track previous positions so we only notify observers for workspaces whose + // position changed during the...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,431 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { + Store, + SyncEngine, + Tracker, +} from "resource://services-sync/engines.sys...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs new file mode 100644 index 00000000000..175319169aa --- /dev/null +++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs @@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a ...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +const lazy = {}; + +ChromeUtils.defineESModuleGetters(lazy, { + ZenSessionStore: "resource...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs new file mode 100644 index 00000000000..1b454da8166 --- /dev/null +++ b/src/zen/sync/ZenSyncManager.sys.mjs @@ -0,0 +1,160 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of t...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -0,0 +1,30 @@ +diff --git a/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs b/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs +index 5702ff28cc22206f5ce16584dac8a78d816562ce..1cd7f0fd222f5b6d2a98d7b5b76c22063d81894f 100644 +--- a/toolkit/components/contextualidentity/C...
bad
review
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch new file mode 100644 index 00000000000..1b108254d1f --- /dev/null +++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s...
good
review_fixed
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -38,6 +38,12 @@ white-space: nowrap; font-weight: 500; flex: 1; + position: absolute; + top: 50%; + left: 0; + transform: translateY(-50%); + width: calc(100% - 40px);
bad
review
zen-browser/desktop
035085519475f9fdb0df16711278461ba077c6cb
diff --git a/src/zen/common/styles/zen-sidebar-notification.css b/src/zen/common/styles/zen-sidebar-notification.css index fdddbe54978..b80f94e9b16 100644 --- a/src/zen/common/styles/zen-sidebar-notification.css +++ b/src/zen/common/styles/zen-sidebar-notification.css @@ -27,7 +27,7 @@ display: flex; position: re...
good
review_fixed
zen-browser/desktop
035085519475f9fdb0df16711278461ba077c6cb
@@ -1154,12 +1167,16 @@ class nsZenWindowSync { aWindow, selectedTab.id ); + const selHasContent = this.#hasLiveContent(selectedTab); + const otherHasContent = this.#hasLiveContent(otherSelectedTab); selectedTab._zenContentsVisible = true; - if (otherSelectedTab) { + ...
bad
review
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
diff --git a/src/zen/sessionstore/ZenWindowSync.sys.mjs b/src/zen/sessionstore/ZenWindowSync.sys.mjs index 12993d74bcc..1c1ba7b2213 100644 --- a/src/zen/sessionstore/ZenWindowSync.sys.mjs +++ b/src/zen/sessionstore/ZenWindowSync.sys.mjs @@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { ...
good
review_fixed
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
@@ -199,6 +199,19 @@ class nsZenWindowSync { } } + /** + * Whether a tab currently displays live page content rather than the + * "about:blank" placeholder loaded into a browser whose contents were + * swapped out to another window. + * + * @param {MozTabbrowserTab} aTab - The tab to check. + * @...
bad
review
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
diff --git a/src/zen/sessionstore/ZenWindowSync.sys.mjs b/src/zen/sessionstore/ZenWindowSync.sys.mjs index 12993d74bcc..1c1ba7b2213 100644 --- a/src/zen/sessionstore/ZenWindowSync.sys.mjs +++ b/src/zen/sessionstore/ZenWindowSync.sys.mjs @@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { ...
good
review_fixed
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
@@ -1154,12 +1167,16 @@ class nsZenWindowSync { aWindow, selectedTab.id ); + const selHasContent = this.#hasLiveContent(selectedTab); + const otherHasContent = this.#hasLiveContent(otherSelectedTab); selectedTab._zenContentsVisible = true; if (otherSelectedTab) { ...
bad
review
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
diff --git a/src/zen/sessionstore/ZenWindowSync.sys.mjs b/src/zen/sessionstore/ZenWindowSync.sys.mjs index 12993d74bcc..1c1ba7b2213 100644 --- a/src/zen/sessionstore/ZenWindowSync.sys.mjs +++ b/src/zen/sessionstore/ZenWindowSync.sys.mjs @@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { ...
good
review_fixed
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
@@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { aTargetItem.zenStaticIcon = aOriginalItem.zenStaticIcon; if (gBrowser.isTab(aOriginalItem)) { - gBrowser.setIcon( - aTargetItem, - aOriginalItem.getAttribute("image") || gBrowser.getIcon(aOriginalItem...
bad
review
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
diff --git a/src/zen/sessionstore/ZenWindowSync.sys.mjs b/src/zen/sessionstore/ZenWindowSync.sys.mjs index 12993d74bcc..1c1ba7b2213 100644 --- a/src/zen/sessionstore/ZenWindowSync.sys.mjs +++ b/src/zen/sessionstore/ZenWindowSync.sys.mjs @@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { ...
good
review_fixed
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
@@ -1542,6 +1545,7 @@ class nsZenWindowSync { console.error(`Error moving active tabs to other windows on close:`, e); } resolve(); + this.#docShellSwitchPromise = null; }
bad
review
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
diff --git a/src/zen/sessionstore/ZenWindowSync.sys.mjs b/src/zen/sessionstore/ZenWindowSync.sys.mjs index 12993d74bcc..1c1ba7b2213 100644 --- a/src/zen/sessionstore/ZenWindowSync.sys.mjs +++ b/src/zen/sessionstore/ZenWindowSync.sys.mjs @@ -521,10 +521,13 @@ class nsZenWindowSync { if (flags & SYNC_FLAG_ICON) { ...
good
review_fixed
javascript
zen-browser/desktop
84a0a157b775b4758e8171fe11ce22b411a9f798
@@ -5,11 +5,10 @@ */ #zen-boost-advanced-color-options-panel { - color-scheme: light;
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-advanced-color-options.css b/src/zen/boosts/zen-advanced-color-options.css index 4cc651de896..385d075ab78 100644 --- a/src/zen/boosts/zen-advanced-color-options.css +++ b/src/zen/boosts/zen-advanced-color-options.css @@ -5,11 +5,10 @@ */ #zen-boost-advanced-color-options-panel { - ...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -5,10 +5,33 @@ */ #zenBoostWindow { - /* For the mica effect we want a white tint */ - @media not (-moz-platform: linux) { - color-scheme: light;
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-boosts.css b/src/zen/boosts/zen-boosts.css index f0b3c43ba85..ba3e57b3c6c 100644 --- a/src/zen/boosts/zen-boosts.css +++ b/src/zen/boosts/zen-boosts.css @@ -5,10 +5,33 @@ */ #zenBoostWindow { - /* For the mica effect we want a white tint */ - @media not (-moz-platform: linux) { - ...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -164,5 +156,10 @@ <command id="cmd_zenBoostDelete" oncommand="window.boostEditor.deleteBoost();" /> </commandset> + + <script> + const { nsZenBoostEditor } = ChromeUtils.importESModule( "resource:///modules/zen/boosts/ZenBoostsEditor.mjs" ); + window.boostEditor = new nsZenBoostEditor(doc...
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-boost-editor.inc.xhtml b/src/zen/boosts/zen-boost-editor.inc.xhtml index 15c75f57cb5..9cd64e411f2 100644 --- a/src/zen/boosts/zen-boost-editor.inc.xhtml +++ b/src/zen/boosts/zen-boost-editor.inc.xhtml @@ -34,14 +34,6 @@ <link rel="stylesheet" href="chrome://browser/content/zen-styles/...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -44,6 +44,7 @@ export class nsZenBoostEditor { this.lastDotSetPos = { x: 0, y: 0 }; this.currentBoostData = null; this.boostInfo = null; + this.isDarkMode = this.openerWindow.gZenThemePicker.isDarkMode;
bad
review
javascript
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs index 6956c124a48..c40a541d7b0 100644 --- a/src/zen/boosts/ZenBoostsEditor.mjs +++ b/src/zen/boosts/ZenBoostsEditor.mjs @@ -44,6 +44,7 @@ export class nsZenBoostEditor { this.lastDotSetPos = { x: 0, y: 0 }; this.currentBoostD...
good
review_fixed
javascript
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -5,11 +5,11 @@ */ #zen-boost-advanced-color-options-panel { - color-scheme: light; + color-scheme: light dark; --panel-padding: 15px;
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-advanced-color-options.css b/src/zen/boosts/zen-advanced-color-options.css index 4cc651de896..385d075ab78 100644 --- a/src/zen/boosts/zen-advanced-color-options.css +++ b/src/zen/boosts/zen-advanced-color-options.css @@ -5,11 +5,10 @@ */ #zen-boost-advanced-color-options-panel { - ...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -44,6 +44,7 @@ export class nsZenBoostEditor { this.lastDotSetPos = { x: 0, y: 0 }; this.currentBoostData = null; this.boostInfo = null; + this.isDarkMode = this.openerWindow.gZenThemePicker.isDarkMode;
bad
review
javascript
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/ZenBoostsEditor.mjs b/src/zen/boosts/ZenBoostsEditor.mjs index 6956c124a48..c40a541d7b0 100644 --- a/src/zen/boosts/ZenBoostsEditor.mjs +++ b/src/zen/boosts/ZenBoostsEditor.mjs @@ -44,6 +44,7 @@ export class nsZenBoostEditor { this.lastDotSetPos = { x: 0, y: 0 }; this.currentBoostD...
good
review_fixed
javascript
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -164,5 +156,10 @@ <command id="cmd_zenBoostDelete" oncommand="window.boostEditor.deleteBoost();" /> </commandset> + + <script> + const { nsZenBoostEditor } = ChromeUtils.importESModule( "resource:///modules/zen/boosts/ZenBoostsEditor.mjs" ); + window.boostEditor = new nsZenBoostEditor(doc...
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-boost-editor.inc.xhtml b/src/zen/boosts/zen-boost-editor.inc.xhtml index 15c75f57cb5..9cd64e411f2 100644 --- a/src/zen/boosts/zen-boost-editor.inc.xhtml +++ b/src/zen/boosts/zen-boost-editor.inc.xhtml @@ -34,14 +34,6 @@ <link rel="stylesheet" href="chrome://browser/content/zen-styles/...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -5,11 +5,11 @@ */ #zen-boost-advanced-color-options-panel { - color-scheme: light; + color-scheme: light dark;
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-advanced-color-options.css b/src/zen/boosts/zen-advanced-color-options.css index 4cc651de896..385d075ab78 100644 --- a/src/zen/boosts/zen-advanced-color-options.css +++ b/src/zen/boosts/zen-advanced-color-options.css @@ -5,11 +5,10 @@ */ #zen-boost-advanced-color-options-panel { - ...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -232,6 +259,7 @@ body { padding: 2px; & button { + color: var(--zen-boosts-primary-color) !important; padding: auto;
bad
review
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
diff --git a/src/zen/boosts/zen-boosts.css b/src/zen/boosts/zen-boosts.css index f0b3c43ba85..ba3e57b3c6c 100644 --- a/src/zen/boosts/zen-boosts.css +++ b/src/zen/boosts/zen-boosts.css @@ -5,10 +5,33 @@ */ #zenBoostWindow { - /* For the mica effect we want a white tint */ - @media not (-moz-platform: linux) { - ...
good
review_fixed
zen-browser/desktop
b4c55ff368484251761e2d5a0b671985b1d2a44c
@@ -64,3 +64,12 @@ index 226d0c5a93a9a2404e1974001da4e34b7b670067..b73277448f7d2706d316df2505e17d23 option( "--with-user-appdir", +@@ -4325,7 +4330,7 @@ with only_when(target_is_windows): + + @depends(target.abi) + def desktop_launcher_enabled(abi): +- return abi == "msvc" ++ r...
bad
review
zen-browser/desktop
3496e4ecee378bfea7dd8c5d57c8c000ca245150
diff --git a/src/toolkit/moz-configure.patch b/src/toolkit/moz-configure.patch index cacaabb60df..48f198e0c3c 100644 --- a/src/toolkit/moz-configure.patch +++ b/src/toolkit/moz-configure.patch @@ -1,8 +1,8 @@ diff --git a/toolkit/moz.configure b/toolkit/moz.configure -index 226d0c5a93a9a2404e1974001da4e34b7b670067..b7...
good
review_fixed
zen-browser/desktop
3496e4ecee378bfea7dd8c5d57c8c000ca245150