text stringlengths 19 585k | label stringclasses 2
values | category stringclasses 2
values | language stringclasses 14
values | repo stringclasses 932
values | sha stringlengths 40 40 |
|---|---|---|---|---|---|
@@ -175,27 +176,83 @@ export class McpContext implements Context {
this.#roots = roots;
}
- validatePath(filePath?: string): void {
+ async validatePath(filePath?: string): Promise<void> {
if (filePath === undefined) {
return;
}
const roots = this.roots();
if (roots === undefined)... | bad | review | typescript | ChromeDevTools/chrome-devtools-mcp | b68617198aacdd566015187168bff37f4dbdadf0 |
diff --git a/src/McpContext.ts b/src/McpContext.ts
index f8b5f3cd8..2a4e1da9d 100644
--- a/src/McpContext.ts
+++ b/src/McpContext.ts
@@ -5,6 +5,7 @@
*/
import fs from 'node:fs/promises';
+import fsPromises from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import {fileURLToPath, pa... | good | review_fixed | typescript | ChromeDevTools/chrome-devtools-mcp | b68617198aacdd566015187168bff37f4dbdadf0 |
@@ -404,6 +401,10 @@ export class McpContext implements Context {
: {};
this.#updateSelectedPageTimeouts();
+
+ // This should happen after updating the page timeouts.
+ // Setting the viewport can trigger a reload which we don't want to timeout.
+ await page.setViewport(newSettings.viewport ... | bad | review | typescript | ChromeDevTools/chrome-devtools-mcp | f921ed89d0642d0d4bc37934a5d954cdca77e2e9 |
diff --git a/src/McpContext.ts b/src/McpContext.ts
index fe288c6cc..3855c02f4 100644
--- a/src/McpContext.ts
+++ b/src/McpContext.ts
@@ -413,7 +413,6 @@ export class McpContext implements Context {
}
if (!options.viewport) {
- await page.setViewport(null);
delete newSettings.viewport;
} els... | good | review_fixed | typescript | ChromeDevTools/chrome-devtools-mcp | f921ed89d0642d0d4bc37934a5d954cdca77e2e9 |
@@ -59,7 +59,7 @@ export class McpPage implements ContextPage {
#dialog?: Dialog;
#dialogHandler: (dialog: Dialog) => void;
- thirdPartyDeveloperTools: ToolGroup<ToolDefinition> | undefined;
+ thirdPartyDeveloperTools: Array<ToolGroup<ToolDefinition>> = []; | bad | review | typescript | ChromeDevTools/chrome-devtools-mcp | db0e80c095d1984a1b6d1ec1545aaba654bbc83a |
diff --git a/src/McpPage.ts b/src/McpPage.ts
index 0a32c2de8..7dd2955d7 100644
--- a/src/McpPage.ts
+++ b/src/McpPage.ts
@@ -14,7 +14,7 @@ import type {
WebMCPTool,
} from './third_party/index.js';
import {takeSnapshot} from './tools/snapshot.js';
-import type {ToolGroup, ToolDefinition} from './tools/thirdPartyDe... | good | review_fixed | typescript | ChromeDevTools/chrome-devtools-mcp | db0e80c095d1984a1b6d1ec1545aaba654bbc83a |
@@ -671,10 +671,107 @@ struct MatchImpl
}
}
- template <typename... Args>
- static void constantVector(Args &&...)
+ static void constantVector( | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -671,10 +666,107 @@ struct MatchImpl
}
}
- template <typename... Args>
- static void constantVector(Args &&...)
+ static void constantVector(
+ const String & haystack,
+ const ColumnString::Chars & needle_data,
+ const ColumnString::Offsets & needle_offsets,
+ [[... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -671,10 +666,115 @@ struct MatchImpl
}
}
- template <typename... Args>
- static void constantVector(Args &&...)
+ static void constantVector(
+ const String & haystack,
+ const ColumnString::Chars & needle_data,
+ const ColumnString::Offsets & needle_offsets,
+ [[... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -494,7 +489,15 @@ struct MatchImpl
reinterpret_cast<const char *>(cur_needle_data),
cur_needle_length);
- if (is_like && impl::likePatternIsSubstring(needle, required_substr))
+ /// Shortcut for the silly but practical case that the pattern matches ev... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -668,10 +679,115 @@ struct MatchImpl
}
}
- template <typename... Args>
- static void constantVector(Args &&...)
+ static void constantVector(
+ const String & haystack,
+ const ColumnString::Chars & needle_data,
+ const ColumnString::Offsets & needle_offsets,
+ [[... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -668,10 +679,115 @@ struct MatchImpl
}
}
- template <typename... Args>
- static void constantVector(Args &&...)
+ static void constantVector(
+ const String & haystack,
+ const ColumnString::Chars & needle_data,
+ const ColumnString::Offsets & needle_offsets,
+ [[... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -593,85 +591,57 @@ struct MatchImpl
for (size_t i = 0; i < input_rows_count; ++i)
{
- const auto * const cur_haystack_data = &haystack[prev_haystack_offset];
+ const auto * const cur_haystack_data = reinterpret_cast<const char *>(&haystack[prev_haystack_offset]);
... | bad | review | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
diff --git a/src/Functions/MatchImpl.h b/src/Functions/MatchImpl.h
index a35e6a7f4650..26f47a3b63ec 100644
--- a/src/Functions/MatchImpl.h
+++ b/src/Functions/MatchImpl.h
@@ -11,13 +11,14 @@
namespace DB
{
-namespace ErrorCodes
+namespace impl
{
- extern const int ILLEGAL_COLUMN;
-}
-namespace impl
+/// Does ... | good | review_fixed | c | ClickHouse/ClickHouse | 38d0e3535d5d16ae471b8f753284fd142a5ca3cb |
@@ -90,6 +90,29 @@ ColumnPtr ExecutableFunctionVariantAdaptor::executeImpl(
}
};
+ /// Helper: execute function, respecting throw_on_type_mismatch.
+ /// Some functions (e.g. comparisons) pass build() but throw during execute()
+ /// because executeGeneric calls getLeastSupertype which can thro... | bad | review | cpp | ClickHouse/ClickHouse | 41b943bafc47fe9e7b467ca712c94a6eccd9270b |
diff --git a/src/Functions/FunctionVariantAdaptor.cpp b/src/Functions/FunctionVariantAdaptor.cpp
index 8797545fcc24..f5fd599ab77e 100644
--- a/src/Functions/FunctionVariantAdaptor.cpp
+++ b/src/Functions/FunctionVariantAdaptor.cpp
@@ -90,6 +90,33 @@ ColumnPtr ExecutableFunctionVariantAdaptor::executeImpl(
}
... | good | review_fixed | cpp | ClickHouse/ClickHouse | 41b943bafc47fe9e7b467ca712c94a6eccd9270b |
@@ -44,6 +45,21 @@ class RewriteAggregateFunctionWithIfVisitor : public InDepthQueryTreeVisitorWith
if (lower_name.ends_with("if"))
return;
+ /// The rewrite f(if(cond, x, NULL)) -> fIf(x, cond) drops the rows whose payload is NULL.
+ /// That is only valid for aggregate functions ... | bad | review | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
index 4e1dec0a9b27..bbc16d0571f0 100644
--- a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
+++ b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
@@ -2,8 +2,10 @@
... | good | review_fixed | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
@@ -52,6 +53,22 @@ class RewriteAggregateFunctionWithIfVisitor : public InDepthQueryTreeVisitorWith
if (!if_node || if_node->getFunctionName() != "if")
return;
+ /// Do not rewrite aggregates that preserve NULL payload rows: dropping those rows via -If
+ /// would change their resu... | bad | review | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
index 4e1dec0a9b27..bbc16d0571f0 100644
--- a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
+++ b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
@@ -2,8 +2,10 @@
... | good | review_fixed | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
@@ -25,6 +26,39 @@ namespace Setting
namespace
{
+/// An aggregate preserves NULL payload rows when its null handling keeps them instead of skipping
+/// them: rewriting f(if(cond, x, NULL)) -> fIf(x, cond) drops those rows and is only valid for
+/// NULL-skipping aggregates. The *_respect_nulls family keeps them a... | bad | review | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
index 4e1dec0a9b27..bbc16d0571f0 100644
--- a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
+++ b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
@@ -2,8 +2,10 @@
... | good | review_fixed | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
@@ -25,6 +27,46 @@ namespace Setting
namespace
{
+/// An aggregate preserves NULL payload rows when its null handling keeps them instead of skipping
+/// them: rewriting f(if(cond, x, NULL)) -> fIf(x, cond) drops those rows and is only valid for
+/// NULL-skipping aggregates. The *_respect_nulls family keeps them a... | bad | review | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
diff --git a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
index 4e1dec0a9b27..bbc16d0571f0 100644
--- a/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
+++ b/src/Analyzer/Passes/RewriteAggregateFunctionWithIfPass.cpp
@@ -2,8 +2,10 @@
... | good | review_fixed | cpp | ClickHouse/ClickHouse | fd2eda719fe3db1cbec94af2409829dcfe8b0a9c |
@@ -0,0 +1,71 @@
+#!/usr/bin/env bash
+# Tags: no-replicated-database
+# Tag no-replicated-database: relies on a single server's user_files directory.
+
+# Regression test for https://github.com/ClickHouse/ClickHouse/issues/106474.
+# The reproduction needs the same client session to (a) pre-warm the
+# `LowCardinality... | bad | review | ClickHouse/ClickHouse | 8b605e0806f52e43e61ca75c35d88903e1e508f1 | |
diff --git a/tests/queries/0_stateless/04322_106474_session_timezone_lowcardinality_datetime_csv_roundtrip.sh b/tests/queries/0_stateless/04322_106474_session_timezone_lowcardinality_datetime_csv_roundtrip.sh
new file mode 100755
index 000000000000..6eb69bf9f177
--- /dev/null
+++ b/tests/queries/0_stateless/04322_10647... | good | review_fixed | ClickHouse/ClickHouse | 8b605e0806f52e43e61ca75c35d88903e1e508f1 | |
@@ -0,0 +1,38 @@
+# option(ENABLE_LIBPNG "Enable libpng" ${ENABLE_LIBRARIES}) | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/contrib/libpng-cmake/CMakeLists.txt b/contrib/libpng-cmake/CMakeLists.txt
new file mode 100644
index 000000000000..08a1cf8b5687
--- /dev/null
+++ b/contrib/libpng-cmake/CMakeLists.txt
@@ -0,0 +1,57 @@
+option(ENABLE_LIBPNG "Enable libpng" ${ENABLE_LIBRARIES})
+
+if (NOT ENABLE_LIBPNG)
+ message(STATUS "... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -1311,6 +1311,27 @@ Set the quoting rule for identifiers in SHOW CREATE query
)", 0) \
DECLARE(IdentifierQuotingStyle, show_create_query_identifier_quoting_style, IdentifierQuotingStyle::Backticks, R"(
Set the quoting style for identifiers in SHOW CREATE query
+)", 0) \
+ DECLARE(String, output_png_image_p... | bad | review | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Core/FormatFactorySettings.h b/src/Core/FormatFactorySettings.h
index a43e2d1e78b5..b93a5cb50024 100644
--- a/src/Core/FormatFactorySettings.h
+++ b/src/Core/FormatFactorySettings.h
@@ -1540,6 +1540,28 @@ Set the quoting rule for identifiers in SHOW CREATE query
)", 0) \
DECLARE(IdentifierQuoting... | good | review_fixed | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -1311,6 +1311,27 @@ Set the quoting rule for identifiers in SHOW CREATE query
)", 0) \
DECLARE(IdentifierQuotingStyle, show_create_query_identifier_quoting_style, IdentifierQuotingStyle::Backticks, R"(
Set the quoting style for identifiers in SHOW CREATE query
+)", 0) \
+ DECLARE(String, output_png_image_p... | bad | review | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Core/FormatFactorySettings.h b/src/Core/FormatFactorySettings.h
index a43e2d1e78b5..b93a5cb50024 100644
--- a/src/Core/FormatFactorySettings.h
+++ b/src/Core/FormatFactorySettings.h
@@ -1540,6 +1540,28 @@ Set the quoting rule for identifiers in SHOW CREATE query
)", 0) \
DECLARE(IdentifierQuoting... | good | review_fixed | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,50 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#include <Formats/FormatFactory.h>
+#include <Formats/FormatSettings.h>
+#include <Formats/PNGSerializer.h>
+#include <Formats/PNGWriter.h>
+
+namespace DB
+{
+
+namespace
+{
+constexpr auto FORMAT_NAME = "PNG";
+}
+
+PNGOutputFormat::PNGOutputFo... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.cpp b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
new file mode 100644
index 000000000000..8e3f6c8dbf7c
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
@@ -0,0 +1,110 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#if USE_LIBP... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,411 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Formats/PNGWriter.h>
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+na... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -41,6 +41,8 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
/// Note: please check if the key already exists to prevent duplicate entries.
addSettingsChanges(settings_changes_history, "26.5",
{
+ {"output_format_image_width", 1024, 1024, "New setting controlli... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp
index 01fadf7eb3cb..c63e8102f026 100644
--- a/src/Core/SettingsChangesHistory.cpp
+++ b/src/Core/SettingsChangesHistory.cpp
@@ -41,6 +41,9 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
/// Note: please c... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,54 @@
+#pragma once
+
+#include <png.h>
+#include <boost/noncopyable.hpp>
+
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+class WriteBuffer;
+
+/** Thin libpng wrapper that writes an 8-bit-per-channel PNG image of fixed size to a `WriteBuffer`.
+ *
+ * Number of channels controls the PNG color type:... | bad | review | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGWriter.h b/src/Formats/PNGWriter.h
new file mode 100644
index 000000000000..7c741c182d29
--- /dev/null
+++ b/src/Formats/PNGWriter.h
@@ -0,0 +1,75 @@
+#pragma once
+
+#include "config.h"
+
+#if USE_LIBPNG
+
+#include <exception>
+#include <string>
+
+#include <png.h>
+#include <boost/noncopy... | good | review_fixed | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,30 @@
+#pragma once
+
+#include <Core/Block_fwd.h>
+#include <Formats/FormatSettings.h>
+#include <Processors/Chunk.h>
+#include <Processors/Formats/IOutputFormat.h>
+
+namespace DB
+{
+
+class PNGSerializer;
+class PNGWriter;
+
+/// Output format that renders the result set as a PNG image.
+class PNGOutputF... | bad | review | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.h b/src/Processors/Formats/Impl/PNGOutputFormat.h
new file mode 100644
index 000000000000..8e2105d17a27
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.h
@@ -0,0 +1,36 @@
+#pragma once
+
+#include "config.h"
+
+#if USE_LIBPNG
+
+#include <Core/Blo... | good | review_fixed | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,141 @@
+#include <Formats/PNGWriter.h>
+
+#include <png.h>
+#include <vector>
+
+#include <IO/WriteBuffer.h>
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+namespace ErrorCodes
+{
+ extern const int LOGICAL_ERROR;
+}
+
+namespace
+{
+ constexpr int PNG_COMPRESSION_LEVEL = 6;
+}
+
+PNGWriter::PNGW... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGWriter.cpp b/src/Formats/PNGWriter.cpp
new file mode 100644
index 000000000000..2ba8fd736e4b
--- /dev/null
+++ b/src/Formats/PNGWriter.cpp
@@ -0,0 +1,169 @@
+#include <Formats/PNGWriter.h>
+
+#if USE_LIBPNG
+
+#include <png.h>
+
+#include <algorithm>
+#include <cstring>
+
+#include <IO/Write... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,141 @@
+#include <Formats/PNGWriter.h>
+
+#include <png.h>
+#include <vector>
+
+#include <IO/WriteBuffer.h>
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+namespace ErrorCodes
+{
+ extern const int LOGICAL_ERROR;
+}
+
+namespace
+{
+ constexpr int PNG_COMPRESSION_LEVEL = 6;
+}
+
+PNGWriter::PNGW... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGWriter.cpp b/src/Formats/PNGWriter.cpp
new file mode 100644
index 000000000000..2ba8fd736e4b
--- /dev/null
+++ b/src/Formats/PNGWriter.cpp
@@ -0,0 +1,169 @@
+#include <Formats/PNGWriter.h>
+
+#if USE_LIBPNG
+
+#include <png.h>
+
+#include <algorithm>
+#include <cstring>
+
+#include <IO/Write... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,417 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Formats/PNGWriter.h>
+#include <Common/Exception.h>
+#include <base/arithmet... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,417 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Formats/PNGWriter.h>
+#include <Common/Exception.h>
+#include <base/arithmet... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,417 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Formats/PNGWriter.h>
+#include <Common/Exception.h>
+#include <base/arithmet... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,417 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Formats/PNGWriter.h>
+#include <Common/Exception.h>
+#include <base/arithmet... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,52 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#include <Formats/FormatFactory.h>
+#include <Formats/FormatSettings.h>
+#include <Formats/PNGSerializer.h>
+#include <Formats/PNGWriter.h>
+
+namespace DB
+{
+
+namespace
+{
+constexpr auto FORMAT_NAME = "PNG";
+}
+
+PNGOutputFormat::PNGOutputFo... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.cpp b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
new file mode 100644
index 000000000000..8e3f6c8dbf7c
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
@@ -0,0 +1,110 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#if USE_LIBP... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,157 @@
+#include <Formats/PNGWriter.h>
+
+#include <png.h>
+#include <vector>
+
+#include <IO/WriteBuffer.h>
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+namespace ErrorCodes
+{
+ extern const int LOGICAL_ERROR;
+}
+
+namespace
+{
+ constexpr int PNG_COMPRESSION_LEVEL = 6;
+}
+
+PNGWriter::PNGW... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGWriter.cpp b/src/Formats/PNGWriter.cpp
new file mode 100644
index 000000000000..2ba8fd736e4b
--- /dev/null
+++ b/src/Formats/PNGWriter.cpp
@@ -0,0 +1,169 @@
+#include <Formats/PNGWriter.h>
+
+#if USE_LIBPNG
+
+#include <png.h>
+
+#include <algorithm>
+#include <cstring>
+
+#include <IO/Write... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,112 @@
+#!/usr/bin/env bash
+# Tags: no-fasttest
+# Tag no-fasttest: requires libpng (not built in fast test)
+
+CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CUR_DIR"/../shell_config.sh
+
+OUT="${CLICKHOUSE_TMP}/04259_png_format"
+mkdir -p "${OUT}"
+
+che... | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/tests/queries/0_stateless/04326_png_format.sh b/tests/queries/0_stateless/04326_png_format.sh
new file mode 100755
index 000000000000..4e90aa2de9dd
--- /dev/null
+++ b/tests/queries/0_stateless/04326_png_format.sh
@@ -0,0 +1,194 @@
+#!/usr/bin/env bash
+
+CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pw... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -0,0 +1,108 @@
+--- | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/docs/en/interfaces/formats/PNG.md b/docs/en/interfaces/formats/PNG.md
new file mode 100644
index 000000000000..41c18bd7f67f
--- /dev/null
+++ b/docs/en/interfaces/formats/PNG.md
@@ -0,0 +1,110 @@
+---
+alias: []
+description: 'Documentation for the PNG image output format'
+input_format: false
+keywords: [... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -0,0 +1,110 @@
+--- | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/docs/en/interfaces/formats/PNG.md b/docs/en/interfaces/formats/PNG.md
new file mode 100644
index 000000000000..41c18bd7f67f
--- /dev/null
+++ b/docs/en/interfaces/formats/PNG.md
@@ -0,0 +1,110 @@
+---
+alias: []
+description: 'Documentation for the PNG image output format'
+input_format: false
+keywords: [... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -0,0 +1,457 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Common/Exception.h>
+#include <Common/assert_cast.h>
+#include <Common/NaNUt... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,38 @@
+option(ENABLE_LIBPNG "Enable libpng" ${ENABLE_LIBRARIES})
+
+if (NOT ENABLE_LIBPNG)
+ message(STATUS "Not using libpng")
+ return()
+endif()
+
+set(LIBRARY_DIR "${ClickHouse_SOURCE_DIR}/contrib/libpng")
+set(SCRIPTS_DIR "${LIBRARY_DIR}/scripts")
+
+set(PNG_LIBCONF_PREBUILT "${SCRIPTS_DIR}/pnglib... | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/contrib/libpng-cmake/CMakeLists.txt b/contrib/libpng-cmake/CMakeLists.txt
new file mode 100644
index 000000000000..08a1cf8b5687
--- /dev/null
+++ b/contrib/libpng-cmake/CMakeLists.txt
@@ -0,0 +1,57 @@
+option(ENABLE_LIBPNG "Enable libpng" ${ENABLE_LIBRARIES})
+
+if (NOT ENABLE_LIBPNG)
+ message(STATUS "... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -96,6 +96,7 @@ void registerOutputFormatMarkdown(FormatFactory & factory);
void registerOutputFormatPostgreSQLWire(FormatFactory & factory);
void registerOutputFormatPrometheus(FormatFactory & factory);
void registerOutputFormatSQLInsert(FormatFactory & factory);
+void registerOutputFormatPNG(FormatFactory & fact... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/registerFormats.cpp b/src/Formats/registerFormats.cpp
index 2b6af47d6ec9..e4e09678871e 100644
--- a/src/Formats/registerFormats.cpp
+++ b/src/Formats/registerFormats.cpp
@@ -96,6 +96,7 @@ void registerOutputFormatMarkdown(FormatFactory & factory);
void registerOutputFormatPostgreSQLWire(Format... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,86 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#include <Formats/FormatFactory.h>
+#include <Formats/FormatSettings.h>
+#include <Formats/PNGSerializer.h>
+#include <Formats/PNGTerminalOutput.h>
+#include <Formats/PNGWriter.h>
+#include <IO/WriteBufferFromString.h>
+
+namespace DB
+{
+
+names... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.cpp b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
new file mode 100644
index 000000000000..8e3f6c8dbf7c
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
@@ -0,0 +1,110 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#if USE_LIBP... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,457 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Common/Exception.h>
+#include <Common/assert_cast.h>
+#include <Common/NaNUt... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,457 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/ColumnNullable.h>
+#include <DataTypes/IDataType.h>
+#include <DataTypes/DataTypeNullable.h>
+#include <Common/Exception.h>
+#include <Common/assert_cast.h>
+#include <Common/NaNUt... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGSerializer.cpp b/src/Formats/PNGSerializer.cpp
new file mode 100644
index 000000000000..3e9cfae73bd1
--- /dev/null
+++ b/src/Formats/PNGSerializer.cpp
@@ -0,0 +1,489 @@
+#include <Formats/PNGSerializer.h>
+
+#include <cstring>
+#include <algorithm>
+#include <optional>
+
+#include <Columns/C... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,35 @@
+#pragma once
+
+#include "config.h"
+
+#if USE_LIBPNG
+
+#include <Core/Block_fwd.h>
+#include <Formats/FormatSettings.h>
+#include <Processors/Chunk.h>
+#include <Processors/Formats/IOutputFormat.h>
+
+namespace DB
+{
+
+class PNGSerializer;
+
+/// Output format that renders the result set as a PNG i... | bad | review | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.h b/src/Processors/Formats/Impl/PNGOutputFormat.h
new file mode 100644
index 000000000000..8e2105d17a27
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.h
@@ -0,0 +1,36 @@
+#pragma once
+
+#include "config.h"
+
+#if USE_LIBPNG
+
+#include <Core/Blo... | good | review_fixed | c | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,156 @@
+#include <Formats/PNGWriter.h>
+
+#if USE_LIBPNG
+
+#include <png.h>
+#include <vector>
+
+#include <IO/WriteBuffer.h>
+#include <Common/Exception.h>
+
+namespace DB
+{
+
+namespace ErrorCodes
+{
+ extern const int LOGICAL_ERROR;
+}
+
+namespace
+{
+ constexpr int PNG_COMPRESSION_LEVEL = 6;
+}
... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Formats/PNGWriter.cpp b/src/Formats/PNGWriter.cpp
new file mode 100644
index 000000000000..2ba8fd736e4b
--- /dev/null
+++ b/src/Formats/PNGWriter.cpp
@@ -0,0 +1,169 @@
+#include <Formats/PNGWriter.h>
+
+#if USE_LIBPNG
+
+#include <png.h>
+
+#include <algorithm>
+#include <cstring>
+
+#include <IO/Write... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,110 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#if USE_LIBPNG
+
+#include <Formats/FormatFactory.h>
+#include <Formats/FormatSettings.h>
+#include <Formats/PNGSerializer.h>
+#include <Formats/PNGTerminalOutput.h>
+#include <Formats/PNGWriter.h>
+#include <IO/WriteBufferFromString.h>
+
+names... | bad | review | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
diff --git a/src/Processors/Formats/Impl/PNGOutputFormat.cpp b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
new file mode 100644
index 000000000000..8e3f6c8dbf7c
--- /dev/null
+++ b/src/Processors/Formats/Impl/PNGOutputFormat.cpp
@@ -0,0 +1,110 @@
+#include <Processors/Formats/Impl/PNGOutputFormat.h>
+
+#if USE_LIBP... | good | review_fixed | cpp | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 |
@@ -0,0 +1,196 @@
+#!/usr/bin/env bash
+# Tags: no-fasttest | bad | review | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
diff --git a/tests/queries/0_stateless/04326_png_format.sh b/tests/queries/0_stateless/04326_png_format.sh
new file mode 100755
index 000000000000..4e90aa2de9dd
--- /dev/null
+++ b/tests/queries/0_stateless/04326_png_format.sh
@@ -0,0 +1,194 @@
+#!/usr/bin/env bash
+
+CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pw... | good | review_fixed | ClickHouse/ClickHouse | 09b2afe7949a3181110e32075ef51c49474b53e9 | |
@@ -9,23 +9,39 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
# shellcheck source=../shell_config.sh
. "$CURDIR"/../shell_config.sh
-NEW_DB_NAME="${CLICKHOUSE_DATABASE}_03913_DATALKE"
+NEW_DB_NAME="${CLICKHOUSE_DATABASE}_03913_DATALAKE"
$CLICKHOUSE_CLIENT -q "DROP DATABASE IF EXISTS ${NEW_DB_NAME};"
$C... | bad | review | ClickHouse/ClickHouse | 5198f3225264c04399828edefa93aec04b3ab11a | |
diff --git a/tests/queries/0_stateless/03913_datalake_restful_catalog_bad_format.sh b/tests/queries/0_stateless/03913_datalake_restful_catalog_bad_format.sh
index b7f78f733d34..fb32a9b0c162 100755
--- a/tests/queries/0_stateless/03913_datalake_restful_catalog_bad_format.sh
+++ b/tests/queries/0_stateless/03913_datalake... | good | review_fixed | ClickHouse/ClickHouse | 5198f3225264c04399828edefa93aec04b3ab11a | |
@@ -148,9 +148,9 @@ void HandshakeResponse::readPayloadImpl(ReadBuffer & payload)
}
else if (capability_flags & CLIENT_SECURE_CONNECTION)
{
- char len = 0;
- payload.readStrict(len);
- auth_response.resize(static_cast<unsigned int>(len));
+ UInt8 len = 0;
+ payload.read... | bad | review | cpp | ClickHouse/ClickHouse | 4668a438051d5f17a5d7ecbb24eb2d380f8eb210 |
diff --git a/src/Core/MySQL/PacketsConnection.cpp b/src/Core/MySQL/PacketsConnection.cpp
index 0cc97f6a8df2..db127898ab3a 100644
--- a/src/Core/MySQL/PacketsConnection.cpp
+++ b/src/Core/MySQL/PacketsConnection.cpp
@@ -148,9 +148,9 @@ void HandshakeResponse::readPayloadImpl(ReadBuffer & payload)
}
else if (ca... | good | review_fixed | cpp | ClickHouse/ClickHouse | 4668a438051d5f17a5d7ecbb24eb2d380f8eb210 |
@@ -1448,6 +1448,18 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(Int32, oom_score, getDefaultOomScore(), R"(On Linux systems this can control the behavior of OOM killer.)", 0) \
+ DECLARE(Bool, oom_canary_enable, true, R"(
+ Enable the OOM... | bad | review | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
diff --git a/src/Core/ServerSettings.cpp b/src/Core/ServerSettings.cpp
index ee0a3d9a0d13..a818c288cec6 100644
--- a/src/Core/ServerSettings.cpp
+++ b/src/Core/ServerSettings.cpp
@@ -1505,6 +1505,45 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(I... | good | review_fixed | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
@@ -1448,6 +1448,18 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(Int32, oom_score, getDefaultOomScore(), R"(On Linux systems this can control the behavior of OOM killer.)", 0) \
+ DECLARE(Bool, oom_canary_enable, false, R"( | bad | review | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
diff --git a/src/Core/ServerSettings.cpp b/src/Core/ServerSettings.cpp
index ee0a3d9a0d13..a818c288cec6 100644
--- a/src/Core/ServerSettings.cpp
+++ b/src/Core/ServerSettings.cpp
@@ -1505,6 +1505,45 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(I... | good | review_fixed | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
@@ -1481,6 +1481,25 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(Int32, oom_score, getDefaultOomScore(), R"(On Linux systems this can control the behavior of OOM killer.)", 0) \
+ DECLARE(Bool, allow_experimental_oom_canary, false, R"( | bad | review | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
diff --git a/src/Core/ServerSettings.cpp b/src/Core/ServerSettings.cpp
index ee0a3d9a0d13..a818c288cec6 100644
--- a/src/Core/ServerSettings.cpp
+++ b/src/Core/ServerSettings.cpp
@@ -1505,6 +1505,45 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
```
)", 0) \
DECLARE(I... | good | review_fixed | cpp | ClickHouse/ClickHouse | f6a6dce6c24bdd0f8a3630844943a0a43218c964 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.