text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,97 @@ +import { defineConfig } from 'vitepress' + +// https://vitepress.dev/reference/site-config +export default defineConfig({ + title: "CanCanCan", + description: "The authorization Gem for Ruby on Rails.", + head: [ + ['link', { rel: "apple-touch-icon", sizes: "180x180", href: "/apple-touch-icon.pn...
bad
review
CanCanCommunity/cancancan
56e1c57e396f8acaa2ccc8a27ad6b0d0def25543
diff --git a/docs/.vitepress/config.mts b/docs/.vitepress/config.mts new file mode 100644 index 00000000..d492843d --- /dev/null +++ b/docs/.vitepress/config.mts @@ -0,0 +1,97 @@ +import { defineConfig } from 'vitepress' + +// https://vitepress.dev/reference/site-config +export default defineConfig({ + title: "CanCanC...
good
review_fixed
CanCanCommunity/cancancan
56e1c57e396f8acaa2ccc8a27ad6b0d0def25543
@@ -909,6 +909,37 @@ class JsonTransaction < ActiveRecord::Base end end + context 'with rule application to subclass for non sti class' do + before do + ActiveRecord::Schema.define do + create_table :parents, force: true do |t| + end + + create_table :children, force: true do |t|...
bad
review
ruby
CanCanCommunity/cancancan
c65a9cda6f40f68f70e00f1fd8334f1204fef15b
diff --git a/spec/cancan/model_adapters/active_record_adapter_spec.rb b/spec/cancan/model_adapters/active_record_adapter_spec.rb index 6fea7554..bb6a93dc 100644 --- a/spec/cancan/model_adapters/active_record_adapter_spec.rb +++ b/spec/cancan/model_adapters/active_record_adapter_spec.rb @@ -1033,6 +1033,43 @@ class Json...
good
review_fixed
ruby
CanCanCommunity/cancancan
c65a9cda6f40f68f70e00f1fd8334f1204fef15b
@@ -1,9 +1,12 @@ module CanCan module ConditionsMatcher # Matches the block or conditions hash - def matches_conditions?(action, subject, extra_args) - return call_block_with_all(action, subject, extra_args) if @match_all - return @block.call(subject, *extra_args) if @block && !subject_class?(subj...
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/lib/cancan/conditions_matcher.rb b/lib/cancan/conditions_matcher.rb index 9c5fee15..3e7d2e73 100644 --- a/lib/cancan/conditions_matcher.rb +++ b/lib/cancan/conditions_matcher.rb @@ -1,10 +1,11 @@ module CanCan module ConditionsMatcher # Matches the block or conditions hash - def matches_conditi...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -275,10 +281,10 @@ int > x end - expect(@ability.can?(:read, 2, 1)).to be(true) - expect(@ability.can?(:read, 2, 3)).to be(false) - expect(@ability.can?(:read, { any: [4, 5] }, 3)).to be(true) - expect(@ability.can?(:read, { any: [2, 3] }, 3)).to be(false) + expect(@ability.can?(:read, 2...
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/spec/cancan/ability_spec.rb b/spec/cancan/ability_spec.rb index 1fbb047d..1e47459e 100644 --- a/spec/cancan/ability_spec.rb +++ b/spec/cancan/ability_spec.rb @@ -182,17 +182,23 @@ it 'lists all permissions' do @ability.can :manage, :all @ability.can :learn, Range - @ability.cannot :read, St...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -43,6 +43,6 @@ appraise 'activerecord_5.1.0' do gemfile.platforms :ruby, :mswin, :mingw do gem 'sqlite3' - gem 'pg' + gem 'pg', '~> 0.18'
bad
review
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/Appraisals b/Appraisals index 383d04c2..43584ed9 100644 --- a/Appraisals +++ b/Appraisals @@ -27,7 +27,7 @@ appraise 'activerecord_5.0.2' do gemfile.platforms :ruby, :mswin, :mingw do gem 'sqlite3' - gem 'pg', '~> 0.21' + gem 'pg', '~> 0.18' end end
good
review_fixed
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -0,0 +1,25 @@ +module CanCan + module Ability + module StrongParameterSupport + # Return an array of attributes suitable for use with strong parameters + def permitted_attributes(action, subject) + @permitted_attributes ||= {} + @permitted_attributes[[action, subject]] ||= allowed_attribu...
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/lib/cancan/ability/strong_parameter_support.rb b/lib/cancan/ability/strong_parameter_support.rb new file mode 100644 index 00000000..bb42cf9e --- /dev/null +++ b/lib/cancan/ability/strong_parameter_support.rb @@ -0,0 +1,39 @@ +module CanCan + module Ability + module StrongParameterSupport + # Retu...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -73,12 +76,31 @@ def matches_subject?(subject) @subjects.include?(:all) || @subjects.include?(subject) || matches_subject_class?(subject) end + def matches_attribute?(attribute) + return true if @attributes.empty? + return @base_behavior if attribute.nil? + @attributes.include?(attrib...
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/lib/cancan/rule.rb b/lib/cancan/rule.rb index 9b3ccf79..af7b1555 100644 --- a/lib/cancan/rule.rb +++ b/lib/cancan/rule.rb @@ -5,25 +5,30 @@ module CanCan # helpful methods to determine permission checking and conditions hash generation. class Rule # :nodoc: include ConditionsMatcher - attr_re...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -0,0 +1,7 @@ +module CanCan + module ParameterValidators + def valid_attribute_param?(attribute) + attribute.nil? || attribute.is_a?(Symbol) || (attribute.is_a?(Array) && attribute.first.is_a?(Symbol))
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/lib/cancan/parameter_validators.rb b/lib/cancan/parameter_validators.rb new file mode 100644 index 00000000..546a4f1d --- /dev/null +++ b/lib/cancan/parameter_validators.rb @@ -0,0 +1,7 @@ +module CanCan + module ParameterValidators + def valid_attribute_param?(attribute) + attribute.nil? || attri...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -0,0 +1,25 @@ +module CanCan + module Ability + module StrongParameterSupport + # Return an array of attributes suitable for use with strong parameters + def permitted_attributes(action, subject) + @permitted_attributes ||= {} + @permitted_attributes[[action, subject]] ||= allowed_attribu...
bad
review
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
diff --git a/lib/cancan/ability/strong_parameter_support.rb b/lib/cancan/ability/strong_parameter_support.rb new file mode 100644 index 00000000..bb42cf9e --- /dev/null +++ b/lib/cancan/ability/strong_parameter_support.rb @@ -0,0 +1,39 @@ +module CanCan + module Ability + module StrongParameterSupport + # Retu...
good
review_fixed
ruby
CanCanCommunity/cancancan
795a51c79d29fb51a858f27b069f5f96a63dd7a7
@@ -443,6 +443,173 @@ class User < ActiveRecord::Base expect(Article.accessible_by(ability)).to eq([article]) end + it 'allows an empty array to be used as a condition for a has_many, but this is never a passing condition' do + a1 = Article.create! + a2 = Article.create! + a2.comments = [Comment.cre...
bad
review
ruby
CanCanCommunity/cancancan
f0fab320c2a2c853ee265a14add8ac57d0021af7
diff --git a/spec/cancan/model_adapters/active_record_adapter_spec.rb b/spec/cancan/model_adapters/active_record_adapter_spec.rb index c50f18bb..b1a76ebd 100644 --- a/spec/cancan/model_adapters/active_record_adapter_spec.rb +++ b/spec/cancan/model_adapters/active_record_adapter_spec.rb @@ -626,6 +626,199 @@ class User ...
good
review_fixed
ruby
CanCanCommunity/cancancan
f0fab320c2a2c853ee265a14add8ac57d0021af7
@@ -443,6 +443,173 @@ class User < ActiveRecord::Base expect(Article.accessible_by(ability)).to eq([article]) end + it 'allows an empty array to be used as a condition for a has_many, but this is never a passing condition' do + a1 = Article.create! + a2 = Article.create! + a2.comments = [Comment.cre...
bad
review
ruby
CanCanCommunity/cancancan
f0fab320c2a2c853ee265a14add8ac57d0021af7
diff --git a/spec/cancan/model_adapters/active_record_adapter_spec.rb b/spec/cancan/model_adapters/active_record_adapter_spec.rb index c50f18bb..b1a76ebd 100644 --- a/spec/cancan/model_adapters/active_record_adapter_spec.rb +++ b/spec/cancan/model_adapters/active_record_adapter_spec.rb @@ -626,6 +626,199 @@ class User ...
good
review_fixed
ruby
CanCanCommunity/cancancan
f0fab320c2a2c853ee265a14add8ac57d0021af7
@@ -1,10 +1,10 @@ source https://api.nuget.org/v3/index.json -framework: net6.0, net7.0, net8.0, netstandard2.0, netstandard2.1 +framework: net6.0, net7.0, net8.0, net9.0, netstandard2.0, netstandard2.1
bad
review
CaptnCodr/Fli
455bd0a009f37a8091cbebbb40a77dfec0136d86
diff --git a/paket.dependencies b/paket.dependencies index 521a6cb..d97e72c 100644 --- a/paket.dependencies +++ b/paket.dependencies @@ -1,5 +1,5 @@ source https://api.nuget.org/v3/index.json -framework: net6.0, net7.0, net8.0, netstandard2.0, netstandard2.1 +framework: net8.0, net9.0, netstandard2.0, netstandard2.1 ...
good
review_fixed
CaptnCodr/Fli
455bd0a009f37a8091cbebbb40a77dfec0136d86
@@ -55,6 +55,25 @@ module CE = member _.Output(context: ICommandContext<ShellContext>, func: string -> unit) = Cli.output (Custom func) context.Context + /// Extra `Output` that is being executed immediately after getting output from execution. + [<CustomOperation("Stream")>] + ...
bad
review
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs index 3b98d9e..16a6dcc 100644 --- a/src/Fli/CE.fs +++ b/src/Fli/CE.fs @@ -4,6 +4,7 @@ module CE = open System.Text + open System.IO open Domain type ICommandContext<'a> with @@ -55,6 +56,11 @@ module CE = member _.Output(context: ICommandContext...
good
review_fixed
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
@@ -55,6 +55,25 @@ module CE = member _.Output(context: ICommandContext<ShellContext>, func: string -> unit) = Cli.output (Custom func) context.Context + /// Extra `Output` that is being executed immediately after getting output from execution.
bad
review
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs index 3b98d9e..16a6dcc 100644 --- a/src/Fli/CE.fs +++ b/src/Fli/CE.fs @@ -4,6 +4,7 @@ module CE = open System.Text + open System.IO open Domain type ICommandContext<'a> with @@ -55,6 +56,11 @@ module CE = member _.Output(context: ICommandContext...
good
review_fixed
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
@@ -127,6 +146,24 @@ module CE = member _.Output(context: ICommandContext<ExecContext>, func: string -> unit) = Program.output (Custom func) context.Context + [<CustomOperation("Stream")>] + member _.Stream(context: ICommandContext<ExecContext>, output: Outputs) = Program.stream ou...
bad
review
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs index 3b98d9e..16a6dcc 100644 --- a/src/Fli/CE.fs +++ b/src/Fli/CE.fs @@ -4,6 +4,7 @@ module CE = open System.Text + open System.IO open Domain type ICommandContext<'a> with @@ -55,6 +56,11 @@ module CE = member _.Output(context: ICommandContext...
good
review_fixed
fsharp
CaptnCodr/Fli
05cadf90628464586ba04829c63840eeae12b2c4
@@ -35,6 +35,16 @@ let ``Check WorkingDirectory in ProcessStartInfo with WorkingDirectory`` () = |> _.WorkingDirectory |> should equal @"C:\Users" +[<Test>] +let ``Check Window Style in ProcessStartInfo with WorkingDirectory`` () = + cli { + Exec "cnd.exe"
bad
review
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs index bb3da1e..0452eb5 100644 --- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs +++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs @@ -28,13 +28,23 @@ let ``Check Arguments i...
good
review_fixed
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -35,6 +35,16 @@ let ``Check WorkingDirectory in ProcessStartInfo with WorkingDirectory`` () = |> _.WorkingDirectory |> should equal @"C:\Users" +[<Test>] +let ``Check Window Style in ProcessStartInfo with WorkingDirectory`` () =
bad
review
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs index bb3da1e..0452eb5 100644 --- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs +++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs @@ -28,13 +28,23 @@ let ``Check Arguments i...
good
review_fixed
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -54,6 +54,14 @@ let ``Check working directory config for executing program`` () = |> _.config.WorkingDirectory |> should equal (Some @"C:\Users") +[<Test>] +let ``Check window style config for executing program`` () =
bad
review
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/src/Fli.Tests/ExecContext/ExecConfigTests.fs b/src/Fli.Tests/ExecContext/ExecConfigTests.fs index cd2b05c..b9bbc60 100644 --- a/src/Fli.Tests/ExecContext/ExecConfigTests.fs +++ b/src/Fli.Tests/ExecContext/ExecConfigTests.fs @@ -54,6 +54,14 @@ let ``Check working directory config for executing program`` () ...
good
review_fixed
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -56,6 +56,12 @@ module CE = member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) = Cli.workingDirectory workingDirectory context.Context + /// The `windowsstyle` for newly created windows.
bad
review
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs index c0f4c67..066716e 100644 --- a/src/Fli/CE.fs +++ b/src/Fli/CE.fs @@ -56,6 +56,12 @@ module CE = member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) = Cli.workingDirectory workingDirectory context.Context + ///...
good
review_fixed
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -118,6 +124,12 @@ module CE = member _.WorkingDirectory(context: ICommandContext<ExecContext>, workingDirectory) = Program.workingDirectory workingDirectory context.Context + /// The `windowsstyle` for newly created windows.
bad
review
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs index c0f4c67..066716e 100644 --- a/src/Fli/CE.fs +++ b/src/Fli/CE.fs @@ -56,6 +56,12 @@ module CE = member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) = Cli.workingDirectory workingDirectory context.Context + ///...
good
review_fixed
fsharp
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -252,6 +262,7 @@ cli { | `Username` | `string` | | `Credentials` | `string * string * string` | | `WorkingDirectory` | `string` | +| `WindowStyle` | `Fli....
bad
review
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
diff --git a/README.md b/README.md index a374eb4..799c291 100644 --- a/README.md +++ b/README.md @@ -124,6 +124,15 @@ cli { |> Command.execute ``` +For Windows applications it's possible to set their visibility. There are four possible values: `Hidden`, `Maximized`, `Minimized` and `Normal`. The default is `Hidden`...
good
review_fixed
CaptnCodr/Fli
6d5704e44d5fbb1fe253f26dbd879988c1ff205a
@@ -0,0 +1,492 @@ +<div align="center"> + +<a href='https://nextchat.club'> + <img src="https://github.com/user-attachments/assets/83bdcc07-ae5e-4954-a53a-ac151ba6ccf3" width="1000" alt="icon"/> +</a> + +<h1 align="center">NextChat</h1> + +영어 / [简体中文](./README_CN.md) + +<a href="https://trendshift.io/repositories/5973...
bad
review
ChatGPTNextWeb/NextChat
1374770929786b89f774d2825bf83aa7d64a50c3
diff --git a/README_KO.md b/README_KO.md new file mode 100644 index 00000000000..40ba5a6a1c4 --- /dev/null +++ b/README_KO.md @@ -0,0 +1,492 @@ +<div align="center"> + +<a href='https://nextchat.club'> + <img src="https://github.com/user-attachments/assets/83bdcc07-ae5e-4954-a53a-ac151ba6ccf3" width="1000" alt="icon"/...
good
review_fixed
ChatGPTNextWeb/NextChat
1374770929786b89f774d2825bf83aa7d64a50c3
@@ -27,90 +29,101 @@ export class FakeIssuesManager extends DevTools.Common.ObjectWrapper } } -// DevTools CDP errors can get noisy. -DevTools.ProtocolClient.InspectorBackend.test.suppressRequestErrors = true; - -// Stub out Network emulation commands on the DevTools Agent prototype globally. -// This prevents th...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/DevtoolsUtils.ts b/src/devtools/DevtoolsUtils.ts similarity index 84% rename from src/DevtoolsUtils.ts rename to src/devtools/DevtoolsUtils.ts index c09a1d87d..5f130a153 100644 --- a/src/DevtoolsUtils.ts +++ b/src/devtools/DevtoolsUtils.ts @@ -4,9 +4,8 @@ * SPDX-License-Identifier: Apache-2.0 */ ...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint-disable @typescript-eslint/no-empty-function */ + +import type {DevTools} from '../third_party/index.js'; + +/** + * BaseClass that is noop or throws for methods. + * the McpHostBidningAdapter sho...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/devtools/McpHostBindingAdapter.ts b/src/devtools/McpHostBindingAdapter.ts new file mode 100644 index 000000000..b4574bad5 --- /dev/null +++ b/src/devtools/McpHostBindingAdapter.ts @@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint-disable @typescript-eslint/no-empty-function */ + +import type {DevTools} from '../third_party/index.js'; + +/** + * BaseClass that is noop or throws for methods. + * the McpHostBidningAdapter sho...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/devtools/McpHostBindingAdapter.ts b/src/devtools/McpHostBindingAdapter.ts new file mode 100644 index 000000000..b4574bad5 --- /dev/null +++ b/src/devtools/McpHostBindingAdapter.ts @@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint-disable @typescript-eslint/no-empty-function */ + +import type {DevTools} from '../third_party/index.js'; + +/** + * BaseClass that is noop or throws for methods. + * the McpHostBidningAdapter sho...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/devtools/McpHostBindingAdapter.ts b/src/devtools/McpHostBindingAdapter.ts new file mode 100644 index 000000000..b4574bad5 --- /dev/null +++ b/src/devtools/McpHostBindingAdapter.ts @@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -27,90 +29,101 @@ export class FakeIssuesManager extends DevTools.Common.ObjectWrapper } } -// DevTools CDP errors can get noisy. -DevTools.ProtocolClient.InspectorBackend.test.suppressRequestErrors = true; - -// Stub out Network emulation commands on the DevTools Agent prototype globally. -// This prevents th...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/DevtoolsUtils.ts b/src/devtools/DevtoolsUtils.ts similarity index 84% rename from src/DevtoolsUtils.ts rename to src/devtools/DevtoolsUtils.ts index c09a1d87d..5f130a153 100644 --- a/src/DevtoolsUtils.ts +++ b/src/devtools/DevtoolsUtils.ts @@ -4,9 +4,8 @@ * SPDX-License-Identifier: Apache-2.0 */ ...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint-disable @typescript-eslint/no-empty-function */ + +import type {DevTools} from '../third_party/index.js'; + +/** + * BaseClass that is noop or throws for methods. + * the McpHostBidningAdapter sho...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
diff --git a/src/devtools/McpHostBindingAdapter.ts b/src/devtools/McpHostBindingAdapter.ts new file mode 100644 index 000000000..b4574bad5 --- /dev/null +++ b/src/devtools/McpHostBindingAdapter.ts @@ -0,0 +1,255 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +/* eslint...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6efd1e0d6cde680355d4bca30b42e7889a4141ce
@@ -1070,6 +1068,26 @@ Call ${handleDialog.name} to handle it before continuing.`); structuredContent.heapSnapshotNodes = paginationData.items; } + const retainingPaths = this.#heapSnapshotOptions.retainingPaths; + if (retainingPaths) { + response.push('### Retaining Paths');
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
4dc723a44c2aecfcf1e79ad59e82ae36dfbe8b4e
diff --git a/src/McpResponse.ts b/src/McpResponse.ts index 9dfea8be2..00baad2ac 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -219,6 +219,7 @@ export class McpResponse implements Response { stats?: DevTools.HeapSnapshotModel.HeapSnapshotModel.Statistics; staticData?: DevTools.HeapSnapshotModel.H...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
4dc723a44c2aecfcf1e79ad59e82ae36dfbe8b4e
@@ -0,0 +1,202 @@ +/** + * @license + * Copyright 2025 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import {UncaughtError} from './PageCollector.js'; +import type { + ConsoleMessage, + WebWorker, + Target, + CDPSession, + Protocol, + Browser, +} from './third_party/index.js'; +import type {Extension...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
diff --git a/src/ServiceWorkerCollector.ts b/src/ServiceWorkerCollector.ts new file mode 100644 index 000000000..562ffeb35 --- /dev/null +++ b/src/ServiceWorkerCollector.ts @@ -0,0 +1,227 @@ +/** + * @license + * Copyright 2025 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import {UncaughtError} from './Pa...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
@@ -13,22 +14,140 @@ import type {ParsedArguments} from '../../src/bin/chrome-devtools-mcp-cli-option import {loadIssueDescriptions} from '../../src/issue-descriptions.js'; import {McpResponse} from '../../src/McpResponse.js'; import {TextSnapshot} from '../../src/TextSnapshot.js'; +import type {CdpWebWorker} from '...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
diff --git a/tests/tools/console.test.ts b/tests/tools/console.test.ts index b68e61606..7ae59f249 100644 --- a/tests/tools/console.test.ts +++ b/tests/tools/console.test.ts @@ -5,6 +5,7 @@ */ import assert from 'node:assert'; +import path from 'node:path'; import {before, describe, it} from 'node:test'; import...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
@@ -13,22 +14,140 @@ import type {ParsedArguments} from '../../src/bin/chrome-devtools-mcp-cli-option import {loadIssueDescriptions} from '../../src/issue-descriptions.js'; import {McpResponse} from '../../src/McpResponse.js'; import {TextSnapshot} from '../../src/TextSnapshot.js'; +import type {CdpWebWorker} from '...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
diff --git a/tests/tools/console.test.ts b/tests/tools/console.test.ts index b68e61606..7ae59f249 100644 --- a/tests/tools/console.test.ts +++ b/tests/tools/console.test.ts @@ -5,6 +5,7 @@ */ import assert from 'node:assert'; +import path from 'node:path'; import {before, describe, it} from 'node:test'; import...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
@@ -13,22 +14,140 @@ import type {ParsedArguments} from '../../src/bin/chrome-devtools-mcp-cli-option import {loadIssueDescriptions} from '../../src/issue-descriptions.js'; import {McpResponse} from '../../src/McpResponse.js'; import {TextSnapshot} from '../../src/TextSnapshot.js'; +import type {CdpWebWorker} from '...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
diff --git a/tests/tools/console.test.ts b/tests/tools/console.test.ts index b68e61606..7ae59f249 100644 --- a/tests/tools/console.test.ts +++ b/tests/tools/console.test.ts @@ -5,6 +5,7 @@ */ import assert from 'node:assert'; +import path from 'node:path'; import {before, describe, it} from 'node:test'; import...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6e475da087fe4cbc56faee327382bfb079476ee8
@@ -154,3 +154,32 @@ export const getHeapSnapshotRetainers = defineTool({ }); }, }); + +export const closeHeapSnapshot = defineTool({ + name: 'close_heapsnapshot', + description: + 'Closes a previously loaded memory heapsnapshot, freeing its memory.', + annotations: { + category: ToolCategory.MEMORY, ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6e02498039db53633d8cfb46146f319d59af76f2
diff --git a/src/tools/memory.ts b/src/tools/memory.ts index e9cd00215..792a05996 100644 --- a/src/tools/memory.ts +++ b/src/tools/memory.ts @@ -154,3 +154,32 @@ export const getHeapSnapshotRetainers = defineTool({ }); }, }); + +export const closeHeapSnapshot = defineTool({ + name: 'close_heapsnapshot', + de...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6e02498039db53633d8cfb46146f319d59af76f2
@@ -32,6 +33,44 @@ if (process.env['CHROME_DEVTOOLS_MCP_CRASH_ON_UNCAUGHT'] !== 'true') { }); } +// Shutdown on stdin EOF (stdio MCP convention — the client closes the +// transport to signal exit) and on standard termination signals. Without +// this, an active Chrome subprocess keeps the Node event loop ref'd a...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
b2311a698056f1df010003a006aec78c39e6fba4
diff --git a/src/bin/chrome-devtools-mcp-main.ts b/src/bin/chrome-devtools-mcp-main.ts index 1d03c089b..25fb69b19 100644 --- a/src/bin/chrome-devtools-mcp-main.ts +++ b/src/bin/chrome-devtools-mcp-main.ts @@ -8,6 +8,7 @@ import '../polyfill.js'; import process from 'node:process'; +import {closeBrowser} from '../b...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
b2311a698056f1df010003a006aec78c39e6fba4
@@ -48,6 +48,7 @@ export interface BaseToolDefinition< }; schema: Schema; blockedByDialog: boolean; + verifyFilesSchema?: Array<keyof Schema>;
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
6c455fa90f0c821bc074cff083757200ec4ebfb5
diff --git a/src/tools/ToolDefinition.ts b/src/tools/ToolDefinition.ts index dd8cba89b..7350b2b45 100644 --- a/src/tools/ToolDefinition.ts +++ b/src/tools/ToolDefinition.ts @@ -48,6 +48,7 @@ export interface BaseToolDefinition< }; schema: Schema; blockedByDialog: boolean; + verifyFilesSchema: Array<keyof Sche...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
6c455fa90f0c821bc074cff083757200ec4ebfb5
@@ -849,10 +810,12 @@ Call ${handleDialog.name} to handle it before continuing.`); const contextLabel = isolatedContextName ? ` isolatedContext=${isolatedContextName}` : ''; + const title = await page.title().catch(() => '');
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
403465713614e9ef9875e9667437357ad7229235
diff --git a/src/McpResponse.ts b/src/McpResponse.ts index b2abf7660..d0de129a8 100644 --- a/src/McpResponse.ts +++ b/src/McpResponse.ts @@ -759,7 +759,7 @@ export class McpResponse implements Response { ); } - format( + async format( toolName: string, context: McpContext, data: { @@ -777,7 +...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
403465713614e9ef9875e9667437357ad7229235
@@ -210,6 +210,17 @@ export const cliOptions = { describe: 'Additional arguments for Chrome. Only applies when Chrome is launched by chrome-devtools-mcp.', }, + blocklist: { + type: 'array', + describe: + 'URL patterns to block access to. Uses standard URLPattern API. Cannot be used with --bl...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.ts index b65929e12..0cfb3c2b8 100644 --- a/src/bin/chrome-devtools-mcp-cli-options.ts +++ b/src/bin/chrome-devtools-mcp-cli-options.ts @@ -205,6 +205,18 @@ export const cliOptions = { describe: 'Additional argu...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -210,6 +210,17 @@ export const cliOptions = { describe: 'Additional arguments for Chrome. Only applies when Chrome is launched by chrome-devtools-mcp.', }, + blocklist: { + type: 'array', + describe: + 'URL patterns to block access to. Uses standard URLPattern API. Cannot be used with --bl...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.ts index b65929e12..0cfb3c2b8 100644 --- a/src/bin/chrome-devtools-mcp-cli-options.ts +++ b/src/bin/chrome-devtools-mcp-cli-options.ts @@ -205,6 +205,18 @@ export const cliOptions = { describe: 'Additional argu...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -210,6 +210,17 @@ export const cliOptions = { describe: 'Additional arguments for Chrome. Only applies when Chrome is launched by chrome-devtools-mcp.', }, + blocklist: { + type: 'array',
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.ts index b65929e12..0cfb3c2b8 100644 --- a/src/bin/chrome-devtools-mcp-cli-options.ts +++ b/src/bin/chrome-devtools-mcp-cli-options.ts @@ -205,6 +205,18 @@ export const cliOptions = { describe: 'Additional argu...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -0,0 +1,241 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:assert/strict'; +import {describe, it} from 'node:test'; + +import {lighthouseAudit} from '../src/tools/lighthouse.js'; +import {navigatePage} from '../src/tools/pages.js'; +import ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts new file mode 100644 index 000000000..fbc2279b3 --- /dev/null +++ b/tests/network_blocking.test.ts @@ -0,0 +1,283 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:asser...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -0,0 +1,241 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:assert/strict'; +import {describe, it} from 'node:test'; + +import {lighthouseAudit} from '../src/tools/lighthouse.js'; +import {navigatePage} from '../src/tools/pages.js'; +import ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts new file mode 100644 index 000000000..fbc2279b3 --- /dev/null +++ b/tests/network_blocking.test.ts @@ -0,0 +1,283 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:asser...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -345,24 +347,27 @@ export class McpContext implements Context { const mcpPage = this.#getMcpPage(page); const newSettings: EmulationSettings = {...mcpPage.emulationSettings}; - if (!options.networkConditions) { - await page.emulateNetworkConditions(null); - delete newSettings.networkConditio...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/src/McpContext.ts b/src/McpContext.ts index 3e7e410a8..4346070d2 100644 --- a/src/McpContext.ts +++ b/src/McpContext.ts @@ -60,6 +60,8 @@ interface McpContextOptions { experimentalIncludeAllPages?: boolean; // Whether CrUX data should be fetched. performanceCrux: boolean; + // Whether allowlist/b...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -100,4 +102,88 @@ describe('browser', () => { await browser.close(); } }); + + describe('Blocking', () => { + const server = serverHooks(); + + it('blocks URLs in blocklist', async () => { + server.addHtmlRoute('/allowed.html', '<html><body>Allowed</body></html>'); + server.addHtmlRou...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/browser.test.ts b/tests/browser.test.ts index 85e9c592f..3c4ed5976 100644 --- a/tests/browser.test.ts +++ b/tests/browser.test.ts @@ -13,6 +13,8 @@ import {executablePath} from 'puppeteer'; import {detectDisplay, ensureBrowserConnected, launch} from '../src/browser.js'; +import {serverHooks} fro...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -100,4 +102,88 @@ describe('browser', () => { await browser.close(); } }); + + describe('Blocking', () => { + const server = serverHooks(); + + it('blocks URLs in blocklist', async () => { + server.addHtmlRoute('/allowed.html', '<html><body>Allowed</body></html>'); + server.addHtmlRou...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/browser.test.ts b/tests/browser.test.ts index 85e9c592f..3c4ed5976 100644 --- a/tests/browser.test.ts +++ b/tests/browser.test.ts @@ -13,6 +13,8 @@ import {executablePath} from 'puppeteer'; import {detectDisplay, ensureBrowserConnected, launch} from '../src/browser.js'; +import {serverHooks} fro...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -345,4 +345,62 @@ describe('cli args parsing', () => { ); assert.strictEqual(disabledArgs.performanceCrux, false); }); + + it('parses blocked-url-pattern flags as array', async () => { + const defaultArgs = parseArguments('1.0.0', ['node', 'main.js']); + assert.strictEqual(defaultArgs.blockedUrlP...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/cli.test.ts b/tests/cli.test.ts index 05f2d3b06..25f07d18e 100644 --- a/tests/cli.test.ts +++ b/tests/cli.test.ts @@ -345,4 +345,94 @@ describe('cli args parsing', () => { ); assert.strictEqual(disabledArgs.performanceCrux, false); }); + + it('parses blocked-url-pattern flags as array',...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -0,0 +1,240 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:assert/strict'; +import {describe, it} from 'node:test'; + +import {lighthouseAudit} from '../src/tools/lighthouse.js'; +import {navigatePage} from '../src/tools/pages.js'; +import ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts new file mode 100644 index 000000000..fbc2279b3 --- /dev/null +++ b/tests/network_blocking.test.ts @@ -0,0 +1,283 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:asser...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -0,0 +1,240 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:assert/strict'; +import {describe, it} from 'node:test'; + +import {lighthouseAudit} from '../src/tools/lighthouse.js'; +import {navigatePage} from '../src/tools/pages.js'; +import ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts new file mode 100644 index 000000000..fbc2279b3 --- /dev/null +++ b/tests/network_blocking.test.ts @@ -0,0 +1,283 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:asser...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -0,0 +1,240 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:assert/strict'; +import {describe, it} from 'node:test'; + +import {lighthouseAudit} from '../src/tools/lighthouse.js'; +import {navigatePage} from '../src/tools/pages.js'; +import ...
bad
review
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts new file mode 100644 index 000000000..fbc2279b3 --- /dev/null +++ b/tests/network_blocking.test.ts @@ -0,0 +1,283 @@ +/** + * @license + * Copyright 2026 Google LLC + * SPDX-License-Identifier: Apache-2.0 + */ + +import assert from 'node:asser...
good
review_fixed
typescript
ChromeDevTools/chrome-devtools-mcp
86eeb4f80670dcfe52170288e8ecbd657c2a38f6
@@ -1,12 +1,12 @@ { "name": "devtools-for-agents", - "description": "Help your agent build, debug, and verify your code correctly. With Chrome DevTools for agents, your AI agent can interact with the Chrome browser to test code, emulate users, and catch bugs using Chrome DevTools’ capabilities before shipping.", +...
bad
review
ChromeDevTools/chrome-devtools-mcp
2d8a46bfdae9cf6ec5803740dc749c1350f1d9ec
diff --git a/.cursor-plugin/plugin.json b/.cursor-plugin/plugin.json index e88830433..fc0aad514 100644 --- a/.cursor-plugin/plugin.json +++ b/.cursor-plugin/plugin.json @@ -6,7 +6,7 @@ "name": "Google Chrome" }, "logo": "https://github.com/ChromeDevTools/devtools-logo/blob/master/logos/svg/chrome-devtools-sq...
good
review_fixed
ChromeDevTools/chrome-devtools-mcp
2d8a46bfdae9cf6ec5803740dc749c1350f1d9ec