repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
CanCanCommunity/cancancan | 778 | issue_to_patch | Drop ActiveRecord4 from CI | This PR removes ActiveRecord4 from the CI, and precedes the removal of AR4 specific code. Rails 4 EOL was in 2017. It makes no sense to keep supporting it. | 6c7b6d89d17ec94bcf6a6a068269064377ed3f58 | 31412760d1db4c645d5d9f46f5c7ac574e3586d5 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 200b7116..08d0a5af 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', 'jruby', 'truffleruby']
- gemfile: ['gemfiles/... | [
".github/workflows/test.yml",
"Appraisals",
"gemfiles/activerecord_4.2.0.gemfile",
"gemfiles/activerecord_5.0.2.gemfile",
"gemfiles/activerecord_5.1.0.gemfile",
"gemfiles/activerecord_5.2.2.gemfile",
"gemfiles/activerecord_6.0.0.gemfile",
"gemfiles/activerecord_6.1.0.gemfile",
"gemfiles/activerecord... | [] | true | ||
CanCanCommunity/cancancan | 777 | issue_to_patch | Swap arguments of some methods to be consistent | In this PR I simply swap two arguments to be consistent across the app. | 3d43db273b390550fa2b52fd8b39f97f3327414e | b198654a0d17cf2b8558bd8369cf9d2b035b3114 | diff --git a/lib/cancan/conditions_matcher.rb b/lib/cancan/conditions_matcher.rb
index 0eca798b..c5bc1e45 100644
--- a/lib/cancan/conditions_matcher.rb
+++ b/lib/cancan/conditions_matcher.rb
@@ -50,20 +50,21 @@ def matches_conditions_hash?(subject, conditions = @conditions)
return adapter.matches_conditions_ha... | [
"lib/cancan/conditions_matcher.rb"
] | [] | true | ||
CanCanCommunity/cancancan | 776 | issue_to_patch | Remove warnings from specs | This PR fixes different warnings raised while executing the tests | 352265f40886f5e710615e378301e78abe9cde0b | 0b8634f913a2e4a186eb8691ade634db88a12aaa | [
"spec/cancan/model_adapters/active_record_adapter_spec.rb"
] | [] | diff --git a/spec/cancan/model_adapters/active_record_adapter_spec.rb b/spec/cancan/model_adapters/active_record_adapter_spec.rb
index 636dbf1f..6fea7554 100644
--- a/spec/cancan/model_adapters/active_record_adapter_spec.rb
+++ b/spec/cancan/model_adapters/active_record_adapter_spec.rb
@@ -263,7 +263,7 @@ class User < ... | true | ||
CanCanCommunity/cancancan | 775 | issue_to_patch | Add more tests for parent-children checks | Extracted again from #767, these tests prove that these checks are currently working. parent-children, when the rule is described using an object, is currently working. | 0563c055fb9131a5271919c3f08a238e1540347a | 4b45aa980ec8b1301e22f3d1fe58451cbe92dc6a | [
"spec/cancan/model_adapters/active_record_adapter_spec.rb"
] | [] | diff --git a/spec/cancan/model_adapters/active_record_adapter_spec.rb b/spec/cancan/model_adapters/active_record_adapter_spec.rb
index af89929c..636dbf1f 100644
--- a/spec/cancan/model_adapters/active_record_adapter_spec.rb
+++ b/spec/cancan/model_adapters/active_record_adapter_spec.rb
@@ -441,6 +441,35 @@ class User <... | true | ||
CanCanCommunity/cancancan | 772 | issue_to_patch | Add support for non-hash conditions | Extracted from the work of @Juleffel on #767, it isolates the fix for non-hash conditions. It also fixes rubocop complains | 5127ee92fc1888acedc593e86bdc4ee4ca883f32 | 154c36587fb63ff14751f4c3f3f903e5cb423ecd | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 84e8b406..56ba01a4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
Unreleased
+* [#772](https://github.com/CanCanCommunity/cancancan/pull/772): Support non-hash conditions in ability definitions. ([@Juleffel][])
* [#773](https://github.com/CanCanCommunity/... | [
"CHANGELOG.md",
"lib/cancan/conditions_matcher.rb",
"spec/cancan/ability_spec.rb"
] | [] | diff --git a/spec/cancan/ability_spec.rb b/spec/cancan/ability_spec.rb
index 7c998fdb..8bfade06 100644
--- a/spec/cancan/ability_spec.rb
+++ b/spec/cancan/ability_spec.rb
@@ -829,4 +829,38 @@ class Account
expect(@ability.send(:rules).size).to eq(0)
end
end
+
+ describe 'when #can? is used with a Hash (... | true | |
CanCanCommunity/cancancan | 773 | issue_to_patch | Drop support for ruby 2.4 and 2.5 | 75d01b523b3aedba0fbb9719718356e57ef9ea67 | 100cbcb162da4c4e6766e9a6f55f0aa020796800 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 216351fe..64bafec0 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- ruby: ['2.4', '2.5', '2.6', '2.7', '3.0', 'jruby', 'truffleruby']
... | [
".github/workflows/test.yml",
".rubocop.yml",
".rubocop_todo.yml",
"CHANGELOG.md",
"cancancan.gemspec",
"spec/cancan/controller_additions_spec.rb",
"spec/cancan/controller_resource_spec.rb"
] | [] | diff --git a/spec/cancan/controller_additions_spec.rb b/spec/cancan/controller_additions_spec.rb
index 013cbbd5..b16c0c7f 100644
--- a/spec/cancan/controller_additions_spec.rb
+++ b/spec/cancan/controller_additions_spec.rb
@@ -30,7 +30,7 @@
it 'load_and_authorize_resource setups a before filter which passes call t... | true | ||
CanCanCommunity/cancancan | 752 | issue_to_patch | Add Ruby 3.0 for CI | Avoid incompatible RoR versions. | 682f20e0e10f193a0648c3cb8ffa89be38491f13 | 5709bd55e4efb6f886818da8802460c4fd63a2ad | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 42280956..8a52ed37 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -14,9 +14,19 @@ jobs:
strategy:
fail-fast: false
matrix:
- ruby: ['2.4', '2.5', '2.6', '2.7', 'jruby', 'truffleruby']
+ ... | [
".github/workflows/test.yml"
] | [] | true | ||
CanCanCommunity/cancancan | 763 | issue_to_patch | Separate Test and Lint | This PR separates Test and Lint to increase the stability of CI.
I believe that lint doesn't need to be run on various Ruby versions, so RuboCop will be run only once. | 19d50fdfb91e4d27a96b2cc18f454ee80aa75b3b | a87da6edf945e88ec0392bce6d7ee7d432b725d8 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 42280956..06f76a87 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,7 +8,7 @@ env:
jobs:
tests:
- name: Test & lint
+ name: Test
runs-on: ubuntu-latest
strategy:
@@ -72,11 +72,27 @@ jobs:
... | [
".github/workflows/test.yml"
] | [] | true | ||
CanCanCommunity/cancancan | 762 | issue_to_patch | Fix some typos | 19d50fdfb91e4d27a96b2cc18f454ee80aa75b3b | cf7c81e659455749e47e4f0129742feac55576ef | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7d4b7312d..5710dfcc5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -166,7 +166,7 @@ Please read the [guide on migrating from CanCanCan 2.x to 3.0](https://github.co
## 1.9.0 (July 20th, 2014)
-* Fix cancancan#59 - Parameters are automatically detected and santitized... | [
"CHANGELOG.md",
"docs/define_abilities_best_practices.md",
"docs/define_check_abilities.md",
"docs/model_adapter.md",
"docs/split_ability.md",
"docs/sql_strategies.md",
"lib/cancan/conditions_matcher.rb",
"lib/cancan/controller_resource.rb",
"lib/cancan/model_adapters/conditions_extractor.rb",
"li... | [] | diff --git a/spec/cancan/controller_additions_spec.rb b/spec/cancan/controller_additions_spec.rb
index 98b2e6643..013cbbd55 100644
--- a/spec/cancan/controller_additions_spec.rb
+++ b/spec/cancan/controller_additions_spec.rb
@@ -139,7 +139,7 @@
expect(@controller_class.cancan_skipper[:load][:article]).to eq({})
... | true | ||
CanCanCommunity/cancancan | 766 | issue_to_patch | verify if activerecord is defined | Fixing problem on rules when the app isn't using ActiveRecord.
There are some recent issues reporting it, for example: https://github.com/CanCanCommunity/cancancan/issues/742.
I think this pr can solve the exception. | 19d50fdfb91e4d27a96b2cc18f454ee80aa75b3b | fd5393feb4d639aa60199f2cded640003769ee69 | diff --git a/lib/cancan/rule.rb b/lib/cancan/rule.rb
index 07063496..18df3895 100644
--- a/lib/cancan/rule.rb
+++ b/lib/cancan/rule.rb
@@ -70,7 +70,7 @@ def only_raw_sql?
end
def with_scope?
- @conditions.is_a?(ActiveRecord::Relation)
+ defined?(ActiveRecord) && @conditions.is_a?(ActiveRecord::Rel... | [
"lib/cancan/rule.rb"
] | [] | true | ||
CanCanCommunity/cancancan | 758 | issue_to_patch | Update Sponsor Logo | InCloudCounsel is now Ontra!
This is to update the company sponsor logo and and href to reflect the company name change.
You can read more about it [here](https://www.ontra.ai/press-release/incloudcounsel-announces-200-million-series-b-funding-from-blackstone-growth-bxg-rebrands-as-ontra/) and also observe that... | 682f20e0e10f193a0648c3cb8ffa89be38491f13 | 8dac8452ce4c355a8a4d75f677c1bdd8ae98686d | diff --git a/README.md b/README.md
index 25434a76..fdd55e9b 100644
--- a/README.md
+++ b/README.md
@@ -56,8 +56,8 @@ of models automatically and reduce duplicated code.
<br />
<br />
<br />
-<a href="https://www.incloudcounsel.com" target="_blank">
- <img src="./logo/in_cloud_counsel.png" alt="InCloudCounsel" heigh... | [
"README.md",
"logo/in_cloud_counsel.png",
"logo/ontra.png"
] | [] | true | ||
CanCanCommunity/cancancan | 759 | issue_to_patch | Update Goboony link | We have a new link to our job page. | 682f20e0e10f193a0648c3cb8ffa89be38491f13 | 9201e8c27f66beb6492ff85770a24bea5d9e2e76 | diff --git a/README.md b/README.md
index 25434a76..0b0ae5f3 100644
--- a/README.md
+++ b/README.md
@@ -44,7 +44,7 @@ of models automatically and reduce duplicated code.
<br/>
<br/>
<br/>
-<a href="https://jobs.goboony.com/fullstack-ruby-on-rails-developer" target="_blank">
+<a href="https://jobs.goboony.com/o/full-s... | [
"README.md"
] | [] | true | ||
CanCanCommunity/cancancan | 765 | issue_to_patch | Fix small typo on file. | Fixes small typo in the word `strategy`. | 19d50fdfb91e4d27a96b2cc18f454ee80aa75b3b | b63e1e6d7a391d509b5eb5095c673c9f3b2d0c71 | diff --git a/docs/sql_strategies.md b/docs/sql_strategies.md
index a013cc4a..57865684 100644
--- a/docs/sql_strategies.md
+++ b/docs/sql_strategies.md
@@ -8,7 +8,7 @@ In the history of CanCanCan we had many issues with different versions of the ge
That's why in the latest versions of CanCanCan, you are given the pos... | [
"docs/sql_strategies.md"
] | [] | true | ||
CanCanCommunity/cancancan | 769 | issue_to_patch | Update link from wiki to docs | 19d50fdfb91e4d27a96b2cc18f454ee80aa75b3b | d7d0904fa290cc125e4540c734e794fc320372eb | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7d4b7312..0d7145b6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -39,7 +39,7 @@
## 3.0.0
-Please read the [guide on migrating from CanCanCan 2.x to 3.0](https://github.com/CanCanCommunity/cancancan/wiki/Migrating-from-CanCanCan-2.x-to-3.0)
+Please read the [guide on... | [
"CHANGELOG.md"
] | [] | true | |||
CanCanCommunity/cancancan | 745 | issue_to_patch | Documentation guides fixes and improvements | 8699ead54f620e4430e22997737267831b1ff783 | 10bd7991c79dc8952b03f7bd7230357b0308c3d8 | diff --git a/docs/Devise.md b/docs/Devise.md
index e3636323..177be0d2 100644
--- a/docs/Devise.md
+++ b/docs/Devise.md
@@ -5,7 +5,7 @@ You should bypass CanCanCan's authorization for Devise controllers:
```ruby
class ApplicationController < ActionController::Base
protect_from_forgery
-
+
check_authorization u... | [
"docs/Devise.md",
"docs/README.md",
"docs/abilities_in_database.md",
"docs/accessible_attributes.md",
"docs/accessing_request_data.md",
"docs/cannot.md",
"docs/changing_defaults.md",
"docs/check_abilities_mistakes.md",
"docs/combine_abilities.md",
"docs/controller_helpers.md",
"docs/debugging.md... | [] | true | |||
CanCanCommunity/cancancan | 754 | issue_to_patch | Extract strategies in separate files | Co-authored-by: @kaspernj
how do I add a co-author if I don't know the email address?? 🤔
Extracted from #691
Compared to the original PR I opted to load all the strategies by default (is not much code anyway) and call the strategy just Base since is already namespaced. | 8699ead54f620e4430e22997737267831b1ff783 | 7caf27a77e39b4a7bf6fcae2637b956a6ddf71d8 | diff --git a/lib/cancan.rb b/lib/cancan.rb
index 80d7a24dc..76d72af77 100644
--- a/lib/cancan.rb
+++ b/lib/cancan.rb
@@ -21,4 +21,7 @@
require 'cancan/model_adapters/active_record_adapter'
require 'cancan/model_adapters/active_record_4_adapter'
require 'cancan/model_adapters/active_record_5_adapter'
+ require... | [
"lib/cancan.rb",
"lib/cancan/model_adapters/abstract_adapter.rb",
"lib/cancan/model_adapters/active_record_5_adapter.rb",
"lib/cancan/model_adapters/active_record_adapter.rb",
"lib/cancan/model_adapters/strategies/base.rb",
"lib/cancan/model_adapters/strategies/left_join.rb",
"lib/cancan/model_adapters/... | [] | true | ||
CanCanCommunity/cancancan | 750 | issue_to_patch | Add EditorConfig file | More info here: https://editorconfig.org/
Also fix some whitespaces. | 8699ead54f620e4430e22997737267831b1ff783 | 91de39612774b31af147aa10da001723c7d4089c | diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 00000000..b372c226
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,10 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+max_line_length = 120
d... | [
".editorconfig",
"CONTRIBUTING.md",
"README.md"
] | [] | true | ||
CanCanCommunity/cancancan | 753 | issue_to_patch | Update accessible_attributes.md | Previous described syntax doesn't work. | 8699ead54f620e4430e22997737267831b1ff783 | 9873e2fba86d9a9ba491576a5cc31961b8436547 | diff --git a/docs/accessible_attributes.md b/docs/accessible_attributes.md
index d97273fd..cd0604f2 100644
--- a/docs/accessible_attributes.md
+++ b/docs/accessible_attributes.md
@@ -5,7 +5,7 @@ CanCanCan gives you the possibility to define actions on single instances' attri
Given you want users to only read a user fi... | [
"docs/accessible_attributes.md"
] | [] | true | ||
CaptnCodr/Fli | 87 | issue_to_patch | Propagate cancellation token instead of defining cancelAfter
**Describe the solution you'd like**
I'd like to reuse a cancellation token instead of defining the [cancelAfter](https://github.com/CaptnCodr/Fli?tab=readme-ov-file#builder-operations) information at the CE level.
**Describe alternatives you've considered... | Provide executeAsync with a cancellationToken. | Closes #79 | e689eb1adf78b6d5290cbcab0767151355191550 | ae9629b38cc1dafeb4647fdd58636788ac54c90d | diff --git a/README.md b/README.md
index 3c8ce2f..bc0374b 100644
--- a/README.md
+++ b/README.md
@@ -164,7 +164,23 @@ cli {
}
|> Command.execute
```
+___
+**NOTE** with using `Command.executeAsync`:
+providing `Command.executeAsync` with a `CancellationToken` will result in ignoring `CancelAfter` in the context:
+... | [
"README.md",
"paket.lock",
"src/Fli.Tests/ExecContext/ExecCommandExecuteWindowsTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteWindowsTests.fs",
"src/Fli/Command.fs",
"src/Fli/Output.fs"
] | [] | true | |
CaptnCodr/Fli | 86 | issue_to_patch | `Command.execute` fails if `Input` contains any curly braces
**Describe the bug**
`Command.execute` fails if `Input` contains any curly braces.
**Repro steps**
Run the following F# script file:
```fs
#r "nuget: Fli,1.1000.0"
open Fli
cli {
Exec "cat"
Input "{"
}
|> Command.execute
```
**Expected behavior*... | Remove encoding from input | Fixes #85
This will remove the encoding from arguments of the `Writeline` function when using `Input`.
Use `StandardInputEncoding` in NET for encoding, others will be used already. | 2097f73ec819189b82469ac92411a775cff75490 | a1d039a3e35307100d9def63ff0127ac62535cb6 | diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs
index 20a63c4..5968107 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs
@@ -138,6 +138,... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteUnixTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteWindowsTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Tests/ShellContext/ShellCommandExecuteWindowsTests.fs",
"src/Fli/Command.fs... | [] | true | |
CaptnCodr/Fli | 84 | issue_to_patch | Update dependencies | - upgrade to `net10.0`
- update paket
- update fantomas
- remove target framework `net8.0` | 6cd52c9e32e3e96a7db750bbbe1b50506fe7fac0 | be910c41101f0f231948fda73135ab1abd76c613 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 8ca7b8d..23ae3e1 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,14 +3,14 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "9.0.2",
+ "version": "10.3.1",
"commands": [
"paket"... | [
".config/dotnet-tools.json",
".github/workflows/build.yml",
".paket/Paket.Restore.targets",
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | ||
CaptnCodr/Fli | 82 | issue_to_patch | Upgrade to `net9.0` and use F#9
Upgrade `.fsproj` to `net9.0` and use dotnet 9.x in pipeline. | Update to .NET9 | Hey,
You will find my attempt at upgrading the project to .net9 (linked to this issue #81).
Let's see if it passes on the 1st try and if not I will look into fixing it. | 672b4f9725b049e93fb9b97d7e1d5ef58e12ab68 | 455bd0a009f37a8091cbebbb40a77dfec0136d86 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 691f3b9..eab8acd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest, macOS-latest, ubuntu-latest]
- dotnet: [8.0.100]
+ ... | [
".github/workflows/build.yml",
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli/Command.fs",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [
{
"comment": "You can remove `net6.0` and `net7.0` here.",
"path": "paket.dependencies",
"hunk": "@@ -1,10 +1,10 @@\n source https://api.nuget.org/v3/index.json\n-framework: net6.0, net7.0, net8.0, netstandard2.0, netstandard2.1\n+framework: net6.0, net7.0, net8.0, net9.0, netstandard2.0, netstandard2.1... | true | |
CaptnCodr/Fli | 82 | comment_to_fix | Update to .NET9 | You can remove `net6.0` and `net7.0` here. | 672b4f9725b049e93fb9b97d7e1d5ef58e12ab68 | 455bd0a009f37a8091cbebbb40a77dfec0136d86 | diff --git a/paket.dependencies b/paket.dependencies
index 521a6cb..d97e72c 100644
--- a/paket.dependencies
+++ b/paket.dependencies
@@ -1,5 +1,5 @@
source https://api.nuget.org/v3/index.json
-framework: net6.0, net7.0, net8.0, netstandard2.0, netstandard2.1
+framework: net8.0, net9.0, netstandard2.0, netstandard2.1
... | [
"paket.dependencies"
] | [
{
"comment": "You can remove `net6.0` and `net7.0` here.",
"path": "paket.dependencies",
"hunk": "@@ -1,10 +1,10 @@\n source https://api.nuget.org/v3/index.json\n-framework: net6.0, net7.0, net8.0, netstandard2.0, netstandard2.1\n+framework: net6.0, net7.0, net8.0, net9.0, netstandard2.0, netstandard2.1... | true | ||
CaptnCodr/Fli | 80 | issue_to_patch | Add stream option | Hello,
I have added a new option that allows a process to stream its output to a specified source.
Basically I just duplicated the `Output` option and passed the given function to the `OutputDataReceived` and `ErrorDataReceived` callbacks. | 334b1bc12456bae53cc59db22dd23ed9434343a9 | 05cadf90628464586ba04829c63840eeae12b2c4 | diff --git a/README.md b/README.md
index 7247bfd..3c8ce2f 100644
--- a/README.md
+++ b/README.md
@@ -98,6 +98,36 @@ cli {
|> Command.execute
```
+Write output to a stream:
+```fsharp
+// using a console stream
+cli {
+ Exec "dotnet"
+ Arguments "--list-sdks"
+ Output (new StreamWriter(Console.OpenStandardO... | [
"README.md",
"src/Fli.Tests/ShellContext/ShellCommandExecuteWindowsTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Output.fs"
] | [
{
"comment": "Typo in `Stream`.",
"path": "src/Fli/CE.fs",
"hunk": "@@ -55,6 +55,25 @@ module CE =\n member _.Output(context: ICommandContext<ShellContext>, func: string -> unit) =\n Cli.output (Custom func) context.Context\n \n+ /// Extra `Output` that is being executed immed... | true | ||
CaptnCodr/Fli | 80 | comment_to_fix | Add stream option | Typo in `Stream`. | 334b1bc12456bae53cc59db22dd23ed9434343a9 | 05cadf90628464586ba04829c63840eeae12b2c4 | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index 3b98d9e..16a6dcc 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -4,6 +4,7 @@
module CE =
open System.Text
+ open System.IO
open Domain
type ICommandContext<'a> with
@@ -55,6 +56,11 @@ module CE =
member _.Output(context: ICommandContext... | [
"src/Fli/CE.fs"
] | [
{
"comment": "Typo in `Stream`.",
"path": "src/Fli/CE.fs",
"hunk": "@@ -55,6 +55,25 @@ module CE =\n member _.Output(context: ICommandContext<ShellContext>, func: string -> unit) =\n Cli.output (Custom func) context.Context\n \n+ /// Extra `Output` that is being executed immed... | true | ||
CaptnCodr/Fli | 80 | comment_to_fix | Add stream option | Update function comments. | 334b1bc12456bae53cc59db22dd23ed9434343a9 | 05cadf90628464586ba04829c63840eeae12b2c4 | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index 3b98d9e..16a6dcc 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -4,6 +4,7 @@
module CE =
open System.Text
+ open System.IO
open Domain
type ICommandContext<'a> with
@@ -55,6 +56,11 @@ module CE =
member _.Output(context: ICommandContext... | [
"src/Fli/CE.fs"
] | [
{
"comment": "Update function comments.",
"path": "src/Fli/CE.fs",
"hunk": "@@ -55,6 +55,25 @@ module CE =\n member _.Output(context: ICommandContext<ShellContext>, func: string -> unit) =\n Cli.output (Custom func) context.Context\n \n+ /// Extra `Output` that is being execut... | true | ||
CaptnCodr/Fli | 80 | comment_to_fix | Add stream option | Same with the comments here. | 334b1bc12456bae53cc59db22dd23ed9434343a9 | 05cadf90628464586ba04829c63840eeae12b2c4 | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index 3b98d9e..16a6dcc 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -4,6 +4,7 @@
module CE =
open System.Text
+ open System.IO
open Domain
type ICommandContext<'a> with
@@ -55,6 +56,11 @@ module CE =
member _.Output(context: ICommandContext... | [
"src/Fli/CE.fs"
] | [
{
"comment": "Same with the comments here.",
"path": "src/Fli/CE.fs",
"hunk": "@@ -127,6 +146,24 @@ module CE =\n member _.Output(context: ICommandContext<ExecContext>, func: string -> unit) =\n Program.output (Custom func) context.Context\n \n+ [<CustomOperation(\"Stream\")>]... | true | ||
CaptnCodr/Fli | 78 | issue_to_patch | Add `CONTRIBUTING.md`
There doesn't need to be a formal `CONTRIBUTING.md` file, but it would be nice to have some additional build instructions in Markdown or as script automation. `build.fsx` appears to be used for pushing to NuGet?
For example, running
```
dotnet test .\src\Fli.Tests\
```
on a clean clone yields
... | Add contribution section in readme | Closes #77. | d130484a2daaf1d9645f2b7e803e784ac1d451ce | 9648df1d1cfee88638f1edb552e634a26d1f1046 | diff --git a/README.md b/README.md
index 7954c14..7247bfd 100644
--- a/README.md
+++ b/README.md
@@ -294,5 +294,17 @@ Provided `Fli.WindowStyle`:
### Do you miss something?
Open an [issue](https://github.com/CaptnCodr/Fli/issues) or start a [discussion](https://github.com/CaptnCodr/Fli/discussions).
+### Contributi... | [
"README.md"
] | [] | true | |
CaptnCodr/Fli | 76 | issue_to_patch | Feature: Strongly-typed Arguments
I recently encountered the behavior regarding `"` with [ProcessStartInfo.Arguments](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.arguments?view=net-9.0#examples). I was trying to pass an argument to a program while keeping `"` preserved.
```fsharp
... | Use ProcessStartInfo.ArgumentList if NET (>= net5.0) | Closes #75. | 47b4f39e9ec897841169db7dca0e1332a4f00122 | bc2f7a91564104ddcfb292f46ba846f981b7602f | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 41785ce..8ca7b8d 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,16 +3,18 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "8.0.0",
+ "version": "9.0.2",
"commands": [
"paket"
... | [
".config/dotnet-tools.json",
".paket/Paket.Restore.targets",
"paket.lock",
"src/Fli.Tests/ExecContext/ExecCommandConfigureUnixTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteUnixTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExec... | [] | true | |
CaptnCodr/Fli | 74 | issue_to_patch | Arguments with space cause trouble
**Describe the bug**
From the docs:
```
cli {
Exec "git"
Arguments ["commit"; "-m"; "Fixing issue #1337."]
}
|> Command.execute
```
gives the error
```
val it: Output =
{ Id = 83741
Text = None
ExitCode = 1
Error =
Some
"error: paths... | Improve documentation | Fixes #73 | 987706c751e106057100af395d36655fdf636cb3 | 8a9c0a9ab7edb3a775acc0bdb1b3c44d6d9c8966 | diff --git a/README.md b/README.md
index 32ce163..7954c14 100644
--- a/README.md
+++ b/README.md
@@ -53,7 +53,7 @@ an example with `git`:
```fsharp
cli {
Exec "git"
- Arguments ["commit"; "-m"; "Fixing issue #1337."]
+ Arguments ["commit"; "-m"; "\"Fixing issue #1337.\""]
}
|> Command.execute
```
@@ -22... | [
"README.md"
] | [] | true | |
CaptnCodr/Fli | 72 | issue_to_patch | Implement Zero value for computation expression.
Would it be possible to implement the `Zero` value for the cli computation expression? This is needed for letting other values be added conditionally.
In my current process, I'm trying to add the output logging if the user specifies a log file. and it would allow th... | Empty file output will not write to file | Closes #69
This will add the ability to have `Outputs` cases in `Fli` CE, this code is now legal:
- `Output ""`
- `Output Outputs.File(null)`
- `Output Outputs.File("")`
this will be treated the same as just not having an `Output`. | d8fb46c669186d97bf97f4aeca68d6fdb5eceaf0 | ce408bf15c72e9ae541c24b16ee46f1247bde76f | diff --git a/README.md b/README.md
index 7a08f91..32ce163 100644
--- a/README.md
+++ b/README.md
@@ -103,9 +103,11 @@ Add environment variables for the executing program:
cli {
Exec "git"
EnvironmentVariables [("GIT_AUTHOR_NAME", "Jon Doe"); ("GIT_AUTHOR_EMAIL", "jon.doe@domain.com")]
+ Output ""
}
|> C... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandConfigureUnixTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandConfigureUnixTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandConfigureWindo... | [] | true | |
CaptnCodr/Fli | 71 | issue_to_patch | Cannot pass data on stdin to a program with Exec
Hi,
I testing your library for scripting purposes, and I found a small bug. In short, you can't pass data on stdin to a command (at least on Linux and Mac OS X where I tried it).
I have a PR to fix the bug and increase test coverage for Linux and Mac OS X which I... | Ensure standard in is always redirected when there is input | Fixes #70
Previously standard in was only being opened when there were argument or environment variables. If there was a value in the "Input" parameter, but no arguments or environment variables, an exception was thrown about standard input not being redirected. This made it impossible to write code like below to pi... | c39d2636e45293591e8dcb172fd0fbcd0cf5e26f | 8c1b94dd56bce0f7cc8461c212f1164790086767 | diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
deleted file mode 100644
index 0452eb5..0000000
--- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
+++ /dev/null
@@ -1,174 +0,0 @@
-module Fli.Tests.ExecContext.ExecCommandConfigureTes... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandConfigureUnixTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandConfigureWindowsTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteUnixTests.fs",
"src/... | [] | true | |
CaptnCodr/Fli | 68 | issue_to_patch | add sh and zsh, add Linux's pwsh, always quote default shell | This PR introduces a breaking change to always quote Command passed to a custom shell.
Comments and discussion welcome. | 307b5eeeb26295ee6ddc1f26e9933dc386488ef8 | 019ddaad4cdd87959042b1f177c3dbf8641bcf4f | diff --git a/README.md b/README.md
index 799c291..480a04c 100644
--- a/README.md
+++ b/README.md
@@ -273,7 +273,9 @@ Currently provided `Fli.Shells`:
- `PS` runs `powershell.exe -Command ...`
- `PWSH` runs `pwsh.exe -Command ...`
- `WSL` runs `wsl.exe -- ...`
+- `SH` runs `sh -c ...`
- `BASH` runs `bash -c ...`
+- ... | [
"README.md",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandToStringTests.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | ||
CaptnCodr/Fli | 67 | issue_to_patch | Added WindowStyle | - #64
I've attempted to add this myself. I've tested it and it appears to work.
* Added WindowStyle. Defaults to Hidden
* Added to ShellConfig and ExecConfig
* Added unit tests
This is my first attempt at updating a CE! Any feedback is welcome. | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/README.md b/README.md
index a374eb4..799c291 100644
--- a/README.md
+++ b/README.md
@@ -124,6 +124,15 @@ cli {
|> Command.execute
```
+For Windows applications it's possible to set their visibility. There are four possible values: `Hidden`, `Maximized`, `Minimized` and `Normal`. The default is `Hidden`... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Dsl.fs"
] | [
{
"comment": "`Exec \"cmd.exe\"`",
"path": "src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"hunk": "@@ -35,6 +35,16 @@ let ``Check WorkingDirectory in ProcessStartInfo with WorkingDirectory`` () =\n |> _.WorkingDirectory\n |> should equal @\"C:\\Users\"\n \n+[<Test>]\n+let ``Check Wind... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | `Exec "cmd.exe"` | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
index bb3da1e..0452eb5 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
@@ -28,13 +28,23 @@ let ``Check Arguments i... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs"
] | [
{
"comment": "`Exec \"cmd.exe\"`",
"path": "src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"hunk": "@@ -35,6 +35,16 @@ let ``Check WorkingDirectory in ProcessStartInfo with WorkingDirectory`` () =\n |> _.WorkingDirectory\n |> should equal @\"C:\\Users\"\n \n+[<Test>]\n+let ``Check Wind... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | `WindowStyle` | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
index bb3da1e..0452eb5 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
@@ -28,13 +28,23 @@ let ``Check Arguments i... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs"
] | [
{
"comment": "`WindowStyle`",
"path": "src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"hunk": "@@ -35,6 +35,16 @@ let ``Check WorkingDirectory in ProcessStartInfo with WorkingDirectory`` () =\n |> _.WorkingDirectory\n |> should equal @\"C:\\Users\"\n \n+[<Test>]\n+let ``Check Window St... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | `WindowStyle` | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/src/Fli.Tests/ExecContext/ExecConfigTests.fs b/src/Fli.Tests/ExecContext/ExecConfigTests.fs
index cd2b05c..b9bbc60 100644
--- a/src/Fli.Tests/ExecContext/ExecConfigTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecConfigTests.fs
@@ -54,6 +54,14 @@ let ``Check working directory config for executing program`` () ... | [
"src/Fli.Tests/ExecContext/ExecConfigTests.fs"
] | [
{
"comment": "`WindowStyle`",
"path": "src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"hunk": "@@ -54,6 +54,14 @@ let ``Check working directory config for executing program`` () =\n |> _.config.WorkingDirectory\n |> should equal (Some @\"C:\\Users\")\n \n+[<Test>]\n+let ``Check window style conf... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | `WindowStyle` | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index c0f4c67..066716e 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -56,6 +56,12 @@ module CE =
member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) =
Cli.workingDirectory workingDirectory context.Context
+ ///... | [
"src/Fli/CE.fs"
] | [
{
"comment": "`WindowStyle`",
"path": "src/Fli/CE.fs",
"hunk": "@@ -56,6 +56,12 @@ module CE =\n member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) =\n Cli.workingDirectory workingDirectory context.Context\n \n+ /// The `windowsstyle` for newly... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | `WindowStyle` | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index c0f4c67..066716e 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -56,6 +56,12 @@ module CE =
member _.WorkingDirectory(context: ICommandContext<ShellContext>, workingDirectory) =
Cli.workingDirectory workingDirectory context.Context
+ ///... | [
"src/Fli/CE.fs"
] | [
{
"comment": "`WindowStyle`",
"path": "src/Fli/CE.fs",
"hunk": "@@ -118,6 +124,12 @@ module CE =\n member _.WorkingDirectory(context: ICommandContext<ExecContext>, workingDirectory) =\n Program.workingDirectory workingDirectory context.Context\n \n+ /// The `windowsstyle` for ... | true | ||
CaptnCodr/Fli | 67 | comment_to_fix | Added WindowStyle | Align this pipe with the other pipes. | d0de1c3cee3dc57aa363a7f7a1076de28faa6bcc | 6d5704e44d5fbb1fe253f26dbd879988c1ff205a | diff --git a/README.md b/README.md
index a374eb4..799c291 100644
--- a/README.md
+++ b/README.md
@@ -124,6 +124,15 @@ cli {
|> Command.execute
```
+For Windows applications it's possible to set their visibility. There are four possible values: `Hidden`, `Maximized`, `Minimized` and `Normal`. The default is `Hidden`... | [
"README.md"
] | [
{
"comment": "Align this pipe with the other pipes.",
"path": "README.md",
"hunk": "@@ -252,6 +262,7 @@ cli {\n | `Username` | `string` |\n | `Credentials` | `string * string * string` |\n | `WorkingDirect... | true | ||
CaptnCodr/Fli | 62 | issue_to_patch | New year's work | 058f76348a90c934d8c301e465311dd94fd48e8e | 9bfc501e06a387aa14194fbe6898f3bba4116105 | diff --git a/.gitignore b/.gitignore
index dfcfd56..e23a889 100644
--- a/.gitignore
+++ b/.gitignore
@@ -348,3 +348,6 @@ MigrationBackup/
# Ionide (cross platform F# VS Code tools) working folder
.ionide/
+
+# Rider's working folder.
+.idea/
\ No newline at end of file
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.... | [
".gitignore",
"RELEASE_NOTES.md",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | |||
CaptnCodr/Fli | 61 | issue_to_patch | Add new logo | 65c54efae453a929f6b9b43968c96988165368c1 | 30ae0f533f97866b9c2792ff7105fcd724a2c623 | diff --git a/logo.png b/logo.png
index 305a26c..28591e7 100644
Binary files a/logo.png and b/logo.png differ
| [
"logo.png"
] | [] | true | |||
CaptnCodr/Fli | 60 | issue_to_patch | Update to .NET8 | c82dba149598ef2bec61f8a9613e00427008cc5c | aabe7953ac098ab9a289d44de2fecb228b644c4a | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index c91157a..41785ce 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "7.2.1",
+ "version": "8.0.0",
"commands": [
"paket"
... | [
".config/dotnet-tools.json",
".github/workflows/build.yml",
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli... | [] | true | |||
CaptnCodr/Fli | 59 | issue_to_patch | Add throw function to interrupt pipeline on error | - [x] Add some docs to this | da518e6facab885581e56d7f2cbfae5e5295408a | b0743a2f12a36c4425aa622525062fcc8b6a5baf | diff --git a/README.md b/README.md
index 27e32cf..1ae7e2d 100644
--- a/README.md
+++ b/README.md
@@ -157,6 +157,33 @@ cli { ... }
|> Output.toError // "This is an error!"
```
+#### `Output` functions
+```fsharp
+throwIfErrored: Output -> Output
+throw: (Output -> bool) -> Output -> Output
+```
+
+`Output.throw` and... | [
"README.md",
"paket.lock",
"src/Fli/Output.fs"
] | [] | true | ||
CaptnCodr/Fli | 58 | issue_to_patch | `Command.executeAsync` does not await output
First of all, I would like to say thanks for creating this library. It has been super useful for me.
When using the `Command.executeAsync` function, it seems like the output of the command is not awaited.
Running the example program:
```fsharp
open Fli
let mainAs... | `Command.ExecuteAsync` stdout and stderr content now gets returned | This is an initial attempt at fixing the `Command.ExecuteAsync` not properly returning the the stdout content. I have updated the tests to return `Async<Unit>` so the results are awaited.
Fixes #57 | 4a97793f69a39d10b9d042c4a5019b7a503271f7 | b991709e9481ad349b461841125f1ea97ce14c6d | diff --git a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
index a6671f9..021a05b 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
@@ -107,9 +107,9 @@ let ``Hello World with executin... | [
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs"
] | [] | true | |
CaptnCodr/Fli | 56 | issue_to_patch | How would I open an HTML page in the default browser?
Hi I'm trying to open an HTML file in the default browser.
```fsharp
cli {
Exec @"<full path to HTML file>"
}
|> Command.execute
```
The above gives me the following exception:
```
System.ComponentModel.Win32Exception (193): An error occurred tr... | Open files in default/assigned program in `Exec` | Closes #55 | e6d6d989eb1392b0815096179412d2f889e4dc8f | 3d47411849672dd9d6dfff03d22cdd580e5115dc | diff --git a/README.md b/README.md
index bea696b..27e32cf 100644
--- a/README.md
+++ b/README.md
@@ -66,6 +66,14 @@ cli {
}
|> Command.execute
```
+or open a file in the default/assigned program:
+```fsharp
+cli {
+ Exec "test.pdf"
+}
+|> Command.execute
+```
+(Hint: if file extension is not assigned to any insta... | [
"README.md",
"src/Fli/Command.fs"
] | [] | true | |
CaptnCodr/Fli | 53 | issue_to_patch | No need to quote the bash command anymore | 9291a04082ac17f41e3177f96d9e1be240f320d0 | 079d93fc9eec1606ff6076bdd08a005ecd945d48 | diff --git a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
index 5c1eaf9..7747286 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
@@ -7,6 +7,7 @@ open System
open System.Co... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandConfigureTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandToStringTests.fs",
"src/Fli/Command.fs"
] | [] | true | |||
CaptnCodr/Fli | 50 | issue_to_patch | Make executeAsync cancellable. | - Add `CancelAfter` CustomOperation which takes `int` in milliseconds for the timeout | 36ab51e6bb30a39faf62e1df5d944538a590c7f1 | f37a77a291ac225f985095a8135fb493982f8257 | diff --git a/README.md b/README.md
index d7edafe..bea696b 100644
--- a/README.md
+++ b/README.md
@@ -203,6 +203,7 @@ cli {
| `EnvironmentVariable` | `string * string` |
| `EnvironmentVariables` | `(string * string) list` |
| `Encoding` | `System.Text.Encoding` |
+| `CancelAfter` ... | [
"README.md",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Dsl.fs",
"src/Fli/Fli.fsproj",
"src/Fli/Output.fs"
] | [] | true | ||
CaptnCodr/Fli | 51 | issue_to_patch | Can't use custom func as output
Trying to use a custom function in Output I am getting the following exception:
```
System.Exception: Cannot convert output type.
at Fli.CE.ICommandContext`1.outputTypeMapping[a,a](ICommandContext`1 _, a output)
at Fli.CE.ICommandContext`1.Output[a,a](ICommandCo... | CustomOperation for each output type. | Closes #49 | ec9e8c55a67b48b00c8946821b99ee9145d9fac3 | fb5efd71ab17e380dd7c68907147cf03f1122af5 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index fc4946e..c91157a 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "7.1.5",
+ "version": "7.2.1",
"commands": [
"paket"
... | [
".config/dotnet-tools.json",
"README.md",
"src/Fli/CE.fs"
] | [] | true | |
CaptnCodr/Fli | 48 | issue_to_patch | FSharp.Core, Version=7.0.0.0
I currently have a deployment with the following .NET SDKs available:
```bash
dotnet --list-sdks
3.1.404
5.0.403
6.0.400
```
When running a Fli test with version 1.0.0 and 0.11.0, I get the following error:
```bash
Unhandled exception. System.IO.FileLoadException: Could not load f... | Tie FSharp.Core to v6.0 for building with .NET6. | Fixes #47. | 32e3301127cd6022947251cceb3ff8d7dcd10d64 | e110830320c716d8e0fb95a8b87637e0b92328d7 | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index c740de2..124a5d7 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -1,36 +1,39 @@
-v1.0.0.0 - Dec 18 2022
+v1.0.1.0 - Feb 02, 2023
+- Fix FSharp.Core to v6.0. (https://github.com/CaptnCodr/Fli/issues/47)
+
+v1.0.0.0 - Dec 18, 2022
- Add `CUSTOM` shell in `Sh... | [
"RELEASE_NOTES.md",
"paket.dependencies",
"paket.lock",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | |
CaptnCodr/Fli | 46 | issue_to_patch | Run custom shell | Provide DU case for custom shell for the user | Closes #44 | 3b5d89e4dc962ed43c39aa128fe8c19b177e3bff | b3e17b3df07f492d8a72ba3d746501ae2d86118a | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 3ca3f2c..fc4946e 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fantomas": {
- "version": "5.1.3",
+ "version": "5.1.4",
"commands": [
"fantomas"
]
dif... | [
".config/dotnet-tools.json",
"README.md",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Helpers.fs"
] | [] | true | |
CaptnCodr/Fli | 45 | issue_to_patch | Provide printing method for each field in output for shorter code. | 9022c207924281cb010a46e449541ca5479325b8 | 25169db07f6f602193a143eb07bb3de61cbfe693 | diff --git a/src/Fli/Domain.fs b/src/Fli/Domain.fs
index 2952699..0069088 100644
--- a/src/Fli/Domain.fs
+++ b/src/Fli/Domain.fs
@@ -89,11 +89,23 @@ module Domain =
/// Gets `Id` from `Output`.
static member toId(output: Output) = output.Id
+ /// Prints `Id` from `Output`.
+ static mem... | [
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 43 | issue_to_patch | Update Fantomas and reformat code. | ae8dea1346b754184ed1b6f7f188aaef9dd4ec05 | 240a2efae23f158cc2c5dc21ece2c968a37a7603 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 29c5720..3ca3f2c 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fantomas": {
- "version": "5.1.0",
+ "version": "5.1.3",
"commands": [
"fantomas"
]
dif... | [
".config/dotnet-tools.json",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 42 | issue_to_patch | NET7.0 support. | cb73b73d09187b5f8e0f3ce5b2ca7344bc42ec76 | 43403f83261b12cb1b3b05cfad4d939246297fd9 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 17a037e..b23b649 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-latest, macOS-latest, ubuntu-latest]
- dotnet: [6.0.401]
+ ... | [
".github/workflows/build.yml",
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | |||
CaptnCodr/Fli | 41 | issue_to_patch | Add custom function as an output. | c491302f360647c0e6959c828b206721041605dc | 393fd36a0f869d1ad36fb23c39141f31881c7839 | diff --git a/README.md b/README.md
index 94381d4..b35cb36 100644
--- a/README.md
+++ b/README.md
@@ -156,7 +156,7 @@ cli {
| `Shell` | `Fli.Shells` |
| `Command` | `string` |
| `Input` | `string` |
-| `Output` ... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 40 | issue_to_patch | Add StringBuilder as Output type. | 6e32cfdfa00ceae0307bab7f77e5899128d22940 | 13c0f9e455d63f5025d77bfcbac541f3fb45a3ca | diff --git a/README.md b/README.md
index abea365..94381d4 100644
--- a/README.md
+++ b/README.md
@@ -151,16 +151,16 @@ cli {
#### Builder operations:
`ShellContext` operations (`cli { Shell ... }`):
-| Operation | Type |
-|------------------------|--------------------------|
-| `She... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 39 | issue_to_patch | File to outputs. | 515631b1e54e9ad400f0492ce2ae9aad659c3b42 | 09a28cea7dafecc7aade0248e312a85efe7c1947 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 6b30063..29c5720 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fantomas": {
- "version": "5.0.6",
+ "version": "5.1.0",
"commands": [
"fantomas"
]
dif... | [
".config/dotnet-tools.json",
"README.md",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/ShellContext/ShellConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Dsl.fs"
] | [] | true | |||
CaptnCodr/Fli | 37 | issue_to_patch | Write output into file | Add `Output` to CE. | Parameter is for a string with an absolute path to the file.
Closes #36. | 5cd901e715c46547cbe1d7aac1964a4fa67279c4 | 1807ba02929d86a8503749292357c3fdd21bd880 | diff --git a/README.md b/README.md
index 27d28a5..b8b3bc1 100644
--- a/README.md
+++ b/README.md
@@ -65,6 +65,16 @@ cli {
|> Command.execute
```
+Write output to a specific file:
+```fsharp
+cli {
+ Exec "dotnet"
+ Arguments "--list-sdks"
+ Output @"absolute\path\to\dotnet-sdks.txt"
+}
+|> Command.execute
... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/ShellContext/ShellConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Dsl.fs"
] | [] | true | |
CaptnCodr/Fli | 34 | issue_to_patch | Add logo for Nuget package | Add logo & update dependencies. | Closes #33. | ab0f28ddaa24896b1756282f9e722dc412b4f7b4 | b171ba49ec732a31817f2cc15f0e6988129c8802 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 672eb20..6b30063 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fantomas": {
- "version": "5.0.3",
+ "version": "5.0.6",
"commands": [
"fantomas"
]
dif... | [
".config/dotnet-tools.json",
"logo.png",
"paket.lock",
"src/Fli/paket.template"
] | [] | true | |
CaptnCodr/Fli | 32 | issue_to_patch | Trim line breaks at the end of the output text
`Output.Text` has a line break in shell context at the end. Just trim it. | Trim Output.Text and Output.Error. | Closes #30. | dc7b39b2bf647bb57043a60ae48e27a7a3003b31 | 46741955f647b06c00a850fa7a07ce8d3f9215a4 | diff --git a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
index 27318f0..4c75b01 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
@@ -15,7 +15,7 @@ let ``Hello World with executing ... | [
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs"
] | [] | true | |
CaptnCodr/Fli | 31 | issue_to_patch | Add `WSL` as Shell | Add `WSL` support. | Closes #29. | e9b72539fd0f1c8cf671f8367dd96e11c1a1d56f | 43bed1ac7ff4fa5bd818f5cf18b4795be2866cc8 | diff --git a/README.md b/README.md
index 952c989..0db387e 100644
--- a/README.md
+++ b/README.md
@@ -161,6 +161,7 @@ Currently provided `Fli.Shells`:
- `CMD` runs `cmd.exe /c ...` or `cmd.exe /k ...` (depends if `Input` is provided or not)
- `PS` runs `powershell.exe -Command ...`
- `PWSH` runs `pwsh.exe -Command ..... | [
"README.md",
"src/Fli.Tests/ShellContext/ShellCommandToStringTests.fs",
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |
CaptnCodr/Fli | 28 | issue_to_patch | Refactorings for Command.fs | 6d3bd30d4c7c7423324c1d4cebe248ede229c10b | c0e41146c945f84d426ae76dce907cc0bdf7b5e8 | diff --git a/src/Fli/Command.fs b/src/Fli/Command.fs
index 609851b..a981be9 100644
--- a/src/Fli/Command.fs
+++ b/src/Fli/Command.fs
@@ -5,12 +5,12 @@ module Command =
open Domain
open Helpers
+ open Extensions
open System
open System.IO
open System.Text
open System.Diagnostics
o... | [
"src/Fli/Command.fs",
"src/Fli/Extensions.fs",
"src/Fli/Fli.fsproj"
] | [] | true | |||
CaptnCodr/Fli | 27 | issue_to_patch | New field in `Output`: `Id` from `Process.Id` | Add Id to output. | Closes #26. | e9c2029600c8d25374a1f6d3f4aa612fad4b8aa2 | 036b222a67bc139e18193ca29d37e36342a524b9 | diff --git a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
index 237d613..27318f0 100644
--- a/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
+++ b/src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs
@@ -19,6 +19,19 @@ let ``Hello World with executing... | [
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |
CaptnCodr/Fli | 25 | issue_to_patch | Add Readme & Release notes to package | Add README.md to paket.template and add release notes to it. | Closes #24. | 01d949e32014615c4b8ce533ee1283b3c7866bea | 0c0753229e8a382f5786b2674fc032456bbadb19 | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
new file mode 100644
index 0000000..f770db7
--- /dev/null
+++ b/RELEASE_NOTES.md
@@ -0,0 +1,25 @@
+v0.8.0.0 - Oct 12 2022
+- Add `Command.executeAsync` for `NET5` and up! (https://github.com/CaptnCodr/Fli/pull/19)
+- Add `Error` from `StandardError`. (https://github.com/... | [
"RELEASE_NOTES.md",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | |
CaptnCodr/Fli | 23 | issue_to_patch | Add documentation to code. | e4c42deecdf4f9ceaf0c1d257ac652585d040509 | 9b97b8cb76cd3b7e57b97831f85d46175e8a9523 | diff --git a/src/Fli/CE.fs b/src/Fli/CE.fs
index eeebd7e..c8e6932 100644
--- a/src/Fli/CE.fs
+++ b/src/Fli/CE.fs
@@ -22,38 +22,47 @@ module CE =
/// Extensions for Shell context.
type ICommandContext<'a> with
+ /// `Shell` opening keyword, which `Fli.Shell` shall be used.
[<CustomOperation("... | [
"src/Fli/CE.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 21 | issue_to_patch | Standard input support
In some cases, a command requires the caller to provide something in the stdin (consider an example of a program feeding a stream of shell commands to the shell line-by-line).
For such cases, something like this could be useful:
```fsharp
cli {
Shell CMD
input "echo 123\necho 345"... | Add interactive input support. (StandardInput) | - with native `CMD` interactive mode `cmd.exe /k`
Closes #18. | d85f6e56569dc54fd6b61c369180953b33504b88 | 52f2c4f62521fbe732336f245d72c01c96d18ebc | diff --git a/README.md b/README.md
index b9eefe1..952c989 100644
--- a/README.md
+++ b/README.md
@@ -130,8 +130,6 @@ cli {
|> Command.toString // "cmd.exe /C echo Hello World!"
```
-### Implementations
-
#### Builder operations:
`ShellContext` operations (`cli { Shell ... }`):
@@ -139,29 +137,34 @@ cli {
|----... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandConfigureTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli.Te... | [] | true | |
CaptnCodr/Fli | 22 | issue_to_patch | Fix build warnings & adjust namespaces of tests. | 7d9999f4c19c6ccdbf5f7af25020b20cfdc7876c | 673475b8ba0059c712e3214a2caa1c9b8b2ea152 | diff --git a/paket.dependencies b/paket.dependencies
index c33ee03..3799d60 100644
--- a/paket.dependencies
+++ b/paket.dependencies
@@ -4,5 +4,7 @@ framework: net5.0, net6.0, netstandard2.0, netstandard2.1
nuget FSharp.Core ~> 5.0.0
nuget FsUnit
+nuget Microsoft.NET.Test.Sdk
nuget NUnit
-nuget NUnit3TestAdapter
\... | [
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandToStringTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Test... | [] | true | |||
CaptnCodr/Fli | 20 | issue_to_patch | Standard error support
Most commands will provide useful information in stderr in case they return non-zero exit code. Some commands may also break if the parent process isn't reading the stderr.
Thus, I believe it would be useful to provide access to stderr in Fli. | Add StandardError support. Return errors in `Output.Error`. | - of course `Output.toError: Output -> string` as convinient member is available
- type of `Output.Text` changes to `string option`
- ~~only one of `Output.Text` and `Output.Error` can be filled~~
Closes #17. | ea1efa1e5bdb920ff1d3eeb491ede8b10fec1a45 | 3c3d1fc467a9b001369fa8f1544d3f301cce30f3 | diff --git a/README.md b/README.md
index 511005c..b9eefe1 100644
--- a/README.md
+++ b/README.md
@@ -84,11 +84,12 @@ cli {
```
#### `Command.execute`
-`Command.execute` returns record: `type Output = { Text: string; ExitCode: int }`
+`Command.execute` returns record: `type Output = { Text: string option; ExitCode: ... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |
CaptnCodr/Fli | 19 | issue_to_patch | Add `Command.executeAsync` for asynchronous execution. (ExecContext, ShellContext) | - works for `net5.0` & `net6.0` only | b8a2f46f33471189b5e4643f8c7f8d238e4b5ab0 | 787b82a0e36f29936485e6204d97376121761107 | diff --git a/paket.dependencies b/paket.dependencies
index 5763d91..c33ee03 100644
--- a/paket.dependencies
+++ b/paket.dependencies
@@ -1,5 +1,5 @@
source https://api.nuget.org/v3/index.json
-framework: netstandard2.0, netstandard2.1, net6.0
+framework: net5.0, net6.0, netstandard2.0, netstandard2.1
nuget FSharp.C... | [
"paket.dependencies",
"paket.lock",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs",
"src/Fli/Fli.fsproj",
"src/Fli/paket.template"
] | [] | true | ||
CaptnCodr/Fli | 14 | issue_to_patch | Question: Do you plan to add some approach to know the exit code of launched processes?
Or it already exists, but I missed them? | Add output type with exit code. | - returning record: `type Output = { Text: string; ExitCode: int }`
- Update docs with usable functions.
Closes #13. | 44160f0590d130ff1ba902e5fe293135499257b1 | d39d48b2ce3b7496d08b44859448958dba90dd75 | diff --git a/README.md b/README.md
index 28aedf8..511005c 100644
--- a/README.md
+++ b/README.md
@@ -83,12 +83,52 @@ cli {
|> Command.execute
```
+#### `Command.execute`
+`Command.execute` returns record: `type Output = { Text: string; ExitCode: int }`
+which has getter methods to get only one value:
+```fsharp
+to... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandExecuteTests.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Dsl.fs",
"src/Fli/Fli.fsproj"
] | [] | true | |
CaptnCodr/Fli | 11 | issue_to_patch | Add encoding for outputs | Add `Encoding` to set output encoding | Closes #10. | b118d1f3c136abafbb9b16588c1c2b5c5bc34dd8 | b04c338d8f341315a94382ec8833507ab645b67c | diff --git a/src/Fli.Tests/ProgramContext/ProgramCommandConfigureTests.fs b/src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
similarity index 85%
rename from src/Fli.Tests/ProgramContext/ProgramCommandConfigureTests.fs
rename to src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs
index 3e62778..c9834ac 100644
... | [
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandExecuteTests.fs",
"src/Fli.Tests/ExecContext/ExecCommandToStringTests.fs",
"src/Fli.Tests/ExecContext/ExecConfigTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Tests/ShellContext/ShellCommandConfigureTest... | [] | true | |
CaptnCodr/Fli | 12 | issue_to_patch | Add more snippets in readme & some refactorings. | ee3def830e468ce92017cb39168b19f52fd6b03c | 9170389a1066ee82e53fcf19b6d3efe9ec4bbe45 | diff --git a/README.md b/README.md
index 6c619ed..28aedf8 100644
--- a/README.md
+++ b/README.md
@@ -19,6 +19,16 @@ cli {
```
that starts `CMD.exe` as Shell and `echo Hello World!` is the command to execute.
+Run a file with PowerShell from a specific directory:
+```fsharp
+cli {
+ Shell PWSH
+ Command "test.... | [
"README.md",
"src/Fli.Tests/ExecContext/ExecCommandConfigureTests.fs",
"src/Fli.Tests/ShellContext/ShellCommandConfigureTests.fs",
"src/Fli/CE.fs",
"src/Fli/Cli.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 9 | issue_to_patch | Add internal method 'configureProcess' for better testing | for testing it on the ProcessStartInfo object. | ac35b64162af947533610cba45d26f0c22208031 | 7c1cce2d9b5319393b0df2736f6018c67c66e8c9 | diff --git a/README.md b/README.md
index 2c2f76b..6c619ed 100644
--- a/README.md
+++ b/README.md
@@ -50,7 +50,7 @@ Add environment variables for the executing program e.g.:
```fsharp
cli {
Exec "git"
- EnvironmentVariables [("GIT_AUTHOR_NAME", "Jon Doe");("GIT_AUTHOR_EMAIL", "jon.doe@domain.com")]
+ Enviro... | [
"README.md",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Tests/ProgramContext/ProgramCommandConfigureTests.fs",
"src/Fli.Tests/ProgramContext/ProgramCommandExecuteTests.fs",
"src/Fli.Tests/ProgramContext/ProgramCommandToStringTests.fs",
"src/Fli.Tests/ProgramContext/ProgramConfigTests.fs",
"src/Fli.Tests... | [] | true | ||
CaptnCodr/Fli | 8 | issue_to_patch | Add `EnvironmentVariables` to contexts | Add 'EnvironmentVariables' to contexts | Adds single tuple:
`EnvironmentVariable (key, value)`
and multiple tuples:
`EnvironmentVariables [(key1, value1); (key2, value2)]`
to the underlaying (starting child) process.
Closes #7 with both `ShellContext` and `ProgramContext`. | 791d7e7dd4be2b054f705e0e61e9b51b4c637bf2 | 47999a54566e88537d4ff75646e46e010c65e893 | diff --git a/README.md b/README.md
index 778d11a..2c2f76b 100644
--- a/README.md
+++ b/README.md
@@ -5,6 +5,8 @@
Execute CLI commands from your F# code in F# style!
### Getting Started
+Get it from Nuget: `dotnet add package Fli`
+
Just `open Fli` and start ...
For example:
@@ -36,7 +38,7 @@ cli {
```
Add a... | [
"README.md",
"src/Fli.Tests/CommandContext/CliCommandConfigTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Tests/ProgramContext/ProgramCommandConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Cli.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |
CaptnCodr/Fli | 5 | issue_to_patch | Add `UserName` to ProgramContext | Add UserName to ProgramContext. | Adds ~~credentials~~ **UserName** to ProgramContext and to is passed into starting process.
Closes #3.
| a662b2346d77888c8204ace24470b466972c3b99 | 4aded9eb919112777d05f9cb66859fb1003593eb | diff --git a/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs b/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs
index e275781..fcc24ec 100644
--- a/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs
+++ b/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs
@@ -3,6 +3,7 @@ module Fli.CliCommandConfigTest... | [
"src/Fli.Tests/CommandContext/CliCommandConfigTests.fs",
"src/Fli.Tests/ProgramContext/ProgramCommandConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Cli.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs",
"src/Fli/Fli.fsproj"
] | [] | true | |
CaptnCodr/Fli | 6 | issue_to_patch | Add 'Verb' to ProgramContext | 0fe7a84a9649b59ed0953a30834e18d6466e096d | 0d489e93e499e01e97626cf512b4f03d8117e5be | diff --git a/README.md b/README.md
index 5574210..778d11a 100644
--- a/README.md
+++ b/README.md
@@ -35,6 +35,15 @@ cli {
|> Command.execute
```
+Add a verb to your executing program:
+```
+cli {
+ Exec "cmd.exe"
+ Verb "runas"
+}
+|> Command.execute
+```
+
#### Implementations
Currently provided Shells:
... | [
"README.md",
"src/Fli.Tests/ProgramContext/ProgramCommandConfigTests.fs",
"src/Fli.Tests/ProgramContext/ProgramCommandExecuteTests.fs",
"src/Fli/CE.fs",
"src/Fli/Cli.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |||
CaptnCodr/Fli | 4 | issue_to_patch | Add optional `WorkingDirectory` to `ShellContext` | Add working directory to both ShellContext & ProgramContext. | Sets the `WorkingDirectory` on `ProcessStartInfo` in `ShellContext` & `ProgramContext`. | ac5c344aae74d1a834991cf29af0e24a078d91f4 | b97e403b29d248efe3a20916c5ef6d3a998d407f | diff --git a/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs b/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs
new file mode 100644
index 0000000..e275781
--- /dev/null
+++ b/src/Fli.Tests/CommandContext/CliCommandConfigTests.fs
@@ -0,0 +1,28 @@
+module Fli.CliCommandConfigTests
+
+open NUnit.Framework
+ope... | [
"src/Fli.Tests/CommandContext/CliCommandConfigTests.fs",
"src/Fli.Tests/Fli.Tests.fsproj",
"src/Fli.Tests/ProgramContext/ProgramCommandConfigTests.fs",
"src/Fli/CE.fs",
"src/Fli/Cli.fs",
"src/Fli/Command.fs",
"src/Fli/Domain.fs"
] | [] | true | |
CaptnCodr/Fli | 1 | issue_to_patch | Add bash as executing CLI | - Add ubuntu and macos to build pipeline
- Add Bash as executing CLI
- Testing the `SupportedOSPlatform` attribute | b551721bdb7368db7193e6eb468d2b05e60b85dd | 6a648a6c2cce0d8cbdafc76c1e218b2fa2e513b3 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2697afd..518cb1d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -13,8 +13,10 @@ jobs:
strategy:
fail-fast: false
-
- runs-on: [windows-latest]
+ matrix:
+ os: [windows-latest, macOS-l... | [
".github/workflows/build.yml",
"paket.lock",
"src/FsCli.Tests/CommandContext/CliCommandExecuteTests.fs",
"src/FsCli.Tests/CommandContext/CliCommandToStringTests.fs",
"src/FsCli.Tests/ProgramContext/ProgramCommandExecuteTests.fs",
"src/FsCli.Tests/ProgramContext/ProgramCommandToStringTests.fs",
"src/FsCl... | [] | true | ||
CarGuo/GSYVideoPlayer | 4,226 | issue_to_patch | Fix NPE in Kotlin implementations of ExoMediaSourceInterceptListener | Kotlin's `checkNotNullParameter` guards throw NPE at method entry for non-nullable parameters. `cacheDir` and `mapHeadData` are both passed as `null` by the library in common scenarios, so Kotlin implementations crash before the method body runs — leaving `mMediaSource` as `null` and causing a downstream crash in `Mask... | 2d78d2d11f0aa9a3d180afd40e7c650154fa7a12 | 43960e2cee1568a73bdf95587c8ec2e7e6eb6e41 | diff --git a/gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/ExoMediaSourceInterceptListener.java b/gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/ExoMediaSourceInterceptListener.java
index 87f57cb2b..ba4346f6c 100644
--- a/gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/m... | [
"gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/ExoMediaSourceInterceptListener.java",
"gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/IjkExo2MediaPlayer.java"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 4,231 | issue_to_patch | Fix unconditional signing task failing when GPG keys are absent | `signMavenCentralPublication` always ran regardless of whether GPG credentials were present, causing builds to fail with "no configured signatory" whenever `GPG_PRIVATE_KEY`/`GPG_PASSPHRASE` env vars were unset.
## Change
Moved `sign publishing.publications.mavenCentral` inside the credentials guard so it only execut... | 344b5f7cd809f1204c777f74246888db390a425b | eb41e61bc5211cb3c5fd98f2c540a8b2a999d52a | diff --git a/gradle/maven-central-publish.gradle b/gradle/maven-central-publish.gradle
index 1b26cbe83..bbd011c88 100644
--- a/gradle/maven-central-publish.gradle
+++ b/gradle/maven-central-publish.gradle
@@ -58,7 +58,7 @@ afterEvaluate {
if (signingKey != null && signingPassword != null) {
... | [
"gradle/maven-central-publish.gradle"
] | [
{
"comment": "The signing credentials guard only checks for null. In Groovy, env vars can be set to an empty string; in that case this condition passes and `useInMemoryPgpKeys`/`sign` may still fail. Consider using Groovy truthiness (e.g., `if (signingKey && signingPassword)`) or trimming/checking emptiness for... | true | ||
CarGuo/GSYVideoPlayer | 4,232 | issue_to_patch | [WIP] Fix staging profile issue for Sonatype | - [ ] Add `packageGroup` to `nexusPublishing` sonatype configuration in `build.gradle` to fix "Failed to find staging profile for package group: " error
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for you](https://github.com/CarGuo/GSYVideoPlayer/issues/new?title=✨+Set+up+Co... | e6d5e75ca274b9499eb135ee9061b7e047954465 | 061933d9c988f88442e71edd557e454faea33f05 | diff --git a/build.gradle b/build.gradle
index d2ba9b01b..158c858ba 100644
--- a/build.gradle
+++ b/build.gradle
@@ -14,6 +14,7 @@ buildscript {
apply plugin: 'io.github.gradle-nexus.publish-plugin'
nexusPublishing {
+ packageGroup = project.findProperty("PROJ_GROUP_MAVEN_CENTRAL") ?: "io.github.carguo"
rep... | [
"build.gradle"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 4,233 | issue_to_patch | Fix missing GPG signatures in Maven Central automated publishing | Maven Central publishing was uploading artifacts without `.asc` signature files because Gradle's signing block was silently skipped — `GPG_PRIVATE_KEY` was never passed to the publish step's environment, so `System.getenv("GPG_PRIVATE_KEY")` returned `null`.
A secondary bug: even with the env var present, `GPG_PRIVATE... | 014567bda039a580fb368916856425623f88285b | 35c491ec332f0db525c2fbcd60b5734eae063b6f | diff --git a/.github/workflows/publish-maven-central.yml b/.github/workflows/publish-maven-central.yml
index 58f2d54ae..eda3658e2 100644
--- a/.github/workflows/publish-maven-central.yml
+++ b/.github/workflows/publish-maven-central.yml
@@ -40,6 +40,7 @@ jobs:
env:
MAVEN_CENTRAL_USERNAME: ${{ secret... | [
".github/workflows/publish-maven-central.yml",
"gradle/maven-central-publish.gradle"
] | [
{
"comment": "The signing configuration is still silently skipped when `GPG_PRIVATE_KEY`/`GPG_PASSPHRASE` are missing (and GitHub Actions may provide missing secrets as empty strings rather than null). That can regress back to publishing unsigned artifacts. Consider validating these values as non-blank and, whe... | true | ||
CarGuo/GSYVideoPlayer | 4,234 | issue_to_patch | Fix GitHub Packages publishing scope | Version 11.4.0-beta6 was missing from GitHub Packages because only `gsyVideoPlayer-base` had the publishing repository configured.
## Changes
- **`gradle/publish.gradle`**: Added `publishing.repositories` block with the `gsyvideoplayer` GitHub Packages repository — previously this only existed in `gsyVideoPlayer-base... | 14158bcc706f0263c48e7b39790eff5a98502956 | 050576ca838d02824faea20c99d104fe14a5cd20 | diff --git a/gradle/publish.gradle b/gradle/publish.gradle
index d152075f1..35bee3585 100644
--- a/gradle/publish.gradle
+++ b/gradle/publish.gradle
@@ -43,5 +43,16 @@ afterEvaluate {
}
}
}
+
+ repositories {
+ maven {
+ name = "gsyvideoplayer"
+ ... | [
"gradle/publish.gradle",
"gsyVideoPlayer-base/build.gradle"
] | [
{
"comment": "The new `publishing.repositories` block in `gradle/publish.gradle` will be applied to every module that includes this script, but many modules already define the same `gsyvideoplayer` Maven repo in their own `build.gradle` files (e.g. `gsyVideoPlayer/build.gradle`, `gsyVideoPlayer-java/build.gradl... | true | ||
CarGuo/GSYVideoPlayer | 4,235 | issue_to_patch | [WIP] Update documentation generation process for video player | - [x] Remove duplicate top-level `publishing { repositories { gsyvideoplayer } }` blocks from all 11 module `build.gradle` files (aliplay, armv5, armv64, armv7a, ex_so, exo_player2, java, proxy_cache, x86, x86_64, gsyVideoPlayer)
- Root cause: Gradle `publishing.repositories` is global to ALL publications; the module... | 8649dc571043c5a5531bb4936f719ee4af4b174e | d5a854f6a09fe92636f4329971691ad126a354dd | diff --git a/gradle/maven-central-publish.gradle b/gradle/maven-central-publish.gradle
index 523cb46f2..3abbee381 100644
--- a/gradle/maven-central-publish.gradle
+++ b/gradle/maven-central-publish.gradle
@@ -64,4 +64,10 @@ afterEvaluate {
sign publishing.publications.mavenCentral
}
}
+
+ ... | [
"gradle/maven-central-publish.gradle",
"gradle/publish.gradle",
"gsyVideoPlayer-aliplay/build.gradle",
"gsyVideoPlayer-armv5/build.gradle",
"gsyVideoPlayer-armv64/build.gradle",
"gsyVideoPlayer-armv7a/build.gradle",
"gsyVideoPlayer-ex_so/build.gradle",
"gsyVideoPlayer-exo_player2/build.gradle",
"gsy... | [
{
"comment": "The PR title suggests a documentation-generation change, but the code changes here are about Gradle publishing repository/task guarding. Please update the PR title (or split the PR) so it accurately reflects the publishing-related changes being made.",
"path": "gradle/publish.gradle",
"hun... | true | ||
CarGuo/GSYVideoPlayer | 4,230 | issue_to_patch | Fix CI failures: migrate Sonatype publishing to Portal OSSRH Staging API | Both the GitHub Packages and Maven Central publish workflows fail because `s01.oss.sonatype.org` returns HTTP 402 (deprecated endpoint), and the `gradle-nexus/publish-plugin` in root `build.gradle` auto-injects a sonatype staging repo into every subproject — causing `initializeSonatypeStagingRepository` to fire even du... | 28d6f42ad56aff03bea35a777ec36984e72a2e53 | 48fa6368a0e02b916d82c52e0c693f6a54922930 | diff --git a/.github/workflows/publish-maven-central.yml b/.github/workflows/publish-maven-central.yml
index eca3017b3..58f2d54ae 100644
--- a/.github/workflows/publish-maven-central.yml
+++ b/.github/workflows/publish-maven-central.yml
@@ -41,7 +41,7 @@ jobs:
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRA... | [
".github/workflows/publish-maven-central.yml",
".github/workflows/release.yml",
"build.gradle",
"gradle/maven-central-publish.gradle",
"gsyVideoPlayer-aliplay/build.gradle",
"gsyVideoPlayer-armv5/build.gradle",
"gsyVideoPlayer-armv64/build.gradle",
"gsyVideoPlayer-armv7a/build.gradle",
"gsyVideoPlay... | [
{
"comment": "`url = version.endsWith('SNAPSHOT')` is checking the Gradle project `version` (likely defaulting to `\"unspecified\"` here), while the publication version is set from `PROJ_VERSION`. This can route snapshot builds to the release/staging endpoint. Use `PROJ_VERSION` (or the publication’s version) f... | true | ||
CarGuo/GSYVideoPlayer | 4,228 | issue_to_patch | 切换全屏之后需要按两下播放才能播放
点击暂停进入全屏，然后需要点击两下播放视频才能正常播放。 | Fix fullscreen player requiring two clicks to resume from paused state | After pausing playback and entering fullscreen, the player required two clicks on the play button to resume — introduced in the "Request audio focus on resume from pause" change.
## Root Cause
When the fullscreen player resumes from `CURRENT_STATE_PAUSE`, it calls `start()` then `requestAudioFocus()`. Since the origi... | 2d78d2d11f0aa9a3d180afd40e7c650154fa7a12 | d17ee378db127c5e727f62685746d17abfa15870 | diff --git a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java b/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java
index 9c4da9bd7..8654b6b2f 100644
--- a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java
+... | [
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYVideoView.java"
] | [
{
"comment": "The `listener != null && listener == GSYVideoView.this` check duplicates the existing `isCurrentMediaListener()` helper later in this class. Using the helper here would reduce duplication and keep the “current listener” definition consistent in one place.",
"path": "gsyVideoPlayer-java/src/mai... | true | |
CarGuo/GSYVideoPlayer | 4,215 | issue_to_patch | Update deprecated Media3 1.9.0 APIs in gsyVideoPlayer-exo_player2 and app modules | Media3 1.9.0 deprecated several Player.Listener and surface APIs. This PR updates the affected code in `gsyVideoPlayer-exo_player2` and `app` modules.
### API Updates
**Player.Listener interface changes:**
- `onCues(List<Cue>)` → `onCues(CueGroup)` - 3 files updated
- Removed deprecated `onMetadata(Metadata)` from Pl... | 7110134dd50a85d237380604a88cfd1101d97dc8 | a6272cbb5530e360893f5183a07be783ba0911c1 | diff --git a/app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayer.java b/app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayer.java
index 3a68f65fb..9e19349a8 100644
--- a/app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayer.java
+++ b/app/src/ma... | [
"app/src/main/java/com/example/gsyvideoplayer/exosubtitle/GSYExoSubTitlePlayer.java",
"gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/Exo2PlayerManager.java",
"gsyVideoPlayer-exo_player2/src/main/java/tv/danmaku/ijk/media/exo2/IjkExo2MediaPlayer.java",
"gsyVideoPlayer-exo_player2/src/main/... | [] | true | ||
CarGuo/GSYVideoPlayer | 4,165 | issue_to_patch | Fix AudioManager memory leaks and replace broken video URLs in demo files | ## Problem
The current AudioManager implementation in GSYVideoPlayer has several critical issues that can cause memory leaks and application instability:
1. **Memory Leaks**: The `onAudioFocusChangeListener` uses anonymous inner classes that hold implicit references to the outer video player instances, preventing pro... | 69fb658713009f1d07572ec6291c4546e94cecfb | 9dc77bdeacb58c2a8faea99f9c06df1433c76b2c | diff --git a/app/src/main/java/com/example/gsyvideoplayer/DanmkuVideoActivity.java b/app/src/main/java/com/example/gsyvideoplayer/DanmkuVideoActivity.java
index 5b58ddd8e..6dd038023 100644
--- a/app/src/main/java/com/example/gsyvideoplayer/DanmkuVideoActivity.java
+++ b/app/src/main/java/com/example/gsyvideoplayer/Danm... | [
"app/src/main/java/com/example/gsyvideoplayer/DanmkuVideoActivity.java",
"app/src/main/java/com/example/gsyvideoplayer/DetailADPlayer.java",
"app/src/main/java/com/example/gsyvideoplayer/DetailControlActivity.java",
"app/src/main/java/com/example/gsyvideoplayer/DetailDownloadExoPlayer.java",
"app/src/main/j... | [] | true | ||
CarGuo/GSYVideoPlayer | 4,134 | issue_to_patch | README 更新鸿蒙版本链接 | README.md:
====before begin====
### * 鸿蒙版本[openharmony-tpc/GSYVideoPlayer](https://gitee.com/openharmony-tpc/openharmony_tpc_samples/tree/master/GSYVideoPlayer)
====before end====
====after begin====
### * 鸿蒙版本[openharmony-tpc/GSYVideoPlayer](https://gitcode.com/openharmony-tpc/openharmony_tpc_samples/tree/maste... | f135d760f711b60cc6aa2f2a50c865db0cb325fb | 41da18d6e978d8568bd2fef773cc28678ad0c0a4 | diff --git a/README.md b/README.md
index 374cab3d4..39532a521 100644
--- a/README.md
+++ b/README.md
@@ -285,7 +285,7 @@ ExoSourceManager.setExoMediaSourceInterceptListener(new ExoMediaSourceInterceptL
### * [Flutter Github客户端](https://github.com/CarGuo/gsy_github_app_flutter) 、[React Native Github客户端](https://github.... | [
"README.md"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,972 | issue_to_patch | Up ListGSYVideoPlayer轮播场景焦点未移除导致播放器状态错误 | 我这边的业务场景是进入视频页面自动播放，经过排查发现这个判断return调了导致再次进入视频页面不会自动播放，首次是正常的。 onAudioFocusChangeListener注册和移除应该是配对存在的，在这里加上这行代码可以解决我的问题。 | ff4f7b8d4ef38bcb5ebff40a71c7f8c8c8918f8d | c86f45071e53680506b733a49767b32896ae427f | diff --git a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/ListGSYVideoPlayer.java b/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/ListGSYVideoPlayer.java
index 624728f72..3c277e542 100644
--- a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/ListGSYVideoPlayer.jav... | [
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/ListGSYVideoPlayer.java"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,856 | issue_to_patch | fix issues 3855 | fix issues 3855 | 1f70914a9d2a4b1cc247874efb04f3609f51fe2b | b3bb6753816d58dc1cb1d116b068db15d1d41b10 | diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index bb59d5552..f306c9924 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -40,7 +40,7 @@
<activity
android:name=".PlayTVActivity"
android:configChanges="keyboard|k... | [
"app/src/main/AndroidManifest.xml",
"app/src/main/java/com/example/gsyvideoplayer/PlayTVActivity.java",
"app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.java"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,843 | issue_to_patch | 添加機頂盒播放器和播放act | e7bc5c61b6eaa624e1d8dd35713c5731a72a0add | fed03e9611a7d0223b62acc833c1be68c81d1bfc | diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 6f1e49568..bb59d5552 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -37,6 +37,11 @@
android:configChanges="keyboard|keyboardHidden|orientation|screenSize|screenLayout|smallestScre... | [
"app/src/main/AndroidManifest.xml",
"app/src/main/java/com/example/gsyvideoplayer/MainActivity.java",
"app/src/main/java/com/example/gsyvideoplayer/PlayTVActivity.java",
"app/src/main/java/com/example/gsyvideoplayer/utils/JumpUtils.java",
"app/src/main/java/com/example/gsyvideoplayer/video/TvVideoPlayer.jav... | [] | true | |||
CarGuo/GSYVideoPlayer | 3,676 | issue_to_patch | 修复退出全屏时获取的封面为黑屏的问题 | initCover()调用的是非全屏播放器截图是黑屏的，gsyVideoPlayer.initCover()是全屏播放器截图 | 9c45597215e000b449fd83d1e747e2839e3f5600 | 1de1857b4fa97329f4a05963deac2d020b704f71 | diff --git a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java b/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java
index 7a9a93a73..992ce6f5c 100644
--- a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBase... | [
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,677 | issue_to_patch | 修复音频焦点冲突 | 当mReleaseWhenLossAudio为false、全屏播放并暂停的时候
这时要恢复播放调用onVideoResume方法时，会执行mAudioManager.requestAudioFocus方法，又因为onAudioFocusChangeListener未克隆，音频焦点就会被抢占，onAudioFocusChangeListener回调了onLossTransientAudio里的onVideoPause。视频就出现刚恢复播放又被暂停的情况 | 9c45597215e000b449fd83d1e747e2839e3f5600 | b090f4f28bf573d9f8082ae8e7cf539701d0b7ff | diff --git a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java b/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java
index 7a9a93a73..bbcbbd954 100644
--- a/gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBase... | [
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/video/base/GSYBaseVideoPlayer.java"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,582 | issue_to_patch | feat(Media DataSource): Video playback data source supports data inpu… | feat(Media DataSource): Video playback data source supports data input stream.(Currently only IJK kernel is supported) | 649a0a7cc1933bdb8fc4b355fdea880186a0f0e4 | 145b376c5e6d3b163cbeb83b805124d654b41968 | diff --git a/gsyVideoPlayer-base/src/main/java/com/shuyu/gsyvideoplayer/model/GSYModel.java b/gsyVideoPlayer-base/src/main/java/com/shuyu/gsyvideoplayer/model/GSYModel.java
index 3569f7aaf..c7e48e0c2 100644
--- a/gsyVideoPlayer-base/src/main/java/com/shuyu/gsyvideoplayer/model/GSYModel.java
+++ b/gsyVideoPlayer-base/sr... | [
"gsyVideoPlayer-base/src/main/java/com/shuyu/gsyvideoplayer/model/GSYModel.java",
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/GSYVideoBaseManager.java",
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvideoplayer/player/IjkPlayerManager.java",
"gsyVideoPlayer-java/src/main/java/com/shuyu/gsyvi... | [] | true | ||
CarGuo/GSYVideoPlayer | 3,548 | issue_to_patch | remove dependencies: transitionsEverywhere | 这个依赖库是多余的 com.andkulikov:transitionseverywhere:2.1.0 | d87d1d99f2ca86d1e68242d2f89c394edf060ad2 | 71ba333e50f48649c424592792f74f14e6d36e2f | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 5feccf69c..db91cab4c 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -11,6 +11,7 @@ ext {
design : "com.google.android.material:material:1.4.0",
viewpager2 : "androidx.viewpager2:viewpager2:1.0... | [
"gradle/dependencies.gradle",
"gsyVideoPlayer-java/build.gradle"
] | [] | true | ||
CarGuo/GSYVideoPlayer | 3,530 | issue_to_patch | Optimize CI a bit | ae25d81a3875f597085b40a2cb5050bfe0ac3a6a | fa421b4ed1a4ffec1c40c0941750eab79c10ec50 | diff --git a/.circleci/config.yml b/.circleci/config.yml
deleted file mode 100644
index 51d36e3dc..000000000
--- a/.circleci/config.yml
+++ /dev/null
@@ -1,114 +0,0 @@
-version: 2.1
-
-config_android: &config_android
- docker:
- - image: circleci/android:api-30
- environment:
- JAVA_TOOL_OPTIONS: "-Xmx4096m"
- ... | [
".circleci/config.yml",
".github/workflows/ci.yml",
".github/workflows/release.yml",
".travis.yml",
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties"
] | [
{
"comment": "https://github.com/gradle/gradle-build-action",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -4,95 +4,55 @@ on:\n push:\n branches:\n - master\n- tags:\n- - 'v*'\n+ paths-ignore:\n+ - '.idea/**'\n+ - '.gitattributes'\n+ - '.github/**.json'\n+ -... | true | |||
CarGuo/GSYVideoPlayer | 676 | issue_to_patch | Create LICENSE | 6a1205684674beb945efce72d12e29d48836cfec | 7e024ea670070abe8e497151c1198d52d1936f87 | diff --git a/LICENSE b/LICENSE
new file mode 100644
index 000000000..261eeb9e9
--- /dev/null
+++ b/LICENSE
@@ -0,0 +1,201 @@
+ Apache License
+ Version 2.0, January 2004
+ http://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE,... | [
"LICENSE"
] | [] | true | |||
CarGuo/GSYVideoPlayer | 3,464 | issue_to_patch | Add .circleci/config.yml | a48010e5202bde1e0b11fb0eb89356f9978bb361 | 7c115b264dd9d002e4075554bcdd4056153e6e4f | diff --git a/.circleci/config.yml b/.circleci/config.yml
new file mode 100644
index 000000000..c8f4f3b69
--- /dev/null
+++ b/.circleci/config.yml
@@ -0,0 +1,128 @@
+#
+#This config uses in all of my live projects. As example, here https://github.com/dmitriy-chernysh/covid-19-tracker-android
+#
+version: 2.1
+
+config_a... | [
".circleci/config.yml"
] | [] | true | |||
CarGuo/GSYVideoPlayer | 3,450 | issue_to_patch | Update dependencies | f7a1e158d5a495e1988993674eaaeb3a8159bad3 | 31358cd2f875a604327e0da57aef166daa166c5b | diff --git a/build.gradle b/build.gradle
index 3d53c2069..45c59d27b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -6,7 +6,7 @@ buildscript {
gradlePluginPortal()
}
dependencies {
- classpath "com.android.tools.build:gradle:7.0.2"
+ classpath "com.android.tools.build:gradle:7.0.3"
... | [
"build.gradle",
"gradle/base.gradle",
"gradle/dependencies.gradle",
"gradle/wrapper/gradle-wrapper.properties"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.