repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
BloopAI/vibe-kanban | 3,265 | issue_to_patch | fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs | ## Summary
Reverts the edit/preview mode split that was introduced as a workaround for code block and inline code escape issues. Instead of working around these Lexical bugs, this PR fixes them directly:
- **Restore MarkdownShortcutPlugin** — markdown renders as-you-type again (bold, italic, lists, headings, etc.) in... | 9a0fb95505b20ddfd247dc0e4750e6d8ac306110 | 1764f9957c930b2fd5de52dc34cd261b46d7eb28 | diff --git a/packages/ui/src/components/CodeBlockEscapePlugin.tsx b/packages/ui/src/components/CodeBlockEscapePlugin.tsx
new file mode 100644
index 00000000000..a76154db777
--- /dev/null
+++ b/packages/ui/src/components/CodeBlockEscapePlugin.tsx
@@ -0,0 +1,128 @@
+import { useEffect } from 'react';
+import { useLexical... | [
"packages/ui/src/components/CodeBlockEscapePlugin.tsx",
"packages/ui/src/components/CodeBlockShortcutPlugin.tsx",
"packages/ui/src/components/InlineCodeBoundaryPlugin.tsx",
"packages/ui/src/components/KanbanIssuePanel.tsx",
"packages/ui/src/components/MarkdownInsertPlugin.tsx",
"packages/ui/src/components... | [
{
"comment": "### Duplicate CODE transformer in allTransformers array\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `CODE` transformer is included explicitly on its own *and* again inside `...TRANSFORMERS` (which bundles all built-in element transformers including `CODE`, `HEADING`, `QUOTE`, etc.). ... | true | ||
BloopAI/vibe-kanban | 3,265 | comment_to_fix | fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs | ### Duplicate CODE transformer in allTransformers array
**Medium Severity**
<!-- DESCRIPTION START -->
The `CODE` transformer is included explicitly on its own *and* again inside `...TRANSFORMERS` (which bundles all built-in element transformers including `CODE`, `HEADING`, `QUOTE`, etc.). This means the code-block t... | 9a0fb95505b20ddfd247dc0e4750e6d8ac306110 | 1764f9957c930b2fd5de52dc34cd261b46d7eb28 | diff --git a/packages/web-core/src/shared/components/WYSIWYGEditor.tsx b/packages/web-core/src/shared/components/WYSIWYGEditor.tsx
index c4c0abdb084..4b40fd1b688 100644
--- a/packages/web-core/src/shared/components/WYSIWYGEditor.tsx
+++ b/packages/web-core/src/shared/components/WYSIWYGEditor.tsx
@@ -15,14 +15,10 @@ imp... | [
"packages/web-core/src/shared/components/WYSIWYGEditor.tsx"
] | [
{
"comment": "### Duplicate CODE transformer in allTransformers array\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `CODE` transformer is included explicitly on its own *and* again inside `...TRANSFORMERS` (which bundles all built-in element transformers including `CODE`, `HEADING`, `QUOTE`, etc.). ... | true | ||
BloopAI/vibe-kanban | 3,265 | comment_to_fix | fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs | ### rehype-raw without sanitization enables XSS vectors
**Medium Severity**
<!-- DESCRIPTION START -->
Adding `rehype-raw` to the rehype pipeline enables raw HTML in markdown to be parsed and rendered without any sanitization. Since `rehype-sanitize` is not present anywhere in the codebase, HTML elements like `<ifram... | 9a0fb95505b20ddfd247dc0e4750e6d8ac306110 | 1764f9957c930b2fd5de52dc34cd261b46d7eb28 | diff --git a/packages/web-core/src/shared/components/MarkdownPreview.tsx b/packages/web-core/src/shared/components/MarkdownPreview.tsx
index c08fc693f31..705cf132870 100644
--- a/packages/web-core/src/shared/components/MarkdownPreview.tsx
+++ b/packages/web-core/src/shared/components/MarkdownPreview.tsx
@@ -2,6 +2,8 @@... | [
"packages/web-core/src/shared/components/MarkdownPreview.tsx"
] | [
{
"comment": "### rehype-raw without sanitization enables XSS vectors\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nAdding `rehype-raw` to the rehype pipeline enables raw HTML in markdown to be parsed and rendered without any sanitization. Since `rehype-sanitize` is not present anywhere in the codebase,... | true | ||
BloopAI/vibe-kanban | 3,265 | comment_to_fix | fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs | ### ArrowDown escape missing element-level selection check
**Medium Severity**
<!-- DESCRIPTION START -->
The `isAtEnd` check in the ArrowDown handler only detects when the anchor is on the last child text node, but the Enter handler correctly handles both that case AND element-level selection on the `CodeNode` itsel... | 9a0fb95505b20ddfd247dc0e4750e6d8ac306110 | 1764f9957c930b2fd5de52dc34cd261b46d7eb28 | diff --git a/packages/ui/src/components/CodeBlockEscapePlugin.tsx b/packages/ui/src/components/CodeBlockEscapePlugin.tsx
new file mode 100644
index 00000000000..a76154db777
--- /dev/null
+++ b/packages/ui/src/components/CodeBlockEscapePlugin.tsx
@@ -0,0 +1,128 @@
+import { useEffect } from 'react';
+import { useLexical... | [
"packages/ui/src/components/CodeBlockEscapePlugin.tsx"
] | [
{
"comment": "### ArrowDown escape missing element-level selection check\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `isAtEnd` check in the ArrowDown handler only detects when the anchor is on the last child text node, but the Enter handler correctly handles both that case AND element-level select... | true | ||
BloopAI/vibe-kanban | 3,265 | comment_to_fix | fix(wysiwyg): restore full WYSIWYG editing, fix code escape bugs | ### Escape characters accumulate after removing stripping logic
**Medium Severity**
<!-- DESCRIPTION START -->
The removal of `preserveMarkdownSyntax` and the `MARKDOWN_ESCAPE_RE` stripping logic causes a round-trip bug. As the old comment noted, Lexical's `$convertToMarkdownString` escapes markdown-special character... | 9a0fb95505b20ddfd247dc0e4750e6d8ac306110 | 1764f9957c930b2fd5de52dc34cd261b46d7eb28 | diff --git a/packages/ui/src/components/MarkdownSyncPlugin.tsx b/packages/ui/src/components/MarkdownSyncPlugin.tsx
index d163ac57482..5c175b158ec 100644
--- a/packages/ui/src/components/MarkdownSyncPlugin.tsx
+++ b/packages/ui/src/components/MarkdownSyncPlugin.tsx
@@ -7,21 +7,12 @@ import {
} from '@lexical/markdown';... | [
"packages/ui/src/components/MarkdownSyncPlugin.tsx"
] | [
{
"comment": "### Escape characters accumulate after removing stripping logic\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe removal of `preserveMarkdownSyntax` and the `MARKDOWN_ESCAPE_RE` stripping logic causes a round-trip bug. As the old comment noted, Lexical's `$convertToMarkdownString` escapes... | true | ||
BloopAI/vibe-kanban | 3,271 | issue_to_patch | Fix macOS app menu branding to Vibe Kanban (Vibe Kanban) | ## Summary
This PR fixes desktop app branding in the macOS application menu so users only see **Vibe Kanban** instead of the internal binary name (`vibe-kanban-tauri`).
## What Changed
- Updated macOS bundle metadata in `crates/tauri-app/Info.plist`:
- Added `CFBundleDisplayName = Vibe Kanban`
- Added `CFBundleNam... | 76c818f7a3dc83bf1e5d308738a1f48a1a7d2c24 | d4f8ff1c1aaa2e41a34fe093b51dde13ee7b3081 | diff --git a/crates/tauri-app/Info.plist b/crates/tauri-app/Info.plist
index 3f53873965b..e9df7876620 100644
--- a/crates/tauri-app/Info.plist
+++ b/crates/tauri-app/Info.plist
@@ -2,6 +2,10 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">... | [
"crates/tauri-app/Info.plist",
"crates/tauri-app/tauri.conf.json"
] | [] | true | ||
BloopAI/vibe-kanban | 3,125 | issue_to_patch | feat: add markdown preview toggle in diff view for .md files | ## Summary
Adds a markdown preview toggle to the diff card header for `.md` and `.mdx` files. Clicking the eye icon switches between the raw code diff and a rendered markdown preview.
- Toggle button (eye icon) appears in the diff card header for markdown files only
- Rendered preview supports GFM (tables, task ... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/package.json b/packages/web-core/package.json
index a0e9f306ac9..6303efc6a99 100644
--- a/packages/web-core/package.json
+++ b/packages/web-core/package.json
@@ -70,16 +70,20 @@
"lexical": "^0.36.2",
"lodash": "^4.17.21",
"lucide-react": "^0.539.0",
+ "mermaid": "^11.4.0... | [
"packages/web-core/package.json",
"packages/web-core/src/i18n/locales/en/tasks.json",
"packages/web-core/src/i18n/locales/es/tasks.json",
"packages/web-core/src/i18n/locales/fr/tasks.json",
"packages/web-core/src/i18n/locales/ja/tasks.json",
"packages/web-core/src/i18n/locales/ko/tasks.json",
"packages/... | [
{
"comment": "### Syntax highlighting dependency added but never wired up\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`rehype-highlight` is added to `package.json` and listed in the PR description as a new dependency, but it's never imported or passed as a `rehypePlugins` prop to `ReactMarkdown`. Only... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Syntax highlighting dependency added but never wired up
**Medium Severity**
<!-- DESCRIPTION START -->
`rehype-highlight` is added to `package.json` and listed in the PR description as a new dependency, but it's never imported or passed as a `rehypePlugins` prop to `ReactMarkdown`. Only `remarkPlugins` is configu... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MarkdownPreview.tsx b/packages/web-core/src/shared/components/MarkdownPreview.tsx
new file mode 100644
index 00000000000..c08fc693f31
--- /dev/null
+++ b/packages/web-core/src/shared/components/MarkdownPreview.tsx
@@ -0,0 +1,224 @@
+import { useMemo, type ComponentPr... | [
"packages/web-core/src/shared/components/MarkdownPreview.tsx"
] | [
{
"comment": "### Syntax highlighting dependency added but never wired up\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`rehype-highlight` is added to `package.json` and listed in the PR description as a new dependency, but it's never imported or passed as a `rehypePlugins` prop to `ReactMarkdown`. Only... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Unused `containerRef` in MermaidDiagram component
**Low Severity**
<!-- DESCRIPTION START -->
`containerRef` is created via `useRef` and attached to the container `div`, but is never read or used for any DOM operation. This is dead code — the `useRef` import and the `ref={containerRef}` assignment can be removed.... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MermaidDiagram.tsx b/packages/web-core/src/shared/components/MermaidDiagram.tsx
new file mode 100644
index 00000000000..a787b21fbc4
--- /dev/null
+++ b/packages/web-core/src/shared/components/MermaidDiagram.tsx
@@ -0,0 +1,87 @@
+import { useEffect, useState, useRef }... | [
"packages/web-core/src/shared/components/MermaidDiagram.tsx"
] | [
{
"comment": "### Unused `containerRef` in MermaidDiagram component\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`containerRef` is created via `useRef` and attached to the container `div`, but is never read or used for any DOM operation. This is dead code — the `useRef` import and the `ref={containerRef}`... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Mermaid diagrams get unwanted pre wrapper styling
**Medium Severity**
<!-- DESCRIPTION START -->
In `react-markdown`, fenced code blocks render as `<pre><code>…</code></pre>`. The custom `code` component correctly detects mermaid language and returns `<MermaidDiagram>`, but react-markdown still wraps this output ... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MarkdownPreview.tsx b/packages/web-core/src/shared/components/MarkdownPreview.tsx
new file mode 100644
index 00000000000..c08fc693f31
--- /dev/null
+++ b/packages/web-core/src/shared/components/MarkdownPreview.tsx
@@ -0,0 +1,224 @@
+import { useMemo, type ComponentPr... | [
"packages/web-core/src/shared/components/MarkdownPreview.tsx"
] | [
{
"comment": "### Mermaid diagrams get unwanted pre wrapper styling\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `react-markdown`, fenced code blocks render as `<pre><code>…</code></pre>`. The custom `code` component correctly detects mermaid language and returns `<MermaidDiagram>`, but react-markdo... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Inline code detection misidentifies language-less fenced blocks
**Medium Severity**
<!-- DESCRIPTION START -->
The `isInline` check (`!codeClassName`) incorrectly treats fenced code blocks that have no language specifier as inline code. In `react-markdown` v9, both inline code and language-less fenced blocks (tri... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MarkdownPreview.tsx b/packages/web-core/src/shared/components/MarkdownPreview.tsx
new file mode 100644
index 00000000000..c08fc693f31
--- /dev/null
+++ b/packages/web-core/src/shared/components/MarkdownPreview.tsx
@@ -0,0 +1,224 @@
+import { useMemo, type ComponentPr... | [
"packages/web-core/src/shared/components/MarkdownPreview.tsx"
] | [
{
"comment": "### Inline code detection misidentifies language-less fenced blocks\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `isInline` check (`!codeClassName`) incorrectly treats fenced code blocks that have no language specifier as inline code. In `react-markdown` v9, both inline code and langu... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Global mermaid initialize called per component instance
**Low Severity**
<!-- DESCRIPTION START -->
`mermaid.initialize()` is a global singleton operation but it's called inside every `MermaidDiagram` instance's `useEffect`. When a page has multiple mermaid diagrams, each one re-initializes the global mermaid con... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MermaidDiagram.tsx b/packages/web-core/src/shared/components/MermaidDiagram.tsx
new file mode 100644
index 00000000000..a787b21fbc4
--- /dev/null
+++ b/packages/web-core/src/shared/components/MermaidDiagram.tsx
@@ -0,0 +1,87 @@
+import { useEffect, useState, useRef }... | [
"packages/web-core/src/shared/components/MermaidDiagram.tsx"
] | [
{
"comment": "### Global mermaid initialize called per component instance\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`mermaid.initialize()` is a global singleton operation but it's called inside every `MermaidDiagram` instance's `useEffect`. When a page has multiple mermaid diagrams, each one re-initial... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Mermaid render races on stable ID across re-renders
**Medium Severity**
<!-- DESCRIPTION START -->
The `id` from `useId()` is stable across re-renders, so when the effect re-runs (on `chart` or `theme` change), `mermaid.render()` is called with the same element ID while a previous async render may still be in fli... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MermaidDiagram.tsx b/packages/web-core/src/shared/components/MermaidDiagram.tsx
new file mode 100644
index 00000000000..a787b21fbc4
--- /dev/null
+++ b/packages/web-core/src/shared/components/MermaidDiagram.tsx
@@ -0,0 +1,87 @@
+import { useEffect, useState, useRef }... | [
"packages/web-core/src/shared/components/MermaidDiagram.tsx"
] | [
{
"comment": "### Mermaid render races on stable ID across re-renders\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `id` from `useId()` is stable across re-renders, so when the effect re-runs (on `chart` or `theme` change), `mermaid.render()` is called with the same element ID while a previous async... | true | ||
BloopAI/vibe-kanban | 3,125 | comment_to_fix | feat: add markdown preview toggle in diff view for .md files | ### Security attributes on links overridable by spread props
**Low Severity**
<!-- DESCRIPTION START -->
The `a` component sets security-sensitive attributes `target="_blank"` and `rel="noopener noreferrer"` *before* `{...props}` is spread. If any rehype plugin (current or future, e.g. `rehype-raw`) injects `rel` or ... | 70864474038dd09ea4af9cb09254561872dde2e6 | 646730f959130eabe7b5de56958d9ee3bd36135c | diff --git a/packages/web-core/src/shared/components/MarkdownPreview.tsx b/packages/web-core/src/shared/components/MarkdownPreview.tsx
new file mode 100644
index 00000000000..c08fc693f31
--- /dev/null
+++ b/packages/web-core/src/shared/components/MarkdownPreview.tsx
@@ -0,0 +1,224 @@
+import { useMemo, type ComponentPr... | [
"packages/web-core/src/shared/components/MarkdownPreview.tsx"
] | [
{
"comment": "### Security attributes on links overridable by spread props\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `a` component sets security-sensitive attributes `target=\"_blank\"` and `rel=\"noopener noreferrer\"` *before* `{...props}` is spread. If any rehype plugin (current or future, e.g. ... | true | ||
BloopAI/vibe-kanban | 3,233 | issue_to_patch | Add conversation turn navigation popover (Vibe Kanban) | ## Summary
Adds a ChatGPT-style conversation turn navigation feature that lets users quickly jump to any of their previous messages in a conversation.
- Hovering over the existing "scroll to previous message" (arrow up) button reveals a popover listing all user messages as numbered turns
- Clicking a turn scrolls the... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/SessionChatBox.tsx b/packages/ui/src/components/SessionChatBox.tsx
index 881d192923f..11ff965577b 100644
--- a/packages/ui/src/components/SessionChatBox.tsx
+++ b/packages/ui/src/components/SessionChatBox.tsx
@@ -33,6 +33,10 @@ import {
AskUserQuestionBanner,
type AskUserQu... | [
"packages/ui/src/components/SessionChatBox.tsx",
"packages/ui/src/components/TurnNavigationPopup.tsx",
"packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx",
"packages/web-core/src/features/workspace-chat/ui/SessionChatBoxContainer.tsx",
"packages/web-core/src/pages/kanban/Project... | [
{
"comment": "### PopoverTrigger click handler conflicts with button onClick\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `TurnNavigationPopup` is designed to open on hover, but Radix's `PopoverTrigger` also adds a click handler that calls `onOpenChange` to toggle the popover. When the wrapped `Too... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### PopoverTrigger click handler conflicts with button onClick
**Medium Severity**
<!-- DESCRIPTION START -->
The `TurnNavigationPopup` is designed to open on hover, but Radix's `PopoverTrigger` also adds a click handler that calls `onOpenChange` to toggle the popover. When the wrapped `ToolbarIconButton` is clicked,... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### PopoverTrigger click handler conflicts with button onClick\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `TurnNavigationPopup` is designed to open on hover, but Radix's `PopoverTrigger` also adds a click handler that calls `onOpenChange` to toggle the popover. When the wrapped `Too... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Missing `getActiveTurnPatchKey` in two container callers
**Medium Severity**
<!-- DESCRIPTION START -->
`VSCodeWorkspacePage` and `ProjectRightSidebarContainer` pass `onScrollToUserMessage` to `SessionChatBoxContainer` but omit `getActiveTurnPatchKey`. Only `WorkspacesMainContainer` wires both props. Without `get... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/web-core/src/pages/workspaces/VSCodeWorkspacePage.tsx b/packages/web-core/src/pages/workspaces/VSCodeWorkspacePage.tsx
index c785fa26c81..235005f738c 100644
--- a/packages/web-core/src/pages/workspaces/VSCodeWorkspacePage.tsx
+++ b/packages/web-core/src/pages/workspaces/VSCodeWorkspacePage.tsx
@@ ... | [
"packages/web-core/src/pages/workspaces/VSCodeWorkspacePage.tsx"
] | [
{
"comment": "### Missing `getActiveTurnPatchKey` in two container callers\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`VSCodeWorkspacePage` and `ProjectRightSidebarContainer` pass `onScrollToUserMessage` to `SessionChatBoxContainer` but omit `getActiveTurnPatchKey`. Only `WorkspacesMainContainer` wir... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Missing `getActiveTurnPatchKey` in two caller sites
**Medium Severity**
<!-- DESCRIPTION START -->
`ProjectRightSidebarContainer` and `VSCodeWorkspacePage` pass `onScrollToUserMessage` but do not pass `getActiveTurnPatchKey` to `SessionChatBoxContainer`. `WorkspacesMainContainer` correctly wires both. Without `ge... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/web-core/src/pages/kanban/ProjectRightSidebarContainer.tsx b/packages/web-core/src/pages/kanban/ProjectRightSidebarContainer.tsx
index 78b44829fb2..f064d14fab2 100644
--- a/packages/web-core/src/pages/kanban/ProjectRightSidebarContainer.tsx
+++ b/packages/web-core/src/pages/kanban/ProjectRightSide... | [
"packages/web-core/src/pages/kanban/ProjectRightSidebarContainer.tsx"
] | [
{
"comment": "### Missing `getActiveTurnPatchKey` in two caller sites\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`ProjectRightSidebarContainer` and `VSCodeWorkspacePage` pass `onScrollToUserMessage` but do not pass `getActiveTurnPatchKey` to `SessionChatBoxContainer`. `WorkspacesMainContainer` correc... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Missing `releaseBottomLock` causes scroll snap-back
**High Severity**
<!-- DESCRIPTION START -->
`scrollToEntryByPatchKey` does not call `conversationVirtualizer.releaseBottomLock()` before scrolling, unlike the analogous `scrollToPreviousUserMessage` which does. When the user is at the bottom of the conversation... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx b/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
index 531e0b11bc5..3e6aee4ae5b 100644
--- a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
+++ b/packages/web-core/... | [
"packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx"
] | [
{
"comment": "### Missing `releaseBottomLock` causes scroll snap-back\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`scrollToEntryByPatchKey` does not call `conversationVirtualizer.releaseBottomLock()` before scrolling, unlike the analogous `scrollToPreviousUserMessage` which does. When the user is at the... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Popover scroll uses `useEffect` instead of `useLayoutEffect`
**Low Severity**
<!-- DESCRIPTION START -->
The auto-scroll logic that positions the popover list at the active turn or bottom runs in a `useEffect`, which fires after the browser paints. This can cause a brief visual flash where the list appears scroll... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### Popover scroll uses `useEffect` instead of `useLayoutEffect`\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe auto-scroll logic that positions the popover list at the active turn or bottom runs in a `useEffect`, which fires after the browser paints. This can cause a brief visual flash wh... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Controlled Popover missing `onOpenChange` prevents dismissal
**Medium Severity**
<!-- DESCRIPTION START -->
The `Popover` is used in controlled mode (`open={open}`) but no `onOpenChange` callback is provided. In Radix UI, controlled-mode dismissal events (Escape key, clicking outside the popover) call `onOpenChan... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### Controlled Popover missing `onOpenChange` prevents dismissal\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `Popover` is used in controlled mode (`open={open}`) but no `onOpenChange` callback is provided. In Radix UI, controlled-mode dismissal events (Escape key, clicking outside th... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### scrollIntoView can disrupt ancestor scroll containers
**Medium Severity**
<!-- DESCRIPTION START -->
`scrollIntoView({ block: 'center' })` scrolls **all** scrollable ancestors, not just the `<ul>` list. When the popover opens near a viewport edge, this can cause the conversation scroll container behind the popove... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### scrollIntoView can disrupt ancestor scroll containers\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`scrollIntoView({ block: 'center' })` scrolls **all** scrollable ancestors, not just the `<ul>` list. When the popover opens near a viewport edge, this can cause the conversation scroll ... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Missing scroll correction loop causes wrong scroll target
**Medium Severity**
<!-- DESCRIPTION START -->
`scrollToEntryByPatchKey` does a one-shot call to `scrollToAbsoluteIndex` without any retry/correction logic. The analogous `scrollToPreviousUserMessage` function (line 566–632) has a multi-attempt correction ... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx b/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
index 531e0b11bc5..3e6aee4ae5b 100644
--- a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
+++ b/packages/web-core/... | [
"packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx"
] | [
{
"comment": "### Missing scroll correction loop causes wrong scroll target\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`scrollToEntryByPatchKey` does a one-shot call to `scrollToAbsoluteIndex` without any retry/correction logic. The analogous `scrollToPreviousUserMessage` function (line 566–632) has ... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Popover active-item centering uses wrong offset reference
**Low Severity**
<!-- DESCRIPTION START -->
The `useLayoutEffect` uses `activeEl.offsetTop` to center the active turn in the scrollable `<ul>`, but `offsetTop` is relative to the nearest positioned ancestor (the Radix popover container), not the `<ul>` scr... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### Popover active-item centering uses wrong offset reference\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `useLayoutEffect` uses `activeEl.offsetTop` to center the active turn in the scrollable `<ul>`, but `offsetTop` is relative to the nearest positioned ancestor (the Radix popover con... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Virtualizer receives out-of-range index for unvirtualized rows
**Medium Severity**
<!-- DESCRIPTION START -->
`scrollToEntryByPatchKey` passes `targetIndex` (an absolute index in `conversationRows`) to `conversationVirtualizer.scrollToIndex`, but the virtualizer's count is only `virtualizedRows.length` (the head ... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx b/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
index 531e0b11bc5..3e6aee4ae5b 100644
--- a/packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx
+++ b/packages/web-core/... | [
"packages/web-core/src/features/workspace-chat/ui/ConversationListContainer.tsx"
] | [
{
"comment": "### Virtualizer receives out-of-range index for unvirtualized rows\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`scrollToEntryByPatchKey` passes `targetIndex` (an absolute index in `conversationRows`) to `conversationVirtualizer.scrollToIndex`, but the virtualizer's count is only `virtual... | true | ||
BloopAI/vibe-kanban | 3,233 | comment_to_fix | Add conversation turn navigation popover (Vibe Kanban) | ### Active turn highlight stale after navigation scroll
**Medium Severity**
<!-- DESCRIPTION START -->
`activePatchKey` is only computed when the popover opens (in `handleTriggerEnter`) by reading the current scroll position. After `handleNavigate` closes the popover and starts an async scroll (via `requestAnimationF... | 70864474038dd09ea4af9cb09254561872dde2e6 | 70e287464b68ea539401a2b0af7f7ac5b8665a4f | diff --git a/packages/ui/src/components/TurnNavigationPopup.tsx b/packages/ui/src/components/TurnNavigationPopup.tsx
new file mode 100644
index 00000000000..80f8e506ccc
--- /dev/null
+++ b/packages/ui/src/components/TurnNavigationPopup.tsx
@@ -0,0 +1,188 @@
+import {
+ useState,
+ useRef,
+ useCallback,
+ useLayout... | [
"packages/ui/src/components/TurnNavigationPopup.tsx"
] | [
{
"comment": "### Active turn highlight stale after navigation scroll\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`activePatchKey` is only computed when the popover opens (in `handleTriggerEnter`) by reading the current scroll position. After `handleNavigate` closes the popover and starts an async scr... | true | ||
BloopAI/vibe-kanban | 3,261 | issue_to_patch | chore: Commit auto-generated tauri schema file | <!-- CURSOR_SUMMARY -->
> [!NOTE]
> **Low Risk**
> Low risk because it only adds a generated schema JSON with no runtime code changes; main impact is repository size and potential downstream tooling that consumes schemas.
>
> **Overview**
> Commits a new auto-generated schema at `crates/tauri-app/gen/schemas/linux-sch... | d9a2c4f906261dfb50e4a0a5c8ade1f99991bea6 | c34efea0a5b0c0f182b9d3b410cb4bf88eaca9ee | diff --git a/crates/tauri-app/gen/schemas/linux-schema.json b/crates/tauri-app/gen/schemas/linux-schema.json
new file mode 100644
index 00000000000..c6bc9189d54
--- /dev/null
+++ b/crates/tauri-app/gen/schemas/linux-schema.json
@@ -0,0 +1,3049 @@
+{
+ "$schema": "http://json-schema.org/draft-07/schema#",
+ "title": "... | [
"crates/tauri-app/gen/schemas/linux-schema.json"
] | [] | true | ||
BloopAI/vibe-kanban | 3,252 | issue_to_patch | ci: pin all third-party GitHub Actions and cargo installs to commit hashes | Supply-chain security hardening:
- Pin all third-party GitHub Actions to exact commit SHAs.
- Replace raw `cargo install` commands with `taiki-e/cache-cargo-install-action` using git commit pinning.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> CI/release workflows are modified in multiple places (tool... | e96323b81c43abc4d6df740d0caed893a88ffa08 | 6e2dc95a663202e0221b8be3b9dd7db92d4c1999 | diff --git a/.github/actions/cargo-checks-common-setup/action.yml b/.github/actions/cargo-checks-common-setup/action.yml
index b0adfc359c7..3b50ffbd317 100644
--- a/.github/actions/cargo-checks-common-setup/action.yml
+++ b/.github/actions/cargo-checks-common-setup/action.yml
@@ -33,19 +33,19 @@ runs:
- name: In... | [
".github/actions/cargo-checks-common-setup/action.yml",
".github/actions/setup-node/action.yml",
".github/workflows/pre-release.yml",
".github/workflows/publish.yml",
".github/workflows/relay-deploy-prod.yml",
".github/workflows/relay-release.yml",
".github/workflows/remote-deploy-prod.yml",
".github/... | [] | true | ||
BloopAI/vibe-kanban | 3,199 | issue_to_patch | feat: self-host improvements | - Bypass OAuth provider configuration
- Gate `relay` and `attachments` behind feature flags
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Adds a new local email/password login path and changes token refresh validation behavior, which touches authentication/session flows. Also changes self-host deploymen... | da4580042168a17accb3b30dded6c7c45325fb4e | 332612ccfada5fb8ab89506fdc1439771860606a | diff --git a/Caddyfile.example b/Caddyfile.example
new file mode 100644
index 00000000000..64a882ca8ec
--- /dev/null
+++ b/Caddyfile.example
@@ -0,0 +1,15 @@
+localhost:3001, relay.localhost:3001, *.relay.localhost:3001 {
+ tls internal
+
+ @relay host relay.localhost *.relay.localhost
+ handle @relay {
+ ... | [
"Caddyfile.example",
"crates/api-types/src/oauth.rs",
"crates/remote/.sqlx/query-efb2b5c658e8b19949dfecf7993578c10248c7a16db74eb3476cc9e8d90573a2.json",
"crates/remote/README.md",
"crates/remote/docker-compose.yml",
"crates/remote/src/app.rs",
"crates/remote/src/auth/local.rs",
"crates/remote/src/auth... | [
{
"comment": "### Empty env vars crash server on startup\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`LocalAuthConfig::from_env()` uses `env::var(...).ok()` which converts `Ok(\"\")` to `Some(\"\")`. The docker-compose passes `${SELF_HOST_LOCAL_AUTH_EMAIL:-}` which resolves to an empty string, so both v... | true | ||
BloopAI/vibe-kanban | 3,199 | comment_to_fix | feat: self-host improvements | ### Empty env vars crash server on startup
**High Severity**
<!-- DESCRIPTION START -->
`LocalAuthConfig::from_env()` uses `env::var(...).ok()` which converts `Ok("")` to `Some("")`. The docker-compose passes `${SELF_HOST_LOCAL_AUTH_EMAIL:-}` which resolves to an empty string, so both variables become `Some("")`. The... | da4580042168a17accb3b30dded6c7c45325fb4e | 332612ccfada5fb8ab89506fdc1439771860606a | diff --git a/crates/remote/src/config.rs b/crates/remote/src/config.rs
index be1fc745041..7ced437d734 100644
--- a/crates/remote/src/config.rs
+++ b/crates/remote/src/config.rs
@@ -92,7 +92,11 @@ pub struct AzureBlobConfig {
impl AzureBlobConfig {
pub fn from_env() -> Result<Option<Self>, ConfigError> {
... | [
"crates/remote/src/config.rs"
] | [
{
"comment": "### Empty env vars crash server on startup\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`LocalAuthConfig::from_env()` uses `env::var(...).ok()` which converts `Ok(\"\")` to `Some(\"\")`. The docker-compose passes `${SELF_HOST_LOCAL_AUTH_EMAIL:-}` which resolves to an empty string, so both v... | true | ||
BloopAI/vibe-kanban | 3,199 | comment_to_fix | feat: self-host improvements | Do we actually provide a `Caddyfile`? I think we have it gitiginored | da4580042168a17accb3b30dded6c7c45325fb4e | 332612ccfada5fb8ab89506fdc1439771860606a | diff --git a/crates/remote/README.md b/crates/remote/README.md
index c0e303bf4ec..5c6acce460d 100644
--- a/crates/remote/README.md
+++ b/crates/remote/README.md
@@ -1,32 +1,30 @@
-# Remote service
+# Remote Service
-The `remote` crate contains the implementation of the Vibe Kanban hosted API.
+The `remote` crate cont... | [
"crates/remote/README.md"
] | [
{
"comment": "Do we actually provide a `Caddyfile`? I think we have it gitiginored",
"path": "crates/remote/README.md",
"hunk": "@@ -36,103 +34,106 @@ LOOPS_REVIEW_READY_TEMPLATE_ID=cmj47k5ge16990iylued9by17\n LOOPS_REVIEW_FAILED_TEMPLATE_ID=cmj49ougk1c8s0iznavijdqpo\n ```\n \n-Generate `VIBEKANBAN_REMO... | true | ||
BloopAI/vibe-kanban | 3,249 | issue_to_patch | fix: bump rmcp | <!-- CURSOR_SUMMARY -->
> [!NOTE]
> **Medium Risk**
> Moderate risk because it upgrades the core `rmcp` dependency and updates MCP server/tool wiring and error handling paths; behavior should be equivalent but could affect runtime compatibility and error surfaces.
>
> **Overview**
> Upgrades `crates/mcp` from `rmcp` `... | 8a0e4c93dce4e80d30f2c4b400e734615c742b3f | c08bb069ace38e0c27dda8b5f7221af0538efa46 | diff --git a/Cargo.lock b/Cargo.lock
index a91d8c6ecf3..be0591b7ce9 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -791,7 +791,7 @@ version = "3.9.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "519bd3116aeeb42d5372c29d982d16d0170d3d4a5ed85fc7dd91642ffff3c67c"
dependencies = [
- "darling... | [
"Cargo.lock",
"crates/mcp/Cargo.toml",
"crates/mcp/src/task_server/handler.rs",
"crates/mcp/src/task_server/tools/issue_assignees.rs",
"crates/mcp/src/task_server/tools/issue_relationships.rs",
"crates/mcp/src/task_server/tools/issue_tags.rs",
"crates/mcp/src/task_server/tools/mod.rs",
"crates/mcp/src... | [] | true | ||
BloopAI/vibe-kanban | 3,240 | issue_to_patch | refactor: isolate git2 usage behind GitService wrappers (Vibe Kanban) | ## Summary
This PR completes a cleanup/refactor to route Git operations through the `git` crate service layer instead of calling `git2` directly from other crates.
## What Changed
- Refactored dependent crates to use `GitService` wrappers instead of direct `git2` APIs.
- `worktree-manager` now uses `GitService` help... | 70864474038dd09ea4af9cb09254561872dde2e6 | 40d269acebb23e2c9f96cc86051c772cebde43cf | diff --git a/Cargo.lock b/Cargo.lock
index a554fcf4216..03089217c15 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1813,7 +1813,6 @@ dependencies = [
"executors",
"futures",
"git",
- "git2",
"preview-proxy",
"relay-control",
"relay-hosts",
@@ -7698,7 +7697,6 @@ dependencies = [
"futures-util",
"git",
"g... | [
"Cargo.lock",
"crates/deployment/Cargo.toml",
"crates/deployment/src/lib.rs",
"crates/git/src/lib.rs",
"crates/git/tests/git_ops_safety.rs",
"crates/git/tests/git_workflow.rs",
"crates/remote/Cargo.lock",
"crates/server/Cargo.toml",
"crates/server/src/error.rs",
"crates/server/src/routes/workspace... | [
{
"comment": "### `FileDiffDetails` struct is now unused dead code\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `FileDiffDetails` struct in `utils/src/diff.rs` is now dead code. Its only consumer was `create_file_details` in the git crate, which was removed in this PR as part of the `DiffTarget::Branc... | diff --git a/crates/git/tests/git_ops_safety.rs b/crates/git/tests/git_ops_safety.rs
index 906bab2e582..c357ea4e423 100644
--- a/crates/git/tests/git_ops_safety.rs
+++ b/crates/git/tests/git_ops_safety.rs
@@ -74,8 +74,6 @@ fn add_path(repo_path: &Path, path: &str) {
git.git(repo_path, ["add", path]).unwrap();
}
... | true | |
BloopAI/vibe-kanban | 3,240 | comment_to_fix | refactor: isolate git2 usage behind GitService wrappers (Vibe Kanban) | ### `FileDiffDetails` struct is now unused dead code
**Low Severity**
<!-- DESCRIPTION START -->
The `FileDiffDetails` struct in `utils/src/diff.rs` is now dead code. Its only consumer was `create_file_details` in the git crate, which was removed in this PR as part of the `DiffTarget::Branch`/`DiffTarget::Commit` cle... | 70864474038dd09ea4af9cb09254561872dde2e6 | 40d269acebb23e2c9f96cc86051c772cebde43cf | diff --git a/crates/utils/src/diff.rs b/crates/utils/src/diff.rs
index ad8b1d991d2..b735abb2f16 100644
--- a/crates/utils/src/diff.rs
+++ b/crates/utils/src/diff.rs
@@ -1,6 +1,5 @@
use std::borrow::Cow;
-use git2::{DiffOptions, Patch};
use serde::{Deserialize, Serialize};
use similar::TextDiff;
use ts_rs::TS;
@@ ... | [
"crates/utils/src/diff.rs"
] | [
{
"comment": "### `FileDiffDetails` struct is now unused dead code\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `FileDiffDetails` struct in `utils/src/diff.rs` is now dead code. Its only consumer was `create_file_details` in the git crate, which was removed in this PR as part of the `DiffTarget::Branc... | true | ||
BloopAI/vibe-kanban | 3,138 | issue_to_patch | fix(auth): Add refresh token refresh grace window and degraded auth UI | - Remote: align auth implementation with common practices.
- allow a grace window for refresh token reuse.
- on reuse, revoke the affected auth session only.
- UX: handle degraded auth gracefully.
- avoid logging out the user on degraded auth state.
- display a degraded auth message.
- retry auth reques... | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/crates/api-types/src/auth.rs b/crates/api-types/src/auth.rs
index 3e2aa6bf06c..65613584d74 100644
--- a/crates/api-types/src/auth.rs
+++ b/crates/api-types/src/auth.rs
@@ -11,6 +11,8 @@ pub struct AuthSession {
pub revoked_at: Option<DateTime<Utc>>,
pub refresh_token_id: Option<Uuid>,
pub re... | [
"crates/api-types/src/auth.rs",
"crates/api-types/src/oauth.rs",
"crates/local-deployment/src/lib.rs",
"crates/relay-tunnel/.sqlx/query-ba255d9addff593557d963bec680dfbd75ba467cde15b884f72ead37cd18f8c0.json",
"crates/relay-tunnel/src/server_bin/db/auth_sessions.rs",
"crates/remote/.sqlx/query-1055ce10fc485... | [
{
"comment": "### Recovery backoff skips first exponential step\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe exponential backoff in `runRecoveryAttempt` is off by one because `getToken`'s error handler calls `this.syncRecoveryState()` (which schedules a timeout using the current `recoveryAttempt`) **b... | true | ||
BloopAI/vibe-kanban | 3,138 | comment_to_fix | fix(auth): Add refresh token refresh grace window and degraded auth UI | ### Recovery backoff skips first exponential step
**Low Severity**
<!-- DESCRIPTION START -->
The exponential backoff in `runRecoveryAttempt` is off by one because `getToken`'s error handler calls `this.syncRecoveryState()` (which schedules a timeout using the current `recoveryAttempt`) **before** `runRecoveryAttempt... | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/packages/web-core/src/shared/lib/auth/tokenManager.ts b/packages/web-core/src/shared/lib/auth/tokenManager.ts
index 8cc8a887668..41b69e5ecae 100644
--- a/packages/web-core/src/shared/lib/auth/tokenManager.ts
+++ b/packages/web-core/src/shared/lib/auth/tokenManager.ts
@@ -1,13 +1,47 @@
import { ApiError, o... | [
"packages/web-core/src/shared/lib/auth/tokenManager.ts"
] | [
{
"comment": "### Recovery backoff skips first exponential step\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe exponential backoff in `runRecoveryAttempt` is off by one because `getToken`'s error handler calls `this.syncRecoveryState()` (which schedules a timeout using the current `recoveryAttempt`) **b... | true | ||
BloopAI/vibe-kanban | 3,138 | comment_to_fix | fix(auth): Add refresh token refresh grace window and degraded auth UI | ### TOCTOU race in early reuse check bypasses grace window
**Medium Severity**
<!-- DESCRIPTION START -->
The early reuse check at line 136 uses a stale `session` snapshot for `is_previous_refresh_token` but a fresh DB query for `is_revoked`. When two concurrent requests carry the same refresh token, request A may co... | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/crates/remote/src/routes/tokens.rs b/crates/remote/src/routes/tokens.rs
index 381a6aff032..f1d14461276 100644
--- a/crates/remote/src/routes/tokens.rs
+++ b/crates/remote/src/routes/tokens.rs
@@ -73,6 +73,33 @@ impl From<OAuthAccountError> for TokenRefreshError {
}
}
+fn current_session_tokens_resp... | [
"crates/remote/src/routes/tokens.rs"
] | [
{
"comment": "### TOCTOU race in early reuse check bypasses grace window\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe early reuse check at line 136 uses a stale `session` snapshot for `is_previous_refresh_token` but a fresh DB query for `is_revoked`. When two concurrent requests carry the same refr... | true | ||
BloopAI/vibe-kanban | 3,138 | comment_to_fix | fix(auth): Add refresh token refresh grace window and degraded auth UI | ### Previous refresh tokens not revoked in bulk session revocation
**Low Severity**
<!-- DESCRIPTION START -->
The new `revoke_auth_session` correctly inserts both `refresh_token_id` and `previous_refresh_token_id` into `revoked_refresh_tokens`, but `revoke_all_user_sessions` only inserts `refresh_token_id`. Since th... | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/crates/remote/src/db/auth.rs b/crates/remote/src/db/auth.rs
index 6c1b383a8bd..209280dccd8 100644
--- a/crates/remote/src/db/auth.rs
+++ b/crates/remote/src/db/auth.rs
@@ -48,7 +48,9 @@ impl<'a> AuthSessionRepository<'a> {
last_used_at AS "last_used_at?",
re... | [
"crates/remote/src/db/auth.rs"
] | [
{
"comment": "### Previous refresh tokens not revoked in bulk session revocation\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe new `revoke_auth_session` correctly inserts both `refresh_token_id` and `previous_refresh_token_id` into `revoked_refresh_tokens`, but `revoke_all_user_sessions` only inserts `... | true | ||
BloopAI/vibe-kanban | 3,138 | comment_to_fix | fix(auth): Add refresh token refresh grace window and degraded auth UI | ### Recovery loop not started for empty access token
**Low Severity**
<!-- DESCRIPTION START -->
In both `getToken()` and `doRefresh()`, the `!data.access_token` path calls `setRemoteAuthDegraded` but omits `this.syncRecoveryState()`. The catch blocks for thrown errors correctly call both. In `doRefresh()` specifical... | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/packages/web-core/src/shared/lib/auth/tokenManager.ts b/packages/web-core/src/shared/lib/auth/tokenManager.ts
index 8cc8a887668..41b69e5ecae 100644
--- a/packages/web-core/src/shared/lib/auth/tokenManager.ts
+++ b/packages/web-core/src/shared/lib/auth/tokenManager.ts
@@ -1,13 +1,47 @@
import { ApiError, o... | [
"packages/web-core/src/shared/lib/auth/tokenManager.ts"
] | [
{
"comment": "### Recovery loop not started for empty access token\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nIn both `getToken()` and `doRefresh()`, the `!data.access_token` path calls `setRemoteAuthDegraded` but omits `this.syncRecoveryState()`. The catch blocks for thrown errors correctly call both. ... | true | ||
BloopAI/vibe-kanban | 3,138 | comment_to_fix | fix(auth): Add refresh token refresh grace window and degraded auth UI | Perhaps worth adding an audit event here? | fa00afc9f8e78fa55484f8db097efd3fe7a829c7 | 5b281c75951695175babe40f6deba1f1b2a21ad4 | diff --git a/crates/server/src/routes/config.rs b/crates/server/src/routes/config.rs
index 3861bc2aa24..f22f7895c63 100644
--- a/crates/server/src/routes/config.rs
+++ b/crates/server/src/routes/config.rs
@@ -26,6 +26,7 @@ use services::services::{
save_config_to_file,
},
container::ContainerService,... | [
"crates/server/src/routes/config.rs"
] | [
{
"comment": "Perhaps worth adding an audit event here?",
"path": "crates/server/src/routes/config.rs",
"hunk": "@@ -105,18 +107,48 @@ async fn get_user_system_info(\n State(deployment): State<DeploymentImpl>,\n ) -> ResponseJson<ApiResponse<UserSystemInfo>> {\n let config = deployment.config().... | true | ||
BloopAI/vibe-kanban | 3,113 | issue_to_patch | feat: link PRs to issues directly | Add the ability to link PRs to issues without going through workspace creation.
## Summary
Adds the ability to link PRs to issues directly, without requiring a workspace. Users can paste a PR URL or browse open PRs from connected repos.
- Local: extracts PR tracking from the `merges` table into a dedicated loc... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/api-types/src/pull_request.rs b/crates/api-types/src/pull_request.rs
index 7d96280287d..bce2654e207 100644
--- a/crates/api-types/src/pull_request.rs
+++ b/crates/api-types/src/pull_request.rs
@@ -23,12 +23,21 @@ pub struct PullRequest {
pub merged_at: Option<DateTime<Utc>>,
pub merge_comm... | [
"crates/api-types/src/pull_request.rs",
"crates/db/.sqlx/query-0ee24d51e7557d9d6c9418a06156c03d7dd49dfe938194cd6951942dfd8f179d.json",
"crates/db/.sqlx/query-1085d1f8107c7e16fc2058ef610918760d8d420f0fca97adecd76d698f6f3a51.json",
"crates/db/.sqlx/query-167c1d13ee37ebe62cd2316feaf6b5354eb26d0a8fc16efb22827a5cd... | [
{
"comment": "### `create_for_workspace` returns phantom struct on duplicate URL\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`create_for_workspace` uses `INSERT OR IGNORE` with a `UNIQUE` constraint on `pr_url`, but always returns an `Ok(TrackedPr { ... })` constructed from the input parameters — even w... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Migration silently drops duplicate PR-workspace associations
**Medium Severity**
<!-- DESCRIPTION START -->
The migration uses `INSERT OR IGNORE` to copy PR rows from `merges` into `tracked_prs`, which has a `UNIQUE` constraint on `pr_url`. If multiple workspaces had merge records with the same `pr_url`, only the... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/migrations/20260311000000_add_tracked_prs.sql b/crates/db/migrations/20260311000000_add_tracked_prs.sql
new file mode 100644
index 00000000000..ac707a995e8
--- /dev/null
+++ b/crates/db/migrations/20260311000000_add_tracked_prs.sql
@@ -0,0 +1,27 @@
+CREATE TABLE pull_requests (
+ id TEXT PRIMA... | [
"crates/db/migrations/20260311000000_add_tracked_prs.sql"
] | [
{
"comment": "### Migration silently drops duplicate PR-workspace associations\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe migration uses `INSERT OR IGNORE` to copy PR rows from `merges` into `tracked_prs`, which has a `UNIQUE` constraint on `pr_url`. If multiple workspaces had merge records with ... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Issue status sync uses wrong PR status for multi-project updates
**Medium Severity**
<!-- DESCRIPTION START -->
In `update_pull_request`, the issue status sync loop uses `pr.status` from the last updated PR for *all* issues across all matched PRs. When `payload.status` is `None`, different PRs (across different p... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/routes/pull_requests.rs b/crates/remote/src/routes/pull_requests.rs
index 05c0d2b2459..a7854ad181a 100644
--- a/crates/remote/src/routes/pull_requests.rs
+++ b/crates/remote/src/routes/pull_requests.rs
@@ -1,6 +1,6 @@
use api_types::{
- ListPullRequestsQuery, ListPullRequestsResponse,... | [
"crates/remote/src/routes/pull_requests.rs"
] | [
{
"comment": "### Issue status sync uses wrong PR status for multi-project updates\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `update_pull_request`, the issue status sync loop uses `pr.status` from the last updated PR for *all* issues across all matched PRs. When `payload.status` is `None`, differ... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### `INSERT OR IGNORE` returns phantom record on conflict
**Low Severity**
<!-- DESCRIPTION START -->
`PullRequest::create` uses `INSERT OR IGNORE`, so when a duplicate `pr_url` exists the insert is silently skipped. The function still returns an `Ok(PullRequest { ... })` with a freshly generated `id` that was never ... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/src/models/pull_request.rs b/crates/db/src/models/pull_request.rs
new file mode 100644
index 00000000000..bb6897e416c
--- /dev/null
+++ b/crates/db/src/models/pull_request.rs
@@ -0,0 +1,354 @@
+use std::collections::HashMap;
+
+use chrono::{DateTime, Utc};
+use sqlx::{FromRow, SqlitePool};
+use u... | [
"crates/db/src/models/pull_request.rs"
] | [
{
"comment": "### `INSERT OR IGNORE` returns phantom record on conflict\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`PullRequest::create` uses `INSERT OR IGNORE`, so when a duplicate `pr_url` exists the insert is silently skipped. The function still returns an `Ok(PullRequest { ... })` with a freshly gen... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### DateTime format mismatch causes infinite PR sync loop
**High Severity**
<!-- DESCRIPTION START -->
`mark_synced` sets `synced_at` using SQL `CURRENT_TIMESTAMP` (format: `YYYY-MM-DD HH:MM:SS`) while `update_status` sets `updated_at` using `Utc::now()` via chrono/sqlx (format: `YYYY-MM-DDThh:mm:ss...`). The `get_pe... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/src/models/pull_request.rs b/crates/db/src/models/pull_request.rs
new file mode 100644
index 00000000000..bb6897e416c
--- /dev/null
+++ b/crates/db/src/models/pull_request.rs
@@ -0,0 +1,354 @@
+use std::collections::HashMap;
+
+use chrono::{DateTime, Utc};
+use sqlx::{FromRow, SqlitePool};
+use u... | [
"crates/db/src/models/pull_request.rs"
] | [
{
"comment": "### DateTime format mismatch causes infinite PR sync loop\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`mark_synced` sets `synced_at` using SQL `CURRENT_TIMESTAMP` (format: `YYYY-MM-DD HH:MM:SS`) while `update_status` sets `updated_at` using `Utc::now()` via chrono/sqlx (format: `YYYY-MM-DD... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Unknown status silently mapped to open causes polling loop
**Medium Severity**
<!-- DESCRIPTION START -->
`PullRequest::update_status` maps `MergeStatus::Unknown` to the string `"open"` when writing to the database. Previously, the old `Merge::update_status` stored the actual enum value as `"unknown"` via sqlx's ... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/src/models/pull_request.rs b/crates/db/src/models/pull_request.rs
new file mode 100644
index 00000000000..bb6897e416c
--- /dev/null
+++ b/crates/db/src/models/pull_request.rs
@@ -0,0 +1,354 @@
+use std::collections::HashMap;
+
+use chrono::{DateTime, Utc};
+use sqlx::{FromRow, SqlitePool};
+use u... | [
"crates/db/src/models/pull_request.rs"
] | [
{
"comment": "### Unknown status silently mapped to open causes polling loop\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`PullRequest::update_status` maps `MergeStatus::Unknown` to the string `\"open\"` when writing to the database. Previously, the old `Merge::update_status` stored the actual enum val... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Linked PR always created as Open on remote
**Medium Severity**
<!-- DESCRIPTION START -->
`link_pr_to_issue` hardcodes `PullRequestStatus::Open` in the `CreatePullRequestApiRequest`, regardless of the PR's actual state. When linking an already-merged or closed PR, the remote server creates it as "open" and trigge... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/server/src/routes/remote/pull_requests.rs b/crates/server/src/routes/remote/pull_requests.rs
index fa4216702b0..f9a1d930385 100644
--- a/crates/server/src/routes/remote/pull_requests.rs
+++ b/crates/server/src/routes/remote/pull_requests.rs
@@ -1,16 +1,22 @@
use api_types::{ListPullRequestsQuery, L... | [
"crates/server/src/routes/remote/pull_requests.rs"
] | [
{
"comment": "### Linked PR always created as Open on remote\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`link_pr_to_issue` hardcodes `PullRequestStatus::Open` in the `CreatePullRequestApiRequest`, regardless of the PR's actual state. When linking an already-merged or closed PR, the remote server crea... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Non-workspace PRs deleted by sync on remote 404
**High Severity**
<!-- DESCRIPTION START -->
The new `link_pr_to_issue` endpoint creates local PRs with `workspace_id = None`. When `sync_pending_to_remote` tries to push these to the remote and gets a 404 (e.g., the remote PR hasn't been created via Electric yet), ... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/services/src/services/pr_monitor.rs b/crates/services/src/services/pr_monitor.rs
index 563a3f4fb2d..c7ac93a2c9b 100644
--- a/crates/services/src/services/pr_monitor.rs
+++ b/crates/services/src/services/pr_monitor.rs
@@ -1,11 +1,12 @@
-use std::time::Duration;
+use std::{sync::Arc, time::Duration};
... | [
"crates/services/src/services/pr_monitor.rs"
] | [
{
"comment": "### Non-workspace PRs deleted by sync on remote 404\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe new `link_pr_to_issue` endpoint creates local PRs with `workspace_id = None`. When `sync_pending_to_remote` tries to push these to the remote and gets a 404 (e.g., the remote PR hasn't been ... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Client-provided ID silently ignored in create handler
**Medium Severity**
<!-- DESCRIPTION START -->
`CreatePullRequestIssueRequest` declares an optional `id` field documented as enabling "stable optimistic updates," but `create_pull_request_issue` never passes `payload.id` to `PullRequestIssueRepository::create`... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/routes/pull_request_issues.rs b/crates/remote/src/routes/pull_request_issues.rs
new file mode 100644
index 00000000000..af076fc676f
--- /dev/null
+++ b/crates/remote/src/routes/pull_request_issues.rs
@@ -0,0 +1,239 @@
+use api_types::{
+ CreatePullRequestIssueRequest, DeleteResponse, L... | [
"crates/remote/src/routes/pull_request_issues.rs"
] | [
{
"comment": "### Client-provided ID silently ignored in create handler\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`CreatePullRequestIssueRequest` declares an optional `id` field documented as enabling \"stable optimistic updates,\" but `create_pull_request_issue` never passes `payload.id` to `PullRe... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | Use `sqlx` macros everywhere. Should apply everywhere in this file. | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/src/models/merge.rs b/crates/db/src/models/merge.rs
index d0e485086df..d16ce624dd2 100644
--- a/crates/db/src/models/merge.rs
+++ b/crates/db/src/models/merge.rs
@@ -1,11 +1,11 @@
-use std::collections::HashMap;
-
use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};
-use sqlx::{Fro... | [
"crates/db/src/models/merge.rs"
] | [
{
"comment": "Use `sqlx` macros everywhere. Should apply everywhere in this file.",
"path": "crates/db/src/models/merge.rs",
"hunk": "@@ -95,210 +90,64 @@ impl Merge {\n let id = Uuid::new_v4();\n let now = Utc::now();\n \n- sqlx::query_as!(\n- MergeRow,\n- r... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ```suggestion
.ok_or(sqlx::Error::RowNotFound);
``` | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/db/src/models/pull_request.rs b/crates/db/src/models/pull_request.rs
new file mode 100644
index 00000000000..bb6897e416c
--- /dev/null
+++ b/crates/db/src/models/pull_request.rs
@@ -0,0 +1,354 @@
+use std::collections::HashMap;
+
+use chrono::{DateTime, Utc};
+use sqlx::{FromRow, SqlitePool};
+use u... | [
"crates/db/src/models/pull_request.rs"
] | [
{
"comment": "```suggestion\n .ok_or(sqlx::Error::RowNotFound);\n```",
"path": "crates/db/src/models/pull_request.rs",
"hunk": "@@ -0,0 +1,354 @@\n+use std::collections::HashMap;\n+\n+use chrono::{DateTime, Utc};\n+use sqlx::{FromRow, SqlitePool};\n+use uuid::Uuid;\n+\n+use super::merge::{Mer... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Backward-compat endpoints change response shape breaking older clients
**High Severity**
<!-- DESCRIPTION START -->
The `create_pull_request`, `update_pull_request`, and `upsert_pull_request` endpoints are documented as "Kept for backward compatibility with older clients," yet their return types changed from `Jso... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/routes/pull_requests.rs b/crates/remote/src/routes/pull_requests.rs
index 05c0d2b2459..a7854ad181a 100644
--- a/crates/remote/src/routes/pull_requests.rs
+++ b/crates/remote/src/routes/pull_requests.rs
@@ -1,6 +1,6 @@
use api_types::{
- ListPullRequestsQuery, ListPullRequestsResponse,... | [
"crates/remote/src/routes/pull_requests.rs"
] | [
{
"comment": "### Backward-compat endpoints change response shape breaking older clients\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `create_pull_request`, `update_pull_request`, and `upsert_pull_request` endpoints are documented as \"Kept for backward compatibility with older clients,\" yet their r... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Silent error swallowing in `list_prs` JSON parsing
**Medium Severity**
<!-- DESCRIPTION START -->
The `list_prs` method uses `unwrap_or_default()` when parsing both the open and closed PR JSON responses, silently returning empty vectors on parse failures. Every other parsing method in this file (`parse_pr_list`, ... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/git-host/src/github/cli.rs b/crates/git-host/src/github/cli.rs
index 88d2ceb1c98..6a6f8e6dcea 100644
--- a/crates/git-host/src/github/cli.rs
+++ b/crates/git-host/src/github/cli.rs
@@ -11,7 +11,7 @@ use std::{
};
use chrono::{DateTime, Utc};
-use db::models::merge::{MergeStatus, PullRequestInfo}... | [
"crates/git-host/src/github/cli.rs"
] | [
{
"comment": "### Silent error swallowing in `list_prs` JSON parsing\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `list_prs` method uses `unwrap_or_default()` when parsing both the open and closed PR JSON responses, silently returning empty vectors on parse failures. Every other parsing method in t... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Missing `headRefName` in `view_pr` JSON fields request
**Medium Severity**
<!-- DESCRIPTION START -->
The `view_pr` method requests JSON fields `"number,url,state,mergedAt,mergeCommit,title,baseRefName"` but omits `headRefName`. Since `GhPrResponse.head_ref_name` is `Option<String>` with `#[serde(default)]`, it d... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/git-host/src/github/cli.rs b/crates/git-host/src/github/cli.rs
index 88d2ceb1c98..6a6f8e6dcea 100644
--- a/crates/git-host/src/github/cli.rs
+++ b/crates/git-host/src/github/cli.rs
@@ -11,7 +11,7 @@ use std::{
};
use chrono::{DateTime, Utc};
-use db::models::merge::{MergeStatus, PullRequestInfo}... | [
"crates/git-host/src/github/cli.rs"
] | [
{
"comment": "### Missing `headRefName` in `view_pr` JSON fields request\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `view_pr` method requests JSON fields `\"number,url,state,mergedAt,mergeCommit,title,baseRefName\"` but omits `headRefName`. Since `GhPrResponse.head_ref_name` is `Option<String>` w... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Client-provided ID silently discarded on conflict
**Medium Severity**
<!-- DESCRIPTION START -->
In `PullRequestIssueRepository::create`, the client can supply an `id` for stable optimistic updates. However, the `ON CONFLICT (pull_request_id, issue_id) DO UPDATE` clause returns the *existing* row's `id`, silently... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/db/pull_request_issues.rs b/crates/remote/src/db/pull_request_issues.rs
new file mode 100644
index 00000000000..165456beab0
--- /dev/null
+++ b/crates/remote/src/db/pull_request_issues.rs
@@ -0,0 +1,196 @@
+use api_types::PullRequestIssue;
+use sqlx::{Executor, PgPool, Postgres};
+use thi... | [
"crates/remote/src/db/pull_request_issues.rs"
] | [
{
"comment": "### Client-provided ID silently discarded on conflict\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `PullRequestIssueRepository::create`, the client can supply an `id` for stable optimistic updates. However, the `ON CONFLICT (pull_request_id, issue_id) DO UPDATE` clause returns the *exi... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### `list_open_prs` now silently returns closed PRs too
**Medium Severity**
<!-- DESCRIPTION START -->
The `GitHostProvider` trait method `list_open_prs` is still named to imply it returns only open PRs, but the GitHub implementation now calls `cli.list_prs` which fetches both open AND closed/merged PRs (with `--stat... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/git-host/src/github/mod.rs b/crates/git-host/src/github/mod.rs
index aa01aa69c8f..619d7275be8 100644
--- a/crates/git-host/src/github/mod.rs
+++ b/crates/git-host/src/github/mod.rs
@@ -8,14 +8,13 @@ use async_trait::async_trait;
use backon::{ExponentialBuilder, Retryable};
pub use cli::GhCli;
use... | [
"crates/git-host/src/github/mod.rs"
] | [
{
"comment": "### `list_open_prs` now silently returns closed PRs too\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `GitHostProvider` trait method `list_open_prs` is still named to imply it returns only open PRs, but the GitHub implementation now calls `cli.list_prs` which fetches both open AND clos... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Existing PR status ignored when linking to issue
**Medium Severity**
<!-- DESCRIPTION START -->
In `create_pull_request_issue`, when a PR already exists in the project, the payload's `status`, `merged_at`, and `merge_commit_sha` are silently discarded—only the existing (potentially stale) DB record is used. The i... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/routes/pull_request_issues.rs b/crates/remote/src/routes/pull_request_issues.rs
new file mode 100644
index 00000000000..af076fc676f
--- /dev/null
+++ b/crates/remote/src/routes/pull_request_issues.rs
@@ -0,0 +1,239 @@
+use api_types::{
+ CreatePullRequestIssueRequest, DeleteResponse, L... | [
"crates/remote/src/routes/pull_request_issues.rs"
] | [
{
"comment": "### Existing PR status ignored when linking to issue\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `create_pull_request_issue`, when a PR already exists in the project, the payload's `status`, `merged_at`, and `merge_commit_sha` are silently discarded—only the existing (potentially stal... | true | ||
BloopAI/vibe-kanban | 3,113 | comment_to_fix | feat: link PRs to issues directly | ### Bulk migration zip misaligns PR IDs with issue IDs
**Medium Severity**
<!-- DESCRIPTION START -->
The `INNER JOIN issues i ON i.id = t.issue_id` added to the bulk insert can filter out rows where the issue doesn't exist, causing `ids` (from `RETURNING`) to be shorter than `issue_ids`. The subsequent `ids.iter().z... | 69aba3041b7b7051f5e51eb01ce0192cd5ce358c | 94c1c457f2e5b156d904bfa758c0de585fa7adbd | diff --git a/crates/remote/src/db/migration.rs b/crates/remote/src/db/migration.rs
index f98820e24f7..e2f3b3380f8 100644
--- a/crates/remote/src/db/migration.rs
+++ b/crates/remote/src/db/migration.rs
@@ -130,10 +130,12 @@ impl MigrationRepository {
let ids = sqlx::query_scalar!(
r#"
- ... | [
"crates/remote/src/db/migration.rs"
] | [
{
"comment": "### Bulk migration zip misaligns PR IDs with issue IDs\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `INNER JOIN issues i ON i.id = t.issue_id` added to the bulk insert can filter out rows where the issue doesn't exist, causing `ids` (from `RETURNING`) to be shorter than `issue_ids`. T... | true | ||
BloopAI/vibe-kanban | 3,242 | issue_to_patch | fix(relay): strip relay signing headers from preview proxy requests (Vibe Kanban) | ## Summary
Fixes 401 errors when previewing a Vibe Kanban instance inside Vibe Kanban via remote relay.
When a preview target is itself a VK instance, the preview proxy was forwarding `x-vk-relayed` and `x-vk-sig-*` headers to the dev server. The target VK's signing middleware interpreted these as relay requests and ... | 70864474038dd09ea4af9cb09254561872dde2e6 | ee5c757bbd82138a39f1a4a6ddd955572a610386 | diff --git a/crates/preview-proxy/src/proxy_common.rs b/crates/preview-proxy/src/proxy_common.rs
index 45af770134b..ab009e0857b 100644
--- a/crates/preview-proxy/src/proxy_common.rs
+++ b/crates/preview-proxy/src/proxy_common.rs
@@ -14,6 +14,15 @@ pub const SKIP_REQUEST_HEADERS: &[&str] = &[
"sec-websocket-extensi... | [
"crates/preview-proxy/src/proxy_common.rs"
] | [] | true | ||
BloopAI/vibe-kanban | 3,241 | issue_to_patch | fix(ci): fix pnpm run lint and add missing crates to CI path filters (Vibe Kanban) | ## Summary
- **Fixed clippy lint failure** in `relay-tunnel-core`: replaced field-reassignment-after-`Default::default()` with struct initialization syntax (`YamuxConfig { ..Default::default() }`) to satisfy `clippy::field_reassign_with_default`.
- **Fixed rustfmt formatting** in `crates/remote/src/mail.rs` that had d... | 1bfdc294715573209a20e5a801dfcc760154eb2b | fc19b5b8c1e0aa9b51561237c97a9ba2ff1b48b8 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ccf84ab06dd..c9c097cbc9a 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -59,16 +59,31 @@ jobs:
- '.github/actions/**'
backend:
- 'crates/api-types/**'
+ - 'crat... | [
".github/workflows/test.yml",
"crates/relay-tunnel-core/src/lib.rs",
"crates/remote/src/mail.rs"
] | [] | true | ||
BloopAI/vibe-kanban | 3,225 | issue_to_patch | Add cursor models to include composer-2, composer-2-fast | Adding cursor models list to include Composer 2 and Composer 2 Fast
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: this only expands the selectable model list and updates schema/descriptions, without changing execution or permission logic.
>
> **Overview**
> **Cursor executor now exposes additional... | 70ca5a068e449c0e699f315e8cbee31f7a4e30bf | 390cc3352e99a67e0097c303b8cc99548c5ff236 | diff --git a/crates/executors/src/executors/cursor.rs b/crates/executors/src/executors/cursor.rs
index bde8027657f..fd3eefde866 100644
--- a/crates/executors/src/executors/cursor.rs
+++ b/crates/executors/src/executors/cursor.rs
@@ -47,7 +47,7 @@ pub struct CursorAgent {
pub force: Option<bool>,
#[serde(defau... | [
"crates/executors/src/executors/cursor.rs",
"shared/schemas/cursor_agent.json"
] | [] | true | ||
BloopAI/vibe-kanban | 3,238 | issue_to_patch | fix(relay): use actual server bind address instead of hardcoded 127.0.0.1 (Vibe Kanban) | ## Summary
On macOS, the Tauri app binds to `localhost:0` which resolves to `::1` (IPv6), but the relay client and preview proxy were hardcoded to connect to `127.0.0.1` (IPv4). This mismatch caused all relay-tunneled requests to fail with 502 Bad Gateway — breaking Tauri-to-Tauri pairing and remote preview proxying.
... | 74ee4a6e886858d3b89ebc8f27039c6b652e60f7 | fc1a38023500b2ffc1727729a18671805cc716b4 | diff --git a/crates/client-info/src/lib.rs b/crates/client-info/src/lib.rs
index 378f5f5adb9..91ac1d2fe87 100644
--- a/crates/client-info/src/lib.rs
+++ b/crates/client-info/src/lib.rs
@@ -1,10 +1,9 @@
-use std::sync::OnceLock;
+use std::{net::SocketAddr, sync::OnceLock};
/// Runtime information about the local serv... | [
"crates/client-info/src/lib.rs",
"crates/preview-proxy/src/lib.rs",
"crates/relay-tunnel-core/src/client.rs",
"crates/server/src/main.rs",
"crates/server/src/routes/preview.rs",
"crates/server/src/runtime/relay_registration.rs",
"crates/server/src/startup.rs"
] | [
{
"comment": "### Non-IP hostname causes infinite retry loop\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `local_hostname` is validated as `Some` in `resolve_relay_params` but only parsed as `IpAddr` later inside `start_relay`, which runs inside the reconnect retry loop. In the `main.rs` path, the hos... | true | ||
BloopAI/vibe-kanban | 3,238 | comment_to_fix | fix(relay): use actual server bind address instead of hardcoded 127.0.0.1 (Vibe Kanban) | ### Non-IP hostname causes infinite retry loop
**Low Severity**
<!-- DESCRIPTION START -->
The `local_hostname` is validated as `Some` in `resolve_relay_params` but only parsed as `IpAddr` later inside `start_relay`, which runs inside the reconnect retry loop. In the `main.rs` path, the hostname comes from the `HOST`... | 74ee4a6e886858d3b89ebc8f27039c6b652e60f7 | fc1a38023500b2ffc1727729a18671805cc716b4 | diff --git a/crates/server/src/runtime/relay_registration.rs b/crates/server/src/runtime/relay_registration.rs
index 84316b36965..f552ac59fa5 100644
--- a/crates/server/src/runtime/relay_registration.rs
+++ b/crates/server/src/runtime/relay_registration.rs
@@ -1,6 +1,8 @@
//! Relay host connection — registers the loca... | [
"crates/server/src/runtime/relay_registration.rs"
] | [
{
"comment": "### Non-IP hostname causes infinite retry loop\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `local_hostname` is validated as `Some` in `resolve_relay_params` but only parsed as `IpAddr` later inside `start_relay`, which runs inside the reconnect retry loop. In the `main.rs` path, the hos... | true | ||
BookStackApp/BookStack | 6,109 | issue_to_patch | PDF: Started building system to allow custom DOMPDF font loading | Adds a way for custom fonts to be loaded for use with DomPDF.
On export, BookStack scans the `storage/fonts/dompdf` folder for `*.ttf` font files, then for each attempts to build the required `.ufm` (font-metrics) file where they don't already exist.
Then it auto-converts the naming scheme to suit dompdf.
### C... | 4f370ccddb4f5fd8eddff5915a9413786ae2a2c7 | 00239bb6c85e36cf724c2c9dfce7e3deb7c558a2 | diff --git a/app/Config/exports.php b/app/Config/exports.php
index 2e22bc759e3..f48fe0a67a3 100644
--- a/app/Config/exports.php
+++ b/app/Config/exports.php
@@ -68,7 +68,7 @@
* Times-Roman, Times-Bold, Times-BoldItalic, Times-Italic,
* Symbol, ZapfDingbats.
*/
- 'font_dir' => storag... | [
"app/Config/exports.php",
"app/Exports/PdfGenerator.php",
"storage/fonts/.gitignore",
"storage/fonts/dompdf/.gitignore",
"storage/fonts/dompdf/cache/.gitignore",
"tests/Exports/PdfExportTest.php",
"tests/test-data/fonts/Cardiff-Bold.ttf",
"tests/test-data/fonts/Cardiff.ttf",
"tests/test-data/fonts/a... | [] | diff --git a/tests/Exports/PdfExportTest.php b/tests/Exports/PdfExportTest.php
index f311f8457db..78da3b0c2cc 100644
--- a/tests/Exports/PdfExportTest.php
+++ b/tests/Exports/PdfExportTest.php
@@ -79,6 +79,39 @@ public function test_page_pdf_export_opens_details_blocks()
$this->assertStringContainsString('<det... | true | |
BookStackApp/BookStack | 6,069 | issue_to_patch | Fix PDF export heading font fallback | PDF exports used the heading font var which in DOMPDF fell back to base fonts lacking Polish glyphs, causing ? in titles. This PR adds a PDF-only heading font fallback to DejaVu Sans for h1-h6. Tested by exporting a page with a Polish title; characters render correctly.
Before
<img width="792" height="386" alt="i... | 25790fd0245257ffaffe6690b8e12d56b326af9b | 0b659671fe08da3a699f0b4ddd93e77e18d13b11 | diff --git a/resources/sass/export-styles.scss b/resources/sass/export-styles.scss
index 8dd7be375e8..22f15d1b82a 100644
--- a/resources/sass/export-styles.scss
+++ b/resources/sass/export-styles.scss
@@ -64,6 +64,11 @@ body.export-format-pdf {
font-size: 14px;
line-height: 1.2;
+ // Ensure heading glyph cover... | [
"resources/sass/export-styles.scss"
] | [] | true | ||
BookStackApp/BookStack | 6,108 | issue_to_patch | Permissions: Started addition of revision-view permission | For #4526
### Todo
- [x] Add at a database level
- [x] Add for roles based on any existing page-view-all or page-view-own permissions.
- [x] Testing coverage
- [x] Access control testing
- [x] Manual testing
### Docs Updates
- Update Advisory: Note that revision visibility is now controlled separat... | 083fb1a600f1eeb8acb719675bdeb089c86ceee1 | 426f9ac4934308da9f57580bc0e2fe399346cbb1 | diff --git a/app/Entities/Controllers/PageRevisionController.php b/app/Entities/Controllers/PageRevisionController.php
index 4bc15e6e967..cc6b79bfe45 100644
--- a/app/Entities/Controllers/PageRevisionController.php
+++ b/app/Entities/Controllers/PageRevisionController.php
@@ -34,6 +34,7 @@ public function __construct(
... | [
"app/Entities/Controllers/PageRevisionController.php",
"app/Permissions/Permission.php",
"database/migrations/2026_04_19_141616_add_revision_view_all_permission.php",
"lang/en/settings.php",
"resources/views/entities/meta.blade.php",
"resources/views/exports/parts/meta.blade.php",
"resources/views/pages... | [] | diff --git a/tests/Entity/PageRevisionTest.php b/tests/Entity/PageRevisionTest.php
index 132a10fa4da..8b46e84a634 100644
--- a/tests/Entity/PageRevisionTest.php
+++ b/tests/Entity/PageRevisionTest.php
@@ -4,6 +4,8 @@
use BookStack\Activity\ActivityType;
use BookStack\Entities\Models\Page;
+use BookStack\Entities\Mo... | true | |
BookStackApp/BookStack | 6,085 | issue_to_patch | Maintenance: Started work for PHPStan Level 4 | e033578feaa86dd0a3ac8dc4137bfec66a1baee7 | 58e2e0ea241e4059e202084fec40d7668613e774 | diff --git a/.gitignore b/.gitignore
index b545d161f13..06a8723c5c1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,6 +2,7 @@
/node_modules
/.vscode
/composer
+/composer.phar
/coverage
Homestead.yaml
.env
diff --git a/app/Access/EmailConfirmationService.php b/app/Access/EmailConfirmationService.php
index 1a5156d3e... | [
".gitignore",
"app/Access/EmailConfirmationService.php",
"app/Access/LoginService.php",
"app/Access/Mfa/MfaValue.php",
"app/Access/Oidc/OidcJwtSigningKey.php",
"app/Access/Oidc/OidcJwtWithClaims.php",
"app/Access/Oidc/OidcUserDetails.php",
"app/Access/Saml2Service.php",
"app/Access/SocialAuthService... | [] | diff --git a/tests/Api/SearchApiTest.php b/tests/Api/SearchApiTest.php
index 517c5d8e4ef..5d0ce53ec1c 100644
--- a/tests/Api/SearchApiTest.php
+++ b/tests/Api/SearchApiTest.php
@@ -106,6 +106,7 @@ public function test_all_endpoint_includes_parent_details_where_visible()
$this->permissions->setEntityPermissions... | true | ||
BookStackApp/BookStack | 5,919 | issue_to_patch | Merge v25-11 changes into dev | 0f40aeb0d31cae2f7b27ec7e7a9e6ad7562341eb | 313326b32adc8a916420d77d1ce1aa6f1d6b8ebb | diff --git a/app/Access/Controllers/OidcController.php b/app/Access/Controllers/OidcController.php
index 055d4c1403f..654ed692880 100644
--- a/app/Access/Controllers/OidcController.php
+++ b/app/Access/Controllers/OidcController.php
@@ -9,11 +9,9 @@
class OidcController extends Controller
{
- protected OidcServi... | [
"app/Access/Controllers/OidcController.php",
"app/Activity/Models/Comment.php",
"app/Activity/Notifications/Handlers/BaseNotificationHandler.php",
"app/Http/Middleware/StartSessionExtended.php",
"composer.json",
"composer.lock",
"dev/licensing/js-library-licenses.txt",
"dev/licensing/php-library-licen... | [] | diff --git a/tests/Api/ApiDocsTest.php b/tests/Api/ApiDocsTest.php
index a1603e0ef82..bdf753e87f7 100644
--- a/tests/Api/ApiDocsTest.php
+++ b/tests/Api/ApiDocsTest.php
@@ -22,7 +22,7 @@ public function test_docs_page_returns_view_with_docs_content()
$resp->assertStatus(200);
$resp->assertSee(url('/ap... | true | ||
BookStackApp/BookStack | 6,100 | issue_to_patch | WYSIWYG: Added inline code support to minimal editor | Used for comments and descriptions.
Also updated shortcut handling that we're not registering shortcuts for edits which can't use the related formatting types.
For #6003 | 0760e677b25d96306b2d1a732c0f92d83ac41ac0 | 18364d1e6e235ab129a03e77279201436bcd954a | diff --git a/app/Util/HtmlDescriptionFilter.php b/app/Util/HtmlDescriptionFilter.php
index 1baa11ffcfa..ba145460381 100644
--- a/app/Util/HtmlDescriptionFilter.php
+++ b/app/Util/HtmlDescriptionFilter.php
@@ -27,6 +27,7 @@ class HtmlDescriptionFilter
'span' => [],
'em' => [],
'br' => [],
+ ... | [
"app/Util/HtmlDescriptionFilter.php",
"resources/js/wysiwyg/index.ts",
"resources/js/wysiwyg/services/shortcuts.ts",
"resources/js/wysiwyg/ui/defaults/toolbars.ts",
"tests/Entity/BookTest.php"
] | [] | diff --git a/tests/Entity/BookTest.php b/tests/Entity/BookTest.php
index 6082c59de61..c0d4fbc63e6 100644
--- a/tests/Entity/BookTest.php
+++ b/tests/Entity/BookTest.php
@@ -256,8 +256,8 @@ public function test_description_limited_to_specific_html()
{
$book = $this->entities->book();
- $input = '<... | true | |
BookStackApp/BookStack | 6,095 | issue_to_patch | API: New tag endpoints | Adds new API endpoints to get tag information, providing the same benefits as the `/tags` UI view.
For #5835
### Todo
- [x] Add some API docs guidance to note how tags are created/updated/deleted (via entities).
- [x] Add API docs examples
- [x] Cover with testing
- [x] Test results limited by permissions/v... | 93f84a81b28ada7467e66d240182a71e5d60278f | 208629ee1fce280c31f9baf30a6ed79c3cd17df0 | diff --git a/app/Activity/Controllers/TagApiController.php b/app/Activity/Controllers/TagApiController.php
new file mode 100644
index 00000000000..f5c5e95d420
--- /dev/null
+++ b/app/Activity/Controllers/TagApiController.php
@@ -0,0 +1,68 @@
+<?php
+
+declare(strict_types=1);
+
+namespace BookStack\Activity\Controllers... | [
"app/Activity/Controllers/TagApiController.php",
"app/Activity/Controllers/TagController.php",
"app/Activity/TagRepo.php",
"app/Api/ApiDocsGenerator.php",
"app/Api/ListingResponseBuilder.php",
"app/Http/ApiController.php",
"dev/api/requests/image-gallery-read-data-for-url.http",
"dev/api/requests/tags... | [] | diff --git a/tests/Api/TagsApiTest.php b/tests/Api/TagsApiTest.php
new file mode 100644
index 00000000000..a079fa63915
--- /dev/null
+++ b/tests/Api/TagsApiTest.php
@@ -0,0 +1,109 @@
+<?php
+
+namespace Api;
+
+use BookStack\Activity\Models\Tag;
+use BookStack\Entities\Models\Book;
+use BookStack\Entities\Models\Chapte... | true | |
BookStackApp/BookStack | 6,083 | issue_to_patch | New HTML to Plaintext handling | To achieve a better and more consistent output.
### Todo
- [x] See if we can use this new class for exports also. | 25790fd0245257ffaffe6690b8e12d56b326af9b | abed4eae0c541a44990d260796e21e420d8243ad | diff --git a/app/Activity/Models/Comment.php b/app/Activity/Models/Comment.php
index ab7d917729c..3faa76657b6 100644
--- a/app/Activity/Models/Comment.php
+++ b/app/Activity/Models/Comment.php
@@ -9,6 +9,7 @@
use BookStack\Users\Models\OwnableInterface;
use BookStack\Util\HtmlContentFilter;
use BookStack\Util\HtmlCo... | [
"app/Activity/Models/Comment.php",
"app/Activity/Notifications/Messages/CommentCreationNotification.php",
"app/Activity/Notifications/Messages/CommentMentionNotification.php",
"app/Entities/Repos/BaseRepo.php",
"app/Entities/Tools/PageContent.php",
"app/Exports/ExportFormatter.php",
"app/Util/HtmlToPlai... | [] | diff --git a/tests/Exports/TextExportTest.php b/tests/Exports/TextExportTest.php
index 4b2d6288775..26298c185da 100644
--- a/tests/Exports/TextExportTest.php
+++ b/tests/Exports/TextExportTest.php
@@ -52,7 +52,7 @@ public function test_book_text_export_format()
$resp = $this->asEditor()->get($entities['book']-... | true | |
BookStackApp/BookStack | 6,094 | issue_to_patch | Install Module Command Updates | - Theme module ZIPs will now support their files being in a single nested directory within a ZIP, to support common ZIP structure approaches. Added test to cover.
- Allowed cross-origin redirects on download, With a prompt to the user to confirm they trust the new origin.
For #6066 | 5e78dc6ed54aeb6d3d2565334074286a0e249b78 | 5fbaab474058c9c90496649d53dd002e25419884 | diff --git a/app/Console/Commands/InstallModuleCommand.php b/app/Console/Commands/InstallModuleCommand.php
index 20252525df8..114bfb105d8 100644
--- a/app/Console/Commands/InstallModuleCommand.php
+++ b/app/Console/Commands/InstallModuleCommand.php
@@ -213,15 +213,23 @@ protected function downloadModuleFile(string $loc... | [
"app/Console/Commands/InstallModuleCommand.php",
"app/Theming/ThemeModuleZip.php",
"dev/docs/theme-system-modules.md",
"tests/Commands/InstallModuleCommandTest.php"
] | [] | diff --git a/tests/Commands/InstallModuleCommandTest.php b/tests/Commands/InstallModuleCommandTest.php
index 8ffc4ead3a0..c085c49077d 100644
--- a/tests/Commands/InstallModuleCommandTest.php
+++ b/tests/Commands/InstallModuleCommandTest.php
@@ -96,18 +96,44 @@ public function test_remote_module_install_follows_redirect... | true | |
BookStackApp/BookStack | 6,090 | issue_to_patch | Maintenance: Updated NPM packages | Includes typescript update to 6. Needed to update some typescript config to align with actual module environment used and built by esbuild. | e033578feaa86dd0a3ac8dc4137bfec66a1baee7 | 45ff8c21b4b127e3a843813bca0e410491ea76ec | diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml
index 13f9a8a9819..379f1ebfaa7 100644
--- a/.github/workflows/test-js.yml
+++ b/.github/workflows/test-js.yml
@@ -17,7 +17,7 @@ jobs:
if: ${{ github.ref != 'refs/heads/l10n_development' }}
runs-on: ubuntu-24.04
steps:
- - uses:... | [
".github/workflows/test-js.yml",
"jest.config.ts",
"package-lock.json",
"package.json",
"tsconfig.json"
] | [] | true | ||
BookStackApp/BookStack | 6,067 | issue_to_patch | Updated translations with latest Crowdin changes | 25790fd0245257ffaffe6690b8e12d56b326af9b | c5e188c2aab4ba8dcef9870f444c5af97ef550b9 | diff --git a/lang/da/editor.php b/lang/da/editor.php
index f135f06a90b..628e1319e21 100644
--- a/lang/da/editor.php
+++ b/lang/da/editor.php
@@ -36,7 +36,7 @@
'paragraph' => 'Paragraf',
'blockquote' => 'Citat',
'inline_code' => 'Inline kode',
- 'callouts' => 'Callouts',
+ 'callouts' => 'Tekstfelter... | [
"lang/da/editor.php",
"lang/da/entities.php",
"lang/da/errors.php",
"lang/da/settings.php",
"lang/de/entities.php",
"lang/de/settings.php",
"lang/de_informal/entities.php",
"lang/de_informal/settings.php",
"lang/ko/editor.php",
"lang/ko/errors.php",
"lang/pt/common.php",
"lang/pt/editor.php",
... | [] | true | |||
BookStackApp/BookStack | 6,064 | issue_to_patch | Updated translations with latest Crowdin changes | 0120b475eb18c7d4e1851a937cafd12724fabb31 | cebad23b352b2675293e11310a54f8d2c74c3f84 | diff --git a/lang/cs/settings.php b/lang/cs/settings.php
index ef25f1a2035..a8c4036e87e 100644
--- a/lang/cs/settings.php
+++ b/lang/cs/settings.php
@@ -104,7 +104,7 @@
'sort_rule_op_chapters_first' => 'Kapitoly jako první',
'sort_rule_op_chapters_last' => 'Kapitoly jako poslední',
'sorting_page_limits' ... | [
"lang/cs/settings.php",
"lang/de/errors.php",
"lang/de/notifications.php",
"lang/de/preferences.php",
"lang/de_informal/errors.php",
"lang/de_informal/notifications.php",
"lang/de_informal/preferences.php",
"lang/fr/settings.php",
"lang/ja/settings.php"
] | [] | true | |||
BookStackApp/BookStack | 6,060 | issue_to_patch | Update PHP_CodeSniffer repository link | PHP_CodeSniffer has moved to a new GitHub organization. The `squizlabs/PHP_CodeSniffer` repository is now archived and the project is actively maintained at https://github.com/PHPCSStandards/PHP_CodeSniffer.
See: https://github.com/squizlabs/PHP_CodeSniffer/issues/3932 | 0120b475eb18c7d4e1851a937cafd12724fabb31 | 04dd9f8e19301fde58218864ae51eef6b678f27a | diff --git a/dev/docs/development.md b/dev/docs/development.md
index 418e9ead672..2c73a0256c5 100644
--- a/dev/docs/development.md
+++ b/dev/docs/development.md
@@ -37,7 +37,7 @@ We use tools to manage code standards and formatting within the project. If subm
### PHP
-PHP code standards are managed by [using PHP_C... | [
"dev/docs/development.md",
"readme.md"
] | [] | true | ||
BookStackApp/BookStack | 6,007 | issue_to_patch | Updated translations with latest Crowdin changes | 46dcc30bf7504459385192a3edcf525a4877a4de | 5a8dfcaad45d3a4ad0f370a29e34185367e66221 | diff --git a/lang/ar/settings.php b/lang/ar/settings.php
index dc95ac8468f..3191bbe3a0a 100644
--- a/lang/ar/settings.php
+++ b/lang/ar/settings.php
@@ -104,7 +104,7 @@
'sort_rule_op_chapters_first' => 'الفصول الأولى',
'sort_rule_op_chapters_last' => 'الفصول الأخيرة',
'sorting_page_limits' => 'حدود العرض... | [
"lang/ar/settings.php",
"lang/bg/settings.php",
"lang/bn/settings.php",
"lang/bs/settings.php",
"lang/ca/settings.php",
"lang/cs/errors.php",
"lang/cs/settings.php",
"lang/cy/settings.php",
"lang/da/settings.php",
"lang/de/settings.php",
"lang/de_informal/settings.php",
"lang/el/settings.php",... | [] | true | |||
BookStackApp/BookStack | 6,057 | issue_to_patch | V25.12 changes v3 | 151823b84e227e6ed63a216ff970ce2fa5491fca | 5f5fea7c83992cecca61b4aabfc1e07053dfa4c4 | diff --git a/app/Entities/Controllers/PageRevisionController.php b/app/Entities/Controllers/PageRevisionController.php
index 35f1e8daf0e..4bc15e6e967 100644
--- a/app/Entities/Controllers/PageRevisionController.php
+++ b/app/Entities/Controllers/PageRevisionController.php
@@ -12,6 +12,8 @@
use BookStack\Facades\Activi... | [
"app/Entities/Controllers/PageRevisionController.php",
"app/Http/Controller.php",
"composer.lock",
"tests/Entity/PageRevisionTest.php",
"tests/User/UserPreferencesTest.php"
] | [] | diff --git a/tests/Entity/PageRevisionTest.php b/tests/Entity/PageRevisionTest.php
index 3828bd06e4a..132a10fa4da 100644
--- a/tests/Entity/PageRevisionTest.php
+++ b/tests/Entity/PageRevisionTest.php
@@ -47,6 +47,20 @@ public function test_page_revision_preview_shows_content_of_revision()
$revisionView->asser... | true | ||
BookStackApp/BookStack | 6,035 | issue_to_patch | Merge further v25-12 changes into development | 6808292c90ce9cced8562651b12635f5ac6a3f3b | 25ed242f61293731210e7962ac63561796396654 | diff --git a/app/Util/ConfiguredHtmlPurifier.php b/app/Util/ConfiguredHtmlPurifier.php
index ab23333882a..1f2528e7155 100644
--- a/app/Util/ConfiguredHtmlPurifier.php
+++ b/app/Util/ConfiguredHtmlPurifier.php
@@ -71,6 +71,8 @@ protected function setConfig(HTMLPurifier_Config $config, string $cachePath): vo
$co... | [
"app/Util/ConfiguredHtmlPurifier.php",
"composer.lock",
"tests/Entity/PageContentFilteringTest.php"
] | [] | diff --git a/tests/Entity/PageContentFilteringTest.php b/tests/Entity/PageContentFilteringTest.php
index 4f77e063369..449189a898c 100644
--- a/tests/Entity/PageContentFilteringTest.php
+++ b/tests/Entity/PageContentFilteringTest.php
@@ -478,4 +478,25 @@ public function test_allow_list_style_filtering()
$re... | true | ||
BookStackApp/BookStack | 5,864 | issue_to_patch | Set cursor to pointer for drawio diagrams | Add cursor style for drawio diagrams in TinyMCE. | 652124abaf8888339190bf2cbfd74c225ae28421 | 570ded10fa7cc17762363dcf622e72664a6fee15 | diff --git a/resources/sass/_tinymce.scss b/resources/sass/_tinymce.scss
index 8cc96df4193..561bb23cae0 100644
--- a/resources/sass/_tinymce.scss
+++ b/resources/sass/_tinymce.scss
@@ -202,4 +202,12 @@ body.page-content.mce-content-body {
background-image: url('data:image/svg+xml;utf8,<svg fill="%23FFFFFF" version=... | [
"resources/sass/_tinymce.scss"
] | [] | true | ||
BookStackApp/BookStack | 6,027 | issue_to_patch | Merge changes from V25-12 patches | 5e12b678c78735ea20d73445a159f0df5bb45080 | 80204518a25bb98beb0790f06496f19ec66d61ca | diff --git a/.env.example.complete b/.env.example.complete
index 18e7bd00d9c..ebebaf9e3e8 100644
--- a/.env.example.complete
+++ b/.env.example.complete
@@ -351,10 +351,25 @@ EXPORT_PDF_COMMAND_TIMEOUT=15
# Only used if 'ALLOW_UNTRUSTED_SERVER_FETCHING=true' which disables security protections.
WKHTMLTOPDF=false
-#... | [
".env.example.complete",
"app/Activity/Models/Comment.php",
"app/Config/app.php",
"app/Entities/Controllers/PageController.php",
"app/Entities/Tools/EntityHtmlDescription.php",
"app/Entities/Tools/PageContent.php",
"app/Entities/Tools/PageEditorData.php",
"app/Theming/CustomHtmlHeadContentProvider.php... | [] | diff --git a/tests/Entity/PageContentFilteringTest.php b/tests/Entity/PageContentFilteringTest.php
new file mode 100644
index 00000000000..4f77e063369
--- /dev/null
+++ b/tests/Entity/PageContentFilteringTest.php
@@ -0,0 +1,481 @@
+<?php
+
+namespace Tests\Entity;
+
+use Tests\TestCase;
+
+class PageContentFilteringTes... | true | ||
BookStackApp/BookStack | 5,998 | issue_to_patch | Further theme system developments | ### Additions
- Before/After view include support.
- Modular hack support - Theme Modules
- Module fetch format/system.
- Split out show/index template sidebar elements into their own views for easier customization control.
### Ideas
- Abstract usage of `THEME_*` config env options?
- Gonna skip this one... | ff59bbdc0780d0ac5e197ce16b99713b36a6ade8 | 057d7be0bc7eb7bc6b62136da6e98c199f82f12f | diff --git a/app/App/Providers/ThemeServiceProvider.php b/app/App/Providers/ThemeServiceProvider.php
index 2cf581d3863..671e5e1df74 100644
--- a/app/App/Providers/ThemeServiceProvider.php
+++ b/app/App/Providers/ThemeServiceProvider.php
@@ -4,6 +4,8 @@
use BookStack\Theming\ThemeEvents;
use BookStack\Theming\ThemeS... | [
"app/App/Providers/ThemeServiceProvider.php",
"app/App/helpers.php",
"app/Config/view.php",
"app/Console/Commands/InstallModuleCommand.php",
"app/Theming/ThemeController.php",
"app/Theming/ThemeEvents.php",
"app/Theming/ThemeModule.php",
"app/Theming/ThemeModuleException.php",
"app/Theming/ThemeModu... | [] | diff --git a/tests/Commands/InstallModuleCommandTest.php b/tests/Commands/InstallModuleCommandTest.php
new file mode 100644
index 00000000000..0872efc3f26
--- /dev/null
+++ b/tests/Commands/InstallModuleCommandTest.php
@@ -0,0 +1,289 @@
+<?php
+
+namespace Tests\Commands;
+
+use GuzzleHttp\Psr7\Response;
+use Illuminat... | true | |
BookStackApp/BookStack | 5,997 | issue_to_patch | Updated translations with latest Crowdin changes | ff59bbdc0780d0ac5e197ce16b99713b36a6ade8 | e389f9f5f309352fb1fe3f3833115df56da273b9 | diff --git a/lang/ar/errors.php b/lang/ar/errors.php
index 491f04c079a..25ba3544d57 100644
--- a/lang/ar/errors.php
+++ b/lang/ar/errors.php
@@ -125,6 +125,7 @@
'api_incorrect_token_secret' => 'الشفرة المُقدمة لرمز API المستخدم المحدد غير صحيحة',
'api_user_no_api_permission' => 'مالك رمز API المستخدم ليس لديه... | [
"lang/ar/errors.php",
"lang/bg/errors.php",
"lang/bn/errors.php",
"lang/bs/errors.php",
"lang/ca/errors.php",
"lang/cs/errors.php",
"lang/cy/errors.php",
"lang/da/editor.php",
"lang/da/entities.php",
"lang/da/errors.php",
"lang/da/notifications.php",
"lang/da/preferences.php",
"lang/da/setti... | [] | true | |||
BookStackApp/BookStack | 5,970 | issue_to_patch | Updated translations with latest Crowdin changes | 07ec880e3385221f99f3f1428fe5d8488887ff8d | f4f970fa280a02a2d39a9d79821557695c420e9b | diff --git a/lang/bg/auth.php b/lang/bg/auth.php
index 71cd2a71295..4a7e56f22e0 100644
--- a/lang/bg/auth.php
+++ b/lang/bg/auth.php
@@ -6,7 +6,7 @@
*/
return [
- 'failed' => 'Въведените удостоверителни данни не съвпадат с нашите записи.',
+ 'failed' => 'Въведените данни не съвпадат с информацията в системат... | [
"lang/bg/auth.php",
"lang/bg/common.php",
"lang/bg/editor.php",
"lang/bg/errors.php",
"lang/cs/errors.php",
"lang/cs/validation.php",
"lang/es/errors.php",
"lang/es/validation.php",
"lang/es_AR/errors.php",
"lang/es_AR/validation.php",
"lang/et/errors.php",
"lang/et/validation.php",
"lang/fr... | [] | true | |||
BookStackApp/BookStack | 5,969 | issue_to_patch | Git 2.35+ may refuse to operate on bind-mounted repos with differing ownership ("dubious ownership"), Mark /app as safe within the container. | Local Environment:
WSL2 + Windows 11 + Docker Desktop + Git 2.43.0
After starting the application with docker compose up, the logs show the following warning:
The repository at "/app" does not have the correct ownership and git refuses to use it:
fatal: detected dubious ownership in repository at '/app'
To a... | 07ec880e3385221f99f3f1428fe5d8488887ff8d | 018de5def3342f1f1bd62354ffa239ade2d937cd | diff --git a/dev/docker/Dockerfile b/dev/docker/Dockerfile
index edab90ca1c5..b64899f797f 100644
--- a/dev/docker/Dockerfile
+++ b/dev/docker/Dockerfile
@@ -14,6 +14,9 @@ RUN apt-get update && \
wait-for-it && \
rm -rf /var/lib/apt/lists/*
+# Mark /app as safe for Git >= 2.35.2
+RUN git config --system ... | [
"dev/docker/Dockerfile"
] | [] | true | ||
BookStackApp/BookStack | 5,962 | issue_to_patch | Updated translations with latest Crowdin changes | 38d3697246a294d011461ceb9850bc45bcef61ce | a3bb752b3e71481f0a665afadbdd302e9e577a28 | diff --git a/lang/ar/errors.php b/lang/ar/errors.php
index 4c6325cb3a1..491f04c079a 100644
--- a/lang/ar/errors.php
+++ b/lang/ar/errors.php
@@ -109,6 +109,7 @@
'import_zip_cant_read' => 'لم أتمكن من قراءة المِلَفّ المضغوط -ZIP-.',
'import_zip_cant_decode_data' => 'لم نتمكن من العثور على محتوى المِلَفّ المضغو... | [
"lang/ar/errors.php",
"lang/ar/validation.php",
"lang/bg/errors.php",
"lang/bg/validation.php",
"lang/bn/errors.php",
"lang/bn/validation.php",
"lang/bs/errors.php",
"lang/bs/validation.php",
"lang/ca/errors.php",
"lang/ca/validation.php",
"lang/cs/entities.php",
"lang/cs/errors.php",
"lang/... | [] | true | |||
BookStackApp/BookStack | 5,968 | issue_to_patch | Add some additional resource-based limits | - Limits ZIP import file sizes to the configured `FILE_UPLOAD_SIZE_LIMIT`.
- Limits the amount of search terms which can be used in one search.
### Docs Updates
Update search page to note limits:
```
$searchLimit = $userLoggedIn ? 10 : 5;
$exactLimit = $userLoggedIn ? 4 : 2;
$tagLim... | 38d3697246a294d011461ceb9850bc45bcef61ce | b08d1b36de36d96fae55fff65bcb5908a43e63b5 | diff --git a/app/Exports/ZipExports/ZipExportReader.php b/app/Exports/ZipExports/ZipExportReader.php
index c3d5c23cfec..28b830167c8 100644
--- a/app/Exports/ZipExports/ZipExportReader.php
+++ b/app/Exports/ZipExports/ZipExportReader.php
@@ -58,6 +58,16 @@ public function readData(): array
{
$this->open();... | [
"app/Exports/ZipExports/ZipExportReader.php",
"app/Exports/ZipExports/ZipFileReferenceRule.php",
"app/Exports/ZipExports/ZipImportRunner.php",
"app/Search/SearchController.php",
"app/Search/SearchOptionSet.php",
"app/Search/SearchOptions.php",
"lang/en/errors.php",
"lang/en/validation.php",
"tests/E... | [] | diff --git a/tests/Exports/ZipImportRunnerTest.php b/tests/Exports/ZipImportRunnerTest.php
index 2255e16c393..67c1a90e528 100644
--- a/tests/Exports/ZipImportRunnerTest.php
+++ b/tests/Exports/ZipImportRunnerTest.php
@@ -5,6 +5,7 @@
use BookStack\Entities\Models\Book;
use BookStack\Entities\Models\Chapter;
use BookS... | true | |
BookStackApp/BookStack | 5,933 | issue_to_patch | Updated translations with latest Crowdin changes | 21730aeb398727574c8e014f031a97dacfa46aea | 4d900a1459d8172dfd5931d773c6f1a927d158c4 | diff --git a/lang/ar/notifications.php b/lang/ar/notifications.php
index 30a49a631cf..69d5dfdcf52 100644
--- a/lang/ar/notifications.php
+++ b/lang/ar/notifications.php
@@ -11,6 +11,8 @@
'updated_page_subject' => 'تم تحديث الصفحة: :pageName',
'updated_page_intro' => 'تم تحديث الصفحة في :appName:',
'updat... | [
"lang/ar/notifications.php",
"lang/ar/preferences.php",
"lang/ar/settings.php",
"lang/bg/notifications.php",
"lang/bg/preferences.php",
"lang/bg/settings.php",
"lang/bn/activities.php",
"lang/bn/auth.php",
"lang/bn/notifications.php",
"lang/bn/preferences.php",
"lang/bn/settings.php",
"lang/bs... | [] | true | |||
BookStackApp/BookStack | 5,956 | issue_to_patch | System CLI: Update to v0.4 | - The init & update commands will now use download-vendor logic instead of using composer to install required PHP packages.
- The init command will now use our source.bookstackapp.com git mirror instead of GitHub.
- Updated depenancy PHP package versions. | d87e8d05c772723c52818975b6d26eb238161276 | d504b191434eaeec78aa59d7505c631b0ca20d20 | diff --git a/bookstack-system-cli b/bookstack-system-cli
index c55c5a8a784..1a518e644e4 100755
Binary files a/bookstack-system-cli and b/bookstack-system-cli differ
| [
"bookstack-system-cli"
] | [] | true | ||
BookStackApp/BookStack | 5,939 | issue_to_patch | Lexical fixes for v25.12 | For #5631
- Updated focus control for popup modal forms to focus on first form-field on show, and restore focus to the editor on hide.
- Fixed `undefined` default search value in link item search selector popup.
- Updated item search selector popup to pre-fill search input with selected text range. | 1ee57114353887420d1dcf0366876d92f554c7ec | 3e1b0587ec5fc81f02e5df4ba5544e233942ce92 | diff --git a/resources/js/wysiwyg/services/shortcuts.ts b/resources/js/wysiwyg/services/shortcuts.ts
index ead4c38d432..c4be0f3cf2f 100644
--- a/resources/js/wysiwyg/services/shortcuts.ts
+++ b/resources/js/wysiwyg/services/shortcuts.ts
@@ -71,13 +71,17 @@ const actionsByKeys: Record<string, ShortcutAction> = {
... | [
"resources/js/wysiwyg/services/shortcuts.ts",
"resources/js/wysiwyg/ui/framework/forms.ts",
"resources/js/wysiwyg/ui/framework/modals.ts",
"resources/js/wysiwyg/utils/links.ts"
] | [] | true | ||
BookStackApp/BookStack | 5,952 | issue_to_patch | Update "Microsoft URL Rewrite Module for IIS" download link | The download link to the *Microsoft URL Rewrite Module for IIS* in the `web.config` file is no longer available. | 9211062e8e0429f7c7b76037cfa38b99649398bb | 4aeb571126c648ac2d3ffe25777925053ac3e090 | diff --git a/public/web.config b/public/web.config
index 474eb68983b..b08c89c9a34 100644
--- a/public/web.config
+++ b/public/web.config
@@ -1,6 +1,6 @@
<!--
Rewrites requires Microsoft URL Rewrite Module for IIS
- Download: https://www.microsoft.com/en-us/download/details.aspx?id=47337
+ Download: https://... | [
"public/web.config"
] | [] | true | ||
BookStackApp/BookStack | 5,944 | issue_to_patch | Comment mentions | Related to #560.
### Todo
- [x] Finish off editor UI.
- [x] Address remaining todos in code changes
- [x] Add lookup for users
- [x] Limit to those with ability to create/update comments for now.
- [x] Back-end comment parsing
- [x] Notification on mention
- [x] Notification preferences - Add option fo... | 9211062e8e0429f7c7b76037cfa38b99649398bb | a941d1b403f66d1162f0a23d4dc88a99234b9423 | diff --git a/app/Activity/Models/MentionHistory.php b/app/Activity/Models/MentionHistory.php
new file mode 100644
index 00000000000..7386a4d742b
--- /dev/null
+++ b/app/Activity/Models/MentionHistory.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace BookStack\Activity\Models;
+
+use Illuminate\Database\Eloquent\Model;
+use Illu... | [
"app/Activity/Models/MentionHistory.php",
"app/Activity/Notifications/Handlers/CommentMentionNotificationHandler.php",
"app/Activity/Notifications/Messages/CommentMentionNotification.php",
"app/Activity/Notifications/NotificationManager.php",
"app/Activity/Tools/MentionParser.php",
"app/App/Providers/AppS... | [] | diff --git a/tests/Entity/CommentDisplayTest.php b/tests/Activity/CommentDisplayTest.php
similarity index 98%
rename from tests/Entity/CommentDisplayTest.php
rename to tests/Activity/CommentDisplayTest.php
index 80664890a7e..798ea16eef4 100644
--- a/tests/Entity/CommentDisplayTest.php
+++ b/tests/Activity/CommentDispla... | true | |
BookStackApp/BookStack | 5,606 | issue_to_patch | Feature Request - Define number of shelves to display on one page
**Describe the feature you'd like**
The ability for an admin to set a global value for the number of shelves to display on one page before showing the next page option.
**Describe the benefits this feature would bring to BookStack users**
Allow use... | Add settings for number of books/shelves that will be displayed per page | A trivial addition to allow setting the number of paginated results on the books/shelves tab. Unfortunately I could not find a way to do this using the Logical Theme System
I'm not sure if these settings would be better placed under the "Customization" tab but I have placed them under "Sorting" for the moment. Unfor... | 3e99ce4098cf45eafd8917e9b208b3b6a4aaa1ec | b6110ed3cd15cf9d0472f1ccced3dbe6fdc7db76 | diff --git a/app/App/HomeController.php b/app/App/HomeController.php
index 0585e0af5cc..7ec8b0af207 100644
--- a/app/App/HomeController.php
+++ b/app/App/HomeController.php
@@ -83,7 +83,7 @@ public function index(
if ($homepageOption === 'bookshelves') {
$shelves = $this->queries->shelves->visible... | [
"app/App/HomeController.php",
"app/Entities/Controllers/BookController.php",
"app/Entities/Controllers/BookshelfController.php",
"lang/en/settings.php",
"resources/views/settings/categories/sorting.blade.php"
] | [] | true | |
BookStackApp/BookStack | 5,928 | issue_to_patch | Initial developer API for WYSIWYG editor | For #5763
### Todo
- [x] Address todos in code | cf847974d2ffcddd9ffc10ad524237bf4b462a50 | b5246a28f0268460588ae33e555337493426e2b0 | diff --git a/dev/docs/development.md b/dev/docs/development.md
index 6c250902a9f..418e9ead672 100644
--- a/dev/docs/development.md
+++ b/dev/docs/development.md
@@ -3,7 +3,7 @@
All development on BookStack is currently done on the `development` branch.
When it's time for a release the `development` branch is merged ... | [
"dev/docs/development.md",
"dev/docs/javascript-code.md",
"dev/docs/javascript-public-events.md",
"dev/docs/wysiwyg-js-api.md",
"package-lock.json",
"package.json",
"resources/js/wysiwyg/api/__tests__/api-test-utils.ts",
"resources/js/wysiwyg/api/__tests__/content.test.ts",
"resources/js/wysiwyg/api... | [] | diff --git a/resources/js/wysiwyg/api/__tests__/api-test-utils.ts b/resources/js/wysiwyg/api/__tests__/api-test-utils.ts
new file mode 100644
index 00000000000..dacec339289
--- /dev/null
+++ b/resources/js/wysiwyg/api/__tests__/api-test-utils.ts
@@ -0,0 +1,14 @@
+import {createTestContext} from "lexical/__tests__/utils... | true | |
BookStackApp/BookStack | 5,923 | issue_to_patch | Styles: Made non-active dark/light css variables exist by default | This means that it would be possible to jump between light/dark mode with just the class, and no reload needed.
Not something we'll directly use right now, but may be useful in customizations. | 0f40aeb0d31cae2f7b27ec7e7a9e6ad7562341eb | bb350639c6be27c746ab886c70f620e39eebfa05 | diff --git a/resources/views/layouts/parts/custom-styles.blade.php b/resources/views/layouts/parts/custom-styles.blade.php
index bfdcc851289..b31334e7331 100644
--- a/resources/views/layouts/parts/custom-styles.blade.php
+++ b/resources/views/layouts/parts/custom-styles.blade.php
@@ -1,15 +1,22 @@
-@php
- $settingSu... | [
"resources/views/layouts/parts/custom-styles.blade.php",
"tests/Settings/SettingsTest.php"
] | [] | diff --git a/tests/Settings/SettingsTest.php b/tests/Settings/SettingsTest.php
index 9d45706e77b..a3e65b483c9 100644
--- a/tests/Settings/SettingsTest.php
+++ b/tests/Settings/SettingsTest.php
@@ -101,4 +101,17 @@ public function test_updating_and_removing_app_icon()
file_get_contents(public_path('favicon.... | true | |
BookStackApp/BookStack | 5,878 | issue_to_patch | DB: Updated entity scope to use models dynamic table | This was hardcoded since the table was always the same, but in some cases Laravel will auto-alias the table name (for example, when in sub-queries) which will break MySQL 5.7 when the scope attempts to use the table name instead of the alias.
Needs testing coverage.
For #5877
### Todo
- [ ] Full testing agai... | 5bf2d801cf0e4a8ea3fc8b6739ee8651952ebf31 | 8ab9252f9bd1626b87df044b14ce3469b1ca07bf | diff --git a/app/Entities/Models/Book.php b/app/Entities/Models/Book.php
index afd50797b15..1909dbd5631 100644
--- a/app/Entities/Models/Book.php
+++ b/app/Entities/Models/Book.php
@@ -67,8 +67,7 @@ public function directPages(): HasMany
*/
public function chapters(): HasMany
{
- return $this->ha... | [
"app/Entities/Models/Book.php",
"app/Entities/Models/EntityScope.php",
"dev/docker/db-testing/Dockerfile",
"dev/docker/db-testing/run.sh",
"tests/Entity/EntityQueryTest.php",
"tests/Uploads/ImageTest.php"
] | [] | diff --git a/tests/Entity/EntityQueryTest.php b/tests/Entity/EntityQueryTest.php
new file mode 100644
index 00000000000..7d3fd38cea2
--- /dev/null
+++ b/tests/Entity/EntityQueryTest.php
@@ -0,0 +1,44 @@
+<?php
+
+namespace Entity;
+
+use BookStack\Entities\Models\Book;
+use Illuminate\Database\Eloquent\Builder;
+use Te... | true | |
BookStackApp/BookStack | 5,850 | issue_to_patch | API: Started building comments API endpoints | For #4194
### Todo
- [x] Address TODOS in controller
- [x] Testing
- [x] Store API example requests/responses | abe9c1e5a3c624b17e7de52e119544ea0b37f499 | a949900570c80c9c46c140a57c17e2d42738232e | diff --git a/app/Activity/CommentRepo.php b/app/Activity/CommentRepo.php
index 7005f8fcf83..1802e390585 100644
--- a/app/Activity/CommentRepo.php
+++ b/app/Activity/CommentRepo.php
@@ -4,10 +4,11 @@
use BookStack\Activity\Models\Comment;
use BookStack\Entities\Models\Entity;
+use BookStack\Entities\Models\Page;
us... | [
"app/Activity/CommentRepo.php",
"app/Activity/Controllers/CommentApiController.php",
"app/Activity/Controllers/CommentController.php",
"app/Activity/Models/Comment.php",
"app/Activity/Tools/CommentTree.php",
"app/Api/ApiDocsGenerator.php",
"app/Entities/Controllers/BookApiController.php",
"app/Entitie... | [] | diff --git a/tests/Activity/CommentsApiTest.php b/tests/Activity/CommentsApiTest.php
new file mode 100644
index 00000000000..ec4ddba995c
--- /dev/null
+++ b/tests/Activity/CommentsApiTest.php
@@ -0,0 +1,250 @@
+<?php
+
+namespace Activity;
+
+use BookStack\Activity\Models\Comment;
+use BookStack\Permissions\Permission;... | true | |
BookStackApp/BookStack | 5,846 | issue_to_patch | Images: Added nulling of image page relation on page delete | Part of DB cleanup/restructure work. | 0bfd79925e9e23f9b6cd6d0534d5ba5ef49f40ca | ea6344898f435c54e225926a68d0b9a26697acd1 | diff --git a/app/Entities/Tools/TrashCan.php b/app/Entities/Tools/TrashCan.php
index cc43b909625..c298169c383 100644
--- a/app/Entities/Tools/TrashCan.php
+++ b/app/Entities/Tools/TrashCan.php
@@ -15,6 +15,7 @@
use BookStack\Exceptions\NotifyException;
use BookStack\Facades\Activity;
use BookStack\Uploads\Attachment... | [
"app/Entities/Tools/TrashCan.php",
"database/migrations/2025_09_15_134751_update_entity_relation_columns.php",
"tests/Entity/PageTest.php"
] | [] | diff --git a/tests/Entity/PageTest.php b/tests/Entity/PageTest.php
index 6994144626e..b9e1294e0ec 100644
--- a/tests/Entity/PageTest.php
+++ b/tests/Entity/PageTest.php
@@ -4,6 +4,7 @@
use BookStack\Entities\Models\Book;
use BookStack\Entities\Models\Page;
+use BookStack\Uploads\Image;
use Carbon\Carbon;
use Test... | true | |
BookStackApp/BookStack | 5,365 | issue_to_patch | Range of fixes/updates for the new Lexical based editor | Following feedback in #5245.
- Adds auto-linking on space/enter press.
- Adds dark-mode support.
- Adds mobile support in UI and styles.
- Adds "about/help" modal & button.
- Details/collapsible blocks:
- Added toolbar with actions
- Made summary/label more consistent.
- Added methods to escape block (... | a8ef820443cc444423f0fd21c4e1ce9fb64cbac0 | ebe2ca7faff580ccb8064920a24fb2fad6412105 | diff --git a/dev/build/svg-blank-transform.js b/dev/build/svg-blank-transform.js
new file mode 100644
index 00000000000..5183014c880
--- /dev/null
+++ b/dev/build/svg-blank-transform.js
@@ -0,0 +1,14 @@
+// This is a basic transformer stub to help jest handle SVG files.
+// Essentially blanks them since we don't really... | [
"dev/build/svg-blank-transform.js",
"jest.config.ts",
"lang/en/editor.php",
"resources/icons/editor/about.svg",
"resources/icons/editor/details-toggle.svg",
"resources/js/wysiwyg-tinymce/plugins-about.js",
"resources/js/wysiwyg/index.ts",
"resources/js/wysiwyg/lexical/core/LexicalEditor.ts",
"resour... | [] | diff --git a/resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts b/resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts
index e9d14ef1139..b13bba6977e 100644
--- a/resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts
+++ b/resources/js/wysiwyg/lexical/core/__tests__/utils/index.ts
@@ -13,6 +13,7 @@ i... | true | |
BookStackApp/BookStack | 5,463 | issue_to_patch | v24-12 branch changes |
- #5462 | 786a434c03faa996e630f4a0a523567d3b093f43 | 4f5f7c10b10bfa0434cbe4c81a066cf779ca63e5 | diff --git a/app/Uploads/ImageResizer.php b/app/Uploads/ImageResizer.php
index fa6b1cac2d4..5f095658f3f 100644
--- a/app/Uploads/ImageResizer.php
+++ b/app/Uploads/ImageResizer.php
@@ -158,7 +158,10 @@ public function resizeImageData(
*/
protected function interventionFromImageData(string $imageData, ?string... | [
"app/Uploads/ImageResizer.php"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.