repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | `hashToSelector` now passes the raw `computeHashInto` value to the sharder, removing the old final `intHashCRC32` mix. For `scatterBlockByHashPow2` that means `grace_hash` buckets use `hash & mask` on the low bits of the per-column CRC32C value, while the added distribution tests and benchmark only cover the fastrange/... | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Interpreters/JoinUtils.h b/src/Interpreters/JoinUtils.h
index ae9dd9b90171..e271e0808c5c 100644
--- a/src/Interpreters/JoinUtils.h
+++ b/src/Interpreters/JoinUtils.h
@@ -3,7 +3,7 @@
#include <Columns/ColumnsNumber.h>
#include <Columns/IColumn.h>
#include <Common/HashTable/Hash.h>
-#include <Common/W... | [
"src/Interpreters/JoinUtils.h"
] | [
{
"comment": "`hashToSelector` now passes the raw `computeHashInto` value to the sharder, removing the old final `intHashCRC32` mix. For `scatterBlockByHashPow2` that means `grace_hash` buckets use `hash & mask` on the low bits of the per-column CRC32C value, while the added distribution tests and benchmark onl... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | This replaces the old `WeakHash32` chain and final selector mix in the sharded aggregation hot path, but the PR is marked as `Performance Improvement` and the current evidence does not yet prove that contract. The only posted cloud benchmark report shows `clickbench` regressions on high-cardinality `GROUP BY` queries t... | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
index 18070958d51a..7353ca912d18 100644
--- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp
+++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
@@ -1,7 +1,8 @@
... | [
"src/Processors/Transforms/BufferedShardByHashTransform.cpp"
] | [
{
"comment": "This replaces the old `WeakHash32` chain and final selector mix in the sharded aggregation hot path, but the PR is marked as `Performance Improvement` and the current evidence does not yet prove that contract. The only posted cloud benchmark report shows `clickbench` regressions on high-cardinalit... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | `BM_HashAndFastrange_New` says it captures the `BufferedShardByHashTransform` path, but the transform now fills `hash_buffer` with `WEAK_HASH32_INITIAL_VALUE` and calls `computeHashInto` with `initial=false` for every key column. This benchmark starts with `initial=true`, and also omits the per-iteration fill, so for `... | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/benchmarks/benchmark_compute_hash_into.cpp b/src/Columns/benchmarks/benchmark_compute_hash_into.cpp
new file mode 100644
index 000000000000..af281c577820
--- /dev/null
+++ b/src/Columns/benchmarks/benchmark_compute_hash_into.cpp
@@ -0,0 +1,236 @@
+/// Microbenchmark for IColumn::computeHashInto... | [
"src/Columns/benchmarks/benchmark_compute_hash_into.cpp"
] | [
{
"comment": "`BM_HashAndFastrange_New` says it captures the `BufferedShardByHashTransform` path, but the transform now fills `hash_buffer` with `WEAK_HASH32_INITIAL_VALUE` and calls `computeHashInto` with `initial=false` for every key column. This benchmark starts with `initial=true`, and also omits the per-it... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | The implementation itself is about the same length as the comments - I'm not sure it is actually useful. Also, if you want to comment on the implementation details, please do so next to the actual code and not in the header. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Common/MapToRange.h b/src/Common/MapToRange.h
new file mode 100644
index 000000000000..e2ed0e8081bc
--- /dev/null
+++ b/src/Common/MapToRange.h
@@ -0,0 +1,14 @@
+#pragma once
+
+#include <base/types.h>
+
+#include <cstddef>
+
+namespace DB
+{
+
+/// Map each 32-bit hash uniformly to [0, range_size) via... | [
"src/Common/MapToRange.h"
] | [
{
"comment": "The implementation itself is about the same length as the comments - I'm not sure it is actually useful. Also, if you want to comment on the implementation details, please do so next to the actual code and not in the header.",
"path": "src/Common/MapToRange.h",
"hunk": "@@ -0,0 +1,29 @@\n+... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | ```suggestion
```
Let's not repeat the same comment at every call site. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
index 18070958d51a..7353ca912d18 100644
--- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp
+++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
@@ -1,7 +1,8 @@
... | [
"src/Processors/Transforms/BufferedShardByHashTransform.cpp"
] | [
{
"comment": "```suggestion\n```\n\nLet's not repeat the same comment at every call site. ",
"path": "src/Processors/Transforms/BufferedShardByHashTransform.cpp",
"hunk": "@@ -132,20 +135,21 @@ void BufferedShardByHashTransform::generateOutputChunks()\n \n chassert(!columns.empty());\n \n- /// Co... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | ```suggestion
hash_buffer.assign(num_rows, WEAK_HASH32_INITIAL_VALUE);
``` | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/BufferedShardByHashTransform.cpp b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
index 18070958d51a..7353ca912d18 100644
--- a/src/Processors/Transforms/BufferedShardByHashTransform.cpp
+++ b/src/Processors/Transforms/BufferedShardByHashTransform.cpp
@@ -1,7 +1,8 @@
... | [
"src/Processors/Transforms/BufferedShardByHashTransform.cpp"
] | [
{
"comment": "```suggestion\n hash_buffer.assign(num_rows, WEAK_HASH32_INITIAL_VALUE);\n```",
"path": "src/Processors/Transforms/BufferedShardByHashTransform.cpp",
"hunk": "@@ -132,20 +135,21 @@ void BufferedShardByHashTransform::generateOutputChunks()\n \n chassert(!columns.empty());\n \n- //... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | The same `assign` suggestion. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
index ecae587c637d..d7c0491bdbb6 100644
--- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp
+++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
@@ -2,6 +2,8 @@
#inc... | [
"src/Processors/Transforms/ScatterByPartitionTransform.cpp"
] | [
{
"comment": "The same `assign` suggestion. ",
"path": "src/Processors/Transforms/ScatterByPartitionTransform.cpp",
"hunk": "@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks()\n \n chassert(!columns.empty());\n \n- hash.reset(num_rows);\n+ hash.resize(num_rows);",
... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | Can we use `mapToRange` here? | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
index ecae587c637d..d7c0491bdbb6 100644
--- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp
+++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
@@ -2,6 +2,8 @@
#inc... | [
"src/Processors/Transforms/ScatterByPartitionTransform.cpp"
] | [
{
"comment": "Can we use `mapToRange` here?",
"path": "src/Processors/Transforms/ScatterByPartitionTransform.cpp",
"hunk": "@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks()\n \n chassert(!columns.empty());\n \n- hash.reset(num_rows);\n+ hash.resize(num_rows);\n+ ... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | Looks like we can reuse `selector` too. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Processors/Transforms/ScatterByPartitionTransform.cpp b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
index ecae587c637d..d7c0491bdbb6 100644
--- a/src/Processors/Transforms/ScatterByPartitionTransform.cpp
+++ b/src/Processors/Transforms/ScatterByPartitionTransform.cpp
@@ -2,6 +2,8 @@
#inc... | [
"src/Processors/Transforms/ScatterByPartitionTransform.cpp"
] | [
{
"comment": "Looks like we can reuse `selector` too.",
"path": "src/Processors/Transforms/ScatterByPartitionTransform.cpp",
"hunk": "@@ -135,16 +137,16 @@ void ScatterByPartitionTransform::generateOutputChunks()\n \n chassert(!columns.empty());\n \n- hash.reset(num_rows);\n+ hash.resize(num_r... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | What are we trying to achieve with avx-512 here? crc builtins won't vectorise AFAIK, and potential unrolling also shouldn't really speed anything up. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp
index 2301d4b6b435..253efd21141d 100644
--- a/src/Columns/ColumnDecimal.cpp
+++ b/src/Columns/ColumnDecimal.cpp
@@ -4,7 +4,6 @@
#include <Common/HashTable/Hash.h>
#include <Common/RadixSort.h>
#include <Common/SipHash.h>
-#include <Common/Wea... | [
"src/Columns/ColumnDecimal.cpp"
] | [
{
"comment": "What are we trying to achieve with avx-512 here? crc builtins won't vectorise AFAIK, and potential unrolling also shouldn't really speed anything up. ",
"path": "src/Columns/ColumnDecimal.cpp",
"hunk": "@@ -167,24 +167,48 @@ void ColumnDecimal<T>::updateHashWithValueRange(size_t begin, siz... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | Please avoid formatting unchanged code. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp
index 2301d4b6b435..253efd21141d 100644
--- a/src/Columns/ColumnDecimal.cpp
+++ b/src/Columns/ColumnDecimal.cpp
@@ -4,7 +4,6 @@
#include <Common/HashTable/Hash.h>
#include <Common/RadixSort.h>
#include <Common/SipHash.h>
-#include <Common/Wea... | [
"src/Columns/ColumnDecimal.cpp"
] | [
{
"comment": "Please avoid formatting unchanged code. ",
"path": "src/Columns/ColumnDecimal.cpp",
"hunk": "@@ -245,9 +270,11 @@ void ColumnDecimal<T>::getPermutation(IColumn::PermutationSortDirection directio\n \n if (direction == IColumn::PermutationSortDirection::Ascending && stability... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | `computeHashInto` must not route equal keys to different partitions, but this path now hashes floating-point raw bits. For `Float32`/`Float64`, `+0.0` and `-0.0` compare equal, and the previous `intHashCRC32` floating overload normalized them; `hashCRC32` sees different bit patterns. The `BFloat16` branch above has the... | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnVector.cpp b/src/Columns/ColumnVector.cpp
index a6d489642ec6..1911ed54f95a 100644
--- a/src/Columns/ColumnVector.cpp
+++ b/src/Columns/ColumnVector.cpp
@@ -19,7 +19,6 @@
#include <Common/RadixSort.h>
#include <Common/SipHash.h>
#include <Common/TargetSpecific.h>
-#include <Common/WeakH... | [
"src/Columns/ColumnVector.cpp"
] | [
{
"comment": "`computeHashInto` must not route equal keys to different partitions, but this path now hashes floating-point raw bits. For `Float32`/`Float64`, `+0.0` and `-0.0` compare equal, and the previous `intHashCRC32` floating overload normalized them; `hashCRC32` sees different bit patterns. The `BFloat16... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | > [[gnu::always_inline]]
1. It is unnecessary
2. We use our own macro - `ALWAYS_INLINE`
The same in `ColumnVector`. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnDecimal.cpp b/src/Columns/ColumnDecimal.cpp
index 2301d4b6b435..253efd21141d 100644
--- a/src/Columns/ColumnDecimal.cpp
+++ b/src/Columns/ColumnDecimal.cpp
@@ -4,7 +4,6 @@
#include <Common/HashTable/Hash.h>
#include <Common/RadixSort.h>
#include <Common/SipHash.h>
-#include <Common/Wea... | [
"src/Columns/ColumnDecimal.cpp"
] | [
{
"comment": "> [[gnu::always_inline]]\n\n1. It is unnecessary \n2. We use our own macro - `ALWAYS_INLINE`\n\nThe same in `ColumnVector`.",
"path": "src/Columns/ColumnDecimal.cpp",
"hunk": "@@ -167,24 +166,28 @@ void ColumnDecimal<T>::updateHashWithValueRange(size_t begin, size_t end, SipHas\n hash.... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | ```suggestion
VectorWithMemoryTracking<PaddedPODArray<UInt32>> nested_hashes(variants.size()); // STYLE_CHECK_ALLOW_STD_CONTAINERS
``` | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnVariant.cpp b/src/Columns/ColumnVariant.cpp
index d79d0e58d8b0..7e2dee7d231d 100644
--- a/src/Columns/ColumnVariant.cpp
+++ b/src/Columns/ColumnVariant.cpp
@@ -7,7 +7,6 @@
#include <Processors/Transforms/ColumnGathererTransform.h>
#include <IO/Operators.h>
#include <IO/WriteBufferFromS... | [
"src/Columns/ColumnVariant.cpp"
] | [
{
"comment": "```suggestion\n VectorWithMemoryTracking<PaddedPODArray<UInt32>> nested_hashes(variants.size()); // STYLE_CHECK_ALLOW_STD_CONTAINERS\n```",
"path": "src/Columns/ColumnVariant.cpp",
"hunk": "@@ -957,38 +956,37 @@ void ColumnVariant::updateHashWithValueRange(size_t begin, size_t end, SipH... | true | ||
ClickHouse/ClickHouse | 106,538 | comment_to_fix | Add non-allocating IColumn::computeHashInto column hash kernel | It looks like we previously set hashes for nulls to `WEAK_HASH32_INITIAL_VALUE`. Now it will be 0. Let's preserve the old behaviour. | 44aecc852cee7a9f38ec84df626833f5681e42f7 | f22f3f8d702ec84858a7d0ef3f236ce0d929ed40 | diff --git a/src/Columns/ColumnVariant.cpp b/src/Columns/ColumnVariant.cpp
index d79d0e58d8b0..7e2dee7d231d 100644
--- a/src/Columns/ColumnVariant.cpp
+++ b/src/Columns/ColumnVariant.cpp
@@ -7,7 +7,6 @@
#include <Processors/Transforms/ColumnGathererTransform.h>
#include <IO/Operators.h>
#include <IO/WriteBufferFromS... | [
"src/Columns/ColumnVariant.cpp"
] | [
{
"comment": "It looks like we previously set hashes for nulls to `WEAK_HASH32_INITIAL_VALUE`. Now it will be 0. Let's preserve the old behaviour. ",
"path": "src/Columns/ColumnVariant.cpp",
"hunk": "@@ -957,38 +956,37 @@ void ColumnVariant::updateHashWithValueRange(size_t begin, size_t end, SipHash &\n... | true | ||
ClickHouse/ClickHouse | 98,115 | issue_to_patch | Enforce READ ON FILE checks for scalar file() and DESCRIBE TABLE file(). | ### Changelog category (leave one):
- Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR
### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the changes that goes into CHANGELOG.md):
Enforce READ ON FILE chec... | bf9520191e35ccd524bcdeae9a5cff9753bc6e04 | 0040628c361a6ef5ca768242d89bb1b28ca5afd1 | diff --git a/src/Functions/FunctionFile.cpp b/src/Functions/FunctionFile.cpp
index b7f154877876..697345fb06d1 100644
--- a/src/Functions/FunctionFile.cpp
+++ b/src/Functions/FunctionFile.cpp
@@ -3,6 +3,7 @@
#include <Columns/ColumnConst.h>
#include <Columns/IColumn.h>
#include <Functions/FunctionFactory.h>
+#include... | [
"src/Functions/FunctionFile.cpp",
"src/TableFunctions/TableFunctionFile.cpp",
"tests/queries/0_stateless/03822_file_function_read_on_file_grant.reference",
"tests/queries/0_stateless/03822_file_function_read_on_file_grant.sh"
] | [
{
"comment": "We propagate context to `FunctionFile::create`. Can't we just save it in a field and use here?",
"path": "src/Functions/FunctionFile.cpp",
"hunk": "@@ -112,12 +114,19 @@ class FunctionFile : public IFunction\n \n res_offsets.resize(input_rows_count);\n \n- const auto & conte... | diff --git a/tests/queries/0_stateless/03822_file_function_read_on_file_grant.reference b/tests/queries/0_stateless/03822_file_function_read_on_file_grant.reference
new file mode 100644
index 000000000000..865d4ff5230b
--- /dev/null
+++ b/tests/queries/0_stateless/03822_file_function_read_on_file_grant.reference
@@ -0,... | true | |
ClickHouse/ClickHouse | 99,531 | issue_to_patch | validate column structure before applying patches | ### Changelog category (leave one):
- Bug Fix (user-visible misbehavior in an official stable release)
### Changelog entry (a [user-readable short description](https://github.com/ClickHouse/ClickHouse/blob/master/docs/changelog_entry_guidelines.md) of the changes that goes into CHANGELOG.md):
validate column struc... | 72360b4b81c935102c295264c815c8eb67ecd358 | 2c2c2d3e458c589a3e5bc20e9515e778cdeeab62 | diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
index 6b8c2fcdcc70..447f51853eff 100644
--- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp
+++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
@@ -8,6 +8,7 @@
#include <DataTypes/DataTypesNum... | [
"src/Storages/MergeTree/PatchParts/applyPatches.cpp",
"src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp"
] | [
{
"comment": "`applyPatchesToBlockCombined` checks `structureEquals` before `removeSpecialRepresentations`, unlike `applyPatchesToBlockRaw`. This can incorrectly mark compatible patches as incompatible when `result_column.column` is in sparse/replicated representation (patch columns are normalized by `MergeTree... | diff --git a/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp
new file mode 100644
index 000000000000..867f2d38448d
--- /dev/null
+++ b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.c... | true | |
ClickHouse/ClickHouse | 99,531 | comment_to_fix | validate column structure before applying patches | `applyPatchesToBlockCombined` checks `structureEquals` before `removeSpecialRepresentations`, unlike `applyPatchesToBlockRaw`. This can incorrectly mark compatible patches as incompatible when `result_column.column` is in sparse/replicated representation (patch columns are normalized by `MergeTreePatchReader`). Please ... | 72360b4b81c935102c295264c815c8eb67ecd358 | 2c2c2d3e458c589a3e5bc20e9515e778cdeeab62 | diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
index 6b8c2fcdcc70..447f51853eff 100644
--- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp
+++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
@@ -8,6 +8,7 @@
#include <DataTypes/DataTypesNum... | [
"src/Storages/MergeTree/PatchParts/applyPatches.cpp"
] | [
{
"comment": "`applyPatchesToBlockCombined` checks `structureEquals` before `removeSpecialRepresentations`, unlike `applyPatchesToBlockRaw`. This can incorrectly mark compatible patches as incompatible when `result_column.column` is in sparse/replicated representation (patch columns are normalized by `MergeTree... | true | ||
ClickHouse/ClickHouse | 99,531 | comment_to_fix | validate column structure before applying patches | Please add a regression test that reproduces the schema-evolution path fixed here (old patch part contains `column` with previous type, current part has a new type) and verifies patch application no longer throws an exception. Without this, future refactoring in patch-apply paths can silently reintroduce the same failu... | 72360b4b81c935102c295264c815c8eb67ecd358 | 2c2c2d3e458c589a3e5bc20e9515e778cdeeab62 | diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
index 6b8c2fcdcc70..447f51853eff 100644
--- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp
+++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
@@ -8,6 +8,7 @@
#include <DataTypes/DataTypesNum... | [
"src/Storages/MergeTree/PatchParts/applyPatches.cpp"
] | [
{
"comment": "Please add a regression test that reproduces the schema-evolution path fixed here (old patch part contains `column` with previous type, current part has a new type) and verifies patch application no longer throws an exception. Without this, future refactoring in patch-apply paths can silently rein... | true | ||
ClickHouse/ClickHouse | 99,531 | comment_to_fix | validate column structure before applying patches | `applyPatchesToBlockCombined` currently skips the entire column when *any* source block has a mismatched type. In schema-transition windows this can drop valid updates from newer compatible patch blocks (e.g. old `UInt64` source + new `String` source => all `String` updates are skipped).
Could we make this per-source ... | 72360b4b81c935102c295264c815c8eb67ecd358 | 2c2c2d3e458c589a3e5bc20e9515e778cdeeab62 | diff --git a/src/Storages/MergeTree/PatchParts/applyPatches.cpp b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
index 6b8c2fcdcc70..447f51853eff 100644
--- a/src/Storages/MergeTree/PatchParts/applyPatches.cpp
+++ b/src/Storages/MergeTree/PatchParts/applyPatches.cpp
@@ -8,6 +8,7 @@
#include <DataTypes/DataTypesNum... | [
"src/Storages/MergeTree/PatchParts/applyPatches.cpp"
] | [
{
"comment": "`applyPatchesToBlockCombined` currently skips the entire column when *any* source block has a mismatched type. In schema-transition windows this can drop valid updates from newer compatible patch blocks (e.g. old `UInt64` source + new `String` source => all `String` updates are skipped).\n\nCould ... | true | ||
ClickHouse/ClickHouse | 99,531 | comment_to_fix | validate column structure before applying patches | This regression suite only exercises the raw path (single-source patch), but this PR also changes `applyPatchesToBlockCombined`. Please add a case that forces the combined path (`canApplyPatchesRaw` = false) and validates mixed schema-transition inputs: incompatible sources are ignored while compatible sources for the ... | 72360b4b81c935102c295264c815c8eb67ecd358 | 2c2c2d3e458c589a3e5bc20e9515e778cdeeab62 | diff --git a/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp
new file mode 100644
index 000000000000..867f2d38448d
--- /dev/null
+++ b/src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.c... | [
"src/Storages/MergeTree/PatchParts/tests/gtest_apply_patches_type_mismatch.cpp"
] | [
{
"comment": "This regression suite only exercises the raw path (single-source patch), but this PR also changes `applyPatchesToBlockCombined`. Please add a case that forces the combined path (`canApplyPatchesRaw` = false) and validates mixed schema-transition inputs: incompatible sources are ignored while compa... | true | ||
ClickHouse/ClickHouse | 106,507 | issue_to_patch | Wrong results: equality predicate (col = const) drops rows when ORDER BY key is a NaN-producing function (sqrt/log of negatives)
**Describe what's wrong**
An equality predicate `col = <const>` returns **wrong (too few) results** when the table's `ORDER BY` (primary) key is a function that is **not defined (NaN) for s... | Fix wrong-results equality with NaN-producing key function | When a `MergeTree` table has `ORDER BY f(c0)` and a query has predicate `c0 = const` where `f(const)` is NaN (e.g. `ORDER BY sqrt(c0)` with `c0 = -30`), the index analysis in `KeyCondition::canConstantBeWrappedByDeterministicFunctions` translated the predicate into `f(c0) in [NaN, NaN]`. Comparing this NaN range agains... | ac805ce05b9d3821ec5d257f85b7ba9bb8d10815 | d77ebd24d2589d3953e2fbde933b0050c4cc897b | diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp
index e40c5a9c2618..7a5b94afb2a8 100644
--- a/src/Storages/MergeTree/KeyCondition.cpp
+++ b/src/Storages/MergeTree/KeyCondition.cpp
@@ -1682,7 +1682,14 @@ bool KeyCondition::canConstantBeWrappedByDeterministicFunctions(
... | [
"src/Storages/MergeTree/KeyCondition.cpp",
"tests/queries/0_stateless/04306_keycondition_nan_equality.reference",
"tests/queries/0_stateless/04306_keycondition_nan_equality.sql"
] | [] | diff --git a/tests/queries/0_stateless/04306_keycondition_nan_equality.reference b/tests/queries/0_stateless/04306_keycondition_nan_equality.reference
new file mode 100644
index 000000000000..de3badc3ed7f
--- /dev/null
+++ b/tests/queries/0_stateless/04306_keycondition_nan_equality.reference
@@ -0,0 +1,14 @@
+1
+1
+1
+... | true |
CompositionalIT/SAFE-Dojo | 183 | issue_to_patch | Bump vite from 5.0.13 to 5.4.6 | Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.4.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p>
<blockquote>
<h2>create-vite@5.4.0</h2>
<p>Please refer to <a href="https://github.com... | 6381b8d7f8ea6c19065a0e3bf1f841073ec4fc8a | f88a650ffb49352ba7ee92c662046fce99d47a58 | diff --git a/package-lock.json b/package-lock.json
index 6b5d855..5e17eee 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -18,7 +18,7 @@
"@vitejs/plugin-react": "^4.2.0",
"mocha": "^8.3.2",
"remotedev": "^0.2.9",
- "vite": "^5.0.13"
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 182 | issue_to_patch | Bump braces from 3.0.2 to 3.0.3 | Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/micromatch/braces/commit/74b2db2938fad48a2ea54a9c8bf27a37a62c350d"><code>74b2db2</code></a> 3.0.3</li>
<li><a href="https://github.com/micromatch/braces/commit/88f1429a0f47... | a29a61cb8f2e52d407c704dd7df093270d8d04d8 | 0b6e3a67323df914e7c08e643c9e00328d9b35e5 | diff --git a/package-lock.json b/package-lock.json
index 84b6ed3..6b5d855 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1154,12 +1154,12 @@
}
},
"node_modules/braces": {
- "version": "3.0.2",
- "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 181 | issue_to_patch | Bump vite from 5.0.12 to 5.0.13 | Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.12 to 5.0.13.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.13/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p>
<blockquote>
<h2><!-- raw HTML omitted -->5.0.13 (2024-03... | e18245e082261b44c2985992069fb4ac8d8b5297 | 81224465d413677384f87298e0cb1a0f7cc246ea | diff --git a/package-lock.json b/package-lock.json
index c0ea788..84b6ed3 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -18,7 +18,7 @@
"@vitejs/plugin-react": "^4.2.0",
"mocha": "^8.3.2",
"remotedev": "^0.2.9",
- "vite": "^5.0.12"
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 180 | issue_to_patch | Bump vite from 5.0.5 to 5.0.12 | Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.5 to 5.0.12.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v5.0.12/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p>
<blockquote>
<h2><!-- raw HTML omitted -->5.0.12 (2024-01-... | 2ea3c88ff3bd3845b8550121365cea4649c8cbce | 7bda8f3aa43abfc1fc182f5cbe16259b9a0fd628 | diff --git a/package-lock.json b/package-lock.json
index ed1870c..c0ea788 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -18,7 +18,7 @@
"@vitejs/plugin-react": "^4.2.0",
"mocha": "^8.3.2",
"remotedev": "^0.2.9",
- "vite": "^5.0.5"
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 179 | issue_to_patch | Remove incorrect url in Server.fs and fix url in launchsettings.json | fix for #178 | dd84aebb8fc07e7ce8a470cd815b86854dc4b97d | 68cb10d0ebc5a1edaaed4748abad2f1d8bf978c9 | diff --git a/src/Server/Properties/launchSettings.json b/src/Server/Properties/launchSettings.json
index 6464ef5..4c40621 100644
--- a/src/Server/Properties/launchSettings.json
+++ b/src/Server/Properties/launchSettings.json
@@ -6,7 +6,7 @@
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Developmen... | [
"src/Server/Properties/launchSettings.json",
"src/Server/Server.fs"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 176 | issue_to_patch | Upgrade suggested solution to SAFE v5 | This is the suggested solution branch with the SAFE v5 upgrade merged in and conflicts resolved.
Most of the changes are from the other branch: #175 | 4436185ed7ec8a543f8f7138e9b0c84ed903844d | feeaf9e297a8e2f443d05ddc1a7bb764e72ff1fe | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index cf268e8..aa15bcc 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,24 +1,30 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "7.2.0",
- "commands": [
- "paket"
- ... | [
".config/dotnet-tools.json",
".editorconfig",
"Build.fs",
"Build.fsproj",
"Helpers.fs",
"README.md",
"SAFE-dojo.sln",
"global.json",
"package-lock.json",
"package.json",
"paket.dependencies",
"paket.lock",
"src/Client/App.fs",
"src/Client/Client.fsproj",
"src/Client/Index.fs",
"src/Cli... | [] | true | ||
CompositionalIT/SAFE-Dojo | 177 | issue_to_patch | require dotnet 8 | 24f20ffdf50a007d53b8edc00d7be4f1f49c27e1 | 7f7676d38058ecd2483fd554c3ac7aad8583837a | diff --git a/README.md b/README.md
index c720658..080e489 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,7 @@ The `master` branch contains the dojo to complete. Please read the [instructions
You'll need to install the following pre-requisites in order to build SAFE applications
-* [.NET Core SDK](https://dotnet... | [
"README.md"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 175 | issue_to_patch | Update to SAFE v5 | Mostly I followed the official instructions to do the update (https://safe-stack.github.io/docs/recipes/upgrading/v4-to-v5/).
The main deviations were:
- Not adding Tailwind, since the whole thing is using Bulma.
- Not upgrading tests since there are no tests
- Change the server port to 8085 to align with the Vit... | 95bd37b72f675110ccfbe8f26a80a24acc280af6 | a4009198c0cb767616b509b0be584362fecd48dc | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index cf268e8..aa15bcc 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,24 +1,30 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "7.2.0",
- "commands": [
- "paket"
- ... | [
".config/dotnet-tools.json",
".editorconfig",
"Build.fs",
"Build.fsproj",
"Helpers.fs",
"Instructions.md",
"SAFE-dojo.sln",
"global.json",
"package-lock.json",
"package.json",
"paket.dependencies",
"paket.lock",
"src/Client/Client.fsproj",
"src/Client/Index.fs",
"src/Client/index.html",
... | [
{
"comment": "Template uses Content for this reference. Does not seem like that would have any implications. ",
"path": "src/Shared/Shared.fsproj",
"hunk": "@@ -1,10 +1,11 @@\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n- <TargetFramework>net... | true | ||
CompositionalIT/SAFE-Dojo | 175 | comment_to_fix | Update to SAFE v5 | Template uses Content for this reference. Does not seem like that would have any implications. | 95bd37b72f675110ccfbe8f26a80a24acc280af6 | a4009198c0cb767616b509b0be584362fecd48dc | diff --git a/src/Shared/Shared.fsproj b/src/Shared/Shared.fsproj
index 8fee1db..83a61a2 100644
--- a/src/Shared/Shared.fsproj
+++ b/src/Shared/Shared.fsproj
@@ -1,10 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net6.0</TargetFramework>
+ ... | [
"src/Shared/Shared.fsproj"
] | [
{
"comment": "Template uses Content for this reference. Does not seem like that would have any implications. ",
"path": "src/Shared/Shared.fsproj",
"hunk": "@@ -1,10 +1,11 @@\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n- <TargetFramework>net... | true | ||
CompositionalIT/SAFE-Dojo | 175 | comment_to_fix | Update to SAFE v5 | <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
| 95bd37b72f675110ccfbe8f26a80a24acc280af6 | a4009198c0cb767616b509b0be584362fecd48dc | diff --git a/src/Server/Server.fsproj b/src/Server/Server.fsproj
index 000648b..c9c22c0 100644
--- a/src/Server/Server.fsproj
+++ b/src/Server/Server.fsproj
@@ -2,7 +2,8 @@
<Project Sdk="Microsoft.NET.Sdk.Web">
<PropertyGroup>
<OutputType>Exe</OutputType>
- <TargetFramework>net6.0</TargetFramework>
+ <Ta... | [
"src/Server/Server.fsproj"
] | [
{
"comment": " <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>\r\n",
"path": "src/Server/Server.fsproj",
"hunk": "@@ -2,7 +2,7 @@\n <Project Sdk=\"Microsoft.NET.Sdk.Web\">\n <PropertyGroup>\n <OutputType>Exe</OutputType>\n- <TargetFramework>net6.0</TargetFramework>",
"r... | true | ||
CompositionalIT/SAFE-Dojo | 175 | comment_to_fix | Update to SAFE v5 | Helpers has had some changes over time, most notably using CreateProcess.FromRawCommand instead of CreateProcess.FormRawCommandLine. This also reflects in this file, where commands are invoked with strings instead of a list of arguments. It's mostly a stylistic thing, I think it would be nice to keep the dojo in sync. | 95bd37b72f675110ccfbe8f26a80a24acc280af6 | a4009198c0cb767616b509b0be584362fecd48dc | diff --git a/Build.fs b/Build.fs
index f6c3897..31b5ce9 100644
--- a/Build.fs
+++ b/Build.fs
@@ -5,7 +5,7 @@ open Farmer.Builders
open Helpers
-initializeContext()
+initializeContext ()
let sharedPath = Path.getFullName "src/Shared"
let serverPath = Path.getFullName "src/Server"
@@ -14,54 +14,48 @@ let deployP... | [
"Build.fs"
] | [
{
"comment": "Helpers has had some changes over time, most notably using CreateProcess.FromRawCommand instead of CreateProcess.FormRawCommandLine. This also reflects in this file, where commands are invoked with strings instead of a list of arguments. It's mostly a stylistic thing, I think it would be nice to k... | true | ||
CompositionalIT/SAFE-Dojo | 173 | issue_to_patch | Bump semver from 7.3.8 to 7.5.3 | Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/npm/node-semver/releases">semver's releases</a>.</em></p>
<blockquote>
<h2>v7.5.3</h2>
<h2><a href="https://github.com/npm/node-semver/compare/v7.5.2...v7.5.... | 6f33e4408ffff00d2da0e5f8936b31d4e0102361 | b6efb9ccbe8ee7b3ea54b34f3e12b49b762ea42a | diff --git a/package-lock.json b/package-lock.json
index 3b61204..3b73001 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4049,9 +4049,9 @@
}
},
"node_modules/semver": {
- "version": "7.3.8",
- "resolved": "https://registry.npmjs.org/semver/-/semver-7.3.8.... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 159 | issue_to_patch | Bump loader-utils from 2.0.0 to 2.0.4 | Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.0 to 2.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/loader-utils/releases">loader-utils's releases</a>.</em></p>
<blockquote>
<h2>v2.0.4</h2>
<h3><a href="https://github.com/webpack/loader-u... | bc2b268e3bfc0175fcf4e45df31377c7face36f7 | 68a8099e415ebf97d1f8ca2941e659599e43104a | diff --git a/package-lock.json b/package-lock.json
index 331f6ba..93472ee 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2715,9 +2715,9 @@
}
},
"node_modules/loader-utils": {
- "version": "2.0.0",
- "resolved": "https://registry.npmjs.org/loader-utils/-/l... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 163 | issue_to_patch | Bump json5 from 2.2.0 to 2.2.3 | Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/json5/json5/releases">json5's releases</a>.</em></p>
<blockquote>
<h2>v2.2.3</h2>
<ul>
<li>Fix: json5@2.2.3 is now the 'latest' release according to npm instead o... | 3757be45d5b6acc30fcfb87bd5380a40e6552f05 | e16b9a17bf8f0010b179586908f84824a8ced07d | diff --git a/package-lock.json b/package-lock.json
index d95054c..bf902ae 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2667,13 +2667,10 @@
"dev": true
},
"node_modules/json5": {
- "version": "2.2.0",
- "resolved": "https://registry.npmjs.org/json5/-/jso... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 165 | issue_to_patch | Bump webpack from 5.75.0 to 5.76.0 | Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p>
<blockquote>
<h2>v5.76.0</h2>
<h2>Bugfixes</h2>
<ul>
<li>Avoid cross-realm object access by <a ... | 3757be45d5b6acc30fcfb87bd5380a40e6552f05 | 060f768016c0b24e17491056910c4a2c5cf8b18e | diff --git a/package-lock.json b/package-lock.json
index d95054c..522c372 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23,7 +23,7 @@
"sass": "^1.43.4",
"sass-loader": "^12.3.0",
"style-loader": "^3.3.1",
- "webpack": "^5.75.0",
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 167 | issue_to_patch | Updated deprecated net web client | There was an Error message to the use of the Net.WebClient class, which is deprecated as of .NET 5.0. Have updated code to use HttpClient. | 3757be45d5b6acc30fcfb87bd5380a40e6552f05 | a91daccac5e520a9a0775be679a4598c6141821f | diff --git a/src/Server/DataAccess.fs b/src/Server/DataAccess.fs
index 9c64831..45d5e28 100644
--- a/src/Server/DataAccess.fs
+++ b/src/Server/DataAccess.fs
@@ -78,6 +78,8 @@ module Crime =
[<AutoOpen>]
module Weather =
+ open System.Net.Http
+
[<Literal>]
let Sample =
"""{"latitude":51.52,"lo... | [
"src/Server/DataAccess.fs"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 162 | issue_to_patch | .NET6 + Fantomas 5 (solution) | efe2890c6cd0938b75f3e3397bcac378acb2e80f | 5fb405c021432620ff7c140f8379f54615495d1d | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index b63ef6a..cf268e8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -14,8 +14,8 @@
"fable"
]
},
- "fantomas-tool": {
- "version": "4.4.0",
+ "fantomas": {
+ "version": "5.0.0",
"co... | [
".config/dotnet-tools.json",
".editorconfig",
".vscode/settings.json",
"global.json",
"package.json",
"paket.lock"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 161 | issue_to_patch | .NET6 + Fantomas 5 | 868e3918c018abd7dcdef3c71d2948a333cf3229 | 948bee3db1f259a77900f792c932986cbddc6117 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index b63ef6a..cf268e8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -14,8 +14,8 @@
"fable"
]
},
- "fantomas-tool": {
- "version": "4.4.0",
+ "fantomas": {
+ "version": "5.0.0",
"co... | [
".config/dotnet-tools.json",
".editorconfig",
".vscode/settings.json",
"global.json",
"package-lock.json",
"package.json",
"paket.lock",
"src/Client/App.fs",
"src/Client/Index.fs",
"src/Server/Api.fs",
"src/Server/DataAccess.fs",
"src/Server/Server.fs",
"src/Shared/Shared.fs"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 160 | issue_to_patch | Upgraded to .net6 fixup | bc2b268e3bfc0175fcf4e45df31377c7face36f7 | 9c68a7affc7d621b8a0724a91631ac64b81b6ab5 | diff --git a/Build.fs b/Build.fs
index 4464b81..f6c3897 100644
--- a/Build.fs
+++ b/Build.fs
@@ -21,7 +21,7 @@ Target.create "InstallClient" (fun _ -> run npm "install" ".")
Target.create "Bundle" (fun _ ->
[ "server", dotnet $"publish -c Release -o \"{deployPath}\"" serverPath
- "client", dotnet "fable --... | [
"Build.fs",
"webpack.config.js"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 158 | issue_to_patch | Upgrade to .NET 6 | 669a566d3e279d1346db82a7ec89913e6db99a15 | f5ede36786017cef0bb2da108d9fac6d33ba95bb | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 66218b2..b63ef6a 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "6.0.0-rc002",
+ "version": "7.2.0",
"commands": [
"p... | [
".config/dotnet-tools.json",
".gitignore",
".paket/Paket.Restore.targets",
"Build.fs",
"Build.fsproj",
"global.json",
"package-lock.json",
"package.json",
"paket.dependencies",
"paket.lock",
"src/Client/Client.fsproj",
"src/Server/Server.fsproj",
"src/Shared/Shared.fsproj",
"webpack.config... | [
{
"comment": "Would it be worth updating Paket while we're updating everything else? It looks like it's on an RC version. (I'm putting the comment here because I can only comment on changed sections)",
"path": ".config/dotnet-tools.json",
"hunk": "@@ -9,7 +9,7 @@\n ]",
"resolving_sha": "f5ede3... | true | |||
CompositionalIT/SAFE-Dojo | 158 | comment_to_fix | Upgrade to .NET 6 | Would it be worth updating Paket while we're updating everything else? It looks like it's on an RC version. (I'm putting the comment here because I can only comment on changed sections) | 669a566d3e279d1346db82a7ec89913e6db99a15 | f5ede36786017cef0bb2da108d9fac6d33ba95bb | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 66218b2..b63ef6a 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "6.0.0-rc002",
+ "version": "7.2.0",
"commands": [
"p... | [
".config/dotnet-tools.json"
] | [
{
"comment": "Would it be worth updating Paket while we're updating everything else? It looks like it's on an RC version. (I'm putting the comment here because I can only comment on changed sections)",
"path": ".config/dotnet-tools.json",
"hunk": "@@ -9,7 +9,7 @@\n ]",
"resolving_sha": "f5ede3... | true | ||
CompositionalIT/SAFE-Dojo | 154 | issue_to_patch | Bump nth-check from 2.0.0 to 2.1.1 | Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fb55/nth-check/releases">nth-check's releases</a>.</em></p>
<blockquote>
<h2>v2.1.1</h2>
<ul>
<li>The ESM code had some issues that are now fixed aeeb067<... | f365e802aac1910ed2a62e1f10080fe0d5aa03d1 | a94dce0027ca3fb2d83bb931dea4adc876238768 | diff --git a/package-lock.json b/package-lock.json
index 8bc350c..37a2373 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4647,9 +4647,9 @@
}
},
"node_modules/nth-check": {
- "version": "2.0.0",
- "resolved": "https://registry.npmjs.org/nth-check/-/nth-che... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 153 | issue_to_patch | Bump minimist from 1.2.5 to 1.2.7 | Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.7.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md">minimist's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/minimistjs/minimist/compare/v1.... | 8ee963c099a2d556d7aac3a11131f0177a5aa380 | 9be46e355dbb2b632586af1776d06e79619abd6a | diff --git a/package-lock.json b/package-lock.json
index 466bb68..9e4e8ac 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5021,10 +5021,13 @@
}
},
"node_modules/minimist": {
- "version": "1.2.5",
- "resolved": "https://registry.npmjs.org/minimist/-/minimis... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 152 | issue_to_patch | Bump glob-parent and webpack | Bumps [glob-parent](https://github.com/gulpjs/glob-parent) to 5.1.2 and updates ancestor dependency [webpack](https://github.com/webpack/webpack). These dependencies need to be updated together.
Updates `glob-parent` from 3.1.0 to 5.1.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://gi... | 8ee963c099a2d556d7aac3a11131f0177a5aa380 | 97a9b9bb5a69555ed21ddb372b9ee8b5fb55c5ab | diff --git a/package-lock.json b/package-lock.json
index 466bb68..8bc350c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23,7 +23,7 @@
"sass": "^1.34.0",
"sass-loader": "^9.0.3",
"style-loader": "^1.2.1",
- "webpack": "^4.46.0",
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 151 | issue_to_patch | Bump terser from 4.8.0 to 4.8.1 | Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/terser/terser/blob/master/CHANGELOG.md">terser's changelog</a>.</em></p>
<blockquote>
<h2>v4.8.1 (backport)</h2>
<ul>
<li>Security fix for RegExps that should not ... | bee7a1957a4fcba813353c01cfffcea9f94abb60 | 1fb23402a9cf1901c09eae8ddf3ffbcfd57429e5 | diff --git a/package-lock.json b/package-lock.json
index ffab27c..125ff41 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7979,9 +7979,9 @@
}
},
"node_modules/terser": {
- "version": "4.8.0",
- "resolved": "https://registry.npmjs.org/terser/-/terser-4.8.0.... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 150 | issue_to_patch | Bump glob-parent and webpack-dev-server | Bumps [glob-parent](https://github.com/gulpjs/glob-parent) to 5.1.2 and updates ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies need to be updated together.
Updates `glob-parent` from 3.1.0 to 5.1.2
<details>
<summary>Release notes</summary>
<p><em>Sourced fr... | bee7a1957a4fcba813353c01cfffcea9f94abb60 | 401d5944f55cd2569d6ab1f7ab206bbbb23fe33a | diff --git a/package-lock.json b/package-lock.json
index ffab27c..0e62e20 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -23,9 +23,9 @@
"sass": "^1.34.0",
"sass-loader": "^9.0.3",
"style-loader": "^1.2.1",
- "webpack": "^4.41.2",
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 142 | issue_to_patch | Bump node-forge and webpack-dev-server | Bumps [node-forge](https://github.com/digitalbazaar/forge) and [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies needed to be updated together.
Updates `node-forge` from 0.10.0 to 1.3.1
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/digitalba... | bee7a1957a4fcba813353c01cfffcea9f94abb60 | cf9746651256a397d31ed30fac7f5e46c0b2e5d7 | diff --git a/package-lock.json b/package-lock.json
index ffab27c..1f7fa6a 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -25,7 +25,7 @@
"style-loader": "^1.2.1",
"webpack": "^4.41.2",
"webpack-cli": "^3.3.9",
- "webpack-dev-server": "^3.11.3"
... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 149 | issue_to_patch | Bump ansi-html and webpack-dev-server | Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer used after updating ancestor dependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server). These dependencies need to be updated together.
Removes `ansi-html`
Updates `webpack-dev-server` from 3.11.2 to 3.11.3
<details>
<summar... | adfb3e8e649ef7ed7b6a3aab08383841502f08af | d6e7f3c840f4e47017a25e59f498fe106e1c1499 | diff --git a/package-lock.json b/package-lock.json
index ed26e39..0f6a6ed 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -25,7 +25,7 @@
"style-loader": "^1.2.1",
"webpack": "^4.41.2",
"webpack-cli": "^3.3.9",
- "webpack-dev-server": "^3.8.2"
+... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 148 | issue_to_patch | Bump minimatch from 3.0.4 to 3.1.2 | Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/isaacs/minimatch/commit/699c459443a6bd98f5b28197978f76e7f71467ac"><code>699c459</code></a> 3.1.2</li>
<li><a href="https://github.com/isaacs/minimatch/commit/2f2b5ff1bb1b... | 0839d342b3188260508b3a35380436e6fd629326 | 007e9eca6f30228d3c0dfab4b361de533b31cf00 | diff --git a/package-lock.json b/package-lock.json
index eeef772..b809fd5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5004,9 +5004,9 @@
"dev": true
},
"node_modules/minimatch": {
- "version": "3.0.4",
- "resolved": "https://registry.npmjs.org/minimatch... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 144 | issue_to_patch | Bump d3-color and recharts | Bumps [d3-color](https://github.com/d3/d3-color) to 3.1.0 and updates ancestor dependency [recharts](https://github.com/recharts/recharts). These dependencies need to be updated together.
Updates `d3-color` from 2.0.0 to 3.1.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/d... | 21736e318a47f36bed4745ee80a5a0e21f5c567d | 363ed1b36f067709396a5ae8c70e599f4da450a5 | diff --git a/package-lock.json b/package-lock.json
index a48b570..bd9bd0c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10,7 +10,7 @@
"pigeon-maps": "^0.19.7",
"react": "^17.0.2",
"react-dom": "^17.0.2",
- "recharts": "^2.0.10",
+ ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 141 | issue_to_patch | Bump eventsource from 1.1.0 to 1.1.2 | Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/EventSource/eventsource/blob/master/HISTORY.md">eventsource's changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/EventSource/event... | 9517ec2674c3417a65312fdf3a71983718e5fa56 | 6335d95e45f8e2624622feafeb45c5085a0da301 | diff --git a/package-lock.json b/package-lock.json
index a48b570..83f7807 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2445,13 +2445,10 @@
}
},
"node_modules/eventsource": {
- "version": "1.1.0",
- "resolved": "https://registry.npmjs.org/eventsource/-/e... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 140 | issue_to_patch | Bump nanoid from 3.1.23 to 3.3.4 | Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ai/nanoid/blob/main/CHANGELOG.md">nanoid's changelog</a>.</em></p>
<blockquote>
<h2>3.3.4</h2>
<ul>
<li>Fixed <code>--help</code> in CLI (by <a href="https://github.c... | 9517ec2674c3417a65312fdf3a71983718e5fa56 | fabd0171f4bc72ff50ed39eca90390ed29f443fd | diff --git a/package-lock.json b/package-lock.json
index a48b570..a20e250 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5199,9 +5199,9 @@
"optional": true
},
"node_modules/nanoid": {
- "version": "3.1.23",
- "resolved": "https://registry.npmjs.org/nanoid... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 136 | issue_to_patch | Bump terser from 4.8.0 to 4.8.1 | Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/terser/terser/blob/master/CHANGELOG.md">terser's changelog</a>.</em></p>
<blockquote>
<h2>v4.8.1 (backport)</h2>
<ul>
<li>Security fix for RegExps that should not ... | 2f622aa713cbe13392f9a24e97dcb1f8273e285e | ed70676301b33a750cae11729ba57508f35205c7 | diff --git a/package-lock.json b/package-lock.json
index dd1effb..b58a261 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6516,9 +6516,9 @@
}
},
"terser": {
- "version": "4.8.0",
- "resolved": "https://registry.npmjs.org/terser/-/terser-4.8.0.tgz",
- ... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 129 | issue_to_patch | Bump async from 2.6.3 to 2.6.4 | Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md">async's changelog</a>.</em></p>
<blockquote>
<h1>v2.6.4</h1>
<ul>
<li>Fix potential prototype pollution exploit (<a href="http... | a95211fc671feda200aebee681bdaa10c9742569 | 9588e1c9bf45a7d8508a9ac7b3160e3a077d9a3b | diff --git a/package-lock.json b/package-lock.json
index dd1effb..27ab261 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -481,9 +481,9 @@
"dev": true
},
"async": {
- "version": "2.6.3",
- "resolved": "https://registry.npmjs.org/async/-/async-2.6.3.tgz",
- ... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 128 | issue_to_patch | Bump minimist from 1.2.5 to 1.2.6 | Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846"><code>7efb22a</code></a> 1.2.6</li>
<li><a href="https://github.com/substack/minimist/commit/ef88b9325f... | a95211fc671feda200aebee681bdaa10c9742569 | 5c2f58fdcc6053bd70d4da8f89866ab5a579f627 | diff --git a/package-lock.json b/package-lock.json
index dd1effb..2020d92 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4116,9 +4116,9 @@
}
},
"minimist": {
- "version": "1.2.5",
- "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.5.tgz",
-... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 127 | issue_to_patch | Bump url-parse from 1.5.1 to 1.5.10 | Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/unshiftio/url-parse/commit/8cd4c6c6435c1ea32243ec20c9cfe535251ec524"><code>8cd4c6c</code></a> 1.5.10</li>
<li><a href="https://github.com/unshiftio/url-parse/commit/c... | a95211fc671feda200aebee681bdaa10c9742569 | 3a355bc6b14942a5f65672e9d4790f828a92dc59 | diff --git a/package-lock.json b/package-lock.json
index dd1effb..9b2d18d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7027,9 +7027,9 @@
}
},
"url-parse": {
- "version": "1.5.1",
- "resolved": "https://registry.npmjs.org/url-parse/-/url-parse-1.5.1.tgz"... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 125 | issue_to_patch | Bump follow-redirects from 1.14.1 to 1.14.8 | Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/follow-redirects/follow-redirects/commit/3d81dc3237b4ffe8b722bb3d1c70a7866657166e"><code>3d81dc3</code></a> Release version 1.14.8 of the npm pa... | a95211fc671feda200aebee681bdaa10c9742569 | 27a506e245fc53e605ac953a9d7f8adf33a792ba | diff --git a/package-lock.json b/package-lock.json
index dd1effb..f8748ae 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2679,9 +2679,9 @@
}
},
"follow-redirects": {
- "version": "1.14.1",
- "resolved": "https://registry.npmjs.org/follow-redirects/-/follo... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 121 | issue_to_patch | Bump nth-check from 2.0.0 to 2.0.1 | Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fb55/nth-check/releases">nth-check's releases</a>.</em></p>
<blockquote>
<h2>v2.0.1</h2>
<p><strong>Fixes:</strong></p>
<ul>
<li>Replace regex with hand-ro... | a95211fc671feda200aebee681bdaa10c9742569 | fd794bb443a1417ddc7b45357c758ccf249a577d | diff --git a/package-lock.json b/package-lock.json
index dd1effb..dad03a7 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4419,9 +4419,9 @@
}
},
"nth-check": {
- "version": "2.0.0",
- "resolved": "https://registry.npmjs.org/nth-check/-/nth-check-2.0.0.tgz"... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 120 | issue_to_patch | Bump tar from 6.1.0 to 6.1.11 | Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.11.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/npm/node-tar/commit/e573aeea19d4d650908b7f6bf0a1ad8dce9f1736"><code>e573aee</code></a> 6.1.11</li>
<li><a href="https://github.com/npm/node-tar/commit/edb8e9a3fa5869cfb935479a262f... | 9517ec2674c3417a65312fdf3a71983718e5fa56 | f1e2c742b60682d0df03dd399fcafea9953ecd54 | diff --git a/package-lock.json b/package-lock.json
index a48b570..1ba96cf 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -7963,9 +7963,9 @@
}
},
"node_modules/tar": {
- "version": "6.1.0",
- "resolved": "https://registry.npmjs.org/tar/-/tar-6.1.0.tgz",
- ... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 101 | issue_to_patch | Bump dns-packet from 1.3.1 to 1.3.4 | Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/mafintosh/dns-packet/commit/ebdf849da5dc0d96836e87628349776c623c5be7"><code>ebdf849</code></a> 1.3.4</li>
<li><a href="https://github.com/mafintosh/dns-packet/commit... | 4d3e91e0fc8058087df717d559d69ab6b0aa28d1 | 85b009763e40e2b956890df7b2108bec3582ecf0 | diff --git a/package-lock.json b/package-lock.json
index 32fa205..4f05c67 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -2899,9 +2899,9 @@
"dev": true
},
"dns-packet": {
- "version": "1.3.1",
- "resolved": "https://registry.npmjs.org/dns-packet/-/dns-pack... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 94 | issue_to_patch | Bump elliptic from 6.5.3 to 6.5.4 | Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/indutny/elliptic/commit/43ac7f230069bd1575e1e4a58394a512303ba803"><code>43ac7f2</code></a> 6.5.4</li>
<li><a href="https://github.com/indutny/elliptic/commit/f4bc72be11b0a... | 4d3e91e0fc8058087df717d559d69ab6b0aa28d1 | 348171cd8cb86c8d26bd2a356310721a7c3269c3 | diff --git a/package-lock.json b/package-lock.json
index 32fa205..2b500eb 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -3009,24 +3009,24 @@
"dev": true
},
"elliptic": {
- "version": "6.5.3",
- "resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6... | [
"package-lock.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 139 | issue_to_patch | Use static JSON samples for type providers (issue #137) | https://github.com/CompositionalIT/SAFE-Dojo/issues/137 | 2e2000e9994d522c1edf23ba7d1dda48ad4681c3 | 79ecf482a60300b5e769455f916f92c2156adf9c | diff --git a/Build.fs b/Build.fs
index 362ffbb..846a4b8 100644
--- a/Build.fs
+++ b/Build.fs
@@ -11,9 +11,6 @@ let sharedPath = Path.getFullName "src/Shared"
let serverPath = Path.getFullName "src/Server"
let clientPath = Path.getFullName "src/Client"
let deployPath = Path.getFullName "deploy"
-let sharedTestsPath =... | [
"Build.fs",
"README.md",
"SAFE-dojo.sln",
"package.json",
"src/Client/Index.fs",
"src/Client/index.html",
"src/Client/paket.references",
"src/Server/Api.fs",
"src/Server/DataAccess.fs",
"src/Server/Properties/launchSettings.json",
"src/Shared/Shared.fs",
"tests/Client/Client.Tests.fs",
"test... | [] | diff --git a/tests/Client/Client.Tests.fs b/tests/Client/Client.Tests.fs
deleted file mode 100644
index 1df5815..0000000
--- a/tests/Client/Client.Tests.fs
+++ /dev/null
@@ -1,29 +0,0 @@
-module Client.Tests
-
-open Fable.Mocha
-
-open Index
-open Shared
-
-let client = testList "Client" [
- testCase "Added todo" <|... | true | |
CompositionalIT/SAFE-Dojo | 134 | issue_to_patch | Metaweather alternative | [metaweather.com](http://metaweather.com) is down. This PR changes the code to use [open-meteo.com](http://open-meteo.com)'s API and display [open source weather icons](https://github.com/erikflowers/weather-icons) instead. | a95211fc671feda200aebee681bdaa10c9742569 | f45fd41ec5ddbd3b67530502866f01cdcfe6479e | diff --git a/src/Client/Index.fs b/src/Client/Index.fs
index d39b639..7a9776e 100644
--- a/src/Client/Index.fs
+++ b/src/Client/Index.fs
@@ -163,7 +163,7 @@ module ViewParts =
prop.children [
Html.img [
prop.style [ style.height 100]
- ... | [
"src/Client/Index.fs",
"src/Server/Api.fs",
"src/Server/DataAccess.fs",
"src/Shared/Shared.fs"
] | [
{
"comment": "`emptyWeather` still uses the `AverageTemperature` label that was renamed to `Temperature`, which causes the project to fail to build. (Api.fs, line 44)",
"path": "src/Server/Api.fs",
"hunk": "@@ -29,14 +29,9 @@ let getCrimeReport postcode = async {\n return crimes\n }\n \n-let private... | true | ||
CompositionalIT/SAFE-Dojo | 134 | comment_to_fix | Metaweather alternative | `emptyWeather` still uses the `AverageTemperature` label that was renamed to `Temperature`, which causes the project to fail to build. (Api.fs, line 44) | a95211fc671feda200aebee681bdaa10c9742569 | f45fd41ec5ddbd3b67530502866f01cdcfe6479e | diff --git a/src/Server/Api.fs b/src/Server/Api.fs
index 86885c7..53645cb 100644
--- a/src/Server/Api.fs
+++ b/src/Server/Api.fs
@@ -29,14 +29,9 @@ let getCrimeReport postcode = async {
return crimes
}
-let private asWeatherResponse (weather: Weather.MetaWeatherLocation.Root) =
- { WeatherType =
- wea... | [
"src/Server/Api.fs"
] | [
{
"comment": "`emptyWeather` still uses the `AverageTemperature` label that was renamed to `Temperature`, which causes the project to fail to build. (Api.fs, line 44)",
"path": "src/Server/Api.fs",
"hunk": "@@ -29,14 +29,9 @@ let getCrimeReport postcode = async {\n return crimes\n }\n \n-let private... | true | ||
CompositionalIT/SAFE-Dojo | 114 | issue_to_patch | Tests need updating
The tests need updating, they are the old TODO tests | Cleanup some code and remove tests | Fixes #110 and does some other code simplification
| ea958a5e9846ce2172853e71b197464eb31b39c2 | 060391a28c18c5025df5b1c7326692081794389f | diff --git a/Build.fs b/Build.fs
index 362ffbb..1fbfdbb 100644
--- a/Build.fs
+++ b/Build.fs
@@ -11,9 +11,6 @@ let sharedPath = Path.getFullName "src/Shared"
let serverPath = Path.getFullName "src/Server"
let clientPath = Path.getFullName "src/Client"
let deployPath = Path.getFullName "deploy"
-let sharedTestsPath =... | [
"Build.fs",
"Instructions.md",
"README.md",
"SAFE-dojo.sln",
"src/Client/Index.fs",
"src/Server/Api.fs",
"src/Server/DataAccess.fs",
"src/Shared/Shared.fs",
"tests/Client/Client.Tests.fs",
"tests/Client/Client.Tests.fsproj",
"tests/Client/index.html",
"tests/Client/paket.references",
"tests/... | [] | diff --git a/tests/Client/Client.Tests.fs b/tests/Client/Client.Tests.fs
deleted file mode 100644
index 1df5815..0000000
--- a/tests/Client/Client.Tests.fs
+++ /dev/null
@@ -1,29 +0,0 @@
-module Client.Tests
-
-open Fable.Mocha
-
-open Index
-open Shared
-
-let client = testList "Client" [
- testCase "Added todo" <|... | true |
CompositionalIT/SAFE-Dojo | 113 | issue_to_patch | Updated readme | 38586540d45c9789847cf22c07664f705a384727 | 7d4d5064bcbbe041798a273808c7d265afedd7fa | diff --git a/README.md b/README.md
index 47d02db..c47ce7c 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,8 @@
-# SAFE Template
+# SAFE Dojo
-This template can be used to generate a full-stack web application using the [SAFE Stack](https://safe-stack.github.io/). It was created using the dotnet [SAFE Template](http... | [
"README.md"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 112 | issue_to_patch | Updated readme to include details of the Dojo | 9a62b2b5226d650b7e4937dfda470282a5b7d4c9 | 2a9588c85b6a56ef6c8a83ae5c84828f4e527f6c | diff --git a/README.md b/README.md
index c1e3ee5..c47ce7c 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,8 @@
-# SAFE Template
+# SAFE Dojo
-This template can be used to generate a full-stack web application using the [SAFE Stack](https://safe-stack.github.io/). It was created using the dotnet [SAFE Template](http... | [
"README.md"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 109 | issue_to_patch | Update README.md | Just in case someone doesn't realise it's actually a dojo π | d84c4891eb0d267283dbe0775d7e452e1024f822 | b0b8172989925359a30037b955fd049cfa3ec7eb | diff --git a/README.md b/README.md
index c1e3ee5..47d02db 100644
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@ To concurrently run the server and the client components in watch mode use the f
dotnet run
```
-Then open `http://localhost:8080` in your browser.
+Then open `http://localhost:8080` in your browser an... | [
"README.md"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 105 | issue_to_patch | Updated solution v3 | 021a06ca812d92499dcdb8f7ff1490b6065e5865 | 41522d386465469b22df747c4f908ada51f274c1 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index eaa5d76..66218b2 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,18 +1,24 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "5.245.0",
- "commands": [
... | [
".config/dotnet-tools.json",
".editorconfig",
".gitignore",
".paket/Paket.Restore.targets",
".paket/paket.exe",
".vscode/extensions.json",
".vscode/launch.json",
".vscode/tasks.json",
"Build.fs",
"Build.fsproj",
"Helpers.fs",
"Instructions.md",
"README.md",
"SAFE-dojo.sln",
"build.fsx",
... | [] | diff --git a/tests/Client/Client.Tests.fs b/tests/Client/Client.Tests.fs
new file mode 100644
index 0000000..1df5815
--- /dev/null
+++ b/tests/Client/Client.Tests.fs
@@ -0,0 +1,29 @@
+module Client.Tests
+
+open Fable.Mocha
+
+open Index
+open Shared
+
+let client = testList "Client" [
+ testCase "Added todo" <| fun... | true | ||
CompositionalIT/SAFE-Dojo | 103 | issue_to_patch | V3 upgrade | Upgraded dojo to v3 | 4d3e91e0fc8058087df717d559d69ab6b0aa28d1 | a49b23216c20f3e51489ca25616b9ba33c0939a0 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index eaa5d76..66218b2 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,18 +1,24 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "5.245.0",
- "commands": [
... | [
".config/dotnet-tools.json",
".editorconfig",
".gitignore",
".paket/Paket.Restore.targets",
".paket/paket.exe",
".vscode/extensions.json",
".vscode/launch.json",
".vscode/tasks.json",
"Build.fs",
"Build.fsproj",
"Helpers.fs",
"Instructions.md",
"README.md",
"SAFE-dojo.sln",
"build.fsx",
... | [] | diff --git a/tests/Client/Client.Tests.fs b/tests/Client/Client.Tests.fs
new file mode 100644
index 0000000..1df5815
--- /dev/null
+++ b/tests/Client/Client.Tests.fs
@@ -0,0 +1,29 @@
+module Client.Tests
+
+open Fable.Mocha
+
+open Index
+open Shared
+
+let client = testList "Client" [
+ testCase "Added todo" <| fun... | true | |
CompositionalIT/SAFE-Dojo | 92 | issue_to_patch | Add global.json for pinning to .NET SDK 3.1 | I wasn't able to start server when running .NET SDK 5. When I added a `global.json` for pinning to SDK 3.1, then I managed to start it. I thought a `global.json` would be a good addition.
// cc @isaacabraham | 641d10e1de995590a0fb37db78551f0a5a0d1973 | 3ca9c160e1908c872baf66fce746081978455a63 | diff --git a/global.json b/global.json
new file mode 100644
index 0000000..f60487d
--- /dev/null
+++ b/global.json
@@ -0,0 +1,6 @@
+{
+ "sdk": {
+ "version": "3.1.404",
+ "rollForward": "latestFeature"
+ }
+}
\ No newline at end of file
| [
"global.json"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 88 | issue_to_patch | Update SAFE component links | It looks like a couple of links are out of date. I've updated them appropriately. | 2a0536c9373732ff9d3d30e649015b4f10642ebb | fbe9ccec95357dd7d171ad4652893fc00d2196fa | diff --git a/src/Client/ViewHelpers.fs b/src/Client/ViewHelpers.fs
index 417c5d2..7e0e303 100644
--- a/src/Client/ViewHelpers.fs
+++ b/src/Client/ViewHelpers.fs
@@ -21,9 +21,9 @@ let intersperse sep ls =
let safeComponents =
let components =
- [ "Saturn", "https://saturnframework.github.io/docs/"
+ ... | [
"src/Client/ViewHelpers.fs"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 87 | issue_to_patch | Update prerequisites and minor textual fixes | e553132c8ac445f570bca2f8f130d74db6fe4135 | 34965796485e16b364bc55301a7526f90296dceb | diff --git a/Instructions.md b/Instructions.md
index 0a14fa9..aa28a17 100644
--- a/Instructions.md
+++ b/Instructions.md
@@ -3,7 +3,7 @@
## Prologue: Build and Run
1. Clone this repo
1. Ensure that you have installed all the pre-requisites in `README.md`
-1. If this is your first time doing this run `dotnet tool res... | [
"Instructions.md",
"README.md"
] | [] | true | |||
CompositionalIT/SAFE-Dojo | 78 | issue_to_patch | #77: Fix input should not be null for postcode | Error was visible through the console. Fix is to simply add an empty string.
Fix for https://github.com/CompositionalIT/SAFE-Dojo/issues/77 | ef4342cfa37b87e2acdf1295dfeb04793493b3da | 443dfb520e239a436c4957dc4f7afb9b1a73c054 | diff --git a/src/Client/App.fs b/src/Client/App.fs
index 1666eb1..299bf86 100644
--- a/src/Client/App.fs
+++ b/src/Client/App.fs
@@ -37,7 +37,7 @@ type Msg =
/// The init function is called to start the message pump with an initial view.
let init () =
- { Postcode = null
+ { Postcode = ""
Report = None... | [
"src/Client/App.fs"
] | [] | true | ||
CompositionalIT/SAFE-Dojo | 75 | issue_to_patch | Bump acorn from 6.3.0 to 6.4.1 | Bumps [acorn](https://github.com/acornjs/acorn) from 6.3.0 to 6.4.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li>
<li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce... | 09cb6610912685d3b2ab8b0c9abba48b5dab6a16 | 39d5fe36eaab06693349e5210dc6d22f5bf34bc8 | diff --git a/yarn.lock b/yarn.lock
index a7fb22c..313b0ff 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -881,9 +881,9 @@ accepts@~1.3.4, accepts@~1.3.5, accepts@~1.3.7:
negotiator "0.6.2"
acorn@^6.2.1:
- version "6.3.0"
- resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.3.0.tgz#0087509119ffa4fc0a0041d1e93a4... | [
"yarn.lock"
] | [] | true | ||
CompositionalIT/farmer | 1,251 | issue_to_patch | Don't allow unsupported combinations of CPU and RAM
Farmer throws if an unsupported combination of CPU and RAM is configured for a container app.
https://github.com/CompositionalIT/farmer/blob/3e0a1e4c790ac42172efe47565a5cfca9dc16d90/src/Farmer/Builders/Builders.ContainerApps.fs#L253-L263
It's better that it throws ... | Add compile-time safe resource allocation for Container App consumption plans | Consumption plans for Azure Container Apps require specific CPU/memory pairs. Previously, setting them independently via `cpu_cores` and `memory` only failed at runtime. This PR introduces a typed DU that constrains valid combinations at compile time.
The changes in this PR are as follows:
* **`ContainerApp.Consumpti... | d71d106bc04e68126a0e7d6316aeed0251f043d4 | 6094d98e1e3ed892345e0c44da06a2e5119cf18f | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 6fdfcc42c..e46c18022 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -1,6 +1,9 @@
Release Notes
=============
+## 1.9.28
+* Container Apps: Add `resources` operation to the `container` builder to set both CPU and memory together using a `ConsumptionPlan... | [
"RELEASE_NOTES.md",
"docs/content/api-overview/resources/container-apps.md",
"src/Farmer/Builders/Builders.ContainerApps.fs",
"src/Farmer/Common.fs",
"src/Tests/ContainerApps.fs"
] | [
{
"comment": "@copilot this is missing some options. Here's the full table from the docs:\n\n```\nvCPUs (cores)\tMemory\n0.25\t0.5Gi\n0.5\t1.0Gi\n0.75\t1.5Gi\n1.0\t2.0Gi\n1.25\t2.5Gi\n1.5\t3.0Gi\n1.75\t3.5Gi\n2.0\t4.0Gi\n2.25\t4.5Gi\n2.5\t5.0Gi\n2.75\t5.5Gi\n3.0\t6.0Gi\n3.25\t6.5Gi\n3.5\t7.0Gi\n3.75\t7.5Gi\n4.0... | diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs
index 0742e4f12..a7b2c061d 100644
--- a/src/Tests/ContainerApps.fs
+++ b/src/Tests/ContainerApps.fs
@@ -485,4 +485,92 @@ let tests =
Expect.equal (probe.Route.ToString()) "/api/healthcheck" "Incorrect probe route"
Expect.equa... | true |
CompositionalIT/farmer | 1,251 | comment_to_fix | Add compile-time safe resource allocation for Container App consumption plans | @copilot this is missing some options. Here's the full table from the docs:
```
vCPUs (cores) Memory
0.25 0.5Gi
0.5 1.0Gi
0.75 1.5Gi
1.0 2.0Gi
1.25 2.5Gi
1.5 3.0Gi
1.75 3.5Gi
2.0 4.0Gi
2.25 4.5Gi
2.5 5.0Gi
2.75 5.5Gi
3.0 6.0Gi
3.25 6.5Gi
3.5 7.0Gi
3.75 7.5Gi
4.0 8.0Gi
``` | d71d106bc04e68126a0e7d6316aeed0251f043d4 | 6094d98e1e3ed892345e0c44da06a2e5119cf18f | diff --git a/src/Farmer/Common.fs b/src/Farmer/Common.fs
index d82be4ae8..7efa18aae 100644
--- a/src/Farmer/Common.fs
+++ b/src/Farmer/Common.fs
@@ -4142,6 +4142,82 @@ module ContainerApp =
/// Mounts an Azure File Share in the same resource group, performing a key lookup.
| AzureFileShare of ShareNam... | [
"src/Farmer/Common.fs"
] | [
{
"comment": "@copilot this is missing some options. Here's the full table from the docs:\n\n```\nvCPUs (cores)\tMemory\n0.25\t0.5Gi\n0.5\t1.0Gi\n0.75\t1.5Gi\n1.0\t2.0Gi\n1.25\t2.5Gi\n1.5\t3.0Gi\n1.75\t3.5Gi\n2.0\t4.0Gi\n2.25\t4.5Gi\n2.5\t5.0Gi\n2.75\t5.5Gi\n3.0\t6.0Gi\n3.25\t6.5Gi\n3.5\t7.0Gi\n3.75\t7.5Gi\n4.0... | true | ||
CompositionalIT/farmer | 1,250 | issue_to_patch | Retrieve EventHub ConnectionString as output
How can we retrieve as output the connection string of an event hub?
let eventHub = eventHub {
namespace_name eventHubNamespaceName
sku EventHub.Standard
enable_auto_inflate 10
name eventHubName
}
let template = arm {
location Location.Austra... | Docs: show how to retrieve EventHub connection string as template output | The existing `DefaultKey` and `GetKey` members on `EventHubConfig` already return the primary connection string via an ARM expression β this was not clearly documented. This PR updates the documentation to make that behaviour explicit and demonstrates how to expose the connection string as an ARM template output.
The ... | d71d106bc04e68126a0e7d6316aeed0251f043d4 | b7cb44d591c8a602e0d0d1d11c4a14f2656ea094 | diff --git a/docs/content/api-overview/resources/event-hub.md b/docs/content/api-overview/resources/event-hub.md
index e40ae926b..c92b78c8c 100644
--- a/docs/content/api-overview/resources/event-hub.md
+++ b/docs/content/api-overview/resources/event-hub.md
@@ -35,8 +35,8 @@ The Event Hub builder creates event hub names... | [
"docs/content/api-overview/resources/event-hub.md"
] | [] | true | |
CompositionalIT/farmer | 1,239 | issue_to_patch | StorageAccountConfig.Key should return the key but returns full connection string
From the source code:
```F#
type StorageAccountConfig = {
...
} with
/// Gets the ARM expression path to the key of this storage account.
member this.Key = StorageAccount.getConnectionString (this.Name)
```
Maybe this one sh... | Fix StorageAccountConfig.Key to return account key instead of connection string | This PR closes #1238
The changes in this PR are as follows:
* Added `AccountKey` member returning just the storage account key via `listKeys(...).keys[0].value`
* Added `ConnectionString` member explicitly returning the full connection string
* Marked `Key` member as obsolete - it incorrectly returned a connect... | 20cf857e3b0019767d3eee4c3c8c240284971b1d | ea724130329f2be76a9961385cbef4431e19cd1b | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 632ff6ccd..6fdfcc42c 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -2,6 +2,7 @@ Release Notes
=============
## 1.9.27
+* Storage Accounts: Add `AccountKey` member to return just the storage account key and `ConnectionString` member to return the conne... | [
"RELEASE_NOTES.md",
"samples/scripts/container-app.fsx",
"samples/scripts/safe-template.fsx",
"samples/scripts/webapp-storage.fsx",
"src/Farmer/Builders/Builders.ContainerApps.fs",
"src/Farmer/Builders/Builders.Storage.fs",
"src/Tests/ContainerApps.fs",
"src/Tests/ContainerGroup.fs",
"src/Tests/Func... | [
{
"comment": "This is a super-old API version @copilot. I don't think it's changed, and this likely still works, but stick with the same version used when deploying storage accounts. At this time, that is `2025-06-01`.",
"path": "src/Farmer/Builders/Builders.Storage.fs",
"hunk": "@@ -10,6 +10,20 @@ open... | diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs
index be3f88af2..0742e4f12 100644
--- a/src/Tests/ContainerApps.fs
+++ b/src/Tests/ContainerApps.fs
@@ -72,7 +72,7 @@ let fullContainerAppDeployment =
component_type "some.component.type"
version "v1"
... | true |
CompositionalIT/farmer | 1,246 | issue_to_patch | Need support for network manager configurations
Create configurations with rule sets that support IP ranges and service tags. | Add Azure Network Manager support with security admin configurations | Adds Farmer builders for Azure Network Manager, enabling centralized network security policy management across subscriptions via security admin configurations with rule sets supporting IP ranges and service tags.
Fixes #1245
### New ARM types (`Arm/NetworkManager.fs`)
- `NetworkManager` β parent resource with s... | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 81e96813680bd5fc5f6bd9cb217ab408b48535a0 | diff --git a/LICENSE b/LICENSE
index 9a6275a6c..144e5e205 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
MIT License
-Copyright (c) 2019 Compositional IT
+Copyright (c) 2019-2026 Compositional IT
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated docu... | [
"LICENSE",
"RELEASE_NOTES.md",
"azure-pipelines.yml",
"docs/config.toml",
"docs/content/_index.md",
"docs/content/api-overview/resources/network-manager.md",
"docs/content/faq/_index.md",
"docs/content/links/_index.md",
"docs/content/support/_index.md",
"docs/content/testimonials/_index.md",
"gl... | [
{
"comment": "@copilot don't add new support with old API versions. Use the newest. This is currently 2025-05-01. Fix for all of these new `ResourceType` instances.",
"path": "src/Farmer/Arm/NetworkManager.fs",
"hunk": "@@ -0,0 +1,264 @@\n+[<AutoOpen>]\n+module Farmer.Arm.NetworkManager\n+\n+open Farmer... | diff --git a/src/Tests/AllTests.fs b/src/Tests/AllTests.fs
index 8aaed2260..47163aa9b 100644
--- a/src/Tests/AllTests.fs
+++ b/src/Tests/AllTests.fs
@@ -62,6 +62,7 @@ let allTests =
LogicApps.tests
Maps.tests
NetworkSecurityGroup.tests
+ NetworkManager.tests
... | true |
CompositionalIT/farmer | 1,246 | comment_to_fix | Add Azure Network Manager support with security admin configurations | @copilot the `AppliesToGroups` list cannot be empty for a rule collection or this will fail at ARM deployment time. Typically this is checked using a `.Run` member on the builder that will perform validation and calls `raiseFarmer` if the field is not valid. | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 81e96813680bd5fc5f6bd9cb217ab408b48535a0 | diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs
new file mode 100644
index 000000000..448571289
--- /dev/null
+++ b/src/Farmer/Builders/Builders.NetworkManager.fs
@@ -0,0 +1,549 @@
+[<AutoOpen>]
+module Farmer.Builders.NetworkManager
+
+open Farmer
+open Farm... | [
"src/Farmer/Builders/Builders.NetworkManager.fs"
] | [
{
"comment": "@copilot the `AppliesToGroups` list cannot be empty for a rule collection or this will fail at ARM deployment time. Typically this is checked using a `.Run` member on the builder that will perform validation and calls `raiseFarmer` if the field is not valid.",
"path": "src/Farmer/Builders/Buil... | true | ||
CompositionalIT/farmer | 1,246 | comment_to_fix | Add Azure Network Manager support with security admin configurations | @copilot you can't use "*". it would need to be 0-65535 to represent all ports. | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 81e96813680bd5fc5f6bd9cb217ab408b48535a0 | diff --git a/src/Farmer/Arm/NetworkManager.fs b/src/Farmer/Arm/NetworkManager.fs
new file mode 100644
index 000000000..da22f7ac6
--- /dev/null
+++ b/src/Farmer/Arm/NetworkManager.fs
@@ -0,0 +1,272 @@
+[<AutoOpen>]
+module Farmer.Arm.NetworkManager
+
+open Farmer
+
+// https://learn.microsoft.com/en-us/azure/templates/m... | [
"src/Farmer/Arm/NetworkManager.fs"
] | [
{
"comment": "@copilot you can't use \"*\". it would need to be 0-65535 to represent all ports.",
"path": "src/Farmer/Arm/NetworkManager.fs",
"hunk": "@@ -0,0 +1,272 @@\n+[<AutoOpen>]\n+module Farmer.Arm.NetworkManager\n+\n+open Farmer\n+\n+// https://learn.microsoft.com/en-us/azure/templates/microsoft.... | true | ||
CompositionalIT/farmer | 1,246 | comment_to_fix | Add Azure Network Manager support with security admin configurations | @copilot you need to add a `_.Run` member here to validate the rule's source uses either service tags or IP prefixes, but not both. If not, this is the error ARM returns:
"Cannot mix IPPrefixes and ServiceTags, please create separate rules."
You can, however have the source be a service tag and destination be an IP p... | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 81e96813680bd5fc5f6bd9cb217ab408b48535a0 | diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs
new file mode 100644
index 000000000..448571289
--- /dev/null
+++ b/src/Farmer/Builders/Builders.NetworkManager.fs
@@ -0,0 +1,549 @@
+[<AutoOpen>]
+module Farmer.Builders.NetworkManager
+
+open Farmer
+open Farm... | [
"src/Farmer/Builders/Builders.NetworkManager.fs"
] | [
{
"comment": "@copilot you need to add a `_.Run` member here to validate the rule's source uses either service tags or IP prefixes, but not both. If not, this is the error ARM returns:\n\n\"Cannot mix IPPrefixes and ServiceTags, please create separate rules.\"\n\nYou can, however have the source be a service ta... | true | ||
CompositionalIT/farmer | 1,246 | comment_to_fix | Add Azure Network Manager support with security admin configurations | @copilot when specifying these scopes, prefix with "/subscriptions/" automatically if it's not there already. It would be pretty normal for someone to just specify the subscription ID itself and then they'll get an error even though their intent is clear. | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 81e96813680bd5fc5f6bd9cb217ab408b48535a0 | diff --git a/src/Farmer/Builders/Builders.NetworkManager.fs b/src/Farmer/Builders/Builders.NetworkManager.fs
new file mode 100644
index 000000000..448571289
--- /dev/null
+++ b/src/Farmer/Builders/Builders.NetworkManager.fs
@@ -0,0 +1,549 @@
+[<AutoOpen>]
+module Farmer.Builders.NetworkManager
+
+open Farmer
+open Farm... | [
"src/Farmer/Builders/Builders.NetworkManager.fs"
] | [
{
"comment": "@copilot when specifying these scopes, prefix with \"/subscriptions/\" automatically if it's not there already. It would be pretty normal for someone to just specify the subscription ID itself and then they'll get an error even though their intent is clear.",
"path": "src/Farmer/Builders/Build... | true | ||
CompositionalIT/farmer | 1,248 | issue_to_patch | Update codebase for dotnet 10 SDK | The changes in this PR are as follows:
* Updates codebase for building on dotnet 10 SDK
* Moves off vulnerable packages used in Tests.
I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following:
* [ ] **Tested my code** end-to-end against a live Azure subscription.
* [ ] **Up... | 1ea9a9cb9f45cd270778651e2e56e9e5dfea7ba9 | cd6e7eeaf3731582bac6f6bf56429855a7728fe3 | diff --git a/LICENSE b/LICENSE
index 9a6275a6c..144e5e205 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
MIT License
-Copyright (c) 2019 Compositional IT
+Copyright (c) 2019-2026 Compositional IT
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated docu... | [
"LICENSE",
"azure-pipelines.yml",
"global.json",
"src/Farmer/Farmer.fsproj",
"src/Tests/AutoscaleSettings.fs",
"src/Tests/Tests.fsproj",
"src/Tests/VmScaleSet.fs"
] | [] | diff --git a/src/Tests/AutoscaleSettings.fs b/src/Tests/AutoscaleSettings.fs
index 85e498d95..594fefc49 100644
--- a/src/Tests/AutoscaleSettings.fs
+++ b/src/Tests/AutoscaleSettings.fs
@@ -59,11 +59,11 @@ let tests =
Statistic = MetricTriggerStatistic.Average
... | true | |
CompositionalIT/farmer | 1,247 | issue_to_patch | CIT link from docs not valid
It's been taken over and now redirects to a spam site
<img width="1058" height="322" alt="Image" src="https://github.com/user-attachments/assets/adf31edb-2586-48eb-b28f-7efa4efbf6ac" /> | Remove defunct compositional-it.com links from docs | Fixes #1242
`compositional-it.com` has been taken over and now redirects to a spam site. Removes all hyperlinks and contact references to that domain from the documentation.
The changes in this PR are as follows:
* `docs/config.toml` β removed Compositional IT sidebar menu shortcut
* `docs/content/_index.md`... | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 67432f68f71231e147a02aa129709344a40bff3c | diff --git a/docs/config.toml b/docs/config.toml
index 62250a13b..d36401944 100644
--- a/docs/config.toml
+++ b/docs/config.toml
@@ -23,8 +23,3 @@ identifier = "nuget"
url = "https://www.nuget.org/packages/Farmer/"
weight = 10
-[[Languages.en.menu.shortcuts]]
-name = "<img src='/farmer/images/cit.png'></img> Compos... | [
"docs/config.toml",
"docs/content/_index.md",
"docs/content/faq/_index.md",
"docs/content/links/_index.md",
"docs/content/support/_index.md",
"docs/content/testimonials/_index.md"
] | [
{
"comment": "@copilot just remove this bullet entirely. Unless someone already has a commercial arrangement, there likely will not be one.",
"path": "docs/content/faq/_index.md",
"hunk": "@@ -43,4 +43,4 @@ Yes. You can use some adapters that Farmer provides to generate resources using\n Create an issue... | true | |
CompositionalIT/farmer | 1,247 | comment_to_fix | Remove defunct compositional-it.com links from docs | @copilot just remove this bullet entirely. Unless someone already has a commercial arrangement, there likely will not be one. | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 67432f68f71231e147a02aa129709344a40bff3c | diff --git a/docs/content/faq/_index.md b/docs/content/faq/_index.md
index 402e4ee4b..56555c282 100644
--- a/docs/content/faq/_index.md
+++ b/docs/content/faq/_index.md
@@ -42,5 +42,3 @@ Yes. You can use some adapters that Farmer provides to generate resources using
#### The resource I need isn't included!
Create an ... | [
"docs/content/faq/_index.md"
] | [
{
"comment": "@copilot just remove this bullet entirely. Unless someone already has a commercial arrangement, there likely will not be one.",
"path": "docs/content/faq/_index.md",
"hunk": "@@ -43,4 +43,4 @@ Yes. You can use some adapters that Farmer provides to generate resources using\n Create an issue... | true | ||
CompositionalIT/farmer | 1,247 | comment_to_fix | Remove defunct compositional-it.com links from docs | @copilot also remove this line so there isn't a mailto going to the defunct domain. | 1df037941bf30e1a20bc58ada939d32f2a34c982 | 67432f68f71231e147a02aa129709344a40bff3c | diff --git a/docs/content/support/_index.md b/docs/content/support/_index.md
index 5e467de8e..91e97235c 100644
--- a/docs/content/support/_index.md
+++ b/docs/content/support/_index.md
@@ -4,12 +4,10 @@ date: 2020-06-27T17:57:05+02:00
weight: 7
---
-The creators of Farmer, [Compositional IT](https://compositional-i... | [
"docs/content/support/_index.md"
] | [
{
"comment": "@copilot also remove this line so there isn't a mailto going to the defunct domain.",
"path": "docs/content/support/_index.md",
"hunk": "@@ -4,12 +4,12 @@ date: 2020-06-27T17:57:05+02:00\n weight: 7\n ---\n \n-The creators of Farmer, [Compositional IT](https://compositional-it.com), offer ... | true | ||
CompositionalIT/farmer | 1,220 | issue_to_patch | Action groups broken
https://github.com/CompositionalIT/farmer/commit/7ce2f6116d7bedaa5c6fef8d88564e329de5d7d3
This commit broke the action group resource as the api version wasn't updated.
My deploy fails with
`"message":"{\r\n \"code\": \"ApiVersionNotSupportingIncidentAction\",\r\n \"message\": \"Incident acti... | Bump action group version to support Incident action | This PR closes #1219 | b6620667990f19dd9960ffd210c4e04ae0f17275 | 18623ebae5738919a2ea882af29054cbdae0402b | diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs
index 0dd1d22c3..f18793025 100644
--- a/src/Farmer/Arm/ActionGroup.fs
+++ b/src/Farmer/Arm/ActionGroup.fs
@@ -6,7 +6,7 @@ open Farmer
open System
let actionGroups =
- Farmer.ResourceType("microsoft.insights/actionGroups", "2022-06-01")
+ ... | [
"src/Farmer/Arm/ActionGroup.fs"
] | [] | true | |
CompositionalIT/farmer | 1,234 | issue_to_patch | Allow floats for metric threshold | I created an alert in the portal then tried to replicate it with Farmer but metric thresholds were ints instead of floats.
This PR just changes that field type.
<img width="1701" height="687" alt="image" src="https://github.com/user-attachments/assets/13e45a5d-aec6-406c-9c40-377890f68908" />
<img width="721" h... | d408f18b101f514381ab02d95ad52e81051dd248 | 3c0a2774ea432e1342f17e5f72eadbfb2ad76960 | diff --git a/src/Farmer/Arm/Alert.fs b/src/Farmer/Arm/Alert.fs
index fb4d90e96..95a1e4f32 100644
--- a/src/Farmer/Arm/Alert.fs
+++ b/src/Farmer/Arm/Alert.fs
@@ -44,7 +44,7 @@ type ResourceCriteria = {
/// Name of the metric
MetricName: MetricsName
/// Threshold to exceed to hit the alert
- Threshold: ... | [
"src/Farmer/Arm/Alert.fs"
] | [] | true | ||
CompositionalIT/farmer | 1,235 | issue_to_patch | Documentation/tutorial updates | I identified a few important gaps in the current documentation:
- Multi-Tenant SaaS Architecture Patterns on Azure
- Azure Security Best Practices
- Azure Cost Optimization Strategies
This PR will not add new features, instead it will just add tutorials to cover these areas.
| d408f18b101f514381ab02d95ad52e81051dd248 | 0a6408f15ef55ff6ee81bd27f5f7f98903cc8cd0 | diff --git a/docs/content/tutorials/azure-cost-optimization.md b/docs/content/tutorials/azure-cost-optimization.md
new file mode 100644
index 000000000..4f52f0e8d
--- /dev/null
+++ b/docs/content/tutorials/azure-cost-optimization.md
@@ -0,0 +1,535 @@
+---
+title: "Azure Cost Optimization Strategies"
+date: 2025-01-15
+... | [
"docs/content/tutorials/azure-cost-optimization.md",
"docs/content/tutorials/azure-security-best-practices.md",
"docs/content/tutorials/multi-tenant-saas-architecture.md"
] | [] | true | ||
CompositionalIT/farmer | 1,237 | issue_to_patch | Add RollingUpgradePolicy support to VirtualMachineScaleSet
Azure's VMSS resource supports several fields inside properties.upgradePolicy.rollingUpgradePolicy [rollingUpgradePolicy ](https://learn.microsoft.com/en-us/azure/templates/microsoft.compute/2023-03-01/virtualmachinescalesets?pivots=deployment-language-arm-tem... | Virtual Machine Scale Sets: Add support for rolling upgrade policy configuration. | This PR closes #1236
The changes in this PR are as follows:
* Add support for rolling upgrade policy configuration.
I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following:
* [X] **Tested my code** end-to-end against a live Azure subscription.
* [X] **Updated the docum... | d408f18b101f514381ab02d95ad52e81051dd248 | a3332330aa5482ebc090f423dafe99c9cec28358 | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 042d2d6d8..d75b2e9c4 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -1,6 +1,9 @@
Release Notes
=============
+## 1.9.26
+* Virtual Machine Scale Sets: Add support for rolling upgrade policy configuration.
+
## 1.9.25
* Service Bus: Support for minimu... | [
"RELEASE_NOTES.md",
"docs/content/api-overview/resources/vm-scale-set.md",
"src/Farmer/Arm/Compute.fs",
"src/Farmer/Builders/Builders.VmScaleSet.fs",
"src/Tests/VmScaleSet.fs"
] | [] | diff --git a/src/Tests/VmScaleSet.fs b/src/Tests/VmScaleSet.fs
index 279cbccf8..5daee7526 100644
--- a/src/Tests/VmScaleSet.fs
+++ b/src/Tests/VmScaleSet.fs
@@ -98,6 +98,11 @@ let tests =
(vmss["zones"].ToString())
"[pickZones('Microsoft.Compute', 'virtualMachineScaleSets', resourceGro... | true |
CompositionalIT/farmer | 1,226 | issue_to_patch | Workaround to not expose user password in command line | The command line password is a bit bad habit as it could end-up to various logs, e.g. when used with Continuous Integration.
So this is a workaround that will hide the password usage.
| c898578217810c4b213a5f13d0d1bbe05c0dd6cc | 6ca2e62a49c2caaf7df456f1de8b93fbdb980ee9 | diff --git a/src/Farmer/Deploy.fs b/src/Farmer/Deploy.fs
index f95a6f3e6..3dcfe1bef 100644
--- a/src/Farmer/Deploy.fs
+++ b/src/Farmer/Deploy.fs
@@ -94,7 +94,24 @@ module Az =
/// Logs you into the Az CLI using the supplied service principal credentials.
let loginWithCredentials appId secret tenantId =
- ... | [
"src/Farmer/Deploy.fs"
] | [] | true | ||
CompositionalIT/farmer | 1,225 | issue_to_patch | Add TLS1.3, remove unsecure TLS1.0 and TLS1.1 support. | A little maintenance PR... | bcd1e2721691a94256e142dcb4c3f7b2da7c064b | 0434f16e27564d510dcade70c743f93c57c9d9a7 | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index a50d740ef..042d2d6d8 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -1,6 +1,19 @@
Release Notes
=============
+## 1.9.25
+* Service Bus: Support for minimum TLS version of 1.3.
+* Storage Accounts: Support for requesting minimum TLS version of 1.3. The... | [
"RELEASE_NOTES.md",
"src/Farmer/Arm/Cache.fs",
"src/Farmer/Arm/ServiceBus.fs",
"src/Farmer/Arm/Storage.fs",
"src/Farmer/Common.fs",
"src/Tests/Storage.fs",
"src/Tests/VirtualMachine.fs",
"src/Tests/test-data/diagnostics.json",
"src/Tests/test-data/event-grid.json",
"src/Tests/test-data/lots-of-res... | [] | diff --git a/src/Tests/Storage.fs b/src/Tests/Storage.fs
index b07f93887..a443cceb3 100644
--- a/src/Tests/Storage.fs
+++ b/src/Tests/Storage.fs
@@ -456,7 +456,7 @@ let tests =
Expect.equal
builder.WebsitePrimaryEndpoint.Value
- "reference(resourceId('Microsoft.Storage/sto... | true | |
CompositionalIT/farmer | 1,229 | issue_to_patch | Add example to documentation for granting AcrPull to the AKS SP
To grant an AKS cluster access to a container registry in the Azure CLI, the AcrPull role is granted on that container registry to the AKS kubelet identity's service principal. This needs to be documented so it's clear how to accomplish this common scenar... | Add AcrPull role assignment example for AKS with user-assigned identities | Issue #530 requested documentation for granting AKS clusters access to Azure Container Registry using the AcrPull role.
## Changes
- **Documentation**: Added "Granting AKS access to Azure Container Registry (ACR)" section to `aks-cluster.md`:
- Complete working example showing the recommended pattern with user... | c898578217810c4b213a5f13d0d1bbe05c0dd6cc | 1b6192145d681747794ee527196cc25dc3d153bc | diff --git a/docs/content/api-overview/resources/aks-cluster.md b/docs/content/api-overview/resources/aks-cluster.md
index 36a7ddf14..617c3e5b6 100644
--- a/docs/content/api-overview/resources/aks-cluster.md
+++ b/docs/content/api-overview/resources/aks-cluster.md
@@ -128,6 +128,81 @@ let myAks = aks {
)
}
```
+... | [
"docs/content/api-overview/resources/aks-cluster.md",
"src/Tests/ContainerService.fs"
] | [] | diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs
index bd93f494b..a1ccf130e 100644
--- a/src/Tests/ContainerService.fs
+++ b/src/Tests/ContainerService.fs
@@ -737,4 +737,77 @@ let tests =
Expect.equal osSKU "AzureLinux" "Incorrect osSKU value"
}
+ test "AKS clust... | true |
CompositionalIT/farmer | 1,230 | issue_to_patch | Builder privateDnsZoneVirtualNetworkLinks resource id fix | Just one minor TODO fixed. | bcd1e2721691a94256e142dcb4c3f7b2da7c064b | d23ffae49b2c24d76bd4529bbf83cb353db5a5f4 | diff --git a/src/Farmer/Builders/Builders.Dns.fs b/src/Farmer/Builders/Builders.Dns.fs
index 9a05cac81..a3600cc0b 100644
--- a/src/Farmer/Builders/Builders.Dns.fs
+++ b/src/Farmer/Builders/Builders.Dns.fs
@@ -178,7 +178,8 @@ type PrivateDnsZoneVirtualNetworkLinkConfig = {
}
]
- me... | [
"src/Farmer/Builders/Builders.Dns.fs"
] | [] | true | ||
CompositionalIT/farmer | 1,156 | issue_to_patch | Updated SQL documentation example for the new enhancements | This PR fixes the code example in the documentation for the changes in #1147
The changes in this PR are as follows:
* Updated example for AD auth set to use the new API
I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following:
* [ ] **Tested my code** end-to-end against a ... | ae6569d12a55f51930263a1ab033d9e215a40720 | f59cdf18d3dab51abd65ede75544f840e47221c1 | diff --git a/docs/content/api-overview/resources/sql.md b/docs/content/api-overview/resources/sql.md
index 0b04b7f99..e9c8065fe 100644
--- a/docs/content/api-overview/resources/sql.md
+++ b/docs/content/api-overview/resources/sql.md
@@ -120,20 +120,12 @@ template
open Farmer
open Farmer.Builders
open Sql
-open Farme... | [
"docs/content/api-overview/resources/sql.md"
] | [] | true | ||
CompositionalIT/farmer | 1,223 | issue_to_patch | Azure SQL Database VCore Type Restriction
Azure SQL Database Serverless Computer Standard-series (Gen 5) allows for VCores as low as 0.5 or 0.75, however the types are restricted as integers. See `src/Farmer/Common.fs` on line 2008. This isn't a super important bug but would be nice to scale to lower than 1 if possibl... | Support fractional VCores for Azure SQL Database Serverless | This PR closes #1205
The changes in this PR are as follows:
* Changed `S_Gen5` capacity parameters from `int` to `float` in `src/Farmer/Common.fs` to support fractional VCores (0.5, 0.75)
* Maintained backward compatibility - F# automatically converts integer literals to float, so existing code continues to work... | 31470da33b8e945a163b3b4e97a4cdc96871f795 | 23e65eadc573f5f0640037b1e7092225b9210dbb | diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 80579c185..a50d740ef 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -3,6 +3,7 @@ Release Notes
## 1.9.24
* Service Bus: Add validation for SKU-specific features (topics not supported on Basic SKU, max message size only supported on Premium SKU).
+* SQL... | [
"RELEASE_NOTES.md",
"docs/content/api-overview/resources/sql.md",
"samples/scripts/sqlserver.fsx",
"src/Farmer/Common.fs",
"src/Tests/Sql.fs"
] | [
{
"comment": "@copilot this would be a breaking change for anyone that currently specifies it as an integer. How can this be supported without causing breakage?",
"path": "src/Farmer/Common.fs",
"hunk": "@@ -2005,7 +2005,7 @@ module Sql =\n | Gen5_32\n | Gen5_40\n | Gen5_80\n- ... | diff --git a/src/Tests/Sql.fs b/src/Tests/Sql.fs
index 9ec43c4d0..f61c8e568 100644
--- a/src/Tests/Sql.fs
+++ b/src/Tests/Sql.fs
@@ -304,6 +304,42 @@ let tests =
"Incorrect autoPauseDelay"
}
+ test "Serverless sql supports fractional VCores (0.5 and 0.75)" {
+ let sql = sql... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.