repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
CompositionalIT/farmer
1,223
comment_to_fix
Support fractional VCores for Azure SQL Database Serverless
@copilot this would be a breaking change for anyone that currently specifies it as an integer. How can this be supported without causing breakage?
31470da33b8e945a163b3b4e97a4cdc96871f795
23e65eadc573f5f0640037b1e7092225b9210dbb
diff --git a/src/Farmer/Common.fs b/src/Farmer/Common.fs index 3ad44478a..760e3e692 100644 --- a/src/Farmer/Common.fs +++ b/src/Farmer/Common.fs @@ -2022,7 +2022,7 @@ module Sql = | Gen5_32 | Gen5_40 | Gen5_80 - | S_Gen5 of CapacityMin: int * CapacityMax: int + | S_Gen5 of Capac...
[ "src/Farmer/Common.fs" ]
[ { "comment": "@copilot this would be a breaking change for anyone that currently specifies it as an integer. How can this be supported without causing breakage?", "path": "src/Farmer/Common.fs", "hunk": "@@ -2005,7 +2005,7 @@ module Sql =\n | Gen5_32\n | Gen5_40\n | Gen5_80\n- ...
true
CompositionalIT/farmer
1,228
issue_to_patch
Copilot needs to follow PR template and format source with fantomas. Every PR so far, I have to ask Copilot to do this. Can something be updated in the repository to give it these hints automatically?
Add GitHub Copilot instructions for PR template and Fantomas formatting
## Plan: Add GitHub Copilot instructions for PR template and Fantomas formatting - [x] Explore repository structure and understand requirements - [x] Create `.github/copilot-instructions.md` with instructions about: - Following the PR template format - Running Fantomas to format F# code before committing - Adher...
027c933b50aa6f72e0cb021646624dcec73a54b6
45be97d4659c86fb266e0e8154f6b6dae872d32f
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md new file mode 100644 index 000000000..afab35f73 --- /dev/null +++ b/.github/copilot-instructions.md @@ -0,0 +1,105 @@ +# GitHub Copilot Instructions for Farmer Repository + +## Pull Request Requirements + +When creating or updating pull requ...
[ ".github/copilot-instructions.md" ]
[ { "comment": "You can generally assume it will be in the next release based off the GitHub releases. Once the PR milestone is set, it will confirm what release the PR should be under in the release notes. @copilot ", "path": ".github/copilot-instructions.md", "hunk": "@@ -0,0 +1,101 @@\n+# GitHub Copilo...
true
CompositionalIT/farmer
1,224
issue_to_patch
Service Bus builder needs validation improvements Some features of Service Bus are only available on certain SKUs. The resource provider doesn't always do this validation or give useful error messages, so if Farmer can tell a feature is incompatible with the requested SKU, it should raise an error. * Topics are not...
Add SKU validation for Service Bus topics and max message size
This PR closes #1110 The changes in this PR are as follows: * Add validation to prevent adding topics to Service Bus namespaces with Basic SKU (not supported by Azure) * Add validation to ensure max message size for topics is only set on Premium SKU (not supported on Basic/Standard) * Add 4 new tests to verify the va...
027c933b50aa6f72e0cb021646624dcec73a54b6
72ce57aa89c723c6d23218c5a969cc513a0bd3df
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 0b8d262ea..80579c185 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,6 +2,7 @@ Release Notes ============= ## 1.9.24 +* Service Bus: Add validation for SKU-specific features (topics not supported on Basic SKU, max message size only supported on Premi...
[ "RELEASE_NOTES.md", "src/Farmer/Builders/Builders.ServiceBus.fs", "src/Tests/EventGrid.fs", "src/Tests/ServiceBus.fs" ]
[]
diff --git a/src/Tests/EventGrid.fs b/src/Tests/EventGrid.fs index b31ea7f98..4444b07ad 100644 --- a/src/Tests/EventGrid.fs +++ b/src/Tests/EventGrid.fs @@ -127,6 +127,7 @@ let tests = let bus = serviceBus { name "busbus" + sku ServiceBus.Standard add_topi...
true
CompositionalIT/farmer
1,222
issue_to_patch
Setting deleteOption for VM It would be helpful to be able to set the deleteOption on VM disks, NICs, and IP Address so they will automatically be removed when the VM itself is deleted.
Add deleteOption support for VM disks, NICs, and public IPs
## Summary Added support for setting the `deleteOption` property on VM resources (disks, network interfaces, and public IP addresses) to enable automatic cleanup when a VM is deleted from Azure. ## Changes Made ### New Types - Added `DeleteOption` type with `Delete` and `Detach` options (single unified type for all r...
dceefc2b8a38ff03d805f30012dbd8964b592f6f
caf06a64d097267333914680ecc7988625717c01
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 50251b359..0b8d262ea 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,12 @@ Release Notes ============= +## 1.9.24 +* Virtual Machines: Added support for `deleteOption` on VM disks, NICs, and public IP addresses to automatically clean up resource...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/virtual-machine.md", "samples/scripts/vm-delete-option.fsx", "src/Farmer/Arm/Compute.fs", "src/Farmer/Arm/Network.fs", "src/Farmer/Builders/Builders.NetworkInterface.fs", "src/Farmer/Builders/Builders.Vm.fs", "src/Farmer/Common.fs", "src/Tests...
[ { "comment": "@copilot usually if someone is attaching an existing disk, then their infra workflow is to reuse the same disk, meaning they probably will not want to delete it. This goes for both OS and data disks. We should keep the existing discriminated union cases for when they don't want to delete it and it...
diff --git a/src/Tests/VirtualMachine.fs b/src/Tests/VirtualMachine.fs index 2207ff3db..32ced47ae 100644 --- a/src/Tests/VirtualMachine.fs +++ b/src/Tests/VirtualMachine.fs @@ -1263,4 +1263,305 @@ let tests = Expect.equal (string publicIpSku) "Standard" "Public IP SKU should be 'Standard'." } + ...
true
CompositionalIT/farmer
1,215
issue_to_patch
Basic WebApp supports VNET integration
Addresses #1216
ee25d105abf8ebfbb2b9e3a46d02f7901a1e029d
c47b2db3de3257651159734b8ff40f5a9d028b82
diff --git a/src/Farmer/Builders/Builders.WebApp.fs b/src/Farmer/Builders/Builders.WebApp.fs index 99957c590..7c3504482 100644 --- a/src/Farmer/Builders/Builders.WebApp.fs +++ b/src/Farmer/Builders/Builders.WebApp.fs @@ -378,12 +378,11 @@ type CommonWebConfig = { | PremiumV3 _ -> () | ElasticP...
[ "src/Farmer/Builders/Builders.WebApp.fs" ]
[]
true
CompositionalIT/farmer
1,218
issue_to_patch
No option for secret store CSI driver add-on for AKS Option for secret store CSI driver add-on for AKS missing https://learn.microsoft.com/en-us/azure/aks/csi-secrets-store-driver
AKS CSI driver addon
This PR closes #1217 The changes in this PR are as follows: * Added support for Azure Key Vault provider for Secrets Store CSI Driver I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **U...
ee25d105abf8ebfbb2b9e3a46d02f7901a1e029d
9c1534904157f14812d52cb4bb89d647ba675fe8
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 732eb4485..633e3cf91 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.22 +* AKS Cluster: Added support for Azure Key Vault provider for Secrets Store CSI Driver + ## 1.9.21 * AKS Cluster: Added auto_upgr...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index db14755ec..bd93f494b 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -529,6 +529,11 @@ let tests = ApplicationGatewayId = (myAppGateway :> IBuilder).ResourceId ...
true
CompositionalIT/farmer
1,172
issue_to_patch
add aks node pool availability zones
The changes in this PR are as follows: * add aks node pool availability zones option I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the docs folder for th...
5dae58b4930583d20b684b79326ce387bc8b1692
d8d38cac390c5e8a5c003b3030101cd38d7cdf42
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index f4b785e11..701830331 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.8 +* AKS Cluster: support for node pool availability zones + ## 1.9.7 * AKS Cluster: support for Sku and Tier. Support for pod subnet...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/test-data/aks-with-acr.json" ]
[]
diff --git a/src/Tests/test-data/aks-with-acr.json b/src/Tests/test-data/aks-with-acr.json index 95cce80b9..9726627d6 100644 --- a/src/Tests/test-data/aks-with-acr.json +++ b/src/Tests/test-data/aks-with-acr.json @@ -53,6 +53,7 @@ "properties": { "agentPoolProfiles": [ { + "availab...
true
CompositionalIT/farmer
1,170
issue_to_patch
aks and agentPool builders missing important features Features missing in AKS: - tier Features missing in agentPool: - pod-subnet-id - cluster autoscaler
Aks features: SKU, pod subnet and node pool autoscaling
This PR closes #1167 The changes in this PR are as follows: * add Sku and Tier option to Aks Cluster * add pod subnet option to Agent Pool profile * add autoscale feature to Agent Pool profile I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my c...
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
a7a62640d4ee4bc8e2a7540cc9365c515633a76f
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e4cc84540..a025ede0f 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.7 +- AKS Cluster: support for Sku and Tier. Support for pod subnet in agent pool config. Support for node pool autoscaling + ## 1.9.6 ...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "samples/scripts/aks.fsx", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Farmer/Common.fs", "src/Tests/ContainerService.fs", "src/Tests/test-data/aks-with-acr.json" ]
[ { "comment": "Please use snake case for consistency in the builders: `scale_down_mode`", "path": "src/Farmer/Builders/Builders.ContainerService.fs", "hunk": "@@ -1,668 +1,735 @@\n-[<AutoOpen>]\n-module Farmer.Builders.ContainerService\n-\n-open System\n-open Farmer\n-open Farmer.Arm\n-open Farmer.Arm.Co...
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index dd60d4fe5..fc2ccf2ce 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -215,6 +215,7 @@ let tests = count 3 vnet "my-vnet" subnet "c...
true
CompositionalIT/farmer
1,169
issue_to_patch
Aks features
This PR partly closes Issue #1167: - add Sku and Tier option to Aks Cluster - add pod subnet option to Agent Pool profile The changes in this PR are as follows: * add Sku and Tier option to Aks Cluster * add pod subnet option to Agent Pool profile I have read the [contributing guidelines](CONTRIBUTING.md)...
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
c992f0658226c22191b74c31355478f2f117452b
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e4cc84540..50d7ef282 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.7 +- AKS Cluster: support for Sku and Tier. Support for pod subnet in agent pool config + ## 1.9.6 - Network Interface: Support for a...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "samples/scripts/aks.fsx", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Farmer/Common.fs", "src/Tests/ContainerService.fs", "src/Tests/test-data/aks-with-acr.json" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index dd60d4fe5..fc2ccf2ce 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -215,6 +215,7 @@ let tests = count 3 vnet "my-vnet" subnet "c...
true
CompositionalIT/farmer
1,137
issue_to_patch
Container apps using user assigned identity (MSI) for ACR authentication - template broken ### Issue No 1: Generated template for containerapp looks as below: ``` "properties": { "configuration": { "registries": [ { "identity": "[resourceId('<GUID>', 'TestMSIr...
Container Apps MSI fix
This PR closes #1136 The changes in this PR are as follows: * modify App.fs to properly generate ARM template for container registry authentication with user assigned identity: * generated "secrets" is an empty array I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the followi...
b4f158196759b49940638a8d8e8d0637805da204
96202e18fa9185381517119fb0b506528e7ca0df
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index ef84faf50..7e81257fc 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.2 +* Container Apps: Fix to container registry credential to not emit a secret for a managed identity. + ## 1.9.1 * Managed Clusters ...
[ "RELEASE_NOTES.md", "src/Farmer/Arm/App.fs" ]
[ { "comment": "This line should stay here so that MSI's defined in the same template will be deployed before this ContainerApp. If you're assigning an existing user assigned identity, use `link_to_identity` instead of `add_identity` and then the dependency won't be emitted here.", "path": "src/Farmer/Arm/App...
true
CompositionalIT/farmer
1,137
comment_to_fix
Container Apps MSI fix
This line should stay here so that MSI's defined in the same template will be deployed before this ContainerApp. If you're assigning an existing user assigned identity, use `link_to_identity` instead of `add_identity` and then the dependency won't be emitted here.
b4f158196759b49940638a8d8e8d0637805da204
96202e18fa9185381517119fb0b506528e7ca0df
diff --git a/src/Farmer/Arm/App.fs b/src/Farmer/Arm/App.fs index 20bb1b9c2..dcb613cc6 100644 --- a/src/Farmer/Arm/App.fs +++ b/src/Farmer/Arm/App.fs @@ -215,13 +215,7 @@ type ContainerApp = { ) .Eval() ...
[ "src/Farmer/Arm/App.fs" ]
[ { "comment": "This line should stay here so that MSI's defined in the same template will be deployed before this ContainerApp. If you're assigning an existing user assigned identity, use `link_to_identity` instead of `add_identity` and then the dependency won't be emitted here.", "path": "src/Farmer/Arm/App...
true
CompositionalIT/farmer
1,213
issue_to_patch
AKS Cluster: Added auto_upgrade_profile option for managed clusters
The changes in this PR are as follows: * AKS Cluster: Added auto_upgrade_profile option for managed clusters I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** i...
07a06fc0c5bce200998f84685ea076ba4593c9ff
35648a380b4eaccaf53c4996d38ea2d22b1d1043
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 3707cecf0..732eb4485 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,6 +2,7 @@ Release Notes ============= ## 1.9.21 +* AKS Cluster: Added auto_upgrade_profile option for managed clusters * AKS Cluster: Added os_sku option for agentPool config ##...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Farmer/Common.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index f3419df9b..db14755ec 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -658,7 +658,35 @@ let tests = "app" "azureMonitorProfile.metrics.kubeStateMetrics.metricLabelsAllowLis...
true
CompositionalIT/farmer
1,212
issue_to_patch
AKS Cluster: Add os_sku option for agent pool config
The changes in this PR are as follows: * Add os_sku option to agent pool config I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the docs folder for the aff...
68771cbaf60d29a2cea81174df8df65c87e4418e
523ee3e63914a8ba1eefc37cd960c53122093c09
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 8ea85cb7c..3707cecf0 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.21 +* AKS Cluster: Added os_sku option for agentPool config + ## 1.9.20 * Data Collection: Fixes bug in data collection association b...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index 98d89e355..f3419df9b 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -658,4 +658,30 @@ let tests = "app" "azureMonitorProfile.metrics.kubeStateMetrics.metricLabelsAllowLis...
true
CompositionalIT/farmer
1,211
issue_to_patch
Remove Location Field in Data Rule Collection Association Template
This PR closes # The changes in this PR are as follows: * Removes the location property in the data rule collection association builder since that's not a property that exists in the arm template. I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [ ] **Tested my...
94901ce08a7a511d3d740bce03fd203e57237f93
fcfc1e9d1b22e40ad74cfddce9436da038ffb47b
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 91a4602fd..8ea85cb7c 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.20 +* Data Collection: Fixes bug in data collection association by removing location field. + ## 1.9.19 * Data Collection: Adds `data...
[ "RELEASE_NOTES.md", "src/Farmer/Arm/Monitor.fs", "src/Farmer/Builders/Builders.AzureMonitor.fs", "src/Tests/DataCollection.fs" ]
[]
diff --git a/src/Tests/DataCollection.fs b/src/Tests/DataCollection.fs index c91c43247..8e6e3492b 100644 --- a/src/Tests/DataCollection.fs +++ b/src/Tests/DataCollection.fs @@ -153,6 +153,14 @@ let tests = .SelectToken("resources[?(@.name=='myRuleAssociation')].properties.dataCollectionRuleId") ...
true
CompositionalIT/farmer
1,210
issue_to_patch
NAT Gateways: set the SKU of NAT Gateway to deploy.
The changes in this PR are as follows: * NAT Gateways: set the SKU of NAT Gateway to deploy. I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the docs folde...
7ae5202335399c973413f8394594cf0c19ba989b
3d9c0ef959ef88f4d889f940bf42a356ed99c440
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index fd7c013ec..91a4602fd 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,13 +1,14 @@ Release Notes ============= -## 1.9.18 +## 1.9.19 * Data Collection: Adds `dataCollectionRule`, `dataCollectionEndpoint`, `dataCollectionRuleAssociation` builders for A...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/nat-gateway.md", "src/Farmer/Arm/Network.fs", "src/Farmer/Builders/Builders.NatGateway.fs", "src/Farmer/Common.fs", "src/Tests/Network.fs", "src/Tests/test-data/load-balancer.json", "src/Tests/test-data/lots-of-resources.json", "src/Tests/test...
[ { "comment": "The `open Farmer.Storage` import appears to be unrelated to the NAT Gateway SKU changes and may have been added accidentally. This import is not used in the visible changes and should be removed.\n```suggestion\n\n```", "path": "src/Farmer/Arm/Network.fs", "hunk": "@@ -1,13 +1,12 @@\n [<Au...
diff --git a/src/Tests/Network.fs b/src/Tests/Network.fs index 4f64c0568..cc5a61bd0 100644 --- a/src/Tests/Network.fs +++ b/src/Tests/Network.fs @@ -696,6 +696,40 @@ let tests = Expect.isFalse (defaultOutbound.ToObject<bool>()) "defaultOutboundAccess should be false" } + test "Creates V2 ...
true
CompositionalIT/farmer
1,210
comment_to_fix
NAT Gateways: set the SKU of NAT Gateway to deploy.
The `open Farmer.Storage` import appears to be unrelated to the NAT Gateway SKU changes and may have been added accidentally. This import is not used in the visible changes and should be removed. ```suggestion ```
7ae5202335399c973413f8394594cf0c19ba989b
3d9c0ef959ef88f4d889f940bf42a356ed99c440
diff --git a/src/Farmer/Arm/Network.fs b/src/Farmer/Arm/Network.fs index 9e5f54c06..a14ddb4b4 100644 --- a/src/Farmer/Arm/Network.fs +++ b/src/Farmer/Arm/Network.fs @@ -1,9 +1,7 @@ [<AutoOpen>] module Farmer.Arm.Network -open System.Net.Mail open Farmer -open Farmer.Arm open Farmer.ExpressRoute open Farmer.Netwo...
[ "src/Farmer/Arm/Network.fs" ]
[ { "comment": "The `open Farmer.Storage` import appears to be unrelated to the NAT Gateway SKU changes and may have been added accidentally. This import is not used in the visible changes and should be removed.\n```suggestion\n\n```", "path": "src/Farmer/Arm/Network.fs", "hunk": "@@ -1,13 +1,12 @@\n [<Au...
true
CompositionalIT/farmer
1,208
issue_to_patch
Support Azure Monitor Data Collection Rules and Promethus Rules Groups for AKS Would like to be able to enable Azure Monitor capabilities on AKS: https://learn.microsoft.com/en-us/azure/azure-monitor/containers/kubernetes-monitoring-enable?tabs=cli#aks-cluster. In addition to adding incident receivers for our action g...
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
This PR closes #1209 The changes in this PR are as follows: * Adds data collection endpoints and data collection rules * Adds prometheus rule group and prometheus rules * Adds flag to enable azure monitor in aks builder I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the foll...
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 94c3a3131..2334f0dda 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,12 @@ Release Notes ============= +## 1.9.18 +* Data Collection: Adds `dataCollectionRule`, `dataCollectionEndpoint`, `dataCollectionRuleAssociation` builders for Azure Monitor...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/action-group.md", "docs/content/api-overview/resources/aks-cluster.md", "docs/content/api-overview/resources/data-collection.md", "docs/content/api-overview/resources/prometheus-rule-group.md", "src/Farmer/Arm/ActionGroup.fs", "src/Farmer/Arm/Aler...
[ { "comment": "The API version string has an extra single quote at the end: \"2023-03-11'\" should be \"2023-03-11\"\n```suggestion\n ResourceType(\"Microsoft.Insights/dataCollectionRules\", \"2023-03-11\")\n```", "path": "src/Farmer/Arm/Monitor.fs", "hunk": "@@ -0,0 +1,175 @@\n+[<AutoOpen>]\n+module ...
diff --git a/src/Tests/ActionGroup.fs b/src/Tests/ActionGroup.fs index 33f6c1e1e..d054c7f9b 100644 --- a/src/Tests/ActionGroup.fs +++ b/src/Tests/ActionGroup.fs @@ -88,6 +88,17 @@ let tests = let myWebhookReceiver = WebhookReceiver.Create(name = "...", serviceUri = uri) + let myIncidentRecei...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
The API version string has an extra single quote at the end: "2023-03-11'" should be "2023-03-11" ```suggestion ResourceType("Microsoft.Insights/dataCollectionRules", "2023-03-11") ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/Monitor.fs b/src/Farmer/Arm/Monitor.fs new file mode 100644 index 000000000..26e0cc101 --- /dev/null +++ b/src/Farmer/Arm/Monitor.fs @@ -0,0 +1,175 @@ +[<AutoOpen>] +module Farmer.Arm.Monitor + +open Farmer + +let dataCollectionEndpoints = + ResourceType("Microsoft.Insights/dataCollection...
[ "src/Farmer/Arm/Monitor.fs" ]
[ { "comment": "The API version string has an extra single quote at the end: \"2023-03-11'\" should be \"2023-03-11\"\n```suggestion\n ResourceType(\"Microsoft.Insights/dataCollectionRules\", \"2023-03-11\")\n```", "path": "src/Farmer/Arm/Monitor.fs", "hunk": "@@ -0,0 +1,175 @@\n+[<AutoOpen>]\n+module ...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
The interface implementation should be for DataCollectionRuleAssociationConfig, not DataCollectionRuleConfig, as this is within the DataCollectionRuleAssociationBuilder class. ```suggestion interface IDependable<DataCollectionRuleAssociationConfig> with ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Builders/Builders.AzureMonitor.fs b/src/Farmer/Builders/Builders.AzureMonitor.fs new file mode 100644 index 000000000..3cc8cea49 --- /dev/null +++ b/src/Farmer/Builders/Builders.AzureMonitor.fs @@ -0,0 +1,237 @@ +[<AutoOpen>] +module Farmer.Builders.AzureMonitor + +open Farmer +open Farmer.Arm +...
[ "src/Farmer/Builders/Builders.AzureMonitor.fs" ]
[ { "comment": "The interface implementation should be for DataCollectionRuleAssociationConfig, not DataCollectionRuleConfig, as this is within the DataCollectionRuleAssociationBuilder class.\n```suggestion\n interface IDependable<DataCollectionRuleAssociationConfig> with\n```", "path": "src/Farmer/Builder...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
Please use PascalCase rather than camelCase for these record fields, just to follow the same convention as the rest of the code.
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs index f8ba11da5..0dd1d22c3 100644 --- a/src/Farmer/Arm/ActionGroup.fs +++ b/src/Farmer/Arm/ActionGroup.fs @@ -222,6 +222,28 @@ type WebhookReceiver = { useCommonAlertSchema = useCommonAlertSchema } +type IncidentServiceConnection...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use PascalCase rather than camelCase for these record fields, just to follow the same convention as the rest of the code.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -222,6 +222,28 @@ type WebhookReceiver = {\n useCommonAlertSchema = useCommonAlertSchema\n }\n...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
This can be simplified to just the following: ```fsharp |> Option.map (List.map _.ToArmJson) ``` There are lots of lambdas that could be removed with this, but I mainly would recommend this for the ones that can remove significant noise like this.
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "This can be simplified to just the following:\r\n```fsharp\r\n|> Option.map (List.map _.ToArmJson)\r\n```\r\nThere are lots of lambdas that could be removed with this, but I mainly would recommend this for the ones that can remove significant noise like this.", "path": "src/Farmer/Arm/AlertsMa...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
You can remove the lambda here, like this: ```fsharp enabled = rule.Enabled |> Option.map _.AsBoolean ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "You can remove the lambda here, like this:\r\n```fsharp\r\nenabled = rule.Enabled |> Option.map _.AsBoolean\r\n```", "path": "src/Farmer/Arm/AlertsManagement.fs", "hunk": "@@ -0,0 +1,128 @@\n+[<AutoOpen>]\n+module Farmer.Arm.AlertsManagement\n+\n+open Farmer\n+\n+let prometheusRuleGroups =...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
Also can simplify this to ```fsharp |> Option.map _.ToArmJson ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "Also can simplify this to\r\n```fsharp\r\n|> Option.map _.ToArmJson\r\n```", "path": "src/Farmer/Arm/AlertsManagement.fs", "hunk": "@@ -0,0 +1,128 @@\n+[<AutoOpen>]\n+module Farmer.Arm.AlertsManagement\n+\n+open Farmer\n+\n+let prometheusRuleGroups =\n+ ResourceType(\"Microsoft.AlertsMa...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
This can simplify with ```fsharp Set.map _.Eval() ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "This can simplify with\r\n```fsharp\r\nSet.map _.Eval()\r\n```", "path": "src/Farmer/Arm/AlertsManagement.fs", "hunk": "@@ -0,0 +1,128 @@\n+[<AutoOpen>]\n+module Farmer.Arm.AlertsManagement\n+\n+open Farmer\n+\n+let prometheusRuleGroups =\n+ ResourceType(\"Microsoft.AlertsManagement/pro...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
This will be a little clearer as ```fsharp |> Option.map (function | IsoDateTime x -> x) ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "This will be a little clearer as\r\n```fsharp\r\n|> Option.map (function | IsoDateTime x -> x)\r\n```", "path": "src/Farmer/Arm/AlertsManagement.fs", "hunk": "@@ -0,0 +1,128 @@\n+[<AutoOpen>]\n+module Farmer.Arm.AlertsManagement\n+\n+open Farmer\n+\n+let prometheusRuleGroups =\n+ Resour...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
This simplifies to ```fsharp rules = this.Rules |> List.map PrometheusRule.ToArmJson ```
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Arm/AlertsManagement.fs b/src/Farmer/Arm/AlertsManagement.fs new file mode 100644 index 000000000..fdd043622 --- /dev/null +++ b/src/Farmer/Arm/AlertsManagement.fs @@ -0,0 +1,127 @@ +[<AutoOpen>] +module Farmer.Arm.AlertsManagement + +open Farmer + +let prometheusRuleGroups = + ResourceType("...
[ "src/Farmer/Arm/AlertsManagement.fs" ]
[ { "comment": "This simplifies to\r\n```fsharp\r\nrules = this.Rules |> List.map PrometheusRule.ToArmJson\r\n```", "path": "src/Farmer/Arm/AlertsManagement.fs", "hunk": "@@ -0,0 +1,128 @@\n+[<AutoOpen>]\n+module Farmer.Arm.AlertsManagement\n+\n+open Farmer\n+\n+let prometheusRuleGroups =\n+ ResourceTy...
true
CompositionalIT/farmer
1,208
comment_to_fix
Support Ability to Enable Azure Monitor on AKS and Populate Prometheus Rules
Same here, doesn't this default to deploying a disabled rule group if they didn't specifically enable it?
3b76eb39be6fc400089be1abbdeaa55d52d49e37
73506b86256f26f3547ef6243684eedb2eb2bd38
diff --git a/src/Farmer/Builders/Builders.AlertsManagement.fs b/src/Farmer/Builders/Builders.AlertsManagement.fs new file mode 100644 index 000000000..44886a1b0 --- /dev/null +++ b/src/Farmer/Builders/Builders.AlertsManagement.fs @@ -0,0 +1,199 @@ +[<AutoOpen>] +module Farmer.Builders.AlertsManagement + +open Farmer +o...
[ "src/Farmer/Builders/Builders.AlertsManagement.fs" ]
[ { "comment": "Same here, doesn't this default to deploying a disabled rule group if they didn't specifically enable it?", "path": "src/Farmer/Builders/Builders.AlertsManagement.fs", "hunk": "@@ -0,0 +1,199 @@\n+[<AutoOpen>]\n+module Farmer.Builders.AlertsManagement\n+\n+open Farmer\n+open Farmer.Arm\n+\...
true
CompositionalIT/farmer
1,196
issue_to_patch
Container Apps Builder Outdated - Adding Key Vault Secret References Hey Farmer folks, I've noticed that the container apps builder is still using Api Version 2022-03-01. I noticed this when I was looking to create container app secrets that reference secrets in a KeyVault. This was added to ARM templates in [2022-1...
Referencing Key Vault Secrets when creating Container App Secrets
Still working on the below PR. This is my first time contributing to Farmer, so please let me know if the pattern I've established is consistent with the project. I wanted to get this PR started so that no one else also starts working on this issue. I'm still working on getting the minimal example configuration working...
0c54fd74baf11936ce85c9d2e6f9a283a10ce5be
97cd68d42a9cc72eb3b5dcb90f9b3da12cbecce8
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 5f8f69ce5..94c3a3131 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,6 +2,7 @@ Release Notes ============= ## 1.9.17 +* Container Apps: Adds `add_key_vault_secret` allowing Container App secrets to reference secrets stored in Azure Key Vault. * AKS:...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/container-apps.md", "src/Farmer/Arm/App.fs", "src/Farmer/Arm/ContainerInstance.fs", "src/Farmer/Arm/DeploymentScript.fs", "src/Farmer/Arm/KeyVault.fs", "src/Farmer/Builders/Builders.ContainerApps.fs", "src/Farmer/Builders/Builders.KeyVault.fs", ...
[ { "comment": "Suggestion - name this something other than `ref` just because it is [a language keyword](https://learn.microsoft.com/dotnet/fsharp/language-reference/reference-cells), albeit less often used these days.", "path": "src/Farmer/Arm/ContainerInstance.fs", "hunk": "@@ -313,6 +315,11 @@ type Co...
diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs index 8d24a196a..9c6b51355 100644 --- a/src/Tests/ContainerApps.fs +++ b/src/Tests/ContainerApps.fs @@ -9,9 +9,13 @@ open Farmer.ContainerApp open Farmer.Identity open Farmer.Arm -let msi = createUserAssignedIdentity "appUser" +let identityName = ...
true
CompositionalIT/farmer
1,206
issue_to_patch
Add Ability To Specify Kubernetes Version
This PR closes # (no corresponding issue) The changes in this PR are as follows: * The AksConfig has been updated to include a `kubernetes_version` parameter. This can be specified as a string or the stronger `KubernetesVersion` type: ``` type KubernetesVersion = { Major: int Minor: int //Lates...
3500fa102c18945288db8fa78c55f72c27750f30
b33ec86c967cf3b059f229744674896ec4ea59f7
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 43ebd037b..5f8f69ce5 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.17 +* AKS: add ability to specify `kubernetes_version` parameter + ## 1.9.16 * AKS: add node_resource_group parameter to aks config ...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index 02dbc60c9..4dbb69d5d 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -1,6 +1,7 @@ module ContainerService open Expecto +open Farmer.Arm open Farmer.Arm.ContainerService.AddonProfiles open Farmer.Arm....
true
CompositionalIT/farmer
1,204
issue_to_patch
AKS: add node_resource_group to aks config
This PR closes # The changes in this PR are as follows: * AKS: add node_resource_group to aks config I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the...
c90a3f0bf032555e895ffd72e5473f606c375076
0540e21ae77e282a79be2ad8030842c8f44cf97e
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 4691d4c7a..43ebd037b 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.16 +* AKS: add node_resource_group parameter to aks config + ## 1.9.15 * Container Apps: Adds health probes. * AKS: Add node_taints ...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[ { "comment": "You probably want this to accept a string rather than a `ResourceName`, and then create the `ResourceName` in the operation itself\r\n\r\n`state with NodeResourceGroup = Some(ResourceName(name))`", "path": "src/Farmer/Builders/Builders.ContainerService.fs", "hunk": "@@ -485,6 +488,13 @@ ty...
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index 00fae32ee..02dbc60c9 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -411,6 +411,31 @@ let tests = Expect.equal firstNodeTaint "CriticalAddonsOnly=true:NoSchedule" "Incorrect nodeTaint value...
true
CompositionalIT/farmer
1,201
issue_to_patch
Health probes for Azure container apps It doesn't look like Health probes can be set for ACA, I have looked at the source code but couldn't figure it out. I think it would be good if this could be added.
Container app probes
This PR closes #1194 The changes in this PR are as follows: * Adds support for container app probes I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the...
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index b8741d84b..4691d4c7a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,7 +2,7 @@ Release Notes ============= ## 1.9.15 - +* Container Apps: Adds health probes. * AKS: Add node_taints parameter to agent pool config. ## 1.9.14 diff --git a/docs/conte...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/container-apps.md", "src/Farmer/Arm/App.fs", "src/Farmer/Builders/Builders.ContainerApps.fs", "src/Farmer/Common.fs", "src/Tests/ContainerApps.fs" ]
[ { "comment": "Using 'Expect.isGreaterThanOrEqual' for comparing probe.Protocol may not correctly validate equality. Consider replacing it with 'Expect.equal' for a precise comparison.\n```suggestion\n Expect.equal probe.Protocol ProbeProtocol.HTTPS \"Incorrect probe protocol\"\n```", "path": "src...
diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs index 1cb78c9be..8d24a196a 100644 --- a/src/Tests/ContainerApps.fs +++ b/src/Tests/ContainerApps.fs @@ -1,5 +1,6 @@ module ContainerApps +open System open Expecto open Farmer open Farmer.Builders @@ -41,6 +42,7 @@ let fullContainerAppDeployment ...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
Using 'Expect.isGreaterThanOrEqual' for comparing probe.Protocol may not correctly validate equality. Consider replacing it with 'Expect.equal' for a precise comparison. ```suggestion Expect.equal probe.Protocol ProbeProtocol.HTTPS "Incorrect probe protocol" ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs index 1cb78c9be..8d24a196a 100644 --- a/src/Tests/ContainerApps.fs +++ b/src/Tests/ContainerApps.fs @@ -1,5 +1,6 @@ module ContainerApps +open System open Expecto open Farmer open Farmer.Builders @@ -41,6 +42,7 @@ let fullContainerAppDeployment ...
[ "src/Tests/ContainerApps.fs" ]
[ { "comment": "Using 'Expect.isGreaterThanOrEqual' for comparing probe.Protocol may not correctly validate equality. Consider replacing it with 'Expect.equal' for a precise comparison.\n```suggestion\n Expect.equal probe.Protocol ProbeProtocol.HTTPS \"Incorrect probe protocol\"\n```", "path": "src...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
The route assertion uses 'Expect.isGreaterThanOrEqual' which may not confirm an exact match. Replace it with 'Expect.equal' to ensure the route is precisely '/api/healthcheck'. ```suggestion Expect.equal (probe.Route.ToString()) "/api/healthcheck" "Incorrect probe route" ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs index 1cb78c9be..8d24a196a 100644 --- a/src/Tests/ContainerApps.fs +++ b/src/Tests/ContainerApps.fs @@ -1,5 +1,6 @@ module ContainerApps +open System open Expecto open Farmer open Farmer.Builders @@ -41,6 +42,7 @@ let fullContainerAppDeployment ...
[ "src/Tests/ContainerApps.fs" ]
[ { "comment": "The route assertion uses 'Expect.isGreaterThanOrEqual' which may not confirm an exact match. Replace it with 'Expect.equal' to ensure the route is precisely '/api/healthcheck'.\n```suggestion\n Expect.equal (probe.Route.ToString()) \"/api/healthcheck\" \"Incorrect probe route\"\n```", ...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
Using 'Expect.isGreaterThanOrEqual' for port comparison may introduce ambiguity. Consider using 'Expect.equal' to assert that the probe port is exactly 443. ```suggestion Expect.equal probe.Port 443 "Incorrect probe port" ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/src/Tests/ContainerApps.fs b/src/Tests/ContainerApps.fs index 1cb78c9be..8d24a196a 100644 --- a/src/Tests/ContainerApps.fs +++ b/src/Tests/ContainerApps.fs @@ -1,5 +1,6 @@ module ContainerApps +open System open Expecto open Farmer open Farmer.Builders @@ -41,6 +42,7 @@ let fullContainerAppDeployment ...
[ "src/Tests/ContainerApps.fs" ]
[ { "comment": "Using 'Expect.isGreaterThanOrEqual' for port comparison may introduce ambiguity. Consider using 'Expect.equal' to assert that the probe port is exactly 443.\n```suggestion\n Expect.equal probe.Port 443 \"Incorrect probe port\"\n```", "path": "src/Tests/ContainerApps.fs", "hunk":...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
```suggestion | set_probe | Adds a health probe of the given type, with the given protocol, at the given route, with the given port | ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/docs/content/api-overview/resources/container-apps.md b/docs/content/api-overview/resources/container-apps.md index 8dfb90974..25d7633ad 100644 --- a/docs/content/api-overview/resources/container-apps.md +++ b/docs/content/api-overview/resources/container-apps.md @@ -88,6 +88,7 @@ The Container builder (`c...
[ "docs/content/api-overview/resources/container-apps.md" ]
[ { "comment": "```suggestion\r\n| set_probe | Adds a health probe of the given type, with the given protocol, at the given route, with the given port |\r\n```", "path": "docs/content/api-overview/resources/container-apps.md", "hunk": "@@ -88,6 +88,7 @@ The Container builder (`container`) is used to defin...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
```suggestion ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/src/Farmer/Arm/App.fs b/src/Farmer/Arm/App.fs index dcb613cc6..128461ba4 100644 --- a/src/Farmer/Arm/App.fs +++ b/src/Farmer/Arm/App.fs @@ -19,6 +19,21 @@ let daprComponents = open Farmer.ContainerAppValidation open Farmer.Identity +type HealthProbe = + | Liveness + | Readiness + | Startup + +...
[ "src/Farmer/Arm/App.fs" ]
[ { "comment": "```suggestion\r\n```", "path": "src/Farmer/Arm/App.fs", "hunk": "@@ -19,6 +19,23 @@ let daprComponents =\n open Farmer.ContainerAppValidation\n open Farmer.Identity\n \n+", "resolving_sha": "c3906265b90a84b8d1ef432a7def40e316e65643", "resolving_diff": "diff --git a/src/Farmer/Arm/A...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
```suggestion ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/src/Farmer/Arm/App.fs b/src/Farmer/Arm/App.fs index dcb613cc6..128461ba4 100644 --- a/src/Farmer/Arm/App.fs +++ b/src/Farmer/Arm/App.fs @@ -19,6 +19,21 @@ let daprComponents = open Farmer.ContainerAppValidation open Farmer.Identity +type HealthProbe = + | Liveness + | Readiness + | Startup + +...
[ "src/Farmer/Arm/App.fs" ]
[ { "comment": "```suggestion\r\n```", "path": "src/Farmer/Arm/App.fs", "hunk": "@@ -19,6 +19,23 @@ let daprComponents =\n open Farmer.ContainerAppValidation\n open Farmer.Identity\n \n+\n+type HealthProbe =\n+ | Liveness\n+ | Readiness\n+ | Startup\n+\n+", "resolving_sha": "c3906265b90a84b8d...
true
CompositionalIT/farmer
1,201
comment_to_fix
Container app probes
```suggestion ## 1.9.15 * Add health probes for Azure Container Apps ```
a0d07f76819a3b0f86eaee7aab9118461b3dac63
c3906265b90a84b8d1ef432a7def40e316e65643
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index b8741d84b..4691d4c7a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,7 +2,7 @@ Release Notes ============= ## 1.9.15 - +* Container Apps: Adds health probes. * AKS: Add node_taints parameter to agent pool config. ## 1.9.14
[ "RELEASE_NOTES.md" ]
[ { "comment": "```suggestion\r\n## 1.9.15\r\n* Add health probes for Azure Container Apps\r\n```", "path": "RELEASE_NOTES.md", "hunk": "@@ -1,6 +1,8 @@\n Release Notes\n =============\n \n+* Add health probes for Azure Container Apps", "resolving_sha": "c3906265b90a84b8d1ef432a7def40e316e65643", ...
true
CompositionalIT/farmer
1,200
issue_to_patch
Add node_taints parameter to agent pool config
The changes in this PR are as follows: * AKS: Add node_taints parameter to agent pool config I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in the docs folde...
c030ea8531618903f6ff9de09f018a577aba4c1f
ac19541da404ee8923e9f2328f40f9b94266ef2d
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index fa8feda1f..b8741d84b 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,10 @@ Release Notes ============= +## 1.9.15 + +* AKS: Add node_taints parameter to agent pool config. + ## 1.9.14 * VMSS, AKS, Azure Firewall, Managed Clusters (AKS): Adds `...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index 7e1c0a129..00fae32ee 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -387,6 +387,30 @@ let tests = "[reference(resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', 'kubeletIdenti...
true
CompositionalIT/farmer
1,199
issue_to_patch
Remove deprecated `docker_bridge` from container services (AKS)
The changes in this PR are as follows: * AKS: Remove deprecated `docker_bridge` from container services. I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x] **Updated the documentation** in th...
d97606cffd12fbb59ace6fe958546ee163bbf26c
7b982858dafb438e4d13977e4bc18ab350217e90
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 088c041e6..fa8feda1f 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -3,6 +3,7 @@ Release Notes ## 1.9.14 * VMSS, AKS, Azure Firewall, Managed Clusters (AKS): Adds `pick_zones` to let ARM select the availability zones. +* AKS: Remove deprecated `docker_...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "samples/scripts/aks.fsx", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Farmer/Common.fs" ]
[]
true
CompositionalIT/farmer
1,198
issue_to_patch
Adds 'pick_zones' for VMSS, AKS, Firewall, and Load Balancer
The changes in this PR are as follows: * VMSS, AKS, Azure Firewall, Managed Clusters (AKS): Adds `pick_zones` to let ARM select the availability zones. I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscript...
166402e456a0830c0ae5bf0f2f1d1df9fa8fa11c
9e7748d3935de40cdc4bce3168936728f725dd05
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 2b650e860..088c041e6 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.14 +* VMSS, AKS, Azure Firewall, Managed Clusters (AKS): Adds `pick_zones` to let ARM select the availability zones. + ## 1.9.13 * Su...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "docs/content/api-overview/resources/azure-firewall.md", "docs/content/api-overview/resources/load-balancer.md", "docs/content/api-overview/resources/vm-scale-set.md", "src/Farmer/Arm/AzureFirewall.fs", "src/Farmer/Arm/Compute.fs"...
[]
diff --git a/src/Tests/LoadBalancer.fs b/src/Tests/LoadBalancer.fs index 5dd488b14..e0ef4a82c 100644 --- a/src/Tests/LoadBalancer.fs +++ b/src/Tests/LoadBalancer.fs @@ -99,7 +99,7 @@ let tests = add_backend_pools [ backendAddressPool { name "lb-backend" - ...
true
CompositionalIT/farmer
1,058
issue_to_patch
Add new resource type action groups
This PR closes # The changes in this PR are as follows: * Adds ActionGroups resource type * Adds ActionGroups documentation * Adds ActionGroups unit tests I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure s...
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index f4764d6c4..73aabaf30 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,8 @@ Release Notes ============= + ## 1.7.27 +* Action Groups: Adds support for action groups to perform actions when alerts fire. * Functions: Add the correct netFrameworkVers...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/action-group.md", "src/Farmer/Arm/ActionGroup.fs", "src/Farmer/Arm/AutomationAccount.fs", "src/Farmer/Arm/Webhook.fs", "src/Farmer/Builders/Builders.ActionGroup.fs", "src/Farmer/Builders/Builders.Alert.fs", "src/Farmer/Farmer.fsproj", "src/Tes...
[ { "comment": "Please follow the convention to pluralize this as `actionGroups`. It's plural in the Azure resource and so we've followed that convention. You can look on most any resource, but [azureFirewalls](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/Arm/...
diff --git a/src/Tests/ActionGroup.fs b/src/Tests/ActionGroup.fs new file mode 100644 index 000000000..1f9ac8237 --- /dev/null +++ b/src/Tests/ActionGroup.fs @@ -0,0 +1,145 @@ +module ActionGroup + +open Expecto +open Farmer +open Farmer.Insights +open Farmer.Arm.ActionGroups +open Farmer.Arm.AutomationAccounts +open ...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please follow the convention to pluralize this as `actionGroups`. It's plural in the Azure resource and so we've followed that convention. You can look on most any resource, but [azureFirewalls](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/Arm/AzureFirewall.fs#L9) f...
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please follow the convention to pluralize this as `actionGroups`. It's plural in the Azure resource and so we've followed that convention. You can look on most any resource, but [azureFirewalls](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/Arm/...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
The predefined roles are in [IdentityExtensions](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/IdentityExtensions.fs#L35). Can you please use those instead of redefining a subset of them here?
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "The predefined roles are in [IdentityExtensions](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/IdentityExtensions.fs#L35). Can you please use those instead of redefining a subset of them here?", "path": "src/Farmer/Arm/ActionGroup.fs", "...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Can this be strongly typed as a `ResourceId` instead? Or is this the Azure AD object ID for an account?
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Can this be strongly typed as a `ResourceId` instead? Or is this the Azure AD object ID for an account?", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Far...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Can this also be a `ResourceId` so it's more strongly typed than just a string?
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Can this also be a `ResourceId` so it's more strongly typed than just a string?", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Can this be a `System.Uri` so it's more strongly typed than a string?
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Can this be a `System.Uri` so it's more strongly typed than a string?", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Far...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Rather than magic strings, can this be kept as an `Option` here and only make it an empty string (or `null`) when it's being serialized to JSON?
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Rather than magic strings, can this be kept as an `Option` here and only make it an empty string (or `null`) when it's being serialized to JSON?", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Same as above - if the `Name` is optional, please keep it an `Option` here.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Same as above - if the `Name` is optional, please keep it an `Option` here.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+op...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use a `System.Uri` here.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use a `System.Uri` here.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Farmer\n+open System\n+\n+let actionGroup...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
If this is optional, please leave it as an `Option` here and only convert it to an empty string when serializing.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "If this is optional, please leave it as an `Option` here and only convert it to an empty string when serializing.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use the existing `Location` type here that creates a type definition for Azure Regions, or even a separate DU similar to `Location` that limits it to the supported ITSM locations.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use the existing `Location` type here that creates a type definition for Azure Regions, or even a separate DU similar to `Location` that limits it to the supported ITSM locations.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.co...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use `System.Uri` for this.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use `System.Uri` for this.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Farmer\n+open System\n+\n+let actionGro...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use a `System.Uri` for this.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use a `System.Uri` for this.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Farmer\n+open System\n+\n+let actionG...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use a `System.Uri` for this.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please use a `System.Uri` for this.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Farmer\n+open System\n+\n+let actionG...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
If this is really optional, please defined it as a `string option`.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "If this is really optional, please defined it as a `string option`.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups\n+[<AutoOpen>]\n+module Farmer.Arm.ActionGroups\n+\n+open Farme...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please leave these as F# `Option` types if they are optional, only converting them to a default empty or `null` string when serializing them to an ARM template.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "Please leave these as F# `Option` types if they are optional, only converting them to a default empty or `null` string when serializing them to an ARM template.", "path": "src/Farmer/Arm/ActionGroup.fs", "hunk": "@@ -0,0 +1,317 @@\n+/// https://learn.microsoft.com/en-us/azure/templates/mi...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
All the fields here are typically defined in camelCase per the ARM convention. Please define the fields in the anonymous record with that same casing so that some of the code isn't using PascalCase and other code using CamelCase. You can see an example in [EventGrids](https://github.com/CompositionalIT/farmer/blob/ff3f...
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Arm/ActionGroup.fs b/src/Farmer/Arm/ActionGroup.fs new file mode 100644 index 000000000..15b14cc67 --- /dev/null +++ b/src/Farmer/Arm/ActionGroup.fs @@ -0,0 +1,331 @@ +/// https://learn.microsoft.com/en-us/azure/templates/microsoft.insights/actiongroups +[<AutoOpen>] +module Farmer.Arm.ActionGr...
[ "src/Farmer/Arm/ActionGroup.fs" ]
[ { "comment": "All the fields here are typically defined in camelCase per the ARM convention. Please define the fields in the anonymous record with that same casing so that some of the code isn't using PascalCase and other code using CamelCase. You can see an example in [EventGrids](https://github.com/Compositio...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please give the binding a meaningful name like `actionGroup` instead of `a`. Alternatively, don't define a binding for it and just define the record directly in the list.
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Builders/Builders.ActionGroup.fs b/src/Farmer/Builders/Builders.ActionGroup.fs new file mode 100644 index 000000000..b8377a4be --- /dev/null +++ b/src/Farmer/Builders/Builders.ActionGroup.fs @@ -0,0 +1,167 @@ +[<AutoOpen>] +module Farmer.Builders.ActionGroup + +open Farmer +open Farmer.Arm.Acti...
[ "src/Farmer/Builders/Builders.ActionGroup.fs" ]
[ { "comment": "Please give the binding a meaningful name like `actionGroup` instead of `a`.\r\n\r\nAlternatively, don't define a binding for it and just define the record directly in the list.", "path": "src/Farmer/Builders/Builders.ActionGroup.fs", "hunk": "@@ -0,0 +1,167 @@\n+[<AutoOpen>]\n+module Far...
true
CompositionalIT/farmer
1,058
comment_to_fix
Add new resource type action groups
Please use a single underscore (`_`) instead of double underscores (`__`) similar to [other builders](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/Builders/Builders.ApplicationGateway.fs#L95).
ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783
127ab632acab9411a1c2b8fa551f5d4fe6cc9d8b
diff --git a/src/Farmer/Builders/Builders.ActionGroup.fs b/src/Farmer/Builders/Builders.ActionGroup.fs new file mode 100644 index 000000000..b8377a4be --- /dev/null +++ b/src/Farmer/Builders/Builders.ActionGroup.fs @@ -0,0 +1,167 @@ +[<AutoOpen>] +module Farmer.Builders.ActionGroup + +open Farmer +open Farmer.Arm.Acti...
[ "src/Farmer/Builders/Builders.ActionGroup.fs" ]
[ { "comment": "Please use a single underscore (`_`) instead of double underscores (`__`) similar to [other builders](https://github.com/CompositionalIT/farmer/blob/ff3f5c5ae2a0b029c1eba3e6d8235156e65c6783/src/Farmer/Builders/Builders.ApplicationGateway.fs#L95).", "path": "src/Farmer/Builders/Builders.ActionG...
true
CompositionalIT/farmer
1,106
issue_to_patch
Add missing web app SKUs, including P0V3
This PR addresses #1104 The changes in this PR are as follows: * Adds the following web app SKUs: * Entry level: `P0V3` * Memory optimised: `P1MV3` `P2MV3` `P3MV3` `P4MV3` `P5MV3` I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [ ] **Tested my code**...
f4dd08c07d3189c26bc59083217206d0b1c536d1
49f86c42604b5c6acb8a67f9ec93190ca97bd134
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e122d60e7..a93ffdbec 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -3,6 +3,7 @@ Release Notes ## 1.8.11 * Service Bus: Added support for setting max message size. +* WebApp: Add new Premium V3 SKUs: Entry level SKU: `P0V3`, and memory optimised SKUs: ...
[ "RELEASE_NOTES.md", "src/Farmer/Common.fs" ]
[]
true
CompositionalIT/farmer
1,129
issue_to_patch
Dependabot update for System.Text.Json forces a library update on Farmer consumers With Farmer, we've historically tried to minimize the dependencies, and when running on recent dotnet versions, there normally aren't any downloaded because we defer to the version of System.Text.Json included in the runtime. Recently d...
Rollback FSharp.Core and System.Text.Json to minimal 5.0.0 versions
This PR closes #1128 The changes in this PR are as follows: * Rolls back FSharp.Core dependency to 5.0.0 since that's the minimal version required by Farmer. Consumers of Farmer can upgrade to whatever newer version of FSharp.Core suites them. * Rolls back System.Text.Json dependency to 5.0.0 since that's the m...
d336530d3a44d9cd93c3afe992f78937f35e7dc9
6a7973c722a060c62ce9f09ffc552c85e8bbf2cf
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 529294a4b..db8e9d801 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,7 @@ Release Notes ============= -## vNext + +## 9.0.0 * PostgreSQL: Support for Flexible Servers. ## 1.8.13 diff --git a/src/Farmer/Farmer.fsproj b/src/Farmer/Farmer.fsproj ...
[ "RELEASE_NOTES.md", "src/Farmer/Farmer.fsproj" ]
[]
true
CompositionalIT/farmer
1,130
issue_to_patch
Virtual Machines: Includes Ubuntu 24.04 LTS images.
This PR closes # The changes in this PR are as follows: * Virtual Machines: Includes Ubuntu 24.04 LTS images. I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [ ] **Updated the documentation...
d336530d3a44d9cd93c3afe992f78937f35e7dc9
73fe935473cab9da05061a84fe69309c6e60bad5
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 529294a4b..2bc0f0378 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,6 +2,7 @@ Release Notes ============= ## vNext * PostgreSQL: Support for Flexible Servers. +* Virtual Machines: Includes Ubuntu 24.04 LTS images. ## 1.8.13 * PostgreSQL: Use the ...
[ "RELEASE_NOTES.md", "src/Farmer/Common.fs" ]
[]
true
CompositionalIT/farmer
1,197
issue_to_patch
Load Balancer AZ Support, drop Basic SKU for Public IP, Subnet disable outbound
The changes in this PR are as follows: * Subnets: Support for `default_outbound_access false` as [recommended](https://learn.microsoft.com/azure/virtual-network/ip-services/default-outbound-access) and will be the default on September 30, 2025. * Public IP Addresses and Load Balancers: drop `Basic` SKU since it [ca...
47d48df58a947d2704b1567362fd58011fb5c212
2fcf85ee2e9fd4b836e6bfce10a7ccb992625bb2
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index dedcdf0e6..2b650e860 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,10 @@ Release Notes ============= +## 1.9.13 +* Subnets: Support for `disable_outbound_access`. +* Public IP Addresses and Load Balancers: drop `Basic` SKU, support zones. + #...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/load-balancer.md", "docs/content/api-overview/resources/vnet.md", "src/Farmer/Arm/LoadBalancer.fs", "src/Farmer/Arm/Network.fs", "src/Farmer/Builders/Builders.ApplicationGateway.fs", "src/Farmer/Builders/Builders.Bastion.fs", "src/Farmer/Builder...
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index 1e36f5dfa..7e1c0a129 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -232,28 +232,6 @@ let tests = Expect.hasLength aks.AgentPoolProfiles 1 "" Expect.equal aks.AgentPoolProfiles.[...
true
CompositionalIT/farmer
1,190
issue_to_patch
Add link_to_kubelet_identity to AKS config
The changes in this PR are as follows: * Add link_to_kubelet_identity to AKS config * Update docs to reference existing link_to_identity option in AKS config I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure su...
3e0a1e4c790ac42172efe47565a5cfca9dc16d90
e94b071fb9c7da23b04c4b23e7ef56ccdd64438d
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 057b1a7c2..dedcdf0e6 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -2,6 +2,7 @@ Release Notes ============= ## 1.9.12 +* AKS Cluster: Add link_to_kubelet_identity * VMSS overprovisioning controls ## 1.9.11 diff --git a/docs/content/api-overview/re...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/aks-cluster.md", "src/Farmer/Arm/ContainerService.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "src/Tests/ContainerService.fs" ]
[]
diff --git a/src/Tests/ContainerService.fs b/src/Tests/ContainerService.fs index fc2ccf2ce..1e36f5dfa 100644 --- a/src/Tests/ContainerService.fs +++ b/src/Tests/ContainerService.fs @@ -283,6 +283,49 @@ let tests = Expect.equal (authIpRanges.[0].ToString()) "88.77.66.0/24" "Got incorrect value for authori...
true
CompositionalIT/farmer
1,186
issue_to_patch
Add .NET 8.0 non-isolated runtime
Very minor addition
ee416323b1b4c437b78cbe7e63a43da1898caad0
c6b5a6ccd82f44938dc0b90aff90abb3fbe3008d
diff --git a/src/Farmer/Builders/Builders.Functions.fs b/src/Farmer/Builders/Builders.Functions.fs index 787f2f4a7..e70a09d5e 100644 --- a/src/Farmer/Builders/Builders.Functions.fs +++ b/src/Farmer/Builders/Builders.Functions.fs @@ -30,6 +30,7 @@ type FunctionsRuntime with static member DotNet50 = DotNet, Some "5....
[ "src/Farmer/Builders/Builders.Functions.fs" ]
[]
true
CompositionalIT/farmer
1,181
issue_to_patch
VMSS overprovisioning controls Need a couple of properties to control [overprovisioning](https://learn.microsoft.com/en-us/azure/templates/microsoft.compute/virtualmachinescalesets?pivots=deployment-language-bicep#virtualmachinescalesetproperties). Overprovisioning is on by default and would execute the configured ex...
VMSS overprovisioning controls
This PR closes #1180 The changes in this PR are as follows: * Add `overprovision` and `run_extensions_on_overprovisioned_vms` to VMSS CE I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end against a live Azure subscription. * [x]...
47d6b5ce8d92a21d314afe4df5a9712279faafb2
ae2342a8d75e1f60b1bb471561c417614821780d
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 84e9261fc..057b1a7c2 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.12 +* VMSS overprovisioning controls + ## 1.9.11 * VM extensions: support for auto-upgrades and initial version diff --git a/docs/c...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/vm-scale-set.md", "src/Farmer/Arm/Compute.fs", "src/Farmer/Builders/Builders.VmScaleSet.fs", "src/Tests/VmScaleSet.fs" ]
[]
diff --git a/src/Tests/VmScaleSet.fs b/src/Tests/VmScaleSet.fs index 7fbcd4eb1..466562e1a 100644 --- a/src/Tests/VmScaleSet.fs +++ b/src/Tests/VmScaleSet.fs @@ -125,6 +125,12 @@ let tests = let vmProfile = vmssProps.SelectToken("virtualMachineProfile") Expect.isNotNull vmProfile "VMSS is missi...
true
CompositionalIT/farmer
1,179
issue_to_patch
VM/SS autoupgrade for extensions Would be good to support [enableAutomaticUpgrade property](https://learn.microsoft.com/en-us/azure/virtual-machines/automatic-extension-upgrade?tabs=RestAPI1%2CRestAPI2#for-virtual-machine-scale-sets)
VM health extension autoupgrade
This PR closes #1178 The changes in this PR are as follows: * Added support for the `enableAutomaticUpgrade` property for `applicationHealthExtension`. * Exposed inital version of the extension, defaulting to the same "1.0" for backwards compat I have read the [contributing guidelines](CONTRIBUTING.md) and...
cc5702452bc89ad4e80fd278c2a35b20b82c3227
6d0dfe5653bf0e71597670895b4a87100abcc487
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 687cdd7d7..84e9261fc 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.11 +* VM extensions: support for auto-upgrades and initial version + ## 1.9.10 * Application Gateways: Adds SSL Certificates * Netwo...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/vm-scale-set.md", "src/Farmer/Arm/Compute.fs", "src/Farmer/Builders/Builders.Vm.fs", "src/Farmer/Builders/Builders.VmScaleSet.fs" ]
[]
true
CompositionalIT/farmer
1,176
issue_to_patch
App Gateway support for sslCertificates To enable end to end TLS, App Gateway needs to support adding "sslCertificates" and also adding an "sslCertificate" to an http listener.
App Gateway SSL Support, ARM Expressions in NSG rules and Gallery Apps
This PR closes #1164 and #1157 and #1175 The changes in this PR are as follows: * Application Gateways: Adds SSL Certificates * Network Security Groups: use ARM expressions in security rules * Gallery Applications: `source_media_link` can be an ARM expression I have read the [contributing guidelines](CONTRI...
0936a50de3aa750806fb081033da0055783fc437
fe36aff2d0a273b0a069063d795037ea054dd3e8
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 7f8a4103e..687cdd7d7 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,11 @@ Release Notes ============= +## 1.9.10 +* Application Gateways: Adds SSL Certificates +* Network Security Groups: use ARM expressions in security rules +* Gallery Applica...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/application-gateway.md", "src/Farmer/Arm/ApplicationGateway.fs", "src/Farmer/Arm/Gallery.fs", "src/Farmer/Arm/NetworkSecurityGroup.fs", "src/Farmer/Builders/Builders.ApplicationGateway.fs", "src/Farmer/Builders/Builders.Gallery.fs", "src/Farmer/...
[]
diff --git a/src/Tests/AppGateway.fs b/src/Tests/AppGateway.fs index 94608bbb0..37bbc1ab9 100644 --- a/src/Tests/AppGateway.fs +++ b/src/Tests/AppGateway.fs @@ -9,6 +9,7 @@ open Farmer.ApplicationGateway open Farmer.Builders open Farmer.Network open Farmer.NetworkSecurity +open Newtonsoft.Json.Linq let client = ...
true
CompositionalIT/farmer
1,174
issue_to_patch
Enable standard SKU public IP for VM
VM support for Azure Linux 3.0, Standard SKU Public IP, Gallery Apps
This PR closes #1165 and #1173 The changes in this PR are as follows: * Virtual Machines: support for Azure Linux 3.0 * Virtual Machines: support for Standard SKU Public IP Address * Galleries: support for Gallery Applications to distribute applications for Virtual Machines and Virtual Machine Scale Sets I ...
2b168ceec975e0f00b01678096f88e5389a22ab7
541450eb173540c60417e5272f169a921ec48191
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 701830331..7f8a4103e 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,11 @@ Release Notes ============= +## 1.9.9 +* Virtual Machines: support for Azure Linux 3.0 +* Virtual Machines: support for Standard SKU Public IP Address +* Galleries: suppo...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/gallery.md", "docs/content/api-overview/resources/virtual-machine.md", "src/Farmer/Arm/AutoscaleSettings.fs", "src/Farmer/Arm/Gallery.fs", "src/Farmer/Builders/Builders.AutoscaleSettings.fs", "src/Farmer/Builders/Builders.ContainerService.fs", "...
[ { "comment": "The variable name 'myGalleryAppVerion' is misspelled. It should be 'myGalleryAppVersion'.\n```suggestion\n myGalleryAppVersion\n```", "path": "docs/content/api-overview/resources/gallery.md", "hunk": "@@ -86,3 +104,59 @@ arm {\n ]\n }\n ```\n+\n+#### Example of a Gallery Applica...
diff --git a/src/Tests/Gallery.fs b/src/Tests/Gallery.fs index b6d7a9a48..464437a66 100644 --- a/src/Tests/Gallery.fs +++ b/src/Tests/Gallery.fs @@ -1,5 +1,6 @@ module Gallery +open System open Expecto open Farmer open Farmer.Builders @@ -145,4 +146,68 @@ let tests = (JValue "[resourceId('Microso...
true
CompositionalIT/farmer
1,174
comment_to_fix
VM support for Azure Linux 3.0, Standard SKU Public IP, Gallery Apps
The variable name 'myGalleryAppVerion' is misspelled. It should be 'myGalleryAppVersion'. ```suggestion myGalleryAppVersion ```
2b168ceec975e0f00b01678096f88e5389a22ab7
541450eb173540c60417e5272f169a921ec48191
diff --git a/docs/content/api-overview/resources/gallery.md b/docs/content/api-overview/resources/gallery.md index 331823e98..15b561751 100644 --- a/docs/content/api-overview/resources/gallery.md +++ b/docs/content/api-overview/resources/gallery.md @@ -6,48 +6,66 @@ chapter: false --- #### Overview -The `gallery` b...
[ "docs/content/api-overview/resources/gallery.md" ]
[ { "comment": "The variable name 'myGalleryAppVerion' is misspelled. It should be 'myGalleryAppVersion'.\n```suggestion\n myGalleryAppVersion\n```", "path": "docs/content/api-overview/resources/gallery.md", "hunk": "@@ -86,3 +104,59 @@ arm {\n ]\n }\n ```\n+\n+#### Example of a Gallery Applica...
true
CompositionalIT/farmer
1,160
issue_to_patch
CosmosDB Gremlin support Hi, Firstly, thanks very much for this excellent piece of technology! Secondly, we're new to Farmer and would like to deploy a Gremlin-enabled CosmosDB account. I see in the docs that it currently says "with support for Gremlin, Table and Cassandra data models planned...". So was ju...
#1097 - Gremlin graph support to CosmosDb
This PR closes #1097 The changes in this PR are as follows: * Add support for creating Gremlin CosmosDb Accounts * Add support for creating Gremlin Graphs under CosmosDb Accounts I have read the [contributing guidelines](CONTRIBUTING.md) and have completed the following: * [x] **Tested my code** end-to-end...
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
e2b51e0c8287dc85fee414759130fcd73cb8c648
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e4cc84540..559d3a531 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,6 +1,9 @@ Release Notes ============= +## 1.9.7 +* CosmosDB: Add support for Gremlin Graphs + ## 1.9.6 - Network Interface: Support for adding Network Security Group (NSG) to Netw...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/cosmos-db.md", "src/Farmer/Arm/DocumentDb.fs", "src/Farmer/Builders/Builders.Cosmos.fs", "src/Tests/Cosmos.fs" ]
[]
diff --git a/src/Tests/Cosmos.fs b/src/Tests/Cosmos.fs index 103a59e9d..ee6b9dfcb 100644 --- a/src/Tests/Cosmos.fs +++ b/src/Tests/Cosmos.fs @@ -146,6 +146,15 @@ let tests = Expect.equal db.Kind Mongo "" } + + test "gremlin" { + let db = cosmosDb { + ...
true
CompositionalIT/farmer
1,162
issue_to_patch
imageReference support for sharedGalleryImageId Would be nice to see `sharedGalleryImageId` support among [VM imageReference](https://learn.microsoft.com/en-us/azure/templates/microsoft.compute/virtualmachines?pivots=deployment-language-arm-template#imagereference-1) options. securityProfile support for VMSS Support...
gallery image reference and security profile support for VMs
This PR closes #1161 and closes #1163 The changes in this PR are as follows: * Offers Community and Shared gallery image support * Introduces `ImageInfo` DU to support gallery image references as well as existing image SKUs * Gallery references still require `OS` when configuring a VM - purely to maintain farme...
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
6d9525e84fe33cbb9f47dd7806333089f7eee331
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e4cc84540..8833e792c 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -1,5 +1,8 @@ Release Notes ============= +## vNext +- Support gallery references for VMs (`operating_system`) +- Support for VM/VMSS security profile options (#1163) ## 1.9.6 - Netwo...
[ "RELEASE_NOTES.md", "docs/content/api-overview/resources/virtual-machine.md", "docs/content/api-overview/resources/vm-scale-set.md", "samples/.gitignore", "src/Farmer/Arm/Compute.fs", "src/Farmer/Builders/Builders.Vm.fs", "src/Farmer/Builders/Builders.VmScaleSet.fs", "src/Farmer/Common.fs", "src/Tes...
[ { "comment": "Thanks for avoiding breakage here.", "path": "src/Farmer/Builders/Builders.Vm.fs", "hunk": "@@ -440,10 +443,18 @@ type VirtualMachineBuilder() =\n \n /// Sets the operating system of the VM. A set of samples is provided in the `CommonImages` module.\n [<CustomOperation \"operating_...
diff --git a/src/Tests/VirtualMachine.fs b/src/Tests/VirtualMachine.fs index f96d24168..11a2593ea 100644 --- a/src/Tests/VirtualMachine.fs +++ b/src/Tests/VirtualMachine.fs @@ -77,6 +77,49 @@ let tests = Expect.isNull (vmProperties.Property "priority") "Priority should not be set by default" } +...
true
CompositionalIT/farmer
1,162
comment_to_fix
gallery image reference and security profile support for VMs
Thanks for avoiding breakage here.
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
6d9525e84fe33cbb9f47dd7806333089f7eee331
diff --git a/src/Farmer/Builders/Builders.Vm.fs b/src/Farmer/Builders/Builders.Vm.fs index 08a80f289..0571ec910 100644 --- a/src/Farmer/Builders/Builders.Vm.fs +++ b/src/Farmer/Builders/Builders.Vm.fs @@ -45,6 +45,7 @@ type VmConfig = { VNet: ResourceRef<VmConfig> AddressPrefix: string SubnetPrefix: stri...
[ "src/Farmer/Builders/Builders.Vm.fs" ]
[ { "comment": "Thanks for avoiding breakage here.", "path": "src/Farmer/Builders/Builders.Vm.fs", "hunk": "@@ -440,10 +443,18 @@ type VirtualMachineBuilder() =\n \n /// Sets the operating system of the VM. A set of samples is provided in the `CommonImages` module.\n [<CustomOperation \"operating_...
true
CompositionalIT/farmer
1,162
comment_to_fix
gallery image reference and security profile support for VMs
Would it be possible to use the `GalleryImageIdentifier` from [gallery image builder](https://github.com/CompositionalIT/farmer/blob/d3e89799cd04bdbce2a98f4c153c05b81b766bf3/src/Farmer/Arm/Gallery.fs#L81) instead of an arbitrary string?
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
6d9525e84fe33cbb9f47dd7806333089f7eee331
diff --git a/src/Farmer/Common.fs b/src/Farmer/Common.fs index 12e93a453..f956dbef7 100644 --- a/src/Farmer/Common.fs +++ b/src/Farmer/Common.fs @@ -217,6 +217,25 @@ module DedicatedHosts = | WindowsPerpetual -> "Windows_Server_Perpetual" module Vm = + + type VmProxyAgentMode = + | Audit + ...
[ "src/Farmer/Common.fs" ]
[ { "comment": "Would it be possible to use the `GalleryImageIdentifier` from [gallery image builder](https://github.com/CompositionalIT/farmer/blob/d3e89799cd04bdbce2a98f4c153c05b81b766bf3/src/Farmer/Arm/Gallery.fs#L81) instead of an arbitrary string?", "path": "src/Farmer/Common.fs", "hunk": "@@ -821,6 ...
true
CompositionalIT/farmer
1,162
comment_to_fix
gallery image reference and security profile support for VMs
Please don't mix snake_case and camel_case. `encryption_at_host`
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
6d9525e84fe33cbb9f47dd7806333089f7eee331
diff --git a/src/Farmer/Builders/Builders.Vm.fs b/src/Farmer/Builders/Builders.Vm.fs index 08a80f289..0571ec910 100644 --- a/src/Farmer/Builders/Builders.Vm.fs +++ b/src/Farmer/Builders/Builders.Vm.fs @@ -45,6 +45,7 @@ type VmConfig = { VNet: ResourceRef<VmConfig> AddressPrefix: string SubnetPrefix: stri...
[ "src/Farmer/Builders/Builders.Vm.fs" ]
[ { "comment": "Please don't mix snake_case and camel_case.\r\n\r\n`encryption_at_host`", "path": "src/Farmer/Builders/Builders.Vm.fs", "hunk": "@@ -378,6 +381,73 @@ type VirtualMachineBuilder() =\n | other -> other)\n }\n \n+ [<CustomOperation \"encryption_atHost\">]", ...
true
CompositionalIT/farmer
1,162
comment_to_fix
gallery image reference and security profile support for VMs
Rather than passing a `UefiSettings` record type, please use operations the individual properties. This keeps users from having to go back and forth in syntax between builders and records. If there are a lot of properties to set, it might need a builder of it's own, but in this case, just two operations. Rather tha...
d3e89799cd04bdbce2a98f4c153c05b81b766bf3
6d9525e84fe33cbb9f47dd7806333089f7eee331
diff --git a/src/Farmer/Builders/Builders.Vm.fs b/src/Farmer/Builders/Builders.Vm.fs index 08a80f289..0571ec910 100644 --- a/src/Farmer/Builders/Builders.Vm.fs +++ b/src/Farmer/Builders/Builders.Vm.fs @@ -45,6 +45,7 @@ type VmConfig = { VNet: ResourceRef<VmConfig> AddressPrefix: string SubnetPrefix: stri...
[ "src/Farmer/Builders/Builders.Vm.fs" ]
[ { "comment": "Rather than passing a `UefiSettings` record type, please use operations the individual properties. This keeps users from having to go back and forth in syntax between builders and records. If there are a lot of properties to set, it might need a builder of it's own, but in this case, just two oper...
true
CopilotKit/CopilotKit
5,418
issue_to_patch
🐛 Bug: Messages added via addMessage don't render until the run finishes — AgentStore re-sets the messages signal with the same array reference ♻️ Reproduction Steps app-level addMessage: // main.ts import { bootstrapApplication } from '@angular/platform-browser'; import { Component } from '@angular/...
fix(angular): emit fresh messages array so OnPush views render on addMessage
Fixes #5416 ## Problem `AgentStore` mirrored the agent's messages into a signal via `this.#messages.set(abstractAgent.messages)`. `AbstractAgent.addMessage` pushes **in place** and notifies with the **same array reference**. Angular signals compare with `Object.is`, so `set(sameRef)` is a no-op: the signal never noti...
54a99977c81e60c6b1148018c4a15d4879088acb
d11fb33169a2e898de7fc4b27902a8bcccaf84a9
diff --git a/packages/angular/src/lib/agent.ts b/packages/angular/src/lib/agent.ts index 154ab794d2a..33feeb70706 100644 --- a/packages/angular/src/lib/agent.ts +++ b/packages/angular/src/lib/agent.ts @@ -1,17 +1,17 @@ +import type { Signal } from "@angular/core"; import { DestroyRef, Injectable, inject, s...
[ "packages/angular/src/lib/agent.spec.ts", "packages/angular/src/lib/agent.ts" ]
[]
diff --git a/packages/angular/src/lib/agent.spec.ts b/packages/angular/src/lib/agent.spec.ts index ef841cda9e1..c09c116af05 100644 --- a/packages/angular/src/lib/agent.spec.ts +++ b/packages/angular/src/lib/agent.spec.ts @@ -1,13 +1,18 @@ -import { Component, signal } from "@angular/core"; +import { + ChangeDetectionS...
true
CopilotKit/CopilotKit
5,425
issue_to_patch
fix(showcase): pin page-registered A2UI catalog as defaultCatalogId fleet-wide
## Problem Asking for a sales dashboard in the beautiful-chat demo (reported on `dojo.showcase.copilotkit.ai/?integration=langgraph-python&demo=beautiful-chat`) fails with: > A2UI render error: Catalog not found: https://a2ui.org/specification/v0_9/basic_catalog.json ## Root cause **Introduced by #5245** ("chore(sh...
0ce40b229264464e7853ba4648c7d5fd07ccebe0
53801f8e04859aa10e4eee0dc8332a5879858275
diff --git a/showcase/aimock/d4/langgraph-python/chat.json b/showcase/aimock/d4/langgraph-python/chat.json index 1e1fd7d2462..ce34cec8a40 100644 --- a/showcase/aimock/d4/langgraph-python/chat.json +++ b/showcase/aimock/d4/langgraph-python/chat.json @@ -25,7 +25,7 @@ { "id": "call_fp_design_a2ui_...
[ ".github/workflows/test_e2e-showcase-on-demand.yml", "showcase/aimock/d4/langgraph-python/chat.json", "showcase/integrations/ag2/src/app/api/copilotkit-beautiful-chat/route.ts", "showcase/integrations/agno/src/app/api/copilotkit-beautiful-chat/route.ts", "showcase/integrations/agno/src/app/api/copilotkit-de...
[]
diff --git a/.github/workflows/test_e2e-showcase-on-demand.yml b/.github/workflows/test_e2e-showcase-on-demand.yml index 13fbbc353ae..69cc3a45097 100644 --- a/.github/workflows/test_e2e-showcase-on-demand.yml +++ b/.github/workflows/test_e2e-showcase-on-demand.yml @@ -298,7 +298,15 @@ jobs: echo "::error::...
true
CopilotKit/CopilotKit
5,397
issue_to_patch
docs(shell-docs): add @copilotkit/react-native reference documentation
Adds a **React Native** SDK to the reference docs at `/reference/react-native`, covering the full `@copilotkit/react-native` public API. Modeled on the existing React/Core/Bots reference sections. **Nav:** register `react-native` in `reference-items.ts`, add the SDK selector label + an overview card. **Content (2...
0ce40b229264464e7853ba4648c7d5fd07ccebe0
cf5126a04e37bc06eb32c713918f707f4a9a3d22
diff --git a/showcase/shell-docs/src/app/reference/page.tsx b/showcase/shell-docs/src/app/reference/page.tsx index 7436218c934..c10f65b003f 100644 --- a/showcase/shell-docs/src/app/reference/page.tsx +++ b/showcase/shell-docs/src/app/reference/page.tsx @@ -42,6 +42,12 @@ const SDK_CHOICES: { name: string; description: ...
[ "showcase/shell-docs/src/app/reference/page.tsx", "showcase/shell-docs/src/components/reference-version-selector.tsx", "showcase/shell-docs/src/content/reference/react-native/components/AssistantMessage.mdx", "showcase/shell-docs/src/content/reference/react-native/components/CopilotChat.mdx", "showcase/shel...
[]
true
CopilotKit/CopilotKit
5,300
issue_to_patch
🐛 Bug: Headers not being sent on /threads requests ### ♻️ Reproduction Steps We are enforcing CRSF checks through a backend proxy and using BFF 1. Set headers on CopilotKit ``` html <CopilotKit runtimeUrl={AGENT_URL} agent={AGENT_ID} useSingleEndpoint={false} headers={{ 'X-CSRF': 1 }} > ``` 2. When the Copi...
fix(react-core): refresh thread headers on provider updates
## What does this PR do? Fixes #5282. Provider header updates already reach the core instance via `setHeaders`, but React consumers of `useCopilotKit()` were only re-rendered for runtime connection status changes. That left `useThreads()` with stale context after the provider `headers` prop changed, so subsequent `/t...
4e4180bf885d005a46dc5c61fc6a2b7d80a4ab8c
9639b8d4d66bd8d2ff2c039c5ea1251a4c57a6eb
diff --git a/packages/react-core/src/v2/context.ts b/packages/react-core/src/v2/context.ts index 29a0ceae38e..7cfcaed5106 100644 --- a/packages/react-core/src/v2/context.ts +++ b/packages/react-core/src/v2/context.ts @@ -37,6 +37,9 @@ export const useCopilotKit = (): CopilotKitContextValue => { onRuntimeConnecti...
[ "packages/react-core/src/v2/context.ts", "packages/react-core/src/v2/hooks/__tests__/use-threads-provider-headers.e2e.test.tsx" ]
[]
diff --git a/packages/react-core/src/v2/hooks/__tests__/use-threads-provider-headers.e2e.test.tsx b/packages/react-core/src/v2/hooks/__tests__/use-threads-provider-headers.e2e.test.tsx new file mode 100644 index 00000000000..ca0cb73cb18 --- /dev/null +++ b/packages/react-core/src/v2/hooks/__tests__/use-threads-provider...
true
CopilotKit/CopilotKit
5,422
issue_to_patch
fix(showcase/harness): redefine family lastSuccessAt — terminal-completion, not all-green
## Symptom Dashboard banner false alarm: *"Worker family E2E demos has not completed successfully since 2h 40m ago"* (and the same on D5/D6) firing while workers were healthy and emitting results every cycle. ## Triage (already done) The D5/D6 family-silence banner fires because: - `lastSuccessAt` is computed via `...
dfdb5e60ae59c6066d450f9a0ab3297d91df2e71
34ca7f1292ec8833611f3d2ff21c01f0ca731e41
diff --git a/showcase/harness/src/fleet/control-plane/run-view.ts b/showcase/harness/src/fleet/control-plane/run-view.ts index 59aedc83638..368d9969c16 100644 --- a/showcase/harness/src/fleet/control-plane/run-view.ts +++ b/showcase/harness/src/fleet/control-plane/run-view.ts @@ -37,17 +37,15 @@ import { isPoolCommE...
[ "showcase/harness/src/fleet/control-plane/family-silence-monitor.test.ts", "showcase/harness/src/fleet/control-plane/run-view.test.ts", "showcase/harness/src/fleet/control-plane/run-view.ts", "showcase/harness/src/http/fleet-runs.test.ts" ]
[]
diff --git a/showcase/harness/src/fleet/control-plane/family-silence-monitor.test.ts b/showcase/harness/src/fleet/control-plane/family-silence-monitor.test.ts index f93977f5696..95f56a671f7 100644 --- a/showcase/harness/src/fleet/control-plane/family-silence-monitor.test.ts +++ b/showcase/harness/src/fleet/control-plan...
true
CopilotKit/CopilotKit
5,386
issue_to_patch
🐛 Bug: Scroll to bottom button not appearing and user message shifts after streaming finishes in "pin to send" autoscroll mode ### ♻️ Reproduction Steps We are using `<CopilotPopup />` at the base level to reproduce: ``` <CopilotPopup scrollView={{ autoScroll: 'pin-to-send', }} /> ``` We are seeing the sam...
fix(react-core): stabilize pin-to-send scrolling
## What does this PR do? Fixes `pin-to-send` scrolling in the v2 chat view. - Re-attaches the non-autoscroll scroll listener after the real scroll element mounts by depending on `nonAutoScrollEl`, not the stable `scrollRef` object. - Lets the `usePinToSend` spacer adjust in both directions as content below the pinned...
81ee31dd5aff12f2d87ac3f5076674d2fbe34e67
8e440a9e7d17552fed1d85507608b94f90f94260
diff --git a/packages/react-core/src/v2/components/chat/CopilotChatView.tsx b/packages/react-core/src/v2/components/chat/CopilotChatView.tsx index 8f01ad738f0..03f9f1fd9dc 100644 --- a/packages/react-core/src/v2/components/chat/CopilotChatView.tsx +++ b/packages/react-core/src/v2/components/chat/CopilotChatView.tsx @@ ...
[ "packages/react-core/src/v2/components/chat/CopilotChatView.tsx", "packages/react-core/src/v2/components/chat/__tests__/CopilotChatView.pinToSend.test.tsx", "packages/react-core/src/v2/hooks/__tests__/use-pin-to-send.test.tsx", "packages/react-core/src/v2/hooks/use-pin-to-send.ts" ]
[]
diff --git a/packages/react-core/src/v2/components/chat/__tests__/CopilotChatView.pinToSend.test.tsx b/packages/react-core/src/v2/components/chat/__tests__/CopilotChatView.pinToSend.test.tsx index 7c045a21046..21145118be2 100644 --- a/packages/react-core/src/v2/components/chat/__tests__/CopilotChatView.pinToSend.test.t...
true
CopilotKit/CopilotKit
5,421
issue_to_patch
fix(showcase): BIA D6 followups — PARITY_NOTES NSF naming + STATE_DELTA op:add
## Summary Small followups to PR #5413 (BIA D6 readiness, merged 2026-06-12). - **`PARITY_NOTES.md` NSF naming**: corrected `hitl` (which is supported in BIA via Strategy-B `useFrontendTool`) to call out the actual NSF-quarantined demos `gen-ui-interrupt` and `shared-state-streaming` per the manifest. PR #5413's NSF ...
5e828aed9de156f5245792fa9e0203955e114d38
bf37f3808d7ab1a579220b0657f1978b05f50947
diff --git a/showcase/integrations/built-in-agent/PARITY_NOTES.md b/showcase/integrations/built-in-agent/PARITY_NOTES.md index f6781a1f9e4..f7fa974c2e7 100644 --- a/showcase/integrations/built-in-agent/PARITY_NOTES.md +++ b/showcase/integrations/built-in-agent/PARITY_NOTES.md @@ -77,11 +77,19 @@ PR that bumps `@copilot...
[ "showcase/integrations/built-in-agent/PARITY_NOTES.md", "showcase/integrations/built-in-agent/src/lib/factory/tanstack-factory.ts" ]
[]
true
CopilotKit/CopilotKit
5,419
issue_to_patch
fix(shared): preserve lambda client cjs export
## Summary - export the telemetry lambda client as a named binding instead of default-reexporting it through the shared barrel - update shared telemetry internals/tests to consume the named binding - add a built-package smoke check to ensure both CommonJS and ESM expose `lambdaClient.send` ## Root Cause `@copilotkit/s...
54a99977c81e60c6b1148018c4a15d4879088acb
5eea242e1fb4b781a6f2c0b1cb1889d48e6197f5
diff --git a/packages/shared/package.json b/packages/shared/package.json index 56cdb397af1..97ae3040ad6 100644 --- a/packages/shared/package.json +++ b/packages/shared/package.json @@ -46,7 +46,7 @@ "check-types": "tsc --noEmit", "link:global": "pnpm link --global", "unlink:global": "pnpm unlink --global...
[ "packages/shared/package.json", "packages/shared/scripts/verify-cjs-exports.cjs", "packages/shared/src/telemetry/index.ts", "packages/shared/src/telemetry/lambda-client.ts", "packages/shared/src/telemetry/telemetry-client.test.ts", "packages/shared/src/telemetry/telemetry-client.ts" ]
[]
diff --git a/packages/shared/src/telemetry/telemetry-client.test.ts b/packages/shared/src/telemetry/telemetry-client.test.ts index 542b0edd390..cd36d95be35 100644 --- a/packages/shared/src/telemetry/telemetry-client.test.ts +++ b/packages/shared/src/telemetry/telemetry-client.test.ts @@ -1,6 +1,6 @@ import { afterEach...
true
CopilotKit/CopilotKit
5,099
issue_to_patch
🐛 Bug: Default Streamdown markdown classes are unstyled in non-Tailwind consumers due to cpk: prefix ### ♻️ Reproduction Steps 1. Create a fresh React app without Tailwind CSS (e.g. `npm create vite@latest my-app -- --template react-ts`) 2. Install CopilotKit: `npm install @copilotkit/react-core @copilotkit/react-ui...
fix(react-core): scope streamdown markdown styles
## Summary Fixes #5072 Fix unstyled Streamdown markdown in non-Tailwind apps that import `@copilotkit/react-core/v2/styles.css`. Streamdown renders plain utility class names, but CopilotKit’s CSS bundle is generated with the `cpk:` Tailwind prefix. That left default markdown elements like headings, lists, str...
54a99977c81e60c6b1148018c4a15d4879088acb
9275ec2ce08ba66e02df26d270ec995ad0d45b6d
diff --git a/packages/react-core/src/v2/styles/globals.css b/packages/react-core/src/v2/styles/globals.css index 4263984287c..3237d18d6cb 100644 --- a/packages/react-core/src/v2/styles/globals.css +++ b/packages/react-core/src/v2/styles/globals.css @@ -1,7 +1,6 @@ @import "tailwindcss" prefix(cpk); @plugin "@tailwind...
[ "packages/react-core/src/v2/styles/__tests__/streamdown-styles.test.ts", "packages/react-core/src/v2/styles/globals.css" ]
[]
diff --git a/packages/react-core/src/v2/styles/__tests__/streamdown-styles.test.ts b/packages/react-core/src/v2/styles/__tests__/streamdown-styles.test.ts new file mode 100644 index 00000000000..f4f822ef504 --- /dev/null +++ b/packages/react-core/src/v2/styles/__tests__/streamdown-styles.test.ts @@ -0,0 +1,32 @@ +impor...
true
CopilotKit/CopilotKit
5,385
issue_to_patch
fix(runtime): add a2ui enabled opt-out via shared isA2UIEnabled predicate
## Summary Follow-up to #5383 (per-agent A2UI scoping). Two small, backwards-compatible runtime changes: 1. **One shared `isA2UIEnabled()` predicate.** Before, "is a2ui on?" was computed independently in two places — `if (runtime.a2ui)` in the run path (`agent-utils.ts`) and `!!runtime.a2ui` in the `/info` response (...
881c24bb2a3cbd18b55fcb410b84b8776838b98a
f5a2dbbb79ee46f01c949f8fa659a64ca1192772
diff --git a/packages/runtime/src/v2/runtime/core/runtime.ts b/packages/runtime/src/v2/runtime/core/runtime.ts index 12bad601485..bd305178f46 100644 --- a/packages/runtime/src/v2/runtime/core/runtime.ts +++ b/packages/runtime/src/v2/runtime/core/runtime.ts @@ -1,35 +1,33 @@ -import { +import type { MaybePromise, ...
[ "packages/runtime/src/v2/runtime/__tests__/get-runtime-info.test.ts", "packages/runtime/src/v2/runtime/__tests__/handle-run.test.ts", "packages/runtime/src/v2/runtime/core/runtime.ts", "packages/runtime/src/v2/runtime/handlers/get-runtime-info.ts", "packages/runtime/src/v2/runtime/handlers/shared/agent-util...
[]
diff --git a/packages/runtime/src/v2/runtime/__tests__/get-runtime-info.test.ts b/packages/runtime/src/v2/runtime/__tests__/get-runtime-info.test.ts index 09c49a7b29a..918cbc5f465 100644 --- a/packages/runtime/src/v2/runtime/__tests__/get-runtime-info.test.ts +++ b/packages/runtime/src/v2/runtime/__tests__/get-runtime-...
true
CopilotKit/CopilotKit
5,412
issue_to_patch
fix(showcase): content-red dashboard remediation — spring-ai/ag2/cst/llamaindex
## Summary Content-red dashboard remediation across CopilotKit showcase integrations (spring-ai, ag2, claude-sdk-typescript, llamaindex). Aligns aimock fixtures (d4 and d6) with real backend output shapes, ports A2UI v0.9 declarative legs, quarantines unsupported features as NSF with the canonical d5-feature-mapping l...
9984c82c66be2a0aaf6aeae06b3ec12dec21f61b
29bd450534aa29d54a8be33f118aaca43ff9976d
diff --git a/showcase/aimock/d4/ag2/chat.json b/showcase/aimock/d4/ag2/chat.json index 0aab4b843c9..205315994fb 100644 --- a/showcase/aimock/d4/ag2/chat.json +++ b/showcase/aimock/d4/ag2/chat.json @@ -266,8 +266,9 @@ } }, { + "_comment": "Disabled: prior matcher 'weather' load-order-shadowed D6 pi...
[ ".github/workflows/test_unit-spring-ai.yml", "showcase/aimock/d4/ag2/chat.json", "showcase/aimock/d4/built-in-agent/chat.json", "showcase/aimock/d4/claude-sdk-typescript/chat.json", "showcase/aimock/d4/spring-ai/chat.json", "showcase/aimock/d6/ag2/gen-ui-declarative.json", "showcase/aimock/d6/ag2/multim...
[]
diff --git a/.github/workflows/test_unit-spring-ai.yml b/.github/workflows/test_unit-spring-ai.yml new file mode 100644 index 00000000000..e0a6ded984b --- /dev/null +++ b/.github/workflows/test_unit-spring-ai.yml @@ -0,0 +1,127 @@ +name: test / unit / spring-ai + +# Unit tests for the spring-ai showcase integration. +#...
true
CopilotKit/CopilotKit
5,413
issue_to_patch
fix(showcase): D6 reds remediation on built-in-agent — testid backfill + PARITY_NOTES + aimock fixtures + STATE_DELTA wiring
## Scope Built-in-agent integration D6 readiness pass — companion to PR #5407 (merged) which fixed the claude-sdk-python integration. This PR follows the same PARITY_NOTES pattern. ### What changed - **~28 testids backfilled across 13 demos**: declarative-gen-ui renderers, headless-complete (assistant-bubble, user-b...
089f8ac243dca6d8cca9390ebedea51a674cf91d
1427475a7e5854a98699d026b17c7b4f8e0d386d
diff --git a/showcase/aimock/d6/built-in-agent/gen-ui-a2ui-fixed.json b/showcase/aimock/d6/built-in-agent/gen-ui-a2ui-fixed.json new file mode 100644 index 00000000000..b0ac44b2bfc --- /dev/null +++ b/showcase/aimock/d6/built-in-agent/gen-ui-a2ui-fixed.json @@ -0,0 +1,36 @@ +{ + "_meta": { + "description": "D6 fixt...
[ "showcase/aimock/d6/built-in-agent/gen-ui-a2ui-fixed.json", "showcase/aimock/d6/built-in-agent/gen-ui-declarative.json", "showcase/integrations/built-in-agent/PARITY_NOTES.md", "showcase/integrations/built-in-agent/src/app/demos/_components/not-supported-banner.tsx", "showcase/integrations/built-in-agent/sr...
[]
diff --git a/showcase/scripts/__tests__/generate-catalog.test.ts b/showcase/scripts/__tests__/generate-catalog.test.ts index a7d6080bb45..3c7fe4e390b 100644 --- a/showcase/scripts/__tests__/generate-catalog.test.ts +++ b/showcase/scripts/__tests__/generate-catalog.test.ts @@ -95,7 +95,7 @@ describe("Catalog Generator",...
true
CopilotKit/CopilotKit
5,415
issue_to_patch
chore: release monorepo v1.60.1
## Release monorepo v1.60.1 **Scope:** `monorepo` | **Bump:** `patch` --- ### How this release process works 1. **This PR was created automatically** by the "release / create-pr" workflow. It bumped the `monorepo` packages to `1.60.1` and generated AI-enhanced release notes. 2. **CI runs on this PR** — the f...
8fb13fd602e2bcd1ba6511c3ee9780f8f32f7c27
02c3a8aef0e2eaa4a90a048066b492a862b4bceb
diff --git a/packages/a2ui-renderer/package.json b/packages/a2ui-renderer/package.json index 5700b985b33..0c645cbc14a 100644 --- a/packages/a2ui-renderer/package.json +++ b/packages/a2ui-renderer/package.json @@ -1,6 +1,6 @@ { "name": "@copilotkit/a2ui-renderer", - "version": "1.60.0", + "version": "1.60.1", "...
[ "packages/a2ui-renderer/package.json", "packages/agentcore-runner/package.json", "packages/core/package.json", "packages/react-core/package.json", "packages/react-native/package.json", "packages/react-textarea/package.json", "packages/react-ui/package.json", "packages/runtime-client-gql/package.json",...
[]
true
CopilotKit/CopilotKit
5,408
issue_to_patch
fix: update cpk to use latest agui core packages
## Summary - Bumps `@ag-ui/client`, `@ag-ui/core`, and `@ag-ui/encoder` to `0.0.57` across all packages under `packages/` - Updates `pnpm-lock.yaml` to reflect the new versions ## Test plan - [ ] Verify packages build successfully - [ ] Confirm no runtime regressions in ag-ui communication
089f8ac243dca6d8cca9390ebedea51a674cf91d
246b907ed8be485b91ab30aac89fc7e9e3e5cd8f
diff --git a/packages/agentcore-runner/package.json b/packages/agentcore-runner/package.json index 2743602784a..f42402ecd16 100644 --- a/packages/agentcore-runner/package.json +++ b/packages/agentcore-runner/package.json @@ -31,7 +31,7 @@ "attw": "attw --pack . --profile node16" }, "dependencies": { - "@a...
[ "packages/agentcore-runner/package.json", "packages/angular/package.json", "packages/bot-slack/package.json", "packages/bot-slack/src/sanitizing-http-agent.ts", "packages/bot/package.json", "packages/core/package.json", "packages/demo-agents/package.json", "packages/react-core/package.json", "packag...
[]
diff --git a/showcase/scripts/__tests__/integration-smoke-registry.test.ts b/showcase/scripts/__tests__/integration-smoke-registry.test.ts index 170593cc632..f95a5f33065 100644 --- a/showcase/scripts/__tests__/integration-smoke-registry.test.ts +++ b/showcase/scripts/__tests__/integration-smoke-registry.test.ts @@ -43,...
true
CopilotKit/CopilotKit
5,407
issue_to_patch
fix(showcase): D6 reds remediation — manifest NSF + hygiene (14 integrations) + claude-sdk-python testid/hook fixes (+16 component testids)
## Summary D6 reds remediation across the staging dashboard. Consolidates manifest-level NSF/hygiene fixes for 13 integrations with two targeted claude-sdk-python fixes that surfaced during the per-integration audit. ### What's in scope **Manifest cleanup** (12-14 integrations touched): - Added `not_supported_featur...
1e9d77ec50a4f494e94b5415bc8f250c7797887e
dad8ff0a714ae92f49a30339f670df76a3040c91
diff --git a/showcase/aimock/d6/claude-sdk-python/gen-ui-a2ui-fixed.json b/showcase/aimock/d6/claude-sdk-python/gen-ui-a2ui-fixed.json new file mode 100644 index 00000000000..5c23090a6dd --- /dev/null +++ b/showcase/aimock/d6/claude-sdk-python/gen-ui-a2ui-fixed.json @@ -0,0 +1,36 @@ +{ + "_meta": { + "description":...
[ "showcase/aimock/d6/claude-sdk-python/gen-ui-a2ui-fixed.json", "showcase/aimock/d6/claude-sdk-python/gen-ui-declarative.json", "showcase/integrations/agno/manifest.yaml", "showcase/integrations/built-in-agent/manifest.yaml", "showcase/integrations/claude-sdk-python/manifest.yaml", "showcase/integrations/c...
[]
true
CopilotKit/CopilotKit
5,400
issue_to_patch
feat(showcase): end-to-end run-visibility for fleet — /api/runs + family-silence Slack alerting
## Summary Adds end-to-end **run-visibility** to the showcase fleet — a new data path from queue enqueue → per-family projection → dashboard + Slack alerting: - **Contracts + PB schema**: `EnqueueJobInput.family`, `FleetQueueClient.pruneAged`, run-id/family/worker-id columns on `probe_jobs` / `resource_snapshots`, fl...
f0a39c8bd7419c3be0c0f29b29c0c90d0d86c739
f6edd48ca8480847803831100daa9608bb79a91b
diff --git a/showcase/harness/src/cli/control-plane-run.ts b/showcase/harness/src/cli/control-plane-run.ts index e9271b70c0e..39e5e7c4d3f 100644 --- a/showcase/harness/src/cli/control-plane-run.ts +++ b/showcase/harness/src/cli/control-plane-run.ts @@ -38,6 +38,7 @@ import { createE2eDeepServiceEnumerator } from "../fl...
[ "showcase/harness/src/cli/control-plane-run.ts", "showcase/harness/src/fleet/contracts.test.ts", "showcase/harness/src/fleet/contracts.ts", "showcase/harness/src/fleet/control-plane/control-plane.test.ts", "showcase/harness/src/fleet/control-plane/control-plane.ts", "showcase/harness/src/fleet/control-pla...
[]
diff --git a/showcase/harness/src/fleet/contracts.test.ts b/showcase/harness/src/fleet/contracts.test.ts index 85c7fede216..b6975b83397 100644 --- a/showcase/harness/src/fleet/contracts.test.ts +++ b/showcase/harness/src/fleet/contracts.test.ts @@ -13,6 +13,7 @@ import { runSummaryForServiceJobResult, isWorkerSta...
true
CopilotKit/CopilotKit
5,399
issue_to_patch
fix(cf+dashboard): fleet claim-fairness, supplemental-merge freshness, dashboard drilldown D4 parity
## Summary Bundles two related dashboard/harness lanes that landed together once both reached green: 1. **CF #18 fairness / claim-fair lane** — the 23-commit base (`fix/fleet-claim-fairness` rebased onto its CF7 integration tip `80c5c9402`) carrying claim-spike, cf3/cf4/cf5/cf6/cf7 hardening waves, plus the **CF8 mic...
10d3939a8ebbf65a2d36091e40a11589bba53d9f
b074a47c98791661c4694c4b4d2088f907f6bfc6
diff --git a/showcase/harness/src/fleet/contracts.ts b/showcase/harness/src/fleet/contracts.ts index 479dea0b97d..3bcc0df55b3 100644 --- a/showcase/harness/src/fleet/contracts.ts +++ b/showcase/harness/src/fleet/contracts.ts @@ -117,7 +117,7 @@ export interface ServiceJobMeta { triggered: boolean; /** ISO timesta...
[ "showcase/harness/src/fleet/contracts.test.ts", "showcase/harness/src/fleet/contracts.ts", "showcase/harness/src/fleet/control-plane/control-plane.test.ts", "showcase/harness/src/fleet/control-plane/fleet-health.test.ts", "showcase/harness/src/fleet/control-plane/fleet-health.ts", "showcase/harness/src/fl...
[]
diff --git a/showcase/harness/src/fleet/contracts.test.ts b/showcase/harness/src/fleet/contracts.test.ts index 5d6ce6f8879..85c7fede216 100644 --- a/showcase/harness/src/fleet/contracts.test.ts +++ b/showcase/harness/src/fleet/contracts.test.ts @@ -7,12 +7,15 @@ import { isPoolCommErrorKind, commErrorToStatusSign...
true
CopilotKit/CopilotKit
5,401
issue_to_patch
fix(showcase/shell): runtime-derived backend URLs, docs-host redirects, and middleware/builder hardening (SU)
## Summary End-to-end hardening of the showcase shell's URL plane: - Carries `backendHostPattern` + `docsHost` in the shell runtime config (no longer baked from `registry.json` at Docker build time). Derives demo backend URLs at runtime from the pattern, so a new pattern via env reconfigures every integration on the ...
f4df2c36fdd1c8613d5e3a28e3025d15ed044d24
7f9b63b069bfcc0bf982f39bde72d223e0d8c994
diff --git a/showcase/harness/src/probes/drivers/seo-redirects.ts b/showcase/harness/src/probes/drivers/seo-redirects.ts index 54b732cc251..1a49ac7ff56 100644 --- a/showcase/harness/src/probes/drivers/seo-redirects.ts +++ b/showcase/harness/src/probes/drivers/seo-redirects.ts @@ -353,8 +353,10 @@ const SPECIFIC_FRAMEWO...
[ "showcase/harness/src/probes/drivers/seo-redirects.ts", "showcase/harness/test/fixtures/redirect-decommission/cli-stdout-human.txt", "showcase/harness/test/fixtures/redirect-decommission/cli-stdout.txt", "showcase/scripts/__tests__/generate-registry-pattern.test.ts", "showcase/scripts/__tests__/generate-reg...
[]
diff --git a/showcase/harness/test/fixtures/redirect-decommission/cli-stdout-human.txt b/showcase/harness/test/fixtures/redirect-decommission/cli-stdout-human.txt index e9675eaade0..8b1b1cd5b7b 100644 --- a/showcase/harness/test/fixtures/redirect-decommission/cli-stdout-human.txt +++ b/showcase/harness/test/fixtures/re...
true
CopilotKit/CopilotKit
5,384
issue_to_patch
feat(showcase): writer-identity namespacing on status writes
## Summary Anti-dual-writer defense for the showcase `status` collection — the flap-comb incident class where the legacy monolith scheduler and the fleet writer fight over the same rows. - **Writer identity columns**: new `written_by` / `state_written_at` columns on `status` (two PB migrations, idempotency-symmetric ...
6a1039b1cf0f16006b8362eaa24983b01c80af00
e9bf2ac9d6dba34401da277ae5cb4778b31ae001
diff --git a/showcase/harness/src/alerts/alert-engine.ts b/showcase/harness/src/alerts/alert-engine.ts index d4fd1503596..1df87c04824 100644 --- a/showcase/harness/src/alerts/alert-engine.ts +++ b/showcase/harness/src/alerts/alert-engine.ts @@ -614,6 +614,11 @@ export function createAlertEngine(deps: AlertEngineDeps): ...
[ "showcase/harness/src/alerts/alert-engine.test.ts", "showcase/harness/src/alerts/alert-engine.ts", "showcase/harness/src/cli/results.test.ts", "showcase/harness/src/cli/results.ts", "showcase/harness/src/cli/runner.test.ts", "showcase/harness/src/cli/runner.ts", "showcase/harness/src/events/event-bus.ts...
[]
diff --git a/showcase/harness/src/alerts/alert-engine.test.ts b/showcase/harness/src/alerts/alert-engine.test.ts index bb4285a8695..2bf3ba1bcdb 100644 --- a/showcase/harness/src/alerts/alert-engine.test.ts +++ b/showcase/harness/src/alerts/alert-engine.test.ts @@ -126,6 +126,7 @@ describe("alert-engine", () => { ...
true
CopilotKit/CopilotKit
5,403
issue_to_patch
docs: add gated Microsoft Teams docs
932bd730363baa63d33612a2204c4f32d2bf889d
fd4c1cadc31b19165709fe1ce6a9e12e722b88a8
diff --git a/showcase/shell-docs/public/images/teams-preview-dark.png b/showcase/shell-docs/public/images/teams-preview-dark.png new file mode 100644 index 00000000000..28c662da504 --- /dev/null +++ b/showcase/shell-docs/public/images/teams-preview-dark.png @@ -0,0 +1,3 @@ +version https://git-lfs.github.com/spec/v1 +o...
[ "showcase/shell-docs/public/images/teams-preview-dark.png", "showcase/shell-docs/public/images/teams-preview-light.png", "showcase/shell-docs/src/components/__tests__/early-access-gate.test.tsx", "showcase/shell-docs/src/components/early-access-gate.tsx", "showcase/shell-docs/src/content/docs/meta.json", ...
[]
diff --git a/showcase/shell-docs/src/components/__tests__/early-access-gate.test.tsx b/showcase/shell-docs/src/components/__tests__/early-access-gate.test.tsx index 611b641b634..769965546a4 100644 --- a/showcase/shell-docs/src/components/__tests__/early-access-gate.test.tsx +++ b/showcase/shell-docs/src/components/__te...
true
CopilotKit/CopilotKit
5,394
issue_to_patch
docs(skills): complete v2 API migration across CopilotKit skills
## What Completes the v2 API migration across the CopilotKit agent skills, extending #5345 (which started it for `copilotkit-setup`). Docs only, no runtime code changed. ## Why The journey skills a new user reaches for were still teaching pre-v2 APIs, so copy-pasting their examples failed before anything ran: - `co...
f4df2c36fdd1c8613d5e3a28e3025d15ed044d24
1ec63986ecbf3079e8a0af410a8d56c7be0051ad
diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.json index 0107e8e42a2..c8f54dc1c79 100644 --- a/.claude-plugin/marketplace.json +++ b/.claude-plugin/marketplace.json @@ -13,7 +13,7 @@ "name": "copilotkit", "source": "./", "description": "AI agent skills for CopilotKit — s...
[ ".claude-plugin/marketplace.json", ".claude-plugin/plugin.json", "packages/react-core/skills/react-core/references/chat-components.md", "packages/runtime/skills/runtime/references/wiring-agno.md", "packages/runtime/skills/runtime/references/wiring-external-agents.md", "packages/runtime/skills/runtime/refe...
[]
true
CopilotKit/CopilotKit
5,398
issue_to_patch
chore(examples/integrations): Intelligence 0.5.0 + CopilotKit 1.60.0, drop demo-user provisioning
## What Across the **threads-enabled integration examples** (`examples/integrations/*`, excluding the vestigial `langgraph-python-threads`): 1. **Drop demo-user provisioning** — removes the `provision-user` one-shot service from the shared `_intelligence/docker-compose.yml`. 2. **Bump Intelligence → 0.5.0** — `ghcr.i...
570dd3933614b3cd864f4709b60d16d4cf71e9d9
717cfccedb102d65d4eccb1b8c7f4658c0915918
diff --git a/examples/integrations/_intelligence/docker-compose.yml b/examples/integrations/_intelligence/docker-compose.yml index 10800b4360d..3a766b0f0c5 100644 --- a/examples/integrations/_intelligence/docker-compose.yml +++ b/examples/integrations/_intelligence/docker-compose.yml @@ -87,7 +87,7 @@ services: # --...
[ "examples/integrations/_intelligence/docker-compose.yml", "examples/integrations/a2a-a2ui/package-lock.json", "examples/integrations/a2a-a2ui/package.json", "examples/integrations/a2a-middleware/package-lock.json", "examples/integrations/a2a-middleware/package.json", "examples/integrations/adk/package-loc...
[]
true
CopilotKit/CopilotKit
5,395
issue_to_patch
feat(shell-docs): gate Slack docs behind early-access password
## What does this PR do? Puts the Slack docs behind a shared early-access password. Gated pages render blurred and non-interactive with an unlock card floating above them: - **`/slack`** — the Slack guide, plus every framework-scoped variant (`/<framework>/slack`), opted in via an `earlyAccess: slack` frontmatter fla...
71e2682790b717b08512f5cb484ee6423c2d0585
a028b5fb9195c390ffd50c76f147eff24d5eade3
diff --git a/showcase/shell-docs/public/images/slack-bot-generative-ui-dark.png b/showcase/shell-docs/public/images/slack-bot-generative-ui-dark.png new file mode 100644 index 00000000000..9d5944f556f --- /dev/null +++ b/showcase/shell-docs/public/images/slack-bot-generative-ui-dark.png @@ -0,0 +1,3 @@ +version https:/...
[ "showcase/shell-docs/public/images/slack-bot-generative-ui-dark.png", "showcase/shell-docs/public/images/slack-bot-generative-ui-light.png", "showcase/shell-docs/src/app/__tests__/public-assets.test.ts", "showcase/shell-docs/src/app/reference/[...slug]/page.tsx", "showcase/shell-docs/src/components/__tests_...
[]
diff --git a/showcase/shell-docs/src/app/__tests__/public-assets.test.ts b/showcase/shell-docs/src/app/__tests__/public-assets.test.ts index 70167aee047..3f5b4312b66 100644 --- a/showcase/shell-docs/src/app/__tests__/public-assets.test.ts +++ b/showcase/shell-docs/src/app/__tests__/public-assets.test.ts @@ -27,4 +27,18...
true