repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
9001/copyparty | 1,265 | comment_to_fix | add skip silence option | iirc this eventually causes a stack overflow (or at least poor perofrmance); better to setInterval and then clearInterval at the return on line 10'031? | 9b436eb52e5cfe7a0a8e59dd9f1a37351f3a2abd | 8f4bb8033a74ddc7a0e3a99918f74efffc95b475 | diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js
index 70c623567..eb6d2a65a 100644
--- a/copyparty/web/browser.js
+++ b/copyparty/web/browser.js
@@ -290,6 +290,7 @@ if (1)
"ml_tint": "tint",
"ml_eq": "audio equalizer",
"ml_drc": "dynamic range compressor",
+ "ml_ss": "skip silence",
"mt_l... | [
"copyparty/web/browser.js"
] | [
{
"comment": "iirc this eventually causes a stack overflow (or at least poor perofrmance); better to setInterval and then clearInterval at the return on line 10'031?",
"path": "copyparty/web/browser.js",
"hunk": "@@ -9929,6 +9984,94 @@ function reload_browser() {\n \tdsel_init();\n })();\n \n+function s... | true | ||
9001/copyparty | 1,304 | issue_to_patch | i18n: check/fix finnish | This PR complies with the DCO; https://developercertificate.org/
| 6f1d6647546832c6640cbad88817e28fb63ea3ec | a76898fe5da20ed450e71d6a5c945249062c41e7 | diff --git a/copyparty/web/tl/fin.js b/copyparty/web/tl/fin.js
index cc90d9db6..455d77b55 100644
--- a/copyparty/web/tl/fin.js
+++ b/copyparty/web/tl/fin.js
@@ -84,8 +84,8 @@ Ls.fin = {
["M", "sulje tekstitiedosto"],
["E", "muokkaa tekstitiedostoa"],
["S", "valitse tiedosto (leikkausta/kopiointia/uudelleenn... | [
"copyparty/web/tl/fin.js"
] | [] | true | ||
9001/copyparty | 1,288 | issue_to_patch | add check for alternative clipboard url on ctrl-c | pretty self-explanatory innit
ui options will be added in the far future
This PR complies with the DCO; https://developercertificate.org/
| 0e8913c2d0a6ada66c5344e3190f10ef6dd96c96 | a9614fb5913d14c1e836294c4baeb449008bca74 | diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js
index 10197b564..cffbf1b02 100644
--- a/copyparty/web/browser.js
+++ b/copyparty/web/browser.js
@@ -4622,8 +4622,9 @@ var fileman = (function () {
r.ccp = true;
r.clip = vps.slice(2);
+ var prefix = sread("clip_uo") || location.origin;
try {
-... | [
"copyparty/web/browser.js"
] | [
{
"comment": "```suggestion\n\t\tvar prefix = sread(\"clip_uo\") || location.origin;\n```\n\"url-origin\" because \"au\" makes it sound audio-related, wdyt?",
"path": "copyparty/web/browser.js",
"hunk": "@@ -4622,8 +4622,9 @@ var fileman = (function () {\n \t\tr.ccp = true;\n \t\tr.clip = vps.slice(2);\... | true | ||
9001/copyparty | 1,303 | issue_to_patch | Music player crashes with high ffwd values
### Describe the bug
When setting the ffwd on the skip silence feature to a value like 100, it brings you to the crash page
### To Reproduce
set ffwd to 100, and play some audio file in the copyparty webui
(tested on https://a.ocv.me/pub/demo/music/aivi%20%26%20surasshu%20-%... | audioplayer: "fix" s-s error with high fade value (+extra) | fixes #1302 (sort of)
- the current fade config value was kinda doing what ffwd was supposed to
- solution: remove it. there isn't much point in having a fade config value as changing it doesn't make much of a difference except at extreme values (0.2 seems fine). having it is just extra confusion
- browsers stop p... | 6f1d6647546832c6640cbad88817e28fb63ea3ec | 5120f8ab48bb5c57911cf0dad75d2add849d2eee | diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js
index 5428f5c2f..2b0425f7a 100644
--- a/copyparty/web/browser.js
+++ b/copyparty/web/browser.js
@@ -332,8 +332,7 @@ if (1)
"mt_ssvt": "volume threshold (0-255)\">vol",
"mt_ssts": "active threshold (% of track, start)\">start",
"mt_sste": "active ... | [
"copyparty/web/browser.js",
"copyparty/web/tl/chi.js",
"copyparty/web/tl/cze.js",
"copyparty/web/tl/deu.js",
"copyparty/web/tl/epo.js",
"copyparty/web/tl/fra.js",
"copyparty/web/tl/grc.js",
"copyparty/web/tl/hun.js",
"copyparty/web/tl/ita.js",
"copyparty/web/tl/jpn.js",
"copyparty/web/tl/kor.js"... | [] | true | |
9001/copyparty | 1,299 | issue_to_patch | Support 4-digit octal values for `chmod_d` and `chmod_f` | Currently, the validation for the `chmod_d` and `chmod_f` volume flags only accepts 3-digit octal values. This prevents users from applying special permission bits (setuid, setgid, and the sticky bit), which are useful for shared group directories.
```
config-option 'chmod_d' must be a three-digit octal value such ... | d067d2a6384e159d4d950a4a596a1f91af14f0c5 | 7efea9622a1cfa3424c29fd83471af844b0c4026 | diff --git a/copyparty/__main__.py b/copyparty/__main__.py
index bdefacfc5..fc843b87d 100644
--- a/copyparty/__main__.py
+++ b/copyparty/__main__.py
@@ -1059,13 +1059,17 @@ def get_sects():
similarly, \033[33m--chmod-d\033[0m and \033[33mchmod_d\033[0m sets the directory/folder perm
- the va... | [
"copyparty/__main__.py",
"copyparty/authsrv.py",
"docs/chungus.conf"
] | [] | true | ||
9001/copyparty | 1,298 | issue_to_patch | Add Hungarian translation | To show that your contribution is compatible with the MIT License, please include the following text somewhere in this PR description:
This PR complies with the DCO; https://developercertificate.org/
| d067d2a6384e159d4d950a4a596a1f91af14f0c5 | 718e6b86855e70096290786d0dec67ff02784377 | diff --git a/copyparty/web/tl/hun.js b/copyparty/web/tl/hun.js
new file mode 100644
index 000000000..70bafa703
--- /dev/null
+++ b/copyparty/web/tl/hun.js
@@ -0,0 +1,726 @@
+Ls.hun = {
+ "tt": 'Magyar',
+
+ "cols": {
+ "c": 'műveletek',
+ "dur": 'hossz',
+ "q": 'minőség / bitrate',
+ "Ac": 'audió kodek',
+ "Vc": '... | [
"copyparty/web/tl/hun.js"
] | [] | true | ||
9001/copyparty | 1,297 | issue_to_patch | Extra Esperanto tweaks | Made some labels on the silence skip config clearer ("ek" is a prefix that means "to start doing something", and is often used as a word itself, meaning "start" or "go"), fixed some grammar, replaced old English-based labels for `ct_dl` and `ct_ihop` ("g" in "g⮯" meant "gallery", right?)
To show that your contributi... | d067d2a6384e159d4d950a4a596a1f91af14f0c5 | 131a6bf59de686576062f99148912c8de0bb1cae | diff --git a/copyparty/web/tl/epo.js b/copyparty/web/tl/epo.js
index a41c208be..3e09ce6bb 100644
--- a/copyparty/web/tl/epo.js
+++ b/copyparty/web/tl/epo.js
@@ -114,7 +114,7 @@ Ls.epo = {
"login": "Ensaluti",
"access": " atingo",
"ot_close": "fermi submenuon",
- "ot_search": "`serĉi dosierojn per atributoj, indik... | [
"copyparty/web/tl/epo.js"
] | [] | true | ||
9001/copyparty | 1,229 | issue_to_patch | Esperanto translation update | Important changes:
The "shift" key is called "MAJ" (short for "majuskla" for "uppercase") in the translation, so the new lines have been updated to match.
"beligi json" is technically a valid string (proper names from other languages don't have to be grammatically modified), but the "-on" ending *could* be confus... | dc8c229bcdc49419f16c983fe1f97d9d1e57bde2 | ac9b220a3cfffc5919e80f08fa51240bd1df0e88 | diff --git a/copyparty/web/tl/epo.js b/copyparty/web/tl/epo.js
index af497407f..c55ba251c 100644
--- a/copyparty/web/tl/epo.js
+++ b/copyparty/web/tl/epo.js
@@ -84,8 +84,8 @@ Ls.epo = {
["M", "fermi dosieron"],
["E", "redakti dosieron"],
["S", "elekti dosieron (por eltondado/kopiado/alinomado)"],
- ["Y", ... | [
"copyparty/web/tl/epo.js"
] | [] | true | ||
9001/copyparty | 1,292 | issue_to_patch | Update Esperanto translation | Most `//m` lines are okay, but some suffered from english-isms or needed grammar/capitalization fixes.
To show that your contribution is compatible with the MIT License, please include the following text somewhere in this PR description:
This PR complies with the DCO; https://developercertificate.org/
| d44ea245307c06eb060b6e6f5c2cba91a759c940 | 320d8711138c452a3fbe14571b66c0cd97c69740 | diff --git a/copyparty/web/tl/epo.js b/copyparty/web/tl/epo.js
index 0d3a967e3..61361fc05 100644
--- a/copyparty/web/tl/epo.js
+++ b/copyparty/web/tl/epo.js
@@ -336,7 +336,7 @@ Ls.epo = {
"mm_eunk": "Nekonata eraro",
"mm_e404": "Ne povas ludi aŭdiaĵon; eraro 404: Dosiero ne trovita.",
"mm_e403": "Ne povas ludi aŭ... | [
"copyparty/web/tl/epo.js"
] | [] | true | ||
9001/copyparty | 1,296 | issue_to_patch | Esperanto translation: silence skipping | Some of the descriptions are guesses at this point (I assume "atk" functions like the "attack" value in an ADSR envelope, setting the amount of time during which the volume/speed changes)
To show that your contribution is compatible with the MIT License, please include the following text somewhere in this PR descrip... | 0ca4c1bda4032f32150b84f00acca7ecf90a7502 | 50d5f89af59b28c17e0b369b3560a0ad7b8acd10 | diff --git a/copyparty/web/tl/epo.js b/copyparty/web/tl/epo.js
index 9217374b8..a41c208be 100644
--- a/copyparty/web/tl/epo.js
+++ b/copyparty/web/tl/epo.js
@@ -283,7 +283,7 @@ Ls.epo = {
"ml_tint": "kolorado",
"ml_eq": "ekvalizilo",
"ml_drc": "kompresoro",
- "ml_ss": "preterpasi silenton", //m
+ "ml_ss": "preter... | [
"copyparty/web/tl/epo.js"
] | [] | true | ||
9001/copyparty | 1,287 | issue_to_patch | opds: add opensearch support | Tested with koreader and works great!
Discussed with original OPDS author @Scotsguy here
https://github.com/9001/copyparty/pull/779#issuecomment-3482160504
Bassed on these specs
https://specs.opds.io/opds-1.2#3-search
https://github.com/koreader/koreader/pull/7380
To show that your contribution is compa... | d44ea245307c06eb060b6e6f5c2cba91a759c940 | 01cbf4592076eaff57f325e645295df72dd6f40a | diff --git a/copyparty/httpcli.py b/copyparty/httpcli.py
index cb915bba5..3f84bb178 100644
--- a/copyparty/httpcli.py
+++ b/copyparty/httpcli.py
@@ -168,9 +168,9 @@
(0o644, -1, -1, 1, 1000, 1000, 8, 0x39230101, 0x39230101, 0x39230101)
)
-RE_CC = re.compile(r"[\x00-\x1f]") # search always faster
-RE_USAFE = re.... | [
"copyparty/httpcli.py",
"copyparty/httpsrv.py",
"copyparty/web/opds.xml",
"copyparty/web/opds_osd.xml",
"scripts/sfx.ls"
] | [
{
"comment": "For the sake of being language-agnostic, is this title necessary? Will clients synthesize a name when the title isn't specified, or will they ignore the search description instead?\n\nThe OPDS spec is (of course) light on details, but they don't seem to include the title in their example link",
... | true | ||
9001/copyparty | 1,282 | issue_to_patch | GraalPy improvements | - Implements `ifaddr` on GraalPy by using Java's network interface APIs. (cursed!)
- Works around a partially broken `inet_pton` implementation when using GraalPy's Java POSIX backend
This PR complies with the DCO; https://developercertificate.org/
| d69283809581cfb7eb188c57468656944a05e0df | 821a509064e008f17b5b654ccaba051a2eee4479 | diff --git a/copyparty/util.py b/copyparty/util.py
index 78d403f24..d680b5af3 100644
--- a/copyparty/util.py
+++ b/copyparty/util.py
@@ -270,6 +270,20 @@ def __call__(self, msg: str, c: Union[int, str] = 0) -> None:
socket.inet_pton(socket.AF_INET6, "::1")
HAVE_IPV6 = True
+
+ if GRAAL:
+ try:
+ ... | [
"copyparty/util.py"
] | [] | true | ||
9001/copyparty | 1,281 | issue_to_patch | Don't show right-click menu in file viewer; fixes #1280 | The right-click menu was still enabled in the text viewer (`?doc=`). Now it checks for that url and doesn't open the menu when it finds it.
(This PR complies with the DCO; https://developercertificate.org/)
| a368fc66b35e2fbc39e5109dc32da32777299a6a | cab51406080b7619188fa24f2d85b094f153ca07 | diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js
index 17787ca11..a2c7311b8 100644
--- a/copyparty/web/browser.js
+++ b/copyparty/web/browser.js
@@ -9753,7 +9753,7 @@ var rcm = (function () {
}
ebi('wrap').oncontextmenu = function(e) {
- if (!r.enabled || e.shiftKey || (r.double && menu.style.dis... | [
"copyparty/web/browser.js"
] | [] | true | ||
9001/copyparty | 1,266 | issue_to_patch | Support for JPEG XL (.jxl) image previews and thumbnails
**Is your feature request related to a problem? Please describe.**
Currently, Copyparty does not recognize or generate thumbnails for JPEG XL (`.jxl`) image files. When I upload `.jxl` files, they are treated as generic files rather than images. This means:
* ... | web, th: rudimentary jxl support | Fixes #724.
Not pretending this is mergeable as-is, I'm just putting it out here to be told where exactly I'm an idiot or something.
Ideally, I want to plumb progressive decoding through libvips for thumbnailing, to generate thumbnails with zero CPU load. If that's not crazy enough, we can even do thumbnailing vi... | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/contrib/plugins/graft-thumbs.js b/contrib/plugins/graft-thumbs.js
index 65046e68e..20d5abd41 100644
--- a/contrib/plugins/graft-thumbs.js
+++ b/contrib/plugins/graft-thumbs.js
@@ -36,7 +36,7 @@
for (var a = 0; a < files.length; a++) {
var file = files[a],
- is_pic = /\.(jpe?g|png|gif|webp)$/i.e... | [
"contrib/plugins/graft-thumbs.js",
"copyparty/__main__.py",
"copyparty/sutil.py",
"copyparty/th_cli.py",
"copyparty/th_srv.py",
"copyparty/web/baguettebox.js",
"copyparty/web/browser.js",
"docs/chungus.conf"
] | [
{
"comment": "```suggestion\n re_i = /^[^?]+\\.(a?png|avif|bmp|gif|heif|jfif|jpe?g|jxl|svg|tiff?|webp)(\\?|$)/i,\n```",
"path": "copyparty/web/baguettebox.js",
"hunk": "@@ -36,10 +36,10 @@ window.baguetteBox = (function () {\n touchFlag = false, // busy\n scrollCSS = ['', ''],\n ... | true | |
9001/copyparty | 1,266 | comment_to_fix | web, th: rudimentary jxl support | ```suggestion
re_i = /^[^?]+\.(a?png|avif|bmp|gif|heif|jfif|jpe?g|jxl|svg|tiff?|webp)(\?|$)/i,
``` | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/copyparty/web/baguettebox.js b/copyparty/web/baguettebox.js
index 4b132a494..c8fbeecbf 100644
--- a/copyparty/web/baguettebox.js
+++ b/copyparty/web/baguettebox.js
@@ -36,7 +36,7 @@ window.baguetteBox = (function () {
touchFlag = false, // busy
scrollCSS = ['', ''],
scrollTimer ... | [
"copyparty/web/baguettebox.js"
] | [
{
"comment": "```suggestion\n re_i = /^[^?]+\\.(a?png|avif|bmp|gif|heif|jfif|jpe?g|jxl|svg|tiff?|webp)(\\?|$)/i,\n```",
"path": "copyparty/web/baguettebox.js",
"hunk": "@@ -36,10 +36,10 @@ window.baguetteBox = (function () {\n touchFlag = false, // busy\n scrollCSS = ['', ''],\n ... | true | ||
9001/copyparty | 1,266 | comment_to_fix | web, th: rudimentary jxl support | ```suggestion
cbz_pics = ["png", "jpg", "jpeg", "gif", "bmp", "tga", "tif", "tiff", "webp", "avif"],
``` | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/copyparty/web/baguettebox.js b/copyparty/web/baguettebox.js
index 4b132a494..c8fbeecbf 100644
--- a/copyparty/web/baguettebox.js
+++ b/copyparty/web/baguettebox.js
@@ -36,7 +36,7 @@ window.baguetteBox = (function () {
touchFlag = false, // busy
scrollCSS = ['', ''],
scrollTimer ... | [
"copyparty/web/baguettebox.js"
] | [
{
"comment": "```suggestion\n cbz_pics = [\"png\", \"jpg\", \"jpeg\", \"gif\", \"bmp\", \"tga\", \"tif\", \"tiff\", \"webp\", \"avif\"],\n```",
"path": "copyparty/web/baguettebox.js",
"hunk": "@@ -36,10 +36,10 @@ window.baguetteBox = (function () {\n touchFlag = false, // busy\n ... | true | ||
9001/copyparty | 1,266 | comment_to_fix | web, th: rudimentary jxl support | ```suggestion
var cached = window['have_' + format];
``` | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/copyparty/web/browser.js b/copyparty/web/browser.js
index eb6d2a65a..17787ca11 100644
--- a/copyparty/web/browser.js
+++ b/copyparty/web/browser.js
@@ -1154,22 +1154,26 @@ function read_sbw() {
onresize100.add(read_sbw, true);
-var have_webp = sread('have_webp');
-(function () {
- if (have_webp !== nu... | [
"copyparty/web/browser.js"
] | [
{
"comment": "```suggestion\n\tvar cached = window['have_' + format];\n```",
"path": "copyparty/web/browser.js",
"hunk": "@@ -1147,22 +1147,26 @@ function read_sbw() {\n onresize100.add(read_sbw, true);\n \n \n-var have_webp = sread('have_webp');\n-(function () {\n-\tif (have_webp !== null)\n+function c... | true | ||
9001/copyparty | 1,266 | comment_to_fix | web, th: rudimentary jxl support | ```suggestion
if rem.startswith(".hist/th/") and rem.split(".")[-1] in IMG_EXTS:
``` | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/copyparty/th_cli.py b/copyparty/th_cli.py
index 384316eeb..5297b6b90 100644
--- a/copyparty/th_cli.py
+++ b/copyparty/th_cli.py
@@ -8,7 +8,7 @@
from .__init__ import TYPE_CHECKING
from .authsrv import VFS
from .bos import bos
-from .th_srv import EXTS_AC, HAVE_WEBP, thumb_path
+from .th_srv import EXTS_... | [
"copyparty/th_cli.py"
] | [
{
"comment": "```suggestion\n if rem.startswith(\".hist/th/\") and rem.split(\".\")[-1] in IMG_EXTS:\n```",
"path": "copyparty/th_cli.py",
"hunk": "@@ -89,10 +90,10 @@ def get(self, dbv: VFS, rem: str, mtime: float, fmt: str) -> Optional[str]:\n \n preferred = self.args.th_dec[0] if self.... | true | ||
9001/copyparty | 1,266 | comment_to_fix | web, th: rudimentary jxl support | ```suggestion
IMG_EXTS = set(["webp", "jpg", "png", "jxl"])
``` | 6694998985e98326ca4ca0a0724cfd4901be2430 | fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef | diff --git a/copyparty/th_cli.py b/copyparty/th_cli.py
index 384316eeb..5297b6b90 100644
--- a/copyparty/th_cli.py
+++ b/copyparty/th_cli.py
@@ -8,7 +8,7 @@
from .__init__ import TYPE_CHECKING
from .authsrv import VFS
from .bos import bos
-from .th_srv import EXTS_AC, HAVE_WEBP, thumb_path
+from .th_srv import EXTS_... | [
"copyparty/th_cli.py"
] | [
{
"comment": "```suggestion\n\n\nIMG_EXTS = set([\"webp\", \"jpg\", \"png\", \"jxl\"])\n```",
"path": "copyparty/th_cli.py",
"hunk": "",
"resolving_sha": "fe4d560e4ab9cb2f7cd221943e32a5bf25f649ef",
"resolving_diff": "diff --git a/copyparty/th_cli.py b/copyparty/th_cli.py\nindex 384316eeb..5297b6... | true | ||
9001/copyparty | 1,260 | issue_to_patch | add support for GraalPy | just turns off some things that fail when running on [GraalPy](https://www.graalvm.org/python/).
This PR complies with the DCO; https://developercertificate.org/
| 22cdc0f8c98e6be3ef5573a273b78c0def853192 | eecb1b13e7f074e097b0286b8772a2bb1902fe72 | diff --git a/copyparty/__init__.py b/copyparty/__init__.py
index afb05d182..c844853d9 100644
--- a/copyparty/__init__.py
+++ b/copyparty/__init__.py
@@ -44,6 +44,8 @@
MACOS = platform.system() == "Darwin"
+GRAAL = platform.python_implementation() == "GraalVM"
+
EXE = bool(getattr(sys, "frozen", False))
try:
di... | [
"copyparty/__init__.py",
"copyparty/stolen/ifaddr/__init__.py",
"copyparty/util.py"
] | [] | true | ||
9001/copyparty | 1,257 | issue_to_patch | Fix `nth` and `nih` | This removes `nth` (which didn't actually do anything) and makes `nih` do what it should have done.
I tried to implement it as I think it was intended, please tell me if there are some other reasons that it was like this or if there are other changes to make.
(This PR complies with the DCO; https://developercertificate... | 2f57228fd4e62f8cd8e12cb80a3531dc2d4d170a | a155d5b869d977b00130dbf068112da8b105cb69 | diff --git a/copyparty/__main__.py b/copyparty/__main__.py
index 1ae4eec8b..2e2c5080d 100644
--- a/copyparty/__main__.py
+++ b/copyparty/__main__.py
@@ -1558,9 +1558,8 @@ def add_optouts(ap):
ap2.add_argument("--no-mv", action="store_true", help="disable move/rename operations")
ap2.add_argument("--no-cp", ac... | [
"copyparty/__main__.py",
"copyparty/web/browser.js"
] | [] | true | ||
9001/copyparty | 1,259 | issue_to_patch | Add checkconfig function to OpenRC script | I found it slightly cumbersome to write a config when the only feedback OpenRC gives is `crashed`, so I added a small QOL function to run copyparty with the `--exit cfg` flag directly from the service.
This PR complies with the DCO; https://developercertificate.org/
| 2f57228fd4e62f8cd8e12cb80a3531dc2d4d170a | fd1434770fff5dfd495b6e9c4035b0a5fc886152 | diff --git a/contrib/openrc/copyparty b/contrib/openrc/copyparty
index d9e39b374..85fa6a827 100644
--- a/contrib/openrc/copyparty
+++ b/contrib/openrc/copyparty
@@ -9,10 +9,19 @@
# you may want to:
# change '/usr/bin/python' to another interpreter
# change '/mnt::rw' to another location or permission-set
+# us... | [
"contrib/openrc/copyparty"
] | [] | true | ||
9001/copyparty | 1,240 | issue_to_patch | WebDAV `x-oc-mtime` header fails on decimal timestamps
<!-- NOTE:
**please use english, or include an english translation.** aside from that,
all of the below are optional, consider them as inspiration, delete and rewrite at will, thx md -->
### Describe the bug
Some WebDAV clients (notably Tampermonkey sync) send... | fix: update `utime_c` to accept float timestamps | Some WebDAV clients (e.g., Tampermonkey sync) send `x-oc-mtime` as a decimal string. Copyparty previously used `int(...)`, which raises `ValueError` for decimal inputs. Python’s `os.utime` accepts float timestamps, so it’s safe to pass floats and preserve sub-second precision where supported.
I updated `bos.utime_c`... | d750f3f0d2a2daf0466f73c4d81dfae6b68f63ef | 6cb1a235bb370f053e02d8c347a840f11254dd07 | diff --git a/copyparty/bos/bos.py b/copyparty/bos/bos.py
index 9013a0661..7aadb2cfe 100644
--- a/copyparty/bos/bos.py
+++ b/copyparty/bos/bos.py
@@ -106,14 +106,14 @@ def utime(
def utime_c(
log: Union["NamedLogger", Any],
p: str,
- ts: int,
+ ts: float,
follow_symlinks: bool = True,
throw: b... | [
"copyparty/bos/bos.py",
"copyparty/httpcli.py",
"tests/test_webdav.py"
] | [
{
"comment": "could be a bit extra here and add a try-catch to ignore mtime when invalid, e.g.\n\n```py\n def _parse_x_oc_mtime(self, raw: str) -> Optional[float]:\n try:\n return float(raw)\n except ValueError:\n self.log(\"invalid x-oc-mtime header %r\" % (raw,), 6)\n ... | diff --git a/tests/test_webdav.py b/tests/test_webdav.py
index d7618a031..7714b61ba 100644
--- a/tests/test_webdav.py
+++ b/tests/test_webdav.py
@@ -63,6 +63,20 @@
fgsfds"""
+RCLONE_PUT_FLOAT = """PUT /%s HTTP/1.1
+Host: 127.0.0.1:3923
+User-Agent: rclone/v1.67.0
+Content-Length: 6
+Authorization: Basic azp1
+Cont... | true |
9001/copyparty | 1,238 | issue_to_patch | update web dependency - prism | * Update prism from 1.29.0 to 1.30.0.
* Separate the plugins into their own array (similar to langs).
* Add some more langs to highlight.
This PR complies with the DCO; https://developercertificate.org/
| d750f3f0d2a2daf0466f73c4d81dfae6b68f63ef | f2ba7aca61316fae7b0f63fcf2b6808be88d8c93 | diff --git a/scripts/deps-docker/Dockerfile b/scripts/deps-docker/Dockerfile
index 6ea7966e5..93931ea42 100644
--- a/scripts/deps-docker/Dockerfile
+++ b/scripts/deps-docker/Dockerfile
@@ -7,7 +7,7 @@ ENV ver_asmcrypto=c72492f4a66e17a0e5dd8ad7874de354f3ccdaa5 \
ver_mde=2.18.0 \
ver_codemirror=5.65... | [
"scripts/deps-docker/Dockerfile",
"scripts/deps-docker/genprism.sh"
] | [] | true | ||
9001/copyparty | 1,245 | issue_to_patch | Portuguese translation fixes | Fixed the broken newlines ($n and $N$n) and adjusted the wording of a few strings.
@4ntsy in case you want to check my changes
To show that your contribution is compatible with the MIT License, please include the following text somewhere in this PR description:
This PR complies with the DCO; https://developercer... | 5c4ba376a0356637598397272959d37e6a96e7fb | a3f8c7af64aac80d5db13a89cc85f94d041ffa6f | diff --git a/copyparty/web/tl/por.js b/copyparty/web/tl/por.js
index 29aea56cd..6fd11845e 100644
--- a/copyparty/web/tl/por.js
+++ b/copyparty/web/tl/por.js
@@ -84,8 +84,8 @@ Ls.por = {
["M", "fechar arquivo de texto"],
["E", "editar arquivo de texto"],
["S", "selecionar arquivo (para recortar/copiar/renome... | [
"copyparty/web/tl/por.js"
] | [] | true | ||
ACINQ/eclair | 3,318 | issue_to_patch | Send `splice_locked` if necessary while reconnecting | When we lock a commitment while reconnecting (because the funding/splice transaction confirms or when we're using zero-conf), we currently have a bug where if we've sent our `channel_reestablish` but we haven't received the remote `channel_reestablish`, we will not send `splice_locked` which results in a mismatch in th... | 2dda79468a8b69a2acf7962cdac63245f7cc3ee8 | 02fad5144867ad3fe04cb689a2e53aa2ce162d15 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index 1eef0ad982..0753320adb 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
index 182c627c53..37957ff47d 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc... | true | |
ACINQ/eclair | 3,313 | issue_to_patch | Back to dev | After the 0.14.0 release. | ec8c63b215b98148887237e3f050342a6ca61f4c | 52ce93d04a6ccf6412f76fd9f545d64175032a1d | diff --git a/.mvn/maven.config b/.mvn/maven.config
index e92391eb19..acf51640eb 100644
--- a/.mvn/maven.config
+++ b/.mvn/maven.config
@@ -2,7 +2,7 @@
-Daether.trustedChecksumsSource.summaryFile=true
-Daether.trustedChecksumsSource.summaryFile.basedir=${session.rootDirectory}/.mvn/checksums/
# post processor: truste... | [
".mvn/maven.config",
"docs/release-notes/eclair-vnext.md",
"eclair-core/pom.xml",
"eclair-front/pom.xml",
"eclair-fuzz/pom.xml",
"eclair-node/pom.xml",
"eclair-node/src/main/scala/fr/acinq/eclair/Boot.scala",
"pom.xml"
] | [] | true | ||
ACINQ/eclair | 3,312 | issue_to_patch | Eclair v0.14.0 release | 0896d03b361a3fff54b6378b0e5fe0424e7c4d95 | e6033a5eff8e3ca1c7f3fe08cfc7122ad2304599 | diff --git a/.mvn/maven.config b/.mvn/maven.config
index acf51640eb..e92391eb19 100644
--- a/.mvn/maven.config
+++ b/.mvn/maven.config
@@ -2,7 +2,7 @@
-Daether.trustedChecksumsSource.summaryFile=true
-Daether.trustedChecksumsSource.summaryFile.basedir=${session.rootDirectory}/.mvn/checksums/
# post processor: truste... | [
".mvn/maven.config",
"docs/release-notes/eclair-v0.14.0.md",
"eclair-core/pom.xml",
"eclair-front/pom.xml",
"eclair-fuzz/pom.xml",
"eclair-node/pom.xml",
"eclair-node/src/main/scala/fr/acinq/eclair/Boot.scala",
"pom.xml"
] | [] | true | |||
ACINQ/eclair | 3,311 | issue_to_patch | Fix Bolt12 path fee hiding | When using blinded paths in our Bolt12 invoices, we may use a feature where instead of making the payer pay the fees for the blinded path, we deduce them from the amount we wish to receive (the recipient pays for the privacy it gains from using blinded paths, instead of making the payer pay for something that they didn... | 35403401008228c71e9ae301bde5092101e9b38f | 3ac6036ab1908d839772bea3e206d059089ada4b | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index 87741f1ab9..ad4d14e75f 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -734,11 +734,10 @@ eclair {
offers {
// Minimum length of an o... | [
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/payment/offer/OfferManager.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/payment/OfferPaymentSpec.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/payment/offer/OfferManagerSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/payment/OfferPaymentSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/payment/OfferPaymentSpec.scala
index 74ed201526..08ba8c4c24 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/payment/OfferPayme... | true | |
ACINQ/eclair | 3,192 | issue_to_patch | Add support for zero-fee commitment format | We add support for the zero-fee commitment format specified in https://github.com/lightning/bolts/pull/1228.
Channels using this commitment format benefit from better protection against pinning attacks (thanks to TRUC/v3 transactions), don't need the `update_fee` mechanism, have less dust exposure risk, and use an o... | 06538ada07403e06b8a9dfaa59fb1c554841a3a4 | 8c75c5caa7f47ee228ff318f528fc62f92505f88 | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index b81810ede4..5fa0e55f4e 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -64,6 +64,26 @@ To open a taproot channel with a node that supports the `option_simple_taproot`
$ eclair-cli open... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/Features.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/blockchain/fee/OnChainFeeConf.scala",
"eclair-core/... | [
{
"comment": "Can this create compatibility issues with other implementations?",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -117,8 +118,10 @@ eclair {\n timeout = 60 seconds\n }\n \n- dust-limit-satoshis = 546\n- max-remote-dust-limit-satoshis = 600\n+ // Now... | diff --git a/eclair-core/src/test/resources/bolt3-tx-test-vectors-zero-fee-commitment-format.json b/eclair-core/src/test/resources/bolt3-tx-test-vectors-zero-fee-commitment-format.json
new file mode 100644
index 0000000000..21cb15f76e
--- /dev/null
+++ b/eclair-core/src/test/resources/bolt3-tx-test-vectors-zero-fee-com... | true | |
ACINQ/eclair | 3,192 | comment_to_fix | Add support for zero-fee commitment format | Can this create compatibility issues with other implementations? | 06538ada07403e06b8a9dfaa59fb1c554841a3a4 | 8c75c5caa7f47ee228ff318f528fc62f92505f88 | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index 64a988c122..87741f1ab9 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -76,6 +76,7 @@ eclair {
option_quiesce = optional
option_att... | [
"eclair-core/src/main/resources/reference.conf"
] | [
{
"comment": "Can this create compatibility issues with other implementations?",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -117,8 +118,10 @@ eclair {\n timeout = 60 seconds\n }\n \n- dust-limit-satoshis = 546\n- max-remote-dust-limit-satoshis = 600\n+ // Now... | true | ||
ACINQ/eclair | 3,192 | comment_to_fix | Add support for zero-fee commitment format | A comment would be welcome here, as it's not obvious at all for a script newbie like myself. | 06538ada07403e06b8a9dfaa59fb1c554841a3a4 | 8c75c5caa7f47ee228ff318f528fc62f92505f88 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala b/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala
index a9b9c981a5..d53e614275 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala
+++ b/eclair-core/src/main/scala/fr/ac... | [
"eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala"
] | [
{
"comment": "A comment would be welcome here, as it's not obvious at all for a script newbie like myself.",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala",
"hunk": "@@ -190,6 +217,11 @@ object Transactions {\n }\n object RedeemInfo {\n sealed trait SegwitV0... | true | ||
ACINQ/eclair | 3,298 | issue_to_patch | Change RBF feerate bump rule to match BIP125 | The 25/24 multiplicative feerate bump for `tx_init_rbf` can produce increments too small for Bitcoin Core to relay the replacement transaction under BIP125's minimum relay fee policy (default `incrementalRelayFee` of 0.1 sat/vB since Bitcoin Core v30.0). Add a minimum additive increment of 25 sat/kw alongside the exist... | 872cb663f56e3319878388027e183bf7101daee3 | cdf56d75a265969759b3cbea05d0ad4b65d1e947 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala
index b054ecc980..4eca2bee1a 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala
+++ b/eclair-c... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala"
] | [] | true | ||
ACINQ/eclair | 3,310 | issue_to_patch | Update features early on reconnection | Otherwise some upgrade paths may fail. | befdcd5444f49aca72b30c8281d807321d13aba8 | d395c5509180936d771cae00c54ec2279bb94287 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 230f2dd073..2029377ee4 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "I think we can get rid of all the changes to that file *and* the calls to `updateFeatures` if we simply call `updateFeatures` once in `Peer.scala`, in `gotoConnect`. This way the channel actor directly receives its data with updated features and this whole class of bugs disappears, and removes the... | true | ||
ACINQ/eclair | 3,310 | comment_to_fix | Update features early on reconnection | I think we can get rid of all the changes to that file *and* the calls to `updateFeatures` if we simply call `updateFeatures` once in `Peer.scala`, in `gotoConnect`. This way the channel actor directly receives its data with updated features and this whole class of bugs disappears, and removes the clunkyness of having ... | befdcd5444f49aca72b30c8281d807321d13aba8 | d395c5509180936d771cae00c54ec2279bb94287 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index 407f0cb903..af889c5140 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "I think we can get rid of all the changes to that file *and* the calls to `updateFeatures` if we simply call `updateFeatures` once in `Peer.scala`, in `gotoConnect`. This way the channel actor directly receives its data with updated features and this whole class of bugs disappears, and removes the... | true | ||
ACINQ/eclair | 3,308 | issue_to_patch | Fix edge case in `availableBalanceForSend/Receive` | There was a small discrepancy between `availableBalanceForSend/Receive` and `canSendAdd/canReceiveAdd` when the sender is not paying the commit tx fees. In `canSendAdd/canReceiveAdd`, we verify that the receiver (who pays the commit fees) can still pay those fees after adding the new HTLC to the commit tx. In `availabl... | e1330154a5ba23bed2b94198c90b25054c48c7b3 | fed51a4ff65a83387adb8c3f4777f92d8dc4eab8 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 5a630f50df..2af018db84 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala"
] | [] | true | ||
ACINQ/eclair | 3,306 | issue_to_patch | Compute channel keys once on startup | We compute channel keys when we load and verify channels from our database, and pass them along instead of re-computing them later (which can be expensive when done at scale).
Implemented by @sstone, with small modifications by @t-bast.
Alternative to #3296 | cb8f6c8997c810b094eea9cc5c2ecf3ecc9c1667 | 58fbb33254dcd2b52b92c59132ada1cf47f4ed06 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala b/eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala
index bacd948555..59c3433367 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala
@@ -16,7 +16,7 @@
... | [
"eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelData.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/Switchboa... | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala
index 5a93b17dbc..18c6242efb 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/Min... | true | |
ACINQ/eclair | 3,305 | issue_to_patch | Bump org.postgresql:postgresql version | This fixes a vulnerability, which doesn't apply to eclair in known deployements, but is worth fixing in case some nodes use untrusted database hosts which could lead to DoS attacks.
Please verify the checksums.
Replaces #3304 | cb8f6c8997c810b094eea9cc5c2ecf3ecc9c1667 | a86a2293cd4cf272bdee918956d1bd9299e9873c | diff --git a/.mvn/checksums/checksums-central.sha256 b/.mvn/checksums/checksums-central.sha256
index 2182f6ed6d..302b72a978 100644
--- a/.mvn/checksums/checksums-central.sha256
+++ b/.mvn/checksums/checksums-central.sha256
@@ -128,6 +128,7 @@
191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesa... | [
".mvn/checksums/checksums-central.sha256",
"eclair-core/pom.xml"
] | [
{
"comment": "Checks out with official release page checksum: https://github.com/pgjdbc/pgjdbc/releases/tag/REL42.7.11",
"path": ".mvn/checksums/checksums-central.sha256",
"hunk": "@@ -128,6 +128,7 @@\n 191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesafe/akka/akka-cluster-tool... | true | ||
ACINQ/eclair | 3,305 | comment_to_fix | Bump org.postgresql:postgresql version | Checks out with official release page checksum: https://github.com/pgjdbc/pgjdbc/releases/tag/REL42.7.11 | cb8f6c8997c810b094eea9cc5c2ecf3ecc9c1667 | a86a2293cd4cf272bdee918956d1bd9299e9873c | diff --git a/.mvn/checksums/checksums-central.sha256 b/.mvn/checksums/checksums-central.sha256
index 2182f6ed6d..302b72a978 100644
--- a/.mvn/checksums/checksums-central.sha256
+++ b/.mvn/checksums/checksums-central.sha256
@@ -128,6 +128,7 @@
191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesa... | [
".mvn/checksums/checksums-central.sha256"
] | [
{
"comment": "Checks out with official release page checksum: https://github.com/pgjdbc/pgjdbc/releases/tag/REL42.7.11",
"path": ".mvn/checksums/checksums-central.sha256",
"hunk": "@@ -128,6 +128,7 @@\n 191acabbce3e466008fe4274d09793603eb0083e3b36c692feb958aa8b067821 com/typesafe/akka/akka-cluster-tool... | true | ||
ACINQ/eclair | 3,302 | issue_to_patch | Dockerfile: Auto-approve apt-get install command | Otherwise the build will wait for a user input and eventually fail.
I'm not sure how it was possibly working before 🤔 | 113d8fba770b64e116b23a7d1ef4cd06053a19ee | 97ef8036e1d49fd703828b5de36d48d5acb9b96d | diff --git a/Dockerfile b/Dockerfile
index dbc39161f6..ff8e22206a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -27,7 +27,7 @@ FROM eclipse-temurin:21-jre-noble
WORKDIR /app
# install jq for eclair-cli
-RUN apt-get update && apt-get install bash jq curl unzip
+RUN apt-get update && apt-get install -y bash jq curl unz... | [
"Dockerfile"
] | [] | true | ||
ACINQ/eclair | 3,303 | issue_to_patch | Add previous commitments to ChannelFundingConfirmed event | Event stream subscribers could use this field to find extra information about previous states that could have been pruned from the current commitments. | 6bb7f258e285181183872d3336e7d4dcc8d1b319 | edb46e7b41080f9cdf67b32fefcbce073ef9f7ad | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
index 971e31585b..da43d3ad59 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/c... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/CommonFundingHandlers.scala",
"eclair-node/src/test/scala/fr/acinq/eclair/api/ApiServiceSpec.scala"
] | [] | diff --git a/eclair-node/src/test/scala/fr/acinq/eclair/api/ApiServiceSpec.scala b/eclair-node/src/test/scala/fr/acinq/eclair/api/ApiServiceSpec.scala
index 2456d87ecf..f3205591f3 100644
--- a/eclair-node/src/test/scala/fr/acinq/eclair/api/ApiServiceSpec.scala
+++ b/eclair-node/src/test/scala/fr/acinq/eclair/api/ApiSer... | true | |
ACINQ/eclair | 3,301 | issue_to_patch | Add liquidity ads metrics | We add metrics for liquidity ads (purchased amount and mining fee refund).
We refactor the interactive-tx metrics to record them *after* tx validation, instead of *before*.
We also remove the input/output count for the "shared" case, since it's always 0 or 1.
Replaces #2997 | 113d8fba770b64e116b23a7d1ef4cd06053a19ee | 306480c9d4363f675b279e4b565b2a4503f13345 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
index d0322f1c6f..23c1aee886 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala"
] | [
{
"comment": "I don't know if it is fine (in terms of performance) to have those histograms on values that are all different (output amounts in satoshi). I don't know how Kamon handles bucketing, there is a risk that records cannot be aggregated at all since they all use different amounts.",
"path": "eclair... | true | ||
ACINQ/eclair | 3,301 | comment_to_fix | Add liquidity ads metrics | I don't know if it is fine (in terms of performance) to have those histograms on values that are all different (output amounts in satoshi). I don't know how Kamon handles bucketing, there is a risk that records cannot be aggregated at all since they all use different amounts. | 113d8fba770b64e116b23a7d1ef4cd06053a19ee | 306480c9d4363f675b279e4b565b2a4503f13345 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
index d0322f1c6f..23c1aee886 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala"
] | [
{
"comment": "I don't know if it is fine (in terms of performance) to have those histograms on values that are all different (output amounts in satoshi). I don't know how Kamon handles bucketing, there is a risk that records cannot be aggregated at all since they all use different amounts.",
"path": "eclair... | true | ||
ACINQ/eclair | 3,300 | issue_to_patch | Add metrics on interactive-tx inputs and outputs | We track:
- global input/output count by type and distribution of amounts
- per-session input/output count by type | 0f5d4b89330f2ae383b13fc64b480d755ba6c9d4 | 0c8bfec956f35c22cf561de16da209986a448cb6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
index 863de3a8b3..d0322f1c6f 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala"
] | [
{
"comment": "```suggestion\n val InteractiveTxOutputs = Kamon.histogram(\"channels.interactive-tx.outputs\", \"Interactive tx outputs\")\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala",
"hunk": "@@ -33,6 +33,10 @@ object Monitoring {\n val HtlcValueInFlightGl... | true | ||
ACINQ/eclair | 3,300 | comment_to_fix | Add metrics on interactive-tx inputs and outputs | ```suggestion
val InteractiveTxOutputs = Kamon.histogram("channels.interactive-tx.outputs", "Interactive tx outputs")
``` | 0f5d4b89330f2ae383b13fc64b480d755ba6c9d4 | 0c8bfec956f35c22cf561de16da209986a448cb6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
index 863de3a8b3..d0322f1c6f 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala"
] | [
{
"comment": "```suggestion\n val InteractiveTxOutputs = Kamon.histogram(\"channels.interactive-tx.outputs\", \"Interactive tx outputs\")\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala",
"hunk": "@@ -33,6 +33,10 @@ object Monitoring {\n val HtlcValueInFlightGl... | true | ||
ACINQ/eclair | 3,300 | comment_to_fix | Add metrics on interactive-tx inputs and outputs | ```suggestion
val InteractiveTxOutputsPerSession = Kamon.histogram("channels.interactive-tx.outputs-per-session", "Interactive tx outputs per session")
``` | 0f5d4b89330f2ae383b13fc64b480d755ba6c9d4 | 0c8bfec956f35c22cf561de16da209986a448cb6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
index 863de3a8b3..d0322f1c6f 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Mo... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala"
] | [
{
"comment": "```suggestion\n val InteractiveTxOutputsPerSession = Kamon.histogram(\"channels.interactive-tx.outputs-per-session\", \"Interactive tx outputs per session\")\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Monitoring.scala",
"hunk": "@@ -33,6 +33,10 @@ object Monitori... | true | ||
ACINQ/eclair | 3,299 | issue_to_patch | Fix flaky DER signature weight test | This test was flaky because for the funding output, we provide two signatures, which means that we need twice the slack for the variable DER encoding length. | 872cb663f56e3319878388027e183bf7101daee3 | 955c34f905c6a6e6b730d38944ae4a5689db25ed | [
"eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
index e46780ace6..3d999531fb 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
+++ b/eclair-core/src/test... | true | ||
ACINQ/eclair | 3,144 | issue_to_patch | Use official feature bit for `option_simple_taproot` | Use the official feature bit and name for taproot channels and the corresponding channel types. Activate taproot channels support by default (without support for announcing such channels yet).
We have test vectors matching the spec (https://github.com/lightning/bolts/pull/995) and cross-compatibility with lnd :tada:... | 68b0096a2f9450e9963c4b61fc16f57449fe943c | 68a85a3c66201d8f20a0d1c206026266a7bda433 | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 85b01d1a39..b81810ede4 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -42,6 +42,28 @@ Node operators should instead create a new splice transaction (with `splicein` o
Note that eclair... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/Features.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala",
"eclair-core/src/ma... | [
{
"comment": "```suggestion\n if (!announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) {\n```\n\nWe currently allow opening public taproot channels, which is not yet supported as there are no specs for gossip messages for these types of channels. ",
... | diff --git a/eclair-core/src/test/resources/bolt3-tx-test-vectors-simple-taproot-commitment-format.json b/eclair-core/src/test/resources/bolt3-tx-test-vectors-simple-taproot-commitment-format.json
new file mode 100644
index 0000000000..26686d3f3e
--- /dev/null
+++ b/eclair-core/src/test/resources/bolt3-tx-test-vectors-... | true | |
ACINQ/eclair | 3,144 | comment_to_fix | Use official feature bit for `option_simple_taproot` | ```suggestion
if (!announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) {
```
We currently allow opening public taproot channels, which is not yet supported as there are no specs for gossip messages for these types of channels. | 68b0096a2f9450e9963c4b61fc16f57449fe943c | 68a85a3c66201d8f20a0d1c206026266a7bda433 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala
index 311e960198..f1537938f1 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala
+++ b/eclair-core/src/main/scala/fr/acinq/ec... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelFeatures.scala"
] | [
{
"comment": "```suggestion\n if (!announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) {\n```\n\nWe currently allow opening public taproot channels, which is not yet supported as there are no specs for gossip messages for these types of channels. ",
... | true | ||
ACINQ/eclair | 2,887 | issue_to_patch | Add support for the official splicing protocol | We replace our experimental version of `splice_init`, `splice_ack` and `splice_locked` by their official version (see https://github.com/lightning/bolts/pull/1160). If our peer is using the experimental feature bit, we convert our outgoing messages to use the experimental encoding and incoming messages to the official ... | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 9ec1a25923..3d19f22128 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -9,6 +9,39 @@
With this release, eclair requires using Bitcoin Core 30.x.
Newer versions of Bitcoin Core may be ... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/Features.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"eclair-core/s... | [
{
"comment": "Should we also mention here that additional splices can be negotiated while previous splices are pending confirmation if 0-conf is activated with the peer, but once an RBF for the channel has been initiated no additional splices can be initiated? ",
"path": "docs/release-notes/eclair-vnext.md... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
index f3a6b698ab..6e6ea254ad 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
@@ -1... | true | |
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | Should we also mention here that additional splices can be negotiated while previous splices are pending confirmation if 0-conf is activated with the peer, but once an RBF for the channel has been initiated no additional splices can be initiated? | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 9ec1a25923..3d19f22128 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -9,6 +9,39 @@
With this release, eclair requires using Bitcoin Core 30.x.
Newer versions of Bitcoin Core may be ... | [
"docs/release-notes/eclair-vnext.md"
] | [
{
"comment": "Should we also mention here that additional splices can be negotiated while previous splices are pending confirmation if 0-conf is activated with the peer, but once an RBF for the channel has been initiated no additional splices can be initiated? ",
"path": "docs/release-notes/eclair-vnext.md... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | Should we also add a check for `remainingRbfAttempts` using `nodeParams.channelConf.remoteRbfLimits.maxAttempts` as is done in `ChannelOpenDualFunded` ? | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index 7b2586071a..aefb30b00c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "Should we also add a check for `remainingRbfAttempts` using `nodeParams.channelConf.remoteRbfLimits.maxAttempts` as is done in `ChannelOpenDualFunded` ?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"hunk": "@@ -1033,6 +1074,100 @@ class Channel(val node... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | Should we also check here "if the parent transaction is unconfirmed, we should only accept it when 0-conf is activated with that peer" ? | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index 7b2586071a..aefb30b00c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "Should we also check here \"if the parent transaction is unconfirmed, we should only accept it when 0-conf is activated with that peer\" ?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"hunk": "@@ -885,68 +918,73 @@ class Channel(val nodeParams: NodePara... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | If 0-conf is activated, should we still only allow a limited number of previous unconfirmed parent txs? and/or have some sort of rate limit on? or perhaps it doesn't matter if we already trust our peer enough to activate 0-conf.. | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index 7b2586071a..aefb30b00c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "If 0-conf is activated, should we still only allow a limited number of previous unconfirmed parent txs? and/or have some sort of rate limit on? or perhaps it doesn't matter if we already trust our peer enough to activate 0-conf.. ",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | Why do we need these `ignoreMsg` calls if above we already waited with `expectNoMessage` ? | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
index dfab1676eb..053d3929cc 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala"
] | [
{
"comment": "Why do we need these `ignoreMsg` calls if above we already waited with `expectNoMessage` ?",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala",
"hunk": "@@ -1373,93 +1478,86 @@ class NormalSplicesStateSpec extends TestKitBaseClass with Fixtu... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | nit: is it important to pass `WatchTxConfirmedTriggered` to `watchConfirmedCommit2.replyTo` instead of just passing to `alice` as you do elsewhere? | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
index dfab1676eb..053d3929cc 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala"
] | [
{
"comment": "nit: is it important to pass `WatchTxConfirmedTriggered` to `watchConfirmedCommit2.replyTo` instead of just passing to `alice` as you do elsewhere?",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala",
"hunk": "@@ -1475,145 +1573,132 @@ clas... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | To ease rebase on feature branches:
```suggestion
val features = defaultFeatures
.add(Features.Splicing, FeatureSupport.Optional)
.add(Features.OnTheFlyFunding, FeatureSupport.Optional)
``` | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala
index bb050bf95c..b8badd7d45 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala
+++ b/eclair-core/src/test... | [
"eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala"
] | [
{
"comment": "To ease rebase on feature branches:\n```suggestion\n val features = defaultFeatures\n .add(Features.Splicing, FeatureSupport.Optional)\n .add(Features.OnTheFlyFunding, FeatureSupport.Optional)\n```",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | ```suggestion
val features = defaultFeatures
.add(Features.Splicing, FeatureSupport.Optional)
.add(Features.OnTheFlyFunding, FeatureSupport.Optional)
``` | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala
index bb050bf95c..b8badd7d45 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala
+++ b/eclair-core/src/test... | [
"eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala"
] | [
{
"comment": "```suggestion\n val features = defaultFeatures\n .add(Features.Splicing, FeatureSupport.Optional)\n .add(Features.OnTheFlyFunding, FeatureSupport.Optional)\n```",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/io/OpenChannelInterceptorSpec.scala",
"hunk": "@@ -210,7 +210,... | true | ||
ACINQ/eclair | 2,887 | comment_to_fix | Add support for the official splicing protocol | ```scala
def apply(channelId: ByteVector32,
tx: Transaction,
witnesses: Seq[ScriptWitness],
previousFundingSig_opt: Option[ChannelSpendSignature]): TxSignatures = {
val tlvs: Set[TxSignaturesTlv] = Set(
previousFundingSig_opt match {
case Some(IndividualSignatu... | 5c44f005abf454b0fe314499cdb3e0822ebc8769 | 318ba314d5bc9824e031d07b772c84920ccfd6ff | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
index 0ceb57534e..8f405b55dd 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala
+++ b/ec... | [
"eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageTypes.scala"
] | [
{
"comment": "```scala\n def apply(channelId: ByteVector32, \n tx: Transaction, \n witnesses: Seq[ScriptWitness], \n previousFundingSig_opt: Option[ChannelSpendSignature]): TxSignatures = {\n val tlvs: Set[TxSignaturesTlv] = Set(\n previousFundingSig_opt match {\n ... | true | ||
ACINQ/eclair | 3,295 | issue_to_patch | More aggressive peer scorer idle channels management | We previously lowered fees from idle channels only if our latest update was from more than 24 hours ago, and closed them if our latest update was more than 5 days ago and using our minimal fees.
The issue is that our channel update may have been refreshed without changing the relay fees, for example if our peer disc... | da7cd962a8db61411aea2a07493ccf7a71d6cf18 | 509f99468a580d5fcd2c2a3a15376eb3b94a2b13 | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 9ec1a25923..74a3dd4fab 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -113,12 +113,16 @@ eclair.peer-scoring {
local-balance-closing-threshold-satoshis = 10000000 // 0.1 btc
... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala",
"eclair-core/src/test/scala... | [
{
"comment": "Note: the current behavior is that we only close channels where less than 5% of the capacity has moved in the past week. Maybe this is too low, do we want to raise this threshold from 5% to 10%?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala",
"hunk": "@@ -34... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
index f3a6b698ab..051ba6efc9 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
@@ -2... | true | |
ACINQ/eclair | 3,295 | comment_to_fix | More aggressive peer scorer idle channels management | Note: the current behavior is that we only close channels where less than 5% of the capacity has moved in the past week. Maybe this is too low, do we want to raise this threshold from 5% to 10%? | da7cd962a8db61411aea2a07493ccf7a71d6cf18 | 509f99468a580d5fcd2c2a3a15376eb3b94a2b13 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala
index c0703f8745..cafea52d8c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerSc... | [
"eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala"
] | [
{
"comment": "Note: the current behavior is that we only close channels where less than 5% of the capacity has moved in the past week. Maybe this is too low, do we want to raise this threshold from 5% to 10%?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala",
"hunk": "@@ -34... | true | ||
ACINQ/eclair | 3,289 | issue_to_patch | Keep our closing_complete in the simple close session | In the simple close session, which is never persisted, we just need to remember our closing_complete and the partial signatures it contains, instead of keeping our musig2 nonces and generating our partial signatures a second time to build the final closing tx when we receive our peer's partial signatures.
We also c... | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | 0a14c7192559ab3d12fc5eec2c4ef96bb2092056 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index e09f4221a4..230f2dd073 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/CommonHandlers.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala"
] | [] | true | ||
ACINQ/eclair | 3,294 | issue_to_patch | Increase start-up ZMQ timeout | We connect to bitcoind over ZMQ right after spawning all actors in the system, which can consume a lot of our available sockets/bandwidth. We increase the default timeout from 5 seconds to 30 seconds. | 119f8c2156e13a098b520fbaf2e44a5d967bba48 | e5811da58175cf7b1af10a2d656c2d36524539a1 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala b/eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala
index 4124e03983..c21f718541 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala
@@ -426,9 +426,9 @@ class Setup(val d... | [
"eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala"
] | [] | true | ||
ACINQ/eclair | 3,293 | issue_to_patch | Add threshold for disabling `from_future_htlc` | When funding a transaction using `from_future_htlc`, we are taking the risk that the remote node doesn't fulfill the corresponding HTLCs. If we detect that too many peers fail such HTLCs, this may indicate a bug on the wallet side, so we automatically disable `from_future_htlc` to limit our exposure.
We also ensure ... | 20dc4105437099f46605b34636121a6e7027896b | 11e6dcd94dbe1f72fdb605813ff4ada8b10f5e57 | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index 2eda41c9fd..0c51fc91ca 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -399,6 +399,10 @@ eclair {
// If our peer doesn't respond to our ... | [
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/OnTheFlyFunding.sca... | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
index 20f87d501b..f3a6b698ab 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
@@ -2... | true | |
ACINQ/eclair | 3,277 | issue_to_patch | Add peer scorer documentation | We add release notes about the peer scorer for node operators who like living on the bleeding edge. We also remove the workaround for the lack of DB data on restart. | 5b43e954e385018331a048ca90e62b08c5371f4c | 97a1a283ad3ca84e471ce23273fdbd278d60ac94 | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index ed697f909c..9ec1a25923 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -54,6 +54,104 @@ It should be acceptable, since liquidity decisions should be taken based on rela
We expose a now... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/scala/fr/acinq/eclair/profit/Monitoring.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerScorer.scala"
] | [] | true | ||
ACINQ/eclair | 3,291 | issue_to_patch | Fix flaky zero-conf integration test | There's a race condition between Bob and Carol's router states, which aren't updated exactly at the same time. Retrying the condition should fix this race condition. | 689dbda1bfba893d059fe02028f38a55d1c2d845 | 85e41b13010e254a06ead04dda045fb0e0691289 | [
"eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/zeroconf/ZeroConfAliasIntegrationSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/zeroconf/ZeroConfAliasIntegrationSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/zeroconf/ZeroConfAliasIntegrationSpec.scala
index bf256981b0..fb1f030dee 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integratio... | true | ||
ACINQ/eclair | 3,290 | issue_to_patch | Don't load network graph twice on start-up | We previously read the whole network graph from DB (channels and nodes) twice: once before starting any actor to verify that the DB has not been corrupted, and then again when initializing the `Router` actor.
We now keep the result of the first DB read instead of throwing it away and provide it as argument to the `R... | 689dbda1bfba893d059fe02028f38a55d1c2d845 | f5ad2841de695c51d4f31225128e9ab88f75770f | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index 7b03f01f65..2eda41c9fd 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -438,7 +438,6 @@ eclair {
channel-exclude-duration = 60 seconds... | [
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/DBChecker.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/Logs.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/remote/EclairInternalsSerializer.scala... | [
{
"comment": "I like the idea, but the initial channels/nodes must be provided in an `Init` message (like we do for the `Switchboard`), otherwise they will never be garbage collected.",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala",
"hunk": "@@ -51,7 +51,7 @@ import scala.util... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala
index b90df36a39..5a93b17dbc 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/Min... | true | |
ACINQ/eclair | 3,290 | comment_to_fix | Don't load network graph twice on start-up | I like the idea, but the initial channels/nodes must be provided in an `Init` message (like we do for the `Switchboard`), otherwise they will never be garbage collected. | 689dbda1bfba893d059fe02028f38a55d1c2d845 | f5ad2841de695c51d4f31225128e9ab88f75770f | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
index e7a47b1920..ad1a48d359 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
@@ -2... | [
"eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala"
] | [
{
"comment": "I like the idea, but the initial channels/nodes must be provided in an `Init` message (like we do for the `Switchboard`), otherwise they will never be garbage collected.",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala",
"hunk": "@@ -51,7 +51,7 @@ import scala.util... | true | ||
ACINQ/eclair | 3,287 | issue_to_patch | Don't try reconnecting automatically to mobile wallets | It's useless as they will always have a different IP address, and they will be offline most of the time anyway. They will initiate connections either when the app is started or when they receive a push notification so we never need to initiate connections from the server side. | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | b5d77da49490965d74105e0b193f59c20d1c32e6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
index ccf59b108b..a9ae568090 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
@@ -88,10 +88,12 @@ class Pee... | [
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/io/ReconnectionTaskSpec.scala"
] | [
{
"comment": "I would keep this a bit more generic:\n\n```suggestion\n val autoReconnect = init.storedChannels.exists(_.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala",
"hunk": "@@ -88,1... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
index 164767d2c1..fc74b5fda8 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/io/PeerSpec.scala
@@ -50,6 +50,... | true | |
ACINQ/eclair | 3,287 | comment_to_fix | Don't try reconnecting automatically to mobile wallets | I would keep this a bit more generic:
```suggestion
val autoReconnect = init.storedChannels.exists(_.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))
``` | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | b5d77da49490965d74105e0b193f59c20d1c32e6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
index ccf59b108b..a9ae568090 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
@@ -88,10 +88,12 @@ class Pee... | [
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala"
] | [
{
"comment": "I would keep this a bit more generic:\n\n```suggestion\n val autoReconnect = init.storedChannels.exists(_.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala",
"hunk": "@@ -88,1... | true | ||
ACINQ/eclair | 3,287 | comment_to_fix | Don't try reconnecting automatically to mobile wallets | With my suggestion above we would have node-level and peer-level `autoReconnect` settings. | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | b5d77da49490965d74105e0b193f59c20d1c32e6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala
index c74177b61c..0d14b7f530 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Reco... | [
"eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala"
] | [
{
"comment": "With my suggestion above we would have node-level and peer-level `autoReconnect` settings.",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/io/ReconnectionTask.scala",
"hunk": "@@ -80,7 +80,11 @@ class ReconnectionTask(nodeParams: NodeParams, remoteNodeId: PublicKey) extends\n \n wh... | true | ||
ACINQ/eclair | 3,287 | comment_to_fix | Don't try reconnecting automatically to mobile wallets | The `init.storedChannels.isEmpty` would only make sense if we didn't reeavaluate the `autoReconnect` flag at each `CONNECTED`->`DISCONNECTED` transition, because we weren't able to characterize new peers before they first have a channel.
```suggestion
val autoReconnect = init.storedChannels.exists(c => !c.channe... | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | b5d77da49490965d74105e0b193f59c20d1c32e6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
index ccf59b108b..a9ae568090 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
@@ -88,10 +88,12 @@ class Pee... | [
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala"
] | [
{
"comment": "The `init.storedChannels.isEmpty` would only make sense if we didn't reeavaluate the `autoReconnect` flag at each `CONNECTED`->`DISCONNECTED` transition, because we weren't able to characterize new peers before they first have a channel.\n\n```suggestion\n val autoReconnect = init.storedChann... | true | ||
ACINQ/eclair | 3,287 | comment_to_fix | Don't try reconnecting automatically to mobile wallets | We don't want to reconnect to random peers that just said hello and disconnected, with no channels:
```suggestion
val autoReconnect = init.storedChannels.exists(c => !c.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))
``` | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | b5d77da49490965d74105e0b193f59c20d1c32e6 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
index ccf59b108b..a9ae568090 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala
@@ -88,10 +88,12 @@ class Pee... | [
"eclair-core/src/main/scala/fr/acinq/eclair/io/Peer.scala"
] | [
{
"comment": "We don't want to reconnect to random peers that just said hello and disconnected, with no channels:\n\n```suggestion\n val autoReconnect = init.storedChannels.exists(c => !c.channelParams.remoteParams.initFeatures.hasFeature(Features.WakeUpNotificationClient))\n```",
"path": "eclair-c... | true | ||
ACINQ/eclair | 3,288 | issue_to_patch | Add delays when reading past payment events for stats | When we restart, we load past payments events into the peer stats tracker to inform our scoring algorithm. We read them in chunks, but it can be quite expensive in terms of bandwidth. Since this is low priority and there are a lot of DB reads already happening when starting up, we add a large initial delay and a small-... | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | a04cd46ce61850471fdacf3a539fe9d01c9d289e | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index e452e9be2a..7b03f01f65 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -671,6 +671,14 @@ eclair {
top-peers-count = 10
// A list of... | [
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/Setup.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scal... | [
{
"comment": "Nit\n```suggestion\n past-events {\n init-delay = 10 minutes\n chunk-interval = 10 seconds\n }\n```",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -671,6 +671,12 @@ eclair {\n top-peers-count = 10\n // A list of node_ids with whom we will try... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
index 94a5edad69..20f87d501b 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/TestConstants.scala
@@ -2... | true | |
ACINQ/eclair | 3,288 | comment_to_fix | Add delays when reading past payment events for stats | Nit
```suggestion
past-events {
init-delay = 10 minutes
chunk-interval = 10 seconds
}
``` | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | a04cd46ce61850471fdacf3a539fe9d01c9d289e | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index e452e9be2a..7b03f01f65 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -671,6 +671,14 @@ eclair {
top-peers-count = 10
// A list of... | [
"eclair-core/src/main/resources/reference.conf"
] | [
{
"comment": "Nit\n```suggestion\n past-events {\n init-delay = 10 minutes\n chunk-interval = 10 seconds\n }\n```",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -671,6 +671,12 @@ eclair {\n top-peers-count = 10\n // A list of node_ids with whom we will try... | true | ||
ACINQ/eclair | 3,288 | comment_to_fix | Add delays when reading past payment events for stats | Human-readable timestamps are more useful here:
```suggestion
log.info("loading past events before {}", Instant.ofEpochMilli(before.toLong))
``` | 8abe5900eb9cf07c4ef66f371621b6e2e4a10d18 | a04cd46ce61850471fdacf3a539fe9d01c9d289e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala b/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala
index 91c574ddf6..ebde194c03 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala
+++ b/eclair-core/src/main/scala/fr/acinq/ec... | [
"eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala"
] | [
{
"comment": "Human-readable timestamps are more useful here:\n```suggestion\n log.info(\"loading past events before {}\", Instant.ofEpochMilli(before.toLong))\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/profit/PeerStatsTracker.scala",
"hunk": "",
"resolving_sha": "a04cd46ce6... | true | ||
ACINQ/eclair | 3,286 | issue_to_patch | Docker image crashes with SIGSEGV in secp256k1-jni due to Alpine musl/glibc incompatibility
## Description
The official Docker image (`acinq/eclair:latest`) crashes with SIGSEGV during channel activation.
## Root Cause
The runtime stage uses `eclipse-temurin:21-jre-alpine` (musl libc), but `libsecp256k1-jni.so` fro... | Use noble docker images instead of alpine | It fixes compatibility issues with alpine (which uses musl and not glibc), and is easier to maintain.
Note that this makes image about 190 Mb bigger. | 0778eafae34bfafb5e4f1412a8566edc2f54b611 | 1032f597c03aebe31668f63154fe83857594d486 | diff --git a/Dockerfile b/Dockerfile
index 06e173b6eb..dbc39161f6 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM eclipse-temurin:21-jdk-alpine as BUILD
+FROM eclipse-temurin:21-jdk-noble as BUILD
# Let's fetch eclair dependencies, so that Docker can cache them
# This way we won't have to fetch depen... | [
"Dockerfile"
] | [] | true | |
ACINQ/eclair | 3,282 | issue_to_patch | Add fuzz tests for onion, route blinding and lightning message codecs | In this PR, I am adding fuzz tests for the remaining `LightningMessageCodecs`. These are core to the LN and must be round-trip safe.
In addition, this PR introduces round-trip fuzz tests for:
- Payment and message onion payloads: since they are under Sphinx onion encryption and may contain malformed inputs. Also,... | 129df369530ece6d1a48632e7f9d17ed09e93a4d | c508de76226a7b108f3aee15d7389f5b393cb6cd | [
"eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/protocol/FailureMessageCodecsFuzzTest.scala",
"eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/protocol/LightningMessageCodecsFuzzTest.scala",
"eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/protocol/OnionPayloadCodecsFuzzTest.scala",
"eclair-fuzz/src/test/sca... | [] | diff --git a/eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/protocol/FailureMessageCodecsFuzzTest.scala b/eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/protocol/FailureMessageCodecsFuzzTest.scala
new file mode 100644
index 0000000000..c26f3a4bc9
--- /dev/null
+++ b/eclair-fuzz/src/test/scala/fr/acinq/eclair/wire/pro... | true | ||
ACINQ/eclair | 3,280 | issue_to_patch | Fix flaky `PeerStatsTracker` test | If the test runs too quickly and the message is processed in less than 1 millisecond, there is a race condition since reading from the database excludes the upper timestamp bound (`timestamp < now`). | 129df369530ece6d1a48632e7f9d17ed09e93a4d | 166d3936fab15ba149ba8eea26aab7657d872b6e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala b/eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala
index 83172bd56b..aefead91c3 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/db/pg/PgAuditDb.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala"
] | [
{
"comment": "It seems that our PG and Sqlite audit dbs use inconsistent queries wrt timestamps:\npg: `timestamp BETWEEN ? AND ?` which is inclusive ( a <= timestamp <= b)\nsqlite: `timestamp >= ? AND timestamp < ?` which does not include the upper bound\n\n=> changing the sqlite audit db to use `<=` too should... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala
index 4d0afda2d6..c2b7a95c9c 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala
+++ b/eclair-core/src/test/scala... | true | |
ACINQ/eclair | 3,280 | comment_to_fix | Fix flaky `PeerStatsTracker` test | It seems that our PG and Sqlite audit dbs use inconsistent queries wrt timestamps:
pg: `timestamp BETWEEN ? AND ?` which is inclusive ( a <= timestamp <= b)
sqlite: `timestamp >= ? AND timestamp < ?` which does not include the upper bound
=> changing the sqlite audit db to use `<=` too should fix the flaking test ? | 129df369530ece6d1a48632e7f9d17ed09e93a4d | 166d3936fab15ba149ba8eea26aab7657d872b6e | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala
index 4d0afda2d6..c2b7a95c9c 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala
+++ b/eclair-core/src/test/scala... | [
"eclair-core/src/test/scala/fr/acinq/eclair/profit/PeerStatsTrackerSpec.scala"
] | [
{
"comment": "It seems that our PG and Sqlite audit dbs use inconsistent queries wrt timestamps:\npg: `timestamp BETWEEN ? AND ?` which is inclusive ( a <= timestamp <= b)\nsqlite: `timestamp >= ? AND timestamp < ?` which does not include the upper bound\n\n=> changing the sqlite audit db to use `<=` too should... | true | ||
ACINQ/eclair | 3,283 | issue_to_patch | Add fee field to findroute full format response | `findroute`, `findroutetonode`, and `findroutebetweennodes` include a `fee` field for each route in their full format response, so callers don't need to compute fees manually from hop parameters. | 129df369530ece6d1a48632e7f9d17ed09e93a4d | 302c37ad729aa8e247ac301acfeb01c8e7b0173e | diff --git a/.gitignore b/.gitignore
index 06d7e8b22c..1287724adf 100644
--- a/.gitignore
+++ b/.gitignore
@@ -31,6 +31,10 @@ jdbcUrlFile_*.tmp
.claude*
+.bloop/
+.metals/
+.vscode/
+
# fuzzing
crash-*
.cifuzz-*
diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 03207f23f... | [
".gitignore",
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/scala/fr/acinq/eclair/json/JsonSerializers.scala",
"eclair-node/src/test/resources/api/findroute-full"
] | [
{
"comment": "That comment looks incorrect, you only added a `fee` field for the total route fee, not for each hop?",
"path": "docs/release-notes/eclair-vnext.md",
"hunk": "@@ -103,6 +103,7 @@ eclair.relay.reserved-for-accountable = 0.0\n ### API changes\n \n - `findroute`, `findroutetonode` and `findro... | diff --git a/eclair-node/src/test/resources/api/findroute-full b/eclair-node/src/test/resources/api/findroute-full
index e1b2229777..4ab5fc7f6f 100644
--- a/eclair-node/src/test/resources/api/findroute-full
+++ b/eclair-node/src/test/resources/api/findroute-full
@@ -1,1 +1,1 @@
-{"routes":[{"amount":456,"hops":[{"nodeI... | true | |
ACINQ/eclair | 3,283 | comment_to_fix | Add fee field to findroute full format response | That comment looks incorrect, you only added a `fee` field for the total route fee, not for each hop? | 129df369530ece6d1a48632e7f9d17ed09e93a4d | 302c37ad729aa8e247ac301acfeb01c8e7b0173e | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 03207f23f2..ed697f909c 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -103,6 +103,7 @@ eclair.relay.reserved-for-accountable = 0.0
### API changes
- `findroute`, `findroutetonode` ... | [
"docs/release-notes/eclair-vnext.md"
] | [
{
"comment": "That comment looks incorrect, you only added a `fee` field for the total route fee, not for each hop?",
"path": "docs/release-notes/eclair-vnext.md",
"hunk": "@@ -103,6 +103,7 @@ eclair.relay.reserved-for-accountable = 0.0\n ### API changes\n \n - `findroute`, `findroutetonode` and `findro... | true | ||
ACINQ/eclair | 3,284 | issue_to_patch | Allow reply-less pings | BOLT1 says:
```
A node receiving a ping message:
- if num_pong_bytes is less than 65532:
- MUST respond by sending a pong message, with byteslen equal to num_pong_bytes.
- otherwise (num_pong_bytes is not less than 65532):
- MUST ignore the ping.
```
These reply-less pings are used to insert cover traff... | 129df369530ece6d1a48632e7f9d17ed09e93a4d | cae0560748f217dc0954db17d8e6329d18274f4a | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala b/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala
index 25e9277d91..262246cd81 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala
+++ b/eclair-core/src/main/scala/fr/acinq/ec... | [
"eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/PeerConnection.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/crypto/TransportHandlerSpec.scala"
] | [
{
"comment": "BOLT1 says you must reply if ping size ` is less than 65532` so this should be:\n```suggestion\n case ping: Ping if ping.pongLength < 65532 =>\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala",
"hunk": "@@ -102,12 +102,15 @@ class Transport... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/crypto/TransportHandlerSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/crypto/TransportHandlerSpec.scala
index 8f9adce049..f9fb8bb283 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/crypto/TransportHandlerSpec.scala
+++ b/eclair-core/src/test/scala... | true | |
ACINQ/eclair | 3,284 | comment_to_fix | Allow reply-less pings | BOLT1 says you must reply if ping size ` is less than 65532` so this should be:
```suggestion
case ping: Ping if ping.pongLength < 65532 =>
``` | 129df369530ece6d1a48632e7f9d17ed09e93a4d | cae0560748f217dc0954db17d8e6329d18274f4a | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala b/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala
index 25e9277d91..262246cd81 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala
+++ b/eclair-core/src/main/scala/fr/acinq/ec... | [
"eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala"
] | [
{
"comment": "BOLT1 says you must reply if ping size ` is less than 65532` so this should be:\n```suggestion\n case ping: Ping if ping.pongLength < 65532 =>\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/crypto/TransportHandler.scala",
"hunk": "@@ -102,12 +102,15 @@ class Transport... | true | ||
ACINQ/eclair | 2,706 | issue_to_patch | Use apache archives for mvn in docker build | The previous repository we used removed the binaries for mvn 3.9.2, which broke our docker build. It looks like `archive.apache.org` keeps artifacts longer and hopefully won't break our docker build again soon. | 4c98e1c23712fdd0f90ee851f50758ea0c5a7638 | 7749a18d3231eb47cb6c92365bce87d2ca28dd09 | diff --git a/Dockerfile b/Dockerfile
index 137b5cfa06..6e98941214 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -8,7 +8,7 @@ RUN apk add --no-cache curl tar bash
ARG MAVEN_VERSION=3.9.2
ARG USER_HOME_DIR="/root"
ARG SHA=900bdeeeae550d2d2b3920fe0e00e41b0069f32c019d566465015bdd1b3866395cbe016e22d95d25d51d3a5e614af2c83ec... | [
"Dockerfile",
"contrib/arm64v8.Dockerfile"
] | [] | true | ||
ACINQ/eclair | 1,928 | issue_to_patch | Add validation on the recid in `verifymessage` | We offset the `recid` by `31` for compatibility with `lnd` [1] but we
should also support normal values (0-3), and also add boundary checks.
[1] https://twitter.com/rusty_twit/status/1182102005914800128 | 59ccf3427ac8cc5b108b5f1e6cf56139415e8ed0 | f1d23f842e96f17031dbdb4a20da8a14e854152a | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala b/eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala
index f335d98244..bc650d75ed 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala
@@ -458,7 +458,11 @@ class Eclair... | [
"eclair-core/src/main/scala/fr/acinq/eclair/Eclair.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
index ac4221c74f..a02314e170 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
@... | true | |
ACINQ/eclair | 2,543 | issue_to_patch | Fix build | Fix the tests on `master` and update github actions. | 2fdc9fa4d3f1da7acea881a1c2f1d6e26f45a343 | 3f84a7c0c6786a284869de7c982d1b114736d6e7 | diff --git a/.github/workflows/latest-bitcoind.yml b/.github/workflows/latest-bitcoind.yml
index c768af0f68..078d5ee974 100644
--- a/.github/workflows/latest-bitcoind.yml
+++ b/.github/workflows/latest-bitcoind.yml
@@ -15,7 +15,7 @@ jobs:
timeout-minutes: 90
steps:
- name: Checkout bitcoind master
- ... | [
".github/workflows/latest-bitcoind.yml",
".github/workflows/main.yml",
"eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
index 9b02162e16..dcb79fff9e 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
@... | true | |
ACINQ/eclair | 2,761 | issue_to_patch | Avoid unusable channels after a large splice | Splicing (and dual funding as well) introduce a new scenario that could not happen before, where the channel initiator (who pays the fees for the commit tx) can end up below the channel reserve, or right above it but any additional HTLC would make it go below the reserve.
In that case it means that most of the chann... | 63a3c4297f6575a3f19425fe78eaefedb52220d3 | 3201d61e102e96c090f72f59885c72d960941def | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 26665bd02b..fc7ee28546 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala"
] | [
{
"comment": "After a dual funded channel creation or splice the reserve should ideally be met for both sides - but if it's not required when the new funding tx is created, then consistency with single funded channels would imply that \"[the protocol ensures that there is always progress toward meeting this res... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.scala
index aa3fcf435e..365a174dd3 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalSplicesStateSpec.sc... | true | |
ACINQ/eclair | 2,761 | comment_to_fix | Avoid unusable channels after a large splice | After a dual funded channel creation or splice the reserve should ideally be met for both sides - but if it's not required when the new funding tx is created, then consistency with single funded channels would imply that "[the protocol ensures that there is always progress toward meeting this reserve, and once met, it ... | 63a3c4297f6575a3f19425fe78eaefedb52220d3 | 3201d61e102e96c090f72f59885c72d960941def | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 26665bd02b..fc7ee28546 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala"
] | [
{
"comment": "After a dual funded channel creation or splice the reserve should ideally be met for both sides - but if it's not required when the new funding tx is created, then consistency with single funded channels would imply that \"[the protocol ensures that there is always progress toward meeting this res... | true | ||
ACINQ/eclair | 2,323 | issue_to_patch | Return local channel alias in payment failures | When using `option_scid_alias`, we must be careful not to expose the real scid to remote payers. We never generate a `channel_update` with the real scid so this isn't a risk, but we're incorrectly returning the remote alias instead of the returning the local one (which should match the invoice). | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index 33cdb33d0b..e956f945ea 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -89,8 +89,9 @@ upgrading to this release.
### API changes
-- `channelbalances` Retrieves information about th... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ChannelOpenSingleFunder.scala",
"eclair-core/src/main/scala/fr/acinq/eclai... | [
{
"comment": "I would change the signature of `handleAddHtlcCommandError` to:\r\n```scala\r\nprivate def handleAddHtlcCommandError(c: CMD_ADD_HTLC, cause: ChannelException, d: DATA_NORMAL)\r\n```\r\n\r\nIt allows better factorization and would be more consistent with other `handle*` methods.",
"path": "ecla... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala
index 48b031fd52..6386271f94 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTes... | true | |
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | I would change the signature of `handleAddHtlcCommandError` to:
```scala
private def handleAddHtlcCommandError(c: CMD_ADD_HTLC, cause: ChannelException, d: DATA_NORMAL)
```
It allows better factorization and would be more consistent with other `handle*` methods. | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
index bab02b5eae..9decc58b0d 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala"
] | [
{
"comment": "I would change the signature of `handleAddHtlcCommandError` to:\r\n```scala\r\nprivate def handleAddHtlcCommandError(c: CMD_ADD_HTLC, cause: ChannelException, d: DATA_NORMAL)\r\n```\r\n\r\nIt allows better factorization and would be more consistent with other `handle*` methods.",
"path": "ecla... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | The original comment is still accurate though? It described the spec logic of what scid should be used for communicating the `channel_update` to our direct peer and to the network. What this PR does is change the scid that we use internally as default for the `channel_update` with store, but this is a separate concern.... | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 357f418a62..8cdb82327a 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala"
] | [
{
"comment": "The original comment is still accurate though? It described the spec logic of what scid should be used for communicating the `channel_update` to our direct peer and to the network. What this PR does is change the scid that we use internally as default for the `channel_update` with store, but this ... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | Why not look at `channelFeatures`, given that in #2329 you handle the case where it isn't set in the channel type? It's not strictly equivalent because it would require _local_ to also set the bit, but I think it's what makes most sense.
Also, this isn't very type safe, caller could accidentally provide `localFeatur... | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 357f418a62..8cdb82327a 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala"
] | [
{
"comment": "Why not look at `channelFeatures`, given that in #2329 you handle the case where it isn't set in the channel type? It's not strictly equivalent because it would require _local_ to also set the bit, but I think it's what makes most sense.\r\n\r\nAlso, this isn't very type safe, caller could acciden... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | This is, in fact, where the spec violation would appear, if `nodeParams.remoteParams.features.hasFeature(Features.ScidAlias) && remoteAlias_opt.isEmpty`
```suggestion
case None => channelUpdate // note that if this is a zero-conf channel and the peer hasn't provided an alias, then the channel_update will have... | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 357f418a62..8cdb82327a 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala"
] | [
{
"comment": "This is, in fact, where the spec violation would appear, if `nodeParams.remoteParams.features.hasFeature(Features.ScidAlias) && remoteAlias_opt.isEmpty`\r\n\r\n```suggestion\r\n case None => channelUpdate // note that if this is a zero-conf channel and the peer hasn't provided an alias, then ... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | This results in unnecessary signatures (even when the payment is successfully relayed), but it doesn't matter much. | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala b/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
index c811d03a84..3ba8c507f4 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
+++ b/eclair-core/src/main/scala/fr... | [
"eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala"
] | [
{
"comment": "This results in unnecessary signatures (even when the payment is successfully relayed), but it doesn't matter much.",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala",
"hunk": "@@ -262,20 +266,35 @@ class ChannelRelay private(nodeParams: NodeParams,\n ... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | I don't get why you need to query `requestedChannelId_opt` here? | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala b/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
index c811d03a84..3ba8c507f4 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala
+++ b/eclair-core/src/main/scala/fr... | [
"eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala"
] | [
{
"comment": "I don't get why you need to query `requestedChannelId_opt` here?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelay.scala",
"hunk": "@@ -262,20 +266,35 @@ class ChannelRelay private(nodeParams: NodeParams,\n case None =>\n RelayFailure(CMD_FAIL_H... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | Nit: I'm not a huge fan of building an intermediate inconsistent object. You could have left `makeChannelUpdate` untouched and implemented:
```scala
def updateScid(nodeSecret: PrivateKey, u: ChannelUpdate, scid: ShortChannelId): ChannelUpdate =
makeChannelUpdate(....)
``` | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
index da8381840c..5441a3407f 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/rout... | [
"eclair-core/src/main/scala/fr/acinq/eclair/router/Announcements.scala"
] | [
{
"comment": "Nit: I'm not a huge fan of building an intermediate inconsistent object. You could have left `makeChannelUpdate` untouched and implemented:\r\n\r\n```scala\r\ndef updateScid(nodeSecret: PrivateKey, u: ChannelUpdate, scid: ShortChannelId): ChannelUpdate = \r\nmakeChannelUpdate(....)\r\n```",
"p... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | 🦅 👁️ | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala
index 48b031fd52..6386271f94 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTes... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala"
] | [
{
"comment": "🦅 👁️ ",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala",
"hunk": "@@ -181,7 +181,7 @@ trait ChannelStateTestsBase extends Assertions with Eventually {\n \n // those features can only be enabled with AnchorOutputsZeroFeeHtlcTxs,... | true | ||
ACINQ/eclair | 2,323 | comment_to_fix | Return local channel alias in payment failures | Is this really useful? I would put it inside `sendFailingPaymentAliceToCarol`. | 8af14ac515f9c01a4b6709720aec1b778aabac90 | 8687bfa4e6168dac65fc6d47f4106ce5d6e7f05d | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala
index 05af0ee034..33bdf0d4c9 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAl... | [
"eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala"
] | [
{
"comment": "Is this really useful? I would put it inside `sendFailingPaymentAliceToCarol`.",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/ZeroConfAliasIntegrationSpec.scala",
"hunk": "@@ -107,33 +123,40 @@ class ZeroConfAliasIntegrationSpec extends FixtureSpec with Integration... | true | ||
ACINQ/eclair | 2,798 | issue_to_patch | FIX eclair-cli error code in case of HTTP problem | Last command of eclair-cli is a curl piped to jq. In case of an error with the curl command (for instance, eclair service is not running) the error code is swallowed by the pipe which will return the exit code of the last command of the pipe (here, jq).
Setting `pipefail` ensures that the error code of curl is prese... | be4ed3c68bcef461b0db24f7fa015d74bf421421 | 6b76fa5a2d49cb17ef8029a71d4c7aa2e51ad41a | diff --git a/eclair-core/eclair-cli b/eclair-core/eclair-cli
index 8e7098e653..4f039ea8b8 100755
--- a/eclair-core/eclair-cli
+++ b/eclair-core/eclair-cli
@@ -166,4 +166,5 @@ else
fi
# we're now ready to execute the API call
+set -o pipefail # ensures we preserve curl error code in case of HTTP issue
eval curl "--... | [
"eclair-core/eclair-cli"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.