repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ACINQ/eclair | 2,797 | issue_to_patch | Dip into remote initiator reserve only for splices | #2761 introduced the ability for the HTLC sender to let a remote initiator dip into its reserve to unblock channels after a large splice. However, we relaxed that condition for all channels, even those that don't use splice. This creates compatibility issues with other implementations that are stricter than what the sp... | be4ed3c68bcef461b0db24f7fa015d74bf421421 | 0139369c0637a1e1064aa101d5147dfcbd42cbb1 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 6df8ed5fda..5dedab5146 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala"
] | [
{
"comment": "Shouldn't we test channel features instead?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"hunk": "@@ -458,7 +458,7 @@ case class Commitment(fundingTxIndex: Long,\n } else if (missingForReceiver < 0.msat) {\n if (params.localParams.isInitiator)... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala
index d49bda0d51..0f46aa934a 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/e/NormalStateSpec.scala
+++ b/eclair-core... | true | |
ACINQ/eclair | 2,797 | comment_to_fix | Dip into remote initiator reserve only for splices | Shouldn't we test channel features instead? | be4ed3c68bcef461b0db24f7fa015d74bf421421 | 0139369c0637a1e1064aa101d5147dfcbd42cbb1 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 6df8ed5fda..5dedab5146 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala"
] | [
{
"comment": "Shouldn't we test channel features instead?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"hunk": "@@ -458,7 +458,7 @@ case class Commitment(fundingTxIndex: Long,\n } else if (missingForReceiver < 0.msat) {\n if (params.localParams.isInitiator)... | true | ||
ACINQ/eclair | 2,547 | issue_to_patch | Update various doc files | - link to plugins repository
- remove android mention for eclair
- update other implementations (renamed)
- update docker CI action versions
- missing eclair-cli APIs in help | d76d0f6591d3fdb6635ec3eb2b1b89a42bcc4ea5 | 7793665858c94dc0f3f997ba06b83f66ae7dbccb | diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml
index 8d145e39c4..602b224dcf 100644
--- a/.github/workflows/docker-image.yml
+++ b/.github/workflows/docker-image.yml
@@ -11,9 +11,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actio... | [
".github/workflows/docker-image.yml",
"BUILD.md",
"CONTRIBUTING.md",
"README.md",
"eclair-core/eclair-cli"
] | [] | true | ||
ACINQ/eclair | 3,157 | issue_to_patch | Resign next remote commit on reconnection | We previously retransmitted our last `commit_sig` on reconnection if it hadn't been received by our peer, without changing it. This can be an issue for taproot channels when remote nodes don't use deterministic nonce derivation, because their nonce may be different on reconnection and our previous `commit_sig` would th... | ae3e44be7066c6ed45b8b8021d5de95e086954da | ccf8d17a7c45c15d3e4c025f47ac22f6a5ebbcdd | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 7200127321..5ff032398d 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala",
"eclair-core/src/m... | [
{
"comment": "Just to make sure that I get this: data encoded with the old format start with the length of the signature encoded as a varint, which can never be 0 its safe to use 0 as the discriminator for the new format ?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala
index 94667ba947..4d802ebfe4 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel... | true | |
ACINQ/eclair | 3,157 | comment_to_fix | Resign next remote commit on reconnection | Just to make sure that I get this: data encoded with the old format start with the length of the signature encoded as a varint, which can never be 0 its safe to use 0 as the discriminator for the new format ? | ae3e44be7066c6ed45b8b8021d5de95e086954da | ccf8d17a7c45c15d3e4c025f47ac22f6a5ebbcdd | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala
index 12c28c2f35..657e02d3b6 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5... | [
"eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/ChannelCodecs5.scala"
] | [
{
"comment": "Just to make sure that I get this: data encoded with the old format start with the length of the signature encoded as a varint, which can never be 0 its safe to use 0 as the discriminator for the new format ?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version5/... | true | ||
ACINQ/eclair | 2,679 | issue_to_patch | Make shared transaction codecs more future-proof | When we want to add new types of inputs/outputs that contain specific tlvs, we will need to store them alongside standard inputs/outputs.
We will use traits and case classes inside `InteractiveTxBuilder`, and need to thus add a discriminator when encoding them.
Note that this is a backwards-incompatible breaking ... | e7b46314cc47f96316770326698e478a154d9510 | 055251769629dab88584c8fd6814fe8fe51be0f2 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4/ChannelCodecs4.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4/ChannelCodecs4.scala
index 5f83c5f715..9c416275f4 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4... | [
"eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4/ChannelCodecs4.scala"
] | [] | true | ||
ACINQ/eclair | 2,817 | issue_to_patch | Test bitcoind wallet behavior during mempool eviction | When transactions are being evicted from the mempool, we want to make sure that bitcoind keeps the corresponding wallet inputs locked to avoid accidentally double-spending ourselves. We update our unit tests to be closer to common scenarios (chain of unconfirmed splice txs, commit txs replaced by the remote version, an... | 5b1c69cc8483626564b03805c2d92b11d0930e93 | e92291f78d599e2db93c1c44a662135bce2aacdb | [
"eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala"
] | [
{
"comment": "Nit (few occurences)\r\n```suggestion\r\n Seq(200_000 sat, 200_000 sat).foreach { amount =>\r\n miner.sendToAddress(address, amount, 1).pipeTo(sender.ref)\r\n sender.expectMsgType[TxId]\r\n }\r\n```",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/Bitco... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
index 2fd27b9703..f5ad7f3521 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS... | true | ||
ACINQ/eclair | 2,817 | comment_to_fix | Test bitcoind wallet behavior during mempool eviction | Nit (few occurences)
```suggestion
Seq(200_000 sat, 200_000 sat).foreach { amount =>
miner.sendToAddress(address, amount, 1).pipeTo(sender.ref)
sender.expectMsgType[TxId]
}
``` | 5b1c69cc8483626564b03805c2d92b11d0930e93 | e92291f78d599e2db93c1c44a662135bce2aacdb | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
index 2fd27b9703..f5ad7f3521 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS... | [
"eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala"
] | [
{
"comment": "Nit (few occurences)\r\n```suggestion\r\n Seq(200_000 sat, 200_000 sat).foreach { amount =>\r\n miner.sendToAddress(address, amount, 1).pipeTo(sender.ref)\r\n sender.expectMsgType[TxId]\r\n }\r\n```",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/Bitco... | true | ||
ACINQ/eclair | 2,817 | comment_to_fix | Test bitcoind wallet behavior during mempool eviction | I wonder why you didn't use methods like `listlockunspent`, `gettxout`, or `listunspent` to check this? Or did you want to actually use `fundrawtransaction` to be as close as possible to the reality? | 5b1c69cc8483626564b03805c2d92b11d0930e93 | e92291f78d599e2db93c1c44a662135bce2aacdb | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
index 2fd27b9703..f5ad7f3521 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS... | [
"eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala"
] | [
{
"comment": "I wonder why you didn't use methods like `listlockunspent`, `gettxout`, or `listunspent` to check this? Or did you want to actually use `fundrawtransaction` to be as close as possible to the reality?",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpe... | true | ||
ACINQ/eclair | 2,817 | comment_to_fix | Test bitcoind wallet behavior during mempool eviction | 🤓
```suggestion
Seq(spliceTx, anchorTx).foreach { walletTx =>
wallet.rpcClient.invoke("gettransaction", walletTx.txid).pipeTo(sender.ref)
val json = sender.expectMsgType[JValue]
assert(!(json \ "trusted").extract[Boolean])
assert(!(json \ "details" \\ "abandoned").extract[Boolean])
... | 5b1c69cc8483626564b03805c2d92b11d0930e93 | e92291f78d599e2db93c1c44a662135bce2aacdb | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
index 2fd27b9703..f5ad7f3521 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS... | [
"eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala"
] | [
{
"comment": "🤓 \r\n```suggestion\r\n Seq(spliceTx, anchorTx).foreach { walletTx =>\r\n wallet.rpcClient.invoke(\"gettransaction\", walletTx.txid).pipeTo(sender.ref)\r\n val json = sender.expectMsgType[JValue]\r\n assert(!(json \\ \"trusted\").extract[Boolean])\r\n assert(!(json \\ \"det... | true | ||
ACINQ/eclair | 2,817 | comment_to_fix | Test bitcoind wallet behavior during mempool eviction | ```suggestion
// permanently double-spent at their ancestors' level.
``` | 5b1c69cc8483626564b03805c2d92b11d0930e93 | e92291f78d599e2db93c1c44a662135bce2aacdb | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala
index 2fd27b9703..f5ad7f3521 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientS... | [
"eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala"
] | [
{
"comment": "```suggestion\r\n // permanently double-spent at their ancestors' level.\r\n```",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/blockchain/bitcoind/BitcoinCoreClientSpec.scala",
"hunk": "@@ -1374,39 +1491,195 @@ class BitcoinCoreClientSpec extends TestKitBaseClass with BitcoindSer... | true | ||
ACINQ/eclair | 3,261 | issue_to_patch | Add backwards-compatible parts of the official splicing protocol | We extract from #2887 the parts that can be integrated and deployed immediately because they only use odd fields. This reduces the scope of #2887 which will be useful since guaranteeing backwards-compatibility with the experimental splicing protocol that Phoenix currently uses will not be trivial.
This PR contains t... | 890ccb37da47398e5757feea8af32411e88292bf | 70ab54c80d7b27f9d8485d98986e797231c79cbc | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index ba318dbedf..e452e9be2a 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -109,7 +109,7 @@ eclair {
funding {
// Each RBF attempt ad... | [
"eclair-core/src/main/resources/reference.conf",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/PeerConnection.scala",
"eclair-core/src/main/scala/fr/... | [
{
"comment": "Any specific reason for increasing this? Not that I mind.",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -109,7 +109,7 @@ eclair {\n funding {\n // Each RBF attempt adds more data that we need to store and process, so we want to limit our peers to a reason... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/InteractiveTxBuilderSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/InteractiveTxBuilderSpec.scala
index b8d7df7b83..def27c0db4 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/InteractiveTxBuilderSpec.scala
+++ b/eclair-core... | true | |
ACINQ/eclair | 3,261 | comment_to_fix | Add backwards-compatible parts of the official splicing protocol | Any specific reason for increasing this? Not that I mind. | 890ccb37da47398e5757feea8af32411e88292bf | 70ab54c80d7b27f9d8485d98986e797231c79cbc | diff --git a/eclair-core/src/main/resources/reference.conf b/eclair-core/src/main/resources/reference.conf
index ba318dbedf..e452e9be2a 100644
--- a/eclair-core/src/main/resources/reference.conf
+++ b/eclair-core/src/main/resources/reference.conf
@@ -109,7 +109,7 @@ eclair {
funding {
// Each RBF attempt ad... | [
"eclair-core/src/main/resources/reference.conf"
] | [
{
"comment": "Any specific reason for increasing this? Not that I mind.",
"path": "eclair-core/src/main/resources/reference.conf",
"hunk": "@@ -109,7 +109,7 @@ eclair {\n funding {\n // Each RBF attempt adds more data that we need to store and process, so we want to limit our peers to a reason... | true | ||
ACINQ/eclair | 3,261 | comment_to_fix | Add backwards-compatible parts of the official splicing protocol | 👓 👌 | 890ccb37da47398e5757feea8af32411e88292bf | 70ab54c80d7b27f9d8485d98986e797231c79cbc | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
index 901f45ec85..dd18fca801 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala"
] | [
{
"comment": "👓 👌 ",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala",
"hunk": "@@ -1089,9 +1089,11 @@ case class Commitments(channelParams: ChannelParams,\n case _: CommitSig if active.size > 1 => return Left(CommitSigCountMismatch(channelId, active.size, 1))\n ... | true | ||
ACINQ/eclair | 3,261 | comment_to_fix | Add backwards-compatible parts of the official splicing protocol | So it's a generic message batching mechanism 👍 | 890ccb37da47398e5757feea8af32411e88292bf | 70ab54c80d7b27f9d8485d98986e797231c79cbc | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala
index ac0f921e50..9aad296841 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala
+++ b/eclair-core/src/main/scala/fr/acinq... | [
"eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala"
] | [
{
"comment": "So it's a generic message batching mechanism 👍 ",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/ChannelTlv.scala",
"hunk": "@@ -395,3 +403,13 @@ object ClosingSigTlv {\n )\n }\n \n+sealed trait StartBatchTlv extends Tlv\n+\n+object StartBatchTlv {\n+ /** Type of [[L... | true | ||
ACINQ/eclair | 2,844 | issue_to_patch | Remove redundant check on `remoteScriptPubkey` | If the peer had `option_shutdown_anysegwit` enabled when they initially sent their `remoteScriptPubkey`, but reconnected later with `option_shutdown_anysegwit` disabled, then `isValidFinalScriptPubkey` may not pass anymore. | c8184b3e43a603454d672aed61b2ae461a80e1a8 | fe0b88f1445fd732769d5bab8f61a6726959fb6b | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index cadcf14950..e84f82f308 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala"
] | [] | true | ||
ACINQ/eclair | 1,927 | issue_to_patch | Add `AbstractChannelRestored` event trait | This is an alternative and hopefully more principled solution to https://github.com/ACINQ/eclair/pull/1924. It makes `Register` in base Eclair to rely on new `ChannelAvailable` trait rather than on concrete `ChannelRestored` class so non-standard channels can be injected into `Register` without affecting other parts of... | 275581df9629eded8a1a78afe92ebf5641637080 | ff0c9b2c869e00d302f9dc84094a17dcc7990817 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
index ba9275e1ee..9999ce323c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/c... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala"
] | [
{
"comment": "For consistency with `Commitment`/`AbstractCommitments`, and because `Available` has another meaning for channels.\r\n\r\n```suggestion\r\ntrait AbstractChannelRestored extends ChannelEvent {\r\n val channel: ActorRef\r\n val channelId: ByteVector32\r\n val peer: ActorRef\r\n val remoteNodeId:... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
new file mode 100644
index 0000000000..b32ec0d9bd
--- /dev/null
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
@@ -0,0 +1,24 @@
+package... | true | |
ACINQ/eclair | 1,927 | comment_to_fix | Add `AbstractChannelRestored` event trait | For consistency with `Commitment`/`AbstractCommitments`, and because `Available` has another meaning for channels.
```suggestion
trait AbstractChannelRestored extends ChannelEvent {
val channel: ActorRef
val channelId: ByteVector32
val peer: ActorRef
val remoteNodeId: PublicKey
}
case class ChannelR... | 275581df9629eded8a1a78afe92ebf5641637080 | ff0c9b2c869e00d302f9dc84094a17dcc7990817 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
index ba9275e1ee..9999ce323c 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/c... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelEvents.scala"
] | [
{
"comment": "For consistency with `Commitment`/`AbstractCommitments`, and because `Available` has another meaning for channels.\r\n\r\n```suggestion\r\ntrait AbstractChannelRestored extends ChannelEvent {\r\n val channel: ActorRef\r\n val channelId: ByteVector32\r\n val peer: ActorRef\r\n val remoteNodeId:... | true | ||
ACINQ/eclair | 1,927 | comment_to_fix | Add `AbstractChannelRestored` event trait | You should use the same pattern as other test suites in the repo, see `PostRestartHtlcCleanerSpec` for example:
```suggestion
class RegisterSpec extends AnyFunSuite extends TestKitBaseClass with AnyFunSuiteLike with ParallelTestExecution {
``` | 275581df9629eded8a1a78afe92ebf5641637080 | ff0c9b2c869e00d302f9dc84094a17dcc7990817 | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
new file mode 100644
index 0000000000..b32ec0d9bd
--- /dev/null
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
@@ -0,0 +1,24 @@
+package... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala"
] | [
{
"comment": "You should use the same pattern as other test suites in the repo, see `PostRestartHtlcCleanerSpec` for example:\r\n\r\n```suggestion\r\nclass RegisterSpec extends AnyFunSuite extends TestKitBaseClass with AnyFunSuiteLike with ParallelTestExecution {\r\n```",
"path": "eclair-core/src/test/scala... | true | ||
ACINQ/eclair | 1,927 | comment_to_fix | Add `AbstractChannelRestored` event trait | You should use `awaitCond` to avoid blocking with `Await`. This is done in many other tests if you need examples.
And your test should be more thorough: you should wait until the register returns a map which contains `customRestoredEvent.channelId` as key, AND that the value is the right actor ref. | 275581df9629eded8a1a78afe92ebf5641637080 | ff0c9b2c869e00d302f9dc84094a17dcc7990817 | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
new file mode 100644
index 0000000000..b32ec0d9bd
--- /dev/null
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
@@ -0,0 +1,24 @@
+package... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala"
] | [
{
"comment": "You should use `awaitCond` to avoid blocking with `Await`. This is done in many other tests if you need examples.\r\n\r\nAnd your test should be more thorough: you should wait until the register returns a map which contains `customRestoredEvent.channelId` as key, AND that the value is the right ac... | true | ||
ACINQ/eclair | 1,927 | comment_to_fix | Add `AbstractChannelRestored` event trait | Unnecessary if you extends the right traits as suggested above. | 275581df9629eded8a1a78afe92ebf5641637080 | ff0c9b2c869e00d302f9dc84094a17dcc7990817 | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
new file mode 100644
index 0000000000..b32ec0d9bd
--- /dev/null
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala
@@ -0,0 +1,24 @@
+package... | [
"eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala"
] | [
{
"comment": "Unnecessary if you extends the right traits as suggested above.",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/channel/RegisterSpec.scala",
"hunk": "@@ -0,0 +1,30 @@\n+package fr.acinq.eclair.channel\n+\n+import fr.acinq.eclair._\n+\n+import scala.concurrent.duration._\n+import akka... | true | ||
ACINQ/eclair | 1,769 | issue_to_patch | Add shorter CI timeout | The default is 360 minutes which is very long.
Our builds are usually around 10 minutes, so 20 minutes is a good value to prevent overbilling builds that create infinite loops. | eb834e2522eb71f410f05300f8937a862c4c83dd | 67eb7a2358bec8b60894e0ad38eb9adcd7ef3425 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index ea78912db4..3a48b058d8 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -10,6 +10,7 @@ jobs:
build:
runs-on: ubuntu-latest
+ timeout-minutes: 20
steps:
- uses: actions/checkout@v2
| [
".github/workflows/main.yml"
] | [] | true | ||
ACINQ/eclair | 2,935 | issue_to_patch | Add force-close notification | 4ca8ea025e68f5db389326ccfc883a356e8d5ea4 | c28907bb8029aef03a5d087287f7720a5214344b | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
index 4ca0696caa..cb6ebe1005 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala
+++ b/eclair-core/src/main/scala/fr/ac... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/ErrorHandlers.scala"
] | [] | true | |||
ACINQ/eclair | 2,322 | issue_to_patch | Make actors signal when they are ready | Since actors are initialized asynchronously, and the initialization sometimes involves subscribing to an `EventStream`, we don't know when they are ready to process messages, especially in tests, which lead to race conditions. By making actors publish `SubscriptionsComplete ` on the same `EventStream` they are subscri... | 6b2e415ecbbd1a602969efb327d9452458129090 | 9ca8551a1d16a2cec2acb1ea46373a3d9266946e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/SubscriptionsComplete.scala b/eclair-core/src/main/scala/fr/acinq/eclair/SubscriptionsComplete.scala
new file mode 100644
index 0000000000..23541c5263
--- /dev/null
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/SubscriptionsComplete.scala
@@ -0,0 +1,10 @@
+pack... | [
"eclair-core/src/main/scala/fr/acinq/eclair/SubscriptionsComplete.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/io/Switchboard.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/ChannelRelayer.scala",
"eclair-core/src/... | [
{
"comment": "nit:\r\n```suggestion\r\n * leads to race conditions.\r\n```",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/IAmReady.scala",
"hunk": "@@ -0,0 +1,10 @@\n+package fr.acinq.eclair\n+\n+/**\n+ * Since actors are initialized asynchronously, and the initialization sometimes involves subsc... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala
index 491a3ea271..4646f513a2 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/Min... | true | |
ACINQ/eclair | 2,322 | comment_to_fix | Make actors signal when they are ready | nit: revert | 6b2e415ecbbd1a602969efb327d9452458129090 | 9ca8551a1d16a2cec2acb1ea46373a3d9266946e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala
index 7622bd13f1..f7d3e6c2cc 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala"
] | [
{
"comment": "nit: revert",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala",
"hunk": "@@ -69,15 +70,19 @@ class Register extends Actor with ActorLogging {\n val compatReplyTo = if (replyTo == ActorRef.noSender) sender() else replyTo\n channels.get(channelId) match... | true | ||
ACINQ/eclair | 2,322 | comment_to_fix | Make actors signal when they are ready | nit: revert | 6b2e415ecbbd1a602969efb327d9452458129090 | 9ca8551a1d16a2cec2acb1ea46373a3d9266946e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala
index 7622bd13f1..f7d3e6c2cc 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Register... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala"
] | [
{
"comment": "nit: revert",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Register.scala",
"hunk": "@@ -69,15 +70,19 @@ class Register extends Actor with ActorLogging {\n val compatReplyTo = if (replyTo == ActorRef.noSender) sender() else replyTo\n channels.get(channelId) match... | true | ||
ACINQ/eclair | 2,322 | comment_to_fix | Make actors signal when they are ready | I don't think we need that anymore now, do we? The `readyListener` will be registered before the other actors (since they're created after), so the `readyListener.expectMsgAllOf` below should be enough. | 6b2e415ecbbd1a602969efb327d9452458129090 | 9ca8551a1d16a2cec2acb1ea46373a3d9266946e | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala b/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala
index 491a3ea271..4646f513a2 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/Min... | [
"eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNodeFixture.scala"
] | [
{
"comment": "I don't think we need that anymore now, do we? The `readyListener` will be registered before the other actors (since they're created after), so the `readyListener.expectMsgAllOf` below should be enough.",
"path": "eclair-core/src/test/scala/fr/acinq/eclair/integration/basic/fixtures/MinimalNod... | true | ||
ACINQ/eclair | 2,322 | comment_to_fix | Make actors signal when they are ready | Shouldn't we emit `IAmReady` just before `startWith`, once we've finished initializing all data? | 6b2e415ecbbd1a602969efb327d9452458129090 | 9ca8551a1d16a2cec2acb1ea46373a3d9266946e | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
index 5755151d33..4a7224fc27 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala
@@ -6... | [
"eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala"
] | [
{
"comment": "Shouldn't we emit `IAmReady` just before `startWith`, once we've finished initializing all data?",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/router/Router.scala",
"hunk": "@@ -62,6 +62,7 @@ class Router(val nodeParams: NodeParams, watcher: typed.ActorRef[ZmqWatcher.Comm\n conte... | true | ||
ACINQ/eclair | 2,662 | issue_to_patch | Eclair rejected its own closing fee
I had a peer force-close after it rejected us sending the shutdown fee it explicitly said it would accept while running Eclair 0.7.0-a804905.
The messages on the wire were as follows:
```
2023-04-28 03:26:16.027 TRACE [lightning::ln::peer_handler:1381] Received message Shut... | Accept closing fee above commit fee | When performing a mutual close, we initially rejected fees that were higher to the commit tx fees. This was removed from the specification for anchor output channels, and doesn't make a lot of sense for standard channels either: even at a higher fee, it makes sense to do a mutual close to avoid waiting for relative del... | c73db8479c7a7ce05d61d2e31935d1088236dd01 | 984177a4361efba3d9238ab195296544ed6b4ac1 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 7b22c886e8..96c721a303 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"eclair-core/src/test/scala/fr/acinq/eclair/channel/states/g/NegotiatingStateSpec.scala"
] | [] | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/g/NegotiatingStateSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/g/NegotiatingStateSpec.scala
index 0f25425948..1b467703a0 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/states/g/NegotiatingStateSpec.scala
++... | true |
ACINQ/eclair | 1,900 | issue_to_patch | Lower minimum remote dust limit | Implement https://github.com/lightningnetwork/lightning-rfc/pull/894
We can safely accept dust limits as small as 354 sats, as long as we explicitly handle the case where a closing tx is generated with an output below dust (when that happens, we force-close to get our funds back).
The spec PR received broad agree... | 467a0bc82975f354143a52504c6fcabe273cf031 | ca2c87f1990bf98a07fa2bc2a3a2cc91db2d9444 | diff --git a/docs/release-notes/eclair-vnext.md b/docs/release-notes/eclair-vnext.md
index dacd58be80..e129106981 100644
--- a/docs/release-notes/eclair-vnext.md
+++ b/docs/release-notes/eclair-vnext.md
@@ -106,6 +106,16 @@ This is fixed in this release: when using Tor, the watchdogs will now also be qu
You can also n... | [
"docs/release-notes/eclair-vnext.md",
"eclair-core/src/main/scala/fr/acinq/eclair/NodeParams.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/ChannelExceptions.scala",
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.s... | [
{
"comment": "Trusting you on this...",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"hunk": "@@ -518,14 +518,36 @@ object Helpers {\n Left(InvalidCloseFee(commitments.channelId, remoteClosingFee))\n } else {\n val (closingTx, closingSigned) = makeClo... | diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala
index ce1590c6ae..6f0a3dc694 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/channel/HelpersSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/channel... | true | |
ACINQ/eclair | 1,900 | comment_to_fix | Lower minimum remote dust limit | Trusting you on this... | 467a0bc82975f354143a52504c6fcabe273cf031 | ca2c87f1990bf98a07fa2bc2a3a2cc91db2d9444 | diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
index 675ebad7fd..afa436caa8 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.sca... | [
"eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala"
] | [
{
"comment": "Trusting you on this...",
"path": "eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala",
"hunk": "@@ -518,14 +518,36 @@ object Helpers {\n Left(InvalidCloseFee(commitments.channelId, remoteClosingFee))\n } else {\n val (closingTx, closingSigned) = makeClo... | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 84 | issue_to_patch | Open "Randomness, random variable and random sample" links in a new tab | Cells where multiple links are present are not opening in a new tab. Added target manually by editing the xml. | 2cc62bd82b5ba9d01c02636ac483d6443672f90c | e281799a48af7e0eaeddbf9ebc0559f680582a90 | diff --git a/images/datascience.svg b/images/datascience.svg
index 23c9cb0..f794f5e 100644
--- a/images/datascience.svg
+++ b/images/datascience.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns="ht... | [
"images/datascience.svg",
"images/datascience.xml"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 44 | issue_to_patch | Update readme.md | Made a few changes to the readme file | c5c5735bee9708c60ef61a2f06e5a38abf8c27a4 | 6d9cbd2cd20dd9644c8d50c83d71f661af24dda7 | diff --git a/readme.md b/readme.md
index 3636b73..8144dbc 100644
--- a/readme.md
+++ b/readme.md
@@ -26,7 +26,7 @@ To receive updates [star :star:](https://github.com/AMAI-GmbH/AI-Expert-Roadmap/
## Disclaimer
-The purpose of these roadmaps is to give you an idea about the landscape and to guide you if you are con... | [
"readme.md"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 42 | issue_to_patch | Changing the link in Overfitting / Underfitting | The current article linked is so poorly written that it often feels cryptic. | c5c5735bee9708c60ef61a2f06e5a38abf8c27a4 | 6050a922b34d7e9c237faf17306825a6ee2be702 | diff --git a/images/machine_learning.xml b/images/machine_learning.xml
index 288ef9e..9e71319 100644
--- a/images/machine_learning.xml
+++ b/images/machine_learning.xml
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
-<mxfile modified="2020-11-29T10:38:48.829Z" host="app.diagrams.net" agent="5.0 (Macintosh; Int... | [
"images/machine_learning.xml"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 34 | issue_to_patch | Aesthetic Edits to Data Science and Fundamentals Roadmap | f40afb42c280b496872b1db2aa99cc5e883e9963 | 81bb7132c8d865ac66505a41dd4f58dc93529519 | diff --git a/images/datascience.svg b/images/datascience.svg
index dab5f3d..23c9cb0 100644
--- a/images/datascience.svg
+++ b/images/datascience.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns="ht... | [
"images/datascience.svg",
"images/datascience.xml",
"images/fundamentals.svg",
"images/fundamentals.xml",
"images/intro.svg",
"images/intro.xml",
"readme.md"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 26 | issue_to_patch | Fixed dead link to Denoising article | d0b1ea10dc2ffd34d36f12c29098f411ebdfb992 | 570451cf7e647320a9be319daa91cc5a75ebbeca | diff --git a/images/fundamentals.svg b/images/fundamentals.svg
index abb099d..299e94d 100644
--- a/images/fundamentals.svg
+++ b/images/fundamentals.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns... | [
"images/fundamentals.svg",
"images/fundamentals.xml"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 24 | issue_to_patch | Bumped year to 2021 | 2e20e67c95ab4b3d11fd0831719f3a4522c11852 | bce379a1a61445cfd89fdd84f3ec625340d87ebc | diff --git a/LICENSE b/LICENSE
index 7c83769..05b9c55 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,6 +1,6 @@
MIT License
-Copyright (c) 2020 AMAI GmbH
+Copyright (c) 2021 AMAI GmbH
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "S... | [
"LICENSE",
"images/intro.svg",
"images/intro.xml",
"package.json",
"readme.md"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 4 | issue_to_patch | Added note to interactive version | ad45a076cd5b32143941a1b8a92063462a1b53f5 | 34b3124f0db7cb1c4277e555f96baab2389994d3 | diff --git a/images/big_data_engineer.svg b/images/big_data_engineer.svg
index 2a3a0e0..2abefc2 100644
--- a/images/big_data_engineer.svg
+++ b/images/big_data_engineer.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg... | [
"images/big_data_engineer.svg",
"images/big_data_engineer.xml",
"images/datascience.svg",
"images/datascience.xml"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 19 | issue_to_patch | Fixing typo in the word 'resources' | 432aa09b7608d1fd28869ba7b530d8fb9795e6c2 | 9dd4972d678ceb6c74360562c99430ceaf84d397 | diff --git a/images/fundamentals.svg b/images/fundamentals.svg
index 7d35f75..abb099d 100644
--- a/images/fundamentals.svg
+++ b/images/fundamentals.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns... | [
"images/fundamentals.svg",
"images/fundamentals.xml"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 18 | issue_to_patch | Fixed Issues from ErdosEuge and Hellisotherpeople | c3fc763913551733640e5b2191e82a3c293de6f5 | bb55e565894a76a463d8f3e3b6244b7ec5271dc9 | diff --git a/images/big_data_engineer.svg b/images/big_data_engineer.svg
index 2abefc2..7b19401 100644
--- a/images/big_data_engineer.svg
+++ b/images/big_data_engineer.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg... | [
"images/big_data_engineer.svg",
"images/big_data_engineer.xml",
"images/datascience.svg",
"images/datascience.xml",
"images/deep_learning.svg",
"images/deep_learning.xml",
"images/fundamentals.svg",
"images/fundamentals.xml",
"images/intro.svg",
"images/intro.xml",
"images/machine_learning.svg",... | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 15 | issue_to_patch | Disable "Blob storage website CI" action on pull requests | - action requires credentials which are not passed to PRs | e63bfdb8f4d20be2a967539ae807074e4e8c9c09 | 91d8f58397cbf15de4c96fcbe3e0cea4caf82ff2 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index e7e3b31..1882abc 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -7,8 +7,6 @@ name: Blob storage website CI
on:
push:
branches: [ main ]
- pull_request:
- branches: [ main ]
jobs:
build:
| [
".github/workflows/main.yml"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 14 | issue_to_patch | Revise "Deep Learning" Section | - revise and extend the "Deep Learning" section
- minor adjustments in contribution guidelines | e63bfdb8f4d20be2a967539ae807074e4e8c9c09 | 79390919d67fa276b1a70eed26a998d89ca08841 | diff --git a/contributing.md b/contributing.md
index f8624ac..f7b67d0 100644
--- a/contributing.md
+++ b/contributing.md
@@ -9,9 +9,9 @@ Our goal is to have a list of things that anybody would have to learn if they we
Your contributions to this repo are always welcome!
Bear in mind, that this repo is *highly opinio... | [
"contributing.md",
"images/deep_learning.svg",
"images/deep_learning.xml"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 13 | issue_to_patch | fix: misplaced wiki link of MLE & KDE | 38ff460e7ce55cb6dbfc3c95a8b30cbf6db9e218 | 8fffc961a54962e375ec68bd0a05a9be8bcb7a31 | diff --git a/images/datascience.svg b/images/datascience.svg
index 7618cd4..2ebb734 100644
--- a/images/datascience.svg
+++ b/images/datascience.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns="ht... | [
"images/datascience.svg",
"images/datascience.xml"
] | [] | true | |||
AMAI-GmbH/AI-Expert-Roadmap | 6 | issue_to_patch | Added link to Khan Academy for Linear Algebra | Added link to Khan Academy as a good resource for Linear Algebra, Matrix Transformations and fundamentals | 72cff0b951599dcb7d821ae008038654813d3d45 | 2acae74468b2029124556f5c89eafd7998a1543b | diff --git a/images/datascience.svg b/images/datascience.svg
index b4c952d..7618cd4 100644
--- a/images/datascience.svg
+++ b/images/datascience.svg
@@ -1,3 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
-<svg xmlns="ht... | [
"images/datascience.svg",
"images/datascience.xml"
] | [] | true | ||
AMAI-GmbH/AI-Expert-Roadmap | 8 | issue_to_patch | Typo | just a typo @JStumpp
| 739402c06015d247b2260f3582e4552dc16940f4 | 0071419330eb7d985cb22f78a98fd53d84963b3c | diff --git a/readme.md b/readme.md
index f9e48ff..63580bc 100644
--- a/readme.md
+++ b/readme.md
@@ -16,7 +16,7 @@
Below you find a set of charts demonstrating the paths that you can take and the technologies that you would want to adopt in order to become a data scientist, machine learning or an ai expert. We made ... | [
"readme.md"
] | [] | true | ||
Aider-AI/aider | 5,132 | issue_to_patch | feat: add bash tree-sitter tags for repomap support | Adds tree-sitter tag queries for Bash/shell scripts so the repo map can index `.sh`, `.bash`, and `.zsh` files.
## What
- New `bash-tags.scm` under both `tree-sitter-language-pack/` and `tree-sitter-languages/` (matching the MATLAB precedent in #20429b685)
- Captures: `function_definition` → definitions, `variable... | 3ec8ec5a7d695b08a6c24fe6c0c235c8f87df9af | ff191affc6e1413f33dad914d9930a5993aad853 | diff --git a/aider/queries/tree-sitter-language-pack/bash-tags.scm b/aider/queries/tree-sitter-language-pack/bash-tags.scm
new file mode 100644
index 00000000000..f89e305e107
--- /dev/null
+++ b/aider/queries/tree-sitter-language-pack/bash-tags.scm
@@ -0,0 +1,8 @@
+(function_definition
+ name: (word) @name.definition.... | [
"aider/queries/tree-sitter-language-pack/bash-tags.scm",
"aider/queries/tree-sitter-languages/bash-tags.scm",
"tests/basic/test_repomap.py",
"tests/fixtures/languages/bash/test.sh"
] | [
{
"comment": "Very good",
"path": "tests/basic/test_repomap.py",
"hunk": "@@ -400,6 +400,9 @@ def test_language_ocaml_interface(self):\n def test_language_matlab(self):\n self._test_language_repo_map(\"matlab\", \"m\", \"Person\")",
"resolving_sha": "ff191affc6e1413f33dad914d9930a5993aad... | diff --git a/tests/basic/test_repomap.py b/tests/basic/test_repomap.py
index 9df806194ac..9453f6c05a8 100644
--- a/tests/basic/test_repomap.py
+++ b/tests/basic/test_repomap.py
@@ -400,6 +400,9 @@ def test_language_ocaml_interface(self):
def test_language_matlab(self):
self._test_language_repo_map("matlab... | true | |
Aider-AI/aider | 5,173 | issue_to_patch | Expand ANTHROPIC_MODELS list with recent Claude model names | ## Summary
\`ANTHROPIC_MODELS\` in \`aider/models.py\` is used by \`sanity_check_models\` to map a bare Claude model name (no provider prefix) to the \`ANTHROPIC_API_KEY\` environment variable. Models not in this list fall through to the keymap provider lookup, which fails when the user passes the name without a provi... | 6435cb8b1e885d7275327d4b61206b1b1618dfe1 | a7a54a9367fefb46fa576840e97f4479c46c7771 | diff --git a/HISTORY.md b/HISTORY.md
index 8e086e757b7..3d523bdccde 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -2,6 +2,7 @@
### main branch
+- Expanded `ANTHROPIC_MODELS` list with Claude Opus 4.1/4.5/4.6/4.7 dated variants and Claude Sonnet 3.7 so the Anthropic API key auto-detection (`models.sanity_check_models... | [
"HISTORY.md",
"aider/models.py"
] | [] | true | ||
Aider-AI/aider | 4,935 | issue_to_patch | fix: replace two deprecated models, delete one | Three models that the unit tests use are no longer available online:
- `gpt-4-32k` (see https://github.com/BerriAI/litellm/pull/20795 and https://github.com/BerriAI/litellm/commit/15075ef9ec881cd51831f9e40423fb2058f701f8)
- `claude-3-5-sonnet-20240620` (see https://github.com/BerriAI/litellm/pull/23400 and https:... | 861a1e4d154f268547a06497cc380e5a5dc8483a | 55164933dc152308b8aeb8f78afc461248470e5c | [
"tests/basic/test_commands.py",
"tests/basic/test_models.py"
] | [] | diff --git a/tests/basic/test_commands.py b/tests/basic/test_commands.py
index 47b8832dc42..406e928ebf2 100644
--- a/tests/basic/test_commands.py
+++ b/tests/basic/test_commands.py
@@ -536,7 +536,7 @@ def test_cmd_tokens_output(self):
io = InputOutput(pretty=False, fancy_input=False, yes=False)
... | true | ||
Aider-AI/aider | 4,899 | issue_to_patch | Add Python 3.13 and 3.14 support | This PR enables Python 3.13 and 3.14 for aider-chat.
What changed:
- widens requires-python to 3.10 through 3.14
- expands the Ubuntu and Windows workflow matrices to 3.10 through 3.14
- adds marker-based NumPy and SciPy requirements so Python 3.10 stays on older compatible versions while Python 3.11+ can use versions... | 265d8a473b5d5bf001db321b251674a120ad75da | 975e5a899168444cba6f85d57070cb0012deb75d | diff --git a/.github/workflows/check_pypi_version.yml b/.github/workflows/check_pypi_version.yml
index b383e87be88..2aaacc3761f 100644
--- a/.github/workflows/check_pypi_version.yml
+++ b/.github/workflows/check_pypi_version.yml
@@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- ... | [
".github/workflows/check_pypi_version.yml",
".github/workflows/ubuntu-tests.yml",
".github/workflows/windows-tests.yml",
".github/workflows/windows_check_pypi_version.yml",
"pyproject.toml",
"requirements.txt",
"requirements/common-constraints.txt",
"requirements/pydub.in",
"requirements/python-comp... | [] | true | ||
Aider-AI/aider | 4,674 | issue_to_patch | Allow adding read-only files to editable with git: false. | When `git: false` is configured, aider won't promote a read-only file in the repo to editable:
> Cannot add /home/chrism/dev/runprompt/README.md as it's not part of the repository
This patch fixes that behaviour so it can promote the file to editable just as if it had been /add'ed. | 5683f1c089ac42debcd951bad972b348aede21d8 | f73085357cf633d04cfa36a5a8f1de3bb826d71c | diff --git a/aider/commands.py b/aider/commands.py
index b9a3d3c2a20..e4567684c89 100644
--- a/aider/commands.py
+++ b/aider/commands.py
@@ -864,7 +864,13 @@ def cmd_add(self, args):
self.io.tool_error(f"{matched_file} is already in the chat as an editable file")
continue
... | [
"aider/commands.py",
"aider/repo.py"
] | [] | true | ||
Aider-AI/aider | 4,682 | issue_to_patch | Don't stage files with no-auto-commits. | This patch prevents aider from staging files (e.g. `git add`) when it's in no-auto-commits mode. | 5683f1c089ac42debcd951bad972b348aede21d8 | 4e77720c6f96d4960b61ef19f32a2ee12218bf96 | diff --git a/aider/coders/base_coder.py b/aider/coders/base_coder.py
index b824e928693..56613782b02 100755
--- a/aider/coders/base_coder.py
+++ b/aider/coders/base_coder.py
@@ -2216,7 +2216,7 @@ def allowed_to_edit(self, path):
# Seems unlikely that we needed to create the file, but it was
... | [
"aider/coders/base_coder.py"
] | [] | true | ||
Aider-AI/aider | 4,830 | issue_to_patch | Allow adding files outside repo when git commits off. | For people who don't allow aider to make commits it is useful to be able to modify files outside the repo. | 7a1bd15f0c78160129c3b7ffc5ffc94bd992bbbe | 172df73b85c450aeb99811cc777acfeb059d450a | diff --git a/aider/commands.py b/aider/commands.py
index b9a3d3c2a20..e104f6eca25 100644
--- a/aider/commands.py
+++ b/aider/commands.py
@@ -846,7 +846,11 @@ def cmd_add(self, args):
for matched_file in sorted(all_matched_files):
abs_file_path = self.coder.abs_root_path(matched_file)
- ... | [
"aider/commands.py"
] | [] | true | ||
Aider-AI/aider | 4,838 | issue_to_patch | Uncaught RuntimeError in pathlib.py line 1074
Aider version: 0.86.1
Python version: 3.10.12
Platform: Linux-6.8.0-87-generic-x86_64-with-glibc2.35
Python implementation: CPython
Virtual environment: Yes
OS: Linux 6.8.0-87-generic (64bit)
Git version: git version 2.34.1
An uncaught exception occurred:
```
Traceback (... | fix: handle symlink loops in safe_abs_path() | ## Summary
- Fixes #4711 — `Path.resolve()` raises `RuntimeError` when encountering circular symlinks (e.g. `v8/v8 -> v8/v8`), crashing aider during repo map generation.
- Wraps the `Path.resolve()` call in `safe_abs_path()` with a try/except for `RuntimeError` and `OSError`, falling back to `Path.absolute()` which do... | 4625ebb4b517ce51db0aa7eb92c3fea61243610f | b2bec25c2c785989d6456cb03321a61f539bcc86 | diff --git a/aider/utils.py b/aider/utils.py
index 834ffa1953d..f8d843eec4f 100644
--- a/aider/utils.py
+++ b/aider/utils.py
@@ -95,7 +95,10 @@ def is_image_file(file_name):
def safe_abs_path(res):
"Gives an abs path, which safely returns a full (not 8.3) windows path"
- res = Path(res).resolve()
+ try:
+... | [
"aider/utils.py",
"tests/basic/test_utils.py"
] | [] | diff --git a/tests/basic/test_utils.py b/tests/basic/test_utils.py
new file mode 100644
index 00000000000..9f5c0a54bc7
--- /dev/null
+++ b/tests/basic/test_utils.py
@@ -0,0 +1,15 @@
+import os
+
+from aider.utils import safe_abs_path
+
+
+def test_safe_abs_path_symlink_loop(tmp_path):
+ # Create circular symlink: a ... | true |
Aider-AI/aider | 4,772 | issue_to_patch | Remove `google-generativeai` as a dependency. | The `google-generativeai` package is deprecated, and emits warnings when it's imported. I'm doing some cleanup work to remove it from popular surfacess, so here's a PR :)
I'll note that `litellm` uses direct HTTP requests for the API, so it does not use `google-genai` (except for type checking) or `google-generative... | fb05748ace65bea780e0766b14b0904fbaac5f7f | d91c02c205b3d23d3da9e58594751255cd12bd52 | diff --git a/aider/exceptions.py b/aider/exceptions.py
index 87d100ae6bf..5cbd023cc4b 100644
--- a/aider/exceptions.py
+++ b/aider/exceptions.py
@@ -82,10 +82,6 @@ def get_ex_info(self, ex):
import litellm
if ex.__class__ is litellm.APIConnectionError:
- if "google.auth" in str(ex):
- ... | [
"aider/exceptions.py",
"aider/website/docs/llms/gemini.md",
"requirements.txt",
"requirements/common-constraints.txt",
"requirements/requirements-browser.txt",
"requirements/requirements-dev.txt",
"requirements/requirements-help.txt",
"requirements/requirements.in"
] | [] | true | ||
Aider-AI/aider | 4,748 | issue_to_patch | Fix regression in the LiteLLM exception list | In an attempt to fix issue #4615, commit 656301c introduced a regression where running the `coder` feature raises the following error:
> TypeError: catching classes that do not inherit from BaseException is not allowed
The primary misunderstanding that caused the regression is the fact that `ErrorEventError` soun... | 1354e0bfa4847c1a71b9eea7374847a786d81c1b | 08165c57a21636d0f995abf55de33fd9bbbcee94 | diff --git a/aider/exceptions.py b/aider/exceptions.py
index c2d0feb3bc9..87d100ae6bf 100644
--- a/aider/exceptions.py
+++ b/aider/exceptions.py
@@ -29,7 +29,6 @@ class ExInfo:
"The API provider has refused the request due to a safety policy about the content.",
),
ExInfo("ContextWindowExceededError"... | [
"aider/exceptions.py"
] | [] | true | ||
Aider-AI/aider | 4,698 | issue_to_patch | Add gpt-5.2 models | This PR adds support for the new [`gpt-5.2`](https://openai.com/index/introducing-gpt-5-2/) models. | 5683f1c089ac42debcd951bad972b348aede21d8 | 4ff959f55b32dff9e486437e8ff774e808367b11 | diff --git a/aider/resources/model-settings.yml b/aider/resources/model-settings.yml
index bb6e0981ebd..e4ec13d8cc7 100644
--- a/aider/resources/model-settings.yml
+++ b/aider/resources/model-settings.yml
@@ -1899,6 +1899,33 @@
use_temperature: false
accepts_settings: ["reasoning_effort"]
+- name: gpt-5.2-pro
+... | [
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 4,656 | issue_to_patch | Add support for the latest GPT and Gemini models | This PR adds support for the latest `gpt-5-pro`, `gpt-5.1`, and `gemini-3-pro-preview` models. | c74f5efb2f3870f56f33ed1dbe2c4167742bcb88 | ab29b9951885003ca2baac7a9131011efae8df77 | diff --git a/aider/models.py b/aider/models.py
index 4a5d86a6975..db0c28d1ede 100644
--- a/aider/models.py
+++ b/aider/models.py
@@ -98,7 +98,8 @@
"quasar": "openrouter/openrouter/quasar-alpha",
"r1": "deepseek/deepseek-reasoner",
"gemini-2.5-pro": "gemini/gemini-2.5-pro",
- "gemini": "gemini/gemini-2... | [
"aider/models.py",
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 4,621 | issue_to_patch | add initial haskell-tags.scm for repomap building | Adds basic repomap support for haskell. Beyond the included tests, here's an example of running with these changes on an existing haskell project:
```shell
❯ git clone https://github.com/jaspervdj/websockets.git
❯ cd websockets
❯ AIDER_ANALYTICS_DISABLE=1 OPENAI_API_KEY=dummy \
aider \
... | 11516d6d6bc7466b441971f7fb34790242f2a982 | 93f20a6d23fa9969906fe4f05277d44c27a79b8e | diff --git a/aider/queries/tree-sitter-languages/haskell-tags.scm b/aider/queries/tree-sitter-languages/haskell-tags.scm
new file mode 100644
index 00000000000..f5c073750a6
--- /dev/null
+++ b/aider/queries/tree-sitter-languages/haskell-tags.scm
@@ -0,0 +1,3 @@
+(function (variable) @name.definition.function)
+(bind ... | [
"aider/queries/tree-sitter-languages/haskell-tags.scm",
"tests/basic/test_repomap.py",
"tests/fixtures/languages/haskell/test.hs"
] | [] | diff --git a/tests/basic/test_repomap.py b/tests/basic/test_repomap.py
index 185e6e62d5f..035c7c31cea 100644
--- a/tests/basic/test_repomap.py
+++ b/tests/basic/test_repomap.py
@@ -302,6 +302,9 @@ def test_language_elixir(self):
def test_language_gleam(self):
self._test_language_repo_map("gleam", "gleam",... | true | |
Aider-AI/aider | 4,620 | issue_to_patch | add initial zig-tags.scm for repomap building | Adds basic repomap support for zig. Beyond the included tests, here's an example of running with these changes on an existing zig project:
```sh
❯ git clone https://github.com/BrookJeynes/jido.git
❯ cd jido
❯ AIDER_ANALYTICS_DISABLE=1 OPENAI_API_KEY=dummy \
aider \
--no-ch... | 11516d6d6bc7466b441971f7fb34790242f2a982 | be8da40b1f050fa325265a75e92b1d7d308679dd | diff --git a/aider/queries/tree-sitter-languages/zig-tags.scm b/aider/queries/tree-sitter-languages/zig-tags.scm
new file mode 100644
index 00000000000..c02028ea8a1
--- /dev/null
+++ b/aider/queries/tree-sitter-languages/zig-tags.scm
@@ -0,0 +1,3 @@
+(FnProto) @name.definition.function
+(VarDecl "const" @name.definitio... | [
"aider/queries/tree-sitter-languages/zig-tags.scm",
"tests/basic/test_repomap.py",
"tests/fixtures/languages/zig/test.zig"
] | [] | diff --git a/tests/basic/test_repomap.py b/tests/basic/test_repomap.py
index 185e6e62d5f..2c965bdffa6 100644
--- a/tests/basic/test_repomap.py
+++ b/tests/basic/test_repomap.py
@@ -334,6 +334,9 @@ def test_language_typescript(self):
def test_language_tsx(self):
self._test_language_repo_map("tsx", "tsx", "... | true | |
Aider-AI/aider | 4,557 | issue_to_patch | Remove duplicate instruction "Always reply to the user in {language}" | After refactoring of the final reminders in 849a379a8cc51f94981be86cb73d311dd6eb5dac, the instruction in which language llm should respond became duplicated at the begining of the system prompt. So begining of the system prompt now looks like:
```
Act as an expert software developer.
Always use best practices when c... | 1a6d035653c8f0016ef818c212959e1837fbda73 | bfed819c1927b26e261e9ec6ab4e08020135676c | diff --git a/aider/coders/editblock_prompts.py b/aider/coders/editblock_prompts.py
index f6baaeb5fe8..fc494af4f1d 100644
--- a/aider/coders/editblock_prompts.py
+++ b/aider/coders/editblock_prompts.py
@@ -12,8 +12,6 @@ class EditBlockPrompts(CoderPrompts):
Take requests for changes to the supplied code.
If the reques... | [
"aider/coders/editblock_prompts.py",
"aider/coders/patch_prompts.py",
"aider/coders/udiff_prompts.py",
"aider/coders/wholefile_prompts.py"
] | [] | true | ||
Aider-AI/aider | 4,552 | issue_to_patch | chore: version DeepSeek name and fix cost calculation | The previous result had costs that don't match up with the cost update that was included, and don't align with what I was actually charged. I suspect the model metadata file was incorrect to begin with and that's why my update didn't have any affect.
This fixes the leaderboard to have the correct costs.
It also v... | d47d689d1890728a51ed70cda96dea7b849c994d | cb6a152e5ee27fbc77ac499d5e628ccd74a5fa2a | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index 1705a6ceec0..64c480e55ed 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -1,5 +1,5 @@
{
- "deepseek-reasoner": {
+ "deepseek/deepseek-reasoner": {
"max_tokens": 6400... | [
"aider/resources/model-metadata.json",
"aider/website/_data/polyglot_leaderboard.yml"
] | [
{
"comment": "The confusing part here is that upstream has:\r\n\r\nhttps://github.com/BerriAI/litellm/blob/main/model_prices_and_context_window.json#L5433\r\n\r\nbut https://aider.chat/docs/config/adv-model-settings.html does point out:\r\n\r\n_Use a fully qualified model name with a provider/ at the front in t... | true | ||
Aider-AI/aider | 4,551 | issue_to_patch | DeepSeek-3.2-Exp chat and reasoning results | 6963e658877df974450c57f83a036b42c010b8dd | 484e47d029fdd3fbbd6489ca03a3ba19dc226efa | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index aff3b78cbe1..1705a6ceec0 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -1,16 +1,32 @@
{
"deepseek-reasoner": {
+ "max_tokens": 64000,
+ "max_input_tokens": 128... | [
"aider/resources/model-metadata.json",
"aider/website/_data/polyglot_leaderboard.yml"
] | [
{
"comment": "@paul-gauthier Should this have been `deepseek/deepseek-reasoner`? The cost update I applied here didn't \"take\", as a result the claimed cost for the reasoner model is about 4 times what I was actually charged.",
"path": "aider/resources/model-metadata.json",
"hunk": "@@ -1,16 +1,32 @@\n... | true | |||
Aider-AI/aider | 4,547 | issue_to_patch | Support for gpt-5-codex | 73409a52c3e8993a083a9ae1b45ecffbfe35bf14 | a3bbb5ec22a1909ad4fcc4067f9c4517d46298a4 | diff --git a/aider/resources/model-settings.yml b/aider/resources/model-settings.yml
index 81ed3a75883..b118a159298 100644
--- a/aider/resources/model-settings.yml
+++ b/aider/resources/model-settings.yml
@@ -1891,6 +1891,13 @@
use_temperature: false
accepts_settings: ["reasoning_effort"]
+- name: gpt-5-codex
+... | [
"aider/resources/model-settings.yml"
] | [] | true | |||
Aider-AI/aider | 4,544 | issue_to_patch | Feature request: support for Bedrock/Claude 4.5
Please add support for Bedrock/Claude 4.5.
Announced here:
https://aws.amazon.com/blogs/aws/introducing-claude-sonnet-4-5-in-amazon-bedrock-anthropics-most-intelligent-model-best-for-coding-and-complex-agents/
Proposed model name:
bedrock/global.anthropic.claude-sonne... | Feature request: support for Bedrock/Claude 4.5 | Support for Bedrock/Claude 4.5.
Announced here:
https://aws.amazon.com/blogs/aws/introducing-claude-sonnet-4-5-in-amazon-bedrock-anthropics-most-intelligent-model-best-for-coding-and-complex-agents/
Proposed model name:
bedrock/global.anthropic.claude-sonnet-4-5-20250929-v1:0
Fixes: https://github.com/Aider-... | 249e38976508007aeda1c74344c83e1e37ec8e14 | 82a31cc7ccdb24e6a8a841f3dacfd55808a93e32 | diff --git a/aider/resources/model-settings.yml b/aider/resources/model-settings.yml
index 96e5a8e6b7c..81ed3a75883 100644
--- a/aider/resources/model-settings.yml
+++ b/aider/resources/model-settings.yml
@@ -1546,6 +1546,20 @@
editor_edit_format: editor-diff
accepts_settings: ["thinking_tokens"]
+- name: bedro... | [
"aider/resources/model-settings.yml"
] | [] | true | |
Aider-AI/aider | 4,541 | issue_to_patch | added tags for FORTRAN | Reference:
Merge commit for PR #4534
Commit: 5777ab97036c94e2c55de0df0880b88310bc8a6b | f8aa80396d9696111c93f6f34adbf10347c59a1a | 39b0c25ae3f8100532c866051088e83995e63748 | diff --git a/aider/queries/tree-sitter-languages/README.md b/aider/queries/tree-sitter-languages/README.md
index 12e1d5ee825..59e7219cacb 100644
--- a/aider/queries/tree-sitter-languages/README.md
+++ b/aider/queries/tree-sitter-languages/README.md
@@ -21,3 +21,4 @@ tree-sitter language implementations:
* [https://git... | [
"aider/queries/tree-sitter-languages/README.md"
] | [] | true | ||
Aider-AI/aider | 4,534 | issue_to_patch | Added tree-sitter tags for FORTRAN | e4fc2f515d9ed76b14b79a4b02740cf54d5a0c0b | 5777ab97036c94e2c55de0df0880b88310bc8a6b | diff --git a/aider/queries/tree-sitter-languages/fortran-tags.scm b/aider/queries/tree-sitter-languages/fortran-tags.scm
new file mode 100644
index 00000000000..c0bb260e881
--- /dev/null
+++ b/aider/queries/tree-sitter-languages/fortran-tags.scm
@@ -0,0 +1,15 @@
+;; derived from: https://github.com/stadelmanma/tree-sit... | [
"aider/queries/tree-sitter-languages/fortran-tags.scm"
] | [] | true | |||
Aider-AI/aider | 4,493 | issue_to_patch | added julia tree sitter | added a new tags.scm file for Julia.
Implements semantic tags for Julia constructs including:
- Functions (named and anonymous)
- Macros
- Modules
- Structs / mutable structs
- Constants & variables
This makes it easier to navigate Julia codebases | 32faf82b31c54d6f19c5c3d63bc294f748bd3e72 | 60c578e2a1631294f5e6e4d181fe18f5ff98a313 | diff --git a/aider/queries/tree-sitter-languages/julia-tags.scm b/aider/queries/tree-sitter-languages/julia-tags.scm
new file mode 100644
index 00000000000..b7d33d93b6c
--- /dev/null
+++ b/aider/queries/tree-sitter-languages/julia-tags.scm
@@ -0,0 +1,60 @@
+;; derived from: https://github.com/tree-sitter/tree-sitter-ju... | [
"aider/queries/tree-sitter-languages/julia-tags.scm"
] | [] | true | ||
Aider-AI/aider | 4,475 | issue_to_patch | Add GPT-5 with all reasoning settings to polyglot leaderboard | Add GPT-5 with high reasoning to polyglot leaderboard | 32faf82b31c54d6f19c5c3d63bc294f748bd3e72 | 54b266f2895c5023470d712ad7d51df1b545560c | diff --git a/aider/website/_data/polyglot_leaderboard.yml b/aider/website/_data/polyglot_leaderboard.yml
index 9088607dbb6..b3122f01102 100644
--- a/aider/website/_data/polyglot_leaderboard.yml
+++ b/aider/website/_data/polyglot_leaderboard.yml
@@ -1711,3 +1711,90 @@
versions: 0.85.3.dev
seconds_per_case: 35.5
... | [
"aider/website/_data/polyglot_leaderboard.yml"
] | [] | true | ||
Aider-AI/aider | 4,412 | issue_to_patch | Add test results for gpt-oss-120b (high) to polyglot leaderboard | Settings used:
```yaml
- name: openrouter/openai/gpt-oss-120b
extra_params:
extra_body:
reasoning:
effort: "high"
provider:
only:
- fireworks
max_tokens: 131072
```
[2025-08-06-04-54-48--gpt-oss-120b-high-polyglot.zip](https://github.com/user-attachments/fil... | 1af0e591497c40b13ed91e92b9c59ed637e9c2c8 | ac40a4c5cb66564eb4daab704292964d73580436 | diff --git a/aider/website/_data/polyglot_leaderboard.yml b/aider/website/_data/polyglot_leaderboard.yml
index 77570329f0c..18de7704e0b 100644
--- a/aider/website/_data/polyglot_leaderboard.yml
+++ b/aider/website/_data/polyglot_leaderboard.yml
@@ -1682,4 +1682,32 @@
date: 2025-07-17
versions: 0.85.3.dev
secon... | [
"aider/website/_data/polyglot_leaderboard.yml"
] | [] | true | ||
Aider-AI/aider | 4,410 | issue_to_patch | chore: prettier scripting usage for faq | Hi, this repo is awesome.
However when I was searching for some programatically usage, it is not that eye-catching.
Finally I found this issue: https://github.com/Aider-AI/aider/issues/426 , and seems there was a hint before.
So I link scripting.md to faq, so that others can find it easily. Thx~ cc @paul-gauthi... | f38200c511674e83a1b34a44e85beb77ee78f5c7 | 3402b151f7e1bfc8faf7c5dec9359426d8bd28c5 | diff --git a/aider/website/docs/faq.md b/aider/website/docs/faq.md
index 97d7d100f00..5d17c1c4376 100644
--- a/aider/website/docs/faq.md
+++ b/aider/website/docs/faq.md
@@ -375,6 +375,10 @@ Aider is
under an
[Apache 2.0 license](https://github.com/Aider-AI/aider/blob/main/LICENSE.txt).
+## Can I Script Aider?
+
+Y... | [
"aider/website/docs/faq.md",
"aider/website/docs/scripting.md"
] | [] | true | ||
Aider-AI/aider | 4,342 | issue_to_patch | Add openrouter kimi-k2 model to `aider/resources`. | Overall documentation is quite light for this new model.
Max token information is from https://openrouter.ai/moonshotai/kimi-k2.
Information regarding the ideal temperature (0.6) and use of system prompt is from https://platform.moonshot.ai/docs/guide/agent-support ; although this is fairly standard.
**Moonsh... | 7bc2e4e911b347599d37bf52454f6da3169d6146 | 63d3dbcc9b2492284a999f7855aa523c4201b619 | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index aff3b78cbe1..46809c40a13 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -112,6 +112,18 @@
"litellm_provider": "openrouter",
"mode": "chat"
},
+ "openroute... | [
"aider/resources/model-metadata.json",
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 4,324 | issue_to_patch | Add gemini 2.5 flash lite preview 06-17 | f22fbf9b3ae20361c23dfbd989929e25cd3ccd61 | ef59ecbcd8fd557681d13a715cf31875d6aef450 | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index f8b44343990..aff3b78cbe1 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -665,6 +665,33 @@
"supported_output_modalities": ["text"],
"source": "https://ai.google.de... | [
"aider/resources/model-metadata.json",
"aider/resources/model-settings.yml"
] | [] | true | |||
Aider-AI/aider | 4,321 | issue_to_patch | fix: add missing output for clear command | This small PR adds output for the `/clear` in-chat command.
Currently, all other commands produce output, but `/clear` does not.
```console
> /drop
Dropping all files from the chat session.
───────────────────────────────────────────────────... | 096702430497cbaf6745c844ae18cc9ade986d88 | 1a577308840110a6c1d8b041403f9c4d0486db89 | diff --git a/aider/commands.py b/aider/commands.py
index 0b341d1d45e..c05ec930996 100644
--- a/aider/commands.py
+++ b/aider/commands.py
@@ -412,6 +412,7 @@ def cmd_clear(self, args):
"Clear the chat history"
self._clear_chat_history()
+ self.io.tool_output("All chat history cleared.")
... | [
"aider/commands.py"
] | [] | true | ||
Aider-AI/aider | 3,789 | issue_to_patch | feat: Add Co-authored-by attribution for AI commits | This PR implements the proposal from issue #3788, adding support for attributing AI-generated commits using the `Co-authored-by:` Git trailer.
**Changes:**
* Introduces the `--attribute-co-authored-by` command-line flag (and corresponding config option) to enable this feature. Defaults to `False`.
* Updates ... | 9d7dc00f25c6d57bb88c55d6b1d3008d544c6694 | 1d42690824f4208c612210b73b6d002830aa7882 | diff --git a/aider/args.py b/aider/args.py
index 6df19778b63..dfa84b6c2c6 100644
--- a/aider/args.py
+++ b/aider/args.py
@@ -427,14 +427,20 @@ def get_parser(default_config_files, git_root):
group.add_argument(
"--attribute-author",
action=argparse.BooleanOptionalAction,
- default=True,
- ... | [
"aider/args.py",
"aider/coders/base_coder.py",
"aider/main.py",
"aider/repo.py",
"tests/basic/test_repo.py"
] | [
{
"comment": "**`# <-- Restored`**: This comment appears to be a remnant from the development process, likely indicating that the line `attribute_co_authored_by = coder.args.attribute_co_authored_by` was perhaps accidentally deleted or commented out and then added back in. It doesn't serve a purpose in the fina... | diff --git a/tests/basic/test_repo.py b/tests/basic/test_repo.py
index aa863c570e4..400c307a86c 100644
--- a/tests/basic/test_repo.py
+++ b/tests/basic/test_repo.py
@@ -4,7 +4,7 @@
import time
import unittest
from pathlib import Path
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
imp... | true | |
Aider-AI/aider | 3,789 | comment_to_fix | feat: Add Co-authored-by attribution for AI commits | **`# <-- Restored`**: This comment appears to be a remnant from the development process, likely indicating that the line `attribute_co_authored_by = coder.args.attribute_co_authored_by` was perhaps accidentally deleted or commented out and then added back in. It doesn't serve a purpose in the final code and can be safe... | 9d7dc00f25c6d57bb88c55d6b1d3008d544c6694 | 1d42690824f4208c612210b73b6d002830aa7882 | diff --git a/aider/repo.py b/aider/repo.py
index 5ece5147ce8..aa2d525f731 100644
--- a/aider/repo.py
+++ b/aider/repo.py
@@ -1,3 +1,4 @@
+import contextlib
import os
import time
from pathlib import Path, PurePosixPath
@@ -34,6 +35,19 @@
ANY_GIT_ERROR = tuple(ANY_GIT_ERROR)
+@contextlib.contextmanager
+def set_g... | [
"aider/repo.py"
] | [
{
"comment": "**`# <-- Restored`**: This comment appears to be a remnant from the development process, likely indicating that the line `attribute_co_authored_by = coder.args.attribute_co_authored_by` was perhaps accidentally deleted or commented out and then added back in. It doesn't serve a purpose in the fina... | true | ||
Aider-AI/aider | 3,789 | comment_to_fix | feat: Add Co-authored-by attribution for AI commits | > "# No return here, implicitly returns None", doesn't "self.io.tool_error" raise error?
You are correct to question this. Looking at the typical behavior of `aider.io.InputOutput.tool_error` (based on the file summaries and common patterns in aider), it usually *prints* the error message to the user interface and i... | 9d7dc00f25c6d57bb88c55d6b1d3008d544c6694 | 1d42690824f4208c612210b73b6d002830aa7882 | diff --git a/aider/repo.py b/aider/repo.py
index 5ece5147ce8..aa2d525f731 100644
--- a/aider/repo.py
+++ b/aider/repo.py
@@ -1,3 +1,4 @@
+import contextlib
import os
import time
from pathlib import Path, PurePosixPath
@@ -34,6 +35,19 @@
ANY_GIT_ERROR = tuple(ANY_GIT_ERROR)
+@contextlib.contextmanager
+def set_g... | [
"aider/repo.py"
] | [
{
"comment": "> \"# No return here, implicitly returns None\", doesn't \"self.io.tool_error\" raise error?\r\n\r\nYou are correct to question this. Looking at the typical behavior of `aider.io.InputOutput.tool_error` (based on the file summaries and common patterns in aider), it usually *prints* the error messa... | true | ||
Aider-AI/aider | 3,789 | comment_to_fix | feat: Add Co-authored-by attribution for AI commits | Since it's now added to `__init__`, a simple `self.attribute_co_authored_by` should suffice when `coder` is not available or doesn't have `args`. However, the current `getattr` is safe and handles potential future scenarios where `self.attribute_co_authored_by` might not be set, so leaving it is also fine.
| 9d7dc00f25c6d57bb88c55d6b1d3008d544c6694 | 1d42690824f4208c612210b73b6d002830aa7882 | diff --git a/aider/repo.py b/aider/repo.py
index 5ece5147ce8..aa2d525f731 100644
--- a/aider/repo.py
+++ b/aider/repo.py
@@ -1,3 +1,4 @@
+import contextlib
import os
import time
from pathlib import Path, PurePosixPath
@@ -34,6 +35,19 @@
ANY_GIT_ERROR = tuple(ANY_GIT_ERROR)
+@contextlib.contextmanager
+def set_g... | [
"aider/repo.py"
] | [
{
"comment": "Since it's now added to `__init__`, a simple `self.attribute_co_authored_by` should suffice when `coder` is not available or doesn't have `args`. However, the current `getattr` is safe and handles potential future scenarios where `self.attribute_co_authored_by` might not be set, so leaving it is a... | true | ||
Aider-AI/aider | 3,789 | comment_to_fix | feat: Add Co-authored-by attribution for AI commits | > Oops. aider.dev is something unrelated to aider project. proper domain is aider.chat
> ... but could you elaborate which email to use?
You are absolutely right! aider.dev is incorrect. The correct domain for the project is aider.chat. ... | 9d7dc00f25c6d57bb88c55d6b1d3008d544c6694 | 1d42690824f4208c612210b73b6d002830aa7882 | diff --git a/aider/repo.py b/aider/repo.py
index 5ece5147ce8..aa2d525f731 100644
--- a/aider/repo.py
+++ b/aider/repo.py
@@ -1,3 +1,4 @@
+import contextlib
import os
import time
from pathlib import Path, PurePosixPath
@@ -34,6 +35,19 @@
ANY_GIT_ERROR = tuple(ANY_GIT_ERROR)
+@contextlib.contextmanager
+def set_g... | [
"aider/repo.py"
] | [
{
"comment": "> Oops. aider.dev is something unrelated to aider project. proper domain is aider.chat\r\n> ... but could you elaborate which email to use? \r\n\r\nYou are absolutely right! aider.dev is incorrect. The correct domain for the project is aider.chat. ... | true | ||
Aider-AI/aider | 3,733 | issue_to_patch | fix: follow conventional commits examples by going all lowercase | Super tiny change, but I recently tried out Aider and I love it. However, when it auto generates commit messages it does so with capital letters, which does not follow any of the examples provided by the [specification](https://www.conventionalcommits.org/en/v1.0.0/#specification). All of them are completely in lowerca... | 2bfb615d68ffdab09f7d34e96cd0bf8f578393eb | 94db758eb7a8861158bd0ac2cb78b24d1c2abb16 | diff --git a/aider/prompts.py b/aider/prompts.py
index 27d833fdd1c..8e26338ee83 100644
--- a/aider/prompts.py
+++ b/aider/prompts.py
@@ -10,12 +10,13 @@
Review the provided context and diffs which are about to be committed to a git repo.
Review the diffs carefully.
Generate a one-line commit message for those change... | [
"aider/prompts.py"
] | [] | true | ||
Aider-AI/aider | 3,752 | issue_to_patch | Update Azure Documentation | I ran into some issues getting aider to work with models hosted on Azure and wanted to update the documentation to make things a little more clear for anyone else going down the same route. | f46deb4eb733732d48cc094005a268337e545dc2 | be303292885f70d76f7e51e70ad38cbcebe99ce1 | diff --git a/aider/website/assets/azure-deployment.png b/aider/website/assets/azure-deployment.png
new file mode 100644
index 00000000000..0594cc08e56
Binary files /dev/null and b/aider/website/assets/azure-deployment.png differ
diff --git a/aider/website/docs/llms/azure.md b/aider/website/docs/llms/azure.md
index 5568... | [
"aider/website/assets/azure-deployment.png",
"aider/website/docs/llms/azure.md"
] | [] | true | ||
Aider-AI/aider | 3,764 | issue_to_patch | Optimize head‑truncation loop in summarize_real() | The update in history.py (summarize_real) includes = >
1. Eliminate list reversals and streamline token summation
2. Refactor head slicing: iterate directly over sized_head for speed
3. Improve performance of message splitting by removing unnecessary reversals.
I think it will make it bit faster as per my exp.. | 7d0dd299374c8c3ca9a6295cc7edfa02c03a025a | 23c9d9c34d46e051d1616925b088b801fe95a50f | diff --git a/aider/history.py b/aider/history.py
index a4727b94183..9836be0ca7b 100644
--- a/aider/history.py
+++ b/aider/history.py
@@ -63,37 +63,38 @@ def summarize_real(self, messages, depth=0):
if split_index <= min_split:
return self.summarize_all(messages)
+ # Split head and tail
... | [
"aider/history.py"
] | [] | true | ||
Aider-AI/aider | 4,307 | issue_to_patch | Remove extra duplicated line in default commit instructions | 3db4d378eb75ce32379aaeb981c78a591e48c824 | 456db697f00c0dedc6cc022a64131f0ddeb030f5 | diff --git a/aider/prompts.py b/aider/prompts.py
index aecf29a9ee8..912bc02c659 100644
--- a/aider/prompts.py
+++ b/aider/prompts.py
@@ -19,9 +19,6 @@
- Does not exceed 72 characters.
Reply only with the one-line commit message, without any additional text, explanations, or line breaks.
-
-Reply only with the one-l... | [
"aider/prompts.py"
] | [] | true | |||
Aider-AI/aider | 4,300 | issue_to_patch | Duplicate Models Prevent Model Settings Overrides from Working
### Issue
When models with a duplicate names exist in aider's model-settings.yml, custom model settings defined in `~/.aider.model.settings.yml` fail to override the duplicated models configuration.
Duplicate model names found:
* `azure/o4-mini`
* `opena... | fix: Remove existing model settings before adding new ones | Fix #4298 | 966cf2b9fbe8ae14140b4f53761cc7d71ef1148b | 02c27732af47537003fe2d88a806dd56a925a634 | diff --git a/aider/models.py b/aider/models.py
index ae76f03424b..84260d607e0 100644
--- a/aider/models.py
+++ b/aider/models.py
@@ -1052,12 +1052,10 @@ def register_models(model_settings_fnames):
for model_settings_dict in model_settings_list:
model_settings = ModelSettings(**model_sett... | [
"aider/models.py"
] | [] | true | |
Aider-AI/aider | 4,264 | issue_to_patch | When editing HTML, Sonnet often spells `<<<<<<< SEARCH>`
### Issue
See title. HTML tag bias too stronk.
Instead of explicitly noting this in the prompt, aider should just accept this syntax.
### Version and model info
_No response_ | refactor: update HEAD regex to accept optional closing tag in search blocks | Fixes https://github.com/Aider-AI/aider/issues/4227
When working with HTML text, the network has a strong bias to go "well, this is '<' followed by text, it's a tag! I should close it with '>'." Then the edit would be ignored.
Fixed by Sonnet. Thanks Sonnet! | f9fc2c6a448b45c1bd1bd01da010fc8422ec7c61 | 7c9cff2f6ecea9b68cced7d446086a7e79c70c04 | diff --git a/aider/coders/editblock_coder.py b/aider/coders/editblock_coder.py
index d8f85da5223..37d40d97c70 100644
--- a/aider/coders/editblock_coder.py
+++ b/aider/coders/editblock_coder.py
@@ -383,7 +383,7 @@ def do_replace(fname, content, before_text, after_text, fence=None):
return new_content
-HEAD = r"... | [
"aider/coders/editblock_coder.py"
] | [] | true | |
Aider-AI/aider | 3,870 | issue_to_patch | feat: add configurable PostHog host and API key parameters | Hi! 👋🏻
Would you consider adding configuration options to specify a custom PostHog project or a custom PostHog host?
This could be helpful for teams using aider within a company who want to monitor adoption and usage among engineers using their own PostHog setup.
Thanks for considering it! | e205629a94dae0b98e4d598109be39467a88b49e | 98ee78edf0ad446361ac98ebe86b499a55a01358 | diff --git a/aider/analytics.py b/aider/analytics.py
index d5c37c10aab..59913ccbf6c 100644
--- a/aider/analytics.py
+++ b/aider/analytics.py
@@ -70,9 +70,17 @@ class Analytics:
# ephemeral
logfile = None
- def __init__(self, logfile=None, permanently_disable=False):
+ def __init__(
+ self,
... | [
"aider/analytics.py",
"aider/args.py",
"aider/main.py",
"aider/website/assets/sample.aider.conf.yml",
"aider/website/docs/more/analytics.md"
] | [] | true | ||
Aider-AI/aider | 4,028 | issue_to_patch | Add Clojure repomap queries | Definitions: symbol name (without namespace) immediately following a `def` prefixed symbol
References: symbol name (without namespace) found anywhere
The definitions is pretty good; using `def` prefix is a very standard Clojure pattern even for 3rd party macros.
References is less than ideal, as it causes buildi... | 3caab85931be9df2d51b8c61352fa213c20ee8d1 | 59dbce8575920665e3e3ff96197fd7ae7e6bf4d4 | diff --git a/aider/queries/tree-sitter-language-pack/clojure-tags.scm b/aider/queries/tree-sitter-language-pack/clojure-tags.scm
new file mode 100644
index 00000000000..4b2bfa1724f
--- /dev/null
+++ b/aider/queries/tree-sitter-language-pack/clojure-tags.scm
@@ -0,0 +1,7 @@
+(list_lit
+ meta: _*
+ . (sym_lit name: (sy... | [
"aider/queries/tree-sitter-language-pack/clojure-tags.scm",
"aider/repomap.py"
] | [] | true | ||
Aider-AI/aider | 4,271 | issue_to_patch | fix: Auto-create parent directories for chat history files | This is follow up to #4257
There was a missing check for input_history_file = None case | d85078a610cbad69e8561060229aa8f35b4e1163 | fb4d2f90c1748154ee7eb59eeb55a59bb06a624d | diff --git a/aider/io.py b/aider/io.py
index 46621cfce6a..5dde5ca7f70 100644
--- a/aider/io.py
+++ b/aider/io.py
@@ -307,8 +307,9 @@ def __init__(
self.yes = yes
+ if input_history_file is not None:
+ Path(input_history_file).mkdir(parents=True, exist_ok=True)
self.input_history_... | [
"aider/io.py"
] | [] | true | ||
Aider-AI/aider | 4,257 | issue_to_patch | feat: Auto-create parent directories for chat history files | Automatically create parent directories when writing to chat-history-file and input-history-file.
Previously, aider would fail to write history files if the parent directory didn't exist, showing errors like
```
Warning: Unable to write to chat history file .chat/.aider.chat.history.md.
[Errno 2] No such file... | fdb49e18cd9b566adde9eecf9e1de47ac78ff7a8 | f695e71398e4786f5eca4b57e4b9ce4f9455a8ce | diff --git a/aider/io.py b/aider/io.py
index f8cf78cd3cf..46621cfce6a 100644
--- a/aider/io.py
+++ b/aider/io.py
@@ -308,9 +308,11 @@ def __init__(
self.yes = yes
self.input_history_file = input_history_file
+ Path(self.input_history_file).parent.mkdir(parents=True, exist_ok=True)
se... | [
"aider/io.py"
] | [] | true | ||
Aider-AI/aider | 4,268 | issue_to_patch | add Gemini 2.5 non-preview Vertex models | add missing Vertex Gemini 2.5 general available models | 90ecde4da9bb4670684b38b8e687ff06cd70005e | 05ca9e5c240f9ae6487953c635f0b078e1037601 | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index b406ce4ff62..f8b44343990 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -276,6 +276,61 @@
"supports_tool_choice": true,
"source": "https://cloud.google.com/vertex... | [
"aider/resources/model-metadata.json",
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 4,269 | issue_to_patch | [Bug] Can't use `/read-only` if filepath contains `[]` while `/add` is working fine
### Issue
```
Readonly: AIDER-INSTRUCTION.md README.md src/lib/api/api.ts
> /read-only /Volumes/t7ex/Documents/oatnil/ud/ud-next-web/src/app/todolist/[id]/page.tsx
No matches found for:
/Volumes/t7ex/... | fix: Resolve literal paths correctly in /read-only command | Fixes: #4253 | a785b0f46347f06909abeab65881c52e4625990c | c4b9f14b906b19bc961bd6b6730c7328fa3d0e9e | diff --git a/aider/commands.py b/aider/commands.py
index e21f29d9887..9bac9bab1f6 100644
--- a/aider/commands.py
+++ b/aider/commands.py
@@ -1316,12 +1316,23 @@ def cmd_read_only(self, args):
# First collect all expanded paths
for pattern in filenames:
expanded_pattern = expanduser(patter... | [
"aider/commands.py",
"tests/basic/test_commands.py"
] | [] | diff --git a/tests/basic/test_commands.py b/tests/basic/test_commands.py
index d187ee5210e..47b8832dc42 100644
--- a/tests/basic/test_commands.py
+++ b/tests/basic/test_commands.py
@@ -1621,6 +1621,33 @@ def test_cmd_read_only_with_tilde_path(self):
# Clean up: remove the test file from the home direct... | true |
Aider-AI/aider | 4,260 | issue_to_patch | add MATLAB tags to enable repo map support | ### Description
This PR adds support for MATLAB repo maps. I added in `matlab-tags.scm` files, and added a test case for these changes. | fdb49e18cd9b566adde9eecf9e1de47ac78ff7a8 | 20429b685291838715465c7e802a6d4c14f21353 | diff --git a/aider/queries/tree-sitter-language-pack/matlab-tags.scm b/aider/queries/tree-sitter-language-pack/matlab-tags.scm
new file mode 100644
index 00000000000..66f12527fe7
--- /dev/null
+++ b/aider/queries/tree-sitter-language-pack/matlab-tags.scm
@@ -0,0 +1,10 @@
+(class_definition
+ name: (identifier) @name.d... | [
"aider/queries/tree-sitter-language-pack/matlab-tags.scm",
"aider/queries/tree-sitter-languages/matlab-tags.scm",
"tests/basic/test_repomap.py",
"tests/fixtures/languages/matlab/test.m"
] | [] | diff --git a/tests/basic/test_repomap.py b/tests/basic/test_repomap.py
index 322bac95472..af7b62131ce 100644
--- a/tests/basic/test_repomap.py
+++ b/tests/basic/test_repomap.py
@@ -388,6 +388,9 @@ def test_language_ocaml(self):
def test_language_ocaml_interface(self):
self._test_language_repo_map("ocaml_i... | true | |
Aider-AI/aider | 4,254 | issue_to_patch | Support official model `openrouter/google/gemini-2.5-pro` | ### **PR Type**
Feature
___
### **PR Description**
- Added support for `openrouter/google/gemini-2.5-pro` model.
- Includes metadata configuration in `model-metadata.json`.
- Added model settings in `model-settings.yml`.
| 3cb120e0a924f8276f121d95a77193e9c492befa | bb1b9e8e2d90692c2ac5a1ab6a8ef109685a54c4 | diff --git a/aider/resources/model-metadata.json b/aider/resources/model-metadata.json
index 0c3676e5634..b406ce4ff62 100644
--- a/aider/resources/model-metadata.json
+++ b/aider/resources/model-metadata.json
@@ -348,6 +348,42 @@
"supports_tool_choice": true,
"source": "https://cloud.google.com/vertex... | [
"aider/resources/model-metadata.json",
"aider/resources/model-settings.yml"
] | [
{
"comment": "@KennyDizi was this supposed to be `openrouter/google/gemini-2.5-pro`?",
"path": "aider/resources/model-metadata.json",
"hunk": "@@ -348,6 +348,42 @@\n \"supports_tool_choice\": true,\n \"source\": \"https://cloud.google.com/vertex-ai/generative-ai/pricing\"\n },\n+ ... | true | ||
Aider-AI/aider | 4,242 | issue_to_patch | Update gemini models in model-settings.yml | 1. Remove dead gemini models (they can't be accessed anymore)
2. Add the new gemini 2.5 pro and flash settings (with `use_temperature: false`)
I noticed that the settings for many gemini models don't have `use_temperature: false` which leads to requests being sent with `temperature=0`. This is especially detrimenta... | f8855ebc5894e6ba3076645927e56f441d7ad1c3 | 1677db3ca7b2ff530b47a81f67828090e43506a0 | diff --git a/aider/models.py b/aider/models.py
index 7a9d1af182b..ae76f03424b 100644
--- a/aider/models.py
+++ b/aider/models.py
@@ -93,11 +93,11 @@
"3": "gpt-3.5-turbo",
# Other models
"deepseek": "deepseek/deepseek-chat",
- "flash": "gemini/gemini-2.5-flash-preview-04-17",
+ "flash": "gemini/gemi... | [
"aider/models.py",
"aider/resources/model-metadata.json",
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 4,228 | issue_to_patch | [Feature] Resetting thinking tokens using "0" | Once you run `/thinking-tokens 4k` inside chat, there was no way to reset it. With this PR, `/thinking-tokens 0` does that. | 2df4beb6e975d1d45a4e9b50718543b0d73ab9b9 | e91efda8fe5c9a98868b3ae2b65b80ea7398f0da | diff --git a/aider/args.py b/aider/args.py
index 43e03702efc..d36009c28fc 100644
--- a/aider/args.py
+++ b/aider/args.py
@@ -143,7 +143,7 @@ def get_parser(default_config_files, git_root):
group.add_argument(
"--thinking-tokens",
type=str,
- help="Set the thinking token budget for models t... | [
"aider/args.py",
"aider/commands.py",
"aider/models.py",
"aider/website/assets/sample.aider.conf.yml",
"aider/website/docs/config/options.md",
"aider/website/docs/config/reasoning.md",
"aider/website/docs/usage/commands.md"
] | [] | true | ||
Aider-AI/aider | 4,236 | issue_to_patch | doc: add correct path for github copilot token for windows users | 72c23800a9d09a72ea47cbf094263584ee269c47 | 262117d1249e2d6e2c517ceb8503355e08d26b51 | diff --git a/aider/website/docs/llms/github.md b/aider/website/docs/llms/github.md
index d71944501a7..43c7853447e 100644
--- a/aider/website/docs/llms/github.md
+++ b/aider/website/docs/llms/github.md
@@ -41,6 +41,12 @@ After you authenticate a file appears:
~/.config/github-copilot/apps.json
```
+On Windows the co... | [
"aider/website/docs/llms/github.md"
] | [] | true | |||
Aider-AI/aider | 4,156 | issue_to_patch | fix: Always pass `extra_headers` to Copilot models | As a few people mentioned in the #2227 issue, it is necessary to pass some `extra_headers` to Copilot with each request in order for it to work properly. Furthermore, without a specific `.aider.model.settings.yml`, the most recent patch #4092 that automatically refreshes the GH Copilot API Key does not work because it ... | 3266eaca91425f5d8b1ce4f1f539ca55552ec532 | c67f6905a5a885e3904b4cfe04caaf918f6d84fb | diff --git a/aider/models.py b/aider/models.py
index e275c907e8e..97b0789b615 100644
--- a/aider/models.py
+++ b/aider/models.py
@@ -16,6 +16,7 @@
import yaml
from PIL import Image
+from aider import __version__
from aider.dump import dump # noqa: F401
from aider.llm import litellm
from aider.openrouter import ... | [
"aider/models.py"
] | [] | true | ||
Aider-AI/aider | 4,022 | issue_to_patch | Vertex AI models can't use the weak or editor models?
### Issue
Using the Vertex AI provider/platform/API, we've been getting this series of errors forever, and I think it's causing fallback to the "big expensive" model for every operation, which is kinda burning through our free credits really fast (and it's slower,... | fix: Vertex AI model names use vertex_ai/ prefix | Don't be confused with `llm_provider` which is `vertex_ai-language-models`
https://github.com/BerriAI/litellm/blob/340a0453d33d980568402713f32238569de5fb30/litellm/__init__.py#L509
Fixes #4109 | 17d40a62c931ac91fc9c31288310b37b62175c47 | e54ac087cbe60d17db3e8aa495aa14cfabf8b394 | diff --git a/aider/resources/model-settings.yml b/aider/resources/model-settings.yml
index 935e0cef649..ff713c3faba 100644
--- a/aider/resources/model-settings.yml
+++ b/aider/resources/model-settings.yml
@@ -315,7 +315,7 @@
editor_edit_format: editor-diff
accepts_settings: ["thinking_tokens"]
-- name: vertex_a... | [
"aider/resources/model-settings.yml",
"aider/website/docs/config/adv-model-settings.md"
] | [] | true | |
Aider-AI/aider | 4,210 | issue_to_patch | Add default model settings for o3-pro | This small PR adds default settings identical to the `o3` settings to provide default support for the new `o3-pro` model, released on June 10.
https://help.openai.com/en/articles/9624314-model-release-notes | 5562caae0c0933e6020ac09ceac93180a33f6e0b | 67e190c8d14c52c9f09e368a4ae4eb348781fd33 | diff --git a/aider/resources/model-settings.yml b/aider/resources/model-settings.yml
index da4bf5f9e3f..935e0cef649 100644
--- a/aider/resources/model-settings.yml
+++ b/aider/resources/model-settings.yml
@@ -1157,6 +1157,20 @@
# extra_body:
# reasoning_effort: high
+- name: o3-pro
+ streaming: false
+ ed... | [
"aider/resources/model-settings.yml"
] | [] | true | ||
Aider-AI/aider | 2,692 | issue_to_patch | Uncaught UnicodeDecodeError in fun.py line 264
Aider version: 0.57.1
Python version: 3.11.10
Platform: Linux-4.4.0-19041-Microsoft-x86_64-with-glibc2.31
Python implementation: CPython
Virtual environment: Yes
OS: Linux 4.4.0-19041-Microsoft (64bit)
Git version: git version 2.45.1
An uncaught exception occurre... | Fix issue #1802: Handle UnicodeDecodeError in repo file paths | Added error handling for UnicodeDecodeError when decoding paths in the Git repository. This issue arises when paths are encoded in formats other than the expected system encoding.
The error handler now provides a detailed error message, helping users identify potential encoding mismatches.
Closes #1802 | 083605e2d762e6281a9230f5ea2de9ddaa88a1a9 | 5c92491bc085d5d10c80bced00d07a916bf4ad2f | diff --git a/aider/main.py b/aider/main.py
index 31dc79c41d1..ee55261a292 100644
--- a/aider/main.py
+++ b/aider/main.py
@@ -393,6 +393,12 @@ def sanity_check_repo(repo, io):
if not repo.git_repo_error:
return True
error_msg = str(repo.git_repo_error)
+ except UnicodeDecodeError as exc... | [
"aider/main.py",
"tests/basic/test_sanity_check_repo.py"
] | [] | diff --git a/tests/basic/test_sanity_check_repo.py b/tests/basic/test_sanity_check_repo.py
index 860572ec54f..fd17fb3b4ef 100644
--- a/tests/basic/test_sanity_check_repo.py
+++ b/tests/basic/test_sanity_check_repo.py
@@ -8,6 +8,8 @@
from aider import urls
from aider.main import sanity_check_repo
+from aider.repo im... | true |
Alexays/Waybar | 5,013 | issue_to_patch | fix(hyprland/workspaces): adapt dispatch commands for Lua IPC protocol | Hyprland 0.54 replaced the text-based dispatch socket protocol with a Lua-based one. Commands like "dispatch workspace 1" are now interpreted as invalid Lua (return hl.dispatch(workspace 1)), breaking workspace clicks and scroll navigation.
Add IPC::dispatch() that probes the running Hyprland on first call and route... | cca8dc38b6ed25ef78920669c5653748f31e4ba6 | 97917db59369b66ef412a87f90cfdbda3ad55225 | diff --git a/include/modules/hyprland/backend.hpp b/include/modules/hyprland/backend.hpp
index a6ebd19178..7c6369da72 100644
--- a/include/modules/hyprland/backend.hpp
+++ b/include/modules/hyprland/backend.hpp
@@ -4,6 +4,7 @@
#include <filesystem>
#include <list>
#include <mutex>
+#include <optional>
#include <str... | [
"include/modules/hyprland/backend.hpp",
"src/modules/hyprland/backend.cpp",
"src/modules/hyprland/workspace.cpp",
"src/modules/hyprland/workspaces.cpp",
"test/hyprland/backend.cpp"
] | [] | diff --git a/test/hyprland/backend.cpp b/test/hyprland/backend.cpp
index ccc2da65a2..62d23ae4d6 100644
--- a/test/hyprland/backend.cpp
+++ b/test/hyprland/backend.cpp
@@ -15,6 +15,10 @@ namespace {
class IPCTestHelper : public hyprland::IPC {
public:
static void resetSocketFolder() { socketFolder_.clear(); }
+ s... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.