repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
DenverCoder1/readme-typing-svg
370
issue_to_patch
Added saadhusayn to README
Added example to README
923dc2773492119c96d12bf6a489d54445d381dd
9a24867c3cd5e4d0f44d4b18cde84b9c2f3dfe8c
diff --git a/README.md b/README.md index 6a9901c0..c3f039ae 100644 --- a/README.md +++ b/README.md @@ -130,6 +130,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Austin Musuya](https://github.com/AustinMusuya.png?size=60)](https://github.com/AustinMusuya "Austin Musuya on GitHub") ...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
369
issue_to_patch
docs: Added Sandeep Prasad to examples
d29f70962914b03895196f6b92e952c90293f9fe
92c94f0d29fad1fd52f4d615ac5b1c7b46b633a2
diff --git a/README.md b/README.md index 4b49c137..6a9901c0 100644 --- a/README.md +++ b/README.md @@ -129,6 +129,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Sarthak Krishak](https://github.com/SarthakKrishak.png?size=60)](https://github.com/SarthakKrishak "Sarthak Krishak on Gi...
[ "README.md" ]
[ { "comment": "Extra blank line should be removed\n\n```suggestion\n[![Sandeep Prasad](https://github.com/Sandeep-Petwal.png?size=60)](https://github.com/sandeep-Petwal \"Sandeep Prasad on GitHub\")\n```\n", "path": "README.md", "hunk": "@@ -129,6 +129,8 @@ Below are links to profiles where you can see R...
true
DenverCoder1/readme-typing-svg
369
comment_to_fix
docs: Added Sandeep Prasad to examples
Extra blank line should be removed ```suggestion [![Sandeep Prasad](https://github.com/Sandeep-Petwal.png?size=60)](https://github.com/sandeep-Petwal "Sandeep Prasad on GitHub") ```
d29f70962914b03895196f6b92e952c90293f9fe
92c94f0d29fad1fd52f4d615ac5b1c7b46b633a2
diff --git a/README.md b/README.md index 4b49c137..6a9901c0 100644 --- a/README.md +++ b/README.md @@ -129,6 +129,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Sarthak Krishak](https://github.com/SarthakKrishak.png?size=60)](https://github.com/SarthakKrishak "Sarthak Krishak on Gi...
[ "README.md" ]
[ { "comment": "Extra blank line should be removed\n\n```suggestion\n[![Sandeep Prasad](https://github.com/Sandeep-Petwal.png?size=60)](https://github.com/sandeep-Petwal \"Sandeep Prasad on GitHub\")\n```\n", "path": "README.md", "hunk": "@@ -129,6 +129,8 @@ Below are links to profiles where you can see R...
true
DenverCoder1/readme-typing-svg
366
issue_to_patch
docs(readme): Add Rohit to examples
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [x] Updat...
cc3ce9c3293f771b77b54ad923aa78e67ab4c431
67770594f98f24b2792edb043ee37a93eeef8a5a
diff --git a/README.md b/README.md index 7475653a..4b49c137 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Snoopy1866](https://github.com/Snoopy1866.png?size=60)](https://github.com/Snoopy1866 "Snoopy1866 on GitHub") [![Sarthak...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
363
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.5.1 to 11.5.2
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.5.1 to 11.5.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.5.2</h2> <h3>Fixed</h3> <ul> <l...
886dfd15fd5adb464ec2568719ad0620f4918ab8
75e09d76f4b57966bd35da248c43b5f8c3289569
diff --git a/composer.lock b/composer.lock index 8ee1863b..32a12672 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.5.1", + "version": "11.5.2", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
356
issue_to_patch
docs(readme): Added Snoopy1866 to examples
## Summary <!-- Please include a summary of the change and which issue is fixed. --> Added example to README ## Type of change - [x] Updated documentation (updated the readme, templates, or other repo files)
58617a17f643b7f20f042f2fbfe3495666340a0d
b11c70359119476560e9d7a06ad1c5d9f6b21d4a
diff --git a/README.md b/README.md index 44460fd7..9e811dfa 100644 --- a/README.md +++ b/README.md @@ -125,6 +125,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Ishaan Rastogi](https://github.com/TridentifyIshaan.png?size=60)](https://github.com/TridentifyIshaan "Tridentify Ishaan ...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
362
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.5.0 to 11.5.1
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.5.0 to 11.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.5.1</h2> <h3>Added</h3> <ul> <l...
e1cc05c215bad10b3ba14f2c615850e2bc4f9cee
a4e669a6d680901efe413a4ec5218915134566d5
diff --git a/composer.lock b/composer.lock index 334190f6..8ee1863b 100644 --- a/composer.lock +++ b/composer.lock @@ -706,16 +706,16 @@ }, { "name": "phpunit/php-code-coverage", - "version": "11.0.7", + "version": "11.0.8", "source": { ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
361
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.4.4 to 11.5.0
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.4.4 to 11.5.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.5.0</h2> <h3>Added</h3> <ul> <l...
cbaa1bb9b74f1a86755f74c9d65837b4b7a08e1e
67c46f231efc3840f70521f6e4884c15e5f44e24
diff --git a/composer.lock b/composer.lock index 33b13251..334190f6 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.4.4", + "version": "11.5.0", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
359
issue_to_patch
docs(readme): fix profile image
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [ ] Updat...
97bb9721971f76b54df9c2ef8b0acee5b5d388f8
ddc11a4b7fb10e59be7292f7294f68a575c654fd
diff --git a/README.md b/README.md index 9e811dfa..7475653a 100644 --- a/README.md +++ b/README.md @@ -126,7 +126,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Eligijus Ciza](https://github.com/krimmyy.png?size=60)](https://github.com/krimmyy "Eligijus Ciza on GitHub") [![Ashish ...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
355
issue_to_patch
Added SarthakKrishak in README.md
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [ ] Updat...
a23605e37037e65fd02aa1c556b5267ae844b393
39b6323a41accd6ff245a885a12bbfa774ab0316
diff --git a/README.md b/README.md index 101c49f5..44460fd7 100644 --- a/README.md +++ b/README.md @@ -125,6 +125,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Ishaan Rastogi](https://github.com/TridentifyIshaan.png?size=60)](https://github.com/TridentifyIshaan "Tridentify Ishaan ...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
354
issue_to_patch
docs(readme): Added AustinMusuya to examples
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Updated documentation (Added AustinMusuya to readme)
977d2c4e351e7aa206f17307f43c22b0fda5f0a5
9695af7396e6ab63b9d0771f43b7aad9c6514b48
diff --git a/README.md b/README.md index bd689031..101c49f5 100644 --- a/README.md +++ b/README.md @@ -125,6 +125,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Ishaan Rastogi](https://github.com/TridentifyIshaan.png?size=60)](https://github.com/TridentifyIshaan "Tridentify Ishaan ...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
358
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.4.3 to 11.4.4
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.4.3 to 11.4.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.4.4</h2> <h3>Fixed</h3> <ul> <l...
977d2c4e351e7aa206f17307f43c22b0fda5f0a5
68da4f6c3fe78852a6848e282913510d577b3853
diff --git a/composer.lock b/composer.lock index 444db219..33b13251 100644 --- a/composer.lock +++ b/composer.lock @@ -470,16 +470,16 @@ "packages-dev": [ { "name": "myclabs/deep-copy", - "version": "1.12.0", + "version": "1.12.1", "source": { ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
352
issue_to_patch
Removed SuSheng13T
Github account does not exist / deleted ## Summary <!-- Please include a summary of the change and which issue is fixed. --> Removed SuSheng13T because that account does not exists / deleted ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking chang...
5382157d2b0fe487c940c0f8b3b6f4210f4ab58e
20a8f440f4cd9810bd1796a43a482863ed6a6307
diff --git a/README.md b/README.md index 9cd93cd5..4df3c1f7 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,6 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![mateusadada](https://github.com/mateusadada.png?size=60)](https://github.com/mateusadada "mateusadada on Github") [![fas...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
353
issue_to_patch
docs(readme): Remove and fix examples
## Summary * Removed profiles not using Typing SVG: @cfcife @v-pun215 @MehmetBozkir If you would like to be added back, put a Typing SVG on your profile and make a new pull request. * Fixed link to https://github.com/ABAN26 ## Type of change <!-- Please delete options that are not relevant. --> - [ ] ...
9dc527b175b29055c4e4594aa92f36de846bf78a
72bd6c46da832bf6eb96b7ce8f33dd58b5886ba3
diff --git a/README.md b/README.md index 4df3c1f7..bd689031 100644 --- a/README.md +++ b/README.md @@ -68,7 +68,6 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![shalinibhatt](https://github.com/shalinibhatt.png?size=60)](https://github.com/shalinibhatt "shalinibhatt on GitHub") [![U...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
350
issue_to_patch
Added Ashish-CodeJourney to README.md
Added Ashish-CodeJourney to README.md
7b32f170e61378040aacb8ae033cd904908b8ca8
89c69015f5d9326f9bd549a9a2a889bad579b28b
diff --git a/README.md b/README.md index 21faf8e4..9cd93cd5 100644 --- a/README.md +++ b/README.md @@ -128,6 +128,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Antônio Nascimento](https://github.com/Ninja1375.png?size=60)](https://github.com/Ninja1375 "Antônio Nascimento on GitHub...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
347
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.4.2 to 11.4.3
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.4.2 to 11.4.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.4.3</h2> <h3>Changed</h3> <ul> ...
60ad57672cf716cc361c3fce6f0616ed7396c16d
e83ce9f24beed9aa4eec84fb47ee80829958e15e
diff --git a/composer.lock b/composer.lock index 60a78937..444db219 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.4.2", + "version": "11.4.3", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
345
issue_to_patch
Update README.md
Added example to README
7df982bef17c39a1dc31bbbc39f25277076afbd9
1d513bdb2333b26597e70a0409dc9bc68f60330c
diff --git a/README.md b/README.md index b1ece5f9..21faf8e4 100644 --- a/README.md +++ b/README.md @@ -126,6 +126,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") [![Yog...
[ "README.md" ]
[ { "comment": "This extra blank line should be removed\n\n```suggestion\n```\n", "path": "README.md", "hunk": "@@ -126,6 +126,8 @@ Below are links to profiles where you can see Readme Typing SVGs in action!\n [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 \"S...
true
DenverCoder1/readme-typing-svg
345
comment_to_fix
Update README.md
This extra blank line should be removed ```suggestion ```
7df982bef17c39a1dc31bbbc39f25277076afbd9
1d513bdb2333b26597e70a0409dc9bc68f60330c
diff --git a/README.md b/README.md index b1ece5f9..21faf8e4 100644 --- a/README.md +++ b/README.md @@ -126,6 +126,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") [![Yog...
[ "README.md" ]
[ { "comment": "This extra blank line should be removed\n\n```suggestion\n```\n", "path": "README.md", "hunk": "@@ -126,6 +126,8 @@ Below are links to profiles where you can see Readme Typing SVGs in action!\n [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 \"S...
true
DenverCoder1/readme-typing-svg
346
issue_to_patch
Added Eligijus Ciza to README.md
Added Eligijus Ciza to README.md
b532e8a6a62ea36c0bb2349455643b756b43379b
64ed0e8e94ca665645e16ca626559f7b0b15adc8
diff --git a/README.md b/README.md index b33a27c6..b1ece5f9 100644 --- a/README.md +++ b/README.md @@ -126,6 +126,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") [![Yog...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
344
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.4.1 to 11.4.2
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.4.1 to 11.4.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.4.2</h2> <h3>Changed</h3> <ul> ...
48367da5c8d5df3ac3185154a63fa9978214da55
a2e72fb3149be13698547ab61eb8a06b1294e5ee
diff --git a/composer.lock b/composer.lock index 1fc57d84..60a78937 100644 --- a/composer.lock +++ b/composer.lock @@ -706,35 +706,35 @@ }, { "name": "phpunit/php-code-coverage", - "version": "11.0.6", + "version": "11.0.7", "source": { ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
343
issue_to_patch
Update README.md
Adicionar meu perfil ao README.md ## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [x] New feature (added a non-breaking change w...
466c9644c446eaeb091460b72ce72515b3270e6c
99fc2e5d87869ea2f0e46da76a57d376e0854379
diff --git a/README.md b/README.md index 44263909..b33a27c6 100644 --- a/README.md +++ b/README.md @@ -125,6 +125,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![ABAN26](https://github.com/ABAN26.png?size=60)](https://github.com/ABAN26/AinaraAndreoli "ABAN26 on Github") [![Soham Mo...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
340
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.4.0 to 11.4.1
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.4.0 to 11.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.4.1</h2> <h3>Changed</h3> <ul> ...
e377bd85f472d2ea958b8358a17c2ce09522d793
87689b73c2ead1f49b998ded6684edab5fb8a7f6
diff --git a/composer.lock b/composer.lock index 5134880b..1fc57d84 100644 --- a/composer.lock +++ b/composer.lock @@ -530,16 +530,16 @@ }, { "name": "nikic/php-parser", - "version": "v5.3.0", + "version": "v5.3.1", "source": { "type": "...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
339
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.6 to 11.4.0
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.6 to 11.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.4.0</h2> <h3>Changed</h3> <ul> ...
05777f081b0be2e3c70356331ecd228de51527f2
d2577af7432326ed23041bc37cff62b0ec6a8343
diff --git a/composer.lock b/composer.lock index 259509af..5134880b 100644 --- a/composer.lock +++ b/composer.lock @@ -530,16 +530,16 @@ }, { "name": "nikic/php-parser", - "version": "v5.2.0", + "version": "v5.3.0", "source": { "type": "...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
338
issue_to_patch
Add Yogi Hariyani to README file
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [ ] Updat...
e2d1098ac5d57b63e7f9a2e618097d70e61dedae
ceacc7a401dab5c0ec6bb1607aec72c3b325ff55
diff --git a/README.md b/README.md index c9f73419..44263909 100644 --- a/README.md +++ b/README.md @@ -124,6 +124,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![AJsuper007](https://github.com/AJsuper007.png?size=60)](https://github.com/AJsuper007 "AJsuper007 on Github") [![ABAN26]...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
333
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.5 to 11.3.6
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.5 to 11.3.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.6</h2> <h3>Changed</h3> <ul> ...
78ec5824a3bdb49935b1afd86a902d25ad718bd9
bb2e1479c47d67c19aad5bdc475077adda8c0fe3
diff --git a/composer.lock b/composer.lock index bd73bc1a..259509af 100644 --- a/composer.lock +++ b/composer.lock @@ -530,16 +530,16 @@ }, { "name": "nikic/php-parser", - "version": "v5.1.0", + "version": "v5.2.0", "source": { "type": "...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
334
issue_to_patch
Added example to README
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [ ] Updat...
78ec5824a3bdb49935b1afd86a902d25ad718bd9
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
diff --git a/README.md b/README.md index 72a6c0b1..c9f73419 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](http...
[ "README.md" ]
[ { "comment": "Extra blank line can be removed\r\n```suggestion\r\n```", "path": "README.md", "hunk": "@@ -39,6 +39,7 @@ Here you can easily customize your Typing SVG with a live preview.\n \n Below are links to profiles where you can see Readme Typing SVGs in action!\n \n+", "resolving_sha": "5ec1c1...
true
DenverCoder1/readme-typing-svg
334
comment_to_fix
Added example to README
Extra blank line can be removed ```suggestion ```
78ec5824a3bdb49935b1afd86a902d25ad718bd9
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
diff --git a/README.md b/README.md index 72a6c0b1..c9f73419 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](http...
[ "README.md" ]
[ { "comment": "Extra blank line can be removed\r\n```suggestion\r\n```", "path": "README.md", "hunk": "@@ -39,6 +39,7 @@ Here you can easily customize your Typing SVG with a live preview.\n \n Below are links to profiles where you can see Readme Typing SVGs in action!\n \n+", "resolving_sha": "5ec1c1...
true
DenverCoder1/readme-typing-svg
334
comment_to_fix
Added example to README
61 -> 60 ```suggestion [![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 "Soham More on GitHub") ```
78ec5824a3bdb49935b1afd86a902d25ad718bd9
5ec1c15965fe369f973f8cdaf85c7adea470d7b7
diff --git a/README.md b/README.md index 72a6c0b1..c9f73419 100644 --- a/README.md +++ b/README.md @@ -123,6 +123,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![amir78729](https://github.com/amir78729.png?size=60)](https://github.com/amir78729 "Amir on Github") [![AJsuper007](http...
[ "README.md" ]
[ { "comment": "61 -> 60\r\n```suggestion\r\n[![Soham More](https://github.com/SohamMore100.png?size=60)](https://github.com/SohamMore100 \"Soham More on GitHub\")\r\n```", "path": "README.md", "hunk": "@@ -123,6 +124,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action!\n [![am...
true
DenverCoder1/readme-typing-svg
332
issue_to_patch
added example to README.md
## Summary <!-- Please include a summary of the change and which issue is fixed. --> ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which adds functionality) - [ ] Updat...
7226b95c7756ece02adbfec4e831cc7d0396471a
baed2b1d52a5850ad4bb31c05281113db2af11ca
diff --git a/README.md b/README.md index b5685d6f..72a6c0b1 100644 --- a/README.md +++ b/README.md @@ -122,6 +122,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![caesar013](https://github.com/caesar013.png?size=60)](https://github.com/caesar013 "caesar013 on Github") [![amir78729](...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
331
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.4 to 11.3.5
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.4 to 11.3.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.5</h2> <h3>Fixed</h3> <ul> <l...
7226b95c7756ece02adbfec4e831cc7d0396471a
c5ea85cfcf9abb0ed3355eb0c7d7ac354b925c8a
diff --git a/composer.lock b/composer.lock index 53de52ee..bd73bc1a 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.3.4", + "version": "11.3.5", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
330
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.3 to 11.3.4
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.3 to 11.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.4</h2> <h3>Fixed</h3> <ul> <l...
40f1042dce85603ba3b411fb643788f3690084fb
e2099aa390be739c9a422c3932201f7c824a3a00
diff --git a/composer.lock b/composer.lock index 07e14ecd..53de52ee 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.3.3", + "version": "11.3.4", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
328
issue_to_patch
Update README.md
Added example to README
0c6909fc5fe40b8b208bf5212d63573f7bda4ff5
9bdeeea65b84fd37f660ae74f319a458ce850609
diff --git a/README.md b/README.md index 49b7b874..b5685d6f 100644 --- a/README.md +++ b/README.md @@ -121,6 +121,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![suzukimain](https://github.com/suzukimain.png?size=60)](https://github.com/suzukimain "suzukimain on Github") [![caesar0...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
327
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.1 to 11.3.3
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.1 to 11.3.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.3</h2> <h3>Added</h3> <ul> <l...
0c6909fc5fe40b8b208bf5212d63573f7bda4ff5
19c7a6cde4aa86026c350c5eb99f0f2cdd253084
diff --git a/composer.lock b/composer.lock index 5950b03b..07e14ecd 100644 --- a/composer.lock +++ b/composer.lock @@ -706,32 +706,32 @@ }, { "name": "phpunit/php-code-coverage", - "version": "11.0.5", + "version": "11.0.6", "source": { ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
324
issue_to_patch
Updated-Anand-Purushottam-on-GitHub
## Summary --> Updated Profile Link for "Anand-Purushottam-on-GitHub" ## Type of change - [x] Updated documentation Code Line No. : 83 (updated the readme files)
ca53a1ecb39df5a8050aad25586d852028090313
f4eb03af572882542889bad51470323c6f050bda
diff --git a/README.md b/README.md index d179c301..49b7b874 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![kaisunoo](https://github.com/kaisunoo.png?size=60)](https://github.com/kaisunoo "kaisunoo on GitHub") [![meyer-pidiache](h...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
18
issue_to_patch
Fix Google Fonts not displaying through image tags
## Description It seems like SVGs inside image tags cannot use font URLs so custom fonts are not actually working in READMEs. To fix the issue, I have made the code convert the URLs to base64 encoded Data URIs. Since converting the Google fonts links can be expensive, I have connected a database for caching fetch...
3fe10f351533ba04c3c842b94507ca7bfc191ead
36df53d5f1eb516e338fef3f370e3a8e702df490
diff --git a/.gitignore b/.gitignore index 6e133e83..def28a32 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ vendor/ .vscode/ +.env \ No newline at end of file diff --git a/README.md b/README.md index 6b8a8886..9bc18182 100644 --- a/README.md +++ b/README.md @@ -64,7 +64,7 @@ Feel free to open a PR and add ...
[ ".gitignore", "README.md", "composer.json", "composer.lock", "src/controllers/RendererController.php", "src/demo/css/loader.css", "src/demo/index.php", "src/demo/js/script.js", "src/index.php", "src/models/DatabaseConnection.php", "src/models/ErrorModel.php", "src/models/GoogleFontConverter.ph...
[ { "comment": "Open", "path": "src/demo/index.php", "hunk": "@@ -54,7 +55,7 @@ function gtag() { dataLayer.push(arguments); }\n <h2>Options</h2>\n <form class=\"parameters two-columns options\">\n <label for=\"font\">Font</label>\n- <input class=\"pa...
diff --git a/tests/OptionsTest.php b/tests/OptionsTest.php index aecae5ad..74a7dcc0 100644 --- a/tests/OptionsTest.php +++ b/tests/OptionsTest.php @@ -5,6 +5,13 @@ final class OptionsTest extends TestCase { + protected static $database; + + public static function setUpBeforeClass(): void + { + self:...
true
DenverCoder1/readme-typing-svg
322
issue_to_patch
docs(readme): Added amir78729 to examples
## Summary <!-- Please include a summary of the change and which issue is fixed. --> Added amir78729 to Readme ## Type of change <!-- Please delete options that are not relevant. --> - [ ] Bug fix (added a non-breaking change which fixes an issue) - [ ] New feature (added a non-breaking change which add...
6980513781d575072179896cdf24c8860b6ec674
6061a35ef9dcb031e8d840ae0b80af0fa2f591c0
diff --git a/README.md b/README.md index a6328cc0..d179c301 100644 --- a/README.md +++ b/README.md @@ -120,6 +120,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![João Pedro](https://github.com/JotaP07.png?size=60)](https://github.com/JotaP07 "JP on GitHub") [![suzukimain](https://g...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
323
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.3.0 to 11.3.1
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.3.0 to 11.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.1</h2> <h3>Changed</h3> <ul> ...
672c66faf3e0ee71b5cbf849af94f213cd339eb8
718b4465966431149d5aca38b02c286b1697ffa7
diff --git a/composer.lock b/composer.lock index 98e83573..5950b03b 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.3.0", + "version": "11.3.1", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
321
issue_to_patch
Added caesar013 README.md
I added my profile on readme
50e68f5dd28a53e171544c0d8007f0de84d37ce8
ecdb07a795658fcf9b1c5edbfa21823df1185ef5
diff --git a/README.md b/README.md index 0e95ff27..a6328cc0 100644 --- a/README.md +++ b/README.md @@ -119,6 +119,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Jafeth Yahuma](https://github.com/Callmeproteus.png?size=60)](https://github.com/Callmeproteus "Callmeproteus on GitHub")...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
319
issue_to_patch
docs(readme): Added suzukimain to examples
Add suzukimain to Example usage in Readme.
380838fe11fc69bd6af5fe84c0979ae0e8bcd622
6819293c906c0322ed1c4b51e19ad82dd461993e
diff --git a/README.md b/README.md index 6525e8b4..0e95ff27 100644 --- a/README.md +++ b/README.md @@ -118,6 +118,7 @@ Below are links to profiles where you can see Readme Typing SVGs in action! [![Borketh](https://github.com/Borketh.png?size=60)](https://github.com/Borketh "Borketh on Github") [![Jafeth Yahuma](http...
[ "README.md" ]
[]
true
DenverCoder1/readme-typing-svg
317
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.2.9 to 11.3.0
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.2.9 to 11.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.3.0</h2> <h3>Added</h3> <ul> <l...
b318b3bcd4eff3e3de8321cf3a218c19dea69348
344f0b7c258294e08e0a42519f2dd644e954c475
diff --git a/composer.lock b/composer.lock index fe31794d..98e83573 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.2.9", + "version": "11.3.0", "source": { "type": ...
[ "composer.lock" ]
[]
true
DenverCoder1/readme-typing-svg
316
issue_to_patch
chore(deps-dev): Bump phpunit/phpunit from 11.2.8 to 11.2.9
Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 11.2.8 to 11.2.9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sebastianbergmann/phpunit/releases">phpunit/phpunit's releases</a>.</em></p> <blockquote> <h2>PHPUnit 11.2.9</h2> <h3>Fixed</h3> <ul> <l...
2304267d2446bb9b77fd1d424b7f205e425b8887
1c1849e64f317b3f5fbae97bf8b32c310266b786
diff --git a/composer.lock b/composer.lock index 25963e01..fe31794d 100644 --- a/composer.lock +++ b/composer.lock @@ -1029,16 +1029,16 @@ }, { "name": "phpunit/phpunit", - "version": "11.2.8", + "version": "11.2.9", "source": { "type": ...
[ "composer.lock" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
511
issue_to_patch
Simplified Chinese Translation
Simplified Chinese Translation
9b4822c1b60866502cd01eedd268ecdaff3f0a45
08cffa452b25b8755cf6f129fc813285b0615681
diff --git a/locale/zh_CN/LC_MESSAGES/More/EAV/README.po b/locale/zh_CN/LC_MESSAGES/More/EAV/README.po index 8e72b0002..3c78a2db3 100644 --- a/locale/zh_CN/LC_MESSAGES/More/EAV/README.po +++ b/locale/zh_CN/LC_MESSAGES/More/EAV/README.po @@ -20,17 +20,19 @@ msgstr "" #: ../../More/EAV/README.rst:2 msgid "`Entity-Att...
[ "locale/zh_CN/LC_MESSAGES/More/EAV/README.po", "locale/zh_CN/LC_MESSAGES/More/README.po", "locale/zh_CN/LC_MESSAGES/More/Repository/README.po", "locale/zh_CN/LC_MESSAGES/More/ServiceLocator/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
510
issue_to_patch
Update designpatternsphp.yml
e204e0d02489d6dc9bbb42bff583b16a56ed3e07
1776deae4dfcc653d132d26d0c34e40780213cea
diff --git a/.github/workflows/designpatternsphp.yml b/.github/workflows/designpatternsphp.yml index c9f5af508..3e848b827 100644 --- a/.github/workflows/designpatternsphp.yml +++ b/.github/workflows/designpatternsphp.yml @@ -10,4 +10,4 @@ jobs: - uses: actions/checkout@v3 - name: build the stack - ...
[ ".github/workflows/designpatternsphp.yml" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
504
issue_to_patch
Update README.md
Before diving into any of the patterns, readers should be reminded of two fundamental laws in software architecture: 1.Everything is a trade-ff 2."Why is more important than the how" So, readers face the nuances and reality of these patterns from the beginning. These two laws are coined by two thought leaders in...
41c623cbfe3e690d3a8b92ad354f09f7b20ab859
00d4ca8d912ffad87d77d11b457e98c3321a60c9
diff --git a/README.md b/README.md index 3f13cb15b..5a4fea8c4 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ or [Download as PDF/Epub](https://readthedocs.org/projects/designpatternsphp/dow This is a collection of known design patterns and some sample codes on how to implement them in PHP. Every pattern has ...
[ "README.md" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
507
issue_to_patch
Fix mismatched string references for russian l10n. Translate NULL-object examples
Some translated strings have typos in their messageId and so the translation doesn't get applied See occasional lines in english: - https://designpatternsphp.readthedocs.io/ru/latest/Behavioral/Command/README.html - first example - https://designpatternsphp.readthedocs.io/ru/latest/Creational/AbstractFactory/READ...
41c623cbfe3e690d3a8b92ad354f09f7b20ab859
0d68af0ae8381b023b57dc7411c0dba99935d0bd
diff --git a/locale/ru/LC_MESSAGES/Behavioral/Command/README.po b/locale/ru/LC_MESSAGES/Behavioral/Command/README.po index 4de13d0b5..3b87cd897 100644 --- a/locale/ru/LC_MESSAGES/Behavioral/Command/README.po +++ b/locale/ru/LC_MESSAGES/Behavioral/Command/README.po @@ -55,7 +55,7 @@ msgstr "Примеры" #: ../../Behavior...
[ "locale/ru/LC_MESSAGES/Behavioral/Command/README.po", "locale/ru/LC_MESSAGES/Behavioral/NullObject/README.po", "locale/ru/LC_MESSAGES/Creational/AbstractFactory/README.po", "locale/ru/LC_MESSAGES/Structural/Facade/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
503
issue_to_patch
Fix: State pattern
**This pull request makes the following changes:** * Fix issue #494 **Checklist:** - [x] I've renamed the classes to match the UML diagram - [x] I've added the return types for each method - [x] I've updated the relevant README file
13af79cc5e51f51721eb47290bd79b987c08ff2f
699ff11308d3413981e6f37f571aff72dcfacbda
diff --git a/Behavioral/State/OrderContext.php b/Behavioral/State/ContextOrder.php similarity index 52% rename from Behavioral/State/OrderContext.php rename to Behavioral/State/ContextOrder.php index c18961c31..3b644408d 100644 --- a/Behavioral/State/OrderContext.php +++ b/Behavioral/State/ContextOrder.php @@ -4,29 +4,...
[ "Behavioral/State/ContextOrder.php", "Behavioral/State/CreateOrder.php", "Behavioral/State/OrderDone.php", "Behavioral/State/README.rst", "Behavioral/State/ShippingOrder.php", "Behavioral/State/StateOrder.php", "Behavioral/State/Tests/StateTest.php" ]
[]
diff --git a/Behavioral/State/Tests/StateTest.php b/Behavioral/State/Tests/StateTest.php index 721efeeee..2b668e294 100644 --- a/Behavioral/State/Tests/StateTest.php +++ b/Behavioral/State/Tests/StateTest.php @@ -4,38 +4,38 @@ namespace DesignPatterns\Behavioral\State\Tests; -use DesignPatterns\Behavioral\State\Or...
true
DesignPatternsPHP/DesignPatternsPHP
499
issue_to_patch
Update README.md
- Change overall language support policy Exact working is still a WIP.
e974b142d10d03ea3f49d19f7a035b4a37c5b426
a2e3002f52e9a24c1b66a9957dce6883d474c2e5
diff --git a/README.md b/README.md index 7fe58599..ed2e68b7 100644 --- a/README.md +++ b/README.md @@ -98,23 +98,31 @@ The patterns can be structured in roughly three different categories. Please cli * [Repository](More/Repository) * [ServiceLocator](More/ServiceLocator) [:notebook:](http://en.wikipedia.org/wiki/Serv...
[ "README.md" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
431
issue_to_patch
prepare to migrate to PHP8
e12d9be945c3d02e5c90f5723bf77ad7af86e652
4678b5d86f017fe502db135216c3c131e2198eac
diff --git a/Behavioral/ChainOfResponsibilities/Handler.php b/Behavioral/ChainOfResponsibilities/Handler.php index a0d25ba67..8e6a74d81 100644 --- a/Behavioral/ChainOfResponsibilities/Handler.php +++ b/Behavioral/ChainOfResponsibilities/Handler.php @@ -6,11 +6,8 @@ abstract class Handler { - private ?Handler $su...
[ "Behavioral/ChainOfResponsibilities/Handler.php", "Behavioral/ChainOfResponsibilities/Responsible/HttpInMemoryCacheHandler.php", "Behavioral/Command/AddMessageDateCommand.php", "Behavioral/Command/HelloCommand.php", "Behavioral/Iterator/Book.php", "Behavioral/Mediator/UserRepositoryUiMediator.php", "Beh...
[]
diff --git a/Creational/AbstractFactory/Tests/AbstractFactoryTest.php b/Creational/AbstractFactory/Tests/AbstractFactoryTest.php index 6e1e984f1..400dc34da 100644 --- a/Creational/AbstractFactory/Tests/AbstractFactoryTest.php +++ b/Creational/AbstractFactory/Tests/AbstractFactoryTest.php @@ -21,8 +21,6 @@ public functi...
true
DesignPatternsPHP/DesignPatternsPHP
497
issue_to_patch
Update README.rst
add some examples
5e323dbd92d85b643ff20b3a2bc8896b90c97472
4af130b13ffdf55143171db4764888fceecf87a6
diff --git a/Creational/Singleton/README.rst b/Creational/Singleton/README.rst index c98da8154..1e4fb1d09 100644 --- a/Creational/Singleton/README.rst +++ b/Creational/Singleton/README.rst @@ -15,6 +15,8 @@ Examples - DB Connector - Logger +- Config Manager +- Threads Handling - Lock file for the application ...
[ "Creational/Singleton/README.rst" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
496
issue_to_patch
[f] compatible with Iterator
PHP Deprecated: Return type of DesignPatterns\Behavioral\Iterator\BookList::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] PHP Deprecated: Return type of DesignPatterns\Behavioral\Iterator\BookList::next() should either be compatible with Iterator::next(): void, or the #...
5f022e4f8c5751da50a4b27b30746862736b301a
9a5208c4f806175cf7279a0f64d1389c5e79ede5
diff --git a/Behavioral/Iterator/BookList.php b/Behavioral/Iterator/BookList.php index 7726e99ff..1391b41aa 100644 --- a/Behavioral/Iterator/BookList.php +++ b/Behavioral/Iterator/BookList.php @@ -46,12 +46,12 @@ public function key(): int return $this->currentIndex; } - public function next() + p...
[ "Behavioral/Iterator/BookList.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
493
issue_to_patch
Ukrainian translation
Hello! Added translations for all patterns.
a0825f1316a6a6f93285cd34adea59e9b996f7ea
ea77d134bad76c2a8ae3da0a5b24d57a4d142acd
diff --git a/README.md b/README.md index 0f42b49a4..18954819d 100644 --- a/README.md +++ b/README.md @@ -98,20 +98,21 @@ The patterns can be structured in roughly three different categories. Please cli ## Localization & Supported Languages -| Code | Language | Documentation | -| ------------------|---------...
[ "README.md", "docker-compose.yml", "locale/uk/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/uk/LC_MESSAGES/Behavioral/Command/README.po", "locale/uk/LC_MESSAGES/Behavioral/Interpreter/README.po", "locale/uk/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/uk/LC_MESSAGES/Behaviora...
[]
true
DesignPatternsPHP/DesignPatternsPHP
487
issue_to_patch
remove unneeded elses
6add37973ffecf3c69e50bd58be0ba6d77486fb5
8077f3a73c0aa2e576c29ae930a928347160591a
diff --git a/Structural/Flyweight/TextFactory.php b/Structural/Flyweight/TextFactory.php index db1402f22..82b39ea7a 100644 --- a/Structural/Flyweight/TextFactory.php +++ b/Structural/Flyweight/TextFactory.php @@ -30,9 +30,8 @@ private function create(string $name): Text { if (strlen($name) == 1) { ...
[ "Structural/Flyweight/TextFactory.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
484
issue_to_patch
Creational :: added missing return types & minor refactor
d93f4e8ca70a2e19ff255313de9468b48c7d20d1
719593cedcdfd355656dcfbafed96d99154dfe6e
diff --git a/Creational/AbstractFactory/WinJsonWriter.php b/Creational/AbstractFactory/WinJsonWriter.php index 7671521e9..4c553a868 100644 --- a/Creational/AbstractFactory/WinJsonWriter.php +++ b/Creational/AbstractFactory/WinJsonWriter.php @@ -6,8 +6,12 @@ class WinJsonWriter implements JsonWriter { public funct...
[ "Creational/AbstractFactory/WinJsonWriter.php", "Creational/Builder/Builder.php", "Creational/Builder/CarBuilder.php", "Creational/Builder/TruckBuilder.php", "Creational/Pool/StringReverseWorker.php", "Creational/Pool/WorkerPool.php", "Creational/StaticFactory/StaticFactory.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
483
issue_to_patch
Simplify service locator get method
The constructing of the services can be simplified here via the `...` operator. PS: I really like this repository, great examples!
8d6d00d356f1ed2a2fbe0e27cfc0e1717da62ef1
230b32c9d70bf25ac32356381034e099f91c80d3
diff --git a/More/ServiceLocator/ServiceLocator.php b/More/ServiceLocator/ServiceLocator.php index af2c8614f..52b5c5a02 100644 --- a/More/ServiceLocator/ServiceLocator.php +++ b/More/ServiceLocator/ServiceLocator.php @@ -40,24 +40,7 @@ public function get(string $class): Service return $this->instantiated[...
[ "More/ServiceLocator/ServiceLocator.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
477
issue_to_patch
Final public method for abstract class
All public methods of abstract classes should be final. Enforce API encapsulation in an inheritance architecture. If you want to override a method, use the Template method pattern.
7b24e1185ac0c6f03b68a673d8a084bd0f73ef07
6ec696d00b4873c1bf942149f5d46a33a34c4cee
diff --git a/Behavioral/Mediator/Colleague.php b/Behavioral/Mediator/Colleague.php index 030bd4558..a893347b5 100644 --- a/Behavioral/Mediator/Colleague.php +++ b/Behavioral/Mediator/Colleague.php @@ -8,7 +8,7 @@ abstract class Colleague { protected Mediator $mediator; - public function setMediator(Mediator ...
[ "Behavioral/Mediator/Colleague.php", "Behavioral/TemplateMethod/Journey.php", "Creational/Builder/Parts/Vehicle.php", "Creational/Prototype/BookPrototype.php", "Structural/Bridge/Service.php", "Structural/Registry/Registry.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
478
issue_to_patch
Self static accessor
Inside a final class or anonymous class self should be preferred to static.
7b24e1185ac0c6f03b68a673d8a084bd0f73ef07
40a46455bdbf01a1a75bf126437d7b71c88a6329
diff --git a/Creational/Singleton/Singleton.php b/Creational/Singleton/Singleton.php index 62150407b..75f60aaa3 100644 --- a/Creational/Singleton/Singleton.php +++ b/Creational/Singleton/Singleton.php @@ -15,11 +15,11 @@ final class Singleton */ public static function getInstance(): Singleton { - ...
[ "Creational/Singleton/Singleton.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
476
issue_to_patch
EAV: Update missing type declarations
This PR adds a missing return type to `Attribute::addValue()`, a missing return type to `EAVTest::testCanAddAttributeToEntity()`, and a missing type declaration in `Entity::__construct()`.
24078ed9de304d7165b73426b2bdbdf69ddffb30
83df396fc9f567e152cbc7e26795e869ea141bef
diff --git a/More/EAV/Attribute.php b/More/EAV/Attribute.php index 46ba9f460..6c36cb2e4 100644 --- a/More/EAV/Attribute.php +++ b/More/EAV/Attribute.php @@ -15,7 +15,7 @@ public function __construct(private string $name) $this->values = new SplObjectStorage(); } - public function addValue(Value $valu...
[ "More/EAV/Attribute.php", "More/EAV/Entity.php", "More/EAV/Tests/EAVTest.php" ]
[]
diff --git a/More/EAV/Tests/EAVTest.php b/More/EAV/Tests/EAVTest.php index 12b4efc83..bb491d8c3 100644 --- a/More/EAV/Tests/EAVTest.php +++ b/More/EAV/Tests/EAVTest.php @@ -11,7 +11,7 @@ class EAVTest extends TestCase { - public function testCanAddAttributeToEntity() + public function testCanAddAttributeToEnt...
true
DesignPatternsPHP/DesignPatternsPHP
474
issue_to_patch
Improve Chinese translation of Creational
Since the original translations are all machine translations, they are very inaccurate. All content was re-translated manually. - [x] 1. Creational - [x] 1.1. Abstract Factory - [x] 1.2. Builder - [x] 1.3. Factory Method - [x] 1.4. Pool - [x] 1.5. Prototype - [x] 1.6. Simple Factory - [x] 1.7. Singleton - [x...
adfb13a41229dda6be566c8c646d32d2fec8353c
9910b93688493c9f63dc574863257f2c43849665
diff --git a/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po b/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po index 1ab207e55..45d90aec0 100644 --- a/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po +++ b/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po @@ -1,18 +1...
[ "locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po", "locale/zh_CN/LC_MESSAGES/Creational/Builder/README.po", "locale/zh_CN/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/zh_CN/LC_MESSAGES/Creational/Pool/README.po", "locale/zh_CN/LC_MESSAGES/Creational/Prototype/README.po", "locale/...
[]
true
DesignPatternsPHP/DesignPatternsPHP
473
issue_to_patch
Update User.php
php8.1 test error handle
548d20b9c2572c4d305e7a99556dc6893a6d1937
491e07fbf8b0f3451b6476ac7f5881d96fcb72b9
diff --git a/Behavioral/Observer/User.php b/Behavioral/Observer/User.php index 79a13f7f3..f42d0d435 100644 --- a/Behavioral/Observer/User.php +++ b/Behavioral/Observer/User.php @@ -22,23 +22,23 @@ public function __construct() $this->observers = new SplObjectStorage(); } - public function attach(SplO...
[ "Behavioral/Observer/User.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
471
issue_to_patch
Enhances example of Observer implementation, with actual change. Fixes #470
152ec3dd34f207f7efda0cc87eb400f848b4460a
b5d7e12b21f3fb818ee28a109752552e955c4670
diff --git a/Behavioral/Observer/User.php b/Behavioral/Observer/User.php index 03cfce841..79a13f7f3 100644 --- a/Behavioral/Observer/User.php +++ b/Behavioral/Observer/User.php @@ -15,6 +15,7 @@ class User implements SplSubject { private SplObjectStorage $observers; + private $email; public function __...
[ "Behavioral/Observer/User.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
469
issue_to_patch
docs: add Chinese translation of Interpreter Pattern
### Translate behavior design patterns into Chinese. **Translation Content:** - [x] 3 Behavior design patterns - [x] 3.1 Chain of responsibility - [x] 3.2. Command - [x] 3.3. Interpreter - [x] 3.4. Iterator - [x] 3.5. Mediator - [x] 3.6. Memento - [x] 3.7. Null Object - [x...
cd00ca62231597234dcf2fddf5e6ec0aa151af1e
afb2e011a8a2150de41e276febd6aafaf3047fb5
diff --git a/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po index 9b3329be8..bc0469b80 100644 --- a/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po +++ b/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfRespon...
[ "locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po", "locale/zh_CN/LC_MESSAGES/Behavioral/Interpreter/README.po", "locale/zh_CN/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/zh_CN/LC_MESSAGES/Behavioral/Mediator/README.po", ...
[]
true
DesignPatternsPHP/DesignPatternsPHP
467
issue_to_patch
add Chinese translation of Command Pattern
### Translate behavior design patterns into Chinese. **Translation Content:** - [ ] 3 Behavior design patterns - [x] 3.1 Chain of responsibility - [x] 3.2. Command - [ ] 3.3. Interpreter - [ ] 3.4. Iterator - [ ] 3.5. Mediator - [ ] 3.6. Memento - [ ] 3.7. Null Object - [ ...
27dc1302133a5e6a00e6b9b2fa83eb1ce3980b92
0cead18424c694780f748cbfd38d29f49b54292a
diff --git a/locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po b/locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po index ab5e1e6d9..016914e96 100644 --- a/locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po +++ b/locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po @@ -5,7 +5,7 @@ msgstr "" "Report-Msgid-Bu...
[ "locale/zh_CN/LC_MESSAGES/Behavioral/Command/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
468
issue_to_patch
Update PostStatus.php
Fixed typo
6b222a2fe2bfb36024d43e5afce251e4821e0076
be700e29af531cbc8a29bebb0b6850cefec0c4ab
diff --git a/More/Repository/Domain/PostStatus.php b/More/Repository/Domain/PostStatus.php index 7db03a918..1c95c352e 100644 --- a/More/Repository/Domain/PostStatus.php +++ b/More/Repository/Domain/PostStatus.php @@ -53,7 +53,7 @@ public function toInt(): int /** * there is a reason that I avoid using __to...
[ "More/Repository/Domain/PostStatus.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
464
issue_to_patch
docs: add Translation to Chinese
### Translate behavior design patterns into Chinese. **Translation Content:** - [ ] 3 Behavior design patterns - [x] 3.1 Chain of responsibility - [ ] 3.2. Command - [ ] 3.3. Interpreter - [ ] 3.4. Iterator - [ ] 3.5. Mediator - [ ] 3.6. Memento - [ ] 3.7. Null Object - [ ...
92e89207c1ffa0bfd0103fd24895170aeaed7cc2
c9555390cef1e92aa84dc1e3fa9801db047cf752
diff --git a/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po index 5c11cce71..9b3329be8 100644 --- a/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po +++ b/locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfRespon...
[ "locale/zh_CN/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/zh_CN/LC_MESSAGES/Behavioral/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
466
issue_to_patch
fix translate pt-br to Dependency Injection, Facade and Interpreter
This PR fix issue #465
92e89207c1ffa0bfd0103fd24895170aeaed7cc2
510d339b0cd52234091b4168a20c8bd67c463bc9
diff --git a/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po b/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po index 68ddc8158..9e4b6285c 100644 --- a/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po +++ b/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po @@ -4,8 +4,8 @@ msgstr "" ...
[ "locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po", "locale/pt_BR/LC_MESSAGES/Structural/DependencyInjection/README.po", "locale/pt_BR/LC_MESSAGES/Structural/Facade/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
463
issue_to_patch
add translate pt-br to NullObject
Tradução do exemplo `Behavioral/NullObject/README.rst:24` para português brasileiro.
17fdaed7395d43a0e6bf5681f45d40d719e41111
400614646a419d98b3a02ae39bf623aa0e5f84b3
diff --git a/locale/pt_BR/LC_MESSAGES/Behavioral/NullObject/README.po b/locale/pt_BR/LC_MESSAGES/Behavioral/NullObject/README.po index 24ed6b69f..363a20e34 100644 --- a/locale/pt_BR/LC_MESSAGES/Behavioral/NullObject/README.po +++ b/locale/pt_BR/LC_MESSAGES/Behavioral/NullObject/README.po @@ -1,11 +1,11 @@ -# +# msgid...
[ "locale/pt_BR/LC_MESSAGES/Behavioral/NullObject/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
460
issue_to_patch
adds pt_br translation for interpreter
Adds missing portuguese translation for interpreter pattern
7364019728a8bd49b3a3f5d1ba392909f8f9a8cd
8343e9e6648d38d976352a0e93af28088a6c4c8b
diff --git a/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po b/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po new file mode 100644 index 000000000..68ddc8158 --- /dev/null +++ b/locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po @@ -0,0 +1,56 @@ +# +msgid "" +msgstr "" +"Project-Id-Version:...
[ "locale/pt_BR/LC_MESSAGES/Behavioral/Interpreter/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
462
issue_to_patch
Composer > Update lock based in the PHP version
Updating Composer lock file
7364019728a8bd49b3a3f5d1ba392909f8f9a8cd
7cc012c990988c59fb158cbcf12a2ddd1ffa27cc
diff --git a/Structural/Flyweight/Character.php b/Structural/Flyweight/Character.php index 351566176..4e9767525 100644 --- a/Structural/Flyweight/Character.php +++ b/Structural/Flyweight/Character.php @@ -18,11 +18,11 @@ public function __construct(private string $name) { } - public function render(strin...
[ "Structural/Flyweight/Character.php", "Structural/Flyweight/Word.php", "composer.json", "composer.lock" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
461
issue_to_patch
Fix PHPUnit issue
Running these composer commands below during the Docker execution or out of the Docker we have the error below. ``` composer install \ && ./vendor/bin/phpcs --ignore=_build . \ && ./vendor/bin/phpunit \ && ./vendor/bin/psalm --show-info=false \ && ./check-refs-readmes ``` **Before:** <img...
7364019728a8bd49b3a3f5d1ba392909f8f9a8cd
a3e06e0ee55736e18561ee4fbe750d72a22c1bae
diff --git a/Creational/Singleton/Singleton.php b/Creational/Singleton/Singleton.php index c7c0976aa..386b3f560 100644 --- a/Creational/Singleton/Singleton.php +++ b/Creational/Singleton/Singleton.php @@ -36,7 +36,7 @@ private function __clone() /** * prevent from being unserialized (which would create a sec...
[ "Creational/Singleton/Singleton.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
456
issue_to_patch
Creational and Structural sections - Fixes and added translations spanish
- Texts removed from the home page - Minor fixes. ## Creational - Page SimpleFactory was not correctly referencing the original text. ## Structural - Page DependencyInjection and Facade was not correctly referencing the original text. - The original text and the translation of the Registry page are updated.
1ea91bcadfb5855bc2f888208eacc53d2fd65111
160366dbea6502e0a6cb24614ee5ef3971155deb
diff --git a/locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po b/locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po index f235fad6e..63d2d43ae 100644 --- a/locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po +++ b/locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po @@ -4,14 +4,14 @@ msgstr "" "P...
[ "locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/es/LC_MESSAGES/Creational/SimpleFactory/README.po", "locale/es/LC_MESSAGES/Creational/StaticFactory/README.po", "locale/es/LC_MESSAGES/README.po", "locale/es/LC_MESSAGES/Structural/Adapter/README.po", "locale/es/LC_MESSAGES/Structural/Dec...
[]
true
DesignPatternsPHP/DesignPatternsPHP
459
issue_to_patch
Grammar errors, message ids and Interpreter pattern
- Italian grammar errors - Some msgids for correct translation - Translated missing Interpreter Pattern
4124c227dceb512d6250a55a56b89156a2bbcfcb
dbe1ef079d63e8b6aa82e38fb2a5cd8c51bff9a0
diff --git a/README.md b/README.md index 138db199d..e40688a9a 100644 --- a/README.md +++ b/README.md @@ -115,4 +115,4 @@ The patterns can be structured in roughly three different categories. Please cli | tr | Turkish | [Docs :notebook:](https://designpatternsphp.readthedocs.io/tr/latest/README.html) | | bg | ...
[ "README.md", "locale/it/LC_MESSAGES/Behavioral/Command/README.po", "locale/it/LC_MESSAGES/Behavioral/Interpreter/README.po", "locale/it/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/it/LC_MESSAGES/Behavioral/Mediator/README.po", "locale/it/LC_MESSAGES/Behavioral/Memento/README.po", "locale/it/LC_M...
[]
true
DesignPatternsPHP/DesignPatternsPHP
458
issue_to_patch
Fix broken msgid so that translation works properly
046800b489b1712bc7df1d79456213709dcd9f7a
4e4b4de6660d67afd9dd4f8dc9fc1367655a865c
diff --git a/locale/ca/LC_MESSAGES/Creational/FactoryMethod/README.po b/locale/ca/LC_MESSAGES/Creational/FactoryMethod/README.po index d409beceb..ed43c2f09 100644 --- a/locale/ca/LC_MESSAGES/Creational/FactoryMethod/README.po +++ b/locale/ca/LC_MESSAGES/Creational/FactoryMethod/README.po @@ -1,4 +1,4 @@ -# +# msgid "...
[ "locale/ca/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/fr/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/nl/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/pl/LC_MESSAGES/Creational/FactoryMethod/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
457
issue_to_patch
Fix typos and some translations
I fix some grammar errors and some phrases that aren't translated
1ea91bcadfb5855bc2f888208eacc53d2fd65111
01e7158627d8fa9af4836048db68c27462f80f31
diff --git a/locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po index 0f2b4333c..8e90d2a22 100644 --- a/locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po +++ b/locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/R...
[ "locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/it/LC_MESSAGES/Behavioral/Command/README.po", "locale/it/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/it/LC_MESSAGES/Behavioral/Memento/README.po", "locale/it/LC_MESSAGES/Behavioral/NullObject/README.po", "locale/it/LC_ME...
[]
true
DesignPatternsPHP/DesignPatternsPHP
455
issue_to_patch
Added spanish translation of Behavioral and More sections
hi! @domnikl I have finished translating the two remaining sections(behavioral & more). Check that everything is fine. Any rectification or error I'll be happy to modify it and learn how to handle git and collaborate with the opensource.
1ea91bcadfb5855bc2f888208eacc53d2fd65111
a735c1231b05393c08a9cc0747b66448989c21f1
diff --git a/locale/es/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/es/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po index 7c7c7aadf..4ebbc061d 100644 --- a/locale/es/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po +++ b/locale/es/LC_MESSAGES/Behavioral/ChainOfResponsibilities/R...
[ "locale/es/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/es/LC_MESSAGES/Behavioral/Command/README.po", "locale/es/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/es/LC_MESSAGES/Behavioral/Mediator/README.po", "locale/es/LC_MESSAGES/Behavioral/Memento/README.po", "locale/es/LC_MESS...
[]
true
DesignPatternsPHP/DesignPatternsPHP
452
issue_to_patch
Added translation to spanish of Structural/fixed typo errors in Creational
hi @domnikl I made a small modification in Creational and translated the entire Structural section. Cause I am a beginner, please check that you have loaded everything correctly and that there are no errors. If all goes well, I will continue with the translation of Behavioral and More
f476239c9952df7361974f10422bbedbc712f830
54bb974817f104087fa5f1a8c6221446434947e1
diff --git a/locale/es/LC_MESSAGES/Creational/Prototype/README.po b/locale/es/LC_MESSAGES/Creational/Prototype/README.po index 388ae8a71..be708dd28 100644 --- a/locale/es/LC_MESSAGES/Creational/Prototype/README.po +++ b/locale/es/LC_MESSAGES/Creational/Prototype/README.po @@ -26,8 +26,8 @@ msgid "" "To avoid the cost ...
[ "locale/es/LC_MESSAGES/Creational/Prototype/README.po", "locale/es/LC_MESSAGES/Creational/README.po", "locale/es/LC_MESSAGES/Creational/SimpleFactory/README.po", "locale/es/LC_MESSAGES/Structural/Adapter/README.po", "locale/es/LC_MESSAGES/Structural/Bridge/README.po", "locale/es/LC_MESSAGES/Structural/Com...
[]
true
DesignPatternsPHP/DesignPatternsPHP
454
issue_to_patch
Fix ru-translation bug for ObjectPool pattern.
Found a bug with quotes in my translation for **Object Pool**. Fixed it)
f476239c9952df7361974f10422bbedbc712f830
e4158e5ba0f4566740e5acbbb83f8d40b437e83c
diff --git a/locale/ru/LC_MESSAGES/Creational/Pool/README.po b/locale/ru/LC_MESSAGES/Creational/Pool/README.po index d8aea3dc6..c979821ed 100644 --- a/locale/ru/LC_MESSAGES/Creational/Pool/README.po +++ b/locale/ru/LC_MESSAGES/Creational/Pool/README.po @@ -46,8 +46,8 @@ msgstr "" "ситуациях, когда стоимость и скорость...
[ "locale/ru/LC_MESSAGES/Creational/Pool/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
453
issue_to_patch
Add ru-translation for Interpreter pattern
+ minor fix for original `.rst` file
f476239c9952df7361974f10422bbedbc712f830
2217528d7ee1739bb306bbdbbfeecd4ff0db8485
diff --git a/Behavioral/Interpreter/README.rst b/Behavioral/Interpreter/README.rst index cdecafcd0..30d14188a 100644 --- a/Behavioral/Interpreter/README.rst +++ b/Behavioral/Interpreter/README.rst @@ -1,5 +1,5 @@ `Interpreter`__ -============ +=============== Purpose ------- diff --git a/locale/ru/LC_MESSAGES/Beha...
[ "Behavioral/Interpreter/README.rst", "locale/ru/LC_MESSAGES/Behavioral/Interpreter/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
451
issue_to_patch
Italian translation
added italian translation. Happy to contribute!
934dc9912000326cbfdd4eb3d9b352e3c59eb7e0
14c7df94a7a39d2a68f79834c07e533be17492f8
diff --git a/README.md b/README.md index 6227ee576..138db199d 100644 --- a/README.md +++ b/README.md @@ -115,3 +115,4 @@ The patterns can be structured in roughly three different categories. Please cli | tr | Turkish | [Docs :notebook:](https://designpatternsphp.readthedocs.io/tr/latest/README.html) | | bg | ...
[ "README.md", "locale/it/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/it/LC_MESSAGES/Behavioral/Command/README.po", "locale/it/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/it/LC_MESSAGES/Behavioral/Mediator/README.po", "locale/it/LC_MESSAGES/Behavioral/Memento/README.po", "lo...
[]
true
DesignPatternsPHP/DesignPatternsPHP
447
issue_to_patch
Update ru-localization for ObjectPool pattern
Fix typos, simplify some phrases.
c03a2f988116715aaabd12f6f11e338254e86bdb
0b5078da72c5fd77b8b85100a36c060cd75a36d9
diff --git a/locale/ru/LC_MESSAGES/Creational/Pool/README.po b/locale/ru/LC_MESSAGES/Creational/Pool/README.po index c18f9799e..d8aea3dc6 100644 --- a/locale/ru/LC_MESSAGES/Creational/Pool/README.po +++ b/locale/ru/LC_MESSAGES/Creational/Pool/README.po @@ -43,11 +43,11 @@ msgid "" "time." msgstr "" "Хранение объекто...
[ "locale/ru/LC_MESSAGES/Creational/Pool/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
450
issue_to_patch
Update ru-localization for ChainOfResponsibilites
- Fix titles
c03a2f988116715aaabd12f6f11e338254e86bdb
45d250a33631b256181f6e7f17aa09668d2d8d80
diff --git a/locale/ru/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/ru/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po index e34329b2f..1eac08f3e 100644 --- a/locale/ru/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po +++ b/locale/ru/LC_MESSAGES/Behavioral/ChainOfResponsibilities/R...
[ "locale/ru/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
445
issue_to_patch
use standard coding style from PHP Code Sniffer Right now, the FLYERALARM coding style is being used, instead the standard coding style from Code Sniffer should be used. With that, the dep on `flyeralarm/php-code-validator` can be removed.
style: Adopt PSR12
Dev dependency flyeralarm/php-code-validator has been removed. Most files were automatically changed with `phpcbf` to adopt the PSR-12 standard. The following files were manually changed to stop with PHPCS warnings about `const` without `public/private` scope: - `Behavioral/Memento/State.php` - `More/Reposito...
7c0b7ece074e17c9fadaa199968a995107a71e6b
56970cc2219d9f0460a58ab0fa5261e5f1365675
diff --git a/Behavioral/ChainOfResponsibilities/Handler.php b/Behavioral/ChainOfResponsibilities/Handler.php index 8e6a74d81..e6e2f9bf5 100644 --- a/Behavioral/ChainOfResponsibilities/Handler.php +++ b/Behavioral/ChainOfResponsibilities/Handler.php @@ -1,4 +1,6 @@ -<?php declare(strict_types=1); +<?php + +declare(stric...
[ "Behavioral/ChainOfResponsibilities/Handler.php", "Behavioral/ChainOfResponsibilities/Responsible/HttpInMemoryCacheHandler.php", "Behavioral/ChainOfResponsibilities/Responsible/SlowDatabaseHandler.php", "Behavioral/ChainOfResponsibilities/Tests/ChainTest.php", "Behavioral/Command/AddMessageDateCommand.php",...
[]
diff --git a/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php b/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php index e888d7699..bfd189a67 100644 --- a/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php +++ b/Behavioral/ChainOfResponsibilities/Tests/ChainTest.php @@ -1,4 +1,6 @@ -<?php declare(strict_t...
true
DesignPatternsPHP/DesignPatternsPHP
446
issue_to_patch
Add missing Spanish translations
Add missing Spanish translations for Creational pattern section
7c0b7ece074e17c9fadaa199968a995107a71e6b
f3759d5ba70a22ea6b657f2264cfb37744db1888
diff --git a/locale/es/LC_MESSAGES/Creational/AbstractFactory/README.po b/locale/es/LC_MESSAGES/Creational/AbstractFactory/README.po index 0e0c68ab1..7a1126c07 100644 --- a/locale/es/LC_MESSAGES/Creational/AbstractFactory/README.po +++ b/locale/es/LC_MESSAGES/Creational/AbstractFactory/README.po @@ -18,14 +18,14 @@ msg...
[ "locale/es/LC_MESSAGES/Creational/AbstractFactory/README.po", "locale/es/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/es/LC_MESSAGES/Creational/Pool/README.po", "locale/es/LC_MESSAGES/Creational/Prototype/README.po", "locale/es/LC_MESSAGES/Creational/SimpleFactory/README.po", "locale/es/LC_MES...
[]
true
DesignPatternsPHP/DesignPatternsPHP
443
issue_to_patch
fix: typo
0bfe9fe9a1ab6083967d432c45d82534336971ab
6febe59be1a27bd64a8b359413007f73fda7e6b5
diff --git a/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po b/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po index 1675674b5..1ab207e55 100644 --- a/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po +++ b/locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po @@ -24,10 +...
[ "locale/zh_CN/LC_MESSAGES/Creational/AbstractFactory/README.po", "locale/zh_CN/LC_MESSAGES/Creational/FactoryMethod/README.po", "locale/zh_CN/LC_MESSAGES/Creational/StaticFactory/README.po", "locale/zh_CN/LC_MESSAGES/Structural/Composite/README.po", "locale/zh_CN/LC_MESSAGES/Structural/DependencyInjection/R...
[]
true
DesignPatternsPHP/DesignPatternsPHP
389
issue_to_patch
add translation in Japanese
9432d9ce613266a132e36fd0669d5f5f6ed59131
412b5e4da4658315355de7b9f2f014f9921fd549
diff --git a/locale/ja/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po b/locale/ja/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po new file mode 100644 index 000000000..dbab20f86 --- /dev/null +++ b/locale/ja/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po @@ -0,0 +1,87 @@ +# SOME DESCRIPTIVE...
[ "locale/ja/LC_MESSAGES/Behavioral/ChainOfResponsibilities/README.po", "locale/ja/LC_MESSAGES/Behavioral/Command/README.po", "locale/ja/LC_MESSAGES/Behavioral/Iterator/README.po", "locale/ja/LC_MESSAGES/Behavioral/Mediator/README.po", "locale/ja/LC_MESSAGES/Behavioral/Memento/README.po", "locale/ja/LC_MESS...
[]
true
DesignPatternsPHP/DesignPatternsPHP
391
issue_to_patch
add translation in Japanese 2
# purposes Add translation in Japanese 2 # related pull request https://github.com/domnikl/DesignPatternsPHP/pull/389
6e1000f4db8105d98a9a184cd080cf1196646029
7f76003b0ca1f8d9f3409dd52755763867c867c4
diff --git a/locale/ja/LC_MESSAGES/Creational/SimpleFactory/README.po b/locale/ja/LC_MESSAGES/Creational/SimpleFactory/README.po index 71517bb64..08bfc59fd 100644 --- a/locale/ja/LC_MESSAGES/Creational/SimpleFactory/README.po +++ b/locale/ja/LC_MESSAGES/Creational/SimpleFactory/README.po @@ -11,7 +11,7 @@ msgstr "" "R...
[ "locale/ja/LC_MESSAGES/Creational/SimpleFactory/README.po" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
439
issue_to_patch
refactor: add string return type
b521db7c06698935793fbd319769a9d2419ebd8b
1aceddc14a98d05dfb74111c1fe483288de6312a
diff --git a/Creational/Pool/StringReverseWorker.php b/Creational/Pool/StringReverseWorker.php index 378f221d6..ca7a5f904 100644 --- a/Creational/Pool/StringReverseWorker.php +++ b/Creational/Pool/StringReverseWorker.php @@ -10,7 +10,7 @@ public function __construct() { } - public function run(string $te...
[ "Creational/Pool/StringReverseWorker.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
440
issue_to_patch
refactor: add void return type
b521db7c06698935793fbd319769a9d2419ebd8b
56e893da00b8021abc47e60eb9c605b21b0727c1
diff --git a/Creational/Prototype/BookPrototype.php b/Creational/Prototype/BookPrototype.php index 5175b15f3..accd89823 100644 --- a/Creational/Prototype/BookPrototype.php +++ b/Creational/Prototype/BookPrototype.php @@ -14,7 +14,7 @@ public function getTitle(): string return $this->title; } - public...
[ "Creational/Prototype/BookPrototype.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
441
issue_to_patch
refactor: add void return type
b521db7c06698935793fbd319769a9d2419ebd8b
93252b894f1efd954efb6af4c68d73d70cdf9ac2
diff --git a/Structural/Adapter/PaperBook.php b/Structural/Adapter/PaperBook.php index f8ad3c490..c9ebf3505 100644 --- a/Structural/Adapter/PaperBook.php +++ b/Structural/Adapter/PaperBook.php @@ -6,12 +6,12 @@ class PaperBook implements Book { private int $page; - public function open() + public function...
[ "Structural/Adapter/PaperBook.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
438
issue_to_patch
refactor: add void return type of update user observer
3f8444252842c12d8065017364e0eef402e7e7a4
db4b17c70e98578522ba41d8a91893ead1c5eae2
diff --git a/Behavioral/Observer/UserObserver.php b/Behavioral/Observer/UserObserver.php index 417ad81ba..2630648a5 100644 --- a/Behavioral/Observer/UserObserver.php +++ b/Behavioral/Observer/UserObserver.php @@ -15,7 +15,7 @@ class UserObserver implements SplObserver /** * It is called by the Subject, usual...
[ "Behavioral/Observer/UserObserver.php" ]
[]
true
DesignPatternsPHP/DesignPatternsPHP
429
issue_to_patch
Add pattern Interpreter
bd124378c5cc19d3278b329eb69082baf03a6d1a
78a716ae0f4473078734172e3d9eb6241f116dd2
diff --git a/Behavioral/Interpreter/AbstractExp.php b/Behavioral/Interpreter/AbstractExp.php new file mode 100644 index 000000000..5e34736fb --- /dev/null +++ b/Behavioral/Interpreter/AbstractExp.php @@ -0,0 +1,8 @@ +<?php declare(strict_types=1); + +namespace DesignPatterns\Behavioral\Interpreter; + +abstract class Ab...
[ "Behavioral/Interpreter/AbstractExp.php", "Behavioral/Interpreter/AndExp.php", "Behavioral/Interpreter/Context.php", "Behavioral/Interpreter/OrExp.php", "Behavioral/Interpreter/README.rst", "Behavioral/Interpreter/Tests/InterpreterTest.php", "Behavioral/Interpreter/VariableExp.php", "Behavioral/Interp...
[]
diff --git a/Behavioral/Interpreter/Tests/InterpreterTest.php b/Behavioral/Interpreter/Tests/InterpreterTest.php new file mode 100644 index 000000000..3b1c07a1d --- /dev/null +++ b/Behavioral/Interpreter/Tests/InterpreterTest.php @@ -0,0 +1,63 @@ +<?php declare(strict_types=1); + +namespace DesignPatterns\Behavioral\In...
true
DesignPatternsPHP/DesignPatternsPHP
435
issue_to_patch
re-add __clone
I re-added the `__clone` method which removed in the last commit.
bd124378c5cc19d3278b329eb69082baf03a6d1a
8d87391aa152162c733f23fadae0ba29d1910c36
diff --git a/Creational/Singleton/Singleton.php b/Creational/Singleton/Singleton.php index ebad0a648..d4ea3a23e 100644 --- a/Creational/Singleton/Singleton.php +++ b/Creational/Singleton/Singleton.php @@ -28,6 +28,13 @@ private function __construct() { } + /** + * prevent the instance from being clon...
[ "Creational/Singleton/Singleton.php" ]
[]
true
DevToys-app/DevToys
1,046
issue_to_patch
Fix crash on Linux on startup
<!--- Please provide a general summary of your changes in the title above --> ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [X] Bugfix - [ ] New feature or enhancement - [ ] UI...
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/.nuke/build.schema.json b/.nuke/build.schema.json index f60885a1c7..40579afa52 100644 --- a/.nuke/build.schema.json +++ b/.nuke/build.schema.json @@ -43,6 +43,10 @@ "VSCode" ] }, + "LinuxSolution": { + "type": "string", + "description": "Path to a s...
[ ".nuke/build.schema.json", ".nuke/parameters.json", "CONTRIBUTING.md", "src/Directory.Packages.props", "src/app/dev/DevToys.Api/DevToys.Api.csproj", "src/app/dev/DevToys.Tools/DevToys.Tools.csproj", "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorAssetFileProvider.cs", "src...
[ { "comment": "Just delaying the loading of WebKit from `LinuxProgram.cs` to here.", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs", "hunk": "@@ -7,6 +7,11 @@ internal sealed class BlazorWebView : WebView\n {\n private readonly BlazorWebViewBridge _bri...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
Just delaying the loading of WebKit from `LinuxProgram.cs` to here.
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs index 95b8707655..20a76b6c60 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs +++ b...
[ "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs" ]
[ { "comment": "Just delaying the loading of WebKit from `LinuxProgram.cs` to here.", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebView.cs", "hunk": "@@ -7,6 +7,11 @@ internal sealed class BlazorWebView : WebView\n {\n private readonly BlazorWebViewBridge _bri...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
This fix the bug I was talking about in the description where we were looking at `wwwroot/index.html` from the wrong root folder.
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs index 4cabf579c2..91c59c51ef 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWe...
[ "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs" ]
[ { "comment": "This fix the bug I was talking about in the description where we were looking at `wwwroot/index.html` from the wrong root folder.", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Components/BlazorWebView/BlazorWebViewOptions.cs", "hunk": "@@ -6,7 +8,7 @@ internal record BlazorWebView...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
THIS line is THE line that was making the app crashing on startup...
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs index 8240f755d5..155d744c79 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs @...
[ "src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs" ]
[ { "comment": "THIS line is THE line that was making the app crashing on startup...", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs", "hunk": "@@ -6,16 +6,8 @@\n namespace DevToys.Linux.Core;\n \n [Export(typeof(IFileStorage))]\n-internal sealed class FileStorage : GObject.Obje...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
We needed `Gtk.Internal.FileDialog.New()` HERE. For THIS line. Now we use `Gtk.FileChooserNative.New`.
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs index 8240f755d5..155d744c79 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs @...
[ "src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs" ]
[ { "comment": "We needed `Gtk.Internal.FileDialog.New()` HERE. For THIS line. Now we use `Gtk.FileChooserNative.New`.", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Core/FileStorage.cs", "hunk": "@@ -69,47 +61,39 @@ public FileStream OpenWriteFile(string relativeOrAbsoluteFilePath, bool replaceI\...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
We can now detect High Contrast, hooray!
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs b/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs index 37a3f50521..6254d54c96 100644 --- a/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs +++ b/src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListe...
[ "src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs" ]
[ { "comment": "We can now detect High Contrast, hooray! ", "path": "src/app/dev/platforms/desktop/DevToys.Linux/Core/ThemeListener.cs", "hunk": "@@ -126,20 +140,14 @@ private bool GetBestValueForCompactMode()\n \n private void UpdateSystemSettingsAndApplyTheme()\n {\n- IsHighContrast = fal...
true
DevToys-app/DevToys
1,046
comment_to_fix
Fix crash on Linux on startup
This is a tiny refactoring here. When I tried to make my own GTK wrapper for Linux I had to recode the whole BlazorWebView and learned a bit more about it. In a separate PR, at the occasion, I will refactor both BlazorWebView from MacOS and Linux to have much more code in common.
495db7dee4f745239ef9a9de81f65edf7b5fed51
1b0d121267ca092135ab63956974acbe322ae365
diff --git a/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs b/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs index b7ca9e3d2f..0327387231 100644 --- a/src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs +++ b...
[ "src/app/dev/platforms/desktop/DevToys.MacOS/Controls/BlazorWebView/BlazorWKWebView.cs" ]
[ { "comment": "This is a tiny refactoring here. When I tried to make my own GTK wrapper for Linux I had to recode the whole BlazorWebView and learned a bit more about it. In a separate PR, at the occasion, I will refactor both BlazorWebView from MacOS and Linux to have much more code in common.", "path": "sr...
true
DevToys-app/DevToys
1,078
issue_to_patch
Explain claims of JWT token like jwt.ms ### What's the Problem? The JWT Token Decoder only decodes property raw values. It would be much more helpful if each claim is explained in detail. For example, both DevToys and jwt.ms show this: ```json "iat": 1658523177, ``` But jwt.ms shows more if you switch to "Claims...
Ported Json Web Token Encoder Decoder to DevToys 2.0
<!--- Please provide a general summary of your changes in the title above --> ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [ ] Bugfix - [ ] New feature or enhancement - [ ] UI...
7d3896855c03ebba419e00fc0647c38f8a8c57c4
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props index 24c35fee15..1f23cb22fd 100644 --- a/src/Directory.Packages.props +++ b/src/Directory.Packages.props @@ -18,7 +18,7 @@ <PackageVersion Include="GirCore.Adw-1" Version="$(GirCore)" /> <PackageVersion Include="GirCore.Gtk-4.0" Version...
[ "src/Directory.Packages.props", "src/app/dev/DevToys.Api/Core/ResultInfo.cs", "src/app/dev/DevToys.Api/Core/ResultInfoSeverity.cs", "src/app/dev/DevToys.Api/Tool/GUI/Components/IUIMultiLineTextInput.cs", "src/app/dev/DevToys.Api/Tool/GUI/Components/UIHoverTooltip.cs", "src/app/dev/DevToys.Blazor/Component...
[ { "comment": "This assignment is incorrect. You want to set a line here, not a column.", "path": "src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs", "hunk": "@@ -178,6 +180,54 @@ private Task OnMonacoEditorInitializedAsync()\n return Task.CompletedTask;\n ...
diff --git a/src/app/tests/DevToys.UnitTests/DevToys.UnitTests.csproj b/src/app/tests/DevToys.UnitTests/DevToys.UnitTests.csproj index 35799cf4b0..206281afba 100644 --- a/src/app/tests/DevToys.UnitTests/DevToys.UnitTests.csproj +++ b/src/app/tests/DevToys.UnitTests/DevToys.UnitTests.csproj @@ -5,6 +5,20 @@ <IsPack...
true
DevToys-app/DevToys
1,078
comment_to_fix
Ported Json Web Token Encoder Decoder to DevToys 2.0
This assignment is incorrect. You want to set a line here, not a column.
7d3896855c03ebba419e00fc0647c38f8a8c57c4
15a7b7f4a9dc709a680c03a7be268b87e1079214
diff --git a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs b/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs index cd3f1df02e..d4b3a02f2d 100644 --- a/src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs...
[ "src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs" ]
[ { "comment": "This assignment is incorrect. You want to set a line here, not a column.", "path": "src/app/dev/DevToys.Blazor/Components/UIElements/UIMultiLineTextInputPresenter.razor.cs", "hunk": "@@ -178,6 +180,54 @@ private Task OnMonacoEditorInitializedAsync()\n return Task.CompletedTask;\n ...
true