repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
CoplayDev/unity-mcp | 1,040 | issue_to_patch | game_view screenshots with include_image miss UI Toolkit overlays
## Summary
`manage_scene(action="screenshot", capture_source="game_view", include_image=true)` can miss UI Toolkit overlays in Play Mode.
## Problem
When `include_image=true` is used without an explicit camera target, the screenshot path captures thr... | fix: include UI Toolkit overlays in game_view screenshots with include_image | ## Summary
Fix the Play Mode `game_view` screenshot path used when `include_image=true` so the returned inline image includes UI Toolkit overlays.
## Problem
When `manage_scene(action="screenshot", capture_source="game_view", include_image=true)` is used without an explicit camera target, the previous implementation... | 9b0a6621d33be5087284bb99c1837523993154f2 | a90ab068443f496c2f03ae0687ea72f2e97af6c1 | diff --git a/MCPForUnity/Editor/Tools/ManageScene.cs b/MCPForUnity/Editor/Tools/ManageScene.cs
index 168167852..842cc338c 100644
--- a/MCPForUnity/Editor/Tools/ManageScene.cs
+++ b/MCPForUnity/Editor/Tools/ManageScene.cs
@@ -591,22 +591,48 @@ private static object CaptureScreenshot(SceneCommand cmd)
... | [
"MCPForUnity/Editor/Tools/ManageScene.cs",
"MCPForUnity/Runtime/Helpers/ScreenshotUtility.cs"
] | [] | true | |
Curzibn/Luban | 319 | issue_to_patch | close InputStream to fix #313,#314 | ead45cf09933e08c18bcdab3a63d0d66d10be3db | 399e9783603886d0429d02696e4813c31d666662 | diff --git a/library/src/main/java/top/zibin/luban/InputStreamAdapter.java b/library/src/main/java/top/zibin/luban/InputStreamAdapter.java
new file mode 100644
index 00000000..e085a301
--- /dev/null
+++ b/library/src/main/java/top/zibin/luban/InputStreamAdapter.java
@@ -0,0 +1,34 @@
+package top.zibin.luban;
+
+impor... | [
"library/src/main/java/top/zibin/luban/InputStreamAdapter.java",
"library/src/main/java/top/zibin/luban/InputStreamProvider.java",
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | |||
Curzibn/Luban | 306 | issue_to_patch | Update README-EN.md | Fix broken profile link | 201db72ecede3ef69fcc83599bd6ac774b6696a0 | 9f5f9a1b67dfbafdd30fc3144a32fa9205940877 | diff --git a/Translation/README-EN.md b/Translation/README-EN.md
index 19c4281b..995efa8f 100644
--- a/Translation/README-EN.md
+++ b/Translation/README-EN.md
@@ -108,5 +108,5 @@ Luban.get(this)
limitations under the License.
-Translation: [_Szabolcs Pasztor_](https://github.com/spqpad)
+Translation: [_Szabo... | [
"Translation/README-EN.md"
] | [] | true | ||
Curzibn/Luban | 223 | issue_to_patch | 可不可以增加忽略以什么什么结尾的图片而不压缩呢
比如说我发送的图片集合中包含两张gif动图，而动图压缩后和jpeg一样不能播放了，我尝试了使用代码不去压缩gif动图，但是只发送一张动图的话，就不会走onSuccess()方法，那样就不会发送出去。 | Added compression switch for each one of all images | Fixed [#194](https://github.com/Curzibn/Luban/issues/194)
Do not compress image file that suffix is ".gif" or use other strategy when the developer has been specified.
Sample code
And
![image](ht... | c44552bb0c62357402a3b5f1ca8bc61b0b3c1359 | bde2b3e4b37c93c07a4dc8bda218e34b19cdc7fe | diff --git a/library/src/main/java/top/zibin/luban/CompressionPredicate.java b/library/src/main/java/top/zibin/luban/CompressionPredicate.java
new file mode 100644
index 00000000..7d45bdc7
--- /dev/null
+++ b/library/src/main/java/top/zibin/luban/CompressionPredicate.java
@@ -0,0 +1,19 @@
+package top.zibin.luban;
+
+/... | [
"library/src/main/java/top/zibin/luban/CompressionPredicate.java",
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | |
Curzibn/Luban | 238 | issue_to_patch | 添加获取输入流的接口，以兼容多种文件输入类型 | 为了兼容从FileProvider获取到的文件路径只有Uri的问题 | c44552bb0c62357402a3b5f1ca8bc61b0b3c1359 | b763593017c77ae3236eb04743698eeef4c47bda | diff --git a/library/build.gradle b/library/build.gradle
index fc8e4423..9a2fb04c 100644
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -31,4 +31,5 @@ dependencies {
compile fileTree(dir: 'libs', include: ['*.jar'])
testCompile 'junit:junit:4.12'
compile 'com.android.support:appcompat-v7:25.3.1... | [
"library/build.gradle",
"library/src/main/java/top/zibin/luban/Engine.java",
"library/src/main/java/top/zibin/luban/InputStreamProvider.java",
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | ||
Curzibn/Luban | 193 | issue_to_patch | 建议这里给一个回调 | 这里失败没回调 | 42114e0ef9e5d9e2d562522a17647946df35ba93 | 204275f3b236f0f3f287243cccc3492ecaca18d7 | diff --git a/library/src/main/java/top/zibin/luban/Luban.java b/library/src/main/java/top/zibin/luban/Luban.java
index c68348ff..0e9794ca 100644
--- a/library/src/main/java/top/zibin/luban/Luban.java
+++ b/library/src/main/java/top/zibin/luban/Luban.java
@@ -133,7 +133,7 @@ private File getImageCacheDir(Context context... | [
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | ||
Curzibn/Luban | 82 | issue_to_patch | recycle bitmap | 因为在尝试用Luban压缩图片的时候，看到内存占用上涨，压缩完成之后没有释放，最后发现可能是bitmap没有recycle的原因，所以提了这个PR。 | ec9290a7336dca2a51bf3aece23d9309683afa6c | 2e1dfb9f43aed05f7faddc6694e58431b4d743f1 | diff --git a/library/src/main/java/top/zibin/luban/Luban.java b/library/src/main/java/top/zibin/luban/Luban.java
index adc3df1a..130f9e9d 100644
--- a/library/src/main/java/top/zibin/luban/Luban.java
+++ b/library/src/main/java/top/zibin/luban/Luban.java
@@ -449,12 +449,14 @@ private File saveImage(String filePath, Bit... | [
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | ||
Curzibn/Luban | 36 | issue_to_patch | improve docs format | 75ae21b154e28a7b4402aafec0b23220827eff98 | 013dad509f3851c3200d9992f5a8e7ac27197201 | diff --git a/DESCRIPTION.md b/DESCRIPTION.md
index 0de1e9ed..93ae12ac 100644
--- a/DESCRIPTION.md
+++ b/DESCRIPTION.md
@@ -1,37 +1,34 @@
-#前言
-Luban 是图片压缩工具，通过参考或者自创压缩规则推求极致的压缩效果
+# 前言
+
+`Luban`是图片压缩工具，通过参考或者自创压缩规则推求极致的压缩效果
目前的版本压缩效果主要参考微信。因为微信用户量最大，如果压缩后的图片越接近微信则越被用户接受。
-#说明
-目前的 Luban 只是压缩结果接近微信，自身的算法只是为了... | [
"DESCRIPTION.md",
"README.md",
"Translation/README-EN.md"
] | [] | true | |||
Curzibn/Luban | 58 | issue_to_patch | 去掉library中application的声明，否则application的属性不同时将产生冲突，导致编译错误 | 去掉library中application的声明，否则application的属性不同时将产生冲突，导致编译错误
| a79f4421926f0e5d3618222bf27190ae0372a5b1 | ed76969650333503658e377b7c62af5fb2604019 | diff --git a/library/src/main/AndroidManifest.xml b/library/src/main/AndroidManifest.xml
index 2483e058..9a531973 100644
--- a/library/src/main/AndroidManifest.xml
+++ b/library/src/main/AndroidManifest.xml
@@ -1,8 +1,3 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="top.zibin.luban">
... | [
"library/src/main/AndroidManifest.xml"
] | [] | true | ||
Curzibn/Luban | 49 | issue_to_patch | #48 setFilename rather than full path | 原先的setFilename必须要设定文件的全路径，而不是只要赋文件名就可以
| 1aa56188c32bfe1d957f04f7b697ae780ec3adf1 | 338d92fefaa2c668f112a57365e6af94e5cf6ee1 | diff --git a/library/src/main/java/top/zibin/luban/Luban.java b/library/src/main/java/top/zibin/luban/Luban.java
index c46a835b..27a2563e 100644
--- a/library/src/main/java/top/zibin/luban/Luban.java
+++ b/library/src/main/java/top/zibin/luban/Luban.java
@@ -6,6 +6,7 @@
import android.graphics.Matrix;
import android.... | [
"library/src/main/java/top/zibin/luban/Luban.java"
] | [] | true | ||
Curzibn/Luban | 32 | issue_to_patch | Reorganize readmes with links (translation folder) | 8bc9ffc4b8e4a3b6101a74c0afea81bbd267b318 | c86e2ba49ec2e451c85eaddfc6c871781f972038 | diff --git a/README-ZH.md b/README.md
similarity index 98%
rename from README-ZH.md
rename to README.md
index 07320127..03f3e5bb 100644
--- a/README-ZH.md
+++ b/README.md
@@ -1,5 +1,8 @@
# Luban
+[English](/Translation/README-EN.md) | 中文
+<p>
Luban(鲁班)——Android图片压缩工具，仿微信朋友圈压缩策略
+</p>
#项目描述
@@ -89,3 +92,6 @@ RxJa... | [
"README.md",
"Translation/README-EN.md"
] | [] | true | |||
Curzibn/Luban | 28 | issue_to_patch | README translated into English | 17df32757ed90f9359fb0785555bf51d96e22224 | db598954c9f34069c112602cc7170d95d1fdb530 | diff --git a/README-EN.md b/README-EN.md
new file mode 100644
index 00000000..dc52442e
--- /dev/null
+++ b/README-EN.md
@@ -0,0 +1,91 @@
+# Intro
+Luban is an image compressing tool for android with efficacy very close to that of WeChat Moments.
+
+# Description
+With mobile development, showing images in an app has be... | [
"README-EN.md",
"README-ZH.md"
] | [] | true | |||
Cysharp/UniTask | 715 | issue_to_patch | ci: use OIDC for NuGet package push authentication | This updates the build-release workflow to leverage OpenID Connect (OIDC) for authenticating with NuGet.org. The package push operation is now performed directly within the build job, replacing static API key usage with ephemeral credentials for enhanced security.
| 2e993ff18f28c931602a07292df0b0804eebef99 | b0d26bebea48a861a1449cdf169a90e1e80d1ef3 | diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
index 94d8d7ef..74b69951 100644
--- a/.github/workflows/build-release.yaml
+++ b/.github/workflows/build-release.yaml
@@ -35,10 +35,10 @@ jobs:
with:
ref: ${{ needs.update-packagejson.outputs.sha }}
- use... | [
".github/workflows/build-release.yaml"
] | [
{
"comment": "The comment claims this pack step will create a `.symbols.nupkg`, but this SDK-style project (Microsoft.NET.Sdk) will produce a `.snupkg` when `IncludeSymbols=true` unless `SymbolPackageFormat` is set. Update the comment to reflect the actual output or set `-p:SymbolPackageFormat=symbols.nupkg` to... | true | ||
Cysharp/UniTask | 715 | comment_to_fix | ci: use OIDC for NuGet package push authentication | The comment claims this pack step will create a `.symbols.nupkg`, but this SDK-style project (Microsoft.NET.Sdk) will produce a `.snupkg` when `IncludeSymbols=true` unless `SymbolPackageFormat` is set. Update the comment to reflect the actual output or set `-p:SymbolPackageFormat=symbols.nupkg` to match the comment.
T... | 2e993ff18f28c931602a07292df0b0804eebef99 | b0d26bebea48a861a1449cdf169a90e1e80d1ef3 | diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
index 94d8d7ef..74b69951 100644
--- a/.github/workflows/build-release.yaml
+++ b/.github/workflows/build-release.yaml
@@ -35,10 +35,10 @@ jobs:
with:
ref: ${{ needs.update-packagejson.outputs.sha }}
- use... | [
".github/workflows/build-release.yaml"
] | [
{
"comment": "The comment claims this pack step will create a `.symbols.nupkg`, but this SDK-style project (Microsoft.NET.Sdk) will produce a `.snupkg` when `IncludeSymbols=true` unless `SymbolPackageFormat` is set. Update the comment to reflect the actual output or set `-p:SymbolPackageFormat=symbols.nupkg` to... | true | ||
Cysharp/UniTask | 715 | comment_to_fix | ci: use OIDC for NuGet package push authentication | The NuGet OIDC login step runs even when `inputs.dry-run` is true (only the push step is gated). Consider adding the same `if: ${{ !inputs.dry-run }}` to the login step (and/or the whole publish job) to avoid unnecessary token issuance and dependence on `secrets.NUGET_USER` during dry runs. | 2e993ff18f28c931602a07292df0b0804eebef99 | b0d26bebea48a861a1449cdf169a90e1e80d1ef3 | diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
index 94d8d7ef..74b69951 100644
--- a/.github/workflows/build-release.yaml
+++ b/.github/workflows/build-release.yaml
@@ -35,10 +35,10 @@ jobs:
with:
ref: ${{ needs.update-packagejson.outputs.sha }}
- use... | [
".github/workflows/build-release.yaml"
] | [
{
"comment": "The NuGet OIDC login step runs even when `inputs.dry-run` is true (only the push step is gated). Consider adding the same `if: ${{ !inputs.dry-run }}` to the login step (and/or the whole publish job) to avoid unnecessary token issuance and dependence on `secrets.NUGET_USER` during dry runs.",
... | true | ||
Cysharp/UniTask | 715 | comment_to_fix | ci: use OIDC for NuGet package push authentication | PR description says the package push is performed “directly within the build job”, but the workflow introduces a separate `publish` job for the NuGet push. Please update the PR description (or adjust the workflow) so the documentation matches the actual implementation. | 2e993ff18f28c931602a07292df0b0804eebef99 | b0d26bebea48a861a1449cdf169a90e1e80d1ef3 | diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
index 94d8d7ef..74b69951 100644
--- a/.github/workflows/build-release.yaml
+++ b/.github/workflows/build-release.yaml
@@ -35,10 +35,10 @@ jobs:
with:
ref: ${{ needs.update-packagejson.outputs.sha }}
- use... | [
".github/workflows/build-release.yaml"
] | [
{
"comment": "PR description says the package push is performed “directly within the build job”, but the workflow introduces a separate `publish` job for the NuGet push. Please update the PR description (or adjust the workflow) so the documentation matches the actual implementation.",
"path": ".github/workf... | true | ||
Cysharp/UniTask | 706 | issue_to_patch | fix: resolve TreeView deprecation in Unity 6.2+ | ## Description
Unity 6 (6000.2) has deprecated the non-generic `TreeView`, `TreeViewItem`, and `TreeViewState` classes in `UnityEditor.IMGUI.Controls`.
* **Unity 6000.2+**: Triggers obsolete warnings (**CS0618**).
* **Unity 6000.5+**: Triggers obsolete compiler errors (**CS0619**).
### Solution
Introduce... | a9e27c03d411d2fca01cc7410c24c97cd77cb539 | 0d304f1feb336a8348011c5f8a171f32634b3069 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Editor/UniTaskTrackerTreeView.cs b/src/UniTask/Assets/Plugins/UniTask/Editor/UniTaskTrackerTreeView.cs
index e7b62692..7c124423 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Editor/UniTaskTrackerTreeView.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Editor/UniTaskTrackerT... | [
"src/UniTask/Assets/Plugins/UniTask/Editor/UniTaskTrackerTreeView.cs"
] | [] | true | ||
Cysharp/UniTask | 680 | issue_to_patch | ci: add id-token: write for NuGet Trusted Publish | ## Summary
This PR enables `build-release.yaml` to publish NuGet packages via [NuGet Trusted Publish](https://devblogs.microsoft.com/dotnet/enhanced-security-is-here-with-the-new-trust-publishing-on-nuget-org/).
This means we no longer depend on a Personal Access Token (PAT) to publish .nupkg packages. | ec9204d381eb406a8f6e68fd67429a96ca6c5322 | 30bec5d5c4902668e5822a11305cfa21203fe7c1 | diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
index 258242d8..94d8d7ef 100644
--- a/.github/workflows/build-release.yaml
+++ b/.github/workflows/build-release.yaml
@@ -101,6 +101,7 @@ jobs:
needs: [update-packagejson, build-dotnet, build-unity]
permissions:
co... | [
".github/workflows/build-release.yaml"
] | [] | true | ||
Cysharp/UniTask | 679 | issue_to_patch | chore: Specify IsPackable=false on Directory.Build.props, explicitly true for target packages. | ## Summary
Change IsPackable from default, implicitly `true`, to explicitly `false`.
This prevent unintended nuget package generation like sandbox, benchmark, and etc....
Side effect:
- nupkg csproj required to specify `<IsPackable>true</IsPackable>`. Previously they are omitted.
- LICENSE.md is now handled by Direc... | 98538ef7c7a22f4ec22101e72f7eec4ed831c724 | 9a6584ff0d3ee86c4f47698997cb5d607c3ca151 | diff --git a/.gitignore b/.gitignore
index 105e2fca..ff66065c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -100,7 +100,19 @@ publish
*.Publish.xml
# NuGet Packages Directory
-packages
+*.nupkg
+# NuGet Symbol Packages
+*.snupkg
+# The packages folder can be ignored because of Package Restore
+# packages # upm pacakg... | [
".gitignore",
"Directory.Build.props",
"opensource.snk",
"src/UniTask.Analyzer/UniTask.Analyzer.csproj",
"src/UniTask.NetCore/UniTask.NetCore.csproj",
"src/UniTask.NetCoreSandbox/UniTask.NetCoreSandbox.csproj",
"src/UniTask.NetCoreTests/UniTask.NetCoreTests.csproj"
] | [] | true | ||
Cysharp/UniTask | 677 | issue_to_patch | ci: replace docfx build from container to docfx command | ## Description
The current docfx build using containers is failing ([example build log](https://github.com/Cysharp/UniTask/actions/runs/17602389494)), and this cannot be resolved from the user side. Let's change the documentation build process to use the [docfx .NET tool](https://github.com/dotnet/docfx) instead.
... | 95998ff3f2d8011da67c7b9ba0c75a57af5f6b26 | 519590ca6e3f42355e12977ae62c538fa9d793c5 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
new file mode 100644
index 00000000..a83f0a32
--- /dev/null
+++ b/.config/dotnet-tools.json
@@ -0,0 +1,13 @@
+{
+ "version": 1,
+ "isRoot": true,
+ "tools": {
+ "docfx": {
+ "version": "2.78.3",
+ "commands": [
+ "docfx"
+ ],... | [
".config/dotnet-tools.json",
".github/workflows/build-docs.yaml",
"docs/docfx.json"
] | [] | true | ||
Cysharp/UniTask | 672 | issue_to_patch | chore: add README.md to nuget package | f213ff497e4ff462a77319cf677cf20cc0860ca9 | 40e020fb02c8cd3e67c6649a73eff107ba5aa1ef | diff --git a/.github/workflows/build-debug.yaml b/.github/workflows/build-debug.yaml
index 3dd99704..0422c131 100644
--- a/.github/workflows/build-debug.yaml
+++ b/.github/workflows/build-debug.yaml
@@ -17,8 +17,9 @@ jobs:
steps:
- uses: Cysharp/Actions/.github/actions/checkout@main
- uses: Cysharp/A... | [
".github/workflows/build-debug.yaml",
"Directory.Build.props",
"Icon.png",
"src/UniTask.NetCore/UniTask.NetCore.csproj"
] | [] | true | |||
Cysharp/UniTask | 654 | issue_to_patch | ci: Pinning third party GitHub Actions sha | ## tl;dr;
Follow to the GitHub recommendation pinning third party actions sha. | cc3c70af90d4edbe5bf448fe3747545ca40ec45a | 70eb7cd3ee1437550ef41675d30936134a1aa6c6 | diff --git a/.github/dependabot.yaml b/.github/dependabot.yaml
index 00aea0a7..63b36f3d 100644
--- a/.github/dependabot.yaml
+++ b/.github/dependabot.yaml
@@ -5,3 +5,8 @@ updates:
directory: "/"
schedule:
interval: "weekly" # Check for updates to GitHub Actions every week
+ ignore:
+ # I just w... | [
".github/dependabot.yaml",
".github/workflows/build-debug.yml",
".github/workflows/build-docs.yml",
".github/workflows/build-release.yml",
".github/workflows/toc.yml"
] | [] | true | ||
Cysharp/UniTask | 619 | issue_to_patch | Add overload in UniTask.WaitUntil, UniTask.WaitWhile and UniTask.Defer | #562 | 83d8a2b424a2ee7137f8671770e9acb2b9d325f0 | 06283f0ffb0d9531815dadf049ac3578d4430e97 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
index bd66aba8..8d4f0c5d 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
@@ -202,6 +20... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.WaitUntil.cs",
"src/UniTask/Assets/Tests/AsyncTest.cs"
] | [] | diff --git a/src/UniTask/Assets/Tests/AsyncTest.cs b/src/UniTask/Assets/Tests/AsyncTest.cs
index 3cd98a39..29645daf 100644
--- a/src/UniTask/Assets/Tests/AsyncTest.cs
+++ b/src/UniTask/Assets/Tests/AsyncTest.cs
@@ -145,6 +145,11 @@ class MyMyClass
public int MyProperty { get; set; }
}
+ c... | true | |
Cysharp/UniTask | 641 | issue_to_patch | Update README_CN.md | Re-translated the documentation.
1. Supplemented the previously leftover untranslated parts.
2. Rectified the translation mistakes.
3. Eliminated the traces of machine translation and made it more in line with the Chinese language context.
4. Optimized the text typesetting and layout when Chinese and English are us... | bdf102f145383dc6f64479183571a1a59e031bfb | 7a63ab70886b435451f88ce354720266ef248765 | diff --git a/README_CN.md b/README_CN.md
index 8001ee05..bbf76c71 100644
--- a/README_CN.md
+++ b/README_CN.md
@@ -2,28 +2,27 @@ UniTask
===
[](https://github.com/Cysharp/UniTask/actions) [![Releases](https://img.shields.io/github/re... | [
"README_CN.md"
] | [] | true | ||
Cysharp/UniTask | 639 | issue_to_patch | Update README_CN.md | f9fd769be7c634610f2a61aa914a1a55f34740e1 | 41cea030abdc1889e20c6ea8d908da7b81b4df9b | diff --git a/README_CN.md b/README_CN.md
index fc12fbe2..8001ee05 100644
--- a/README_CN.md
+++ b/README_CN.md
@@ -6,14 +6,15 @@ UniTask
- 基于值类型的`UniTask<T>`和自定义的 AsyncMethodBuilder 来实现0GC
- 使所有 Unity 的 AsyncOperations 和 Coroutines 可等待
-- 基于 PlayerLoop 的任务( `UniTask.Yield`, `UniTask.Delay`, `UniTask.DelayFrame`, et... | [
"README_CN.md"
] | [] | true | |||
Cysharp/UniTask | 623 | issue_to_patch | ci: remove Unity 2021 LTS from Build matrix | ## tl;dr;
To speed up CI, and 2021 LTS will end support when Unity 6 released, later 2024. (Officially already end but currently [extending](https://unity.com/blog/unity-2021-long-term-support-extended?ref=dailydev)) | 5984b67ecb857310d4a3f204f6b827e70c07779d | eaa553dc8390d2eafe1c86c5c9db3683732943c5 | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index e3bd6a6b..09bd3f87 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -24,7 +24,7 @@ jobs:
fail-fast: false
max-parallel: 2
matrix:
- unity: ["2021.3.41f1", "2022.3... | [
".github/workflows/build-debug.yml"
] | [] | true | ||
Cysharp/UniTask | 621 | issue_to_patch | add generic type UnityAction support & fix typo | #564
#619 | 2e0917428bc49a88f8bb90f3cbdeabd4d978ae30 | a51632cd4b2512e7f14e89e5ffcf91dd3bf742d8 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
index 8d4f0c5d..8bdec75f 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
@@ -184,6 +18... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs",
"src/UniTask/Assets/Tests/AsyncTest.cs"
] | [] | diff --git a/src/UniTask/Assets/Tests/AsyncTest.cs b/src/UniTask/Assets/Tests/AsyncTest.cs
index 29645daf..2f07d1e0 100644
--- a/src/UniTask/Assets/Tests/AsyncTest.cs
+++ b/src/UniTask/Assets/Tests/AsyncTest.cs
@@ -145,7 +145,7 @@ class MyMyClass
public int MyProperty { get; set; }
}
- cl... | true | |
Cysharp/UniTask | 620 | issue_to_patch | Added a note for users using Unity 2023.1 or newer to prevent compilation error | As stated in the note: When using Unity 2023.1 or newer, ensure you have `using UnityEngine;` in the using statements of your file when working with new `UnityEngine.Awaitable` methods like `SceneManager.LoadSceneAsync`. This prevents compilation errors by avoiding the use of the `UnityEngine.AsyncOperation` version.
... | 74bbe87b58a727021ab0d6593b4b4816d26f307c | 0b16005f4becb47c2ca06a6c8e2db976c93e1a23 | diff --git a/README.md b/README.md
index c6eb4469..277c0c62 100644
--- a/README.md
+++ b/README.md
@@ -526,6 +526,9 @@ It indicates when to run, you can check [PlayerLoopList.md](https://gist.github.
In UniTask, await directly uses native timing, while `WithCancellation` and `ToUniTask` use specified timing. This is... | [
"README.md"
] | [] | true | ||
Cysharp/UniTask | 600 | issue_to_patch | TextMeshPro Unity6 adoptions | Since Unity 6 / com.unity.ugui 2.0, TextMeshPro was merged into the ugui package.
This PR extends the UniTask.TextMeshPro.asmdef to still activate 'UNITASK_TEXTMESHPRO_SUPPORT' | cdf88c6a6ac8c9b7e6e5d3c0a360a4af29641c24 | 8d98bbc7ba39c4d6b3c23749f1d7814c73c615d9 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/TextMeshPro/UniTask.TextMeshPro.asmdef b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/TextMeshPro/UniTask.TextMeshPro.asmdef
index 6bb01d7f..3ac90fb7 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/TextMeshPro/UniTask.TextMeshPro.a... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/TextMeshPro/UniTask.TextMeshPro.asmdef"
] | [] | true | ||
Cysharp/UniTask | 610 | issue_to_patch | Forget ignored task | I believe that the UniTask extension method AttachExternalCancellation should call task forget method when the cancellation token has already requested. | 9057452c86079e4265228480b1439442894d5078 | e0465c6c2c69ca8dc28c49991ae6c9bf42349d3e | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
index 1e4faa1e..51555679 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
@@ -2... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs"
] | [] | true | ||
Cysharp/UniTask | 607 | issue_to_patch | fix: incorrect download progress reporting | f057abff0f4ea52e4c9699c2831808d6c0a27bcc | a2f6f84bde4476734eea5af25c9901cc5d2427c2 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs
index ee1a9e6c..acf9f599 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/Addressabl... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs"
] | [] | true | |||
Cysharp/UniTask | 605 | issue_to_patch | chore(deps): bump peaceiris/actions-gh-pages from 3 to 4 | Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peaceiris/actions-gh-pages/releases">peaceiris/actions-gh-pages's releases</a>.</em></p>
<blockquote>
<h2>actions-github-pages v4.0.0<... | e52663cef6f0c869f3519a1ba4b7cca0697d9ce8 | 4fc41ecb17c8f4de33deb6dc0dd51265507cd6ea | diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml
index be5c4b95..09ad0e38 100644
--- a/.github/workflows/build-docs.yml
+++ b/.github/workflows/build-docs.yml
@@ -25,7 +25,7 @@ jobs:
with:
args: build docs/docfx.json
- name: Publish to GitHub Pages
- use... | [
".github/workflows/build-docs.yml"
] | [] | true | ||
Cysharp/UniTask | 606 | issue_to_patch | chore(deps): bump technote-space/toc-generator from 2.4.0 to 4.3.1 | Bumps [technote-space/toc-generator](https://github.com/technote-space/toc-generator) from 2.4.0 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/technote-space/toc-generator/releases">technote-space/toc-generator's releases</a>.</em></p>
<blockquote>
<h2>v4.3.1</h2>
... | e52663cef6f0c869f3519a1ba4b7cca0697d9ce8 | b2532b07983b3bb7406b625293dcc0c8028220cc | diff --git a/.github/workflows/toc.yml b/.github/workflows/toc.yml
index f7519c3d..0f2c6750 100644
--- a/.github/workflows/toc.yml
+++ b/.github/workflows/toc.yml
@@ -10,6 +10,6 @@ jobs:
name: TOC Generator
runs-on: ubuntu-latest
steps:
- - uses: technote-space/toc-generator@v2.4.0
+ - uses: te... | [
".github/workflows/toc.yml"
] | [] | true | ||
Cysharp/UniTask | 570 | issue_to_patch | ci: add depndabot.yaml to update github-actions | ## tl;dr;
Automate suggestion for update GitHub Actions.
## Motivation
Important actions are centrally managed on Cysharp/Actions, however few pieces of direct actions usage is managed by own repo.
Let's use dependabot to manage repo's actions version update strategy. | 88ecfa2992d4f7247aaad0322921aa3fb929aeee | 3b3f7ebd3e75008be014b8b1ab7ee20697885b8c | diff --git a/.github/dependabot.yaml b/.github/dependabot.yaml
new file mode 100644
index 00000000..00aea0a7
--- /dev/null
+++ b/.github/dependabot.yaml
@@ -0,0 +1,7 @@
+# ref: https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
+version: 2
+update... | [
".github/dependabot.yaml"
] | [] | true | ||
Cysharp/UniTask | 603 | issue_to_patch | ci: Change Unity UnitTest from Mono to IL2CPP and enabled on CI | ## tl;dr;
Previously Unity's Unit Test was commented out due to Unity Healess (DedicatedServer) API change was unstable. I've confirm it's stable now and re-enable on GitHub Actions.
To Run UnitTest IL2CPP.
* Bump Unity version from 2020.2.1f1 to 2022.3.39f1. (LTS)
* Change Unity versions running on matrix to... | cdf88c6a6ac8c9b7e6e5d3c0a360a4af29641c24 | 8560561ef301f72c9b894e5e858388e83883ae31 | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index f6e4ba7d..d36e1eb4 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- - uses: actions/checkout@v3
+... | [
".github/workflows/build-debug.yml",
".github/workflows/build-docs.yml",
".github/workflows/build-release.yml",
".gitignore",
"src/UniTask/Assets/RuntimeUnitTestToolkit.meta",
"src/UniTask/Assets/RuntimeUnitTestToolkit/Editor.meta",
"src/UniTask/Assets/RuntimeUnitTestToolkit/Editor/HierarchyTreeBuilder.... | [] | diff --git a/src/UniTask/Assets/Tests/Resources/sample_texture.png.meta b/src/UniTask/Assets/Tests/Resources/sample_texture.png.meta
index 15a1de57..85d79c76 100644
--- a/src/UniTask/Assets/Tests/Resources/sample_texture.png.meta
+++ b/src/UniTask/Assets/Tests/Resources/sample_texture.png.meta
@@ -12,7 +12,7 @@ Texture... | true | |
Cysharp/UniTask | 599 | issue_to_patch | OnEndTextSelectionAsAsyncEnumerable The requested operation caused a stack overflow.
When using "onTextSelection" or "onEndTextSelection" , recursive calls will occur, eventually leading to stack overflow.
>
m_InputField.OnEndTextSelectionAsAsyncEnumerable().ForEachAwaitAsync(async (x) =... | Fix onTextSelection and onEndTextSelection stack overflow issue | Fix [https://github.com/Cysharp/UniTask/issues/598](https://github.com/Cysharp/UniTask/issues/598) | fbe0bf85155f42f8832205f7b3ac3df571ada33e | 222b1401f5406ef23e74d5c790447c9f64c09127 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAsyncExtensions.uGUI.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAsyncExtensions.uGUI.cs
index 7f1a90c7..e1b11fe0 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAsyncExtensions.uGUI.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/Un... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAsyncExtensions.uGUI.cs"
] | [] | true | |
Cysharp/UniTask | 579 | issue_to_patch | ci: change upload-artifact & download-artifact to Cysharp/Actions | ## tl;dr;
To handle actions/upload-artifact & download-artifact version consistency, manage actions version via Central Maanged Cysharp/Actions.
| 2e225fb8414e023df2aa3acae2ef225471981316 | 626685292c5ed3315cd3cae4043d43862eeb3805 | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index b09439e4..f6e4ba7d 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -74,7 +74,8 @@ jobs:
directory: src/UniTask
# Store artifacts.
- - uses: actions/upload-artifact@... | [
".github/workflows/build-debug.yml",
".github/workflows/build-release.yml"
] | [] | true | ||
Cysharp/UniTask | 571 | issue_to_patch | feat: change load secret from op | ## tl;dr;
Change secret management to op. | 88ecfa2992d4f7247aaad0322921aa3fb929aeee | 935523f25cbddf651c70eff3dfe28836c197132f | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index e03ce3fe..b09439e4 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -19,22 +19,33 @@ jobs:
- run: dotnet test -c Debug
build-unity:
- if: "((github.event_name == 'push' && git... | [
".github/workflows/build-debug.yml",
".github/workflows/build-release.yml"
] | [] | true | ||
Cysharp/UniTask | 538 | issue_to_patch | Factory method allowed argument | I think it would be useful if there were.
As for methods with return values, we did not implement them, judging that they are used infrequently due to the trouble of setting the types of both the argument and the return value. | d057074f177b078e29f10dd511b54df48a8806ea | 28867646b0c65bce6550535950a635f6be8e1c03 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
index 2f6a6a9e..bd66aba8 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs
@@ -81,6 +81,... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Factory.cs"
] | [] | true | ||
Cysharp/UniTask | 557 | issue_to_patch | Fix unintended returning to pool with cancelImmediately | #553
## Problem
It was a cancelImmediately issue.
1. When cancelImmediately is cancelled, the object is returned to the object pool immediately,
2. MoveNext in the Player Loop is still running even after it is returned to the pool.
3. if we enter MoveNext in the initialized state, it would probably stop immed... | 01c8fada1f4d48465f7ef31b46b150d4f6e428aa | 938ddd5356780409370adce47eefdf44941abd99 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs
index 620cfadc..ee1a9e6c 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/Addressabl... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Delay.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.WaitUntil.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAsyncExtensions.AssetBundleReque... | [] | true | ||
Cysharp/UniTask | 542 | issue_to_patch | ci: Cysharp/Actions/.github/workflows/create-release.yaml | ## tl;dr;
Replace create-release with `Cysharp/Actions/.github/workflows/create-release.yaml`.
This brings central managed release flow control.
see: https://github.com/Cysharp/UniTask/actions/runs/7814464098 | 809d23edae0df58fd0f61b4b6f67855c59d1b2fb | 10cd13712664e2d3feff2b7ed8dde344cdebc75e | diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml
index 13183a1b..10b0549b 100644
--- a/.github/workflows/build-release.yml
+++ b/.github/workflows/build-release.yml
@@ -12,17 +12,13 @@ on:
default: false
type: boolean
-env:
- GIT_TAG: ${{ github.event.inputs.ta... | [
".github/workflows/build-release.yml"
] | [] | true | ||
Cysharp/UniTask | 541 | issue_to_patch | Optimization of ToArray in Merge method | If IEnumerable<T> is an array, unnecessary ToArray calls are no longer made. | 64792b672d35e43b3412fc74861f8bdbf41e3a6f | d38731bc44706fbbbc605080a3f725ce6bc4c06e | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs
index d4ea969a..b74bf252 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs
@@ -27,7 +27,9 @@ public static I... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs"
] | [] | true | ||
Cysharp/UniTask | 535 | issue_to_patch | UniTask does not work in .NET Framework environment after adding UniTask.AsValueTask | Probably after #533 was implemented, I started getting the following error in the .NET Framework environment of Unity2021.
> Library\PackageCache\com.cysharp.unitask.........\Runtime\IUniTaskSource.cs(55,41): error CS1961: Invalid variance: The type parameter 'T' must be invariantly valid on 'IValueTaskSource<T>'. '... | fe8bf834e604234c77a13af3e38b07a55c9a18f8 | 9a4720d180f5fd7b23163123c561e490251a82d7 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
index 5ef6112e..c8177b42 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
@@ -19,7 +19,7 @@... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.AsValueTask.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.cs"
] | [] | true | ||
Cysharp/UniTask | 521 | issue_to_patch | Release handle when cancellation is requested | Hi, I would like to release the asset on handle when the cancellation token is requested | 5cc97c7f0085624b6ef57853d70b404440060cef | 36ac0863adc827eb14389f9c91120a6d3d8aa88e | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs
index a0ca8a1f..0f3a25c8 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/Addressabl... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/UniTask.Addressables.asmdef"
] | [
{
"comment": "Syntax error seems to occur due to typo.\r\n\r\n```suggestion\r\n if (handle.IsValid())\r\n```",
"path": "src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs",
"hunk": "@@ -171,6 +172,10 @@ void Continuation(AsyncOperationHa... | true | ||
Cysharp/UniTask | 536 | issue_to_patch | Fix "Release handle when cancellation is requested" | refs: https://github.com/Cysharp/UniTask/pull/521#issuecomment-1909695098
This is a modified version of the PR #521 as commented.
EDIT:
- Add a new `autoReleaseWhenCancelled` flag because `Addressable.Release` would be a breaking change. | fe8bf834e604234c77a13af3e38b07a55c9a18f8 | b99646558c3a144c8a83923c61f9bf45b1a8322c | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs
index a0ca8a1f..656e833d 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/Addressabl... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/UniTask.Addressables.asmdef"
] | [] | true | ||
Cysharp/UniTask | 533 | issue_to_patch | Adding ValueTask.AsUniTask() and UniTask.AsValueTask() for Unity
`UniTask.AsValueTask.cs` is implemented only for .NET Core.
https://github.com/Cysharp/UniTask/blob/66de0d3a58b256b6e0194f285cc530fd0c08407b/src/UniTask.NetCore/NetCore/UniTask.AsValueTask.cs
I would like to use the same extension method for Unity.
... | add UniTask.AsValueTask for Unity | close #532
I moved `src/UniTask.NetCore/NetCore/UniTask.AsValueTask.cs` to `src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.AsValueTask.cs` and made some changes.
I confirmed that the extension method works in Unity 2021.3 .NET Standard 2.1 and `UniTask.NetCoreTests` test was successful.
I am not sure if thi... | 66de0d3a58b256b6e0194f285cc530fd0c08407b | 4fe0861714b251c691ddcb9b4d7a9c3c051157df | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
index 88147811..5ef6112e 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs
@@ -19,7 +19,7 @@... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/IUniTaskSource.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.AsValueTask.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.AsValueTask.cs.meta",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.cs"
] | [] | true | |
Cysharp/UniTask | 519 | issue_to_patch | Use Cysharp/Actions/setup-dotnet default version | ## tl;dr;
It support both .NET 6,7 and 8. No need specify version. | 5cc97c7f0085624b6ef57853d70b404440060cef | 104f8e09ca46d24f737e7f2f253d07946d5ad42c | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index 5a7eb3aa..e03ce3fe 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -15,10 +15,6 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: Cysharp/Actions/.github/actions/setup-... | [
".github/workflows/build-debug.yml",
".github/workflows/build-release.yml"
] | [] | true | ||
Cysharp/UniTask | 524 | issue_to_patch | Fixed typo in TimeoutWithoutException summary. | ### Changes
- Fixed a minor typo in the method summary of `TimeoutWithoutException` in `UniTaskExtensions`.
| 5cc97c7f0085624b6ef57853d70b404440060cef | d60f64761bc167557568b7f733bb5107d8a00f91 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
index 362da525..1e4faa1e 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs
@@ -4... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs"
] | [] | true | ||
Cysharp/UniTask | 518 | issue_to_patch | Add Awaitable.AsUniTask() | 6f5d81854456a351ff99a5d8dca85d49cf6f6a0d | 5f3aa18f38804bdd4c22ced512405329effd32bc | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAwaitableExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAwaitableExtensions.cs
new file mode 100644
index 00000000..4580da3a
--- /dev/null
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAwaitableExtensions.cs
@@ -0,0 +1,17 @@
+#if UNIT... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAwaitableExtensions.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UnityAwaitableExtensions.cs.meta"
] | [] | true | |||
Cysharp/UniTask | 517 | issue_to_patch | Add a flag to cancel immediately instead of player loop | For awaitable features using PlayerLoop,
Currently, CancellationToken are checked by PlayerLoop.
This pr change this behavior and add an option such that cancellations by CancellationToken will fire immediately.
e.g)
```csharp
UnitTask.Yield(cancellationToken, cancelImmediately: true)
```
List of methods wi... | 6f5d81854456a351ff99a5d8dca85d49cf6f6a0d | ad23f7fb29b8c706dd8acc1b7858cdd4968ce7b4 | diff --git a/README.md b/README.md
index 487aec09..d1cacac9 100644
--- a/README.md
+++ b/README.md
@@ -336,6 +336,18 @@ if (isCanceled)
Note: Only suppress throws if you call directly into the most source method. Otherwise, the return value will be converted, but the entire pipeline will not suppress throws.
+Some... | [
"README.md",
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/Addressables/AddressablesAsyncExtensions.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/UnityExtensions/EveryUpdate.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/UnityExtensions/EveryValueChanged.cs",
"src/UniTask/Assets/Plugin... | [] | diff --git a/src/UniTask/Assets/Tests/AsyncOperationTest.cs b/src/UniTask/Assets/Tests/AsyncOperationTest.cs
new file mode 100644
index 00000000..0eaa1888
--- /dev/null
+++ b/src/UniTask/Assets/Tests/AsyncOperationTest.cs
@@ -0,0 +1,90 @@
+using System.Collections;
+using System.Threading;
+using Cysharp.Threading.Task... | true | |
Cysharp/UniTask | 484 | issue_to_patch | Fix problem with finally in UniTaskAsyncEnumerable.Create not being executed | #438
If await foreach break in the middle, the factory declared in UniTaskAsyncEnumerable.Create(...) is not executed until the end.
```csharp
await foreach (var elem in IterateAsync())
{
Console.WriteLine("elem: " + elem);
break;
}
```
```csharp
static IUniTaskAsyncEnumerable<int> IterateAsy... | d210e3d76adc0cce77f4ad2af1ade88dad6b1d5a | b4486802f2a6555584acd106ebf8d7c064c15037 | diff --git a/src/UniTask.NetCoreTests/Linq/CreateTest.cs b/src/UniTask.NetCoreTests/Linq/CreateTest.cs
index 17ba22f7..e1319eb2 100644
--- a/src/UniTask.NetCoreTests/Linq/CreateTest.cs
+++ b/src/UniTask.NetCoreTests/Linq/CreateTest.cs
@@ -159,6 +159,30 @@ public async Task ASyncManually()
list.Should().Equ... | [
"src/UniTask.NetCoreTests/Linq/CreateTest.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Create.cs"
] | [] | true | ||
Cysharp/UniTask | 515 | issue_to_patch | Fix typo in README.md | cfe509a55602ba5be6df7fa0468b10298b8a053d | 2ccb37cb02ccc860844caf2c85bebccbc35a8a9f | diff --git a/README.md b/README.md
index a27a629c..487aec09 100644
--- a/README.md
+++ b/README.md
@@ -295,7 +295,7 @@ public class MyBehaviour : MonoBehaviour
When cancellation is detected, all methods throw `OperationCanceledException` and propagate upstream. When exception(not limited to `OperationCanceledExcepti... | [
"README.md"
] | [] | true | |||
Cysharp/UniTask | 509 | issue_to_patch | Fix a bug in Dotween after returning to the pool of `CancellationToken.Register` | #508 | 64f7eec4e9e451b07ba0c56a152efaca88b6be17 | 3ed28e534aa0153e320ffc5c85f78168eb449eaf | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs
index 076bed51..ba783672 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs
+++ b/src... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs"
] | [
{
"comment": "> // restore to original callback\r\n\r\nI made this a method (because duplicated). There should be no change in behavior.",
"path": "src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs",
"hunk": "@@ -250,30 +251,7 @@ public static IUniTaskSource Create(... | true | ||
Cysharp/UniTask | 500 | issue_to_patch | Use always innerException for Task.AsUniTask | refs: #422
After #486, There was some further discussion.
> UniTask is a world line like Task when there is only await, so it may be possible to throw away other exceptions to match the behavior of await Task...
So, if `await Task.WhenAll(...).AsUniTask()` throws an exception, always use inner exception just... | c170af5642889b9034b8f910c1a61a4939103ba5 | 90c81613acd9d652644a891bd7fda5eb91b42979 | diff --git a/src/UniTask.NetCoreTests/TaskExtensionsTest.cs b/src/UniTask.NetCoreTests/TaskExtensionsTest.cs
index 39265614..6097bc13 100644
--- a/src/UniTask.NetCoreTests/TaskExtensionsTest.cs
+++ b/src/UniTask.NetCoreTests/TaskExtensionsTest.cs
@@ -20,6 +20,15 @@ await Assert.ThrowsAsync<InvalidOperationException>(as... | [
"src/UniTask.NetCoreTests/TaskExtensionsTest.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs"
] | [] | true | ||
Cysharp/UniTask | 498 | issue_to_patch | Add UniTaskAsyncEnumerable.Merge | #361
Add Merge operator for Async LINQ.
I'm assuming the behavior is something like this:
```
a:
00:00: hello
00:05: world
b:
00:01: foo
00:02: bar
00:06: baz
merge result:
hello
foo
bar
world
baz
```
refs: https://github.com/dotnet/reactive/blob/305d381dcc46c5966e7260e0959b... | 90c5e5a6ade385314c0836dd3bfc240d44159be4 | 3ba64412f8b5f502004892652c4bb7e9b284779d | diff --git a/README.md b/README.md
index 8571cb0e..b0665427 100644
--- a/README.md
+++ b/README.md
@@ -716,7 +716,7 @@ Async LINQ is enabled when `using Cysharp.Threading.Tasks.Linq;`, and `UniTaskAs
It's closer to UniRx (Reactive Extensions), but UniTaskAsyncEnumerable is a pull-based asynchronous stream, whereas R... | [
"README.md",
"src/UniTask.NetCoreTests/Linq/Merge.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Internal/Error.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/Linq/Merge.cs.meta"
] | [] | true | ||
Cysharp/UniTask | 496 | issue_to_patch | Add EndOfFrame implementation using `UnityEngine.Awaitable` | Currently, MonoBehaviour is required to implement EndOfFrame, but Awaitable.EndOfFrameAsync is available from Unity 2023.1.
| c1042b32b7205d1fab2cfb03048dea98af0f20de | ffbadbcc4c94708833e3d7bfe188e7dee76bdfe9 | diff --git a/README.md b/README.md
index ff1bf631..5f4374db 100644
--- a/README.md
+++ b/README.md
@@ -86,8 +86,13 @@ async UniTask<string> DemoAsync()
await UniTask.Yield();
await UniTask.NextFrame();
- // replacement of WaitForEndOfFrame(requires MonoBehaviour(CoroutineRunner))
+ // replacement of W... | [
"README.md",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Delay.cs"
] | [
{
"comment": "I have done a easy implementation that uses `async`.\r\nShould I consider adding Awaitable.ToUniTask()?\r\n\r\n📝 But Awaitable is has so few features that converting it to IUniTaskSource could be inefficient.\r\n",
"path": "src/UniTask/Assets/Plugins/UniTask/Runtime/UniTask.Delay.cs",
"h... | true | ||
Cysharp/UniTask | 499 | issue_to_patch | Fix conditions for UniTaskCompletionSourceCore.TrySet* to be true | About the TrySetResult family of UniTaskCompletionSourceCore,
It is expected that true will be returned if set succeeds. However, if continuation is not set, the return value seems to be false.
I would like to correct this to the expected behavior.
I visually checked :eyes: . the return value was not actually ... | c170af5642889b9034b8f910c1a61a4939103ba5 | 50ad2ee9d626df32a6d8a0fa716f50aa36d81947 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs
index 67b882ee..12f3c26e 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskC... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs"
] | [] | true | ||
Cysharp/UniTask | 503 | issue_to_patch | Add check to that AutoResetUniTaskSource already returned to the pool | #298
AutoResetUniTaskSource is dangerous to use after it has been returned to the pool.
In this case, it should be failed to try set. | c170af5642889b9034b8f910c1a61a4939103ba5 | 4f6344a12fa6caf94e14347dd35065591c2bc28c | diff --git a/src/UniTask.NetCoreTests/UniTaskCompletionSourceTest.cs b/src/UniTask.NetCoreTests/UniTaskCompletionSourceTest.cs
new file mode 100644
index 00000000..1c5b943b
--- /dev/null
+++ b/src/UniTask.NetCoreTests/UniTaskCompletionSourceTest.cs
@@ -0,0 +1,80 @@
+using System.Threading.Tasks;
+using Cysharp.Threadin... | [
"src/UniTask.NetCoreTests/UniTaskCompletionSourceTest.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskCompletionSource.cs"
] | [] | true | ||
Cysharp/UniTask | 489 | issue_to_patch | Earlier intialization for Unitask, depending on unity version | Current Issue:
UniTask is currently initialized during BeforeSceneLoad.
Execution order between multiple BeforeSceneLoad calls is undefined.
=> UniTask can only be used after BeforeSceneLoad
Proposed solution:
Allow unitask to initialize at AfterAssembliesLoaded, so it can be safely used during BeforeSceneLoad.
... | c170af5642889b9034b8f910c1a61a4939103ba5 | 3121903fa3f35daba980a9c602a0fc6aff5f1eea | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/PlayerLoopHelper.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/PlayerLoopHelper.cs
index 538fc011..b17375e7 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/PlayerLoopHelper.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/PlayerLoopHelper.cs
@@ -285,7... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/PlayerLoopHelper.cs"
] | [] | true | ||
Cysharp/UniTask | 487 | issue_to_patch | Fix TriggerEvent problem with iterate breaking on Remove when it has multiple handlers | After merging #445 , TriggerEvent test was broken... 🙏
Problem:
- In `h.Next`, In the loop of `TriggerEvent.SetResult`
- if Remove(h.Next), next is unreliable.
- Also, `.SetCompleted` , `.SetError`, `.SetCancelled` needs to be similar fixes.
Fix:
- If it removes itself, iteratingNode instance variab... | c1042b32b7205d1fab2cfb03048dea98af0f20de | af2e49aa29fc3b61a298ee0bef537e613a34c71a | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/TriggerEvent.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/TriggerEvent.cs
index 503e9db9..0b817fe3 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/TriggerEvent.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/Runtime/TriggerEvent.cs
@@ -20,8 +20,6 @@ public ... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/TriggerEvent.cs"
] | [] | true | ||
Cysharp/UniTask | 492 | issue_to_patch | Update README about DOTween | #390
Fix description of DOTWeen introduction. | c1042b32b7205d1fab2cfb03048dea98af0f20de | e5cc8667acaa4424b0a39a263d37e8c9cfbd2836 | diff --git a/README.md b/README.md
index ff1bf631..8571cb0e 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,3 @@
-UniTask
===
[](https://github.com/Cysharp/UniTask/actions) [![Releases](https://img.shields.io/github/release/Cysharp... | [
"README.md",
"README_CN.md"
] | [] | true | ||
Cysharp/UniTask | 493 | issue_to_patch | Reduce the times of AwakeMonitor checking | #435 | c1042b32b7205d1fab2cfb03048dea98af0f20de | a7a6af0a68d6482dc6728a9be4805b7f5cb85900 | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/Triggers/AsyncDestroyTrigger.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/Triggers/AsyncDestroyTrigger.cs
index 811f9770..77c92859 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/Triggers/AsyncDestroyTrigger.cs
+++ b/src/UniTask/Assets/Plugins/UniTask/R... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/Triggers/AsyncDestroyTrigger.cs"
] | [] | true | ||
Cysharp/UniTask | 486 | issue_to_patch | Use innerException for `Task.AsUniTask` | #422 #428
The problem is that if Task.AsUniTask throws an exception, it becomes an AggregateException.
It seems that there is a historical reason why Task holds AggregateException internally.
We have fixed it as such, as supplementing InnerException is probably sufficient in most cases.
| 4c3d6938edef1ebc4d8c0fb5b9245cd3d219d45e | bc27f6c0d81d676316d5af666b1f5b4d3e469411 | diff --git a/src/UniTask.NetCoreTests/TaskExtensionsTest.cs b/src/UniTask.NetCoreTests/TaskExtensionsTest.cs
new file mode 100644
index 00000000..39265614
--- /dev/null
+++ b/src/UniTask.NetCoreTests/TaskExtensionsTest.cs
@@ -0,0 +1,34 @@
+using System;
+using System.Threading.Tasks;
+using Cysharp.Threading.Tasks;
+us... | [
"src/UniTask.NetCoreTests/TaskExtensionsTest.cs",
"src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs"
] | [
{
"comment": "~~Even if there are multiple InnerExceptions, always unwrapping.~~\r\n~~This is because the behavior is the same as `await Task.WhenAll()`.~~\r\n~~Is this a problem?~~",
"path": "src/UniTask/Assets/Plugins/UniTask/Runtime/UniTaskExtensions.cs",
"hunk": "@@ -28,7 +28,7 @@ public static UniT... | true | ||
Cysharp/UniTask | 497 | issue_to_patch | Use dotnet >= 6.0 | c1042b32b7205d1fab2cfb03048dea98af0f20de | 07211f1fc30e3f5a90d8d6bbb90822bc7c2eb6bd | diff --git a/.github/workflows/build-debug.yml b/.github/workflows/build-debug.yml
index 76c0fedf..5a7eb3aa 100644
--- a/.github/workflows/build-debug.yml
+++ b/.github/workflows/build-debug.yml
@@ -17,8 +17,8 @@ jobs:
- uses: Cysharp/Actions/.github/actions/setup-dotnet@main
with:
dotnet-ver... | [
".github/workflows/build-debug.yml",
"src/UniTask.NetCore/UniTask.NetCore.csproj",
"src/UniTask.NetCoreSandbox/UniTask.NetCoreSandbox.csproj",
"src/UniTask.NetCoreTests/UniTask.NetCoreTests.csproj"
] | [] | true | |||
Cysharp/UniTask | 485 | issue_to_patch | Fix a problem in dotween where an extra update would run after canceling | #301
| 4c3d6938edef1ebc4d8c0fb5b9245cd3d219d45e | afe5f57adc03da3e074ee3578aeadc05cf11e5ee | diff --git a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs b/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs
index 80ae27c0..076bed51 100644
--- a/src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs
+++ b/src... | [
"src/UniTask/Assets/Plugins/UniTask/Runtime/External/DOTween/DOTweenAsyncExtensions.cs"
] | [] | true | ||
D4Vinci/Scrapling | 345 | issue_to_patch | v0.4.9 | **A maintenance update packed with community-reported fixes 🛠️**
> [!NOTE]
> **[Follow us on X for daily tips and tricks](https://x.com/Scrapling_dev)**
## 🚀 New Stuff and quality of life changes
- **Updated all browsers and fingerprints**. Run `scrapling install --force` after updating to refresh them.
- ... | b9bc17b46109da28be7c7b89ef398904ec15b56b | 74c5848060cae99e7076add01397609d5232e043 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index f82605da..930d0a00 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -73,7 +73,7 @@ jobs:
- name: Install all browsers dependencies
run: |
python3 -m pip install --upgrade pip
- python3 -... | [
".github/workflows/tests.yml",
"CONTRIBUTING.md",
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/mcp-server.md",
"docs/README_AR.md",
"docs/README_CN.md",
"docs/README... | [] | diff --git a/tests/cli/test_cli.py b/tests/cli/test_cli.py
index 39345d0a..642699d7 100644
--- a/tests/cli/test_cli.py
+++ b/tests/cli/test_cli.py
@@ -4,8 +4,9 @@
import pytest_httpbin
from scrapling.parser import Selector
+from scrapling import __version__
from scrapling.cli import (
- shell, mcp, get, post, p... | true | |
D4Vinci/Scrapling | 323 | issue_to_patch | fix: parse quoted charset values in content-type headers | ## Problem
`ResponseFactory.__extract_browser_encoding` extracts the charset from a `content-type` header with:
```python
__CHARSET_RE__ = re_compile(r"charset=([\w-]+)")
```
`[\w-]+` stops at a quote character. But [RFC 7231 §3.1.1.1](https://www.rfc-editor.org/rfc/rfc7231#section-3.1.1.1) allows the charset value ... | b3408c6f3c70eb8672c4178a55918ec567e2dad1 | 9352ccec3f1a8665305dcf4097e5b8f9b63bbd02 | diff --git a/scrapling/engines/toolbelt/convertor.py b/scrapling/engines/toolbelt/convertor.py
index 8d624e09..cf303c84 100644
--- a/scrapling/engines/toolbelt/convertor.py
+++ b/scrapling/engines/toolbelt/convertor.py
@@ -10,7 +10,7 @@
from .custom import Response, StatusText
from scrapling.core._types import Dict, ... | [
"scrapling/engines/toolbelt/convertor.py",
"tests/fetchers/test_utils.py"
] | [] | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index 942835f1..46794780 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -1,5 +1,6 @@
import pytest
+from scrapling.engines.toolbelt.convertor import ResponseFactory
from scrapling.engines.toolbelt.custom import... | true | |
D4Vinci/Scrapling | 320 | issue_to_patch | Fix broken docs link in CONTRIBUTING | CONTRIBUTING.md linked to https://github.com/D4Vinci/Scrapling/tree/docs, but there is no docs branch.\n\nThis updates the link to point at the existing dev/docs directory. | 4ced6e4ac26893304464f6368454a80830c3263d | c84764d6274369cea138cd070b469163373d3df2 | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 3967c1db..c1ed65fe 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -11,7 +11,7 @@ There are many ways to contribute to Scrapling. Here are some of them:
- Report bugs and request features using the [GitHub issues](https://github.com/D4Vinci/Scrapling/issues). ... | [
"CONTRIBUTING.md"
] | [] | true | ||
D4Vinci/Scrapling | 340 | issue_to_patch | fix: prevent IndexError in adaptive relocation when auto_save is enabled | ## Bug
Calling `css()` / `xpath()` with both `adaptive=True` and `auto_save=True` raises `IndexError: list index out of range` whenever the saved element cannot be relocated above the `percentage` threshold (e.g. the page structure changed too much, or a high threshold was set).
### Reproduce
```python
from scraplin... | 9c0c857245726352a8502b1e4822a444ade96543 | 3d96baf28487fc6e22ede41761d65c3ba2c557c7 | diff --git a/scrapling/parser.py b/scrapling/parser.py
index a075f2bb..8401f273 100644
--- a/scrapling/parser.py
+++ b/scrapling/parser.py
@@ -671,7 +671,7 @@ def xpath(
element_data = self.retrieve(identifier or selector)
if element_data:
elements = se... | [
"scrapling/parser.py",
"tests/parser/test_adaptive.py"
] | [] | diff --git a/tests/parser/test_adaptive.py b/tests/parser/test_adaptive.py
index 8d40f77c..85881d13 100644
--- a/tests/parser/test_adaptive.py
+++ b/tests/parser/test_adaptive.py
@@ -56,6 +56,32 @@ def test_element_relocation(self):
assert relocated[0].has_class("new-class")
assert relocated[0].css(".... | true | |
D4Vinci/Scrapling | 344 | issue_to_patch | fix(spiders): use os.replace for atomic checkpoint/cache writes on Windows | ## Summary
`CheckpointManager.save()` and `ResponseCacheManager.put()` write to a temporary file and then move it into place with `Path.rename()`. On Windows, `os.rename` cannot overwrite an existing destination and raises `FileExistsError` (`WinError 183`), so **every write after the first one fails**:
- **Checkpoin... | 2b2abb38105f4cbd180b4163d48f06fa2d32bb7d | 4f0a593b7d9d7b8ca4fef5f31b20f57906c374f0 | diff --git a/scrapling/spiders/cache.py b/scrapling/spiders/cache.py
index 40d39d32..0305aeff 100644
--- a/scrapling/spiders/cache.py
+++ b/scrapling/spiders/cache.py
@@ -64,7 +64,7 @@ async def put(self, fingerprint: bytes, response: Response, method: str = "GET")
async with await anyio.open_file(temp_pat... | [
"scrapling/spiders/cache.py",
"scrapling/spiders/checkpoint.py",
"tests/spiders/test_cache.py"
] | [] | diff --git a/tests/spiders/test_cache.py b/tests/spiders/test_cache.py
index fc9bc594..eb1b04b6 100644
--- a/tests/spiders/test_cache.py
+++ b/tests/spiders/test_cache.py
@@ -49,6 +49,27 @@ async def test_put_get_roundtrip(self):
assert dict(restored.headers) == dict(original.headers)
assert d... | true | |
D4Vinci/Scrapling | 303 | issue_to_patch | feat: add `--version` flag to the CLI | ## What
Adds a `--version` flag to the `scrapling` CLI, as requested in #299.
```bash
$ scrapling --version
Scrapling, version 0.4.8
```
## How
- Decorates the top-level `main` group with click's `version_option`, sourcing the version from `scrapling.__version__` and using `prog_name="Scrapling"` so the output matc... | 5d839c599559e0e771b8fe187a3953c1e66e5a8d | 507f7f626ddaa3dfb0b8837eb5f03c2bf2074fe8 | diff --git a/scrapling/cli.py b/scrapling/cli.py
index 47056d92..4b9eb862 100644
--- a/scrapling/cli.py
+++ b/scrapling/cli.py
@@ -2,6 +2,7 @@
from subprocess import check_output
from sys import executable as python_executable
+from scrapling import __version__
from scrapling.core.utils import log
from scrapling.... | [
"scrapling/cli.py",
"tests/cli/test_cli.py"
] | [] | diff --git a/tests/cli/test_cli.py b/tests/cli/test_cli.py
index 39345d0a..642699d7 100644
--- a/tests/cli/test_cli.py
+++ b/tests/cli/test_cli.py
@@ -4,8 +4,9 @@
import pytest_httpbin
from scrapling.parser import Selector
+from scrapling import __version__
from scrapling.cli import (
- shell, mcp, get, post, p... | true | |
D4Vinci/Scrapling | 315 | issue_to_patch | docs: fix Docker image name in remaining examples | ## Summary
PR #283 corrected the bare `scrapling` Docker image in `docs/ai/mcp-server.md` after #282 reported `pull access denied for scrapling`. Two other docs still showed `docker run … scrapling`, which hits the same failure mode.
## Problem
`docker pull pyd4vinci/scrapling` is documented everywhere, but `docker ... | 464fba24358816ce8852437a11dbea2bc68f3acb | 6efd50dd17bd342349d1ec861f5223153df528a8 | diff --git a/agent-skill/Scrapling-Skill/references/mcp-server.md b/agent-skill/Scrapling-Skill/references/mcp-server.md
index 48a2d107..6aaa014b 100644
--- a/agent-skill/Scrapling-Skill/references/mcp-server.md
+++ b/agent-skill/Scrapling-Skill/references/mcp-server.md
@@ -208,7 +208,7 @@ Docker alternative:
```bas... | [
"agent-skill/Scrapling-Skill/references/mcp-server.md",
"docs/cli/extract-commands.md"
] | [] | true | ||
D4Vinci/Scrapling | 283 | issue_to_patch | docs: fix Docker image name in MCP example | Docs at `docs/ai/mcp-server.md` instruct `docker pull pyd4vinci/scrapling`, but the Claude Desktop example config uses bare image name `scrapling`. Docker then tries the official library namespace and fails with `pull access denied for scrapling`.
Fix: use `pyd4vinci/scrapling` in the example so it matches the pulled ... | 6380ef0f266a5fff898c18953d6b03ca320b2fd4 | b5d7d3d103a6ee8345690366a0bb381eb6e74c18 | diff --git a/docs/ai/mcp-server.md b/docs/ai/mcp-server.md
index 534c5251..0ab72b54 100644
--- a/docs/ai/mcp-server.md
+++ b/docs/ai/mcp-server.md
@@ -129,7 +129,7 @@ If you are using the Docker image, then it would be something like
"ScraplingServer": {
"command": "docker",
"args": [
- "run",... | [
"docs/ai/mcp-server.md"
] | [] | true | ||
D4Vinci/Scrapling | 277 | issue_to_patch | v0.4.8 | **A big spider update that takes the crawling framework to the next level 🕷️**
> [!NOTE]
> **[Follow us on X for daily tips and tricks](https://x.com/Scrapling_dev)**
## 🚀 New Stuff and quality of life changes
- **Added a `LinkExtractor` primitive** in `scrapling.spiders.LinkExtractor` to pull URLs out of a... | 940036fa8f8ee6e12798c35b799fe3d970f3c7c7 | 66d891701376ca67e07e0aa81f914f7b94347812 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 1cf61397..f82605da 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -73,7 +73,7 @@ jobs:
- name: Install all browsers dependencies
run: |
python3 -m pip install --upgrade pip
- python3 -... | [
".github/workflows/tests.yml",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/fetching/choosing.md",
"agent-skill/Scrapling-Skill/references/fetching/dynamic.md",
"agent-skill/Scrapling-... | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [example.com](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/12)",
"path": "tests/spiders/test_links.py",
"hunk": "@@ -0,0 +1,243 @@\... | diff --git a/tests/fetchers/async/test_requests.py b/tests/fetchers/async/test_requests.py
index 51417cd1..f0bccd13 100644
--- a/tests/fetchers/async/test_requests.py
+++ b/tests/fetchers/async/test_requests.py
@@ -6,6 +6,17 @@
AsyncFetcher.adaptive = True
+@pytest.fixture
+def _reset_async_fetcher_config():
+ ... | true | |
D4Vinci/Scrapling | 277 | comment_to_fix | v0.4.8 | ## CodeQL / Incomplete URL substring sanitization
The string [example.com](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/12) | 940036fa8f8ee6e12798c35b799fe3d970f3c7c7 | 66d891701376ca67e07e0aa81f914f7b94347812 | diff --git a/tests/spiders/test_links.py b/tests/spiders/test_links.py
new file mode 100644
index 00000000..24139925
--- /dev/null
+++ b/tests/spiders/test_links.py
@@ -0,0 +1,243 @@
+"""Tests for `LinkExtractor`."""
+
+import re
+
+import pytest
+
+from scrapling.engines.toolbelt.custom import Response
+from scrapling... | [
"tests/spiders/test_links.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [example.com](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/12)",
"path": "tests/spiders/test_links.py",
"hunk": "@@ -0,0 +1,243 @@\... | true | ||
D4Vinci/Scrapling | 255 | issue_to_patch | fix: hash request kwargs and headers correctly | Summary
Request fingerprint collisions: `Request.update_fingerprint()` previously hashed only kwarg names and lowercased header values. Distinct requests could collapse to the same fingerprint when `fp_include_kwargs` or `fp_include_headers` were enabled, which can silently break scheduler deduplication, cache replay, ... | f305580f1d4e9349ee603a7c43f5fc4c71ce947f | 809d4782ba25ce0b77edc2f6764ab85ad575f9f0 | diff --git a/scrapling/spiders/request.py b/scrapling/spiders/request.py
index ce728ee2..ef766b2c 100644
--- a/scrapling/spiders/request.py
+++ b/scrapling/spiders/request.py
@@ -22,6 +22,13 @@ def _convert_to_bytes(value: str | bytes) -> bytes:
return value.encode(encoding="utf-8", errors="ignore")
+def _stab... | [
"scrapling/spiders/request.py",
"tests/spiders/test_request.py"
] | [
{
"comment": "Using `str(value)` for kwarg values is fragile if someone passes a non-primitive. ",
"path": "scrapling/spiders/request.py",
"hunk": "@@ -97,15 +97,19 @@ def update_fingerprint(\n }\n \n if include_kwargs:\n- kwargs = (key.lower() for key in self._session_kwargs.... | diff --git a/tests/spiders/test_request.py b/tests/spiders/test_request.py
index 997a71ba..00f6c49c 100644
--- a/tests/spiders/test_request.py
+++ b/tests/spiders/test_request.py
@@ -99,6 +99,38 @@ def test_fingerprint_different_urls(self):
r2 = Request("https://example.com/page2")
assert r1.update_fi... | true | |
D4Vinci/Scrapling | 251 | issue_to_patch | Block Ads unexpected argument
### Have you searched if there an existing issue for this?
- [x] I have searched the existing issues
### Python version (python --version)
3.12
### Scrapling version (scrapling.__version__)
0.4.6
### Dependencies version (pip3 freeze)
Image docker dependencies
## Issue descriptio... | v0.4.7 | **A focused update bringing eyes to your AI agents 📸**
> [!NOTE]
> **[Follow us on X for daily tips and tricks](https://x.com/Scrapling_dev)**
## 🚀 New Stuff and quality of life changes
- **Added a `screenshot` MCP tool** that captures a page and returns it as a real MCP `ImageContent` block so the model ca... | 11e038768b6c1e3a5224eb2444e6c944c9569e8a | 2a1e9e22f26666fd0e9d9b33d7a2bfa48fc5d0f5 | diff --git a/README.md b/README.md
index 82c24a64..537d4963 100644
--- a/README.md
+++ b/README.md
@@ -14,7 +14,7 @@
<p align="center">
<a href="https://trendshift.io/repositories/14244" target="_blank"><img src="https://trendshift.io/api/badge/repositories/14244" alt="D4Vinci%2FScrapling | Trendshift" style="wid... | [
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/mcp-server.md",
"docs/README_PT_BR.md",
"docs/ai/mcp-server.md",
"pyproject.toml",
"scrapling/__init__.py",
"scrapling/c... | [] | diff --git a/tests/ai/test_ai_mcp.py b/tests/ai/test_ai_mcp.py
index d897bb5a..19e2f020 100644
--- a/tests/ai/test_ai_mcp.py
+++ b/tests/ai/test_ai_mcp.py
@@ -1,5 +1,12 @@
+import base64
+import struct
+from contextlib import contextmanager
+from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
+from thre... | true |
D4Vinci/Scrapling | 245 | issue_to_patch | fix: prevent FetcherSession state corruption and lazy session close crash | ## Summary
- **Lazy session close crash**: `SessionManager.close()` called `__aexit__` on every session including lazy ones never opened. `FetcherSession.__aexit__` raises `RuntimeError: Cannot exit invalid session` when `_client is None`. Fix: skip sessions where `sid in _lazy_sessions and not _is_alive`.
- **State ... | 614d136f8cb9f0c31e2720189f25b26472c42d68 | 62b95a047d27a36be176ae4c36f9f41265e92aa2 | diff --git a/scrapling/engines/static.py b/scrapling/engines/static.py
index fae9f83c..8d4a3dee 100644
--- a/scrapling/engines/static.py
+++ b/scrapling/engines/static.py
@@ -718,8 +718,13 @@ def __enter__(self) -> _SyncSessionLogic:
config["selector_config"] = self.selector_config
config["pro... | [
"scrapling/engines/static.py",
"scrapling/spiders/session.py"
] | [] | true | ||
D4Vinci/Scrapling | 250 | issue_to_patch | Add pt-BR README link to language selector | ## Proposed change
This pull request adds a Brazilian Portuguese translation of the project README and updates the main `README.md` language selector to include `Português (Brasil)`.
The new translation follows the same structure and formatting as the existing localized READMEs, while preserving links, assets, co... | df0531d3269345132bf1492c25fe34176d66139f | 35653181001da19e6af374df106a2d794957aab0 | diff --git a/README.md b/README.md
index 82c24a64..537d4963 100644
--- a/README.md
+++ b/README.md
@@ -14,7 +14,7 @@
<p align="center">
<a href="https://trendshift.io/repositories/14244" target="_blank"><img src="https://trendshift.io/api/badge/repositories/14244" alt="D4Vinci%2FScrapling | Trendshift" style="wid... | [
"README.md",
"docs/README_PT_BR.md"
] | [] | true | ||
D4Vinci/Scrapling | 243 | issue_to_patch | feat(mcp): add optional session_id parameter to open_session | ## Proposed change
Allow users to specify a custom `session_id` when opening a browser session via `open_session()`, rather than always generating a random UUID. This is useful for naming sessions for easier management across multiple tool calls.
Changes:
- Add `session_id: Optional[str] = None` parameter to `open_se... | ced9a8d63c7da93839ff40968c08262b78ff254f | 00897dad2f60dc632e4f33972e7ae0c0889b1fff | diff --git a/scrapling/core/ai.py b/scrapling/core/ai.py
index 060cb204..7292a835 100644
--- a/scrapling/core/ai.py
+++ b/scrapling/core/ai.py
@@ -123,6 +123,7 @@ def _get_session(self, session_id: str, expected_type: SessionType) -> _SessionE
async def open_session(
self,
session_type: SessionTy... | [
"scrapling/core/ai.py",
"tests/ai/test_ai_mcp.py"
] | [] | diff --git a/tests/ai/test_ai_mcp.py b/tests/ai/test_ai_mcp.py
index d897bb5a..48060888 100644
--- a/tests/ai/test_ai_mcp.py
+++ b/tests/ai/test_ai_mcp.py
@@ -177,6 +177,25 @@ async def test_fetch_with_closed_session(self, server, test_url):
with pytest.raises(ValueError, match="not found"):
await... | true | |
D4Vinci/Scrapling | 241 | issue_to_patch | fix: duplicate ID segments in full-path selector generation | ## Summary
Full-path CSS and XPath selectors produce duplicate ID segments for elements with `id` attributes.
**Before:**
```
body > #main > #main > #target > #target
//body/[@id='main']/[@id='main']/[@id='target']/[@id='target']
```
**After:**
```
body > #main > #target
//body/[@id='main']/[@id='target']
```
## Roo... | c2e66ab75351d35b52f32453da618d16daea43fc | 3c234364487535c67e83b41863b4223181dcd9fa | diff --git a/scrapling/core/mixins.py b/scrapling/core/mixins.py
index c2e74202..868d620d 100644
--- a/scrapling/core/mixins.py
+++ b/scrapling/core/mixins.py
@@ -26,7 +26,12 @@ def _general_selection(self: Any, selection: str = "css", full_path: bool = Fals
if target.parent:
if target.att... | [
"scrapling/core/mixins.py",
"tests/parser/test_general.py"
] | [
{
"comment": "For XPath mode, `selectorPath` entries built for elements with `id` are predicates only (e.g. `[@id='main']`). When `full_path=True`, joining these with `\"//\" + \"/\".join(...)` yields steps like `//body/[@id='main']/[@id='target']`, which is not valid XPath syntax (a step cannot be just a predi... | diff --git a/tests/parser/test_general.py b/tests/parser/test_general.py
index 26f6e6c2..293e93ed 100644
--- a/tests/parser/test_general.py
+++ b/tests/parser/test_general.py
@@ -321,6 +321,50 @@ def _traverse(element: Selector):
_traverse(page)
+def test_full_path_selector_no_duplicate_ids():
+ """Test tha... | true | |
D4Vinci/Scrapling | 241 | comment_to_fix | fix: duplicate ID segments in full-path selector generation | For XPath mode, `selectorPath` entries built for elements with `id` are predicates only (e.g. `[@id='main']`). When `full_path=True`, joining these with `"//" + "/".join(...)` yields steps like `//body/[@id='main']/[@id='target']`, which is not valid XPath syntax (a step cannot be just a predicate). Consider emitting a... | c2e66ab75351d35b52f32453da618d16daea43fc | 3c234364487535c67e83b41863b4223181dcd9fa | diff --git a/scrapling/core/mixins.py b/scrapling/core/mixins.py
index c2e74202..868d620d 100644
--- a/scrapling/core/mixins.py
+++ b/scrapling/core/mixins.py
@@ -26,7 +26,12 @@ def _general_selection(self: Any, selection: str = "css", full_path: bool = Fals
if target.parent:
if target.att... | [
"scrapling/core/mixins.py"
] | [
{
"comment": "For XPath mode, `selectorPath` entries built for elements with `id` are predicates only (e.g. `[@id='main']`). When `full_path=True`, joining these with `\"//\" + \"/\".join(...)` yields steps like `//body/[@id='main']/[@id='target']`, which is not valid XPath syntax (a step cannot be just a predi... | true | ||
D4Vinci/Scrapling | 241 | comment_to_fix | fix: duplicate ID segments in full-path selector generation | The regression test checks that the generated full XPath selector doesn’t duplicate id segments, but it never validates that the XPath expression is syntactically valid or actually selects the target element. Since this PR claims to fix full-path XPath generation, consider asserting that `page.xpath(xpath_full)` return... | c2e66ab75351d35b52f32453da618d16daea43fc | 3c234364487535c67e83b41863b4223181dcd9fa | diff --git a/tests/parser/test_general.py b/tests/parser/test_general.py
index 26f6e6c2..293e93ed 100644
--- a/tests/parser/test_general.py
+++ b/tests/parser/test_general.py
@@ -321,6 +321,50 @@ def _traverse(element: Selector):
_traverse(page)
+def test_full_path_selector_no_duplicate_ids():
+ """Test tha... | [
"tests/parser/test_general.py"
] | [
{
"comment": "The regression test checks that the generated full XPath selector doesn’t duplicate id segments, but it never validates that the XPath expression is syntactically valid or actually selects the target element. Since this PR claims to fix full-path XPath generation, consider asserting that `page.xpa... | true | ||
D4Vinci/Scrapling | 242 | issue_to_patch | v0.4.6 | **A focused update on browser stealth, privacy, and developer experience 🔒**
> [!NOTE]
> **[Follow us on X for daily tips and tricks](https://x.com/Scrapling_dev)**
## 🚀 New Stuff and quality of life changes
- **Added built-in ad blocking** for browser fetchers. Pass `block_ads=True` to block requests to ~3... | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/README.md b/README.md
index 94eb7b89..81d7848d 100644
--- a/README.md
+++ b/README.md
@@ -235,7 +235,8 @@ MySpider().start()
- **Anti-bot Bypass**: Advanced stealth capabilities with `StealthyFetcher` and fingerprint spoofing. Can easily bypass all types of Cloudflare's Turnstile/Interstitial with automat... | [
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/fetching/dynamic.md",
"agent-skill/Scrapling-Skill/references/fetching/stealthy.md",
"agent-skill/Scrapling-Skill/references/m... | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/7)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,3 +396... | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | true | |
D4Vinci/Scrapling | 242 | comment_to_fix | v0.4.6 | ## CodeQL / Incomplete URL substring sanitization
The string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/7) | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | [
"tests/fetchers/test_utils.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/7)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,3 +396... | true | ||
D4Vinci/Scrapling | 242 | comment_to_fix | v0.4.6 | ## CodeQL / Incomplete URL substring sanitization
The string [googlesyndication.com](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/8) | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | [
"tests/fetchers/test_utils.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [googlesyndication.com](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/8)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,... | true | ||
D4Vinci/Scrapling | 242 | comment_to_fix | v0.4.6 | ## CodeQL / Incomplete URL substring sanitization
The string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/9) | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | [
"tests/fetchers/test_utils.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/9)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,3 +396... | true | ||
D4Vinci/Scrapling | 242 | comment_to_fix | v0.4.6 | ## CodeQL / Incomplete URL substring sanitization
The string [my-custom-block.com](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/10) | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | [
"tests/fetchers/test_utils.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [my-custom-block.com](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/10)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,3... | true | ||
D4Vinci/Scrapling | 242 | comment_to_fix | v0.4.6 | ## CodeQL / Incomplete URL substring sanitization
The string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.
[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/11) | 2046527575c879a0586b953966387eacad2b3aff | 65c54f3b91582696b52f3b0a1402eb6d8af0578d | diff --git a/tests/fetchers/test_utils.py b/tests/fetchers/test_utils.py
index bebb5fd8..942835f1 100644
--- a/tests/fetchers/test_utils.py
+++ b/tests/fetchers/test_utils.py
@@ -5,11 +5,9 @@
construct_proxy_dict,
create_intercept_handler,
create_async_intercept_handler,
+ _is_domain_blocked,
)
-from... | [
"tests/fetchers/test_utils.py"
] | [
{
"comment": "## CodeQL / Incomplete URL substring sanitization\n\nThe string [doubleclick.net](1) may be at an arbitrary position in the sanitized URL.\n\n[Show more details](https://github.com/D4Vinci/Scrapling/security/code-scanning/11)",
"path": "tests/fetchers/test_utils.py",
"hunk": "@@ -411,3 +39... | true | ||
D4Vinci/Scrapling | 235 | issue_to_patch | v0.4.5 | **A focused update with one big quality-of-life feature for spider developers and a couple of important fixes 🎉**
> [!NOTE]
> **[Follow us on X for daily tips and tricks](https://x.com/Scrapling_dev)**
## 🚀 New Stuff and quality of life changes
- **Spider Development Mode**: Iterating on a spider's `parse... | aee6888dd5f0aada4e2ed1a0bab27c28f8550d5e | 664e41975120951a244e9245ad50a5ef027176fe | diff --git a/README.md b/README.md
index ab5fb8a9..408cfef4 100644
--- a/README.md
+++ b/README.md
@@ -215,6 +215,7 @@ MySpider().start()
- 📡 **Streaming Mode**: Stream scraped items as they arrive via `async for item in spider.stream()` with real-time stats - ideal for UI, pipelines, and long-running crawls.
- 🛡️ ... | [
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/fetching/static.md",
"agent-skill/Scrapling-Skill/references/mcp-server.md",
"agent-skill/Scrapling-Skill/references/spiders/a... | [] | diff --git a/tests/spiders/test_cache.py b/tests/spiders/test_cache.py
new file mode 100644
index 00000000..fc9bc594
--- /dev/null
+++ b/tests/spiders/test_cache.py
@@ -0,0 +1,228 @@
+"""Tests for the ResponseCacheManager and development_mode integration."""
+
+import tempfile
+from pathlib import Path
+
+import anyio
... | true | |
D4Vinci/Scrapling | 229 | issue_to_patch | ProxyRotator raise a NotImplementedError
### Have you searched if there an existing issue for this?
- [x] I have searched the existing issues
### Python version (python --version)
Python 3.11.8
### Scrapling version (scrapling.__version__)
0.4.2
### Dependencies version (pip3 freeze)
apify_fingerprint_datapoint... | v0.4.4 | **A new update with important spider improvements and bug fixes 🎉**
## 🚀 New Stuff and quality of life changes
- **Added robots.txt compliance to the Spider framework** with a new `robots_txt_obey` option. When enabled, the spider will automatically fetch and respect robots.txt rules before crawling, including `D... | fcf930c5689c545b6d5dd5abac139934e71e29e6 | 087634ab67883edbb3d80a4f6a949c5c525a1e94 | diff --git a/README.md b/README.md
index d577a00a..d6b6e418 100644
--- a/README.md
+++ b/README.md
@@ -214,6 +214,7 @@ MySpider().start()
- 💾 **Pause & Resume**: Checkpoint-based crawl persistence. Press Ctrl+C for a graceful shutdown; restart to resume from where you left off.
- 📡 **Streaming Mode**: Stream scrape... | [
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/spiders/advanced.md",
"agent-skill/Scrapling-Skill/references/spiders/architecture.md",
"agent-skill/Scrapling-Skill/reference... | [] | diff --git a/tests/fetchers/test_pages.py b/tests/fetchers/test_pages.py
index 69dc4ba0..b726c749 100644
--- a/tests/fetchers/test_pages.py
+++ b/tests/fetchers/test_pages.py
@@ -84,6 +84,15 @@ def test_add_page_limit_exceeded(self):
with pytest.raises(RuntimeError):
pool.add_page(Mock())
+ d... | true |
D4Vinci/Scrapling | 226 | issue_to_patch | feat(spiders): robots.txt compliance with concurrent fetch deduplication | ## Proposed change
Implements robots.txt compliance for the spider framework. When `robots_txt_obey = True`, the engine checks each URL against the domain's robots.txt before fetching, respects
`Crawl-delay` / `Request-rate` directives by computing a per-domain delay, and enforces `CapacityLimiter(1)` for domains... | eaf7ec2cc06f07a50ae711c3b3f60e24ca0f1fc6 | a134fdb8cce853f66713e115b81d195ec6e7b0c3 | diff --git a/pyproject.toml b/pyproject.toml
index a8058188..4333d7ea 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -66,7 +66,7 @@ dependencies = [
"orjson>=3.11.8",
"tld>=0.13.2",
"w3lib>=2.4.1",
- "typing_extensions",
+ "typing_extensions"
]
[project.optional-dependencies]
@@ -78,7 +78,... | [
"pyproject.toml",
"scrapling/spiders/engine.py",
"scrapling/spiders/result.py",
"scrapling/spiders/robotstxt.py",
"scrapling/spiders/spider.py",
"tests/spiders/test_engine.py",
"tests/spiders/test_robotstxt.py"
] | [
{
"comment": "The new feature is part of the spiders framework only, so `protego` shouldn't be added to the main dependencies.\nMove `protego` to the `fetchers` optional dependency below. 👇🏼 ",
"path": "pyproject.toml",
"hunk": "@@ -67,6 +67,7 @@ dependencies = [\n \"tld>=0.13.2\",\n \"w3lib>=... | diff --git a/tests/spiders/test_engine.py b/tests/spiders/test_engine.py
index b7bfd0f9..e7382f89 100644
--- a/tests/spiders/test_engine.py
+++ b/tests/spiders/test_engine.py
@@ -8,6 +8,7 @@
from scrapling.spiders.engine import CrawlerEngine, _dump
from scrapling.spiders.request import Request
+from scrapling.spide... | true | |
D4Vinci/Scrapling | 226 | comment_to_fix | feat(spiders): robots.txt compliance with concurrent fetch deduplication | The new feature is part of the spiders framework only, so `protego` shouldn't be added to the main dependencies.
Move `protego` to the `fetchers` optional dependency below. 👇🏼 | eaf7ec2cc06f07a50ae711c3b3f60e24ca0f1fc6 | a134fdb8cce853f66713e115b81d195ec6e7b0c3 | diff --git a/pyproject.toml b/pyproject.toml
index a8058188..4333d7ea 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -66,7 +66,7 @@ dependencies = [
"orjson>=3.11.8",
"tld>=0.13.2",
"w3lib>=2.4.1",
- "typing_extensions",
+ "typing_extensions"
]
[project.optional-dependencies]
@@ -78,7 +78,... | [
"pyproject.toml"
] | [
{
"comment": "The new feature is part of the spiders framework only, so `protego` shouldn't be added to the main dependencies.\nMove `protego` to the `fetchers` optional dependency below. 👇🏼 ",
"path": "pyproject.toml",
"hunk": "@@ -67,6 +67,7 @@ dependencies = [\n \"tld>=0.13.2\",\n \"w3lib>=... | true | ||
D4Vinci/Scrapling | 223 | issue_to_patch | fix: proxy rotation page pool leak | Hey, opening this as requested by @D4Vinci in #215! | 966e17a1dc9088c178f41dddb7fc02f752675b38 | 6c6aabeb73a872202db5bc295890226859b5eccb | diff --git a/scrapling/engines/_browsers/_base.py b/scrapling/engines/_browsers/_base.py
index eefb9f32..2d42b08f 100644
--- a/scrapling/engines/_browsers/_base.py
+++ b/scrapling/engines/_browsers/_base.py
@@ -196,11 +196,14 @@ def _page_generator(
context_options = self._build_context_with_proxy(proxy)
... | [
"scrapling/engines/_browsers/_base.py",
"tests/fetchers/test_pages.py"
] | [] | diff --git a/tests/fetchers/test_pages.py b/tests/fetchers/test_pages.py
index 69dc4ba0..b726c749 100644
--- a/tests/fetchers/test_pages.py
+++ b/tests/fetchers/test_pages.py
@@ -84,6 +84,15 @@ def test_add_page_limit_exceeded(self):
with pytest.raises(RuntimeError):
pool.add_page(Mock())
+ d... | true | |
D4Vinci/Scrapling | 217 | issue_to_patch | v0.4.3 | **A new update with many important changes 🎉**
## New Stuff and quality of life changes
- **Added a new MCP tool** to open a persistent normal/stealthy browser to keep using it with the rest of the tools, and another new tool to close it. ([Examples](https://scrapling.readthedocs.io/en/latest/ai/mcp-server.html?h=... | f36ddb4b16c2343f03dc70d605305e6b28a17ace | b354be06c0301cd6123dad0debb6edc43a281c85 | diff --git a/README.md b/README.md
index cd97172c..62bbfd0c 100644
--- a/README.md
+++ b/README.md
@@ -53,7 +53,7 @@
Scrapling is an adaptive Web Scraping framework that handles everything from a single request to a full-scale crawl.
-Its parser learns from website changes and automatically relocates your elements... | [
"README.md",
"agent-skill/Scrapling-Skill.zip",
"agent-skill/Scrapling-Skill/SKILL.md",
"agent-skill/Scrapling-Skill/examples/01_fetcher_session.py",
"agent-skill/Scrapling-Skill/examples/README.md",
"agent-skill/Scrapling-Skill/references/fetching/choosing.md",
"agent-skill/Scrapling-Skill/references/f... | [] | diff --git a/tests/ai/test_ai_mcp.py b/tests/ai/test_ai_mcp.py
index 4a9e3085..d897bb5a 100644
--- a/tests/ai/test_ai_mcp.py
+++ b/tests/ai/test_ai_mcp.py
@@ -1,7 +1,14 @@
import pytest
import pytest_httpbin
-from scrapling.core.ai import ScraplingMCPServer, ResponseModel
+from scrapling.core.ai import (
+ Scrap... | true | |
D4Vinci/Scrapling | 193 | issue_to_patch | test: add save/retrieve round-trip and core storage coverage | ## What
Extends `tests/core/test_storage_core.py` with comprehensive coverage for the storage subsystem that powers Scrapling's adaptive element relocation:
- **`_get_base_url()`**: `None` input, empty string, valid URL extraction, case normalization
- **`_get_hash()`**: determinism, uniqueness, strip/lowercase handl... | 3b4cae6889a52f4f0eb163b39280c57aa1964bf8 | 30ffe76cfabea565e4bc5f8c173902615392126e | [
"tests/core/test_storage_core.py"
] | [
{
"comment": "This needs to be changed to `assert \"parent_name\" in result` because result here will be `{'attributes': {}, 'parent_attribs': {}, 'parent_name': 'body', 'parent_text': None, ...}`",
"path": "tests/core/test_storage_core.py",
"hunk": "@@ -24,18 +83,210 @@ def test_sqlite_storage_with_fil... | diff --git a/tests/core/test_storage_core.py b/tests/core/test_storage_core.py
index 18272942..21de243c 100644
--- a/tests/core/test_storage_core.py
+++ b/tests/core/test_storage_core.py
@@ -1,18 +1,77 @@
import tempfile
import os
+import threading
-from scrapling.core.storage import SQLiteStorageSystem
+from lxml.... | true | ||
D4Vinci/Scrapling | 193 | comment_to_fix | test: add save/retrieve round-trip and core storage coverage | This needs to be changed to `assert "parent_name" in result` because result here will be `{'attributes': {}, 'parent_attribs': {}, 'parent_name': 'body', 'parent_text': None, ...}` | 3b4cae6889a52f4f0eb163b39280c57aa1964bf8 | 30ffe76cfabea565e4bc5f8c173902615392126e | diff --git a/tests/core/test_storage_core.py b/tests/core/test_storage_core.py
index 18272942..21de243c 100644
--- a/tests/core/test_storage_core.py
+++ b/tests/core/test_storage_core.py
@@ -1,18 +1,77 @@
import tempfile
import os
+import threading
-from scrapling.core.storage import SQLiteStorageSystem
+from lxml.... | [
"tests/core/test_storage_core.py"
] | [
{
"comment": "This needs to be changed to `assert \"parent_name\" in result` because result here will be `{'attributes': {}, 'parent_attribs': {}, 'parent_name': 'body', 'parent_text': None, ...}`",
"path": "tests/core/test_storage_core.py",
"hunk": "@@ -24,18 +83,210 @@ def test_sqlite_storage_with_fil... | true | ||
D4Vinci/Scrapling | 193 | comment_to_fix | test: add save/retrieve round-trip and core storage coverage | This needs to be `assert path == ('html', 'body', 'div')` as this will be the correct value of `path`. | 3b4cae6889a52f4f0eb163b39280c57aa1964bf8 | 30ffe76cfabea565e4bc5f8c173902615392126e | diff --git a/tests/core/test_storage_core.py b/tests/core/test_storage_core.py
index 18272942..21de243c 100644
--- a/tests/core/test_storage_core.py
+++ b/tests/core/test_storage_core.py
@@ -1,18 +1,77 @@
import tempfile
import os
+import threading
-from scrapling.core.storage import SQLiteStorageSystem
+from lxml.... | [
"tests/core/test_storage_core.py"
] | [
{
"comment": "This needs to be `assert path == ('html', 'body', 'div')` as this will be the correct value of `path`.",
"path": "tests/core/test_storage_core.py",
"hunk": "@@ -24,18 +83,210 @@ def test_sqlite_storage_with_file(self):\n assert storage is not None\n assert os.path.e... | true | ||
D4Vinci/Scrapling | 204 | issue_to_patch | [Bug] Skill loading failed due to broken Markdown links in scrapling skill
### Have you searched if there an existing issue for this?
- [x] I have searched the existing issues
### Page URL
https://github.com/D4Vinci/Scrapling/tree/main/agent-skill
### Type of issue
Incorrect information
### Description
When att... | Fix broken markdown links in skill references | Closes #203
Small fix for the broken relative paths in the `references/` markdown files that were causing Zeroclaw to reject the skill directory. Updated links in `spiders/` to use `../fetching/` and removed redundant prefixes in `fetching/`. | 7bfaf204b7fd4142f8d28afba0bafed4c50ca6a5 | a4f31ae20553c8bd53d0be5126d8c4b14a811390 | diff --git a/agent-skill/Scrapling-Skill/references/fetching/dynamic.md b/agent-skill/Scrapling-Skill/references/fetching/dynamic.md
index a87fdf6a..1a4c96d7 100644
--- a/agent-skill/Scrapling-Skill/references/fetching/dynamic.md
+++ b/agent-skill/Scrapling-Skill/references/fetching/dynamic.md
@@ -44,7 +44,7 @@ Instead... | [
"agent-skill/Scrapling-Skill/references/fetching/dynamic.md",
"agent-skill/Scrapling-Skill/references/spiders/architecture.md",
"agent-skill/Scrapling-Skill/references/spiders/getting-started.md",
"agent-skill/Scrapling-Skill/references/spiders/sessions.md"
] | [] | true | |
D4Vinci/Scrapling | 187 | issue_to_patch | docs: Add Korean (한국어) README translation | Added Korean translation of README at `docs/README_KR.md` and updated the language links in the main README.
Follows the same structure and format as existing translations (JP, CN, etc.). | 383671293954a6c82f958f1ca1d53922002fd91a | 60243a823a087890e392edbc83b4712e5b9b510c | diff --git a/README.md b/README.md
index 3f3a5333..0ab3d036 100644
--- a/README.md
+++ b/README.md
@@ -14,7 +14,7 @@
<p align="center">
<a href="https://trendshift.io/repositories/14244" target="_blank"><img src="https://trendshift.io/api/badge/repositories/14244" alt="D4Vinci%2FScrapling | Trendshift" style="wid... | [
"README.md",
"docs/README_KR.md"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.