Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
LadybirdBrowser/ladybird
10,085
issue_to_patch
Unable to navigate back to file:// URLs To reproduce: 1. Open a local file in Ladybird 2. Type `example.com` in the address bar and navigate to it 3. Once it's loaded, press the Back button 4. Error, see screenshot below 5. Press refresh 6. Local file does load Picture for step 4: ![image](https://github.com...
LibWebView: Keep browser history in the UI process
This moves the browser’s top-level session history model into the UI process. Before this, each WebContent process owned its own view of history. That meant the browser chrome could lose accurate back/forward state when a tab swapped to a different WebContent process, for example during cross-site navigation or a...
6c13a3f37d790275c68ba98c86fa75fc35afd11f
439aa12b56d4f43cee579b148fd893325cc05426
diff --git a/Libraries/LibWeb/CMakeLists.txt b/Libraries/LibWeb/CMakeLists.txt index d38c2f793f760..ecc57417e5f28 100644 --- a/Libraries/LibWeb/CMakeLists.txt +++ b/Libraries/LibWeb/CMakeLists.txt @@ -656,6 +656,7 @@ set(SOURCES HTML/Plugin.cpp HTML/PluginArray.cpp HTML/PolicyContainers.cpp + HTML/POS...
[ "Libraries/LibWeb/CMakeLists.txt", "Libraries/LibWeb/DOM/Document.cpp", "Libraries/LibWeb/DOM/Document.h", "Libraries/LibWeb/Dump.cpp", "Libraries/LibWeb/HTML/HTMLFormElement.cpp", "Libraries/LibWeb/HTML/Navigable.cpp", "Libraries/LibWeb/HTML/Navigable.h", "Libraries/LibWeb/HTML/NavigateEvent.cpp", ...
[]
diff --git a/Tests/LibWeb/CMakeLists.txt b/Tests/LibWeb/CMakeLists.txt index a2097b3005566..cf21f24ce74aa 100644 --- a/Tests/LibWeb/CMakeLists.txt +++ b/Tests/LibWeb/CMakeLists.txt @@ -14,6 +14,7 @@ set(TEST_SOURCES TestMicrosyntax.cpp TestMimeSniff.cpp TestNumbers.cpp + TestPage.cpp TestRefCount...
true
LadybirdBrowser/ladybird
9,988
issue_to_patch
Intermittent WebContent crash with Layout/input/pdf-viewer.pdf: VERIFY(m_dom_node) during paint-cache release `Tests/LibWeb/Layout/input/pdf-viewer.pdf` intermittently crashes under CI — roughly once in a few dozen runs. Backtrace: ``` ak_verification_failed Web::Layout::Node::document() const ...
LibWeb: Run `removed_from` for descendants when shadow root removed
This is only relevant for UA-internal shadow roots (specifically those created by `HTMLInputElement` and `MediaControls`) since they are the only ones which can be removed from their hosts. Previously after removing a shadow root from it's host we left it's descendants' paintables' caches to be cleared during th...
ac0e0833e705a99974a899c18b8faa3836851a48
18cc88679e9fbc49fb6f21ff8046d8e40f3f8e6c
diff --git a/Libraries/LibWeb/DOM/Element.cpp b/Libraries/LibWeb/DOM/Element.cpp index fa69901c9960e..08944e25506fd 100644 --- a/Libraries/LibWeb/DOM/Element.cpp +++ b/Libraries/LibWeb/DOM/Element.cpp @@ -1493,6 +1493,14 @@ void Element::set_shadow_root(GC::Ptr<ShadowRoot> shadow_root) if (m_shadow_root) { ...
[ "Libraries/LibWeb/DOM/Element.cpp", "Libraries/LibWeb/DOM/Node.cpp", "Libraries/LibWeb/DOM/Node.h", "Tests/LibWeb/Crash/DOM/block-in-inline-removal-crash.html", "Tests/LibWeb/Crash/DOM/shadow-root-children-removed-on-attribute-change.html" ]
[]
diff --git a/Tests/LibWeb/Crash/DOM/block-in-inline-removal-crash.html b/Tests/LibWeb/Crash/DOM/block-in-inline-removal-crash.html new file mode 100644 index 0000000000000..ef130bce143ee --- /dev/null +++ b/Tests/LibWeb/Crash/DOM/block-in-inline-removal-crash.html @@ -0,0 +1,30 @@ +<!doctype html> +<body></body> +<scri...
true
LadybirdBrowser/ladybird
9,878
issue_to_patch
LibWasm: Fix validation and don't wait for compilation
(wip)
879fc69f89ba4ef547ab3d7ce2929f7c50063ac8
4e4e6a241ff78820f84f2c8575a731e1a3fcb567
diff --git a/Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp b/Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp index a4e734ae45440..dbc2751885b77 100644 --- a/Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp +++ b/Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp @@ -8,6 +8,7 @@ #include <AK/Never...
[ "Libraries/LibWasm/AbstractMachine/AbstractMachine.cpp", "Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.cpp", "Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.h", "Libraries/LibWasm/AbstractMachine/Configuration.cpp", "Libraries/LibWasm/AbstractMachine/Validator.cpp", "Libraries/LibWasm/Abst...
[]
true
LadybirdBrowser/ladybird
10,093
issue_to_patch
LibJS: Enable AsmInterpreter on Windows
Enable the asm interpreter on Windows for both x86_64 and ARM64. The x86_64 backend now emits COFF assembly using the Win64 ABI, including argument registers, non-volatile register saves, shadow space, SEH unwind directives, and the sret convention used by raw native calls. The AArch64 backend now emits Windows ARM6...
f52852cd837355f219e9f7e57ff1b94e97805f9c
0e30f329122c4d9b5661f581a2e4f80c372b894f
diff --git a/Libraries/LibJS/AsmIntGen/src/codegen_aarch64.rs b/Libraries/LibJS/AsmIntGen/src/codegen_aarch64.rs index 5a3224f3f8d07..2038d4e3c60e6 100644 --- a/Libraries/LibJS/AsmIntGen/src/codegen_aarch64.rs +++ b/Libraries/LibJS/AsmIntGen/src/codegen_aarch64.rs @@ -23,6 +23,11 @@ struct PinnedConstants { map: H...
[ "Libraries/LibJS/AsmIntGen/src/codegen_aarch64.rs", "Libraries/LibJS/AsmIntGen/src/codegen_x86_64.rs", "Libraries/LibJS/AsmIntGen/src/main.rs", "Libraries/LibJS/AsmIntGen/src/parser.rs", "Libraries/LibJS/Bytecode/AsmInterpreter/AsmInterpreter.cpp", "Libraries/LibJS/Bytecode/AsmInterpreter/gen_asm_offsets....
[]
true
LadybirdBrowser/ladybird
10,091
issue_to_patch
LibWeb: Avoid sorting InvalidationSet hashes
Keep the cached equality precheck, but compute the set hash with order-independent aggregate values instead of materializing and sorting the per-property hashes. This avoids allocation and sorting in a hot equality path while leaving correctness to the existing full property comparison after hash matches.
b0c25736f908f4f246f0eaffe55fdccce99ca06c
feda71867d39e68399d61000c02ecc7f94913951
diff --git a/Libraries/LibWeb/CSS/InvalidationSet.cpp b/Libraries/LibWeb/CSS/InvalidationSet.cpp index 0ad424da8d721..7b4505e1684b2 100644 --- a/Libraries/LibWeb/CSS/InvalidationSet.cpp +++ b/Libraries/LibWeb/CSS/InvalidationSet.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include <AK/QuickSor...
[ "Libraries/LibWeb/CSS/InvalidationSet.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,089
issue_to_patch
AK: Simplify smart pointer destruction
This removes `OwnPtr` custom deleter support. The only production use was `AddressInfoVector`, which needs `freeaddrinfo()` rather than `delete`, so that special case now owns the raw `addrinfo*` directly and releases it in its destructor. With custom deleters gone, `OwnPtr` destruction can `delete` its pointer dire...
b0c25736f908f4f246f0eaffe55fdccce99ca06c
f7fad9fd8678beb4991fb57b0483649dacaa8e9e
diff --git a/AK/DefaultDelete.h b/AK/DefaultDelete.h deleted file mode 100644 index be13a1018c67f..0000000000000 --- a/AK/DefaultDelete.h +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Copyright (c) 2022, the SerenityOS developers. - * - * SPDX-License-Identifier: BSD-2-Clause - */ - -#pragma once - -namespace AK { - -template...
[ "AK/DefaultDelete.h", "AK/Forward.h", "AK/NonnullOwnPtr.h", "AK/NonnullRefPtr.h", "AK/OwnPtr.h", "AK/RefPtr.h", "Documentation/EditorConfiguration/QtCreatorConfiguration.md", "Libraries/LibCore/AddressInfoVector.cpp", "Libraries/LibCore/AddressInfoVector.h", "Tests/AK/TestOwnPtr.cpp" ]
[]
diff --git a/Tests/AK/TestOwnPtr.cpp b/Tests/AK/TestOwnPtr.cpp index 1f73fbac8abf9..206f8c9e232a4 100644 --- a/Tests/AK/TestOwnPtr.cpp +++ b/Tests/AK/TestOwnPtr.cpp @@ -8,20 +8,6 @@ #include <AK/OwnPtr.h> -static u64 deleter_call_count = 0; - -TEST_CASE(should_call_custom_deleter) -{ - auto deleter = [](auto* p...
true
LadybirdBrowser/ladybird
10,090
issue_to_patch
LibWeb: Allocate layout used values with bump allocator
Store UsedValues separately from the sparse layout index pages. The pages now hold pointers for O(1) lookup by layout index, while the values are allocated from a uniform bump allocator owned by the paged store. This keeps pointer stability for containing-block links and avoids placing large Optional<UsedValues> slo...
b0c25736f908f4f246f0eaffe55fdccce99ca06c
9cbf0e5cbae8fafabab13a240832b41c7c2c9f15
diff --git a/Libraries/LibWeb/Layout/LayoutState.h b/Libraries/LibWeb/Layout/LayoutState.h index dd1d06960087a..ab2ca848f03b7 100644 --- a/Libraries/LibWeb/Layout/LayoutState.h +++ b/Libraries/LibWeb/Layout/LayoutState.h @@ -6,6 +6,7 @@ #pragma once +#include <AK/BumpAllocator.h> #include <AK/HashTable.h> #inclu...
[ "Libraries/LibWeb/Layout/LayoutState.h" ]
[]
true
LadybirdBrowser/ladybird
10,087
issue_to_patch
LibWeb: Always treat [Replaceable] attributes as having setters
[Replaceable] readonly attributes still need JS accessor setters for replacement and receiver checks. Remove the include_replaceable opt-in so the binding generator handles them consistently.
956a2b96d556eb845d67a9d626f36ab19668d51e
b0eb23e6e37e64cfc8004e487a821d385b8963e1
diff --git a/Meta/Generators/libweb_bindings/attributes.py b/Meta/Generators/libweb_bindings/attributes.py index 98c8a4cb0d2de..7538a08397ab1 100644 --- a/Meta/Generators/libweb_bindings/attributes.py +++ b/Meta/Generators/libweb_bindings/attributes.py @@ -22,12 +22,12 @@ from Utils.webidl_parser import Interface ...
[ "Meta/Generators/libweb_bindings/attributes.py", "Meta/Generators/libweb_bindings/global_mixins.py", "Tests/LibWeb/TestConfig.ini", "Tests/LibWeb/Text/expected/wpt-import/webidl/ecmascript-binding/global-object-implicit-this-value.any.worker.txt", "Tests/LibWeb/Text/input/wpt-import/webidl/ecmascript-bindin...
[]
diff --git a/Tests/LibWeb/TestConfig.ini b/Tests/LibWeb/TestConfig.ini index e4221ae580b96..f37bc0e709760 100644 --- a/Tests/LibWeb/TestConfig.ini +++ b/Tests/LibWeb/TestConfig.ini @@ -151,6 +151,7 @@ Text/input/wpt-import/html/canvas/element/manual/imagebitmap/createImageBitmap-i ; Unable to fetch from inside of th...
true
LadybirdBrowser/ladybird
10,088
issue_to_patch
LibWeb: Scale `image-set()` natural size by the selected resolution
The <resolution> of the chosen image-set() option overrides the image's natural resolution, so the image-set()'s natural dimensions are the selected image's pixel dimensions divided by that resolution. This issue manifested on https://tonsky.me/, where the custom cursor rendered at twice its intended size.
956a2b96d556eb845d67a9d626f36ab19668d51e
a074595e05012c4f7ebda38c0d63c5a7aa56b78f
diff --git a/Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.cpp b/Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.cpp index 25766e1c810dd..fbf6ae760cd48 100644 --- a/Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.cpp +++ b/Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.cpp @@ -30,7 +30,7 @@ ImageSetS...
[ "Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.cpp", "Libraries/LibWeb/CSS/StyleValues/ImageSetStyleValue.h", "Tests/LibWeb/Ref/expected/css-image-set-natural-size-ref.html", "Tests/LibWeb/Ref/input/css-image-set-natural-size.html" ]
[]
diff --git a/Tests/LibWeb/Ref/expected/css-image-set-natural-size-ref.html b/Tests/LibWeb/Ref/expected/css-image-set-natural-size-ref.html new file mode 100644 index 0000000000000..3e7236d6bab0b --- /dev/null +++ b/Tests/LibWeb/Ref/expected/css-image-set-natural-size-ref.html @@ -0,0 +1,16 @@ +<!doctype html> +<style> ...
true
LadybirdBrowser/ladybird
10,086
issue_to_patch
Prepare 2D canvas command replay for compositor rasterization
Instead of having CanvasRenderingContext2D paint directly into a WebContent-owned surface, canvas drawing now records LibGfx canvas commands and replays them through a CanvasCommandPlayer. Playback still happens locally with this changes, but the API shape now matches the future compositor-process path: WebContent prod...
956a2b96d556eb845d67a9d626f36ab19668d51e
702026119b4fe93f8d15e38792cc3dd6830029fa
diff --git a/Libraries/LibGfx/AffineTransform.cpp b/Libraries/LibGfx/AffineTransform.cpp index c7b0fc4693b2e..fb14ad6df07ca 100644 --- a/Libraries/LibGfx/AffineTransform.cpp +++ b/Libraries/LibGfx/AffineTransform.cpp @@ -9,6 +9,8 @@ #include <LibGfx/AffineTransform.h> #include <LibGfx/Quad.h> #include <LibGfx/Rect.h...
[ "Libraries/LibGfx/AffineTransform.cpp", "Libraries/LibGfx/AffineTransform.h", "Libraries/LibGfx/CMakeLists.txt", "Libraries/LibGfx/CanvasCommandList.cpp", "Libraries/LibGfx/CanvasCommandList.h", "Libraries/LibGfx/CanvasCommandPlayer.cpp", "Libraries/LibGfx/CanvasCommandPlayer.h", "Libraries/LibGfx/Dec...
[]
true
LadybirdBrowser/ladybird
10,084
issue_to_patch
LibWeb: Allocate layout and painting objects with mimalloc
Add class-local allocation macros for operator new/delete through AK's malloc helpers. The macros can optionally choose a HeapPartition. Add Layout and Painting partitions, plus basic partition stats helpers. Use the new partitions for LibWeb layout and painting object hierarchies and layout-state side data.
b29d3622af9ed342595f43b0ff6ba0721203459a
d5bf8794c2a577ef586b7de0a1401f9c0a14b276
diff --git a/AK/kmalloc.cpp b/AK/kmalloc.cpp index 5b8ad3ab34ec9..fcdfb1814625e 100644 --- a/AK/kmalloc.cpp +++ b/AK/kmalloc.cpp @@ -134,6 +134,12 @@ static mi_heap_t* heap_for_partition(HeapPartition partition) case HeapPartition::JSObjectStorage: static mi_heap_t* js_object_storage_heap = mi_heap_new();...
[ "AK/kmalloc.cpp", "AK/kmalloc.h", "Libraries/LibWeb/CSS/StyleValues/StyleValue.h", "Libraries/LibWeb/Layout/FlexLayoutData.h", "Libraries/LibWeb/Layout/GridLayoutData.h", "Libraries/LibWeb/Layout/LayoutState.h", "Libraries/LibWeb/Layout/Node.h", "Libraries/LibWeb/Painting/Paintable.h", "Libraries/Li...
[]
true
LadybirdBrowser/ladybird
10,076
issue_to_patch
Meta: Remove Meta/Lagom
Noticed this directory is practically empty. Let's do a lagom amount of organization to remove it.
f47b6f32706fa6385cac85b43764c039f6bce6b1
f40e3ad0a8491be9e7680287a2eeea8cbfa95538
diff --git a/CMakeLists.txt b/CMakeLists.txt index cb1c2eb76430d..ae8c715910680 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -83,7 +83,7 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang$") # Vanilla host builds only for building the clang plugins if (ENABLE_CLANG_PLUGINS AND NOT CROSS_COMPILING AND NOT EN...
[ "CMakeLists.txt", "Documentation/AdvancedBuildInstructions.md", "Meta/CMake/get_linked_lagom_libraries.cmake", "Meta/ClangPlugins/CMakeLists.txt", "Meta/ClangPlugins/LambdaCapturePluginAction.cpp", "Meta/ClangPlugins/LambdaCapturePluginAction.h", "Meta/ClangPlugins/LibJSGCPluginAction.cpp", "Meta/Clan...
[]
true
LadybirdBrowser/ladybird
10,081
issue_to_patch
LibWeb: Reduce CSS parser token memory usage
Store CSS token payloads in a variant so each token only carries the state needed by its type. Keep delimiter, number, hash, string, and dimension data separate instead of storing every possible payload on every token. Use a smaller component-value token for function and block boundary metadata. These component valu...
2c33de1583acaa18a65e842fad413e12ae7d48fb
0ff99572c2dc0dd6c07b702c222f333fa15741d0
diff --git a/Libraries/LibWeb/CSS/Parser/ComponentValue.h b/Libraries/LibWeb/CSS/Parser/ComponentValue.h index 4bf8a3e3da3fd..ab3687752bdaf 100644 --- a/Libraries/LibWeb/CSS/Parser/ComponentValue.h +++ b/Libraries/LibWeb/CSS/Parser/ComponentValue.h @@ -60,6 +60,8 @@ class WEB_API ComponentValue { bool m_attr_taint...
[ "Libraries/LibWeb/CSS/Parser/ComponentValue.h", "Libraries/LibWeb/CSS/Parser/RustTokenizer.cpp", "Libraries/LibWeb/CSS/Parser/SourcePosition.h", "Libraries/LibWeb/CSS/Parser/Token.cpp", "Libraries/LibWeb/CSS/Parser/Token.h", "Libraries/LibWeb/CSS/Parser/Tokenizer.cpp", "Libraries/LibWeb/CSS/Parser/Types...
[]
true
LadybirdBrowser/ladybird
10,078
issue_to_patch
LibWeb: Avoid media rule reevaluation for matchMedia
Separate MediaQueryList change reporting from stylesheet media rule invalidation. Creating matchMedia() objects evaluates their own baseline state, but should not make the next style update walk all active stylesheets when the media environment has not changed. This avoids continuous stylesheet media query reevaluat...
347ac79e7b7cc5006be9263d79c97325049a2f3e
c2f47cde5537d7852358d70f933e261d45e144cc
diff --git a/Libraries/LibWeb/CSS/Invalidation/MediaQueryInvalidator.cpp b/Libraries/LibWeb/CSS/Invalidation/MediaQueryInvalidator.cpp index aef93b368cfd2..0324b0fd200c1 100644 --- a/Libraries/LibWeb/CSS/Invalidation/MediaQueryInvalidator.cpp +++ b/Libraries/LibWeb/CSS/Invalidation/MediaQueryInvalidator.cpp @@ -44,6 +4...
[ "Libraries/LibWeb/CSS/Invalidation/MediaQueryInvalidator.cpp", "Libraries/LibWeb/DOM/Document.cpp", "Libraries/LibWeb/DOM/Document.h", "Libraries/LibWeb/Internals/Internals.cpp", "Tests/LibWeb/Text/expected/css/style-invalidation/match-media-does-not-evaluate-rules.txt", "Tests/LibWeb/Text/input/css/style...
[]
diff --git a/Tests/LibWeb/Text/expected/css/style-invalidation/match-media-does-not-evaluate-rules.txt b/Tests/LibWeb/Text/expected/css/style-invalidation/match-media-does-not-evaluate-rules.txt new file mode 100644 index 0000000000000..3dc17bb5ccbba --- /dev/null +++ b/Tests/LibWeb/Text/expected/css/style-invalidation...
true
LadybirdBrowser/ladybird
10,057
issue_to_patch
Tests: Import a WPT test for cookie domain processing
Intention being to get some more cookie testing in tree and fix some bugs relating to handling it. This just starts importing a test where we have two issues - one where the test does not match the spec and another which is a bug. Will fix both separately, intention here is to get the test working in the first place.
0b9e59f61ff357b7d569fd08a398d9f4c413f8a0
46449352c8b4f47b9c6b11b8e0c619cee3907332
diff --git a/Libraries/LibWeb/Internals/Internals.cpp b/Libraries/LibWeb/Internals/Internals.cpp index 339e509c1713d..1d325944f24cd 100644 --- a/Libraries/LibWeb/Internals/Internals.cpp +++ b/Libraries/LibWeb/Internals/Internals.cpp @@ -478,6 +478,16 @@ void Internals::expire_cookies_with_time_offset(WebIDL::LongLong s...
[ "Libraries/LibWeb/Internals/Internals.cpp", "Libraries/LibWeb/Internals/Internals.h", "Libraries/LibWeb/Internals/Internals.idl", "Libraries/LibWeb/Page/Page.h", "Libraries/LibWebView/CookieJar.cpp", "Libraries/LibWebView/CookieJar.h", "Libraries/LibWebView/WebContentClient.cpp", "Libraries/LibWebView...
[]
diff --git a/Tests/LibWeb/TestConfig.ini b/Tests/LibWeb/TestConfig.ini index ee9e748dfb8f1..e4221ae580b96 100644 --- a/Tests/LibWeb/TestConfig.ini +++ b/Tests/LibWeb/TestConfig.ini @@ -1,6 +1,7 @@ [LoadFromHttpServer] -; Cookies require HTTP(s) scheme. +; Tests cookies. Text/input/cookie-working.html +Text/input/wpt-...
true
LadybirdBrowser/ladybird
10,075
issue_to_patch
Route all GL calls through generated GLFunctions
LibWeb's WebGL implementation currently reaches ANGLE by calling glFoo() throughout the WebGL context and extension code. That ties the WebGL spec layer to the concrete GL executor. A future backend that records operations, sends them to another process, or executes them from the Compositor would otherwise need to dupl...
6134119353b29f2c6dd681365f90c55854b7da33
b49ba8166cbcf1e23e8513655313b98b8badcf02
diff --git a/Libraries/LibWeb/CMakeLists.txt b/Libraries/LibWeb/CMakeLists.txt index bb7da143e280c..d38c2f793f760 100644 --- a/Libraries/LibWeb/CMakeLists.txt +++ b/Libraries/LibWeb/CMakeLists.txt @@ -1226,6 +1226,8 @@ generate_css_implementation() generate_html_implementation() +generate_webgl_implementation() + ...
[ "Libraries/LibWeb/CMakeLists.txt", "Libraries/LibWeb/WebGL/Extensions/ANGLEInstancedArrays.cpp", "Libraries/LibWeb/WebGL/Extensions/OESVertexArrayObject.cpp", "Libraries/LibWeb/WebGL/Extensions/WebGLDrawBuffers.cpp", "Libraries/LibWeb/WebGL/GLFunctions.json", "Libraries/LibWeb/WebGL/OpenGLContext.cpp", ...
[]
true
LadybirdBrowser/ladybird
10,074
issue_to_patch
LibIPC performance optimizations
See commit descriptions
6134119353b29f2c6dd681365f90c55854b7da33
fc432cce406f818af3ede8f91f1a5d8c51d4f178
diff --git a/Libraries/LibIPC/CMakeLists.txt b/Libraries/LibIPC/CMakeLists.txt index 62663b545b570..097092658517f 100644 --- a/Libraries/LibIPC/CMakeLists.txt +++ b/Libraries/LibIPC/CMakeLists.txt @@ -5,6 +5,7 @@ set(SOURCES Encoder.cpp File.cpp Message.cpp + ReceivedMessageBytes.cpp TransportHan...
[ "Libraries/LibIPC/CMakeLists.txt", "Libraries/LibIPC/Connection.cpp", "Libraries/LibIPC/Message.cpp", "Libraries/LibIPC/ReceivedMessageBytes.cpp", "Libraries/LibIPC/ReceivedMessageBytes.h", "Libraries/LibIPC/TransportMachPort.cpp", "Libraries/LibIPC/TransportMachPort.h", "Libraries/LibIPC/TransportSoc...
[]
true
LadybirdBrowser/ladybird
10,071
issue_to_patch
SIGSEGV in Web::HTML::HTMLMetaElement::inserted() Ladybird crashes with the following repro on Linux: ``` <!doctype html> <script> document.documentElement.remove(); const head = document.createElement("head"); const meta = document.createElement("meta"); meta.setAttribute("http-equiv", "content-language"); meta.setA...
LibWeb: Skip meta http-equiv processing outside a document tree
The pragma directives specification steps should only run when a meta element is inserted into the document, meaning it is in a document tree after the insertion steps have run. We previously ran the pragma algorithms for any insertion, so inserting a meta element with `http-equiv=content-language` into a detached subt...
de664c4c1269ab09f7f687e298e6aecd8bd0453c
9219341a6168e09a21472ed472c9d1bdef84c6a7
diff --git a/Libraries/LibWeb/HTML/HTMLMetaElement.cpp b/Libraries/LibWeb/HTML/HTMLMetaElement.cpp index da3c5663e1549..13df3c29357c6 100644 --- a/Libraries/LibWeb/HTML/HTMLMetaElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLMetaElement.cpp @@ -122,6 +122,9 @@ void HTMLMetaElement::inserted() // When a meta element is...
[ "Libraries/LibWeb/HTML/HTMLMetaElement.cpp", "Tests/LibWeb/Crash/HTML/meta-content-language-without-document-element.html" ]
[]
diff --git a/Tests/LibWeb/Crash/HTML/meta-content-language-without-document-element.html b/Tests/LibWeb/Crash/HTML/meta-content-language-without-document-element.html new file mode 100644 index 0000000000000..ccdbb6f48dd94 --- /dev/null +++ b/Tests/LibWeb/Crash/HTML/meta-content-language-without-document-element.html @...
true
LadybirdBrowser/ladybird
10,072
issue_to_patch
TIFF decode verification failure: i < m_size Loading the following repro on Linux creates a verification failure: ``` <!doctype html> <meta charset="utf-8"> <body> <script> const img = new Image(); img.onload = () => console.log("loaded", img.naturalWidth, img.naturalHeight); img.onerror = () => console.log("error"); ...
LibGfx+LibCompress+LibWeb: Remove TIFF image decoding
This is no longer widely supported by other engines and is a large attack surface for potential vulnerabilities. The Exif parsing parts of the TIFF loader have been extracted to a separate file. Fixes #9968 Fixes #10006
de664c4c1269ab09f7f687e298e6aecd8bd0453c
a92e0baac31b92b575a0cd52d01fa53439670afd
diff --git a/Libraries/LibCompress/CMakeLists.txt b/Libraries/LibCompress/CMakeLists.txt index 6c593d6615b80..0e54758c1ef5e 100644 --- a/Libraries/LibCompress/CMakeLists.txt +++ b/Libraries/LibCompress/CMakeLists.txt @@ -2,7 +2,6 @@ set(SOURCES Deflate.cpp GenericZlib.cpp Gzip.cpp - PackBitsDecoder.cp...
[ "Libraries/LibCompress/CMakeLists.txt", "Libraries/LibCompress/PackBitsDecoder.cpp", "Libraries/LibCompress/PackBitsDecoder.h", "Libraries/LibGfx/ImageFormats/CCITTDecoder.cpp", "Libraries/LibGfx/ImageFormats/CCITTDecoder.h", "Libraries/LibGfx/ImageFormats/ExifReader.cpp", "Libraries/LibGfx/ImageFormats...
[]
diff --git a/Tests/LibCompress/CMakeLists.txt b/Tests/LibCompress/CMakeLists.txt index 258f185eb5b3f..75b3d0b8cd898 100644 --- a/Tests/LibCompress/CMakeLists.txt +++ b/Tests/LibCompress/CMakeLists.txt @@ -2,7 +2,6 @@ set(TEST_SOURCES TestDeflate.cpp TestGzip.cpp TestLzw.cpp - TestPackBits.cpp Tes...
true
LadybirdBrowser/ladybird
10,073
issue_to_patch
UI/Qt: Present Linux DMABUF frames with QVulkanWindow
Use a native QVulkanWindow child to present Linux DMABUF compositor frames directly in the Qt UI. This keeps the main browser window on the normal QWidget backing store path while allowing web content to be sampled directly from shared GPU backing stores. The QWidget paint path remains available as a fallback when V...
6134119353b29f2c6dd681365f90c55854b7da33
1fae347727f663052281c551db12d4ae9a0ecd4f
diff --git a/Libraries/LibGfx/SharedImageBuffer.cpp b/Libraries/LibGfx/SharedImageBuffer.cpp index 0495a19fa5bee..e101dae905d1a 100644 --- a/Libraries/LibGfx/SharedImageBuffer.cpp +++ b/Libraries/LibGfx/SharedImageBuffer.cpp @@ -55,6 +55,14 @@ SharedImageBuffer::SharedImageBuffer(NonnullRefPtr<Bitmap> bitmap) : m_...
[ "Libraries/LibGfx/SharedImageBuffer.cpp", "Libraries/LibGfx/SharedImageBuffer.h", "Libraries/LibGfx/VulkanImage.cpp", "Meta/CMake/check_for_dependencies.cmake", "UI/Qt/Autocomplete.cpp", "UI/Qt/CMakeLists.txt", "UI/Qt/Shaders/WebContentViewLinux.frag", "UI/Qt/Shaders/WebContentViewLinux.vert", "UI/Q...
[ { "comment": "Each of these custom commands should have an `add_custom_target` associated with it that the ladybird binary also depends on. Per the pattern in other cmake files. Iirc the point of the pattern is to ensure files are regenerated when inputs change, and that downstream targets always pick up the up...
true
LadybirdBrowser/ladybird
10,073
comment_to_fix
UI/Qt: Present Linux DMABUF frames with QVulkanWindow
Each of these custom commands should have an `add_custom_target` associated with it that the ladybird binary also depends on. Per the pattern in other cmake files. Iirc the point of the pattern is to ensure files are regenerated when inputs change, and that downstream targets always pick up the updated edge. Even when ...
6134119353b29f2c6dd681365f90c55854b7da33
1fae347727f663052281c551db12d4ae9a0ecd4f
diff --git a/UI/Qt/CMakeLists.txt b/UI/Qt/CMakeLists.txt index 6cdbaf00a9c61..582d029c38782 100644 --- a/UI/Qt/CMakeLists.txt +++ b/UI/Qt/CMakeLists.txt @@ -4,8 +4,8 @@ set(CMAKE_AUTOUIC ON) find_package(Qt6 REQUIRED COMPONENTS Core Widgets) if (APPLE) - # The macOS QRhiWidget presentation path uses QRhi's priva...
[ "UI/Qt/CMakeLists.txt" ]
[ { "comment": "Each of these custom commands should have an `add_custom_target` associated with it that the ladybird binary also depends on. Per the pattern in other cmake files. Iirc the point of the pattern is to ensure files are regenerated when inputs change, and that downstream targets always pick up the up...
true
LadybirdBrowser/ladybird
10,077
issue_to_patch
LibSandbox: Permit `faccessat2`, `faccessat` and `fstatfs`
SDL enumerates connected input devices through libudev whenever a device is added or removed, which probes per-device metadata using `faccessat2` and `fstatfs`. These calls run after the seccomp filter is installed, and neither syscall was permitted, so connecting a gamepad killed the WebContent process with SIGSYS. We...
6134119353b29f2c6dd681365f90c55854b7da33
edabbbb164a816cf1b6b827fc001b230669140de
diff --git a/Libraries/LibSandbox/Seccomp.cpp b/Libraries/LibSandbox/Seccomp.cpp index 8279cc9db4f63..93066f7364499 100644 --- a/Libraries/LibSandbox/Seccomp.cpp +++ b/Libraries/LibSandbox/Seccomp.cpp @@ -84,6 +84,8 @@ static constexpr unsigned read_only_open_flags = O_CLOEXEC; #define IF_DEFINED_epoll_pwait(if_define...
[ "Libraries/LibSandbox/Seccomp.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,067
issue_to_patch
LibWeb: Reduce no-op style invalidation on chatgpt.com
This tightens several broad `:has()` and structural selector invalidation paths that were causing substantial no-op style recomputation on https://chatgpt.com/. The changes make interaction pseudo-class invalidation only schedule `:has()` ancestor work for scopes that actually mention the changed pseudo-class, avoid...
de664c4c1269ab09f7f687e298e6aecd8bd0453c
b1069e13dc18079595c9251c7c573d075b1a6098
diff --git a/Libraries/LibWeb/CSS/Invalidation/HasMutationInvalidator.cpp b/Libraries/LibWeb/CSS/Invalidation/HasMutationInvalidator.cpp index b8294373b5440..7f620ddbcb3dc 100644 --- a/Libraries/LibWeb/CSS/Invalidation/HasMutationInvalidator.cpp +++ b/Libraries/LibWeb/CSS/Invalidation/HasMutationInvalidator.cpp @@ -138...
[ "Libraries/LibWeb/CSS/Invalidation/HasMutationInvalidator.cpp", "Libraries/LibWeb/CSS/Invalidation/PseudoClassInvalidator.cpp", "Libraries/LibWeb/CSS/Invalidation/StructuralMutationInvalidator.cpp", "Libraries/LibWeb/CSS/Invalidation/StructuralMutationInvalidator.h", "Libraries/LibWeb/CSS/Invalidation/Style...
[]
diff --git a/Tests/LibWeb/Text/expected/css/style-invalidation/complex-has-descendant-does-not-poison-has-invalidation.txt b/Tests/LibWeb/Text/expected/css/style-invalidation/complex-has-descendant-does-not-poison-has-invalidation.txt new file mode 100644 index 0000000000000..6552a1aba05a1 --- /dev/null +++ b/Tests/Lib...
true
LadybirdBrowser/ladybird
9,978
issue_to_patch
Fuzzers: Avoid crash on empty input in MatroskaReader fuzzer
Previously, the fuzzer would crash on empty input because `IncrementallyPopulatedStream::add_chunk_at()` expects non-empty data.
8e746504167ae4ca2ca17757f872d67c8134f6c0
f6f9cdb201f270ae321264bfbf2d8a14fb6698b8
diff --git a/Meta/Lagom/Fuzzers/FuzzMatroskaReader.cpp b/Meta/Lagom/Fuzzers/FuzzMatroskaReader.cpp index be5b1db02b55d..0c49fdd152887 100644 --- a/Meta/Lagom/Fuzzers/FuzzMatroskaReader.cpp +++ b/Meta/Lagom/Fuzzers/FuzzMatroskaReader.cpp @@ -11,7 +11,12 @@ extern "C" int LLVMFuzzerTestOneInput(u8 const* data, size_t si...
[ "Meta/Lagom/Fuzzers/FuzzMatroskaReader.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,060
issue_to_patch
LibWeb: Restore context after culled display list effects
Effect culling can stop a visual context switch after applying some ancestor contexts. The player left those contexts on the painter stack even though the target command was skipped. Restore the painter stack back to the common ancestor when effect culling aborts the switch. Fixes the logo and background on the h...
2629c36dcc302eb8eb00eb3f83f223bf13066aad
6367b83c6d4fcb3acba352a0ca82617e49940ef5
diff --git a/Libraries/LibWeb/Painting/DisplayList.cpp b/Libraries/LibWeb/Painting/DisplayList.cpp index fd07697bb2a16..d45cec5125494 100644 --- a/Libraries/LibWeb/Painting/DisplayList.cpp +++ b/Libraries/LibWeb/Painting/DisplayList.cpp @@ -264,10 +264,13 @@ void DisplayListPlayer::execute_impl( return fal...
[ "Libraries/LibWeb/Painting/DisplayList.cpp", "Tests/LibWeb/Ref/expected/effect-culling-restores-previous-context-ref.html", "Tests/LibWeb/Ref/input/effect-culling-restores-previous-context.html" ]
[]
diff --git a/Tests/LibWeb/Ref/expected/effect-culling-restores-previous-context-ref.html b/Tests/LibWeb/Ref/expected/effect-culling-restores-previous-context-ref.html new file mode 100644 index 0000000000000..aaaa2c4adc1ae --- /dev/null +++ b/Tests/LibWeb/Ref/expected/effect-culling-restores-previous-context-ref.html @...
true
LadybirdBrowser/ladybird
10,064
issue_to_patch
LibGfx+LibWeb: Reuse matrix helpers and add some spec steps
Some cleanup/factoring work; no functional changes.
7390818b5a6e4444fb2acc482e9c6705ff88ebff
32d3c815e938112512e43ed5a7ada90221763316
diff --git a/Libraries/LibGfx/Matrix4x4.h b/Libraries/LibGfx/Matrix4x4.h index de15453bd0402..2b63a936c0e70 100644 --- a/Libraries/LibGfx/Matrix4x4.h +++ b/Libraries/LibGfx/Matrix4x4.h @@ -59,6 +59,16 @@ constexpr static Matrix4x4<T> scale_matrix(Vector3<T> const& s) 0, 0, 0, 1); } +template<typename T> +co...
[ "Libraries/LibGfx/Matrix4x4.h", "Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp", "Libraries/LibWeb/Page/ElementResizeAction.cpp", "Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp", "Libraries/LibWeb/Painting/Paintable.cpp", "Libraries/LibWeb/Painting/PaintableBox.h" ]
[]
true
LadybirdBrowser/ladybird
10,030
issue_to_patch
AK: Make Badge accept multiple types, including subclasses
There are several places where we really wanted to let multiple classes create a Badge, but we couldn't, and so had to jump through hoops to make it work. This PR makes that work, which simplifies those users. It's a bit verbose currently because [P2893R3 (variadic `friend`)](https://www.open-std.org/jtc1/sc22/wg21/...
45c499d18501a05f6bc59161b459ae81ed13db8b
ef7deea0ce856f19d2cc98d8ab1573461b0f4638
diff --git a/AK/Badge.h b/AK/Badge.h index 7733aa0d27ae8..dd43cb339dbfe 100644 --- a/AK/Badge.h +++ b/AK/Badge.h @@ -8,19 +8,123 @@ #include <AK/Noncopyable.h> #include <AK/Platform.h> +#include <AK/StdLibExtraDetails.h> namespace AK { +namespace Detail { + +template<typename AuthorizedType, typename BadgeType...
[ "AK/Badge.h", "AK/BufferedStream.h", "AK/Forward.h", "AK/StringBase.h", "AK/StringBuilder.h", "Libraries/LibCore/Socket.h", "Libraries/LibWeb/CSS/Parser/Token.cpp", "Libraries/LibWeb/CSS/Parser/Token.h", "Libraries/LibWeb/DOM/Document.h", "Libraries/LibWeb/DOM/Element.h", "Libraries/LibWeb/DOM/N...
[]
diff --git a/Tests/AK/TestBadge.cpp b/Tests/AK/TestBadge.cpp index 8f12b9dcb3faf..91c9b1b9ccc09 100644 --- a/Tests/AK/TestBadge.cpp +++ b/Tests/AK/TestBadge.cpp @@ -8,7 +8,185 @@ #include <AK/Badge.h> +namespace { + +struct MultipleBadgeUserA { + static void call_two_argument_badge(); + static void call_thre...
true
LadybirdBrowser/ladybird
10,063
issue_to_patch
LibWeb: Apply the z component of transform-origin
compute_transform() resolved transform-origin to a 2D point, so 3D rotations pivoted around the element's own plane. Build the conjugation T(0, 0, z) * M * T(0, 0, -z) into the matrix instead; this composes with the 2D origin at paint time into the full 3D conjugation. Corrects the initial view transformation for ht...
2629c36dcc302eb8eb00eb3f83f223bf13066aad
a011a68dc84572edacabb2c4c5b3732cf958d991
diff --git a/Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp b/Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp index bd24aded021b8..2cb5efd5e8113 100644 --- a/Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp +++ b/Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp @@ -94,7 +94,13 @@ static Optio...
[ "Libraries/LibWeb/Painting/AccumulatedVisualContext.cpp", "Tests/LibWeb/Ref/expected/wpt-import/css/css-transforms/transform3d-translate3d-ref.html", "Tests/LibWeb/Ref/expected/wpt-import/css/css-transforms/transform3d-translatez-notref.html", "Tests/LibWeb/Ref/expected/wpt-import/css/css-transforms/transform...
[]
diff --git a/Tests/LibWeb/Ref/expected/wpt-import/css/css-transforms/transform3d-translate3d-ref.html b/Tests/LibWeb/Ref/expected/wpt-import/css/css-transforms/transform3d-translate3d-ref.html new file mode 100644 index 0000000000000..c79a7efb832c4 --- /dev/null +++ b/Tests/LibWeb/Ref/expected/wpt-import/css/css-transf...
true
LadybirdBrowser/ladybird
10,050
issue_to_patch
LibMedia: Don't display video frames that are late
Frames are considered late if the time is ahead by half their duration. The fudging is necessary because Matroska (and perhaps other formats) store their frame durations in different time units than their timestamps. Skipping these should make it clear when decoding is running behind, instead of displaying the video...
9e2a82088440fdc17878052af2dc17fbb133d95e
a886d98216e605cf4031df2dc5b709fdf5193889
diff --git a/Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp b/Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp index a7c873ecad03d..77e8667c4cdad 100644 --- a/Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp +++ b/Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp @@ -42,7 +42,6 @@ void DisplayingVideoSink::consume_mov...
[ "Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp", "Libraries/LibMedia/Sinks/DisplayingVideoSink.h" ]
[]
true
LadybirdBrowser/ladybird
10,061
issue_to_patch
LibWeb/Bindings: Don't install inherited members on global objects
When generating global mixins, only define regular members from the [Global] interface itself on the global object. Inherited members remain available through the prototype chain. This was found due to a timeout on: https://wpt.live/html/dom/idlharness.any.worker.html Installing inherited members created fresh...
2629c36dcc302eb8eb00eb3f83f223bf13066aad
516c73b5b894b6f9bf135a7e6cb337e9e3d1ee68
diff --git a/Meta/Generators/libweb_bindings/global_mixins.py b/Meta/Generators/libweb_bindings/global_mixins.py index ea9b291f340bc..ab29015c6060b 100644 --- a/Meta/Generators/libweb_bindings/global_mixins.py +++ b/Meta/Generators/libweb_bindings/global_mixins.py @@ -24,14 +24,6 @@ from Utils.webidl_parser import Int...
[ "Meta/Generators/libweb_bindings/global_mixins.py", "Tests/LibWeb/Text/expected/Worker/WorkerGlobalScope-inherited-properties.txt", "Tests/LibWeb/Text/input/Worker/WorkerGlobalScope-inherited-properties.html" ]
[]
diff --git a/Tests/LibWeb/Text/expected/Worker/WorkerGlobalScope-inherited-properties.txt b/Tests/LibWeb/Text/expected/Worker/WorkerGlobalScope-inherited-properties.txt new file mode 100644 index 0000000000000..71b6873c58fc6 --- /dev/null +++ b/Tests/LibWeb/Text/expected/Worker/WorkerGlobalScope-inherited-properties.tx...
true
LadybirdBrowser/ladybird
10,059
issue_to_patch
LibWeb/Bindings: Preserve object EventHandler assignments
EventHandler attributes are nullable callback function attributes with [LegacyTreatNonObjectAsNull]. Assigning a non-object value should produce null, but assigning an object value should preserve that object as the callback value, even when the object is not callable. Previously, object values such as `{ handleE...
2629c36dcc302eb8eb00eb3f83f223bf13066aad
3d8a1b04dc3aea499c004ba9494107978291c5dc
diff --git a/Meta/Generators/libweb_bindings/to_idl_value.py b/Meta/Generators/libweb_bindings/to_idl_value.py index 76fe4fb4db15d..6816796057954 100644 --- a/Meta/Generators/libweb_bindings/to_idl_value.py +++ b/Meta/Generators/libweb_bindings/to_idl_value.py @@ -19,7 +19,6 @@ from Generators.libweb_bindings.cpp_type...
[ "Meta/Generators/libweb_bindings/to_idl_value.py", "Tests/LibWeb/Text/expected/wpt-import/workers/constructors/SharedWorker/setting-port-members.txt", "Tests/LibWeb/Text/input/wpt-import/workers/constructors/SharedWorker/#', '", "Tests/LibWeb/Text/input/wpt-import/workers/constructors/SharedWorker/setting-por...
[]
diff --git a/Tests/LibWeb/Text/expected/wpt-import/workers/constructors/SharedWorker/setting-port-members.txt b/Tests/LibWeb/Text/expected/wpt-import/workers/constructors/SharedWorker/setting-port-members.txt new file mode 100644 index 0000000000000..8fb77de55a69f --- /dev/null +++ b/Tests/LibWeb/Text/expected/wpt-impo...
true
LadybirdBrowser/ladybird
10,058
issue_to_patch
HTML spec change potpourri
A handful of small random spec changes that have been piling up in my GitHub notifications.
0b9e59f61ff357b7d569fd08a398d9f4c413f8a0
dd1438b297d80a72e43de42f1e07b7ec5273f711
diff --git a/Libraries/LibWeb/DOM/Element.cpp b/Libraries/LibWeb/DOM/Element.cpp index fa69901c9960e..ded014b9c26c1 100644 --- a/Libraries/LibWeb/DOM/Element.cpp +++ b/Libraries/LibWeb/DOM/Element.cpp @@ -2478,13 +2478,19 @@ bool Element::is_actually_disabled() const return !form_associated_element.enabled(); ...
[ "Libraries/LibWeb/DOM/Element.cpp", "Libraries/LibWeb/HTML/HTMLButtonElement.cpp", "Libraries/LibWeb/HTML/HTMLIFrameElement.cpp", "Libraries/LibWeb/HTML/HTMLIFrameElement.h", "Libraries/LibWeb/HTML/HTMLImageElement.cpp", "Libraries/LibWeb/HTML/HTMLOptionElement.cpp", "Libraries/LibWeb/HTML/HTMLOptionEle...
[]
true
LadybirdBrowser/ladybird
10,035
issue_to_patch
DevTools: Add cookie display and modification
<img width="1164" height="194" alt="image" src="https://github.com/user-attachments/assets/65eeec64-54a8-4270-a449-6133b1428f0c" />
ca6911bacfebdb62869ea7c84102bbc237d1da1a
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
diff --git a/Libraries/LibDevTools/Actors/CookiesActor.cpp b/Libraries/LibDevTools/Actors/CookiesActor.cpp new file mode 100644 index 0000000000000..54895f9c3f6ae --- /dev/null +++ b/Libraries/LibDevTools/Actors/CookiesActor.cpp @@ -0,0 +1,736 @@ +/* + * Copyright (c) 2026, Ladybird contributors + * + * SPDX-License-Id...
[ "Libraries/LibDevTools/Actors/CookiesActor.cpp", "Libraries/LibDevTools/Actors/CookiesActor.h", "Libraries/LibDevTools/Actors/WatcherActor.cpp", "Libraries/LibDevTools/Actors/WatcherActor.h", "Libraries/LibDevTools/CMakeLists.txt", "Libraries/LibDevTools/DevToolsDelegate.h", "Libraries/LibDevTools/Forwa...
[ { "comment": "What is meant by a storage host? Is this the same as an origin?", "path": "Libraries/LibDevTools/Actors/CookiesActor.cpp", "hunk": "@@ -0,0 +1,147 @@\n+/*\n+ * Copyright (c) 2026, Ladybird contributors\n+ *\n+ * SPDX-License-Identifier: BSD-2-Clause\n+ */\n+\n+#include <AK/JsonArray.h>\n+#...
diff --git a/Tests/LibDevTools/TestDevToolsProtocol.cpp b/Tests/LibDevTools/TestDevToolsProtocol.cpp index 3ff63084d58a3..7b1713e013306 100644 --- a/Tests/LibDevTools/TestDevToolsProtocol.cpp +++ b/Tests/LibDevTools/TestDevToolsProtocol.cpp @@ -17,6 +17,7 @@ #include <LibDevTools/Connection.h> #include <LibDevTools/D...
true
LadybirdBrowser/ladybird
10,035
comment_to_fix
DevTools: Add cookie display and modification
What is meant by a storage host? Is this the same as an origin?
ca6911bacfebdb62869ea7c84102bbc237d1da1a
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
diff --git a/Libraries/LibDevTools/Actors/CookiesActor.cpp b/Libraries/LibDevTools/Actors/CookiesActor.cpp new file mode 100644 index 0000000000000..54895f9c3f6ae --- /dev/null +++ b/Libraries/LibDevTools/Actors/CookiesActor.cpp @@ -0,0 +1,736 @@ +/* + * Copyright (c) 2026, Ladybird contributors + * + * SPDX-License-Id...
[ "Libraries/LibDevTools/Actors/CookiesActor.cpp" ]
[ { "comment": "What is meant by a storage host? Is this the same as an origin?", "path": "Libraries/LibDevTools/Actors/CookiesActor.cpp", "hunk": "@@ -0,0 +1,147 @@\n+/*\n+ * Copyright (c) 2026, Ladybird contributors\n+ *\n+ * SPDX-License-Identifier: BSD-2-Clause\n+ */\n+\n+#include <AK/JsonArray.h>\n+#...
true
LadybirdBrowser/ladybird
10,035
comment_to_fix
DevTools: Add cookie display and modification
Is there a particular reason we need something specific to validating a cookie from devtools, what makes this different to any other cookie?
ca6911bacfebdb62869ea7c84102bbc237d1da1a
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
diff --git a/Libraries/LibWebView/CookieJar.cpp b/Libraries/LibWebView/CookieJar.cpp index ef12748c73d46..96c9c93dfb2c3 100644 --- a/Libraries/LibWebView/CookieJar.cpp +++ b/Libraries/LibWebView/CookieJar.cpp @@ -25,6 +25,34 @@ namespace WebView { static constexpr auto DATABASE_SYNCHRONIZATION_TIMER = AK::Duration::...
[ "Libraries/LibWebView/CookieJar.cpp" ]
[ { "comment": "Is there a particular reason we need something specific to validating a cookie from devtools, what makes this different to any other cookie?", "path": "Libraries/LibWebView/CookieJar.cpp", "hunk": "@@ -25,6 +25,61 @@ namespace WebView {\n \n static constexpr auto DATABASE_SYNCHRONIZATION_T...
true
LadybirdBrowser/ladybird
10,055
issue_to_patch
DevTools: Add localStorage and sessionStorage support
Similar to the cookies support really, just with the web storage API things. Comes with a bonus commit to add a "dump session storage" debug menu option, because we didn't have that and I needed it to verify that the session storage modifications were working.
aa4139d00220a4e8d1f59aea0ece20a9929a6c85
9ab4cb512167adbd8e0ef9d6e7f4fa63b31af6b5
diff --git a/Libraries/LibDevTools/Actors/CookiesActor.cpp b/Libraries/LibDevTools/Actors/CookiesActor.cpp index 54895f9c3f6ae..73962eb324661 100644 --- a/Libraries/LibDevTools/Actors/CookiesActor.cpp +++ b/Libraries/LibDevTools/Actors/CookiesActor.cpp @@ -81,26 +81,6 @@ static bool cookie_matches_requested_domain(HTTP...
[ "Libraries/LibDevTools/Actors/CookiesActor.cpp", "Libraries/LibDevTools/Actors/StorageActor.cpp", "Libraries/LibDevTools/Actors/StorageActor.h", "Libraries/LibDevTools/Actors/WatcherActor.cpp", "Libraries/LibDevTools/Actors/WatcherActor.h", "Libraries/LibDevTools/CMakeLists.txt", "Libraries/LibDevTools/...
[]
diff --git a/Tests/LibDevTools/TestDevToolsProtocol.cpp b/Tests/LibDevTools/TestDevToolsProtocol.cpp index 7b1713e013306..e16722c9d4d60 100644 --- a/Tests/LibDevTools/TestDevToolsProtocol.cpp +++ b/Tests/LibDevTools/TestDevToolsProtocol.cpp @@ -547,7 +547,7 @@ class TestDevToolsDelegate final : public DevTools::DevTool...
true
LadybirdBrowser/ladybird
10,013
issue_to_patch
LibWeb: Track CORS-cross-origin image data for canvas tainting
See commit messages for details. Some initial work towards https://github.com/LadybirdBrowser/ladybird/issues/10009. Had this sitting locally for a while, but since I saw that issue raised this upstreams a little slice working towards that. Also includes a change to get WPT server substitutions working to support ev...
ddbc3e200642d365c64bcb6664fd2e0bd1e99aa0
062f27f52414ffe267c6fcb772b254f164cae417
diff --git a/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp b/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp index aebf05cfbabdc..66d94d9a964a8 100644 --- a/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp +++ b/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp @@ -29,6 +29,7 @@ #include <LibWeb/CSS/StyleVa...
[ "Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp", "Libraries/LibWeb/HTML/DecodedImageData.h", "Libraries/LibWeb/HTML/SharedResourceRequest.cpp", "Libraries/LibWeb/HTML/SharedResourceRequest.h", "Tests/LibWeb/Fixtures/http-test-server.py", "Tests/LibWeb/TestConfig.ini", "Tests/LibWeb/Text/expected/wp...
[]
diff --git a/Tests/LibWeb/Fixtures/http-test-server.py b/Tests/LibWeb/Fixtures/http-test-server.py index f17833a00b20f..fd16fff4b8b64 100755 --- a/Tests/LibWeb/Fixtures/http-test-server.py +++ b/Tests/LibWeb/Fixtures/http-test-server.py @@ -4,7 +4,9 @@ import base64 import hashlib import http.server +import itertool...
true
LadybirdBrowser/ladybird
10,054
issue_to_patch
LibWeb: Track SVG use elements in a document list
This replaces document-wide SVG scans for `<use>` invalidation with a per-document intrusive list of connected `SVGUseElement`s. This avoids repeatedly walking large SVG documents when SVG elements are inserted, removed, or changed. The change also handles the edge cases needed to keep the list correct: - re-reso...
7b6e94a4458764f7bb20754999c595f2c397bc37
4ff1bbaa99a47d043dcdd0f749e528b64bba41a0
diff --git a/Libraries/LibWeb/DOM/Document.cpp b/Libraries/LibWeb/DOM/Document.cpp index 45a3dcef325d3..1b673f5e7a4eb 100644 --- a/Libraries/LibWeb/DOM/Document.cpp +++ b/Libraries/LibWeb/DOM/Document.cpp @@ -206,6 +206,7 @@ #include <LibWeb/SVG/SVGScriptElement.h> #include <LibWeb/SVG/SVGStyleElement.h> #include <L...
[ "Libraries/LibWeb/DOM/Document.cpp", "Libraries/LibWeb/DOM/Document.h", "Libraries/LibWeb/DOM/ParentNode.cpp", "Libraries/LibWeb/SVG/SVGElement.cpp", "Libraries/LibWeb/SVG/SVGUseElement.cpp", "Libraries/LibWeb/SVG/SVGUseElement.h", "Tests/LibWeb/Text/expected/SVG/use-element-inserted-together-with-refer...
[]
diff --git a/Tests/LibWeb/Text/expected/SVG/use-element-inserted-together-with-referenced-element.txt b/Tests/LibWeb/Text/expected/SVG/use-element-inserted-together-with-referenced-element.txt new file mode 100644 index 0000000000000..0578c305ad1c2 --- /dev/null +++ b/Tests/LibWeb/Text/expected/SVG/use-element-inserted...
true
LadybirdBrowser/ladybird
10,052
issue_to_patch
LibWeb: Connect iframe referrerpolicy to ancestorOrigins
This is a spec change. I realised too late that we don't yet implement ancestorOrigins, because of [an issue](https://github.com/whatwg/html/issues/1918) that has now been resolved. But this at least wires up the iframe referrerpolicy part of that. 😅
7b6e94a4458764f7bb20754999c595f2c397bc37
f7653ab360ffbda871dd2db89a5e2faa5b7b02d1
diff --git a/Libraries/LibWeb/DOM/Document.cpp b/Libraries/LibWeb/DOM/Document.cpp index 690a988ec928b..91aa298d87260 100644 --- a/Libraries/LibWeb/DOM/Document.cpp +++ b/Libraries/LibWeb/DOM/Document.cpp @@ -119,6 +119,7 @@ #include <LibWeb/HTML/CustomElements/CustomElementDefinition.h> #include <LibWeb/HTML/CustomE...
[ "Libraries/LibWeb/DOM/Document.cpp", "Libraries/LibWeb/DOM/Document.h", "Libraries/LibWeb/DOM/DocumentLoading.h", "Libraries/LibWeb/HTML/BrowsingContext.cpp", "Libraries/LibWeb/HTML/HTMLIFrameElement.cpp", "Libraries/LibWeb/HTML/HTMLIFrameElement.h", "Libraries/LibWeb/HTML/Navigable.cpp", "Libraries/L...
[]
true
LadybirdBrowser/ladybird
10,051
issue_to_patch
LibWebView: A couple `about:history` fixes
A hover color tweak, and elide overflown title rows. Before: <img width="1147" height="385" alt="before" src="https://github.com/user-attachments/assets/3bd46a10-94eb-4046-a822-a5293a11b402" /> After: <img width="879" height="385" alt="after" src="https://github.com/user-attachments/assets/9fda5ae2-1a96-4723-ab...
7b6e94a4458764f7bb20754999c595f2c397bc37
652da0f09a0d04907c9272921503f1f8e11b5766
diff --git a/Base/res/ladybird/about-pages/history.html b/Base/res/ladybird/about-pages/history.html index 24738b0433ec1..6be6e9db4f115 100644 --- a/Base/res/ladybird/about-pages/history.html +++ b/Base/res/ladybird/about-pages/history.html @@ -6,6 +6,18 @@ <link rel="stylesheet" type="text/css" href="resource...
[ "Base/res/ladybird/about-pages/history.html" ]
[]
true
LadybirdBrowser/ladybird
10,049
issue_to_patch
UI/Qt: Add tab hover previews
Show a delayed preview popup when hovering background tabs. Build the thumbnail from the cached front or backup WebContent bitmap so chrome does not need a fresh screenshot request or WebContent repaint on hover. Tie the popup to the tab hover lifecycle and hide it on current-tab hovers, tab presses, drags, layout c...
ca6911bacfebdb62869ea7c84102bbc237d1da1a
01a986a417a2291a37fd4c25d254a102cbfb1517
diff --git a/UI/Qt/TabBar.cpp b/UI/Qt/TabBar.cpp index dd74db31a3daf..8b2a39d7ed959 100644 --- a/UI/Qt/TabBar.cpp +++ b/UI/Qt/TabBar.cpp @@ -16,6 +16,7 @@ # include <UI/Qt/MacWindow.h> #endif #include <UI/Qt/Menu.h> +#include <UI/Qt/StringUtils.h> #include <UI/Qt/Tab.h> #include <UI/Qt/TabBar.h> #include <UI/Q...
[ "UI/Qt/TabBar.cpp", "UI/Qt/TabBar.h", "UI/Qt/WebContentView.cpp", "UI/Qt/WebContentView.h" ]
[]
true
LadybirdBrowser/ladybird
10,044
issue_to_patch
LibMedia+LibWeb: Consolidate sink state tracking for buffering/seeking/ending
See individual commits, there are some bug fixes mixed in that were relevant to the changes and the testing they involved. tl;dr: `PlaybackManager` now uses the same status combination function that `AudioMixer` does to determine the output state. That state is then dispatched to the state handlers to allow them to ...
ca6911bacfebdb62869ea7c84102bbc237d1da1a
f29fe41c93bddc9369a79d353d5ec65249d04c2d
diff --git a/Libraries/LibMedia/CMakeLists.txt b/Libraries/LibMedia/CMakeLists.txt index e60585fb7ac7e..9cd10e14d0cba 100644 --- a/Libraries/LibMedia/CMakeLists.txt +++ b/Libraries/LibMedia/CMakeLists.txt @@ -21,6 +21,8 @@ set(SOURCES GenericTimeProvider.cpp IncrementallyPopulatedStream.cpp PlaybackManag...
[ "Libraries/LibMedia/CMakeLists.txt", "Libraries/LibMedia/PipelineStatus.h", "Libraries/LibMedia/PlaybackManager.cpp", "Libraries/LibMedia/PlaybackManager.h", "Libraries/LibMedia/PlaybackStates/BufferingStateHandler.cpp", "Libraries/LibMedia/PlaybackStates/BufferingStateHandler.h", "Libraries/LibMedia/Pl...
[]
diff --git a/Tests/LibWeb/Text/expected/HTML/HTMLVideoElement-resize-event-during-playback.txt b/Tests/LibWeb/Text/expected/HTML/HTMLVideoElement-resize-event-during-playback.txt index 670c49a1c4e48..1b608bcd605e7 100644 --- a/Tests/LibWeb/Text/expected/HTML/HTMLVideoElement-resize-event-during-playback.txt +++ b/Tests...
true
LadybirdBrowser/ladybird
10,048
issue_to_patch
UI/Qt: Use Ctrl+, for Settings outside macOS
abfd5ab860cc9901d57e8247fe6edfd06725802f
42e18735c3009bc3c0380201d758fb9a9e8afac8
diff --git a/UI/Qt/Menu.cpp b/UI/Qt/Menu.cpp index 2757eca4bffaf..fdbf477e8fb09 100644 --- a/UI/Qt/Menu.cpp +++ b/UI/Qt/Menu.cpp @@ -218,7 +218,11 @@ static void initialize_native_control(WebView::Action& action, QAction& qaction, qaction.setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_M)); br...
[ "UI/Qt/Menu.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,046
issue_to_patch
UI/Qt: Draw a border around frameless windows
When using client-side decorations, the window was a flat rectangle with no outline, so its edge disappeared against similarly colored backgrounds. Paint a 1px border in a new chrome window outline color and reserve a matching 1px contents margin so child widgets do not cover it. The outline color matches chrome_bor...
abfd5ab860cc9901d57e8247fe6edfd06725802f
93c0aae0d24c05d527e4df480f23d87cdd3c686c
diff --git a/UI/Qt/BrowserWindow.cpp b/UI/Qt/BrowserWindow.cpp index 485d0d112abaf..5cd33dd7d416f 100644 --- a/UI/Qt/BrowserWindow.cpp +++ b/UI/Qt/BrowserWindow.cpp @@ -43,6 +43,7 @@ #include <QMenuBar> #include <QMessageBox> #include <QMouseEvent> +#include <QPainter> #include <QPlatformSurfaceEvent> #include <QP...
[ "UI/Qt/BrowserWindow.cpp", "UI/Qt/BrowserWindow.h", "UI/Qt/ChromeStyle.cpp", "UI/Qt/ChromeStyle.h" ]
[]
true
LadybirdBrowser/ladybird
10,047
issue_to_patch
UI/Qt: Tint missing find-in-page results
Mark the search field with a dynamic property when a find-in-page query has zero matches, and let the chrome stylesheet show a red-tinted background. Clear the state immediately for empty searches.
abfd5ab860cc9901d57e8247fe6edfd06725802f
c417bfc881fdbbdbe7c5783f01327c90167d96c1
diff --git a/UI/Qt/ChromeStyle.cpp b/UI/Qt/ChromeStyle.cpp index 1a55b3b252ca2..297e1fd3a5518 100644 --- a/UI/Qt/ChromeStyle.cpp +++ b/UI/Qt/ChromeStyle.cpp @@ -650,14 +650,18 @@ QToolBar#LadybirdBookmarksBar QToolButton:checked {{ QString find_in_page_style_sheet(QPalette const& palette) { auto background = sty...
[ "UI/Qt/ChromeStyle.cpp", "UI/Qt/FindInPageWidget.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,032
issue_to_patch
Tests: Make JSON.stringify deep serialization test more consistent
This test verifies that we throw an exception instead of overflowing the stack, but some machines have a large enough stack that this wouldn't fill it. Raise the value by 10x, which does now throw an exception for me.
45c499d18501a05f6bc59161b459ae81ed13db8b
b6e93911e5565dde92c283564a8a8fab7486cb58
[ "Tests/LibJS/Runtime/builtins/JSON/JSON.stringify.js" ]
[]
diff --git a/Tests/LibJS/Runtime/builtins/JSON/JSON.stringify.js b/Tests/LibJS/Runtime/builtins/JSON/JSON.stringify.js index f8cc630de7ab5..97bc5541f2bcb 100644 --- a/Tests/LibJS/Runtime/builtins/JSON/JSON.stringify.js +++ b/Tests/LibJS/Runtime/builtins/JSON/JSON.stringify.js @@ -152,7 +152,7 @@ describe("errors", () =...
true
LadybirdBrowser/ladybird
10,037
issue_to_patch
LibWeb/HTML: Ignore if select has `multiple` to determine placeholder
Corresponds to: https://github.com/whatwg/html/commit/d59fb13c28c62d50f103a95577f15fc1e8bd7500 WPT has tests for this, but we don't implement listbox layout for select so there's no testable difference here.
19dd5bef6004ac847533a53b31d57eb7ab7b65c8
078522acd3540ea63059ba2f08b4183bb3842b15
diff --git a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp index 09fdb8f140219..44df1e119649a 100644 --- a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp @@ -852,11 +852,11 @@ bool HTMLSelectElement::is_focusable() const // http...
[ "Libraries/LibWeb/HTML/HTMLSelectElement.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,043
issue_to_patch
LibWeb: Transfer the load delayer when a media element is adopted
Otherwise, the load event will block the original document until GC runs. This makes the run time of media-load-task-after-adoption.html not depend on the GC idle timeout.
ddbc3e200642d365c64bcb6664fd2e0bd1e99aa0
578c09b66d7efd1f2a508b7061ac23d2c86d5210
diff --git a/Libraries/LibWeb/DOM/StyleElementBase.h b/Libraries/LibWeb/DOM/StyleElementBase.h index b36e7a391302d..dfcd385773cdc 100644 --- a/Libraries/LibWeb/DOM/StyleElementBase.h +++ b/Libraries/LibWeb/DOM/StyleElementBase.h @@ -43,6 +43,12 @@ class StyleElementBase { void visit_style_element_edges(JS::Cell:...
[ "Libraries/LibWeb/DOM/StyleElementBase.h", "Libraries/LibWeb/HTML/HTMLImageElement.cpp", "Libraries/LibWeb/HTML/HTMLInputElement.cpp", "Libraries/LibWeb/HTML/HTMLInputElement.h", "Libraries/LibWeb/HTML/HTMLLinkElement.cpp", "Libraries/LibWeb/HTML/HTMLLinkElement.h", "Libraries/LibWeb/HTML/HTMLMediaEleme...
[]
true
LadybirdBrowser/ladybird
10,045
issue_to_patch
LibWeb: Avoid pruning live CSS image resources
Keep decoded image resources alive while they are backing a CSS image resource for the document. Pruning these entries can make background images temporarily non-paintable during display-list recording, causing visible blank frames until the resource is requested again.
ddbc3e200642d365c64bcb6664fd2e0bd1e99aa0
6d1b64b82b2ba424218b337db37a07ad10bca2a9
diff --git a/Libraries/LibWeb/DOM/Document.cpp b/Libraries/LibWeb/DOM/Document.cpp index 690a988ec928b..45a3dcef325d3 100644 --- a/Libraries/LibWeb/DOM/Document.cpp +++ b/Libraries/LibWeb/DOM/Document.cpp @@ -6776,6 +6776,11 @@ void Document::prune_image_resource_caches() static constexpr size_t decoded_image_reso...
[ "Libraries/LibWeb/DOM/Document.cpp" ]
[]
true
LadybirdBrowser/ladybird
10,042
issue_to_patch
LibSandbox: Add macOS service sandboxing
Add Seatbelt-based macOS sandboxing for the browser service processes. The shared profile builder grants only the filesystem, network, Mach, and process execution permissions each service needs, with fatal sandbox violation reporting enabled so denials are visible during development. Wire sandbox profiles into WebCo...
3424c08b27c25b3453e89722d3e6f8fac356eaf3
df3d67fd8ff49e38eaaff8ab3f26acb151bd66d9
diff --git a/Libraries/LibSandbox/Sandbox.cpp b/Libraries/LibSandbox/Sandbox.cpp index 702b0510e9c4a..0dff64dcb5a5c 100644 --- a/Libraries/LibSandbox/Sandbox.cpp +++ b/Libraries/LibSandbox/Sandbox.cpp @@ -19,6 +19,22 @@ # include <unistd.h> #endif +#if defined(AK_OS_MACOS) +# include <AK/LexicalPath.h> +# ...
[ "Libraries/LibSandbox/Sandbox.cpp", "Libraries/LibSandbox/Sandbox.h", "Services/Compositor/CMakeLists.txt", "Services/Compositor/SandboxMacOS.cpp", "Services/ImageDecoder/CMakeLists.txt", "Services/ImageDecoder/SandboxMacOS.cpp", "Services/RendererSandboxMacOS.cpp", "Services/RequestServer/CMakeLists....
[]
true
LadybirdBrowser/ladybird
10,038
issue_to_patch
LibWebView: Add `about:history` to view, query and mangage browser history
This adds a WebUI to view the local browsing history, with controls to search and delete entries. The APIs used to search history are paginated to prevent excessive query sizes. [history.webm](https://github.com/user-attachments/assets/00800083-ef10-49bc-a726-67e72c3fc21d)
19dd5bef6004ac847533a53b31d57eb7ab7b65c8
1cd378160136f1d2c8115b4f74e712f4995fdb7c
diff --git a/Base/res/ladybird/about-pages/bookmarks.html b/Base/res/ladybird/about-pages/bookmarks.html index 9f90d2353c998..f976514493082 100644 --- a/Base/res/ladybird/about-pages/bookmarks.html +++ b/Base/res/ladybird/about-pages/bookmarks.html @@ -6,102 +6,13 @@ <link rel="stylesheet" type="text/css" href...
[ "Base/res/ladybird/about-pages/bookmarks.html", "Base/res/ladybird/about-pages/history.html", "Base/res/ladybird/about-pages/webui.css", "Libraries/LibURL/InternalURLs.h", "Libraries/LibURL/URL.h", "Libraries/LibWeb/HTML/Scripting/Environments.cpp", "Libraries/LibWeb/SecureContexts/AbstractOperations.cp...
[]
diff --git a/Tests/LibWebView/TestHistoryStore.cpp b/Tests/LibWebView/TestHistoryStore.cpp index 03acb0ca0414e..e1b6588930be2 100644 --- a/Tests/LibWebView/TestHistoryStore.cpp +++ b/Tests/LibWebView/TestHistoryStore.cpp @@ -87,6 +87,59 @@ static void expect_history_autocomplete_entries_include_metadata(WebView::Histor...
true
Lanayx/Oxpecker
94
issue_to_patch
Htmx4 and AlpineJS initial support
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/Oxpecker.slnx b/Oxpecker.slnx index ee20bf45..97b0f390 100644 --- a/Oxpecker.slnx +++ b/Oxpecker.slnx @@ -14,12 +14,15 @@ <Project Path="examples/MCP/Server/Server.fsproj" /> </Folder> <Folder Name="/src/"> + <Project Path="src/Oxpecker.Alpine/Oxpecker.Alpine.fsproj" /> <Project Path="sr...
[ "Oxpecker.slnx", "README.md", "examples/Basic/Program.fs", "examples/ContactApp/Handlers.fs", "examples/ContactApp/templates/edit.fs", "examples/ContactApp/templates/index.fs", "examples/ContactApp/templates/shared/contactFields.fs", "examples/ContactApp/templates/shared/layout.fs", "examples/Weathe...
[ { "comment": "The examples now load htmx via the floating `@next` tag. This makes the sample non-reproducible (a future htmx4 prerelease could break the demo without any repo change). Consider pinning to a specific htmx 4 version (or commit/tag) and updating intentionally when needed; alternatively document exp...
diff --git a/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..251ff29f --- /dev/null +++ b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs @@ -0,0 +1,187 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Alpine +o...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The examples now load htmx via the floating `@next` tag. This makes the sample non-reproducible (a future htmx4 prerelease could break the demo without any repo change). Consider pinning to a specific htmx 4 version (or commit/tag) and updating intentionally when needed; alternatively document explicitly why `@next` is...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/WeatherApp/templates/shared/layout.fs b/examples/WeatherApp/templates/shared/layout.fs index 869f5f62..6163d1a9 100644 --- a/examples/WeatherApp/templates/shared/layout.fs +++ b/examples/WeatherApp/templates/shared/layout.fs @@ -83,10 +83,10 @@ module layout = link(rel="stylesheet...
[ "examples/WeatherApp/templates/shared/layout.fs" ]
[ { "comment": "The examples now load htmx via the floating `@next` tag. This makes the sample non-reproducible (a future htmx4 prerelease could break the demo without any repo change). Consider pinning to a specific htmx 4 version (or commit/tag) and updating intentionally when needed; alternatively document exp...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
This switches the htmx script URL to `@next`, which is a moving target and can make the example break unexpectedly over time. Prefer pinning to a specific htmx 4 prerelease version (or add a brief comment explaining why a floating tag is intentional). ```suggestion script(src="https://cdn.jsdelivr.net/n...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/ContactApp/templates/shared/layout.fs b/examples/ContactApp/templates/shared/layout.fs index 0ab8adc5..1f0d527c 100644 --- a/examples/ContactApp/templates/shared/layout.fs +++ b/examples/ContactApp/templates/shared/layout.fs @@ -1,4 +1,4 @@ -namespace ContactApp.templates.shared +namespace Contac...
[ "examples/ContactApp/templates/shared/layout.fs" ]
[ { "comment": "This switches the htmx script URL to `@next`, which is a moving target and can make the example break unexpectedly over time. Prefer pinning to a specific htmx 4 prerelease version (or add a brief comment explaining why a floating tag is intentional).\n```suggestion\n script(src=\"h...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The sample now references `htmx.org@next`, which can change behavior between runs and makes the example hard to debug when it breaks. Consider pinning to a specific htmx version (even a beta) or documenting why `@next` is necessary for this streaming scenario. ```suggestion script(src = "https://cdn...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/Basic/Program.fs b/examples/Basic/Program.fs index 0c2585d9..2650b536 100644 --- a/examples/Basic/Program.fs +++ b/examples/Basic/Program.fs @@ -1,4 +1,4 @@ -open System +open System open System.Text.Json.Serialization open System.Threading.Tasks open Microsoft.AspNetCore.Authorization @@ -118...
[ "examples/Basic/Program.fs" ]
[ { "comment": "The sample now references `htmx.org@next`, which can change behavior between runs and makes the example hard to debug when it breaks. Consider pinning to a specific htmx version (even a beta) or documenting why `@next` is necessary for this streaming scenario.\n```suggestion\n s...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxInclude` accepts selector-like values (e.g., `closest form`, CSS selectors). For consistency with other selector-based htmx attributes in this file (`hxTarget`, `hxSelect`, `hxSelectOob`, `hxIndicator`), consider adding `[<StringSyntax("css")>]` to improve editor tooling and reduce accidental invalid strings. ```sug...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxInclude` accepts selector-like values (e.g., `closest form`, CSS selectors). For consistency with other selector-based htmx attributes in this file (`hxTarget`, `hxSelect`, `hxSelectOob`, `hxIndicator`), consider adding `[<StringSyntax(\"css\")>]` to improve editor tooling and reduce accidental...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxDisable` is selector-driven in htmx 4 (tests/README use selector-like values). Consider annotating the setter parameter with `[<StringSyntax("css")>]` (as done for `hxIndicator`/`hxTarget`) to keep the API consistent and help callers with tooling/validation. ```suggestion /// Adds the disabled attribute to s...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxDisable` is selector-driven in htmx 4 (tests/README use selector-like values). Consider annotating the setter parameter with `[<StringSyntax(\"css\")>]` (as done for `hxIndicator`/`hxTarget`) to keep the API consistent and help callers with tooling/validation.\n```suggestion\n /// Adds t...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxOptimistic` appears to take a selector/element reference (e.g. `#template-id` in tests). Consider adding `[<StringSyntax("css")>]` (or whatever syntax is most appropriate) so callers get consistent IntelliSense and reduced typo risk. ```suggestion with set ([<StringSyntax("css")>] value: string | null) =...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxOptimistic` appears to take a selector/element reference (e.g. `#template-id` in tests). Consider adding `[<StringSyntax(\"css\")>]` (or whatever syntax is most appropriate) so callers get consistent IntelliSense and reduced typo risk.\n```suggestion\n with set ([<StringSyntax(\"css\...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The `StringSyntax` identifiers use mixed casing (e.g., `"Css"`, `"Json"`, `"Uri"` here vs `"js"` elsewhere in the repo). If these annotations are meant for analyzers/tooling, it’s worth standardizing the identifiers (including casing) to avoid tools treating them differently.
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "The `StringSyntax` identifiers use mixed casing (e.g., `\"Css\"`, `\"Json\"`, `\"Uri\"` here vs `\"js\"` elsewhere in the repo). If these annotations are meant for analyzers/tooling, it’s worth standardizing the identifiers (including casing) to avoid tools treating them differently.", "path":...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`HtmlTagHtmxExtensions.attr` ignores the value returned from `HxElement.SetAttribute`. Since `SetAttribute`’s contract returns an updated tag, this implementation will silently break if any future `HxElement` (or `HtmlTag`) implementation becomes non-mutating. Consider either (a) changing `HxElement.SetAttribute` to re...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`HtmlTagHtmxExtensions.attr` ignores the value returned from `HxElement.SetAttribute`. Since `SetAttribute`’s contract returns an updated tag, this implementation will silently break if any future `HxElement` (or `HtmlTag`) implementation becomes non-mutating. Consider either (a) changing `HxEleme...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxPreserve` currently emits `hx-preserve=""` by calling `tag.attr(..., "")`. The ViewEngine has a dedicated `bool` helper that renders boolean attributes without a value (value = null), which is the convention used for other boolean attributes (e.g., `inert`). Consider using `tag.bool($"hx-preserve{...}", true)` when ...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxPreserve` currently emits `hx-preserve=\"\"` by calling `tag.attr(..., \"\")`. The ViewEngine has a dedicated `bool` helper that renders boolean attributes without a value (value = null), which is the convention used for other boolean attributes (e.g., `inert`). Consider using `tag.bool($\"hx-p...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxIgnore` currently renders `hx-ignore=""` when true. For consistency with other boolean attributes in Oxpecker.ViewEngine (which use `HtmlElementExtensions.bool` to render valueless attributes), consider switching to `tag.bool("hx-ignore", value)` so the output becomes `hx-ignore` instead of `hx-ignore=""`. ```sugges...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxIgnore` currently renders `hx-ignore=\"\"` when true. For consistency with other boolean attributes in Oxpecker.ViewEngine (which use `HtmlElementExtensions.bool` to render valueless attributes), consider switching to `tag.bool(\"hx-ignore\", value)` so the output becomes `hx-ignore` instead of...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The docs describe an `HxInherited.Replace` modifier and show `hxBoost(true, HxInherited.Replace)`, but the implementation exposes `HxInherited.Set`/`Append` and `hxBoost` currently takes a string value (e.g. "true"). Please align the README examples/terminology with the actual API surface so users can copy/paste them s...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/README.md b/src/Oxpecker.Htmx/README.md index a18c9ace..c415521f 100644 --- a/src/Oxpecker.Htmx/README.md +++ b/src/Oxpecker.Htmx/README.md @@ -2,11 +2,13 @@ --- # Oxpecker.Htmx -`Oxpecker.Htmx` extends `Oxpecker.ViewEngine` package with HTMX attributes and headers. +`Oxpecker.Htmx` e...
[ "src/Oxpecker.Htmx/README.md" ]
[ { "comment": "The docs describe an `HxInherited.Replace` modifier and show `hxBoost(true, HxInherited.Replace)`, but the implementation exposes `HxInherited.Set`/`Append` and `hxBoost` currently takes a string value (e.g. \"true\"). Please align the README examples/terminology with the actual API surface so use...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The example in the comment uses `HxInherited.Replace`, but the `HxInherited` DU defines `Set`/`Append` only. This will confuse users (and suggests a non-existent API). Update the example (or rename the DU case) so it matches the actual public API. ```suggestion /// div().attr(hxGet "/api", hxTarget "#out", hxBo...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "The example in the comment uses `HxInherited.Replace`, but the `HxInherited` DU defines `Set`/`Append` only. This will confuse users (and suggests a non-existent API). Update the example (or rename the DU case) so it matches the actual public API.\n```suggestion\n /// div().attr(hxGet \"/ap...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxPreserve` currently uses `tag.bool(...)`, which renders a valueless attribute (`hx-preserve`) and cannot emit the empty-string form used elsewhere in this package/tests (e.g. `hx-preserve=""`). If the intended contract is `hx-preserve=""`, set it via `tag.attr(..., "")` when true (and omit when false), rather than `...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxPreserve` currently uses `tag.bool(...)`, which renders a valueless attribute (`hx-preserve`) and cannot emit the empty-string form used elsewhere in this package/tests (e.g. `hx-preserve=\"\"`). If the intended contract is `hx-preserve=\"\"`, set it via `tag.attr(..., \"\")` when true (and omi...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxValidate` uses `tag.bool(...)`, which only supports presence/absence and cannot represent an explicit `hx-validate="false"` (useful for overriding inheritance). It also won’t match the expected output in the new tests (`hx-validate="true"`). Consider rendering `"true"/"false"` via `tag.attr(...)` instead of `tag.boo...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxValidate` uses `tag.bool(...)`, which only supports presence/absence and cannot represent an explicit `hx-validate=\"false\"` (useful for overriding inheritance). It also won’t match the expected output in the new tests (`hx-validate=\"true\"`). Consider rendering `\"true\"/\"false\"` via `tag....
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxIgnore` is rendered with `tag.bool("hx-ignore", ...)`, which produces a valueless attribute (`hx-ignore`) rather than the empty-string form asserted by the tests (`hx-ignore=""`). If the public contract is the empty-string form, switch to setting `hx-ignore` with an explicit empty string when true. ```suggestion ...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxIgnore` is rendered with `tag.bool(\"hx-ignore\", ...)`, which produces a valueless attribute (`hx-ignore`) rather than the empty-string form asserted by the tests (`hx-ignore=\"\"`). If the public contract is the empty-string form, switch to setting `hx-ignore` with an explicit empty string wh...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
This test name references `HxInherited.Replace`, but the current API uses `HxInherited.Set`. Rename the test to match the public API term you expose, otherwise it’s easy to misread the intended usage.
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
[ "tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs" ]
[ { "comment": "This test name references `HxInherited.Replace`, but the current API uses `HxInherited.Set`. Rename the test to match the public API term you expose, otherwise it’s easy to misread the intended usage.", "path": "tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs", "hunk": "@@ -0,0 +1,288 @@\n+m...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`open System` appears unused in this file. Removing it would avoid unnecessary imports (and potential unused-open warnings depending on build settings).
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`open System` appears unused in this file. Removing it would avoid unnecessary imports (and potential unused-open warnings depending on build settings).", "path": "src/Oxpecker.Htmx/Attributes.fs", "hunk": "@@ -1,121 +1,244 @@\n-namespace Oxpecker.Htmx\n+namespace Oxpecker.Htmx\n \n+open ...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxBoost` is currently modeled as `type hxBoost(value: string, ...)`, which allows arbitrary values and regresses type-safety compared to the previous bool-based API. If htmx 4 still treats `hx-boost` as a boolean flag, consider taking `bool` (and rendering "true"/"false" internally) or providing an overload so callers...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxBoost` is currently modeled as `type hxBoost(value: string, ...)`, which allows arbitrary values and regresses type-safety compared to the previous bool-based API. If htmx 4 still treats `hx-boost` as a boolean flag, consider taking `bool` (and rendering \"true\"/\"false\" internally) or provid...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
These parameters are annotated as `StringSyntax("css")`, but the comment/doc implies extended selectors like `closest form`/`this` are valid inputs (which are not CSS). Consider removing the CSS annotation or changing it to a more accurate syntax category to avoid incorrect IDE validation. ```suggestion type hxIncl...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "These parameters are annotated as `StringSyntax(\"css\")`, but the comment/doc implies extended selectors like `closest form`/`this` are valid inputs (which are not CSS). Consider removing the CSS annotation or changing it to a more accurate syntax category to avoid incorrect IDE validation.\n```s...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
Test name mentions `HxInherited.Replace`, but `HxInherited` only defines `Set`/`Append` and the body uses `HxInherited.Set`. Please rename the test case to match the actual modifier to avoid confusion when reading failures. ```suggestion let ``hxTarget with HxInherited.Set renders hx-target:inherited`` () = ```
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
[ "tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs" ]
[ { "comment": "Test name mentions `HxInherited.Replace`, but `HxInherited` only defines `Set`/`Append` and the body uses `HxInherited.Set`. Please rename the test case to match the actual modifier to avoid confusion when reading failures.\n```suggestion\nlet ``hxTarget with HxInherited.Set renders hx-target:inhe...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
The word "typedly" isn’t standard English and reads like a typo. Consider rephrasing this sentence (e.g., "type-safely" / "in a type-safe way") to keep the README clear and professional. ```suggestion Build [htmx 4 extended selectors](https://four.htmx.org/docs/features/extended-selectors) in a type-safe way via the `H...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/README.md b/src/Oxpecker.Htmx/README.md index a18c9ace..c415521f 100644 --- a/src/Oxpecker.Htmx/README.md +++ b/src/Oxpecker.Htmx/README.md @@ -2,11 +2,13 @@ --- # Oxpecker.Htmx -`Oxpecker.Htmx` extends `Oxpecker.ViewEngine` package with HTMX attributes and headers. +`Oxpecker.Htmx` e...
[ "src/Oxpecker.Htmx/README.md" ]
[ { "comment": "The word \"typedly\" isn’t standard English and reads like a typo. Consider rephrasing this sentence (e.g., \"type-safely\" / \"in a type-safe way\") to keep the README clear and professional.\n```suggestion\nBuild [htmx 4 extended selectors](https://four.htmx.org/docs/features/extended-selectors)...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
This test duplicates the earlier `hxDisable with merge renders hx-disable:merge` case (same call to `main().hxDisable(HxSelector.find "button", HxModifier.merge)` and same expected HTML). Consider removing one of them or changing one to cover a distinct scenario (e.g., `:merge:inherited` vs `:merge`), to avoid redundan...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
[ "tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs" ]
[ { "comment": "This test duplicates the earlier `hxDisable with merge renders hx-disable:merge` case (same call to `main().hxDisable(HxSelector.find \"button\", HxModifier.merge)` and same expected HTML). Consider removing one of them or changing one to cover a distinct scenario (e.g., `:merge:inherited` vs `:me...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxInclude` is documented as accepting extended selectors (e.g. `closest form`), but its argument is annotated as `StringSyntax("css")`. That annotation is misleading for extended selectors and may generate incorrect IDE CSS validation; consider dropping/changing the annotation for htmx selector parameters (and alignin...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxInclude` is documented as accepting extended selectors (e.g. `closest form`), but its argument is annotated as `StringSyntax(\"css\")`. That annotation is misleading for extended selectors and may generate incorrect IDE CSS validation; consider dropping/changing the annotation for htmx selector...
true
Lanayx/Oxpecker
94
comment_to_fix
Htmx4 and AlpineJS initial support
`hxTarget` is annotated with `StringSyntax("css")`, but htmx 4 selector-typed attributes also accept extended selectors (e.g. `closest form`, `next`, etc.) produced by `HxSelector`. Marking the parameter as CSS will cause IDEs/analyzers to treat valid extended selectors as invalid CSS; consider removing the `StringSynt...
06464aded8df101ecf6a6e9058eaa3f0548ebd1a
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
[ "src/Oxpecker.Htmx/Attributes.fs" ]
[ { "comment": "`hxTarget` is annotated with `StringSyntax(\"css\")`, but htmx 4 selector-typed attributes also accept extended selectors (e.g. `closest form`, `next`, etc.) produced by `HxSelector`. Marking the parameter as CSS will cause IDEs/analyzers to treat valid extended selectors as invalid CSS; consider ...
true
Lanayx/Oxpecker
95
issue_to_patch
Alpinejs
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/Oxpecker.slnx b/Oxpecker.slnx index 70a4f28f..97b0f390 100644 --- a/Oxpecker.slnx +++ b/Oxpecker.slnx @@ -14,12 +14,14 @@ <Project Path="examples/MCP/Server/Server.fsproj" /> </Folder> <Folder Name="/src/"> + <Project Path="src/Oxpecker.Alpine/Oxpecker.Alpine.fsproj" /> <Project Path="sr...
[ "Oxpecker.slnx", "README.md", "examples/WeatherApp/WeatherApp.fsproj", "examples/WeatherApp/templates/counter.fs", "examples/WeatherApp/templates/shared/layout.fs", "examples/WeatherApp/templates/weather.fs", "src/Oxpecker.Alpine/Attributes.fs", "src/Oxpecker.Alpine/Oxpecker.Alpine.fsproj", "src/Oxp...
[ { "comment": "The XML doc for `xModel(..., modifiers)` says modifiers are like `\"number.debounce.500ms\"`, but the API concatenates `modifiers` verbatim and the provided helpers include the leading `.` (e.g. `.number`). Update the comment to clarify that callers should include the leading `.` (or adjust the AP...
diff --git a/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..251ff29f --- /dev/null +++ b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs @@ -0,0 +1,187 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Alpine +o...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
The XML doc for `xModel(..., modifiers)` says modifiers are like `"number.debounce.500ms"`, but the API concatenates `modifiers` verbatim and the provided helpers include the leading `.` (e.g. `.number`). Update the comment to clarify that callers should include the leading `.` (or adjust the API to add it automaticall...
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
[ "src/Oxpecker.Alpine/Attributes.fs" ]
[ { "comment": "The XML doc for `xModel(..., modifiers)` says modifiers are like `\"number.debounce.500ms\"`, but the API concatenates `modifiers` verbatim and the provided helpers include the leading `.` (e.g. `.number`). Update the comment to clarify that callers should include the leading `.` (or adjust the AP...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
The XML doc for `xShow(..., modifiers)` says modifiers are like `"important"`, but the method concatenates `modifiers` verbatim and the helper `XShowModifier.important` includes the leading `.`. Update the comment to avoid implying callers should omit the dot (or change the API to add it).
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
[ "src/Oxpecker.Alpine/Attributes.fs" ]
[ { "comment": "The XML doc for `xShow(..., modifiers)` says modifiers are like `\"important\"`, but the method concatenates `modifiers` verbatim and the helper `XShowModifier.important` includes the leading `.`. Update the comment to avoid implying callers should omit the dot (or change the API to add it).", ...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
`xTransitionOn` (both overloads) is a new public rendering path but there’s currently no test asserting the rendered attribute name (including phase and modifiers). Add at least one test to cover `xTransitionOn("enter")` and `xTransitionOn("enter", XTransitionModifier.durationMs 300)` to prevent regressions.
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
[ "src/Oxpecker.Alpine/Attributes.fs" ]
[ { "comment": "`xTransitionOn` (both overloads) is a new public rendering path but there’s currently no test asserting the rendered attribute name (including phase and modifiers). Add at least one test to cover `xTransitionOn(\"enter\")` and `xTransitionOn(\"enter\", XTransitionModifier.durationMs 300)` to preve...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
This test name says it covers a modifier, but it calls `xIgnore(true)` exactly like the earlier `xIgnore true renders x-ignore` test and doesn’t exercise any additional behavior. Either remove this duplicate test or rename it to reflect what it actually asserts. ```suggestion let ``xIgnore true also renders x-ignore`` ...
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..251ff29f --- /dev/null +++ b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs @@ -0,0 +1,187 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Alpine +o...
[ "tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs" ]
[ { "comment": "This test name says it covers a modifier, but it calls `xIgnore(true)` exactly like the earlier `xIgnore true renders x-ignore` test and doesn’t exercise any additional behavior. Either remove this duplicate test or rename it to reflect what it actually asserts.\n```suggestion\nlet ``xIgnore true ...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
`scaleOrigin`'s doc comment says it adds `x-transition.origin.XXX`, but the implementation returns `.scale.origin.<origin>`. Either the comment is incorrect or the modifier string is wrong; align them so the generated attribute matches the documented/expected Alpine syntax. ```suggestion let scaleOrigin origin = $"...
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
[ "src/Oxpecker.Alpine/Attributes.fs" ]
[ { "comment": "`scaleOrigin`'s doc comment says it adds `x-transition.origin.XXX`, but the implementation returns `.scale.origin.<origin>`. Either the comment is incorrect or the modifier string is wrong; align them so the generated attribute matches the documented/expected Alpine syntax.\n```suggestion\n let...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
The Markdown table uses double leading pipes (`|| ...`) on each row, which creates an extra empty column (and may render incorrectly on GitHub/NuGet/Docs). Consider switching to standard table syntax with a single leading `|` per row (and matching separator row).
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/README.md b/src/Oxpecker.Alpine/README.md new file mode 100644 index 00000000..c9811dbc --- /dev/null +++ b/src/Oxpecker.Alpine/README.md @@ -0,0 +1,116 @@ +--- +--- +# Oxpecker.Alpine + +`Oxpecker.Alpine` extends `Oxpecker.ViewEngine` with typed [Alpine.js](https://alpinejs.dev) direct...
[ "src/Oxpecker.Alpine/README.md" ]
[ { "comment": "The Markdown table uses double leading pipes (`|| ...`) on each row, which creates an extra empty column (and may render incorrectly on GitHub/NuGet/Docs). Consider switching to standard table syntax with a single leading `|` per row (and matching separator row).", "path": "src/Oxpecker.Alpine...
true
Lanayx/Oxpecker
95
comment_to_fix
Alpinejs
The XML doc comment for `scale` says it adds `x-transition.scale`, but the function actually returns a value-specific modifier like `.scale.<value>`. Please update the comment to reflect the actual rendered modifier format. ```suggestion /// Adds `x-transition.scale.XXX` for a scale transition value of XXX. ```
725ecadef9acd37bcffb66e467aab65041704cdc
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
[ "src/Oxpecker.Alpine/Attributes.fs" ]
[ { "comment": "The XML doc comment for `scale` says it adds `x-transition.scale`, but the function actually returns a value-specific modifier like `.scale.<value>`. Please update the comment to reflect the actual rendered modifier format.\n```suggestion\n /// Adds `x-transition.scale.XXX` for a scale transiti...
true
Lanayx/Oxpecker
84
issue_to_patch
Oxpecker.OpenApi changes following .NET 10 changes
- New `configureOperation` signature (breaking change) - Handling F# options
c887f9079621cd587bb6e0b74c85b19873751783
a680b5bae03817024ad669d8c64e10a5de2a3328
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0f86b23a..6bb092fb 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -8,7 +8,7 @@ on: env: DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true DOTNET_CLI_TELEMETRY_OPTOUT: true - DOTNET_VERSION: 9.0.300 + DOTNET_VERSION: 10.0.100 ...
[ ".github/workflows/CI.yml", "examples/Basic/Basic.fsproj", "examples/Basic/Program.fs", "examples/CRUD/Backend/Backend.fsproj", "examples/CRUD/Shared/Shared.fsproj", "examples/Empty/Empty.fsproj", "examples/MCP/Client/Client.fsproj", "examples/MCP/Server/Server.fsproj", "examples/WeatherApp/WeatherA...
[]
diff --git a/tests/Oxpecker.Tests/Json.Tests.fs b/tests/Oxpecker.Tests/Json.Tests.fs index b4f95a3d..ed747ab9 100644 --- a/tests/Oxpecker.Tests/Json.Tests.fs +++ b/tests/Oxpecker.Tests/Json.Tests.fs @@ -60,3 +60,18 @@ let ``Test default deserializer`` () = let! value = serializer.Deserialize<{| Name: string |}...
true
Lanayx/Oxpecker
85
issue_to_patch
New routing
- Added new function `routeGroup` - Moved endpoint configuration to the group level
f94f9067897d8377e03d5c9f1db3e2aaa8622c52
7ed3fe9f8aa24c3f57a3cb62d38931e5ed20c291
diff --git a/examples/Basic/Program.fs b/examples/Basic/Program.fs index 458bcda4..4c1bb0b3 100644 --- a/examples/Basic/Program.fs +++ b/examples/Basic/Program.fs @@ -137,15 +137,15 @@ let streamingHtml2: EndpointHandler = } htmlChunked values ctx -let CLOSED = applyBefore closedHandler +let CLO...
[ "examples/Basic/Program.fs", "examples/ContactApp/ContactApp.fsproj", "global.json", "src/Oxpecker/Middleware.fs", "src/Oxpecker/Oxpecker.fsproj", "src/Oxpecker/README.md", "src/Oxpecker/Routing.fs", "tests/Oxpecker.Tests/Routing.Tests.fs", "tests/PerfTest/PerfTest.fsproj", "tests/PerfTest/Program...
[]
diff --git a/tests/Oxpecker.Tests/Routing.Tests.fs b/tests/Oxpecker.Tests/Routing.Tests.fs index a1f23bb3..66b9a203 100644 --- a/tests/Oxpecker.Tests/Routing.Tests.fs +++ b/tests/Oxpecker.Tests/Routing.Tests.fs @@ -3,6 +3,7 @@ open System open System.Net open System.Net.Http.Json +open System.Threading.Tasks open M...
true
Lanayx/Oxpecker
83
issue_to_patch
CSRF protection implementation in Oxpecker
- Enabled by default for POST, PUT, PATCH requests if Antiforgery is also enabled (similar to [MiminalApi](https://learn.microsoft.com/en-us/aspnet/core/security/anti-request-forgery?view=aspnetcore-9.0#antiforgery-with-minimal-apis)) - `AntiforgeryValidationException` is thrown on `.BindForm` (similar to MinimalApi's...
c887f9079621cd587bb6e0b74c85b19873751783
f42f69055130066e3cefd4578749dd23f9898848
diff --git a/examples/Empty/Program.fs b/examples/Empty/Program.fs index 747fd578..7c029ec2 100644 --- a/examples/Empty/Program.fs +++ b/examples/Empty/Program.fs @@ -11,6 +11,9 @@ let main args = let builder = WebApplication.CreateBuilder(args) builder.Services.AddRouting().AddOxpecker() |> ignore let a...
[ "examples/Empty/Program.fs", "examples/WeatherApp/Program.fs", "examples/WeatherApp/templates/weather.fs", "src/Oxpecker/Handlers.fs", "src/Oxpecker/HttpContextExtensions.fs", "src/Oxpecker/Middleware.fs", "src/Oxpecker/README.md", "src/Oxpecker/Routing.fs", "tests/Oxpecker.Tests/Antiforgery.Tests.f...
[]
diff --git a/tests/Oxpecker.Tests/Antiforgery.Tests.fs b/tests/Oxpecker.Tests/Antiforgery.Tests.fs new file mode 100644 index 00000000..cdd5c3ba --- /dev/null +++ b/tests/Oxpecker.Tests/Antiforgery.Tests.fs @@ -0,0 +1,111 @@ +module Oxpecker.Tests.Antiforgery + +open System.Collections.Generic +open System.Net +open Sy...
true
Lanayx/Oxpecker
88
issue_to_patch
OpenApi fix
- Fix for #87 - Fix for openApiSimple - Fix for nested DTO schemas generation - Added OpenApi tests
9c8f4840e1923bd2bd5ead69cf841dcd29df3a6f
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/Oxpecker.slnx b/Oxpecker.slnx index bfce13e3..ee20bf45 100644 --- a/Oxpecker.slnx +++ b/Oxpecker.slnx @@ -20,6 +20,7 @@ <Project Path="src/Oxpecker/Oxpecker.fsproj" /> </Folder> <Folder Name="/tests/"> + <Project Path="tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj" /> <Proje...
[ "Oxpecker.slnx", "src/Oxpecker.OpenApi/Configuration.fs", "src/Oxpecker.OpenApi/Oxpecker.OpenApi.fsproj", "src/Oxpecker.OpenApi/Routing.fs", "src/Oxpecker.OpenApi/Transformers.fs", "tests/Oxpecker.OpenApi.Tests/General.Tests.fs", "tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj", "tests/Oxp...
[ { "comment": "There's commented-out code that appears to be an alternative implementation for determining complex types. If this code is no longer needed, it should be removed to improve code clarity. If it's kept for reference or future use, consider adding a comment explaining why it's preserved.", "path"...
diff --git a/tests/Oxpecker.OpenApi.Tests/General.Tests.fs b/tests/Oxpecker.OpenApi.Tests/General.Tests.fs new file mode 100644 index 00000000..3ce9b1ba --- /dev/null +++ b/tests/Oxpecker.OpenApi.Tests/General.Tests.fs @@ -0,0 +1,536 @@ +module Oxpecker.OpenApi.Tests.General + +open System.Net +open Microsoft.AspNetCo...
true
Lanayx/Oxpecker
88
comment_to_fix
OpenApi fix
There's commented-out code that appears to be an alternative implementation for determining complex types. If this code is no longer needed, it should be removed to improve code clarity. If it's kept for reference or future use, consider adding a comment explaining why it's preserved.
9c8f4840e1923bd2bd5ead69cf841dcd29df3a6f
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/src/Oxpecker.OpenApi/Transformers.fs b/src/Oxpecker.OpenApi/Transformers.fs index 3cbf1e58..d370152f 100644 --- a/src/Oxpecker.OpenApi/Transformers.fs +++ b/src/Oxpecker.OpenApi/Transformers.fs @@ -21,6 +21,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (...
[ "src/Oxpecker.OpenApi/Transformers.fs" ]
[ { "comment": "There's commented-out code that appears to be an alternative implementation for determining complex types. If this code is no longer needed, it should be removed to improve code clarity. If it's kept for reference or future use, consider adding a comment explaining why it's preserved.", "path"...
true
Lanayx/Oxpecker
88
comment_to_fix
OpenApi fix
The Program.fs file is missing from the ItemGroup compilation list. In F# projects, all source files must be explicitly listed in compilation order. Add Program.fs to the Compile ItemGroup, and it should come last since it contains the entry point. ```suggestion <Compile Include="Transformers.Tests.fs" /> ...
9c8f4840e1923bd2bd5ead69cf841dcd29df3a6f
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj b/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj new file mode 100644 index 00000000..ef6f2fbd --- /dev/null +++ b/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj @@ -0,0 +1,28 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <Pr...
[ "tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj" ]
[ { "comment": "The Program.fs file is missing from the ItemGroup compilation list. In F# projects, all source files must be explicitly listed in compilation order. Add Program.fs to the Compile ItemGroup, and it should come last since it contains the entry point.\n```suggestion\n <Compile Include=\"Transf...
true
Lanayx/Oxpecker
88
comment_to_fix
OpenApi fix
There's a naming collision in the isSimple function. The parameter in the inner pattern match shadows the OpenApiSchema parameter 's' with a string variable 's' on line 50. This makes the code confusing and could lead to bugs. Consider renaming the inner string variable to something like 'schemaId' or 'idValue'. ```sug...
9c8f4840e1923bd2bd5ead69cf841dcd29df3a6f
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/src/Oxpecker.OpenApi/Transformers.fs b/src/Oxpecker.OpenApi/Transformers.fs index 3cbf1e58..d370152f 100644 --- a/src/Oxpecker.OpenApi/Transformers.fs +++ b/src/Oxpecker.OpenApi/Transformers.fs @@ -21,6 +21,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (...
[ "src/Oxpecker.OpenApi/Transformers.fs" ]
[ { "comment": "There's a naming collision in the isSimple function. The parameter in the inner pattern match shadows the OpenApiSchema parameter 's' with a string variable 's' on line 50. This makes the code confusing and could lead to bugs. Consider renaming the inner string variable to something like 'schemaId...
true
Lanayx/Oxpecker
80
issue_to_patch
fix: pass ServiceProvider from HttpContext to ValidationContext
Hello, I noticed a bug when trying to validate an object that implements the `IValidatableObject` (https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.ivalidatableobject?view=net-9.0 ) with dependency injection. `IValidatableObject` interface allow us to implement a `Validate` met...
e20ad8d14c4e13ab4088ab1dcf9ddf986246c264
91e1f7756f90cef486c346068a11f7dd937fd619
diff --git a/src/Oxpecker/ModelValidation.fs b/src/Oxpecker/ModelValidation.fs index 98dd7f80..4b544d38 100644 --- a/src/Oxpecker/ModelValidation.fs +++ b/src/Oxpecker/ModelValidation.fs @@ -78,6 +78,17 @@ module ModelValidation = | true -> ModelValidationResult.Valid model | false -> ModelValidationR...
[ "src/Oxpecker/ModelValidation.fs", "src/Oxpecker/README.md", "tests/Oxpecker.Tests/ModelValidation.Tests.fs" ]
[ { "comment": "This is a breaking change, I suggest adding function `validateModelWith` and having `ValidationContext` passed as an argument, rather than `IServiceProvider`, since it's possible that user will want to pass items dictionary. Once done, you can use this new function in other places. Also, please ad...
diff --git a/tests/Oxpecker.Tests/ModelValidation.Tests.fs b/tests/Oxpecker.Tests/ModelValidation.Tests.fs index ea783fe8..a536d560 100644 --- a/tests/Oxpecker.Tests/ModelValidation.Tests.fs +++ b/tests/Oxpecker.Tests/ModelValidation.Tests.fs @@ -1,5 +1,7 @@ module Oxpecker.Tests.ModelValidation +open System +open M...
true
Lanayx/Oxpecker
81
issue_to_patch
Some little typos in the README.md files
It's mostly the about the grammar error "it's" instead of "its". I took the chance to suggest few other little corrections.
5e5221ff85ef7f987eabbecaee920d308040a776
a1814528d10bba16eef40553cfe5ae18628363b4
diff --git a/README.md b/README.md index ecc048e0..e788ac65 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ ![Oxpecker](https://github.com/Lanayx/Oxpecker/raw/develop/images/oxpecker.png) -**Welcome to Oxpecker!** An F# library designed to supercharge your web development with ASP.NET Core, Htmx, and Solid....
[ "README.md", "src/Oxpecker.ViewEngine/README.md", "src/Oxpecker/README.md" ]
[]
true
Lanayx/Oxpecker
72
issue_to_patch
[Oxpecker.Solid] Svg Tags
Fresh commit tree for #56
fc40f31fc4aa1222fcb8ca354b2b8a56b35a2dbe
1d3e78a0a8e5f17ec54fe28b9e86a6389fbacd34
diff --git a/src/Oxpecker.Solid/Oxpecker.Solid.fsproj b/src/Oxpecker.Solid/Oxpecker.Solid.fsproj index 18fee21d..03c73961 100644 --- a/src/Oxpecker.Solid/Oxpecker.Solid.fsproj +++ b/src/Oxpecker.Solid/Oxpecker.Solid.fsproj @@ -39,6 +39,7 @@ <Compile Include="IdeTweaks.fs" /> <Compile Include="Builder....
[ "src/Oxpecker.Solid/Oxpecker.Solid.fsproj", "src/Oxpecker.Solid/Svg.fs", "tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.expected", "tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.fs", "tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.fsproj", "tests/Oxpecker.Solid.Tests/GeneralTests.fs", "tests/Oxpecker.Solid.Tests/Oxpeck...
[]
diff --git a/tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.expected b/tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.expected new file mode 100644 index 00000000..6e930633 --- /dev/null +++ b/tests/Oxpecker.Solid.Tests/Cases/Svg/Svg.expected @@ -0,0 +1,22 @@ + +export function SvgTest() { + return <svg> + <defs> + ...
true
Lanayx/Oxpecker
71
issue_to_patch
Mcp
08031f8ed3fb5573fa782882cd5071277b26b71e
44401ec18f9e16ef50fee5e7f84376a6e14cbbf3
diff --git a/.fantomasignore b/.fantomasignore index 0d4988e3..13bf12e8 100644 --- a/.fantomasignore +++ b/.fantomasignore @@ -8,3 +8,4 @@ examples/Empty examples/EmptySolid examples/TodoList examples/CRUD +examples/MCP diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 6f617b3f..0f86b23a 100644 ...
[ ".fantomasignore", ".github/workflows/CI.yml", "Oxpecker.sln", "README.md", "examples/MCP/Client/Client.fsproj", "examples/MCP/Client/Program.fs", "examples/MCP/README.md", "examples/MCP/Server/Program.fs", "examples/MCP/Server/Server.fsproj", "global.json" ]
[ { "comment": "The kernel builder configured with logging (created on line 44) is not used when building the kernel, which may result in the logging service being omitted. Consider reusing the same kernel builder instance by chaining the logging configuration with the OpenAI chat completion addition.\n```suggest...
true
Lanayx/Oxpecker
67
issue_to_patch
Model binding optimization
4e0a9ab4ef08a99fe413c4616615cf2f26cb7a58
9eb62d83e9e05e9f9dc7d9399f320af97855ee45
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index 0c08bb03..44104f50 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -13,10 +13,90 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>>...
[ "src/Oxpecker/ModelBinder.fs", "tests/Oxpecker.Tests/FsUnitTyped.fs", "tests/Oxpecker.Tests/ModelParser.Tests.fs", "tests/PerfTest.Csharp/BindingModel.cs", "tests/PerfTest.Csharp/Class1.cs", "tests/PerfTest/ModelBinding.fs", "tests/PerfTest/ModelParsing.fs", "tests/PerfTest/PerfTest.fsproj", "tests/...
[]
diff --git a/tests/Oxpecker.Tests/FsUnitTyped.fs b/tests/Oxpecker.Tests/FsUnitTyped.fs index e511f8ba..b83ea6f3 100644 --- a/tests/Oxpecker.Tests/FsUnitTyped.fs +++ b/tests/Oxpecker.Tests/FsUnitTyped.fs @@ -3,9 +3,9 @@ namespace FsUnitTyped [<AutoOpen>] module CustomTopLevelOperators = - open FsUnit.Xunit o...
true
Lanayx/Oxpecker
65
issue_to_patch
Model binding using TypeShape
cc01b32335f10e9bcfee31ba57ff02a573548793
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/AssemblyInfo.fs b/src/Oxpecker/AssemblyInfo.fs deleted file mode 100644 index 700d9ac5..00000000 --- a/src/Oxpecker/AssemblyInfo.fs +++ /dev/null @@ -1,7 +0,0 @@ -module Oxpecker.ViewEngine.AssemblyInfo - -open System.Runtime.CompilerServices - -[<InternalsVisibleTo("Oxpecker.Tests")>] - -do ...
[ "src/Oxpecker/AssemblyInfo.fs", "src/Oxpecker/HttpContextExtensions.fs", "src/Oxpecker/ModelBinder.fs", "src/Oxpecker/Oxpecker.fsproj", "src/Oxpecker/Serializers.fs", "tests/Oxpecker.Tests/FsUnitTyped.fs", "tests/Oxpecker.Tests/ModelParser.Tests.fs", "tests/Oxpecker.Tests/Oxpecker.Tests.fsproj", "te...
[ { "comment": "Please extract this regex somewhere to the root for performance", "path": "src/Oxpecker/ModelBinder.fs", "hunk": "@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives\n type IModelBinder =\n abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T\n \n+module inte...
diff --git a/tests/Oxpecker.Tests/FsUnitTyped.fs b/tests/Oxpecker.Tests/FsUnitTyped.fs new file mode 100644 index 00000000..e511f8ba --- /dev/null +++ b/tests/Oxpecker.Tests/FsUnitTyped.fs @@ -0,0 +1,21 @@ +namespace FsUnitTyped + +[<AutoOpen>] +module CustomTopLevelOperators = + + open FsUnit.Xunit + open System...
true
Lanayx/Oxpecker
65
comment_to_fix
Model binding using TypeShape
Please extract this regex somewhere to the root for performance
cc01b32335f10e9bcfee31ba57ff02a573548793
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
[ "src/Oxpecker/ModelBinder.fs" ]
[ { "comment": "Please extract this regex somewhere to the root for performance", "path": "src/Oxpecker/ModelBinder.fs", "hunk": "@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives\n type IModelBinder =\n abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T\n \n+module inte...
true
Lanayx/Oxpecker
65
comment_to_fix
Model binding using TypeShape
This feels like very inefficient wrapper, can it be avoided?
cc01b32335f10e9bcfee31ba57ff02a573548793
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
[ "src/Oxpecker/ModelBinder.fs" ]
[ { "comment": "This feels like very inefficient wrapper, can it be avoided?", "path": "src/Oxpecker/ModelBinder.fs", "hunk": "@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives\n type IModelBinder =\n abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T\n \n+module interna...
true
Lanayx/Oxpecker
65
comment_to_fix
Model binding using TypeShape
Why does this function return dictionary? As far as I understand, it can return a sequence
cc01b32335f10e9bcfee31ba57ff02a573548793
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
[ "src/Oxpecker/ModelBinder.fs" ]
[ { "comment": "Why does this function return dictionary? As far as I understand, it can return a sequence", "path": "src/Oxpecker/ModelBinder.fs", "hunk": "@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives\n type IModelBinder =\n abstract member Bind<'T> : seq<KeyValuePair<string, StringValu...
true