repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Kong/insomnia | 10,040 | issue_to_patch | fix: import dialog | fixes
<img width="1242" height="446" alt="image" src="https://github.com/user-attachments/assets/0af821ac-b7d2-4a93-9bc5-7f8b845c206e" />
<!--
Please open an [Issue](https://github.com/kong/insomnia/issues/new) first to discuss new
features or non-trivial changes. Please provide as much detail as possible on the ch... | 82e679263611f2ba8c216b942e87fb314e40c652 | cbe8d46989546354349883a717aab04323d112cb | diff --git a/packages/insomnia/src/common/import.ts b/packages/insomnia/src/common/import.ts
index 55a696e288b4..1f4538ea494d 100644
--- a/packages/insomnia/src/common/import.ts
+++ b/packages/insomnia/src/common/import.ts
@@ -92,7 +92,7 @@ export async function fetchImportContentFromURI({ uri }: { uri: string }) {
... | [
"packages/insomnia/src/common/import.ts",
"packages/insomnia/tsconfig.json",
"packages/insomnia/types/global.d.ts",
"packages/insomnia/types/vite.d.ts",
"packages/insomnia/vite.config.ts",
"packages/insomnia/vitest.config.ts"
] | [] | true | ||
Kong/insomnia | 10,039 | issue_to_patch | fix: change pokemon api | <!--
Please open an [Issue](https://github.com/kong/insomnia/issues/new) first to discuss new
features or non-trivial changes. Please provide as much detail as possible on the change as
possible including general description, implementation details, potential shortcomings, etc.
If this PR closes an issue, please ... | d4a77df9ec1bec6928a3a58b435ee120d7c24a68 | 62f4a943284d18a7c1ef8a9dc1d08794f7e85c42 | diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx
index 36bfed713d0..50e613c78fb 100644
--- a/packages/insomnia/src/ui/components/first-request-creation.tsx
+++ b/packages/insomnia/src/ui/components/first-request-creation.tsx
@@ ... | [
"packages/insomnia/src/ui/components/first-request-creation.tsx"
] | [
{
"comment": "The PokeAPI base `pokemon` collection endpoint is documented/canonical with a trailing slash. Omitting it can result in a redirect or inconsistent responses, which would make this “starter request” less reliable for new users. Use the trailing slash before the query string.",
"path": "packages... | true | ||
Kong/insomnia | 10,039 | comment_to_fix | fix: change pokemon api | The PokeAPI base `pokemon` collection endpoint is documented/canonical with a trailing slash. Omitting it can result in a redirect or inconsistent responses, which would make this “starter request” less reliable for new users. Use the trailing slash before the query string. | d4a77df9ec1bec6928a3a58b435ee120d7c24a68 | 62f4a943284d18a7c1ef8a9dc1d08794f7e85c42 | diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx
index 36bfed713d0..50e613c78fb 100644
--- a/packages/insomnia/src/ui/components/first-request-creation.tsx
+++ b/packages/insomnia/src/ui/components/first-request-creation.tsx
@@ ... | [
"packages/insomnia/src/ui/components/first-request-creation.tsx"
] | [
{
"comment": "The PokeAPI base `pokemon` collection endpoint is documented/canonical with a trailing slash. Omitting it can result in a redirect or inconsistent responses, which would make this “starter request” less reliable for new users. Use the trailing slash before the query string.",
"path": "packages... | true | ||
Kong/insomnia | 10,031 | issue_to_patch | fix: remove Buffer class usage in renderer code | Replaced renderer-side `Buffer` usage with `Uint8Array` and encoding helpers, normalized IPC byte transfer at the main/renderer boundary, updated response body types/viewers/export paths, and added tests for UTF-8, Latin1, and base64 byte handling to prevent `Buffer is not defined` exceptions. | d4bb70a9e518cbf4a9cee32234f2332e08cd12c5 | 7e264f627bdf63337a228362d9a133dee3e3cdfd | diff --git a/packages/insomnia-data/src/models/response.ts b/packages/insomnia-data/src/models/response.ts
index 87c7614de342..cc356dce1665 100644
--- a/packages/insomnia-data/src/models/response.ts
+++ b/packages/insomnia-data/src/models/response.ts
@@ -34,7 +34,7 @@ export interface BaseResponse {
headers: Respons... | [
"packages/insomnia-data/src/models/response.ts",
"packages/insomnia/src/main/ipc/main.ts",
"packages/insomnia/src/main/multipart-buffer-to-array.ts",
"packages/insomnia/src/network/basic-auth/get-header.ts",
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId... | [
{
"comment": "latin1BytesFromString currently uses codePointAt(i). For surrogate pairs / non-BMP characters this diverges from Node's Buffer.from(str, 'latin1') semantics (which operate on UTF-16 code units via charCodeAt), producing different bytes for the first code unit of the pair. This can change Basic Aut... | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx
index 221768d857b2..d8d87e9d9111 100644
--- a/packages/insomnia/src/routes/organization... | true | |
Kong/insomnia | 10,031 | comment_to_fix | fix: remove Buffer class usage in renderer code | latin1BytesFromString currently uses codePointAt(i). For surrogate pairs / non-BMP characters this diverges from Node's Buffer.from(str, 'latin1') semantics (which operate on UTF-16 code units via charCodeAt), producing different bytes for the first code unit of the pair. This can change Basic Auth output for inputs co... | d4bb70a9e518cbf4a9cee32234f2332e08cd12c5 | 7e264f627bdf63337a228362d9a133dee3e3cdfd | diff --git a/packages/insomnia/src/utils/utf8-bytes.ts b/packages/insomnia/src/utils/utf8-bytes.ts
new file mode 100644
index 000000000000..042097483e6d
--- /dev/null
+++ b/packages/insomnia/src/utils/utf8-bytes.ts
@@ -0,0 +1,48 @@
+const BASE64_CHUNK_SIZE = 0x80_00;
+
+export function utf8BytesFromString(value: string... | [
"packages/insomnia/src/utils/utf8-bytes.ts"
] | [
{
"comment": "latin1BytesFromString currently uses codePointAt(i). For surrogate pairs / non-BMP characters this diverges from Node's Buffer.from(str, 'latin1') semantics (which operate on UTF-16 code units via charCodeAt), producing different bytes for the first code unit of the pair. This can change Basic Aut... | true | ||
Kong/insomnia | 10,031 | comment_to_fix | fix: remove Buffer class usage in renderer code | services.invoke converts Buffer results with `new Uint8Array(result)`, which copies the entire buffer. For large payloads this adds avoidable memory/time overhead. You can return a plain Uint8Array view over the same underlying memory to avoid the copy while still stripping the Buffer prototype. | d4bb70a9e518cbf4a9cee32234f2332e08cd12c5 | 7e264f627bdf63337a228362d9a133dee3e3cdfd | diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts
index e533f32adf42..2daa99915cd7 100644
--- a/packages/insomnia/src/main/ipc/main.ts
+++ b/packages/insomnia/src/main/ipc/main.ts
@@ -204,8 +204,8 @@ export interface RendererToMainBridgeAPI {
installPlugin: typeof installPl... | [
"packages/insomnia/src/main/ipc/main.ts"
] | [
{
"comment": "services.invoke converts Buffer results with `new Uint8Array(result)`, which copies the entire buffer. For large payloads this adds avoidable memory/time overhead. You can return a plain Uint8Array view over the same underlying memory to avoid the copy while still stripping the Buffer prototype.",... | true | ||
Kong/insomnia | 10,025 | issue_to_patch | fix: v13 onboarding content | Implements new onboarding for v13 release.
**TODO:**
I believe there is still some code that replaces these onboarding slides with the git migration, so the migration experience will need to be integrated with this experience. A separate PR can implement that.
Preview
<img width="1394" height="1150" alt="Scree... | 65acc136b16a3e14b4fe6d286d5cfafddcd4b88a | 765d297a41e1b0c693a82ad915bc9462da3a3557 | diff --git a/packages/insomnia/src/entry.client.tsx b/packages/insomnia/src/entry.client.tsx
index 509ba0a27ec5..7a525e48fe28 100644
--- a/packages/insomnia/src/entry.client.tsx
+++ b/packages/insomnia/src/entry.client.tsx
@@ -63,7 +63,7 @@ try {
// we need to inject state into localStorage
const skipOnboarding =... | [
"packages/insomnia/src/entry.client.tsx",
"packages/insomnia/src/routes/onboarding.$.tsx",
"packages/insomnia/src/ui/images/onboarding/custom_linting.png",
"packages/insomnia/src/ui/images/onboarding/first_request.png",
"packages/insomnia/src/ui/images/onboarding/generate_mocks.png",
"packages/insomnia/sr... | [
{
"comment": "**3rd party Github Actions should be pinned** - medium severity\nA third-party GitHub Action was imported, and is not pinned via a hash. This leaves your CI/CD at risk for potential supply chain attacks, if the affected GitHub Action is compromised.\n\n```suggestion\n uses: amondnet/vercel-... | true | ||
Kong/insomnia | 9,983 | issue_to_patch | chore: bump/inline actions off of Node 20 runtime | GitHub flags actions running on the Node.js 20 runtime with a "Node.js 20 actions are deprecated" warning in workflow logs. This PR bumps the actions where a Node 24 upstream release is already available. This PR also inlines actions which don't support Node 24—all of them just look unmaintained and there were no obvio... | e2209a179b9edbce25907048fa0fad73e554abb0 | 72d0ab11bd827ab823bce207fdb2e75b0aa980dc | diff --git a/.github/workflows/homebrew.yml b/.github/workflows/homebrew.yml
index 8b009a369e7..94592a268f2 100644
--- a/.github/workflows/homebrew.yml
+++ b/.github/workflows/homebrew.yml
@@ -19,7 +19,7 @@ jobs:
steps:
- name: Set up Homebrew
id: set-up-homebrew
- uses: Homebrew/actions/set... | [
".github/workflows/homebrew.yml",
".github/workflows/release-build.yml",
".github/workflows/release-publish.yml",
".github/workflows/release-start.yml",
".github/workflows/update-changelog.yml"
] | [] | true | ||
Kong/insomnia | 10,044 | issue_to_patch | refactor(runtime): extend IoC runtime to crypto and templating | ## Summary
Extended the explicit IoC runtime registry (from PR #10037) to cover crypto and templating operations, removing all remaining Vite aliases and bringing the runtime to 3 total capabilities.
**Changes:**
- Add CryptoRuntime and TemplatingRuntime interfaces to runtime/types.ts
- Update runtime.node.ts and... | 32668df4b8b18cad5357d5c4665a4231f1f1ba4a | 1e06471c95592c0c3b0add77e41a650399a63455 | diff --git a/packages/insomnia-inso/vitest.config.ts b/packages/insomnia-inso/vitest.config.ts
index f45915619a9..a96bacf010c 100644
--- a/packages/insomnia-inso/vitest.config.ts
+++ b/packages/insomnia-inso/vitest.config.ts
@@ -4,8 +4,6 @@ export default defineConfig({
test: {
hideSkippedTests: true,
alia... | [
"packages/insomnia-inso/vitest.config.ts",
"packages/insomnia/src/common/__tests__/har.test.ts",
"packages/insomnia/src/common/render.ts",
"packages/insomnia/src/common/runtime/runtime.node.ts",
"packages/insomnia/src/common/runtime/runtime.renderer.ts",
"packages/insomnia/src/common/runtime/types.ts",
... | [] | diff --git a/packages/insomnia/src/common/__tests__/har.test.ts b/packages/insomnia/src/common/__tests__/har.test.ts
index e744d63c483..d700dc8399b 100644
--- a/packages/insomnia/src/common/__tests__/har.test.ts
+++ b/packages/insomnia/src/common/__tests__/har.test.ts
@@ -14,12 +14,16 @@ vi.mock('~/common/runtime', () ... | true | |
Kong/insomnia | 10,043 | issue_to_patch | fix(linting): show refresh ruleset button only if there is a remote url in a extends entry | Adds logic to display the refresh ruleset button conditionally. If a ruleset does not have a remote URL extends entry, we do not display it; otherwise we do so the user can fetch the latest changes for Insomnia. | 7f609226ac621fcb1619227f94593afc526537d7 | fc18697f98bfc32a837dfedb1fa89ff720df4971 | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx"
] | [
{
"comment": "The `some((entry: string) => entry.startsWith('https://'))` callback will throw if `extends` contains any non-string entry, and the `catch` will then return `false` even if there is also a valid remote URL elsewhere in the array. This can incorrectly hide the refresh button for partially-valid rul... | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx
index d43b1a2fc25..77f2c54f9b3 100644
--- a/packages/insomnia/src/routes/organization.$... | true | ||
Kong/insomnia | 10,043 | comment_to_fix | fix(linting): show refresh ruleset button only if there is a remote url in a extends entry | The `some((entry: string) => entry.startsWith('https://'))` callback will throw if `extends` contains any non-string entry, and the `catch` will then return `false` even if there is also a valid remote URL elsewhere in the array. This can incorrectly hide the refresh button for partially-valid rulesets (e.g. a git-mana... | 7f609226ac621fcb1619227f94593afc526537d7 | fc18697f98bfc32a837dfedb1fa89ff720df4971 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx
index d43b1a2fc25..77f2c54f9b3 100644
--- a/packages/insomnia/src/routes/organization.$... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx"
] | [
{
"comment": "The `some((entry: string) => entry.startsWith('https://'))` callback will throw if `extends` contains any non-string entry, and the `catch` will then return `false` even if there is also a valid remote URL elsewhere in the array. This can incorrectly hide the refresh button for partially-valid rul... | true | ||
Kong/insomnia | 10,035 | issue_to_patch | fix: packaged inso segfault patch via pkg-safe consola reporter | this is a workaround to prevent segfaults when a fully packaged `inso` binary logs using the fancy reporter
this came about after upgrading `consola` [from 2.x to 3.x](https://github.com/Kong/insomnia/pull/9945/changes#diff-8598a2d77bc64cffc9f5fc7d0c7c4c9fc2f9e62717c175293ef8152188f68df5R61)
updates the verify-pk... | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml
index cafe2cbf41a1..e0f01bd9cce0 100644
--- a/.github/workflows/release-build.yml
+++ b/.github/workflows/release-build.yml
@@ -237,8 +237,7 @@ jobs:
- name: Package inso
run: |
- echo "Replacing electron b... | [
".github/workflows/release-build.yml",
"package-lock.json",
"packages/insomnia-inso/package.json",
"packages/insomnia-inso/src/logger.ts",
"packages/insomnia-inso/src/reporters/__snapshots__/fancy-reporter.test.ts.snap",
"packages/insomnia-inso/src/reporters/fancy-reporter.test.ts",
"packages/insomnia-i... | [
{
"comment": "Using `CI: ''` leaves the `CI` env var defined for the child process; some tooling checks for the *presence* of CI rather than truthiness, which would keep CI-mode behavior enabled. If the intent is to force non-CI behavior for the packaged smoke test, explicitly removing the variable is more reli... | diff --git a/packages/insomnia-inso/src/reporters/__snapshots__/fancy-reporter.test.ts.snap b/packages/insomnia-inso/src/reporters/__snapshots__/fancy-reporter.test.ts.snap
new file mode 100644
index 000000000000..84feae28c03f
--- /dev/null
+++ b/packages/insomnia-inso/src/reporters/__snapshots__/fancy-reporter.test.ts... | true | |
Kong/insomnia | 10,035 | comment_to_fix | fix: packaged inso segfault patch via pkg-safe consola reporter | Using `CI: ''` leaves the `CI` env var defined for the child process; some tooling checks for the *presence* of CI rather than truthiness, which would keep CI-mode behavior enabled. If the intent is to force non-CI behavior for the packaged smoke test, explicitly removing the variable is more reliable. | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/packages/insomnia-inso/src/scripts/verify-pkg.js b/packages/insomnia-inso/src/scripts/verify-pkg.js
index d77ae5c49a2f..605e8381dc6e 100644
--- a/packages/insomnia-inso/src/scripts/verify-pkg.js
+++ b/packages/insomnia-inso/src/scripts/verify-pkg.js
@@ -1,20 +1,31 @@
-const spawn = require('child_process')... | [
"packages/insomnia-inso/src/scripts/verify-pkg.js"
] | [
{
"comment": "Using `CI: ''` leaves the `CI` env var defined for the child process; some tooling checks for the *presence* of CI rather than truthiness, which would keep CI-mode behavior enabled. If the intent is to force non-CI behavior for the packaged smoke test, explicitly removing the variable is more reli... | true | ||
Kong/insomnia | 10,035 | comment_to_fix | fix: packaged inso segfault patch via pkg-safe consola reporter | When the packaged binary is terminated by a signal, `spawnSync` returns `status === null`; the current message prints `exit null` and drops the signal information, which makes failures harder to diagnose. | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/packages/insomnia-inso/src/scripts/verify-pkg.js b/packages/insomnia-inso/src/scripts/verify-pkg.js
index d77ae5c49a2f..605e8381dc6e 100644
--- a/packages/insomnia-inso/src/scripts/verify-pkg.js
+++ b/packages/insomnia-inso/src/scripts/verify-pkg.js
@@ -1,20 +1,31 @@
-const spawn = require('child_process')... | [
"packages/insomnia-inso/src/scripts/verify-pkg.js"
] | [
{
"comment": "When the packaged binary is terminated by a signal, `spawnSync` returns `status === null`; the current message prints `exit null` and drops the signal information, which makes failures harder to diagnose.",
"path": "packages/insomnia-inso/src/scripts/verify-pkg.js",
"hunk": "@@ -1,20 +1,30... | true | ||
Kong/insomnia | 10,035 | comment_to_fix | fix: packaged inso segfault patch via pkg-safe consola reporter | `writeStream` checks for a cached `__write` function but never initializes it, so every call still re-reads `stream.write`. If the segfault workaround depends on caching the original `write` (as the `__write` name implies), this currently won’t take effect. | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/packages/insomnia-inso/src/reporters/fancy-reporter.ts b/packages/insomnia-inso/src/reporters/fancy-reporter.ts
new file mode 100644
index 000000000000..1fd31a09fe39
--- /dev/null
+++ b/packages/insomnia-inso/src/reporters/fancy-reporter.ts
@@ -0,0 +1,159 @@
+import path from 'node:path';
+import { formatW... | [
"packages/insomnia-inso/src/reporters/fancy-reporter.ts"
] | [
{
"comment": "`writeStream` checks for a cached `__write` function but never initializes it, so every call still re-reads `stream.write`. If the segfault workaround depends on caching the original `write` (as the `__write` name implies), this currently won’t take effect.",
"path": "packages/insomnia-inso/sr... | true | ||
Kong/insomnia | 10,035 | comment_to_fix | fix: packaged inso segfault patch via pkg-safe consola reporter | In the `trace` formatting branch, the stack is derived from `logObj.message`, but `formatLogObj` already has the rendered first-line `message`. Using `message` avoids depending on an optional/non-standard `LogObject.message` field and prevents creating a `Trace: undefined` error when `message` isn’t present on the obje... | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/packages/insomnia-inso/src/reporters/fancy-reporter.ts b/packages/insomnia-inso/src/reporters/fancy-reporter.ts
new file mode 100644
index 000000000000..1fd31a09fe39
--- /dev/null
+++ b/packages/insomnia-inso/src/reporters/fancy-reporter.ts
@@ -0,0 +1,159 @@
+import path from 'node:path';
+import { formatW... | [
"packages/insomnia-inso/src/reporters/fancy-reporter.ts"
] | [
{
"comment": "In the `trace` formatting branch, the stack is derived from `logObj.message`, but `formatLogObj` already has the rendered first-line `message`. Using `message` avoids depending on an optional/non-standard `LogObject.message` field and prevents creating a `Trace: undefined` error when `message` isn... | true | ||
Kong/insomnia | 10,035 | comment_to_fix | fix: packaged inso segfault patch via pkg-safe consola reporter | When a process terminates via signal (e.g. SIGSEGV), `spawnSync` sets `status` to `null`. The current check prints `exit null` and drops the signal information, making segfault regressions harder to diagnose (this script is explicitly meant to catch those). | b019b6e207a3c226b21f6fc243f3c404e5f1a4af | 7a2fdc5be66f3190852fd13b5adaca4c46b6f44d | diff --git a/packages/insomnia-inso/src/scripts/verify-pkg.js b/packages/insomnia-inso/src/scripts/verify-pkg.js
index d77ae5c49a2f..605e8381dc6e 100644
--- a/packages/insomnia-inso/src/scripts/verify-pkg.js
+++ b/packages/insomnia-inso/src/scripts/verify-pkg.js
@@ -1,20 +1,31 @@
-const spawn = require('child_process')... | [
"packages/insomnia-inso/src/scripts/verify-pkg.js"
] | [
{
"comment": "When a process terminates via signal (e.g. SIGSEGV), `spawnSync` sets `status` to `null`. The current check prints `exit null` and drops the signal information, making segfault regressions harder to diagnose (this script is explicitly meant to catch those).",
"path": "packages/insomnia-inso/sr... | true | ||
Kong/insomnia | 10,037 | issue_to_patch | refactor(runtime): introduce explicit network runtime capabilities | ## Summary
Introduce a typed `RuntimeCapabilities` boundary and migrate the first capability group: `network`.
This is an incremental step toward making runtime/process-specific code more explicit. Instead of having shared code import process-specific adapters directly, entrypoints initialize the appropriate runt... | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia-inso/src/cli.ts b/packages/insomnia-inso/src/cli.ts
index 522d99bb9b9..fb579ae75bc 100644
--- a/packages/insomnia-inso/src/cli.ts
+++ b/packages/insomnia-inso/src/cli.ts
@@ -10,6 +10,8 @@ import { Confirm } from 'enquirer';
import { pick } from 'es-toolkit';
import { isDevelopment, JSON... | [
"packages/insomnia-inso/src/cli.ts",
"packages/insomnia-inso/vitest.config.ts",
"packages/insomnia/setup-vitest.ts",
"packages/insomnia/src/common/__tests__/har.test.ts",
"packages/insomnia/src/common/runtime/index.ts",
"packages/insomnia/src/common/runtime/runtime.node.ts",
"packages/insomnia/src/commo... | [
{
"comment": "`initRuntime(nodeRuntime)` is executed before the Vitest mocks are registered. Because `nodeRuntime` statically imports `network-adapter.node` → `main/network/libcurl-promise`, this can eagerly load the real `electron` and `@getinsomnia/node-libcurl` modules before `vi.mock(...)` takes effect, cau... | diff --git a/packages/insomnia/src/common/__tests__/har.test.ts b/packages/insomnia/src/common/__tests__/har.test.ts
index f7edfe8cae9..e744d63c483 100644
--- a/packages/insomnia/src/common/__tests__/har.test.ts
+++ b/packages/insomnia/src/common/__tests__/har.test.ts
@@ -2,15 +2,19 @@ import path from 'node:path';
... | true | |
Kong/insomnia | 10,037 | comment_to_fix | refactor(runtime): introduce explicit network runtime capabilities | `initRuntime(nodeRuntime)` makes the CLI use the Node network runtime. That runtime’s `getTimelinePath()` implementation (in `packages/insomnia/src/network/network-adapter.node.ts`) calls `require('electron')`, which will throw in `insomnia-inso` environments because `insomnia-inso` does not declare an `electron` depen... | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia-inso/src/cli.ts b/packages/insomnia-inso/src/cli.ts
index 522d99bb9b9..fb579ae75bc 100644
--- a/packages/insomnia-inso/src/cli.ts
+++ b/packages/insomnia-inso/src/cli.ts
@@ -10,6 +10,8 @@ import { Confirm } from 'enquirer';
import { pick } from 'es-toolkit';
import { isDevelopment, JSON... | [
"packages/insomnia-inso/src/cli.ts"
] | [
{
"comment": "`initRuntime(nodeRuntime)` makes the CLI use the Node network runtime. That runtime’s `getTimelinePath()` implementation (in `packages/insomnia/src/network/network-adapter.node.ts`) calls `require('electron')`, which will throw in `insomnia-inso` environments because `insomnia-inso` does not decla... | true | ||
Kong/insomnia | 10,037 | comment_to_fix | refactor(runtime): introduce explicit network runtime capabilities | Inconsistency: `applyRequestHooks` was migrated to `getRuntime().network.*` (see line 248), but `getAuthHeader` is still imported directly here — even though `NetworkRuntime` exposes `getAuthHeader` via the same runtime interface.
Either migrate this too (`getRuntime().network.getAuthHeader(...)`) or document why `har... | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia/src/main/har.ts b/packages/insomnia/src/main/har.ts
index e00e36942f6..3c2dd3db5b2 100644
--- a/packages/insomnia/src/main/har.ts
+++ b/packages/insomnia/src/main/har.ts
@@ -3,9 +3,9 @@ import type { BaseModel, Cookie, Environment, Request, RequestGroup, Response, W
import { models, serv... | [
"packages/insomnia/src/main/har.ts"
] | [
{
"comment": "Inconsistency: `applyRequestHooks` was migrated to `getRuntime().network.*` (see line 248), but `getAuthHeader` is still imported directly here — even though `NetworkRuntime` exposes `getAuthHeader` via the same runtime interface.\n\nEither migrate this too (`getRuntime().network.getAuthHeader(...... | true | ||
Kong/insomnia | 10,037 | comment_to_fix | refactor(runtime): introduce explicit network runtime capabilities | The throw-on-reinit guard makes the singleton non-resettable, which is awkward for tests. `setup-vitest.ts` initialises `nodeRuntime` globally, which works until a test needs to swap the implementation — at that point the only escape is `vi.mock('~/common/runtime', ...)`, which mocks the registry itself rather than the... | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia/src/common/runtime/index.ts b/packages/insomnia/src/common/runtime/index.ts
new file mode 100644
index 00000000000..2e9eb0683cb
--- /dev/null
+++ b/packages/insomnia/src/common/runtime/index.ts
@@ -0,0 +1,19 @@
+import type { RuntimeCapabilities } from './types';
+
+let runtime: RuntimeCa... | [
"packages/insomnia/src/common/runtime/index.ts"
] | [
{
"comment": "The throw-on-reinit guard makes the singleton non-resettable, which is awkward for tests. `setup-vitest.ts` initialises `nodeRuntime` globally, which works until a test needs to swap the implementation — at that point the only escape is `vi.mock('~/common/runtime', ...)`, which mocks the registry ... | true | ||
Kong/insomnia | 10,037 | comment_to_fix | refactor(runtime): introduce explicit network runtime capabilities | This `require` → `await import` change is functionally unrelated to the IoC container refactor. It changes plugin-index loading from synchronous to async and would be easier to bisect/revert if split into its own commit. | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia/src/network/network-adapter.node.ts b/packages/insomnia/src/network/network-adapter.node.ts
index b7d8338e7ba..bab8a32cea0 100644
--- a/packages/insomnia/src/network/network-adapter.node.ts
+++ b/packages/insomnia/src/network/network-adapter.node.ts
@@ -77,7 +77,7 @@ export async function... | [
"packages/insomnia/src/network/network-adapter.node.ts"
] | [
{
"comment": "This `require` → `await import` change is functionally unrelated to the IoC container refactor. It changes plugin-index loading from synchronous to async and would be easier to bisect/revert if split into its own commit.",
"path": "packages/insomnia/src/network/network-adapter.node.ts",
"h... | true | ||
Kong/insomnia | 10,037 | comment_to_fix | refactor(runtime): introduce explicit network runtime capabilities | `RuntimeCapabilities` currently has a single slot (`network`). If more capabilities are planned (e.g. `storage`, `scripting`), the nesting is justified. If `network` is all there will ever be, the extra wrapper just adds `.network.` noise to every call site with no benefit. Worth a note in the PR description clarifying... | 767260931d65e130be3d2f0077c86b1db34634b4 | 3c8f0d5f9e1a6caf3bcf3804d4904f55f90235bf | diff --git a/packages/insomnia/src/common/runtime/types.ts b/packages/insomnia/src/common/runtime/types.ts
new file mode 100644
index 00000000000..5de4963fdb7
--- /dev/null
+++ b/packages/insomnia/src/common/runtime/types.ts
@@ -0,0 +1,38 @@
+import type { Cookie, RequestHeader } from 'insomnia-data';
+
+import type { ... | [
"packages/insomnia/src/common/runtime/types.ts"
] | [
{
"comment": "`RuntimeCapabilities` currently has a single slot (`network`). If more capabilities are planned (e.g. `storage`, `scripting`), the nesting is justified. If `network` is all there will ever be, the extra wrapper just adds `.network.` noise to every call site with no benefit. Worth a note in the PR ... | true | ||
Kong/insomnia | 9,989 | issue_to_patch | chore: add e2e tests for custom linting rules | ed388d2fa96518dcbc162d8e1342216cfff8744b | cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a | diff --git a/packages/insomnia-smoke-test/fixtures/files/custom.spectral.yaml b/packages/insomnia-smoke-test/fixtures/files/custom.spectral.yaml
new file mode 100644
index 000000000000..7004ddb37295
--- /dev/null
+++ b/packages/insomnia-smoke-test/fixtures/files/custom.spectral.yaml
@@ -0,0 +1,10 @@
+extends: [spectral... | [
"packages/insomnia-smoke-test/fixtures/files/custom.spectral.yaml",
"packages/insomnia-smoke-test/fixtures/files/invalid.spectral.yaml",
"packages/insomnia-smoke-test/playwright/launch.ts",
"packages/insomnia-smoke-test/playwright/pages/insomnia-app.ts",
"packages/insomnia-smoke-test/playwright/test.ts",
... | [
{
"comment": "**Exposed secret in packages/insomnia-smoke-test/server/cloud-sync-api.ts** - high severity\nDetected a Generic API Key, potentially exposing access to various services and sensitive operations.\n\n<sub>Reply `@AikidoSec ignore: [REASON]` to ignore this issue.</sub>\n<sub>[More Info](https://app.a... | diff --git a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts
new file mode 100644
index 000000000000..df4e42d7d530
--- /dev/null
+++ b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts
@@ -0,0 +1,406 @@
+import fs f... | true | ||
Kong/insomnia | 9,989 | comment_to_fix | chore: add e2e tests for custom linting rules | **Exposed secret in packages/insomnia-smoke-test/server/cloud-sync-api.ts** - high severity
Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
<sub>Reply `@AikidoSec ignore: [REASON]` to ignore this issue.</sub>
<sub>[More Info](https://app.aikido.dev/repositories/126... | ed388d2fa96518dcbc162d8e1342216cfff8744b | cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a | diff --git a/packages/insomnia-smoke-test/server/cloud-sync-api.ts b/packages/insomnia-smoke-test/server/cloud-sync-api.ts
index 69e5f113a7ba..3ce4571d85ab 100644
--- a/packages/insomnia-smoke-test/server/cloud-sync-api.ts
+++ b/packages/insomnia-smoke-test/server/cloud-sync-api.ts
@@ -1,10 +1,10 @@
+import crypto from... | [
"packages/insomnia-smoke-test/server/cloud-sync-api.ts"
] | [
{
"comment": "**Exposed secret in packages/insomnia-smoke-test/server/cloud-sync-api.ts** - high severity\nDetected a Generic API Key, potentially exposing access to various services and sensitive operations.\n\n<sub>Reply `@AikidoSec ignore: [REASON]` to ignore this issue.</sub>\n<sub>[More Info](https://app.a... | true | ||
Kong/insomnia | 9,989 | comment_to_fix | chore: add e2e tests for custom linting rules | **Exposed secret in packages/insomnia-smoke-test/server/cloud-sync-api.ts** - high severity
Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
<sub>Reply `@AikidoSec ignore: [REASON]` to ignore this issue.</sub>
<sub>[More Info](https://app.aikido.dev/repositories/126... | ed388d2fa96518dcbc162d8e1342216cfff8744b | cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a | diff --git a/packages/insomnia-smoke-test/server/cloud-sync-api.ts b/packages/insomnia-smoke-test/server/cloud-sync-api.ts
index 69e5f113a7ba..3ce4571d85ab 100644
--- a/packages/insomnia-smoke-test/server/cloud-sync-api.ts
+++ b/packages/insomnia-smoke-test/server/cloud-sync-api.ts
@@ -1,10 +1,10 @@
+import crypto from... | [
"packages/insomnia-smoke-test/server/cloud-sync-api.ts"
] | [
{
"comment": "**Exposed secret in packages/insomnia-smoke-test/server/cloud-sync-api.ts** - high severity\nDetected a Generic API Key, potentially exposing access to various services and sensitive operations.\n\n<sub>Reply `@AikidoSec ignore: [REASON]` to ignore this issue.</sub>\n<sub>[More Info](https://app.a... | true | ||
Kong/insomnia | 9,989 | comment_to_fix | chore: add e2e tests for custom linting rules | In Playwright mode, falling back to `dialog.showOpenDialog()` when no queued response exists can open a native OS dialog and hang CI/test runs. It’s safer to always return a canceled/empty result when `PLAYWRIGHT === 'true'` and the queue is empty (and also guard against `shift()` returning undefined). | ed388d2fa96518dcbc162d8e1342216cfff8744b | cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a | diff --git a/packages/insomnia/src/main/ipc/electron.ts b/packages/insomnia/src/main/ipc/electron.ts
index 214eea46b656..a6caddb93688 100644
--- a/packages/insomnia/src/main/ipc/electron.ts
+++ b/packages/insomnia/src/main/ipc/electron.ts
@@ -1,5 +1,9 @@
import { mkdirSync } from 'node:fs';
+declare global {
+ var ... | [
"packages/insomnia/src/main/ipc/electron.ts"
] | [
{
"comment": "In Playwright mode, falling back to `dialog.showOpenDialog()` when no queued response exists can open a native OS dialog and hang CI/test runs. It’s safer to always return a canceled/empty result when `PLAYWRIGHT === 'true'` and the queue is empty (and also guard against `shift()` returning undefi... | true | ||
Kong/insomnia | 9,989 | comment_to_fix | chore: add e2e tests for custom linting rules | `playwrightConfig.webServer` is configured as an array in this repo, so `playwrightConfig?.webServer?.url` is always `undefined` and this line always falls back to the hard-coded URL. That makes the comment inaccurate and makes the test brittle if the echo server URL/port changes in the config. | ed388d2fa96518dcbc162d8e1342216cfff8744b | cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a | diff --git a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts
new file mode 100644
index 000000000000..df4e42d7d530
--- /dev/null
+++ b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts
@@ -0,0 +1,406 @@
+import fs f... | [
"packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts"
] | [
{
"comment": "`playwrightConfig.webServer` is configured as an array in this repo, so `playwrightConfig?.webServer?.url` is always `undefined` and this line always falls back to the hard-coded URL. That makes the comment inaccurate and makes the test brittle if the echo server URL/port changes in the config.",
... | true | ||
Kong/insomnia | 10,034 | issue_to_patch | Implement app context methods via fetch bridge | ## Summary
Replace stub implementations of app context methods (alert, dialog, prompt, getPath, clipboard operations, showSaveDialog) with actual implementations using the fetch bridge to the main process.
This allows plugins to properly use app context methods in template tags instead of throwing errors.
## Changes
... | bece18552e897c17451c9b5f524ec470a91c97da | a66b78d470f64679a904b1d5b5b02fb28aec70c1 | diff --git a/packages/insomnia/src/main/templating-worker-database.ts b/packages/insomnia/src/main/templating-worker-database.ts
index 32ed81fc6e6..689797839f3 100644
--- a/packages/insomnia/src/main/templating-worker-database.ts
+++ b/packages/insomnia/src/main/templating-worker-database.ts
@@ -2,7 +2,7 @@ import type... | [
"packages/insomnia/src/main/templating-worker-database.ts",
"packages/insomnia/src/plugins/context/app.ts",
"packages/insomnia/src/templating/liquid-extension-worker.ts",
"packages/insomnia/src/templating/types.ts"
] | [] | true | ||
Kong/insomnia | 9,940 | issue_to_patch | Streamline workspace create & settings form [INS-2621] | This PR addresses a few usability issues in the "Create a new *" and "* Settings" modals for Git Sync projects:
1. Editing just the name and leaving the filename untouched in the Settings modal still leads to a validation error for the filename, preventing the user from saving the new name.
2. Filename input width is... | 4bc34bba992a8e9f87d80b04b6501d4621b25fd5 | 0b22d18e2cd6831e69fb65fe6a86f66a5e55a7a8 | diff --git a/packages/insomnia/src/ui/components/modals/new-workspace-modal.tsx b/packages/insomnia/src/ui/components/modals/new-workspace-modal.tsx
index 90c58283bfc..9309d422b8b 100644
--- a/packages/insomnia/src/ui/components/modals/new-workspace-modal.tsx
+++ b/packages/insomnia/src/ui/components/modals/new-workspa... | [
"packages/insomnia/src/ui/components/modals/new-workspace-modal.tsx",
"packages/insomnia/src/ui/components/modals/workspace-settings-modal.tsx"
] | [
{
"comment": "Enforcing a minimum width on this was leading to a strange gap when typing short filenames one the hardcoded extension was allowed to move around freely:\n\n<img width=\"346\" height=\"204\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/5117b993-77a8-4401-a0ea-2c634e95fb3e\" />",
... | true | ||
Kong/insomnia | 10,030 | issue_to_patch | fix: runner route bug | Previous code was triggering a full renderer refresh becuase of a bad route matcher in this component. This is replaced with a conditional render.
Error message that this PR fixes
```
You rendered descendant <Routes> (or called `useRoutes()`) at
"/organization/org_7f5554f7-34a7-43e5-8e51-691984a61ae9/pro... | 3752d54a908d01dd58610fd1073ab0666844cd90 | d47d2c1e68ecaf8e19cc8338278125d764048482 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.tsx
index 74ab0992ad2..4e8df4c32fa 100644
--- a/packages/insomnia/src/routes/organization... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.tsx"
] | [] | true | ||
Kong/insomnia | 9,991 | issue_to_patch | fix(linting): resolved TOC/TOU issue (INS-2691); adds refresh button to recompile a ruleset; address minor bugs | ## What this PR does
- Remote extends URLs were fetched twice. Once for validation, once (unguarded) by the lint worker. This PR resolves the TROC/TOU issues by compiling the ruleset once in the main process into a flattened, validated, URL-free object and lint off that, as a result, the worker has nothing left to ... | b8195724586a18d5434ba35cb343fc326e5ab084 | 211400f3d2eb449b8a9716420353ae8b9be40453 | diff --git a/packages/insomnia-inso/src/commands/lint-specification.ts b/packages/insomnia-inso/src/commands/lint-specification.ts
index ab7646e8727d..142fd73f3691 100644
--- a/packages/insomnia-inso/src/commands/lint-specification.ts
+++ b/packages/insomnia-inso/src/commands/lint-specification.ts
@@ -11,7 +11,7 @@ imp... | [
"packages/insomnia-inso/src/commands/lint-specification.ts",
"packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts",
"packages/insomnia/src/common/__tests__/private-host.test.ts",
"packages/insomnia/src/common/bundle-spectral-ruleset.ts",
"packages/insomnia/src/common/private-hos... | [
{
"comment": "## Semgrep OSS / Semgrep Finding: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring\n\nDetected string concatenation with a non-literal variable in a util.format / console.log function. If an attacker injects a format specifier in the string, it will forge the log message. Try... | diff --git a/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts b/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts
index c6bf35cbbe7b..778f8ceb8878 100644
--- a/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts
+++ b/packages/i... | true | |
Kong/insomnia | 9,991 | comment_to_fix | fix(linting): resolved TOC/TOU issue (INS-2691); adds refresh button to recompile a ruleset; address minor bugs | **Potential file inclusion attack via reading file** - medium severity
If an attacker can control the input leading into the ReadFile function, they might be able to read sensitive files and launch further attacks with that information.
<details>
<summary>Show fix</summary>
```suggestion
const base = path.resolve(p... | b8195724586a18d5434ba35cb343fc326e5ab084 | 211400f3d2eb449b8a9716420353ae8b9be40453 | diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts
new file mode 100644
index 000000000000..fa30388fef33
--- /dev/null
+++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts
@@ -0,0 +1,64 @@
+import { createHash } from 'node:crypto';
+import fs f... | [
"packages/insomnia/src/main/spectral-ruleset-cache.ts"
] | [
{
"comment": "**Potential file inclusion attack via reading file** - medium severity\nIf an attacker can control the input leading into the ReadFile function, they might be able to read sensitive files and launch further attacks with that information.\n\n<details>\n<summary>Show fix</summary>\n\n```suggestion\n... | true | ||
Kong/insomnia | 9,991 | comment_to_fix | fix(linting): resolved TOC/TOU issue (INS-2691); adds refresh button to recompile a ruleset; address minor bugs | The lint helper registration closure captures `projectId`, but this effect only re-runs when `rulesetContent` changes. If the route params change without a full unmount/remount (e.g. navigating between projects), linting could compile/write rulesets under the wrong project ID and point the worker at the wrong cached ru... | b8195724586a18d5434ba35cb343fc326e5ab084 | 211400f3d2eb449b8a9716420353ae8b9be40453 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx
index 0ec897c198d7..221768d857b2 100644
--- a/packages/insomnia/src/routes/organization... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx"
] | [
{
"comment": "The lint helper registration closure captures `projectId`, but this effect only re-runs when `rulesetContent` changes. If the route params change without a full unmount/remount (e.g. navigating between projects), linting could compile/write rulesets under the wrong project ID and point the worker ... | true | ||
Kong/insomnia | 9,991 | comment_to_fix | fix(linting): resolved TOC/TOU issue (INS-2691); adds refresh button to recompile a ruleset; address minor bugs | `projectId` is interpolated directly into an on-disk path via `path.join(...)`. Since `projectId` comes from IPC options (ultimately renderer-controlled), a malicious value containing path separators/`..` could escape the intended base directory and cause arbitrary file write/delete under the app's data path. | b8195724586a18d5434ba35cb343fc326e5ab084 | 211400f3d2eb449b8a9716420353ae8b9be40453 | diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts
new file mode 100644
index 000000000000..fa30388fef33
--- /dev/null
+++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts
@@ -0,0 +1,64 @@
+import { createHash } from 'node:crypto';
+import fs f... | [
"packages/insomnia/src/main/spectral-ruleset-cache.ts"
] | [
{
"comment": "`projectId` is interpolated directly into an on-disk path via `path.join(...)`. Since `projectId` comes from IPC options (ultimately renderer-controlled), a malicious value containing path separators/`..` could escape the intended base directory and cause arbitrary file write/delete under the app'... | true | ||
Kong/insomnia | 9,991 | comment_to_fix | fix(linting): resolved TOC/TOU issue (INS-2691); adds refresh button to recompile a ruleset; address minor bugs | Typo in comment: "We need to this" → "We need this". | b8195724586a18d5434ba35cb343fc326e5ab084 | 211400f3d2eb449b8a9716420353ae8b9be40453 | diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts
new file mode 100644
index 000000000000..fa30388fef33
--- /dev/null
+++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts
@@ -0,0 +1,64 @@
+import { createHash } from 'node:crypto';
+import fs f... | [
"packages/insomnia/src/main/spectral-ruleset-cache.ts"
] | [
{
"comment": "Typo in comment: \"We need to this\" → \"We need this\".",
"path": "packages/insomnia/src/main/spectral-ruleset-cache.ts",
"hunk": "@@ -0,0 +1,55 @@\n+import { createHash } from 'node:crypto';\n+import fs from 'node:fs';\n+import path from 'node:path';\n+\n+import { app } from 'electron';\... | true | ||
Kong/insomnia | 10,015 | issue_to_patch | feat: user-agent default handling for v13 | - Removes the `disableAppVersionUserAgent` setting, opting to allow for specific overrides on individual requests.
- No longer adds a `User-Agent` header to new requests.
- The headers tab now shows a default that can be enabled/disabled freely, which is hidden when requests have a custom `User-Agent` header.
Defa... | 54a23e3bbb64f35160fd0e38b75a5b0e755efdcb | ce08a276dcf0ef62fbdfaec4b163cdb67089f96b | diff --git a/packages/insomnia-data/common-src/settings.ts b/packages/insomnia-data/common-src/settings.ts
index 97e1800412c3..1ba4e4a4b012 100644
--- a/packages/insomnia-data/common-src/settings.ts
+++ b/packages/insomnia-data/common-src/settings.ts
@@ -109,8 +109,6 @@ export interface Settings {
disableResponseP... | [
"packages/insomnia-data/__tests__/grpc-request.test.ts",
"packages/insomnia-data/common-src/settings.ts",
"packages/insomnia-data/node-src/database/database.test.ts",
"packages/insomnia-data/src/models/grpc-request.ts",
"packages/insomnia-data/src/models/mcp-request.ts",
"packages/insomnia-data/src/models... | [
{
"comment": "The read-only row toggle is rendered even when `pair.canDisable` is falsy (it’s only made `invisible`). Because `ToggleButton` remains focusable, keyboard users can tab to an invisible control. Also, if `pair.canDisable` is true but `onReadOnlyDisabledChange` is not provided, the control appears i... | diff --git a/packages/insomnia-data/__tests__/grpc-request.test.ts b/packages/insomnia-data/__tests__/grpc-request.test.ts
index 9eeb027d5295..1274caf52730 100644
--- a/packages/insomnia-data/__tests__/grpc-request.test.ts
+++ b/packages/insomnia-data/__tests__/grpc-request.test.ts
@@ -22,6 +22,7 @@ describe('init()', ... | true | |
Kong/insomnia | 10,015 | comment_to_fix | feat: user-agent default handling for v13 | The read-only row toggle is rendered even when `pair.canDisable` is falsy (it’s only made `invisible`). Because `ToggleButton` remains focusable, keyboard users can tab to an invisible control. Also, if `pair.canDisable` is true but `onReadOnlyDisabledChange` is not provided, the control appears interactive but can’t p... | 54a23e3bbb64f35160fd0e38b75a5b0e755efdcb | ce08a276dcf0ef62fbdfaec4b163cdb67089f96b | diff --git a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx
index 2a687c63ceeb..dff5335232b6 100644
--- a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx
+++ b/packages/insomnia/src/ui/compon... | [
"packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx"
] | [
{
"comment": "The read-only row toggle is rendered even when `pair.canDisable` is falsy (it’s only made `invisible`). Because `ToggleButton` remains focusable, keyboard users can tab to an invisible control. Also, if `pair.canDisable` is true but `onReadOnlyDisabledChange` is not provided, the control appears i... | true | ||
Kong/insomnia | 10,015 | comment_to_fix | feat: user-agent default handling for v13 | This User-Agent fallback injection only checks for an *enabled* `user-agent` header. If a user adds a `User-Agent` header and disables it (or disables all User-Agent headers), `lowerCasedEnabledHeaders['user-agent']` becomes `undefined` and this code re-injects the default `insomnia/<version>` UA anyway.
That makes it... | 54a23e3bbb64f35160fd0e38b75a5b0e755efdcb | ce08a276dcf0ef62fbdfaec4b163cdb67089f96b | diff --git a/packages/insomnia/src/main/network/websocket.ts b/packages/insomnia/src/main/network/websocket.ts
index 466f90792061..adfcc9c5431a 100644
--- a/packages/insomnia/src/main/network/websocket.ts
+++ b/packages/insomnia/src/main/network/websocket.ts
@@ -22,6 +22,7 @@ import { type CloseEvent, type ErrorEvent, ... | [
"packages/insomnia/src/main/network/websocket.ts"
] | [
{
"comment": "This User-Agent fallback injection only checks for an *enabled* `user-agent` header. If a user adds a `User-Agent` header and disables it (or disables all User-Agent headers), `lowerCasedEnabledHeaders['user-agent']` becomes `undefined` and this code re-injects the default `insomnia/<version>` UA ... | true | ||
Kong/insomnia | 10,015 | comment_to_fix | feat: user-agent default handling for v13 | Same issue as websocket.ts: this fallback injection checks only for an *enabled* `user-agent` header. If a user intentionally disables their `User-Agent` header(s), the fallback `insomnia/<version>` UA will still be injected because disabled headers are filtered out.
Inject the fallback only when there is no `User-Age... | 54a23e3bbb64f35160fd0e38b75a5b0e755efdcb | ce08a276dcf0ef62fbdfaec4b163cdb67089f96b | diff --git a/packages/insomnia/src/main/network/socket-io.ts b/packages/insomnia/src/main/network/socket-io.ts
index 98bbfe32d5cc..be3ed6c43a1e 100644
--- a/packages/insomnia/src/main/network/socket-io.ts
+++ b/packages/insomnia/src/main/network/socket-io.ts
@@ -18,6 +18,7 @@ import { v4 as uuidV4 } from 'uuid';
imp... | [
"packages/insomnia/src/main/network/socket-io.ts"
] | [
{
"comment": "Same issue as websocket.ts: this fallback injection checks only for an *enabled* `user-agent` header. If a user intentionally disables their `User-Agent` header(s), the fallback `insomnia/<version>` UA will still be injected because disabled headers are filtered out.\n\nInject the fallback only wh... | true | ||
Kong/insomnia | 10,026 | issue_to_patch | refactor: remove dead vite config stubs and fix stale comments | ## Summary
- Remove `@apidevtools/swagger-parser` and `mocha` from `externalDependencies` — both are only imported in the main process, never in the renderer
- Update stale comment claiming `nodeIntegration: true` is still being used
- Remove misleading `insomnia-testing` example from SSR conditions comment
- Remove `m... | cb47e882a597fdd90b33d611a35893fc1d7e9dd9 | 76f5f4ce66830ace555ab33cce458d13f6bc0eeb | diff --git a/packages/insomnia-testing/package.json b/packages/insomnia-testing/package.json
index d767e046ef5..7f4420fcc18 100644
--- a/packages/insomnia-testing/package.json
+++ b/packages/insomnia-testing/package.json
@@ -12,8 +12,6 @@
"bugs": {
"url": "https://github.com/Kong/insomnia/issues"
},
- "main... | [
"packages/insomnia-testing/package.json",
"packages/insomnia/vite.config.ts"
] | [] | true | ||
Kong/insomnia | 10,006 | issue_to_patch | fix: new sidebar UI issues | # Changes:
- Support sidebar item context menu
- Add `import` item in project dropdown
- Refine and align the icon and text for project dropdown
- Enhance the drag & drop behavior
- Can not drop to a expanded collection unless drop to the last item of the collection
- Allow drop to the top of the project
-... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx
index 0f49b5325286..27be1a8b40b4 100644
--- a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index... | [
"packages/insomnia-smoke-test/tests/critical/scratchpad.test.ts",
"packages/insomnia-smoke-test/tests/smoke/after-response-script-features.test.ts",
"packages/insomnia-smoke-test/tests/smoke/dashboard-interactions.test.ts",
"packages/insomnia-smoke-test/tests/smoke/git-sync.test.ts",
"packages/insomnia-smok... | [
{
"comment": "The visible labels were renamed from \"Global Environment(s)\" to \"Project Environment(s)\", but the surrounding `aria-label` attributes still reference \"Manage global environment\" (line 141) and \"Global Environment\" (lines 155 and 196). For screen-reader consistency with the new wording, the... | diff --git a/packages/insomnia-smoke-test/tests/critical/scratchpad.test.ts b/packages/insomnia-smoke-test/tests/critical/scratchpad.test.ts
index ec8be04f756c..df171e20fb6b 100644
--- a/packages/insomnia-smoke-test/tests/critical/scratchpad.test.ts
+++ b/packages/insomnia-smoke-test/tests/critical/scratchpad.test.ts
@... | true | |
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | The visible labels were renamed from "Global Environment(s)" to "Project Environment(s)", but the surrounding `aria-label` attributes still reference "Manage global environment" (line 141) and "Global Environment" (lines 155 and 196). For screen-reader consistency with the new wording, these aria-labels should be updat... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx
index 4e82bfcb5850..05e13fff70be 100644
--- a/packages/insomnia/src/ui/components/environment-picker.tsx
+++ b/packages/insomnia/src/ui/components/environment-picker.tsx
@@ -136,9 +136,9 ... | [
"packages/insomnia/src/ui/components/environment-picker.tsx"
] | [
{
"comment": "The visible labels were renamed from \"Global Environment(s)\" to \"Project Environment(s)\", but the surrounding `aria-label` attributes still reference \"Manage global environment\" (line 141) and \"Global Environment\" (lines 155 and 196). For screen-reader consistency with the new wording, the... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | The visible heading and placeholder text were renamed from "Global Environment(s)" to "Project Environment(s)", but the surrounding `aria-label`s ("Manage global environment" on the gear button, "Global Environment" on the ComboBox/Input) and the tooltip "active global environment" were left unchanged. This creates an ... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx
index 4e82bfcb5850..05e13fff70be 100644
--- a/packages/insomnia/src/ui/components/environment-picker.tsx
+++ b/packages/insomnia/src/ui/components/environment-picker.tsx
@@ -136,9 +136,9 ... | [
"packages/insomnia/src/ui/components/environment-picker.tsx"
] | [
{
"comment": "The visible heading and placeholder text were renamed from \"Global Environment(s)\" to \"Project Environment(s)\", but the surrounding `aria-label`s (\"Manage global environment\" on the gear button, \"Global Environment\" on the ComboBox/Input) and the tooltip \"active global environment\" were ... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | This callback now reads `localWorkspaceOrders` from the closure and is re-created whenever it changes (it was added to the dep array on line 691). Compared to the previous functional updater (`setLocalWorkspaceOrders(prev => ...)`), this is more fragile: if `handleLocalWorkspaceReorder` is invoked twice in the same ren... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx
index 266bf3749b53..22c34595771b 100644
--- a/packages/insomnia/src/ui/components/sidebar/project-nav... | [
"packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx"
] | [
{
"comment": "This callback now reads `localWorkspaceOrders` from the closure and is re-created whenever it changes (it was added to the dep array on line 691). Compared to the previous functional updater (`setLocalWorkspaceOrders(prev => ...)`), this is more fragile: if `handleLocalWorkspaceReorder` is invoked... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | `setLocalWorkspaceOrders({ ...localWorkspaceOrders, ... })` is not safe here because `reactUse.useLocalStorage` can yield `undefined` (e.g. read failure), and spreading `undefined` will throw at runtime. It also risks clobbering updates because it relies on the captured `localWorkspaceOrders` value instead of using a f... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx
index 266bf3749b53..22c34595771b 100644
--- a/packages/insomnia/src/ui/components/sidebar/project-nav... | [
"packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx"
] | [
{
"comment": "`setLocalWorkspaceOrders({ ...localWorkspaceOrders, ... })` is not safe here because `reactUse.useLocalStorage` can yield `undefined` (e.g. read failure), and spreading `undefined` will throw at runtime. It also risks clobbering updates because it relies on the captured `localWorkspaceOrders` valu... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | This input now prompts for a “project environment”, but its `aria-label` is still “Global Environment”, which makes the accessible name inconsistent with the visible label. | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx
index 4e82bfcb5850..05e13fff70be 100644
--- a/packages/insomnia/src/ui/components/environment-picker.tsx
+++ b/packages/insomnia/src/ui/components/environment-picker.tsx
@@ -136,9 +136,9 ... | [
"packages/insomnia/src/ui/components/environment-picker.tsx"
] | [
{
"comment": "This input now prompts for a “project environment”, but its `aria-label` is still “Global Environment”, which makes the accessible name inconsistent with the visible label.",
"path": "packages/insomnia/src/ui/components/environment-picker.tsx",
"hunk": "@@ -194,7 +194,7 @@ export const Env... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | The comment says cross-project drops allow “collection and design” workspaces, but the whitelist (`allowCrossProjectDropWorkspaceScope`) currently only includes `collection`. This mismatch makes the behavior unclear and can lead to incorrect future changes. | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/use-sidebar-drag-and-drop.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/use-sidebar-drag-and-drop.tsx
index ac1f8bc75514..028b19d2e18f 100644
--- a/packages/insomnia/src/ui/components/sidebar/project-navig... | [
"packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/use-sidebar-drag-and-drop.tsx"
] | [
{
"comment": "The comment says cross-project drops allow “collection and design” workspaces, but the whitelist (`allowCrossProjectDropWorkspaceScope`) currently only includes `collection`. This mismatch makes the behavior unclear and can lead to incorrect future changes.",
"path": "packages/insomnia/src/ui/... | true | ||
Kong/insomnia | 10,006 | comment_to_fix | fix: new sidebar UI issues | `ROW_CLASS` no longer applies a selected-text style (it previously used `group-aria-selected:text-(--color-font)`). This makes selected sidebar rows keep the dimmed text color (`rgba(...,0.8)`), which is inconsistent with other selectable lists (e.g. command palette uses `group-aria-selected:text-(--color-font)` at pac... | f82f7f4b8bc0b5dc254ad27e9a11cd0bd467db15 | 80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1 | diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar-utils.ts b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar-utils.ts
index 437ab0b1499d..be6383c9f30e 100644
--- a/packages/insomnia/src/ui/components/sidebar/p... | [
"packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar-utils.ts"
] | [
{
"comment": "`ROW_CLASS` no longer applies a selected-text style (it previously used `group-aria-selected:text-(--color-font)`). This makes selected sidebar rows keep the dimmed text color (`rgba(...,0.8)`), which is inconsistent with other selectable lists (e.g. command palette uses `group-aria-selected:text-... | true | ||
Kong/insomnia | 10,007 | issue_to_patch | fix: first request feature feedback | <!--
Please open an [Issue](https://github.com/kong/insomnia/issues/new) first to discuss new
features or non-trivial changes. Please provide as much detail as possible on the change as
possible including general description, implementation details, potential shortcomings, etc.
If this PR closes an issue, please ... | 79c544238b2e2940b4342b8b5ec710c002c1a593 | ce94a6569ee97b12336d1402cdb5c0a306e602e8 | diff --git a/packages/insomnia/src/basic-components/select-popover.tsx b/packages/insomnia/src/basic-components/select-popover.tsx
index 64a74cdd90bf..2fa8ff65b3a9 100644
--- a/packages/insomnia/src/basic-components/select-popover.tsx
+++ b/packages/insomnia/src/basic-components/select-popover.tsx
@@ -109,18 +109,15 @@... | [
"packages/insomnia-smoke-test/tests/critical/bundling.test.ts",
"packages/insomnia/src/basic-components/select-popover.tsx",
"packages/insomnia/src/common/project.ts",
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx",
"packages/insomnia/src/routes/organization.$organ... | [
{
"comment": "`SelectPopover` now sets `disallowEmptySelection` while still allowing `selectedKey` to be `null`/`undefined` (it passes `selectedKeys={[]}` in that case). This makes the API inconsistent and can force an unintended selection (e.g., `FirstRequestCreation` expects `selectedCollectionId` to be nulla... | diff --git a/packages/insomnia-smoke-test/tests/critical/bundling.test.ts b/packages/insomnia-smoke-test/tests/critical/bundling.test.ts
index bd7046be1fb2..228a2c97d571 100644
--- a/packages/insomnia-smoke-test/tests/critical/bundling.test.ts
+++ b/packages/insomnia-smoke-test/tests/critical/bundling.test.ts
@@ -20,7 ... | true | |
Kong/insomnia | 10,007 | comment_to_fix | fix: first request feature feedback | `SelectPopover` now sets `disallowEmptySelection` while still allowing `selectedKey` to be `null`/`undefined` (it passes `selectedKeys={[]}` in that case). This makes the API inconsistent and can force an unintended selection (e.g., `FirstRequestCreation` expects `selectedCollectionId` to be nullable to mean “create a ... | 79c544238b2e2940b4342b8b5ec710c002c1a593 | ce94a6569ee97b12336d1402cdb5c0a306e602e8 | diff --git a/packages/insomnia/src/basic-components/select-popover.tsx b/packages/insomnia/src/basic-components/select-popover.tsx
index 64a74cdd90bf..2fa8ff65b3a9 100644
--- a/packages/insomnia/src/basic-components/select-popover.tsx
+++ b/packages/insomnia/src/basic-components/select-popover.tsx
@@ -109,18 +109,15 @@... | [
"packages/insomnia/src/basic-components/select-popover.tsx"
] | [
{
"comment": "`SelectPopover` now sets `disallowEmptySelection` while still allowing `selectedKey` to be `null`/`undefined` (it passes `selectedKeys={[]}` in that case). This makes the API inconsistent and can force an unintended selection (e.g., `FirstRequestCreation` expects `selectedCollectionId` to be nulla... | true | ||
Kong/insomnia | 10,007 | comment_to_fix | fix: first request feature feedback | Query parameter name `isExpended` looks like a typo ("expanded" vs "expended"). Since this flag is intended to control sidebar expansion, use a correctly spelled and self-descriptive parameter name to avoid baking a misspelling into URLs and future code. | 79c544238b2e2940b4342b8b5ec710c002c1a593 | ce94a6569ee97b12336d1402cdb5c0a306e602e8 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx b/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx
index c77c1bbdb432..69195ebb0da5 100644
--- a/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx
+++ b/packages/insomnia/src/... | [
"packages/insomnia/src/routes/organization.$organizationId.project._index.tsx"
] | [
{
"comment": "Query parameter name `isExpended` looks like a typo (\"expanded\" vs \"expended\"). Since this flag is intended to control sidebar expansion, use a correctly spelled and self-descriptive parameter name to avoid baking a misspelling into URLs and future code.",
"path": "packages/insomnia/src/ro... | true | ||
Kong/insomnia | 10,007 | comment_to_fix | fix: first request feature feedback | This code reads `isExpended` from the URL query string, which appears to be a typo for `isExpanded` (used to control sidebar expansion). Renaming the parameter improves clarity and avoids propagating the misspelling into other places that may set/read it. | 79c544238b2e2940b4342b8b5ec710c002c1a593 | ce94a6569ee97b12336d1402cdb5c0a306e602e8 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx
index 25ca878a1614..53dc8b5b04ff 100644
--- a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx
+++ b/packages/i... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx"
] | [
{
"comment": "This code reads `isExpended` from the URL query string, which appears to be a typo for `isExpanded` (used to control sidebar expansion). Renaming the parameter improves clarity and avoids propagating the misspelling into other places that may set/read it.",
"path": "packages/insomnia/src/route... | true | ||
Kong/insomnia | 9,996 | issue_to_patch | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | ## What
Final step in removing `nodeIntegration` from the Electron renderer. Flips `nodeIntegration: false` / `contextIsolation: true` on `mainWindow`, then traces and eliminates every remaining Node-dependent import path from the renderer bundle.
The hidden window that runs pre/post-request scripts keeps `nodeIntegr... | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 8577c7e1b9cc..52b895788433 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -47,15 +47,20 @@ jobs:
- name: Lint
run: npm run lint
- - name: Check renderer Node import baseline
- run: npm r... | [
".github/workflows/test.yml",
"package-lock.json",
"package.json",
"packages/insomnia-inso/esbuild.ts",
"packages/insomnia-inso/src/cli.ts",
"packages/insomnia-inso/src/commands/__mocks__/insomnia-testing.ts",
"packages/insomnia-scripting-environment/esbuild-runner.config.js",
"packages/insomnia-scrip... | [
{
"comment": "Importing from the `insomnia-testing` package root still pulls in the package entry (`src/index.ts`), which re-exports `runTests` and `generateToFile`. Those modules import Node builtins (`node:fs`, `node:path`, etc.), so this renderer `clientAction` will still try to load Node-only code when node... | diff --git a/packages/insomnia-smoke-test/tests/smoke/pre-request-script-features.test.ts b/packages/insomnia-smoke-test/tests/smoke/pre-request-script-features.test.ts
index 8131bb8ce56f..4d750cd1b72b 100644
--- a/packages/insomnia-smoke-test/tests/smoke/pre-request-script-features.test.ts
+++ b/packages/insomnia-smok... | true | |
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | Importing from the `insomnia-testing` package root still pulls in the package entry (`src/index.ts`), which re-exports `runTests` and `generateToFile`. Those modules import Node builtins (`node:fs`, `node:path`, etc.), so this renderer `clientAction` will still try to load Node-only code when nodeIntegration is disable... | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.test.$testId.run.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.test.$testId.run.tsx
index... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.test.$testId.run.tsx"
] | [
{
"comment": "Importing from the `insomnia-testing` package root still pulls in the package entry (`src/index.ts`), which re-exports `runTests` and `generateToFile`. Those modules import Node builtins (`node:fs`, `node:path`, etc.), so this renderer `clientAction` will still try to load Node-only code when node... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | Same issue as the single-test route: importing `generate` from `insomnia-testing` package root will still load re-exported Node-only modules (`runTests`, `generateToFile`) in the renderer module graph. Switch to a deep import of the Node-free `generate` implementation and import `TestResults` as a type from `run/entiti... | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.run-all-tests.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.run-all-tests.tsx
index 7e2f2... | [
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.run-all-tests.tsx"
] | [
{
"comment": "Same issue as the single-test route: importing `generate` from `insomnia-testing` package root will still load re-exported Node-only modules (`runTests`, `generateToFile`) in the renderer module graph. Switch to a deep import of the Node-free `generate` implementation and import `TestResults` as a... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | This line is mis-indented compared to the rest of the JSON file (2-space indentation). Keeping consistent formatting helps avoid noisy diffs and aligns with the surrounding style. | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/package.json b/packages/insomnia/package.json
index 3d397f365ec4..53ae7bee3153 100644
--- a/packages/insomnia/package.json
+++ b/packages/insomnia/package.json
@@ -20,9 +20,6 @@
"verify-bundle-plugins": "esr --cache ./scripts/verify-bundle-plugins.ts",
"install-x64-native-depend... | [
"packages/insomnia/package.json"
] | [
{
"comment": "This line is mis-indented compared to the rest of the JSON file (2-space indentation). Keeping consistent formatting helps avoid noisy diffs and aligns with the surrounding style.",
"path": "packages/insomnia/package.json",
"hunk": "@@ -20,10 +20,7 @@\n \"verify-bundle-plugins\": \"esr... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | This script entry is mis-indented compared to the rest of the JSON file (2-space indentation), which will cause unnecessary formatting churn. | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/package.json b/package.json
index 4eadfc49f85a..61660319017f 100644
--- a/package.json
+++ b/package.json
@@ -27,7 +27,6 @@
"scripts": {
"dev": "npm start -w insomnia",
"dev:autoRestart": "npm run start:autoRestart -w insomnia",
- "check:renderer-node-imports": "npm run check:renderer-node-... | [
"package.json"
] | [
{
"comment": "This script entry is mis-indented compared to the rest of the JSON file (2-space indentation), which will cause unnecessary formatting churn.",
"path": "package.json",
"hunk": "@@ -26,7 +26,6 @@\n \"scripts\": {\n \"dev\": \"npm start -w insomnia\",\n \"dev:autoRestart\": \"npm r... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | ## CodeQL / Clear text storage of sensitive information
This stores sensitive data returned by [an access to INSOMNIA_SECRET_KEY](1) as clear text.
This stores sensitive data returned by [a call to getInsomniaSecretKey](2) as clear text.
[Show more details](https://github.com/Kong/insomnia/security/code-scanning/538) | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/ui/auth-session-provider.client.ts b/packages/insomnia/src/ui/auth-session-provider.client.ts
index cf33fbfee5c7..6d0bc7026ebe 100644
--- a/packages/insomnia/src/ui/auth-session-provider.client.ts
+++ b/packages/insomnia/src/ui/auth-session-provider.client.ts
@@ -1,24 +1,23 @@
import... | [
"packages/insomnia/src/ui/auth-session-provider.client.ts"
] | [
{
"comment": "## CodeQL / Clear text storage of sensitive information\n\nThis stores sensitive data returned by [an access to INSOMNIA_SECRET_KEY](1) as clear text.\nThis stores sensitive data returned by [a call to getInsomniaSecretKey](2) as clear text.\n\n[Show more details](https://github.com/Kong/insomnia/... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | This looks like a snapshot test, but I didn't see any test use it. What is it used for? | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia-scripting-environment/src/autocomplete-snippets.json b/packages/insomnia-scripting-environment/src/autocomplete-snippets.json
new file mode 100644
index 000000000000..c84261c71dbd
--- /dev/null
+++ b/packages/insomnia-scripting-environment/src/autocomplete-snippets.json
@@ -0,0 +1,1137 @@... | [
"packages/insomnia-scripting-environment/src/autocomplete-snippets.json"
] | [
{
"comment": "This looks like a snapshot test, but I didn't see any test use it. What is it used for?",
"path": "packages/insomnia-scripting-environment/src/autocomplete-snippets.json",
"hunk": "@@ -0,0 +1,88 @@\n+[",
"resolving_sha": "6b3adaf59737f4c34b813ea3abd3a0cf0d121c38",
"resolving_diff":... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | This still bundle the crypt into the renderer. Why do we use different pattern here instead of using adapter? | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/account/session.ts b/packages/insomnia/src/account/session.ts
index 509cffa089e3..aafa473cfe8c 100644
--- a/packages/insomnia/src/account/session.ts
+++ b/packages/insomnia/src/account/session.ts
@@ -1,10 +1,11 @@
import { getEncryptionKeys, getUserProfile, logout as logoutAPI } from... | [
"packages/insomnia/src/account/session.ts"
] | [
{
"comment": "This still bundle the crypt into the renderer. Why do we use different pattern here instead of using adapter? ",
"path": "packages/insomnia/src/account/session.ts",
"hunk": "@@ -1,10 +1,21 @@\n import { getEncryptionKeys, getUserProfile, logout as logoutAPI } from 'insomnia-api';\n import ... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | This is not enabled. Is it missing? | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/main/window-utils.ts b/packages/insomnia/src/main/window-utils.ts
index e4e17a67dce2..6dd0945d9563 100644
--- a/packages/insomnia/src/main/window-utils.ts
+++ b/packages/insomnia/src/main/window-utils.ts
@@ -201,7 +201,7 @@ export function createWindow(): ElectronBrowserWindow {
... | [
"packages/insomnia/src/main/window-utils.ts"
] | [
{
"comment": "This is not enabled. Is it missing?",
"path": "packages/insomnia/src/main/window-utils.ts",
"hunk": "@@ -201,10 +199,9 @@ export function createWindow(): ElectronBrowserWindow {\n webPreferences: {\n preload: path.join(__dirname, 'entry.preload.min.js'),\n zoomFactor: getZo... | true | ||
Kong/insomnia | 9,996 | comment_to_fix | feat: disable nodeIntegration in renderer mainWindow, remove Node import check tooling | Why do we remove trackAnalyticsEvent here? | 3312a1ab977e451002562504f7fbfe69e49a32ef | 6b3adaf59737f4c34b813ea3abd3a0cf0d121c38 | diff --git a/packages/insomnia/src/main/window-utils.ts b/packages/insomnia/src/main/window-utils.ts
index e4e17a67dce2..6dd0945d9563 100644
--- a/packages/insomnia/src/main/window-utils.ts
+++ b/packages/insomnia/src/main/window-utils.ts
@@ -201,7 +201,7 @@ export function createWindow(): ElectronBrowserWindow {
... | [
"packages/insomnia/src/main/window-utils.ts"
] | [
{
"comment": "Why do we remove trackAnalyticsEvent here?",
"path": "packages/insomnia/src/main/window-utils.ts",
"hunk": "@@ -270,7 +267,6 @@ export function createWindow(): ElectronBrowserWindow {\n {\n label: `${MNEMONIC_SYM}Preferences`,\n click: () => {",
"resolving_sha": "... | true | ||
Kong/insomnia | 10,023 | issue_to_patch | fix(smoke): Fix smoke test | This PR resolves multiple smoke test bugs. | 8b5caa06a6dfe7c33520fc9628327b1018932fcc | 921bad0fc83dc5effcc16aae6be93538bcc7acbd | diff --git a/packages/insomnia/vite.config.ts b/packages/insomnia/vite.config.ts
index f4b57fc9458..e16a5141959 100644
--- a/packages/insomnia/vite.config.ts
+++ b/packages/insomnia/vite.config.ts
@@ -48,7 +48,7 @@ export default defineConfig(({ mode }) => {
optimizeDeps: {
exclude: ['@getinsomnia/node-libc... | [
"packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts",
"packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts",
"packages/insomnia-smoke-test/tests/smoke/konnect.test.ts",
"packages/insomnia-smoke-test/tests/smoke/mtls.test.ts",
"packages/insomnia-smoke-test/tests/smoke/... | [] | diff --git a/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts b/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts
index 8f08a5c4195..c6bf35cbbe7 100644
--- a/packages/insomnia-smoke-test/tests/smoke/environment-editor-interactions.test.ts
+++ b/packages/ins... | true | |
Kong/insomnia | 9,984 | issue_to_patch | fix: app crash if no writable stdout is available #9951 | On Linux, launching Insomnia from a .desktop entry (or any context without a writable stdout) could crash the main process in two ways:
1. Synchronous write failure — initializeLogging() was called after initElectronStorage(), meaning early log writes could throw before any EPIPE handler was in place. Reordering the... | f0687feef6380b31374fd76fa3ad296fa8ac0c68 | 0c1c22e7327a03a066fb04d742244bd3fbb3bc1b | diff --git a/packages/insomnia/src/entry.main.ts b/packages/insomnia/src/entry.main.ts
index 53594c8f8948..b4b6ca35317d 100644
--- a/packages/insomnia/src/entry.main.ts
+++ b/packages/insomnia/src/entry.main.ts
@@ -50,9 +50,9 @@ const dataPath =
path.join(app.getPath('userData'), '../', isDevelopment() ? 'insomnia-a... | [
"packages/insomnia-smoke-test/tests/smoke/stdout-epipe.test.ts",
"packages/insomnia/src/entry.main.ts",
"packages/insomnia/src/main/log.ts"
] | [] | diff --git a/packages/insomnia-smoke-test/tests/smoke/stdout-epipe.test.ts b/packages/insomnia-smoke-test/tests/smoke/stdout-epipe.test.ts
new file mode 100644
index 000000000000..fc4c11f42d96
--- /dev/null
+++ b/packages/insomnia-smoke-test/tests/smoke/stdout-epipe.test.ts
@@ -0,0 +1,37 @@
+import { expect } from '@pl... | true | |
Kong/insomnia | 10,018 | issue_to_patch | feat: add segment event for first request creation pane | **Analytics tracking improvements:**
* Added two new analytics events: `firstRequestPaneExampleClicked` and `firstRequestPaneCollectionChanged` to the `AnalyticsEvent` enum for more granular tracking of user actions in the first request pane.
* Updated the `RequestCreatedMetricsProperties` type to include `'first-r... | d61526496e7117c770d534f79a524a01a17b47e3 | b8ebe2e0a284507cb5fc72474fcd5fbc17d91711 | diff --git a/packages/insomnia-analytics/src/events.ts b/packages/insomnia-analytics/src/events.ts
index 10049c0e2a0f..9bc29f8cd28d 100644
--- a/packages/insomnia-analytics/src/events.ts
+++ b/packages/insomnia-analytics/src/events.ts
@@ -136,6 +136,8 @@ export enum AnalyticsEvent {
projectSwitched = 'project-switch... | [
"packages/insomnia-analytics/src/events.ts",
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId._index.tsx",
"packages/insomnia/src/ui/analytics.ts",
"packages/insomnia/src/ui/components/first-request-creation.tsx"
] | [
{
"comment": "AnalyticsEvent is imported directly from `insomnia-analytics/events` here, but the renderer codebase consistently imports it via `~/ui/analytics` (which also centralizes analytics helpers/re-exports). Aligning this import avoids having mixed import paths for the same enum (see e.g. `packages/insom... | true | ||
Kong/insomnia | 10,018 | comment_to_fix | feat: add segment event for first request creation pane | AnalyticsEvent is imported directly from `insomnia-analytics/events` here, but the renderer codebase consistently imports it via `~/ui/analytics` (which also centralizes analytics helpers/re-exports). Aligning this import avoids having mixed import paths for the same enum (see e.g. `packages/insomnia/src/routes/auth.lo... | d61526496e7117c770d534f79a524a01a17b47e3 | b8ebe2e0a284507cb5fc72474fcd5fbc17d91711 | diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx
index 0dbe126968c0..ed9fc7359407 100644
--- a/packages/insomnia/src/ui/components/first-request-creation.tsx
+++ b/packages/insomnia/src/ui/components/first-request-creation.tsx
@... | [
"packages/insomnia/src/ui/components/first-request-creation.tsx"
] | [
{
"comment": "AnalyticsEvent is imported directly from `insomnia-analytics/events` here, but the renderer codebase consistently imports it via `~/ui/analytics` (which also centralizes analytics helpers/re-exports). Aligning this import avoids having mixed import paths for the same enum (see e.g. `packages/insom... | true | ||
Kong/insomnia | 10,013 | issue_to_patch | fix: Buffer.from usage in the renderer | Substitutes a fair amount of `Buffer.from` invocations from the renderer with browser alternatives | f6ccdecd6ff000beeebbe2e341f4626616991768 | b6215805a9b161c48d4963da32e03aac2af3e7a0 | diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts
index d6d632854f76..1b8d07a6fb5a 100644
--- a/packages/insomnia/src/main/ipc/main.ts
+++ b/packages/insomnia/src/main/ipc/main.ts
@@ -203,8 +203,8 @@ export interface RendererToMainBridgeAPI {
installPlugin: typeof installPl... | [
"packages/insomnia/src/main/ipc/main.ts",
"packages/insomnia/src/main/multipart-buffer-to-array.ts",
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.request.$requestId.tsx",
"packages/insomnia/src/routes/organization.$organizationId.project.$projectId... | [
{
"comment": "`utf8ToBase64`/`bytesToBase64` build a binary string via `binary += ...` in a loop. For medium/large payloads this is O(n²) due to repeated string reallocations and is significantly slower than the previous `Buffer(...).toString('base64')` path (notably in the response viewer for images/audio). Yo... | diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx
index 0ec897c198d7..539d1da0354c 100644
--- a/packages/insomnia/src/routes/organization... | true | |
Kong/insomnia | 10,013 | comment_to_fix | fix: Buffer.from usage in the renderer | `utf8ToBase64`/`bytesToBase64` build a binary string via `binary += ...` in a loop. For medium/large payloads this is O(n²) due to repeated string reallocations and is significantly slower than the previous `Buffer(...).toString('base64')` path (notably in the response viewer for images/audio). You can avoid the loop e... | f6ccdecd6ff000beeebbe2e341f4626616991768 | b6215805a9b161c48d4963da32e03aac2af3e7a0 | diff --git a/packages/insomnia/src/utils/utf8-bytes.ts b/packages/insomnia/src/utils/utf8-bytes.ts
new file mode 100644
index 000000000000..b93cd68c0cdd
--- /dev/null
+++ b/packages/insomnia/src/utils/utf8-bytes.ts
@@ -0,0 +1,39 @@
+const BASE64_CHUNK_SIZE = 0x80_00;
+
+export function utf8BytesFromString(value: string... | [
"packages/insomnia/src/utils/utf8-bytes.ts"
] | [
{
"comment": "`utf8ToBase64`/`bytesToBase64` build a binary string via `binary += ...` in a loop. For medium/large payloads this is O(n²) due to repeated string reallocations and is significantly slower than the previous `Buffer(...).toString('base64')` path (notably in the response viewer for images/audio). Yo... | true | ||
Kong/insomnia | 10,005 | issue_to_patch | Only create necessary konnect proxy env vars | **Summary:**
Environment variables (`grpc_proxy_host`, `grpcs_proxy_host`) are now only created when the control plane's `proxy_urls` actually contains a matching protocol entry. Previously, all three proxy vars were always created (with empty string values) even if the control plane didn't utilize grpc/grpcs protoc... | abd54c2267a76f8f1779d51fd776c1b3bc7ea44f | 614a0acfcd15b7b4a97dfc091fa700fed0236b64 | diff --git a/packages/insomnia/src/konnect/sync.ts b/packages/insomnia/src/konnect/sync.ts
index 757b61863048..308fe7e21834 100644
--- a/packages/insomnia/src/konnect/sync.ts
+++ b/packages/insomnia/src/konnect/sync.ts
@@ -542,6 +542,7 @@ async function upsertProjectEnvVars(controlPlane: KonnectControlPlane, project:
... | [
"packages/insomnia/src/konnect/__tests__/sync.test.ts",
"packages/insomnia/src/konnect/sync.ts"
] | [] | diff --git a/packages/insomnia/src/konnect/__tests__/sync.test.ts b/packages/insomnia/src/konnect/__tests__/sync.test.ts
index 3ae1f98845fb..687430791f48 100644
--- a/packages/insomnia/src/konnect/__tests__/sync.test.ts
+++ b/packages/insomnia/src/konnect/__tests__/sync.test.ts
@@ -70,11 +70,7 @@ function makeRoute(ove... | true | |
Kong/insomnia | 10,004 | issue_to_patch | fix(ci): resolve PR versioning bug and missing backport E2E triggers | [INS-2632](https://konghq.atlassian.net/browse/INS-2632)
Fixes the version generation logic inside automated PR bodies and updates workflow triggers to ensure E2E tests run correctly whenever PRs are backported to a release branch.
[INS-2632]: https://konghq.atlassian.net/browse/INS-2632?atlOrigin=eyJpIjoiNWRkNTljNzY... | 13b60292d64608defaa92eaaf109f8f711fd6ca7 | 60781aab06936dbed7b3e6ea7b74fbea3a8b3b42 | diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml
index 517333012e8f..cafe2cbf41a1 100644
--- a/.github/workflows/release-build.yml
+++ b/.github/workflows/release-build.yml
@@ -364,15 +364,18 @@ jobs:
needs: build-and-upload-release-artifacts
runs-on: ubuntu-24.04
pe... | [
".github/workflows/release-build.yml",
".github/workflows/test-cli.yml",
".github/workflows/test-e2e.yml"
] | [
{
"comment": "The suggested `git log` command uses `--since/--until`, which accept dates, not refs/branches. Passing the release branch name here will not correctly limit the commit range and can confuse users trying to generate changelog entries.\n\nConsider using a revision range (`<last_release_tag>..branch`... | true | ||
Kong/insomnia | 10,014 | issue_to_patch | chore: add konnect smoke tests | Adds dedicated smoke tests to ensure the Konnect project sidecar renders when the Konnect feature is enabled. | 4c83a808b7e5e684833a8a5bb376c053f1cc8fe4 | 3554248222ff6051d41f819fd229c74a5daebe8e | diff --git a/packages/insomnia-smoke-test/playwright/test.ts b/packages/insomnia-smoke-test/playwright/test.ts
index 06e3bd5a1a07..d643d318b198 100644
--- a/packages/insomnia-smoke-test/playwright/test.ts
+++ b/packages/insomnia-smoke-test/playwright/test.ts
@@ -41,6 +41,7 @@ interface EnvOptions {
INSOMNIA_VAULT_KE... | [
"packages/insomnia-smoke-test/playwright/test.ts",
"packages/insomnia-smoke-test/server/insomnia-api.ts",
"packages/insomnia-smoke-test/tests/smoke/konnect.test.ts",
"packages/insomnia/src/ui/components/modals/konnect-settings-modal.tsx"
] | [
{
"comment": "This test mutates the global `organizationFeatures` state on the shared echo server, but the re-enable request is not guaranteed to run if the assertion fails (or if the test errors earlier). That can cascade into unrelated smoke tests failing due to `konnectSync` staying disabled. Wrap the featur... | diff --git a/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts
new file mode 100644
index 000000000000..172592bd35cb
--- /dev/null
+++ b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts
@@ -0,0 +1,40 @@
+import { expect } from '@playwright/test';... | true | |
Kong/insomnia | 10,014 | comment_to_fix | chore: add konnect smoke tests | This test mutates the global `organizationFeatures` state on the shared echo server, but the re-enable request is not guaranteed to run if the assertion fails (or if the test errors earlier). That can cascade into unrelated smoke tests failing due to `konnectSync` staying disabled. Wrap the feature toggle in a `try/fin... | 4c83a808b7e5e684833a8a5bb376c053f1cc8fe4 | 3554248222ff6051d41f819fd229c74a5daebe8e | diff --git a/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts
new file mode 100644
index 000000000000..172592bd35cb
--- /dev/null
+++ b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts
@@ -0,0 +1,40 @@
+import { expect } from '@playwright/test';... | [
"packages/insomnia-smoke-test/tests/smoke/konnect.test.ts"
] | [
{
"comment": "This test mutates the global `organizationFeatures` state on the shared echo server, but the re-enable request is not guaranteed to run if the assertion fails (or if the test errors earlier). That can cascade into unrelated smoke tests failing due to `konnectSync` staying disabled. Wrap the featur... | true | ||
Kong/insomnia | 10,012 | issue_to_patch | fix(e2e): remove pat seeding from flaky windows test | An attempt to clear up the flaky Windows e2e, since we only run the critical paths, we don't test the Konnect integration | efe930fe0a9655f0ac0a3851c091696a8dcff3b5 | a5696942d4bbca36f5fd8c0830e0088cfbd08ba7 | diff --git a/packages/insomnia-smoke-test/playwright/test.ts b/packages/insomnia-smoke-test/playwright/test.ts
index 4be9625908d2..06e3bd5a1a07 100644
--- a/packages/insomnia-smoke-test/playwright/test.ts
+++ b/packages/insomnia-smoke-test/playwright/test.ts
@@ -159,9 +159,6 @@ export const test = baseTest.extend<{
... | [
"packages/insomnia-smoke-test/playwright/test.ts"
] | [] | true | ||
Kong/insomnia | 9,964 | issue_to_patch | feat: add options for adjusting LLM URL option | Add ability to change parameters and use API key for self-hosted LLMs like from Ollama, or other cloud providers that have OpenAI compatible endpoints. | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts
index 71f521eb6604..a6ea08f0c933 100644
--- a/packages/insomnia/src/main/ipc/main.ts
+++ b/packages/insomnia/src/main/ipc/main.ts
@@ -797,14 +797,17 @@ export function registerMainHandlers() {
reject({ error: err.toStr... | [
"packages/insomnia-smoke-test/tests/smoke/preferences-interactions.test.ts",
"packages/insomnia/src/main/__tests__/llm-config-service.test.ts",
"packages/insomnia/src/main/ipc/main.ts",
"packages/insomnia/src/main/llm-config-service.ts",
"packages/insomnia/src/ui/components/settings/ai-settings.tsx",
"pac... | [
{
"comment": "`useEffect` currently depends on `hasChanges`, but it also sets `url`/`selectedModel`/etc. This causes the effect to re-run on user edits (since `hasChanges` changes), which can overwrite in-progress form input (especially when the active backend isn't `url`). The hydration effect should only re-r... | diff --git a/packages/insomnia-smoke-test/tests/smoke/preferences-interactions.test.ts b/packages/insomnia-smoke-test/tests/smoke/preferences-interactions.test.ts
index aa210671b323..e785226ed75d 100644
--- a/packages/insomnia-smoke-test/tests/smoke/preferences-interactions.test.ts
+++ b/packages/insomnia-smoke-test/te... | true | |
Kong/insomnia | 9,964 | comment_to_fix | feat: add options for adjusting LLM URL option | `useEffect` currently depends on `hasChanges`, but it also sets `url`/`selectedModel`/etc. This causes the effect to re-run on user edits (since `hasChanges` changes), which can overwrite in-progress form input (especially when the active backend isn't `url`). The hydration effect should only re-run when external confi... | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx
index 4e252e31f0d4..ca9777545dbf 100644
--- a/packages/insomnia/src/ui/components/settings/llms/url.tsx
+++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx
@@ -3,6 +3,17 @@ impo... | [
"packages/insomnia/src/ui/components/settings/llms/url.tsx"
] | [
{
"comment": "`useEffect` currently depends on `hasChanges`, but it also sets `url`/`selectedModel`/etc. This causes the effect to re-run on user edits (since `hasChanges` changes), which can overwrite in-progress form input (especially when the active backend isn't `url`). The hydration effect should only re-r... | true | ||
Kong/insomnia | 9,964 | comment_to_fix | feat: add options for adjusting LLM URL option | `min`/`max` props are currently derived from `urlModelParametersSchema.shape.temperature.min/max`, but those are Zod methods (functions), not numeric limits. This will stringify a function into the DOM attribute and the browser will ignore the constraint. | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx
index 4e252e31f0d4..ca9777545dbf 100644
--- a/packages/insomnia/src/ui/components/settings/llms/url.tsx
+++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx
@@ -3,6 +3,17 @@ impo... | [
"packages/insomnia/src/ui/components/settings/llms/url.tsx"
] | [
{
"comment": "`min`/`max` props are currently derived from `urlModelParametersSchema.shape.temperature.min/max`, but those are Zod methods (functions), not numeric limits. This will stringify a function into the DOM attribute and the browser will ignore the constraint.",
"path": "packages/insomnia/src/ui/co... | true | ||
Kong/insomnia | 9,964 | comment_to_fix | feat: add options for adjusting LLM URL option | Same issue as Temperature: `min`/`max` are taken from Zod methods and will not produce valid numeric HTML constraints. | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx
index 4e252e31f0d4..ca9777545dbf 100644
--- a/packages/insomnia/src/ui/components/settings/llms/url.tsx
+++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx
@@ -3,6 +3,17 @@ impo... | [
"packages/insomnia/src/ui/components/settings/llms/url.tsx"
] | [
{
"comment": "Same issue as Temperature: `min`/`max` are taken from Zod methods and will not produce valid numeric HTML constraints.",
"path": "packages/insomnia/src/ui/components/settings/llms/url.tsx",
"hunk": "@@ -179,6 +252,99 @@ export const Url = ({\n )}\n </Button>\n ... | true | ||
Kong/insomnia | 9,964 | comment_to_fix | feat: add options for adjusting LLM URL option | `getUrlActivateSettingsPayload` stores `apiKey` without trimming, while `getUrlLoadModelsSettingsPayload` trims it. This can persist accidental whitespace and make `hasChanges` behave unexpectedly across sessions. | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/ui/components/settings/llms/url-utils.ts b/packages/insomnia/src/ui/components/settings/llms/url-utils.ts
new file mode 100644
index 000000000000..61a4564df886
--- /dev/null
+++ b/packages/insomnia/src/ui/components/settings/llms/url-utils.ts
@@ -0,0 +1,86 @@
+import z from 'zod/v4';
... | [
"packages/insomnia/src/ui/components/settings/llms/url-utils.ts"
] | [
{
"comment": "`getUrlActivateSettingsPayload` stores `apiKey` without trimming, while `getUrlLoadModelsSettingsPayload` trims it. This can persist accidental whitespace and make `hasChanges` behave unexpectedly across sessions.",
"path": "packages/insomnia/src/ui/components/settings/llms/url-utils.ts",
... | true | ||
Kong/insomnia | 9,964 | comment_to_fix | feat: add options for adjusting LLM URL option | `mergedModelConfig` currently special-cases the `url` backend by ignoring `modelConfigFromSamplingRequest` (maxTokens/temperature). This makes the MCP sampling form's per-request settings ineffective when using the URL backend and differs from the behavior of other backends. | 26020af10903badd95ddbb78febc9740991601a4 | 479e8d16dfda209ce8dd54f8ffc30b9d762b0694 | diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts
index 71f521eb6604..a6ea08f0c933 100644
--- a/packages/insomnia/src/main/ipc/main.ts
+++ b/packages/insomnia/src/main/ipc/main.ts
@@ -797,14 +797,17 @@ export function registerMainHandlers() {
reject({ error: err.toStr... | [
"packages/insomnia/src/main/ipc/main.ts"
] | [
{
"comment": "`mergedModelConfig` currently special-cases the `url` backend by ignoring `modelConfigFromSamplingRequest` (maxTokens/temperature). This makes the MCP sampling form's per-request settings ineffective when using the URL backend and differs from the behavior of other backends.",
"path": "package... | true | ||
LAION-AI/Open-Assistant | 2,867 | issue_to_patch | Feature/add rm mode to dataset entry | works towards #2819 | 28ae5efb0bb519487e7973c58b13bce83f65ebaa | dc85d741016e06d851afba79e3b73557cf7d0e5c | diff --git a/model/model_training/custom_datasets/formatting.py b/model/model_training/custom_datasets/formatting.py
index 91e25b513e..b72834d96b 100644
--- a/model/model_training/custom_datasets/formatting.py
+++ b/model/model_training/custom_datasets/formatting.py
@@ -64,36 +64,55 @@ def system_tag(self, eos_token: s... | [
"model/model_training/custom_datasets/formatting.py",
"model/model_training/custom_datasets/ranking_collator.py",
"model/model_training/tests/test_ranking_collator.py"
] | [] | diff --git a/model/model_training/tests/test_ranking_collator.py b/model/model_training/tests/test_ranking_collator.py
index f5e7962d75..e4e47ebca1 100644
--- a/model/model_training/tests/test_ranking_collator.py
+++ b/model/model_training/tests/test_ranking_collator.py
@@ -1,10 +1,158 @@
from argparse import Namespac... | true | |
LAION-AI/Open-Assistant | 3,743 | issue_to_patch | add note about oasst2 being available | e1769c102f1597cc0b53a8b915f858239d197aeb | 7d64ceadf2246254506f9cccb83f18777a988dd1 | diff --git a/README.md b/README.md
index 054fb65ef2..f8ed80496f 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@
</h1>
<blockquote>
-<p>:memo: <strong>NOTE</strong>: OpenAssistant is completed, and the project is now finished. Thank you to everyone who contributed! Check out our <a href="https://projects.laio... | [
"README.md",
"docs/blog/2023-10-25-open-assistant-is-completed/index.mdx"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,393 | issue_to_patch | Write a script to sync translation in EN with other locales
The script should accept an option locales params, example signature in TS
```ts
type Params = {
locales?: string[]
}
``` | https://github.com/LAION-AI/Open-Assistant/pull/3733 | ## Description
This PR add the `inlang.config.js` and `@inlang/cli` to Open-Assistant to solve the issue #3077
With these changes, translators can manage translations in a no-code web editor and useful linting rules and machine translations can be used within the editor or via the `@inlang/cli`.
I added a bad... | d381aa1fb9f9911aed16e45d37643644793cd413 | 8d4bad8ed5ace14c9d5ea246d4cc9764debcf030 | diff --git a/.vscode/extensions.json b/.vscode/extensions.json
index cf91a68b2d..ac3b940a0a 100644
--- a/.vscode/extensions.json
+++ b/.vscode/extensions.json
@@ -2,6 +2,7 @@
"recommendations": [
"ms-vscode-remote.remote-containers",
"ms-vscode-remote.vscode-remote-extensionpack",
- "esbenp.prettier-vsc... | [
".vscode/extensions.json",
"CONTRIBUTING.md",
"inlang.config.js",
"website/package-lock.json",
"website/package.json"
] | [] | true | |
LAION-AI/Open-Assistant | 3,730 | issue_to_patch | Update docs for current project status. | This PR updates the FAQ, which is currently very out of date, to the current status of the project. It also adds a notice to the introduction page in the docs that the project has concluded. Feel free to make any changes if it isn't worded how you would like.
| 7558fa8ed3f5a63df9cdf845cbdd0c86c995b51b | 786798a7f4deba0a81cdfc94a1fb98773e9cfb01 | diff --git a/docs/docs/faq.md b/docs/docs/faq.md
index 91c277cb66..8566b9dfe2 100644
--- a/docs/docs/faq.md
+++ b/docs/docs/faq.md
@@ -15,12 +15,12 @@ In this page, there are some of the most frequently asked questions.
</summary>
-We have released candidate supervised finetuning (SFT) models using both Pythia
-an... | [
"docs/docs/faq.md",
"docs/docs/intro.md"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,724 | issue_to_patch | add note to readme about project being completed | @yk @andreaskoepf small one to just add note about project being completed to the top of readme | 5e9ba5f02c00149b58496fa2915ccffc0e664cfd | a42076a3f0549745fcbf968c701afa68433c65d7 | diff --git a/README.md b/README.md
index b0bb4562d6..054fb65ef2 100644
--- a/README.md
+++ b/README.md
@@ -3,6 +3,10 @@
<img width="auto" height="50px" src="https://github.com/LAION-AI/Open-Assistant/blob/main/assets/logo_crop.png"/>
</h1>
+<blockquote>
+<p>:memo: <strong>NOTE</strong>: OpenAssistant is completed... | [
"README.md"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,719 | issue_to_patch | add blog of video about project being completed | 709bb99d3e03dc62abc11892500352cb2da31a29 | 26e8d5ecfb705934f83af8d09be41be77904c906 | diff --git a/docs/blog/2023-10-25-open-assistant-is-completed/index.mdx b/docs/blog/2023-10-25-open-assistant-is-completed/index.mdx
new file mode 100644
index 0000000000..175c04e784
--- /dev/null
+++ b/docs/blog/2023-10-25-open-assistant-is-completed/index.mdx
@@ -0,0 +1,17 @@
+---
+title: OpenAssistant is Completed!
... | [
"docs/blog/2023-10-25-open-assistant-is-completed/index.mdx"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,614 | issue_to_patch | Consuming much more gpu memory than expected using model_training and model_eval
Previously, I have trained a pythia-6.9b using code here: [dolly](https://github.com/databrickslabs/dolly)
I can train with the below setting on 4xA100(80G) without GPU OOM:
```yaml
per-device-train-batch-size: 8
per-device-eval-batch... | [Fix] Consume much more gpt memory running eval_rm | Fix #3611.
Still debugging or model_training. | 7a68b591a12fa900ac58601ff5b77519c97aad97 | 01b01d013a122d5629ee69afcd385b6e22dce5db | diff --git a/model/model_eval/eval_rm.py b/model/model_eval/eval_rm.py
index c18df94009..a380b76d8c 100644
--- a/model/model_eval/eval_rm.py
+++ b/model/model_eval/eval_rm.py
@@ -7,6 +7,7 @@
from model_training.custom_datasets.ranking_collator import RankingDataCollator
from model_training.metrics import RewardMetric... | [
"model/model_eval/eval_rm.py",
"model/model_training/custom_datasets/__init__.py",
"model/model_training/custom_datasets/qa_datasets.py"
] | [] | true | |
LAION-AI/Open-Assistant | 3,649 | issue_to_patch | Dev zhanglu | Check whether the size of the embedding layer has been resized, rather than checking if the length of the tokenizer is equal to the size of the embedding layer.
This is because the embedding layer of the model may be resized and padded to a multiple of 16, but the tokenizer may not be padded, which will cause the fre... | c4c9f372ca1b9ff0b8999057c71a6fd2ed22b462 | c1de84ae6d599ed82ef91e69f093b81d1895139c | diff --git a/model/model_training/utils/utils.py b/model/model_training/utils/utils.py
index 677da36a22..0397822d3c 100644
--- a/model/model_training/utils/utils.py
+++ b/model/model_training/utils/utils.py
@@ -330,15 +330,16 @@ def get_model(conf, tokenizer, pad_vocab_size_to_multiple_of=16, check_freeze_la
... | [
"model/model_training/utils/utils.py",
"model/pyproject.toml"
] | [
{
"comment": "I am unsure why this change is shown, this was already merged in https://github.com/LAION-AI/Open-Assistant/pull/3643.",
"path": "model/pyproject.toml",
"hunk": "@@ -42,7 +42,7 @@ tests = [\n ]\n \n [tool.setuptools]\n-py-modules = [\"model_training\"]\n+packages = [\"model_training\"]",
... | true | ||
LAION-AI/Open-Assistant | 3,674 | issue_to_patch | Fix german leaderboard translation | - fix order to match leaderboard.json of other locales
- fix template: `{{Bedarf, Zahl, Ganzzahl}}` -> `{{level,number,integer}}` | d613c81e04ac8759de5e031464cac9e506086124 | 8cbfcecc32c37cd5344e48aa64eb144b48fdc6c8 | diff --git a/website/public/locales/de/leaderboard.json b/website/public/locales/de/leaderboard.json
index 84e990df22..75cb1141b4 100644
--- a/website/public/locales/de/leaderboard.json
+++ b/website/public/locales/de/leaderboard.json
@@ -4,36 +4,36 @@
"daily": "Täglich",
"day": "Day",
"good_rankings": "Gute R... | [
"website/public/locales/de/leaderboard.json"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,673 | issue_to_patch | Fixes for worker prompt truncation in ChatML case | d613c81e04ac8759de5e031464cac9e506086124 | 5d0321a343e5e8ce8f1063824cf1f315ccc350c5 | diff --git a/inference/worker/__main__.py b/inference/worker/__main__.py
index 569e340276..cb7d3089a5 100644
--- a/inference/worker/__main__.py
+++ b/inference/worker/__main__.py
@@ -34,7 +34,7 @@ def main():
tokenizer = None
else:
tokenizer: transformers.PreTrainedTokenizer = transformers.AutoTo... | [
"inference/worker/__main__.py",
"inference/worker/basic_hf_server.py",
"inference/worker/utils.py",
"oasst-shared/oasst_shared/model_configs.py"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,668 | issue_to_patch | Support ChatML prompt format in worker | 8c0e1a31bea1542dd39716b1dbbecd46785d9d23 | 8e5d1f948cb7a741e3815904e73bc0d03962aec0 | diff --git a/inference/worker/chat_chain.py b/inference/worker/chat_chain.py
index 70c732bbb3..78dadcb126 100644
--- a/inference/worker/chat_chain.py
+++ b/inference/worker/chat_chain.py
@@ -14,8 +14,6 @@
PREFIX,
SUFFIX,
THOUGHT_SEQ,
- V2_ASST_PREFIX,
- V2_PROMPTER_PREFIX,
)
from chat_chain_utils... | [
"inference/worker/chat_chain.py",
"inference/worker/chat_chain_prompts.py",
"inference/worker/chat_chain_utils.py",
"inference/worker/settings.py",
"inference/worker/utils.py",
"inference/worker/work.py",
"oasst-shared/oasst_shared/model_configs.py"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,662 | issue_to_patch | More translations into german | cf166c4c1307e1e5d1cf316565bf935d0019a609 | c357372e25eada9f70a9bc2af2c7bb18b79162dc | diff --git a/website/public/locales/de/chat.json b/website/public/locales/de/chat.json
index b99661a80a..ddf3341b64 100644
--- a/website/public/locales/de/chat.json
+++ b/website/public/locales/de/chat.json
@@ -6,6 +6,7 @@
"delete_chat": "Chat löschen",
"delete_confirmation": "Sind Sie sicher, dass Sie den Chat l... | [
"website/public/locales/de/chat.json",
"website/public/locales/de/common.json",
"website/public/locales/de/index.json",
"website/public/locales/de/leaderboard.json",
"website/public/locales/de/message.json",
"website/public/locales/de/tasks.json"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,660 | issue_to_patch | Add dataset adapter for loading dolly15k_multilingual dataset | Dataset: [argilla/databricks-dolly-15k-curated-multilingual](https://huggingface.co/datasets/argilla/databricks-dolly-15k-curated-multilingual)
| 2cc90ffbeb6e2a83b5c994f1e0cd5742eb9d4e45 | c32b9f1c92749c72b9cde6f05e0f82b93dcb079e | diff --git a/model/model_training/custom_datasets/__init__.py b/model/model_training/custom_datasets/__init__.py
index 870f323484..27841c779a 100644
--- a/model/model_training/custom_datasets/__init__.py
+++ b/model/model_training/custom_datasets/__init__.py
@@ -18,6 +18,7 @@
SODA,
AlpacaGpt4,
Databricks... | [
"model/model_training/custom_datasets/__init__.py",
"model/model_training/custom_datasets/qa_datasets.py",
"model/pretokenizer/pretokenize.py"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,658 | issue_to_patch | fix: unsupported message typo | f182486feec9e533aa0062d40b6bcb172809389b | c406c48bf8552de27f4a6da2bd076e890d8592b1 | diff --git a/model/model_training/tools/export_model.py b/model/model_training/tools/export_model.py
index 8ce456085e..b0959f862d 100644
--- a/model/model_training/tools/export_model.py
+++ b/model/model_training/tools/export_model.py
@@ -41,7 +41,7 @@ def main():
elif args.dtype in ("bfloat16", "bf16"):
... | [
"model/model_training/tools/export_model.py"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,656 | issue_to_patch | Add megacode3 dataset | Adds [rombodawg/LosslessMegaCodeTrainingV3_2.2m_Evol](https://huggingface.co/datasets/rombodawg/LosslessMegaCodeTrainingV3_2.2m_Evol/tree/main) and separates the configuration from the `InstructionDataset` class. | f182486feec9e533aa0062d40b6bcb172809389b | b0c5db5a92afb47f419417c05e9b9846c8253524 | diff --git a/model/model_training/custom_datasets/__init__.py b/model/model_training/custom_datasets/__init__.py
index 4c66d06008..870f323484 100644
--- a/model/model_training/custom_datasets/__init__.py
+++ b/model/model_training/custom_datasets/__init__.py
@@ -116,7 +116,8 @@ def get_one_dataset(
eval = ... | [
"model/model_training/custom_datasets/__init__.py",
"model/model_training/custom_datasets/instruction.py",
"model/pretokenizer/configs/pretokenize.yaml"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,654 | issue_to_patch | Add pretokenizer utility | The pretokenizer utility (`pretokenizer/pretokenize.py`) allows to tokenize datamixes in advance for use with the [epfLLM/Megatron-LLM/](https://github.com/epfLLM/Megatron-LLM) trainer.
The datamix configuration can be defined in a yaml file similarly to the classic training configurations of trainer_sft.py. For loa... | f747529777788b7d7fff3d6a4e85f27c4954350c | c60ef8a97d375d7f50656808fc0f1d4325e4bcf2 | diff --git a/model/pretokenizer/README.md b/model/pretokenizer/README.md
new file mode 100644
index 0000000000..6c89e8da51
--- /dev/null
+++ b/model/pretokenizer/README.md
@@ -0,0 +1,48 @@
+# OA Pretokenizer Utility
+
+The pretokenizer allows to tokenize datasets before training with the
+[epfLLM/Megatron-LLM](https://... | [
"model/pretokenizer/README.md",
"model/pretokenizer/configs/pretokenize.yaml",
"model/pretokenizer/create_hf_tokenizer_config.py",
"model/pretokenizer/indexed_dataset.py",
"model/pretokenizer/pretokenize.py",
"model/pretokenizer/requirements.txt",
"model/pretokenizer/tokenizer.py"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,650 | issue_to_patch | Add loader for megacode2 (rombodawg/LosslessMegaCodeTrainingV2_1m_Evol_Uncensored) | c4c9f372ca1b9ff0b8999057c71a6fd2ed22b462 | b9706bac4b903ccb154db410472ca071f408b768 | diff --git a/model/model_training/custom_datasets/instruction.py b/model/model_training/custom_datasets/instruction.py
index e932d26259..384a299c71 100644
--- a/model/model_training/custom_datasets/instruction.py
+++ b/model/model_training/custom_datasets/instruction.py
@@ -29,6 +29,7 @@
"tell_a_joke": "mikegarts/... | [
"model/model_training/custom_datasets/instruction.py"
] | [] | true | |||
LAION-AI/Open-Assistant | 3,651 | issue_to_patch | Make sure eval subset is sampled without replacing | Explicitly specify `replace=False` for [numpy.random.choice](https://numpy.org/doc/stable/reference/random/generated/numpy.random.choice.html) (it was missing and default is `replace=True` which could lead to duplicate examples in the evaluation set). | c4c9f372ca1b9ff0b8999057c71a6fd2ed22b462 | 0abeb5bfaaec2823fe1d567ab56babcf731f4885 | diff --git a/model/model_training/custom_datasets/__init__.py b/model/model_training/custom_datasets/__init__.py
index 50f0a1bf6e..4c66d06008 100644
--- a/model/model_training/custom_datasets/__init__.py
+++ b/model/model_training/custom_datasets/__init__.py
@@ -196,7 +196,7 @@ def get_one_dataset(
train, eval... | [
"model/model_training/custom_datasets/__init__.py"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,646 | issue_to_patch | Long context datasets | ## What
Added support for RAG based dataloaders
Currently supports
- shahules786/Multi-chapter-summaries
| a2a7448e0571187ec49e97eaf2e69d17dc883ee3 | 0ceb0f3d7039aeee6ac5b423de4441ded3318a7e | diff --git a/model/model_training/custom_datasets/__init__.py b/model/model_training/custom_datasets/__init__.py
index 29eb24f3b8..50f0a1bf6e 100644
--- a/model/model_training/custom_datasets/__init__.py
+++ b/model/model_training/custom_datasets/__init__.py
@@ -5,7 +5,12 @@
import numpy as np
from model_training.c... | [
"model/model_training/custom_datasets/__init__.py",
"model/model_training/custom_datasets/instruction.py"
] | [] | true | ||
LAION-AI/Open-Assistant | 3,632 | issue_to_patch | Web app manifest for assistant website
I'd like to suggest that you add a web app manifest to the assistant website.
https://developer.mozilla.org/en-US/docs/Web/Manifest
https://web.dev/add-manifest/
With the correct settings (`"display": "standalone"`), this will enable users (using Chrome, Edge or Safari) t... | Web App Manifest - Save as desktop or mobile app | From issue https://github.com/LAION-AI/Open-Assistant/issues/3548
✅ Branched from latest
✅ Pre-commit changes added
This commit adds a manifest file that allows users to save the website on desktop or mobile, see [this documentation](https://developer.mozilla.org/en-US/docs/Web/Manifest).
It makes an icon that ca... | 0d4adb5f1ad6c38a828370414a584dd485165dce | 5ed13e2a770097f0ddba26aafa4339022bf35e82 | diff --git a/website/public/images/logos/logo_192x192.png b/website/public/images/logos/logo_192x192.png
new file mode 100644
index 0000000000..8b09a82728
Binary files /dev/null and b/website/public/images/logos/logo_192x192.png differ
diff --git a/website/public/manifest.json b/website/public/manifest.json
new file mo... | [
"website/public/images/logos/logo_192x192.png",
"website/public/manifest.json",
"website/src/pages/_document.tsx"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.