repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
LibreHardwareMonitor/LibreHardwareMonitor
2,360
issue_to_patch
Prepare for Avalonia app - rename LHM UI project
Prepare for Avalonia app - rename LHM UI project.
91b01784cae8374924280d26ea5f1eced318a16a
f80307473f45d30b33f4eca93994dd0f0dbbabf9
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index de15b70e8..75f87480d 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -34,22 +34,22 @@ jobs: } | Set-Content Directory.Build.props - name: Restore application packages - run: dotnet r...
[ ".github/workflows/master.yml", ".github/workflows/pull requests.yml", "LibreHardwareMonitor.Windows.Forms/LibreHardwareMonitor.Windows.Forms.csproj", "LibreHardwareMonitor.Windows.Forms/Program.cs", "LibreHardwareMonitor.Windows.Forms/Resources/PawnIO_setup.exe", "LibreHardwareMonitor.Windows.Forms/Resou...
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,357
issue_to_patch
Arrow Lake Intel Core I7 265U Temperature Arrow Lake Intel Core I7 265U Temperature not detected. Could you add support for CPU model 0xB5? CPUID Processor 0 Processor Vendor: Intel Processor Brand: Intel(R) Core(TM) Ultra 7 265U Family: 0x6 Model: 0xB5 Stepping: 0x0 thanks
Add support for Intel ArrowLake-U
The model of `Intel Core Ultra 7 265U` and `Intel Core Ultra 5 235U` is `0xB5`. Fixes #2221.
de31b7bf5df5af545792cbd9959580827bc19b1b
3e8fe2ad380af9d58f8e4f1c6e29df88484c561e
diff --git a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs index 2545c56a4..972b6cfdb 100644 --- a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs @@ -232,6 +232,7 @@ public IntelCpu(int processorIndex, CpuId[]...
[ "LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,373
issue_to_patch
Bump System.IO.Ports from 10.0.7 to 10.0.8
Updated [System.IO.Ports](https://github.com/dotnet/dotnet) from 10.0.7 to 10.0.8. <details> <summary>Release notes</summary> _Sourced from [System.IO.Ports's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/d...
f2d72f5b5c039fcc77b14c194b0a75aec414713d
a6d80d02564df71e2ec3e0a02ed6d673f0d41aca
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 0d2c2882b..5d9a6545e 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -77,7 +77,7 @@ <PackageReferenc...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,371
issue_to_patch
Bump the all-dependencies group with 4 updates
Updated [System.Management](https://github.com/dotnet/dotnet) from 10.0.7 to 10.0.8. <details> <summary>Release notes</summary> _Sourced from [System.Management's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.c...
54b6360ce906296a05a81d1960a772d2be7bf0e1
23729300b29686ea6a1a1fc16cd6d4382613d2a0
diff --git a/Aga.Controls/Aga.Controls.csproj b/Aga.Controls/Aga.Controls.csproj index 7a88bb60e..1c4a03555 100644 --- a/Aga.Controls/Aga.Controls.csproj +++ b/Aga.Controls/Aga.Controls.csproj @@ -123,6 +123,6 @@ <Compile Remove="Tree\NativeMethods.cs" /> </ItemGroup> <ItemGroup> - <PackageReference Inclu...
[ "Aga.Controls/Aga.Controls.csproj", "LibreHardwareMonitor/LibreHardwareMonitor.csproj", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,346
issue_to_patch
fix: Improve mouse wheel handling for high-resolution devices
This pull request improves the scrolling behavior in `TreeViewAdv` to better support high-resolution precision trackpads. Previously, only classic scroll wheels (which send multiples of 120 for `e.Delta`) were handled correctly, causing precision devices (which send smaller deltas) to sometimes not scroll at all. The n...
d7473cc8cc21a23994b27604a0f3fd8db265a76d
a9604c6af55e69e17d3a85150593c85590b60f1a
diff --git a/Aga.Controls/Tree/TreeViewAdv.Input.cs b/Aga.Controls/Tree/TreeViewAdv.Input.cs index 57d1ecfbc..466a233dc 100644 --- a/Aga.Controls/Tree/TreeViewAdv.Input.cs +++ b/Aga.Controls/Tree/TreeViewAdv.Input.cs @@ -116,15 +116,25 @@ protected override void OnMouseWheel(MouseEventArgs e) _search.EndSearch(); ...
[ "Aga.Controls/Tree/TreeViewAdv.Input.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,358
issue_to_patch
Update DiskInfoToolkit.
Update DiskInfoToolkit. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/2.1.0
3fb768295a4792dbbbf2bf1763b1fe9945e7461a
a08b04eda75ff21abd166f1a2ec35e24c5b1bc73
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index f90fbaaa7..66f901e0c 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -81,7 +81,7 @@ </ItemGroup> ...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,356
issue_to_patch
Add support for Asrock B550M Pro4
de31b7bf5df5af545792cbd9959580827bc19b1b
a81160cf8d4947cb1c3afd91f9eae57e8f1cf01d
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs index c49be2543..537302653 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs @@ -141...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Model.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,351
issue_to_patch
Fix PTL voltage
4f58c459cadca0b3eb3a105ea74740d1ab597eba
194b5b209762cebbd3203aa5a8a9a31beb1f7276
diff --git a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs index 489704dd2..2545c56a4 100644 --- a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs @@ -712,17 +712,40 @@ public override void Update() ...
[ "LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,332
issue_to_patch
Intel Panther lake support wanted ( Ultra5 358h ) I am currently using a 358h model based on Panther Lake. When using librehardware, it only displays CPU load information, without detailed information such as IO, voltage, and pkg power consumption. I request support for adding these features. Thank you. <img width="7...
Add support for Intel Panther Lake microarchitecture
Closes #2286
d7473cc8cc21a23994b27604a0f3fd8db265a76d
591b7a85f7ffe64c880d63125f1db699a03628f4
diff --git a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs index d7e13db53..489704dd2 100644 --- a/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs @@ -242,15 +242,22 @@ public IntelCpu(int processorIndex, CpuId...
[ "LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,340
issue_to_patch
Bump System.Resources.Extensions from 10.0.6 to 10.0.7
Updated [System.Resources.Extensions](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7. <details> <summary>Release notes</summary> _Sourced from [System.Resources.Extensions's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare vi...
aa0781a7ca80add5995accf47d5484d7391058e7
748846f3bc6a16792e0a00cb5ff471d2ef0f5855
diff --git a/Aga.Controls/Aga.Controls.csproj b/Aga.Controls/Aga.Controls.csproj index 52ae73776..7a88bb60e 100644 --- a/Aga.Controls/Aga.Controls.csproj +++ b/Aga.Controls/Aga.Controls.csproj @@ -123,6 +123,6 @@ <Compile Remove="Tree\NativeMethods.cs" /> </ItemGroup> <ItemGroup> - <PackageReference Inclu...
[ "Aga.Controls/Aga.Controls.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,337
issue_to_patch
Bump System.Management from 10.0.6 to 10.0.7
Updated [System.Management](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7. <details> <summary>Release notes</summary> _Sourced from [System.Management's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.c...
b0d4e079d79828fe42ba538a2a4a3c44e811102b
115cf4fdea3f8a8a1d0f6854b40bab38de3e59ba
diff --git a/LibreHardwareMonitor/LibreHardwareMonitor.csproj b/LibreHardwareMonitor/LibreHardwareMonitor.csproj index c16c6367b..9bb333fd4 100644 --- a/LibreHardwareMonitor/LibreHardwareMonitor.csproj +++ b/LibreHardwareMonitor/LibreHardwareMonitor.csproj @@ -29,7 +29,7 @@ <ItemGroup> <PackageReference Include...
[ "LibreHardwareMonitor/LibreHardwareMonitor.csproj", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,339
issue_to_patch
Bump System.Threading.AccessControl from 10.0.6 to 10.0.7
Updated [System.Threading.AccessControl](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7. <details> <summary>Release notes</summary> _Sourced from [System.Threading.AccessControl's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [comp...
d7473cc8cc21a23994b27604a0f3fd8db265a76d
4d93b318fd561fe36b31b1d617a1b370fa04dc26
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index a51eec094..1c8528668 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -90,7 +90,7 @@ <PackageReferenc...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,341
issue_to_patch
Bump System.Text.Json from 10.0.6 to 10.0.7
Updated [System.Text.Json](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7. <details> <summary>Release notes</summary> _Sourced from [System.Text.Json's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com...
d7473cc8cc21a23994b27604a0f3fd8db265a76d
357ab73b600af08f8498e9b24c63ebd07a9f8733
diff --git a/LibreHardwareMonitor/LibreHardwareMonitor.csproj b/LibreHardwareMonitor/LibreHardwareMonitor.csproj index c16c6367b..95aca1c80 100644 --- a/LibreHardwareMonitor/LibreHardwareMonitor.csproj +++ b/LibreHardwareMonitor/LibreHardwareMonitor.csproj @@ -31,7 +31,7 @@ <PackageReference Include="OxyPlot.Windo...
[ "LibreHardwareMonitor/LibreHardwareMonitor.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,336
issue_to_patch
Bump System.IO.Ports from 10.0.6 to 10.0.7
Updated [System.IO.Ports](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7. <details> <summary>Release notes</summary> _Sourced from [System.IO.Ports's releases](https://github.com/dotnet/dotnet/releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/d...
d7473cc8cc21a23994b27604a0f3fd8db265a76d
aa3aa5f63a5e87019509ddc25f8b967abe473a6c
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index a51eec094..d0e7a9500 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -77,7 +77,7 @@ <PackageReferenc...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,350
issue_to_patch
Update DiskInfoToolkit.
Update DiskInfoToolkit. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/2.0.4
d7473cc8cc21a23994b27604a0f3fd8db265a76d
03cebf8718537cae127b4adaab1cc03e43c7d881
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index a51eec094..9b50792d2 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -81,7 +81,7 @@ </ItemGroup> ...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,306
issue_to_patch
Update workflow versions.
Update workflow versions.
47b46c7bf458fd9a8afe56fbff07ba0091a59141
571a2e122d6f381a4840a501388c3ddef87856b6
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 71ccf172b..de15b70e8 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -8,16 +8,16 @@ jobs: build: runs-on: windows-2022 steps: - - uses: actions/checkout@v4 - - uses: actions/setup-dotnet...
[ ".github/workflows/master.yml", ".github/workflows/pull requests.yml" ]
[ { "comment": "Let's pin all to a hash:\nhttps://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions", "path": ".github/workflows/master.yml", "hunk": "@@ -8,16 +8,16 @@ jobs:\n build:\n runs-on: windows-2022\n steps:\n- - uses: actions/checkout@v4\n+ - ...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,306
comment_to_fix
Update workflow versions.
Let's pin all to a hash: https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions
47b46c7bf458fd9a8afe56fbff07ba0091a59141
571a2e122d6f381a4840a501388c3ddef87856b6
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 71ccf172b..de15b70e8 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -8,16 +8,16 @@ jobs: build: runs-on: windows-2022 steps: - - uses: actions/checkout@v4 - - uses: actions/setup-dotnet...
[ ".github/workflows/master.yml" ]
[ { "comment": "Let's pin all to a hash:\nhttps://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions", "path": ".github/workflows/master.yml", "hunk": "@@ -8,16 +8,16 @@ jobs:\n build:\n runs-on: windows-2022\n steps:\n- - uses: actions/checkout@v4\n+ - ...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,328
issue_to_patch
Update DiskInfoToolkit
Update DiskInfoToolkit. Add trace to report. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/2.0.3
035a878e2015870b660f1d3e28ceaa95a05b0349
8500374ce2f242c55348119bede3c86086422c88
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index 666acb7a5..e390b5e66 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -7,12 +7,12 @@ using Sy...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,310
issue_to_patch
NVIDIA GPU: reserve load index 3 for GPU Memory, remap other loads
Encountered this problem of `GPU Memory` display in Gadget not being saved when the software closed. Saw several issues here but none being addressed yet: https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/issues/1545 https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/issues/2178 I tried to ed...
47b46c7bf458fd9a8afe56fbff07ba0091a59141
d094862ec8fefed11b2c19b31b9f75fb6bb6cb6a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs index d281a09ea..9cb56c001 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs @@ -246,6 +246,8 @@ public NvidiaGpu(int adapterIndex, NvAp...
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs" ]
[ { "comment": "We should be able to just use `loads.Count` everywhere to make this much easier. It's not a problem that GPU Memory load is a different index.", "path": "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs", "hunk": "@@ -260,7 +260,7 @@ public NvidiaGpu(int adapterIndex, NvApi.NvPhysicalGpuH...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,324
issue_to_patch
Bump Microsoft.Windows.CsWin32 from 0.3.269 to 0.3.275
Updated [Microsoft.Windows.CsWin32](https://github.com/microsoft/CsWin32) from 0.3.269 to 0.3.275. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Windows.CsWin32's releases](https://github.com/microsoft/CsWin32/releases)._ ## 0.3.275 ## Changes: * #​1678: Fix cross-winmd STATUS_SUCCESS lookup...
f8f9712974accf7d7477b2c85182136d9e901cf3
1de26132575e81a20e54b027a30ea44bea083385
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 7d3b9e397..0bd2d43dd 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -83,7 +83,7 @@ <ItemGroup> <...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,323
issue_to_patch
Bump 5 NuGet packages from 10.0.5 to 10.0.6
Consolidates all 5 open Dependabot PRs (#2316, #2318, #2319, #2320, #2321) into a single update. ## Changes - **Aga.Controls.csproj**: `System.Resources.Extensions` 10.0.5 → 10.0.6 - **LibreHardwareMonitor.csproj**: `System.Resources.Extensions`, `System.Text.Json` 10.0.5 → 10.0.6 - **LibreHardwareMonitorLib.csproj**...
fadcba0a0d104d9a83e8727fc15c64c7d1ce3112
1df280504424715d3b42c1cbe77ae3777b24289d
diff --git a/Aga.Controls/Aga.Controls.csproj b/Aga.Controls/Aga.Controls.csproj index 192c20fb2..52ae73776 100644 --- a/Aga.Controls/Aga.Controls.csproj +++ b/Aga.Controls/Aga.Controls.csproj @@ -123,6 +123,6 @@ <Compile Remove="Tree\NativeMethods.cs" /> </ItemGroup> <ItemGroup> - <PackageReference Inclu...
[ "Aga.Controls/Aga.Controls.csproj", "LibreHardwareMonitor/LibreHardwareMonitor.csproj", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,322
issue_to_patch
Update DiskInfoToolkit - fixes bluescreen.
Update DiskInfoToolkit. Fixes bluescreen for Intel Rst drives where it has occurred. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/2.0.2
c6bf0c63ab4e529644b2a13117128879d21eaa40
bba603ce8448b84f3b3c06eb55c915762b8b32cc
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 6f2c4c47c..53f1215ab 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -81,7 +81,7 @@ </ItemGroup> ...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,303
issue_to_patch
Fix temperature offset detection on newer Zen CPUs
This updates the Zen CPU temperature logic in `Amd17Cpu.cs`. LibreHardwareMonitor previously only applied the 49 °C correction when `RANGE_SEL[19]` was set. On newer Threadripper 9000 / Pro 9000 CPUs, the same correction can also be signaled through `TJ_SEL[17:16] == 0b11`, which can otherwise lead to readings that ...
47b46c7bf458fd9a8afe56fbff07ba0091a59141
a9b4faff14959fc02967242168b7218f37dfa6bd
diff --git a/LibreHardwareMonitorLib/Hardware/Cpu/Amd17Cpu.cs b/LibreHardwareMonitorLib/Hardware/Cpu/Amd17Cpu.cs index 0e5fe504b..54e6daee6 100644 --- a/LibreHardwareMonitorLib/Hardware/Cpu/Amd17Cpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Cpu/Amd17Cpu.cs @@ -271,8 +271,9 @@ public void UpdateSensors() ...
[ "LibreHardwareMonitorLib/Hardware/Cpu/Amd17Cpu.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,308
issue_to_patch
NetworkInformationException unhandled in UpdateNetworkInterfaces when constructing Network ## Description `NetworkGroup.UpdateNetworkInterfaces` crashes with an unhandled `System.Net.NetworkInformation.NetworkInformationException` ("The system cannot find the file specified.") when a network interface disappears or b...
Fix unhandled NetworkInformationException in UpdateNetworkInterfaces
Fixes #2307 Wrap new Network(networkInterface, settings) in UpdateNetworkInterfaces with a try/catch for NetworkInformationException, matching how GetNetworkInterfaces() already handles the same exception type. If a network interface disappears between enumeration and the Network constructor calling GetIPStatis...
47b46c7bf458fd9a8afe56fbff07ba0091a59141
26f0b458c1af55c4be170deb9c0d8dcd9a85bfe4
diff --git a/LibreHardwareMonitorLib/Hardware/Network/NetworkGroup.cs b/LibreHardwareMonitorLib/Hardware/Network/NetworkGroup.cs index e4e309ffc..b69e29a22 100644 --- a/LibreHardwareMonitorLib/Hardware/Network/NetworkGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Network/NetworkGroup.cs @@ -92,9 +92,16 @@ private void...
[ "LibreHardwareMonitorLib/Hardware/Network/NetworkGroup.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,311
issue_to_patch
Fix NVMe temperature sensors.
Fix NVMe temperature sensors. https://github.com/Rem0o/FanControl.Releases/issues/3990
47b46c7bf458fd9a8afe56fbff07ba0091a59141
09f7d34545ca78cb31d68223d70783bf305e4134
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index 6c8959479..78dd94e93 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -219,14 +219,14 @@ priva...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,304
issue_to_patch
Update for DIT 2.0.1
Update for DIT 2.0.1. Move force wakeup to proper place. Check power state of disk and update depending on that.
47b46c7bf458fd9a8afe56fbff07ba0091a59141
297f12f3981b1f264163b7a8771e3c6777f04d5a
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index 6c8959479..d0d7239fc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -80,8 +80,23 @@ public o...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,300
issue_to_patch
Need someway to either automatically refresh or sound an alarm when LibreHardwareMonitor fails I am dependent on Fan Control. If its not running, my fans dont work and my CPU overheats immediately. It works super well but sometimes LibreHardwareMonitor fails and I have to manually refresh Fan control. Sometimes I d...
X570 null exception and pdb in release
Fixes https://github.com/Rem0o/FanControl.Releases/issues/3982#issuecomment-4195468095 And also remove PDB from release build output.
47b46c7bf458fd9a8afe56fbff07ba0091a59141
3f62c58a81f213231bd86d27a7defbb017fa73af
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs index 1fe59a812..047d3ceff 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs @@ ...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/SuperIOHardware.cs" ]
[ { "comment": "This is not needed.\r\n```\r\n The Optimize option is enabled by default for a Release build configuration\r\n```\r\n\r\nWhy do you want to disable PDBs?", "path": "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj", "hunk": "@@ -46,6 +46,9 @@\n </PropertyGroup>\n \n <PropertyGrou...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,301
issue_to_patch
Update storage performance sensors even when device state is unchanged
### Summary This PR fixes stale disk throughput data by continuing to update storage performance sensors even when the storage device has no visible state changes. In some cases, especially on mechanical drives, the read/write throughput sensors could appear delayed or remain stuck on old values because the perfo...
aa838636e1e54dc8febd38b3ff05d6df2da6c9b4
33b65fa1c4368649a6d5f1bf23b53c02848797b5
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index 523b7145e..6c8959479 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -80,16 +80,18 @@ public ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,280
issue_to_patch
feat: Add Native AOT compilation support for LibreHardwareMonitorLib
## Summary Add Native AOT compilation support for LibreHardwareMonitorLib without losing any functionality. ## Changes ### Marshal API modernization (AOT-safe generic versions) - **NvApi.cs**: \GetDelegate<T>\ now uses \Marshal.GetDelegateForFunctionPointer<T>(ptr)\ - **NvidiaML.cs**: All 9 \GetDelegateForFu...
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
4ca54a104a5db07b489a9fe42b99e2cebd126e55
diff --git a/LibreHardwareMonitorLib/Hardware/Controller/MSI/MsiCoreLiquidController.cs b/LibreHardwareMonitorLib/Hardware/Controller/MSI/MsiCoreLiquidController.cs index 6a5a2f1d2..4009cd153 100644 --- a/LibreHardwareMonitorLib/Hardware/Controller/MSI/MsiCoreLiquidController.cs +++ b/LibreHardwareMonitorLib/Hardware/C...
[ "LibreHardwareMonitorLib/Hardware/Controller/MSI/MsiCoreLiquidController.cs", "LibreHardwareMonitorLib/Hardware/Gpu/AmdGpu.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Ipmi.cs", "LibreHardwareMonitorLib/Hardware/OpCode.cs", "LibreHardwareMonitorLib/Hardware/PowerMonitor/WireViewPro2.cs", "LibreH...
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
issue_to_patch
Update for DiskInfoToolkit Version 2.0.0.
Update for DiskInfoToolkit Version 2.0.0. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/2.0.0
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs index 06d0c7f36..5a0fe2325 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs @@ -4,6 +4,8 @@ // Par...
[ "LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs", "LibreHardwareMonitorLib/Hardware/Storage/SmartAttributeTranslator.cs", "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs", "LibreHardwareMonitorLib/Hardware/Storage/Stor...
[ { "comment": "`CreateAttributes()` now constructs `SmartAttribute` instances with `sensorType` always `null`, but `AddSmartAttributeSensors()` only creates sensors for attributes where `SensorType.HasValue`. As a result, SMART attribute sensors will never be created (the method becomes a no-op), which is a func...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
`CreateAttributes()` now constructs `SmartAttribute` instances with `sensorType` always `null`, but `AddSmartAttributeSensors()` only creates sensors for attributes where `SensorType.HasValue`. As a result, SMART attribute sensors will never be created (the method becomes a no-op), which is a functional regression comp...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "`CreateAttributes()` now constructs `SmartAttribute` instances with `sensorType` always `null`, but `AddSmartAttributeSensors()` only creates sensors for attributes where `SensorType.HasValue`. As a result, SMART attribute sensors will never be created (the method becomes a no-op), which is a func...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
`UpdateSpaceSensors()` uses `_storage.DiskSizeBytes` and `_storage.TotalPartitionFreeSpaceBytes` in comparisons and arithmetic without consistently handling nullability. In this file the same properties are treated as nullable elsewhere (`GetValueOrDefault()` / `!= null`), so `if (_storage.DiskSizeBytes > 0)` and the d...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "`UpdateSpaceSensors()` uses `_storage.DiskSizeBytes` and `_storage.TotalPartitionFreeSpaceBytes` in comparisons and arithmetic without consistently handling nullability. In this file the same properties are treated as nullable elsewhere (`GetValueOrDefault()` / `!= null`), so `if (_storage.DiskSiz...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and may drop required attrib...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and ma...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and may drop required attrib...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs" ]
[ { "comment": "These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and ma...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and may drop required attrib...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs index b1f8dfe8c..b04809b62 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs @@ ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs" ]
[ { "comment": "These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and ma...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and may drop required attrib...
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs index 06d0c7f36..5a0fe2325 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs @@ -4,6 +4,8 @@ // Par...
[ "LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs" ]
[ { "comment": "These files previously used the project-wide MPL header/attribution format (e.g., `LibreHardwareMonitorLib/Hardware/Computer.cs:3-5`). Replacing the existing LibreHardwareMonitor/OpenHardwareMonitor copyright lines with a new single-owner notice is inconsistent with the rest of the codebase and ma...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
```suggestion if (ForceWakeup && !_storage.IsDevicePowerOn.GetValueOrDefault(true) ```
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "```suggestion\n if (ForceWakeup && !_storage.IsDevicePowerOn.GetValueOrDefault(true)\n```", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "hunk": "@@ -77,18 +79,37 @@ public override void Update()\n return;\n }\n \n+ // If storage de...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
Why is there an alternative device path when the first one is null?
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "Why is there an alternative device path when the first one is null?", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "hunk": "@@ -274,7 +322,7 @@ private unsafe void UpdatePerformanceSensors()\n {\n DISK_PERFORMANCE diskPerformance = new();\n \n- us...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
Just commenting on this here (applies to other files), I'm not sure this is more readable than the original naming. But I don't feel too strong about this.
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs" ]
[ { "comment": "Just commenting on this here (applies to other files), I'm not sure this is more readable than the original naming. But I don't feel too strong about this.", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs", "hunk": "@@ -1,13 +1,13 @@\n // This Source Code Form is subjec...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
Why is this called when there are no changes? 🤔
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs" ]
[ { "comment": "Why is this called when there are no changes? 🤔", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs", "hunk": "@@ -34,49 +34,71 @@ public StorageGroup(ISettings settings)\n \n private void AddHardware(ISettings settings)\n {\n- StorageManager.StoragesChanged...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
Let's avoid breaking this, the original name was OK.
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[ { "comment": "Let's avoid breaking this, the original name was OK.", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "hunk": "@@ -57,16 +60,15 @@ public StorageDevice(DiskInfoToolkit.Storage storage, string id, ISettings setti\n \n public override HardwareType HardwareType => Ha...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,298
comment_to_fix
Update for DiskInfoToolkit Version 2.0.0.
```suggestion ```
9d9bb0084b1a686f86ae37edde19e8799ff73cdc
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
[ "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs" ]
[ { "comment": "```suggestion\n```", "path": "LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs", "hunk": "@@ -34,49 +35,71 @@ public StorageGroup(ISettings settings)\n \n private void AddHardware(ISettings settings)\n {\n- StorageManager.StoragesChanged -= OnStoragesChanged;\n+ ...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
issue_to_patch
NCT6687DR MSI X870 — Sysfan headers slow ramp: does LHM implement 7-point curve write for sysfan control? Config and observed behavior: * Mobo: MSI MAG X870 Tomahawk WiFi * SuperIO chip: Nuvoton NCT6687D-R * LHM version: 0.9.6.0 * FanControl version: 264 NET 10.0 All fan headers are detected and controllable...
Fix NCT6687DR fan control for system fans (index 9–15)
Fixes #2292 ## Problem On MSI AM5/LGA1851 800-series motherboards using the NCT6687D-R (detected as `Chip.NCT6687DR`), **system fan control (SYSFAN1–7) is partialy non-functional**. Setting a fan duty cycle results in an extremely slow ~2%/s ramp instead of an immediate change, and the fans eventually revert to t...
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "Please switch this to Stopwatch (`.Elapsed < TimeSpan.FromSeconds(1)`). Same below.", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor()\n ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
Please switch this to Stopwatch (`.Elapsed < TimeSpan.FromSeconds(1)`). Same below.
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "Please switch this to Stopwatch (`.Elapsed < TimeSpan.FromSeconds(1)`). Same below.", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor()\n ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
Let's name this `engineSts` instead of this (also in other function).
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "Let's name this `engineSts` instead of this (also in other function).", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor()\n ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
Will wait 15.6ms on most PCs, but probably irrelevant.
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "Will wait 15.6ms on most PCs, but probably irrelevant.", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor()\n ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW_REGISTER)) == ...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
```suggestion private bool CompleteFanConfigUpdate(int index) ```
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "```suggestion\n private bool CompleteFanConfigUpdate(int index)\n```", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor()\n ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_L...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
I forgot to write this, please remove all regions, we don't use these.
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "I forgot to write this, please remove all regions, we don't use these.", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -19,23 +19,72 @@ namespace LibreHardwareMonitor.Hardware.Motherboard.Lpc;\n \n internal class Nct677X : ISuperIO\n {\n+ #region Con...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,294
comment_to_fix
Fix NCT6687DR fan control for system fans (index 9–15)
This logic has the same problem. https://learn.microsoft.com/en-us/dotnet/api/system.threading.spinwait.spinonce?view=net-10.0#remarks https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Threading/SpinWait.cs,193 Just use Thread.Sleep(10), it'll sleep longer on most OS, but ...
3d0a31d4ab8ceac683e95ea13cf6bb20f9778b8d
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "This logic has the same problem.\n\nhttps://learn.microsoft.com/en-us/dotnet/api/system.threading.spinwait.spinonce?view=net-10.0#remarks\nhttps://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Threading/SpinWait.cs,193\n\nJust use Thread.Sleep(10), it'll sl...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,282
issue_to_patch
Gadget Styling (Background Color)
# PR #2282 Long time fan of Open/Librehardwaremonitor. It's still my go to over HWiNfo64 for the plot chart but I'm also a big fan of the gadget! I worry I'm a little bit of an outlier when it comes to enjoying the gadget as it's seemed to have gotten a left behind compared to the other QoL updates the software has s...
516c90c7beb8c0c2329ec2f3f17bcb97e644a279
069d4e904f0196570cdcd562dc44d1dfc6bdacef
diff --git a/LibreHardwareMonitor/Resources/bar.png b/LibreHardwareMonitor/Resources/bar.png new file mode 100644 index 000000000..7d7bb663d Binary files /dev/null and b/LibreHardwareMonitor/Resources/bar.png differ diff --git a/LibreHardwareMonitor/Resources/barblue.png b/LibreHardwareMonitor/Resources/barblue.png del...
[ "LibreHardwareMonitor/Resources/bar.png", "LibreHardwareMonitor/Resources/barblue.png", "LibreHardwareMonitor/Resources/gadget.png", "LibreHardwareMonitor/UI/SensorGadget.cs" ]
[ { "comment": "CreateBackgroundTint() can produce a non-grayscale tint even when the user selects a true grayscale color (target saturation == 0). Because saturation is forced to at least sourceSaturation * 0.25, a custom (colored) gadget_background.png will end up slightly tinted (often reddish because GetHue()...
true
LibreHardwareMonitor/LibreHardwareMonitor
1,644
issue_to_patch
Add support for MSI AM5/LGA1851 Motherboards using the NCT6687D SIO Controller
### Background It appears that new MSI Motherboards with AMD Socket AM5 or Intel Socket LGA1851 that utilize the Nuvoton NCT6687D Super I/O Controller behave differently than motherboards of the past with the same model controller. This led to issues with sensors being incorrectly detected, mainly fan speed and duty c...
9b985d3bea2aa39e2b270f111e98802f91551285
13f997598e4deff4358d947817a78891d05aa94b
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs index 5692c6ec1..9d3abfe2f 100755 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs @@ -627...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Chip.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Model.cs", ...
[ { "comment": "Just going to comment once, can you reformat all documents to follow code style? For example, `){` should be `) {`, same with `else{` to `else {`", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -409,7 +478,13 @@ public void SetControl(int index, byte? v...
true
LibreHardwareMonitor/LibreHardwareMonitor
1,644
comment_to_fix
Add support for MSI AM5/LGA1851 Motherboards using the NCT6687D SIO Controller
Just going to comment once, can you reformat all documents to follow code style? For example, `){` should be `) {`, same with `else{` to `else {`
9b985d3bea2aa39e2b270f111e98802f91551285
13f997598e4deff4358d947817a78891d05aa94b
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index f500f88d8..e94c45721 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -76,6 +76,13 @@ ...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs" ]
[ { "comment": "Just going to comment once, can you reformat all documents to follow code style? For example, `){` should be `) {`, same with `else{` to `else {`", "path": "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs", "hunk": "@@ -409,7 +478,13 @@ public void SetControl(int index, byte? v...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,288
issue_to_patch
Update DiskInfoToolkit.
Update DiskInfoToolkit. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/1.2.1 https://github.com/Rem0o/FanControl.Releases/issues/3965
4058577277088832b715ed0c077b5a8a3542d7d3
eabddc06ce710ffc92c52065077942a152636040
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 31987b5b9..10de77437 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -70,7 +70,7 @@ </ItemGroup> ...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,284
issue_to_patch
Sensors on older Intel Framework Laptops
Hi, I've added MEC ChromeOS EC support, which is present on 11th, 12th, and 13th Gen Intel Framework laptops (and Chromebooks). LibreHardwareMonitor should now show the EC sensors on every currently released Framework device. Example output: <img width="569" height="624" alt="Screenshot 2026-03-18 094250" src=...
0db3cc8e156af665ab44c0296ddcb5133cc408ec
87d1a96bc44f5e64dbd490dff45d8c78f882e802
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs index b409c2f1e..c49be2543 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs @@ -804...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Identification.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/EC/EmbeddedController.cs", "LibreHardwareMonitorLib/Hardware/Motherboard/Model.cs", "LibreHardwareMonitorLib/Resources/PawnIo/LpcCrOSEC.bin" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,281
issue_to_patch
Add MSI B860 mainboard handling (NCT6687D-R).
Add MSI B860 mainboard handling (NCT6687D-R). #2279
516c90c7beb8c0c2329ec2f3f17bcb97e644a279
5d11dfca894e0d71e03e04ab6ecd897a766fe6de
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs index 605e73d78..596c80668 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs @@ -413,6 +413,7 @@ private...
[ "LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/LpcIO.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,277
issue_to_patch
DELL Latitude lost NVMe on versions 0.9.5/6 On DELL Latitude 3400 doesn't show NVMe disk on ver. 0.9.5-0.9.6 (on 0.9.4 it works perfectly) <img width="724" height="480" alt="Image" src="https://github.com/user-attachments/assets/d1b6b984-83ab-4b94-8288-1a9aeb7ad1b1" /> <img width="709" height="379" alt="Image" src=...
Update DiskInfoToolkit.
Update DiskInfoToolkit. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/1.2.0 Closes: #2227
44d3263b27bdff4be1daa1a86b47282ba26cf726
b1476f2820b40e8e0e782cbffff17e79dac05fbd
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 2dab64c08..2fbf83cbe 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -70,7 +70,7 @@ </ItemGroup> ...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,255
issue_to_patch
Handle driver restart for NVIDIA GPUs
Handle driver restart for NVIDIA GPUs. #2249
273b47b462223d6237e504455465722ae4baaac2
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs index cca01b697..d281a09ea 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs @@ -6,6 +6,7 @@ using System; using System.Collections....
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGpu.cs", "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs" ]
[ { "comment": "We have this task monitoring stuff now in various places. I think we should add an Update method to IGroup and a VisitGroup in IVisitor.", "path": "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs", "hunk": "@@ -4,100 +4,316 @@\n // Partial Copyright (C) Michael Möller <mmoeller@openhar...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,255
comment_to_fix
Handle driver restart for NVIDIA GPUs
`RefreshHardware` mutates `_hardwareSnapshot` from a background task while `Computer.Traverse()` reads `group.Hardware` multiple times per loop iteration (for `Count` and the indexer). If `_hardwareSnapshot` is replaced between those calls, `Traverse()` can hit `IndexOutOfRangeException` and crash the update loop. Cons...
273b47b462223d6237e504455465722ae4baaac2
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs" ]
[ { "comment": "`RefreshHardware` mutates `_hardwareSnapshot` from a background task while `Computer.Traverse()` reads `group.Hardware` multiple times per loop iteration (for `Count` and the indexer). If `_hardwareSnapshot` is replaced between those calls, `Traverse()` can hit `IndexOutOfRangeException` and crash...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,255
comment_to_fix
Handle driver restart for NVIDIA GPUs
`HardwareAdded` is invoked while holding `_syncRoot`. If any event handler calls back into `NvidiaGroup` (e.g., reads `Hardware`/`GetReport`) this can deadlock, and it also extends the lock hold time. Prefer collecting newly-added GPUs under the lock, updating `_hardwareSnapshot`, then raising `HardwareAdded` for those...
273b47b462223d6237e504455465722ae4baaac2
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs" ]
[ { "comment": "`HardwareAdded` is invoked while holding `_syncRoot`. If any event handler calls back into `NvidiaGroup` (e.g., reads `Hardware`/`GetReport`) this can deadlock, and it also extends the lock hold time. Prefer collecting newly-added GPUs under the lock, updating `_hardwareSnapshot`, then raising `Ha...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,255
comment_to_fix
Handle driver restart for NVIDIA GPUs
I don't think we have to maintain two lists here, we can just assign a new List to `_hardware` on update so they're effectively lock-free.
273b47b462223d6237e504455465722ae4baaac2
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs" ]
[ { "comment": "I don't think we have to maintain two lists here, we can just assign a new List to `_hardware` on update so they're effectively lock-free.", "path": "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs", "hunk": "@@ -4,100 +4,316 @@\n // Partial Copyright (C) Michael Möller <mmoeller@openh...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,255
comment_to_fix
Handle driver restart for NVIDIA GPUs
Why does this need to be locked (also further down)? This should never run simultaneously.
273b47b462223d6237e504455465722ae4baaac2
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
[ "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs" ]
[ { "comment": "Why does this need to be locked (also further down)? This should never run simultaneously.", "path": "LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs", "hunk": "@@ -4,100 +4,316 @@\n // Partial Copyright (C) Michael Möller <mmoeller@openhardwaremonitor.org> and Contributors.\n // All R...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,254
issue_to_patch
Remove formatting from raw values in HttpServer
Remove formatting from raw values. #2253
f5479cdbf00de652d6df1a345f7528dbb0381c36
f104e726d0b9217d0afe7e221d71fa016ed5c095
diff --git a/LibreHardwareMonitor/Utilities/HttpServer.cs b/LibreHardwareMonitor/Utilities/HttpServer.cs index 139658065..ab7f0f472 100644 --- a/LibreHardwareMonitor/Utilities/HttpServer.cs +++ b/LibreHardwareMonitor/Utilities/HttpServer.cs @@ -807,9 +807,9 @@ private Dictionary<string, object> GenerateJsonForNode(Node...
[ "LibreHardwareMonitor/Utilities/HttpServer.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,261
issue_to_patch
Support new firmware for WVP2 and fix possible freeze.
Support new firmware for WVP2 and fix possible freeze. See also: https://github.com/ElmorLabs-ThermalGrizzly/WireViewDeviceLib/compare/c507fc5...master
273b47b462223d6237e504455465722ae4baaac2
625e160a475acbab3295d867c2737e9d69200738
diff --git a/LibreHardwareMonitorLib/Hardware/PowerMonitor/SharedSerialPort.cs b/LibreHardwareMonitorLib/Hardware/PowerMonitor/SharedSerialPort.cs index 84ea4e5bb..9a257abd2 100644 --- a/LibreHardwareMonitorLib/Hardware/PowerMonitor/SharedSerialPort.cs +++ b/LibreHardwareMonitorLib/Hardware/PowerMonitor/SharedSerialPor...
[ "LibreHardwareMonitorLib/Hardware/PowerMonitor/SharedSerialPort.cs", "LibreHardwareMonitorLib/Hardware/PowerMonitor/WireViewPro2.cs", "LibreHardwareMonitorLib/Interop/PowerMonitor/DeviceData.cs", "LibreHardwareMonitorLib/Interop/PowerMonitor/StructureConversion.cs", "LibreHardwareMonitorLib/Interop/PowerMon...
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,257
issue_to_patch
Fix build for Linux
Fix build for Linux.
a0392ad4fc0dab78ece9911ca13013ff28ab25e1
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs index 45fa4fb13..e29f8d0d6 100644 --- a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs @@ -28,6 +28,7 @@ public unsafe...
[ "LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs", "LibreHardwareMonitorLib/Hardware/Computer.cs", "LibreHardwareMonitorLib/Hardware/Cpu/IntelCpu.cs", "LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[ { "comment": "```suggestion\n#endif\n```", "path": "LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs", "hunk": "@@ -129,11 +130,13 @@ public unsafe BatteryGroup(ISettings settings)\n \n hdev.Dispose();\n }\n+ #endif", "resolving_sha": "6ef07af09797ef2fb4f1ee3ee711bfa8c...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,257
comment_to_fix
Fix build for Linux
```suggestion #endif ```
a0392ad4fc0dab78ece9911ca13013ff28ab25e1
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs index 45fa4fb13..e29f8d0d6 100644 --- a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs @@ -28,6 +28,7 @@ public unsafe...
[ "LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs" ]
[ { "comment": "```suggestion\n#endif\n```", "path": "LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs", "hunk": "@@ -129,11 +130,13 @@ public unsafe BatteryGroup(ISettings settings)\n \n hdev.Dispose();\n }\n+ #endif", "resolving_sha": "6ef07af09797ef2fb4f1ee3ee711bfa8c...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,257
comment_to_fix
Fix build for Linux
```suggestion #endif ```
a0392ad4fc0dab78ece9911ca13013ff28ab25e1
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs b/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs index 715322a2d..eefef6511 100644 --- a/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs +++ b/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs @@ ...
[ "LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs" ]
[ { "comment": "```suggestion\n#endif\n```", "path": "LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs", "hunk": "@@ -116,6 +115,9 @@ static string GetProperty(SafeHandle hDevInfo, SETUP_DI_REGISTRY_PROPERTY proper\n \n return null;\n }\n+ #endif", "resolving_sha"...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,257
comment_to_fix
Fix build for Linux
```suggestion if (!Software.OperatingSystem.IsUnix) ``` ?
a0392ad4fc0dab78ece9911ca13013ff28ab25e1
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Hardware/Computer.cs b/LibreHardwareMonitorLib/Hardware/Computer.cs index bb87340ed..7a23d0106 100644 --- a/LibreHardwareMonitorLib/Hardware/Computer.cs +++ b/LibreHardwareMonitorLib/Hardware/Computer.cs @@ -512,7 +512,9 @@ public void Open() _smbios = new SMBios(); - ...
[ "LibreHardwareMonitorLib/Hardware/Computer.cs" ]
[ { "comment": "```suggestion\n if (!Software.OperatingSystem.IsUnix)\n```\n?", "path": "LibreHardwareMonitorLib/Hardware/Computer.cs", "hunk": "@@ -512,7 +512,9 @@ public void Open()\n \n _smbios = new SMBios();\n \n- Mutexes.Open();\n+ if (Software.OperatingSystem.IsWindows8...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,252
issue_to_patch
Add StorageDevice.ForceWakeup property
Add StorageDevice.ForceWakeup property.
f5479cdbf00de652d6df1a345f7528dbb0381c36
a9fa4ac6142ab917a2bf07d28a2b40dca48f3670
diff --git a/LibreHardwareMonitor/UI/MainForm.cs b/LibreHardwareMonitor/UI/MainForm.cs index 0720794de..1a3970d8c 100644 --- a/LibreHardwareMonitor/UI/MainForm.cs +++ b/LibreHardwareMonitor/UI/MainForm.cs @@ -295,7 +295,7 @@ static string ExtractPawnIO() .ToList() .ForEach(sd => ...
[ "LibreHardwareMonitor/UI/MainForm.cs", "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,250
issue_to_patch
Update RAMSPDToolkit - adds detection logic for Intel Skylake IMC
Update RAMSPDToolkit - adds detection logic for Intel Skylake IMC. See also: https://github.com/Blacktempel/RAMSPDToolkit/releases/tag/1.5.0
f5479cdbf00de652d6df1a345f7528dbb0381c36
68b5bbe9410a666e7b4bec488facdc47f5ecf8fb
diff --git a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj index 410d6c4ac..7fddd1ccd 100644 --- a/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj +++ b/LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj @@ -51,6 +51,7 @@ <EmbeddedResourc...
[ "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj", "LibreHardwareMonitorLib/RAMSPDToolkitDriver.cs", "LibreHardwareMonitorLib/Resources/PawnIo/SmbusIntelSkylakeIMC.bin" ]
[]
true
LibreHardwareMonitor/LibreHardwareMonitor
2,245
issue_to_patch
Update DiskInfoToolkit & add Force Drive Wakeup option
Update DiskInfoToolkit. Add option for Force Drive Wakeup. https://github.com/Blacktempel/DiskInfoToolkit/releases/tag/1.1.3
e6cd6ccc74c9db9cd87ff5a594d9d7d05af011c5
7342bac1ed43dfc1516e048517116531b22e0302
diff --git a/LibreHardwareMonitor/UI/MainForm.Designer.cs b/LibreHardwareMonitor/UI/MainForm.Designer.cs index 0135057ff..dba5a5e1c 100644 --- a/LibreHardwareMonitor/UI/MainForm.Designer.cs +++ b/LibreHardwareMonitor/UI/MainForm.Designer.cs @@ -102,6 +102,7 @@ private void InitializeComponent() this.splitP...
[ "LibreHardwareMonitor/UI/MainForm.Designer.cs", "LibreHardwareMonitor/UI/MainForm.cs", "LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs", "LibreHardwareMonitorLib/LibreHardwareMonitorLib.csproj" ]
[ { "comment": "Maybe we should default this to false?", "path": "LibreHardwareMonitor/UI/MainForm.cs", "hunk": "@@ -286,10 +287,21 @@ static string ExtractPawnIO()\n \n _showGadget = new UserOption(\"gadgetMenuItem\", false, gadgetMenuItem, _settings);\n \n+ _forceDriveWakeup = new UserOpt...
true
LibreHardwareMonitor/LibreHardwareMonitor
2,245
comment_to_fix
Update DiskInfoToolkit & add Force Drive Wakeup option
Maybe we should default this to false?
e6cd6ccc74c9db9cd87ff5a594d9d7d05af011c5
7342bac1ed43dfc1516e048517116531b22e0302
diff --git a/LibreHardwareMonitor/UI/MainForm.cs b/LibreHardwareMonitor/UI/MainForm.cs index b98afb57f..0720794de 100644 --- a/LibreHardwareMonitor/UI/MainForm.cs +++ b/LibreHardwareMonitor/UI/MainForm.cs @@ -33,6 +33,7 @@ public sealed partial class MainForm : Form private readonly UserRadioGroup _updateInterval;...
[ "LibreHardwareMonitor/UI/MainForm.cs" ]
[ { "comment": "Maybe we should default this to false?", "path": "LibreHardwareMonitor/UI/MainForm.cs", "hunk": "@@ -286,10 +287,21 @@ static string ExtractPawnIO()\n \n _showGadget = new UserOption(\"gadgetMenuItem\", false, gadgetMenuItem, _settings);\n \n+ _forceDriveWakeup = new UserOpt...
true
LoopPerfect/buckaroo
381
issue_to_patch
improvement/github-actions
* Moves to net6.0 * Adds GitHub Action
f95792c47b3f4e6b4ed9ca121071422c88498908
7578e6e680019b2514c7a5745ad508dd0e5b440b
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml new file mode 100644 index 0000000..f5b1a4d --- /dev/null +++ b/.github/workflows/build.yml @@ -0,0 +1,24 @@ +name: Build + +on: [ push, pull_request ] + +jobs: + + build: + runs-on: ubuntu-20.04 + + steps: + - name: Setup .NET Core SDK + ...
[ ".github/workflows/build.yml", "buckaroo-cli/buckaroo-cli.fsproj", "buckaroo-tests/buckaroo-tests.fsproj", "buckaroo/buckaroo.fsproj" ]
[]
true
LoopPerfect/buckaroo
380
issue_to_patch
quickfix/remove-ionide-folder
* Removes Ionide IDE file
f95792c47b3f4e6b4ed9ca121071422c88498908
5115f4a7a188017ea07e62be4e03759b7487558c
diff --git a/.gitignore b/.gitignore index 027a7fe..890d1d1 100644 --- a/.gitignore +++ b/.gitignore @@ -293,3 +293,5 @@ buckaroo-windows.exe warp/ fsi.fsx + +.ionide diff --git a/buckaroo/.ionide/symbolCache.db b/buckaroo/.ionide/symbolCache.db deleted file mode 100644 index 97e504b..0000000 Binary files a/buckaro...
[ ".gitignore", "buckaroo/.ionide/symbolCache.db" ]
[]
true
LoopPerfect/buckaroo
374
issue_to_patch
Resolving private repositories <!--- Provide a general summary of the issue in the Title above --> ## Description <!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug --> I've been using buckaroo quite some time with my private repos and I'm constantly running into t...
adds git fallback in cacheOrApi to fix #373
should fix #373 by gracefully falling back to FindCommit if API call fails. In theory we could decide to not even try the API if we are in SSH mode, however the API is significantly faster then git so IMHO worth a try. I presume querying the API to determine if the repository is public is slower then trying to get th...
6e7ff66196d3bd6c4022cac8d544fea35e191b40
e3e4e79e52a52fb1ed42450b9b4d951532f50778
diff --git a/buckaroo/.ionide/symbolCache.db b/buckaroo/.ionide/symbolCache.db new file mode 100644 index 0000000..97e504b Binary files /dev/null and b/buckaroo/.ionide/symbolCache.db differ diff --git a/buckaroo/DefaultSourceExplorer.fs b/buckaroo/DefaultSourceExplorer.fs index a2e5040..6921a67 100644 --- a/buckaroo/D...
[ "buckaroo/.ionide/symbolCache.db", "buckaroo/DefaultSourceExplorer.fs" ]
[]
true
LoopPerfect/buckaroo
365
issue_to_patch
remove ssh prefix and update nuget.config
98daf110dafd4a7cafd3427914614708d4100f81
184d78cc345704b0c70928ea2826a0079ae7fe31
diff --git a/buckaroo-cli/buckaroo-cli.fsproj b/buckaroo-cli/buckaroo-cli.fsproj index 00c35ce..38f119b 100644 --- a/buckaroo-cli/buckaroo-cli.fsproj +++ b/buckaroo-cli/buckaroo-cli.fsproj @@ -14,7 +14,7 @@ </ItemGroup> <ItemGroup> - <PackageReference Include="Microsoft.DotNet.ILCompiler" Version="1.0.0-alph...
[ "buckaroo-cli/buckaroo-cli.fsproj", "buckaroo-cli/nuget.config", "buckaroo/PackageLocation.fs" ]
[]
true
LoopPerfect/buckaroo
359
issue_to_patch
* Adds buckaroo_workspace macro
49b54251d2d6685b4f441d57511307d5808b98ed
ec3c50fa4283367400fd730d200800187600fa04
diff --git a/buckaroo/InstallCommand.fs b/buckaroo/InstallCommand.fs index 06782a4..a068dee 100644 --- a/buckaroo/InstallCommand.fs +++ b/buckaroo/InstallCommand.fs @@ -331,7 +331,7 @@ let private generateBuckConfig (sourceExplorer : ISourceExplorer) (parents : Pac return buckarooConfig |> BuckConfig.render } -le...
[ "buckaroo/InstallCommand.fs" ]
[]
true
LoopPerfect/buckaroo
357
issue_to_patch
feature/bazel
Rudimentary Bazel support.
b84a0150e25f705940c79567c41397d6d205922a
6ee30370cd3fbd8b5554842401d8a407e1e68583
diff --git a/.gitignore b/.gitignore index 668888d..027a7fe 100644 --- a/.gitignore +++ b/.gitignore @@ -163,8 +163,6 @@ publish/ # Publish Web Output *.[Pp]ublish.xml *.azurePubxml -# TODO: Comment the next line if you want to checkin your web deploy settings -# but database connection strings (with potential passw...
[ ".gitignore", "buckaroo-cli/Program.fs", "buckaroo-tests/Lock.fs", "buckaroo-tests/Manifest.fs", "buckaroo-tests/Paths.fs", "buckaroo-tests/Solver.fs", "buckaroo/AddCommand.fs", "buckaroo/BuildSystem.fs", "buckaroo/Command.fs", "buckaroo/Constants.fs", "buckaroo/Constraint.fs", "buckaroo/Defau...
[ { "comment": "why does the source explorer need to know about the buildsystem?", "path": "buckaroo/DefaultSourceExplorer.fs", "hunk": "@@ -6,7 +6,7 @@ open Buckaroo.Console\n open Buckaroo.RichOutput\n open Buckaroo.Logger\n \n-type DefaultSourceExplorer (console : ConsoleManager, downloadManager : Down...
true
LoopPerfect/buckaroo
355
issue_to_patch
feature/bazel-explain
0bd4d00681ee633007c2c0e9ccf9f41d05d33bad
80203804bfee253a9ac681a0ba606bf29b7fafd1
diff --git a/buckaroo/Command.fs b/buckaroo/Command.fs index fda4129..6b117d4 100644 --- a/buckaroo/Command.fs +++ b/buckaroo/Command.fs @@ -17,6 +17,7 @@ type Command = | UpgradeDependencies of List<PackageIdentifier> | AddDependencies of List<Dependency> | RemoveDependencies of List<PackageIdentifier> + | E...
[ "buckaroo/Command.fs", "buckaroo/ExplainCommand.fs", "buckaroo/Logger.fs", "buckaroo/buckaroo.fsproj" ]
[]
true
LoopPerfect/buckaroo
354
issue_to_patch
Feature/bazel overrides
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- I...
a951bfff766ada16b52589b311efd62b490acb85
2142f59a8631420e36a7c7bc2464e0a50e6284d8
diff --git a/buckaroo-tests/Manifest.fs b/buckaroo-tests/Manifest.fs index afb9179..88de197 100644 --- a/buckaroo-tests/Manifest.fs +++ b/buckaroo-tests/Manifest.fs @@ -104,18 +104,26 @@ let ``Manifest.toToml roundtrip 1`` () = [<Fact>] let ``Manifest.toToml roundtrip 2`` () = let expected : Manifest = { - Targ...
[ "buckaroo-tests/Manifest.fs", "buckaroo-tests/Solver.fs", "buckaroo/Dependency.fs", "buckaroo/Manifest.fs", "buckaroo/Override.fs", "buckaroo/OverrideSourceExplorer.fs", "buckaroo/Prefetch.fs", "buckaroo/Solver.fs", "buckaroo/UpgradeCommand.fs", "buckaroo/buckaroo.fsproj" ]
[]
true
LoopPerfect/buckaroo
349
issue_to_patch
* Removes app as a valid name
2b63d9be7bb598a5ed229a8098f2ccd674ea42b9
da1255d9e07fde78b6c03b893a1082f5239003f0
diff --git a/buckaroo/QuickstartCommand.fs b/buckaroo/QuickstartCommand.fs index fa9a60d..b30b737 100644 --- a/buckaroo/QuickstartCommand.fs +++ b/buckaroo/QuickstartCommand.fs @@ -66,7 +66,8 @@ let private defaultMain = |> String.concat "\n" let isValidProjectName (candidate : string) = - (Regex(@"^[A-Za-z0-9\-...
[ "buckaroo/QuickstartCommand.fs" ]
[]
true
LoopPerfect/buckaroo
347
issue_to_patch
Switches to packaged result computation expression
* Switches to packaged result computation expression * Adds ionide files to gitignore
8d7d53656ebdc1ac0dc73b574f17026e900963d1
3aece084968e481e605f8659988ae64cdad0bae2
diff --git a/.gitignore b/.gitignore index 4de7f6e..668888d 100644 --- a/.gitignore +++ b/.gitignore @@ -14,6 +14,7 @@ .buckconfig.local fsi.fsx +/.ionide ## Ignore Visual Studio temporary files, build results, and ## files generated by popular Visual Studio add-ons. diff --git a/buckaroo/Lock.fs b/buckaroo/Loc...
[ ".gitignore", "buckaroo/Lock.fs", "buckaroo/Manifest.fs", "buckaroo/PackageLock.fs", "buckaroo/Result.fs", "buckaroo/buckaroo.fsproj" ]
[]
true
LoopPerfect/buckaroo
332
issue_to_patch
Feat/baobab solver
432ac62a140cf240fc7b568e5015d086f4c087eb
193a27b66e32d7793d17b09fcef01c2a074e4dcd
diff --git a/buckaroo-cli/Program.fs b/buckaroo-cli/Program.fs index d418ed1..c12d593 100644 --- a/buckaroo-cli/Program.fs +++ b/buckaroo-cli/Program.fs @@ -15,10 +15,10 @@ let main argv = let! exitCode = async { try match Buckaroo.Command.parse input with - | Result.Ok (command, loggingL...
[ "buckaroo-cli/Program.fs", "buckaroo-tests/Command.fs", "buckaroo-tests/Constraint.fs", "buckaroo-tests/Manifest.fs", "buckaroo-tests/Solver.fs", "buckaroo/AddCommand.fs", "buckaroo/Command.fs", "buckaroo/ConsoleManager.fs", "buckaroo/Constants.fs", "buckaroo/Constraint.fs", "buckaroo/DefaultSou...
[]
true
LoopPerfect/buckaroo
335
issue_to_patch
feat: implements cache first option for remoterefs fetching
`git ls-remote` is a slow operation. This PR adds the option `--cache-first` allowing the user to skip the syncing of the local cache with the remote if possible. This speeds-up resolution significantly (more than 10x) but may result in a set of packages that is not up-to-date
fc87666dd52a42f980e614110adae64c97c2cd40
e6f9b9ed16fa10442621d7937fa0e7d9a5900e5a
diff --git a/buckaroo-cli/Program.fs b/buckaroo-cli/Program.fs index d418ed1..c12d593 100644 --- a/buckaroo-cli/Program.fs +++ b/buckaroo-cli/Program.fs @@ -15,10 +15,10 @@ let main argv = let! exitCode = async { try match Buckaroo.Command.parse input with - | Result.Ok (command, loggingL...
[ "buckaroo-cli/Program.fs", "buckaroo-tests/Command.fs", "buckaroo-tests/Solver.fs", "buckaroo/Command.fs", "buckaroo/GitManager.fs", "buckaroo/Solver.fs", "buckaroo/Tasks.fs" ]
[ { "comment": "Remove", "path": "buckaroo-tests/Command.fs", "hunk": "@@ -15,41 +15,46 @@ let private ijkXyz = GitHub { Owner = \"ijk\"; Project = \"xyz\" }\n [<Fact>]\n let ``Command.parse works correctly`` () =\n let cases = [\n- (Result.Ok (Command.Init, defaultLoggingLevel), \"init\");\n+ (Re...
true
LoopPerfect/buckaroo
335
comment_to_fix
feat: implements cache first option for remoterefs fetching
Remove
fc87666dd52a42f980e614110adae64c97c2cd40
e6f9b9ed16fa10442621d7937fa0e7d9a5900e5a
diff --git a/buckaroo-tests/Command.fs b/buckaroo-tests/Command.fs index 0351926..a002f85 100644 --- a/buckaroo-tests/Command.fs +++ b/buckaroo-tests/Command.fs @@ -15,32 +15,37 @@ let private ijkXyz = GitHub { Owner = "ijk"; Project = "xyz" } [<Fact>] let ``Command.parse works correctly`` () = let cases = [ - ...
[ "buckaroo-tests/Command.fs" ]
[ { "comment": "Remove", "path": "buckaroo-tests/Command.fs", "hunk": "@@ -15,41 +15,46 @@ let private ijkXyz = GitHub { Owner = \"ijk\"; Project = \"xyz\" }\n [<Fact>]\n let ``Command.parse works correctly`` () =\n let cases = [\n- (Result.Ok (Command.Init, defaultLoggingLevel), \"init\");\n+ (Re...
true
LoopPerfect/buckaroo
335
comment_to_fix
feat: implements cache first option for remoterefs fetching
Code formatting
fc87666dd52a42f980e614110adae64c97c2cd40
e6f9b9ed16fa10442621d7937fa0e7d9a5900e5a
diff --git a/buckaroo/Command.fs b/buckaroo/Command.fs index 7e6c9c3..8f7d460 100644 --- a/buckaroo/Command.fs +++ b/buckaroo/Command.fs @@ -31,6 +31,13 @@ module Command = return Option.isSome maybeSkip } + let cacheFirstParser : Parser<bool, Unit> = parse { + let! cacheFirst = + CharParsers.skipStr...
[ "buckaroo/Command.fs" ]
[ { "comment": "Code formatting", "path": "buckaroo/Command.fs", "hunk": "@@ -170,13 +177,16 @@ module Command =\n \n do! CharParsers.spaces\n \n+ let! isCacheFirst = cacheFirstParser\n+ do! CharParsers.spaces\n let! isVerbose = verboseParser\n \n do! CharParsers.spaces\n \n let logg...
true
LoopPerfect/buckaroo
335
comment_to_fix
feat: implements cache first option for remoterefs fetching
Remove type annotation?
fc87666dd52a42f980e614110adae64c97c2cd40
e6f9b9ed16fa10442621d7937fa0e7d9a5900e5a
diff --git a/buckaroo/Tasks.fs b/buckaroo/Tasks.fs index 9cd0593..7f6d24b 100644 --- a/buckaroo/Tasks.fs +++ b/buckaroo/Tasks.fs @@ -30,7 +30,7 @@ let private getCachePath = async { | path -> path } -let getContext loggingLevel = async { +let getContext loggingLevel fetchStyle = async { let consoleManager = ...
[ "buckaroo/Tasks.fs" ]
[ { "comment": "Remove type annotation?", "path": "buckaroo/Tasks.fs", "hunk": "@@ -30,7 +30,7 @@ let private getCachePath = async {\n | path -> path\n }\n \n-let getContext loggingLevel = async {\n+let getContext loggingLevel (fetchStyle : FetchStyle) = async {", "resolving_sha": "e6f9b9ed16fa104...
true
LoopPerfect/buckaroo
334
issue_to_patch
Sorting, prefetcher
cc8d939f9c56ca5b1a467a66e6d56c844f9bbd4d
a1d5847a64fb2689ef361c67fc0e943184132b8e
diff --git a/buckaroo-tests/Constraint.fs b/buckaroo-tests/Constraint.fs index b4c1e4a..83bf32d 100644 --- a/buckaroo-tests/Constraint.fs +++ b/buckaroo-tests/Constraint.fs @@ -100,6 +100,7 @@ let ``Constraint.simplify works correctly`` () = ("any(all(revision=aabbccddee))", "revision=aabbccddee"); ("all(any(...
[ "buckaroo-tests/Constraint.fs", "buckaroo/Command.fs", "buckaroo/Constraint.fs", "buckaroo/DefaultSourceExplorer.fs", "buckaroo/Manifest.fs", "buckaroo/Prefetch.fs", "buckaroo/QuickstartCommand.fs", "buckaroo/ResolveCommand.fs", "buckaroo/SearchStrategy.fs", "buckaroo/Solver.fs", "buckaroo/Upgra...
[]
true
LoopPerfect/buckaroo
333
issue_to_patch
Error messages
fdaa8d2df0698d4803911855c61682f66d7633de
3f62d16c11e338b8cf1bf74a9de67abb8a8b1c1c
diff --git a/buckaroo-tests/Constraint.fs b/buckaroo-tests/Constraint.fs index 52c5645..b4c1e4a 100644 --- a/buckaroo-tests/Constraint.fs +++ b/buckaroo-tests/Constraint.fs @@ -16,9 +16,9 @@ let ``Constraint.parse works correctly`` () = ("*", Constraint.wildcard |> Some); ("revision=aabbccddee", Version.Git(G...
[ "buckaroo-tests/Constraint.fs", "buckaroo-tests/Solver.fs", "buckaroo/AddCommand.fs", "buckaroo/Command.fs", "buckaroo/ConsoleManager.fs", "buckaroo/Constants.fs", "buckaroo/Constraint.fs", "buckaroo/DefaultSourceExplorer.fs", "buckaroo/Dependency.fs", "buckaroo/GitCli.fs", "buckaroo/GitLabApi.f...
[]
true
LoopPerfect/buckaroo
330
issue_to_patch
fixes fetch commits and terminates exponential deepening if all commits fetched
In some cases we mistakenly perform a`git fetch origin <commithash>:<commithash>` which confuses git when you try to checkout <commithash> as then it does not know whether you mean the created ref or actual commit. Furthermore we always fetch upto 13 times in our deepening algorithm before we terminate the deepeni...
281b0fcbb04a0b4688ef64f53c93124d85f42313
0feac9784a825a05c48842d68c44e3b2b162e4fb
diff --git a/buckaroo/DefaultSourceExplorer.fs b/buckaroo/DefaultSourceExplorer.fs index 2e772c4..4a52439 100644 --- a/buckaroo/DefaultSourceExplorer.fs +++ b/buckaroo/DefaultSourceExplorer.fs @@ -101,7 +101,7 @@ type DefaultSourceExplorer (console : ConsoleManager, downloadManager : Download match maybeBranchRef ...
[ "buckaroo/DefaultSourceExplorer.fs", "buckaroo/GitCli.fs" ]
[]
true
LoopPerfect/buckaroo
327
issue_to_patch
* Reduces the size of the final bundle
947baa4ac8dee59838eeb4ef8d133c74688c4d6b
f2acd1998ba3ba81a2bc304c2812fd60a28b4dde
diff --git a/buckaroo-cli/buckaroo-cli.fsproj b/buckaroo-cli/buckaroo-cli.fsproj index 3032163..00c35ce 100644 --- a/buckaroo-cli/buckaroo-cli.fsproj +++ b/buckaroo-cli/buckaroo-cli.fsproj @@ -5,6 +5,8 @@ <TargetFramework>netcoreapp2.1</TargetFramework> <IsPackable>false</IsPackable> <CopyLocalLockFileAs...
[ "buckaroo-cli/buckaroo-cli.fsproj", "buckaroo/Archive.fs", "buckaroo/Constants.fs", "buckaroo/buckaroo.fsproj", "warp-bundle-linux.sh", "warp-bundle-macos.sh" ]
[]
true
LoopPerfect/buckaroo
326
issue_to_patch
* Fixes up paths for GitLab subgroups
b4bac8ec2fb6d104b3928daa1d26d4c623b02a6c
68e8898e457e3dbf98ff37a5951751909bec0d8c
diff --git a/buckaroo/InstallCommand.fs b/buckaroo/InstallCommand.fs index 1bb9f56..944eadf 100644 --- a/buckaroo/InstallCommand.fs +++ b/buckaroo/InstallCommand.fs @@ -145,6 +145,12 @@ let rec computeCellIdentifier (parents : PackageIdentifier list) (package : Pack | head::tail -> (computeCellIdentifier tail h...
[ "buckaroo/InstallCommand.fs" ]
[]
true
LoopPerfect/buckaroo
324
issue_to_patch
* Expands parser and data-structures for GitLab groups
bbd432855e841184b0d53980ea55a0fe9373f9b8
477c99e4e4e1f04f8980ecb21d9cfdad5499bd5b
diff --git a/buckaroo-tests/PackageIdentifier.fs b/buckaroo-tests/PackageIdentifier.fs index e20cf88..f1f437f 100644 --- a/buckaroo-tests/PackageIdentifier.fs +++ b/buckaroo-tests/PackageIdentifier.fs @@ -1,7 +1,6 @@ module Buckaroo.Tests.PackageIdentifier open Xunit - open Buckaroo [<Fact>] @@ -12,12 +11,17 @@...
[ "buckaroo-tests/PackageIdentifier.fs", "buckaroo/GitLabApi.fs", "buckaroo/InstallCommand.fs", "buckaroo/PackageIdentifier.fs", "buckaroo/PackageLocation.fs", "buckaroo/PackageLock.fs", "buckaroo/ResolvedVersion.fs", "buckaroo/RichOutput.fs" ]
[]
true
LoopPerfect/buckaroo
321
issue_to_patch
Feature/ide integration showcase
d7eaaca1f07fdd0ba2dde2cdf0b0762c772fcf71
664ccc04bab7e546cc7d6e87529c3cbfc7e07856
diff --git a/README.md b/README.md index 594c1b4..a280d1b 100644 --- a/README.md +++ b/README.md @@ -26,7 +26,23 @@ $ buckaroo add github.com/buckaroo-pm/boost-thread@branch=master $ buck run :my-app ``` -We have an [FAQ](https://github.com/LoopPerfect/buckaroo/wiki/FAQ). +We have an [FAQ](https://github.com/LoopP...
[ "README.md", "www/ides.png", "www/ides.svg", "www/registries.png", "www/registries.svg" ]
[]
true
LoopPerfect/buckaroo
320
issue_to_patch
* Fixes GitLab URLs
38d090f325449ac06a381b8a4eea6dfe546cc760
d41b6e0d108d5c1f30f39be264973b63bea47f2a
diff --git a/buckaroo/DefaultSourceExplorer.fs b/buckaroo/DefaultSourceExplorer.fs index 72ebe0e..2e772c4 100644 --- a/buckaroo/DefaultSourceExplorer.fs +++ b/buckaroo/DefaultSourceExplorer.fs @@ -142,6 +142,7 @@ type DefaultSourceExplorer (console : ConsoleManager, downloadManager : Download let fetchVersionsFrom...
[ "buckaroo/DefaultSourceExplorer.fs", "buckaroo/GitManager.fs" ]
[]
true
LoopPerfect/buckaroo
317
issue_to_patch
Fix/git fetch again
f03c572965fc1ddb55cf4d6b64afb53ddceb1afa
8a672612ee1161cd943a3c24661b7eaf3af107b7
diff --git a/buckaroo/Constants.fs b/buckaroo/Constants.fs index bc8fb41..ceb6457 100644 --- a/buckaroo/Constants.fs +++ b/buckaroo/Constants.fs @@ -1,7 +1,7 @@ module Buckaroo.Constants [<Literal>] -let Version = "2.0.0" +let Version = "2.0.2" [<Literal>] let PackagesDirectory = "buckaroo" diff --git a/buckaro...
[ "buckaroo/Constants.fs", "buckaroo/GitCli.fs" ]
[]
true
LoopPerfect/buckaroo
311
issue_to_patch
Create LICENSE
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- I...
ae6feeb64cf58074836f1635e5081248968dce18
72aedb28935670cc76623aa7a996d38e40f6d3b8
diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..acaafb3 --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2019 LoopPerfect + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to...
[ "LICENSE" ]
[]
true
LoopPerfect/buckaroo
310
issue_to_patch
Update DefaultSourceExplorer.fs
e7fd04fed47a1d51429df2f7fe6a1cbf1cb7e273
241be2c2643a6a4d5802ebf897bf1443476b8feb
diff --git a/buckaroo/DefaultSourceExplorer.fs b/buckaroo/DefaultSourceExplorer.fs index f7ac277..72ebe0e 100644 --- a/buckaroo/DefaultSourceExplorer.fs +++ b/buckaroo/DefaultSourceExplorer.fs @@ -150,6 +150,7 @@ type DefaultSourceExplorer (console : ConsoleManager, downloadManager : Download | (RefType.Tag, R...
[ "buckaroo/DefaultSourceExplorer.fs" ]
[]
true
LoopPerfect/buckaroo
306
issue_to_patch
feat: prefer git also on windows
20b8c626b8001109fdddde02085d7397023dee37
82fbad47d593d963ca91fc8d391776b6c7f19fa5
diff --git a/buckaroo-tests/Bash.fs b/buckaroo-tests/Bash.fs index 131ae2d..b8815f9 100644 --- a/buckaroo-tests/Bash.fs +++ b/buckaroo-tests/Bash.fs @@ -12,30 +12,30 @@ open System.Text #else // [<Fact>] -// let ``Bash.runBash works correctly`` () = +// let ``Bash.runBash works correctly`` () = // let stdout = ...
[ "buckaroo-tests/Bash.fs", "buckaroo/Tasks.fs" ]
[]
true
LoopPerfect/buckaroo
305
issue_to_patch
Ensure GitCli works for PowerShell and bash Perhaps call Git directly?
fix: process call git instead of bash
also fixes #303
e3847cecf07c2136b535734d2d270d2d5c5178aa
e91fc31e6861223f1d22c022c49b5932e8404484
diff --git a/buckaroo/Bash.fs b/buckaroo/Bash.fs index de3e2ba..a8902aa 100644 --- a/buckaroo/Bash.fs +++ b/buckaroo/Bash.fs @@ -17,13 +17,13 @@ let escapeBash (command : string) = raise <| new Exception("Malicious bash? " + command) command -let runBashSync (command : String) (stdoutHandler : ProgressCallbac...
[ "buckaroo/Bash.fs", "buckaroo/GitCli.fs" ]
[]
true
LoopPerfect/buckaroo
300
issue_to_patch
* Version now optional in add
41d7545d85e9a0dd4cc7f619b6190132eaca5473
0c226171677545d455659436f74878e2f20857cf
diff --git a/buckaroo-tests/Command.fs b/buckaroo-tests/Command.fs index 60e6f2b..0351926 100644 --- a/buckaroo-tests/Command.fs +++ b/buckaroo-tests/Command.fs @@ -29,6 +29,16 @@ let ``Command.parse works correctly`` () = (Result.Ok (Command.UpgradeDependencies [], verboseLoggingLevel), " upgrade --verbose ");...
[ "buckaroo-tests/Command.fs", "buckaroo/Command.fs" ]
[]
true