repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
MahApps/MahApps.Metro | 4,429 | issue_to_patch | Remove .NET Core 3.1 support | ## Describe the changes you have made to improve this project
- remove .NET Core 3.1 support
- update cake and cake script
- update package references
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the change is.
-->
## Unit test
<!-- If it's... | 221996ba181414de311c7550a774d83555631258 | 41f48d369f3deea68e2410737c1203d2ff3fd251 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 4903ba5f5b..8f3a4382f2 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"cake.tool": {
- "version": "1.3.0",
+ "version": "3.1.0",
"commands": [
... | [
".config/dotnet-tools.json",
".github/workflows/ci.yml",
"appveyor.yml",
"build.cake",
"src/Directory.Build.Props",
"src/Directory.Build.Targets",
"src/Directory.packages.props",
"src/Mahapps.Metro.Tests/MahApps.Metro.Tests.csproj",
"src/Mahapps.Metro.Tests/Tests/AnimatedTabControlTest.cs",
"src/M... | [] | diff --git a/src/Mahapps.Metro.Tests/Tests/AnimatedTabControlTest.cs b/src/Mahapps.Metro.Tests/Tests/AnimatedTabControlTest.cs
index ba2d4d4969..ae394fb7fb 100644
--- a/src/Mahapps.Metro.Tests/Tests/AnimatedTabControlTest.cs
+++ b/src/Mahapps.Metro.Tests/Tests/AnimatedTabControlTest.cs
@@ -19,7 +19,7 @@ public async Ta... | true | |
MahApps/MahApps.Metro | 4,403 | issue_to_patch | Color Canvas Background Color is not updated
## Describe the bug
Color Canvas Background Color is not updated when Saturation or Value or Both are 0.
## Steps to reproduce
1. Go to Mah.Apps Demo Application
2. Click on ColorPicker Tab
3. Set Saturation or Value or Both to 0.
4. Change Hue
5. Observe Color... | Fix HSV-Invalidation | ## Describe the changes you have made to improve this project
Fix an issue with `ColorPicker`, where `Hue` value was not updated in some cases
## Unit test
<!-- If it's possible then make a unit test for your changes. -->
## Additional context
<!-- Add any other context or screenshots about the feature r... | 3fce0224bcdc62112dabecbb3757a438559bf86e | 1c9f0a4288e3f0f2b2dfec97e1549841c6abe012 | diff --git a/src/MahApps.Metro/Controls/ColorPicker/ColorPickerBase.cs b/src/MahApps.Metro/Controls/ColorPicker/ColorPickerBase.cs
index bbb8918896..9c9a787ff8 100644
--- a/src/MahApps.Metro/Controls/ColorPicker/ColorPickerBase.cs
+++ b/src/MahApps.Metro/Controls/ColorPicker/ColorPickerBase.cs
@@ -280,6 +280,7 @@ priva... | [
"src/MahApps.Metro/Controls/ColorPicker/ColorPickerBase.cs"
] | [] | true | |
MahApps/MahApps.Metro | 4,396 | issue_to_patch | Updating ControlzEx and using padding as margin for window content | 317b9bc40cdb4b56591673c05d8323db7663d0ca | 93f9f80362a90273d897c386041716351eac9e54 | diff --git a/src/Directory.packages.props b/src/Directory.packages.props
index 7a7b28d75..3251c5e2b 100644
--- a/src/Directory.packages.props
+++ b/src/Directory.packages.props
@@ -4,7 +4,7 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<Item... | [
"src/Directory.packages.props",
"src/MahApps.Metro/Themes/MetroWindow.xaml"
] | [] | true | |||
MahApps/MahApps.Metro | 4,380 | issue_to_patch | [DEV] Wrong colour for mouse-over of the close button
## Describe the bug
Since https://github.com/MahApps/MahApps.Metro/commit/a521dafe5c525f95e8abd2089903e60df0dfab84, the style of the `MetroWindow` close button is no longer correct. Normally, this should be red for `IsMouseOver`, but this is currently not the ca... | Fixes #4379 by using NonClientControlProperties where required | ac945ce8a4cdc98867652a92325adedfe6cdf4a1 | ac324e1295c7a775dc175e43f0b37f06f1ad36c6 | diff --git a/src/MahApps.Metro/Styles/Clean/WindowButtons.xaml b/src/MahApps.Metro/Styles/Clean/WindowButtons.xaml
index 7ffd362304..f23ad0c4a0 100644
--- a/src/MahApps.Metro/Styles/Clean/WindowButtons.xaml
+++ b/src/MahApps.Metro/Styles/Clean/WindowButtons.xaml
@@ -1,5 +1,6 @@
<ResourceDictionary xmlns="http://schem... | [
"src/MahApps.Metro/Styles/Clean/WindowButtons.xaml",
"src/MahApps.Metro/Styles/Controls.Buttons.xaml"
] | [] | true | ||
MahApps/MahApps.Metro | 4,385 | issue_to_patch | Show Flyout topmost above BaseMetroDialog
It would be really cool, if the Flyouts are shown topmost above a BaseMetroDialog.
See gitter thread [here](https://gitter.im/MahApps/MahApps.Metro?at=627d6d1c14df4e44f220d8ec).
![image](https://user-images.githubusercontent.com/48946764/168292438-005f7efc-8989-4391-8239... | Flyout over dialogs | ## Describe the changes you have made to improve this project
Add new property `ShowFlyoutsOverDialogs`. With this property it's possible to show the Flyouts always over the Dialogs.
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the change is.
-->
... | 0f66bccf587a63279a4d536247f04559fdf2399f | d6f7c0f58e23de349456f13ada92c160186bb49f | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml
index 44b6ce971..9c0aaafc6 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml
+++ b/src/MahApps.Metro.Samples/MahAp... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml.cs",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindowViewModel.cs",
"src/MahApps.Metro/Controls/MetroWindow.cs",
"src/MahApps.Metro/Controls/Met... | [] | true | |
MahApps/MahApps.Metro | 4,384 | issue_to_patch | Remove methods to show an existing dialog externally | ## Describe the changes you have made to improve this project
This PR removes the methods to show an existing dialog externally:
- ShowDialogExternally<TDialog>
- ShowModalDialogExternally<TDialog>
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the ... | 75cd3b5f6fbfd40cdcfe858fde89c846fe01e481 | e3e4f5377fda6636a66b07039f4ef22f84d08e92 | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
index dfbf76c9b..0fccc39e6 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
+++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
@@ -209,7 +209,... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml.cs",
"src/MahApps.Metro/Controls/Dialogs/BaseMetroDialog.cs",
"src/MahApps.Metro/Controls/Dialogs/DialogManager.cs"
] | [] | true | ||
MahApps/MahApps.Metro | 4,383 | issue_to_patch | Reset window position from code
## Describe the feature
Hi @punker76,
is it possible to reset the window position (`SaveWindowPosition=true`) from the code?
I know i can delete the `user.config` in the `%localappdata%`, but a simple solution like `ResetPosition()` would be nice. Then i could implement a comman... | Allow to reset the window settings | ## Describe the changes you have made to improve this project
Add the `Reset` method to the `IWindowPlacementSettings` interface to allow reset the window settings.
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the change is.
-->
## Additional cont... | 6cf65e856b998b2257113f7d1d1669e3b56967f5 | f9edff619169a51466a4afb50eef400f3edb7084 | diff --git a/src/Directory.packages.props b/src/Directory.packages.props
index 088e7cc496..7a7b28d75b 100644
--- a/src/Directory.packages.props
+++ b/src/Directory.packages.props
@@ -15,7 +15,7 @@
</ItemGroup>
<ItemGroup Label="Build">
<PackageVersion Include="JetBrains.Annotations" Version="2022.3.1... | [
"src/Directory.packages.props",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/FlyoutDemo.xaml.cs",
"src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs",
"src/MahApps.Metro/Controls/MetroWindow.cs",
"src/MahApps.Metro/Controls/WinApiHelper.cs",
"src/MahApps.Metro/Controls/WindowSettings.c... | [] | true | |
MahApps/MahApps.Metro | 3,925 | issue_to_patch | Binding updates for buttons from TextBoxHelper.ButtonCommand
## Describe the feature
I would like the bindings to be updated when clicking on the buttons created by "TextBoxHelper.ButtonCommand".
## Additional context
Good afternoon,
i have a question about the behaviour of ButtonCommand in a textbox and t... | Update Binding before executing the command of "TextBoxHelper.ButtonCommand" | ## Describe the changes you have made to improve this project
Now an update of the binding is done before executing the command of "TextBoxHelper.ButtonCommand".
## Unit test
guess not
## Additional context
See #3924
## Closed Issues
#3924
| 698e4d6fcf81016b05405be13bf66a573057ce4f | 58497ad2a4b7635ee516e07843f604e30ff421b7 | diff --git a/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs b/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
index bc4deaaad7..ff9346af9c 100644
--- a/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
+++ b/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
@@ -892,6 +892,11 @@ public static void ButtonClicked... | [
"src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs"
] | [] | true | |
MahApps/MahApps.Metro | 4,247 | issue_to_patch | Fix changing DefaultButtonFocus for MessageDialog | ## Describe the changes you have made to improve this project
Fix DefaultButtonFocus error.
The DefaultButtonFocus is always Negative, can't change to the other, except MessageDialogStyle is Affirmative.
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of wh... | 17f51ef475452b92c2e248e047ec4de46a010ab2 | c93254b2267c7f19e55d0f382fa5ff81e577e5a4 | diff --git a/src/MahApps.Metro/Controls/Dialogs/MessageDialog.cs b/src/MahApps.Metro/Controls/Dialogs/MessageDialog.cs
index 1164b8495e..a4a5eeb966 100644
--- a/src/MahApps.Metro/Controls/Dialogs/MessageDialog.cs
+++ b/src/MahApps.Metro/Controls/Dialogs/MessageDialog.cs
@@ -169,19 +169,7 @@ internal MessageDialog(Metro... | [
"src/MahApps.Metro/Controls/Dialogs/MessageDialog.cs"
] | [] | true | ||
MahApps/MahApps.Metro | 4,264 | issue_to_patch | Added FallbackValue in XAML for Calendar control styles: | This is to address performance issues when templates & styles are loaded & unloaded from the visual tree - these warnings slow the UI from rendering and can cause animation to stutter - specifically the Calendar control in this case.
This only occur where a Template or Style (MahApps) uses a "{Binding}" without spec... | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "The FallbackValue should be True, because the default of the property is also True",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -102,9 +103,9 @@\n <!-- IsToday, IsTodayHighlighted and IsSelected -->\n <MultiDataT... | true | ||
MahApps/MahApps.Metro | 4,264 | comment_to_fix | Added FallbackValue in XAML for Calendar control styles: | The FallbackValue should be True, because the default of the property is also True | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "The FallbackValue should be True, because the default of the property is also True",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -102,9 +103,9 @@\n <!-- IsToday, IsTodayHighlighted and IsSelected -->\n <MultiDataT... | true | ||
MahApps/MahApps.Metro | 4,264 | comment_to_fix | Added FallbackValue in XAML for Calendar control styles: | The FallbackValue should be True, because the default of the property is also True | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "The FallbackValue should be True, because the default of the property is also True",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -114,8 +115,8 @@\n <!-- IsToday and IsTodayHighlighted -->\n <MultiDataTrigger>\n ... | true | ||
MahApps/MahApps.Metro | 4,264 | comment_to_fix | Added FallbackValue in XAML for Calendar control styles: | I don't think that we need this here, because it's a normal Binding. | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "I don't think that we need this here, because it's a normal Binding.",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -291,7 +292,7 @@\n FontWeight=\"Bold\"\n Foreground=\"{DynamicResource... | true | ||
MahApps/MahApps.Metro | 4,264 | comment_to_fix | Added FallbackValue in XAML for Calendar control styles: | The FallbackValue should be CalendarMode.Month because it's the default of the DisplayMode property | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "The FallbackValue should be CalendarMode.Month because it's the default of the DisplayMode property",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -394,11 +395,11 @@\n <Trigger Property=\"IsEnabled\" Value=\"False\">\n ... | true | ||
MahApps/MahApps.Metro | 4,264 | comment_to_fix | Added FallbackValue in XAML for Calendar control styles: | The FallbackValue should be CalendarMode.Month because it's the default of the DisplayMode property | fbaad878a84a38f7eecf0926869ef384db8754b8 | 1a3e4dd48344664e00a4b8e57c35b45e471c3876 | diff --git a/src/MahApps.Metro/Styles/Controls.Calendar.xaml b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
index 9e57442294..cd606b1215 100644
--- a/src/MahApps.Metro/Styles/Controls.Calendar.xaml
+++ b/src/MahApps.Metro/Styles/Controls.Calendar.xaml
@@ -1,9 +1,10 @@
<ResourceDictionary xmlns="http://schemas.micr... | [
"src/MahApps.Metro/Styles/Controls.Calendar.xaml"
] | [
{
"comment": "The FallbackValue should be CalendarMode.Month because it's the default of the DisplayMode property",
"path": "src/MahApps.Metro/Styles/Controls.Calendar.xaml",
"hunk": "@@ -394,11 +395,11 @@\n <Trigger Property=\"IsEnabled\" Value=\"False\">\n ... | true | ||
MahApps/MahApps.Metro | 4,025 | issue_to_patch | Keep SelectedItemProperty Binding for ClearTextButton in ComboBox | Use the SetCurrentValue method to prevent the binding from being released.
| 865121020a352089cf23631351385fab89ef3436 | 33f45ae1ab90f9ce0c722b0902108b8118d61ec3 | diff --git a/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs b/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
index e27211a1ce..d4f3cda5cf 100644
--- a/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
+++ b/src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs
@@ -931,11 +931,11 @@ public static void ButtonClicke... | [
"src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs"
] | [] | true | ||
MahApps/MahApps.Metro | 3,917 | issue_to_patch | [RFC] Updates the MahApps example list | ## Describe the changes you have made to improve this project
This pull request adds [WinReform](https://github.com/AKruimink/WinReform) to the list of example application that use MahApps Metro (2.0.0).
Having developed multiple application using MahApps, using both the old 1.6 as well as the new 2.0 release, i kn... | 698e4d6fcf81016b05405be13bf66a573057ce4f | 33fe4962050a539043c7a2c4e5db037ea543ed13 | diff --git a/readme.md b/readme.md
index aa95f12922..85e36adbd2 100644
--- a/readme.md
+++ b/readme.md
@@ -143,6 +143,7 @@ Does your company use MahApps.Metro? Ask your manager or marketing team if your
* [Papercut](https://github.com/jaben/papercut) by [@Jaben](https://github.com/Jaben) Simple Desktop SMTP Server / ... | [
"readme.md"
] | [] | true | ||
MahApps/MahApps.Metro | 4,376 | issue_to_patch | MultiSelectionComboBox looks like it's disabled in dark mode.
To get the same background look as a normal ComboBox i use mah:ControlsHelper.DisabledVisualElementVisibility="Collapsed"
like so below. I guess it's just a hack. just trying to point you in the direction where the bug may be.
```
<mah:MultiSelectionC... | fix for GH #4375 | ## Describe the changes you have made to improve this project
Fix #4375
## Unit test
None
## Additional context
None
## Closed Issues
Fixes #4375
| 2818c8a7114c0d386d0191f85f0bf68953bff753 | 7d2e92f2f0216cbef5d66862ad98e6b57d1b1d54 | diff --git a/src/MahApps.Metro/Controls/Helper/ControlsHelper.cs b/src/MahApps.Metro/Controls/Helper/ControlsHelper.cs
index 6ef7d93ca6..40b87aa389 100644
--- a/src/MahApps.Metro/Controls/Helper/ControlsHelper.cs
+++ b/src/MahApps.Metro/Controls/Helper/ControlsHelper.cs
@@ -30,6 +30,7 @@ public static readonly Dependen... | [
"src/MahApps.Metro/Controls/Helper/ControlsHelper.cs",
"src/MahApps.Metro/Themes/MultiSelectionComboBox.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,263 | issue_to_patch | Show shadow effect if ToolTip.HasDropShadow is set to true | Added the ability to set HasDropShadow for ToolTips.
Adds new effect and color:
- `MahApps.DropShadowEffect.ToolTip`
- `MahApps.Colors.ToolTipShadow` | 1429280fb06ca3a88a49a333acbea2c8bce32a17 | 453de6b686445a4ac4d9c1a46a9835e468e52d5a | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/MultiSelectionComboBoxExample.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/MultiSelectionComboBoxExample.xaml
index e00f77959b..9536f538fc 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/MultiSelectionCombo... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/MultiSelectionComboBoxExample.xaml",
"src/MahApps.Metro/Styles/Controls.Shadows.xaml",
"src/MahApps.Metro/Styles/Controls.Tooltip.xaml",
"src/MahApps.Metro/Styles/Themes/GeneratorParameters.json",
"src/MahApps.Metro/Styles/Themes/Theme.Template.xaml... | [] | true | ||
MahApps/MahApps.Metro | 4,076 | issue_to_patch | Running Window in another Thread results in a crash
After updating to 2.4.4 form 2.4.3 following code stopped working:
public partial class App : Application
{
protected override void OnStartup(StartupEventArgs e)
{
ShutdownMode = ShutdownMode.OnExplicitShutdown;
... | Fixed issue #4072 | ## Describe the changes you have made to improve this project
After upgrading to version 2.4.4 I've noticed a change which prevents you from creating a window I a different thread. This will fix this issue. by adding an additional Dispatcher.Invoke call.
## Closed Issues
Closes #4072
| cab7d25670fddd30314e189741d947214e4a8790 | 3f8c6f86c36a9aabef963a51c612c66a5413e941 | diff --git a/src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs b/src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs
index d144e11e6d..c9bf1edb1a 100644
--- a/src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs
+++ b/src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs
@@ -46,15 +46,14 @@ private void Associat... | [
"src/MahApps.Metro/Behaviors/WindowsSettingBehavior.cs",
"src/MahApps.Metro/Controls/Extensions.cs"
] | [] | true | |
MahApps/MahApps.Metro | 3,970 | issue_to_patch | Memory leak in MahApps.Templates.ValidationError
## Describe the bug
There is a minor memory leak with the default validation error template ([MahApps.Templates.ValidationError](https://github.com/MahApps/MahApps.Metro/blob/091132933e1db9dd38acae1737b8fd2589d060e9/src/MahApps.Metro/Styles/Controls.ValidationError.... | Changing the binding for ValidationError.ErrorContent to mode=OneTime… | ## Describe the changes you have made to improve this project
Updated the binding for the default validation error template (MahApps.Templates.ValidationError): the binding mode is set to OneTime, as the underlying object (System.Windows.Controls.ValidationError) does not implement `INotifyPropertyChanged `(avoid me... | 2ab3d8c5f012548e27e84e3093e206f0581b6aef | 95c81612bde4030c166cd457c53e590b6d540033 | diff --git a/src/MahApps.Metro/Styles/Controls.ValidationError.xaml b/src/MahApps.Metro/Styles/Controls.ValidationError.xaml
index c2ca7665fb..318fc0463d 100644
--- a/src/MahApps.Metro/Styles/Controls.ValidationError.xaml
+++ b/src/MahApps.Metro/Styles/Controls.ValidationError.xaml
@@ -112,7 +112,7 @@
... | [
"src/MahApps.Metro/Styles/Controls.ValidationError.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,364 | issue_to_patch | MultiSelectionComboBox item duplicating
## Describe the bug
When selected only one item it is added two times to bound collection
## Steps to reproduce
1. Open MahApps demo
2. Select one item in MultiSelectionComboBox
## Expected behavior
One item added
## Actual behavior
Two items added
## En... | fix: #4363 MultiSelectionComboBox item duplicating | ## Closed Issues
Closes #4363
| 6bce9f8733318a7f1f50ff112f834e917e766ae8 | ff8dd9a665125b9cc5cf0817ecc2bdd38a4ee663 | diff --git a/src/MahApps.Metro/Controls/MultiSelectionComboBox/MultiSelectionComboBox.cs b/src/MahApps.Metro/Controls/MultiSelectionComboBox/MultiSelectionComboBox.cs
index 87be18d0e1..0df7bb3a94 100644
--- a/src/MahApps.Metro/Controls/MultiSelectionComboBox/MultiSelectionComboBox.cs
+++ b/src/MahApps.Metro/Controls/Mu... | [
"src/MahApps.Metro/Controls/MultiSelectionComboBox/MultiSelectionComboBox.cs"
] | [] | true | |
MahApps/MahApps.Metro | 4,090 | issue_to_patch | NumericUpDown must set minimum on value deleting
**Describe the bug**
If the minimum value is set, then when deleting the contents (Delete or Backspace button), the minimum value must be set. Instead, a conversion error is displayed.
The problem is observed when using mvvm
**To Reproduce**
See demo-project
**... | Implement `DefaultValue` to the `NumericUpDown`-Control | ## Describe the changes you have made to improve this project
Implemented a new Property `DefaultValue` which will be used if the `Value` is `null`. This will also prevent errors for non-nullable values if set.
## Unit test
Implemented some basic tests which worked fine so far.
Test-Overview:
```c#
MahApps.M... | 077161c41be0e74f81a0ad150a12495bd8b2237d | 2867abea70c460efc74e10ee8c30a5cfdd1ca0ec | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
index cac99344a6..f73cee2ac2 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
+++ b/src/MahApps.Metro.Samples/Mah... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindowViewModel.cs",
"src/MahApps.Metro/Controls/NumericUpDown.cs",
"src/Mahapps.Metro.Tests/Tests/NumericUpDownTests.cs"
] | [] | diff --git a/src/Mahapps.Metro.Tests/Tests/NumericUpDownTests.cs b/src/Mahapps.Metro.Tests/Tests/NumericUpDownTests.cs
index 59836ca1ae..1f0315d9c4 100644
--- a/src/Mahapps.Metro.Tests/Tests/NumericUpDownTests.cs
+++ b/src/Mahapps.Metro.Tests/Tests/NumericUpDownTests.cs
@@ -331,5 +331,45 @@ private static void SetText(... | true |
MahApps/MahApps.Metro | 3,914 | issue_to_patch | DataGridNumericUpDownColumn DecimalPointCorrection
## Describe the feature
The DataGridNumericUpDownColumn control is missing the DecimalPointCorrection option like the NumericUpDown control | Add DecimalPointCorrection property to DataGridNumericUpDownColumn | ## Describe the changes you have made to improve this project
Add a missing DecimalPointCorrection property to DataGridNumericUpDownColumn
## Closed Issues
Closes #3903
| 698e4d6fcf81016b05405be13bf66a573057ce4f | 3e59934e9d30341088b67db5750cd584cf081829 | diff --git a/src/MahApps.Metro/Controls/DataGridNumericUpDownColumn.cs b/src/MahApps.Metro/Controls/DataGridNumericUpDownColumn.cs
index 06a7b36d26..0b34fc38b2 100644
--- a/src/MahApps.Metro/Controls/DataGridNumericUpDownColumn.cs
+++ b/src/MahApps.Metro/Controls/DataGridNumericUpDownColumn.cs
@@ -128,6 +128,7 @@ priva... | [
"src/MahApps.Metro/Controls/DataGridNumericUpDownColumn.cs"
] | [] | true | |
MahApps/MahApps.Metro | 4,188 | issue_to_patch | Update readme.md | Hello,
I improved the spelling within the README.
Great project! Keep up the good work!
Peace and Love. | 8df76144430605ce7a12a207ad0ab92a2c449dfd | a3e96e36ef294580cc7daa5ef14103351e9f6b32 | diff --git a/readme.md b/readme.md
index 4715633aa1..48c7e66169 100644
--- a/readme.md
+++ b/readme.md
@@ -114,7 +114,7 @@ Thanks to all the great people who have already contributed to the project!
This framework is free and can be used for free, open source and commercial applications. MahApps.Metro (all code, NuG... | [
"readme.md"
] | [] | true | ||
MahApps/MahApps.Metro | 4,354 | issue_to_patch | Allow arbitrary content for metro dialog.
## Describe the feature
Right now (version 2.4.9) the `BaseMetroDialog` has a `Title` property that is of type string. I would prefer if the dialog allowed arbitrary content to allow for putting more (in my case an icon plus some text). For now my work around is to skip usi... | Adding the ability for the dialog title to contain arbitrary content | Fixes #4350 | 135e84c658a264ad3de971c1d2c9931fcfb6560a | 06385f1cd7533a1b139b92755a12539ed23edcba | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
index 84a25b077a..ba692b2041 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
+++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
@@ -1,13 +1,1... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml",
"src/MahApps.Metro/Automation/Peers/MetroDialogAutomationPeer.cs",
"src/MahApps.Metro/Controls/Dialogs/BaseMetroDialog.cs",
"src/MahApps.Metro/Controls/Dialogs/DialogManager.cs",
"src/MahApps.Metro/Controls/Dialogs/ProgressDialogController.cs",... | [] | diff --git a/src/Mahapps.Metro.Tests/Tests/CustomDialogTest.cs b/src/Mahapps.Metro.Tests/Tests/CustomDialogTest.cs
index dd14da0895..6c5eada4f9 100644
--- a/src/Mahapps.Metro.Tests/Tests/CustomDialogTest.cs
+++ b/src/Mahapps.Metro.Tests/Tests/CustomDialogTest.cs
@@ -2,6 +2,7 @@
// The .NET Foundation licenses this fil... | true |
MahApps/MahApps.Metro | 4,353 | issue_to_patch | Updating some dependencies | This PR updates some dependencies and fixes the code that didn't compile afterwards. | 8d46a8a8447085887703f0ab0ecae4ad95ec9289 | e084a8c6c20509a34f9b0ac62a5d16cd957d8794 | diff --git a/src/Directory.Build.Props b/src/Directory.Build.Props
index fc2921d531..71981b5cef 100644
--- a/src/Directory.Build.Props
+++ b/src/Directory.Build.Props
@@ -22,8 +22,8 @@
<!-- Add the references for all projects and targets -->
<ItemGroup>
- <PackageReference Include="JetBrains.Annotati... | [
"src/Directory.Build.Props",
"src/MahApps.Metro/Controls/CustomValidationPopup.cs",
"src/MahApps.Metro/Controls/WindowSettings.cs",
"src/MahApps.Metro/MahApps.Metro.csproj",
"src/MahApps.Metro/NativeMethods.txt"
] | [] | true | ||
MahApps/MahApps.Metro | 4,300 | issue_to_patch | MetroWindow not detectable by applications as Screen2Gif and WinSnap
## Describe the bug
For some reason, a `MetroWindow` isn't seen as a Window by applications like Screen2Gif and WinSnap.
## Steps to reproduce
1. Install WinSnap or Screen2Gif
2. Try to record the window (Screen2Gif) or take a screenshot of... | Update ControlzEx to version 6.0 | This PR updates ControlzEx to version 6.0.
Because of this i also added a dependency to CSWin32 as ControlzEx does no longer expose any win32 APIs. | 05906a202087db16757411e2438022d9f32278c5 | 32e04300b0ceb52b858d8bc94539fe0958e43b9c | diff --git a/src/Directory.Build.Targets b/src/Directory.Build.Targets
index 78f7c55a09..0d92292e43 100644
--- a/src/Directory.Build.Targets
+++ b/src/Directory.Build.Targets
@@ -18,4 +18,14 @@
<Page Update="@(Page)" SubType="Designer" Generator="MSBuild:Compile" />
</ItemGroup>
+ <Target Name="Remov... | [
"src/Directory.Build.Targets",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/SizeToContentDemo.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.De... | [] | true | |
MahApps/MahApps.Metro | 4,343 | issue_to_patch | Updating ControlzEx | Update ControlzEx to the latest preview | 8f28aba44d5ce661b4b982ce1f44ff6b2b71e61e | ef24e718e25b55b54be7203620636e876dcbb18f | diff --git a/src/MahApps.Metro/MahApps.Metro.csproj b/src/MahApps.Metro/MahApps.Metro.csproj
index 6cbf434f8f..649f3efba3 100644
--- a/src/MahApps.Metro/MahApps.Metro.csproj
+++ b/src/MahApps.Metro/MahApps.Metro.csproj
@@ -23,7 +23,7 @@
</PropertyGroup>
<ItemGroup>
- <PackageReference Include="Contro... | [
"src/MahApps.Metro/MahApps.Metro.csproj"
] | [] | true | ||
MahApps/MahApps.Metro | 4,335 | issue_to_patch | docs: fix description of FolderSecurityViewer in readme | ## Describe the changes you have made to improve this project
Fix description of FolderSecurityViewer in readme.md
## Unit test
<!-- If it's possible then make a unit test for your changes. -->
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
## Close... | 7202fa85345f012d007ffd6df6106c4557ab83f8 | 12bb438ac5237dd72c1905096107ebed7f6894a3 | diff --git a/readme.md b/readme.md
index bb7352ac85..f44a708bfb 100644
--- a/readme.md
+++ b/readme.md
@@ -114,8 +114,7 @@ A big virtual hug :hugs: goes to all the great people around the world who contr
* [Certify The Web](https://github.com/webprofusion/certify) by [@webprofusion](https://github.com/webprofusion) Th... | [
"readme.md"
] | [] | true | ||
MahApps/MahApps.Metro | 4,332 | issue_to_patch | Square Button light theme disabled status is too subtle to notice...
I have a button which is styled with MahApps (Current 2.5.0 pre-release ?.. latest from GIT)
It's bound to a Command which IS functional - I have confirmed that the CanExecute is correctly returning false AND i've confirmed that the button can't b... | Improve Square button disabled style | ## Describe the changes you have made to improve this project
Improve square button disabled style.
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the change is.
-->
## Additional context
BREAKING CHANGE: remove old unused MetroSquare button st... | 70fb2b7210aee4f5b9ba750e277740d6dac0e9eb | 749c800a159fb712030d404d8ae511b2be4def69 | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml
index 45667532f4..f4afc4b04c 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml
+++ b/src/MahApps.Metro.Sampl... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml",
"src/MahApps.Metro/Styles/Controls.Buttons.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,323 | issue_to_patch | Remove the IsWaitingForData attached property | ## Describe the changes you have made to improve this project
BREAKING CHANGE: remove the IsWaitingForData attached property
Remove the IsWaitingForData attached property and all associated styles and effects.
The "mandatory" visual can be used with the WPF validation rules, so this extra attached property can... | 12d64a6905ff00d6d9cbcac3504acb42e08d439e | 296065013f184a8dc1fe8a61d650d996b488cb38 | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
index 91b3c8e5c9..895a996b89 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
+++ b/src/MahApps.Metro.Samples/Mah... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleWindows/CleanWindowDemo.xaml",
"src/MahApps.Metro/Controls/Helper/TextBoxHelper.cs",
"src/MahApps.Metro/Styles/Controls.PasswordBox.xaml",
"src/MahApps.Metro/Styles/Controls.Sh... | [] | true | ||
MahApps/MahApps.Metro | 4,087 | issue_to_patch | Bug at TimePicker when IsClockVisible="False"
<p>When I use TimePicker and want to get rid of the clock by using IsClockVisible="False".
TimePicker is not working at all.</p>
<i>Just create TimePicker:</i>
<mah:TimePicker IsClockVisible="False" Width="120" Height="22"/>
<i>Expected result:</i>
TimePicker shou... | Fix bug #4083 | Setting IsClockVisible=false on the TimePicker should not hide the HoursMinutesSeconds picker. Only the clock should be hidden
Closes #4083
| d38b21d0f8d1f2673f30dd8e15c62b3c1366c874 | a0933446e90125a937c5e00aa88b3340a03f4dfb | diff --git a/src/MahApps.Metro/Themes/DateTimePicker.xaml b/src/MahApps.Metro/Themes/DateTimePicker.xaml
index 983720d3ed..1e630079fe 100644
--- a/src/MahApps.Metro/Themes/DateTimePicker.xaml
+++ b/src/MahApps.Metro/Themes/DateTimePicker.xaml
@@ -441,7 +441,6 @@
<Trigger Property="IsClockVisi... | [
"src/MahApps.Metro/Themes/DateTimePicker.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,319 | issue_to_patch | Value binding to NumericUpDown.Value bleeds into another instance of NumericUpDown within the same TabControl
When I have a collection of view models of identical type bound to the `ItemsSource` of a `TabControl` and a numeric value within each such view model is bound to the `Value` of a `NumericUpDown,` changes made... | Don't change NUD value on lost focus event (because of binding problems) | ## Describe the changes you have made to improve this project
The NUD has a strange behavior if it's located inside a TabItem and the value is bound to a MVVM property which is used then in all TabItems (via DataTemplate).
So updating the value from the textbox is not a good way. Instead it should only update the... | c1992b0538941d737e2e3a2abdd738554f855e55 | 53f7e5aa78080bf6d166eab8d4db5b63e4e175cb | diff --git a/src/MahApps.Metro/Controls/Helper/MahAppsCommands.cs b/src/MahApps.Metro/Controls/Helper/MahAppsCommands.cs
index 3375a03b35..5346a6f4f6 100644
--- a/src/MahApps.Metro/Controls/Helper/MahAppsCommands.cs
+++ b/src/MahApps.Metro/Controls/Helper/MahAppsCommands.cs
@@ -77,7 +77,7 @@ public static void ClearCon... | [
"src/MahApps.Metro/Controls/Helper/MahAppsCommands.cs",
"src/MahApps.Metro/Controls/NumericUpDown.cs"
] | [] | true | |
MahApps/MahApps.Metro | 4,317 | issue_to_patch | Slider (Win 10 Default Style) Thumb Height
I'm trying to change the height of the slider's thumb, but I'm only able to change the older style's thumb so far. Any help / suggestions welcome. Thanks. | Allow set the thumb height of the Win10 slider style | ## Describe the changes you have made to improve this project
Add new double values to allow set the thumb size:
- MahApps.Sizes.Slider.HorizontalThumb.Height.Win10 = 24
- MahApps.Sizes.Slider.HorizontalThumb.Width.Win10 = 8
- MahApps.Sizes.Slider.VerticalThumb.Width.Win10 = 24
- MahApps.Sizes.Slider.VerticalT... | 70959ceaac66dfa2bd408e247a5658456b223c72 | 2031a48e066138c51ac05d1068c096e75c75c2fd | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
index e3629f37c0..d4e5165bf3 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
+++ b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml
@@ -96,13 +96... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/MainWindow.xaml",
"src/MahApps.Metro/Styles/Controls.Slider.xaml",
"src/MahApps.Metro/Themes/RangeSlider.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,316 | issue_to_patch | Allow set the corner radius of a ListBoxItem
Why mahapps Styles. The border in ListBoxItem style is not bound to controlshelper CornerRadius attached property? | feat: #4288 allow set the corner radius of a ListBoxItem | ## Describe the changes you have made to improve this project
Add also new attached properties to ItemHelper to set the different border brush states
- ActiveSelectionBorderBrush
- SelectedBorderBrush
- HoverBorderBrush
- HoverSelectedBorderBrush
- DisabledSelectedBorderBrush
- DisabledBorderBrush
- MouseLe... | c8f6f20c1cfb3f204773087502796b23d91349cc | a30a4cf8826d8edcbc714762739e415eff99a883 | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/SelectionExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/SelectionExamples.xaml
index eb26244c4a..f147279d78 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/SelectionExamples.xaml
+++ b/src/MahApps.Me... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/SelectionExamples.xaml",
"src/MahApps.Metro/Controls/Helper/ItemHelper.cs",
"src/MahApps.Metro/Styles/Controls.Buttons.xaml",
"src/MahApps.Metro/Styles/Controls.ListBox.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,315 | issue_to_patch | Flat button style is theme-agnostic
**Is your feature request related to a problem? Please describe.**
The current flat button style is theme-agnostic. In Windows 10, these flat buttons style based on the selected theme. For those designing apps more in line with Win10, it would be nice to see a themed flat button st... | Add new flat button and Win10 button styles | ## Describe the changes you have made to improve this project
This PR adds new button styles.
- new style MahApps.Styles.Button.Win10
- new style MahApps.Styles.Button.Accent.Win10
- new style MahApps.Styles.Button.Flat.Accent
There are also new brushes for the new styles.
- MahApps.Brushes.Button.Backgro... | 1b4fb007f382045a7de73988d3e78ee38a79799f | d45144a52ff95176589fedec8d9818729d8ba4ea | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml
index c883ece144..45667532f4 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml
+++ b/src/MahApps.Metro.Sampl... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/ButtonsExample.xaml",
"src/MahApps.Metro/Styles/Controls.Buttons.xaml",
"src/MahApps.Metro/Styles/Fonts.xaml",
"src/MahApps.Metro/Styles/Themes/Theme.Template.xaml"
] | [] | true | |
MahApps/MahApps.Metro | 4,313 | issue_to_patch | Enhance TextBoxHelper.ClearTextButton to Esc Key as well
## What steps will reproduce this issue?
No real issue, it would be just a nice addition to have the `TextBoxHelper.ClearTextButton` to also trigger a `Clear` by hitting the `Esc` key, or another boolean configuration flag to signal this intent.
### Expected ou... | Add clear/custom button command to all input controls | ## Describe the changes you have made to improve this project
Add clear/custom button command to all input controls and use the ClearControlCommand.
- RichTextBox
- TextBox
- ComboBox
- DatePicker
- DateTimePicker
- PasswordBox
- MultiSelectionComboBox
- ColorPicker
- NumericUpDown
- HotKeyBox
<!--
I... | a55904686c92dba115090e15fc4119be9b069a33 | ec7f897b3da575ba9b86f181ec8682f53286473e | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/DateExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/DateExamples.xaml
index 576242aa0b..a7206ce82f 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/DateExamples.xaml
+++ b/src/MahApps.Metro.Samples/Mah... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/DateExamples.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/MultiSelectionComboBoxExample.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/SelectionExamples.xaml",
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/Examp... | [] | diff --git a/src/Mahapps.Metro.Tests/Tests/HeaderedControlHelperTests.cs b/src/Mahapps.Metro.Tests/Tests/HeaderedControlHelperTests.cs
index 42e524ec03..1fdf24e6a9 100644
--- a/src/Mahapps.Metro.Tests/Tests/HeaderedControlHelperTests.cs
+++ b/src/Mahapps.Metro.Tests/Tests/HeaderedControlHelperTests.cs
@@ -33,19 +33,19 ... | true |
MahApps/MahApps.Metro | 4,312 | issue_to_patch | Move RichTextBox style to it's own resource file | ## Describe the changes you have made to improve this project
BREAKING CHANGE: move RichTextBox style to it's own resource file
<!--
Is your feature request related to a problem? Please describe.
A clear and concise description of what the change is.
-->
| cd7a85fadd43fa5f8328dfb8653f3ab663466247 | e1add5006f7e4f701641a974639e13df4f69c68e | diff --git a/src/MahApps.Metro/Styles/Controls.RichTextBox.xaml b/src/MahApps.Metro/Styles/Controls.RichTextBox.xaml
new file mode 100644
index 0000000000..22dc0516c2
--- /dev/null
+++ b/src/MahApps.Metro/Styles/Controls.RichTextBox.xaml
@@ -0,0 +1,502 @@
+<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/... | [
"src/MahApps.Metro/Styles/Controls.RichTextBox.xaml",
"src/MahApps.Metro/Styles/Controls.TextBox.xaml",
"src/MahApps.Metro/Styles/Controls.xaml"
] | [] | true | ||
MahApps/MahApps.Metro | 4,310 | issue_to_patch | RichTextBox superfluous scrollbar
## Describe the bug
MahApps causes a scrollbar to appear for RichTextBox.
## Steps to reproduce
* Create a new WPF project.
* Paste this in the main window:
```
<RichTextBox
HorizontalScrollBarVisibility="Auto">
<FlowDocument>
<Parag... | Fix scrolling and width of RichTextBox | ## Describe the changes you have made to improve this project
Remove the workaround for Documents PageWidth. The main problem here is that a RichTextBox inside a ScrollViewer with horizontal scrolling is still broken. The RichTextBox will wrap the text after each letter.
To solve this the ScrollViewer binds now t... | 0d15780047abf9014c5125abfc6de01a7174cbc0 | 22cd16e12f1593d23c6f9f1dee41bdda0aefd8b2 | diff --git a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml b/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
index ec1f1c7671..86a2ef62aa 100644
--- a/src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml
+++ b/src/MahApps.Metro.Samples/Mah... | [
"src/MahApps.Metro.Samples/MahApps.Metro.Demo/ExampleViews/TextExamples.xaml",
"src/MahApps.Metro/Controls/Helper/ScrollViewerHelper.cs",
"src/MahApps.Metro/Styles/Controls.ComboBox.xaml",
"src/MahApps.Metro/Styles/Controls.DatePicker.xaml",
"src/MahApps.Metro/Styles/Controls.PasswordBox.xaml",
"src/MahAp... | [] | true | |
MahApps/MahApps.Metro | 4,296 | issue_to_patch | Updated readme with some additional examples | ## Describe the changes you have made to improve this project
I have added a couple of projects of mine that use MahApps to the Examples section of the readme
## Unit test
N/A
## Additional context
N/A
## Closed Issues
N/A
| 01e5e1d39aefcb9658d5493937241df02544a610 | 75afb52cf8c8605127291b41d18e971121bf2a46 | diff --git a/readme.md b/readme.md
index f905995688..14c0e16d16 100644
--- a/readme.md
+++ b/readme.md
@@ -145,8 +145,10 @@ Does your company use MahApps.Metro? Ask your manager or marketing team if your
* [myEcho](http://myechoapp.com/) iOS Dictation for Windows
* [NETworkManager](https://github.com/BornToBeRoot/NE... | [
"readme.md"
] | [] | true | ||
MahApps/MahApps.Metro | 4,272 | issue_to_patch | Allow changing the ListView grid header reorder indicator brush | ## Describe the changes you have made to improve this project
The column reorder indicator of the `GridViewHeaderRowPresenter` is hard coded and can not easily change by the user. Especially the brush of the inner border can not be changed.
So we added a new attached property to the `ItemHelper` called `GridViewH... | 9ab2a9ad4caaaf565f00314b08c8c26374bb0dce | ddeb8496049874a7267181d0e4caed08e62aa74b | diff --git a/src/MahApps.Metro/Controls/GridViewHeaderRowPresenterEx.cs b/src/MahApps.Metro/Controls/GridViewHeaderRowPresenterEx.cs
new file mode 100644
index 0000000000..c132153d0e
--- /dev/null
+++ b/src/MahApps.Metro/Controls/GridViewHeaderRowPresenterEx.cs
@@ -0,0 +1,61 @@
+// Licensed to the .NET Foundation under... | [
"src/MahApps.Metro/Controls/GridViewHeaderRowPresenterEx.cs",
"src/MahApps.Metro/Controls/Helper/ItemHelper.cs",
"src/MahApps.Metro/Styles/Controls.ListView.xaml"
] | [] | true | ||
MahApps/MahApps.Metro | 4,271 | issue_to_patch | TabControl: allow for some tweak without to redefine the full style
## Describe the feature
I am trying to mimic the style from Microsoft Money app, see following screenshot:
So I'd like to be able t... | Allow set TabContol/TabItem Underline properties without to redefine the full style | ## Describe the changes you have made to improve this project
Add an attached property to set the Margin for the Underline inside a TabItem. New property is called `TabControlHelper.UnderlineMargin`.
Add keys to set the LineExtent and LineThickness of the Underline for TabControl and TabItem.
```xaml
<sys... | df4b55b4a40976aa47f6ac616a683daefc894927 | af1b0e9b01b0e23cd04e93af227adc1440dd74fc | diff --git a/src/MahApps.Metro/Controls/Helper/TabControlHelper.cs b/src/MahApps.Metro/Controls/Helper/TabControlHelper.cs
index 343dd9dde1..80452144ae 100644
--- a/src/MahApps.Metro/Controls/Helper/TabControlHelper.cs
+++ b/src/MahApps.Metro/Controls/Helper/TabControlHelper.cs
@@ -275,11 +275,14 @@ public static void ... | [
"src/MahApps.Metro/Controls/Helper/TabControlHelper.cs",
"src/MahApps.Metro/Styles/Controls.TabControl.xaml",
"src/MahApps.Metro/Themes/MetroTabControl.xaml",
"src/MahApps.Metro/Themes/MetroTabItem.xaml"
] | [] | true | |
ManimCommunity/manim | 4,681 | issue_to_patch | Support typst with manim
## Description of proposed feature
It would be nice to have support for the typst typesetting language next to LaTeX.
https://github.com/typst/typst
## How can the new feature be used?
```py
from manim import *
complex_typst_example = \
"""$ frac(a^2, 2) $
$ vec(1, 2, delim: "[... | Introduce first-class support for rendering text and markup via Typst (optional dependency) | This PR adds first-class Typst support to Manim via new `Typst` and `TypstMath` mobjects. Typst source is compiled directly to SVG through the Python `typst` package, so users can render both general Typst markup and math without relying on a TeX installation. The branch also integrates Typst with existing label-orient... | 561de9d72ac1e462166a492546f0abfb12031609 | e56dac53dd5037c5e02e608195d2094c9f33c9e0 | diff --git a/.github/workflows/release-publish-documentation.yml b/.github/workflows/release-publish-documentation.yml
index 11807809b4..77e25045f9 100644
--- a/.github/workflows/release-publish-documentation.yml
+++ b/.github/workflows/release-publish-documentation.yml
@@ -33,7 +33,7 @@ jobs:
babel-english ... | [
".github/workflows/release-publish-documentation.yml",
"agents/typst_selector.md",
"docs/requirements.txt",
"docs/rtd-requirements.txt",
"docs/source/guides/using_text.rst",
"manim/__init__.py",
"manim/mobject/geometry/labeled.py",
"manim/mobject/graphing/number_line.py",
"manim/mobject/graphing/pro... | [] | diff --git a/tests/module/mobject/text/test_typst_mobject.py b/tests/module/mobject/text/test_typst_mobject.py
new file mode 100644
index 0000000000..998d3d61c4
--- /dev/null
+++ b/tests/module/mobject/text/test_typst_mobject.py
@@ -0,0 +1,339 @@
+from __future__ import annotations
+
+import numpy as np
+import pytest
... | true |
ManimCommunity/manim | 4,706 | issue_to_patch | Use `language` parameter to format `Code` even when passing `code_file` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Allows the usage of the `language` parameter in combination with the `code_file`parameter` when creat... | 05b3042ab0ef8ec5027e3165d3330d63951afad6 | 50a4219bdc8a3457470d77e357f87f586f2fbf9e | diff --git a/manim/mobject/text/code_mobject.py b/manim/mobject/text/code_mobject.py
index efa82cde8a..c9b66a9e3b 100644
--- a/manim/mobject/text/code_mobject.py
+++ b/manim/mobject/text/code_mobject.py
@@ -139,7 +139,10 @@ def __init__(
if code_file is not None:
code_file = Path(code_file)
... | [
"manim/mobject/text/code_mobject.py"
] | [] | true | ||
ManimCommunity/manim | 4,753 | issue_to_patch | Add tuple key support in `GenericGraph.__getitem__()`
## Description of proposed feature
```py
vertices = [1, 2, 3, 4]
edges = [(1, 2), (2, 3), (3, 4), (1, 3), (1, 4)]
g = Graph(vertices, edges)
assert isinstance(g[1], Dot) # This is OK
assert isinstance(g[(1, 2)], Line) # But this will raise a KeyError
```... | Add tests for edge lookup in `GenericGraph.__getitem__()` | ## Summary
Fixes #3798.
`GenericGraph.__getitem__` only looked up vertices. When a user passed a
`(u, v)` tuple to retrieve an edge mobject, it raised a `KeyError` against
`self.vertices` instead of looking up `self.edges`.
```python
g = Graph([1, 2, 3, 4], [(1, 2), (2, 3)])
g[1] # works — returns vertex mobje... | 2ece488b2c705dd400c33fafbe1723b98c15eb94 | 4ea944a1be58c46ea8bd9c4e5a0003574f129ecb | [
"tests/module/mobject/test_graph.py"
] | [
{
"comment": "One thing I mentioned in issue #3798 is that vertices can be any hashable object. This includes tuples: vertices can be tuples themselves. This is not too strange, actually. For example, vertices could represent 2D coordinates. There's also this concept of a \"line graph L of a graph G\" where eac... | diff --git a/tests/module/mobject/test_graph.py b/tests/module/mobject/test_graph.py
index 16c32da88e..fb052119df 100644
--- a/tests/module/mobject/test_graph.py
+++ b/tests/module/mobject/test_graph.py
@@ -76,6 +76,19 @@ def test_graph_add_edges():
assert set(G._graph.edges()) == set(G.edges.keys())
+def test... | true | |
ManimCommunity/manim | 3,799 | issue_to_patch | Support edge lookup via tuple in `GenericGraph.__getitem__()` | ## Motivation and Explanation: Why and how do your changes improve the library?
<!-- Optional for bugfixes, small enhancements, and documentation-related PRs. Otherwise, please give a short reasoning for your changes. -->
In the old GenericGraph, you can get the vertex 1 via `g[1]`, but you cannot get the edge 1->2 v... | 852ebd1c60b99546d688e24698617d54e65e8b9b | 4695b73c0ed5f61c835cfa095b2593be2c88fbbc | diff --git a/manim/mobject/graph.py b/manim/mobject/graph.py
index 7eaee412b4..f6bbe681ee 100644
--- a/manim/mobject/graph.py
+++ b/manim/mobject/graph.py
@@ -669,8 +669,13 @@ def _populate_edge_dict(
"""Helper method for populating the edges of the graph."""
raise NotImplementedError("To be implement... | [
"manim/mobject/graph.py"
] | [
{
"comment": "I think a better error message might be useful, so what about something like\r\n```suggestion\r\n if isinstance(k, tuple):\r\n if (edge := self.edges.get(k)) is not None:\r\n return edge\r\n elif (vertex := self.vertices.get(k)) is not None:\r\n r... | true | ||
ManimCommunity/manim | 3,799 | comment_to_fix | Support edge lookup via tuple in `GenericGraph.__getitem__()` | I think a better error message might be useful, so what about something like
```suggestion
if isinstance(k, tuple):
if (edge := self.edges.get(k)) is not None:
return edge
elif (vertex := self.vertices.get(k)) is not None:
return vertex
raise ValueE... | 852ebd1c60b99546d688e24698617d54e65e8b9b | 4695b73c0ed5f61c835cfa095b2593be2c88fbbc | diff --git a/manim/mobject/graph.py b/manim/mobject/graph.py
index 7eaee412b4..f6bbe681ee 100644
--- a/manim/mobject/graph.py
+++ b/manim/mobject/graph.py
@@ -669,8 +669,13 @@ def _populate_edge_dict(
"""Helper method for populating the edges of the graph."""
raise NotImplementedError("To be implement... | [
"manim/mobject/graph.py"
] | [
{
"comment": "I think a better error message might be useful, so what about something like\r\n```suggestion\r\n if isinstance(k, tuple):\r\n if (edge := self.edges.get(k)) is not None:\r\n return edge\r\n elif (vertex := self.vertices.get(k)) is not None:\r\n r... | true | ||
ManimCommunity/manim | 4,088 | issue_to_patch | Wrong result of Mobject.length_over_dim()
## Description of bug / unexpected behavior
In some conditions, the result of `Mobject.length_over_dim(self, dim: int) -> float` is wrong.
Given:
a VGroup containing:
* an empty VGroup (no submobject)
* any MObject with some position, like Square
and with only positi... | Fix empty submobjects distorting width/height of parent Mobject | ## Overview: What does this pull request change?
<!--changelog-start-->
Fixes #4087
When a Mobject contains an empty VGroup, its width or height can be wrong
<!--changelog-end-->
## Motivation and Explanation: Why and how do your changes improve the library?
Bug fix + tests
## Links to added or changed doc... | 82522795f1af8a7668845993ef8fc60e27f8c8d8 | f53b515df40e5e719d024a4404aebe84a58e5b2b | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 721ce57356..615d6b90e7 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -2162,13 +2162,31 @@ def restore(self) -> Self:
def reduce_across_dimension(
self, reduce_func: Callable[[Iterable[float]], float], dim: i... | [
"manim/mobject/mobject.py",
"tests/module/mobject/mobject/test_mobject.py"
] | [
{
"comment": "As the previous test was testing an unexpected behavior, it should have been linked to an issue.",
"path": "tests/module/mobject/mobject/test_mobject.py",
"hunk": "@@ -136,21 +136,19 @@ def test_mobject_dimensions_nested_mobjects():\n \n \n def test_mobject_dimensions_mobjects_with_no_poin... | diff --git a/tests/module/mobject/mobject/test_mobject.py b/tests/module/mobject/mobject/test_mobject.py
index 203d312627..a7eaee6446 100644
--- a/tests/module/mobject/mobject/test_mobject.py
+++ b/tests/module/mobject/mobject/test_mobject.py
@@ -3,7 +3,20 @@
import numpy as np
import pytest
-from manim import DL, ... | true |
ManimCommunity/manim | 4,088 | comment_to_fix | Fix empty submobjects distorting width/height of parent Mobject | As the previous test was testing an unexpected behavior, it should have been linked to an issue. | 82522795f1af8a7668845993ef8fc60e27f8c8d8 | f53b515df40e5e719d024a4404aebe84a58e5b2b | diff --git a/tests/module/mobject/mobject/test_mobject.py b/tests/module/mobject/mobject/test_mobject.py
index 203d312627..a7eaee6446 100644
--- a/tests/module/mobject/mobject/test_mobject.py
+++ b/tests/module/mobject/mobject/test_mobject.py
@@ -3,7 +3,20 @@
import numpy as np
import pytest
-from manim import DL, ... | [
"tests/module/mobject/mobject/test_mobject.py"
] | [
{
"comment": "As the previous test was testing an unexpected behavior, it should have been linked to an issue.",
"path": "tests/module/mobject/mobject/test_mobject.py",
"hunk": "@@ -136,21 +136,19 @@ def test_mobject_dimensions_nested_mobjects():\n \n \n def test_mobject_dimensions_mobjects_with_no_poin... | true | ||
ManimCommunity/manim | 4,211 | issue_to_patch | Using Swap on two Mobjects in a group can cause self.remove to not work on that group
## Description of bug / unexpected behavior
After using `Swap` on two `Mobjects` in the same `Group`, I have found that attempts to use `self.remove` to remove the `Group` sometimes fail and the `Group` remains visible
## Expected ... | Allow `CyclicReplace` and `Swap` to accept single `Group` or `VGroup` and add example | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Fix #4210
This PR modifies `CyclicReplace` (which `Swap` is an alias for) to allow it to accept `Gro... | 12c5640a322c6c5af51148dd846f99909d9a543a | dfcf3a95f04efbefcbe998d4281b20ccd339034c | diff --git a/manim/animation/transform.py b/manim/animation/transform.py
index 1eaa91b0fc..e33114812c 100644
--- a/manim/animation/transform.py
+++ b/manim/animation/transform.py
@@ -46,6 +46,7 @@
RendererType,
)
from ..mobject.mobject import Group, Mobject
+from ..mobject.types.vectorized_mobject import VGroup
... | [
"manim/animation/transform.py"
] | [
{
"comment": "## Cyclic import\n\nImport of module [manim.mobject.types.vectorized_mobject](1) begins an import cycle.\n\n[Show more details](https://github.com/ManimCommunity/manim/security/code-scanning/1694)",
"path": "manim/animation/transform.py",
"hunk": "@@ -45,6 +45,7 @@\n RendererType,\n )\... | true | |
ManimCommunity/manim | 4,400 | issue_to_patch | Add type annotations to `transform_matching_parts.py` |
<!-- Thank you again for contributing! Do not modify the lines below, they are for reviewers. -->
## Reviewer Checklist
- [ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
- [ ] If applicable: newly added non-private functions and classes have a docstring including a short... | 33424fe43df80eaf9a24cb30b82e1bd38b9689e8 | c4178ece5c4c73d149829128e96ecd9cd153ae0c | diff --git a/manim/animation/transform.py b/manim/animation/transform.py
index 9719ddf7c1..1eaa91b0fc 100644
--- a/manim/animation/transform.py
+++ b/manim/animation/transform.py
@@ -835,7 +835,14 @@ def construct(self):
"""
- def __init__(self, mobject, target_mobject, stretch=True, dim_to_match=1, **kwarg... | [
"manim/animation/transform.py",
"manim/animation/transform_matching_parts.py",
"mypy.ini"
] | [] | true | ||
ManimCommunity/manim | 4,728 | issue_to_patch | More specific Callable type annotations in mobject_update_utils | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Better type annotations for Mobject updaters for better type checking in the IDE.
## Motivation an... | 1b3390073c4433c3f697a463566ee36381481238 | 682be530c830ab8f80b5fc592fe71515489f5fd8 | diff --git a/manim/animation/updaters/mobject_update_utils.py b/manim/animation/updaters/mobject_update_utils.py
index 25fb372254..151254bcbb 100644
--- a/manim/animation/updaters/mobject_update_utils.py
+++ b/manim/animation/updaters/mobject_update_utils.py
@@ -16,7 +16,7 @@
import inspect
from collections.abc imp... | [
"manim/animation/updaters/mobject_update_utils.py"
] | [] | true | ||
ManimCommunity/manim | 4,731 | issue_to_patch | Allow excluding inner lines of `Table` | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Add option to hide table inner lines.
## Motivation and Explanation: Why and how do your changes imp... | 56f7eb2a1f4ff6c63b1b68aceacde310c252de39 | f14e01b5e6ac901ee53636db99ccfa7ca67a54ad | diff --git a/manim/mobject/table.py b/manim/mobject/table.py
index dc4519dea3..ee0df9ece6 100644
--- a/manim/mobject/table.py
+++ b/manim/mobject/table.py
@@ -104,6 +104,8 @@ class Table(VGroup):
Horizontal buffer passed to :meth:`~.Mobject.arrange_in_grid`, by default 1.3.
include_outer_lines
``... | [
"manim/mobject/table.py",
"tests/module/mobject/test_table.py"
] | [
{
"comment": "I think you might have commited this change in the wrong branch... If this change is worthwhile, please make another PR for it.",
"path": "manim/utils/file_ops.py",
"hunk": "@@ -195,9 +195,9 @@ def modify_atime(file_path: str) -> None:\n def open_file(file_path: Path, in_browser: bool = Fa... | diff --git a/tests/module/mobject/test_table.py b/tests/module/mobject/test_table.py
index 739f7aaaf9..969ff202d6 100644
--- a/tests/module/mobject/test_table.py
+++ b/tests/module/mobject/test_table.py
@@ -17,3 +17,27 @@ def test_highlighted_cell_color_access():
# Should not raise RecursionError
color = rect... | true | |
ManimCommunity/manim | 4,750 | issue_to_patch | Add regression tests for four recent fixes in vectorized_mobject.py
`manim/mobject/types/vectorized_mobject.py` is one of the more frequently-touched files in the repo, 18+ commits since 2024-01-01, including several bug fixes that landed without regression tests in the same PR. The test suite increase the coverage of... | Add regression tests for four recent fixes in vectorized_mobject.py | Closes #4741.
## Summary
`manim/mobject/types/vectorized_mobject.py` is one of the more frequently-touched files in the repo — 18+ commits since 2024-01-01, including several bug fixes that landed without regression tests in the same PR. The bugs are gone, but nothing in the test suite checks they don't come back.
T... | cfb5c684b7ba8a01fe4a9bd1186f47d6c56ceaca | 22375ad827197c002154ce86adf04be78c13f2cd | [
"tests/module/mobject/types/vectorized_mobject/test_stroke.py",
"tests/module/mobject/types/vectorized_mobject/test_vectorized_mobject.py"
] | [] | diff --git a/tests/module/mobject/types/vectorized_mobject/test_stroke.py b/tests/module/mobject/types/vectorized_mobject/test_stroke.py
index 25c09cd294..62076e3d0a 100644
--- a/tests/module/mobject/types/vectorized_mobject/test_stroke.py
+++ b/tests/module/mobject/types/vectorized_mobject/test_stroke.py
@@ -61,3 +61,... | true | |
ManimCommunity/manim | 4,749 | issue_to_patch | Increasing Coverage in Color Testing
We're planning to contribute tests for the module-level helper functions in `manim/utils/color/core.py`, in a new file `tests/module/utils/test_color_helpers.py`. They don't have dedicated coverage today — the file sits around 71%, mostly from the `ManimColor` class itself.
While ... | Add unit tests for module-level color helpers in manim/utils/color/core.py | Closes #4740
## Summary
Adds `tests/module/utils/test_color_helpers.py` covering the standalone helper functions exported from `manim.utils.color.core` (`color_to_rgb`, `color_to_rgba`, `color_to_int_rgb`, `color_to_int_rgba`, `rgb_to_color`, `rgba_to_color`, `rgb_to_hex`, `hex_to_rgb`, `invert_color`, `color_gra... | 429f25328deb48673adbbb38c592c85eb79552d3 | e54947b8eb2d7b6479210f891ec15aa97bea522d | [
"tests/module/utils/test_color_helpers.py"
] | [
{
"comment": "Since this function tests that the color gradient passes through all colors, the assertions should check that each one of the gradient colors is one of the original colors, not only the first and last ones:\n```suggestion\ndef test_color_gradient_passes_through_each_of_four_reference_colors() -> N... | diff --git a/tests/module/utils/test_color_helpers.py b/tests/module/utils/test_color_helpers.py
new file mode 100644
index 0000000000..13c3cb0346
--- /dev/null
+++ b/tests/module/utils/test_color_helpers.py
@@ -0,0 +1,264 @@
+from __future__ import annotations
+
+import numpy as np
+import numpy.testing as nt
+import ... | true | |
ManimCommunity/manim | 4,749 | comment_to_fix | Add unit tests for module-level color helpers in manim/utils/color/core.py | Since this function tests that the color gradient passes through all colors, the assertions should check that each one of the gradient colors is one of the original colors, not only the first and last ones:
```suggestion
def test_color_gradient_passes_through_each_of_four_reference_colors() -> None:
# With >= 4 ref... | 429f25328deb48673adbbb38c592c85eb79552d3 | e54947b8eb2d7b6479210f891ec15aa97bea522d | diff --git a/tests/module/utils/test_color_helpers.py b/tests/module/utils/test_color_helpers.py
new file mode 100644
index 0000000000..13c3cb0346
--- /dev/null
+++ b/tests/module/utils/test_color_helpers.py
@@ -0,0 +1,264 @@
+from __future__ import annotations
+
+import numpy as np
+import numpy.testing as nt
+import ... | [
"tests/module/utils/test_color_helpers.py"
] | [
{
"comment": "Since this function tests that the color gradient passes through all colors, the assertions should check that each one of the gradient colors is one of the original colors, not only the first and last ones:\n```suggestion\ndef test_color_gradient_passes_through_each_of_four_reference_colors() -> N... | true | ||
ManimCommunity/manim | 4,694 | issue_to_patch | Fixed inconsistent stroke width scaling for text in compound objects | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
The current code for scale() in vectorized_mobject.py takes the root mobject's stroke width and sets st... | c45724989df900e6026425f524022a8d54625ef2 | 155ac7f3215ae832bbbe91677326258f3214c61a | diff --git a/manim/mobject/types/vectorized_mobject.py b/manim/mobject/types/vectorized_mobject.py
index d32bd39739..768091ea65 100644
--- a/manim/mobject/types/vectorized_mobject.py
+++ b/manim/mobject/types/vectorized_mobject.py
@@ -500,8 +500,10 @@ def scale(
will shrink, and for :math:`|\alpha| > 1` it... | [
"manim/mobject/types/vectorized_mobject.py"
] | [] | true | ||
ManimCommunity/manim | 4,532 | issue_to_patch | Add a `seed` config option + `--seed` CLI option for reproducible randomness in rendered scenes | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
<!-- If there is more information than the PR title that should be added to our release changelog, add it in the following changelog section. This is opt... | cd7cd1b219e3c81f0bc8d9654d44e65b2edb9341 | 56f97d547819c231863798c0a854f48656e87f3c | diff --git a/manim/_config/utils.py b/manim/_config/utils.py
index a3da85558d..1db9d6b29f 100644
--- a/manim/_config/utils.py
+++ b/manim/_config/utils.py
@@ -299,6 +299,7 @@ class MyScene(Scene): ...
"save_last_frame",
"save_pngs",
"scene_names",
+ "seed",
"show_in_file_brows... | [
"manim/_config/utils.py",
"manim/cli/render/global_options.py",
"manim/scene/scene.py",
"manim/utils/color/core.py",
"manim/utils/commands.py",
"tests/module/scene/test_scene.py",
"tests/test_scene_rendering/simple_scenes.py",
"tests/test_scene_rendering/test_cli_flags.py"
] | [] | diff --git a/tests/module/scene/test_scene.py b/tests/module/scene/test_scene.py
index 70ea9eaf2a..c64fbd46ac 100644
--- a/tests/module/scene/test_scene.py
+++ b/tests/module/scene/test_scene.py
@@ -4,7 +4,7 @@
import pytest
-from manim import Circle, FadeIn, Group, Mobject, Scene, Square
+from manim import Circle... | true | |
ManimCommunity/manim | 4,675 | issue_to_patch | Change `VMobject._bezier_t_values` typehint to `npt.NDArray[np.float64]` | ## Overview: What does this pull request change?
This PR changes the typehint for the attribute: _bezier_t_values in the __init__ of VMobject class.
earlier: self._bezier_t_values: npt.NDArray[float] = np.linspace( 0, 1, n_points_per_cubic_curve)
now: self._bezier_t_values: npt.NDArray[np.float64] = np.linspace(0, ... | 82f93b6c3c7c1d67180b063c0eff83e5fa01f566 | 5bcd60d01242f87023d4031416c563c0192eaed1 | diff --git a/manim/mobject/types/vectorized_mobject.py b/manim/mobject/types/vectorized_mobject.py
index 19cb14d591..d32bd39739 100644
--- a/manim/mobject/types/vectorized_mobject.py
+++ b/manim/mobject/types/vectorized_mobject.py
@@ -155,7 +155,7 @@ def __init__(
self.shade_in_3d: bool = shade_in_3d
... | [
"manim/mobject/types/vectorized_mobject.py"
] | [] | true | ||
ManimCommunity/manim | 4,658 | issue_to_patch | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | ## Overview: What does this pull request change?
This PR refactors the method "put_start_and_end_on" in mobject.py and opengl_mobject.py:
Replaces self.points = np.array(start) with self.shift(np.asarray(start) - current_start) in the case of a mobject whose start and end point are the same, in both mobject.py and... | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 9f3818c188..721ce57356 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -1941,30 +1941,33 @@ def surround(
return self
def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:
- curr... | [
"manim/mobject/mobject.py",
"manim/mobject/opengl/opengl_mobject.py",
"tests/module/mobject/graphing/test_number_line.py"
] | [
{
"comment": "As this old TODO mentioned, tests break when modifying this. In particular, there is a failing test in `tests/module/mobject/graphing/test_number_line.py` which must be fixed in order to approve and merge this PR:\n\n```py\ndef test_start_and_end_at_same_point():\n line = DashedLine(np.zeros(3)... | diff --git a/tests/module/mobject/graphing/test_number_line.py b/tests/module/mobject/graphing/test_number_line.py
index 55810bc701..be73e1d7da 100644
--- a/tests/module/mobject/graphing/test_number_line.py
+++ b/tests/module/mobject/graphing/test_number_line.py
@@ -129,4 +129,6 @@ def test_start_and_end_at_same_point(... | true | |
ManimCommunity/manim | 4,658 | comment_to_fix | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | As this old TODO mentioned, tests break when modifying this. In particular, there is a failing test in `tests/module/mobject/graphing/test_number_line.py` which must be fixed in order to approve and merge this PR:
```py
def test_start_and_end_at_same_point():
line = DashedLine(np.zeros(3), np.zeros(3))
line.pu... | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 9f3818c188..721ce57356 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -1941,30 +1941,33 @@ def surround(
return self
def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:
- curr... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "As this old TODO mentioned, tests break when modifying this. In particular, there is a failing test in `tests/module/mobject/graphing/test_number_line.py` which must be fixed in order to approve and merge this PR:\n\n```py\ndef test_start_and_end_at_same_point():\n line = DashedLine(np.zeros(3)... | true | ||
ManimCommunity/manim | 4,658 | comment_to_fix | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | I believe that it is not necessary to leave a comment on how the old TODO was fixed:
```suggestion
``` | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 9f3818c188..721ce57356 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -1941,30 +1941,33 @@ def surround(
return self
def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:
- curr... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "I believe that it is not necessary to leave a comment on how the old TODO was fixed:\n```suggestion\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -1941,30 +1941,35 @@ def surround(\n return self\n \n def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) ... | true | ||
ManimCommunity/manim | 4,658 | comment_to_fix | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | ```suggestion
``` | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/opengl/opengl_mobject.py b/manim/mobject/opengl/opengl_mobject.py
index 52cb3f3ac2..e624dc2e58 100644
--- a/manim/mobject/opengl/opengl_mobject.py
+++ b/manim/mobject/opengl/opengl_mobject.py
@@ -6,6 +6,7 @@
import random
import sys
import types
+import warnings
from collections.abc impor... | [
"manim/mobject/opengl/opengl_mobject.py"
] | [
{
"comment": "```suggestion\n```",
"path": "manim/mobject/opengl/opengl_mobject.py",
"hunk": "@@ -2134,26 +2134,35 @@ def surround(\n return self\n \n def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:\n- curr_start, curr_end = self.get_start_and_end()\n- ... | true | ||
ManimCommunity/manim | 4,658 | comment_to_fix | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | precommit demands that the `stacklevel` parameter is explicitly set when emitting a warning. It suggests a value of 2, which is the best choice in this case:
```suggestion
warnings.warn(
"put_start_and_end_on has been called on a closed loop or zero-length mobject. "
f"{type(... | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/opengl/opengl_mobject.py b/manim/mobject/opengl/opengl_mobject.py
index 52cb3f3ac2..e624dc2e58 100644
--- a/manim/mobject/opengl/opengl_mobject.py
+++ b/manim/mobject/opengl/opengl_mobject.py
@@ -6,6 +6,7 @@
import random
import sys
import types
+import warnings
from collections.abc impor... | [
"manim/mobject/opengl/opengl_mobject.py"
] | [
{
"comment": "precommit demands that the `stacklevel` parameter is explicitly set when emitting a warning. It suggests a value of 2, which is the best choice in this case:\n```suggestion\n warnings.warn(\n \"put_start_and_end_on has been called on a closed loop or zero-length mobject. ... | true | ||
ManimCommunity/manim | 4,658 | comment_to_fix | Refactor `Mobject.put_start_and_end_on()` to shift `Mobject` to `start` when it's a closed curve | ```suggestion
warnings.warn(
"put_start_and_end_on has been called on a closed loop or zero-length mobject. "
f"{type(self).__name__} will be shifted to start point instead.",
stacklevel=2,
)
``` | af70b6fef2180a926c47aa0cb309e2314672926f | ab7224add0160e27219d92bb3ef846e389a2c634 | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 9f3818c188..721ce57356 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -1941,30 +1941,33 @@ def surround(
return self
def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:
- curr... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "```suggestion\n warnings.warn(\n \"put_start_and_end_on has been called on a closed loop or zero-length mobject. \"\n f\"{type(self).__name__} will be shifted to start point instead.\",\n stacklevel=2,\n )\n```",
"path": "manim... | true | ||
ManimCommunity/manim | 4,618 | issue_to_patch | [Experimental] Fix image test | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Fixes `test_invert_image` in `tests/module/mobject/test_image.py` by overriding `ImageMobject.init_co... | 64511b98e4dde10d7e60ce5a8696db5e02b22c73 | 183191c4397972f290a5cb2c909646e1bc20e604 | diff --git a/manim/mobject/types/image_mobject.py b/manim/mobject/types/image_mobject.py
index f03541cd1f..6a462d0265 100644
--- a/manim/mobject/types/image_mobject.py
+++ b/manim/mobject/types/image_mobject.py
@@ -26,8 +26,6 @@
)
from ...utils.images import change_to_rgba_array, get_full_raster_image_path
-__all__... | [
"manim/mobject/types/image_mobject.py",
"tests/module/mobject/test_image.py"
] | [] | diff --git a/tests/module/mobject/test_image.py b/tests/module/mobject/test_image.py
index ef00eb75b9..584068bd45 100644
--- a/tests/module/mobject/test_image.py
+++ b/tests/module/mobject/test_image.py
@@ -7,7 +7,7 @@
@pytest.mark.parametrize("dtype", [np.uint8, np.uint16])
def test_invert_image(dtype):
rng = n... | true | |
ManimCommunity/manim | 4,659 | issue_to_patch | chore(deps-dev): bump requests from 2.32.5 to 2.33.0 | Bumps [requests](https://github.com/psf/requests) from 2.32.5 to 2.33.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/psf/requests/releases">requests's releases</a>.</em></p>
<blockquote>
<h2>v2.33.0</h2>
<h2>2.33.0 (2026-03-25)</h2>
<p><strong>Announcements</strong></p>
<u... | 4b32312dd1779f0989dcb947cae202f00b3219d6 | df1a6a1f329dd8b472b4687024ef2dddad9c414b | diff --git a/uv.lock b/uv.lock
index 78de531e86..d5d2357739 100644
--- a/uv.lock
+++ b/uv.lock
@@ -2667,7 +2667,7 @@ wheels = [
[[package]]
name = "requests"
-version = "2.32.5"
+version = "2.33.0"
source = { registry = "https://pypi.org/simple" }
dependencies = [
{ name = "certifi" },
@@ -2675,9 +2675,9 @@ ... | [
"uv.lock"
] | [] | true | ||
ManimCommunity/manim | 4,635 | issue_to_patch | chore(deps): bump tornado from 6.5.4 to 6.5.5 | Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.5.4 to 6.5.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst">tornado's changelog</a>.</em></p>
<blockquote>
<h1>Release notes</h1>
<p>.. toctree::
:maxdepth: 2</p>
<p>r... | 90141df1050bd8a2e20e162c85fe9bfd9eaf5988 | c128db2e1e68d12d7c6d1fffa24e03947bb9540a | diff --git a/uv.lock b/uv.lock
index 5d1d718fe4..78de531e86 100644
--- a/uv.lock
+++ b/uv.lock
@@ -3295,21 +3295,19 @@ wheels = [
[[package]]
name = "tornado"
-version = "6.5.4"
-source = { registry = "https://pypi.org/simple" }
-sdist = { url = "https://files.pythonhosted.org/packages/37/1d/0a336abf618272d53f62ebe... | [
"uv.lock"
] | [] | true | ||
ManimCommunity/manim | 4,677 | issue_to_patch | chore: combine dependabot updates for CI retest | Includes the changes from PRs #4666, #4668, #4669, #4670, and #4671.
| 752b46a0035edb208107a237a53e03aeb6dca1f8 | 69d9762c35dbb333f02854a6c64bf84a5d1bfa0d | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a7ef5817c0..ac93626f9e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -129,7 +129,7 @@ jobs:
path: ${{ github.workspace }}\ManimCache
key: ${{ runner.os }}-dependencies-tinytex-${{ hashFiles('.github/ma... | [
".github/workflows/ci.yml",
".github/workflows/publish-docker.yml",
"uv.lock"
] | [] | true | ||
ManimCommunity/manim | 4,679 | issue_to_patch | Update TinyTeX Windows/macOS installation in `ci.yml` to fix failing pipelines | Recent PR pipelines have been failing because the daily TinyTex-1.zip for Windows and TinyTex-1.tgz for macOS are missing. According to [this tinytex-releases commit](https://github.com/rstudio/tinytex-releases/commit/50a59183136a63d4dc7a09efa5457ea38f226d17), they were replaced with TinyTex-1-windows.exe (which is a 7... | 21cf9998cc7ad34cdc5cb2fae09aa500d88d86c2 | 5cd97091590bc808d6756d123b652dcff5c4e558 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 58faeca90a..a7ef5817c0 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -104,8 +104,8 @@ jobs:
oriPath=$PATH
sudo mkdir -p $PWD/macos-cache
echo "Install TinyTeX"
- sudo curl -L -o "/t... | [
".github/workflows/ci.yml"
] | [] | true | ||
ManimCommunity/manim | 4,630 | issue_to_patch | get_nth_subpath can return List instead of expected type of NDArray.
https://github.com/ManimCommunity/manim/blob/286f366a3584ae84d29d13c2a2c1f70b43752f95/manim/mobject/opengl/opengl_vectorized_mobject.py#L1215C33-L1215C33
```py
def get_nth_subpath(path_list, n):
if n >= len(path_list):
# Create a nu... | Fix `IndexError` in `get_nth_subpath()` and ensure it always returns a NumPy array | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Fixes #3569 by making sure that `get_nth_subpath()` always returns a NumPy array
Fixes #4629 by fallin... | ebb230f6f1ed1cd5cafadec7f2e1af453e40b56f | ebf0155f990e51f20725af8085b4fc01b45f1698 | diff --git a/manim/mobject/opengl/opengl_vectorized_mobject.py b/manim/mobject/opengl/opengl_vectorized_mobject.py
index 41059782f2..c805ebb377 100644
--- a/manim/mobject/opengl/opengl_vectorized_mobject.py
+++ b/manim/mobject/opengl/opengl_vectorized_mobject.py
@@ -1227,7 +1227,9 @@ def align_points(self, vmobject):
... | [
"manim/mobject/opengl/opengl_vectorized_mobject.py",
"manim/mobject/types/vectorized_mobject.py"
] | [] | true | |
ManimCommunity/manim | 4,642 | issue_to_patch | Update link in pyproject.toml to X / Twitter | ## Overview: What does this pull request change?
Updates the link to X / Twitter to the new account created at the end of 2025.
<!-- Thank you again for contributing! Do not modify the lines below, they are for reviewers. -->
## Reviewer Checklist
- [ ] The PR title is descriptive enough for the changelog, ... | 46177d247e88d9813c5b23459973feec8801898b | fb4ff2237761476df4ae6af03c132acd1ad7c514 | diff --git a/pyproject.toml b/pyproject.toml
index 19ef211cfa..eaceea4bbd 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -62,7 +62,7 @@ documentation = "https://docs.manim.community/"
homepage = "https://www.manim.community/"
"Bug Tracker" = "https://github.com/ManimCommunity/manim/issues"
"Changelog" = "https:... | [
"pyproject.toml"
] | [] | true | ||
ManimCommunity/manim | 3,973 | issue_to_patch | Code example for Sphere is misleading
## Description of bug / unexpected behavior
<!-- Add a clear and concise description of the problem you encountered. -->
The corresponding 3d shading of `sphere1` in the [Figure of ExampleSphere](https://docs.manim.community/en/stable/reference/manim.mobject.three_d.three_dimens... | Fix wrong angle ranges in `Sphere` documentation and add more examples | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
This pull request resolves [3948](https://github.com/ManimCommunity/manim/issues/3948), by changing the... | 468929889b11f0b15d5bbd48c46c605d6b48906f | a2f0ec61e1b16046815f1b5960f00478b4fb6caf | diff --git a/manim/mobject/three_d/three_dimensions.py b/manim/mobject/three_d/three_dimensions.py
index 48297a67da..f2698de7e8 100644
--- a/manim/mobject/three_d/three_dimensions.py
+++ b/manim/mobject/three_d/three_dimensions.py
@@ -379,13 +379,7 @@ class Sphere(Surface):
class ExampleSphere(ThreeDScene):
... | [
"manim/mobject/three_d/three_dimensions.py"
] | [
{
"comment": "Add an extra line in between, so that Sphinx renders the example correctly.\r\n\r\n```suggestion\r\n This example shows that overlapping spheres can intersect with rough transitions.\r\n \r\n .. manim:: ExampleSphereOverlap\r\n```",
"path": "manim/mobject/three_d/three_dimensions.py",... | true | |
ManimCommunity/manim | 3,973 | comment_to_fix | Fix wrong angle ranges in `Sphere` documentation and add more examples | Add an extra line in between, so that Sphinx renders the example correctly.
```suggestion
This example shows that overlapping spheres can intersect with rough transitions.
.. manim:: ExampleSphereOverlap
``` | 468929889b11f0b15d5bbd48c46c605d6b48906f | a2f0ec61e1b16046815f1b5960f00478b4fb6caf | diff --git a/manim/mobject/three_d/three_dimensions.py b/manim/mobject/three_d/three_dimensions.py
index 48297a67da..f2698de7e8 100644
--- a/manim/mobject/three_d/three_dimensions.py
+++ b/manim/mobject/three_d/three_dimensions.py
@@ -379,13 +379,7 @@ class Sphere(Surface):
class ExampleSphere(ThreeDScene):
... | [
"manim/mobject/three_d/three_dimensions.py"
] | [
{
"comment": "Add an extra line in between, so that Sphinx renders the example correctly.\r\n\r\n```suggestion\r\n This example shows that overlapping spheres can intersect with rough transitions.\r\n \r\n .. manim:: ExampleSphereOverlap\r\n```",
"path": "manim/mobject/three_d/three_dimensions.py",... | true | ||
ManimCommunity/manim | 3,973 | comment_to_fix | Fix wrong angle ranges in `Sphere` documentation and add more examples | The `u_range` and `v_range` default values are already `[0, TAU]` and `[0, PI]`, so we might as well simply remove these explicit arguments if the intention of the original example was to actually use `u` in `[0, TAU]` and `v` in `[0, PI]`.
The original example is, indeed, weird. Why did it use `u_range` and `v_rang... | 468929889b11f0b15d5bbd48c46c605d6b48906f | a2f0ec61e1b16046815f1b5960f00478b4fb6caf | diff --git a/manim/mobject/three_d/three_dimensions.py b/manim/mobject/three_d/three_dimensions.py
index 48297a67da..f2698de7e8 100644
--- a/manim/mobject/three_d/three_dimensions.py
+++ b/manim/mobject/three_d/three_dimensions.py
@@ -379,13 +379,7 @@ class Sphere(Surface):
class ExampleSphere(ThreeDScene):
... | [
"manim/mobject/three_d/three_dimensions.py"
] | [
{
"comment": "The `u_range` and `v_range` default values are already `[0, TAU]` and `[0, PI]`, so we might as well simply remove these explicit arguments if the intention of the original example was to actually use `u` in `[0, TAU]` and `v` in `[0, PI]`.\r\n\r\nThe original example is, indeed, weird. Why did it... | true | ||
ManimCommunity/manim | 4,621 | issue_to_patch | [Experimental] Fix ruff linter issues | <!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html -->
## Overview: What does this pull request change?
Fixes a few issues which the ruff linter is complaining about on the experimental branch.
## Motiv... | f565d48e5dc4092d8ec27767d9b40fc93289fcb5 | 708efc574a43300a640fa454f48be461a54c5085 | diff --git a/manim/animation/animation.py b/manim/animation/animation.py
index 4c0a866d82..e61667afc6 100644
--- a/manim/animation/animation.py
+++ b/manim/animation/animation.py
@@ -337,7 +337,7 @@ def interpolate(self, alpha: float) -> None:
families = tuple(self.get_all_families_zipped())
for i, mo... | [
"manim/animation/animation.py",
"manim/animation/growing.py",
"manim/animation/rotation.py",
"manim/animation/transform_matching_parts.py",
"manim/manager.py",
"manim/utils/testing/_test_class_makers.py"
] | [] | diff --git a/manim/utils/testing/_test_class_makers.py b/manim/utils/testing/_test_class_makers.py
index 872246ab20..6e9710813c 100644
--- a/manim/utils/testing/_test_class_makers.py
+++ b/manim/utils/testing/_test_class_makers.py
@@ -4,6 +4,7 @@
from manim.file_writer.protocols import FileWriterProtocol
from manim... | true | |
ManimCommunity/manim | 4,388 | issue_to_patch | Add type annotations to `mobject.py` | ## Overview: What does this pull request change?
This PR add type annotations to `mobject.py`.
Issue #3375.
<!-- Thank you again for contributing! Do not modify the lines below, they are for reviewers. -->
## Reviewer Checklist
- [ ] The PR title is descriptive enough for the changelog, and the PR is labeled... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/camera/moving_camera.py b/manim/camera/moving_camera.py
index af1fbb22a9..3bb61120d2 100644
--- a/manim/camera/moving_camera.py
+++ b/manim/camera/moving_camera.py
@@ -10,7 +10,7 @@
__all__ = ["MovingCamera"]
from collections.abc import Iterable
-from typing import Any
+from typing import Any, Li... | [
"manim/camera/moving_camera.py",
"manim/mobject/geometry/line.py",
"manim/mobject/graphing/probability.py",
"manim/mobject/matrix.py",
"manim/mobject/mobject.py",
"manim/mobject/text/tex_mobject.py",
"manim/mobject/text/text_mobject.py",
"manim/mobject/three_d/three_dimensions.py",
"manim/mobject/ty... | [
{
"comment": "These issues can be handled by typing.cast, but I don't think that is the best way to deal with them.",
"path": "manim/mobject/geometry/line.py",
"hunk": "@@ -649,8 +649,10 @@ def scale(self, factor: float, scale_tips: bool = False, **kwargs: Any) -> Self:\n self._set_stroke_width_... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | An overload could allow us to specify that `auto_zoom` returns a `Mobject` when `animate == False` and an `_AnimationBuilder` when `animate == True`, although it could be a bit verbose. What do you think of that?
```py
@overload
def auto_zoom(
self,
mobjects: Iterable[Mobject],
margin: ... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/camera/moving_camera.py b/manim/camera/moving_camera.py
index af1fbb22a9..3bb61120d2 100644
--- a/manim/camera/moving_camera.py
+++ b/manim/camera/moving_camera.py
@@ -10,7 +10,7 @@
__all__ = ["MovingCamera"]
from collections.abc import Iterable
-from typing import Any
+from typing import Any, Li... | [
"manim/camera/moving_camera.py"
] | [
{
"comment": "An overload could allow us to specify that `auto_zoom` returns a `Mobject` when `animate == False` and an `_AnimationBuilder` when `animate == True`, although it could be a bit verbose. What do you think of that?\n\n```py\n @overload\n def auto_zoom(\n self,\n mobjects: Iterabl... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | Indeed, the return value is not a `SampleSpace`.
Because now indexing a `VGroup` returns a `VMobject`, there is no longer a need to explicitly type `val`, so this method can be simplified a bit:
```py
def __getitem__(self, index: int) -> VMobject:
if hasattr(self, "horizontal_parts"):
return s... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/graphing/probability.py b/manim/mobject/graphing/probability.py
index 4fe0e1f393..4f5d882575 100644
--- a/manim/mobject/graphing/probability.py
+++ b/manim/mobject/graphing/probability.py
@@ -207,13 +207,11 @@ def add_braces_and_labels(self) -> None:
if hasattr(parts, subattr... | [
"manim/mobject/graphing/probability.py"
] | [
{
"comment": "Indeed, the return value is not a `SampleSpace`.\n\nBecause now indexing a `VGroup` returns a `VMobject`, there is no longer a need to explicitly type `val`, so this method can be simplified a bit:\n\n```py\n def __getitem__(self, index: int) -> VMobject:\n if hasattr(self, \"horizontal_... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | Changing the return type to `VMobject | None` is fine. Until we implement something similar to what's proposed in issue #4387 and PR #3606, there doesn't seem to be a way to properly type the return type as `SingleStringMathTex` (not `MathTex`).
Just one question: is it necessary to use `all_parts.submobjects[0]` ra... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/text/tex_mobject.py b/manim/mobject/text/tex_mobject.py
index 8698e024b8..729fbb158b 100644
--- a/manim/mobject/text/tex_mobject.py
+++ b/manim/mobject/text/tex_mobject.py
@@ -587,7 +587,7 @@ def set_color_by_tex_to_color_map(
self.id_to_vgroup_dict[match[1]].set_color(co... | [
"manim/mobject/text/tex_mobject.py"
] | [
{
"comment": "Changing the return type to `VMobject | None` is fine. Until we implement something similar to what's proposed in issue #4387 and PR #3606, there doesn't seem to be a way to properly type the return type as `SingleStringMathTex` (not `MathTex`).\r\n\r\nJust one question: is it necessary to use `al... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | Minor nitpick, but I believe that a name like `self.lines_alignments` or `self.line_alignments` with a plural on "alignments" reflects better the fact that it is a list of alignments. | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/text/text_mobject.py b/manim/mobject/text/text_mobject.py
index 812a6b084f..d484420301 100644
--- a/manim/mobject/text/text_mobject.py
+++ b/manim/mobject/text/text_mobject.py
@@ -166,9 +166,12 @@ def __init__(
lines_str_list = lines_str.split("\n")
self.chars = self._gen_ch... | [
"manim/mobject/text/text_mobject.py"
] | [
{
"comment": "Minor nitpick, but I believe that a name like `self.lines_alignments` or `self.line_alignments` with a plural on \"alignments\" reflects better the fact that it is a list of alignments.",
"path": "manim/mobject/text/text_mobject.py",
"hunk": "@@ -166,9 +166,12 @@ def __init__(\n li... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | Same as before: I don't understand the reason for this change... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/text/text_mobject.py b/manim/mobject/text/text_mobject.py
index 812a6b084f..d484420301 100644
--- a/manim/mobject/text/text_mobject.py
+++ b/manim/mobject/text/text_mobject.py
@@ -166,9 +166,12 @@ def __init__(
lines_str_list = lines_str.split("\n")
self.chars = self._gen_ch... | [
"manim/mobject/text/text_mobject.py"
] | [
{
"comment": "Same as before: I don't understand the reason for this change...",
"path": "manim/mobject/text/text_mobject.py",
"hunk": "@@ -1285,19 +1288,23 @@ def add_line_to(end: Point3D) -> None:\n if self.gradient:\n self.set_color_by_gradient(*self.gradient)\n for col in... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | Same as before | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/text/text_mobject.py b/manim/mobject/text/text_mobject.py
index 812a6b084f..d484420301 100644
--- a/manim/mobject/text/text_mobject.py
+++ b/manim/mobject/text/text_mobject.py
@@ -166,9 +166,12 @@ def __init__(
lines_str_list = lines_str.split("\n")
self.chars = self._gen_ch... | [
"manim/mobject/text/text_mobject.py"
] | [
{
"comment": "Same as before",
"path": "manim/mobject/text/text_mobject.py",
"hunk": "@@ -1285,19 +1288,23 @@ def add_line_to(end: Point3D) -> None:\n if self.gradient:\n self.set_color_by_gradient(*self.gradient)\n for col in colormap:\n- self.chars[\n+ ... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | `matrix` should be an iterable of iterables of elements. Normally, those elements are strings, since the default `element_to_mobject` is a `MathTex` which expects a string as an argument. However, since you can change `element_to_mobject` to something else which can accept anything you want, let the element type simply... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "`matrix` should be an iterable of iterables of elements. Normally, those elements are strings, since the default `element_to_mobject` is a `MathTex` which expects a string as an argument. However, since you can change `element_to_mobject` to something else which can accept anything you want, let t... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | These are possible kwargs to `element_to_mobject`. Thus, their type should be:
```suggestion
element_to_mobject_config: dict[str, Any] = {},
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "These are possible kwargs to `element_to_mobject`. Thus, their type should be:\n```suggestion\n element_to_mobject_config: dict[str, Any] = {},\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -172,7 +171,7 @@ def __init__(\n bracket_v_buff: float = MED_SMALL_BUFF,\n ... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
element_alignment_corner: Vector3DLike = DR,
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "```suggestion\n element_alignment_corner: Vector3DLike = DR,\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -172,7 +171,7 @@ def __init__(\n bracket_v_buff: float = MED_SMALL_BUFF,\n add_background_rectangles_to_entries: bool = False,\n include_backgro... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | For consistency with the suggestion on `__init__()`:
```suggestion
def _matrix_to_mob_matrix(self, matrix: Iterable[Iterable[Any]]) -> list[list[VMobject]]:
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "For consistency with the suggestion on `__init__()`:\n```suggestion\n def _matrix_to_mob_matrix(self, matrix: Iterable[Iterable[Any]]) -> list[list[VMobject]]:\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -207,7 +206,7 @@ def __init__(\n if self.include_background_recta... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
matrix: Iterable[Iterable[Any]],
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "```suggestion\n matrix: Iterable[Iterable[Any]],\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -485,7 +484,7 @@ def construct(self):\n def __init__(\n self,\n matrix: Iterable,",
"resolving_sha": "0d2ad520a435905841ae46d7135a424f65df22ba",
"resolv... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | For consistency with the parent class:
```suggestion
element_to_mobject: type[VMobject] | Callable[..., VMobject] = DecimalNumber,
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "For consistency with the parent class:\n```suggestion\n element_to_mobject: type[VMobject] | Callable[..., VMobject] = DecimalNumber,\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -485,7 +484,7 @@ def construct(self):\n def __init__(\n self,\n matrix: Ite... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
matrix: Iterable[Iterable[Any]],
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "```suggestion\n matrix: Iterable[Iterable[Any]],\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -530,7 +529,7 @@ def construct(self):\n def __init__(\n self,\n matrix: Iterable,",
"resolving_sha": "0d2ad520a435905841ae46d7135a424f65df22ba",
"resolv... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
element_to_mobject: type[VMobject] | Callable[..., VMobject] = Integer,
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "```suggestion\n element_to_mobject: type[VMobject] | Callable[..., VMobject] = Integer,\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -530,7 +529,7 @@ def construct(self):\n def __init__(\n self,\n matrix: Iterable,\n- element_to_mobject: type[Mobj... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
matrix: Iterable[Iterable[Any]],
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/matrix.py b/manim/mobject/matrix.py
index 5a965cc655..73fc7b4e53 100644
--- a/manim/mobject/matrix.py
+++ b/manim/mobject/matrix.py
@@ -40,15 +40,15 @@ def construct(self):
import itertools as it
-from collections.abc import Callable, Iterable, Sequence
+from collections.abc import Calla... | [
"manim/mobject/matrix.py"
] | [
{
"comment": "```suggestion\n matrix: Iterable[Iterable[Any]],\n```",
"path": "manim/mobject/matrix.py",
"hunk": "@@ -568,7 +567,7 @@ def construct(self):\n def __init__(\n self,\n matrix: Iterable,",
"resolving_sha": "0d2ad520a435905841ae46d7135a424f65df22ba",
"resolv... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | There are two lines importing from `collections.abc`, so please combine them into a single one:
```suggestion
from collections.abc import Callable, Iterable, Iterator
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "There are two lines importing from `collections.abc`, so please combine them into a single one:\n```suggestion\nfrom collections.abc import Callable, Iterable, Iterator\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -17,7 +17,7 @@\n from collections.abc import Callable, Iterable",
... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "```suggestion\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -41,25 +41,35 @@\n from ..utils.space_ops import angle_between_vectors, normalize, rotation_matrix\n \n if TYPE_CHECKING:\n+ from collections.abc import Iterator",
"resolving_sha": "0d2ad520a435905841ae46d7135a424f... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | There are three lines importing from `typing`, so please combine them into a single one:
```suggestion
from typing import TYPE_CHECKING, Any, Literal, Union, cast
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "There are three lines importing from `typing`, so please combine them into a single one:\n\n```suggestion\nfrom typing import TYPE_CHECKING, Any, Literal, Union, cast\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -17,7 +17,7 @@\n from collections.abc import Callable, Iterable\n fr... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | All these three objects were already imported. Also, `typing.Callable` is deprecated in favor of `collections.abc.Callable`:
```suggestion
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "All these three objects were already imported. Also, `typing.Callable` is deprecated in favor of `collections.abc.Callable`:\n\n```suggestion\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -41,25 +41,35 @@\n from ..utils.space_ops import angle_between_vectors, normalize, rotation_m... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | ```suggestion
``` | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "```suggestion\n```",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -41,25 +41,35 @@\n from ..utils.space_ops import angle_between_vectors, normalize, rotation_matrix\n \n if TYPE_CHECKING:\n+ from collections.abc import Iterator\n+ from typing import Any, Callable, Literal\n+\n ... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | MyPy should have been able to detect that the original expression evaluates to a boolean. Why hasn't it...? | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "MyPy should have been able to detect that the original expression evaluates to a boolean. Why hasn't it...?",
"path": "manim/mobject/mobject.py",
"hunk": "@@ -1637,20 +1655,21 @@ def shift_onto_screen(self, **kwargs) -> Self:\n self.to_edge(vect, **kwargs)\n return ... | true | ||
ManimCommunity/manim | 4,388 | comment_to_fix | Add type annotations to `mobject.py` | It seems there's a typo on the first line. The code seems to intend to refer to `self.saved_state`. `self.save_state` is actually a method (and will never be `None`).
When fixing the typo, the assertion is no longer needed:
```suggestion
if not hasattr(self, "saved_state") or self.saved_state is None:
... | 98c458b6b2e30792936fa0b544ceb357467c8163 | 0d2ad520a435905841ae46d7135a424f65df22ba | diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py
index 14738d22a7..9f3818c188 100644
--- a/manim/mobject/mobject.py
+++ b/manim/mobject/mobject.py
@@ -14,10 +14,10 @@
import sys
import types
import warnings
-from collections.abc import Callable, Iterable
+from collections.abc import Callable, Iterabl... | [
"manim/mobject/mobject.py"
] | [
{
"comment": "It seems there's a typo on the first line. The code seems to intend to refer to `self.saved_state`. `self.save_state` is actually a method (and will never be `None`).\r\n\r\nWhen fixing the typo, the assertion is no longer needed:\r\n```suggestion\r\n if not hasattr(self, \"saved_state\") o... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.