Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
In the usages of `reduce_across_dimension()`, `reduce_func` is either `min` or `max`, two functions which are able to accept iterables of values. In general, that is how `reduce_func` is used inside this method: it's passed a list of two floats and it returns one float. Thus, the correct parameter type for the callable...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "In the usages of `reduce_across_dimension()`, `reduce_func` is either `min` or `max`, two functions which are able to accept iterables of values. In general, that is how `reduce_func` is used inside this method: it's passed a list of two floats and it returns one float. Thus, the correct parameter...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
Maybe we could also have this method for `VMobject`, returning a `list[VMobject]`. Note, however, that here it should return a `Sequence[Mobject]` and there it should return a `Sequence[VMobject]` for it to work properly if we ever want to stop ignoring `vectorized_mobject.py` errors, because lists are invariant.
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "Maybe we could also have this method for `VMobject`, returning a `list[VMobject]`. Note, however, that here it should return a `Sequence[Mobject]` and there it should return a `Sequence[VMobject]` for it to work properly if we ever want to stop ignoring `vectorized_mobject.py` errors, because list...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
`max_distance` and `min_distance` are a bit misleading, because distances are always positive or zero. Here, the values returned by `reduce_across_dimension()` can be negative and are more related to coordinates in space, so a better option could be `max_coord` and `min_coord`. For example, for a `Mobject` which spans ...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "`max_distance` and `min_distance` are a bit misleading, because distances are always positive or zero. Here, the values returned by `reduce_across_dimension()` can be negative and are more related to coordinates in space, so a better option could be `max_coord` and `min_coord`. For example, for a ...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
It feels weird that MyPy seemed to require you to make the `direction` a NumPy array... Since the elements of `direction` are floats and the `key` parameter of `get_extremum_along_dim()` is currently an `int`, an option is to change the `key` parameter type to `float`. It does feel a bit strange, at least to me, but i...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "It feels weird that MyPy seemed to require you to make the `direction` a NumPy array...\n\nSince the elements of `direction` are floats and the `key` parameter of `get_extremum_along_dim()` is currently an `int`, an option is to change the `key` parameter type to `float`. It does feel a bit strang...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
`Camera.get_image()` is typed to return a `PIL.Image.Image`, so please try `from PIL import Image` inside the `if TYPE_CHECKING:` and then do the following change: ```suggestion def get_image(self, camera: Camera | None = None) -> Image.Image: ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "`Camera.get_image()` is typed to return a `PIL.Image.Image`, so please try `from PIL import Image` inside the `if TYPE_CHECKING:` and then do the following change:\n```suggestion\n def get_image(self, camera: Camera | None = None) -> Image.Image:\n```", "path": "manim/mobject/mobject.py", ...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
The returned size can initially be `None`: ```suggestion ) -> int | None: ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "The returned size can initially be `None`:\r\n```suggestion\r\n ) -> int | None:\r\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -2567,13 +2605,18 @@ def construct(self):\n start_pos = self.get_center()\n \n # get cols / rows values if given (implicitly)\n- ...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
It is actually expected that this function sometimes returns `None`, as evidenced by the check `if rows is None and cols is None:` a few lines below. Raising this error is currently making the doc build to fail. The actual mistake in the original function is that it implicitly returns `None` instead of doing it e...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "It is actually expected that this function sometimes returns `None`, as evidenced by the check `if rows is None and cols is None:` a few lines below.\r\n\r\nRaising this error is currently making the doc build to fail.\r\n\r\nThe actual mistake in the original function is that it implicitly return...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
The values of this dictionary refer to alignment directions, so they're more properly represented by vectors. As `init_alignments()` is an internal function, I suggest renaming this parameter to a more descriptive name as well: ```suggestion char_to_direction: dict[str, Vector3D], ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "The values of this dictionary refer to alignment directions, so they're more properly represented by vectors.\r\n\r\nAs `init_alignments()` is an internal function, I suggest renaming this parameter to a more descriptive name as well:\r\n```suggestion\r\n char_to_direction: dict[str, Ve...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
As I'll explain below, this function actually returns a list of vectors. Each character is converted to a vector. ```suggestion ) -> list[Vector3D]: ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "As I'll explain below, this function actually returns a list of vectors. Each character is converted to a vector.\n```suggestion\n ) -> list[Vector3D]:\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -2600,25 +2643,31 @@ def init_size(num, alignments, sizes):\n bu...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
As long as `dir_` is a NumPy array, it is not really necessary to convert `cell_alignment` into a NumPy array.
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "As long as `dir_` is a NumPy array, it is not really necessary to convert `cell_alignment` into a NumPy array.", "path": "manim/mobject/mobject.py", "hunk": "@@ -2600,25 +2643,31 @@ def init_size(num, alignments, sizes):\n buff_x = buff_y = buff\n \n # Initialize alignm...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
Currently, `alignments_in_list` starts as a list of strings and becomes a list of vectors as the `mapping` is applied over each element. A possible way to avoid this problem cleanly is by replacing all of the selected code by the following: ```py alignment_directions = [char_to_direction[char] for char in ...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "Currently, `alignments_in_list` starts as a list of strings and becomes a list of vectors as the `mapping` is applied over each element.\n\nA possible way to avoid this problem cleanly is by replacing all of the selected code by the following:\n```py\n alignment_directions = [char_to_di...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
In line with the previous suggestion, I recommend changing this name as well: ```suggestion row_alignment_directions = init_alignments( ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "In line with the previous suggestion, I recommend changing this name as well:\n```suggestion\n row_alignment_directions = init_alignments(\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -2600,25 +2643,31 @@ def init_size(num, alignments, sizes):\n buff_x = buff_y...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
```suggestion col_alignment_directions = init_alignments( ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "```suggestion\n col_alignment_directions = init_alignments(\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -2600,25 +2643,31 @@ def init_size(num, alignments, sizes):\n buff_x = buff_y = buff\n \n # Initialize alignments correctly\n- def init_align...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
As a minor nitpick, the lambdas are functions, not methods. It would be nice if the variable name described what the function actually does, because it gets a bit confusing later when it's used. This function calculates the index for the `Mobject` which will be placed at the row `r` and column `c` of the grid. Its n...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "As a minor nitpick, the lambdas are functions, not methods.\r\n\r\nIt would be nice if the variable name described what the function actually does, because it gets a bit confusing later when it's used. This function calculates the index for the `Mobject` which will be placed at the row `r` and col...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
Properly typing `reverse()` in order to preserve the types of the elements might be cumbersome and make reading the code more difficult than it should. Since it's used to reverse only two lists, I suggest doing the following which requires much less code and is pretty straightforward to read: ```py # Reverse ro...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "Properly typing `reverse()` in order to preserve the types of the elements might be cumbersome and make reading the code more difficult than it should. Since it's used to reverse only two lists, I suggest doing the following which requires much less code and is pretty straightforward to read:\n```...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
```suggestion def init_sizes( sizes: list[float | None] | None, num: int, measures: list[float], name: str, ) -> list[float]: ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "```suggestion\n def init_sizes(\n sizes: list[float | None] | None,\n num: int,\n measures: list[float],\n name: str,\n ) -> list[float]:\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -2670,8 +2723,10 @@ def reverse(maybe_l...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
As I'll explain later, the decorator `@override_animate` dynamically adds an `_override_animate` attribute to a method, and `_AnimationBuilder` is not a method. ```suggestion ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "As I'll explain later, the decorator `@override_animate` dynamically adds an `_override_animate` attribute to a method, and `_AnimationBuilder` is not a method.\n```suggestion\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -3225,13 +3282,15 @@ class Group(Mobject, metaclass=Convert...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
```suggestion self.overridden_animation: Animation | None = None ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "```suggestion\n self.overridden_animation: Animation | None = None\n```", "path": "manim/mobject/mobject.py", "hunk": "", "resolving_sha": "0d2ad520a435905841ae46d7135a424f65df22ba", "resolving_diff": "diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py\nindex 1...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
```suggestion self.anim_args: dict[str, Any] = {} ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "```suggestion\n self.anim_args: dict[str, Any] = {}\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -3241,9 +3300,9 @@ def __init__(self, mobject) -> None:\n \n # Whether animation args can be passed\n self.cannot_pass_args = False\n- self.anim_args = {...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
This function is a bit complicated to type. `@override_animate(method)` is a decorator which takes (decorates) an `animation_method` and returns it after dynamically assigning it as an attribute of `method`. Both `method` and `animation_method` should be typed as `MethodType`s. `method` does not necessarily retur...
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "This function is a bit complicated to type.\r\n\r\n`@override_animate(method)` is a decorator which takes (decorates) an `animation_method` and returns it after dynamically assigning it as an attribute of `method`. Both `method` and `animation_method` should be typed as `MethodType`s.\r\n\r\n`meth...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
`_AnimationBuilder` is not a method. Properly typing `method` or `temp_method` so that it has an attribute `_override_animate` is, indeed, difficult. I'll write about that in the next suggestions: ```suggestion ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "`_AnimationBuilder` is not a method. Properly typing `method` or `temp_method` so that it has an attribute `_override_animate` is, indeed, difficult. I'll write about that in the next suggestions:\r\n```suggestion\r\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -3390,9 +3450,11 @@...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
```suggestion def decorator(animation_method: types.MethodType) -> types.MethodType: ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 14738d22a7..9f3818c188 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -14,10 +14,10 @@ import sys import types import warnings -from collections.abc import Callable, Iterable +from collections.abc import Callable, Iterabl...
[ "manim/mobject/mobject.py" ]
[ { "comment": "```suggestion\r\n def decorator(animation_method: types.MethodType) -> types.MethodType:\r\n```", "path": "manim/mobject/mobject.py", "hunk": "@@ -3390,9 +3450,11 @@ def construct(self):\n self.wait()\n \n \"\"\"\n+ temp_method = cast(_AnimationBuilder, method)\n ...
true
ManimCommunity/manim
4,388
comment_to_fix
Add type annotations to `mobject.py`
`vector` should still be a `Vector`, because we need to access its `.get_vector()` and `.get_angle()` methods. Would it be possible to cast `i_hat` and `j_hat` to `Vector`s before passing them to `get_vector_label()`? ```suggestion vector: Vector, ```
98c458b6b2e30792936fa0b544ceb357467c8163
0d2ad520a435905841ae46d7135a424f65df22ba
diff --git a/manim/scene/vector_space_scene.py b/manim/scene/vector_space_scene.py index ecb688ac2f..56afea2095 100644 --- a/manim/scene/vector_space_scene.py +++ b/manim/scene/vector_space_scene.py @@ -281,15 +281,19 @@ def get_basis_vector_labels(self, **kwargs: Any) -> VGroup: color (str), ...
[ "manim/scene/vector_space_scene.py" ]
[ { "comment": "`vector` should still be a `Vector`, because we need to access its `.get_vector()` and `.get_angle()` methods. Would it be possible to cast `i_hat` and `j_hat` to `Vector`s before passing them to `get_vector_label()`?\r\n```suggestion\r\n vector: Vector,\r\n```", "path": "manim/scene/ve...
true
ManimCommunity/manim
4,515
issue_to_patch
LaTeX compilation error when breaking up a MathTex string by subscripts ## Description of bug / unexpected behavior When using `MathTex()` with the `substrings_to_isolate` argument, I get the following error: ``` ERROR LaTeX compilation error: tex_file_writing.py:199 Argument of ...
Rewrite MathTex to make it more robust regarding splitting
## Overview: What does this pull request change? This PR changes a large part of the implementation of the MathTex class. The reason is to deal with the issues related to splitting the tex string and then try to match the generated objects with parts of the original tex string. The idea for the PR is based on this d...
6e9ec60b6fe70ec922c9a6dd9a5c0bbe2dfd0be0
a27cb1243a29f30363625121370365fa34f8d3fc
diff --git a/docs/source/guides/using_text.rst b/docs/source/guides/using_text.rst index a71b29ec81..739510621c 100644 --- a/docs/source/guides/using_text.rst +++ b/docs/source/guides/using_text.rst @@ -424,7 +424,7 @@ may be expected. To color only ``x`` yellow, we have to do the following: class CorrectLaTeXSubs...
[ "docs/source/guides/using_text.rst", "manim/mobject/svg/svg_mobject.py", "manim/mobject/table.py", "manim/mobject/text/tex_mobject.py", "tests/control_data/logs_data/bad_tex_scene_BadTex.txt", "tests/module/mobject/text/test_texmobject.py", "tests/opengl/test_texmobject_opengl.py" ]
[ { "comment": "## Variable defined multiple times\n\nThis assignment to 'parent_name' is unnecessary as it is [redefined](1) before this value is used.\n\n[Show more details](https://github.com/ManimCommunity/manim/security/code-scanning/1846)", "path": "manim/mobject/svg/svg_mobject.py", "hunk": "@@ -26...
diff --git a/tests/control_data/logs_data/bad_tex_scene_BadTex.txt b/tests/control_data/logs_data/bad_tex_scene_BadTex.txt index 02c8813969..06a36fb5a1 100644 --- a/tests/control_data/logs_data/bad_tex_scene_BadTex.txt +++ b/tests/control_data/logs_data/bad_tex_scene_BadTex.txt @@ -1,8 +1,8 @@ {"levelname": "INFO", "m...
true
ManimCommunity/manim
4,515
comment_to_fix
Rewrite MathTex to make it more robust regarding splitting
Should we attempt to strengthen the parser to make this not necessary? Perhaps not at first.
6e9ec60b6fe70ec922c9a6dd9a5c0bbe2dfd0be0
a27cb1243a29f30363625121370365fa34f8d3fc
diff --git a/docs/source/guides/using_text.rst b/docs/source/guides/using_text.rst index a71b29ec81..739510621c 100644 --- a/docs/source/guides/using_text.rst +++ b/docs/source/guides/using_text.rst @@ -424,7 +424,7 @@ may be expected. To color only ``x`` yellow, we have to do the following: class CorrectLaTeXSubs...
[ "docs/source/guides/using_text.rst" ]
[ { "comment": "Should we attempt to strengthen the parser to make this not necessary? Perhaps not at first.", "path": "docs/source/guides/using_text.rst", "hunk": "@@ -434,6 +434,8 @@ By setting ``substrings_to_isolate`` to ``x``, we split up the\n :class:`~.MathTex` into substrings automatically and iso...
true
ManimCommunity/manim
4,515
comment_to_fix
Rewrite MathTex to make it more robust regarding splitting
logger.error with a bit more context?
6e9ec60b6fe70ec922c9a6dd9a5c0bbe2dfd0be0
a27cb1243a29f30363625121370365fa34f8d3fc
diff --git a/manim/mobject/svg/svg_mobject.py b/manim/mobject/svg/svg_mobject.py index bd494c0211..c296130a27 100644 --- a/manim/mobject/svg/svg_mobject.py +++ b/manim/mobject/svg/svg_mobject.py @@ -21,12 +21,12 @@ from ..geometry.line import Line from ..geometry.polygram import Polygon, Rectangle, RoundedRectangle ...
[ "manim/mobject/svg/svg_mobject.py" ]
[ { "comment": "logger.error with a bit more context?", "path": "manim/mobject/svg/svg_mobject.py", "hunk": "@@ -267,36 +272,77 @@ def get_mobjects_from(self, svg: se.SVG) -> list[VMobject]:\n The parsed SVG file.\n \"\"\"\n result: list[VMobject] = []\n- for shape in sv...
true
ManimCommunity/manim
4,515
comment_to_fix
Rewrite MathTex to make it more robust regarding splitting
Again, more context + logger? ```suggestion logger.error(f"MathTex: Could not find SVG group for tex part '{tex_string}' (id: {tex_string_id}). Using fallback to root group.") ```
6e9ec60b6fe70ec922c9a6dd9a5c0bbe2dfd0be0
a27cb1243a29f30363625121370365fa34f8d3fc
diff --git a/manim/mobject/text/tex_mobject.py b/manim/mobject/text/tex_mobject.py index 5d5cca069b..18546bce89 100644 --- a/manim/mobject/text/tex_mobject.py +++ b/manim/mobject/text/tex_mobject.py @@ -12,7 +12,7 @@ from __future__ import annotations -from manim.utils.color import BLACK, ManimColor, ParsableManim...
[ "manim/mobject/text/tex_mobject.py" ]
[ { "comment": "Again, more context + logger?\n\n\n```suggestion\n logger.error(f\"MathTex: Could not find SVG group for tex part '{tex_string}' (id: {tex_string_id}). Using fallback to root group.\")\n```", "path": "manim/mobject/text/tex_mobject.py", "hunk": "@@ -339,51 +399,32 @@ def _break_...
true
ManimCommunity/manim
4,230
issue_to_patch
Add type annotations to `manim/_config/utils.py`
## Overview: What does this pull request change? More work on https://github.com/ManimCommunity/manim/issues/3375 Continuation of PR #4134 The module manim/_config/utils.py is now going through mypy checks without raising any issues. <!-- Thank you again for contributing! Do not modify the lines below, the...
33a0e56d7383f0f5a99e32839e2d90980c1f9d7e
4bd68d09129cf5f6a3e5974762b1c446f7c2c734
diff --git a/manim/_config/utils.py b/manim/_config/utils.py index 1db9d6b29f..3e45846539 100644 --- a/manim/_config/utils.py +++ b/manim/_config/utils.py @@ -20,7 +20,7 @@ import os import re import sys -from collections.abc import Iterable, Iterator, Mapping, MutableMapping +from collections.abc import Iterator, M...
[ "manim/_config/utils.py", "manim/renderer/opengl_renderer_window.py" ]
[]
true
ManimCommunity/manim
4,631
issue_to_patch
Fix incorrect terminology in quickstart docs
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? In the "Positioning Mobjects" section, "SquareToCircle method" was used, but SquareToCircle is a cla...
d4af5b2baa62d4716b1d217a37e0b4533780d6e8
1343cae34cfd835181171c2f3d8d1bdbbaa995f2
diff --git a/docs/source/tutorials/quickstart.rst b/docs/source/tutorials/quickstart.rst index 6f419aa029..ca24d7516d 100644 --- a/docs/source/tutorials/quickstart.rst +++ b/docs/source/tutorials/quickstart.rst @@ -195,7 +195,7 @@ Positioning ``Mobject``\s Next, let's go over some basic techniques for positioning ``...
[ "docs/source/tutorials/quickstart.rst" ]
[]
true
ManimCommunity/manim
4,622
issue_to_patch
Vector3D typing in opengl_mobject ## Description of bug / unexpected behavior Name error raised line 1225 manim/mobject/opengl/opengl_mobject.py when running in preview mode. i.e. `manim -qm -p --renderer=opengl main.py TableExamples` Adding from manim.typing import Vector3D regardless of type checking seems to do the...
fix: fix `cast` crash in `OpenGLMobject.arrange_in_grid()` and `OpenGLPoint.get_location()`
Fixes #4550 Added quotes to Vector3D and to Point3D to match other calls to `cast`, such has Chopan suggested ## Overview: What does this pull request change? Add quotes to types in `cast("Vector3D", ...)` to solve the "NameError: name 'Vector3D' is not defined" issue. A similar issue could have happened wit...
1157b746c37130685e0a02d8aa0871d1f164d5f4
09792180764a4b0e7756bda9895ada8cd1da8e4c
diff --git a/manim/mobject/opengl/opengl_mobject.py b/manim/mobject/opengl/opengl_mobject.py index 4bb2733d70..52cb3f3ac2 100644 --- a/manim/mobject/opengl/opengl_mobject.py +++ b/manim/mobject/opengl/opengl_mobject.py @@ -1222,7 +1222,7 @@ def init_alignments( ) -> Sequence[Vector3D]: if str_alig...
[ "manim/mobject/opengl/opengl_mobject.py" ]
[]
true
ManimCommunity/manim
4,613
issue_to_patch
LaggedStartMap new bug (since 0.19.1) ## Description of bug / unexpected behavior LaggedStartMap is producing an error now, but the same code works fine in 0.19.0. I guess it's releated to the refactoring of LaggedStartMap in 0.19.1: https://github.com/ManimCommunity/manim/pull/4214 ## Expected behavior All three s...
Fix unintended propagation of `kwargs` in `LaggedStartMap`
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? Fix #4508 ## Motivation and Explanation: Why and how do your changes improve the library? <!-- Opti...
a0414dccece18676276965b5aaf23cf1b3a7637a
6bea8964db81d2815972a68b75e20c80aa1a99ea
diff --git a/manim/animation/composition.py b/manim/animation/composition.py index 1da15e914e..82488425f8 100644 --- a/manim/animation/composition.py +++ b/manim/animation/composition.py @@ -353,7 +353,7 @@ class LaggedStartMap(LaggedStart): Parameters ---------- - AnimationClass + animation_class ...
[ "manim/animation/composition.py", "tests/module/animation/test_composition.py" ]
[]
diff --git a/tests/module/animation/test_composition.py b/tests/module/animation/test_composition.py index 8c5f044b2a..3c7a3dcc3e 100644 --- a/tests/module/animation/test_composition.py +++ b/tests/module/animation/test_composition.py @@ -5,14 +5,16 @@ import pytest from manim.animation.animation import Animation, ...
true
ManimCommunity/manim
4,606
issue_to_patch
Fix creation or animation of a zero-length `DashedLine`
## Overview Fix crash when creating or animating a zero-length `DashedLine` (`start == end`). Issue: #4591 ## Motivation `DashedLine(ORIGIN, ORIGIN)` or converting a line to zero-length caused `IndexError` because `pop_tips()` always called `put_start_and_end_on`, breaking the points array. **Fix:** Only c...
704830ff5f0a97ad9e5ed251979c60ce88a715e1
9e208899298e52a7000af381312a52f23f972245
diff --git a/manim/mobject/geometry/arc.py b/manim/mobject/geometry/arc.py index eef149307b..d78a3622ba 100644 --- a/manim/mobject/geometry/arc.py +++ b/manim/mobject/geometry/arc.py @@ -241,7 +241,8 @@ def pop_tips(self) -> VGroup: if self.has_start_tip(): result.add(self.start_tip) ...
[ "manim/mobject/geometry/arc.py", "tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py" ]
[]
diff --git a/tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py b/tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py index 809c9c47f7..499d017e45 100644 --- a/tests/module/mobject/types/vectorized_mobject/test_dashed_vmobject.py +++ b/tests/module/mobject/types/vectorized_mobject/t...
true
ManimCommunity/manim
4,615
issue_to_patch
Prepare new release: `v0.20.1`
New release preparations incl. first pass for changelog.
6f825e85134102a642018ac320d233ac330e4883
6d39ed1aab9721957be60ebca82be17809559c35
diff --git a/CITATION.cff b/CITATION.cff index 67f10c8f44..3457722cf3 100644 --- a/CITATION.cff +++ b/CITATION.cff @@ -4,10 +4,10 @@ authors: - name: "The Manim Community Developers" cff-version: "1.2.0" -date-released: 2026-02-20 +date-released: 2026-02-27 license: MIT message: "We acknowledge the importanc...
[ "CITATION.cff", "docs/source/changelog.rst", "docs/source/changelog/0.20.1-changelog.md", "manim/utils/bezier.py", "pyproject.toml", "uv.lock" ]
[ { "comment": "Optional:\n```suggestion\n* fix: MathTex double-brace splitting no longer fires on natural LaTeX `}}` by {user}`behackl` in {pr}`4602`\n```\n", "path": "docs/source/changelog/0.20.1-changelog.md", "hunk": "@@ -0,0 +1,40 @@\n+---\n+short-title: v0.20.1\n+description: Changelog for v0.20.1\n...
true
ManimCommunity/manim
4,615
comment_to_fix
Prepare new release: `v0.20.1`
Optional: ```suggestion * fix: MathTex double-brace splitting no longer fires on natural LaTeX `}}` by {user}`behackl` in {pr}`4602` ```
6f825e85134102a642018ac320d233ac330e4883
6d39ed1aab9721957be60ebca82be17809559c35
diff --git a/docs/source/changelog/0.20.1-changelog.md b/docs/source/changelog/0.20.1-changelog.md new file mode 100644 index 0000000000..f2959810bb --- /dev/null +++ b/docs/source/changelog/0.20.1-changelog.md @@ -0,0 +1,41 @@ +--- +short-title: v0.20.1 +description: Changelog for v0.20.1 +--- + +# v0.20.1 + +Date +: ...
[ "docs/source/changelog/0.20.1-changelog.md" ]
[ { "comment": "Optional:\n```suggestion\n* fix: MathTex double-brace splitting no longer fires on natural LaTeX `}}` by {user}`behackl` in {pr}`4602`\n```\n", "path": "docs/source/changelog/0.20.1-changelog.md", "hunk": "@@ -0,0 +1,40 @@\n+---\n+short-title: v0.20.1\n+description: Changelog for v0.20.1\n...
true
ManimCommunity/manim
4,602
issue_to_patch
Incorrect MathTex rendering due to overly eager double brace splitting ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> I was rendering a mathtex mobject like this: MathTex(...,r"\\+\int_{0}^{\frac{Mq}{M+m}}",r"\dfrac{((M+m)p-q)^3}{3M(M+m)^2pq}",....
fix: MathTex double-brace splitting no longer fires on natural LaTeX `}}`
Fixes #4601. `MathTex` supports a `{{ ... }}` notation for splitting a single string argument into multiple submobjects. The splitting logic was recently rewritten (in #4515) and inadvertently changed the regex from a paired `{{(.*?)}}` match to `re.split(r"{{|}}", ...)`, which splits on any `{{` or `}}` in isolation....
704830ff5f0a97ad9e5ed251979c60ce88a715e1
755cbcfe10a73bee1fa8c977f3ce953fc530f1aa
diff --git a/docs/source/guides/using_text.rst b/docs/source/guides/using_text.rst index 739510621c..947bbae2ee 100644 --- a/docs/source/guides/using_text.rst +++ b/docs/source/guides/using_text.rst @@ -389,8 +389,9 @@ Substrings and parts The TeX mobject can accept multiple strings as arguments. Afterwards you can ...
[ "docs/source/guides/using_text.rst", "manim/mobject/text/tex_mobject.py", "tests/module/mobject/text/test_texmobject.py" ]
[]
diff --git a/tests/module/mobject/text/test_texmobject.py b/tests/module/mobject/text/test_texmobject.py index ed79633c08..48297abec6 100644 --- a/tests/module/mobject/text/test_texmobject.py +++ b/tests/module/mobject/text/test_texmobject.py @@ -20,13 +20,122 @@ def test_SingleStringMathTex(config): @pytest.mark.pa...
true
ManimCommunity/manim
4,604
issue_to_patch
enhancement: optimize Docker image build and runtime footprint
This PR reworks the Docker image build for smaller, cleaner images and faster builds. Key changes: - Switch to a multi-stage Docker build (separate builder/runtime). - Install Manim into a copied runtime virtual environment. - Slim runtime dependencies and keep only required system libraries. - Add `libgl1` to runtime...
80fd11efbc3c7d577244bdc72c8eb6880c9e7f72
7f11a08069003fd59ca232d77204186e2e4507dc
diff --git a/.dockerignore b/.dockerignore index 6b8710a711..e19bacca96 100644 --- a/.dockerignore +++ b/.dockerignore @@ -1,1 +1,20 @@ .git + +# Development / test artifacts +__pycache__ +**/__pycache__ +*.pyc +*.pyo +*.pyd +*.egg-info +dist/ +build/ +coverage.xml + +# Not needed to install the package +docs/ +tests/...
[ ".dockerignore", "docker/Dockerfile", "docker/readme.md", "docs/source/installation/docker.rst" ]
[]
true
ManimCommunity/manim
4,603
issue_to_patch
Silence pydub ffmpeg/avconv import warning when ffmpeg CLI is absent
Manim currently emits pydub's import-time warning about missing ffmpeg/avconv even though our audio conversion/transcoding paths are handled via PyAV. This warning is noisy and misleading (especially in environments where ffmpeg CLI is intentionally absent, like optimized container images). This PR suppresses that sp...
498f0b9c899f492af1b56835f543c6876d8a0c6d
9d26b0e1dd46b42f96b6ae45884004ca6ef1b1a7
diff --git a/manim/scene/scene_file_writer.py b/manim/scene/scene_file_writer.py index f4d8194da2..21425af759 100644 --- a/manim/scene/scene_file_writer.py +++ b/manim/scene/scene_file_writer.py @@ -6,6 +6,7 @@ import json import shutil +import warnings from fractions import Fraction from pathlib import Path fro...
[ "manim/scene/scene_file_writer.py" ]
[]
true
ManimCommunity/manim
4,064
issue_to_patch
Add alt text to all images in `README.md`
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be added to our release changelog, add ...
87cd63549c928d16d480f28b9906ec796a178208
6581f885da995e1c43bc33af8fd0a27fc635a94e
diff --git a/README.md b/README.md index d6dd5e38a3..2d272267cd 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,10 @@ <p align="center"> - <a href="https://www.manim.community/"><img src="https://raw.githubusercontent.com/ManimCommunity/manim/main/logo/cropped.png"></a> + <a href="https://www.manim.community/...
[ "README.md" ]
[]
true
ManimCommunity/manim
4,389
issue_to_patch
AnimationGroup with negative z_index ## Description of bug / unexpected behavior <!-- Add a clear and concise description of the problem you encountered. --> When an `AnimationGroup` acts on a Mobject with a negative `z_index`, the animation doesn't actually play. ## Expected behavior <!-- Add a clear and concis...
Fix moving-object detection for nested AnimationGroups with z-indexed mobjects
## Overview: What does this pull request change? Fixes an AnimationGroup behaviour with negative z_index Mobjects. More about this problem you can see in these issues: https://github.com/ManimCommunity/manim/issues/3334 and https://github.com/ManimCommunity/manim/issues/3914 ## Motivation and Explanation: Why and how ...
cd370610c5d985b0af2f0b2b7611bce03f2fd199
bc8a7dab977336e35e60d27bcba8dabdeb2d0de0
diff --git a/manim/scene/scene.py b/manim/scene/scene.py index 96d5fd9abc..845fafd0b9 100644 --- a/manim/scene/scene.py +++ b/manim/scene/scene.py @@ -903,7 +903,24 @@ def get_moving_mobjects(self, *animations: Animation) -> list[Mobject]: # as soon as there's one that needs updating of # some kind pe...
[ "manim/scene/scene.py", "tests/test_graphical_units/control_data/geometry/negative_z_index_AnimationGroup.npz", "tests/test_graphical_units/control_data/geometry/negative_z_index_LaggedStart.npz", "tests/test_graphical_units/control_data/geometry/nested_animation_groups_with_negative_z_index.npz", "tests/te...
[ { "comment": "If it works, I'd prefer a simpler solution not requiring a new method; something along the lines of the suggestion from my previous review:\n\n\n```suggestion\n animation_mobjects = []\n for anim in animations:\n animation_mobject.extend(anim.mob.get_family())\n```", "...
diff --git a/tests/test_graphical_units/control_data/geometry/negative_z_index_AnimationGroup.npz b/tests/test_graphical_units/control_data/geometry/negative_z_index_AnimationGroup.npz new file mode 100644 index 0000000000..80ba71a0eb Binary files /dev/null and b/tests/test_graphical_units/control_data/geometry/negativ...
true
ManimCommunity/manim
4,389
comment_to_fix
Fix moving-object detection for nested AnimationGroups with z-indexed mobjects
If it works, I'd prefer a simpler solution not requiring a new method; something along the lines of the suggestion from my previous review: ```suggestion animation_mobjects = [] for anim in animations: animation_mobject.extend(anim.mob.get_family()) ```
cd370610c5d985b0af2f0b2b7611bce03f2fd199
bc8a7dab977336e35e60d27bcba8dabdeb2d0de0
diff --git a/manim/scene/scene.py b/manim/scene/scene.py index 96d5fd9abc..845fafd0b9 100644 --- a/manim/scene/scene.py +++ b/manim/scene/scene.py @@ -903,7 +903,24 @@ def get_moving_mobjects(self, *animations: Animation) -> list[Mobject]: # as soon as there's one that needs updating of # some kind pe...
[ "manim/scene/scene.py" ]
[ { "comment": "If it works, I'd prefer a simpler solution not requiring a new method; something along the lines of the suggestion from my previous review:\n\n\n```suggestion\n animation_mobjects = []\n for anim in animations:\n animation_mobject.extend(anim.mob.get_family())\n```", "...
true
ManimCommunity/manim
4,456
issue_to_patch
VectorizedPoint being reset to origin by Create() ## Description of bug / unexpected behavior While working on a plugin for Manim, I came across a strange issue that I'm almost certain is not supposed to happen. When I tried calling Create() and passing it a VGroup that included several VectorizedPoint objects, all of...
Documentation: manual installation of manim as a local package
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be added to our release changelog, add ...
a6af7f3d7659c19f4761d0db5386ec22b3324a4a
b74a010149f7185688c53c79bee8f79e66c9459d
diff --git a/docs/source/installation/uv.md b/docs/source/installation/uv.md index ab2ccec554..c4cf17e6cb 100644 --- a/docs/source/installation/uv.md +++ b/docs/source/installation/uv.md @@ -329,3 +329,13 @@ version satisfies the requirement. Change the line to, for example to pin the python version to `3.12`. Finally...
[ "docs/source/installation/uv.md" ]
[ { "comment": "This needs to be reverted.\n\n\n```suggestion\n- [ ] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html)\n- [ ] I have written a descriptive PR title (see top of PR template for examples)\n- [ ] My new documentation builds, looks correctly formatted,...
true
ManimCommunity/manim
4,456
comment_to_fix
Documentation: manual installation of manim as a local package
```suggestion :::{dropdown} Installing the latest development version ```
a6af7f3d7659c19f4761d0db5386ec22b3324a4a
b74a010149f7185688c53c79bee8f79e66c9459d
diff --git a/docs/source/installation/uv.md b/docs/source/installation/uv.md index ab2ccec554..c4cf17e6cb 100644 --- a/docs/source/installation/uv.md +++ b/docs/source/installation/uv.md @@ -329,3 +329,13 @@ version satisfies the requirement. Change the line to, for example to pin the python version to `3.12`. Finally...
[ "docs/source/installation/uv.md" ]
[ { "comment": "```suggestion\n:::{dropdown} Installing the latest development version\n```", "path": "docs/source/installation/uv.md", "hunk": "@@ -329,3 +329,30 @@ version satisfies the requirement. Change the line to, for example\n to pin the python version to `3.12`. Finally, run `uv sync`, and your\n...
true
ManimCommunity/manim
4,456
comment_to_fix
Documentation: manual installation of manim as a local package
```suggestion If you want to install the latest (potentially unstable!) development version of Manim from our source repository [on GitHub](https://github.com/ManimCommunity/manim), then simply run ```
a6af7f3d7659c19f4761d0db5386ec22b3324a4a
b74a010149f7185688c53c79bee8f79e66c9459d
diff --git a/docs/source/installation/uv.md b/docs/source/installation/uv.md index ab2ccec554..c4cf17e6cb 100644 --- a/docs/source/installation/uv.md +++ b/docs/source/installation/uv.md @@ -329,3 +329,13 @@ version satisfies the requirement. Change the line to, for example to pin the python version to `3.12`. Finally...
[ "docs/source/installation/uv.md" ]
[ { "comment": "```suggestion\nIf you want to install the latest (potentially unstable!)\ndevelopment version of Manim from our source repository\n[on GitHub](https://github.com/ManimCommunity/manim), then\nsimply run\n```", "path": "docs/source/installation/uv.md", "hunk": "@@ -329,3 +329,30 @@ version s...
true
ManimCommunity/manim
4,456
comment_to_fix
Documentation: manual installation of manim as a local package
The code fences here are not correct. Like in the sections above, I'd only mention the `uv` command. ````suggestion ``` uv add git+https://github.com/ManimCommunity/manim.git@main ``` ````
a6af7f3d7659c19f4761d0db5386ec22b3324a4a
b74a010149f7185688c53c79bee8f79e66c9459d
diff --git a/docs/source/installation/uv.md b/docs/source/installation/uv.md index ab2ccec554..c4cf17e6cb 100644 --- a/docs/source/installation/uv.md +++ b/docs/source/installation/uv.md @@ -329,3 +329,13 @@ version satisfies the requirement. Change the line to, for example to pin the python version to `3.12`. Finally...
[ "docs/source/installation/uv.md" ]
[ { "comment": "The code fences here are not correct. Like in the sections above, I'd only mention the `uv` command.\n\n````suggestion\n```\nuv add git+https://github.com/ManimCommunity/manim.git@main\n```\n````", "path": "docs/source/installation/uv.md", "hunk": "@@ -329,3 +329,30 @@ version satisfies th...
true
ManimCommunity/manim
4,456
comment_to_fix
Documentation: manual installation of manim as a local package
This seems very specific, you shouldn't ever really need to install cibuildwheel or bandersnatch just if you want to get a specific commit. I'd delete this section from the dropdown. ```suggestion ```
a6af7f3d7659c19f4761d0db5386ec22b3324a4a
b74a010149f7185688c53c79bee8f79e66c9459d
diff --git a/docs/source/installation/uv.md b/docs/source/installation/uv.md index ab2ccec554..c4cf17e6cb 100644 --- a/docs/source/installation/uv.md +++ b/docs/source/installation/uv.md @@ -329,3 +329,13 @@ version satisfies the requirement. Change the line to, for example to pin the python version to `3.12`. Finally...
[ "docs/source/installation/uv.md" ]
[ { "comment": "This seems very specific, you shouldn't ever really need to install cibuildwheel or bandersnatch just if you want to get a specific commit. I'd delete this section from the dropdown.\n\n\n```suggestion\n```", "path": "docs/source/installation/uv.md", "hunk": "@@ -329,3 +329,30 @@ version s...
true
ManimCommunity/manim
4,503
issue_to_patch
Cleanup `TipableVMobject`: avoid mutable default and fix `assign_tip_attr` typo
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? <!-- If there is more information than the PR title that should be added to our release changelog, add ...
e34e70785814ccca49e451eb0d3d5828bdeb5309
475166f17e9b1395bf889b92724bcf8927cf3df2
diff --git a/manim/mobject/geometry/arc.py b/manim/mobject/geometry/arc.py index d78a3622ba..32b1133a6b 100644 --- a/manim/mobject/geometry/arc.py +++ b/manim/mobject/geometry/arc.py @@ -101,12 +101,12 @@ def __init__( self, tip_length: float = DEFAULT_ARROW_TIP_LENGTH, normal_vector: Vector3...
[ "manim/mobject/geometry/arc.py", "manim/mobject/opengl/opengl_geometry.py" ]
[]
true
ManimCommunity/manim
4,600
issue_to_patch
Fix publish release workflow
Our publish workflow has -- yet again -- failed (see https://github.com/ManimCommunity/manim/actions/runs/22245001472/job/64356983357). These changes simplify the action a bit and add the missing write permission.
704830ff5f0a97ad9e5ed251979c60ce88a715e1
f17f501d061be2cda07eb6213ef6d0088b7a25c5
diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index fa8c5c9085..771973407a 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -11,6 +11,7 @@ jobs: environment: release permissions: id-token: write + contents: w...
[ ".github/workflows/python-publish.yml" ]
[ { "comment": "While I think this code itself is fine, might be a good idea to specify `shell: bash`?", "path": ".github/workflows/python-publish.yml", "hunk": "@@ -37,37 +37,10 @@ jobs:\n with:\n path: dist/*.tar.gz\n name: manim.tar.gz\n- - name: Install Dependency\n- ...
true
ManimCommunity/manim
4,600
comment_to_fix
Fix publish release workflow
While I think this code itself is fine, might be a good idea to specify `shell: bash`?
704830ff5f0a97ad9e5ed251979c60ce88a715e1
f17f501d061be2cda07eb6213ef6d0088b7a25c5
diff --git a/.github/workflows/python-publish.yml b/.github/workflows/python-publish.yml index fa8c5c9085..771973407a 100644 --- a/.github/workflows/python-publish.yml +++ b/.github/workflows/python-publish.yml @@ -11,6 +11,7 @@ jobs: environment: release permissions: id-token: write + contents: w...
[ ".github/workflows/python-publish.yml" ]
[ { "comment": "While I think this code itself is fine, might be a good idea to specify `shell: bash`?", "path": ".github/workflows/python-publish.yml", "hunk": "@@ -37,37 +37,10 @@ jobs:\n with:\n path: dist/*.tar.gz\n name: manim.tar.gz\n- - name: Install Dependency\n- ...
true
ManimCommunity/manim
4,599
issue_to_patch
Prepare new release, `v0.20.0`
See title.
95047579181d527345d7fb12b5681798611b1f0e
b4dcd86ca9fc7e0bb8123b121a92fa175bedff0c
diff --git a/CITATION.cff b/CITATION.cff index c010e3833d..67f10c8f44 100644 --- a/CITATION.cff +++ b/CITATION.cff @@ -4,10 +4,10 @@ authors: - name: "The Manim Community Developers" cff-version: "1.2.0" -date-released: 2026-01-17 +date-released: 2026-02-20 license: MIT message: "We acknowledge the importanc...
[ "CITATION.cff", "docs/source/changelog.rst", "docs/source/changelog/0.20.0-changelog.md", "pyproject.toml", "scripts/release.py", "uv.lock" ]
[ { "comment": "```suggestion\n* Enable `strict=True` for `zip()` where safe by {user}`Oll-iver` in {pr}`4547`\n```", "path": "docs/source/changelog/0.20.0-changelog.md", "hunk": "@@ -0,0 +1,85 @@\n+---\n+short-title: v0.20.0\n+description: Changelog for v0.20.0\n+---\n+\n+# v0.20.0\n+\n+Date\n+: Februar...
true
ManimCommunity/manim
4,599
comment_to_fix
Prepare new release, `v0.20.0`
```suggestion * Enable `strict=True` for `zip()` where safe by {user}`Oll-iver` in {pr}`4547` ```
95047579181d527345d7fb12b5681798611b1f0e
b4dcd86ca9fc7e0bb8123b121a92fa175bedff0c
diff --git a/docs/source/changelog/0.20.0-changelog.md b/docs/source/changelog/0.20.0-changelog.md new file mode 100644 index 0000000000..349212c53e --- /dev/null +++ b/docs/source/changelog/0.20.0-changelog.md @@ -0,0 +1,86 @@ +--- +short-title: v0.20.0 +description: Changelog for v0.20.0 +--- + +# v0.20.0 + +Date +: ...
[ "docs/source/changelog/0.20.0-changelog.md" ]
[ { "comment": "```suggestion\n* Enable `strict=True` for `zip()` where safe by {user}`Oll-iver` in {pr}`4547`\n```", "path": "docs/source/changelog/0.20.0-changelog.md", "hunk": "@@ -0,0 +1,85 @@\n+---\n+short-title: v0.20.0\n+description: Changelog for v0.20.0\n+---\n+\n+# v0.20.0\n+\n+Date\n+: Februar...
true
ManimCommunity/manim
4,599
comment_to_fix
Prepare new release, `v0.20.0`
```suggestion * Add `py.typed` to declare manim as having type hints by {user}`Timmmm` in {pr}`4553` ``` to be consistent with the above `mypy.ini`
95047579181d527345d7fb12b5681798611b1f0e
b4dcd86ca9fc7e0bb8123b121a92fa175bedff0c
diff --git a/docs/source/changelog/0.20.0-changelog.md b/docs/source/changelog/0.20.0-changelog.md new file mode 100644 index 0000000000..349212c53e --- /dev/null +++ b/docs/source/changelog/0.20.0-changelog.md @@ -0,0 +1,86 @@ +--- +short-title: v0.20.0 +description: Changelog for v0.20.0 +--- + +# v0.20.0 + +Date +: ...
[ "docs/source/changelog/0.20.0-changelog.md" ]
[ { "comment": "```suggestion\n* Add `py.typed` to declare manim as having type hints by {user}`Timmmm` in {pr}`4553`\n```\nto be consistent with the above `mypy.ini`", "path": "docs/source/changelog/0.20.0-changelog.md", "hunk": "@@ -0,0 +1,85 @@\n+---\n+short-title: v0.20.0\n+description: Changelog for ...
true
ManimCommunity/manim
4,599
comment_to_fix
Prepare new release, `v0.20.0`
```suggestion * docs: improve `TransformFromCopy` docstring by {user}`GoThrones` in {pr}`4597` ```
95047579181d527345d7fb12b5681798611b1f0e
b4dcd86ca9fc7e0bb8123b121a92fa175bedff0c
diff --git a/docs/source/changelog/0.20.0-changelog.md b/docs/source/changelog/0.20.0-changelog.md new file mode 100644 index 0000000000..349212c53e --- /dev/null +++ b/docs/source/changelog/0.20.0-changelog.md @@ -0,0 +1,86 @@ +--- +short-title: v0.20.0 +description: Changelog for v0.20.0 +--- + +# v0.20.0 + +Date +: ...
[ "docs/source/changelog/0.20.0-changelog.md" ]
[ { "comment": "```suggestion\n* docs: improve `TransformFromCopy` docstring by {user}`GoThrones` in {pr}`4597`\n```", "path": "docs/source/changelog/0.20.0-changelog.md", "hunk": "@@ -0,0 +1,86 @@\n+---\n+short-title: v0.20.0\n+description: Changelog for v0.20.0\n+---\n+\n+# v0.20.0\n+\n+Date\n+: Februar...
true
ManimCommunity/manim
4,598
issue_to_patch
Reduce dependency on scipy - replace `scipy.special.comb` with `math.comb`
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? This PR replaces `scipy.special.comb` with `math.comb` in `simple_functions.py`'s `choose` method. ...
7eab4c5450f6ded540d0dd693e35516bf0c85d9e
8b7a3a40b71179f57aefecfac673be53bc60e57a
diff --git a/manim/utils/simple_functions.py b/manim/utils/simple_functions.py index 792b7764d6..317ea9ba4b 100644 --- a/manim/utils/simple_functions.py +++ b/manim/utils/simple_functions.py @@ -9,13 +9,12 @@ "sigmoid", ] - +import math from collections.abc import Callable from functools import lru_cache fro...
[ "manim/utils/simple_functions.py" ]
[]
true
ManimCommunity/manim
4,590
issue_to_patch
[Experimental] Remove `_Uniforms`, `_Data` and some shader logic from `Mobject`s
In PR #4578, attributes marked as `_Uniforms` or `_Data` descriptors caused trouble in `OpenGLMobject._add_intrinsic_animation_overrides()`. I then realized that `OpenGLMobject` attributes `uniforms` and `data` were gone long ago in favor of the plan of removing the shader logic which was directly embedded into Mobject...
186ad964bb7981541eeb79d66f1203fe7ab978ab
f685ab6b7f195f5f6ba66c33ad97009483f7a91c
diff --git a/manim/mobject/opengl/opengl_mobject.py b/manim/mobject/opengl/opengl_mobject.py index b89831d536..5643d6fd7f 100644 --- a/manim/mobject/opengl/opengl_mobject.py +++ b/manim/mobject/opengl/opengl_mobject.py @@ -322,16 +322,6 @@ def init_points(self) -> None: # Typically implemented in subclass, unl...
[ "manim/mobject/opengl/opengl_mobject.py", "manim/mobject/opengl/opengl_point_cloud_mobject.py", "manim/mobject/opengl/opengl_surface.py", "manim/mobject/opengl/opengl_vectorized_mobject.py", "manim/utils/config_ops.py", "tests/module/mobject/mobject/test_bounding_box.py", "tests/module/mobject/mobject/t...
[]
diff --git a/tests/module/mobject/mobject/test_bounding_box.py b/tests/module/mobject/mobject/test_bounding_box.py new file mode 100644 index 0000000000..cb34cbb569 --- /dev/null +++ b/tests/module/mobject/mobject/test_bounding_box.py @@ -0,0 +1,22 @@ +from __future__ import annotations + +import numpy as np + +from ma...
true
ManimCommunity/manim
4,596
issue_to_patch
v0.18.1 weird behavior of Axes().coords_to_point / Axes().c2p ## Description of bug / unexpected behavior According to the documentation, the argument of `.c2p()` may be individual values for x, y (and z), as well as lists, lists of lists and `numpy.array`s. However, when using just lists `[x,y,z]` or 1D np.arrays th...
Fix c2p/coords_to_point with single flat list or 1D array input
## Summary Fixes #4073 When a single flat list or 1D numpy array is passed to `Axes.coords_to_point()` / `Axes.c2p()`, the values are incorrectly interpreted as multiple x-coordinates instead of a single point: ```python ax = Axes() ax.c2p(1, 2) # Correct: [0.857, 1.5, 0.0] ax.c2p([1, 2]) # Bef...
ab7cfc54d8c6e02f7e25f1074709b74fe85a0615
2e75efa3604b2ee00e49df8590970985e14cb3ae
diff --git a/manim/mobject/graphing/coordinate_systems.py b/manim/mobject/graphing/coordinate_systems.py index a57ab2f16f..6b8237827f 100644 --- a/manim/mobject/graphing/coordinate_systems.py +++ b/manim/mobject/graphing/coordinate_systems.py @@ -2089,6 +2089,10 @@ def coords_to_point( ``ax.coords_to_poi...
[ "manim/mobject/graphing/coordinate_systems.py" ]
[]
true
ManimCommunity/manim
4,594
issue_to_patch
Add new Animation Builder `Mobject.always`
This is a version of #3852 that is more conservative, in that it doesn't move the animation builders into their own file. In a sense, it's the minimum change needed for `Mobject.always` to be implemented. ### Motivation Allows for syntax like ```py d = Dot() s = Square() d.always.next_to(s, UP) self.add(s, d) ...
ab17eb58a3f292384b8faef8decee9f57e9fb3a5
d0694e03377f79a4ba9c55991743075a7c8e0b3d
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 401b2e4829..964ce661f9 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -394,6 +394,42 @@ def construct(self): """ return _AnimationBuilder(self) + @property + def always(self) -> Self: + """Ca...
[ "manim/mobject/mobject.py", "tests/module/animation/test_updaters.py" ]
[]
diff --git a/tests/module/animation/test_updaters.py b/tests/module/animation/test_updaters.py index 50a2716b54..d8782fbcd4 100644 --- a/tests/module/animation/test_updaters.py +++ b/tests/module/animation/test_updaters.py @@ -1,6 +1,6 @@ from __future__ import annotations -from manim import Circle, FadeIn +from man...
true
ManimCommunity/manim
4,586
issue_to_patch
Add type annotations to `point_cloud_mobject.py`
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? More work on #3375. ## Motivation and Explanation: Why and how do your changes improve the library...
601a007192048ce6af460a10136f1e0c8f3dedaa
941f32c40c32063ec48aeca6c0cacf172b49b38a
diff --git a/manim/mobject/mobject.py b/manim/mobject/mobject.py index 964ce661f9..14738d22a7 100644 --- a/manim/mobject/mobject.py +++ b/manim/mobject/mobject.py @@ -17,7 +17,7 @@ from collections.abc import Callable, Iterable from functools import partialmethod, reduce from pathlib import Path -from typing import ...
[ "manim/mobject/mobject.py", "manim/mobject/types/image_mobject.py", "manim/mobject/types/point_cloud_mobject.py", "mypy.ini" ]
[ { "comment": "After thinking about it for a while, I don't think that typing `Mobject.get_array_attrs()` as returning `list[Literal[\"points\", \"rgbas\"]]` because `PMobject.get_array_attrs()` returns `[\"points\", \"rgbas\"]` is the most correct solution.\n\nI would say that both methods should be typehinted ...
true
ManimCommunity/manim
4,536
issue_to_patch
Add type annotations to ```opengl_image_mobject.py```
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? More work on #3375 <!-- If there is more information than the PR title that should be added to our re...
a5d4ab134caec5ab2a41a4d1d79502e22066eec7
4436d14efec3f514393081ccd64abaf388f08592
diff --git a/manim/mobject/opengl/opengl_image_mobject.py b/manim/mobject/opengl/opengl_image_mobject.py index 84e3ef7ad6..d7617d3ffb 100644 --- a/manim/mobject/opengl/opengl_image_mobject.py +++ b/manim/mobject/opengl/opengl_image_mobject.py @@ -5,6 +5,7 @@ ] from pathlib import Path +from typing import TYPE_CHECK...
[ "manim/mobject/opengl/opengl_image_mobject.py", "manim/mobject/opengl/opengl_surface.py", "mypy.ini" ]
[]
true
ManimCommunity/manim
4,593
issue_to_patch
Fix assertion in `ImageMobjectFromCamera.interpolate_color()`
When reviewing PR #4458, I missed an assertion in `ImageMobjectFromCamera.interpolate_color()` causing an error because the types of the Mobjects passed as parameters should have been `ImageMobjectFromCamera`, not `ImageMobject`. This is causing an example scene using `MovingScene` to crash. This PR fixes that.
761bc46cc844a776ec1928c017f645d7207f4380
ecece95c2954ece5031d685695cf5955141db21d
diff --git a/manim/mobject/types/image_mobject.py b/manim/mobject/types/image_mobject.py index 34f7b07de1..6b47a23c41 100644 --- a/manim/mobject/types/image_mobject.py +++ b/manim/mobject/types/image_mobject.py @@ -353,8 +353,8 @@ def add_display_frame(self, **kwargs: Any) -> Self: def interpolate_color( ...
[ "manim/mobject/types/image_mobject.py" ]
[]
true
ManimCommunity/manim
4,585
issue_to_patch
Add type annotations to `opengl_compatibility.py`
<!-- Thank you for contributing to Manim! Learn more about the process in our contributing guidelines: https://docs.manim.community/en/latest/contributing.html --> ## Overview: What does this pull request change? A little more work on completing #3375 ## Motivation and Explanation: Why and how do your changes ...
c8db165825aca1f5eb926f83466faf21c3ec1a15
e879e767b73dea4a716ee62f8575d0e86e5e16d5
diff --git a/manim/mobject/opengl/opengl_compatibility.py b/manim/mobject/opengl/opengl_compatibility.py index 94991d544e..761cd32918 100644 --- a/manim/mobject/opengl/opengl_compatibility.py +++ b/manim/mobject/opengl/opengl_compatibility.py @@ -1,6 +1,7 @@ from __future__ import annotations from abc import ABCMet...
[ "manim/mobject/opengl/opengl_compatibility.py", "mypy.ini" ]
[ { "comment": "I just tested locally and `namespace` is, more specifically, a `dict[str, Any]`:\n```suggestion\n def __new__(\n mcls, name: str, bases: tuple[type, ...], namespace: dict[str, Any]\n ) -> type:\n```", "path": "manim/mobject/opengl/opengl_compatibility.py", "hunk": "@@ -19,13 +...
true
ManimCommunity/manim
4,585
comment_to_fix
Add type annotations to `opengl_compatibility.py`
I just tested locally and `namespace` is, more specifically, a `dict[str, Any]`: ```suggestion def __new__( mcls, name: str, bases: tuple[type, ...], namespace: dict[str, Any] ) -> type: ```
c8db165825aca1f5eb926f83466faf21c3ec1a15
e879e767b73dea4a716ee62f8575d0e86e5e16d5
diff --git a/manim/mobject/opengl/opengl_compatibility.py b/manim/mobject/opengl/opengl_compatibility.py index 94991d544e..761cd32918 100644 --- a/manim/mobject/opengl/opengl_compatibility.py +++ b/manim/mobject/opengl/opengl_compatibility.py @@ -1,6 +1,7 @@ from __future__ import annotations from abc import ABCMet...
[ "manim/mobject/opengl/opengl_compatibility.py" ]
[ { "comment": "I just tested locally and `namespace` is, more specifically, a `dict[str, Any]`:\n```suggestion\n def __new__(\n mcls, name: str, bases: tuple[type, ...], namespace: dict[str, Any]\n ) -> type:\n```", "path": "manim/mobject/opengl/opengl_compatibility.py", "hunk": "@@ -19,13 +...
true
ManimCommunity/manim
4,585
comment_to_fix
Add type annotations to `opengl_compatibility.py`
```suggestion def __init__(cls, name: str, bases: tuple[type, ...], namespace: dict[str, Any]): ```
c8db165825aca1f5eb926f83466faf21c3ec1a15
e879e767b73dea4a716ee62f8575d0e86e5e16d5
diff --git a/manim/mobject/opengl/opengl_compatibility.py b/manim/mobject/opengl/opengl_compatibility.py index 94991d544e..761cd32918 100644 --- a/manim/mobject/opengl/opengl_compatibility.py +++ b/manim/mobject/opengl/opengl_compatibility.py @@ -1,6 +1,7 @@ from __future__ import annotations from abc import ABCMet...
[ "manim/mobject/opengl/opengl_compatibility.py" ]
[ { "comment": "```suggestion\n def __init__(cls, name: str, bases: tuple[type, ...], namespace: dict[str, Any]):\n```", "path": "manim/mobject/opengl/opengl_compatibility.py", "hunk": "@@ -40,6 +41,6 @@ def __new__(mcls, name, bases, namespace):\n \n return super().__new__(mcls, name, bases, n...
true
ManimCommunity/manim
4,584
issue_to_patch
Cleaned up `mypy.ini`
Updated the list of ignores modules when checking type errors with mypy. This command line shown below was helpful with updating `mypy.ini`. It should be run after having removed all entries in `mypy.ini` that ignores specific modules. The command first lets mypy find all type errors in the code base and then prep...
7efa45492f3eedd44925a031f93a7e5517da01e2
bcca8f7cfe4a73bf17095bc9166eafcc26d6f720
diff --git a/mypy.ini b/mypy.ini index ba90aad29f..fa00d6afce 100644 --- a/mypy.ini +++ b/mypy.ini @@ -52,27 +52,15 @@ warn_return_any = True # # disable_recursive_aliases = True -[mypy-manim.__main__] -ignore_errors = True - [mypy-manim._config.utils] ignore_errors = True -[mypy-manim._config.cli_colors] -igno...
[ "mypy.ini" ]
[]
true
MassTransit/MassTransit
6,216
issue_to_patch
Fix BusOutboxDeliveryService infinite retry loop on send fault
## Summary Fixes an infinite retry loop in the persistent bus outbox (`BusOutboxDeliveryService`) where a single un-sendable message pins the background worker at 100% CPU and prevents every other outbox from shipping — until the host process is restarted. Affects both the EF Core and MongoDB persistence implementatio...
b47d3df8f3ec4f2cd95d612232094e7ef3712821
c027b333744c22b20f8c12c1d302806f782d3a2c
diff --git a/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/EntityFrameworkCoreIntegration/BusOutboxDeliveryService.cs b/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/EntityFrameworkCoreIntegration/BusOutboxDeliveryService.cs index 5bb962a0951..2cb2afe07cd 100644 --- a/src/Persistence/MassTrans...
[ "src/Persistence/MassTransit.EntityFrameworkCoreIntegration/EntityFrameworkCoreIntegration/BusOutboxDeliveryService.cs", "src/Persistence/MassTransit.MongoDbIntegration/MongoDbIntegration/BusOutboxDeliveryService.cs", "tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/BusOutbox_Specs.cs" ...
[ { "comment": "`executeResult == 0` can also occur when an outbox is already marked `Delivered` and is being removed (`continueProcessing = 0` in `Execute()` when `outboxState.Delivered.HasValue`). With the new `if (executeResult <= 0) break;`, a single delivered/cleanup outbox at the head of the queue will caus...
diff --git a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/BusOutbox_Specs.cs b/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/BusOutbox_Specs.cs index e6a2ba0acbe..2955871cb3f 100644 --- a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/BusO...
true
MassTransit/MassTransit
6,195
issue_to_patch
v8.5.8
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
855cf1752c94ca9498e0c45ce8d09fdc9e957dd6
c1e5caa9a49ba4e56dbad6ed1b9c8f7843a9dba5
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cae788367bc..e18a448033e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.7 + MASSTRANSIT_VERSION: 8.5.8 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/app.vue", "src/MassTransit.Abstractions/Util/ExceptionUtil.cs", "src/MassTransit/JobService/JobAttemptStateMachine.cs", "src/MassTransit/JobService/JobStateMachine.cs", "src/MassTransit/JobService/JobTypeStateMachine.cs", "src/Transports/...
[]
true
MassTransit/MassTransit
6,173
issue_to_patch
feat: Add configurable visibility timeout renewal
Made the visibility timeout extension configurable for Amazon SQS instead of the default 60 seconds. As there are use cases where in case of background task the compute is known to take more than 2 hours. In such cases if we use the default 60 seconds of extension when the default timeout of a message is set to 1 hour,...
d964e8ff82e756e2562a77f3e924b45a3c4cc0b8
fe5a7da852599c4667bfd57a734ea009f9965549
diff --git a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs b/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs index 9e9ef5a8246..b8b09368e20 100644 --- a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Amaz...
[ "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/ReceiveSettings.cs", "...
[ { "comment": "I'm not a fan of the name, it isn't an extension it's something in the middle, not the minimum but the maximum in this case. MaxVisibilityTimeout is already used. MaxVisibilityTimeoutRenewal or something perhaps.", "path": "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Conf...
true
MassTransit/MassTransit
6,173
comment_to_fix
feat: Add configurable visibility timeout renewal
I'm not a fan of the name, it isn't an extension it's something in the middle, not the minimum but the maximum in this case. MaxVisibilityTimeout is already used. MaxVisibilityTimeoutRenewal or something perhaps.
d964e8ff82e756e2562a77f3e924b45a3c4cc0b8
fe5a7da852599c4667bfd57a734ea009f9965549
diff --git a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs b/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs index 6b15aa7640a..defa5c64fdb 100644 --- a/src/Transports/MassTr...
[ "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs" ]
[ { "comment": "I'm not a fan of the name, it isn't an extension it's something in the middle, not the minimum but the maximum in this case. MaxVisibilityTimeout is already used. MaxVisibilityTimeoutRenewal or something perhaps.", "path": "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Conf...
true
MassTransit/MassTransit
6,162
issue_to_patch
v8.5.7
Finally resolves ActiveMQ CVE
b0c39878222627229dd1cf2b65e860e79cc762c5
855cf1752c94ca9498e0c45ce8d09fdc9e957dd6
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f991a839006..cae788367bc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.6 + MASSTRANSIT_VERSION: 8.5.7 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props" ]
[]
true
MassTransit/MassTransit
6,150
issue_to_patch
Bump Apache.NMS.AMQP to 2.4.0 to address CVE-2025-54539
Bumping Apache.NMS.AMQP package from 2.2.0 -> 2.4.0 to address [CVE-2025-54539](https://nvd.nist.gov/vuln/detail/CVE-2025-54539). The 2.3.0 and 2.4.0 releases contain the following changes: * [2.3.0](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311201&version=12355896) * [2.4.0](https://iss...
b0c39878222627229dd1cf2b65e860e79cc762c5
ee011331a13e6650e2227a182fe1ccbb115d290d
diff --git a/Directory.Packages.props b/Directory.Packages.props index e61bcd533c5..a7fe3f54cc2 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -3,8 +3,8 @@ <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> </PropertyGroup> <ItemGroup> - <PackageVersion Include=...
[ "Directory.Packages.props" ]
[]
true
MassTransit/MassTransit
6,159
issue_to_patch
v8.5.6 (.NET 10 update)
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
e2e54ca475ec334e2c44bca1538720904ced69df
b0c39878222627229dd1cf2b65e860e79cc762c5
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 92165640895..f991a839006 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.5 + MASSTRANSIT_VERSION: 8.5.6 on: push: paths: @@ -36,9 +36,9 @...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/content/1.introduction/v9-announcement.md", "doc/content/4.support/0.index.md", "src/MassTransit.Abstractions/MassTransit.Abstractions.csproj", "src/MassTransit.Interop.NServiceBus/MassTransit.Interop.NServiceBus.csproj", "src/MassTransit.M...
[]
diff --git a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/Outbox_Specs.cs b/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/Outbox_Specs.cs index baa8e871527..e57b154ed67 100644 --- a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/ReliableMessaging/Outbox_Spe...
true
MassTransit/MassTransit
6,132
issue_to_patch
v8.5.5
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
6803ed9a0bef6af09209848e01ded7e7663b82a6
e2e54ca475ec334e2c44bca1538720904ced69df
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d3e8fa53fb1..92165640895 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.4 + MASSTRANSIT_VERSION: 8.5.5 on: push: paths: diff --git a/src...
[ ".github/workflows/build.yml", "src/MassTransit.Abstractions/NewId/INewIdGenerator.cs", "src/MassTransit.Abstractions/NewId/NewId.cs", "src/MassTransit.Abstractions/NewId/NewIdGenerator.cs", "src/MassTransit/DependencyInjection/Configuration/JobServiceEndpointDefinition.cs", "src/MassTransit/DependencyInj...
[]
diff --git a/tests/MassTransit.Abstractions.Tests/NewId/NewId_Specs.cs b/tests/MassTransit.Abstractions.Tests/NewId/NewId_Specs.cs index fbcf9c8450d..56e486f5767 100644 --- a/tests/MassTransit.Abstractions.Tests/NewId/NewId_Specs.cs +++ b/tests/MassTransit.Abstractions.Tests/NewId/NewId_Specs.cs @@ -166,6 +166,38 @@ pu...
true
MassTransit/MassTransit
6,130
issue_to_patch
Add transaction configurability to EF saga repository
### Description In high-throughput scenarios, long-lived transactions can lead to connection pool exhaustion. This change introduces configurability around transaction usage, allowing developers to explicitly disable transactions when appropriate. ### Technical details Introduce _isTransactionEnabled to control tr...
d7f77a6d7dd791cfd1330fa9de1bde8978fcb481
283ee750ea522c404dcc0e1980f52acd21805970
diff --git a/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs b/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs index f463f4a21a0..76060addd7e 100644 ---...
[ "src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs", "src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/IEntityFrameworkSagaRepositoryConfigurator.cs", "src/Persistence/MassTransit.EntityFrameworkCoreIntegra...
[]
diff --git a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/TransactionConfiguration/Configurator_TransactionConfiguration_Specs.cs b/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/TransactionConfiguration/Configurator_TransactionConfiguration_Specs.cs new file mode 100644 index 00000000000..eb7af84b99f...
true
MassTransit/MassTransit
6,128
issue_to_patch
Add transaction configurability to EF saga repository
### Description In high-throughput scenarios, long-lived transactions can lead to connection pool exhaustion. This change introduces configurability around transaction usage, allowing developers to explicitly disable transactions when appropriate. ### Technical details Introduce `_isTransactionEnabled` to control ...
d7f77a6d7dd791cfd1330fa9de1bde8978fcb481
e03a274b07edc4d67dcea00abb33a9d26a6d92eb
diff --git a/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs b/src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs index f463f4a21a0..76060addd7e 100644 ---...
[ "src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/Configuration/EntityFrameworkSagaRepositoryConfigurator.cs", "src/Persistence/MassTransit.EntityFrameworkCoreIntegration/Configuration/IEntityFrameworkSagaRepositoryConfigurator.cs", "src/Persistence/MassTransit.EntityFrameworkCoreIntegra...
[ { "comment": "This should just be a property setter, not a method, to be consistent with every other property.", "path": "tests/MassTransit.EntityFrameworkCoreIntegration.Tests/TransactionConfiguration/Configurator_TransactionConfiguration_Specs.cs", "hunk": "@@ -0,0 +1,58 @@\n+namespace MassTransit.Ent...
diff --git a/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/TransactionConfiguration/Configurator_TransactionConfiguration_Specs.cs b/tests/MassTransit.EntityFrameworkCoreIntegration.Tests/TransactionConfiguration/Configurator_TransactionConfiguration_Specs.cs new file mode 100644 index 00000000000..eb7af84b99f...
true
MassTransit/MassTransit
6,117
issue_to_patch
v8.5.4
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
c616977d06d231c43bd4b0ef1151bf834fc818eb
6803ed9a0bef6af09209848e01ded7e7663b82a6
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9582ff869e7..d3e8fa53fb1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.3 + MASSTRANSIT_VERSION: 8.5.4 on: push: paths: diff --git a/src...
[ ".github/workflows/build.yml", "src/MassTransit.Abstractions/Internals/Extensions/TaskExtensions.cs", "src/MassTransit.Interop.NServiceBus/Serialization/NServiceBusHeaderAdapter.cs", "src/MassTransit/Clients/ClientRequestHandle.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqs...
[]
diff --git a/tests/MassTransit.Azure.ServiceBus.Core.Tests/StateMachineRequest_Specs.cs b/tests/MassTransit.Azure.ServiceBus.Core.Tests/StateMachineRequest_Specs.cs index ec57cf8abd8..06b982c196a 100644 --- a/tests/MassTransit.Azure.ServiceBus.Core.Tests/StateMachineRequest_Specs.cs +++ b/tests/MassTransit.Azure.Servic...
true
MassTransit/MassTransit
6,108
issue_to_patch
v8.5.3
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
96adb565f7cc311488d1df104549f924203be760
c616977d06d231c43bd4b0ef1151bf834fc818eb
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f0c495b3535..9582ff869e7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.2 + MASSTRANSIT_VERSION: 8.5.3 on: push: paths: @@ -33,7 +33,7 @...
[ ".github/workflows/build.yml", "Directory.Packages.props", "README.md", "doc/content/3.documentation/2.configuration/2.transports/2.rabbitmq.md", "src/MassTransit/Configuration/DependencyInjection/InboxCleanupServiceOptions.cs", "src/MassTransit/Consumers/Configuration/JobConsumerMessageConnector.cs", "...
[]
diff --git a/tests/MassTransit.EntityFrameworkIntegration.Tests/DbQuery.cs b/tests/MassTransit.EntityFrameworkIntegration.Tests/DbQuery.cs index 001185f4dc1..15b6ced1c98 100644 --- a/tests/MassTransit.EntityFrameworkIntegration.Tests/DbQuery.cs +++ b/tests/MassTransit.EntityFrameworkIntegration.Tests/DbQuery.cs @@ -1,6...
true
MassTransit/MassTransit
6,090
issue_to_patch
Improved clarity of warning on message loss
The new text is less complex and distinguishes publishers and listeners.
89468e3e74fbee0d9ba2dd6d5cd5d6b60a66aa45
2ba68ac80d762b20e3863157462d8f0f5f9c365f
diff --git a/doc/content/3.documentation/2.configuration/2.transports/2.rabbitmq.md b/doc/content/3.documentation/2.configuration/2.transports/2.rabbitmq.md index 184f529145c..b3a70374177 100755 --- a/doc/content/3.documentation/2.configuration/2.transports/2.rabbitmq.md +++ b/doc/content/3.documentation/2.configuratio...
[ "doc/content/3.documentation/2.configuration/2.transports/2.rabbitmq.md" ]
[]
true
MassTransit/MassTransit
6,060
issue_to_patch
v8.5.2
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
6a2f4c07dfe21c14ed78299d6d4b4f4cf57bb86c
96adb565f7cc311488d1df104549f924203be760
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d15da98895a..f0c495b3535 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.1 + MASSTRANSIT_VERSION: 8.5.2 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/content/3.documentation/1.concepts/6.requests.md", "doc/content/3.documentation/2.configuration/0.index.md", "src/MassTransit.Abstractions/Transports/PublishEndpoint.cs", "src/MassTransit/Futures/Futures/FutureRequest.cs", "src/MassTransit/...
[]
diff --git a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs index df0ba09c3b1..62e46d7555c 100644 --- a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs +++ b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs @@ -122,10 ...
true
MassTransit/MassTransit
6,052
issue_to_patch
Fix reference to Azure Service Bus documentation
Minor documentation fix I came across
ec8a7818ee81c6a9c86792f304ace868b11f4f77
138d6ac6cc31374da211dd0178640c9cf4bdde04
diff --git a/doc/content/3.documentation/2.configuration/0.index.md b/doc/content/3.documentation/2.configuration/0.index.md index 07c2a5cb203..e7bdbd19961 100755 --- a/doc/content/3.documentation/2.configuration/0.index.md +++ b/doc/content/3.documentation/2.configuration/0.index.md @@ -83,7 +83,7 @@ services.Configur...
[ "doc/content/3.documentation/2.configuration/0.index.md" ]
[]
true
MassTransit/MassTransit
6,050
issue_to_patch
Allow port in failover host configuration
Hello, When I tested failover with completely local Artemis cluster running on same host but on different ports, I figured out that there is no way how to configure it in MT. I add possibility to do it. If there is no port defined in a failover host the default will be used. Thank you.
9f46a6c4b7f5579f69650edd2b015621cda14f3e
af101926d0dbe0e80102455b3236647a24a82a50
diff --git a/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs b/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs index dff97555b09..ba356b40813 100644 --- a/src/Transports/MassTransit.ActiveMqTransport/Acti...
[ "src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs", "tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs" ]
[]
diff --git a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs index dc6aeb7c86f..62e46d7555c 100644 --- a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs +++ b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs @@ -136,7 +...
true
MassTransit/MassTransit
6,048
issue_to_patch
Fix ActiveMQ connection string creation for failover
This is fix for #6044 The root of problem is in creating connection string for ActiveMQ. In AMQP settings for failover need prefix failover. In OpenWire it is transport. I also added condition to accept settings with prefix and put them to correct part of connection string.
78d82a49764d110eaa743dbef4998415b5281963
da7481f3cbdf299509a00e71981cbb5ad7111deb
diff --git a/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/AmqpHostSettings.cs b/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/AmqpHostSettings.cs index 9e77daf8bc7..78a42846885 100644 --- a/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Conf...
[ "src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/AmqpHostSettings.cs", "src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs", "src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/OpenWireHostSettings.cs",...
[]
diff --git a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs index df0ba09c3b1..dc6aeb7c86f 100644 --- a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs +++ b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs @@ -122,10 ...
true
MassTransit/MassTransit
5,931
issue_to_patch
Avoid generating saga queries with embedded constants
Generating saga queries with embedded constants is not great for the EF Core query cache.
334a336c01fba5734cf8a16a6b050d5aee7178db
b6907d453fe45bcd87659decd8fc769483ef7862
diff --git a/src/MassTransit/Sagas/Saga/PropertyExpressionSagaQueryFactory.cs b/src/MassTransit/Sagas/Saga/PropertyExpressionSagaQueryFactory.cs index c4a73cc708b..9430b789e17 100644 --- a/src/MassTransit/Sagas/Saga/PropertyExpressionSagaQueryFactory.cs +++ b/src/MassTransit/Sagas/Saga/PropertyExpressionSagaQueryFactor...
[ "src/MassTransit/Sagas/Saga/PropertyExpressionSagaQueryFactory.cs" ]
[]
true
MassTransit/MassTransit
6,033
issue_to_patch
v8.5.1
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
9c1b9ef3228ac000bf2ed0c4e0a669a30f1431ae
6a2f4c07dfe21c14ed78299d6d4b4f4cf57bb86c
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6db5135acd1..d15da98895a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.5.0 + MASSTRANSIT_VERSION: 8.5.1 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/content/3.documentation/2.configuration/5.scheduling.md", "doc/content/3.documentation/3.patterns/13.job-consumers.md", "doc/content/4.support/3.samples.md", "doc/content/4.support/4.upgrade.md", "src/MassTransit.Abstractions/Internals/Exte...
[]
diff --git a/tests/MassTransit.RabbitMqTransport.Tests/KillSwitch_Specs.cs b/tests/MassTransit.RabbitMqTransport.Tests/KillSwitch_Specs.cs index d9507f205c0..02ca46f7396 100644 --- a/tests/MassTransit.RabbitMqTransport.Tests/KillSwitch_Specs.cs +++ b/tests/MassTransit.RabbitMqTransport.Tests/KillSwitch_Specs.cs @@ -1,8...
true
MassTransit/MassTransit
6,026
issue_to_patch
SendMessageBatchAsync has changed to return a null value for response.Failed
- Adds a check to prevent an exception accessing response.Failed when there are no failed messages response.Failed is null, which generates an exception. ![image](https://github.com/user-attachments/assets/d2a1a776-92bb-4c56-8b93-37f69bf7b255) The response was successful. ![image](https://github.com/user-attac...
1437b6e87f5e7cf1b03c0c1d783d0ef2dcb74a50
28038955d5d0222b89dbcec16e98358a6f479779
diff --git a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/SendBatcher.cs b/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/SendBatcher.cs index 8b66d4d8e02..d121684c45e 100644 --- a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/SendBatcher.cs +++ b/src/Transports/...
[ "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/SendBatcher.cs" ]
[]
true
MassTransit/MassTransit
6,021
issue_to_patch
feat(rabbitmq-stream): add support for consumer reference name
Introduced `Reference` property on `IRabbitMqStreamConfigurator` to allow specifying a consumer reference name used for server-side offset tracking. This value is applied to the "name" argument of the stream consumer. ## What I did to test 1. I made the code change to the MassTransit project 1. I ran this to get a...
cc49a66f420d330f6790831ac016dcb9e1aac821
08e092a07507111f7d3dd23e8acf2c113c4e707d
diff --git a/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqStreamConfigurator.cs b/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqStreamConfigurator.cs index e455d9a8ea7..180e5cf1ad2 100644 --- a/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqStreamConfigu...
[ "src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqStreamConfigurator.cs", "src/Transports/MassTransit.RabbitMqTransport/RabbitMqTransport/Configuration/RabbitMqStreamConfigurator.cs" ]
[]
true
MassTransit/MassTransit
6,015
issue_to_patch
docs: improve config guidance and clarify documentation
This PR updates the MassTransit job consumer documentation for clarity and correctness: - Fixed grammar in job scheduling section - Standardized use of “routing slip” (removed unnecessary hyphen) - Clarified job type saga state list to resolve contradiction in listed states - Updated `AddQuartz()` usage by removi...
9c1b9ef3228ac000bf2ed0c4e0a669a30f1431ae
a32f1708d9d60ed1fd0534c58ac9ad4fd99ff32f
diff --git a/doc/content/3.documentation/2.configuration/5.scheduling.md b/doc/content/3.documentation/2.configuration/5.scheduling.md index d13a97cc450..e11879eb032 100644 --- a/doc/content/3.documentation/2.configuration/5.scheduling.md +++ b/doc/content/3.documentation/2.configuration/5.scheduling.md @@ -303,13 +303...
[ "doc/content/3.documentation/2.configuration/5.scheduling.md", "doc/content/3.documentation/3.patterns/13.job-consumers.md", "doc/content/4.support/3.samples.md" ]
[]
true
MassTransit/MassTransit
6,009
issue_to_patch
Update KillSwitch.cs to activate StartedKillSwitchState when connecte…
…d to endpoint Fix a bug where attempt count does not get reset <!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
7706dff0002e91ae04dd5bdcd8648579225ecce6
7530d2aac935556c0b820e8c367d76de70fcc1d1
diff --git a/src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs b/src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs index 2d4d6a52c63..7b26be8ae8f 100644 --- a/src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs +++ b/src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs @@ ...
[ "src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs" ]
[ { "comment": "Well, now state can be `null`, which isn't ideal. Can it still be set here and started below in `Ready`?", "path": "src/MassTransit/Transports/Components/KillSwitch/KillSwitch.cs", "hunk": "@@ -26,8 +26,6 @@ public KillSwitch(KillSwitchOptions options)\n _options = options;\n \...
true
MassTransit/MassTransit
6,013
issue_to_patch
v8.5.0
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
8c7e467cd2edf26ecef95e98a99e3633a7325676
9c1b9ef3228ac000bf2ed0c4e0a669a30f1431ae
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e09b7dc0eec..6db5135acd1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.4.1 + MASSTRANSIT_VERSION: 8.5.0 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/content/4.support/4.upgrade.md", "src/MassTransit.Abstractions/Middleware/Configuration/ExceptionSpecification.cs", "src/MassTransit.TestFramework/FutureTestFixture.cs", "src/MassTransit.TestFramework/InMemoryTestFixture.cs", "src/MassTrans...
[]
diff --git a/tests/MassTransit.ActiveMqTransport.Tests/ActiveMqTestFixture.cs b/tests/MassTransit.ActiveMqTransport.Tests/ActiveMqTestFixture.cs index 26e33148ae2..e6b6850b9a3 100644 --- a/tests/MassTransit.ActiveMqTransport.Tests/ActiveMqTestFixture.cs +++ b/tests/MassTransit.ActiveMqTransport.Tests/ActiveMqTestFixtur...
true
MassTransit/MassTransit
5,966
issue_to_patch
Update the AWS packages to use AWS .NET SDK V4
We GA V4 of the AWS SDK for .NET: https://aws.amazon.com/blogs/developer/general-availability-of-aws-sdk-for-net-v4-0/ The PR updates the SDK dependencies to V4 and address any compilation and obsolete warnings triggered by the update. V4 does have a runtime behavior change where collection properties for types used...
3031bb73f1b16f716a08ba84ee2cbb860ae5dc53
575cf3e6bd29f337569cc805edf6366d6e8c435a
diff --git a/Directory.Packages.props b/Directory.Packages.props index d9efb8527db..effc1848485 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -5,10 +5,10 @@ <ItemGroup> <PackageVersion Include="Apache.NMS.ActiveMQ" Version="2.1.1" /> <PackageVersion Include="Apache.NMS.AMQP" Versi...
[ "Directory.Packages.props", "src/Persistence/MassTransit.DynamoDbIntegration/DynamoDbIntegration/Saga/DynamoDbDatabaseContext.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsClientContext.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsHeaderProv...
[ { "comment": "In V4 we obsoleted the versions that take the generic OperationConfig because it caused users confusion on what property to set. Now each of the operation has there own specific config.", "path": "src/Persistence/MassTransit.DynamoDbIntegration/DynamoDbIntegration/Saga/DynamoDbDatabaseContext....
true
MassTransit/MassTransit
5,568
issue_to_patch
Fixing failover parameters and adding priorityBackup and priorityURIs parameters
Hello. I encountered the fact that the failover transport parameters, such as randomize and backup, are not applied. The bug is in the implementation of the Apache.NMS.ActiveMQ client. When creating the transport, I need to add the prefix `"transport."` which is absent in the instruction https://activemq.apach...
4bf036f8ac5748409a20c0bf329ef3fb31651213
634c76c9f15ba4cf9ef2bec739c57d0f6957dd31
diff --git a/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs b/src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs index d6c32c84c2e..358e11e93e0 100644 --- a/src/Transports/MassTransit.ActiveMqTransport/Acti...
[ "src/Transports/MassTransit.ActiveMqTransport/ActiveMqTransport/Configuration/ConfigurationHostSettings.cs", "tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs" ]
[]
diff --git a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs index 654c433b7c9..8d77c93054a 100644 --- a/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs +++ b/tests/MassTransit.ActiveMqTransport.Tests/Configure_Specs.cs @@ -116,7 +...
true
MassTransit/MassTransit
5,977
issue_to_patch
Clarify description of RabbitMQ quorum queues replicationFactor configuration
Yep... I will be that guy and contribute the documentation PR :sweat_smile:
8c7e467cd2edf26ecef95e98a99e3633a7325676
31d8794e7c9963d9e314ce3068779bde495cf5e8
diff --git a/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqQueueConfigurator.cs b/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqQueueConfigurator.cs index 5d369bb38b5..8764ca106d1 100644 --- a/src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqQueueConfigurat...
[ "src/Transports/MassTransit.RabbitMqTransport/Configuration/IRabbitMqQueueConfigurator.cs" ]
[]
true
MassTransit/MassTransit
5,976
issue_to_patch
v8.4.1
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
c0977e09482f7f5e3585c9a59e67941a89fd2963
8c7e467cd2edf26ecef95e98a99e3633a7325676
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7ae9f9f43a1..e09b7dc0eec 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.4.0 + MASSTRANSIT_VERSION: 8.4.1 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/content/0.index.md", "doc/content/1.introduction/v9-announcement.md", "doc/content/2.quick-starts/4.amazon-sqs.md", "doc/content/3.documentation/1.concepts/2.consumers.md", "doc/content/3.documentation/1.concepts/4.exceptions.md", "doc/co...
[]
diff --git a/tests/MassTransit.Abstractions.Tests/NewId/Generator_Specs.cs b/tests/MassTransit.Abstractions.Tests/NewId/Generator_Specs.cs index f6f72cd76c4..47a466fa7c2 100644 --- a/tests/MassTransit.Abstractions.Tests/NewId/Generator_Specs.cs +++ b/tests/MassTransit.Abstractions.Tests/NewId/Generator_Specs.cs @@ -11,...
true
MassTransit/MassTransit
5,672
issue_to_patch
feat: add job service extension that accepts the job + cancellation token
As the title suggests, this change introduces an additional extension to simplify cases where `setJobProperties` isn't required. This avoids having to pass `null` or a named parameter unnecessarily. For example, instead of writing: ```csharp await context.SubmitJob(new FileSystemProbe.Job { Path = entry.PathInf...
66405b6cf850c064af2b7edab0720b60729ab42c
05a95adf2f5e0e355dbbcdab4143f6a9c32c4073
diff --git a/src/MassTransit/JobService/JobServiceExtensions.cs b/src/MassTransit/JobService/JobServiceExtensions.cs index 48e263f7b1a..88411d81c3a 100644 --- a/src/MassTransit/JobService/JobServiceExtensions.cs +++ b/src/MassTransit/JobService/JobServiceExtensions.cs @@ -43,6 +43,20 @@ public static async Task<JobStat...
[ "src/MassTransit/JobService/JobServiceExtensions.cs" ]
[]
true
MassTransit/MassTransit
5,973
issue_to_patch
Updated documentation on configureError method in Error pipe
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! --> Updated documentation to explicitly tell that we need to include default filters in error pipe if we want to defin...
36d888e8d6ef5c2aff290d7cb911cfdcea6ba8a2
48bd0f7f76213a531ab18bac784ee1106e18018b
diff --git a/doc/content/3.documentation/1.concepts/4.exceptions.md b/doc/content/3.documentation/1.concepts/4.exceptions.md index 689205d57f2..a978d2fbe9c 100644 --- a/doc/content/3.documentation/1.concepts/4.exceptions.md +++ b/doc/content/3.documentation/1.concepts/4.exceptions.md @@ -343,7 +343,7 @@ cfg.ReceiveEndp...
[ "doc/content/3.documentation/1.concepts/4.exceptions.md" ]
[]
true
MassTransit/MassTransit
5,968
issue_to_patch
Use context.CancellationToken in Forward
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
8526cf9c9251563388684dfd5cbe5d7f66966453
b061736bd23a786ca1ceb9c60704e35a04e9d09c
diff --git a/src/MassTransit/ForwardExtensions.cs b/src/MassTransit/ForwardExtensions.cs index f93d147c554..14c16c738d2 100644 --- a/src/MassTransit/ForwardExtensions.cs +++ b/src/MassTransit/ForwardExtensions.cs @@ -84,7 +84,7 @@ void AddForwarderAddress(ConsumeContext consumeContext, SendContext sendContext) ...
[ "src/MassTransit/ForwardExtensions.cs" ]
[]
true
MassTransit/MassTransit
5,965
issue_to_patch
typo (changed withing => within)
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
dda57baf064f8070510d281ed66d69ca5095a95c
7a4809b99eebc57ed0206a0b8c3922ad0d71fd72
diff --git a/doc/content/3.documentation/2.configuration/2.transports/10.kafka.md b/doc/content/3.documentation/2.configuration/2.transports/10.kafka.md index 3e7cc9b6119..597bc83e6cf 100755 --- a/doc/content/3.documentation/2.configuration/2.transports/10.kafka.md +++ b/doc/content/3.documentation/2.configuration/2.tr...
[ "doc/content/3.documentation/2.configuration/2.transports/10.kafka.md", "doc/content/3.documentation/2.configuration/2.transports/11.azure-event-hub.md" ]
[]
true
MassTransit/MassTransit
5,963
issue_to_patch
Add configuration for capping maximum AWS SQS message visibility rene…
…wal. - Addresses https://github.com/MassTransit/MassTransit/discussions/5946
55c9ef310c913547929dc175f5e06bb71c879e55
909a787b7d7af1aea71b608e3d6bb949664a25cb
diff --git a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs b/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs index 4f4110fb860..ad803dce3ec 100644 --- a/src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Amaz...
[ "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/AmazonSqsReceiveLockContext.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs", "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/ReceiveSettings.cs", "...
[ { "comment": "Can you add validation to ensure the value is also greater than or equal to the visibility timeout? The Validate() method is where the check should be performed.", "path": "src/Transports/MassTransit.AmazonSqsTransport/AmazonSqsTransport/Configuration/AmazonSqsReceiveEndpointConfiguration.cs",...
true
MassTransit/MassTransit
5,098
issue_to_patch
Added duplicate check to group headers by Key before group into dicti…
This PR aims to resolve an issue with Kafka header serializers. When Kafka messages arrive with multiple duplicated headers, which can occur when working with external services (like NewRelic, etc.), MassTransit was throwing a "duplicate key entry" exception when attempting to insert these into a dictionary.
5fe32f707c3be4ff8b576707710a2fb5c8f857fd
143eac5b24889b760e3872754b001b3dca4a51b8
diff --git a/src/Transports/MassTransit.KafkaIntegration/KafkaIntegration/Serializers/DictionaryHeadersSerialize.cs b/src/Transports/MassTransit.KafkaIntegration/KafkaIntegration/Serializers/DictionaryHeadersSerialize.cs index aea36a8435f..e9ae3b35c63 100644 --- a/src/Transports/MassTransit.KafkaIntegration/KafkaIntegr...
[ "src/Transports/MassTransit.KafkaIntegration/KafkaIntegration/Serializers/DictionaryHeadersSerialize.cs", "tests/MassTransit.KafkaIntegration.Tests/DictionaryHeadersDeserializerTests.cs" ]
[]
diff --git a/tests/MassTransit.KafkaIntegration.Tests/DictionaryHeadersDeserializerTests.cs b/tests/MassTransit.KafkaIntegration.Tests/DictionaryHeadersDeserializerTests.cs index e0fdcd03f5a..2ecaf16ae71 100644 --- a/tests/MassTransit.KafkaIntegration.Tests/DictionaryHeadersDeserializerTests.cs +++ b/tests/MassTransit....
true
MassTransit/MassTransit
5,744
issue_to_patch
Add Configuration for Compression in AzureStorageMessageDataRepository for Claim Check
This update enables compression when using AzureStorageMessageDataRepository for claim check. Files will be compressed before being written to blob storage and saved as `.gz` files. ![image](https://github.com/user-attachments/assets/62e89ee5-a631-48d8-b6ab-1e3181e4bb08) On the consumer side, there is no need t...
874d3218fcd54e7168547688f784ece64395dde9
1481be575e6ce8147930ca9a4182737525e06d7c
diff --git a/doc/content/3.documentation/3.patterns/8.claim-check.md b/doc/content/3.documentation/3.patterns/8.claim-check.md index f0284808823..e2f3f9fe6d5 100644 --- a/doc/content/3.documentation/3.patterns/8.claim-check.md +++ b/doc/content/3.documentation/3.patterns/8.claim-check.md @@ -57,7 +57,7 @@ public async ...
[ "doc/content/3.documentation/3.patterns/8.claim-check.md", "src/Persistence/MassTransit.Azure.Storage/AzureStorage/MessageData/AzureStorageMessageDataRepository.cs", "src/Persistence/MassTransit.Azure.Storage/Configuration/AzureStorageConfigurationExtensions.cs", "src/Persistence/MassTransit.Azure.Storage/Con...
[ { "comment": "It seems like you're going to have some ownership/disposable issues with these streams to where they aren't closed and/or disposed properly.\r\n", "path": "src/Persistence/MassTransit.Azure.Storage/AzureStorage/MessageData/AzureStorageMessageDataRepository.cs", "hunk": "@@ -115,7 +118,8 @@...
diff --git a/tests/MassTransit.Azure.ServiceBus.Core.Tests/Configuration.cs b/tests/MassTransit.Azure.ServiceBus.Core.Tests/Configuration.cs index 4469a1d188d..cc0d52e3175 100644 --- a/tests/MassTransit.Azure.ServiceBus.Core.Tests/Configuration.cs +++ b/tests/MassTransit.Azure.ServiceBus.Core.Tests/Configuration.cs @@ ...
true
MassTransit/MassTransit
5,913
issue_to_patch
v8.4.0
<!-- Thank you for sending the PR! If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots! Happy contributing! -->
1a56bc49bec19037fa6a418c53a2c95ae9b309aa
c0977e09482f7f5e3585c9a59e67941a89fd2963
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fa088617d78..7ae9f9f43a1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,6 +1,6 @@ name: MassTransit env: - MASSTRANSIT_VERSION: 8.3.7 + MASSTRANSIT_VERSION: 8.4.0 on: push: paths: diff --git a/Dir...
[ ".github/workflows/build.yml", "Directory.Packages.props", "doc/app.config.ts", "doc/content/3.documentation/1.concepts/6.requests.md", "doc/content/3.documentation/2.configuration/0.index.md", "doc/content/3.documentation/2.configuration/4.persistence/dynamodb.md", "doc/content/3.documentation/2.config...
[]
diff --git a/tests/MassTransit.Benchmark/ActiveMqOptionSet.cs b/tests/MassTransit.Benchmark/ActiveMqOptionSet.cs index e4a87b61161..8e378c2f8bc 100644 --- a/tests/MassTransit.Benchmark/ActiveMqOptionSet.cs +++ b/tests/MassTransit.Benchmark/ActiveMqOptionSet.cs @@ -15,11 +15,11 @@ class ActiveMqOptionSet : pu...
true
MassTransit/MassTransit
5,906
issue_to_patch
Use Primary Constructors where applicable & Add docs for DynamoDB
This PR improves the documentation by: - Updating two sample code snippets in the Requests section to use primary constructors, making the examples more concise. - Adding an example for configuring DynamoDB as a SagaRepository, replacing a previously empty page. The updated snippets were tested in a sample proje...
ce62836b72937b147e6eda34ed7949c46ed2c280
013595326880b82662146c028aeb143472e715ec
diff --git a/doc/content/3.documentation/1.concepts/6.requests.md b/doc/content/3.documentation/1.concepts/6.requests.md index 743217dc66c..654d74753df 100644 --- a/doc/content/3.documentation/1.concepts/6.requests.md +++ b/doc/content/3.documentation/1.concepts/6.requests.md @@ -28,19 +28,12 @@ public record OrderStat...
[ "doc/content/3.documentation/1.concepts/6.requests.md", "doc/content/3.documentation/2.configuration/4.persistence/dynamodb.md" ]
[]
true