repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
tj/commander.js | 2,384 | issue_to_patch | List excess arguments in error message | Sometimes a typo in arguments list can be parsed as an excess argument rather than option. When the options list is long, finding it can be tricky, so it would be helpful to see exactly what arguments are treated as excess.
## Solution
Real life example by mistakenly adding spaces before # in systemd service file... | 395cf7145fe28122f5a69026b310e02df114f907 | c003325e5319afdb9c1a9a936677a58cd568f117 | diff --git a/lib/command.js b/lib/command.js
index c92b49b25..192e221c4 100644
--- a/lib/command.js
+++ b/lib/command.js
@@ -2149,8 +2149,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
const expected = this.registeredArguments.length;
const s = expected === 1 ? '' : 's';
+ const received = rec... | [
"lib/command.js",
"tests/command.exitOverride.test.js"
] | [
{
"comment": "This is the description of the behaviour in Commander v13, which has not changed.\r\n\r\nThe PR should not be updating the CHANGELOG.",
"path": "CHANGELOG.md",
"hunk": "@@ -74,7 +74,7 @@ Now shows an error:\n \n ```console\n $ node example.js a b c\n-error: too many arguments. Expected 0 a... | diff --git a/tests/command.exitOverride.test.js b/tests/command.exitOverride.test.js
index 994f8fdc0..65ae78383 100644
--- a/tests/command.exitOverride.test.js
+++ b/tests/command.exitOverride.test.js
@@ -183,7 +183,7 @@ describe('.exitOverride and error details', () => {
caughtErr,
1,
'commander.e... | true | |
tj/commander.js | 2,384 | comment_to_fix | List excess arguments in error message | This looks wrong, and unnecessary. You are comparing the values of the arguments with the names of the arguments? You just want to log all of receivedArgs? | 395cf7145fe28122f5a69026b310e02df114f907 | c003325e5319afdb9c1a9a936677a58cd568f117 | diff --git a/lib/command.js b/lib/command.js
index c92b49b25..192e221c4 100644
--- a/lib/command.js
+++ b/lib/command.js
@@ -2149,8 +2149,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
const expected = this.registeredArguments.length;
const s = expected === 1 ? '' : 's';
+ const received = rec... | [
"lib/command.js"
] | [
{
"comment": "This looks wrong, and unnecessary. You are comparing the values of the arguments with the names of the arguments? You just want to log all of receivedArgs?",
"path": "lib/command.js",
"hunk": "@@ -2150,7 +2150,9 @@ Expecting one of '${allowedValues.join(\"', '\")}'`);\n const expected ... | true | ||
tj/commander.js | 2,384 | comment_to_fix | List excess arguments in error message | Why are you slicing the arguments? I think it makes more sense to show them all. We don't know if there is an accidental extra argument on the start or on the end. | 395cf7145fe28122f5a69026b310e02df114f907 | c003325e5319afdb9c1a9a936677a58cd568f117 | diff --git a/lib/command.js b/lib/command.js
index c92b49b25..192e221c4 100644
--- a/lib/command.js
+++ b/lib/command.js
@@ -2149,8 +2149,10 @@ Expecting one of '${allowedValues.join("', '")}'`);
const expected = this.registeredArguments.length;
const s = expected === 1 ? '' : 's';
+ const received = rec... | [
"lib/command.js"
] | [
{
"comment": "Why are you slicing the arguments? I think it makes more sense to show them all. We don't know if there is an accidental extra argument on the start or on the end.",
"path": "lib/command.js",
"hunk": "@@ -2150,7 +2150,8 @@ Expecting one of '${allowedValues.join(\"', '\")}'`);\n const e... | true | ||
tj/commander.js | 2,485 | issue_to_patch | Use simple match in test (to avoid warning about expensive regex) | ## Problem
CodeQL reports:
> Polynomial regular expression used on uncontrolled data
for regex `assert(!/\W-h\W.*display help/.test(helpInformation));`
## Solution
This isn't a vulnerability since only used within test with controlled data, but want to fix warning/error anyway.
Just replace regex with... | 3f00f5bc8240bcac963654530c590895fb585884 | 44ad6638195cfc779fbfd5868d15aa3ba0f57f1b | [
"tests/command.help.test.js"
] | [] | diff --git a/tests/command.help.test.js b/tests/command.help.test.js
index 6046e034c..030cb858b 100644
--- a/tests/command.help.test.js
+++ b/tests/command.help.test.js
@@ -120,7 +120,9 @@ Commands:
const program = new commander.Command();
program.option('-h, --host', 'select host');
const helpInformatio... | true | ||
tj/commander.js | 2,486 | issue_to_patch | Use node:util stripVTControlCharacters instead of own code | ## Problem
I wrote my own `stripColor`, but discovered that node has had [stripVTControlCharacters](https://nodejs.org/docs/latest/api/util.html#utilstripvtcontrolcharactersstr) from Node 16.11.0
## Solution
Use `stripVTControlCharacters`. Easy!
This will strip some special sequences that the custom code di... | 3f00f5bc8240bcac963654530c590895fb585884 | ac89e186c48b4fe24e96be5f442937185b523ad2 | diff --git a/lib/command.js b/lib/command.js
index d8b810a6c..70989b815 100644
--- a/lib/command.js
+++ b/lib/command.js
@@ -3,10 +3,11 @@ import childProcess from 'node:child_process';
import path from 'node:path';
import fs from 'node:fs';
import process from 'node:process';
+import { stripVTControlCharacters } fr... | [
"lib/command.js",
"lib/help.js",
"tests/help.stripAnsi.test.js"
] | [] | diff --git a/tests/help.stripAnsi.test.js b/tests/help.stripAnsi.test.js
deleted file mode 100644
index 7590780d6..000000000
--- a/tests/help.stripAnsi.test.js
+++ /dev/null
@@ -1,69 +0,0 @@
-import { stripColor } from '../lib/help.js';
-import { test, describe } from 'node:test';
-import assert from 'node:assert/stric... | true | |
tj/commander.js | 2,523 | issue_to_patch | Fix release dates in changelog | a752ed909f179e3a5dcae31a890a89fb748473c4 | deb614de6f851392790e476ed0e0157afccef0e8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c75f18e5c..cab334506 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
-## [15.0.0] (2025-05-29)
+## [15.... | [
"CHANGELOG.md"
] | [] | true | |||
tj/commander.js | 2,521 | issue_to_patch | Pin GitHub actions with hash | ## Problem
1) Best practice to lower risk of supply chain attacks is to pin GitHub Actions to hash.
2) Can't manually run actions on branches (e.g. run CodeQL on `release/15.x`)
## Solution
1) Switch to hashes using `npx actions-up`. In theory, dependabot will update the cases and maintain the version numbe... | 74d5dfe9b7e199d98e2269ecf88dcf771c260983 | dcd55c163961bb1c6e29d033a7ebc7b06853d513 | diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index e9346a93c..2704f1624 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -8,6 +8,7 @@ on:
branches: [ master, develop ]
schedule:
- cron: '27 5 * * 6'
+ workflow_d... | [
".github/workflows/codeql-analysis.yml",
".github/workflows/tests.yml"
] | [] | true | ||
tj/commander.js | 2,520 | issue_to_patch | Drop EOL node 20 from test matrix, and add node 26 | Was going to leave out node 26 for now, but testing against latest release is useful, and will be LTS eventually. | 6df9b68b75ad8df1532ad3572e1d5a1c53bde6cd | 3f1047ae2842c09e4a1bd0e038ad5f537a7966da | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index c2986219e..5e8263600 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- node-version: [20.x, 22.x, 24.x]
+ node-version: [22.... | [
".github/workflows/tests.yml"
] | [] | true | ||
tj/commander.js | 2,519 | issue_to_patch | Update details for 15.0.0 release | Preparing for 15.0.0 release. I put in a date of next weekend, but we could do it this weekend if you like @abetomo ? Just when suits you, no rush.
For interest:
- the `15.0.0-0` version has had 4162 downloads from [npmjs](https://www.npmjs.com/package/commander?activeTab=versions), which is our most ever for a pr... | 01ce5d0cd7e845d6ed749ab57616ec9c173cf91f | c401b4b8a2ef29fe4c1fc852198ae02ee2a6b7fd | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0378cf8e0..c75f18e5c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,11 +8,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
-## [15.0.0-0] (2025-02-22)
+## ... | [
"CHANGELOG.md",
"Readme_zh-CN.md",
"docs/release-policy.md",
"package-lock.json",
"package.json"
] | [] | true | ||
tj/commander.js | 2,517 | issue_to_patch | Remove jest esm examples | A recent release of Jest includes support for `require(esm)`, albeit still requiring an option to enabled experimental feature. I think with Jest showing some forward progress again, perhaps better to leave out my examples which predated that support?
- https://github.com/jestjs/jest/releases/tag/v30.4.0
My hopef... | 9098b4863ef7678b9d138ae0f04afd949287510c | 025a49de455bf65885c83a6832a8992aa08f0ac8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 207ac2b78..0378cf8e0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -44,10 +44,6 @@ or bundler.
If you have problems using Commander 15 in your environment, one option is stay on Commander 14 for now. Commander 14 will
get security updates until May 2027 and things will... | [
"CHANGELOG.md",
"examples/using-esm-from-commonjs/jest-javascript/.gitignore",
"examples/using-esm-from-commonjs/jest-javascript/README.md",
"examples/using-esm-from-commonjs/jest-javascript/babel.config.js",
"examples/using-esm-from-commonjs/jest-javascript/index.spec.cjs",
"examples/using-esm-from-commo... | [] | diff --git a/examples/using-esm-from-commonjs/jest-javascript/index.spec.cjs b/examples/using-esm-from-commonjs/jest-javascript/index.spec.cjs
deleted file mode 100644
index 66fcfa394..000000000
--- a/examples/using-esm-from-commonjs/jest-javascript/index.spec.cjs
+++ /dev/null
@@ -1,9 +0,0 @@
-const { Command } = requ... | true | |
tj/commander.js | 2,518 | issue_to_patch | Update dependencies | Simple update to dependencies. I just ran `npm update`. `npm audit` is clean. | 9098b4863ef7678b9d138ae0f04afd949287510c | 9d13fcb68a37bf7cdc589a1bc2610670c876c611 | diff --git a/package-lock.json b/package-lock.json
index 08d0bef28..f48132b8c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -106,9 +106,9 @@
}
},
"node_modules/@eslint/config-helpers": {
- "version": "0.5.5",
- "resolved": "https://registry.npmjs.org/@eslint/config-helpers/-/confi... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,506 | issue_to_patch | Update dependencies | Semver compatible updates to various.
Update typescript from v5 to v6
```console
$ npm outdated
Package Current Wanted Latest Location Depended by
@types/node 22.19.13 22.19.17 25.6.0 node_modules/@types/node my-fork
eslint 10.0.2 10.2.0 ... | 373f660f6febb720b82635220eea72dd9b7e0cba | 1b6938d77edc199b9a5bb951a1cf6703cb0a6900 | diff --git a/package-lock.json b/package-lock.json
index 13f23b1ae..08d0bef28 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -16,7 +16,7 @@
"globals": "^17.3.0",
"prettier": "^3.2.5",
"tsd": "^0.33.0",
- "typescript": "^5.0.4",
+ "typescript": "^6.0.2",
"type... | [
"package-lock.json",
"package.json"
] | [] | true | ||
tj/commander.js | 2,489 | issue_to_patch | Update dependencies and lint | ## Problem
- stale dependencies
- using deprecated `tseslint.config`, and eslint now has `defineConfig()`
## Solution
Update dependencies. Fix new lint errors. Switch from `tseslint.config` to `defineConfig()`
| 7c6fd250543b6c46bcceb8b065feefc8a42402e2 | f7b9a17ba8956801a9749871ae0b96cbdcd8fd2d | diff --git a/eslint.config.js b/eslint.config.js
index 1c73cb6bd..e6454c97c 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -1,5 +1,6 @@
import globals from 'globals';
import esLintjs from '@eslint/js';
+import { defineConfig } from 'eslint/config';
import tseslint from 'typescript-eslint';
import prettier ... | [
"eslint.config.js",
"lib/command.js",
"lib/suggestSimilar.js",
"package-lock.json",
"package.json",
"tests/command.parse.test.js"
] | [
{
"comment": "One of the features of the config helper is it handles whether the config is an object or an array of objects, and likewise for the `extends`, so removed the spread operator.",
"path": "eslint.config.js",
"hunk": "@@ -8,13 +9,13 @@ const tsconfigTsFiles = ['**/*.{ts,mts}']; // match \"incl... | diff --git a/tests/command.parse.test.js b/tests/command.parse.test.js
index 25014cccf..61912b404 100644
--- a/tests/command.parse.test.js
+++ b/tests/command.parse.test.js
@@ -407,7 +407,7 @@ describe('Command.parse()', () => {
});
test('when parse subcommand then reset state before preSubcommand hook call... | true | |
tj/commander.js | 2,488 | issue_to_patch | Fix examples/using-esm-from-commonjs for prerelease | ## Problem
I put in `^15.0.0` as a placeholder for the Commander version in the example packages, but that does not work with the prerelease.
## Solution
Now we have a prerelease, use that. (I could have done this in advance but didn't work it out at the time!) | 3f00f5bc8240bcac963654530c590895fb585884 | 446b117354db4d70a5e2a49c37f8097f9da3b8c7 | diff --git a/examples/using-esm-from-commonjs/jest-javascript/package.json b/examples/using-esm-from-commonjs/jest-javascript/package.json
index 73de3614b..4f156b4f1 100644
--- a/examples/using-esm-from-commonjs/jest-javascript/package.json
+++ b/examples/using-esm-from-commonjs/jest-javascript/package.json
@@ -8,7 +8,... | [
"examples/using-esm-from-commonjs/jest-javascript/package.json",
"examples/using-esm-from-commonjs/jest-typescript/package.json"
] | [] | true | ||
tj/commander.js | 2,484 | issue_to_patch | Prepare for prerelease 15.0.0-0 | Updating the changelog for Commander 15, and bumping the Commander version and minimum Node.js version. Aiming for May release after node 22 goes EOL.
I'll do a prerelease when approved, and put up pinned issues about prerelease and moving to esm-only. | 26e3ba341af46e4ac5c5fded41485a97771858c4 | 23e39fe042b9bd949e2793d15fa7e768529d7306 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6c5314f3c..207ac2b78 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,23 +8,26 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
-## [15.0.0] (2026-05-15)
-
-_da... | [
"CHANGELOG.md",
"Readme.md",
"docs/release-policy.md",
"package-lock.json",
"package.json"
] | [
{
"comment": "## Polynomial regular expression used on uncontrolled data\n\nThis [regular expression](1) that depends on [library input](2) may run slow on strings starting with ' -h ' and with many repetitions of ' -h '.\nThis [regular expression](1) that depends on [library input](3) may run slow on strings s... | true | ||
tj/commander.js | 2,482 | issue_to_patch | Merge from develop into release/15.x | Merge changes from `develop` branch onto `release/15.x` branch. There were some minor conflicts, and a couple of new tests needed to be converted from Jest to `node:test`. | ca14529d071ec072ec9999475c81d74346f40a4c | 3e3736c5aa8ea3a8cd5eb495f13f0d35643457b0 | diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index a5c2042e3..e9346a93c 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -25,11 +25,11 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@v4
+... | [
".github/workflows/codeql-analysis.yml",
".github/workflows/tests.yml",
"CHANGELOG.md",
"Readme.md",
"Readme_zh-CN.md",
"SECURITY.md",
"docs/release-policy.md",
"examples/split.js",
"examples/string-util.js",
"lib/argument.js",
"lib/command.js",
"lib/option.js",
"package-lock.json",
"packa... | [] | diff --git a/tests/argument.variadic.test.js b/tests/argument.variadic.test.js
index 81be78d89..f0f95bbd1 100644
--- a/tests/argument.variadic.test.js
+++ b/tests/argument.variadic.test.js
@@ -104,4 +104,17 @@ describe('Command variadic argument using .argument()', (t) => {
program.parse(['one', 'two'], { from: 'u... | true | |
tj/commander.js | 2,476 | issue_to_patch | Bump prettier from 3.7.4 to 3.8.1 | Bumps [prettier](https://github.com/prettier/prettier) from 3.7.4 to 3.8.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prettier/prettier/releases">prettier's releases</a>.</em></p>
<blockquote>
<h2>3.8.1</h2>
<ul>
<li>Include available <code>printers</code> in plugin type... | c174291718e95c25ee8cad8ec2c99b88eba3f803 | 702f69076472489ce1959d1609c0cfcc801e9d33 | diff --git a/package-lock.json b/package-lock.json
index 9b3d132e9..fbe1926e0 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5372,9 +5372,9 @@
}
},
"node_modules/prettier": {
- "version": "3.7.4",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.7.4.tgz",
- "in... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,477 | issue_to_patch | Bump @types/node from 22.19.1 to 22.19.7 | Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.1 to 22.19.7.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li>
</ul>
</details>
<br />
<detail... | 8247364da749736570161e95682b07fc2d72497b | f03d769562ada6789c5928416dc3ad6d2af8d1b3 | diff --git a/package-lock.json b/package-lock.json
index 2c977311b..c42e1f750 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,7 +72,6 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
- ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,478 | issue_to_patch | Bump globals from 16.5.0 to 17.3.0 | Bumps [globals](https://github.com/sindresorhus/globals) from 16.5.0 to 17.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/globals/releases">globals's releases</a>.</em></p>
<blockquote>
<h2>v17.3.0</h2>
<ul>
<li>Update globals (2026-02-01) (<a href="https://... | 8247364da749736570161e95682b07fc2d72497b | 32371b779ec7a13086b17eaf972a9940b0101bc1 | diff --git a/package-lock.json b/package-lock.json
index 2c977311b..19535c5d3 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15,7 +15,7 @@
"eslint": "^9.17.0",
"eslint-config-prettier": "^10.0.1",
"eslint-plugin-jest": "^29.0.1",
- "globals": "^16.0.0",
+ "globals": ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
tj/commander.js | 2,479 | issue_to_patch | Bump typescript-eslint from 8.48.0 to 8.54.0 | Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.48.0 to 8.54.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases">typescript-eslint's releases</a>.</em></p... | 8247364da749736570161e95682b07fc2d72497b | d832ad156893d84295095975a0874d105400212f | diff --git a/package-lock.json b/package-lock.json
index 2c977311b..cb179335c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,7 +72,6 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
- ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,480 | issue_to_patch | Bump eslint-plugin-jest from 29.2.1 to 29.12.1 | Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 29.2.1 to 29.12.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/jest-community/eslint-plugin-jest/releases">eslint-plugin-jest's releases</a>.</em></p>
<blockquote>
<h2>v29.12.1</h2>
<h2><... | 8247364da749736570161e95682b07fc2d72497b | c7a1a6b5b1263d163c1820a030bd4a7bef1612e3 | diff --git a/package-lock.json b/package-lock.json
index 2c977311b..d23b88360 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,7 +72,6 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
- ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,474 | issue_to_patch | Update docs for 14.0.3 | Prepare a patch release, which in particular includes the new Release Policy.
Suggested release date next weekend, but no rush if that does not suit you @abetomo | 7357ddafe2cb7f6eed09217d77db4201e22aad83 | a3c5b5b752cd64737a63bae3396d35a67a22a80b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7cc9828e2..1257bc198 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
+## [14.0.3] (2026-01-31)
+
+### ... | [
"CHANGELOG.md",
"Readme.md",
"docs/release-policy.md"
] | [
{
"comment": "```suggestion\r\n## [14.0.3] (2026-01-31)\r\n```\r\n\r\nWould you like to follow the previous format?",
"path": "CHANGELOG.md",
"hunk": "@@ -8,6 +8,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.\n <!-- markdownlint-disable MD024 -->\n <!-- markdownli... | true | ||
tj/commander.js | 2,474 | comment_to_fix | Update docs for 14.0.3 | ```suggestion
## [14.0.3] (2026-01-31)
```
Would you like to follow the previous format? | 7357ddafe2cb7f6eed09217d77db4201e22aad83 | a3c5b5b752cd64737a63bae3396d35a67a22a80b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7cc9828e2..1257bc198 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
+## [14.0.3] (2026-01-31)
+
+### ... | [
"CHANGELOG.md"
] | [
{
"comment": "```suggestion\r\n## [14.0.3] (2026-01-31)\r\n```\r\n\r\nWould you like to follow the previous format?",
"path": "CHANGELOG.md",
"hunk": "@@ -8,6 +8,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.\n <!-- markdownlint-disable MD024 -->\n <!-- markdownli... | true | ||
tj/commander.js | 2,448 | issue_to_patch | Fix support backing details | The `npm_funding` support field refers to the funding property in `package.json`, and does not cover the funding file in the root level of the repo that GitHub uses.
Specification: https://github.com/nodejs/package-maintenance/blob/main/docs/PACKAGE-SUPPORT.md#support-backing
I actually had explicit fields when ... | 8417d7d80f04e94435d1a1af805f22cc677ea750 | d45483fc8db430772a4f8b7b5580acc68df77330 | diff --git a/package-support.json b/package-support.json
index 4eabb970e..47c9b3a05 100644
--- a/package-support.json
+++ b/package-support.json
@@ -9,7 +9,10 @@
"type": "time-permitting"
},
"backing": {
- "npm-funding": true
+ "donations": [
+ "https://github.com/sponsors/... | [
"package-support.json"
] | [] | true | ||
tj/commander.js | 2,465 | issue_to_patch | docs(README): Tweak formatting, punctuation for clarity | Simple copy-edits and small tweaks to the README.
| 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "The blank line and `Examples:` may make it seem the example will be of short-ish flags. If you think the blank line is helpful, perhaps remove the `Examples:` to avoid that impression.",
"path": "Readme.md",
"hunk": "@@ -176,7 +176,9 @@ const program = new Command();\n \n ## Options\n \n-O... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | The blank line and `Examples:` may make it seem the example will be of short-ish flags. If you think the blank line is helpful, perhaps remove the `Examples:` to avoid that impression. | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "The blank line and `Examples:` may make it seem the example will be of short-ish flags. If you think the blank line is helpful, perhaps remove the `Examples:` to avoid that impression.",
"path": "Readme.md",
"hunk": "@@ -176,7 +176,9 @@ const program = new Command();\n \n ## Options\n \n-O... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | As above, perhaps:
```suggestion
single characters, you may also have two long options.
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "As above, perhaps:\r\n```suggestion\r\nsingle characters, you may also have two long options.\r\n```",
"path": "Readme.md",
"hunk": "@@ -176,7 +176,9 @@ const program = new Command();\n \n ## Options\n \n-Options are defined with the `.option()` method, also serving as documentation for th... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I think this is an old line with tweaks over the years! Still clunky. How about a bigger rewrite:
Multi-word options like `--template-engine` are normalized to camelCase option names, resulting in properties such as `program.opts().templateEngine`. | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I think this is an old line with tweaks over the years! Still clunky. How about a bigger rewrite:\r\n\r\nMulti-word options like `--template-engine` are normalized to camelCase option names, resulting in properties such as `program.opts().templateEngine`.",
"path": "Readme.md",
"hunk": "@@... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I settled on `Example file:` elsewhere, and I think use that here too.
```suggestion
Subcommands may be nested. Example file: [nestedCommands.js](./examples/nestedCommands.js).
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I settled on `Example file:` elsewhere, and I think use that here too.\r\n\r\n```suggestion\r\nSubcommands may be nested. Example file: [nestedCommands.js](./examples/nestedCommands.js).\r\n```",
"path": "Readme.md",
"hunk": "@@ -521,7 +525,12 @@ $ custom --list x,y,z\n \n ## Commands\n \n... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I don't think this expansion is enough of an improvement over the concise statement. | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I don't think this expansion is enough of an improvement over the concise statement.",
"path": "Readme.md",
"hunk": "@@ -521,7 +525,12 @@ $ custom --list x,y,z\n \n ## Commands\n \n-You can specify (sub)commands using `.command()` or `.addCommand()`. There are two ways these can be impleme... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | ```suggestion
subcommand is specified. (Example file: [defaultCommand.js](./examples/defaultCommand.js).)
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "```suggestion\r\nsubcommand is specified. (Example file: [defaultCommand.js](./examples/defaultCommand.js).)\r\n```",
"path": "Readme.md",
"hunk": "@@ -553,19 +562,20 @@ program\n \n Configuration options can be passed with the call to `.command()` and `.addCommand()`. Specifying `hidden: ... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | ```suggestion
You can add alternative names for a command with `.alias()`. (Example file: [alias.js](./examples/alias.js).)
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "```suggestion\r\nYou can add alternative names for a command with `.alias()`. (Example file: [alias.js](./examples/alias.js).)\r\n```",
"path": "Readme.md",
"hunk": "@@ -553,19 +562,20 @@ program\n \n Configuration options can be passed with the call to `.command()` and `.addCommand()`. Sp... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | The "For other subcommands" is in contrast to "implemented using a stand-alone executable" which gets lost with the line break.
I think this needs a bigger rewrite. Want to have a go? The background is that `.argument()` is newer and somewhat preferred, but you can't use it with stand-alone executables (because the... | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "The \"For other subcommands\" is in contrast to \"implemented using a stand-alone executable\" which gets lost with the line break. \r\n\r\nI think this needs a bigger rewrite. Want to have a go? The background is that `.argument()` is newer and somewhat preferred, but you can't use it with stand-... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I am neutral on the blank line. If you do like it, I suggest dropping the "for example" as example is for the whole thing.
```suggestion
A variadic argument is passed to the action handler as an array.
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I am neutral on the blank line. If you do like it, I suggest dropping the \"for example\" as example is for the whole thing.\r\n\r\n```suggestion\r\nA variadic argument is passed to the action handler as an array.\r\n```",
"path": "Readme.md",
"hunk": "@@ -584,8 +594,10 @@ program\n });\... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I wanted one clause and not two. ChatGPT agreed with you that comma needed as written, but suggested a rewrite to allow no comma:
```suggestion
If you prefer, you can work with the command directly and skip declaring the parameters for the action handler. The `this` keyword is set to the running command and usable ... | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I wanted one clause and not two. ChatGPT agreed with you that comma needed as written, but suggested a rewrite to allow no comma:\r\n\r\n```suggestion\r\nIf you prefer, you can work with the command directly and skip declaring the parameters for the action handler. The `this` keyword is set to the... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | Ok, but I suspect my markdown linter is going to complain about using bold as headings. 😆 | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "Ok, but I suspect my markdown linter is going to complain about using bold as headings. 😆 ",
"path": "Readme.md",
"hunk": "@@ -1031,15 +1049,15 @@ program\n \n ### TypeScript\n \n-extra-typings: There is an optional project to infer extra type information from the option and argument defi... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | ```suggestion
customise the new subcommand. Example file: [custom-command-class.js](./examples/custom-command-class.js).
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "```suggestion\r\ncustomise the new subcommand. Example file: [custom-command-class.js](./examples/custom-command-class.js).\r\n```",
"path": "Readme.md",
"hunk": "@@ -1054,15 +1072,15 @@ const { createCommand } = require('commander');\n const program = createCommand();\n ```\n \n-`createCo... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I don't like the bold here, too noisy.
```suggestion
- Use `#! /usr/bin/env node --harmony` in the subcommands scripts. (Note: Windows does not support this pattern.)
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I don't like the bold here, too noisy.\r\n\r\n```suggestion\r\n- Use `#! /usr/bin/env node --harmony` in the subcommands scripts. (Note: Windows does not support this pattern.)\r\n```",
"path": "Readme.md",
"hunk": "@@ -1054,15 +1072,15 @@ const { createCommand } = require('commander');\n ... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | Side note: I had left out the code formatting in a couple of places you noticed as I thought it might make the link less clear, but looks fine. | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "Side note: I had left out the code formatting in a couple of places you noticed as I thought it might make the link less clear, but looks fine.",
"path": "Readme.md",
"hunk": "@@ -1072,14 +1090,14 @@ An executable subcommand is launched as a separate child process.\n If you are using the n... | true | ||
tj/commander.js | 2,465 | comment_to_fix | docs(README): Tweak formatting, punctuation for clarity | I went compact on purpose, but agree list is clearer. I think not as a sentence though.
```suggestion
The override callback is passed a `CommanderError` with the properties:
- `exitCode`: number
- `code`: string
- `message`: string
``` | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | daf0cf1ffb49e45aa5aee6dd84fb7ff51a1bbfbd | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..87adff948 100644
--- a/Readme.md
+++ b/Readme.md
@@ -154,7 +154,7 @@ This is used in the examples in this README for brevity.
const { program } = require('commander');
```
-For larger programs which may use commander in multiple ways, including unit testing, it is... | [
"Readme.md"
] | [
{
"comment": "I went compact on purpose, but agree list is clearer. I think not as a sentence though.\r\n\r\n```suggestion\r\nThe override callback is passed a `CommanderError` with the properties:\r\n- `exitCode`: number\r\n- `code`: string \r\n- `message`: string\r\n```",
"path": "Readme.md",
"hunk": ... | true | ||
tj/commander.js | 2,427 | issue_to_patch | minor change in index.d.ts | ## Problem
No problem, just a subtlety in the typings. The deprecated versions of `help` and `outputHelp` should not include the parameter-less version to make it entirely clear that only the callback variant itself is deprecated.
## Solution
Remove optional marker from the deprecated signatures.
## ChangeL... | bd4ae263f6966183f3c9e8b105fb5ae3c568c047 | 6ad7e14c69c8aaab5fb06da5b1f6e81488870fd1 | diff --git a/typings/index.d.ts b/typings/index.d.ts
index 65f08c923..9ef79355c 100644
--- a/typings/index.d.ts
+++ b/typings/index.d.ts
@@ -1044,7 +1044,7 @@ export class Command {
*/
outputHelp(context?: HelpContext): void;
/** @deprecated since v7 */
- outputHelp(cb?: (str: string) => string): void;
+ ou... | [
"typings/index.d.ts"
] | [] | true | ||
tj/commander.js | 2,462 | issue_to_patch | Separate out a more detailed release policy document | ## Problem
In particular:
- mixing security policy and releases policy
- no explicit EOL date for old versions
See #2455 for detailed background.
## Solution
Create a new Release Policy document with detail about release versioning, cadence, version status, and EOL dates.
## ChangeLog
- add new Rele... | 4208a96ee7533b7ee5fa10123d169bc8c631b83c | dcca4c0dbf716bce7658ce024bf3831e0418cb05 | diff --git a/Readme.md b/Readme.md
index 1f10fb5a6..01d730648 100644
--- a/Readme.md
+++ b/Readme.md
@@ -1148,7 +1148,8 @@ There is more information available about:
## Support
The current version of Commander is fully supported on Long Term Support versions of Node.js, and requires at least v20.
-(For older versio... | [
"Readme.md",
"SECURITY.md",
"docs/release-policy.md"
] | [] | true | ||
tj/commander.js | 2,428 | issue_to_patch | Improve negative test | I had a loose expression to accept all of`123` and `4.5` and `.678`. More explicit and tidier using the OR operator to test for a number with OR without a decimal point.
The OR operator is lowest precedence, so `\d+|\d*\.\d+` is same as `(\d+)|(\d*\.\d+)` | 1a6dba53bf3a0a411505397809d5c930b63a6e29 | 2751a7321d6f90f0906208af6ef36f14803e9224 | diff --git a/lib/command.js b/lib/command.js
index a176dfbb9..f1cdc429f 100644
--- a/lib/command.js
+++ b/lib/command.js
@@ -1756,7 +1756,7 @@ Expecting one of '${allowedValues.join("', '")}'`);
const negativeNumberArg = (arg) => {
// return false if not a negative number
- if (!/^-\d*\.?\d+(e[+-]?\d... | [
"lib/command.js"
] | [] | true | ||
tj/commander.js | 2,470 | issue_to_patch | Bump eslint from 9.39.1 to 9.39.2 | Bumps [eslint](https://github.com/eslint/eslint) from 9.39.1 to 9.39.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p>
<blockquote>
<h2>v9.39.2</h2>
<h2>Bug Fixes</h2>
<ul>
<li><a href="https://github.com/eslint/eslint/c... | 921191868b3cb935908256d4655b7bb9c6ad90bc | 6020c502d12af589ebf7e56bd6038e3cfa826ab4 | diff --git a/package-lock.json b/package-lock.json
index ef560bf52..6f2a3bbcf 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -713,9 +713,9 @@
}
},
"node_modules/@eslint/js": {
- "version": "9.39.1",
- "resolved": "https://registry.npmjs.org/@eslint/js/-/js-9.39.1.tgz",
- "inte... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,467 | issue_to_patch | Bump ts-jest from 29.4.5 to 29.4.6 | Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.4.5 to 29.4.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/kulshekhar/ts-jest/releases">ts-jest's releases</a>.</em></p>
<blockquote>
<h2>v29.4.6</h2>
<p>Please refer to <a href="https://github.com/kulshekhar/t... | 921191868b3cb935908256d4655b7bb9c6ad90bc | 268dea41fe43e29a5b534220fc153451a79b3e62 | diff --git a/package-lock.json b/package-lock.json
index ef560bf52..2daba48e9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6267,9 +6267,9 @@
}
},
"node_modules/ts-jest": {
- "version": "29.4.5",
- "resolved": "https://registry.npmjs.org/ts-jest/-/ts-jest-29.4.5.tgz",
- "int... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,466 | issue_to_patch | Bump prettier from 3.6.2 to 3.7.4 | Bumps [prettier](https://github.com/prettier/prettier) from 3.6.2 to 3.7.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/prettier/prettier/releases">prettier's releases</a>.</em></p>
<blockquote>
<h2>3.7.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Fix comment in union type gets... | 921191868b3cb935908256d4655b7bb9c6ad90bc | ee957849ac0268547e56e36c7b55645e8c70fca6 | diff --git a/package-lock.json b/package-lock.json
index ef560bf52..77c0ffd39 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5387,9 +5387,9 @@
}
},
"node_modules/prettier": {
- "version": "3.6.2",
- "resolved": "https://registry.npmjs.org/prettier/-/prettier-3.6.2.tgz",
- "in... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,458 | issue_to_patch | Bump typescript-eslint from 8.46.2 to 8.48.0 | Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.46.2 to 8.48.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases">typescript-eslint's releases</a>.</em></p... | 03308ceb50c8b508abcfc3b34c36daa2e7b813d2 | 043962a21da7ce60fd678631527d89bb7bf8acff | diff --git a/package-lock.json b/package-lock.json
index 329ef0348..ef560bf52 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1611,18 +1611,18 @@
"license": "MIT"
},
"node_modules/@typescript-eslint/eslint-plugin": {
- "version": "8.46.2",
- "resolved": "https://registry.npmjs.org/... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,457 | issue_to_patch | Bump eslint-plugin-jest from 29.0.1 to 29.2.1 | Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 29.0.1 to 29.2.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/jest-community/eslint-plugin-jest/releases">eslint-plugin-jest's releases</a>.</em></p>
<blockquote>
<h2>v29.2.1</h2>
<h2><a ... | 8f9de6b1117b597bbf036ed8c143dc35f3a22f74 | feedb6353c8cfc28514b389604522c9816f0cad9 | diff --git a/package-lock.json b/package-lock.json
index 1029cda07..30a667996 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,6 +72,7 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
+ ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,456 | issue_to_patch | Bump globals from 16.4.0 to 16.5.0 | Bumps [globals](https://github.com/sindresorhus/globals) from 16.4.0 to 16.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sindresorhus/globals/releases">globals's releases</a>.</em></p>
<blockquote>
<h2>v16.5.0</h2>
<ul>
<li>Update globals (2025-11-01) (<a href="https://... | 8f9de6b1117b597bbf036ed8c143dc35f3a22f74 | c75573ec0602684c97c1034a4684fde8f9eab1c8 | diff --git a/package-lock.json b/package-lock.json
index 1029cda07..2e7b6a673 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,6 +72,7 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
+ ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,459 | issue_to_patch | Bump @types/node from 22.18.13 to 22.19.1 | Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.18.13 to 22.19.1.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node">compare view</a></li>
</ul>
</details>
<br />
<detai... | 8f9de6b1117b597bbf036ed8c143dc35f3a22f74 | cd3ea1ae675b8355c3f63734b2b78f2e950c1191 | diff --git a/package-lock.json b/package-lock.json
index 1029cda07..c1d35e85a 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,6 +72,7 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
+ ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,460 | issue_to_patch | Bump eslint from 9.39.0 to 9.39.1 | Bumps [eslint](https://github.com/eslint/eslint) from 9.39.0 to 9.39.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p>
<blockquote>
<h2>v9.39.1</h2>
<h2>Bug Fixes</h2>
<ul>
<li><a href="https://github.com/eslint/eslint/c... | 8f9de6b1117b597bbf036ed8c143dc35f3a22f74 | 4a635da7dbd6a94a3df3db1215444145ac712170 | diff --git a/package-lock.json b/package-lock.json
index 1029cda07..9c6f6fcf2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -72,6 +72,7 @@
"integrity": "sha512-yDBHV9kQNcr2/sUr9jghVyz9C3Y5G2zUM2H2lo+9mKv4sFgbA8s8Z9t8D1jiTkGoO/NoIfKMyKWr4s6CN23ZwQ==",
"dev": true,
"license": "MIT",
+ ... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,453 | issue_to_patch | Bump actions/checkout from 5 to 6 | Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README to includ... | e5c164de5912d16c03a6f931dad05eeb30045a37 | a29895e98a4aea5697a591709c624b4ce0989018 | diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index 50861b5a6..e9346a93c 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -25,7 +25,7 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@v5
+ ... | [
".github/workflows/codeql-analysis.yml",
".github/workflows/tests.yml"
] | [] | true | ||
tj/commander.js | 2,315 | issue_to_patch | Add 13.1 to CHANGELOG | Document changes in 13.1. I added an explicit example to the Migration Tips for 13.0 to point to the new feature.
This can go out when suits you @abetomo | 2619c99a193792d6700b0a1f8bb4b1075558a56c | ce9ae8a9d0cc6cfffde197a01b3cf9754608f098 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f8ab4410d..443acd768 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
<!-- markdownlint-disable MD024 -->
<!-- markdownlint-disable MD004 -->
+## [13.1.0] (2025-01-21)
+
+### ... | [
"CHANGELOG.md"
] | [] | true | ||
tj/commander.js | 2,349 | issue_to_patch | Update dependencies | Updated everything together to sort out typescript update.
| 04d6b0c762f33f481d9d4577971fb60576c66f51 | 6d65bbe05e1587a9e3c253c5209b369c92913dd3 | diff --git a/package-lock.json b/package-lock.json
index fb4030dc8..a2bb17720 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -15,7 +15,7 @@
"eslint": "^9.17.0",
"eslint-config-prettier": "^10.0.1",
"eslint-plugin-jest": "^28.3.0",
- "globals": "^15.7.0",
+ "globals": ... | [
"package-lock.json",
"package.json"
] | [] | true | ||
tj/commander.js | 2,442 | issue_to_patch | Bump eslint from 9.34.0 to 9.39.0 | Bumps [eslint](https://github.com/eslint/eslint) from 9.34.0 to 9.39.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p>
<blockquote>
<h2>v9.39.0</h2>
<h2>Features</h2>
<ul>
<li><a href="https://github.com/eslint/eslint/co... | 8dc72eb7548d8b1c3e7431693b7185932c296252 | 6e9a0894c190c4ae3312b13b89ada56e3dc08f83 | diff --git a/package-lock.json b/package-lock.json
index c195f3286..1029cda07 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -592,9 +592,9 @@
}
},
"node_modules/@eslint-community/eslint-utils": {
- "version": "4.7.0",
- "resolved": "https://registry.npmjs.org/@eslint-community/esli... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,441 | issue_to_patch | Bump @eslint/js from 9.34.0 to 9.39.0 | Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.34.0 to 9.39.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/eslint/eslint/releases"><code>@eslint/js</code>'s releases</a>.</em></p>
<blockquote>
<h2>v9.39.0</h2>
<h2>Features</h2>
<ul>
<li>... | 0692be58103e1ea8052d5d45ab11cc02e197eea5 | 4f2ce356f3c4aa3dd514ecbe192e16e2ce474ef6 | diff --git a/package-lock.json b/package-lock.json
index 765e4b70a..7f2e5ea18 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -709,9 +709,9 @@
}
},
"node_modules/@eslint/js": {
- "version": "9.34.0",
- "resolved": "https://registry.npmjs.org/@eslint/js/-/js-9.34.0.tgz",
- "inte... | [
"package-lock.json"
] | [] | true | ||
tj/commander.js | 2,440 | issue_to_patch | Bump ts-jest from 29.4.4 to 29.4.5 | Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.4.4 to 29.4.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/kulshekhar/ts-jest/releases">ts-jest's releases</a>.</em></p>
<blockquote>
<h2>v29.4.5</h2>
<p>Please refer to <a href="https://github.com/kulshekhar/t... | 0692be58103e1ea8052d5d45ab11cc02e197eea5 | 4f9d3069c138d5826d3890f55a1e3053f1918d41 | diff --git a/package-lock.json b/package-lock.json
index 765e4b70a..2e8b14d2c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5741,9 +5741,9 @@
}
},
"node_modules/semver": {
- "version": "7.7.2",
- "resolved": "https://registry.npmjs.org/semver/-/semver-7.7.2.tgz",
- "integrit... | [
"package-lock.json"
] | [] | true | ||
tmrts/go-patterns | 27 | issue_to_patch | structural/proxy: implement structural proxy pattern | Greetings.
Please review proxy realization, tried my best.
Cheers. | 67efe3e622fe41d7ad2d9f1d9877be311286f0a7 | f46dd555a8bd5304ddbf54c44ca3e3e405f6f2d9 | diff --git a/.gitignore b/.gitignore
index daf913b..f72f0cd 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,6 +19,16 @@ _cgo_export.*
_testmain.go
-*.exe
-*.test
*.prof
+# Test binary, build with `go test -c`
+*.test
+# Binaries for programs and plugins
+*.exe
+*.dll
+*.dylib
+
+# JetBrains project files
+.idea/
... | [
".gitignore",
"README.md",
"structural/proxy.md",
"structural/proxy/main.go"
] | [] | true | ||
tmrts/go-patterns | 26 | issue_to_patch | fix stategy.md markdown | 399a51c7fea4ca40c347d7d28149c5f866f0183c | 451e2399c09c9f3e1e0ea91678a0fc1f43cb8f43 | diff --git a/behavioral/strategy.md b/behavioral/strategy.md
index e04e683..3290227 100644
--- a/behavioral/strategy.md
+++ b/behavioral/strategy.md
@@ -1,4 +1,4 @@
-#Strategy Pattern
+# Strategy Pattern
Strategy behavioral design pattern enables an algorithm's behavior to be selected at runtime.
It defines algorit... | [
"behavioral/strategy.md"
] | [] | true | |||
tmrts/go-patterns | 24 | issue_to_patch | fix generator pattern range issue | https://github.com/tmrts/go-patterns/issues/23 | 0ca6f6652de7977a7607425ecfe66337b02611d2 | 3ba3e0109330514f304a99818c5d2913d3a8016b | diff --git a/concurrency/generator.md b/concurrency/generator.md
index 6d4d134..e9821b6 100644
--- a/concurrency/generator.md
+++ b/concurrency/generator.md
@@ -9,7 +9,7 @@ func Count(start int, end int) chan int {
ch := make(chan int)
go func(ch chan int) {
- for i := start; i < end ; i++ {
+ ... | [
"concurrency/generator.md"
] | [] | true | ||
tmrts/go-patterns | 20 | issue_to_patch | Fix Object Pool example | Sorry for adding typo fixes in this PR :( | af1dfcd39ff93e0c8cf2da2fd15b39b7ad6adc3b | a2159501d1d9ec77eb228e825f136b993d038b50 | diff --git a/creational/object-pool.md b/creational/object-pool.md
index 37066d3..c50667d 100644
--- a/creational/object-pool.md
+++ b/creational/object-pool.md
@@ -11,13 +11,13 @@ package pool
type Pool chan *Object
func New(total int) *Pool {
- p := make(chan *Object, total)
+ p := make(Pool, total)
for i := ... | [
"creational/object-pool.md"
] | [] | true | ||
tmrts/go-patterns | 16 | issue_to_patch | Fix build error | remove asterisk
| f7e32625ecaba2d5b1cc0695f2c79e3a6eddfde1 | 304c68c4897f47f22173e75c4e9f07cd215f70d8 | diff --git a/creational/singleton.md b/creational/singleton.md
index 09ffeae..fa6c463 100644
--- a/creational/singleton.md
+++ b/creational/singleton.md
@@ -11,9 +11,9 @@ type singleton map[string]string
var once sync.Once
-var instance *singleton
+var instance singleton
-func New() *singleton {
+func New() sing... | [
"creational/singleton.md"
] | [] | true | ||
tmrts/go-patterns | 15 | issue_to_patch | Result is not defined | The example is not working because `result` is not defined.
Now the example works
| 82fc76d6ab592a5e20fe4d287163b0e275a216ba | f84fbfcaadf4bdd121c0d7b7ad5a1dc02e7bf985 | diff --git a/concurrency/generator.md b/concurrency/generator.md
index 92982e8..6d4d134 100644
--- a/concurrency/generator.md
+++ b/concurrency/generator.md
@@ -11,7 +11,7 @@ func Count(start int, end int) chan int {
go func(ch chan int) {
for i := start; i < end ; i++ {
// Blocks on the oper... | [
"concurrency/generator.md"
] | [] | true | ||
tmrts/go-patterns | 9 | issue_to_patch | fix object_pool.go | the original `object_pool.go` can not be compiled
go playground ref: [go playground](https://play.golang.org/p/9gwqoARH2F)
| 4b81980a1f86625f4169b1b041ecb0a3aa24f22c | 53fabca211a1636d568196609649059b679049ee | diff --git a/creational/object_pool.go b/creational/object_pool.go
index ef00c0f..28a582d 100644
--- a/creational/object_pool.go
+++ b/creational/object_pool.go
@@ -1,6 +1,15 @@
package main
-import "container/list"
+import (
+ "container/list"
+ "errors"
+ "log"
+)
+
+var (
+ ErrNoMoreObject = errors.New("no ... | [
"creational/object_pool.go"
] | [] | true | ||
tmrts/go-patterns | 3 | issue_to_patch | Observer documentation and example. | This adds the observer pattern and an example application.
| 3d2d78a8a2e2ab3081c9b378a64b9847774c3623 | b9f8a7203a6bb044c0d8704d3a34bc3fb9c017d8 | diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 0000000..9dad772
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,2 @@
+script:
+ - exit $(grep -c ".go)" README.md)
\ No newline at end of file
diff --git a/README.md b/README.md
index 8b694da..7efea6a 100644
--- a/README.md
+++ b/README.md
@@ -15,90 +15,90 ... | [
".travis.yml",
"README.md",
"behavioral/observer.md",
"behavioral/observer/main.go",
"concurrency/bounded_parallelism.go",
"concurrency/bounded_parallelism.md",
"concurrency/parallelism.go",
"concurrency/parallelism.md",
"creational/object_pool.go",
"creational/object_pool.md",
"messaging/publis... | [] | true | ||
tmrts/go-patterns | 5 | issue_to_patch | Nothing special on Subscription | 3d2d78a8a2e2ab3081c9b378a64b9847774c3623 | 655d3daf6735562e41abf21e66320e3c927a0ac2 | diff --git a/messaging/publish_subscribe.md b/messaging/publish_subscribe.md
index efb46b5..79d4405 100644
--- a/messaging/publish_subscribe.md
+++ b/messaging/publish_subscribe.md
@@ -27,11 +27,11 @@ type Subscription struct {
}
func (s *Subscription) Publish(msg Message) error {
- if _, ok := ch; !ok {
+ if _, ok... | [
"messaging/publish_subscribe.md"
] | [] | true | |||
tmrts/go-patterns | 4 | issue_to_patch | Add TODO Information to README | This changes the names of some files to match the pattern that was observed in the existing files, adds `TODO` to unfinished patterns regarding #1, and ensures that all links in the README file are Markdown and not `go` files.
Also done is creation of the simplest `.travis.yml` file I could think of for checking the R... | 3d2d78a8a2e2ab3081c9b378a64b9847774c3623 | ef768c00c42d1af7f0512b5b13d18c6d89060c7a | diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 0000000..9dad772
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,2 @@
+script:
+ - exit $(grep -c ".go)" README.md)
\ No newline at end of file
diff --git a/README.md b/README.md
index 8b694da..dfec8f7 100644
--- a/README.md
+++ b/README.md
@@ -15,90 +15,90 ... | [
".travis.yml",
"README.md",
"concurrency/bounded_parallelism.go",
"concurrency/bounded_parallelism.md",
"concurrency/parallelism.go",
"concurrency/parallelism.md",
"creational/object_pool.go",
"creational/object_pool.md",
"stability/circuit_breaker.md",
"stability/circuitbreaker.go"
] | [] | true | ||
tmux/tmux | 5,198 | issue_to_patch | feat(floating_panes): Enabled swapping marked panes from the pane mouse menu. | e2b52abd470a759b1a46a35770609a7dd1bad913 | d1fe0d449b3561fff2ce42c96cd995c013d44a4d | diff --git a/key-bindings.c b/key-bindings.c
index 5ef7706c4..647971a2b 100644
--- a/key-bindings.c
+++ b/key-bindings.c
@@ -65,7 +65,7 @@
" ''" \
" '#{?#{&&:#{!:#{pane_floating_flag}},#{>:#{window_panes},1}},Swap Up,}' 'u' {swap-pane -U}" \
" '#{?#{&&:#{!:#{pane_floating_flag}},#{>:#{window_panes},1}},Swap Down,... | [
"key-bindings.c"
] | [] | true | |||
tmux/tmux | 5,197 | issue_to_patch | fix(floating_panes): Move the hidden panes format logic to their alphabetical positions. | 8497b588a27d01dde50249f10fb39689c612ea30 | f58eb4dc0efb3a7b179d085b83eaa83a35e4e62f | diff --git a/format.c b/format.c
index af251c3ae..99f9287dd 100644
--- a/format.c
+++ b/format.c
@@ -2145,6 +2145,20 @@ format_cb_pane_height(struct format_tree *ft)
return (NULL);
}
+/* Callback for pane_hidden_flag. */
+static void *
+format_cb_pane_hidden_flag(struct format_tree *ft)
+{
+ struct window_pane *wp... | [
"format.c"
] | [] | true | |||
tmux/tmux | 5,193 | issue_to_patch | fix(floating_panes): `swap-pane` can now affect floating panes. | It seems like the new layout logic works with floating panes in `swap-pane`. I couldn't get it to break.
**EDIT**: as for the second commit message, I noticed that the guard had an `&&` previously. Is there a reason to restrict swapping two floating panes? | 2a830aa5672d3e440d93e633382613860b0926ba | b675c2149c892b8bf5fe6642a136acdb969f446d | diff --git a/cmd-swap-pane.c b/cmd-swap-pane.c
index 48785c921..8a83a67af 100644
--- a/cmd-swap-pane.c
+++ b/cmd-swap-pane.c
@@ -79,12 +79,6 @@ cmd_swap_pane_exec(struct cmd *self, struct cmdq_item *item)
if (src_wp == dst_wp)
goto out;
- if (window_pane_is_floating(src_wp) ||
- window_pane_is_floating(dst_w... | [
"cmd-swap-pane.c"
] | [] | true | ||
tmux/tmux | 5,186 | issue_to_patch | Merge master into floating panes. | b2ac4475cc7abe20eb8eebe7d95d4feb183230ea | 45e9e541a4a07679db22c3b51237e7b3dfe86d8f | diff --git a/cmd-kill-pane.c b/cmd-kill-pane.c
index fc3eb1b77..ed8336430 100644
--- a/cmd-kill-pane.c
+++ b/cmd-kill-pane.c
@@ -27,13 +27,17 @@
*/
static enum cmd_retval cmd_kill_pane_exec(struct cmd *, struct cmdq_item *);
+static enum cmd_retval cmd_kill_pane_all(struct cmdq_item *, const char *);
+static int ... | [
"cmd-kill-pane.c",
"cmd-kill-session.c",
"cmd-kill-window.c",
"cmd-server-access.c",
"cmd-split-window.c",
"proc.c",
"server-acl.c",
"server-client.c",
"server.c",
"tmux.1",
"tmux.h",
"tty.c",
"utf8-combined.c",
"window-tree.c",
"window.c"
] | [] | true | |||
tmux/tmux | 5,183 | issue_to_patch | refactor(floating_panes): Layout cell position in root layout. | ~~(WIP)~~
Currently, layout cells are appended to the container at the top of the layout tree. This PR aims to meaningfully place them inside the tree to enable float/tile operations. | 2955c1fdc7367521c3d659c2a1ae53b85b05cef4 | e370ce5a003ba4ccf3328321b00c52f131b4ff93 | diff --git a/layout.c b/layout.c
index d6b6ca860..853b0b6f5 100644
--- a/layout.c
+++ b/layout.c
@@ -250,10 +250,7 @@ layout_fix_offsets1(struct layout_cell *lc)
if (lc->type == LAYOUT_LEFTRIGHT) {
xoff = lc->xoff;
TAILQ_FOREACH(lcchild, &lc->cells, entry) {
- if (lcchild->flags & LAYOUT_CELL_FLOATING ||
- ... | [
"layout.c",
"tmux.h",
"window.c"
] | [] | true | ||
tmux/tmux | 5,182 | issue_to_patch | Merging master into floating panes. | 0b1089e105dc87233f4180346c599789ca7d94ac | a7952492c172ded8717f2c6161673f3b4f416ebc | diff --git a/CHANGES b/CHANGES
index cf125fd99..cb92e2ff0 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,332 @@
+CHANGES FROM 3.6b TO 3.7
+
+* Add floating panes. These are panes which sit above the layout ("tiled
+ panes") like popups but unlike popups are not modal and behave like panes (so
+ the same escape sequenc... | [
"CHANGES",
"cmd-capture-pane.c",
"cmd-choose-tree.c",
"cmd-display-panes.c",
"cmd-join-pane.c",
"cmd-kill-session.c",
"cmd-list-keys.c",
"cmd-split-window.c",
"cmd-swap-pane.c",
"format.c",
"grid.c",
"layout.c",
"mode-tree.c",
"options-table.c",
"regress/am-terminal.sh",
"regress/borde... | [] | true | |||
tmux/tmux | 5,154 | issue_to_patch | fix(floating_panes): Leftover compile errors | There were some leftover flags that needed to be cleaned up. | 90ede52728085c33536fba53e524238227f98d19 | 7c908bca7a2b49819ed0af67ad268a8f9966b0de | diff --git a/cmd-tile-float-pane.c b/cmd-tile-float-pane.c
index ec3d8f64f..19dfa4fc9 100644
--- a/cmd-tile-float-pane.c
+++ b/cmd-tile-float-pane.c
@@ -159,7 +159,7 @@ cmd_float_pane_exec(struct cmd *self, struct cmdq_item *item)
u_int sx, sy;
struct layout_cell *lc;
- if (wp->flags & PANE_FLOATING) {
+ if (w... | [
"cmd-tile-float-pane.c",
"layout.c",
"screen-redraw.c",
"tty.c",
"window.c"
] | [] | true | ||
tmux/tmux | 5,111 | issue_to_patch | fix(floating_panes): Hidden panes are correctly prevented from becoming the active pane. | Added logic to prevent hidden panes from being selected as the active pane to `window_lost_pane`. | 1def5878844ca3876caced18893ff16908c545a8 | 243465386769eeffead0531df4b668b335676492 | diff --git a/window.c b/window.c
index c79f98eb3e..57ef2e92b1 100644
--- a/window.c
+++ b/window.c
@@ -843,26 +843,41 @@ window_add_pane(struct window *w, struct window_pane *other, u_int hlimit,
void
window_lost_pane(struct window *w, struct window_pane *wp)
{
+ struct window_pane *wpp, *twpp;
+
log_debug("%s: @%... | [
"window.c"
] | [] | true | ||
tmux/tmux | 5,112 | issue_to_patch | Correcting 'oops' commit to floating_panes by pushing same changes to staging | 7127595ac6eb8e9d54b5678cc6c432f75c4477a1 | 831e3c813f24a77812eca4f18472109ff1c9bc58 | diff --git a/window.c b/window.c
index bf0d90f1fc..6cb175c3b6 100644
--- a/window.c
+++ b/window.c
@@ -805,26 +805,41 @@ window_add_pane(struct window *w, struct window_pane *other, u_int hlimit,
void
window_lost_pane(struct window *w, struct window_pane *wp)
{
+ struct window_pane *wpp, *twpp;
+
log_debug("%s: @%... | [
"window.c"
] | [] | true | |||
tmux/tmux | 5,107 | issue_to_patch | Fixed null dereference. | If there is no active layout root (all other panes minimised with dotted background), checking for saved float dimensions would crash with a null deref in `window.c:window_pane_float_geometry`. | 0ae8019e7f152fb980bf1cde80de6c93d3d59776 | b7cc218a036b6cbf0db28f08c4f84615fc7ac680 | diff --git a/window.c b/window.c
index 88269c3537..051daed81f 100644
--- a/window.c
+++ b/window.c
@@ -2188,7 +2188,7 @@ window_pane_float_geometry(struct window *w, struct window_pane *wp,
u_int x, y, sx, sy;
const u_int cx = 4, cy = 2;
- if ((wp->flags & PANE_SAVED_FLOAT) &&
+ if (wp != NULL && (wp->flags & PA... | [
"window.c"
] | [] | true | ||
tmux/tmux | 5,106 | issue_to_patch | refactor(floating_panes): Better abstractions learned from #5043 | In working on #5043, I discovered that more abstractions were needed because more code was shared than I initially thought. This remedies that and simplifies future refactors. @mgrant0 | fd4e68315159f6fad2211ddf9fb98950f72c8e68 | c3fc0229e5d4dae317fb1af1572fb9434971bee3 | diff --git a/cmd-split-window.c b/cmd-split-window.c
index 2286d41d1c..5859983ce8 100644
--- a/cmd-split-window.c
+++ b/cmd-split-window.c
@@ -38,13 +38,12 @@ const struct cmd_entry cmd_new_pane_entry = {
.name = "new-pane",
.alias = "newp",
- .args = { "bc:de:fF:hIkl:m:M:p:PR:s:S:t:x:X:y:Y:vZ", 0, -1, NULL },
+ ... | [
"cmd-split-window.c",
"spawn.c",
"tmux.h",
"window.c"
] | [] | true | ||
tmux/tmux | 5,108 | issue_to_patch | refactor(floating_panes): Changed 'minimised' semantics to 'hide' semantics | In discussing #5043, it was agreed upon to keep `un/minimise-pane` as their own commands, but change the semantics around them to `hide-pane` and `show-pane`. This affects the commands themselves, but also a number of other functions and flags. @mgrant0 | f8e908b89c100e736bdf3dc13c5f490edd5ad97a | 0a7b008b2136d1275fc07a241d2465647f4cd7e7 | diff --git a/Makefile.am b/Makefile.am
index fc054091c5..bea57e6506 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -102,6 +102,7 @@ dist_tmux_SOURCES = \
cmd-display-panes.c \
cmd-find-window.c \
cmd-find.c \
+ cmd-hide-pane.c \
cmd-if-shell.c \
cmd-join-pane.c \
cmd-kill-pane.c \
@@ -117,7 +118,6 @@ dist_tm... | [
"Makefile.am",
"cmd-hide-pane.c",
"cmd-split-window.c",
"cmd-tile-float-pane.c",
"cmd.c",
"format.c",
"key-bindings.c",
"layout.c",
"screen-redraw.c",
"screen-write.c",
"tmux.1",
"tmux.h",
"window-tree.c",
"window.c"
] | [] | true | ||
tmux/tmux | 4,979 | issue_to_patch | refactor: Combined the code for `split-window` and `new-pane` | I have combined the code for `split-window` and `new-pane` as requested in #4800. I have merged the `split-window` code into `cmd-new-pane.c` because it is a more general name. Here is an overview of what I have done.
- The command now operates off of two modes, creating a window that is `FLOATING` or `TILED`. `spli... | b528fc438c627a35c130b45f2e67f24404615f7e | 0a55e5ca541c924c4f8515e55f8db18560222801 | diff --git a/Makefile.am b/Makefile.am
index a956035e6e..999e990968 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -115,7 +115,6 @@ dist_tmux_SOURCES = \
cmd-lock-server.c \
cmd-minimise-pane.c \
cmd-move-window.c \
- cmd-new-pane.c \
cmd-new-session.c \
cmd-new-window.c \
cmd-parse.y \
diff --git a/cmd-new-... | [
"Makefile.am",
"cmd-new-pane.c",
"cmd-split-window.c",
"tmux.1"
] | [] | true | ||
tmux/tmux | 4,929 | issue_to_patch | feat: Panes' status format now displays title/flag information | This is an implementation of point 9 from issue #4800:
'Modify status line 2 to be the name of the window pane and not width x height.`
I have added two new flags, `pane_zoomed_flag` and `pane_minimised_flag` to be utilized by formats. The implementation borrows the technique and styling used by `window_flags` for ... | ab0081294c26bf88652b6867b62ee7f07948c553 | 08fd890a890e6c827a8cdd7b5872cecdf57d140b | diff --git a/format.c b/format.c
index 398161e717..37316046d3 100644
--- a/format.c
+++ b/format.c
@@ -1004,6 +1004,15 @@ format_cb_pane_fg(struct format_tree *ft)
return (xstrdup(colour_tostring(gc.fg)));
}
+/* Callback for pane_flags. */
+static void *
+format_cb_pane_flags(struct format_tree *ft)
+{
+ if (ft->w... | [
"format.c",
"options-table.c",
"tmux.1",
"tmux.h",
"window.c"
] | [] | true | ||
tmux/tmux | 5,029 | issue_to_patch | fix(floating_panes): Z-index related crashing in `join-pane` | I have discovered that `join-pane` has the same fatal issue that `break-pane` had. I have applied the fix from @nicm to `join-pane`. | 05fdd042629327a9ced3a219df2f5f67ad04b8c1 | a1cd68e3f82b6a017b80d18948b88bd9a176f1d5 | diff --git a/cmd-join-pane.c b/cmd-join-pane.c
index c68d358864..2dfbda83b3 100644
--- a/cmd-join-pane.c
+++ b/cmd-join-pane.c
@@ -146,14 +146,18 @@ cmd_join_pane_exec(struct cmd *self, struct cmdq_item *item)
server_client_remove_pane(src_wp);
window_lost_pane(src_w, src_wp);
TAILQ_REMOVE(&src_w->panes, src_wp, ... | [
"cmd-join-pane.c"
] | [] | true | ||
tmux/tmux | 5,026 | issue_to_patch | docs(floating_panes): A couple documentation fixes from #4979 | 05fdd042629327a9ced3a219df2f5f67ad04b8c1 | a74f1739026386b9276c153e6818fa0d86d34221 | diff --git a/cmd-split-window.c b/cmd-split-window.c
index 046dc66e23..0cd6d8daaa 100644
--- a/cmd-split-window.c
+++ b/cmd-split-window.c
@@ -43,7 +43,7 @@ const struct cmd_entry cmd_new_pane_entry = {
"[-F format] [-l size] [-m message] [-M mode] "
"[-R inactive-border-style] [-s style] "
"[-S active-bord... | [
"cmd-split-window.c",
"tmux.1"
] | [] | true | |||
tmux/tmux | 5,039 | issue_to_patch | fix: fixed site of null dereference in layout.c | Here is the command to reproduce the crash: `splitw; splitw -hf`. | 3400a312dd028e75bd0f3cfa5ba8d4de82746cac | 0719dcf2e75938fc738b6e18deb377cc21fbb492 | diff --git a/layout.c b/layout.c
index b83af8a460..df7c5177e8 100644
--- a/layout.c
+++ b/layout.c
@@ -262,6 +262,7 @@ layout_fix_offsets1(struct layout_cell *lc)
xoff = lc->xoff;
TAILQ_FOREACH(lcchild, &lc->cells, entry) {
if (lcchild->type == LAYOUT_WINDOWPANE &&
+ lcchild->wp != NULL &&
lcchi... | [
"layout.c"
] | [] | true | ||
tmux/tmux | 5,042 | issue_to_patch | fix(floating_panes): null dereference in `screen_redraw_two_panes` from `screen_redraw_border_arrows` | The border arrows regression test was crashing due to passing `NULL` as an argument to a function that dereferences that argument. The regression test now passes. | 3400a312dd028e75bd0f3cfa5ba8d4de82746cac | e18c10d340ae92559b5bf8a50ffdf7612b526003 | diff --git a/screen-redraw.c b/screen-redraw.c
index 066bc94feb..8fd9839eae 100644
--- a/screen-redraw.c
+++ b/screen-redraw.c
@@ -974,7 +974,7 @@ screen_redraw_draw_border_arrows(struct screen_redraw_ctx *ctx, u_int i,
}
if ((int)j == wp->yoff + 1) {
if (border == SCREEN_REDRAW_OUTSIDE) {
- if (screen_redraw_... | [
"screen-redraw.c"
] | [] | true | ||
tmux/tmux | 4,893 | issue_to_patch | feat(format variable): added format variable for floating panes. | I implemented `10` from the [floating panes issues](https://github.com/tmux/tmux/issues/4800).
```
There needs to be a format variable if a pane is floating so that formats can distinguish them.
```
Let me know how it looks!
| 8e6450c8fc74674a0c26dd90f8c20a1cc8a039a5 | 0faed7aeb552a0afcf85677eae72904cdec4b5ca | diff --git a/format.c b/format.c
index 223f624b5a..4a6766f897 100644
--- a/format.c
+++ b/format.c
@@ -1004,6 +1004,20 @@ format_cb_pane_fg(struct format_tree *ft)
return (xstrdup(colour_tostring(gc.fg)));
}
+/* Callback for pane_floating_flag. */
+static void *
+format_cb_pane_floating_flag(struct format_tree *ft... | [
"format.c",
"tmux.1"
] | [] | true | ||
tmux/tmux | 4,799 | issue_to_patch | Sync from master | 34add944f2a89ab694917e5efd6abc8f83d5c47f | ca95950148ec7bc6eefcaa4702be642a2703439b | diff --git a/resize.c b/resize.c
index 2d7be9cbcc..9a61c30048 100644
--- a/resize.c
+++ b/resize.c
@@ -127,7 +127,7 @@ clients_calculate_size(int type, int current, struct client *c,
if (type == WINDOW_SIZE_LARGEST) {
*sx = 0;
*sy = 0;
- } else if (type == WINDOW_SIZE_MANUAL) {
+ } else if (w != NULL && type ==... | [
"resize.c",
"tty-keys.c"
] | [] | true | |||
tmuxinator/tmuxinator | 995 | issue_to_patch | test: update basic interface snapshots | ### Metadata
Adds the reproducing template from issue #988 (bug is not reproduced by our tests on Ruby 4)
### Problem / Motivation
The basic interface fixture does not exercise a named commands pane with multiple commands.
### Solution
- [X] CHANGELOG entry is added for code changes
Update the basic f... | abe46eee76105978bf0e2cb75dad43b4c8067bcf | d7e684e5bbe763a22f12147d4f8b328926940e7b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e3c0c525..d8f3b416 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
## Unreleased
### Misc
+- Update interface snapshots for the basic fixture commands pane
- Add `UPDATE_SNAPSHOTS` support for regenerating interface snapshots
- Update Ruby versions tested ... | [
"CHANGELOG.md",
"spec/fixtures/interface/basic.yml",
"spec/snapshots/debug/1.6/basic.sh",
"spec/snapshots/debug/1.8/basic.sh",
"spec/snapshots/debug/2.6/basic.sh"
] | [] | diff --git a/spec/fixtures/interface/basic.yml b/spec/fixtures/interface/basic.yml
index 6e599126..f7401603 100644
--- a/spec/fixtures/interface/basic.yml
+++ b/spec/fixtures/interface/basic.yml
@@ -11,4 +11,6 @@ windows:
- shell:
root: .
panes:
- - bin/setup
+ - commands:
+ - ... | true | |
tmuxinator/tmuxinator | 994 | issue_to_patch | test: add interface snapshot update mode | ### Problem / Motivation
Interface snapshot updates required ad hoc Ruby commands, so contributors could verify snapshots but not regenerate them through the documented interface test target.
### Solution
- [X] CHANGELOG entry is added for code changes
Teach the interface snapshot spec to rewrite snapshots ... | 34527219b4a5f225bbd99c0cf859d07ce13a0a64 | d7cfedb599ec471fcc98d68c72a2e84b29f7619b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ed078a78..e3c0c525 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
## Unreleased
### Misc
+- Add `UPDATE_SNAPSHOTS` support for regenerating interface snapshots
- Update Ruby versions tested in CI interface tests
## 3.4.0
diff --git a/README.md b/README.... | [
"CHANGELOG.md",
"README.md",
"spec/interface/debug_snapshot_spec.rb"
] | [] | diff --git a/spec/interface/debug_snapshot_spec.rb b/spec/interface/debug_snapshot_spec.rb
index b737e2c2..f8650ed4 100644
--- a/spec/interface/debug_snapshot_spec.rb
+++ b/spec/interface/debug_snapshot_spec.rb
@@ -6,6 +6,14 @@
let(:cli) { Tmuxinator::Cli }
let(:snapshot_root) { File.expand_path("../snapshots/deb... | true | |
tmuxinator/tmuxinator | 993 | issue_to_patch | chore: Update ruby versions in CI | ### Metadata
https://www.ruby-lang.org/en/downloads/branches/
### Problem / Motivation
Ruby 3.2 went EOL on April 1.
Ruby 4.0 was released Dec 25, 2025.
Stale Ruby patch versions included.
### Solution
- [X] CHANGELOG entry is added for code changes
Remove Ruby 3.2, bump 3.3 and 3.4, and add Rub... | 9db2f9f17445ff5cdf54ef58182e252f3a44ea82 | 4e6568f9b1adef6a6f9038e319e78327071d617a | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index edb7c046..f50f52dc 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -65,9 +65,9 @@ jobs:
fail-fast: false
matrix:
ruby-version:
- - '3.4.8'
- - '3.3.10'
- - '3.2.10'
+ ... | [
".github/workflows/ci.yaml",
"CHANGELOG.md"
] | [] | true | ||
tmuxinator/tmuxinator | 991 | issue_to_patch | chore: Bump tmuxinator to 3.4.0 | ## 3.4.0
### Features
- Add ability to focus panes via `focused_pane`
### Fixes
- Reintroduce `open` as an explicit create-or-open editor command
- Reintroduce `edit` as an explicit existing-config editor command
- Normalize project session names containing `.` or `:` to match tmux-created session names
### Misc... | 836ef6e3ab4e78c4deff902d97c6a71702b84591 | cc874ee539b99ed40c6571de4831de56d8f4108b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 11146e35..643a0764 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,14 +1,14 @@
## Unreleased
-### Features
+
+## 3.4.0
+### Features
- Add ability to focus panes via `focused_pane`
### Fixes
-
- Reintroduce `open` as an explicit create-or-open editor command
- Re... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 989 | issue_to_patch | chore: add support for tmux 3.6b | ### Metadata
https://github.com/tmux/tmux/releases/tag/3.6b
### Problem / Motivation
Newly released tmux 3.6b
### Solution
- [X] CHANGELOG entry is added for code changes
Add tmux 3.6b to `SUPPORTED_TMUX_VERSIONS`
### Testing
Updated config_spec.rb | c9f91d9135d28444c126899524e183e654d70eb8 | 51eb73faa4fd1263fd4ef4556d51884500b1d8bc | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e48a8b4a..11146e35 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,9 @@
- Reintroduce `open` as an explicit create-or-open editor command
- Reintroduce `edit` as an explicit existing-config editor command
- Normalize project session names containing `.` or `:` t... | [
"CHANGELOG.md",
"lib/tmuxinator/tmux_version.rb",
"spec/lib/tmuxinator/config_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/config_spec.rb b/spec/lib/tmuxinator/config_spec.rb
index 5de1ebc1..bbe61b3a 100644
--- a/spec/lib/tmuxinator/config_spec.rb
+++ b/spec/lib/tmuxinator/config_spec.rb
@@ -205,6 +205,7 @@
"v3.5" => 3.5,
"v3.6" => 3.6,
"v3.6a" => 3.6,
+ "v3.6b" => 3.6,
"v3.... | true | |
tmuxinator/tmuxinator | 984 | issue_to_patch | test: cover normalized tmux session targets | ### Problem
The session-name normalization fix from PR #983 is covered by unit specs, but the interface snapshot suite does not show reviewers the rendered tmux commands for project names containing separators.
### Solution
Add a minimal debug snapshot fixture for a project named `home.arpa:lab` so rendered se... | 8b26159819b04f4b81a279946f4fe11b71c30e2f | 6e33811880c59c4e097b0a2494e69972b4e08e47 | [
"spec/fixtures/interface/session_name.yml",
"spec/interface/debug_snapshot_spec.rb",
"spec/snapshots/debug/2.6/session_name.sh"
] | [] | diff --git a/spec/fixtures/interface/session_name.yml b/spec/fixtures/interface/session_name.yml
new file mode 100644
index 00000000..959dbd03
--- /dev/null
+++ b/spec/fixtures/interface/session_name.yml
@@ -0,0 +1,5 @@
+name: home.arpa:lab
+windows:
+ - main:
+ panes:
+ - echo ok
diff --git a/spec/interfa... | true | ||
tmuxinator/tmuxinator | 983 | issue_to_patch | fix: normalize tmux session names | ### Metadata
Relates to #93
### Problem
Tmux rewrites dots and colons in session names to underscores, so projects using those characters can create one session name and then target another when rendering tmux commands.
### Solution
Normalize dots and colons before shellescaping project session names, ad... | 45a1eb71824c3a927339b81b99a4c25bb7681dcf | 2e44b1b93fa64b5603479c2ebf806aaf66b85e17 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a8e6d940..e48a8b4a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@
- Reintroduce `open` as an explicit create-or-open editor command
- Reintroduce `edit` as an explicit existing-config editor command
+- Normalize project session names containing `.` or `:`... | [
"CHANGELOG.md",
"lib/tmuxinator/project.rb",
"spec/lib/tmuxinator/project_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/project_spec.rb b/spec/lib/tmuxinator/project_spec.rb
index 4f392abb..48ce57d4 100644
--- a/spec/lib/tmuxinator/project_spec.rb
+++ b/spec/lib/tmuxinator/project_spec.rb
@@ -232,6 +232,22 @@
end
end
+ context "with dots" do
+ it "uses the session name tmux creates"... | true | |
tmuxinator/tmuxinator | 981 | issue_to_patch | ci: streamline PR verification and tmux compatibility tests | ### Metadata
- Scope: GitHub Actions CI, Rake tasks, CLI specs, interface snapshots
- Verification: `bundle exec rake lint`, `bundle exec rake unit`, `bundle exec rake interface`
- A bit of a rework of https://github.com/tmuxinator/tmuxinator/pull/980
### Problem
The pull request workflow was paying for a la... | a1a9e5d3629f04bce6b97500a6c79e2e393e9916 | 4f9fab25a813eb7a7803ef5c0278068db06ba5c8 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index ccd12f64..edb7c046 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -1,93 +1,82 @@
+---
# continuous integration workflow based on old travis-ci configuration
-name: Integration Tests
-on:
- - push
- - pull_request
+n... | [
".github/workflows/ci.yaml",
"Rakefile",
"spec/fixtures/interface/basic.yml",
"spec/fixtures/interface/pane_titles.yml",
"spec/interface/debug_snapshot_spec.rb",
"spec/lib/tmuxinator/cli_spec.rb",
"spec/snapshots/debug/1.6/basic.sh",
"spec/snapshots/debug/1.6/pane_titles.sh",
"spec/snapshots/debug/1... | [] | diff --git a/spec/fixtures/interface/basic.yml b/spec/fixtures/interface/basic.yml
new file mode 100644
index 00000000..6e599126
--- /dev/null
+++ b/spec/fixtures/interface/basic.yml
@@ -0,0 +1,14 @@
+name: basic
+root: /workspace/basic
+tmux_options: -L interface
+pre_window: bundle exec ruby -v
+windows:
+ - editor:... | true | |
tmuxinator/tmuxinator | 953 | issue_to_patch | Aliases are not listed in help menu
As noted by @cwhits in [#416](https://github.com/tmuxinator/tmuxinator/pull/416#issuecomment-22135571), aliases defined using `map` (e.g. `map "edit" => :new`) are not listed by `tmuxinator help`, which appears to be by (Thor's) design. Since it looks like there's no way to achieve ... | Clarify new, open, and edit command semantics | ### Metadata
This PR fixes #817 and fixes #420.
### Problem / Motivation
`open` and `edit` were only aliases of `new`, which made them harder to
discover in help and blurred their intended roles.
- `edit` is an explicit command for opening an existing project file
- `open` is an explicit command for the e... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 96bf760e..a8e6d940 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
### Features
- Add ability to focus panes via `focused_pane`
+### Fixes
+
+- Reintroduce `open` as an explicit create-or-open editor command
+- Reintroduce `edit` as an explicit existing-c... | [
"CHANGELOG.md",
"README.md",
"lib/tmuxinator/cli.rb",
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The `append_option` description concatenates two strings without a separating space, so the generated help text will read `windowsand panes...`. Add a space at the end of the first fragment or the beginning of the second so the option description renders correctly.",
"path": "lib/tmuxinator/cl... | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 0c52e6be..0942d6e1 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -517,6 +517,16 @@
let(:name) { "test" }
let(:path) { Tmuxinator::Config.default_project(name) }
+ context "with --h... | true |
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | The `append_option` description concatenates two strings without a separating space, so the generated help text will read `windowsand panes...`. Add a space at the end of the first fragment or the beginning of the second so the option description renders correctly. | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "The `append_option` description concatenates two strings without a separating space, so the generated help text will read `windowsand panes...`. Add a space at the end of the first fragment or the beginning of the second so the option description renders correctly.",
"path": "lib/tmuxinator/cl... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `find_project_file` always calls `generate_project_file` when the target path doesn't exist, even when `existing: true`. This makes `edit`/`open_project` silently create a new config instead of erroring for missing projects (and also defeats the point of the `existing` flag). Consider exiting with a clear error when `e... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`find_project_file` always calls `generate_project_file` when the target path doesn't exist, even when `existing: true`. This makes `edit`/`open_project` silently create a new config instead of erroring for missing projects (and also defeats the point of the `existing` flag). Consider exiting with... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `write_project_from_session` writes to `path` unconditionally. When called from `open_project_with_session` with `existing: true`, this will overwrite an existing project file without confirmation, which is surprising for an `edit`-style command and risks data loss. Consider preventing overwrites when `existing: true` ... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`write_project_from_session` writes to `path` unconditionally. When called from `open_project_with_session` with `existing: true`, this will overwrite an existing project file without confirmation, which is surprising for an `edit`-style command and risks data loss. Consider preventing overwrites ... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This still maps `open` to `:edit` via Thor aliases, but Thor's `help` output only lists commands that have their own `desc`. If the intent is to address the long-standing alias-not-listed-in-help issue (see PR description / #420), `open` will remain missing from `tmuxinator help` unless it gets its own command method/`... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "This still maps `open` to `:edit` via Thor aliases, but Thor's `help` output only lists commands that have their own `desc`. If the intent is to address the long-standing alias-not-listed-in-help issue (see PR description / #420), `open` will remain missing from `tmuxinator help` unless it gets it... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.