repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This example stubs `Tmuxinator::Config.project(name)` and creates a temp file at `path`, but the new `edit` implementation resolves paths via `global_project/default_project` (not `Config.project`). As written, `cli.start` can operate on a different path (potentially writing into the real config directory) and the expe... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 0c52e6be..0942d6e1 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -517,6 +517,16 @@
let(:name) { "test" }
let(:path) { Tmuxinator::Config.default_project(name) }
+ context "with --h... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "This example stubs `Tmuxinator::Config.project(name)` and creates a temp file at `path`, but the new `edit` implementation resolves paths via `global_project/default_project` (not `Config.project`). As written, `cli.start` can operate on a different path (potentially writing into the real config d... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This context asserts that `tmuxinator edit <name>` creates a new project file when none exists. That conflicts with the PR motivation/help text that `edit` is for existing project files and should error when the named project doesn't exist. Either update `edit` to error for missing named projects (and adjust this spec ... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 0c52e6be..0942d6e1 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -517,6 +517,16 @@
let(:name) { "test" }
let(:path) { Tmuxinator::Config.default_project(name) }
+ context "with --h... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "This context asserts that `tmuxinator edit <name>` creates a new project file when none exists. That conflicts with the PR motivation/help text that `edit` is for existing project files and should error when the named project doesn't exist. Either update `edit` to error for missing named projects ... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | These new `find_project_file(... existing: true)` examples expect the method to return a path (and currently it will generate the file if missing). If `existing: true` is meant to enforce “must already exist” for the new `edit`/`open` behavior, these specs should instead expect an error/exit when the resolved named pro... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 0c52e6be..0942d6e1 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -517,6 +517,16 @@
let(:name) { "test" }
let(:path) { Tmuxinator::Config.default_project(name) }
+ context "with --h... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "These new `find_project_file(... existing: true)` examples expect the method to return a path (and currently it will generate the file if missing). If `existing: true` is meant to enforce “must already exist” for the new `edit`/`open` behavior, these specs should instead expect an error/exit when ... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | Markdown formatting: there should be a blank line between the last list item under `### Features` and the next heading (`### Misc`). Without a blank line, many renderers treat the heading as part of the list item. | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 96bf760e..a8e6d940 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
### Features
- Add ability to focus panes via `focused_pane`
+### Fixes
+
+- Reintroduce `open` as an explicit create-or-open editor command
+- Reintroduce `edit` as an explicit existing-c... | [
"CHANGELOG.md"
] | [
{
"comment": "Markdown formatting: there should be a blank line between the last list item under `### Features` and the next heading (`### Misc`). Without a blank line, many renderers treat the heading as part of the list item.",
"path": "CHANGELOG.md",
"hunk": "@@ -2,6 +2,9 @@\n ### Features\n \n - Add... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `open` is no longer mapped to `new` and now routes through `open_project` (i.e., `find_project_file(..., editing: true)`), which exits when the named project file is missing. This is a user-facing behavior change compared to the previous `open -> new` alias and appears to contradict the PR description’s claim of no bac... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`open` is no longer mapped to `new` and now routes through `open_project` (i.e., `find_project_file(..., editing: true)`), which exits when the named project file is missing. This is a user-facing behavior change compared to the previous `open -> new` alias and appears to contradict the PR descrip... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | The changelog entry only mentions re-implementing the `edit` command, but this PR also makes `open` an explicit command and (as currently implemented) changes its behavior compared to being an alias of `new`. Please update this entry to reflect the full user-visible CLI change (and note any compatibility impact), or ad... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 96bf760e..a8e6d940 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
### Features
- Add ability to focus panes via `focused_pane`
+### Fixes
+
+- Reintroduce `open` as an explicit create-or-open editor command
+- Reintroduce `edit` as an explicit existing-c... | [
"CHANGELOG.md"
] | [
{
"comment": "The changelog entry only mentions re-implementing the `edit` command, but this PR also makes `open` an explicit command and (as currently implemented) changes its behavior compared to being an alias of `new`. Please update this entry to reflect the full user-visible CLI change (and note any compat... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `new` currently shows help whenever `name` is nil, which prevents `tmuxinator new --local` (no project name) from creating a local config even though local flows infer the name from `Dir.pwd` (and the README suggests the name is optional). Consider matching `open`/`edit` by only showing help when `name` is missing *and... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`new` currently shows help whenever `name` is nil, which prevents `tmuxinator new --local` (no project name) from creating a local config even though local flows infer the name from `Dir.pwd` (and the README suggests the name is optional). Consider matching `open`/`edit` by only showing help when ... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This line exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) and is likely to fail linting. Please wrap the expression across multiple lines (e.g., using parentheses and a line break). | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "This line exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) and is likely to fail linting. Please wrap the expression across multiple lines (e.g., using parentheses and a line break).",
"path": "lib/tmuxinator/cli.rb",
"hunk": "@@ -155,31 +446,80 @@ def new_project_with_session... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This line exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) and is likely to fail linting. Please wrap the `global_project || default_project` expression onto multiple lines for readability and to satisfy the linter. | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "This line exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) and is likely to fail linting. Please wrap the `global_project || default_project` expression onto multiple lines for readability and to satisfy the linter.",
"path": "lib/tmuxinator/cli.rb",
"hunk": "@@ -155,31 +446,8... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `find_project_file` only errors on missing configs when `editing && !local`, meaning `tmuxinator edit --local` will still generate a new local config if it doesn't exist. The PR description states `edit` should only open existing project files (including for local flows); either update the implementation to exit for mi... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`find_project_file` only errors on missing configs when `editing && !local`, meaning `tmuxinator edit --local` will still generate a new local config if it doesn't exist. The PR description states `edit` should only open existing project files (including for local flows); either update the impleme... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | This context description line still exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) even with the line continuation. Consider shortening the description or splitting it (e.g., string concatenation) to avoid lint failures. | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 0c52e6be..0942d6e1 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -517,6 +517,16 @@
let(:name) { "test" }
let(:path) { Tmuxinator::Config.default_project(name) }
+ context "with --h... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "This context description line still exceeds the repo's RuboCop `Layout/LineLength` max (80 chars) even with the line continuation. Consider shortening the description or splitting it (e.g., string concatenation) to avoid lint failures.",
"path": "spec/lib/tmuxinator/cli_spec.rb",
"hunk": "... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `ensure_new_project_target!` only checks `Config.global_project(name)` for non-local projects. `Config.global_project` matches on basename and can return `nil` for valid existing projects that live in subdirectories (e.g. name `sub/project`), allowing `tmuxinator new` to overwrite an existing config despite the new sem... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`ensure_new_project_target!` only checks `Config.global_project(name)` for non-local projects. `Config.global_project` matches on basename and can return `nil` for valid existing projects that live in subdirectories (e.g. name `sub/project`), allowing `tmuxinator new` to overwrite an existing conf... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | When `editing` is true and `name` is `nil` (e.g. `tmuxinator edit --local`), this error message becomes `Project doesn't exist!`, which is confusing and doesn’t indicate the missing local config path. Consider emitting a local-specific message (e.g. using `Tmuxinator::Config::NO_LOCAL_FILE_MSG`) when `local` is true /... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "When `editing` is true and `name` is `nil` (e.g. `tmuxinator edit --local`), this error message becomes `Project doesn't exist!`, which is confusing and doesn’t indicate the missing local config path. Consider emitting a local-specific message (e.g. using `Tmuxinator::Config::NO_LOCAL_FILE_MSG`) ... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `edit --local <name>` currently ignores `name` for the path (always uses `./.tmuxinator.yml`), but if the local file is missing it falls through to `exit! "Project #{name} doesn't exist!"`. This is misleading for local mode and also inconsistent with the `NO_LOCAL_FILE_MSG` handling. Consider either disallowing a proje... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`edit --local <name>` currently ignores `name` for the path (always uses `./.tmuxinator.yml`), but if the local file is missing it falls through to `exit! \"Project #{name} doesn't exist!\"`. This is misleading for local mode and also inconsistent with the `NO_LOCAL_FILE_MSG` handling. Consider ei... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | The `--local` option description for `edit` says it will "Create local project file", but `edit` explicitly refuses to create anything and exits when the file is missing. Updating the option description to reflect the actual behavior (e.g., "Use local project file at ...") would make `tmuxinator help edit` accurate. | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "The `--local` option description for `edit` says it will \"Create local project file\", but `edit` explicitly refuses to create anything and exits when the file is missing. Updating the option description to reflect the actual behavior (e.g., \"Use local project file at ...\") would make `tmuxinat... | true | ||
tmuxinator/tmuxinator | 953 | comment_to_fix | Clarify new, open, and edit command semantics | `Kernel.system("$EDITOR #{path}")` invokes a shell, so spaces/shell metacharacters in `path` can change the executed command. To avoid command-injection/quoting issues, consider using the multi-arg form of `system` (e.g., split `$EDITOR` into argv and pass `path` as a separate argument) so Ruby bypasses the shell and h... | 3586520c4a4b74b0f728318cc4bec313d13cd35f | 9881d1dbf57a798e08ae2af42de3a53cd592e694 | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 282d84b4..1b6ea151 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -22,13 +22,13 @@ def self.exit_on_failure?
debug: "Output the shell commands that are generated by tmuxinator",
delete: "Deletes given project",
doct... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "`Kernel.system(\"$EDITOR #{path}\")` invokes a shell, so spaces/shell metacharacters in `path` can change the executed command. To avoid command-injection/quoting issues, consider using the multi-arg form of `system` (e.g., split `$EDITOR` into argv and pass `path` as a separate argument) so Ruby ... | true | ||
tmuxinator/tmuxinator | 952 | issue_to_patch | Select focused pane for each window
**Is your feature request related to a problem? Please describe.**
For windows that have multiple panes, I often have to navigate to the primary pane (which is not necessarily the largest in the layout) manually.
**Describe the solution you'd like**
There could be a window ... | Add support for focus panes | ### Metadata
Fixes #878
### Problem / Motivation
As outlined in the linked PR, users would like the ability to select specific panes in each window. Prior solutions such as `startup_pane` are insufficient.
### Solution
This PR adds the ability to specify a focused pane under the window section. A focused... | 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 82491ae8..96bf760e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,7 @@
## Unreleased
+### Features
+
+- Add ability to focus panes via `focused_pane`
## 3.3.8
### Features
diff --git a/README.md b/README.md
index 4db136de..5010f0ba 100644
--- a/README.md
+++ ... | [
"CHANGELOG.md",
"README.md",
"lib/tmuxinator/assets/sample.yml",
"lib/tmuxinator/assets/template.erb",
"lib/tmuxinator/assets/wemux_template.erb",
"lib/tmuxinator/project.rb",
"lib/tmuxinator/window.rb",
"spec/lib/tmuxinator/project_spec.rb",
"spec/lib/tmuxinator/window_spec.rb"
] | [
{
"comment": "`tmux_startup_pane_command` treats any truthy value (including an empty string) as configured. If a YAML config sets `startup_pane: \"\"`, this will emit `select-pane -t <session>:<window>.` which is an invalid target. Consider treating blank values as unset (e.g., `return \"\" if blank?(yaml[\"st... | diff --git a/spec/lib/tmuxinator/project_spec.rb b/spec/lib/tmuxinator/project_spec.rb
index 215819fa..4f392abb 100644
--- a/spec/lib/tmuxinator/project_spec.rb
+++ b/spec/lib/tmuxinator/project_spec.rb
@@ -73,10 +73,40 @@
expect(project.render).to_not be_empty
end
+ it "renders focused pane selection ... | true |
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | `tmux_startup_pane_command` treats any truthy value (including an empty string) as configured. If a YAML config sets `startup_pane: ""`, this will emit `select-pane -t <session>:<window>.` which is an invalid target. Consider treating blank values as unset (e.g., `return "" if blank?(yaml["startup_pane"])`) and/or vali... | 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/project.rb b/lib/tmuxinator/project.rb
index 71de8359..d38ead2b 100644
--- a/lib/tmuxinator/project.rb
+++ b/lib/tmuxinator/project.rb
@@ -200,6 +200,10 @@ def tmux_command
yaml["tmux_command"] || "tmux"
end
+ def tmux_startup_pane_command
+ "#{tmux} select-pane -t #{st... | [
"lib/tmuxinator/project.rb"
] | [
{
"comment": "`tmux_startup_pane_command` treats any truthy value (including an empty string) as configured. If a YAML config sets `startup_pane: \"\"`, this will emit `select-pane -t <session>:<window>.` which is an invalid target. Consider treating blank values as unset (e.g., `return \"\" if blank?(yaml[\"st... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | Typo in comment: "iwth" should be "with".
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/window.rb b/lib/tmuxinator/window.rb
index 074b65f8..82188db0 100644
--- a/lib/tmuxinator/window.rb
+++ b/lib/tmuxinator/window.rb
@@ -17,7 +17,7 @@ def initialize(window_yaml, index, project)
end
def panes
- build_panes(yaml["panes"]) || []
+ @panes ||= build_panes(yam... | [
"lib/tmuxinator/window.rb"
] | [
{
"comment": "Typo in comment: \"iwth\" should be \"with\".\n",
"path": "lib/tmuxinator/window.rb",
"hunk": "@@ -134,16 +138,41 @@ def tmux_layout_command\n \"#{project.tmux} select-layout -t #{tmux_window_target} #{layout}\"\n end\n \n- def tmux_select_first_pane\n- \"#{project.tmux} ... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | In `pane_index`, the local variable `focused_pane` shadows the private method `focused_pane` defined above. Renaming the local (e.g., `focused_pane_config`) would avoid confusion and reduce the chance of mistakes during future edits.
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/window.rb b/lib/tmuxinator/window.rb
index 074b65f8..82188db0 100644
--- a/lib/tmuxinator/window.rb
+++ b/lib/tmuxinator/window.rb
@@ -17,7 +17,7 @@ def initialize(window_yaml, index, project)
end
def panes
- build_panes(yaml["panes"]) || []
+ @panes ||= build_panes(yam... | [
"lib/tmuxinator/window.rb"
] | [
{
"comment": "In `pane_index`, the local variable `focused_pane` shadows the private method `focused_pane` defined above. Renaming the local (e.g., `focused_pane_config`) would avoid confusion and reduce the chance of mistakes during future edits.\n",
"path": "lib/tmuxinator/window.rb",
"hunk": "@@ -134... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | Test description has a trailing space ("focuses first "), which makes the spec output a bit sloppy; consider trimming and/or clarifying the wording (e.g., "focuses first pane").
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/spec/lib/tmuxinator/window_spec.rb b/spec/lib/tmuxinator/window_spec.rb
index e02e74e2..19a63bd8 100644
--- a/spec/lib/tmuxinator/window_spec.rb
+++ b/spec/lib/tmuxinator/window_spec.rb
@@ -5,6 +5,7 @@
describe Tmuxinator::Window do
let(:project) { double }
let(:panes) { ["vim", nil, "top"] }
+ let... | [
"spec/lib/tmuxinator/window_spec.rb"
] | [
{
"comment": "Test description has a trailing space (\"focuses first \"), which makes the spec output a bit sloppy; consider trimming and/or clarifying the wording (e.g., \"focuses first pane\").\n",
"path": "spec/lib/tmuxinator/window_spec.rb",
"hunk": "@@ -148,6 +150,74 @@\n end\n end\n \n+ ... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | README uses "Tmux" here, but elsewhere the project consistently refers to the tool as "tmux". Consider changing to "tmux v2.6" for consistency.
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/README.md b/README.md
index 4db136de..5010f0ba 100644
--- a/README.md
+++ b/README.md
@@ -142,7 +142,7 @@ root: ~/
# Specifies (by name or index) which window will be selected on project startup. If not set, the first window is used.
# startup_window: editor
-# Specifies (by index) which pane of the sp... | [
"README.md"
] | [
{
"comment": "README uses \"Tmux\" here, but elsewhere the project consistently refers to the tool as \"tmux\". Consider changing to \"tmux v2.6\" for consistency.\n",
"path": "README.md",
"hunk": "@@ -232,16 +232,10 @@ The layout setting gets handed down to tmux directly, so you can choose from\n one o... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | `focused_pane` accepts negative integers because Ruby arrays allow negative indexing (e.g. -1 returns the last pane). This will produce an invalid tmux target after adding `pane_base_index` (e.g. base 0 => -1) and conflicts with the documented “indices start at zero” behavior. Add a guard to treat any index < 0 as inva... | 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/window.rb b/lib/tmuxinator/window.rb
index 074b65f8..82188db0 100644
--- a/lib/tmuxinator/window.rb
+++ b/lib/tmuxinator/window.rb
@@ -17,7 +17,7 @@ def initialize(window_yaml, index, project)
end
def panes
- build_panes(yaml["panes"]) || []
+ @panes ||= build_panes(yam... | [
"lib/tmuxinator/window.rb"
] | [
{
"comment": "`focused_pane` accepts negative integers because Ruby arrays allow negative indexing (e.g. -1 returns the last pane). This will produce an invalid tmux target after adding `pane_base_index` (e.g. base 0 => -1) and conflicts with the documented “indices start at zero” behavior. Add a guard to treat... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | Inside `pane_index`, the local variable `pane_index = Integer(...)` shadows the method name `pane_index`, which makes the control flow harder to read and debug. Rename the local to something like `idx` (and update subsequent uses) to avoid the shadowing.
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/window.rb b/lib/tmuxinator/window.rb
index 074b65f8..82188db0 100644
--- a/lib/tmuxinator/window.rb
+++ b/lib/tmuxinator/window.rb
@@ -17,7 +17,7 @@ def initialize(window_yaml, index, project)
end
def panes
- build_panes(yaml["panes"]) || []
+ @panes ||= build_panes(yam... | [
"lib/tmuxinator/window.rb"
] | [
{
"comment": "Inside `pane_index`, the local variable `pane_index = Integer(...)` shadows the method name `pane_index`, which makes the control flow harder to read and debug. Rename the local to something like `idx` (and update subsequent uses) to avoid the shadowing.\n",
"path": "lib/tmuxinator/window.rb",... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | The updated `startup_pane` comment no longer mentions the default behavior when it is unset. Since `startup_pane` is optional and tmuxinator still selects the first pane by default, consider explicitly documenting that “If not set, the first pane is used” to avoid confusion.
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/README.md b/README.md
index 4db136de..5010f0ba 100644
--- a/README.md
+++ b/README.md
@@ -142,7 +142,7 @@ root: ~/
# Specifies (by name or index) which window will be selected on project startup. If not set, the first window is used.
# startup_window: editor
-# Specifies (by index) which pane of the sp... | [
"README.md"
] | [
{
"comment": "The updated `startup_pane` comment no longer mentions the default behavior when it is unset. Since `startup_pane` is optional and tmuxinator still selects the first pane by default, consider explicitly documenting that “If not set, the first pane is used” to avoid confusion.\n",
"path": "READM... | true | ||
tmuxinator/tmuxinator | 952 | comment_to_fix | Add support for focus panes | Like the README, this sample config comment for `startup_pane` no longer mentions the default behavior when it is unset. Since `startup_pane` is optional and tmuxinator still selects the first pane by default, consider adding “If not set, the first pane is used” for clarity.
| 616d095952de9900772a72377bde32781b5db8a3 | 2e89364702dd5ee57ae12e42200153c3d959b31e | diff --git a/lib/tmuxinator/assets/sample.yml b/lib/tmuxinator/assets/sample.yml
index 7a79a92f..ad6f4cd9 100644
--- a/lib/tmuxinator/assets/sample.yml
+++ b/lib/tmuxinator/assets/sample.yml
@@ -38,7 +38,7 @@ root: ~/
# Specifies (by name or index) which window will be selected on project startup. If not set, the firs... | [
"lib/tmuxinator/assets/sample.yml"
] | [
{
"comment": "Like the README, this sample config comment for `startup_pane` no longer mentions the default behavior when it is unset. Since `startup_pane` is optional and tmuxinator still selects the first pane by default, consider adding “If not set, the first pane is used” for clarity.\n",
"path": "lib/t... | true | ||
tmuxinator/tmuxinator | 977 | issue_to_patch | chore: Bump tmuxinator to v3.3.8 | ## 3.3.8
### Features
- Add completion support for 'stop' command in tmuxinator
### Misc
- Revert gemspec required ruby version to >= 2.6 | f303fdc449c1a1b98780373f04ae3450fad8a2ad | 6a73ddabe719ef433cffa8e5f78c8a72ce0a85f8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e73c3632..82491ae8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.8
### Features
- Add completion support for 'stop' command in tmuxinator
### Misc
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator/version.rb
index d9591669..... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 976 | issue_to_patch | Lower supported Ruby version back to 2.6
👋 thanks for all the hard work on this gem, I'd like to request that you lower the supported Ruby version back to 2.6, as earlier versions of 3.3.x e.g. 3.3.2 have.
# Why?
MacOS still ships with Ruby 2.6.
# Reasoning
Currently you can install tmuxinator and tmux on a cl... | fix: Revert rubygems ruby version to >= 2.6 | ### Metadata
Fixes #974
### Problem / Motivation
The latest version of tmuxinator cannot be installed on system ruby on macos:
```
$ sudo /usr/bin/gem install tmuxinator
ERROR: Error installing tmuxinator:
The last version of tmuxinator (>= 0) to support your Ruby & RubyGems was 3.3.4. Try insta... | db826a8fdb5c744dfa3bdc639a96c231d0b49aa3 | 8901c64c69a4fbe69e115d94fce990a0cf703fdb | diff --git a/.rubocop.yml b/.rubocop.yml
index 05c9cc4c..b983d4f2 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
- "db/schema.rb"
DisplayCopNames: true
StyleGuideCopsOnly: false
- TargetRubyVersion: 2.7
+ TargetRubyVersion: 2.6
Layout/AccessModifierIndentation:
Description: Check i... | [
".rubocop.yml",
"CHANGELOG.md",
"tmuxinator.gemspec"
] | [
{
"comment": "`required_ruby_version` is the contract for the *minimum supported runtime*. With the repo still targeting Ruby 2.7 in linting (and likely local dev), it’s easy to accidentally introduce Ruby 2.7-only syntax/stdlib usage while publishing a gem that claims Ruby 2.6 support. If Ruby 2.6 is truly sup... | true | |
tmuxinator/tmuxinator | 976 | comment_to_fix | fix: Revert rubygems ruby version to >= 2.6 | `required_ruby_version` is the contract for the *minimum supported runtime*. With the repo still targeting Ruby 2.7 in linting (and likely local dev), it’s easy to accidentally introduce Ruby 2.7-only syntax/stdlib usage while publishing a gem that claims Ruby 2.6 support. If Ruby 2.6 is truly supported, align enforcem... | db826a8fdb5c744dfa3bdc639a96c231d0b49aa3 | 8901c64c69a4fbe69e115d94fce990a0cf703fdb | diff --git a/tmuxinator.gemspec b/tmuxinator.gemspec
index 36d232e2..eb36c08b 100644
--- a/tmuxinator.gemspec
+++ b/tmuxinator.gemspec
@@ -38,7 +38,8 @@ Gem::Specification.new do |s|
}
s.required_rubygems_version = Gem::Requirement.new(">= 2.7")
- s.required_ruby_version = ">= 2.7"
+ # Keep installation worki... | [
"tmuxinator.gemspec"
] | [
{
"comment": "`required_ruby_version` is the contract for the *minimum supported runtime*. With the repo still targeting Ruby 2.7 in linting (and likely local dev), it’s easy to accidentally introduce Ruby 2.7-only syntax/stdlib usage while publishing a gem that claims Ruby 2.6 support. If Ruby 2.6 is truly sup... | true | ||
tmuxinator/tmuxinator | 976 | comment_to_fix | fix: Revert rubygems ruby version to >= 2.6 | Disabling `Gemspec/RequiredRubyVersion` globally removes an important consistency check across the repo. Prefer scoping the exception to just the gemspec (e.g., exclude `tmuxinator.gemspec` for this cop, or use an inline disable/enable around the specific line) so other gemspecs/files still benefit from the rule.
| db826a8fdb5c744dfa3bdc639a96c231d0b49aa3 | 8901c64c69a4fbe69e115d94fce990a0cf703fdb | diff --git a/.rubocop.yml b/.rubocop.yml
index 05c9cc4c..b983d4f2 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
- "db/schema.rb"
DisplayCopNames: true
StyleGuideCopsOnly: false
- TargetRubyVersion: 2.7
+ TargetRubyVersion: 2.6
Layout/AccessModifierIndentation:
Description: Check i... | [
".rubocop.yml"
] | [
{
"comment": "Disabling `Gemspec/RequiredRubyVersion` globally removes an important consistency check across the repo. Prefer scoping the exception to just the gemspec (e.g., exclude `tmuxinator.gemspec` for this cop, or use an inline disable/enable around the specific line) so other gemspecs/files still benefi... | true | ||
tmuxinator/tmuxinator | 976 | comment_to_fix | fix: Revert rubygems ruby version to >= 2.6 | Under `## Unreleased`, subsections appear to use `###` headings (e.g., `### Features`), but `Misc` was added as `## Misc`, which breaks the heading hierarchy/formatting. Change it to `### Misc` for consistency. | db826a8fdb5c744dfa3bdc639a96c231d0b49aa3 | 8901c64c69a4fbe69e115d94fce990a0cf703fdb | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3290ab38..e73c3632 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,8 @@
## Unreleased
### Features
- Add completion support for 'stop' command in tmuxinator
+### Misc
+- Revert gemspec required ruby version to >= 2.6
## 3.3.7
## Misc
| [
"CHANGELOG.md"
] | [
{
"comment": "Under `## Unreleased`, subsections appear to use `###` headings (e.g., `### Features`), but `Misc` was added as `## Misc`, which breaks the heading hierarchy/formatting. Change it to `### Misc` for consistency.",
"path": "CHANGELOG.md",
"hunk": "@@ -1,6 +1,8 @@\n ## Unreleased\n ### Featur... | true | ||
tmuxinator/tmuxinator | 976 | comment_to_fix | fix: Revert rubygems ruby version to >= 2.6 | The changelog entry says 'rubygems required ruby version', but the actual change is to the gemspec’s `required_ruby_version` (Ruby), not `required_rubygems_version` (RubyGems). Please reword to avoid confusion (e.g., 'Revert required Ruby version to >= 2.6'). | db826a8fdb5c744dfa3bdc639a96c231d0b49aa3 | 8901c64c69a4fbe69e115d94fce990a0cf703fdb | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3290ab38..e73c3632 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,8 @@
## Unreleased
### Features
- Add completion support for 'stop' command in tmuxinator
+### Misc
+- Revert gemspec required ruby version to >= 2.6
## 3.3.7
## Misc
| [
"CHANGELOG.md"
] | [
{
"comment": "The changelog entry says 'rubygems required ruby version', but the actual change is to the gemspec’s `required_ruby_version` (Ruby), not `required_rubygems_version` (RubyGems). Please reword to avoid confusion (e.g., 'Revert required Ruby version to >= 2.6').",
"path": "CHANGELOG.md",
"hun... | true | ||
tmuxinator/tmuxinator | 975 | issue_to_patch | feat: Add completion support for 'stop' command in tmuxinator | Enhance tmuxinator command completions by adding support for the 'stop' command in both Fish and Zsh completion scripts, improving user experience and command discoverability.
### Metadata
completion/tmuxinator.fish — add completion entry for stop.
completion/tmuxinator.zsh — add stop to the subcommand list.
CH... | 4c836b8cc18c9bf5637b6dd7b303df1f92a246b1 | 1054504298630cac290a8439ef93a3230cd10ca6 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ef8de21a..3290ab38 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+### Features
+- Add completion support for 'stop' command in tmuxinator
## 3.3.7
## Misc
diff --git a/completion/tmuxinator.fish b/completion/tmuxinator.fish
index 8e4e88e5.... | [
"CHANGELOG.md",
"completion/tmuxinator.fish",
"completion/tmuxinator.zsh"
] | [] | true | ||
tmuxinator/tmuxinator | 973 | issue_to_patch | chore: Update Ruby versions in CI; add Ruby 4.0 | ### Metadata
https://www.ruby-lang.org/en/downloads/branches/
### Problem / Motivation
Ruby 4.0 released at the start of 2026
### Solution
Bump the patch versions of ruby in our CI config; Add Ruby 4.0.1
### Testing
Within the CI pipeline | 8f8a4687c229b4d0ed725451057b32f14b476ebd | 9ea6ad137b9d7fb238e827db196333c40d125ec3 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 1d9015f2..3cc8bd58 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,9 +11,10 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- - '3.4.5'
- - '3.3.9'
- - '3.2.9'
+ ... | [
".github/workflows/ci.yaml"
] | [] | true | ||
tmuxinator/tmuxinator | 972 | issue_to_patch | chore: Bump tmuxinator to v3.3.7 | ## 3.3.7
## Misc
- Update CI tmux versions to include 3.6a
- Include tmux 3.6a in supported versions list
| db861a077dfed884c9a9541b14fb97f08b0d5665 | 50837850b30de12a8342eb922374c3879eca6aa8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 65af15b6..ef8de21a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.7
## Misc
- Update CI tmux versions to include 3.6a
- Include tmux 3.6a in supported versions list
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator/version.rb... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 971 | issue_to_patch | chore: Add support for tmux 3.6a | ### Metadata
See https://github.com/tmux/tmux/releases/tag/3.6a
### Problem / Motivation
Tmux 3.6a was recently released
### Solution
- [X] CHANGELOG entry is added for code changes
Update the CI pipeline and list of supported tmux versions to include tmux 3.6a
### Testing
N/A
| 984d3cbf5bb4ca720c60cbe8239d8a73516222cd | ed6aa4e69e55b20df486b312ac1ef4c20ebe6f8d | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index bea2613b..38c1e07f 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -15,6 +15,7 @@ jobs:
- '3.3.9'
- '3.2.9'
tmux_version:
+ - '3.6a'
- '3.6'
- '3.5a'
... | [
".github/workflows/ci.yaml",
"CHANGELOG.md",
"lib/tmuxinator/tmux_version.rb",
"spec/lib/tmuxinator/config_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/config_spec.rb b/spec/lib/tmuxinator/config_spec.rb
index 89eaf1db..5de1ebc1 100644
--- a/spec/lib/tmuxinator/config_spec.rb
+++ b/spec/lib/tmuxinator/config_spec.rb
@@ -204,6 +204,7 @@
"2.9ä" => 2.9,
"v3.5" => 3.5,
"v3.6" => 3.6,
+ "v3.6a" => 3.6,
"v3.1... | true | |
tmuxinator/tmuxinator | 965 | issue_to_patch | Update copyright notice in README
README.md currently reads:
> Copyright (c) 2010-2020 Allen Bargi, Christopher Chow. See LICENSE for further details.
It should be updated to 2010-2025.
In an ideal world, we'd have a GH Action or something which runs on 1/1 every year and updates it but that's probably overthinkin... | Update copyright section in README.md | Update the date range used in the copyright notice in README.md
Closes #964 | 04ed23e90a7da6a6dcbc015c9c56f6379c93f6ca | 9b973e466797cd69aa57171f96eab3130ec5be7b | diff --git a/README.md b/README.md
index 6b63b2db..4db136de 100644
--- a/README.md
+++ b/README.md
@@ -455,4 +455,4 @@ To contribute, please read the [contributing guide](https://github.com/tmuxinato
## Copyright
-Copyright (c) 2010-2020 Allen Bargi, Christopher Chow. See LICENSE for further details.
+Copyright (c... | [
"README.md"
] | [] | true | |
tmuxinator/tmuxinator | 970 | issue_to_patch | chore(deps): Bump actions/checkout from 5 to 6 | Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README to includ... | 5c93af7f6d95d0d4e7fdc01ef8570f2a443ecf98 | 51785a8d57e46e1b9defb31effce438141113298 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 1d9015f2..bea2613b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -69,7 +69,7 @@ jobs:
cd ..
tmux -V
- - uses: actions/checkout@v5
+ - uses: actions/checkout@v6
- name: "Test ruby ${{ matri... | [
".github/workflows/ci.yaml"
] | [] | true | ||
tmuxinator/tmuxinator | 969 | issue_to_patch | chore: Bump tmuxinator to 3.3.6 | ## 3.3.6
### Features
- Add `help` to the list of commands output by `tmuxinator commands`
- Add `--help`/`-h` flag support to subcommands (start, stop, new, debug, copy, delete, list) for easier access to command-specific help
## Misc
- Update CI ruby versions to latest, remove Ruby 3.1
- Update CI tmux versions... | dffd17574ffbc98e1769580c1d97f3994a3c0513 | d1b44257e9bedf9667f603d71c8bafeb421413d8 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 28d4e23f..fe086c65 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.6
### Features
- Add `help` to the list of commands output by `tmuxinator commands`
- Add `--help`/`-h` flag support to subcommands (start, stop, new, debug, copy, d... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 968 | issue_to_patch | chore: Add support for tmux 3.6 | ### Metadata
https://github.com/tmux/tmux/releases/tag/3.6
### Problem
tmux 3.6 was just released
tmuxinator does not yet support it or test against it
### Solution
Add tmux 3.6 to the test matrix and supported versions list.
- [X] CHANGELOG entry is added for code changes
### Testing
Describ... | 71275f96cb73564448afc24e0dc7b8b924c92a4d | 827d9d160552787c3622906cd440e56318d6097a | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 858fc5e2..1d9015f2 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -15,6 +15,7 @@ jobs:
- '3.3.9'
- '3.2.9'
tmux_version:
+ - '3.6'
- '3.5a'
- '3.5'
... | [
".github/workflows/ci.yaml",
"CHANGELOG.md",
"lib/tmuxinator/tmux_version.rb",
"spec/lib/tmuxinator/config_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/config_spec.rb b/spec/lib/tmuxinator/config_spec.rb
index b3f362fc..89eaf1db 100644
--- a/spec/lib/tmuxinator/config_spec.rb
+++ b/spec/lib/tmuxinator/config_spec.rb
@@ -203,6 +203,7 @@
"!@#^%" => 0.0,
"2.9ä" => 2.9,
"v3.5" => 3.5,
+ "v3.6" => 3.6,
"v3.1... | true | |
tmuxinator/tmuxinator | 967 | issue_to_patch | Detach session automatically
Hello,
I'm looking to launch a project at startup and then detach immediately so that other people can use the session. Is there any way to do that? I tried sending in a C-b D and ^b D as the second line of the panel array but that just sent that text to the pane. Any ideas? | Add help to commands list and --help/-h flag support to subcommands | ### Metadata
Fixes: https://github.com/tmuxinator/tmuxinator/issues/191#issuecomment-3539068931
### Problem / Motivation
Users reported two discoverability issues with tmuxinator's help system:
1. The `help` command was not listed in the output of `mux commands`, making it less discoverable for users who di... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d1db2925..14138a79 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,7 @@
## Unreleased
+### Features
+- Add `help` to the list of commands output by `tmuxinator commands`
+- Add `--help`/`-h` flag support to subcommands (start, stop, new, debug, copy, delete, list)... | [
"CHANGELOG.md",
"lib/tmuxinator/cli.rb",
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The `copy` method requires two mandatory parameters (`existing` and `new`), which means Thor will raise an error about missing required arguments when users try `tmuxinator copy --help` before the `options[:help]` check in the method body can execute.\n\nTo fix this, make the parameters optional w... | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | true |
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The `copy` method requires two mandatory parameters (`existing` and `new`), which means Thor will raise an error about missing required arguments when users try `tmuxinator copy --help` before the `options[:help]` check in the method body can execute.
To fix this, make the parameters optional with default values:
```r... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2953b416..282d84b4 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -23,6 +23,7 @@ def self.exit_on_failure?
delete: "Deletes given project",
doctor: "Look for problems in your configuration",
edit: "Alias of new",
+ ... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "The `copy` method requires two mandatory parameters (`existing` and `new`), which means Thor will raise an error about missing required arguments when users try `tmuxinator copy --help` before the `options[:help]` check in the method body can execute.\n\nTo fix this, make the parameters optional w... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The test expects the help output to include `"stop [PROJECT]"`, but the command description on line 290 of `lib/tmuxinator/cli.rb` is defined as `desc "stop [PROJECT] [ARGS]"`. Thor's help output will match the desc string, so this test will fail.
The test expectation should be updated to match the actual command desc... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The test expects the help output to include `\"stop [PROJECT]\"`, but the command description on line 290 of `lib/tmuxinator/cli.rb` is defined as `desc \"stop [PROJECT] [ARGS]\"`. Thor's help output will match the desc string, so this test will fail.\n\nThe test expectation should be updated to m... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The expectation `expect(FileUtils).not_to receive(:rm)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `rm` is not called when showing help for a... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The expectation `expect(FileUtils).not_to receive(:rm)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `rm` is not called w... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The expectation `expect(FileUtils).not_to receive(:copy_file)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `copy_file` is not called when show... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The expectation `expect(FileUtils).not_to receive(:copy_file)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `copy_file` i... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The expectation `expect(FileUtils).not_to receive(:copy_file)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `copy_file` is not called when show... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The expectation `expect(FileUtils).not_to receive(:copy_file)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `copy_file` i... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | The expectation `expect(FileUtils).not_to receive(:rm)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `rm` is not called when showing help. | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 3cda7e05..0c52e6be 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -206,6 +206,7 @@
delete
doctor
edit
+ help
implode
local
list
@@ -297... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "The expectation `expect(FileUtils).not_to receive(:rm)` is placed after `cli.start` has already been executed. In RSpec, mock expectations must be set before the action that triggers them. Move this expectation before the `capture_io { cli.start }` line to properly verify that `rm` is not called w... | true | ||
tmuxinator/tmuxinator | 967 | comment_to_fix | Add help to commands list and --help/-h flag support to subcommands | [nitpick] Inconsistent aliases syntax: this uses an array `["-h"]` while other `--help` method_option declarations in this PR (lines 272, 297, 371, 390, 419) use string syntax `"-h"`. For consistency, consider using the same format throughout. While both are valid in Thor, using a consistent style improves maintainabil... | 1cbffad2b2e8d1fb90964b7cb13436d37f95fca4 | 744ebf684ed82e17bfecee637ab4f2838ea2c11c | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2953b416..282d84b4 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -23,6 +23,7 @@ def self.exit_on_failure?
delete: "Deletes given project",
doctor: "Look for problems in your configuration",
edit: "Alias of new",
+ ... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "[nitpick] Inconsistent aliases syntax: this uses an array `[\"-h\"]` while other `--help` method_option declarations in this PR (lines 272, 297, 371, 390, 419) use string syntax `\"-h\"`. For consistency, consider using the same format throughout. While both are valid in Thor, using a consistent s... | true | ||
tmuxinator/tmuxinator | 966 | issue_to_patch | chore(deps): Bump actions/checkout from 4 to 5 | Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update actions checkout... | 94f24b9f3430e110e94d93efc8ba4d9603457724 | 7348240e69d91139dcb8c0d80567dca399e34cd8 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 37d37e32..858fc5e2 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -68,7 +68,7 @@ jobs:
cd ..
tmux -V
- - uses: actions/checkout@v4
+ - uses: actions/checkout@v5
- name: "Test ruby ${{ matri... | [
".github/workflows/ci.yaml"
] | [] | true | ||
tmuxinator/tmuxinator | 961 | issue_to_patch | chore: Update Ruby versions in ci.yaml | ### Metadata
https://www.ruby-lang.org/en/downloads/branches/
### Problem / Motivation
We're testing against Ruby 3.1, which went EOL on 2025-03-26
We're similarly not testing against the latest patch versions of supported Ruby versions.
### Solution
- [x] CHANGELOG entry is added for code changes
... | 6764cf7f7779c9bb4f8ae5a507bf1a3d5d7fd28e | 9d85f5230157128fedd532724527db3c6f074f48 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index d1faa8dd..37d37e32 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,10 +11,9 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- - '3.4.2'
- - '3.3.7'
- - '3.2.7'
- ... | [
".github/workflows/ci.yaml",
"CHANGELOG.md"
] | [] | true | ||
tmuxinator/tmuxinator | 960 | issue_to_patch | chore: Bump tmuxinator to 3.3.5 | ## 3.3.5
## Misc
- Add Ruby 3.4 to the test matrix
- Document new from session feature in the README
- Update required Ruby version to >=2.7
- Update runtime dependencies to up-to-date versions
- Update development dependencies to up-to-date versions
## Fixes
- Properly pass args with equals (=) in their value... | dfcf423a916c07c4b8aa480f5f16ef70c6ee2a10 | 1d7bf186be89da2c773541672d3bdcd84bc43198 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index da50a439..442f5b63 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.5
## Misc
- Add Ruby 3.4 to the test matrix
- Document new from session feature in the README
@@ -8,7 +10,6 @@
## Fixes
- Properly pass args with equals (=) in the... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 959 | issue_to_patch | pinned version of `thor` has an open security advisory
**Describe the bug**
[Here](https://github.com/tmuxinator/tmuxinator/blob/fe37bf00469f7fb6fcdfa0a0ee7db2638877816f/tmuxinator.gemspec#L44) `thor` is added as a dependency to this project, with the version `~> 1.3.0`. This means version `1.4.0` is not allowed. All ... | Update Thor dependency and everything else too :see_no_evil: | ### Metadata
Fixes #958
### Solution
This PR updates the linked Thor dependency, and then some more. Couldn't help myself
- Updated Thor to fix security advisory
- Updated Ruby to 2.7. Not sure if we should update to 3.1, since we're not even running tests for older versions? :thinking:
- Updated the runt... | fe37bf00469f7fb6fcdfa0a0ee7db2638877816f | 6709854983418610504ccd0d8290cd9e02c84afc | diff --git a/.rubocop.yml b/.rubocop.yml
index c46bbe78..05c9cc4c 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -4,9 +4,7 @@ AllCops:
- "db/schema.rb"
DisplayCopNames: true
StyleGuideCopsOnly: false
- TargetRubyVersion: 2.6
-Rails:
- Enabled: false
+ TargetRubyVersion: 2.7
Layout/AccessModifierIndentatio... | [
".rubocop.yml",
"CHANGELOG.md",
"lib/tmuxinator.rb",
"lib/tmuxinator/cli.rb",
"lib/tmuxinator/config.rb",
"lib/tmuxinator/project.rb",
"lib/tmuxinator/window.rb",
"spec/lib/tmuxinator/cli_spec.rb",
"spec/lib/tmuxinator/config_spec.rb",
"spec/lib/tmuxinator/wemux_support_spec.rb",
"spec/spec_help... | [
{
"comment": "The required_rubygems_version should specify a RubyGems version, not a Ruby version. This should be something like \">= 2.0\" or similar RubyGems version number.\n```suggestion\n s.required_rubygems_version = Gem::Requirement.new(\">= 2.7\")\n```",
"path": "tmuxinator.gemspec",
"hunk": "@... | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 7d272a1b..3cda7e05 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -924,7 +924,7 @@
end
it "should generate a project file" do
- new_path = described_class.new.find_project_f... | true |
tmuxinator/tmuxinator | 959 | comment_to_fix | Update Thor dependency and everything else too :see_no_evil: | The required_rubygems_version should specify a RubyGems version, not a Ruby version. This should be something like ">= 2.0" or similar RubyGems version number.
```suggestion
s.required_rubygems_version = Gem::Requirement.new(">= 2.7")
``` | fe37bf00469f7fb6fcdfa0a0ee7db2638877816f | 6709854983418610504ccd0d8290cd9e02c84afc | diff --git a/tmuxinator.gemspec b/tmuxinator.gemspec
index 74e30a63..36d232e2 100644
--- a/tmuxinator.gemspec
+++ b/tmuxinator.gemspec
@@ -37,22 +37,18 @@ Gem::Specification.new do |s|
__________________________________________________________
}
- s.required_rubygems_version = ">= 1.8.23"
- s.required_ruby_... | [
"tmuxinator.gemspec"
] | [
{
"comment": "The required_rubygems_version should specify a RubyGems version, not a Ruby version. This should be something like \">= 2.0\" or similar RubyGems version number.\n```suggestion\n s.required_rubygems_version = Gem::Requirement.new(\">= 2.7\")\n```",
"path": "tmuxinator.gemspec",
"hunk": "@... | true | ||
tmuxinator/tmuxinator | 959 | comment_to_fix | Update Thor dependency and everything else too :see_no_evil: | Duplicate "Features" sections with identical content "Add support for tmuxinator stop-all" appear on lines 12, 15, and 18. These should be consolidated into a single entry.
```suggestion
``` | fe37bf00469f7fb6fcdfa0a0ee7db2638877816f | 6709854983418610504ccd0d8290cd9e02c84afc | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0858503e..da50a439 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## Misc
- Add Ruby 3.4 to the test matrix
- Document new from session feature in the README
+- Update required Ruby version to >=2.7
+- Update runtime dependencies to up-to-date versions
+-... | [
"CHANGELOG.md"
] | [
{
"comment": "Duplicate \"Features\" sections with identical content \"Add support for tmuxinator stop-all\" appear on lines 12, 15, and 18. These should be consolidated into a single entry.\n```suggestion\n\n```",
"path": "CHANGELOG.md",
"hunk": "@@ -2,13 +2,22 @@\n ## Misc\n - Add Ruby 3.4 to the test... | true | ||
tmuxinator/tmuxinator | 959 | comment_to_fix | Update Thor dependency and everything else too :see_no_evil: | This seems like it was added multiple times on accident, maybe just a bad merge resolution? | fe37bf00469f7fb6fcdfa0a0ee7db2638877816f | 6709854983418610504ccd0d8290cd9e02c84afc | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0858503e..da50a439 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
## Misc
- Add Ruby 3.4 to the test matrix
- Document new from session feature in the README
+- Update required Ruby version to >=2.7
+- Update runtime dependencies to up-to-date versions
+-... | [
"CHANGELOG.md"
] | [
{
"comment": "This seems like it was added multiple times on accident, maybe just a bad merge resolution?",
"path": "CHANGELOG.md",
"hunk": "@@ -2,13 +2,22 @@\n ## Misc\n - Add Ruby 3.4 to the test matrix\n - Document new from session feature in the README\n+- Update required Ruby version to >=2.7 \n+- ... | true | ||
tmuxinator/tmuxinator | 959 | comment_to_fix | Update Thor dependency and everything else too :see_no_evil: | nit: These rubocop updates could be included in a .git-blame-ignore-revs file to exclude them in blame/annotate reports. | fe37bf00469f7fb6fcdfa0a0ee7db2638877816f | 6709854983418610504ccd0d8290cd9e02c84afc | diff --git a/spec/lib/tmuxinator/config_spec.rb b/spec/lib/tmuxinator/config_spec.rb
index 28a45c7c..b3f362fc 100644
--- a/spec/lib/tmuxinator/config_spec.rb
+++ b/spec/lib/tmuxinator/config_spec.rb
@@ -55,7 +55,8 @@
Dir.mktmpdir do |dir|
config_parent = "#{dir}/non_existent_parent/s"
- a... | [
"spec/lib/tmuxinator/config_spec.rb"
] | [
{
"comment": "nit: These rubocop updates could be included in a .git-blame-ignore-revs file to exclude them in blame/annotate reports.",
"path": "spec/lib/tmuxinator/config_spec.rb",
"hunk": "@@ -181,7 +181,8 @@\n \n before do\n expect(Tmuxinator::Doctor).to receive(:installed?).and_return(tru... | true | ||
tmuxinator/tmuxinator | 956 | issue_to_patch | Fish completion is broken
**Describe the bug**
tmuxinator/completion/tmuxinator.fish doesn't correctly set __fish_tmuxinator_program_cmd in `set __fish_tmuxinator_program_cmd (commandline -o)[1]`. In my shell, tested in empty fish environment as well, this variable is empty after I try reproducing this problem.
``... | fix: Fix `fish-shell` completions (857) | Refactors `fish-shell` completion so that it works as expected.
### Metadata
Fixes https://github.com/tmuxinator/tmuxinator/issues/857
### Problem / Motivation
Fixing `fish-shell` completions. In my case, I was noticing that completions for `tmuxinator` did not work at all, either when typing `tmuxinator<TA... | 9b36b689c2810b6657afea8fed794666ffbf73e0 | 3dc4de4015b4725db16dd57c213e23f6223fefcd | diff --git a/CHANGELOG.md b/CHANGELOG.md
index e7d50528..0858503e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
- Document new from session feature in the README
## Fixes
- Properly pass args with equals (=) in their values
+- Fix `fish-shell` completion
### Features
- Add support for tmuxinator s... | [
"CHANGELOG.md",
"completion/tmuxinator.fish"
] | [] | true | |
tmuxinator/tmuxinator | 945 | issue_to_patch | feat: add stop_all command | ### Metadata
This adresses #932 by adding a `stop_all` command.
### Problem / Motivation
As outlined in the linked issue, the user wants the ability to stop all Tmux projects at once. As that's also something I can use, so I thought I'd give it a shot.
### Solution
This adds a new command `stop_all`, wi... | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/.gitignore b/.gitignore
index 2153bf58..3a3414b6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -18,3 +18,7 @@ vendor/
tags
.env*
.env
+
+# ASDF VM
+.tool-versions
+
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 873d3dd2..e7d50528 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,9 @@
## Fixes
- P... | [
".gitignore",
"CHANGELOG.md",
"README.md",
"lib/tmuxinator/cli.rb",
"lib/tmuxinator/config.rb",
"lib/tmuxinator/project.rb",
"lib/tmuxinator/util.rb",
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "I sort of wanted to sort this last time I touched it - thanks for taking the initiative! 🙌 ",
"path": "lib/tmuxinator/cli.rb",
"hunk": "@@ -15,25 +15,26 @@ def self.exit_on_failure?\n COMMANDS = {\n commands: \"Lists commands available in tmuxinator\",\n completions: \"Use... | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 2bdabdde..7d272a1b 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -198,21 +198,24 @@
it "lists the commands" do
out, _err = capture_io { cli.start }
- expected = %w(commands
- ... | true | |
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | I sort of wanted to sort this last time I touched it - thanks for taking the initiative! 🙌 | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2ac7dfe8..8ce7730e 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -15,25 +15,26 @@ def self.exit_on_failure?
COMMANDS = {
commands: "Lists commands available in tmuxinator",
completions: "Used for shell completion",
-... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "I sort of wanted to sort this last time I touched it - thanks for taking the initiative! 🙌 ",
"path": "lib/tmuxinator/cli.rb",
"hunk": "@@ -15,25 +15,26 @@ def self.exit_on_failure?\n COMMANDS = {\n commands: \"Lists commands available in tmuxinator\",\n completions: \"Use... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | It almost feels like this could be an option of `mux stop [project]` like `mux stop --all`.
It has some parity with `mux list` (running projects) vs. `mux list --all`, but it sort of means something different in this context. In theory, it's stopping all active and inactive (no-op) projects, though, so one could arg... | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2ac7dfe8..8ce7730e 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -15,25 +15,26 @@ def self.exit_on_failure?
COMMANDS = {
commands: "Lists commands available in tmuxinator",
completions: "Used for shell completion",
-... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "It almost feels like this could be an option of `mux stop [project]` like `mux stop --all`.\r\n\r\nIt has some parity with `mux list` (running projects) vs. `mux list --all`, but it sort of means something different in this context. In theory, it's stopping all active and inactive (no-op) projects... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | We could support a default here, like `(y/N)` (no being the default, which seems to be the case if you just press enter as written).
Additionally, we may want to implement some kind of `-y/--yes` or `-f/--force` option to skip the interactive prompt so it's useful for scripting. | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2ac7dfe8..8ce7730e 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -15,25 +15,26 @@ def self.exit_on_failure?
COMMANDS = {
commands: "Lists commands available in tmuxinator",
completions: "Used for shell completion",
-... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "We could support a default here, like `(y/N)` (no being the default, which seems to be the case if you just press enter as written).\r\n\r\nAdditionally, we may want to implement some kind of `-y/--yes` or `-f/--force` option to skip the interactive prompt so it's useful for scripting.",
"path... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | Love the additional rdoc! | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/config.rb b/lib/tmuxinator/config.rb
index 08c6df5b..02be5275 100644
--- a/lib/tmuxinator/config.rb
+++ b/lib/tmuxinator/config.rb
@@ -131,7 +131,7 @@ def active_sessions
`tmux list-sessions -F "#S"`.split("\n")
end
- # Sorted list of all project .yml file basenames, i... | [
"lib/tmuxinator/config.rb"
] | [
{
"comment": "Love the additional rdoc!",
"path": "lib/tmuxinator/config.rb",
"hunk": "@@ -147,6 +147,16 @@ def configs(active: nil)\n configs\n end\n \n+ # List the names of all config files relative to the config directory.\n+ #\n+ # If sub-folders are used, those are part... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | This test seems to be testing `mux stop foo` vs. `stop_all` unless I'm missing something. | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 2bdabdde..7d272a1b 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -198,21 +198,24 @@
it "lists the commands" do
out, _err = capture_io { cli.start }
- expected = %w(commands
- ... | [
"spec/lib/tmuxinator/cli_spec.rb"
] | [
{
"comment": "This test seems to be testing `mux stop foo` vs. `stop_all` unless I'm missing something.",
"path": "spec/lib/tmuxinator/cli_spec.rb",
"hunk": "@@ -379,6 +382,22 @@\n end\n end\n \n+ describe \"#stop_all\" do\n+ before do\n+ allow(Tmuxinator::Config).to receive_messages(vali... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | Hi @hschne, I'm having trouble successfully running `stop-all`:
```sh
$ bundle exec tmuxinator stop-all
Stop all active projects:
dots
notes
tmuxinator
Are you sure? (n/y) y
bundler: failed to load command: tmuxinator (/Users/akofink/.rbenv/versions/3.3.7/lib/ruby/gems/3.3.0/bin/tmuxinator)
/Users/akofin... | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/project.rb b/lib/tmuxinator/project.rb
index 123592ae..2228439a 100644
--- a/lib/tmuxinator/project.rb
+++ b/lib/tmuxinator/project.rb
@@ -42,31 +42,46 @@ class Project
attr_reader :custom_name
attr_reader :no_pre_window
- def self.load(path, options = {})
- yaml = begin
... | [
"lib/tmuxinator/project.rb"
] | [
{
"comment": "Hi @hschne, I'm having trouble successfully running `stop-all`:\r\n\r\n```sh\r\n$ bundle exec tmuxinator stop-all\r\nStop all active projects:\r\n\r\ndots\r\nnotes\r\ntmuxinator\r\n\r\nAre you sure? (n/y) y\r\nbundler: failed to load command: tmuxinator (/Users/akofink/.rbenv/versions/3.3.7/lib/ru... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | This looks like a bad rebase with master - we want to keep this version with the `split("=", 2)`, from https://github.com/tmuxinator/tmuxinator/pull/951
There is also a missing `end` for `parse_settings` so this file is not syntactically correct. If you try to run it, it fails with a syntax error:
```sh
Unmatche... | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/project.rb b/lib/tmuxinator/project.rb
index 123592ae..2228439a 100644
--- a/lib/tmuxinator/project.rb
+++ b/lib/tmuxinator/project.rb
@@ -42,31 +42,46 @@ class Project
attr_reader :custom_name
attr_reader :no_pre_window
- def self.load(path, options = {})
- yaml = begin
... | [
"lib/tmuxinator/project.rb"
] | [
{
"comment": "This looks like a bad rebase with master - we want to keep this version with the `split(\"=\", 2)`, from https://github.com/tmuxinator/tmuxinator/pull/951\r\n\r\nThere is also a missing `end` for `parse_settings` so this file is not syntactically correct. If you try to run it, it fails with a synt... | true | ||
tmuxinator/tmuxinator | 945 | comment_to_fix | feat: add stop_all command | This alias doesn't seem to work correctly. I believe short CLI args (with a single `-`) may only allow for a single character. This is because you can stack them together behind a single hyphen to represent multiple options, i.e.
```sh
ls -l -a
# is equivalent to
ls -la
```
Here's what I get with `-nc`:
... | b7bef6fdb80e80a21f689093e3f0211e19e2a1ab | eef7cd0bf320a186a586ddab635c900e3ed5c27e | diff --git a/lib/tmuxinator/cli.rb b/lib/tmuxinator/cli.rb
index 2ac7dfe8..8ce7730e 100644
--- a/lib/tmuxinator/cli.rb
+++ b/lib/tmuxinator/cli.rb
@@ -15,25 +15,26 @@ def self.exit_on_failure?
COMMANDS = {
commands: "Lists commands available in tmuxinator",
completions: "Used for shell completion",
-... | [
"lib/tmuxinator/cli.rb"
] | [
{
"comment": "This alias doesn't seem to work correctly. I believe short CLI args (with a single `-`) may only allow for a single character. This is because you can stack them together behind a single hyphen to represent multiple options, i.e.\r\n\r\n```sh\r\nls -l -a\r\n\r\n# is equivalent to\r\n\r\nls -la\r\n... | true | ||
tmuxinator/tmuxinator | 881 | issue_to_patch | FAQ: commands may be lost or corrupted when TTY typeahead buffer is full | At my work, we recently experienced issues with our tmuxinator configuration where characters seemed to be lost or commands corrupted. I investigated this and found it might be due to an issue with the TTY typeahead buffer filling up and dropping characters. It was resolved by splitting long commands out into a separat... | 423ce4021bbe014fa9617a802b319dc495bcff24 | d6f7b5cc212d1408eacfd65da4a823e0a42b3601 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 885d36d0..c41a8ab6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## Unreleased
+- add a FAQ entry about how long commands may be lost/corrupted by TTY typeahead
+
## 3.0.5
### tmux
- add tmux 3.3a to (currently defunct) Travis test matrix; add 3.3a to su... | [
"CHANGELOG.md",
"README.md"
] | [] | true | ||
tmuxinator/tmuxinator | 951 | issue_to_patch | Incorrectly Character Parsing on ERB Parameter
**ERB Incorrectly Parses the '=' character**
Passing a parameter into a tmuxinator script with a '=' strips the rest of the string in that parameter away.
For an example, if using the command `mux start -p ./template.yml value='set value = this`, accessing the `value`... | fix: Properly parse args with equals (=) in their value | ### Metadata
Fixes #879
### Problem / Motivation
Arguments passed to `tmuxinator start [project] [args]` with an equals sign (=) drops everything after the equals sign.
Example:
```sh
tmuxinator start 879 value='set value = this'
```
### Solution
- [X] CHANGELOG entry is added for code changes
... | fbcfd5a36d7884a8b9c9e389de4be99fd39a465a | b338409b400f1fe407483dc2112fa8948f4413f6 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cd804b84..873d3dd2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,8 @@
## Misc
- Add Ruby 3.4 to the test matrix
- Document new from session feature in the README
+## Fixes
+- Properly pass args with equals (=) in their values
## 3.3.4
### Features
diff --g... | [
"CHANGELOG.md",
"lib/tmuxinator/project.rb",
"spec/lib/tmuxinator/project_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/project_spec.rb b/spec/lib/tmuxinator/project_spec.rb
index d637e56e..215819fa 100644
--- a/spec/lib/tmuxinator/project_spec.rb
+++ b/spec/lib/tmuxinator/project_spec.rb
@@ -665,7 +665,7 @@
end
describe "::parse_settings" do
- let(:args) { ["one", "two=three"] }
+ let(:arg... | true |
tmuxinator/tmuxinator | 950 | issue_to_patch | able to save a current session to a tmuxinator configuration file?
**Describe the solution you'd like**
I think you know what I mean by the title | doc: Document `new [project] [session]` functionality | ### Metadata
Fixes #940
### Problem / Motivation
This command is currently undocumented:
```sh
tmuxinator new [project] [session]
```
### Solution
- [X] CHANGELOG entry is added for code changes
Add documentation in the readme about how this works and what it supports
### Testing
N/A for a ... | 05626ebc96ed2aa9ab5c51f27e4bf6157f719f62 | 012689e58c8c84242eb7454f419aa86a599fdd0a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index bbfee13c..cd804b84 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
## Unreleased
## Misc
- Add Ruby 3.4 to the test matrix
+- Document new from session feature in the README
## 3.3.4
### Features
diff --git a/README.md b/README.md
index 095c0376..8d265a... | [
"CHANGELOG.md",
"README.md"
] | [] | true | |
tmuxinator/tmuxinator | 949 | issue_to_patch | Running tests fails on Ruby 3.4
**Describe the bug**
Running tests with Ruby 3.4 is not possible and results in failures related to SimpleCov. This is a development issue.
```
An error occurred while loading ./spec/lib/tmuxinator/config_spec.rb.
Failure/Error:
SimpleCov.start do
add_filter "vendor/cache"
end
... | chore: Test against Ruby 3.4 in CI | ### Metadata
Fixes #944
https://www.ruby-lang.org/en/downloads/branches/
### Problem / Motivation
Ruby 3.4 released on 2024-12-25
We're currently not testing against 3.4
### Solution
- [X] CHANGELOG entry is added for code changes
Add Ruby 3.4.2 to our CI pipelines
Update patch versions of o... | ce6affd9868981af9cdc94b45841599505e00b08 | 46dcf302175ced661b296f0bc2c16679f5847926 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 71ca22fd..d1faa8dd 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,8 +11,9 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- - '3.3.5'
- - '3.2.5'
+ - '3.4.2'
+ ... | [
".github/workflows/ci.yaml",
"CHANGELOG.md",
"tmuxinator.gemspec"
] | [] | true | |
tmuxinator/tmuxinator | 947 | issue_to_patch | chore: Bump tmuxinator to v3.3.4 | ## 3.3.4
### Features
- Add support for tmuxinator start --append
- Add support for tmuxinator start --no-pre-window
### Fixes
- Properly pass additional arguments to the start command when no command is given
### Misc
- Fix code coverage reporting via coveralls, now with GitHub Actions | 60c353c182ca4b45e8d822306b5b0c355fa12883 | 965415c8494675c61dc93832f809a9994085218b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index b6861c5e..9f4438fd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.4
### Features
- Add support for tmuxinator start --append
- Add support for tmuxinator start --no-pre-window
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 946 | issue_to_patch | chore: Fix coveralls to run from GH actions | ### Metadata
Related discussion in https://github.com/tmuxinator/tmuxinator/issues/944
https://coveralls.io/github/tmuxinator/tmuxinator
[Example parallel CI setup from the coveralls GitHub Action docs](https://github.com/coverallsapp/github-action?tab=readme-ov-file#complete-parallel-job-example)
### Probl... | 7f35ac1371cf73cc4dbf0d7d8acba811cc04f7cc | 56498456502170c5673fe8babc54bb9e4b79199f | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 8a37be77..71ca22fd 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -73,3 +73,18 @@ jobs:
run: |
bundle install
bundle exec rake test
+ - name: Coveralls
+ uses: coverallsapp/github-action@... | [
".github/workflows/ci.yaml",
".gitignore",
"CHANGELOG.md",
"spec/spec_helper.rb",
"tmuxinator.gemspec"
] | [] | diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index e5c97f66..65e5a92b 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -1,16 +1,21 @@
# frozen_string_literal: true
-require "coveralls"
require "pry"
require "simplecov"
require "xdg"
-formatters = [
- SimpleCov::Formatter::HTMLFormatter,
... | true | |
tmuxinator/tmuxinator | 942 | issue_to_patch | feat: Add --no-pre-window option to start command | ### Metadata
https://github.com/tmuxinator/tmuxinator/pull/908#issuecomment-2127709831
### Problem / Motivation
Sometimes, you don't want to have the `pre_window` command run when starting a project.
This may especially be true if you are using the `--append` option to add windows to an existing session.
... | a745a629b982bf3e55f13638391ce578e995604e | 9bf906ec99c4d3733fdee16352c9d59b83e4e05a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4a8821d3..0a9db27b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
## Unreleased
### Features
- Add support for tmuxinator start --append
+- Add support for tmuxinator start --no-pre-window
### Fixes
- Properly pass additional arguments to the start comma... | [
"CHANGELOG.md",
"lib/tmuxinator/cli.rb",
"lib/tmuxinator/project.rb",
"spec/lib/tmuxinator/project_spec.rb"
] | [
{
"comment": "These changes are mostly to make codeclimate happy. The relevant addition is\r\n\r\n```rb\r\nno_pre_window: project_options[:no_pre_window],\r\n```",
"path": "lib/tmuxinator/cli.rb",
"hunk": "@@ -176,29 +176,22 @@ def generate_project_file(name, path)\n end\n \n def create_proj... | diff --git a/spec/lib/tmuxinator/project_spec.rb b/spec/lib/tmuxinator/project_spec.rb
index 8ef506cb..d637e56e 100644
--- a/spec/lib/tmuxinator/project_spec.rb
+++ b/spec/lib/tmuxinator/project_spec.rb
@@ -281,6 +281,16 @@
end
end
end
+
+ context "no_pre_window option is true" do
+ before ... | true | |
tmuxinator/tmuxinator | 943 | issue_to_patch | fix: Properly pass args to start when no command is given | ### Metadata
N/A
### Problem / Motivation
`mux start [project] [args]` should behave the same as `mux [project] [args]`.
Currently, the args are not passed through to the start command as Thor `options` - they come through as args instead.
I noticed this when recently implementing the `--append` and `--n... | 5ef509d783564afcc2c0ed49e84c22ba126f11ce | 4fb022e691ac5b1bba1cb741f89f767f3b9e0b49 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a5eae494..4a8821d3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,8 @@
## Unreleased
### Features
- Add support for tmuxinator start --append
+### Fixes
+- Properly pass additional arguments to the start command when no command is given
## 3.3.3
### Feature... | [
"CHANGELOG.md",
"lib/tmuxinator/cli.rb",
"spec/lib/tmuxinator/cli_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 494b1ca2..2bdabdde 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -99,9 +99,7 @@
end
it "should call #start" do
- instance = instance_double(cli)
- ex... | true | |
tmuxinator/tmuxinator | 908 | issue_to_patch | Option to create window in the same tmux session instead of creating a new session
Most of the time for my workflow, it's enough just to create a new window with multiple panes in it instead of creating new sessions. | feat: Add support for tmuxinator append | ## Metadata
Original PR from @flovilmart: https://github.com/tmuxinator/tmuxinator/pull/652
## Problem
Closes: https://github.com/tmuxinator/tmuxinator/issues/265
It often makes sense to want to add a tmuxinator project to an existing tmux session vs. creating a new session.
## Solution
Add a new opti... | 11de7f6102afb7f1713f47d751f4d8f30fd6a594 | 8ffccfc4e1de989e9272e66464215f0d911e7025 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8e33dada..a5eae494 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+### Features
+- Add support for tmuxinator start --append
## 3.3.3
### Features
diff --git a/README.md b/README.md
index 121be4f8..095c0376 100644
--- a/README.md
+++ b/READ... | [
"CHANGELOG.md",
"README.md",
"lib/tmuxinator/assets/template.erb",
"lib/tmuxinator/cli.rb",
"lib/tmuxinator/project.rb",
"spec/factories/projects.rb",
"spec/lib/tmuxinator/cli_spec.rb",
"spec/lib/tmuxinator/project_spec.rb"
] | [
{
"comment": "This needed updating for https://github.com/ruby/psych/issues/533",
"path": "lib/tmuxinator/config.rb",
"hunk": "@@ -63,6 +67,12 @@ def default\n \"#{directory}/default.yml\"\n end\n \n+ def options\n+ YAML.safe_load(File.read(options_file), aliases: true) || {}",... | diff --git a/spec/factories/projects.rb b/spec/factories/projects.rb
index 460da048..87b20535 100644
--- a/spec/factories/projects.rb
+++ b/spec/factories/projects.rb
@@ -115,4 +115,12 @@ def yaml_load(file)
initialize_with { Tmuxinator::Project.load(file) }
end
+
+ factory :project_with_append, class: Tmuxi... | true |
tmuxinator/tmuxinator | 936 | issue_to_patch | chore: Bump tmuxinator to v3.3.3 | ## 3.3.3
### Features
- Add active (-a) option to tmuxinator list | 8895f12657f976e9a86bf867ba1a6d11856cb394 | 2e5c0f45a6e538e86f2e6b031fffe8b802bca31a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71dbee72..8e33dada 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,12 +1,14 @@
## Unreleased
+## 3.3.3
+### Features
+- Add active (-a) option to tmuxinator list
+
## 3.3.2
### Misc
- Bump patch versions of Ruby 3.1, 3.2, 3.3 in the test matrix
### tmux
- Add tm... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 934 | issue_to_patch | Ability to list all active `tmuxinator` projects
**Is your feature request related to a problem? Please describe.**
This is somewhat related to https://github.com/tmuxinator/tmuxinator/issues/932, but sometimes I want to see what `tmuxinator` projects I have running, as opposed to all `tmux` sessions (that may not ha... | feat: Add -a option to list active projects | ### Metadata
Fixes #933
### Problem / Motivation
See https://github.com/tmuxinator/tmuxinator/issues/933
Users want to be able to list projects and filter them by those that are already started or not.
### Solution
- [x] CHANGELOG entry is added for code changes
Introduce an `--active`/`-a` option ... | ae24ae74622140cfc509be9edafff2e2aca78966 | bf4f118698154dfdecdbe9920fa6b1d4003e8cf9 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f1f8c2ae..bcf50d46 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,8 @@
- Bump patch versions of Ruby 3.1, 3.2, 3.3 in the test matrix
### tmux
- Add tmux 3.5a to test matrix
+### Features
+- Add active (-a) option to tmuxinator list
## 3.3.1
### Misc
diff -... | [
"CHANGELOG.md",
"lib/tmuxinator/cli.rb",
"lib/tmuxinator/config.rb",
"spec/lib/tmuxinator/cli_spec.rb",
"spec/lib/tmuxinator/config_spec.rb"
] | [] | diff --git a/spec/lib/tmuxinator/cli_spec.rb b/spec/lib/tmuxinator/cli_spec.rb
index 6c27a3cf..8426aba8 100644
--- a/spec/lib/tmuxinator/cli_spec.rb
+++ b/spec/lib/tmuxinator/cli_spec.rb
@@ -845,6 +845,14 @@
end
end
+ context "set --active flag " do
+ ARGV.replace(["list", "--active"])
+
+ it... | true |
tmuxinator/tmuxinator | 935 | issue_to_patch | chore: Bump tmuxinator to v3.3.2 | ## 3.3.2
### Misc
- Bump patch versions of Ruby 3.1, 3.2, 3.3 in the test matrix
### tmux
- Add tmux 3.5a to test matrix | ae24ae74622140cfc509be9edafff2e2aca78966 | 8c9d16eea451af48407dd21f3c5aeca2a1dddfc9 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f1f8c2ae..9cec12c1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.2
### Misc
- Bump patch versions of Ruby 3.1, 3.2, 3.3 in the test matrix
### tmux
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator/version.rb
index d654bf08.... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 930 | issue_to_patch | chore: Add support for tmux 3.5a | ### Metadata
https://github.com/tmux/tmux/releases/tag/3.5a
### Problem / Motivation
Tmux released a bug fix version, 3.5a
### Solution
- [x] CHANGELOG entry is added for code changes
Add this new version to the list of supported tmux versions
Update the test matrix with tmux 3.5a
Bump patch ver... | 0e3d598eaa6e7c3c2dd2df540eede4181970d040 | 39c76391b30b056e4636915aa647d9a7577e0523 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index bd5675de..8a37be77 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,10 +11,11 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- - '3.3.3'
- - '3.2.4'
+ - '3.3.5'
+ ... | [
".github/workflows/ci.yaml",
"CHANGELOG.md",
"lib/tmuxinator/tmux_version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 929 | issue_to_patch | chore: Bump tmuxinator to v3.3.1 | ## 3.3.1
### Misc
- Update Ruby 3.1, 3.2, 3.3 in the test matrix; rm ruby 3.0
### tmux
- Add tmux 3.5 to test matrix
- Add tmux 3.5 to supported tmux versions list
### Fixes
- Don't unset TMUX env variable for new-session | a3d083a3052d308ffa4e85c75f06565877c3710a | 703d8ffa1927943273caecae6392bf98f07a3b8b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8c891e6d..3494c39a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.1
### Misc
- Update Ruby 3.1, 3.2, 3.3 in the test matrix; rm ruby 3.0
### tmux
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator/version.rb
index 25f0ff95..d6... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 925 | issue_to_patch | Unable to start sessions due to "TMUX= tmux new-session ..."
**Describe the bug**
Given a config such as
```
name: sample
root: ~/
windows:
- editor:
layout: main-horizontal
panes:
- nvim
```
Trying to start it produces the error
```
$ tmuxinator start sample
can't find sessi... | fix: Don't unset TMUX variable for new-session | ### Metadata
fixes #924
Links to relevant docs, related PRs or issues, etc.
### Problem / Motivation
The [TMUX env variable contains the server socket path](https://github.com/tmux/tmux/blob/master/environ.c#L271). If the current server isn't using the default socket path, it errors finding the session:
... | 2c0093f9f10a85f7796f5bc0eb50ac137b09fe66 | fdfc2aed839baa080729d3e0bd69e2f37a71d98f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6ad1928b..8c891e6d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,8 @@
### tmux
- Add tmux 3.5 to test matrix
- Add tmux 3.5 to supported tmux versions list
+### Fixes
+- Don't unset TMUX env variable for new-session
## 3.3.0
### Enhancements
diff --git a/l... | [
"CHANGELOG.md",
"lib/tmuxinator/assets/template.erb"
] | [] | true | |
tmuxinator/tmuxinator | 927 | issue_to_patch | Add tmux 3.5 to the list of supported tmux versions | ### Metadata
N/A
### Problem / Motivation
`tmux` was recently updated to version `3.5`, but tmuxinator shows it as unsupported.
### Solution
I'm updating `tmux_versions.rb` file to add the version.
### Testing
Didn't test; let me know if there are tests to be run/added/updated.
I have `tmux 3.5`... | 5ae0f18fbd924849c1d0a40e5ef85e46d1f78d9d | 0666361883e8b0784c796841b8e18ef939cf2840 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 0115130a..bd5675de 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -15,6 +15,7 @@ jobs:
- '3.2.4'
- '3.1.6'
tmux_version:
+ - '3.5'
- '3.4'
- '3.3a'
... | [
".github/workflows/ci.yaml",
"CHANGELOG.md",
"lib/tmuxinator/tmux_version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 923 | issue_to_patch | Optimize README | ### Metadata
Links to relevant docs, related PRs or issues, etc.
### Problem / Motivation
Describe what the problem is or why the change is needed
### Solution
- [x] CHANGELOG entry is added for code changes
Describe how you are solving the problem
### Testing
Describe any interesting automated ... | b15ddb9569b3c9ee39f9242030ae1d8b5b684521 | d824b3135850741f3e16192983c5fa3f09aa69ac | diff --git a/README.md b/README.md
index b1981f07..121be4f8 100644
--- a/README.md
+++ b/README.md
@@ -44,7 +44,7 @@ echo $EDITOR
For me that produces "vim". If you want to change your default editor simply
put a line in ~/.bashrc that changes it. Mine looks like this:
-```
+```bash
export EDITOR='vim'
```
@@ -... | [
"README.md"
] | [] | true | ||
tmuxinator/tmuxinator | 922 | issue_to_patch | chore: Update CI ruby versions matrix, drop 3.0 | ### Metadata
https://www.ruby-lang.org/en/downloads/branches/
### Problem / Motivation
We want to test against the most recent patch version of each supported Ruby
### Solution
- [x] CHANGELOG entry is added for code changes
Remove 3.0, bump patch versions of 3.1, 3.2, and 3.3
### Testing
In the... | 7df3afadcc0f8bdcb2839a14a327d1b757004dc0 | 7587cd0241211aecba11aa9195d6864080ed5042 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 6ddafeb3..0115130a 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,10 +11,9 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- - '3.3.0'
- - '3.2.3'
- - '3.1.4'
- ... | [
".github/workflows/ci.yaml",
"CHANGELOG.md"
] | [] | true | ||
tmuxinator/tmuxinator | 921 | issue_to_patch | chore: Bump tmuxinator to 3.3.0 | ## 3.3.0
### Enhancements
- Detect relative window root, join with project root
### Fixes
- Session path is project root, not first window root
### Misc
- Unpin activesupport as a development depenedency | a9a85fdfff233001aa66118a746c052e4577dc81 | 0ecd849c0ab46135b7e048b1baa965181b5f0f68 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 60ad4f89..25b8aa4f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+
+## 3.3.0
### Enhancements
- Detect relative window root, join with project root
### Fixes
diff --git a/lib/tmuxinator/version.rb b/lib/tmuxinator/version.rb
index baba9e07.... | [
"CHANGELOG.md",
"lib/tmuxinator/version.rb"
] | [] | true | ||
tmuxinator/tmuxinator | 918 | issue_to_patch | Resolve window/root relative to project root
If you have multiple windows with differing roots (#283), you have to specify an absolute path for all windows. This can lead to your .conf looking like:
```
name: example
root: ~/Work/Projects/Example
windows:
- vagrant:
root: ~/Work/Projects/Example
panes:... | feat: Detect relative window root, join with project root | ## Problem
Relative window root paths are relative to the current working directory (CWD), something that is likely an unintentional side effect of using `File.expand_path(...)`, which is aware of the CWD:
```sh
$ (cd /tmp; ruby -e "puts File.expand_path('')")
/tmp
```
## Solution
Rely on [`File.expand_p... | 1d6a53efacda77b2d42f6b5cf34e0012102c23f8 | 04cb5bf386dc879816340aa0235351b72fb15c8f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9b223216..60ad4f89 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+### Enhancements
+- Detect relative window root, join with project root
### Fixes
- Session path is project root, not first window root
### Misc
diff --git a/lib/tmuxinator/w... | [
"CHANGELOG.md",
"lib/tmuxinator/window.rb",
"spec/lib/tmuxinator/window_spec.rb"
] | [
{
"comment": "I removed this fixture and `window_root` below by making the `yaml` fixture above flexible enough for all the tests by extracting the `root`/`root?` attributes.",
"path": "spec/lib/tmuxinator/window_spec.rb",
"hunk": "@@ -16,27 +18,14 @@\n ],\n \"synchronize\" => synchroniz... | diff --git a/spec/lib/tmuxinator/window_spec.rb b/spec/lib/tmuxinator/window_spec.rb
index fe4ff7ed..e02e74e2 100644
--- a/spec/lib/tmuxinator/window_spec.rb
+++ b/spec/lib/tmuxinator/window_spec.rb
@@ -7,6 +7,8 @@
let(:panes) { ["vim", nil, "top"] }
let(:window_name) { "editor" }
let(:synchronize) { false }
+... | true |
tmuxinator/tmuxinator | 920 | issue_to_patch | chore: unpin activesupport | ### Metadata
It was first pinned here: https://github.com/tmuxinator/tmuxinator/pull/433
### Problem / Motivation
activesupport was pinned to support Ruby < 2.2.3
We no longer support Ruby < 3.0, so this pin is no longer necessary
### Solution
- [X] CHANGELOG entry is added for code changes
Remove ... | b2d21213e22cb7400e9c25d56c4d918331c262b3 | cbb533bbb8f5c415e3b37aefa2357c3f210f0d91 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 204c32a7..9b223216 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,8 @@
## Unreleased
### Fixes
- Session path is project root, not first window root
+### Misc
+- Unpin activesupport as a development depenedency
## 3.2.1
### Enhancements
diff --git a/tmuxina... | [
"CHANGELOG.md",
"tmuxinator.gemspec"
] | [] | true | ||
tmuxinator/tmuxinator | 919 | issue_to_patch | chore: Add a PR template | ### Metadata
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
### Problem / Motivation
Contributors and reviewers both might benefit from a bit more structure when submitting code changes
### Solution
... | 53881e42f2f33fbf1eda32d71191d4a6eaf3dba0 | 9f23eb5a41a373c9bdca0762ab615a31c40298d7 | diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 00000000..7c987c8b
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,23 @@
+### Metadata
+
+Links to relevant docs, related PRs or issues, etc.
+
+### Problem / Motivation
+
+Describe what the probl... | [
".github/pull_request_template.md"
] | [] | true | ||
tmuxinator/tmuxinator | 917 | issue_to_patch | `project.root` property is "overridden" by `windows.first.root`
**Describe the bug**
When using version 3.2.1, if `windows.first.root` is defined, it overrides the `project.root` configuration - starting new windows with `tmux` will start the shell at `windows.first.root` instead of `project.root`.
I believe this ... | fix: Session current path | ## Problems being solved
We [attempted to leverage](https://github.com/tmuxinator/tmuxinator/pull/914) `tmux new-session [-c start-directory]` for tmux >= 1.9 instead of relying on `cd <start-directory>` before the `new-session` command, which by default uses the current working directory.
The tmux manpage for `n... | 0f7e9ffa93c508c45bb0bfd7537a7b5b675e0048 | efd3a5019d0dd43a52f77484d52a1481afb56ec5 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 71b4a70c..204c32a7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
## Unreleased
+### Fixes
+- Session path is project root, not first window root
## 3.2.1
### Enhancements
diff --git a/lib/tmuxinator/assets/template.erb b/lib/tmuxinator/assets/template.e... | [
"CHANGELOG.md",
"lib/tmuxinator/assets/template.erb",
"lib/tmuxinator/window.rb",
"spec/lib/tmuxinator/window_spec.rb"
] | [
{
"comment": "All this was trying to set up the session path without breaking old tmux versions. The logic is removed, and we rely on the `cd` higher up in this file to set the session root path.",
"path": "lib/tmuxinator/assets/template.erb",
"hunk": "@@ -19,18 +19,7 @@ cd <%= root || \".\" %>\n # Ru... | diff --git a/spec/lib/tmuxinator/window_spec.rb b/spec/lib/tmuxinator/window_spec.rb
index 35d63c9f..fe4ff7ed 100644
--- a/spec/lib/tmuxinator/window_spec.rb
+++ b/spec/lib/tmuxinator/window_spec.rb
@@ -354,7 +354,7 @@
let(:window_part) { "new-window" }
let(:name_part) { window.tmux_window_name_option }
- ... | true |
tokio-rs/axum | 3,782 | issue_to_patch | The TypedPath derive macro breaks for segments with a prefix or suffix
- [X] I have looked for existing issues (including closed) about this
## Bug Report
### Version
axum v0.8.8
axum-extra v0.12.5
### Crates
axum-extra
### Description
Currently, the `typed_path` attribute macro does not support paths like `#[t... | Support affixed typed path captures | Fixes #3681
## Motivation
`#[derive(TypedPath)]` currently only recognizes captures when the whole path segment is a capture, such as `{id}`.
That means paths with captures plus a prefix or suffix, such as `/@{username}` or `/files/{name}.json`, cannot be derived even though they are useful route patterns.
... | 42d6fdc80d8933ced5ff4ae858f43a3581106c75 | bf213559287587d91754bf0da2a19879c53c8742 | diff --git a/axum-macros/src/typed_path.rs b/axum-macros/src/typed_path.rs
index 0e89660f39..77ffa8f45a 100644
--- a/axum-macros/src/typed_path.rs
+++ b/axum-macros/src/typed_path.rs
@@ -362,8 +362,7 @@ fn format_str_from_path(segments: &[Segment]) -> String {
Segment::Capture(capture, _) => format!("{{{ca... | [
"axum-macros/src/typed_path.rs",
"axum-macros/tests/typed_path/pass/affixed_captures.rs"
] | [
{
"comment": "This doesn't really make sense, we've found the first `}` so the string cannot contain it.",
"path": "axum-macros/src/typed_path.rs",
"hunk": "@@ -387,23 +386,43 @@ fn parse_path(path: &LitStr) -> syn::Result<Vec<Segment>> {\n return Err(syn::Error::new_spanned(path, \"paths must s... | diff --git a/axum-macros/tests/typed_path/pass/affixed_captures.rs b/axum-macros/tests/typed_path/pass/affixed_captures.rs
new file mode 100644
index 0000000000..a0ac984776
--- /dev/null
+++ b/axum-macros/tests/typed_path/pass/affixed_captures.rs
@@ -0,0 +1,79 @@
+use axum_extra::routing::{RouterExt, TypedPath};
+use s... | true |
tokio-rs/axum | 3,782 | comment_to_fix | Support affixed typed path captures | This doesn't really make sense, we've found the first `}` so the string cannot contain it. | 42d6fdc80d8933ced5ff4ae858f43a3581106c75 | bf213559287587d91754bf0da2a19879c53c8742 | diff --git a/axum-macros/src/typed_path.rs b/axum-macros/src/typed_path.rs
index 0e89660f39..77ffa8f45a 100644
--- a/axum-macros/src/typed_path.rs
+++ b/axum-macros/src/typed_path.rs
@@ -362,8 +362,7 @@ fn format_str_from_path(segments: &[Segment]) -> String {
Segment::Capture(capture, _) => format!("{{{ca... | [
"axum-macros/src/typed_path.rs"
] | [
{
"comment": "This doesn't really make sense, we've found the first `}` so the string cannot contain it.",
"path": "axum-macros/src/typed_path.rs",
"hunk": "@@ -387,23 +386,43 @@ fn parse_path(path: &LitStr) -> syn::Result<Vec<Segment>> {\n return Err(syn::Error::new_spanned(path, \"paths must s... | true | ||
tokio-rs/axum | 3,782 | comment_to_fix | Support affixed typed path captures | Also add tests for paths with e.g. `/{{escpaed_capture}}/{id}` which should match stuff like `/{escaped_capture}/7`. I think the parsing code does not handle this and says that it's invalid capture. | 42d6fdc80d8933ced5ff4ae858f43a3581106c75 | bf213559287587d91754bf0da2a19879c53c8742 | diff --git a/axum-macros/tests/typed_path/pass/affixed_captures.rs b/axum-macros/tests/typed_path/pass/affixed_captures.rs
new file mode 100644
index 0000000000..a0ac984776
--- /dev/null
+++ b/axum-macros/tests/typed_path/pass/affixed_captures.rs
@@ -0,0 +1,79 @@
+use axum_extra::routing::{RouterExt, TypedPath};
+use s... | [
"axum-macros/tests/typed_path/pass/affixed_captures.rs"
] | [
{
"comment": "Also add tests for paths with e.g. `/{{escpaed_capture}}/{id}` which should match stuff like `/{escaped_capture}/7`. I think the parsing code does not handle this and says that it's invalid capture.",
"path": "axum-macros/tests/typed_path/pass/affixed_captures.rs",
"hunk": "@@ -0,0 +1,69 @... | true | ||
tokio-rs/axum | 3,782 | comment_to_fix | Support affixed typed path captures | This makes the `starts_with('{')` redundant. But see the later comment on test. | 42d6fdc80d8933ced5ff4ae858f43a3581106c75 | bf213559287587d91754bf0da2a19879c53c8742 | diff --git a/axum-macros/src/typed_path.rs b/axum-macros/src/typed_path.rs
index 0e89660f39..77ffa8f45a 100644
--- a/axum-macros/src/typed_path.rs
+++ b/axum-macros/src/typed_path.rs
@@ -362,8 +362,7 @@ fn format_str_from_path(segments: &[Segment]) -> String {
Segment::Capture(capture, _) => format!("{{{ca... | [
"axum-macros/src/typed_path.rs"
] | [
{
"comment": "This makes the `starts_with('{')` redundant. But see the later comment on test.",
"path": "axum-macros/src/typed_path.rs",
"hunk": "@@ -387,23 +386,43 @@ fn parse_path(path: &LitStr) -> syn::Result<Vec<Segment>> {\n return Err(syn::Error::new_spanned(path, \"paths must start with a... | true | ||
tokio-rs/axum | 3,786 | issue_to_patch | document ws cancellation & delegation | Documents `recv` as cancel safe as well as the difference between `StreamExt::next`/`recv` and `SinkExt::send`/`send` (there is no difference).
Ref: #3780, #3282 | 4a72e063b916f39e0698a345a99a755deb8f345b | 6b529f996bdbe8ba8322020b996ebc5b5496ae5b | diff --git a/axum/src/extract/ws.rs b/axum/src/extract/ws.rs
index 2eb3b2af8f..d9e7adcdea 100644
--- a/axum/src/extract/ws.rs
+++ b/axum/src/extract/ws.rs
@@ -549,11 +549,22 @@ impl WebSocket {
/// Receive another message.
///
/// Returns `None` if the stream has closed.
+ ///
+ /// This method del... | [
"axum/src/extract/ws.rs"
] | [
{
"comment": "Can we also add here then that not polling to completion means the message is lost?\n\nThis is from tokio's mpsc bounded sender' send, I think we can use almost the same thing if I'm not mistaken? Or is this actually the place where we should refer to the implementation's guarantees?\n\nCancel saf... | true | ||
tokio-rs/axum | 3,786 | comment_to_fix | document ws cancellation & delegation | Can we also add here then that not polling to completion means the message is lost?
This is from tokio's mpsc bounded sender' send, I think we can use almost the same thing if I'm not mistaken? Or is this actually the place where we should refer to the implementation's guarantees?
Cancel safety
If send is used as the... | 4a72e063b916f39e0698a345a99a755deb8f345b | 6b529f996bdbe8ba8322020b996ebc5b5496ae5b | diff --git a/axum/src/extract/ws.rs b/axum/src/extract/ws.rs
index 2eb3b2af8f..d9e7adcdea 100644
--- a/axum/src/extract/ws.rs
+++ b/axum/src/extract/ws.rs
@@ -549,11 +549,22 @@ impl WebSocket {
/// Receive another message.
///
/// Returns `None` if the stream has closed.
+ ///
+ /// This method del... | [
"axum/src/extract/ws.rs"
] | [
{
"comment": "Can we also add here then that not polling to completion means the message is lost?\n\nThis is from tokio's mpsc bounded sender' send, I think we can use almost the same thing if I'm not mistaken? Or is this actually the place where we should refer to the implementation's guarantees?\n\nCancel saf... | true | ||
tokio-rs/axum | 3,784 | issue_to_patch | Exclude tokio/net for WASM builds | ## Motivation
I want to implement a custom `axum::serve::Listener` for my WASM runtime, but `axum::serve` needlessly relies on tokio/net, which doesn't compile on WASM.
## Solution
Made tokio/net an optional feature. | e1f5f5eaa7ed3aca1a9420cc4b2f759b5893a9fc | d053666cc8057544bca67516a8b25a7655b64f42 | diff --git a/axum/Cargo.toml b/axum/Cargo.toml
index ed430d2e99..54e01bf58a 100644
--- a/axum/Cargo.toml
+++ b/axum/Cargo.toml
@@ -72,7 +72,6 @@ query = [
tokio = [
"dep:hyper-util",
"dep:tokio",
- "tokio/net",
"tokio/rt",
"tower/make",
"tokio/macros",
@@ -102,6 +101,12 @@ __private_docs = ... | [
"axum/Cargo.toml",
"axum/src/serve/listener.rs"
] | [
{
"comment": "This whole module is already gated behind `tokio`. Let's use just the target arch here. The same applies on lines 244 and 265. On line 53 we don't need to change anything.",
"path": "axum/src/serve/listener.rs",
"hunk": "@@ -32,8 +30,9 @@ pub trait Listener: Send + 'static {\n fn local... | true | ||
tokio-rs/axum | 3,784 | comment_to_fix | Exclude tokio/net for WASM builds | This whole module is already gated behind `tokio`. Let's use just the target arch here. The same applies on lines 244 and 265. On line 53 we don't need to change anything. | e1f5f5eaa7ed3aca1a9420cc4b2f759b5893a9fc | d053666cc8057544bca67516a8b25a7655b64f42 | diff --git a/axum/src/serve/listener.rs b/axum/src/serve/listener.rs
index 559ffbd62f..bebe8948cc 100644
--- a/axum/src/serve/listener.rs
+++ b/axum/src/serve/listener.rs
@@ -4,13 +4,11 @@ use std::{
pin::Pin,
sync::Arc,
task::{Context, Poll},
- time::Duration,
};
use pin_project_lite::pin_project... | [
"axum/src/serve/listener.rs"
] | [
{
"comment": "This whole module is already gated behind `tokio`. Let's use just the target arch here. The same applies on lines 244 and 265. On line 53 we don't need to change anything.",
"path": "axum/src/serve/listener.rs",
"hunk": "@@ -32,8 +30,9 @@ pub trait Listener: Send + 'static {\n fn local... | true | ||
tokio-rs/axum | 3,788 | issue_to_patch | Error handling example not displaying the correct behavior | ## Motivation
This PR targets #3787 which indicates an issue regarding the rust
documentation of the error-handling example and the actual code's behavior.
The error-handling example added `log_app_errors` as the outer layer and
TraceLayer as the inner one. Because `.layer()` wraps from the inside out,
this ... | ffe32473ccd5e7dfa08aa5fde63d42c980377b53 | 021707f1f6eac19eb6925441c54a4abb1885e239 | diff --git a/examples/error-handling/src/main.rs b/examples/error-handling/src/main.rs
index bbefe374fc..74147ef4c8 100644
--- a/examples/error-handling/src/main.rs
+++ b/examples/error-handling/src/main.rs
@@ -58,6 +58,11 @@ async fn main() {
let app = Router::new()
// A dummy route that accepts some JSO... | [
"examples/error-handling/src/main.rs"
] | [] | true | ||
tokio-rs/axum | 3,790 | issue_to_patch | chore(deps): bump taiki-e/cache-cargo-install-action from 2 to 3 | Bumps [taiki-e/cache-cargo-install-action](https://github.com/taiki-e/cache-cargo-install-action) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/taiki-e/cache-cargo-install-action/releases">taiki-e/cache-cargo-install-action's releases</a>.</em></p>
<blockquote>
... | df2b4a0830c2e7232fe515c81607defa79212259 | 91412f9df56d293a69b2124d2ab4f0781136c6ed | diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index ee5e0d9f58..b70dbf48c9 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -71,7 +71,7 @@ jobs:
with:
toolchain: nightly-2025-10-18
- name: Install cargo-check-external-types
- uses: taiki-e/cach... | [
".github/workflows/CI.yml"
] | [] | true | ||
tokio-rs/axum | 3,789 | issue_to_patch | chore(deps): bump crate-ci/typos from 1.29.4 to 1.47.2 | Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.29.4 to 1.47.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/crate-ci/typos/releases">crate-ci/typos's releases</a>.</em></p>
<blockquote>
<h2>v1.47.2</h2>
<h2>[1.47.2] - 2026-06-04</h2>
<h3>Fixes</h3>
<ul>
<l... | df2b4a0830c2e7232fe515c81607defa79212259 | 5af71949f91240ae21d09a8c53f17cd7ad180a09 | diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index ee5e0d9f58..13ce084fd4 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -216,4 +216,4 @@ jobs:
steps:
- uses: actions/checkout@v6
- name: Check the spelling of the files in our repo
- uses: crate-ci/t... | [
".github/workflows/CI.yml"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.