repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
tokio-rs/tokio | 8,156 | issue_to_patch | net: enable Miri tests for TCP socket | <!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Bug fixes and new features should include tests.
Contributors guide: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md
The contributors guide includes instructions for running rustfmt and b... | c6d58ce7e7bf4a6e7e6efc1ffeb42daa3a627c17 | c5d51ae876dd8a8d6519bf7d11c9169983ba7048 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2efe408ad24..98659301936 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,7 +18,7 @@ env:
rust_stable: stable
rust_nightly: nightly-2025-10-12
# Pin a specific miri version
- rust_miri_nightly: nightly-2026-04-27... | [
".github/workflows/ci.yml",
"tokio-util/tests/udp.rs",
"tokio/src/io/util/mod.rs",
"tokio/src/net/tcp/listener.rs",
"tokio/src/net/tcp/socket.rs",
"tokio/src/net/tcp/stream.rs",
"tokio/src/net/udp.rs",
"tokio/src/net/unix/datagram/socket.rs",
"tokio/src/net/unix/stream.rs",
"tokio/tests/io_copy_bi... | [
{
"comment": "We lowered the `ITER` from 1000 to 32, is is because the Miri tests are slow?",
"path": "tokio/tests/tcp_echo.rs",
"hunk": "@@ -17,25 +15,25 @@ use tokio_test::assert_ok;\n \n #[tokio::test]\n async fn echo_server() {\n- const ITER: usize = 1024;\n+ const BYTES: &[u8] = b\"foo bar ba... | diff --git a/tokio-util/tests/udp.rs b/tokio-util/tests/udp.rs
index 12c852fa75f..62d6d0165b1 100644
--- a/tokio-util/tests/udp.rs
+++ b/tokio-util/tests/udp.rs
@@ -1,6 +1,6 @@
#![warn(rust_2018_idioms)]
#![cfg(not(target_os = "wasi"))] // Wasi doesn't support UDP
-#![cfg(not(miri))] // No `socket` in Miri.
+#![cfg(n... | true | |
tokio-rs/tokio | 8,156 | comment_to_fix | net: enable Miri tests for TCP socket | We lowered the `ITER` from 1000 to 32, is is because the Miri tests are slow? | c6d58ce7e7bf4a6e7e6efc1ffeb42daa3a627c17 | c5d51ae876dd8a8d6519bf7d11c9169983ba7048 | diff --git a/tokio/tests/tcp_echo.rs b/tokio/tests/tcp_echo.rs
index 7592538504a..ad35f89f7cd 100644
--- a/tokio/tests/tcp_echo.rs
+++ b/tokio/tests/tcp_echo.rs
@@ -1,13 +1,11 @@
#![warn(rust_2018_idioms)]
// WASIp1 doesn't support bind
-// No `socket` on miri.
#![cfg(all(
feature = "net",
feature = "macro... | [
"tokio/tests/tcp_echo.rs"
] | [
{
"comment": "We lowered the `ITER` from 1000 to 32, is is because the Miri tests are slow?",
"path": "tokio/tests/tcp_echo.rs",
"hunk": "@@ -17,25 +15,25 @@ use tokio_test::assert_ok;\n \n #[tokio::test]\n async fn echo_server() {\n- const ITER: usize = 1024;\n+ const BYTES: &[u8] = b\"foo bar ba... | true | ||
tokio-rs/tokio | 8,169 | issue_to_patch | time: ensure timers stay in the same runtime after `.reset()` | ## Motivation
It is possible that a timer is `.reset()`ed in a runtime that is different from the runtime that the timer is created in. However, currently, there is no compile-time guarantee to keep this invariant.
Fix the regression introduced by <https://github.com/tokio-rs/tokio/pull/8132>.
## Solution
*... | 923e72345c77aef4d11875d874ba67421b0412d3 | 9a3508a66373a7a5eab6111ebc434e8713d70cbb | diff --git a/tokio/src/runtime/time_alt/timer.rs b/tokio/src/runtime/time_alt/timer.rs
index bd87d05b62b..1798deeb73a 100644
--- a/tokio/src/runtime/time_alt/timer.rs
+++ b/tokio/src/runtime/time_alt/timer.rs
@@ -29,7 +29,7 @@ impl Timer {
#[track_caller]
pub(crate) fn new(handle: scheduler::Handle, deadline:... | [
"tokio/src/runtime/time_alt/timer.rs",
"tokio/tests/time_alt.rs"
] | [
{
"comment": "Does this need to panic ?\n\n```suggestion\n false\n```\n\nReturning `false` seems to be enough for a test similar to the added one below:\n\n```rust\n#[test]\n/// It is possible that a timer is created in one runtime,\n/// but `.reset()` is called in a different runtime.\n/// I... | diff --git a/tokio/tests/time_alt.rs b/tokio/tests/time_alt.rs
index 360aac3c802..fd8d1dd688d 100644
--- a/tokio/tests/time_alt.rs
+++ b/tokio/tests/time_alt.rs
@@ -4,6 +4,12 @@
use tokio::runtime::Runtime;
use tokio::time::*;
+use std::future::Future;
+
+use futures::FutureExt;
+use futures_test::task::noop_contex... | true | |
tokio-rs/tokio | 8,169 | comment_to_fix | time: ensure timers stay in the same runtime after `.reset()` | Does this need to panic ?
```suggestion
false
```
Returning `false` seems to be enough for a test similar to the added one below:
```rust
#[test]
/// It is possible that a timer is created in one runtime,
/// but `.reset()` is called in a different runtime.
/// In this case, the timer should be r... | 923e72345c77aef4d11875d874ba67421b0412d3 | 9a3508a66373a7a5eab6111ebc434e8713d70cbb | diff --git a/tokio/src/runtime/time_alt/timer.rs b/tokio/src/runtime/time_alt/timer.rs
index bd87d05b62b..1798deeb73a 100644
--- a/tokio/src/runtime/time_alt/timer.rs
+++ b/tokio/src/runtime/time_alt/timer.rs
@@ -29,7 +29,7 @@ impl Timer {
#[track_caller]
pub(crate) fn new(handle: scheduler::Handle, deadline:... | [
"tokio/src/runtime/time_alt/timer.rs"
] | [
{
"comment": "Does this need to panic ?\n\n```suggestion\n false\n```\n\nReturning `false` seems to be enough for a test similar to the added one below:\n\n```rust\n#[test]\n/// It is possible that a timer is created in one runtime,\n/// but `.reset()` is called in a different runtime.\n/// I... | true | ||
tokio-rs/tokio | 7,818 | issue_to_patch | signal: specialize unix OsStorage | Noticed that this was unnecessarily boxed, even though that's only required for linux and illumos. | c27bed36acc96ae46193ff32ceb8ccc225fd58b1 | 6d7f31841d899891e55a82d41619940c87659732 | diff --git a/tokio/src/signal/unix.rs b/tokio/src/signal/unix.rs
index e70863b54b7..56bec97ff33 100644
--- a/tokio/src/signal/unix.rs
+++ b/tokio/src/signal/unix.rs
@@ -18,21 +18,25 @@ use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Once;
use std::task::{Context, Poll};
+#[cfg(not(any(target_os = "lin... | [
"tokio/src/signal/unix.rs"
] | [
{
"comment": "This import can go on the top, or just do `std::array::from_fn`.",
"path": "tokio/src/signal/unix.rs",
"hunk": "@@ -18,21 +18,33 @@ use std::sync::atomic::{AtomicBool, Ordering};\n use std::sync::Once;\n use std::task::{Context, Poll};\n \n-pub(crate) type OsStorage = Box<[SignalInfo]>;\n+... | true | ||
tokio-rs/tokio | 7,818 | comment_to_fix | signal: specialize unix OsStorage | This import can go on the top, or just do `std::array::from_fn`. | c27bed36acc96ae46193ff32ceb8ccc225fd58b1 | 6d7f31841d899891e55a82d41619940c87659732 | diff --git a/tokio/src/signal/unix.rs b/tokio/src/signal/unix.rs
index e70863b54b7..56bec97ff33 100644
--- a/tokio/src/signal/unix.rs
+++ b/tokio/src/signal/unix.rs
@@ -18,21 +18,25 @@ use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Once;
use std::task::{Context, Poll};
+#[cfg(not(any(target_os = "lin... | [
"tokio/src/signal/unix.rs"
] | [
{
"comment": "This import can go on the top, or just do `std::array::from_fn`.",
"path": "tokio/src/signal/unix.rs",
"hunk": "@@ -18,21 +18,33 @@ use std::sync::atomic::{AtomicBool, Ordering};\n use std::sync::Once;\n use std::task::{Context, Poll};\n \n-pub(crate) type OsStorage = Box<[SignalInfo]>;\n+... | true | ||
tokio-rs/tokio | 7,818 | comment_to_fix | signal: specialize unix OsStorage | Same here. | c27bed36acc96ae46193ff32ceb8ccc225fd58b1 | 6d7f31841d899891e55a82d41619940c87659732 | diff --git a/tokio/src/signal/unix.rs b/tokio/src/signal/unix.rs
index e70863b54b7..56bec97ff33 100644
--- a/tokio/src/signal/unix.rs
+++ b/tokio/src/signal/unix.rs
@@ -18,21 +18,25 @@ use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Once;
use std::task::{Context, Poll};
+#[cfg(not(any(target_os = "lin... | [
"tokio/src/signal/unix.rs"
] | [
{
"comment": "Same here.",
"path": "tokio/src/signal/unix.rs",
"hunk": "@@ -18,21 +18,33 @@ use std::sync::atomic::{AtomicBool, Ordering};\n use std::sync::Once;\n use std::task::{Context, Poll};\n \n-pub(crate) type OsStorage = Box<[SignalInfo]>;\n+// There are reliable signals ranging from 1 to 33 ava... | true | ||
tokio-rs/tokio | 7,818 | comment_to_fix | signal: specialize unix OsStorage | It may be clearer to move the `#[cfg()]` inside `fn init()` rather than having entirely separate blocks. | c27bed36acc96ae46193ff32ceb8ccc225fd58b1 | 6d7f31841d899891e55a82d41619940c87659732 | diff --git a/tokio/src/signal/unix.rs b/tokio/src/signal/unix.rs
index e70863b54b7..56bec97ff33 100644
--- a/tokio/src/signal/unix.rs
+++ b/tokio/src/signal/unix.rs
@@ -18,21 +18,25 @@ use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Once;
use std::task::{Context, Poll};
+#[cfg(not(any(target_os = "lin... | [
"tokio/src/signal/unix.rs"
] | [
{
"comment": "It may be clearer to move the `#[cfg()]` inside `fn init()` rather than having entirely separate blocks.",
"path": "tokio/src/signal/unix.rs",
"hunk": "@@ -18,21 +18,33 @@ use std::sync::atomic::{AtomicBool, Ordering};\n use std::sync::Once;\n use std::task::{Context, Poll};\n \n-pub(crate... | true | ||
tokio-rs/tokio | 8,124 | issue_to_patch | time: consolidate mutex locks on spurious poll | The match guard (`is_woken_up`) and fallback (`register_waker`) both acquired the mutex separately.
| 02ff0833e00adeb8cd451420f586f968deb70f78 | b5a9d4d226938c8790203ee68da8b799dfd5b449 | diff --git a/tokio/src/runtime/time_alt/entry.rs b/tokio/src/runtime/time_alt/entry.rs
index f9a4746b8fe..40c1fc47337 100644
--- a/tokio/src/runtime/time_alt/entry.rs
+++ b/tokio/src/runtime/time_alt/entry.rs
@@ -4,7 +4,7 @@ use crate::util::linked_list;
use std::marker::PhantomPinned;
use std::ptr::NonNull;
-use s... | [
"tokio/src/runtime/time_alt/entry.rs",
"tokio/src/runtime/time_alt/timer.rs"
] | [] | true | ||
tokio-rs/tokio | 8,132 | issue_to_patch | time: move lazy-registration state into Sleep | ## Motivation
Timers are a complex implementation detail of the Sleep future and should therefore be simple. Moving the lazy-registration state into Sleep reduces Timer responsibilities and correctly synchronizes Tracing event emission.
## Solution
Moves the lazy-registration state from Timer into Sleep. Timer... | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 7e1265c0da7b8ad60ba175530de03b0effed2177 | diff --git a/tokio/src/runtime/mod.rs b/tokio/src/runtime/mod.rs
index 713f60de05b..2b3f0ad9b2d 100644
--- a/tokio/src/runtime/mod.rs
+++ b/tokio/src/runtime/mod.rs
@@ -416,7 +416,7 @@ cfg_process_driver! {
mod process;
}
-#[cfg_attr(not(feature = "time"), allow(dead_code))]
+#[allow(dead_code)]
#[derive(Debug... | [
"tokio/src/runtime/mod.rs",
"tokio/src/runtime/scheduler/mod.rs",
"tokio/src/runtime/time/entry.rs",
"tokio/src/runtime/time/tests/mod.rs",
"tokio/src/runtime/time_alt/cancellation_queue/tests.rs",
"tokio/src/runtime/time_alt/context.rs",
"tokio/src/runtime/time_alt/entry.rs",
"tokio/src/runtime/time_... | [
{
"comment": "It is unclear to me whether the documentation for calling `sleep` outside a runtime with `time` enabled is _guaranteed_ to panic or a helpful description of the current behaviour. I left it as is, but it would be nice to drop.",
"path": "tokio/src/time/sleep.rs",
"hunk": "@@ -251,18 +252,1... | diff --git a/tokio/src/runtime/time/tests/mod.rs b/tokio/src/runtime/time/tests/mod.rs
index 33c4a5366d1..84c765af69e 100644
--- a/tokio/src/runtime/time/tests/mod.rs
+++ b/tokio/src/runtime/time/tests/mod.rs
@@ -48,11 +48,11 @@ fn single_timer() {
let handle_ = handle.clone();
let jh = thread::spaw... | true | |
tokio-rs/tokio | 8,132 | comment_to_fix | time: move lazy-registration state into Sleep | This reverses the order of `tracing::trace_span!` and `this.inner.ctx.*_span.enter()`? Is this intentional? | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 7e1265c0da7b8ad60ba175530de03b0effed2177 | diff --git a/tokio/src/time/sleep.rs b/tokio/src/time/sleep.rs
index 2aa19b6663f..e4535e4d6eb 100644
--- a/tokio/src/time/sleep.rs
+++ b/tokio/src/time/sleep.rs
@@ -1,4 +1,4 @@
-use crate::runtime::Timer;
+use crate::runtime::{scheduler, Timer};
use crate::time::{error::Error, Duration, Instant};
use crate::util::tra... | [
"tokio/src/time/sleep.rs"
] | [
{
"comment": "This reverses the order of `tracing::trace_span!` and `this.inner.ctx.*_span.enter()`? Is this intentional?",
"path": "tokio/src/time/sleep.rs",
"hunk": "@@ -349,74 +349,50 @@ impl Sleep {\n ///\n /// [`Pin::as_mut`]: fn@std::pin::Pin::as_mut\n pub fn reset(self: Pin<&mut Self>... | true | ||
tokio-rs/tokio | 8,132 | comment_to_fix | time: move lazy-registration state into Sleep | w/ `start_paused`, there's no race to call `time::pause`, so `Instant::now` is exactly 0. Internally, the sleep deadline is equal to the wheel's `elapsed` field, which causes the timer fire immediately. | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 7e1265c0da7b8ad60ba175530de03b0effed2177 | diff --git a/tokio/tests/time_sleep.rs b/tokio/tests/time_sleep.rs
index 857b3822d64..b82b1cc6ae4 100644
--- a/tokio/tests/time_sleep.rs
+++ b/tokio/tests/time_sleep.rs
@@ -10,15 +10,19 @@ use futures::task::noop_waker_ref;
use tokio::time::{self, Duration, Instant};
use tokio_test::{assert_elapsed, assert_pending, a... | [
"tokio/tests/time_sleep.rs"
] | [
{
"comment": "w/ `start_paused`, there's no race to call `time::pause`, so `Instant::now` is exactly 0. Internally, the sleep deadline is equal to the wheel's `elapsed` field, which causes the timer fire immediately.",
"path": "tokio/tests/time_sleep.rs",
"hunk": "@@ -10,15 +10,19 @@ use futures::task::... | true | ||
tokio-rs/tokio | 8,132 | comment_to_fix | time: move lazy-registration state into Sleep | This change looks interesting, it looks like the old test never poll the `Sleep` future. Does it mean the old test never be executed? | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 7e1265c0da7b8ad60ba175530de03b0effed2177 | diff --git a/tokio/tests/tracing_time.rs b/tokio/tests/tracing_time.rs
index f251cc780b9..261237b7cb9 100644
--- a/tokio/tests/tracing_time.rs
+++ b/tokio/tests/tracing_time.rs
@@ -17,6 +17,12 @@ async fn test_sleep_creates_span() {
.named("runtime.resource")
.with_target("tokio::time::sleep");
+ ... | [
"tokio/tests/tracing_time.rs"
] | [
{
"comment": "This change looks interesting, it looks like the old test never poll the `Sleep` future. Does it mean the old test never be executed?",
"path": "tokio/tests/tracing_time.rs",
"hunk": "@@ -40,31 +46,35 @@ async fn test_sleep_creates_span() {\n \n let (subscriber, handle) = subscriber::m... | true | ||
tokio-rs/tokio | 8,132 | comment_to_fix | time: move lazy-registration state into Sleep | Emm, if I understand correctly, we `.enter()` twice times for both `resource_span` and `async_op_span`. Any reason for this? Did I miss something? | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 7e1265c0da7b8ad60ba175530de03b0effed2177 | diff --git a/tokio/src/time/sleep.rs b/tokio/src/time/sleep.rs
index 2aa19b6663f..e4535e4d6eb 100644
--- a/tokio/src/time/sleep.rs
+++ b/tokio/src/time/sleep.rs
@@ -1,4 +1,4 @@
-use crate::runtime::Timer;
+use crate::runtime::{scheduler, Timer};
use crate::time::{error::Error, Duration, Instant};
use crate::util::tra... | [
"tokio/src/time/sleep.rs"
] | [
{
"comment": "Emm, if I understand correctly, we `.enter()` twice times for both `resource_span` and `async_op_span`. Any reason for this? Did I miss something?",
"path": "tokio/src/time/sleep.rs",
"hunk": "@@ -349,74 +349,47 @@ impl Sleep {\n ///\n /// [`Pin::as_mut`]: fn@std::pin::Pin::as_mut\... | true | ||
tokio-rs/tokio | 8,166 | issue_to_patch | docs: improve contributing guidelines | ## Motivation
A couple of improvements on the contributing docs following contributors questions | 82fe082ef14c2e2b2c1c29ed9873c2ca6e6109ee | 9d9e1905fc309d4fef7fdd937d5cf8dfa2c7ba2e | diff --git a/docs/contributing/README.md b/docs/contributing/README.md
index f6caca4363c..050f6b2fbb5 100644
--- a/docs/contributing/README.md
+++ b/docs/contributing/README.md
@@ -8,7 +8,8 @@ It should be considered a map to help you navigate the process.
If you are unsure where to begin, use the following guides:
... | [
"docs/contributing/README.md",
"docs/contributing/keeping-track-of-issues-and-prs.md",
"docs/contributing/pull-requests.md"
] | [] | true | ||
tokio-rs/tokio | 8,143 | issue_to_patch | tokio-stream: fix duplicated word in changelog | Fix a duplicated word in the `tokio-stream` CHANGELOG entry.
Line in question: `- stream: improve the the docs of `TcpListenerStream``
The word "the" appears twice. This removes the duplicate. | 7d3b0ad192fa6da7f0301fb0db7472031a3d253a | 4bc1645796504583104de7aad69e2dd7d4ce0bcd | diff --git a/tokio-stream/CHANGELOG.md b/tokio-stream/CHANGELOG.md
index 6216bbf8202..5e2a43aa5ee 100644
--- a/tokio-stream/CHANGELOG.md
+++ b/tokio-stream/CHANGELOG.md
@@ -12,7 +12,7 @@
### Documented
-- stream: improve the the docs of `TcpListenerStream` ([#7578])
+- stream: improve the docs of `TcpListenerStrea... | [
"tokio-stream/CHANGELOG.md"
] | [] | true | ||
tokio-rs/tokio | 8,159 | issue_to_patch | tokio-util write_all_vectored can drop data after partial vectored writes
### Description
`tokio_util::io::write_all_vectored` can advance the provided `IoSlice` list incorrectly after a partial `poll_write_vectored` result. The local `advance_slices` helper removes fully written buffers, then re-slices the new first... | io: advance partially written buffers correctly in `write_all_vectored` | Fixes #8158.
## Summary
- Correct `advance_slices` to retain the unwritten suffix after a partial vectored write.
- Add regression coverage for a partial write inside a buffer.
- Add regression coverage for a partial write that lands exactly on a buffer boundary.
## Root cause
The local `advance_slices` helper remo... | 2a05f364b79a7377bb21d6d5d14fd191b26e3ade | d2da302deac80688930edeefc5a9f1c07385b59a | diff --git a/tokio-util/src/io/write_all_vectored.rs b/tokio-util/src/io/write_all_vectored.rs
index dbc59a0b73a..c2b19a19c52 100644
--- a/tokio-util/src/io/write_all_vectored.rs
+++ b/tokio-util/src/io/write_all_vectored.rs
@@ -147,7 +147,7 @@ fn advance_slices<'a>(bufs: &mut &mut [IoSlice<'a>], n: usize) {
*bu... | [
"tokio-util/src/io/write_all_vectored.rs",
"tokio-util/tests/io_write_all_vectored.rs"
] | [] | diff --git a/tokio-util/tests/io_write_all_vectored.rs b/tokio-util/tests/io_write_all_vectored.rs
index 5ba0e62db96..3009030378f 100644
--- a/tokio-util/tests/io_write_all_vectored.rs
+++ b/tokio-util/tests/io_write_all_vectored.rs
@@ -10,6 +10,55 @@ use std::io::IoSlice;
use std::pin::Pin;
use std::task::{Context, ... | true |
tokio-rs/tokio | 8,155 | issue_to_patch | ci(freebsd): set copyback to false | Sets `copyback` to false on FreeBSD `vmactions` jobs. | c6d58ce7e7bf4a6e7e6efc1ffeb42daa3a627c17 | 89702d76719a137409d56ab22ca3d184fb51c3e7 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2efe408ad24..8558302fb51 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1323,6 +1323,8 @@ jobs:
with:
release: '14.4'
envs: "TOKIO_STABLE_FEATURES RUSTFLAGS"
+ sync: rsync
+ ... | [
".github/workflows/ci.yml"
] | [] | true | ||
tokio-rs/tokio | 8,145 | issue_to_patch | ci: fix macos runner | We started to observe failures in macOS runners, it seems that disabling the cache-bin option for rust-cache fixes the issue (this is a temporary fix that will be reverted once the upstream fixes the issue). see: https://github.com/Swatinem/rust-cache/issues/341 | 7d3b0ad192fa6da7f0301fb0db7472031a3d253a | bbfdadd1a9df7d415b20a39e2d4177453a07be63 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e8585e67835..2efe408ad24 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -75,6 +75,9 @@ jobs:
tool: cargo-nextest
- uses: Swatinem/rust-cache@v2
+ with:
+ # FIXME: temporary workaround, see... | [
".github/workflows/ci.yml"
] | [] | true | ||
tokio-rs/tokio | 8,142 | issue_to_patch | sync: remove useless conversion in oneshot Receiver::poll | ## Summary
`Inner::poll_recv` returns `Poll<Result<T, RecvError>>` and `Receiver`'s `Future::Output` is `Result<T, RecvError>`, so the `.map_err(Into::into)` in `Receiver::poll` is an identity conversion. Newer `clippy` flags it as `clippy::useless_conversion`. This removes it from both `#[cfg]` arms — no behavior cha... | 0121120b6d91c438ca3a088a286ad78d293eea0b | 27bb1ad058175761792503677c6b9bb390e479f3 | diff --git a/tokio/src/sync/oneshot.rs b/tokio/src/sync/oneshot.rs
index 3b8055b682a..aea2550204f 100644
--- a/tokio/src/sync/oneshot.rs
+++ b/tokio/src/sync/oneshot.rs
@@ -1279,10 +1279,10 @@ impl<T> Future for Receiver<T> {
let ret = if let Some(inner) = self.as_ref().get_ref().inner.as_ref() {
... | [
"tokio/src/sync/oneshot.rs"
] | [] | true | ||
tokio-rs/tokio | 8,043 | issue_to_patch | taskdump: skip double wake on `Trace::capture`/`Trace::trace_with` | <!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Bug fixes and new features should include tests.
Contributors guide: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md
The contributors guide includes instructions for running rustfmt and b... | bdcea6b2cd716b0a378626796bf5dc049608663d | eed0f1cb60966da65cd221add83f5745434eed24 | diff --git a/spellcheck.dic b/spellcheck.dic
index ea6ab93ae81..aeb1e9db419 100644
--- a/spellcheck.dic
+++ b/spellcheck.dic
@@ -1,4 +1,4 @@
-323
+324
&
+
<
@@ -89,6 +89,7 @@ decrementing
demangled
dequeued
dereferenced
+derefs
deregister
deregistered
deregistering
diff --git a/tokio/src/fs/file.rs b/tokio/src... | [
"spellcheck.dic",
"tokio/src/fs/file.rs",
"tokio/src/io/util/copy.rs",
"tokio/src/io/util/empty.rs",
"tokio/src/io/util/mem.rs",
"tokio/src/io/util/repeat.rs",
"tokio/src/io/util/sink.rs",
"tokio/src/lib.rs",
"tokio/src/process/mod.rs",
"tokio/src/runtime/dump.rs",
"tokio/src/runtime/io/registra... | [
{
"comment": "By using the same return value as `waker_ref`, I think you can avoid this clone and refcount increment.",
"path": "tokio/src/runtime/task/mod.rs",
"hunk": "@@ -509,6 +509,22 @@ impl<S: Schedule> LocalNotified<S> {\n mem::forget(self);\n raw.poll();\n }\n+\n+ /// Retu... | diff --git a/tokio/tests/task_trace_self.rs b/tokio/tests/task_trace_self.rs
index e3e0c479132..6553a0a1fb1 100644
--- a/tokio/tests/task_trace_self.rs
+++ b/tokio/tests/task_trace_self.rs
@@ -61,6 +61,10 @@ impl<F: Future> Future for PrettyFuture<F> {
let (res, trace) = tokio::runtime::dump::Trace::captur... | true | |
tokio-rs/tokio | 8,043 | comment_to_fix | taskdump: skip double wake on `Trace::capture`/`Trace::trace_with` | By using the same return value as `waker_ref`, I think you can avoid this clone and refcount increment. | bdcea6b2cd716b0a378626796bf5dc049608663d | eed0f1cb60966da65cd221add83f5745434eed24 | diff --git a/tokio/src/runtime/task/mod.rs b/tokio/src/runtime/task/mod.rs
index 53c477d52de..6f964c1de40 100644
--- a/tokio/src/runtime/task/mod.rs
+++ b/tokio/src/runtime/task/mod.rs
@@ -509,6 +509,20 @@ impl<S: Schedule> LocalNotified<S> {
mem::forget(self);
raw.poll();
}
+
+ /// Returns a ... | [
"tokio/src/runtime/task/mod.rs"
] | [
{
"comment": "By using the same return value as `waker_ref`, I think you can avoid this clone and refcount increment.",
"path": "tokio/src/runtime/task/mod.rs",
"hunk": "@@ -509,6 +509,22 @@ impl<S: Schedule> LocalNotified<S> {\n mem::forget(self);\n raw.poll();\n }\n+\n+ /// Retu... | true | ||
tokio-rs/tokio | 8,064 | issue_to_patch | docs: add docs flag for task-dump related features | <!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Bug fixes and new features should include tests.
Contributors guide: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md
The contributors guide includes instructions for running rustfmt and b... | 905c146aeda741ea2202f942a7c3a606dda13da5 | e411b19fa9268a0de93c0b2545a94168ab0e2450 | diff --git a/tokio/src/macros/cfg.rs b/tokio/src/macros/cfg.rs
index a0d8da518e9..efbd163c7f4 100644
--- a/tokio/src/macros/cfg.rs
+++ b/tokio/src/macros/cfg.rs
@@ -520,6 +520,20 @@ macro_rules! cfg_taskdump {
target_arch = "x86_64"
)
))]
+ #[cfg_attr(
+ ... | [
"tokio/src/macros/cfg.rs"
] | [] | true | ||
tokio-rs/tokio | 8,134 | issue_to_patch | fs(tests): improve io_uring tests | <!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Bug fixes and new features should include tests.
Contributors guide: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md
The contributors guide includes instructions for running rustfmt and b... | ee0dc9092665a1f13df573dc5e5124999d8e9035 | 6fd038b9c2cf83fbbe0d696bb2c5c99bd84a20fc | diff --git a/.github/workflows/uring-kernel-version-test.yml b/.github/workflows/uring-kernel-version-test.yml
index 14170f36c8b..bc90ea0a2f6 100644
--- a/.github/workflows/uring-kernel-version-test.yml
+++ b/.github/workflows/uring-kernel-version-test.yml
@@ -40,6 +40,8 @@ jobs:
make defconfig
ma... | [
".github/workflows/uring-kernel-version-test.yml",
"tokio/tests/fs_uring_cancel_open.rs",
"tokio/tests/fs_uring_completed_then_dropped_before_repoll.rs",
"tokio/tests/fs_uring_runtime_shutdown.rs",
"tokio/tests/support/io_uring.rs"
] | [] | diff --git a/tokio/tests/fs_uring_cancel_open.rs b/tokio/tests/fs_uring_cancel_open.rs
index 5f204020564..989f9525d42 100644
--- a/tokio/tests/fs_uring_cancel_open.rs
+++ b/tokio/tests/fs_uring_cancel_open.rs
@@ -13,10 +13,21 @@ use std::fs;
use std::future::poll_fn;
use std::task::Poll;
use tempfile::NamedTempFile;... | true | |
tokio-rs/tokio | 8,131 | issue_to_patch | Merge 1.52.3 | 067f229371b982412a3dc523cf58f95c3c8794ec | 78594a7497dcabd6850dbaf15dd3c5b4fe045d2c | diff --git a/README.md b/README.md
index 657a5f3f4c0..01e7a84f6c4 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.52.2", features = ["full"] }
+tokio = { version = "1.52.3", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md",
"tokio/src/sync/mpsc/block.rs",
"tokio/src/sync/mpsc/bounded.rs",
"tokio/src/sync/mpsc/chan.rs",
"tokio/src/sync/mpsc/list.rs",
"tokio/src/sync/mpsc/mod.rs",
"tokio/src/sync/rwlock.rs",
"tokio/src/sync/tests/loom_mpsc.rs",... | [] | diff --git a/tokio/src/sync/tests/loom_mpsc.rs b/tokio/src/sync/tests/loom_mpsc.rs
index 620a9638a6c..468177143dd 100644
--- a/tokio/src/sync/tests/loom_mpsc.rs
+++ b/tokio/src/sync/tests/loom_mpsc.rs
@@ -1,4 +1,4 @@
-use crate::sync::mpsc;
+use crate::sync::mpsc::{self, BLOCK_CAP};
use loom::future::block_on;
use ... | true | ||
tokio-rs/tokio | 8,130 | issue_to_patch | chore: prepare Tokio v1.52.3 | # 1.52.3 (May 8th, 2026)
### Fixed
* sync: fix underflow in mpsc channel `len()` ([#8062])
* sync: notify receivers in mpsc `OwnedPermit::release()` method ([#8075])
* sync: require that an `RwLock` has `max_readers != 0` ([#8076])
* sync: return `Empty` from `try_recv()` when mpsc is closed with outstanding p... | e1aebb031cb24bdb52289561343308f4a44a4d81 | 7c19718c3da2010dcdcced38ffa2684e68434805 | diff --git a/README.md b/README.md
index 657a5f3f4c0..01e7a84f6c4 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.52.2", features = ["full"] }
+tokio = { version = "1.52.3", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md"
] | [] | true | ||
tokio-rs/tokio | 8,129 | issue_to_patch | Merge 'tokio-1.51.3' into 'tokio-1.52.x' | Must be merged on the command-line. | 4abe9d732eb01f7b092a571c3dcc4fbd266f4067 | e1aebb031cb24bdb52289561343308f4a44a4d81 | diff --git a/tokio/CHANGELOG.md b/tokio/CHANGELOG.md
index 442ac5b8cb9..9e44c77e5c5 100644
--- a/tokio/CHANGELOG.md
+++ b/tokio/CHANGELOG.md
@@ -55,6 +55,15 @@ This release reverts the LIFO slot stealing change introduced in 1.51.0
[#8035]: https://github.com/tokio-rs/tokio/pull/8035
[#8040]: https://github.com/tokio... | [
"tokio/CHANGELOG.md",
"tokio/src/sync/mpsc/block.rs",
"tokio/src/sync/mpsc/bounded.rs",
"tokio/src/sync/mpsc/chan.rs",
"tokio/src/sync/mpsc/list.rs",
"tokio/src/sync/mpsc/mod.rs",
"tokio/src/sync/rwlock.rs",
"tokio/src/sync/tests/loom_mpsc.rs",
"tokio/tests/sync_mpsc.rs",
"tokio/tests/sync_rwlock.... | [] | diff --git a/tokio/src/sync/tests/loom_mpsc.rs b/tokio/src/sync/tests/loom_mpsc.rs
index 620a9638a6c..468177143dd 100644
--- a/tokio/src/sync/tests/loom_mpsc.rs
+++ b/tokio/src/sync/tests/loom_mpsc.rs
@@ -1,4 +1,4 @@
-use crate::sync::mpsc;
+use crate::sync::mpsc::{self, BLOCK_CAP};
use loom::future::block_on;
use ... | true | |
tokio-rs/tokio | 8,125 | issue_to_patch | clippy: fix manual_clear lint | https://rust-lang.github.io/rust-clippy/master/index.html#manual_clear
| 02ff0833e00adeb8cd451420f586f968deb70f78 | 236b3b4e56a41cf2761023043faec797fe359f5c | diff --git a/tokio/src/io/blocking.rs b/tokio/src/io/blocking.rs
index 2aefd2cc02e..0fce78993b0 100644
--- a/tokio/src/io/blocking.rs
+++ b/tokio/src/io/blocking.rs
@@ -214,7 +214,7 @@ impl Buf {
self.pos += n;
if self.pos == self.buf.len() {
- self.buf.truncate(0);
+ self.buf.... | [
"tokio/src/io/blocking.rs"
] | [] | true | ||
tokio-rs/tokio | 8,127 | issue_to_patch | chore: prepare Tokio v1.51.3 | # 1.51.3 (May 8th, 2026)
### Fixed
* sync: fix underflow in mpsc channel `len()` ([#8062])
* sync: notify receivers in mpsc `OwnedPermit::release()` method ([#8075])
* sync: require that an `RwLock` has `max_readers != 0` ([#8076])
* sync: return `Empty` from `try_recv()` when mpsc is closed with outstanding p... | 8c600d0fd2cdebea4828fe9f699ced4dfd8aad3b | 44ba40990f91ae2d2513b4faa6be01095b8aa2bf | diff --git a/README.md b/README.md
index a45c812c132..58053042de0 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.51.2", features = ["full"] }
+tokio = { version = "1.51.3", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md"
] | [] | true | ||
tokio-rs/tokio | 8,123 | issue_to_patch | Merge 'tokio-1.47.5' into 'tokio-1.51.x' | Forward port bugfixes for 1.51 LTS release. | 64834ec7018de92fadf00d053b565263913439c1 | 8c600d0fd2cdebea4828fe9f699ced4dfd8aad3b | diff --git a/tokio/CHANGELOG.md b/tokio/CHANGELOG.md
index 6131728700a..93b9e7f8f26 100644
--- a/tokio/CHANGELOG.md
+++ b/tokio/CHANGELOG.md
@@ -330,6 +330,20 @@ The MSRV is increased to 1.71.
[#7672]: https://github.com/tokio-rs/tokio/pull/7672
[#7675]: https://github.com/tokio-rs/tokio/pull/7675
+# 1.47.5 (May 7t... | [
"tokio/CHANGELOG.md",
"tokio/src/sync/mpsc/block.rs",
"tokio/src/sync/mpsc/bounded.rs",
"tokio/src/sync/mpsc/chan.rs",
"tokio/src/sync/mpsc/list.rs",
"tokio/src/sync/mpsc/mod.rs",
"tokio/src/sync/rwlock.rs",
"tokio/src/sync/tests/loom_mpsc.rs",
"tokio/tests/sync_mpsc.rs",
"tokio/tests/sync_rwlock.... | [] | diff --git a/tokio/src/sync/tests/loom_mpsc.rs b/tokio/src/sync/tests/loom_mpsc.rs
index 620a9638a6c..468177143dd 100644
--- a/tokio/src/sync/tests/loom_mpsc.rs
+++ b/tokio/src/sync/tests/loom_mpsc.rs
@@ -1,4 +1,4 @@
-use crate::sync::mpsc;
+use crate::sync::mpsc::{self, BLOCK_CAP};
use loom::future::block_on;
use ... | true | |
tokio-rs/tokio | 8,122 | issue_to_patch | Prepare Tokio v1.47.5 | # 1.47.5 (May 7th, 2026)
### Fixed
* sync: fix underflow in mpsc channel `len()` ([#8062])
* sync: notify receivers in mpsc `OwnedPermit::release()` method ([#8075])
* sync: require that an `RwLock` has `max_readers != 0` ([#8076])
* sync: return `Empty` from `try_recv()` when mpsc is closed with outstanding p... | f085b6211b8ebb6aba21f1f1f91e7b8b243aa815 | 7f9612821dadc8931a43c0c9ec5d80ddbcf06f10 | diff --git a/Cargo.lock b/Cargo.lock
index d1a338d4369..6d093ee837a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1050,9 +1050,9 @@ checksum = "69cdb34c158ceb288df11e18b4bd39de994f6657d83847bdffdbd7f346754b0f"
[[package]]
name = "rand"
-version = "0.9.2"
+version = "0.9.4"
source = "registry+https://github.com/rust... | [
"Cargo.lock",
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md"
] | [
{
"comment": "https://github.com/tokio-rs/tokio/pull/8122/changes#diff-f4bfdbfbf2e4c7b2036d9a38e3e99cf403fb50ce4f319c12552bc02e06e4fee7R89 still has a `path` dependency for `tokio-macros`",
"path": "tokio/Cargo.toml",
"hunk": "",
"resolving_sha": "7f9612821dadc8931a43c0c9ec5d80ddbcf06f10",
"reso... | true | ||
tokio-rs/tokio | 8,076 | issue_to_patch | Require that an `RwLock` has `max_readers != 0` | If an `RwLock` is created with max readers equal to zero, then write locks do not ensure mutual exclusion because they acquire 0 permits. This can be abused to trigger UB.
```rs
let v = RwLock::with_max_readers(vec![1], 0);
let mut w1 = v.write().await;
let w2 = v.write().await;
let one = &w2[0];
*w1 = Vec::new()... | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock.rs
index d94b6514306..b6bf7faca9a 100644
--- a/tokio/src/sync/rwlock.rs
+++ b/tokio/src/sync/rwlock.rs
@@ -266,12 +266,13 @@ impl<T: ?Sized> RwLock<T> {
///
/// # Panics
///
- /// Panics if `max_reads` is more than `u32::MAX >> 3`.
+ ///... | [
"tokio/src/sync/rwlock.rs",
"tokio/tests/sync_rwlock.rs"
] | [
{
"comment": "```suggestion\n /// Panics if `max_reads` is `0` or is bigger than `u32::MAX >> 3`\n```",
"path": "tokio/src/sync/rwlock.rs",
"hunk": "",
"resolving_sha": "586201858bdfa0f25ee1626bed9f8f4595159bc6",
"resolving_diff": "diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock... | diff --git a/tokio/tests/sync_rwlock.rs b/tokio/tests/sync_rwlock.rs
index 5a58b4971b9..2dc7b0a62ac 100644
--- a/tokio/tests/sync_rwlock.rs
+++ b/tokio/tests/sync_rwlock.rs
@@ -78,6 +78,18 @@ fn exhaust_reading() {
let _g1 = assert_ready!(t1.poll());
}
+#[test]
+#[should_panic(expected = "a RwLock may not be cr... | true | |
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
/// Panics if `max_reads` is `0` or is bigger than `u32::MAX >> 3`
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock.rs
index d94b6514306..b6bf7faca9a 100644
--- a/tokio/src/sync/rwlock.rs
+++ b/tokio/src/sync/rwlock.rs
@@ -266,12 +266,13 @@ impl<T: ?Sized> RwLock<T> {
///
/// # Panics
///
- /// Panics if `max_reads` is more than `u32::MAX >> 3`.
+ ///... | [
"tokio/src/sync/rwlock.rs"
] | [
{
"comment": "```suggestion\n /// Panics if `max_reads` is `0` or is bigger than `u32::MAX >> 3`\n```",
"path": "tokio/src/sync/rwlock.rs",
"hunk": "",
"resolving_sha": "586201858bdfa0f25ee1626bed9f8f4595159bc6",
"resolving_diff": "diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock... | true | ||
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
assert_ne!(max_reads, 0, "a RwLock may not be created with 0 readers"));
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock.rs
index d94b6514306..b6bf7faca9a 100644
--- a/tokio/src/sync/rwlock.rs
+++ b/tokio/src/sync/rwlock.rs
@@ -266,12 +266,13 @@ impl<T: ?Sized> RwLock<T> {
///
/// # Panics
///
- /// Panics if `max_reads` is more than `u32::MAX >> 3`.
+ ///... | [
"tokio/src/sync/rwlock.rs"
] | [
{
"comment": "```suggestion\n assert_ne!(max_reads, 0, \"a RwLock may not be created with 0 readers\"));\n```",
"path": "tokio/src/sync/rwlock.rs",
"hunk": "@@ -271,6 +271,7 @@ impl<T: ?Sized> RwLock<T> {\n where\n T: Sized,\n {\n+ assert_ne!(max_reads, 0);",
"resolving... | true | ||
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
assert!(max_reads != 0, "a RwLock may not be created with 0 readers"));
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock.rs
index d94b6514306..b6bf7faca9a 100644
--- a/tokio/src/sync/rwlock.rs
+++ b/tokio/src/sync/rwlock.rs
@@ -266,12 +266,13 @@ impl<T: ?Sized> RwLock<T> {
///
/// # Panics
///
- /// Panics if `max_reads` is more than `u32::MAX >> 3`.
+ ///... | [
"tokio/src/sync/rwlock.rs"
] | [
{
"comment": "```suggestion\n assert!(max_reads != 0, \"a RwLock may not be created with 0 readers\"));\n```",
"path": "tokio/src/sync/rwlock.rs",
"hunk": "@@ -371,6 +372,7 @@ impl<T: ?Sized> RwLock<T> {\n where\n T: Sized,\n {\n+ assert!(max_reads != 0);",
"resolving_s... | true | ||
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
/// # Panics
///
/// Panics if `max_reads` is `0` or is bigger than `u32::MAX >> 3`
#[cfg(not(all(loom, test)))]
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/src/sync/rwlock.rs b/tokio/src/sync/rwlock.rs
index d94b6514306..b6bf7faca9a 100644
--- a/tokio/src/sync/rwlock.rs
+++ b/tokio/src/sync/rwlock.rs
@@ -266,12 +266,13 @@ impl<T: ?Sized> RwLock<T> {
///
/// # Panics
///
- /// Panics if `max_reads` is more than `u32::MAX >> 3`.
+ ///... | [
"tokio/src/sync/rwlock.rs"
] | [
{
"comment": "```suggestion\n /// # Panics\n ///\n /// Panics if `max_reads` is `0` or is bigger than `u32::MAX >> 3`\n #[cfg(not(all(loom, test)))]\n```",
"path": "tokio/src/sync/rwlock.rs",
"hunk": "",
"resolving_sha": "586201858bdfa0f25ee1626bed9f8f4595159bc6",
"resolving_diff": "... | true | ||
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
#[should_panic(expected = "a RwLock may not be created with 0 readers")]
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/tests/sync_rwlock.rs b/tokio/tests/sync_rwlock.rs
index 5a58b4971b9..2dc7b0a62ac 100644
--- a/tokio/tests/sync_rwlock.rs
+++ b/tokio/tests/sync_rwlock.rs
@@ -78,6 +78,18 @@ fn exhaust_reading() {
let _g1 = assert_ready!(t1.poll());
}
+#[test]
+#[should_panic(expected = "a RwLock may not be cr... | [
"tokio/tests/sync_rwlock.rs"
] | [
{
"comment": "```suggestion\n#[should_panic(expected = \"a RwLock may not be created with 0 readers\")]\n```",
"path": "tokio/tests/sync_rwlock.rs",
"hunk": "@@ -78,6 +78,18 @@ fn exhaust_reading() {\n let _g1 = assert_ready!(t1.poll());\n }\n \n+#[test]\n+#[should_panic]",
"resolving_sha": "586... | true | ||
tokio-rs/tokio | 8,076 | comment_to_fix | Require that an `RwLock` has `max_readers != 0` | ```suggestion
#[should_panic(expected = "a RwLock may not be created with 0 readers")]
``` | 670a907c55c7f7b27da203208e65da60de6598b2 | 586201858bdfa0f25ee1626bed9f8f4595159bc6 | diff --git a/tokio/tests/sync_rwlock.rs b/tokio/tests/sync_rwlock.rs
index 5a58b4971b9..2dc7b0a62ac 100644
--- a/tokio/tests/sync_rwlock.rs
+++ b/tokio/tests/sync_rwlock.rs
@@ -78,6 +78,18 @@ fn exhaust_reading() {
let _g1 = assert_ready!(t1.poll());
}
+#[test]
+#[should_panic(expected = "a RwLock may not be cr... | [
"tokio/tests/sync_rwlock.rs"
] | [
{
"comment": "```suggestion\n#[should_panic(expected = \"a RwLock may not be created with 0 readers\")]\n```",
"path": "tokio/tests/sync_rwlock.rs",
"hunk": "@@ -78,6 +78,18 @@ fn exhaust_reading() {\n let _g1 = assert_ready!(t1.poll());\n }\n \n+#[test]\n+#[should_panic]\n+fn zero_max_readers() {\n... | true | ||
tokio-rs/tokio | 8,075 | issue_to_patch | Notify receivers in mpsc channel `OwnedPermit::release()` method | The `OwnedPermit::release()` method is missing a check for whether the receiver should be woken up. This results in lost wakeups when combined with `Receiver::close()`.
This bug was discovered by asking Gemini to look for bugs in the `release` method of `tokio/src/sync/mpsc/bounded.rs`.
| 670a907c55c7f7b27da203208e65da60de6598b2 | 855f2f17979b27874e05f1bb0b83d8f262dbe452 | diff --git a/tokio/src/sync/mpsc/bounded.rs b/tokio/src/sync/mpsc/bounded.rs
index 06eeffc3f09..f7b0081c652 100644
--- a/tokio/src/sync/mpsc/bounded.rs
+++ b/tokio/src/sync/mpsc/bounded.rs
@@ -1844,14 +1844,12 @@ impl<T> OwnedPermit<T> {
///
/// [`Sender`]: Sender
pub fn release(mut self) -> Sender<T> {
... | [
"tokio/src/sync/mpsc/bounded.rs",
"tokio/tests/sync_mpsc.rs"
] | [
{
"comment": "[tx.is_closed()](https://github.com/tokio-rs/tokio/blob/d1db1a93045d3be4e040b63a4654b70cd27fee2e/tokio/src/sync/mpsc/bounded.rs#L1068-L1070) returns `true` here.\nThe test name `dropping_last_permit_closes_channel` suggests that the channel is still open until line 800.",
"path": "tokio/tests/... | diff --git a/tokio/tests/sync_mpsc.rs b/tokio/tests/sync_mpsc.rs
index 048b94eb533..41bdd45da1e 100644
--- a/tokio/tests/sync_mpsc.rs
+++ b/tokio/tests/sync_mpsc.rs
@@ -788,6 +788,91 @@ async fn drop_permit_iterator_releases_permits() {
}
}
+#[test]
+fn dropping_last_permit_wakes_closed_receiver() {
+ let (t... | true | |
tokio-rs/tokio | 8,075 | comment_to_fix | Notify receivers in mpsc channel `OwnedPermit::release()` method | [tx.is_closed()](https://github.com/tokio-rs/tokio/blob/d1db1a93045d3be4e040b63a4654b70cd27fee2e/tokio/src/sync/mpsc/bounded.rs#L1068-L1070) returns `true` here.
The test name `dropping_last_permit_closes_channel` suggests that the channel is still open until line 800. | 670a907c55c7f7b27da203208e65da60de6598b2 | 855f2f17979b27874e05f1bb0b83d8f262dbe452 | diff --git a/tokio/tests/sync_mpsc.rs b/tokio/tests/sync_mpsc.rs
index 048b94eb533..41bdd45da1e 100644
--- a/tokio/tests/sync_mpsc.rs
+++ b/tokio/tests/sync_mpsc.rs
@@ -788,6 +788,91 @@ async fn drop_permit_iterator_releases_permits() {
}
}
+#[test]
+fn dropping_last_permit_wakes_closed_receiver() {
+ let (t... | [
"tokio/tests/sync_mpsc.rs"
] | [
{
"comment": "[tx.is_closed()](https://github.com/tokio-rs/tokio/blob/d1db1a93045d3be4e040b63a4654b70cd27fee2e/tokio/src/sync/mpsc/bounded.rs#L1068-L1070) returns `true` here.\nThe test name `dropping_last_permit_closes_channel` suggests that the channel is still open until line 800.",
"path": "tokio/tests/... | true | ||
tokio-rs/tokio | 8,074 | issue_to_patch | Return `Empty` from `try_recv()` when channel is closed but there are outstanding permits | The `Receiver::try_recv()` method is missing a check for whether there are remaining permits. This results in `TryPopError::Disconnected` when messages can still be sent.
This bug was discovered by asking Gemini to look for bugs in the `close` method of `tokio/src/sync/mpsc/chan.rs`.
| 670a907c55c7f7b27da203208e65da60de6598b2 | 490125dcdd508bef0a1b7437ce840f8bdae4c127 | diff --git a/tokio/src/sync/mpsc/chan.rs b/tokio/src/sync/mpsc/chan.rs
index 7f7f8b16dc7..f9a72de60b0 100644
--- a/tokio/src/sync/mpsc/chan.rs
+++ b/tokio/src/sync/mpsc/chan.rs
@@ -436,7 +436,9 @@ impl<T, S: Semaphore> Rx<T, S> {
}
TryPopResult::Closed => return Err(Try... | [
"tokio/src/sync/mpsc/chan.rs",
"tokio/tests/sync_mpsc.rs"
] | [] | diff --git a/tokio/tests/sync_mpsc.rs b/tokio/tests/sync_mpsc.rs
index 048b94eb533..27157288e25 100644
--- a/tokio/tests/sync_mpsc.rs
+++ b/tokio/tests/sync_mpsc.rs
@@ -999,6 +999,19 @@ fn try_recv_after_receiver_close() {
assert_eq!(Err(TryRecvError::Disconnected), rx.try_recv());
}
+#[test]
+fn try_recv_after... | true | |
tokio-rs/tokio | 8,062 | issue_to_patch | Panic in subtraction with overflow in tokio/src/sync/mpsc/list.rs
Since updating to Tokio 1.51.1 in Wasmtime's CI we've been seening spurious panics in debug mode on [this line of code](https://github.com/tokio-rs/tokio/blob/905c146aeda741ea2202f942a7c3a606dda13da5/tokio/src/sync/mpsc/list.rs#L278). Bisection original... | sync: fix underflow in mpsc channel `len()` | Fixes: #8061 | 670a907c55c7f7b27da203208e65da60de6598b2 | c207675890e089994b0af8463afeca39017b0ed2 | diff --git a/tokio/src/sync/mpsc/block.rs b/tokio/src/sync/mpsc/block.rs
index 927c4566463..7d7e59afd18 100644
--- a/tokio/src/sync/mpsc/block.rs
+++ b/tokio/src/sync/mpsc/block.rs
@@ -211,11 +211,6 @@ impl<T> Block<T> {
self.header.ready_slots.fetch_or(TX_CLOSED, Release);
}
- pub(crate) unsafe fn i... | [
"tokio/src/sync/mpsc/block.rs",
"tokio/src/sync/mpsc/list.rs",
"tokio/src/sync/mpsc/mod.rs",
"tokio/src/sync/tests/loom_mpsc.rs"
] | [
{
"comment": "I realized that we should also be using wrapping arithmetic for the position indices. On 32-bit machines these indices can wrap around after a few billion messages.",
"path": "tokio/src/sync/mpsc/list.rs",
"hunk": "@@ -272,10 +268,24 @@ impl<T> Rx<T> {\n }\n \n pub(crate) fn len(&s... | diff --git a/tokio/src/sync/tests/loom_mpsc.rs b/tokio/src/sync/tests/loom_mpsc.rs
index 039b87a7734..3e6c847988b 100644
--- a/tokio/src/sync/tests/loom_mpsc.rs
+++ b/tokio/src/sync/tests/loom_mpsc.rs
@@ -1,4 +1,4 @@
-use crate::sync::mpsc;
+use crate::sync::mpsc::{self, BLOCK_CAP};
use loom::future::block_on;
use ... | true |
tokio-rs/tokio | 8,062 | comment_to_fix | sync: fix underflow in mpsc channel `len()` | Should we add a safety comment here? | 670a907c55c7f7b27da203208e65da60de6598b2 | c207675890e089994b0af8463afeca39017b0ed2 | diff --git a/tokio/src/sync/mpsc/list.rs b/tokio/src/sync/mpsc/list.rs
index 118bac85633..1f3d2383906 100644
--- a/tokio/src/sync/mpsc/list.rs
+++ b/tokio/src/sync/mpsc/list.rs
@@ -224,15 +224,6 @@ impl<T> Tx<T> {
let _ = Box::from_raw(block.as_ptr());
}
}
-
- pub(crate) fn is_closed(&self... | [
"tokio/src/sync/mpsc/list.rs"
] | [
{
"comment": "Should we add a safety comment here?",
"path": "tokio/src/sync/mpsc/list.rs",
"hunk": "@@ -99,6 +99,11 @@ impl<T> Tx<T> {\n unsafe { block.as_ref().tx_close() }\n }\n \n+ fn has_value(&self, slot_index: usize) -> bool {\n+ let block = unsafe { self.find_block(slot_ind... | true | ||
tokio-rs/tokio | 8,062 | comment_to_fix | sync: fix underflow in mpsc channel `len()` | Is it possible another thread to advance the `block_tail` between line 271 (`tail_position.load()`) and line 285 (`tx.has_value()`) ?
If this happens `tx.has_value()` may enter an infinite loop calling `block.grow()` in `find_block()`. | 670a907c55c7f7b27da203208e65da60de6598b2 | c207675890e089994b0af8463afeca39017b0ed2 | diff --git a/tokio/src/sync/mpsc/list.rs b/tokio/src/sync/mpsc/list.rs
index 118bac85633..1f3d2383906 100644
--- a/tokio/src/sync/mpsc/list.rs
+++ b/tokio/src/sync/mpsc/list.rs
@@ -224,15 +224,6 @@ impl<T> Tx<T> {
let _ = Box::from_raw(block.as_ptr());
}
}
-
- pub(crate) fn is_closed(&self... | [
"tokio/src/sync/mpsc/list.rs"
] | [
{
"comment": "Is it possible another thread to advance the `block_tail` between line 271 (`tail_position.load()`) and line 285 (`tx.has_value()`) ?\nIf this happens `tx.has_value()` may enter an infinite loop calling `block.grow()` in `find_block()`.",
"path": "tokio/src/sync/mpsc/list.rs",
"hunk": "@@ ... | true | ||
tokio-rs/tokio | 8,110 | issue_to_patch | Provide a way to check if CancellationToken are the same
**Is your feature request related to a problem? Please describe.**
I want to check if the `CancellationToken` are the same one in the following code to catch a bug:
```rust
impl<'a> Drop for ApiGuard<'a> {
fn drop(&mut self) {
let s = match self
... | sync: implement `PartialEq` and `Eq` for `CancellationToken` | ## Motivation
#8087 requests for a way to check if two `CancellationToken`s are equal/the same.
## Solution
Implementations for `PartialEq` and `Eq` were added to `CancellationToken` to check, whether two tokens point to the same tree node of the cancellation tree. With this two tokens are considered equal if canc... | e77885a494d91baaaeeb9590436e555dea8dd1cb | 876754b536e95a8df3fd071339d5a8d3ae9a0317 | diff --git a/tokio-util/src/sync/cancellation_token.rs b/tokio-util/src/sync/cancellation_token.rs
index 1b397c2bbc2..46c270a405c 100644
--- a/tokio-util/src/sync/cancellation_token.rs
+++ b/tokio-util/src/sync/cancellation_token.rs
@@ -122,6 +122,26 @@ impl Clone for CancellationToken {
}
}
+impl PartialEq for... | [
"tokio-util/src/sync/cancellation_token.rs",
"tokio-util/tests/sync_cancellation_token.rs"
] | [
{
"comment": "It would be nice if this section mentioned that parent/child relationships return false.",
"path": "tokio-util/src/sync/cancellation_token.rs",
"hunk": "@@ -122,6 +122,18 @@ impl Clone for CancellationToken {\n }\n }\n \n+impl PartialEq for CancellationToken {\n+ /// Checks if two t... | diff --git a/tokio-util/tests/sync_cancellation_token.rs b/tokio-util/tests/sync_cancellation_token.rs
index 995890171b7..4a1f1f093c4 100644
--- a/tokio-util/tests/sync_cancellation_token.rs
+++ b/tokio-util/tests/sync_cancellation_token.rs
@@ -5,8 +5,10 @@ use tokio::sync::oneshot;
use tokio_util::sync::{Cancellation... | true |
tokio-rs/tokio | 8,110 | comment_to_fix | sync: implement `PartialEq` and `Eq` for `CancellationToken` | It would be nice if this section mentioned that parent/child relationships return false. | e77885a494d91baaaeeb9590436e555dea8dd1cb | 876754b536e95a8df3fd071339d5a8d3ae9a0317 | diff --git a/tokio-util/src/sync/cancellation_token.rs b/tokio-util/src/sync/cancellation_token.rs
index 1b397c2bbc2..46c270a405c 100644
--- a/tokio-util/src/sync/cancellation_token.rs
+++ b/tokio-util/src/sync/cancellation_token.rs
@@ -122,6 +122,26 @@ impl Clone for CancellationToken {
}
}
+impl PartialEq for... | [
"tokio-util/src/sync/cancellation_token.rs"
] | [
{
"comment": "It would be nice if this section mentioned that parent/child relationships return false.",
"path": "tokio-util/src/sync/cancellation_token.rs",
"hunk": "@@ -122,6 +122,18 @@ impl Clone for CancellationToken {\n }\n }\n \n+impl PartialEq for CancellationToken {\n+ /// Checks if two t... | true | ||
tokio-rs/tokio | 8,117 | issue_to_patch | Merge 'tokio-1.52.2' into 'master' | Must be merged with the commandline. | e77885a494d91baaaeeb9590436e555dea8dd1cb | e56ff72fe7574867c6c9bbd171afd8717897ea43 | diff --git a/README.md b/README.md
index 567c7332dbd..657a5f3f4c0 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.52.1", features = ["full"] }
+tokio = { version = "1.52.2", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md",
"tokio/src/runtime/builder.rs",
"tokio/src/runtime/config.rs",
"tokio/src/runtime/mod.rs",
"tokio/src/runtime/scheduler/multi_thread/queue.rs",
"tokio/src/runtime/scheduler/multi_thread/worker.rs",
"tokio/src/runtime/task/at... | [] | diff --git a/tokio/src/runtime/tests/loom_multi_thread/queue.rs b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
index 2098b548a2b..0d818283653 100644
--- a/tokio/src/runtime/tests/loom_multi_thread/queue.rs
+++ b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
@@ -62,65 +62,6 @@ fn basic() {
});
}
-// L... | true | |
tokio-rs/tokio | 8,115 | issue_to_patch | chore: prepare Tokio v1.52.2 | # 1.52.2 (May 4th, 2026)
This release reverts the LIFO slot stealing change introduced in 1.51.0 ([#7431]), due to [its performance impact][#8065]. ([#8100])
[#7431]: https://github.com/tokio-rs/tokio/pull/7431
[#8065]: https://github.com/tokio-rs/tokio/pull/8065
[#8100]: https://github.com/tokio-rs/tokio/pull/... | f82bcf3f45eb9d0dad9d7e45251adf67223f03b6 | 76c813feb38d36b717afb787cdfe28e179cea09e | diff --git a/README.md b/README.md
index 567c7332dbd..657a5f3f4c0 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.52.1", features = ["full"] }
+tokio = { version = "1.52.2", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md"
] | [] | true | ||
tokio-rs/tokio | 8,114 | issue_to_patch | Merge 'tokio-1.51.2' into 'tokio-1.52.x' | Must be merged on the command-line with a merge commit.
```
* commit f82bcf3f
|\ Merge: 7db9bc41 64834ec7
| | Author: Alice Ryhl <aliceryhl@google.com>
| | Date: Mon May 4 12:16:30 2026 +0200
| |
| | Merge 'tokio-1.51.2' into 'tokio-1.52.x' (#8114)
| |
| * commit 64834ec7 (tag: tokio-1.51.2, tokio-1... | 9271e3ed05928eafbeed9dd31d93aebaa49d2aad | f82bcf3f45eb9d0dad9d7e45251adf67223f03b6 | diff --git a/tokio/CHANGELOG.md b/tokio/CHANGELOG.md
index 50df159d649..d9a2da4a9dc 100644
--- a/tokio/CHANGELOG.md
+++ b/tokio/CHANGELOG.md
@@ -50,6 +50,14 @@
[#8035]: https://github.com/tokio-rs/tokio/pull/8035
[#8040]: https://github.com/tokio-rs/tokio/pull/8040
+# 1.51.2 (May 4th, 2026)
+
+This release reverts ... | [
"tokio/CHANGELOG.md",
"tokio/src/runtime/builder.rs",
"tokio/src/runtime/config.rs",
"tokio/src/runtime/mod.rs",
"tokio/src/runtime/scheduler/multi_thread/queue.rs",
"tokio/src/runtime/scheduler/multi_thread/worker.rs",
"tokio/src/runtime/task/atomic_notified.rs",
"tokio/src/runtime/task/mod.rs",
"t... | [] | diff --git a/tokio/src/runtime/tests/loom_multi_thread/queue.rs b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
index 2098b548a2b..0d818283653 100644
--- a/tokio/src/runtime/tests/loom_multi_thread/queue.rs
+++ b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
@@ -62,65 +62,6 @@ fn basic() {
});
}
-// L... | true | |
tokio-rs/tokio | 8,113 | issue_to_patch | chore: prepare Tokio v1.51.2 | # 1.51.2 (May 4th, 2026)
This release reverts the LIFO slot stealing change introduced in 1.51.0 ([#7431]), due to [its performance impact][#8065]. ([#8100])
[#7431]: https://github.com/tokio-rs/tokio/pull/7431
[#8065]: https://github.com/tokio-rs/tokio/pull/8065
[#8100]: https://github.com/tokio-rs/tokio/pull/... | 967f5715a71d5d2600b71da8c4ab652c4e644a41 | 011c38f5656353bcbfb168b8235a0b776c24a031 | diff --git a/README.md b/README.md
index 1e4454b7072..a45c812c132 100644
--- a/README.md
+++ b/README.md
@@ -60,7 +60,7 @@ Make sure you enable the full features of the tokio crate on Cargo.toml:
```toml
[dependencies]
-tokio = { version = "1.51.1", features = ["full"] }
+tokio = { version = "1.51.2", features = ["... | [
"README.md",
"tokio/CHANGELOG.md",
"tokio/Cargo.toml",
"tokio/README.md"
] | [
{
"comment": "```suggestion\nThis release reverts the LIFO slot stealing change introduced in 1.51.0 ([#7431]), due to [its\n```",
"path": "tokio/CHANGELOG.md",
"hunk": "@@ -1,3 +1,11 @@\n+# 1.51.2 (May 4th, 2026)\n+\n+This release reverts the LIFO slot stealing change ([#7431]), due to [its",
"reso... | true | ||
tokio-rs/tokio | 8,113 | comment_to_fix | chore: prepare Tokio v1.51.2 | ```suggestion
This release reverts the LIFO slot stealing change introduced in 1.51.0 ([#7431]), due to [its
``` | 967f5715a71d5d2600b71da8c4ab652c4e644a41 | 011c38f5656353bcbfb168b8235a0b776c24a031 | diff --git a/tokio/CHANGELOG.md b/tokio/CHANGELOG.md
index 1b446fef062..6131728700a 100644
--- a/tokio/CHANGELOG.md
+++ b/tokio/CHANGELOG.md
@@ -1,3 +1,11 @@
+# 1.51.2 (May 4th, 2026)
+
+This release reverts the LIFO slot stealing change introduced in 1.51.0
+([#7431]), due to [its performance impact][#8065]. ([#8100])... | [
"tokio/CHANGELOG.md"
] | [
{
"comment": "```suggestion\nThis release reverts the LIFO slot stealing change introduced in 1.51.0 ([#7431]), due to [its\n```",
"path": "tokio/CHANGELOG.md",
"hunk": "@@ -1,3 +1,11 @@\n+# 1.51.2 (May 4th, 2026)\n+\n+This release reverts the LIFO slot stealing change ([#7431]), due to [its",
"reso... | true | ||
tokio-rs/tokio | 8,100 | issue_to_patch | Performance regression on high-QPS short-handler workloads since 1.51.0
## Summary
Since Tokio `1.51.0` ([#7431](https://github.com/tokio-rs/tokio/pull/7431), "runtime: steal tasks from the LIFO slot"), `schedule_local` on the multi-thread scheduler unconditionally calls `notify_parked_local()` whenever a parked work... | Revert stealing of tasks from the LIFO slot | Fixes: https://github.com/tokio-rs/tokio/issues/8065 | a97cf12ed9b90e3d5c1557f3afb47f43fcb84301 | b818328f1b7fb37750317344a72599af22665eca | diff --git a/tokio/src/runtime/builder.rs b/tokio/src/runtime/builder.rs
index 62f183b5c44..04f7efff057 100644
--- a/tokio/src/runtime/builder.rs
+++ b/tokio/src/runtime/builder.rs
@@ -1257,21 +1257,22 @@ impl Builder {
/// scheduled task being polled first.
///
/// To implement this heuristi... | [
"tokio/src/runtime/builder.rs",
"tokio/src/runtime/config.rs",
"tokio/src/runtime/mod.rs",
"tokio/src/runtime/scheduler/multi_thread/queue.rs",
"tokio/src/runtime/scheduler/multi_thread/worker.rs",
"tokio/src/runtime/task/atomic_notified.rs",
"tokio/src/runtime/task/mod.rs",
"tokio/src/runtime/tests/l... | [] | diff --git a/tokio/src/runtime/tests/loom_multi_thread/queue.rs b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
index 2098b548a2b..0d818283653 100644
--- a/tokio/src/runtime/tests/loom_multi_thread/queue.rs
+++ b/tokio/src/runtime/tests/loom_multi_thread/queue.rs
@@ -62,65 +62,6 @@ fn basic() {
});
}
-// L... | true |
tokio-rs/tokio | 8,086 | issue_to_patch | Add PID to UCred on remaining platforms
Implement `pid` on windows for `UCred`. See #3085 and #2633.
What other platforms are missing?
cc @de-vri-es, @Kloenk | net: implement UCred::pid on FreeBSD | ## Motivation
`UCred::pid()` returns `None` on FreeBSD even though the kernel exposes the peer PID via `LOCAL_PEERCRED`.
## Solution
Read `xucred.cr_pid` (added in FreeBSD 13) via `getsockopt(LOCAL_PEERCRED)`. The DragonFly path is split into its own module since DragonFly's `xucred` has no PID field. The `UCr... | 89713ad1eccdab8c21137a37f996f130d5a8bd31 | abf38af4010489d800e4cdf1fdc5ca63255de280 | diff --git a/spellcheck.dic b/spellcheck.dic
index 0cf8ae850f5..ea6ab93ae81 100644
--- a/spellcheck.dic
+++ b/spellcheck.dic
@@ -1,4 +1,4 @@
-316
+323
&
+
<
@@ -189,14 +189,17 @@ mutex
Mutex
Nagle
namespace
+NetBSD
nonblocking
nondecreasing
noop
ntasks
+NTO
NUMA
ok
oneshot
opcode
+OpenBSD
ORed
os
parke... | [
"spellcheck.dic",
"tokio/src/net/unix/ucred.rs",
"tokio/tests/uds_cred.rs"
] | [
{
"comment": "If `ret == 0`, i.e. `len` is not `size_of::<xucred>()` then `io::Error::last_os_error()` might be wrong.\n\nI think this needs to be split into two separate checks:\n1) `if ret != 0 { return Err(io::Error::last_os_error()); }`\n2) `if len as usize != size_of::<xucred>() { return Err(io::Error::new... | diff --git a/tokio/tests/uds_cred.rs b/tokio/tests/uds_cred.rs
index 4f08d764e26..7da49b4550b 100644
--- a/tokio/tests/uds_cred.rs
+++ b/tokio/tests/uds_cred.rs
@@ -23,4 +23,35 @@ async fn test_socket_pair() {
assert_eq!(cred_a.uid(), uid);
assert_eq!(cred_a.gid(), gid);
+
+ // On platforms where `UCred:... | true |
tokio-rs/tokio | 8,086 | comment_to_fix | net: implement UCred::pid on FreeBSD | If `ret == 0`, i.e. `len` is not `size_of::<xucred>()` then `io::Error::last_os_error()` might be wrong.
I think this needs to be split into two separate checks:
1) `if ret != 0 { return Err(io::Error::last_os_error()); }`
2) `if len as usize != size_of::<xucred>() { return Err(io::Error::new(io::ErrorKind::InvalidDat... | 89713ad1eccdab8c21137a37f996f130d5a8bd31 | abf38af4010489d800e4cdf1fdc5ca63255de280 | diff --git a/tokio/src/net/unix/ucred.rs b/tokio/src/net/unix/ucred.rs
index f77befb0624..a268bad1b10 100644
--- a/tokio/src/net/unix/ucred.rs
+++ b/tokio/src/net/unix/ucred.rs
@@ -24,8 +24,10 @@ impl UCred {
/// Gets PID (process ID) of the process.
///
- /// This is only implemented under Linux, Androi... | [
"tokio/src/net/unix/ucred.rs"
] | [
{
"comment": "If `ret == 0`, i.e. `len` is not `size_of::<xucred>()` then `io::Error::last_os_error()` might be wrong.\n\nI think this needs to be split into two separate checks:\n1) `if ret != 0 { return Err(io::Error::last_os_error()); }`\n2) `if len as usize != size_of::<xucred>() { return Err(io::Error::new... | true | ||
tokio-rs/tokio | 8,086 | comment_to_fix | net: implement UCred::pid on FreeBSD | What about FreeBSD 12 ? Is it supported ?
Should `cr_pid == 0` be treated as `None` ? | 89713ad1eccdab8c21137a37f996f130d5a8bd31 | abf38af4010489d800e4cdf1fdc5ca63255de280 | diff --git a/tokio/src/net/unix/ucred.rs b/tokio/src/net/unix/ucred.rs
index f77befb0624..a268bad1b10 100644
--- a/tokio/src/net/unix/ucred.rs
+++ b/tokio/src/net/unix/ucred.rs
@@ -24,8 +24,10 @@ impl UCred {
/// Gets PID (process ID) of the process.
///
- /// This is only implemented under Linux, Androi... | [
"tokio/src/net/unix/ucred.rs"
] | [
{
"comment": "What about FreeBSD 12 ? Is it supported ?\nShould `cr_pid == 0` be treated as `None` ?",
"path": "tokio/src/net/unix/ucred.rs",
"hunk": "@@ -203,6 +208,59 @@ pub(crate) mod impl_bsd {\n }\n }\n \n+#[cfg(target_os = \"freebsd\")]\n+pub(crate) mod impl_freebsd {\n+ use crate::net::uni... | true | ||
tokio-rs/tokio | 8,107 | issue_to_patch | time: defer waker clone on spurious poll | The alternative Timer eagerly cloned the incoming waker instead of
checking whether it is equal to the current waker.
| 1cd6e65d76ba934d7545afe4b8ad93787b80c1e3 | 3c7f47a0d3032352775fce620566417dc45efce4 | diff --git a/tokio/src/runtime/time_alt/entry.rs b/tokio/src/runtime/time_alt/entry.rs
index b7b5627e0b1..f9a4746b8fe 100644
--- a/tokio/src/runtime/time_alt/entry.rs
+++ b/tokio/src/runtime/time_alt/entry.rs
@@ -228,11 +228,16 @@ impl Handle {
}
}
- pub(crate) fn register_waker(&self, waker: Waker) ... | [
"tokio/src/runtime/time_alt/entry.rs",
"tokio/src/runtime/time_alt/timer.rs"
] | [
{
"comment": "The `waker.clone()` is a tricky part. The `Clone` might be implemented by user code, so it might panic, this is the reason I clone the waker unconditionally outside of the `register_waker`.\r\n\r\nSo there is a trade-off I made before: avoding possible panic (in the tokio runtime) from user code a... | true | ||
tokio-rs/tokio | 8,107 | comment_to_fix | time: defer waker clone on spurious poll | The `waker.clone()` is a tricky part. The `Clone` might be implemented by user code, so it might panic, this is the reason I clone the waker unconditionally outside of the `register_waker`.
So there is a trade-off I made before: avoding possible panic (in the tokio runtime) from user code at the expense of the perfo... | 1cd6e65d76ba934d7545afe4b8ad93787b80c1e3 | 3c7f47a0d3032352775fce620566417dc45efce4 | diff --git a/tokio/src/runtime/time_alt/entry.rs b/tokio/src/runtime/time_alt/entry.rs
index b7b5627e0b1..f9a4746b8fe 100644
--- a/tokio/src/runtime/time_alt/entry.rs
+++ b/tokio/src/runtime/time_alt/entry.rs
@@ -228,11 +228,16 @@ impl Handle {
}
}
- pub(crate) fn register_waker(&self, waker: Waker) ... | [
"tokio/src/runtime/time_alt/entry.rs"
] | [
{
"comment": "The `waker.clone()` is a tricky part. The `Clone` might be implemented by user code, so it might panic, this is the reason I clone the waker unconditionally outside of the `register_waker`.\r\n\r\nSo there is a trade-off I made before: avoding possible panic (in the tokio runtime) from user code a... | true | ||
tokio-rs/tokio | 8,078 | issue_to_patch | Avoid illegal state in `FastRand` | Since `tokio/src/util/rand/rt.rs` calls `from_pair()` with two random numbers, it is possible that `rt.rs` will create an rng with seed zero. However, the seed zero is not allowed because the Xorshift64+ algorithm produces zeroes indefinitely for this seed. The `from_seed()` method was also adjusted to check both integ... | 1afb39135073a56d8983fed0bde85b9f70a1ec3b | 1744df2c9a1ed7299dcc924f199119683c56c3d4 | diff --git a/tokio/src/util/rand.rs b/tokio/src/util/rand.rs
index 67c45693c9c..efd23515423 100644
--- a/tokio/src/util/rand.rs
+++ b/tokio/src/util/rand.rs
@@ -39,18 +39,17 @@ impl RngSeed {
fn from_u64(seed: u64) -> Self {
let one = (seed >> 32) as u32;
- let mut two = seed as u32;
-
- i... | [
"tokio/src/util/rand.rs"
] | [] | true | ||
tokio-rs/tokio | 8,102 | issue_to_patch | ci: minor improvements for freeBSD jobs | Remove leftover io-uring reference and rename the step on freeBSD docs job | 5ee26af3dbd606ce91adfcdfcd917ab73e6350f6 | 0c62d9c848f860940828629266f8fc54fce58df1 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c1573eb3321..e8585e67835 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1323,7 +1323,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- - name: Test in FreeBSD
+ - name: Build ... | [
".github/workflows/ci.yml"
] | [
{
"comment": "This change will land in master when https://github.com/tokio-rs/tokio/pull/8101 merges into master.",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -1324,22 +1324,21 @@ jobs:\n runs-on: ubuntu-latest\n steps:\n - uses: actions/checkout@v6\n- - name: Test in FreeBSD\n+... | true | ||
tokio-rs/tokio | 8,106 | issue_to_patch | Merge CI fixes into master | 5030b3005eae09141d6ee6725366007c767b9a97 | 5ee26af3dbd606ce91adfcdfcd917ab73e6350f6 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f6d7acd15ea..c1573eb3321 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1314,8 +1314,7 @@ jobs:
# Enable all unstable features except `io_uring` and `taskdump`,
# which are Linux-only features.
... | [
".github/workflows/ci.yml"
] | [] | true | |||
traefik/traefik | 13,343 | issue_to_patch | Increase timeout for Docker image sync job to 30 minutes | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | 2391520b50b086cc4cd9d0e0bbd09b900c722224 | b63728daba845954056c1577b637b6261d87f8b0 | diff --git a/.github/workflows/sync-docker-images.yaml b/.github/workflows/sync-docker-images.yaml
index 2dcf4aab5d..003a1d751a 100644
--- a/.github/workflows/sync-docker-images.yaml
+++ b/.github/workflows/sync-docker-images.yaml
@@ -8,7 +8,7 @@ on:
jobs:
sync:
runs-on: ubuntu-latest
- timeout-minutes: 15
... | [
".github/workflows/sync-docker-images.yaml"
] | [] | true | ||
traefik/traefik | 13,356 | issue_to_patch | Add missing Gateway API features in conformance tests | ### What does this PR do?
Adds a few missing features in the Gateway API conformance tests that we already support.
### Motivation
Green check marks.
### More
- [x] Added/updated tests
- [ ] Added/updated documentation | b46e795f41e9aa02b25f1ab4eef4907a766c15c1 | f4713eab2e28308be4447728691fdc9453ade7ba | diff --git a/integration/fixtures/gateway-api-conformance/02-traefik.yml b/integration/fixtures/gateway-api-conformance/02-traefik.yml
index c03c7d8528..157a51c745 100644
--- a/integration/fixtures/gateway-api-conformance/02-traefik.yml
+++ b/integration/fixtures/gateway-api-conformance/02-traefik.yml
@@ -49,6 +49,7 @@... | [
"integration/fixtures/gateway-api-conformance/02-traefik.yml",
"integration/gateway-api-conformance-reports/v1.4.0/experimental-v3.6-default-report.yaml",
"pkg/provider/kubernetes/gateway/features.go"
] | [] | true | ||
traefik/traefik | 12,914 | issue_to_patch | X-Forwarded-Scheme: https and X-Scheme: https headers
### Welcome!
- [x] Yes, I've searched similar issues on [GitHub](https://github.com/traefik/traefik/issues) and didn't find any.
- [x] Yes, I've searched similar issues on the [Traefik community forum](https://community.traefik.io) and didn't find any.
### What ... | Add optional X-Forwarded-Scheme and X-Scheme headers in forwarded headers middleware | ### What does this PR do?
Adds optional support for emitting the legacy `X-Forwarded-Scheme` and `X-Scheme` headers from Traefik's core forwarded headers middleware at the entrypoint level.
When `entryPoints.<name>.forwardedHeaders.addXForwardedSchemeHeaders=true` is enabled, Traefik sets these compatibility head... | 6cc3dd8d409e8d758382ea1ee57c896743a203b6 | a07ee73538ea612fa65e919deda68f13c3d1721f | diff --git a/docs/content/migrate/nginx-to-traefik.md b/docs/content/migrate/nginx-to-traefik.md
index 79499038ba..a8d5833996 100644
--- a/docs/content/migrate/nginx-to-traefik.md
+++ b/docs/content/migrate/nginx-to-traefik.md
@@ -93,6 +93,12 @@ For a complete list of supported annotations and behavioral differences, s... | [
"docs/content/migrate/nginx-to-traefik.md",
"docs/content/reference/install-configuration/configuration-options.md",
"docs/content/reference/install-configuration/entrypoints.md",
"docs/content/reference/routing-configuration/kubernetes/ingress-nginx.md",
"docs/content/reference/static-configuration/file.to... | [
{
"comment": "XForwardedProto is always set before (L153-171), so this condition is unnecessary.",
"path": "pkg/middlewares/forwardedheaders/forwarded_header.go",
"hunk": "@@ -168,6 +174,14 @@ func (x *XForwarded) rewrite(outreq *http.Request) {\n \t\tunsafeHeader(outreq.Header).Set(XForwardedPort, forw... | diff --git a/pkg/middlewares/forwardedheaders/forwarded_header_test.go b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
index 57f33caed4..273ba27041 100644
--- a/pkg/middlewares/forwardedheaders/forwarded_header_test.go
+++ b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
@@ -17,12 +17,14 @@ func ... | true |
traefik/traefik | 12,914 | comment_to_fix | Add optional X-Forwarded-Scheme and X-Scheme headers in forwarded headers middleware | XForwardedProto is always set before (L153-171), so this condition is unnecessary. | 6cc3dd8d409e8d758382ea1ee57c896743a203b6 | a07ee73538ea612fa65e919deda68f13c3d1721f | diff --git a/pkg/middlewares/forwardedheaders/forwarded_header.go b/pkg/middlewares/forwardedheaders/forwarded_header.go
index 48187d5ef0..b4c2f19e86 100644
--- a/pkg/middlewares/forwardedheaders/forwarded_header.go
+++ b/pkg/middlewares/forwardedheaders/forwarded_header.go
@@ -18,12 +18,14 @@ const (
XForwardedFor ... | [
"pkg/middlewares/forwardedheaders/forwarded_header.go"
] | [
{
"comment": "XForwardedProto is always set before (L153-171), so this condition is unnecessary.",
"path": "pkg/middlewares/forwardedheaders/forwarded_header.go",
"hunk": "@@ -168,6 +174,14 @@ func (x *XForwarded) rewrite(outreq *http.Request) {\n \t\tunsafeHeader(outreq.Header).Set(XForwardedPort, forw... | true | ||
traefik/traefik | 12,914 | comment_to_fix | Add optional X-Forwarded-Scheme and X-Scheme headers in forwarded headers middleware | ```suggestion
desc: "xForwardedScheme headers overwrite in insecure mode",
``` | 6cc3dd8d409e8d758382ea1ee57c896743a203b6 | a07ee73538ea612fa65e919deda68f13c3d1721f | diff --git a/pkg/middlewares/forwardedheaders/forwarded_header_test.go b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
index 57f33caed4..273ba27041 100644
--- a/pkg/middlewares/forwardedheaders/forwarded_header_test.go
+++ b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
@@ -17,12 +17,14 @@ func ... | [
"pkg/middlewares/forwardedheaders/forwarded_header_test.go"
] | [
{
"comment": "```suggestion\n\t\t\tdesc: \"xForwardedScheme headers overwrite in insecure mode\",\n```",
"path": "pkg/middlewares/forwardedheaders/forwarded_header_test.go",
"hunk": "@@ -257,6 +289,21 @@ func TestServeHTTP(t *testing.T) {\n \t\t\t\tXForwardedProto: \"wss\",\n \t\t\t},\n \t\t... | true | ||
traefik/traefik | 12,914 | comment_to_fix | Add optional X-Forwarded-Scheme and X-Scheme headers in forwarded headers middleware | The tests only iterates over `expectedHeaders` and checks values, it never asserts that unlisted headers are absent.
Could you add a test that verifies that if `addSchemeHeaders` is false, the `xForwardedScheme` and `xScheme` are not present? | 6cc3dd8d409e8d758382ea1ee57c896743a203b6 | a07ee73538ea612fa65e919deda68f13c3d1721f | diff --git a/pkg/middlewares/forwardedheaders/forwarded_header_test.go b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
index 57f33caed4..273ba27041 100644
--- a/pkg/middlewares/forwardedheaders/forwarded_header_test.go
+++ b/pkg/middlewares/forwardedheaders/forwarded_header_test.go
@@ -17,12 +17,14 @@ func ... | [
"pkg/middlewares/forwardedheaders/forwarded_header_test.go"
] | [
{
"comment": "The tests only iterates over `expectedHeaders` and checks values, it never asserts that unlisted headers are absent. \nCould you add a test that verifies that if `addSchemeHeaders` is false, the `xForwardedScheme` and `xScheme` are not present?",
"path": "pkg/middlewares/forwardedheaders/forwa... | true | ||
traefik/traefik | 12,914 | comment_to_fix | Add optional X-Forwarded-Scheme and X-Scheme headers in forwarded headers middleware | There is also an error on the CI related to this file. Could you run `make generate` to fix this? | 6cc3dd8d409e8d758382ea1ee57c896743a203b6 | a07ee73538ea612fa65e919deda68f13c3d1721f | diff --git a/docs/content/reference/install-configuration/configuration-options.md b/docs/content/reference/install-configuration/configuration-options.md
index 4f5ea989c4..f8643681c4 100644
--- a/docs/content/reference/install-configuration/configuration-options.md
+++ b/docs/content/reference/install-configuration/co... | [
"docs/content/reference/install-configuration/configuration-options.md"
] | [
{
"comment": "There is also an error on the CI related to this file. Could you run `make generate` to fix this?",
"path": "docs/content/reference/install-configuration/configuration-options.md",
"hunk": "",
"resolving_sha": "a07ee73538ea612fa65e919deda68f13c3d1721f",
"resolving_diff": "diff --gi... | true | ||
traefik/traefik | 12,920 | issue_to_patch | Feature Request: Support reporting Node Internal IPs for Ingress status (bare-metal Kubernetes)
### Welcome!
- [x] Yes, I've searched similar issues on [GitHub](https://github.com/traefik/traefik/issues) and didn't find any.
- [x] Yes, I've searched similar issues on the [Traefik community forum](https://community.tr... | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | ### What does this PR do?
Adds a `reportNodeInternalIPs` option to the Kubernetes Ingress provider that populates the `status.loadBalancer.ingress` field of each managed Ingress resource with the internal IPs of all cluster nodes. This is the equivalent of ingress-nginx's `--report-node-internal-ip-address` flag, in... | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/docs/content/reference/install-configuration/configuration-options.md b/docs/content/reference/install-configuration/configuration-options.md
index 1076f643fe..4f5ea989c4 100644
--- a/docs/content/reference/install-configuration/configuration-options.md
+++ b/docs/content/reference/install-configuration/co... | [
"docs/content/reference/install-configuration/configuration-options.md",
"docs/content/reference/install-configuration/providers/kubernetes/kubernetes-ingress.md",
"pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml",
"pkg/provider/kubernetes/ingress/kubernetes.go",
"pkg/provider/kubernetes/ingre... | [
{
"comment": "```suggestion\n\t\tif len(nodes) == 0 {\n```\n\nI think this condition can be simplified. ",
"path": "pkg/provider/kubernetes/ingress/kubernetes.go",
"hunk": "@@ -406,6 +415,34 @@ func (p *Provider) loadConfigurationFromIngresses(ctx context.Context, client Cl\n }\n \n func (p *Provider) u... | diff --git a/pkg/provider/kubernetes/ingress/kubernetes_test.go b/pkg/provider/kubernetes/ingress/kubernetes_test.go
index 8adcf6d7a1..7c6a036a62 100644
--- a/pkg/provider/kubernetes/ingress/kubernetes_test.go
+++ b/pkg/provider/kubernetes/ingress/kubernetes_test.go
@@ -3094,6 +3094,77 @@ func readResources(t *testing.... | true |
traefik/traefik | 12,920 | comment_to_fix | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | ```suggestion
if len(nodes) == 0 {
```
I think this condition can be simplified. | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/pkg/provider/kubernetes/ingress/kubernetes.go b/pkg/provider/kubernetes/ingress/kubernetes.go
index 439941dd76..1e55adb9b7 100644
--- a/pkg/provider/kubernetes/ingress/kubernetes.go
+++ b/pkg/provider/kubernetes/ingress/kubernetes.go
@@ -48,6 +48,7 @@ type Provider struct {
LabelSelector stri... | [
"pkg/provider/kubernetes/ingress/kubernetes.go"
] | [
{
"comment": "```suggestion\n\t\tif len(nodes) == 0 {\n```\n\nI think this condition can be simplified. ",
"path": "pkg/provider/kubernetes/ingress/kubernetes.go",
"hunk": "@@ -406,6 +415,34 @@ func (p *Provider) loadConfigurationFromIngresses(ctx context.Context, client Cl\n }\n \n func (p *Provider) u... | true | ||
traefik/traefik | 12,920 | comment_to_fix | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | ```suggestion
name: service1-abc
namespace: default
``` | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml b/pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml
new file mode 100644
index 0000000000..8067837284
--- /dev/null
+++ b/pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml
@@ -0,0 +1,75 @@
+---
+kind: Node
+apiVersion: v1... | [
"pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml"
] | [
{
"comment": "```suggestion\n name: service1-abc\n namespace: default\n```",
"path": "pkg/provider/kubernetes/ingress/fixtures/Node-Internal-IP.yml",
"hunk": "@@ -0,0 +1,74 @@\n+---\n+kind: Node\n+apiVersion: v1\n+metadata:\n+ name: node1\n+\n+status:\n+ addresses:\n+ - type: InternalIP\n+ a... | true | ||
traefik/traefik | 12,920 | comment_to_fix | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | This test doesn't need testcases. | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/pkg/provider/kubernetes/ingress/kubernetes_test.go b/pkg/provider/kubernetes/ingress/kubernetes_test.go
index 8adcf6d7a1..7c6a036a62 100644
--- a/pkg/provider/kubernetes/ingress/kubernetes_test.go
+++ b/pkg/provider/kubernetes/ingress/kubernetes_test.go
@@ -3094,6 +3094,77 @@ func readResources(t *testing.... | [
"pkg/provider/kubernetes/ingress/kubernetes_test.go"
] | [
{
"comment": "This test doesn't need testcases.",
"path": "pkg/provider/kubernetes/ingress/kubernetes_test.go",
"hunk": "@@ -2379,6 +2379,114 @@ func readResources(t *testing.T, paths []string) []runtime.Object {\n \treturn k8sObjects\n }\n \n+func TestProviderInit(t *testing.T) {\n+\tp := Provider{\n+\... | true | ||
traefik/traefik | 12,920 | comment_to_fix | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | ```suggestion
``` | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/pkg/provider/kubernetes/ingress/kubernetes_test.go b/pkg/provider/kubernetes/ingress/kubernetes_test.go
index 8adcf6d7a1..7c6a036a62 100644
--- a/pkg/provider/kubernetes/ingress/kubernetes_test.go
+++ b/pkg/provider/kubernetes/ingress/kubernetes_test.go
@@ -3094,6 +3094,77 @@ func readResources(t *testing.... | [
"pkg/provider/kubernetes/ingress/kubernetes_test.go"
] | [
{
"comment": "```suggestion\n```",
"path": "pkg/provider/kubernetes/ingress/kubernetes_test.go",
"hunk": "@@ -3069,6 +3069,100 @@ func readResources(t *testing.T, paths []string) []runtime.Object {\n \treturn k8sObjects\n }\n \n+func TestProviderInit(t *testing.T) {\n+\tp := Provider{\n+\t\tReportNodeIn... | true | ||
traefik/traefik | 12,920 | comment_to_fix | Add reportNodeInternalIPs option to report node internal IPs in Ingress status | WDYT of moving the `ingressStatus[]` compilation out of `updateIngressStatus` and computing it once before the ingress loop? That way we avoid recalculating it per ingress, and the result can be passed in as a parameter. | bcf768ee09004261569afcedf72dc9742955ae4e | daa59c40ebede551a091c63cc7f3bf5fcc859f4a | diff --git a/pkg/provider/kubernetes/ingress/kubernetes.go b/pkg/provider/kubernetes/ingress/kubernetes.go
index 439941dd76..1e55adb9b7 100644
--- a/pkg/provider/kubernetes/ingress/kubernetes.go
+++ b/pkg/provider/kubernetes/ingress/kubernetes.go
@@ -48,6 +48,7 @@ type Provider struct {
LabelSelector stri... | [
"pkg/provider/kubernetes/ingress/kubernetes.go"
] | [
{
"comment": "WDYT of moving the `ingressStatus[]` compilation out of `updateIngressStatus` and computing it once before the ingress loop? That way we avoid recalculating it per ingress, and the result can be passed in as a parameter.",
"path": "pkg/provider/kubernetes/ingress/kubernetes.go",
"hunk": "@... | true | ||
traefik/traefik | 13,344 | issue_to_patch | fix x-forwarded-port in forward-auth | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | ad1c1fc2f20c0dcb24df59685afedbf83c8232ec | d5b8d13a0c028b56aad7e5f42de08b0f24c00e52 | diff --git a/pkg/middlewares/auth/forward.go b/pkg/middlewares/auth/forward.go
index 5917182ae5..4c890d3c24 100644
--- a/pkg/middlewares/auth/forward.go
+++ b/pkg/middlewares/auth/forward.go
@@ -270,7 +270,7 @@ func writeHeader(req, forwardReq *http.Request, trustForwardHeader bool, allowed
}
if _, ok := forwardR... | [
"pkg/middlewares/auth/forward.go",
"pkg/middlewares/auth/forward_test.go"
] | [] | diff --git a/pkg/middlewares/auth/forward_test.go b/pkg/middlewares/auth/forward_test.go
index 9196166420..6a1a45fbf3 100644
--- a/pkg/middlewares/auth/forward_test.go
+++ b/pkg/middlewares/auth/forward_test.go
@@ -456,6 +456,21 @@ func TestForwardAuth_writeHeader(t *testing.T) {
"X-Forwarded-Port": "80",
},... | true | |
traefik/traefik | 13,342 | issue_to_patch | Clarify intentional auth-response-headers gating and absence of stripping incoming X-Forwarded-* headers | ### What does this PR do?
Adds in-code documentation comments at the two ForwardAuth identity-propagation explaining that the auth-response-headers gating is intentional.
It also adds a comment about intentional absence of stripping incoming X-Forwarded-* headers in the Ingress NGINX ForwardAuth middleware.
### ... | 26c96a3935cafb473f4a5bae1886560d9aa4e4f0 | 7d5ccdfbbd7c01d2e271c01de4e77f4a233f8ca4 | diff --git a/pkg/middlewares/auth/forward.go b/pkg/middlewares/auth/forward.go
index 90b77785a9..d7d51b2472 100644
--- a/pkg/middlewares/auth/forward.go
+++ b/pkg/middlewares/auth/forward.go
@@ -301,6 +301,12 @@ func (fa *forwardAuth) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
return
}
+ // Only the ... | [
"pkg/middlewares/auth/forward.go",
"pkg/middlewares/ingressnginx/snippet/snippet.go"
] | [] | true | ||
traefik/traefik | 13,327 | issue_to_patch | Update Gateway API statuses once routing config is built | ### What does this PR do?
This pull request changes when the Gateway API statuses are published to the cluster.
Instead of publishing the statuses on the go while building the routing configuration, we're now publishing them all at once after the configuration has been sent to the aggregator.
### Motivation
T... | 51b9a376154cebe7d8d26988fd60eb69799d881d | 63b3be5681c3a3c41a1b9f37715509fb7d46d797 | diff --git a/pkg/provider/kubernetes/gateway/client.go b/pkg/provider/kubernetes/gateway/client.go
index 34d15d5724..56b5ffec2d 100644
--- a/pkg/provider/kubernetes/gateway/client.go
+++ b/pkg/provider/kubernetes/gateway/client.go
@@ -727,14 +727,6 @@ func (c *clientWrapper) UpdateBackendTLSPolicyStatus(ctx context.Con... | [
"pkg/provider/kubernetes/gateway/client.go",
"pkg/provider/kubernetes/gateway/grpcroute.go",
"pkg/provider/kubernetes/gateway/httproute.go",
"pkg/provider/kubernetes/gateway/kubernetes.go",
"pkg/provider/kubernetes/gateway/kubernetes_test.go",
"pkg/provider/kubernetes/gateway/status.go",
"pkg/provider/k... | [] | diff --git a/pkg/provider/kubernetes/gateway/kubernetes_test.go b/pkg/provider/kubernetes/gateway/kubernetes_test.go
index 37aef0a097..a2d0cc8952 100644
--- a/pkg/provider/kubernetes/gateway/kubernetes_test.go
+++ b/pkg/provider/kubernetes/gateway/kubernetes_test.go
@@ -95,7 +95,10 @@ func TestGatewayClassLabelSelector... | true | |
traefik/traefik | 13,340 | issue_to_patch | Merge branch v3.7 into master | ### What does this PR do?
Merge branch v3.7 into master
### Motivation
To be up to date.
### More
- ~[ ] Added/updated tests~
- ~[ ] Added/updated documentation~
### Additional Notes
<!-- Anything else we should know when reviewing? -->
| e0439822446baa7c002287f5f5a33d95918b4019 | 51b9a376154cebe7d8d26988fd60eb69799d881d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83301e2565..c57cd5eaba 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,30 @@
+## [v3.7.5](https://github.com/traefik/traefik/tree/v3.7.5) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v3.7.4...v3.7.5)
+
+**Bug fixes:**
+- **[k8s/ingress-ngi... | [
"CHANGELOG.md",
"go.mod",
"go.sum",
"integration/fixtures/https/https_tls_options_conflict.toml",
"integration/https_test.go",
"integration/simple_test.go",
"pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml",
"pkg/provider/kubernetes/gateway/fixtures/tcproute/invalid_cross... | [] | diff --git a/integration/https_test.go b/integration/https_test.go
index e962337e67..7821219ad0 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -415,7 +415,7 @@ func (s *HTTPSSuite) TestWithConflictingTLSOptions() {
assert.ErrorContains(s.T(), err, "tls: no supported versions satisfy MinVers... | true | |
traefik/traefik | 13,339 | issue_to_patch | Prepare release v3.7.5 | ### What does this PR do?
Prepare release v3.7.5
aka `langres`
### Motivation
To create a new release.
### More
- [ ] ~Added/updated tests~
- [x] Added/updated documentation
### Additional Notes
| cb9e8ab510fc9220c9639d04f80303b4969185ba | 0d3f2eb9a8d4789f7181918fe33bd34d608d2106 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8d134b8fa0..c57cd5eaba 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## [v3.7.5](https://github.com/traefik/traefik/tree/v3.7.5) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v3.7.4...v3.7.5)
+
+**Bug fixes:**
+- **[k8s/ingress-ngi... | [
"CHANGELOG.md",
"script/gcg/traefik-bugfix.toml"
] | [] | true | ||
traefik/traefik | 12,105 | issue_to_patch | Format HTTP headers as code | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3: use branch v3.5
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3: use branch v3.5
Enhancements:
- use branch master
HOW TO WRITE A GOOD PULL REQUEST? https://do... | 5ab001b55b867d0065ae05099490690a514f95d3 | dbba6af4d61005c1f471e5d5762a110e0d680fcd | diff --git a/docs/content/getting-started/faq.md b/docs/content/getting-started/faq.md
index 66f2d4d046..83622b8966 100644
--- a/docs/content/getting-started/faq.md
+++ b/docs/content/getting-started/faq.md
@@ -147,13 +147,13 @@ for example, by using the `touch` command on the configuration file.
By default, the fol... | [
"docs/content/getting-started/faq.md",
"docs/content/middlewares/http/forwardauth.md",
"docs/content/middlewares/http/inflightreq.md",
"docs/content/middlewares/http/ipallowlist.md",
"docs/content/middlewares/http/ipwhitelist.md",
"docs/content/middlewares/http/ratelimit.md",
"docs/content/middlewares/h... | [] | true | ||
traefik/traefik | 13,338 | issue_to_patch | Merge branch v3.6 into v3.7 | ### What does this PR do?
Merge branch v3.6 into v3.7
### Motivation
To be up to date
### More
- ~[ ] Added/updated tests~
- ~[ ] Added/updated documentation~
### Additional Notes
<!-- Anything else we should know when reviewing? -->
| d5ad3eb63bd1f539eb5c41d9d760b1eaf614c550 | cb9e8ab510fc9220c9639d04f80303b4969185ba | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83301e2565..8d134b8fa0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,19 @@
+## [v3.6.21](https://github.com/traefik/traefik/tree/v3.6.21) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v3.6.20...v3.6.21)
+
+**Bug fixes:**
+- **[k8s/gateway... | [
"CHANGELOG.md",
"go.mod",
"go.sum",
"integration/fixtures/https/https_tls_options_conflict.toml",
"integration/https_test.go",
"integration/simple_test.go",
"pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml",
"pkg/provider/kubernetes/gateway/fixtures/tcproute/invalid_cross... | [] | diff --git a/integration/https_test.go b/integration/https_test.go
index e962337e67..7821219ad0 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -415,7 +415,7 @@ func (s *HTTPSSuite) TestWithConflictingTLSOptions() {
assert.ErrorContains(s.T(), err, "tls: no supported versions satisfy MinVers... | true | |
traefik/traefik | 13,337 | issue_to_patch | Prepare release v3.6.21 | ### What does this PR do?
Prepare release v3.6.21
aka `ramequin`
### Motivation
To create a new release.
### More
- [ ] ~Added/updated tests~
- [x] Added/updated documentation
### Additional Notes
| e53a37b869c181e9a9a6280c760bed159e49da9d | 257cfd9a1755052dcae275e0ce6aafa67ddd148c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 41e9f2b3dd..a2fd39f257 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,12 @@
+## [v3.6.21](https://github.com/traefik/traefik/tree/v3.6.21) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v3.6.20...v3.6.21)
+
+**Bug fixes:**
+- **[k8s/gateway... | [
"CHANGELOG.md",
"script/gcg/traefik-bugfix.toml"
] | [] | true | ||
traefik/traefik | 13,336 | issue_to_patch | Merge branch v2.11 into v3.6 | ### What does this PR do?
Merge current v2.11 into v3.6
### Motivation
To be up to date
### More
- ~[ ] Added/updated tests~
- ~[ ] Added/updated documentation~
### Additional Notes
<!-- Anything else we should know when reviewing? -->
| 149e62d6db59d10ea22a698e0823abd7acb1ff11 | e53a37b869c181e9a9a6280c760bed159e49da9d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 369b2989d1..41e9f2b3dd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## [v2.11.50](https://github.com/traefik/traefik/tree/v2.11.50) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v2.11.49...v2.11.50)
+
+**Bug fixes:**
+- **[tls]** ... | [
"CHANGELOG.md",
"integration/fixtures/https/https_tls_options_conflict.toml",
"integration/https_test.go",
"integration/simple_test.go",
"pkg/server/aggregator.go",
"pkg/server/aggregator_test.go",
"pkg/server/configurationwatcher.go",
"pkg/server/router/tcp/manager.go"
] | [] | diff --git a/integration/https_test.go b/integration/https_test.go
index d0e04c021d..3f8c5d059a 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -259,7 +259,6 @@ func (s *HTTPSSuite) TestWithTLSOptions() {
}
// TestWithConflictingTLSOptions checks that routers with same SNI but different TL... | true | |
traefik/traefik | 13,335 | issue_to_patch | Prepare release v2.11.50 | ### What does this PR do?
Prepare release v2.11.50.
aka `mimolette`
### Motivation
To create a new release.
### More
- [ ] Added/updated tests
- [x] Added/updated documentation | 0209f984eb950861e10fc9bf0af993cd54b494b5 | 02950859df6e70bbda0eefe9d77e04c1d723cdf4 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index b3b6e5402b..6f94d7dfb5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## [v2.11.50](https://github.com/traefik/traefik/tree/v2.11.50) (2026-06-10)
+[All Commits](https://github.com/traefik/traefik/compare/v2.11.49...v2.11.50)
+
+**Bug fixes:**
+- **[tls]** ... | [
"CHANGELOG.md",
"script/gcg/traefik-bugfix.toml"
] | [] | true | ||
traefik/traefik | 13,333 | issue_to_patch | Fix snicheck for routers with no hosts | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | 4ef4c09300f56fff7004f2962f6227e75360c4e2 | 5c84492d76550d8608e071781b45cca0f14f722a | diff --git a/pkg/server/aggregator.go b/pkg/server/aggregator.go
index 9397710411..ba88f8bfc5 100644
--- a/pkg/server/aggregator.go
+++ b/pkg/server/aggregator.go
@@ -150,9 +150,8 @@ func mergeConfiguration(configurations dynamic.Configurations, defaultEntryPoint
//
// A router keeps its original name, and its resolv... | [
"integration/https_test.go",
"integration/simple_test.go",
"pkg/server/aggregator.go",
"pkg/server/aggregator_test.go",
"pkg/server/router/tcp/manager.go"
] | [
{
"comment": "Two remarks on this condition:\n\n- `len(router.TLS.Options) > 0 && router.TLS.Options != traefiktls.DefaultTLSConfigName` re-derives what the first loop of `resolveHTTPTLSOptions` already computed into `ResolvedOptions`. Testing `router.TLS.ResolvedOptions != traefiktls.DefaultTLSConfigName` woul... | diff --git a/integration/https_test.go b/integration/https_test.go
index 66560a3a80..2a9075c17a 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -315,7 +315,7 @@ func (s *HTTPSSuite) TestWithConflictingTLSOptions() {
assert.ErrorContains(s.T(), err, "tls: no supported versions satisfy MinVers... | true | |
traefik/traefik | 13,333 | comment_to_fix | Fix snicheck for routers with no hosts | Two remarks on this condition:
- `len(router.TLS.Options) > 0 && router.TLS.Options != traefiktls.DefaultTLSConfigName` re-derives what the first loop of `resolveHTTPTLSOptions` already computed into `ResolvedOptions`. Testing `router.TLS.ResolvedOptions != traefiktls.DefaultTLSConfigName` would keep a single source o... | 4ef4c09300f56fff7004f2962f6227e75360c4e2 | 5c84492d76550d8608e071781b45cca0f14f722a | diff --git a/pkg/server/aggregator.go b/pkg/server/aggregator.go
index 9397710411..ba88f8bfc5 100644
--- a/pkg/server/aggregator.go
+++ b/pkg/server/aggregator.go
@@ -150,9 +150,8 @@ func mergeConfiguration(configurations dynamic.Configurations, defaultEntryPoint
//
// A router keeps its original name, and its resolv... | [
"pkg/server/aggregator.go"
] | [
{
"comment": "Two remarks on this condition:\n\n- `len(router.TLS.Options) > 0 && router.TLS.Options != traefiktls.DefaultTLSConfigName` re-derives what the first loop of `resolveHTTPTLSOptions` already computed into `ResolvedOptions`. Testing `router.TLS.ResolvedOptions != traefiktls.DefaultTLSConfigName` woul... | true | ||
traefik/traefik | 13,333 | comment_to_fix | Fix snicheck for routers with no hosts | Nit: the sentence reads "a dedicated copy is emitted, and named following this pattern" (double "and"), and it lost the mention that the copy gets its TLS options reset to the default ones, which is the actual point of the copy. Suggestion:
```suggestion
// entryPoint is removed from the router and a dedicated copy is... | 4ef4c09300f56fff7004f2962f6227e75360c4e2 | 5c84492d76550d8608e071781b45cca0f14f722a | diff --git a/pkg/server/aggregator.go b/pkg/server/aggregator.go
index 9397710411..ba88f8bfc5 100644
--- a/pkg/server/aggregator.go
+++ b/pkg/server/aggregator.go
@@ -150,9 +150,8 @@ func mergeConfiguration(configurations dynamic.Configurations, defaultEntryPoint
//
// A router keeps its original name, and its resolv... | [
"pkg/server/aggregator.go"
] | [
{
"comment": "Nit: the sentence reads \"a dedicated copy is emitted, and named following this pattern\" (double \"and\"), and it lost the mention that the copy gets its TLS options reset to the default ones, which is the actual point of the copy. Suggestion:\n\n```suggestion\n// entryPoint is removed from the r... | true | ||
traefik/traefik | 13,333 | comment_to_fix | Fix snicheck for routers with no hosts | Before #13291 this situation was logged at `Warn` level. The routers still serve traffic (with the default options), so this is a degraded-but-functional state rather than a failure. Is `Error` deliberate? Users alerting on error-level logs will start paging on a misconfiguration that used to be a warning. | 4ef4c09300f56fff7004f2962f6227e75360c4e2 | 5c84492d76550d8608e071781b45cca0f14f722a | diff --git a/pkg/server/aggregator.go b/pkg/server/aggregator.go
index 9397710411..ba88f8bfc5 100644
--- a/pkg/server/aggregator.go
+++ b/pkg/server/aggregator.go
@@ -150,9 +150,8 @@ func mergeConfiguration(configurations dynamic.Configurations, defaultEntryPoint
//
// A router keeps its original name, and its resolv... | [
"pkg/server/aggregator.go"
] | [
{
"comment": "Before #13291 this situation was logged at `Warn` level. The routers still serve traffic (with the default options), so this is a degraded-but-functional state rather than a failure. Is `Error` deliberate? Users alerting on error-level logs will start paging on a misconfiguration that used to be a... | true | ||
traefik/traefik | 13,333 | comment_to_fix | Fix snicheck for routers with no hosts | Nit: this covers `Options: ""`, but not an explicit `Options: "default"`, which goes through the other half of the condition. A second case (or a second router in this one) would pin that behavior down. | 4ef4c09300f56fff7004f2962f6227e75360c4e2 | 5c84492d76550d8608e071781b45cca0f14f722a | diff --git a/pkg/server/aggregator_test.go b/pkg/server/aggregator_test.go
index c0c24e1712..02ee3495cd 100644
--- a/pkg/server/aggregator_test.go
+++ b/pkg/server/aggregator_test.go
@@ -693,8 +693,8 @@ func Test_resolveHTTPTLSOptions(t *testing.T) {
"router-b@file": {EntryPoints: []string{"ep-a"}, Rule: "Host(`ex... | [
"pkg/server/aggregator_test.go"
] | [
{
"comment": "Nit: this covers `Options: \"\"`, but not an explicit `Options: \"default\"`, which goes through the other half of the condition. A second case (or a second router in this one) would pin that behavior down.",
"path": "pkg/server/aggregator_test.go",
"hunk": "@@ -716,22 +716,32 @@ func Test... | true | ||
traefik/traefik | 13,332 | issue_to_patch | Support BackendTLSPolicy for TLSRoute | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | dc4b6fe2c69b11e75d06f4d597a3c1d6c83a226c | 346fdc234c5baede61c494281f1fa3c2ce37f819 | diff --git a/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml b/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml
index 2e583101a5..aa4bbbfe4d 100644
--- a/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml
+++ b/pkg/provider/kuberne... | [
"pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml",
"pkg/provider/kubernetes/gateway/fixtures/tlsroute/with_backend_tls_policy.yml",
"pkg/provider/kubernetes/gateway/fixtures/tlsroute/with_backend_tls_policy_system.yml",
"pkg/provider/kubernetes/gateway/httproute.go",
"pkg/prov... | [
{
"comment": "```suggestion\n\t\t\t// When something went wrong during the loading of a ServersTransport,\n```",
"path": "pkg/provider/kubernetes/gateway/tlsroute.go",
"hunk": "@@ -304,8 +311,126 @@ func (p *Provider) loadTLSServers(namespace string, route *gatev1.TLSRoute, back\n \t\t}\n \t}\n \n+\tbac... | diff --git a/pkg/provider/kubernetes/gateway/kubernetes_test.go b/pkg/provider/kubernetes/gateway/kubernetes_test.go
index 6516289696..88535974fa 100644
--- a/pkg/provider/kubernetes/gateway/kubernetes_test.go
+++ b/pkg/provider/kubernetes/gateway/kubernetes_test.go
@@ -3579,6 +3579,8 @@ func TestLoadGRPCRoutes(t *test... | true | |
traefik/traefik | 13,332 | comment_to_fix | Support BackendTLSPolicy for TLSRoute | ```suggestion
// When something went wrong during the loading of a ServersTransport,
``` | dc4b6fe2c69b11e75d06f4d597a3c1d6c83a226c | 346fdc234c5baede61c494281f1fa3c2ce37f819 | diff --git a/pkg/provider/kubernetes/gateway/tlsroute.go b/pkg/provider/kubernetes/gateway/tlsroute.go
index 9b660d4492..c9d4f00402 100644
--- a/pkg/provider/kubernetes/gateway/tlsroute.go
+++ b/pkg/provider/kubernetes/gateway/tlsroute.go
@@ -5,12 +5,14 @@ import (
"fmt"
"net"
"regexp"
+ "slices"
"strconv"
"s... | [
"pkg/provider/kubernetes/gateway/tlsroute.go"
] | [
{
"comment": "```suggestion\n\t\t\t// When something went wrong during the loading of a ServersTransport,\n```",
"path": "pkg/provider/kubernetes/gateway/tlsroute.go",
"hunk": "@@ -304,8 +311,126 @@ func (p *Provider) loadTLSServers(namespace string, route *gatev1.TLSRoute, back\n \t\t}\n \t}\n \n+\tbac... | true | ||
traefik/traefik | 13,313 | issue_to_patch | Bump to github.com/pires/go-proxyproto v0.12.0 | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | 8447bfc71e971ed150d610d67ca261d64253695c | 4695e76b453ccbf469896f9940b1ab59cd11642d | diff --git a/go.mod b/go.mod
index 3b3ad05d83..e2184ad481 100644
--- a/go.mod
+++ b/go.mod
@@ -52,7 +52,7 @@ require (
github.com/moby/moby/api v1.54.1
github.com/moby/moby/client v0.4.0
github.com/patrickmn/go-cache v2.1.0+incompatible
- github.com/pires/go-proxyproto v0.8.1
+ github.com/pires/go-proxyproto v0.1... | [
"go.mod",
"go.sum"
] | [] | true | ||
traefik/traefik | 13,265 | issue_to_patch | GRPCRoute is not respecting BackendTLSPolicy
### Welcome!
- [x] Yes, I've searched similar issues on [GitHub](https://github.com/traefik/traefik/issues) and didn't find any.
- [x] Yes, I've searched similar issues on the [Traefik community forum](https://community.traefik.io) and didn't find any.
### What did you do... | Support Backend TLS policy for gRPC backends | ### What does this PR do?
Fixes gRPC backend TLS policy handling as described in #12176.
Ensures TLS policies are correctly applied when establishing connections to gRPC backends.
### Motivation
Currently, TLS policies configured for gRPC backends are not properly applied.
This PR addresses the issue rep... | 8773d7ead4b009c0b36a46e7f4c81e787edc3085 | c2703cda6a37c3127a9c996ed035ae651dce0d2f | diff --git a/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml b/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml
new file mode 100644
index 0000000000..2e583101a5
--- /dev/null
+++ b/pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.ym... | [
"pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy.yml",
"pkg/provider/kubernetes/gateway/fixtures/grpcroute/with_backend_tls_policy_system.yml",
"pkg/provider/kubernetes/gateway/grpcroute.go",
"pkg/provider/kubernetes/gateway/kubernetes_test.go"
] | [] | diff --git a/pkg/provider/kubernetes/gateway/kubernetes_test.go b/pkg/provider/kubernetes/gateway/kubernetes_test.go
index ccf623eb05..6516289696 100644
--- a/pkg/provider/kubernetes/gateway/kubernetes_test.go
+++ b/pkg/provider/kubernetes/gateway/kubernetes_test.go
@@ -3508,6 +3508,186 @@ func TestLoadHTTPRoutes_filte... | true |
traefik/traefik | 13,329 | issue_to_patch | Fix routers with same host, different tlsoptions on different entryPoint | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | ba8830fdef9ea6e9f0497b06128b36cf5d4a2760 | 662b7cb69e54d7555f7f173af011034632ad0c07 | diff --git a/integration/fixtures/https/https_tls_options_conflict.toml b/integration/fixtures/https/https_tls_options_conflict.toml
new file mode 100644
index 0000000000..1d01b7eaa8
--- /dev/null
+++ b/integration/fixtures/https/https_tls_options_conflict.toml
@@ -0,0 +1,101 @@
+[global]
+ checkNewVersion = false
+ ... | [
"integration/fixtures/https/https_tls_options_conflict.toml",
"integration/https_test.go",
"integration/simple_test.go",
"pkg/server/aggregator.go",
"pkg/server/aggregator_test.go",
"pkg/server/configurationwatcher.go"
] | [] | diff --git a/integration/https_test.go b/integration/https_test.go
index 2a79da18b3..66560a3a80 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -258,7 +258,6 @@ func (s *HTTPSSuite) TestWithTLSOptions() {
}
// TestWithConflictingTLSOptions checks that routers with same SNI but different TL... | true | |
traefik/traefik | 13,290 | issue_to_patch | Pass endpointslice fencing on ingress-nginx provider | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | 15ecff2bbd344e5a8c4e5ebb64a6a31179daf69b | 965daee8d005a58a0021f737e3824eb3f4f4322e | diff --git a/pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/ingress-with-endpoint-conditions.yml b/pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/ingress-with-endpoint-conditions.yml
new file mode 100644
index 0000000000..4def723e74
--- /dev/null
+++ b/pkg/provider/kubernetes/ingress-nginx/fixtures/... | [
"pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/ingress-with-endpoint-conditions.yml",
"pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go",
"pkg/provider/kubernetes/ingress-nginx/translator.go"
] | [] | diff --git a/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go b/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
index a594a84063..ed7acf3954 100644
--- a/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
+++ b/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
@@ -15687,6 +15687,102 @@ fun... | true | |
traefik/traefik | 13,322 | issue_to_patch | Reject cross-provider references with backendRefs.namespace | <!--
PLEASE READ THIS MESSAGE.
Documentation:
- for Traefik v2: use branch v2.11 (fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Bug:
- for Traefik v2: use branch v2.11 (security fixes only)
- for Traefik v3.6: use branch v3.6
- for Traefik v3.7: use branch v3.7
Enha... | 1137f1f8076b3bd7966464769e9a65a554e7e894 | 36b3c5ea8203a70cde7a2728049dec0bf3101b66 | diff --git a/pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml b/pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml
new file mode 100644
index 0000000000..55bb251d3c
--- /dev/null
+++ b/pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml
@... | [
"pkg/provider/kubernetes/gateway/fixtures/httproute/invalid_cross_provider.yml",
"pkg/provider/kubernetes/gateway/fixtures/tcproute/invalid_cross_provider.yml",
"pkg/provider/kubernetes/gateway/fixtures/tlsroute/invalid_cross_provider.yml",
"pkg/provider/kubernetes/gateway/httproute.go",
"pkg/provider/kuber... | [] | diff --git a/pkg/provider/kubernetes/gateway/kubernetes_test.go b/pkg/provider/kubernetes/gateway/kubernetes_test.go
index 3e6d08a88a..3fdad7bff7 100644
--- a/pkg/provider/kubernetes/gateway/kubernetes_test.go
+++ b/pkg/provider/kubernetes/gateway/kubernetes_test.go
@@ -8366,20 +8366,22 @@ func Test_isCrossProviderName... | true | |
traefik/traefik | 13,323 | issue_to_patch | Skip ingress when auth-secret resolution fails | ### What does this PR do?
This PR brings a fix to skip the ingress entirely instead of only skipping the middleware if the configured auth-secret could not be resolved.
### Motivation
To have the same behavior as ingress-nginx.
### More
- [x] Added/updated tests
- [ ] Added/updated documentation
... | 74b6408475ffbba8a8c02a0abd0ac7e608d72087 | 5312ca3a090801e42e6ec0aa7848dd543ffd15cb | diff --git a/pkg/provider/kubernetes/ingress-nginx/build.go b/pkg/provider/kubernetes/ingress-nginx/build.go
index e39e243b9f..c319f5cd85 100644
--- a/pkg/provider/kubernetes/ingress-nginx/build.go
+++ b/pkg/provider/kubernetes/ingress-nginx/build.go
@@ -415,11 +415,13 @@ func (p *Provider) build(ctx context.Context, i... | [
"pkg/provider/kubernetes/ingress-nginx/build.go",
"pkg/provider/kubernetes/ingress-nginx/fixtures/ingresses/ingress-with-basicauth-secret-missing.yml",
"pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go"
] | [] | diff --git a/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go b/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
index 981246150a..a594a84063 100644
--- a/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
+++ b/pkg/provider/kubernetes/ingress-nginx/kubernetes_test.go
@@ -1329,6 +1329,37 @@ func T... | true | |
traefik/traefik | 13,312 | issue_to_patch | Merge branch v3.7 into master | ### What does this PR do?
Merge branch v3.7 into master
### Motivation
To be up to date.
### More
- ~[ ] Added/updated tests~
- ~[ ] Added/updated documentation~
### Additional Notes
<!-- Anything else we should know when reviewing? -->
| 29406d42898547f1ffabd904f66af06c212740cf | 8773d7ead4b009c0b36a46e7f4c81e787edc3085 | diff --git a/.golangci.yml b/.golangci.yml
index 16688de6b1..1e7bac8be5 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -348,6 +348,9 @@ linters:
text: 'appendAssign: append result not assigned to the same slice'
linters:
- gocritic
+ - path: pkg/server/conncontext.go
+ linter... | [
".golangci.yml",
"CHANGELOG.md",
"docs/content/migrate/nginx-to-traefik.md",
"docs/content/migrate/v3.md",
"docs/content/reference/install-configuration/configuration-options.md",
"docs/content/reference/install-configuration/providers/kubernetes/kubernetes-gateway.md",
"docs/content/reference/routing-c... | [] | diff --git a/integration/https_test.go b/integration/https_test.go
index b9b64e8d67..e962337e67 100644
--- a/integration/https_test.go
+++ b/integration/https_test.go
@@ -13,6 +13,7 @@ import (
"time"
"github.com/BurntSushi/toml"
+ "github.com/quic-go/quic-go/http3"
"github.com/stretchr/testify/assert"
"githu... | true | |
traefik/traefik | 13,311 | issue_to_patch | Prepare release v3.7.4 | ### What does this PR do?
Prepare release v3.7.4
aka `langres`
### Motivation
To create a new release.
### More
- [ ] ~Added/updated tests~
- [x] Added/updated documentation
### Additional Notes
| 708aa38f3686a32cffa3c38a709b113b28649304 | eb3258724f6a3727dff560d9e9900dec5931ff69 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8224d33dfa..83301e2565 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## [v3.7.4](https://github.com/traefik/traefik/tree/v3.7.4) (2026-06-05)
+[All Commits](https://github.com/traefik/traefik/compare/v3.7.3...v3.7.4)
+
+**Bug fixes:**
+- **[middleware]** F... | [
"CHANGELOG.md",
"script/gcg/traefik-bugfix.toml"
] | [] | true | ||
traefik/traefik | 13,310 | issue_to_patch | Merge branch v3.6 into v3.7 | ### What does this PR do?
Merge branch v3.6 into v3.7
### Motivation
To be up to date
### More
- ~[ ] Added/updated tests~
- ~[ ] Added/updated documentation~
### Additional Notes
<!-- Anything else we should know when reviewing? -->
| 5ea71f1c3af049067a0b6d5afd97bad1cf1a0071 | 708aa38f3686a32cffa3c38a709b113b28649304 | diff --git a/.golangci.yml b/.golangci.yml
index 16688de6b1..1e7bac8be5 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -348,6 +348,9 @@ linters:
text: 'appendAssign: append result not assigned to the same slice'
linters:
- gocritic
+ - path: pkg/server/conncontext.go
+ linter... | [
".golangci.yml",
"CHANGELOG.md",
"go.mod",
"go.sum",
"pkg/middlewares/ratelimiter/redis_limiter.go",
"pkg/provider/kubernetes/gateway/client.go",
"pkg/provider/kubernetes/gateway/httproute.go",
"pkg/server/conncontext.go",
"pkg/server/conncontext_test.go",
"pkg/server/router/tcp/manager.go",
"pk... | [] | diff --git a/pkg/server/conncontext_test.go b/pkg/server/conncontext_test.go
new file mode 100644
index 0000000000..6160ea358e
--- /dev/null
+++ b/pkg/server/conncontext_test.go
@@ -0,0 +1,26 @@
+package server
+
+import (
+ "context"
+ "net"
+ "testing"
+
+ "github.com/stretchr/testify/require"
+)
+
+type keyTest stri... | true | |
traefik/traefik | 13,309 | issue_to_patch | Prepare release v3.6.20 | ### What does this PR do?
Prepare release v3.6.20
aka `ramequin`
### Motivation
To create a new release.
### More
- [ ] ~Added/updated tests~
- [x] Added/updated documentation
### Additional Notes
| 15c47f9cb457f2af735385dea986eed1acd3504e | adddfc3b1246ddf71caf7342653e345124570769 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4058426560..369b2989d1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## [v3.6.20](https://github.com/traefik/traefik/tree/v3.6.20) (2026-06-05)
+[All Commits](https://github.com/traefik/traefik/compare/v3.6.19...v3.6.20)
+
+**Bug fixes:**
+- **[middleware]... | [
"CHANGELOG.md",
"script/gcg/traefik-bugfix.toml"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.