repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
trekhleb/javascript-algorithms
628
issue_to_patch
Update README.es-ES.md
fixed an error on the marked line.
3038c77a8c59269d300a15b5925c22b7ec47a6f3
d1cc8fb3e2d48e333107f8bcfc0b67a0090efaa9
diff --git a/src/data-structures/linked-list/README.es-ES.md b/src/data-structures/linked-list/README.es-ES.md index 0a9ec6b3a2..62cda8d14a 100644 --- a/src/data-structures/linked-list/README.es-ES.md +++ b/src/data-structures/linked-list/README.es-ES.md @@ -7,10 +7,10 @@ _Lee este artรญculo en otros idiomas:_ [_Portug...
[ "src/data-structures/linked-list/README.es-ES.md" ]
[]
true
trekhleb/javascript-algorithms
637
issue_to_patch
fix error
cadee1405310b779e965738ff900d2864f40cc17
a3f8fcf08a80c9e8e439ae2a2728a0e5d2594eec
diff --git a/README.ru-RU.md b/README.ru-RU.md index 32f4b2f526..5b734a06a2 100644 --- a/README.ru-RU.md +++ b/README.ru-RU.md @@ -35,7 +35,7 @@ _ะงะธั‚ะฐั‚ัŒ ะฝะฐ ะดั€ัƒะณะธั… ัะทั‹ะบะฐั…:_ * `B` [ะ”ะฒัƒะฝะฐะฟั€ะฐะฒะปะตะฝะฝั‹ะน ัะฒัะทะฝั‹ะน ัะฟะธัะพะบ](src/data-structures/doubly-linked-list) * `B` [ะžั‡ะตั€ะตะดัŒ](src/data-structures/queue) * `B` [ะกั‚ะตะบ](src/data-s...
[ "README.ru-RU.md" ]
[]
true
trekhleb/javascript-algorithms
639
issue_to_patch
Fix: spacing word
fix: korean word
83357075c4698f487af733e6e0bf9567ba94c266
c0ddf3681caa917c59858eee47eb4680b19d1d4f
diff --git a/README.ko-KR.md b/README.ko-KR.md index 02f35d0250..6a0abe703f 100644 --- a/README.ko-KR.md +++ b/README.ko-KR.md @@ -5,7 +5,7 @@ ์ด ์ €์žฅ์†Œ์—๋Š” ๋งŽ์ด ์•Œ๋ ค์ง„ ์•Œ๊ณ ๋ฆฌ์ฆ˜ ๋ฐ ์ž๋ฃŒ ๊ตฌ์กฐ์˜ Javascript ๊ธฐ๋ฐ˜ ์˜ˆ์ œ๋ฅผ ๋‹ด๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. -๊ฐ ์•Œ๊ณ ๋ฆฌ์ฆ˜๊ณผ ์ž๋ฃŒ ๊ตฌ์กฐ์— ๋Œ€ํ•ด ์—ฐ๊ด€๋˜์–ด์žˆ๋Š” ์„ค๋ช…์ด README์— ์ž‘์„ฑ๋˜์–ด ์žˆ์œผ๋ฉฐ, +๊ฐ ์•Œ๊ณ ๋ฆฌ์ฆ˜๊ณผ ์ž๋ฃŒ ๊ตฌ์กฐ์— ๋Œ€ํ•ด ์—ฐ๊ด€๋˜์–ด ์žˆ๋Š” ์„ค๋ช…์ด README์— ์ž‘์„ฑ๋˜์–ด ์žˆ์œผ๋ฉฐ, ๋งํฌ๋ฅผ ํ†ตํ•ด ๋” ์ž์„ธํ•œ ์„ค๋ช…์„ ๋งŒ...
[ "README.ko-KR.md" ]
[]
true
trekhleb/javascript-algorithms
644
issue_to_patch
Add Korean translation.
translate README files to Korean. - src\data-structures\heap\README.ko-KR.md - src\data-structures\priority-queue\README.ko-KR.md - src\algorithms\graph\kruskal\README.ko-KR.md - src\algorithms\graph\dijkstra\README.ko-KR.md
677862540e12b2189f535ff237633c7e25f1afe0
1bcaf7e6ea3291a91d4e94d4d835f3392ce4aa7d
diff --git a/src/algorithms/graph/dijkstra/README.ko-KR.md b/src/algorithms/graph/dijkstra/README.ko-KR.md new file mode 100644 index 0000000000..e2595bbe23 --- /dev/null +++ b/src/algorithms/graph/dijkstra/README.ko-KR.md @@ -0,0 +1,16 @@ +# ๋‹ค์ต์ŠคํŠธ๋ผ ์•Œ๊ณ ๋ฆฌ์ฆ˜(Dijkstra's algorithm) + +๋‹ค์ต์ŠคํŠธ๋ผ ์•Œ๊ณ ๋ฆฌ์ฆ˜์€ ๋„๋กœ ๋„คํŠธ์›Œํฌ ๋“ฑ์„ ๋‚˜ํƒ€๋‚ผ ์ˆ˜ ์žˆ๋Š” ๊ทธ๋ž˜ํ”„์—์„œ ๋…ธ๋“œ ...
[ "src/algorithms/graph/dijkstra/README.ko-KR.md", "src/algorithms/graph/dijkstra/README.md", "src/algorithms/graph/kruskal/README.ko-KR.md", "src/algorithms/graph/kruskal/README.md", "src/data-structures/heap/README.ko-KR.md", "src/data-structures/priority-queue/README.ko-KR.md", "src/data-structures/pri...
[]
true
trpc/trpc
7,366
issue_to_patch
chore: fix duplicate "the" in unstable-core JSDoc comment
Removes a duplicate "the" in the JSDoc header of `packages/server/src/unstable-core-do-not-import.ts` ("the the glue" -> "the glue"). Comment-only change, no behavior impact. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Fixed a duplicated ...
c7360d4eb3c89c336468809a293e5cda4b302d4b
7c9ec53ced006da9816144c9ceb36090af6ff5fa
diff --git a/packages/server/src/unstable-core-do-not-import.ts b/packages/server/src/unstable-core-do-not-import.ts index 71ed69bec3f..dd9356b9fd2 100644 --- a/packages/server/src/unstable-core-do-not-import.ts +++ b/packages/server/src/unstable-core-do-not-import.ts @@ -3,7 +3,7 @@ * * This file is here to: * -...
[ "packages/server/src/unstable-core-do-not-import.ts" ]
[]
true
trpc/trpc
7,370
issue_to_patch
bug(tanstack-react-query): mutationOptions doesn't contain keyPrefix ### Provide environment information ``` System: OS: macOS 26.4.1 CPU: (12) arm64 Apple M3 Pro Memory: 129.14 MB / 36.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 24.4.1 - /Users/tmk/.local/share/mise/installs/node/24.4.1/bin/node npm: 11....
fix(tanstack-react-query): add prefix support for mutation options
Closes #7369 ## ๐ŸŽฏ Changes Add prefix parameter to mutation options to support key prefixing from proxy/context level. This allows mutation key prefixes to be defined at a higher level while still allowing per-mutation overrides. <!-- Note: once you create a Pull request, we will automatically fix auto-fixabl...
774b244ca97518b86489d7b3c02c5f7b5e0de3ee
664b98c0b36e6c26e903b912ef97531314d7b59c
diff --git a/packages/tanstack-react-query/src/internals/createOptionsProxy.ts b/packages/tanstack-react-query/src/internals/createOptionsProxy.ts index 7e0218962f0..e3c9506db21 100644 --- a/packages/tanstack-react-query/src/internals/createOptionsProxy.ts +++ b/packages/tanstack-react-query/src/internals/createOptions...
[ "packages/tanstack-react-query/src/internals/createOptionsProxy.ts", "packages/tanstack-react-query/src/internals/mutationOptions.ts", "packages/tanstack-react-query/test/mutationOptions.test.tsx" ]
[]
diff --git a/packages/tanstack-react-query/test/mutationOptions.test.tsx b/packages/tanstack-react-query/test/mutationOptions.test.tsx index e02f138e7af..76c82312619 100644 --- a/packages/tanstack-react-query/test/mutationOptions.test.tsx +++ b/packages/tanstack-react-query/test/mutationOptions.test.tsx @@ -216,5 +216,...
true
trpc/trpc
7,393
issue_to_patch
fix(ci): restore tests package version and pin Bun
## Summary - Reintroduce the `version` field for the private `@trpc/tests` workspace package. - Sync its pinned `@trpc/client` and `@trpc/server` dependencies to `11.17.0` so the manifest matches the current lockfile. - Pin the Bun E2E job to Bun `1.3.9` instead of `latest` while Bun `1.3.14` trips over existing `using...
23c723cfeaf07da28a52a5c35c3dcccf96a47578
183f11c7249f2419be430ef6c4f09bfe03820123
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index aea440af08e..62e48c59bb2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -227,7 +227,7 @@ jobs: - uses: oven-sh/setup-bun@v2 with: - bun-version: latest + bun-version: 1.3.9 ...
[ ".github/workflows/main.yml", "packages/tests/package.json" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index c9337412c7d..ec1fe93a080 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -1,5 +1,6 @@ { "name": "@trpc/tests", + "version": "11.17.0", "private": true, "scripts": { "lint": "eslint --cache .", @@ -...
true
trpc/trpc
7,350
issue_to_patch
chore: upgrade pnpm to 10.33.1
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Closes # ## ๐ŸŽฏ Changes - upgrade the monorepo's pnpm version pins to `10.33.1` - align shared/example GitHub workflows that explicitly install pnpm so CI uses the same version everywhere ## โœ… Checklist - [x] I have followed the steps listed in the [Contributing guide](https://git...
37917335d97f4799dc9924ca78b16e299388bdd0
ba979079a2133f49ee450570887192c592e31da1
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 78686b71a7e..aea440af08e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -78,7 +78,7 @@ jobs: fetch-depth: 0 - uses: ./.github/setup - - run: MUTE_REACT_ACT_WARNINGS=1 pnpm test -- --coverage ...
[ ".github/workflows/main.yml", "examples/next-prisma-starter/.github/workflows/main.yml", "examples/next-prisma-websockets-starter/.github/workflows/main.yml", "examples/next-prisma-websockets-starter/package.json", "examples/next-websockets-encoder/package.json", "package.json", "packages/openapi/src/cl...
[ { "comment": "do we need to pass this?", "path": ".github/setup/action.yml", "hunk": "@@ -4,6 +4,8 @@ runs:\n using: 'composite'\n steps:\n - uses: pnpm/action-setup@v5\n+ with:\n+ version: 10.33.1", "resolving_sha": "ba979079a2133f49ee450570887192c592e31da1", "resolving_diff...
diff --git a/packages/upgrade/test/transforms.test.ts b/packages/upgrade/test/transforms.test.ts index dd435ecb15a..37f442b1fe8 100644 --- a/packages/upgrade/test/transforms.test.ts +++ b/packages/upgrade/test/transforms.test.ts @@ -1,9 +1,8 @@ import { existsSync, readdirSync, readFileSync } from 'node:fs'; import {...
true
trpc/trpc
7,351
issue_to_patch
build: upgrade drizzle in next-sse-chat example
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Closes # ## ๐ŸŽฏ Changes Upgrade the `examples/next-sse-chat` Drizzle dependencies to the latest published releases and refresh the lockfile. Validated the upgrade by: - running the repo's main PR checks under Node 24 (`pnpm build`, `pnpm typecheck-packages`, `pnpm typecheck-www`, `...
60c89fc316524904e03394b606c184b8e3abed03
f090979feffa3124c03c84cfa097675c8cca0dbd
diff --git a/examples/next-sse-chat/package.json b/examples/next-sse-chat/package.json index 297622964d0..e75b597e2fe 100644 --- a/examples/next-sse-chat/package.json +++ b/examples/next-sse-chat/package.json @@ -23,7 +23,7 @@ "@trpc/server": "npm:@trpc/server", "class-variance-authority": "^0.7.0", "dat...
[ "examples/next-sse-chat/package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,358
issue_to_patch
chore(www): Add Legora to website logos
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Closes # ## ๐ŸŽฏ Changes - add the official Legora wordmark asset to `www/static/logos` so it appears in the website's "As used by" carousel via the existing generated company list ## โœ… Checklist - [x] I have followed the steps listed in the [Contributing guide](https://github.com/...
331db6d1948f97f55003573bdbb4b8031693eda5
8f8e5569193eacc8147a53b5c8fef9927c67dec8
diff --git a/www/static/logos/Legora.svg b/www/static/logos/Legora.svg new file mode 100644 index 00000000000..40c21c1e1aa --- /dev/null +++ b/www/static/logos/Legora.svg @@ -0,0 +1,3 @@ +<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 102 20" width="102" height="20"> + <path d="M35.589 18.574C38.025 18.574 39.75...
[ "www/static/logos/Legora.svg" ]
[]
true
trpc/trpc
7,340
issue_to_patch
docs: add trpc-studio to awesome-trpc extensions
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? Adds [@srawad/trpc-studio](https://www.npmjs.com/package/@srawad/trpc-studio) to the Extensions section. **What it does:** - Swagger-like developer UI for tRPC APIs - Auto-generated input forms from Zod schemas (inc...
2c5b6a8c6366c005508c0f481ad3ae344653a6f8
101a2a58bee6b40c4a3c796747367e20985d532b
diff --git a/www/docs/community/awesome-trpc.mdx b/www/docs/community/awesome-trpc.mdx index cf7063cda37..2e24b7060e1 100644 --- a/www/docs/community/awesome-trpc.mdx +++ b/www/docs/community/awesome-trpc.mdx @@ -17,24 +17,25 @@ A collection of resources on tRPC. ### Extensions -| Description ...
[ "www/docs/community/awesome-trpc.mdx" ]
[]
true
trpc/trpc
7,336
issue_to_patch
bug(server): handle React 19 proxy coercion in createInnerProxy ## Problem React 19 can introspect or coerce the proxy returned by `createInnerProxy()` and call `valueOf`, `toString`, or `toJSON` on it. In downstream apps, this can break the proxy at runtime unless those keys return a primitive-friendly function ins...
fix(server): handle React 19 proxy coercion in createInnerProxy
## Problem React 19 can coerce a proxy object to a primitive by calling `valueOf()`, `toString()`, or `toJSON()` on it โ€” for example during rendering, string interpolation, or console logging. When these methods are called on the proxy returned by `createInnerProxy()`, the current `get` trap simply returns *another pr...
c188dab0822caf3615199e4ac95147bc7560d26f
c8ca1b63fe9c3c958ced9d19bdfa1563306f1177
diff --git a/packages/server/src/unstable-core-do-not-import/createProxy.ts b/packages/server/src/unstable-core-do-not-import/createProxy.ts index f61edc53927..ec1c72782b9 100644 --- a/packages/server/src/unstable-core-do-not-import/createProxy.ts +++ b/packages/server/src/unstable-core-do-not-import/createProxy.ts @@ ...
[ "packages/server/src/unstable-core-do-not-import/createProxy.test.ts", "packages/server/src/unstable-core-do-not-import/createProxy.ts" ]
[ { "comment": "Special-casing `valueOf`/`toString`/`toJSON` in the `get` trap makes those path segments unchainable (e.g. a router/procedure named `toString` would no longer support `caller.toString.query()` because `toString` now returns a plain function). If you want to avoid this behavioral break while still ...
diff --git a/packages/server/src/unstable-core-do-not-import/createProxy.test.ts b/packages/server/src/unstable-core-do-not-import/createProxy.test.ts index 5af8899a625..48b49d5a91d 100644 --- a/packages/server/src/unstable-core-do-not-import/createProxy.test.ts +++ b/packages/server/src/unstable-core-do-not-import/cre...
true
trpc/trpc
7,306
issue_to_patch
chore(monorepo): remove versions from private workspaces
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Closes # ## ๐ŸŽฏ Changes Remove the redundant `version` field from private/non-published workspace packages. Update `scripts/version.ts` because it previously assumed every package in `packages/*` declared a local `version`. Once private workspaces like `@trpc/tests` stop carrying t...
cb17317f15654ee7bce1d34f737fee64a8babb43
c29a887bdc2ec59e6582663b6a2c5f91c185628f
diff --git a/examples/.experimental/next-app-dir/package.json b/examples/.experimental/next-app-dir/package.json index 215f2a87268..8d4abddfb77 100644 --- a/examples/.experimental/next-app-dir/package.json +++ b/examples/.experimental/next-app-dir/package.json @@ -38,6 +38,5 @@ "@playwright/test": "^1.50.1", ...
[ "examples/.experimental/next-app-dir/package.json", "examples/.test/diagnostics-big-router/package.json", "examples/.test/internal-types-export/package.json", "examples/.test/monotest-api-router01/package.json", "examples/.test/monotest-api/package.json", "examples/.test/monotest-app/package.json", "exa...
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 4ff4cad755e..c9337412c7d 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -36,6 +36,5 @@ "ws": "^8.0.0", "yup": "^1.0.0", "zod-form-data": "^3.0.1" - }, - "version": "11.16.0" + } }
true
trpc/trpc
7,316
issue_to_patch
fix(deps): update dependency undici to v8
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://redirect.github.com/nodejs/undici)) | [`^7.0.0` โ†’ `^8.0.0`](https...
1638ac173aac937982afe82075502596c60faa44
bfae85fbb306a74d72dcbf82abef59a65f095419
diff --git a/packages/client/package.json b/packages/client/package.json index f55dd206a45..291c0bbf935 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -130,7 +130,7 @@ "tsdown": "0.12.7", "tslib": "^2.8.1", "typescript": "^5.9.2", - "undici": "^7.0.0", + "undici": "...
[ "packages/client/package.json", "packages/tests/package.json", "pnpm-lock.yaml" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 225a9a82858..4ff4cad755e 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -31,7 +31,7 @@ "tsx": "^4.19.3", "tupleson": "0.23.1", "typescript": "^5.9.2", - "undici": "^7.0.0", + "undici": "^8.0....
true
trpc/trpc
7,288
issue_to_patch
chore(deps): bump fastify from 5.8.1 to 5.8.3
Bumps [fastify](https://github.com/fastify/fastify) from 5.8.1 to 5.8.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/fastify/fastify/releases">fastify's releases</a>.</em></p> <blockquote> <h2>v5.8.3</h2> <h2>โš ๏ธ Security Release</h2> <p>This fixes CVE CVE-2026-3635 <a href...
a6f049ee4979e8ca9e897af03209154441c5921b
9fa56dd2f0dd8ac1494d80d25cf84d9b6a284f3e
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index f7cdba94d7f..7d0a54e6b37 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -643,7 +643,7 @@ importers: version: link:../../packages/server fastify: specifier: ^5.0.0 - version: 5.8.1 + version: 5.8.3 superjson: s...
[ "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,313
issue_to_patch
chore(deps): update codecov/codecov-action action to v6
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [codecov/codecov-action](https://redirect.github.com/codecov/codecov-action) | action | major | `v5` โ†’ `v6` | --- ### Release Notes <details> <summary>codecov/codecov-action (codecov/codecov-action)</summary> ### [`v6`...
dff3dfea360ee508a96262658cf8a73e6b823e78
4ee2581c4002b5a3c03b1159260e8fae0ae56b87
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a926ba781aa..78686b71a7e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -92,7 +92,7 @@ jobs: exit 1 fi - - uses: codecov/codecov-action@v5 + - uses: codecov/codecov-action@v6 ...
[ ".github/workflows/main.yml" ]
[]
true
trpc/trpc
7,314
issue_to_patch
fix(deps): update dependency eslint-plugin-unicorn to v64
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [eslint-plugin-unicorn](https://redirect.github.com/sindresorhus/eslint-plugin-unicorn) | [`63.0.0` โ†’ `64.0.0`](https:/...
231fdd013605896df9ec0f25ec81b741ca8cae2e
28ef22e5fc4c1bfe87c593edefad1d7a2fea56c5
diff --git a/package.json b/package.json index bab3306af82..3894e5041e0 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "eslint": "^9.26.0", "eslint-plugin-react": "^7.37.5", "eslint-plugin-react-hooks": "6.0.0-rc.1", - "eslint-plugin-unicorn": "63.0.0", + "eslint-plugin-unicorn": "6...
[ "package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,309
issue_to_patch
fix(deps): update dependency @tanstack/intent to ^0.0.27
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@tanstack/intent](https://redirect.github.com/tanstack/intent) | [`^0.0.23` โ†’ `^0.0.27`](https://renovatebot.com/diffs...
19c599c48b2621ccbc412b8a4b38a701272fd9b0
614f16f765115c7bc82235b9884edf48f3e6b4ea
diff --git a/package.json b/package.json index 9bc25c538d2..bab3306af82 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "@eslint/compat": "^2.0.0", "@ianvs/prettier-plugin-sort-imports": "^4.4.0", "@manypkg/cli": "^0.22.0", - "@tanstack/intent": "^0.0.23", + "@tanstack/intent": "^0.0...
[ "package.json", "packages/client/package.json", "packages/next/package.json", "packages/openapi/package.json", "packages/server/package.json", "packages/tanstack-react-query/package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,310
issue_to_patch
fix(deps): update dependency srvx to v0.11.14
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [srvx](https://srvx.h3.dev) ([source](https://redirect.github.com/h3js/srvx)) | [`0.11.13` โ†’ `0.11.14`](https://renovat...
48c51585463c03c95db9d0ea97447c4ca6c68134
158ad7b2abd24c23326e9fdd8c8568e8e1dc42fc
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 8c558c55ad8..2c62239d155 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2262,8 +2262,8 @@ importers: specifier: ^0.13.0 version: 0.13.0 srvx: - specifier: 0.11.13 - version: 0.11.13 + specifier: 0.11.14 + versi...
[ "packages/tests/package.json", "pnpm-lock.yaml" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 0909d2b1402..225a9a82858 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -25,7 +25,7 @@ "node-fetch": "^3.3.0", "runtypes": "^7.0.0", "scale-codec": "^0.13.0", - "srvx": "0.11.13", + "srvx": "...
true
trpc/trpc
7,311
issue_to_patch
chore(deps): update dependency @oxc-project/runtime to v0.123.0
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@oxc-project/runtime](https://oxc.rs) ([source](https://redirect.github.com/oxc-project/oxc/tree/HEAD/npm/runtime)) | ...
1b085072bd9002859bccc9df388f9dda18f5024b
162474726befc0d0fbb97e8a7c3848ea3811e620
diff --git a/packages/server/package.json b/packages/server/package.json index 0ff8bffd464..007b62bd452 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -197,7 +197,7 @@ }, "devDependencies": { "@fastify/websocket": "^11.0.0", - "@oxc-project/runtime": "0.115.0", + "@oxc-...
[ "packages/server/package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,312
issue_to_patch
fix(deps): update dependency @clack/prompts to v1.2.0
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@clack/prompts](https://redirect.github.com/bombshell-dev/clack/tree/main/packages/prompts#readme) ([source](https://r...
7ba14fdb6c351d93747bc883c5c61af22702aadb
9086eed845e6484e94f282f6fcc18c1cc2b87f1b
diff --git a/packages/upgrade/package.json b/packages/upgrade/package.json index fd58ceb6b50..90e4c548973 100644 --- a/packages/upgrade/package.json +++ b/packages/upgrade/package.json @@ -33,7 +33,7 @@ ], "dependencies": { "@bomb.sh/args": "0.3.1", - "@clack/prompts": "1.1.0", + "@clack/prompts": "1.2...
[ "packages/upgrade/package.json", "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,302
issue_to_patch
Accessibility: 42 links without accessible text on trpc.io (WCAG scan) ## Accessibility Scan Results for trpc.io **Score: 0/100 (Grade F)** โ€” 73 issues found I ran an automated WCAG accessibility scan on trpc.io and found significant accessibility barriers, primarily around link accessibility and color contrast. ##...
fix(www): Add accessible text to links without discernible text
## Summary Fixed accessibility issues where links had no discernible text for screen reader users. ## Issues Found An automated WCAG accessibility scan found 42 links on trpc.io without accessible text, making the site difficult to navigate for screen reader users. ## Changes ### 1. TwitterWall Component - Added a...
d3c4051f03d0ca1f31177cadc10adff21c9048b8
6a7069d64c98fe4f1f8e7b87cd80e1e112f9c2a0
diff --git a/www/src/components/TwitterWall/index.tsx b/www/src/components/TwitterWall/index.tsx index 82540261250..763b0767526 100644 --- a/www/src/components/TwitterWall/index.tsx +++ b/www/src/components/TwitterWall/index.tsx @@ -60,6 +60,7 @@ export const TwitterWall = () => { viewport={{ once: true }} ...
[ "www/src/components/TwitterWall/index.tsx", "www/src/components/sponsors/SponsorBubbles.jsx" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\n# Description: Extract the link structure from TwitterWall component to confirm nesting\n\nast-grep --pattern $'<motion.a $$$>\n $$$\n <a $$$>\n $$$\n </a>\n...
true
trpc/trpc
7,303
issue_to_patch
feat: Add subscription inferrence helpers
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
d2ea28e14fe0afde553cc5fce177ed7642943731
d62b192f58b8d118fd8ca28e681b562a359e4e1b
diff --git a/packages/server/src/@trpc/server/index.ts b/packages/server/src/@trpc/server/index.ts index 7c39514d383..d8154d4a6f8 100644 --- a/packages/server/src/@trpc/server/index.ts +++ b/packages/server/src/@trpc/server/index.ts @@ -13,6 +13,8 @@ export { createRecursiveProxy as createTRPCRecursiveProxy, type...
[ "packages/server/src/@trpc/server/index.ts", "packages/server/src/unstable-core-do-not-import/clientish/inference.ts", "packages/server/src/unstable-core-do-not-import/procedure.ts", "packages/tests/server/inferenceHelpers.test.ts", "www/docs/client/vanilla/infer-types.md" ]
[]
diff --git a/packages/tests/server/inferenceHelpers.test.ts b/packages/tests/server/inferenceHelpers.test.ts index 4b53be5431a..8265a57f188 100644 --- a/packages/tests/server/inferenceHelpers.test.ts +++ b/packages/tests/server/inferenceHelpers.test.ts @@ -1,5 +1,13 @@ -import type { inferRouterInputs, inferRouterOutpu...
true
trpc/trpc
7,296
issue_to_patch
chore: Add cache checks for openapi router fixtures
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0497781ae51..a926ba781aa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -80,6 +80,18 @@ jobs: - run: MUTE_REACT_ACT_WARNINGS=1 pnpm test -- --coverage + - name: Verify committed openapi test fixtures ...
[ ".github/workflows/main.yml", ".gitignore", "packages/openapi/src/generate.ts", "packages/openapi/test/amazonIon.test.ts", "packages/openapi/test/cli.test.ts", "packages/openapi/test/cyclicTypes.test.ts", "packages/openapi/test/edgeCases.test.ts", "packages/openapi/test/generate.test.ts", "packages/...
[ { "comment": "The failure message says to \"Run the openapi codegen locally\" but doesnโ€™t tell contributors which command to run. Since `packages/openapi/package.json` defines a `codegen` script, consider updating the message to point to the exact command (e.g. `pnpm -C packages/openapi codegen`) so CI failures...
diff --git a/packages/openapi/test/amazonIon.test.ts b/packages/openapi/test/amazonIon.test.ts index 43dbc7cb544..c6f9a8b3d2e 100644 --- a/packages/openapi/test/amazonIon.test.ts +++ b/packages/openapi/test/amazonIon.test.ts @@ -3,12 +3,12 @@ import { createHTTPHandler } from '@trpc/server/adapters/standalone'; import...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
The failure message says to "Run the openapi codegen locally" but doesnโ€™t tell contributors which command to run. Since `packages/openapi/package.json` defines a `codegen` script, consider updating the message to point to the exact command (e.g. `pnpm -C packages/openapi codegen`) so CI failures are immediately actiona...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0497781ae51..a926ba781aa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -80,6 +80,18 @@ jobs: - run: MUTE_REACT_ACT_WARNINGS=1 pnpm test -- --coverage + - name: Verify committed openapi test fixtures ...
[ ".github/workflows/main.yml" ]
[ { "comment": "The failure message says to \"Run the openapi codegen locally\" but doesnโ€™t tell contributors which command to run. Since `packages/openapi/package.json` defines a `codegen` script, consider updating the message to point to the exact command (e.g. `pnpm -C packages/openapi codegen`) so CI failures...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Avoid adding a new `console.log` path under `packages/`.** This introduces both a file-wide `no-console` suppression and a new runtime log site. Please route the cache-hit message through the repoโ€™s normal logging path instead of `console.log`. As per coding guidelines, `packages/...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Avoid adding a new `console.log` path under `packages/`.**\n\nThis introduces both a file-wide `no-console` suppression and a new runtime log site. Please route the cache-hit message through the repoโ€™s normal logging path instead of `console.log`.\n\nAs per c...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Include generator changes and missing artifacts in the cache miss path.** A cache hit is currently based only on `package.json`, `src/**`, and the router file. Changes to `packages/openapi/test/scripts/codegen.ts` itselfโ€”or a deleted `${stem}.ts.json` / `${stem}-heyapi` artifactโ€”st...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Include generator changes and missing artifacts in the cache miss path.**\n\nA cache hit is currently based only on `package.json`, `src/**`, and the router file. Changes to `packages/openapi/test/scripts/codegen.ts` itselfโ€”or a deleted `${stem}.ts.json` / `$...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
The condition `if ((pattern === '$router', '../server/src'))` uses the comma operator, so it always evaluates truthy and returns `routerPath` for *every* pattern. This makes the cache hash ignore `package.json` and `src/**` (and repeats the router file multiple times), so fixture regeneration will be skipped when non-r...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "The condition `if ((pattern === '$router', '../server/src'))` uses the comma operator, so it always evaluates truthy and returns `routerPath` for *every* pattern. This makes the cache hash ignore `package.json` and `src/**` (and repeats the router file multiple times), so fixture regeneration will...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
`CACHE_INPUT_PATTERNS` includes `'../server/src'`, but for non-`'/**'` patterns this code passes the resolved path into `hashFiles()`, which calls `readFileSync()` and will throw if the path is a directory. Either change the pattern to `'../server/src/**'` or teach the hashing logic to expand directories into their con...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "`CACHE_INPUT_PATTERNS` includes `'../server/src'`, but for non-`'/**'` patterns this code passes the resolved path into `hashFiles()`, which calls `readFileSync()` and will throw if the path is a directory. Either change the pattern to `'../server/src/**'` or teach the hashing logic to expand dire...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
`getRouterInputsHash()` recomputes the full file list and re-reads the contents of `src/**` (and potentially `../server/src/**`) for each router. With multiple routers this is O(routers ร— files) work on every run, which can negate the intended speedup. Consider computing a shared hash once for the common inputs and com...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "`getRouterInputsHash()` recomputes the full file list and re-reads the contents of `src/**` (and potentially `../server/src/**`) for each router. With multiple routers this is O(routers ร— files) work on every run, which can negate the intended speedup. Consider computing a shared hash once for the...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
Inside the loop `file` is already an absolute path (from `getRouterFiles()`), but `routerPath` is recomputed via `path.resolve(routersDir, file)`, which is redundant and slightly confusing. Consider using `routerPath = file` (or make `getRouterFiles()` return relative paths) to keep the path handling straightforward. `...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "Inside the loop `file` is already an absolute path (from `getRouterFiles()`), but `routerPath` is recomputed via `path.resolve(routersDir, file)`, which is redundant and slightly confusing. Consider using `routerPath = file` (or make `getRouterFiles()` return relative paths) to keep the path handl...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Hash the routerโ€™s actual dependency surface, not just these glob roots.** `generateOpenAPIDocument()` type-checks the router with loaded compiler options and then tries to import the router module, so the output depends on transitive imports and TS config too. With the current patt...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Hash the routerโ€™s actual dependency surface, not just these glob roots.**\n\n`generateOpenAPIDocument()` type-checks the router with loaded compiler options and then tries to import the router module, so the output depends on transitive imports and TS config ...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
`hasExpectedArtifacts()` only checks that `docPath` and `outputDir` exist. If `outputDir` exists but is incomplete/corrupted (e.g. a generated file inside is deleted), this will be treated as a cache hit and codegen will be skipped, potentially breaking tests/CI. Consider checking for one or more sentinel files inside ...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "`hasExpectedArtifacts()` only checks that `docPath` and `outputDir` exist. If `outputDir` exists but is incomplete/corrupted (e.g. a generated file inside is deleted), this will be treated as a cache hit and codegen will be skipped, potentially breaking tests/CI. Consider checking for one or more ...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
The file-level `/* eslint-disable no-console */` is broad, but this file only uses `console.log` for the cache-hit message. Consider narrowing the suppression to just the specific line (or switching to a non-console mechanism) so new console usage doesnโ€™t get silently introduced later. ```suggestion /* eslint-disable-n...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "The file-level `/* eslint-disable no-console */` is broad, but this file only uses `console.log` for the cache-hit message. Consider narrowing the suppression to just the specific line (or switching to a non-console mechanism) so new console usage doesnโ€™t get silently introduced later.\n```suggest...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
The cache key doesnโ€™t currently include `tsconfig.json`, but `generateOpenAPIDocument()` loads compiler options via `ts.findConfigFile(..., 'tsconfig.json')`. If `packages/openapi/tsconfig.json` changes, outputs can change while the cache still hits, which would also prevent the CI โ€œfixtures are out of dateโ€ check from...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "The cache key doesnโ€™t currently include `tsconfig.json`, but `generateOpenAPIDocument()` loads compiler options via `ts.findConfigFile(..., 'tsconfig.json')`. If `packages/openapi/tsconfig.json` changes, outputs can change while the cache still hits, which would also prevent the CI โ€œfixtures are o...
true
trpc/trpc
7,296
comment_to_fix
chore: Add cache checks for openapi router fixtures
`getRouterInputsHash()` is called once per router and re-traverses + re-reads all files under `src/**`, `../server/src/**`, and `test/scripts/**` each time. With multiple routers this becomes O(N_routers * N_files) reads and can significantly slow globalSetup even on cache hits (because the hash still has to be compute...
2b8a4f826d3b22829343cebd9b23e163dfeecd09
85586e7a6d9d85c9a25f7d9e8bb8648c705f396d
diff --git a/packages/openapi/test/scripts/codegen.ts b/packages/openapi/test/scripts/codegen.ts index 322c0386b5d..b5088fbd214 100644 --- a/packages/openapi/test/scripts/codegen.ts +++ b/packages/openapi/test/scripts/codegen.ts @@ -1,12 +1,22 @@ +/* eslint-disable no-console */ /** * Generates hey-api SDK clients f...
[ "packages/openapi/test/scripts/codegen.ts" ]
[ { "comment": "`getRouterInputsHash()` is called once per router and re-traverses + re-reads all files under `src/**`, `../server/src/**`, and `test/scripts/**` each time. With multiple routers this becomes O(N_routers * N_files) reads and can significantly slow globalSetup even on cache hits (because the hash s...
true
trpc/trpc
7,298
issue_to_patch
chore: Update Hey API for new type imports
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob...
492bacf3b9ca28d16cfe5ec32e4eb4d164b7f8f0
35cd933366f02979e7da97126e17abd0795d5dde
diff --git a/examples/openapi-codegen/package.json b/examples/openapi-codegen/package.json index 1dfb2859ea9..e19bd1995ac 100644 --- a/examples/openapi-codegen/package.json +++ b/examples/openapi-codegen/package.json @@ -20,7 +20,7 @@ "zod": "^4.2.1" }, "devDependencies": { - "@hey-api/openapi-ts": "^0.94...
[ "examples/openapi-codegen/package.json", "packages/openapi/package.json", "packages/openapi/src/heyapi/index.ts", "packages/openapi/test/routers/amazonIonRouter-heyapi/client/utils.gen.ts", "packages/openapi/test/routers/amazonIonRouter-heyapi/core/types.gen.ts", "packages/openapi/test/routers/amazonIonRo...
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Significant peerDependency minimum version bump.**\n\nThe peerDependency minimum jumped from `>=0.13.0` to `>=0.94.5`. This is a breaking change for users who have `@hey-api/openapi-ts` installed at versions below 0.94.5. Since this is an optional peer depend...
diff --git a/packages/openapi/test/routers/amazonIonRouter-heyapi/client/utils.gen.ts b/packages/openapi/test/routers/amazonIonRouter-heyapi/client/utils.gen.ts index b4bd2435ce0..5162192d8a7 100644 --- a/packages/openapi/test/routers/amazonIonRouter-heyapi/client/utils.gen.ts +++ b/packages/openapi/test/routers/amazon...
true
trpc/trpc
7,298
comment_to_fix
chore: Update Hey API for new type imports
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Significant peerDependency minimum version bump.** The peerDependency minimum jumped from `>=0.13.0` to `>=0.94.5`. This is a breaking change for users who have `@hey-api/openapi-ts` installed at versions below 0.94.5. Since this is an optional peer dependency, the impact is limite...
492bacf3b9ca28d16cfe5ec32e4eb4d164b7f8f0
35cd933366f02979e7da97126e17abd0795d5dde
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 06edd7c35ab..89e0a5e2c81 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -77,7 +77,7 @@ "openapi-types": "^12.1.3" }, "devDependencies": { - "@hey-api/openapi-ts": "^0.94.1", + "@hey-api/o...
[ "packages/openapi/package.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Significant peerDependency minimum version bump.**\n\nThe peerDependency minimum jumped from `>=0.13.0` to `>=0.94.5`. This is a breaking change for users who have `@hey-api/openapi-ts` installed at versions below 0.94.5. Since this is an optional peer depend...
true
trpc/trpc
7,299
issue_to_patch
docs: Add oasdiff docs to openapi
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
fb9fe87fd4885f3e2b3f16fe484b1467b77d5324
9acc17e99bcb413a2d8fc7f7276d25d15888747f
diff --git a/packages/openapi/README.md b/packages/openapi/README.md index 184d7c76e64..380bce7e471 100644 --- a/packages/openapi/README.md +++ b/packages/openapi/README.md @@ -53,7 +53,6 @@ npx @tanstack/intent@latest install - [ ] non-nodejs example - [ ] an ai/mcp example - [ ] investigate async generators suppor...
[ "packages/openapi/README.md", "www/docs/client/openapi.md" ]
[ { "comment": "Grammar: โ€œUsing this you can quick generate โ€ฆโ€ reads incorrectly and is missing punctuation. Consider rephrasing to โ€œUsing this, you can quickly generate โ€ฆโ€ and end the sentence with a period.\n```suggestion\nUsing this, you can quickly generate changelogs or detect inadvertent breaking changes to...
true
trpc/trpc
7,299
comment_to_fix
docs: Add oasdiff docs to openapi
Grammar: โ€œUsing this you can quick generate โ€ฆโ€ reads incorrectly and is missing punctuation. Consider rephrasing to โ€œUsing this, you can quickly generate โ€ฆโ€ and end the sentence with a period. ```suggestion Using this, you can quickly generate changelogs or detect inadvertent breaking changes to APIs to help plan and c...
fb9fe87fd4885f3e2b3f16fe484b1467b77d5324
9acc17e99bcb413a2d8fc7f7276d25d15888747f
diff --git a/www/docs/client/openapi.md b/www/docs/client/openapi.md index d57523d5824..124c7fc0a4d 100644 --- a/www/docs/client/openapi.md +++ b/www/docs/client/openapi.md @@ -190,13 +190,13 @@ To integrate correctly with tRPC's protocol, you need to set up your generated c See the [Hey API config source](https://g...
[ "www/docs/client/openapi.md" ]
[ { "comment": "Grammar: โ€œUsing this you can quick generate โ€ฆโ€ reads incorrectly and is missing punctuation. Consider rephrasing to โ€œUsing this, you can quickly generate โ€ฆโ€ and end the sentence with a period.\n```suggestion\nUsing this, you can quickly generate changelogs or detect inadvertent breaking changes to...
true
trpc/trpc
7,299
comment_to_fix
docs: Add oasdiff docs to openapi
The shell snippet includes `$` prompts and uses a `sh` fence, but the rest of this doc uses `bash` fences without prompts (easier to copy/paste). Consider switching to a `bash` block and removing the `$` prefixes for consistency.
fb9fe87fd4885f3e2b3f16fe484b1467b77d5324
9acc17e99bcb413a2d8fc7f7276d25d15888747f
diff --git a/www/docs/client/openapi.md b/www/docs/client/openapi.md index d57523d5824..124c7fc0a4d 100644 --- a/www/docs/client/openapi.md +++ b/www/docs/client/openapi.md @@ -190,13 +190,13 @@ To integrate correctly with tRPC's protocol, you need to set up your generated c See the [Hey API config source](https://g...
[ "www/docs/client/openapi.md" ]
[ { "comment": "The shell snippet includes `$` prompts and uses a `sh` fence, but the rest of this doc uses `bash` fences without prompts (easier to copy/paste). Consider switching to a `bash` block and removing the `$` prefixes for consistency.", "path": "www/docs/client/openapi.md", "hunk": "@@ -76,6 +7...
true
trpc/trpc
7,299
comment_to_fix
docs: Add oasdiff docs to openapi
The example paths reference repo-internal test fixtures (`packages/openapi/test/routers/...`), which wonโ€™t exist for most readers. Consider using generic filenames (e.g. `openapi.prev.json` / `openapi.next.json`) or referencing the output from the earlier generation step.
fb9fe87fd4885f3e2b3f16fe484b1467b77d5324
9acc17e99bcb413a2d8fc7f7276d25d15888747f
diff --git a/www/docs/client/openapi.md b/www/docs/client/openapi.md index d57523d5824..124c7fc0a4d 100644 --- a/www/docs/client/openapi.md +++ b/www/docs/client/openapi.md @@ -190,13 +190,13 @@ To integrate correctly with tRPC's protocol, you need to set up your generated c See the [Hey API config source](https://g...
[ "www/docs/client/openapi.md" ]
[ { "comment": "The example paths reference repo-internal test fixtures (`packages/openapi/test/routers/...`), which wonโ€™t exist for most readers. Consider using generic filenames (e.g. `openapi.prev.json` / `openapi.next.json`) or referencing the output from the earlier generation step.", "path": "www/docs/c...
true
trpc/trpc
7,299
comment_to_fix
docs: Add oasdiff docs to openapi
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Add the period in โ€œetc.โ€** Small copy-edit: change `etc` to `etc.` for consistency with American English style in docs. <details> <summary>๐Ÿงฐ Tools</summary> <details> <summary>๐Ÿช› LanguageTool</summary> [style] ~83-~83: In American English, abbreviations like โ€œetc.โ€ require a pe...
fb9fe87fd4885f3e2b3f16fe484b1467b77d5324
9acc17e99bcb413a2d8fc7f7276d25d15888747f
diff --git a/www/docs/client/openapi.md b/www/docs/client/openapi.md index d57523d5824..124c7fc0a4d 100644 --- a/www/docs/client/openapi.md +++ b/www/docs/client/openapi.md @@ -190,13 +190,13 @@ To integrate correctly with tRPC's protocol, you need to set up your generated c See the [Hey API config source](https://g...
[ "www/docs/client/openapi.md" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Add the period in โ€œetc.โ€**\n\nSmall copy-edit: change `etc` to `etc.` for consistency with American English style in docs.\n\n<details>\n<summary>๐Ÿงฐ Tools</summary>\n\n<details>\n<summary>๐Ÿช› LanguageTool</summary>\n\n[style] ~83-~83: In American English, abbr...
true
trpc/trpc
7,283
issue_to_patch
feat: OpenAPI Cyclic Types support
* Drops the depth limit of 20, and significantly hardens cyclic-type support for both inference and Zod * Support zod.lazy via Standard Schema fallback * Strip symbols from output (no more weird async generator output until we can do that right) * Add more comprehensive types for the OpenAPI doc from the official pa...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 00000000000..8f3d1c333da --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,10 @@ +reviews: + path_instructions: + - path: 'packages/openapi/test/routers/**' + instructions: | + - *.ts files should contain valid tRPC routers, and t...
[ ".coderabbit.yaml", "packages/openapi/README.md", "packages/openapi/package.json", "packages/openapi/src/generate.ts", "packages/openapi/src/index.ts", "packages/openapi/src/schemaExtraction.ts", "packages/openapi/src/types.ts", "packages/openapi/test/cyclicTypes.test.ts", "packages/openapi/test/edg...
[ { "comment": "`beforeAll` is used in this test but not imported from vitest, which will throw at runtime (ReferenceError) when the suite runs. Import `beforeAll` alongside `describe/it/expect` (or remove the hook).\n```suggestion\nimport { beforeAll, describe, expect, it } from 'vitest';\n```", "path": "pac...
diff --git a/packages/openapi/test/cyclicTypes.test.ts b/packages/openapi/test/cyclicTypes.test.ts new file mode 100644 index 00000000000..d9466b7ef8c --- /dev/null +++ b/packages/openapi/test/cyclicTypes.test.ts @@ -0,0 +1,419 @@ +import * as path from 'node:path'; +import { beforeAll, describe, expect, it } from 'vit...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`beforeAll` is used in this test but not imported from vitest, which will throw at runtime (ReferenceError) when the suite runs. Import `beforeAll` alongside `describe/it/expect` (or remove the hook). ```suggestion import { beforeAll, describe, expect, it } from 'vitest'; ```
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/cyclicTypes.test.ts b/packages/openapi/test/cyclicTypes.test.ts new file mode 100644 index 00000000000..d9466b7ef8c --- /dev/null +++ b/packages/openapi/test/cyclicTypes.test.ts @@ -0,0 +1,419 @@ +import * as path from 'node:path'; +import { beforeAll, describe, expect, it } from 'vit...
[ "packages/openapi/test/cyclicTypes.test.ts" ]
[ { "comment": "`beforeAll` is used in this test but not imported from vitest, which will throw at runtime (ReferenceError) when the suite runs. Import `beforeAll` alongside `describe/it/expect` (or remove the hook).\n```suggestion\nimport { beforeAll, describe, expect, it } from 'vitest';\n```", "path": "pac...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
This generated file defines `export type JsonValue = JsonValue;`, which is an invalid self-referential type alias in TypeScript and will fail type-checking. This is likely caused by the OpenAPI schema for `JsonValue` being an unexpanded self `$ref`; the generator should emit a concrete schema (e.g. a `oneOf`/`anyOf` un...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter-heyapi/types.gen.ts b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/types.gen.ts new file mode 100644 index 00000000000..a7ee0a1e463 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/types.gen.ts @@ -0,0 +1,566 @@ +// This fi...
[ "packages/openapi/test/routers/cyclicTypesRouter-heyapi/types.gen.ts" ]
[ { "comment": "This generated file defines `export type JsonValue = JsonValue;`, which is an invalid self-referential type alias in TypeScript and will fail type-checking. This is likely caused by the OpenAPI schema for `JsonValue` being an unexpanded self `$ref`; the generator should emit a concrete schema (e.g...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`components.schemas.JsonValue` is currently a `$ref` to itself, which makes the schema unusable (it never bottoms out) and leads to broken downstream codegen (e.g. `type JsonValue = JsonValue`). The OpenAPI output should describe the recursive union structure (primitives | array | object) and only use `$ref` for recurs...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter.ts.json b/packages/openapi/test/routers/cyclicTypesRouter.ts.json new file mode 100644 index 00000000000..3416210c3b4 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter.ts.json @@ -0,0 +1,1137 @@ +{ + "openapi": "3.1.1", + "jsonSchemaDialec...
[ "packages/openapi/test/routers/cyclicTypesRouter.ts.json" ]
[ { "comment": "`components.schemas.JsonValue` is currently a `$ref` to itself, which makes the schema unusable (it never bottoms out) and leads to broken downstream codegen (e.g. `type JsonValue = JsonValue`). The OpenAPI output should describe the recursive union structure (primitives | array | object) and only...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
The cyclic-type handling can still produce a degenerate component schema that is just a self `$ref` (see the `JsonValue` snapshot in the new cyclic router fixture). Consider adding a guard here: if the computed `schema` is exactly `schemaRef(postConvertRef)` (or if `ctx.schemas[postConvertRef]` would remain a self-ref)...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/generate.ts b/packages/openapi/src/generate.ts index 16b32daf7b0..6b05405d792 100644 --- a/packages/openapi/src/generate.ts +++ b/packages/openapi/src/generate.ts @@ -1,3 +1,4 @@ +import * as fs from 'node:fs'; import * as path from 'node:path'; import * as ts from 'typescript'; imp...
[ "packages/openapi/src/generate.ts" ]
[ { "comment": "The cyclic-type handling can still produce a degenerate component schema that is just a self `$ref` (see the `JsonValue` snapshot in the new cyclic router fixture). Consider adding a guard here: if the computed `schema` is exactly `schemaRef(postConvertRef)` (or if `ctx.schemas[postConvertRef]` wo...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`beforeAll` is used but not imported from vitest, so this test file will throw at runtime / fail typecheck. Import `beforeAll` alongside `describe/it`.
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/cyclicTypes.test.ts b/packages/openapi/test/cyclicTypes.test.ts new file mode 100644 index 00000000000..d9466b7ef8c --- /dev/null +++ b/packages/openapi/test/cyclicTypes.test.ts @@ -0,0 +1,419 @@ +import * as path from 'node:path'; +import { beforeAll, describe, expect, it } from 'vit...
[ "packages/openapi/test/cyclicTypes.test.ts" ]
[ { "comment": "`beforeAll` is used but not imported from vitest, so this test file will throw at runtime / fail typecheck. Import `beforeAll` alongside `describe/it`.", "path": "packages/openapi/test/cyclicTypes.test.ts", "hunk": "@@ -0,0 +1,361 @@\n+import * as path from 'node:path';\n+import { describe...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
This changes the public export surface by no longer re-exporting `JsonSchema` / `OpenAPIDocument` from `./generate`. If external users were relying on those types, this is a breaking change. Consider keeping backward-compatible type aliases (possibly deprecated) or documenting the new import path (`OpenAPIV3_1.Document...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/index.ts b/packages/openapi/src/index.ts index 9596614e7c0..b4f9e52a81a 100644 --- a/packages/openapi/src/index.ts +++ b/packages/openapi/src/index.ts @@ -1,2 +1,3 @@ export { generateOpenAPIDocument } from './generate'; -export type { GenerateOptions, JsonSchema, OpenAPIDocument } fr...
[ "packages/openapi/src/index.ts" ]
[ { "comment": "This changes the public export surface by no longer re-exporting `JsonSchema` / `OpenAPIDocument` from `./generate`. If external users were relying on those types, this is a breaking change. Consider keeping backward-compatible type aliases (possibly deprecated) or documenting the new import path ...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Incomplete TODO item text.** The TODO text ends with "and probably" which appears to be incomplete. Please finish the sentence or remove the trailing text. <details> <summary>Suggested fix</summary> ```diff -- [ ] investigate async generators support (types generate... poorly) a...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/README.md b/packages/openapi/README.md index e15da1fbe65..184d7c76e64 100644 --- a/packages/openapi/README.md +++ b/packages/openapi/README.md @@ -50,9 +50,9 @@ npx @tanstack/intent@latest install - [ ] SSE subscriptions - [ ] non-json content types (might already work, needs tests) --...
[ "packages/openapi/README.md" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Incomplete TODO item text.**\n\nThe TODO text ends with \"and probably\" which appears to be incomplete. Please finish the sentence or remove the trailing text.\n\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-- [ ] investigate async generators s...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_ **Backfill self-`$ref` placeholders before returning the component ref.** A recursive union/intersection can reach this block after an inner call has already replaced the `{}` placeholder with `schemaRef(postConvertRef)`. `isNonEmptySchema()` then treats that self-reference as fin...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/generate.ts b/packages/openapi/src/generate.ts index 16b32daf7b0..6b05405d792 100644 --- a/packages/openapi/src/generate.ts +++ b/packages/openapi/src/generate.ts @@ -1,3 +1,4 @@ +import * as fs from 'node:fs'; import * as path from 'node:path'; import * as ts from 'typescript'; imp...
[ "packages/openapi/src/generate.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_\n\n**Backfill self-`$ref` placeholders before returning the component ref.**\n\nA recursive union/intersection can reach this block after an inner call has already replaced the `{}` placeholder with `schemaRef(postConvertRef)`. `isNonEmptySchema()` then treats ...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_ **Missing `beforeAll` import.** The `beforeAll` function used on line 20 is not included in the imports from `vitest`. This will cause a runtime error. <details> <summary>๐Ÿ› Proposed fix</summary> ```diff -import { describe, expect, it } from 'vitest'; +import { beforeAll, des...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/cyclicTypes.test.ts b/packages/openapi/test/cyclicTypes.test.ts new file mode 100644 index 00000000000..d9466b7ef8c --- /dev/null +++ b/packages/openapi/test/cyclicTypes.test.ts @@ -0,0 +1,419 @@ +import * as path from 'node:path'; +import { beforeAll, describe, expect, it } from 'vit...
[ "packages/openapi/test/cyclicTypes.test.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_\n\n**Missing `beforeAll` import.**\n\nThe `beforeAll` function used on line 20 is not included in the imports from `vitest`. This will cause a runtime error.\n\n\n\n<details>\n<summary>๐Ÿ› Proposed fix</summary>\n\n```diff\n-import { describe, expect, it } from ...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Chain the transformed error through the interceptor loop.** Both loops keep invoking each interceptor with the original `error`. That means later interceptors cannot see earlier transformations, and a logging-only interceptor that returns `undefined` can clobber a previously wrappe...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter-heyapi/client/client.gen.ts b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/client/client.gen.ts new file mode 100644 index 00000000000..14dc0a0ec56 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/client/client.gen.ts @@ -0...
[ "packages/openapi/test/routers/cyclicTypesRouter-heyapi/client/client.gen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Chain the transformed error through the interceptor loop.**\n\nBoth loops keep invoking each interceptor with the original `error`. That means later interceptors cannot see earlier transformations, and a logging-only interceptor that returns `undefined` can c...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Donโ€™t JSON-quote `Date` values in URL-encoded bodies.** `JSON.stringify(new Date(...))` produces `"2025-..."`, so this helper serializes dates with literal quotes. The sibling form-data serializer already special-cases `Date`; URL-encoded bodies should emit the raw ISO string too. ...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/bodySerializer.gen.ts b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/bodySerializer.gen.ts new file mode 100644 index 00000000000..67daca60f89 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/bodySeria...
[ "packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/bodySerializer.gen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Donโ€™t JSON-quote `Date` values in URL-encoded bodies.**\n\n`JSON.stringify(new Date(...))` produces `\"2025-...\"`, so this helper serializes dates with literal quotes. The sibling form-data serializer already special-cases `Date`; URL-encoded bodies should e...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Flush the buffered tail chunk before EOF.** The loop breaks as soon as `reader.read()` returns `{ done: true }`, so a final event without a trailing blank line is silently dropped. That is a common finite-stream shape and makes the last SSE message disappear. <details> <summary>๐Ÿ’ก...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/serverSentEvents.gen.ts b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/serverSentEvents.gen.ts new file mode 100644 index 00000000000..6aa6cf02a4f --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/serve...
[ "packages/openapi/test/routers/cyclicTypesRouter-heyapi/core/serverSentEvents.gen.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Flush the buffered tail chunk before EOF.**\n\nThe loop breaks as soon as `reader.read()` returns `{ done: true }`, so a final event without a trailing blank line is silently dropped. That is a common finite-stream shape and makes the last SSE message disappe...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **`JsonValue` needs real terminal branches, not a bare self `$ref`.** `"$ref": "#/components/schemas/JsonValue"` by itself validates no finite JSON value, so this fixture is baking a broken recursive shape into the expected output and any downstream codegen that consumes it. Please e...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter.ts.json b/packages/openapi/test/routers/cyclicTypesRouter.ts.json new file mode 100644 index 00000000000..3416210c3b4 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter.ts.json @@ -0,0 +1,1137 @@ +{ + "openapi": "3.1.1", + "jsonSchemaDialec...
[ "packages/openapi/test/routers/cyclicTypesRouter.ts.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**`JsonValue` needs real terminal branches, not a bare self `$ref`.**\n\n`\"$ref\": \"#/components/schemas/JsonValue\"` by itself validates no finite JSON value, so this fixture is baking a broken recursive shape into the expected output and any downstream code...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell #!/bin/bash # Check if there are other symbol-based property names in OpenAPI test snapshots rg -n '__@.*@[0-9]+' --glob '*.json' packages/openapi/test/ ``` Repository: trpc/trpc Length of output: 237 ---...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/edgeCaseRouter.ts.json b/packages/openapi/test/routers/edgeCaseRouter.ts.json index 151514d7cef..eedbdcf54fb 100644 --- a/packages/openapi/test/routers/edgeCaseRouter.ts.json +++ b/packages/openapi/test/routers/edgeCaseRouter.ts.json @@ -796,6 +796,54 @@ } ...
[ "packages/openapi/test/routers/edgeCaseRouter.ts.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\n# Check if there are other symbol-based property names in OpenAPI test snapshots\nrg -n '__@.*@[0-9]+' --glob '*.json' packages/openapi/test/\n```\n\nRepository: tr...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell #!/bin/bash # Check if other Zod lazy inputs in the codebase also produce empty schemas rg -n 'z\.lazy' packages/openapi/test/routers/ -A5 | head -50 ``` Repository: trpc/trpc Length of output: 3422 --- ...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter.ts.json b/packages/openapi/test/routers/cyclicTypesRouter.ts.json new file mode 100644 index 00000000000..3416210c3b4 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter.ts.json @@ -0,0 +1,1137 @@ +{ + "openapi": "3.1.1", + "jsonSchemaDialec...
[ "packages/openapi/test/routers/cyclicTypesRouter.ts.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\n# Check if other Zod lazy inputs in the codebase also produce empty schemas\nrg -n 'z\\.lazy' packages/openapi/test/routers/ -A5 | head -50\n```\n\nRepository: trpc...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell cat -n packages/openapi/src/generate.ts | sed -n '120,140p' ``` Repository: trpc/trpc Length of output: 752 --- ๐Ÿ Script executed: ```shell cat -n packages/openapi/src/generate.ts | sed -n '668,680p...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/generate.ts b/packages/openapi/src/generate.ts index 16b32daf7b0..6b05405d792 100644 --- a/packages/openapi/src/generate.ts +++ b/packages/openapi/src/generate.ts @@ -1,3 +1,4 @@ +import * as fs from 'node:fs'; import * as path from 'node:path'; import * as ts from 'typescript'; imp...
[ "packages/openapi/src/generate.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\ncat -n packages/openapi/src/generate.ts | sed -n '120,140p'\n```\n\nRepository: trpc/trpc\n\nLength of output: 752\n\n---\n\n๐Ÿ Script executed:\n\n```shell\ncat -n packages/...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_ **Avoid parameter destructuring in these query handlers.** These callbacks should take a single variable and access `input` off it directly to match the repo rule. <details> <summary>โ™ป๏ธ Proposed fix</summary> ```diff - category: t.procedure.input(zodCategorySchema).query(({...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/routers/cyclicTypesRouter.ts b/packages/openapi/test/routers/cyclicTypesRouter.ts new file mode 100644 index 00000000000..71503ecec63 --- /dev/null +++ b/packages/openapi/test/routers/cyclicTypesRouter.ts @@ -0,0 +1,264 @@ +import { initTRPC } from '@trpc/server'; +import * as z from ...
[ "packages/openapi/test/routers/cyclicTypesRouter.ts" ]
[ { "comment": "_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_\n\n**Avoid parameter destructuring in these query handlers.**\n\nThese callbacks should take a single variable and access `input` off it directly to match the repo rule.\n\n<details>\n<summary>โ™ป๏ธ Proposed fix</summary>\n\n```diff\n- category: t.procedure.i...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_ **Refactor `getParameter` to avoid 4 positional arguments.** Line 122โ€“127 violates the repoโ€™s max-3-params rule and makes call sites harder to read. <details> <summary>โ™ป๏ธ Proposed fix</summary> ```diff +export interface ParameterLookupOptions { + doc: Document; + procPath: s...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/test/types.ts b/packages/openapi/test/types.ts new file mode 100644 index 00000000000..a359239603d --- /dev/null +++ b/packages/openapi/test/types.ts @@ -0,0 +1,342 @@ +/* eslint-disable max-params */ +import type { + ArraySchemaObject, + Document, + OperationObject, + ParameterObject,...
[ "packages/openapi/test/types.ts" ]
[ { "comment": "_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_\n\n**Refactor `getParameter` to avoid 4 positional arguments.**\n\nLine 122โ€“127 violates the repoโ€™s max-3-params rule and makes call sites harder to read.\n\n<details>\n<summary>โ™ป๏ธ Proposed fix</summary>\n\n```diff\n+export interface ParameterLookupOptions {\...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`openapi-types` is imported from `src/types.ts` and is part of the public type surface (re-exported from `src/index.ts`), so it must be available to downstream consumers. Keeping it in `devDependencies` will cause TypeScript resolution failures for consumers of `@trpc/openapi` who don't have `openapi-types` installed. ...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/package.json b/packages/openapi/package.json index f149ef9c91e..ef74f27a351 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -73,6 +73,9 @@ "publishConfig": { "access": "public" }, + "dependencies": { + "openapi-types": "^12.1.3" + }, "de...
[ "packages/openapi/package.json" ]
[ { "comment": "`openapi-types` is imported from `src/types.ts` and is part of the public type surface (re-exported from `src/index.ts`), so it must be available to downstream consumers. Keeping it in `devDependencies` will cause TypeScript resolution failures for consumers of `@trpc/openapi` who don't have `open...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
The TODO bullet ends mid-sentence ("and probably"), which reads like an incomplete thought. Please finish the sentence or remove the trailing fragment so the README remains clear. ```suggestion - [ ] investigate async generators support (types generate... poorly) ```
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/README.md b/packages/openapi/README.md index e15da1fbe65..184d7c76e64 100644 --- a/packages/openapi/README.md +++ b/packages/openapi/README.md @@ -50,9 +50,9 @@ npx @tanstack/intent@latest install - [ ] SSE subscriptions - [ ] non-json content types (might already work, needs tests) --...
[ "packages/openapi/README.md" ]
[ { "comment": "The TODO bullet ends mid-sentence (\"and probably\"), which reads like an incomplete thought. Please finish the sentence or remove the trailing fragment so the README remains clear.\n```suggestion\n- [ ] investigate async generators support (types generate... poorly)\n```", "path": "packages/o...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
Typo: duplicated word "should" in this sentence. ```suggestion - *.json files are generated by the code under test, they should be valid and correct OpenAPI 3.1+ JSON docs ```
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 00000000000..8f3d1c333da --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,10 @@ +reviews: + path_instructions: + - path: 'packages/openapi/test/routers/**' + instructions: | + - *.ts files should contain valid tRPC routers, and t...
[ ".coderabbit.yaml" ]
[ { "comment": "Typo: duplicated word \"should\" in this sentence.\n```suggestion\n - *.json files are generated by the code under test, they should be valid and correct OpenAPI 3.1+ JSON docs\n```", "path": ".coderabbit.yaml", "hunk": "@@ -0,0 +1,10 @@\n+reviews:\n+ path_instructions:\n+ - pat...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`applyDescriptions()` cannot apply nested `.describe()` paths that traverse into array items when `items` is a `$ref`. In `setNestedDescription`, when a property is an array whose `items` is `{ $ref: ... }`, `target` becomes the `$ref` object (no `properties`), so paths like `children.name` (produced by `walkZodShape` ...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/schemaExtraction.ts b/packages/openapi/src/schemaExtraction.ts index a9bbeaf8844..d7c0b08712d 100644 --- a/packages/openapi/src/schemaExtraction.ts +++ b/packages/openapi/src/schemaExtraction.ts @@ -13,7 +13,7 @@ import type { $ZodTypeDef, GlobalMeta, } from 'zod/v4/core'; -impo...
[ "packages/openapi/src/schemaExtraction.ts" ]
[ { "comment": "`applyDescriptions()` cannot apply nested `.describe()` paths that traverse into array items when `items` is a `$ref`. In `setNestedDescription`, when a property is an array whose `items` is `{ $ref: ... }`, `target` becomes the `$ref` object (no `properties`), so paths like `children.name` (produ...
true
trpc/trpc
7,283
comment_to_fix
feat: OpenAPI Cyclic Types support
`setNestedDescription()` resolves `$ref`s when descending into nested paths, but the leaf cases (`rest.length === 0`) write `description` onto the immediate schema even if it is a `$ref`. Many OpenAPI/JSON Schema consumers ignore sibling keywords on `$ref`, so descriptions for referenced properties/items may be lost. C...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
1f45c26d1d4652d21fe4aba7e4907eed914f00f8
diff --git a/packages/openapi/src/schemaExtraction.ts b/packages/openapi/src/schemaExtraction.ts index a9bbeaf8844..d7c0b08712d 100644 --- a/packages/openapi/src/schemaExtraction.ts +++ b/packages/openapi/src/schemaExtraction.ts @@ -13,7 +13,7 @@ import type { $ZodTypeDef, GlobalMeta, } from 'zod/v4/core'; -impo...
[ "packages/openapi/src/schemaExtraction.ts" ]
[ { "comment": "`setNestedDescription()` resolves `$ref`s when descending into nested paths, but the leaf cases (`rest.length === 0`) write `description` onto the immediate schema even if it is a `$ref`. Many OpenAPI/JSON Schema consumers ignore sibling keywords on `$ref`, so descriptions for referenced propertie...
true
trpc/trpc
7,294
issue_to_patch
chore: Review stale skills (manual)
## ๐ŸŽฏ Changes Updated all 24 SKILL.md intent skill files from `library_version` `11.14.0` โ†’ `11.15.1` (and `11.14.0-alpha` โ†’ `11.15.1-alpha` for openapi) to reflect the latest tRPC release. In addition to the version bumps, skill content was updated to document the new `maxBatchSize` server option introduced in v11.1...
12bbc8ebf73df011d1da66b4dd80abfaa54e6bcf
d6e8b486cfffd94071672b4f7c5f916bc2df4f9d
diff --git a/packages/client/skills/client-setup/SKILL.md b/packages/client/skills/client-setup/SKILL.md index efe9e28717f..54c140baf9c 100644 --- a/packages/client/skills/client-setup/SKILL.md +++ b/packages/client/skills/client-setup/SKILL.md @@ -7,7 +7,7 @@ description: > inferRouterOutputs. AbortController signa...
[ "packages/client/skills/client-setup/SKILL.md", "packages/client/skills/links/SKILL.md", "packages/client/skills/superjson/SKILL.md", "packages/next/skills/nextjs-app-router/SKILL.md", "packages/next/skills/nextjs-pages-router/SKILL.md", "packages/openapi/skills/openapi/SKILL.md", "packages/server/skill...
[]
true
trpc/trpc
7,268
issue_to_patch
chore(deps): bump next from 15.5.10 to 15.5.14
Bumps [next](https://github.com/vercel/next.js) from 15.5.10 to 15.5.14. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vercel/next.js/releases">next's releases</a>.</em></p> <blockquote> <h2>v15.5.14</h2> <blockquote> <p>[!NOTE] This release is backporting bug fixes. It does...
2713275631db358f17f2fec71a7f7e04b3db4add
50ec2420ab42708e3b86bc75c45c8424182cb274
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index bbfdf780107..82726bd0ab9 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -82,7 +82,7 @@ importers: version: 0.7.0 lerna: specifier: ^9.0.0 - version: 9.0.1(@swc/core@1.11.21(@swc/helpers@0.5.18))(@types/node@22.17.0) + version...
[ "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,295
issue_to_patch
chore: Review stale skills (v11.16.0)
## ๐ŸŽฏ Changes This PR updates stale Intent skill metadata for the v11.16.0 release in `@trpc/trpc`. - Updated `library_version` in 24 `SKILL.md` files: - `11.15.1` โ†’ `11.16.0` - `11.15.1-alpha` โ†’ `11.16.0-alpha` (for `@trpc/openapi`) - Scope is metadata-only for stale skill version drift; no API/behavioral code c...
66d5b5e722dc247ddd0c0f0a93aff935a3c208c8
a2d67f83c7f73bcabc57a8d62290eeabba752b82
diff --git a/packages/client/skills/client-setup/SKILL.md b/packages/client/skills/client-setup/SKILL.md index 54c140baf9c..b05fc971ff5 100644 --- a/packages/client/skills/client-setup/SKILL.md +++ b/packages/client/skills/client-setup/SKILL.md @@ -7,7 +7,7 @@ description: > inferRouterOutputs. AbortController signa...
[ "packages/client/skills/client-setup/SKILL.md", "packages/client/skills/links/SKILL.md", "packages/client/skills/superjson/SKILL.md", "packages/next/skills/nextjs-app-router/SKILL.md", "packages/next/skills/nextjs-pages-router/SKILL.md", "packages/openapi/skills/openapi/SKILL.md", "packages/server/skill...
[]
true
trpc/trpc
7,286
issue_to_patch
fix(server): unwrap error from cause for streaming onError
## Summary The `onError` callback in `resolveResponse.ts` receives a `{ error, path }` object from jsonl.ts but passes the entire wrapper to `getTRPCErrorFromUnknown(cause)` instead of `cause.error`. This causes `getCauseFromUnknown` to create an `UnknownCauseError` with an empty message (`""`), which then short-circu...
59f2cdb3c58310733b06d3b2e16c94065fe0a9c3
6ad54e57f3a9a6c4ccdf82bd3fd886a890591e87
diff --git a/packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts b/packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts index 05d18e6399d..44fe5454e19 100644 --- a/packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts +++ b/packages/server/src/unstable-core-do-no...
[ "packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts", "packages/tests/server/errors.test.ts", "packages/tests/server/streaming.test.ts" ]
[ { "comment": "Test name says it should preserve the error message and *path*, but the assertions only cover the message/cause. Either assert on the relevant path info (e.g. `serverErrorOpts.path`) or remove the \"and preserve ... path\" portion to keep the test intent accurate.", "path": "packages/tests/ser...
diff --git a/packages/tests/server/errors.test.ts b/packages/tests/server/errors.test.ts index 5b08e5ef13d..c943daad504 100644 --- a/packages/tests/server/errors.test.ts +++ b/packages/tests/server/errors.test.ts @@ -543,3 +543,40 @@ describe('links have meta data about http failures', async () => { expect(error)....
true
trpc/trpc
7,292
issue_to_patch
fix(deps): update dependency srvx to v0.11.13 [security]
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [srvx](https://srvx.h3.dev) ([source](https://redirect.github.com/h3js/srvx)) | [`0.11.12` โ†’ `0.11.13`](https://renovat...
88b02b81d16d4046a709508799a905ac7bf9ce8b
0dc37d4f07996ac077a763d0dba36576384f1b95
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7be15b2ed65..806747ca8b6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2255,8 +2255,8 @@ importers: specifier: ^0.13.0 version: 0.13.0 srvx: - specifier: 0.11.12 - version: 0.11.12 + specifier: 0.11.13 + versi...
[ "packages/tests/package.json", "pnpm-lock.yaml" ]
[]
diff --git a/packages/tests/package.json b/packages/tests/package.json index 9e8d50f5ebd..992c46dd43c 100644 --- a/packages/tests/package.json +++ b/packages/tests/package.json @@ -25,7 +25,7 @@ "node-fetch": "^3.3.0", "runtypes": "^7.0.0", "scale-codec": "^0.13.0", - "srvx": "0.11.12", + "srvx": "...
true
trpc/trpc
7,293
issue_to_patch
chore(deps): update dependency devalue to v5.6.4 [security]
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [devalue](https://redirect.github.com/sveltejs/devalue) | [`5.6.3` โ†’ `5.6.4`](https://renovatebot.com/diffs/npm/devalue...
586d93021f55383a66efaa6218d44cf9b8486646
b0e40d065d4dea457fe77fcf04266e84f2fdbc93
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 806747ca8b6..7677d35d743 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -1917,7 +1917,7 @@ importers: version: 19.1.1(@types/react@19.1.0) devalue: specifier: ^5.0.0 - version: 5.6.3 + version: 5.6.4 eslint: s...
[ "pnpm-lock.yaml" ]
[]
true
trpc/trpc
7,280
issue_to_patch
bug: tRPC error handling with Node VM ### Provide environment information ``` System: OS: macOS 26.3.1 CPU: (11) arm64 Apple M3 Pro Memory: 2.63 GB / 36.00 GB Binaries: Node: 24.14.0 - /Users/<user>/.nvm/versions/node/v24.14.0/bin/node npm: 11.9.0 - /Users/<user>/.nvm/versions/node/v24.14.0/bin/npm pnpm: ...
fix: error handling with Node VM
Closes #7272 ## ๐ŸŽฏ Changes Fixed error handling when tRPC is used with Node VM by attempting to show the error message for implicitly thrown errors. ## โœ… Checklist - [x] I have followed the steps listed in the [Contributing guide](https://github.com/trpc/trpc/blob/main/CONTRIBUTING.md). - [ ] If necessary,...
f6e839f2b127b394fa1e9eb26bfe0c75c47fcbf2
671818a6c48f3d934717fcaaf04409852b43b615
diff --git a/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts b/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts index 7feb8609200..913a35e4bae 100644 --- a/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts +++ b/packages/server/src/unstable-core-do-not-import/error/...
[ "packages/server/src/unstable-core-do-not-import/error/TRPCError.ts", "packages/tests/server/regression/issue-7272-node-vm-error-message.test.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐ŸŒ Web query:\n\n`In JavaScript/Node.js, does Object.assign copy non-enumerable properties like Error.stack from an Error instance?`\n\n๐Ÿ’ก Result:\n\nNo, Object.assign does not copy non-enumerable properties li...
diff --git a/packages/tests/server/regression/issue-7272-node-vm-error-message.test.ts b/packages/tests/server/regression/issue-7272-node-vm-error-message.test.ts new file mode 100644 index 00000000000..88510cd70b3 --- /dev/null +++ b/packages/tests/server/regression/issue-7272-node-vm-error-message.test.ts @@ -0,0 +1,...
true
trpc/trpc
7,280
comment_to_fix
fix: error handling with Node VM
Could we get regressions tests for this please? There's a regression/ directory with a bunch of them. I need to be able to see a test fail before i merge something like this
f6e839f2b127b394fa1e9eb26bfe0c75c47fcbf2
671818a6c48f3d934717fcaaf04409852b43b615
diff --git a/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts b/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts index 7feb8609200..913a35e4bae 100644 --- a/packages/server/src/unstable-core-do-not-import/error/TRPCError.ts +++ b/packages/server/src/unstable-core-do-not-import/error/...
[ "packages/server/src/unstable-core-do-not-import/error/TRPCError.ts" ]
[ { "comment": "Could we get regressions tests for this please? There's a regression/ directory with a bunch of them. I need to be able to see a test fail before i merge something like this", "path": "packages/server/src/unstable-core-do-not-import/error/TRPCError.ts", "hunk": "@@ -22,7 +32,7 @@ export fu...
true
trpc/trpc
7,285
issue_to_patch
fix(www): render sponsor links in static HTML for SEO
## Problem The `SponsorBubbles` component renders **zero HTML** during Docusaurus SSG, making all sponsor links in the "All Sponsors" section invisible to search engine crawlers. **Root cause:** `@visx/responsive`'s `ParentSize` uses `useParentSize` which returns `{ width: 0 }` during SSG (no DOM/ResizeObserver). The...
9b42e02fa7acf2f203b4b1c77c12e41b7a04b4fb
31813da8085a04d9071bbbed2ed045a55791cec5
diff --git a/www/src/components/sponsors/SponsorBubbles.jsx b/www/src/components/sponsors/SponsorBubbles.jsx index 1f170c3fda4..4c4b139f193 100644 --- a/www/src/components/sponsors/SponsorBubbles.jsx +++ b/www/src/components/sponsors/SponsorBubbles.jsx @@ -23,7 +23,32 @@ export function SponsorBubbles() { return ( ...
[ "www/src/components/sponsors/SponsorBubbles.jsx" ]
[]
true
trpc/trpc
7,284
issue_to_patch
chore: Add superset config
Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed in the [Contributing guide](https://github.com/tr...
25b97f51ee4ee57da0da3c63cf54a50c6c8627d5
a1626da93017455c532fec48edbad4f835a22b72
diff --git a/.superset/config.json b/.superset/config.json new file mode 100644 index 00000000000..b5dd9c91521 --- /dev/null +++ b/.superset/config.json @@ -0,0 +1,4 @@ +{ + "setup": ["pnpm install"], + "teardown": [] +}
[ ".superset/config.json" ]
[]
true
trpc/trpc
7,191
issue_to_patch
bug: max batch size handling bypass ### Provide environment information Binaries: Node: 24.13.0 - ~/fnm_multishells/98932_1770386641777/bin/node pnpm: 10.17.1 - ~/fnm_multishells/98932_1770386641777/bin/pnpm npmPackages: @tanstack/react-query: catalog:react-query5 => 5.90.20 @trpc/client: catalog...
feat(server): max batch size
Closes #7153 ## ๐ŸŽฏ Changes Adds maxBatchSize to server adapters, validating at the earliest point possible during batch deserialisation <!-- Note: once you create a Pull request, we will automatically fix auto-fixable lint issues in your branch --> ## โœ… Checklist - [ ] I have followed the steps listed ...
e971f84240eca55a274e1ad6992d26ece7bcee2e
da548524755b52f3a2287486c52f570931e35253
diff --git a/packages/server/src/unstable-core-do-not-import/http/contentType.ts b/packages/server/src/unstable-core-do-not-import/http/contentType.ts index 570f8f84d62..bae425bdc08 100644 --- a/packages/server/src/unstable-core-do-not-import/http/contentType.ts +++ b/packages/server/src/unstable-core-do-not-import/htt...
[ "packages/server/src/unstable-core-do-not-import/http/contentType.ts", "packages/server/src/unstable-core-do-not-import/http/resolveResponse.ts", "packages/server/src/unstable-core-do-not-import/http/types.ts", "packages/tests/server/adapters/standalone.test.ts", "www/docs/client/links/httpBatchLink.md", ...
[ { "comment": "`maxBatchSize` is documented as applying to โ€œbatch callโ€ only, but the current check runs even when `batch=1` is not set. This means `maxBatchSize: 0` (or any value < 1) would also reject normal single (non-batched) requests. Consider gating this check behind `isBatchCall` (and/or clarifying the o...
diff --git a/packages/tests/server/adapters/standalone.test.ts b/packages/tests/server/adapters/standalone.test.ts index 5e68b226455..a61e02070ac 100644 --- a/packages/tests/server/adapters/standalone.test.ts +++ b/packages/tests/server/adapters/standalone.test.ts @@ -280,17 +280,7 @@ test('bad url does not crash serve...
true
trpc/trpc
7,191
comment_to_fix
feat(server): max batch size
`maxBatchSize` is documented as applying to โ€œbatch callโ€ only, but the current check runs even when `batch=1` is not set. This means `maxBatchSize: 0` (or any value < 1) would also reject normal single (non-batched) requests. Consider gating this check behind `isBatchCall` (and/or clarifying the option semantics to app...
e971f84240eca55a274e1ad6992d26ece7bcee2e
da548524755b52f3a2287486c52f570931e35253
diff --git a/packages/server/src/unstable-core-do-not-import/http/contentType.ts b/packages/server/src/unstable-core-do-not-import/http/contentType.ts index 570f8f84d62..bae425bdc08 100644 --- a/packages/server/src/unstable-core-do-not-import/http/contentType.ts +++ b/packages/server/src/unstable-core-do-not-import/htt...
[ "packages/server/src/unstable-core-do-not-import/http/contentType.ts" ]
[ { "comment": "`maxBatchSize` is documented as applying to โ€œbatch callโ€ only, but the current check runs even when `batch=1` is not set. This means `maxBatchSize: 0` (or any value < 1) would also reject normal single (non-batched) requests. Consider gating this check behind `isBatchCall` (and/or clarifying the o...
true
trpc/trpc
7,191
comment_to_fix
feat(server): max batch size
Even with `maxBatchSize` set, `opts.path.split(',')` will allocate an array proportional to the number of commas in the URL path before the size check runs. An attacker can still force large allocations by sending a huge comma-separated path. To make `maxBatchSize` an effective DoS mitigation, consider counting separat...
e971f84240eca55a274e1ad6992d26ece7bcee2e
da548524755b52f3a2287486c52f570931e35253
diff --git a/packages/server/src/unstable-core-do-not-import/http/contentType.ts b/packages/server/src/unstable-core-do-not-import/http/contentType.ts index 570f8f84d62..bae425bdc08 100644 --- a/packages/server/src/unstable-core-do-not-import/http/contentType.ts +++ b/packages/server/src/unstable-core-do-not-import/htt...
[ "packages/server/src/unstable-core-do-not-import/http/contentType.ts" ]
[ { "comment": "Even with `maxBatchSize` set, `opts.path.split(',')` will allocate an array proportional to the number of commas in the URL path before the size check runs. An attacker can still force large allocations by sending a huge comma-separated path. To make `maxBatchSize` an effective DoS mitigation, con...
true
trpc/trpc
7,191
comment_to_fix
feat(server): max batch size
`maxBatchSize` accepts any `number` at runtime (including `NaN`, `Infinity`, negatives, and non-integers). Some of these values effectively disable the limit (`NaN`) or reject all calls (negatives/0, especially if applied to non-batch requests). Consider validating that itโ€™s a finite positive integer (e.g. `Number.isSa...
e971f84240eca55a274e1ad6992d26ece7bcee2e
da548524755b52f3a2287486c52f570931e35253
diff --git a/packages/server/src/unstable-core-do-not-import/http/types.ts b/packages/server/src/unstable-core-do-not-import/http/types.ts index ed1fb16c27d..9bd4953f773 100644 --- a/packages/server/src/unstable-core-do-not-import/http/types.ts +++ b/packages/server/src/unstable-core-do-not-import/http/types.ts @@ -158...
[ "packages/server/src/unstable-core-do-not-import/http/types.ts" ]
[ { "comment": "`maxBatchSize` accepts any `number` at runtime (including `NaN`, `Infinity`, negatives, and non-integers). Some of these values effectively disable the limit (`NaN`) or reject all calls (negatives/0, especially if applied to non-batch requests). Consider validating that itโ€™s a finite positive inte...
true
trpc/trpc
7,191
comment_to_fix
feat(server): max batch size
This doc section removes the previous โ€œLimiting Batch Sizeโ€ guidance but doesnโ€™t add any replacement documenting the new `maxBatchSize` adapter option. As a result, thereโ€™s no longer an obvious place in the docs explaining how to configure batch limits server-side. Consider adding a short section here (or linking to th...
e971f84240eca55a274e1ad6992d26ece7bcee2e
da548524755b52f3a2287486c52f570931e35253
diff --git a/www/docs/server/context.md b/www/docs/server/context.md index 6d32813bae9..a95db955d81 100644 --- a/www/docs/server/context.md +++ b/www/docs/server/context.md @@ -296,27 +296,3 @@ export const apiProcedure = publicProcedure.use((opts) => { }); }); ``` - -## Limiting Batch Size - -You can use the cont...
[ "www/docs/server/context.md" ]
[ { "comment": "This doc section removes the previous โ€œLimiting Batch Sizeโ€ guidance but doesnโ€™t add any replacement documenting the new `maxBatchSize` adapter option. As a result, thereโ€™s no longer an obvious place in the docs explaining how to configure batch limits server-side. Consider adding a short section ...
true
trpc/trpc
7,270
issue_to_patch
fix: empty string fallback on pathExtractor
I'm not 100% about this usage is ok or not ref #7269 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated documentation examples to safely handle potentially undefined metadata by using optional chaining and a safe empty-string fallback...
7d9bb2e1aa3ab0494488e7d555faee227a93dc27
5d116f9f363735139c6a65dda58a516cdd6300aa
diff --git a/www/docs/client/nextjs/app-router/server-actions.mdx b/www/docs/client/nextjs/app-router/server-actions.mdx index f6fe56338a9..926b48f6a3a 100644 --- a/www/docs/client/nextjs/app-router/server-actions.mdx +++ b/www/docs/client/nextjs/app-router/server-actions.mdx @@ -31,7 +31,7 @@ export const t = initTRPC...
[ "www/docs/client/nextjs/app-router/server-actions.mdx" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Fix is incomplete: one unsafe `pathExtractor` example remains.**\n\nThese updated snippets are safe, but Line 122 still uses `(meta as Meta).span` without fallback. That leaves the same runtime failure mode in one copy-pasteable example and makes the docs inc...
true
trpc/trpc
7,270
comment_to_fix
fix: empty string fallback on pathExtractor
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ **Fix is incomplete: one unsafe `pathExtractor` example remains.** These updated snippets are safe, but Line 122 still uses `(meta as Meta).span` without fallback. That leaves the same runtime failure mode in one copy-pasteable example and makes the docs inconsistent with this PRโ€™s g...
7d9bb2e1aa3ab0494488e7d555faee227a93dc27
5d116f9f363735139c6a65dda58a516cdd6300aa
diff --git a/www/docs/client/nextjs/app-router/server-actions.mdx b/www/docs/client/nextjs/app-router/server-actions.mdx index f6fe56338a9..926b48f6a3a 100644 --- a/www/docs/client/nextjs/app-router/server-actions.mdx +++ b/www/docs/client/nextjs/app-router/server-actions.mdx @@ -31,7 +31,7 @@ export const t = initTRPC...
[ "www/docs/client/nextjs/app-router/server-actions.mdx" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n**Fix is incomplete: one unsafe `pathExtractor` example remains.**\n\nThese updated snippets are safe, but Line 122 still uses `(meta as Meta).span` without fallback. That leaves the same runtime failure mode in one copy-pasteable example and makes the docs inc...
true
trpc/trpc
7,277
issue_to_patch
chore(deps): update actions/setup-node action to v6
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://redirect.github.com/actions/setup-node) | action | major | `v4` โ†’ `v6` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v6`](https://redire...
b682e395881d3b6a49cf68338e58d5f714bc2e51
cf1bfca56d9e5da76c76283e1335edee6235d6a5
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml index 2573999b116..a35e9cf41dd 100644 --- a/.github/workflows/check-skills.yml +++ b/.github/workflows/check-skills.yml @@ -31,7 +31,7 @@ jobs: fetch-depth: 0 - name: Setup Node - uses: actions/setup-node@v4 ...
[ ".github/workflows/check-skills.yml", ".github/workflows/validate-skills.yml" ]
[]
true
trpc/trpc
7,278
issue_to_patch
chore(deps): update peter-evans/repository-dispatch action to v4
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [peter-evans/repository-dispatch](https://redirect.github.com/peter-evans/repository-dispatch) | action | major | `v3` โ†’ `v4` | --- ### Release Notes <details> <summary>peter-evans/repository-dispatch (peter-evans/repos...
f3df74b7886f3c6b33c2e969213ce2d645ae7803
100e8bfeb5c69076a7308828354fa96b845ec1e7
diff --git a/.github/workflows/notify-intent.yml b/.github/workflows/notify-intent.yml index cfba6203a94..c91d3e584b6 100644 --- a/.github/workflows/notify-intent.yml +++ b/.github/workflows/notify-intent.yml @@ -42,7 +42,7 @@ jobs: echo "files=$FILES" >> "$GITHUB_OUTPUT" - name: Dispatch to intent ...
[ ".github/workflows/notify-intent.yml" ]
[]
true
trpc/trpc
7,233
issue_to_patch
bug: httpBatchStreamLink loses buffered chunks on normal stream completion due to closeOrAbort using controller.error() instead of controller.close() ### Provide environment information ``` System: OS: macOS 26.2 CPU: (10) arm64 Apple M1 Max Memory: 78.77 MB / 32.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: ...
fix: preserve buffered chunks on stream close in httpBatchStreamLink
## Summary Fixes #7209 When using `httpBatchStreamLink`, normal stream completion was causing buffered chunks to be silently discarded because both `close` and `abort` handlers called `controller.error()` via `closeOrAbort`. Per the [WHATWG Streams spec](https://streams.spec.whatwg.org/#rs-default-controller-error),...
5b0a4378f4bc5613ffc499c4781c549570799fbd
3cffe797ca63441b05a8093c0302a2495afa7ec8
diff --git a/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts b/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts index 3013ad54313..ef2d1954073 100644 --- a/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts +++ b/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts...
[ "packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts", "packages/server/src/unstable-core-do-not-import/stream/jsonl.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Potential edge case: `headDeferred` may hang if stream closes before head is received.**\n\nIf the source stream closes normally but before sending any data (e.g., an empty response), `headDeferred` will never resolve since `handleClose` only calls `streamMan...
diff --git a/packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts b/packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts index aa10b6da42b..1094ee741c2 100644 --- a/packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts +++ b/packages/server/src/unstable-core-do-not-import/...
true
trpc/trpc
7,233
comment_to_fix
fix: preserve buffered chunks on stream close in httpBatchStreamLink
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Potential edge case: `headDeferred` may hang if stream closes before head is received.** If the source stream closes normally but before sending any data (e.g., an empty response), `headDeferred` will never resolve since `handleClose` only calls `streamManager.closeAll()` and doesn...
5b0a4378f4bc5613ffc499c4781c549570799fbd
3cffe797ca63441b05a8093c0302a2495afa7ec8
diff --git a/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts b/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts index 3013ad54313..ef2d1954073 100644 --- a/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts +++ b/packages/server/src/unstable-core-do-not-import/stream/jsonl.ts...
[ "packages/server/src/unstable-core-do-not-import/stream/jsonl.ts" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Potential edge case: `headDeferred` may hang if stream closes before head is received.**\n\nIf the source stream closes normally but before sending any data (e.g., an empty response), `headDeferred` will never resolve since `handleClose` only calls `streamMan...
true
trpc/trpc
7,252
issue_to_patch
feat: Tanstack Intent Skills
- **Add package** - **Add generated skills and artifacts** - **docs: add AI agents installation instructions across multiple README files** Closes # ## ๐ŸŽฏ Changes What changes are made in this PR? Is it a feature or a bug fix? <!-- Note: once you create a Pull request, we will automatically fix auto-fixa...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/.github/workflows/check-skills.yml b/.github/workflows/check-skills.yml new file mode 100644 index 00000000000..9435aead66c --- /dev/null +++ b/.github/workflows/check-skills.yml @@ -0,0 +1,143 @@ +# check-skills.yml โ€” Drop this into your library repo's .github/workflows/ +# +# Checks for stale intent skil...
[ ".github/workflows/check-skills.yml", ".github/workflows/notify-intent.yml", ".github/workflows/validate-skills.yml", ".gitignore", "README.md", "_artifacts/domain_map.yaml", "_artifacts/skill_spec.md", "_artifacts/skill_tree.yaml", "package.json", "packages/client/README.md", "packages/client/b...
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but there is no `bin/intent.js` (or even a `bin/` directory) in this package in the PR. This will make the published package expose a broken CLI entry. Either add the referenced file (and ensure itโ€™s included in `files`) or remove the `bin` entry if the CL...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` points to `./bin/intent.js`, but there is no `bin/intent.js` (or even a `bin/` directory) in this package in the PR. This will make the published package expose a broken CLI entry. Either add the referenced file (and ensure itโ€™s included in `files`) or remove the `bin` entry if the CLI isnโ€™t meant to ship ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "`bin.intent` points to `./bin/intent.js`, but there is no `bin/intent.js` (or even a `bin/` directory) in this package in the PR. This will make the published package expose a broken CLI entry. Either add the referenced file (and ensure itโ€™s included in `files`) or remove the `bin` entry if the CL...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package exports a `bin` named `intent` pointing at `./bin/intent.js`, but the `bin/` directory / file is not present in the PR. Also, multiple `@trpc/*` packages in this PR define the same `bin` name (`intent`), which will collide when users install more than one package (a common case). Consider shipping the CLI ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "This package exports a `bin` named `intent` pointing at `./bin/intent.js`, but the `bin/` directory / file is not present in the PR. Also, multiple `@trpc/*` packages in this PR define the same `bin` name (`intent`), which will collide when users install more than one package (a common case). Cons...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
`bin.intent` references `./bin/intent.js`, but thereโ€™s no `bin/intent.js` in this package in the PR (searching the repo shows no matches). This will publish a broken CLI entry. Either add the file or drop the `bin` field. Also, exporting the same `intent` bin from multiple `@trpc/*` packages will cause `.bin/intent` co...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/package.json b/packages/server/package.json index 373f0003788..58f27aa6ce4 100644 --- a/packages/server/package.json +++ b/packages/server/package.json @@ -187,7 +187,10 @@ "shared", "unstable-core-do-not-import", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + ...
[ "packages/server/package.json" ]
[ { "comment": "`bin.intent` references `./bin/intent.js`, but thereโ€™s no `bin/intent.js` in this package in the PR (searching the repo shows no matches). This will publish a broken CLI entry. Either add the file or drop the `bin` field. Also, exporting the same `intent` bin from multiple `@trpc/*` packages will ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
This package declares a `bin` entry `intent: ./bin/intent.js`, but there is no `bin/intent.js` (or `bin/` directory) included in the PR. That will break the published CLI. Either add the script or remove the `bin` entry; if the goal is a single shared CLI, avoid having multiple `@trpc/*` packages export the same `inten...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/tanstack-react-query/package.json b/packages/tanstack-react-query/package.json index 090979c49dd..d59e6ce9a9d 100644 --- a/packages/tanstack-react-query/package.json +++ b/packages/tanstack-react-query/package.json @@ -39,7 +39,10 @@ "README.md", "package.json", "!**/*.test.*", - ...
[ "packages/tanstack-react-query/package.json" ]
[ { "comment": "This package declares a `bin` entry `intent: ./bin/intent.js`, but there is no `bin/intent.js` (or `bin/` directory) included in the PR. That will break the published CLI. Either add the script or remove the `bin` entry; if the goal is a single shared CLI, avoid having multiple `@trpc/*` packages ...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
File header comment says `# skills/_artifacts/skill_tree.yaml` but the file lives at `/_artifacts/skill_tree.yaml`. If the header is meant to reflect the actual path (useful for generated artifacts), update it to avoid confusion.
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/_artifacts/skill_tree.yaml b/_artifacts/skill_tree.yaml new file mode 100644 index 00000000000..a53e9690b9c --- /dev/null +++ b/_artifacts/skill_tree.yaml @@ -0,0 +1,485 @@ +# _artifacts/skill_tree.yaml +library: + name: '@trpc/server' + version: '11.14.0' + repository: 'https://github.com/trpc/trpc' + ...
[ "_artifacts/skill_tree.yaml" ]
[ { "comment": "File header comment says `# skills/_artifacts/skill_tree.yaml` but the file lives at `/_artifacts/skill_tree.yaml`. If the header is meant to reflect the actual path (useful for generated artifacts), update it to avoid confusion.\n", "path": "_artifacts/skill_tree.yaml", "hunk": "@@ -0,0 +...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Inconsistency: Auth failure mode count.** The Skill Inventory table (line 43) lists auth with "5" failure modes, but the "auth (5 failure modes)" section only contains 4 entries (lines 218-221). Either update the table count to 4, or add the missing 5th failure mode. <details> <su...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/_artifacts/skill_spec.md b/_artifacts/skill_spec.md new file mode 100644 index 00000000000..caa79108451 --- /dev/null +++ b/_artifacts/skill_spec.md @@ -0,0 +1,300 @@ +# tRPC โ€” Skill Spec + +tRPC is a TypeScript framework for building end-to-end typesafe APIs without +schemas or code generation. It lets yo...
[ "_artifacts/skill_spec.md" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Inconsistency: Auth failure mode count.**\n\nThe Skill Inventory table (line 43) lists auth with \"5\" failure modes, but the \"auth (5 failure modes)\" section only contains 4 entries (lines 218-221). Either update the table count to 4, or add the missing 5t...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell # Check if packages/client/bin/intent.js exists find packages/client -name "intent.js" -type f 2>/dev/null # Also check the full bin directory structure ls -la packages/client/bin/ 2>/dev/null || echo "bin ...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/package.json b/packages/client/package.json index 1fae648eaf9..bfd4afe5ca4 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -109,13 +109,17 @@ "links", "unstable-internals", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills...
[ "packages/client/package.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n# Check if packages/client/bin/intent.js exists\nfind packages/client -name \"intent.js\" -type f 2>/dev/null\n\n# Also check the full bin directory structure\nls -la packages/c...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_ **Missing `httpSubscriptionLink` import in the `splitLink` snippet.** Line 87 uses `httpSubscriptionLink`, but it isnโ€™t imported in Line 83. <details> <summary>Suggested doc fix</summary> ```diff -import { splitLink, httpBatchLink, httpLink } from '@trpc/client'; +import { + split...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/client/skills/links/references/link-options.md b/packages/client/skills/links/references/link-options.md new file mode 100644 index 00000000000..55e649d8fd8 --- /dev/null +++ b/packages/client/skills/links/references/link-options.md @@ -0,0 +1,248 @@ +# Link Options Reference + +## httpLink + +Ter...
[ "packages/client/skills/links/references/link-options.md" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸก Minor_\n\n**Missing `httpSubscriptionLink` import in the `splitLink` snippet.**\n\nLine 87 uses `httpSubscriptionLink`, but it isnโ€™t imported in Line 83.\n\n<details>\n<summary>Suggested doc fix</summary>\n\n```diff\n-import { splitLink, httpBatchLink, httpLink } from '@...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell #!/bin/bash set -euo pipefail echo "Packages declaring intent bin:" rg -n '"intent"\s*:\s*"\./bin/intent\.js"' packages -g 'package.json' -C2 echo echo "Checking bin target existence next to each manife...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/next/package.json b/packages/next/package.json index bdf36f5c1d6..6942604e82f 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -100,7 +100,10 @@ "app-dir", "ssrPrepass", "!**/*.test.*", - "!**/__tests__" + "!**/__tests__", + "skills", + "!skill...
[ "packages/next/package.json" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐Ÿ”ด Critical_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"Packages declaring intent bin:\"\nrg -n '\"intent\"\\s*:\\s*\"\\./bin/intent\\.js\"' packages -g 'package.json' -C2\n\necho\necho \"C...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_ <details> <summary>๐Ÿงฉ Analysis chain</summary> ๐Ÿ Script executed: ```shell #!/bin/bash set -euo pipefail echo "Check the SKILL snippet:" rg -n 'TRPCDataTransformer|Document|ejsonTransformer' \ packages/openapi/skills/openapi/SKILL.md -C2 echo echo "Check whether TRPCDataTransfo...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/openapi/skills/openapi/SKILL.md b/packages/openapi/skills/openapi/SKILL.md new file mode 100644 index 00000000000..3eb7ced8c0b --- /dev/null +++ b/packages/openapi/skills/openapi/SKILL.md @@ -0,0 +1,300 @@ +--- +name: openapi +description: > + Generate OpenAPI 3.1 spec from a tRPC router with @tr...
[ "packages/openapi/skills/openapi/SKILL.md" ]
[ { "comment": "_โš ๏ธ Potential issue_ | _๐ŸŸ  Major_\n\n<details>\n<summary>๐Ÿงฉ Analysis chain</summary>\n\n๐Ÿ Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"Check the SKILL snippet:\"\nrg -n 'TRPCDataTransformer|Document|ejsonTransformer' \\\n packages/openapi/skills/openapi/SKILL.md -C2\n\n...
true
trpc/trpc
7,252
comment_to_fix
feat: Tanstack Intent Skills
_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_ **Add error handling consistent with the basic setup example.** The basic setup example (lines 67-75) properly wraps `server.listen()` in an async IIFE with try/catch error handling, but this WebSocket example calls `server.listen()` without awaiting or handling errors. This inc...
6e03f5c2f8d8ebaa237747d2db447737393402c6
cab33f299950f93dea50e5e6cd88f87fa44a83ac
diff --git a/packages/server/skills/adapter-fastify/SKILL.md b/packages/server/skills/adapter-fastify/SKILL.md new file mode 100644 index 00000000000..cc396baf958 --- /dev/null +++ b/packages/server/skills/adapter-fastify/SKILL.md @@ -0,0 +1,206 @@ +--- +name: adapter-fastify +description: > + Mount tRPC as a Fastify ...
[ "packages/server/skills/adapter-fastify/SKILL.md" ]
[ { "comment": "_๐Ÿ› ๏ธ Refactor suggestion_ | _๐ŸŸ  Major_\n\n**Add error handling consistent with the basic setup example.**\n\nThe basic setup example (lines 67-75) properly wraps `server.listen()` in an async IIFE with try/catch error handling, but this WebSocket example calls `server.listen()` without awaiting or...
true