repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
twitter/algebird | 901 | issue_to_patch | Update sbt-scalafix to 0.9.24 | Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.23 to 0.9.24.
[GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.24) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.23...v0.9.24)
I'll automatically update this PR to ... | 45c60ae4f0d44c0d940dd8f5dfc9545d2f78fc23 | 75aca7f79ac48428ecba46c7d2a52c50825da39d | diff --git a/project/plugins.sbt b/project/plugins.sbt
index dfeb50446..4be093388 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1")
addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3")
addSbtPlugin("org.scoverage" % "sbt-scove... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 1,136 | issue_to_patch | Update sbt-mima-plugin to 1.1.3 | ## About this PR
📦 Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from `1.1.2` to `1.1.3`
📜 [GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/1.1.3) - [Version Diff](https://github.com/lightbend/mima/compare/1.1.2...1.1.3)
## Usage
✅ **Please merge!**
I'll automatical... | 78c4971ac1a4f6c1fa504956aa3f97a0e7596873 | d5417e62ad8f9a1f89d162fd695658a84c96fbe4 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index fbbc86a0c..321afd444 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.4.3")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
addSbtPlugin("org.scalameta" %... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 1,112 | issue_to_patch | Update sbt-mima-plugin to 1.1.2 | ## About this PR
📦 Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from `1.1.1` to `1.1.2`
📜 [GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/1.1.2) - [Version Diff](https://github.com/lightbend/mima/compare/1.1.1...1.1.2)
## Usage
✅ **Please merge!**
I'll automatical... | f644ba451a9892858df1b1c57fa530a843e9bf20 | cc52f5f0bc4d534f5301b39990a4c62943328ca6 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 4ac14cfc1..a3b52b249 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.4.2")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
addSbtPlugin("org.scalameta" %... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 1,081 | issue_to_patch | Update sbt-mima-plugin to 1.1.1 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 1.1.0 to 1.1.1.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/1.1.1) - [Version Diff](https://github.com/lightbend/mima/compare/1.1.0...1.1.1)
I'll automatically update this PR to resolve conflicts as long as you don... | 3cefba6a62d27924e2348261e21e95471cfabb47 | e478ae28181bef5f916e69d218391f72322b8ca8 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 534e41ac1..9b0eefa50 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
addSbtPlugin("org.scalameta" %... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 1,060 | issue_to_patch | Update sbt-mima-plugin to 1.1.0 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 1.0.1 to 1.1.0.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/1.1.0) - [Version Diff](https://github.com/lightbend/mima/compare/1.0.1...1.1.0)
I'll automatically update this PR to resolve conflicts as long as you don... | 3cceaae19b29cc91f1f60b82d40ef20df34fdff9 | f8e66f76c04eadc82ab8e87a9055ebc787c8bb79 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 69feeebd1..8141974c9 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
addSbtPlugin("org.scalameta" %... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 1,013 | issue_to_patch | Update sbt-mima-plugin to 1.0.1 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 1.0.0 to 1.0.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments belo... | 06b588a36c5123fbd57fab46d9924bb1fd6ca310 | 73087f77940282a264f96e8806fed67398f5f105 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 777122f3c..a01746968 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
addSbtPlugin("org.scalameta" % "... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 995 | issue_to_patch | Update sbt-mima-plugin to 1.0.0 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 0.9.2 to 1.0.0.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/1.0.0) - [Version Diff](https://github.com/lightbend/mima/compare/0.9.2...1.0.0)
I'll automatically update this PR to resolve conflicts as long as you don... | 00e12ac88da12039d3562fc1c535538aab305809 | e26321ce298228cf73f9441770c0ea5bc8d64cbf | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 740f326a5..b43cebff2 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
addSbtPlugin("org.scalameta" % "... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 980 | issue_to_patch | Update sbt-mima-plugin to 0.9.2 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 0.9.1 to 0.9.2.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/0.9.2) - [Version Diff](https://github.com/lightbend/mima/compare/0.9.1...0.9.2)
I'll automatically update this PR to resolve conflicts as long as you don... | c81ee2eb9234ff1a84e5f092fe05ca4715e62a79 | 226f4f02437d0c52a4d95fa84dbb6c532e2d05e9 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 48d429a4b..0217da08e 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
addSbtPlugin("org.scalameta" % "... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 964 | issue_to_patch | Update sbt-mima-plugin to 0.9.1 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 0.9.0 to 0.9.1.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/0.9.1) - [Version Diff](https://github.com/lightbend/mima/compare/0.9.0...0.9.1)
I'll automatically update this PR to resolve conflicts as long as you don... | d2a60d4617a411ea8404c8a75a592c8e8544213f | 66845867faf157b01e158680245b9b3bfd38a2a8 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 65b5873c8..ce4d89a1d 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
addSbtPlugin("org.scalameta" % "... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/algebird | 952 | issue_to_patch | Update sbt-mima-plugin to 0.9.0 | Updates [com.typesafe:sbt-mima-plugin](https://github.com/lightbend/mima) from 0.8.1 to 0.9.0.
[GitHub Release Notes](https://github.com/lightbend/mima/releases/tag/0.9.0) - [Version Diff](https://github.com/lightbend/mima/compare/0.8.1...0.9.0)
I'll automatically update this PR to resolve conflicts as long as you don... | b8fd9f9a2c7aad53c0ee1a165c14887d2fb54242 | a0f18f39812248b1283f430134a748a21af66ec4 | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 4c8e3315b..afae9481a 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -8,7 +8,7 @@ resolvers ++= Seq(
addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4")
addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3")
addSbtPlugin("org.scalameta" % "... | [
"project/plugins.sbt"
] | [] | true | ||
twitter/finagle | 928 | issue_to_patch | fix some typos | c6060de877b97936ef2ca54431a4539f6ee06c78 | b0f802633c74b0ba163a5ba120639870d9c6d8b0 | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 627754fd859..2c61bded70e 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -852,7 +852,7 @@ Bug Fixes
Runtime Behavior Changes
~~~~~~~~~~~~~~~~~~~~~~~~
-* finagle-memcached: The key in `RetrievalCommand` are ommited in traces. The total number of Hits
+* finagle-memc... | [
"CHANGELOG.rst",
"finagle-base-http/src/test/scala/com/twitter/finagle/http/codec/ResponseConformanceFilterTest.scala",
"finagle-benchmark/src/main/scripts/build_graphs.R"
] | [] | diff --git a/finagle-base-http/src/test/scala/com/twitter/finagle/http/codec/ResponseConformanceFilterTest.scala b/finagle-base-http/src/test/scala/com/twitter/finagle/http/codec/ResponseConformanceFilterTest.scala
index 8ffaa097298..d888fec0b96 100644
--- a/finagle-base-http/src/test/scala/com/twitter/finagle/http/cod... | true | ||
twitter/finagle | 112 | issue_to_patch | Don't say "get sbt". Clarify: can't build w/Maven. Don't repeat version num | bad753017ae33d968112537ad2e8a307d6367aae | 02e236685d633f99ef3a149ab7efc601c8b6f875 | diff --git a/index.html b/index.html
index 34cb3cf65d9..026b2344f5e 100644
--- a/index.html
+++ b/index.html
@@ -82,8 +82,6 @@ <h6>Join in</h6>
<h6>Fork on GitHub</h6>
<p>Download, fork, pull, file issues, and more with the official Finagle repo on Github.</p>
<p><a target="_blank... | [
"index.html"
] | [] | true | |||
twitter/finagle | 8 | issue_to_patch | Copy channel buffer after decode line | dda5a71ce7e6a8261efa47d8ccf072c7d13152ce | dc4c16b4acfe601d376afd48bde3f31bcfbcfd77 | diff --git a/finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ChannelBufferUtils.scala b/finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ChannelBufferUtils.scala
index 9241e5c9e08..5fee09a5588 100644
--- a/finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/Channel... | [
"finagle-memcached/src/main/scala/com/twitter/finagle/memcached/util/ChannelBufferUtils.scala"
] | [] | true | |||
twitter/finagle | 9 | issue_to_patch | Add finagle-ostrich4 | dda5a71ce7e6a8261efa47d8ccf072c7d13152ce | 8e635b0f6843e6d53ff5a3712b94da033e976fcc | diff --git a/finagle-ostrich4/src/main/scala/com/twitter/finagle/builder/ServerBuilderToTwitterService.scala b/finagle-ostrich4/src/main/scala/com/twitter/finagle/builder/ServerBuilderToTwitterService.scala
new file mode 100644
index 00000000000..31d9b03788d
--- /dev/null
+++ b/finagle-ostrich4/src/main/scala/com/twitt... | [
"finagle-ostrich4/src/main/scala/com/twitter/finagle/builder/ServerBuilderToTwitterService.scala",
"finagle-ostrich4/src/main/scala/com/twitter/finagle/stats/OstrichStatsReceiver.scala",
"project/build/Project.scala"
] | [] | true | |||
twitter/finatra | 347 | issue_to_patch | Updated user-guide/getting-started markdown | **Problem**
Due to an additional padding of 60px for 'anchor' class, the user can not access links just above the anchor.
E.g. On [User Guide -> Getting Started](http://twitter.github.io/finatra/user-guide/getting-started/) page, the link for _Filters_ is not accessible.
**Solution**
Changed class name from 'anchor'... | bd313f62671eb90c8931076939fe06cd03d52390 | 9b707a9362cdec45b3e0f6d121e4c52ac1f2646a | diff --git a/source/user-guide/getting-started/index.markdown b/source/user-guide/getting-started/index.markdown
index 090f260831..67efa3b0b9 100644
--- a/source/user-guide/getting-started/index.markdown
+++ b/source/user-guide/getting-started/index.markdown
@@ -13,7 +13,7 @@ footer: true
Finatra at it's core is agn... | [
"source/user-guide/getting-started/index.markdown"
] | [] | true | ||
twitter/finatra | 336 | issue_to_patch | Added new blog post announcing 2.2.0 | Problem
We're releasing Finatra v2.2.0 which has some major changes.
Solution
Let's write a blog post about it!
Result
Users will be informed of major updates, fixes and changes.
| b6dd73e0cb0a152e90dbcc1b295eee765c9e5abe | 1fe38a975b31d36425d84bded3a3be256f247eb8 | diff --git a/source/_posts/2016-04-28-announcing-the-release-of-finatra-v2-dot-1-6.markdown b/source/_posts/2016-04-28-announcing-the-release-of-finatra-v2-dot-1-6.markdown
index d7951bebdc..858bcdd110 100644
--- a/source/_posts/2016-04-28-announcing-the-release-of-finatra-v2-dot-1-6.markdown
+++ b/source/_posts/2016-0... | [
"source/_posts/2016-04-28-announcing-the-release-of-finatra-v2-dot-1-6.markdown",
"source/_posts/2016-06-30-announcing-finatra-v2-dot-2-0.markdown"
] | [] | true | ||
twitter/finatra | 265 | issue_to_patch | Remove unneccesary files | f1437ae7c0b7da57d4a7b631153737de2813e51f | 4b0ce03e7b2c4c75c0bddca201e2801640373d05 | diff --git a/benchmarks/BUILD b/benchmarks/BUILD
deleted file mode 100644
index 7bac465146..0000000000
--- a/benchmarks/BUILD
+++ /dev/null
@@ -1,13 +0,0 @@
-maven_layout()
-
-target(name='benchmarks',
- dependencies=[
- 'finatra/benchmarks/src/main/scala'
- ]
-)
-
-target(name='tests',
- dependencies=[
- 'fin... | [
"benchmarks/BUILD",
"benchmarks/CONFIG.ini",
"benchmarks/src/main/java/BUILD",
"benchmarks/src/main/scala/BUILD",
"benchmarks/src/test/scala/BUILD",
"examples/BUILD",
"examples/benchmark-server/BUILD",
"examples/benchmark-server/src/main/resources/BUILD",
"examples/benchmark-server/src/main/scala/BU... | [] | diff --git a/benchmarks/src/test/scala/BUILD b/benchmarks/src/test/scala/BUILD
deleted file mode 100644
index add72866a2..0000000000
--- a/benchmarks/src/test/scala/BUILD
+++ /dev/null
@@ -1,9 +0,0 @@
-junit_tests(
- name='scala',
- dependencies=[
- 'finatra/benchmarks',
- 'finatra/http:test-deps',
- 'finatr... | true | ||
twitter/finatra | 258 | issue_to_patch | finatra/inject - Rename InjectUtils to more specific PoolUtils | 4d8e32cc5c5c55d841d39d6d79b142a2b82b5be5 | f72b44c3df184570a897c79ccb31aebc8dc2281b | [
"http/src/test/scala/com/twitter/finatra/http/test/HttpTest.scala",
"inject/inject-app/src/test/scala/com/twitter/inject/app/EmbeddedApp.scala",
"inject/inject-core/src/test/scala/com/twitter/inject/PoolUtils.scala"
] | [] | diff --git a/http/src/test/scala/com/twitter/finatra/http/test/HttpTest.scala b/http/src/test/scala/com/twitter/finatra/http/test/HttpTest.scala
index 1a99d6473e..6fe53de175 100644
--- a/http/src/test/scala/com/twitter/finatra/http/test/HttpTest.scala
+++ b/http/src/test/scala/com/twitter/finatra/http/test/HttpTest.sca... | true | |||
twitter/finatra | 251 | issue_to_patch | Update TweetsControllerIntegrationTest.scala | 556de8acde8148bde03d527b5817108b37a13f58 | ae83aa4d422f10ee749513442472e90453bd7c12 | [
"http/src/test/scala/com/twitter/finatra/http/integration/tweetexample/test/TweetsControllerIntegrationTest.scala",
"http/src/test/scala/com/twitter/finatra/http/test/HttpTest.scala",
"inject/inject-app/src/test/scala/com/twitter/inject/app/EmbeddedApp.scala",
"inject/inject-app/src/test/scala/com/twitter/inj... | [] | diff --git a/http/src/test/scala/com/twitter/finatra/http/integration/tweetexample/test/TweetsControllerIntegrationTest.scala b/http/src/test/scala/com/twitter/finatra/http/integration/tweetexample/test/TweetsControllerIntegrationTest.scala
index f352d83241..051d81b785 100644
--- a/http/src/test/scala/com/twitter/finat... | true | |||
twitter/finatra | 244 | issue_to_patch | Update Travis CI to build with java8 fix. | f3926d4b9178067f55d829642263a998dda6b487 | 5b5d60dc5f2a9700d11f2254a34a941200b380ef | diff --git a/.travis.yml b/.travis.yml
index 5d41c806fd..181024af9e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,6 +14,10 @@ before_script:
# default $SBT_OPTS is irrelevant to sbt lancher
- unset SBT_OPTS
+before_script:
+ # default $SBT_OPTS is irrelevant to sbt lancher
+ - unset SBT_OPTS
+
script:
... | [
".travis.yml",
"build.sbt",
"sbt"
] | [] | true | |||
twitter/finatra | 242 | issue_to_patch | Scosenza update readmes | 9c37c84009e7d5add51e25459e169ef654c7e41e | 2f8074aa3908bacc42408adc6a81052042528af9 | diff --git a/README.md b/README.md
index 79a331c9e0..e01d9f8c0c 100644
--- a/README.md
+++ b/README.md
@@ -18,14 +18,18 @@ Features
* Optional JSR-330 Dependency Injection using [Google Guice][guice]
* [Jackson][jackson] based JSON parsing supporting required fields, default values, and custom validations
* [Logback... | [
"README.md",
"http/README.md"
] | [] | true | |||
twitter/finatra | 238 | issue_to_patch | Update warmup docs | 033f9a874db494279821a39ffb3f75ccfeb8b053 | b7d8e180dbaa4a66de2f77db30a19bb13262c4a1 | diff --git a/http/README.md b/http/README.md
index fd701bf831..5e0b7db71c 100644
--- a/http/README.md
+++ b/http/README.md
@@ -650,7 +650,7 @@ class Server extends HttpServer {
Warmup
===============================
-Finatra server provides a *warmup* method that's called before the server's external HTTP port is b... | [
"http/README.md"
] | [] | true | |||
twitter/finatra | 217 | issue_to_patch | Change Google Analytics tracking to use Twitter OSS account | @scosenza, @cacoco, this is a new property tied to the official Twitter OSS Google Analytics account.
| 67938be36d1fc50b4a30e01a53bc5ab7299e3c50 | a7d09e3d6a57e40a34f3d132d688cdaabb19707d | diff --git a/source/_layouts/finatra.html b/source/_layouts/finatra.html
index ebed2da85e..295d9910ea 100644
--- a/source/_layouts/finatra.html
+++ b/source/_layouts/finatra.html
@@ -91,7 +91,7 @@
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.... | [
"source/_layouts/finatra.html",
"source/_layouts/finatrav1.html"
] | [] | true | ||
twitter/finatra | 202 | issue_to_patch | Update README.md | bbe0e9afefd236b117309fd7152ecc4f02ddaf71 | 402237073b077b1a3ce9c11389252633d1d4bbf5 | diff --git a/README.md b/README.md
index b4c749859a..ba45da4480 100644
--- a/README.md
+++ b/README.md
@@ -1,10 +1,9 @@
Finatra
==========================================================
-The scala service framework inspired by [Sinatra](http://www.sinatrarb.com/) powered by [`twitter-server`][twitter-server].
+Fast,... | [
"README.md"
] | [] | true | |||
twitter/finatra | 179 | issue_to_patch | remove dependency on scalatest | currently, finatra will pull in scalatest in an outdated version, which
will cause version conflicts with upstream projects that want to use
newer versions. the only reason for this seems to be the FlatSpecHelper,
which is a one-liner only mixing in the Helper trait. Pull request #59
was already supposed to "Let people... | 0b9fce0c1525a1aa88a80c586df8abed486017f0 | 5c2395f835044b05e9d7e22c2092e0f66acb85ad | diff --git a/build.sbt b/build.sbt
index c357740bca..9fc26e842e 100644
--- a/build.sbt
+++ b/build.sbt
@@ -13,7 +13,7 @@ crossScalaVersions := Seq("2.9.2", "2.10.3")
libraryDependencies ++= Seq(
"com.twitter" %% "twitter-server" % "1.8.0",
"commons-io" % "commons-io" % "1.3.2",
- "org.scalatest" %% "scalatest" ... | [
"build.sbt",
"src/test/scala/com/twitter/finatra/test/FlatSpecHelper.scala"
] | [] | diff --git a/src/main/scala/com/twitter/finatra/test/FlatSpecHelper.scala b/src/test/scala/com/twitter/finatra/test/FlatSpecHelper.scala
similarity index 100%
rename from src/main/scala/com/twitter/finatra/test/FlatSpecHelper.scala
rename to src/test/scala/com/twitter/finatra/test/FlatSpecHelper.scala
| true | |
twitter/finatra | 188 | issue_to_patch | FIX: issue #182, let controller's error handler handle its own errors. | This is a partial fix for issue #182. It allows a controller's error handler to handle its own errors. It still uses the "last" registered handler as the global error handler. Fixing that would require API changes.
| a9f8a44c4cd59d1daa3b63e6d62b0f711e8277a6 | 8192716f00ae513358d1210645e4e47352be8e48 | diff --git a/src/main/scala/com/twitter/finatra/Router.scala b/src/main/scala/com/twitter/finatra/Router.scala
index 5604ec5dac..0b744c04b2 100644
--- a/src/main/scala/com/twitter/finatra/Router.scala
+++ b/src/main/scala/com/twitter/finatra/Router.scala
@@ -45,7 +45,10 @@ class Router(controller: Controller) {
... | [
"src/main/scala/com/twitter/finatra/Router.scala",
"src/test/scala/com/twitter/finatra/ErrorHandlerSpec.scala"
] | [] | diff --git a/src/test/scala/com/twitter/finatra/ErrorHandlerSpec.scala b/src/test/scala/com/twitter/finatra/ErrorHandlerSpec.scala
new file mode 100644
index 0000000000..8418f29c3d
--- /dev/null
+++ b/src/test/scala/com/twitter/finatra/ErrorHandlerSpec.scala
@@ -0,0 +1,47 @@
+package com.twitter.finatra
+
+import com.t... | true | |
twitter/finatra | 169 | issue_to_patch | Add an apache style directory browser | Check if a directory exists in FileService
Add directory_browser.mustache
Add DirectoryViewer
Add test files in resources
Rename localFileResponse to localFileSystemResponse
Testing
It looks like this:
![screen shot 2014-10-18 at 6 39 11 pm](https://cloud.githubusercontent.com/assets/1482532/4692329/366dbe2c-575c-11e... | 57a87a097f5fd90e0186a2fb3b594933bcb7b5d7 | f62408cf13f04e14ec48a3a9c7e10a757d51c06d | diff --git a/src/main/resources/directory_browser.mustache b/src/main/resources/directory_browser.mustache
new file mode 100644
index 0000000000..e3869a7c00
--- /dev/null
+++ b/src/main/resources/directory_browser.mustache
@@ -0,0 +1,45 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+ <style>
+ /* apache.org/icons */
+ ... | [
"src/main/resources/directory_browser.mustache",
"src/main/resources/public/components/test_file.txt",
"src/main/resources/public/components/test_folder/.keep",
"src/main/scala/com/twitter/finatra/DirectoryViewer.scala",
"src/main/scala/com/twitter/finatra/FileService.scala",
"src/main/scala/com/twitter/f... | [] | diff --git a/src/main/resources/public/components/test_file.txt b/src/main/resources/public/components/test_file.txt
new file mode 100644
index 0000000000..482c764492
--- /dev/null
+++ b/src/main/resources/public/components/test_file.txt
@@ -0,0 +1,1 @@
+This file is here for testing. Do not delete it.
\ No newline at ... | true | |
twitter/finatra | 167 | issue_to_patch | fixed resource resolution not loading from dependencies, and consistent ... | ...use of *.mustache extension when loading from file or classpath.
| f7a402c1f9c793e423a4b61867a9904e8e1eb7cf | b043938d2ecdf94e36ef1139601f148aa202c20a | diff --git a/src/main/scala/com/twitter/finatra/View.scala b/src/main/scala/com/twitter/finatra/View.scala
index ccdacd7b39..cad50abab4 100644
--- a/src/main/scala/com/twitter/finatra/View.scala
+++ b/src/main/scala/com/twitter/finatra/View.scala
@@ -27,29 +27,39 @@ class FinatraMustacheFactory(baseTemplatePath:String)... | [
"src/main/scala/com/twitter/finatra/View.scala"
] | [] | true | ||
twitter/finatra | 164 | issue_to_patch | added builder from ChannelBuffer | 7b01b3f14fdf36b3e90308979070b2b22d596594 | 00111613954684f9349fa326275b0a022f3e9418 | diff --git a/src/main/scala/com/twitter/finatra/Controller.scala b/src/main/scala/com/twitter/finatra/Controller.scala
index 7111695d83..cbc0e794da 100644
--- a/src/main/scala/com/twitter/finatra/Controller.scala
+++ b/src/main/scala/com/twitter/finatra/Controller.scala
@@ -15,11 +15,11 @@
*/
package com.twitter.fin... | [
"src/main/scala/com/twitter/finatra/Controller.scala",
"src/main/scala/com/twitter/finatra/ResponseBuilder.scala",
"src/main/scala/com/twitter/finatra/View.scala",
"src/main/scala/com/twitter/finatra/serialization/JacksonJsonSerializer.scala",
"src/main/scala/com/twitter/finatra/serialization/JsonSerializer... | [] | diff --git a/src/test/scala/com/twitter/finatra/ResponseBuilderSpec.scala b/src/test/scala/com/twitter/finatra/ResponseBuilderSpec.scala
index a8b46d2819..0ad4da06b8 100644
--- a/src/test/scala/com/twitter/finatra/ResponseBuilderSpec.scala
+++ b/src/test/scala/com/twitter/finatra/ResponseBuilderSpec.scala
@@ -15,6 +15,... | true | ||
twitter/finatra | 181 | issue_to_patch | Fix heroku deployments for template project | As per issue https://github.com/twitter/finatra/issues/180
The included deployment (well, the assembly plugin) does not work against heroku. In short, heroku expects to call `stage` and the shipped plugin uses `assembly`:
I made a few changes to get it working:
1. Added the native packager plugin to `project/plugins.... | 0b9fce0c1525a1aa88a80c586df8abed486017f0 | 2e2af791e350ba5d4162475298aad4d9f10bcf05 | diff --git a/script/finatra/libexec/finatra-new b/script/finatra/libexec/finatra-new
index 934851b855..ebe553d835 100755
--- a/script/finatra/libexec/finatra-new
+++ b/script/finatra/libexec/finatra-new
@@ -59,10 +59,10 @@ echo " creating build.sbt"
cp $_FINATRA_ROOT/share/build.sbt $root_path/$project_name/
echo " ... | [
"script/finatra/libexec/finatra-new",
"script/finatra/share/Procfile",
"script/finatra/share/README.markdown",
"script/finatra/share/assembly.sbt",
"script/finatra/share/assembly_plugin.sbt",
"script/finatra/share/build.properties",
"script/finatra/share/build.sbt",
"script/finatra/share/dot-env",
"... | [] | true | ||
twitter/finatra | 183 | issue_to_patch | Refactor FinatraServer to allow custom tlsConfig | Allow implementors to supply a custom TLS Configuration for secure services.
| 0b9fce0c1525a1aa88a80c586df8abed486017f0 | 04b5cbb9e71488d590eab76cffcc284685cbaa47 | diff --git a/src/main/scala/com/twitter/finatra/FinatraServer.scala b/src/main/scala/com/twitter/finatra/FinatraServer.scala
index 87cc0e22d9..6856b61702 100644
--- a/src/main/scala/com/twitter/finatra/FinatraServer.scala
+++ b/src/main/scala/com/twitter/finatra/FinatraServer.scala
@@ -19,12 +19,11 @@ import com.twitte... | [
"src/main/scala/com/twitter/finatra/FinatraServer.scala"
] | [] | true | ||
twitter/finatra | 163 | issue_to_patch | Do not log errors in the ErrorHandler | This change is to suppress excessive logging for exceptions that are captured and handled correctly downstream. Specifically, we're following the [conventions suggested in the documentation](http://finatra.info/docs/index.html#routing) by using an error handler to respond to certain requests a 404 NOT FOUND. Because of... | f7a402c1f9c793e423a4b61867a9904e8e1eb7cf | 63ca2ab4c8de25693765cada2759060f7560d47d | diff --git a/src/main/scala/com/twitter/finatra/ErrorHandler.scala b/src/main/scala/com/twitter/finatra/ErrorHandler.scala
index f0c1dc54f7..b8019a0b45 100644
--- a/src/main/scala/com/twitter/finatra/ErrorHandler.scala
+++ b/src/main/scala/com/twitter/finatra/ErrorHandler.scala
@@ -5,7 +5,6 @@ import com.twitter.app.Ap... | [
"src/main/scala/com/twitter/finatra/ErrorHandler.scala"
] | [] | true | ||
twitter/finatra | 186 | issue_to_patch | Update to use new Travis CI infrastructure | Should speed up builds a bit. Also use 2.10.4 for Scala.
http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/
Signed-off-by: Chris Aniszczyk zx@twitter.com
| 0b9fce0c1525a1aa88a80c586df8abed486017f0 | 8edf86b9680740805985ff499910a619f7b15b98 | diff --git a/.travis.yml b/.travis.yml
index e4a28bd00c..5144f4f3ed 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,8 @@
language: scala
+sudo: false
script:
- sbt test
- sbt coveralls
scala:
- 2.9.2
- - 2.10.0
+ - 2.10.4
| [
".travis.yml"
] | [] | true | ||
twitter/finatra | 176 | issue_to_patch | Update to twitter-server 1.8.0 (finagle 6.22.0) | 57a87a097f5fd90e0186a2fb3b594933bcb7b5d7 | 7b01b3f14fdf36b3e90308979070b2b22d596594 | diff --git a/build.sbt b/build.sbt
index 5c9ca2eb48..c357740bca 100644
--- a/build.sbt
+++ b/build.sbt
@@ -11,7 +11,7 @@ crossScalaVersions := Seq("2.9.2", "2.10.3")
//Main
libraryDependencies ++= Seq(
- "com.twitter" %% "twitter-server" % "1.7.1",
+ "com.twitter" %% "twitter-server" % "1.8.0",
"commons-io" % ... | [
"build.sbt",
"src/main/scala/com/twitter/finatra/FinatraServer.scala",
"src/test/scala/com/twitter/finatra/LoggingSpec.scala"
] | [] | diff --git a/src/test/scala/com/twitter/finatra/LoggingSpec.scala b/src/test/scala/com/twitter/finatra/LoggingSpec.scala
index 63064c952f..e49e497ac4 100644
--- a/src/test/scala/com/twitter/finatra/LoggingSpec.scala
+++ b/src/test/scala/com/twitter/finatra/LoggingSpec.scala
@@ -15,6 +15,7 @@
*/
package com.twitter.f... | true | ||
twitter/finatra | 126 | issue_to_patch | ObjectMapper reuse & config | Enables ObjectMapper reuse. ObjectMapper can be accessed & configured, with a convenience module registration method.
Additionally, added a per-request method which allows overriding the ObjectMapper for a specific request
It's inefficient to make new ObjectMappers with every request and incur annotation processing o... | 778b58e07daf452404ad13a13bb570676bf58f7c | b6d64536918bfec6f6c2010598f32125cdd33f20 | diff --git a/src/main/scala/com/twitter/finatra/Controller.scala b/src/main/scala/com/twitter/finatra/Controller.scala
index 329cbeb784..b55d3d05de 100644
--- a/src/main/scala/com/twitter/finatra/Controller.scala
+++ b/src/main/scala/com/twitter/finatra/Controller.scala
@@ -15,11 +15,11 @@
*/
package com.twitter.fin... | [
"src/main/scala/com/twitter/finatra/Controller.scala",
"src/main/scala/com/twitter/finatra/ResponseBuilder.scala",
"src/main/scala/com/twitter/finatra/serialization/JacksonJsonSerializer.scala",
"src/main/scala/com/twitter/finatra/serialization/JsonSerializer.scala"
] | [
{
"comment": "I think DefaultJacksonSerializer should be an object in this patch vs a class otherwise we do not get the reuse of ObjectMapper across separate render calls\n",
"path": "src/main/scala/com/twitter/finatra/AppService.scala",
"hunk": "@@ -19,11 +19,12 @@ import com.twitter.finagle.Service\n ... | true | ||
twitter/finatra | 162 | issue_to_patch | Adding missing copyright headers to source files | Many source files in finatra don't have the standard copyright header on them - adding these.
| f7a402c1f9c793e423a4b61867a9904e8e1eb7cf | 495367042301216f54428955d2ed26fd1d31a2df | diff --git a/src/main/scala/com/twitter/finatra/AdminHttpServer.scala b/src/main/scala/com/twitter/finatra/AdminHttpServer.scala
index 31950150de..fc9f380a79 100644
--- a/src/main/scala/com/twitter/finatra/AdminHttpServer.scala
+++ b/src/main/scala/com/twitter/finatra/AdminHttpServer.scala
@@ -1,3 +1,18 @@
+/**
+ * Cop... | [
"src/main/scala/com/twitter/finatra/AdminHttpServer.scala",
"src/main/scala/com/twitter/finatra/ContentType.scala",
"src/main/scala/com/twitter/finatra/ControllerCollection.scala",
"src/main/scala/com/twitter/finatra/ErrorHandler.scala",
"src/main/scala/com/twitter/finatra/FileService.scala",
"src/main/sc... | [] | diff --git a/src/test/scala/com/twitter/finatra/FileServiceSpec.scala b/src/test/scala/com/twitter/finatra/FileServiceSpec.scala
index 6b3b4c11e2..68956e7cea 100644
--- a/src/test/scala/com/twitter/finatra/FileServiceSpec.scala
+++ b/src/test/scala/com/twitter/finatra/FileServiceSpec.scala
@@ -1,3 +1,18 @@
+/**
+ * Cop... | true | |
twitter/rsc | 490 | issue_to_patch | Update LICENSE to use the full text, remove file extension | As part of some GitHub cleanup, Twitter's OSPO is updating license text to use the full text of the stated license. If there are no objections in the next 7 days, we will go ahead and merge this PR. | 8a8263dc828b0551caa8ea3e54c9b266bd5802f1 | a082e9cdc080c187c841cec89cc93e47d7b3d5e3 | diff --git a/LICENSE b/LICENSE
new file mode 100644
index 00000000..261eeb9e
--- /dev/null
+++ b/LICENSE
@@ -0,0 +1,201 @@
+ Apache License
+ Version 2.0, January 2004
+ http://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, R... | [
"LICENSE",
"LICENSE.md"
] | [] | true | ||
twitter/rsc | 489 | issue_to_patch | Upgrade to Scala 2.12.10 | 445e77d8514b237d1a0bb270ea3546237a84b66a | 9bf877c2b51e5d9da7fecdab9a76c897f322232f | diff --git a/.travis.yml b/.travis.yml
index 8fae8025..5f42fa7a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,13 +19,13 @@ matrix:
- env:
- CI_COMMAND: ci-fmt
- env:
- - CI_SCALA_VERSION: 2.12.8
+ - CI_SCALA_VERSION: 2.12.10
- CI_COMMAND: ci-fast
- env:
- - CI_SCALA_VERSI... | [
".travis.yml",
"bin/scalafix",
"build.sbt",
"tests/src/test/resources/scalasig/scala/Predef.highlevel",
"tests/src/test/resources/scalasig/scala/Predef.lowlevel",
"tests/src/test/scala/rsc/tests/ScalametaTests.scala"
] | [] | diff --git a/tests/src/test/resources/scalasig/scala/Predef.highlevel b/tests/src/test/resources/scalasig/scala/Predef.highlevel
index c6fe9f2b..91f5dc37 100644
--- a/tests/src/test/resources/scalasig/scala/Predef.highlevel
+++ b/tests/src/test/resources/scalasig/scala/Predef.highlevel
@@ -479,6 +479,31 @@ scalasig {
... | true | ||
twitter/rsc | 487 | issue_to_patch | Remove type refinements from ascribed structural types | Structural type ascriptions are a pretty bad pattern, so let's not ascribe them in a rewrite. Furthermore, this will prevent a strange bug where `scalac` would say that the `found` and `required` types are not the same, while the printed type strings are equivalent. | 16ef22ff3cb335b52c0ab7d92051e2606a20093c | 1b93a032fb1f13e12d94611adf4dc21d2706cd46 | diff --git a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala b/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
index 321590f8..353f60b3 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/pretty/S... | [
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala"
] | [] | diff --git a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
index 1f6fb81e..2b3072d1 100644
--- a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -146,7... | true | |
twitter/rsc | 486 | issue_to_patch | Fix parenthesization of ascribed function types with single tuple arg | `val foo = (t: (A, B)) => ()` should be ascribed `foo: ((A, B)) => Unit` instead of `foo: (A, B) => Unit`, i.e. extra parentheses are necessary when dealing with functions of a single tuple argument. | be111203418e2c56fbb31bd81b2290d71293a378 | b8fad2bb6dfb24ced2f633b774bf123092082a99 | diff --git a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala b/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
index 921380e7..321590f8 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/pretty/S... | [
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala"
] | [
{
"comment": "Aha, good catch!",
"path": "scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala",
"hunk": "@@ -30,13 +30,22 @@ class SemanticdbPrinter(\n rep(args, \", \")(normal)\n str(\")\")\n } else if (sym.startsWith(\"scala/Function\")) {\n- ... | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index 2a49d69b..d11c23c2 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -283,4 +28... | true | |
twitter/rsc | 482 | issue_to_patch | checkbytecode should be able to run on pre-compiled jars | The checkbytecode CLI should accept jars to diff rather than requiring compilation steps in the tool itself. | 0a8c66559bd43edadfbba37384dc58a5c9ff085a | eace06da50f8a11b7b26ce1c51ab9813d6bfbe29 | diff --git a/check/src/main/scala/rsc/checkbase/SettingsBase.scala b/check/src/main/scala/rsc/checkbase/SettingsBase.scala
index fca0e54e..b58d8c81 100644
--- a/check/src/main/scala/rsc/checkbase/SettingsBase.scala
+++ b/check/src/main/scala/rsc/checkbase/SettingsBase.scala
@@ -2,6 +2,16 @@
// Licensed under the Apach... | [
"check/src/main/scala/rsc/checkbase/SettingsBase.scala",
"check/src/main/scala/rsc/checkbytecode/Checker.scala",
"check/src/main/scala/rsc/checkbytecode/Main.scala",
"check/src/main/scala/rsc/checkbytecode/Settings.scala",
"check/src/main/scala/rsc/checkscalasig/Settings.scala"
] | [] | true | ||
twitter/rsc | 481 | issue_to_patch | Add ability to take in multiple classfiles for checkscalasig | If users have a bunch of classfiles or jars they wish to check, should be able to source scalasigs from all of them at once. | 61790abbadfab96f9fa6cd10c62adf49b19b8494 | 8424c9acb26eb4d4ff7471fb2141d8565b583617 | diff --git a/check/src/main/scala/rsc/checkscalasig/Checker.scala b/check/src/main/scala/rsc/checkscalasig/Checker.scala
index a88a98f1..7d80e73e 100644
--- a/check/src/main/scala/rsc/checkscalasig/Checker.scala
+++ b/check/src/main/scala/rsc/checkscalasig/Checker.scala
@@ -11,10 +11,10 @@ import scala.meta.scalasig.hi... | [
"check/src/main/scala/rsc/checkscalasig/Checker.scala",
"check/src/main/scala/rsc/checkscalasig/Main.scala",
"check/src/main/scala/rsc/checkscalasig/Settings.scala"
] | [] | true | ||
twitter/rsc | 480 | issue_to_patch | Fix ScalametaTests; the previous expect texts were incorrect (fix #429) | 2a6764ce3aa900b13b59360197ce46953353d7ae | a6bc0eac92fc3395ec237d34c14dcff976526f5d | [
"tests/src/test/resources/scalasig/scala/Predef.highlevel",
"tests/src/test/resources/scalasig/scala/Predef.lowlevel",
"tests/src/test/scala/rsc/tests/ScalametaTests.scala"
] | [] | diff --git a/tests/src/test/resources/scalasig/scala/Predef.highlevel b/tests/src/test/resources/scalasig/scala/Predef.highlevel
index 9176c6ec..c6fe9f2b 100644
--- a/tests/src/test/resources/scalasig/scala/Predef.highlevel
+++ b/tests/src/test/resources/scalasig/scala/Predef.highlevel
@@ -82,6 +82,19 @@ scalasig {
... | true | |||
twitter/rsc | 479 | issue_to_patch | Better checkscalasig | Allow the checker to take in already-compiled classfiles and also split the diffing by top-level symbol. | 8df1e01eb259262aac3a0734bd5d7a25bb45992c | 90d63a1663c5c4a747ce7889bf66975efc9f8703 | diff --git a/check/src/main/scala/rsc/checkscalasig/Checker.scala b/check/src/main/scala/rsc/checkscalasig/Checker.scala
index dce2c974..a88a98f1 100644
--- a/check/src/main/scala/rsc/checkscalasig/Checker.scala
+++ b/check/src/main/scala/rsc/checkscalasig/Checker.scala
@@ -4,7 +4,7 @@ import better.files._
import jav... | [
"check/src/main/scala/rsc/checkscalasig/Checker.scala",
"check/src/main/scala/rsc/checkscalasig/Main.scala",
"check/src/main/scala/rsc/checkscalasig/Settings.scala"
] | [
{
"comment": "/s/rscSyms/nscSyms ?",
"path": "check/src/main/scala/rsc/checkscalasig/Checker.scala",
"hunk": "@@ -38,18 +45,26 @@ class Checker(settings: Settings, nscResult: Path, rscResult: Path)\n val rscTexts = mutable.ListBuffer.empty[String]\n \n nscSigs.foreach {\n- case (k, nscText)... | true | ||
twitter/rsc | 473 | issue_to_patch | Cache member lookup in RscCompat Scopes | Without this, it seems RscCompat is too slow with `better = true`. | 0f241ddf11c145a04fd564e1ee017cca606db869 | f50b26e6db2710758746cb31cf98b2fe09088d9b | diff --git a/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala b/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
index 97b7c2e1..688bb214 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
@@ -2,6 +... | [
"scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala",
"scalafix/rules/src/main/scala/rsc/rules/util/MemoizeUtil.scala",
"scalafix/rules/src/main/scala/rsc/rules/util/package.scala"
] | [
{
"comment": "Since you do a lot of cacheing, how about using a function like this:\r\n\r\n```\r\n /**\r\n * Memoize the results of a function call to prevent repeated calls to disk\r\n * This is a short lived application so this should be a safe operation\r\n */\r\n def memoize[I, O](f: I => O): I => O... | true | ||
twitter/rsc | 478 | issue_to_patch | Update the docs | 0f241ddf11c145a04fd564e1ee017cca606db869 | e52d0ab78c9e9ca53f49cef80a3ee6a22c33ac1d | diff --git a/docs/gettingstarted.md b/docs/gettingstarted.md
index 4a06ee8b..8db87f2a 100644
--- a/docs/gettingstarted.md
+++ b/docs/gettingstarted.md
@@ -30,10 +30,10 @@ $ sbt
The best way to get your feet wet is to run our outliner on an example
codebase. Feel free to change a thing or two to see how everything w... | [
"docs/gettingstarted.md"
] | [] | true | |||
twitter/rsc | 477 | issue_to_patch | Specify dist: trusty for CI | https://travis-ci.community/t/error-installing-oraclejdk8-expected-feature-release-number-in-range-of-9-to-14-but-got-8/3766/6 | 2f191f2985d524a5b30d81cf1b16eb82fd68e0cc | 75aad8db6a08b981aee54895a07e6cd26131855e | diff --git a/.travis.yml b/.travis.yml
index f8d43afa..8fae8025 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -8,6 +8,9 @@ branches:
language:
- scala
+dist:
+ - trusty
+
jdk:
- oraclejdk8
| [
".travis.yml"
] | [] | true | ||
twitter/rsc | 469 | issue_to_patch | Add better-files and save pretty-printed scalasigs from checkscalasig | a6f3ea2668ebcd7d6abdf5026f5c4064610f5925 | 5ddc105a2ab93bdc13617c70506e0cd490ace22f | diff --git a/build.sbt b/build.sbt
index c780bb93..d8f90278 100644
--- a/build.sbt
+++ b/build.sbt
@@ -61,6 +61,7 @@ lazy val check = project
moduleName := "rsc-check",
scalacOptions += "-Xexperimental",
libraryDependencies += "ch.qos.logback" % "logback-classic" % "1.2.3",
+ libraryDependencies += "c... | [
"build.sbt",
"check/src/main/scala/rsc/checkscalasig/Checker.scala",
"check/src/main/scala/rsc/checkscalasig/Settings.scala"
] | [] | true | |||
twitter/rsc | 466 | issue_to_patch | Naive text diff Checker utility for Scalasigs (fix #463) | 471f6980ad3b2e91e1ecc32f0384b04e7ed3e798 | b8c2fbca68a2260c2b05b73c92378a9145d172ab | diff --git a/build.sbt b/build.sbt
index 8008a2ab..c780bb93 100644
--- a/build.sbt
+++ b/build.sbt
@@ -61,13 +61,13 @@ lazy val check = project
moduleName := "rsc-check",
scalacOptions += "-Xexperimental",
libraryDependencies += "ch.qos.logback" % "logback-classic" % "1.2.3",
- libraryDependencies += ... | [
"build.sbt",
"check/src/main/scala/rsc/checkscalasig/Checker.scala",
"check/src/main/scala/rsc/checkscalasig/Main.scala",
"check/src/main/scala/rsc/checkscalasig/Settings.scala",
"rsc/src/main/scala/rsc/scalasig/Mtab.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala",
"scalasig/scalap/src/main/scala... | [
{
"comment": "I don't mind the re-order here, but what is the reason behind it? Looks like it's moved down to be between org.scala-lang.scalap and org.scala-lang.scala-compiler. Did you mean to sort them all?",
"path": "build.sbt",
"hunk": "@@ -61,12 +61,12 @@ lazy val check = project\n moduleName... | true | |||
twitter/rsc | 464 | issue_to_patch | Incorrect type parameter ascription when extending from nonpolymorphic trait with polymorphic grandparent class
```scala
class C[A]
trait T extends C[Int]
class D extends T
```
```diff
--- obtained
+++ expected
@@ -7,3 +7,3 @@
∙
- class D extends T[Int]
+ class D extends T
}
```
Basicall... | fix ascription when extending from non-polymorphic trait with polymor… | …phic grandparent class (fix #456) | 471f6980ad3b2e91e1ecc32f0384b04e7ed3e798 | bcc9e0aa74e29a993dcf96ab1560eb672db278b2 | diff --git a/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala b/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
index e2d7c94a..5fe90164 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
@@ -15,6 +15,7 @@ import scala.meta.i... | [
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala"
] | [
{
"comment": "we might want to just crash if there isn't a symbol for this?",
"path": "scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala",
"hunk": "@@ -129,8 +130,12 @@ case class RscCompat(legacyIndex: SemanticdbIndex, config: RscCompatConfig)\n val name = templ.name.get\n ini... | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index 68bd59ad..2a49d69b 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -263,4 +26... | true |
twitter/rsc | 464 | comment_to_fix | fix ascription when extending from non-polymorphic trait with polymor… | we might want to just crash if there isn't a symbol for this? | 471f6980ad3b2e91e1ecc32f0384b04e7ed3e798 | bcc9e0aa74e29a993dcf96ab1560eb672db278b2 | diff --git a/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala b/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
index e2d7c94a..5fe90164 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala
@@ -15,6 +15,7 @@ import scala.meta.i... | [
"scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala"
] | [
{
"comment": "we might want to just crash if there isn't a symbol for this?",
"path": "scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala",
"hunk": "@@ -129,8 +130,12 @@ case class RscCompat(legacyIndex: SemanticdbIndex, config: RscCompatConfig)\n val name = templ.name.get\n ini... | true | ||
twitter/rsc | 464 | comment_to_fix | fix ascription when extending from non-polymorphic trait with polymor… | We probably want to have test cases for `abstract class` instead of `class` or `trait`. | 471f6980ad3b2e91e1ecc32f0384b04e7ed3e798 | bcc9e0aa74e29a993dcf96ab1560eb672db278b2 | diff --git a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
index 55bb3247..9ed8b5e0 100644
--- a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -263,4... | [
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala"
] | [
{
"comment": "We probably want to have test cases for `abstract class` instead of `class` or `trait`. ",
"path": "scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"hunk": "@@ -263,4 +263,12 @@ object BetterRscCompat_Test {\n object NestedTuples {\n val foo: ((String, Int), Double) ... | true | ||
twitter/rsc | 460 | issue_to_patch | Allow trailing commas (fix #427) | 97637a9af4702487a8d5e54255889d61521c332c | ef03f825fc5089dc95137634b7fd6962c11b8246 | diff --git a/examples/error/src/main/scala/427.scala b/examples/error/src/main/scala/427.scala
new file mode 100644
index 00000000..85184d3a
--- /dev/null
+++ b/examples/error/src/main/scala/427.scala
@@ -0,0 +1,4 @@
+object C {
+ def foo(x: Int = 0): Int = 0
+ foo(x = 1,)
+}
diff --git a/examples/syntactic/src/main/... | [
"examples/error/src/main/scala/427.scala",
"examples/syntactic/src/main/scala/427.scala",
"rsc/src/main/scala/rsc/parse/scala/Helpers.scala",
"rsc/src/main/scala/rsc/parse/scala/Scanners.scala",
"tests/src/test/scala/rsc/tests/ErrorTests.scala"
] | [
{
"comment": "Do we really need to use `restore(snapshot)`? ",
"path": "rsc/src/main/scala/rsc/parse/scala/Scanners.scala",
"hunk": "@@ -166,4 +166,22 @@ trait Scanners {\n in.nextToken()\n }\n }\n+\n+ def optTrailingComma(): Unit = {",
"resolving_sha": "ef03f825fc5089dc95137634b7fd6962... | diff --git a/tests/src/test/scala/rsc/tests/ErrorTests.scala b/tests/src/test/scala/rsc/tests/ErrorTests.scala
index 1999c445..ea774f5d 100644
--- a/tests/src/test/scala/rsc/tests/ErrorTests.scala
+++ b/tests/src/test/scala/rsc/tests/ErrorTests.scala
@@ -41,6 +41,19 @@ class ErrorTests extends RscTests {
checkFail... | true | ||
twitter/rsc | 460 | comment_to_fix | Allow trailing commas (fix #427) | Do we really need to use `restore(snapshot)`? | 97637a9af4702487a8d5e54255889d61521c332c | ef03f825fc5089dc95137634b7fd6962c11b8246 | diff --git a/rsc/src/main/scala/rsc/parse/scala/Scanners.scala b/rsc/src/main/scala/rsc/parse/scala/Scanners.scala
index fec6b391..16fce4f0 100644
--- a/rsc/src/main/scala/rsc/parse/scala/Scanners.scala
+++ b/rsc/src/main/scala/rsc/parse/scala/Scanners.scala
@@ -166,4 +166,22 @@ trait Scanners {
in.nextToken()
... | [
"rsc/src/main/scala/rsc/parse/scala/Scanners.scala"
] | [
{
"comment": "Do we really need to use `restore(snapshot)`? ",
"path": "rsc/src/main/scala/rsc/parse/scala/Scanners.scala",
"hunk": "@@ -166,4 +166,22 @@ trait Scanners {\n in.nextToken()\n }\n }\n+\n+ def optTrailingComma(): Unit = {",
"resolving_sha": "ef03f825fc5089dc95137634b7fd6962... | true | ||
twitter/rsc | 460 | comment_to_fix | Allow trailing commas (fix #427) | We also want an error case, like `foo(x = 1,)`, and test with comments too. | 97637a9af4702487a8d5e54255889d61521c332c | ef03f825fc5089dc95137634b7fd6962c11b8246 | diff --git a/examples/syntactic/src/main/scala/427.scala b/examples/syntactic/src/main/scala/427.scala
new file mode 100644
index 00000000..49e798c6
--- /dev/null
+++ b/examples/syntactic/src/main/scala/427.scala
@@ -0,0 +1,8 @@
+object C {
+ def foo(x: Int = 0) = 0
+ foo(x = 1,
+ )
+ foo(
+ x = 1, //Test of com... | [
"examples/syntactic/src/main/scala/427.scala"
] | [
{
"comment": "We also want an error case, like `foo(x = 1,)`, and test with comments too.",
"path": "examples/syntactic/src/main/scala/427.scala",
"hunk": "@@ -0,0 +1,5 @@\n+object C {",
"resolving_sha": "ef03f825fc5089dc95137634b7fd6962c11b8246",
"resolving_diff": "diff --git a/examples/syntact... | true | ||
twitter/rsc | 459 | issue_to_patch | Rename private vals for easier debugging | af6b9ad54115f30b6619214c925f6a7dd30f2eb6 | 53c28ea4e0cbaa25ab26be5a25e42bd547b014f7 | diff --git a/rsc/src/main/scala/rsc/symtab/Envs.scala b/rsc/src/main/scala/rsc/symtab/Envs.scala
index 600ebd80..9918e1f3 100644
--- a/rsc/src/main/scala/rsc/symtab/Envs.scala
+++ b/rsc/src/main/scala/rsc/symtab/Envs.scala
@@ -8,24 +8,24 @@ import rsc.semantics._
import rsc.util._
trait Envs {
- private val impl =... | [
"rsc/src/main/scala/rsc/symtab/Envs.scala",
"rsc/src/main/scala/rsc/symtab/Outlines.scala",
"rsc/src/main/scala/rsc/symtab/Sketches.scala"
] | [] | true | |||
twitter/rsc | 457 | issue_to_patch | Fix #364 | b6df2e0c3a780beaa034afa61af53b4f638d05e8 | 0d2021ccc19cc87ba55ba4b0a99569a9744cebbf | diff --git a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala b/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
index 7f791587..921380e7 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/pretty/S... | [
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala",
"scalafix/rules/src/main/scala/rsc/rules/semantics/Env.scala",
"scalafix/rules/src/main/scala/rsc/rules... | [
{
"comment": "I think this would go in the `else if` statement? Basically, you don't want to add an import if it was renamed.",
"path": "scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala",
"hunk": "@@ -88,7 +88,7 @@ class SemanticdbPrinter(\n str(sym.desc.value)\n ... | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index c996a063..68bd59ad 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -76,9 +76,... | true | ||
twitter/rsc | 457 | comment_to_fix | Fix #364 | I think this would go in the `else if` statement? Basically, you don't want to add an import if it was renamed. | b6df2e0c3a780beaa034afa61af53b4f638d05e8 | 0d2021ccc19cc87ba55ba4b0a99569a9744cebbf | diff --git a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala b/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
index 7f791587..921380e7 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/pretty/S... | [
"scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala"
] | [
{
"comment": "I think this would go in the `else if` statement? Basically, you don't want to add an import if it was renamed.",
"path": "scalafix/rules/src/main/scala/rsc/rules/pretty/SemanticdbPrinter.scala",
"hunk": "@@ -88,7 +88,7 @@ class SemanticdbPrinter(\n str(sym.desc.value)\n ... | true | ||
twitter/rsc | 457 | comment_to_fix | Fix #364 | I think we want to not have `lookup` in the method name and add a comment. This won't be returning a symbol, but just an unqualified name. | b6df2e0c3a780beaa034afa61af53b4f638d05e8 | 0d2021ccc19cc87ba55ba4b0a99569a9744cebbf | diff --git a/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala b/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
index db89c106..97b7c2e1 100644
--- a/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
+++ b/scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala
@@ -12,6 ... | [
"scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala"
] | [
{
"comment": "I think we want to not have `lookup` in the method name and add a comment. This won't be returning a symbol, but just an unqualified name.",
"path": "scalafix/rules/src/main/scala/rsc/rules/semantics/Scopes.scala",
"hunk": "@@ -12,6 +12,8 @@ import scala.meta.internal.semanticdb.Scala.{Nam... | true | ||
twitter/rsc | 455 | issue_to_patch | Default param in abstract method allowed for interfaces | d1470528d104e232012282a6c994208a1346a21e | 5ea1cfc61fe4953204f18a2e31ea8bea30539edc | diff --git a/examples/deps3/src/main/scala/454.scala b/examples/deps3/src/main/scala/454.scala
new file mode 100644
index 00000000..f5d35afc
--- /dev/null
+++ b/examples/deps3/src/main/scala/454.scala
@@ -0,0 +1,10 @@
+package ticket454
+
+trait C {
+ def foo(x: Int = 0): Int
+}
+object C {
+ trait D extends C {
+ ... | [
"examples/deps3/src/main/scala/454.scala",
"examples/semantic/src/main/scala/454.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala",
"tests/src/test/scala/rsc/tests/BytecodeTests.scala"
] | [] | diff --git a/tests/src/test/scala/rsc/tests/BytecodeTests.scala b/tests/src/test/scala/rsc/tests/BytecodeTests.scala
index fcb20ec1..63560d91 100644
--- a/tests/src/test/scala/rsc/tests/BytecodeTests.scala
+++ b/tests/src/test/scala/rsc/tests/BytecodeTests.scala
@@ -8,7 +8,12 @@ import scala.meta.cli._
class BytecodeT... | true | ||
twitter/rsc | 453 | issue_to_patch | Enable a portion of Scalameta tests | Also upgrade Predef test scalasigs to 2.12.8 and use a newer diffutils.
This works towards issue #429 | d1470528d104e232012282a6c994208a1346a21e | 86dff1f22364898c3a1fe071d5354b95e8e68e05 | diff --git a/build.sbt b/build.sbt
index 1a2365cc..8008a2ab 100644
--- a/build.sbt
+++ b/build.sbt
@@ -61,7 +61,7 @@ lazy val check = project
moduleName := "rsc-check",
scalacOptions += "-Xexperimental",
libraryDependencies += "ch.qos.logback" % "logback-classic" % "1.2.3",
- libraryDependencies += "c... | [
"build.sbt",
"check/src/main/scala/rsc/checkbase/DiffUtil.scala",
"tests/src/test/resources/scalasig/scala/Predef.highlevel",
"tests/src/test/resources/scalasig/scala/Predef.lowlevel",
"tests/src/test/scala/rsc/tests/ScalametaTests.scala"
] | [] | diff --git a/tests/src/test/resources/scalasig/scala/Predef.highlevel b/tests/src/test/resources/scalasig/scala/Predef.highlevel
index b48e0153..9176c6ec 100644
--- a/tests/src/test/resources/scalasig/scala/Predef.highlevel
+++ b/tests/src/test/resources/scalasig/scala/Predef.highlevel
@@ -85,7 +85,7 @@ scalasig {
s... | true | |
twitter/rsc | 452 | issue_to_patch | Remove lie about Windows | a72945d832b9a32afabd5f67ba344e2dc1c661a5 | 5174400bbb8d5db0b7c70d25957446325695a778 | diff --git a/docs/gettingstarted.md b/docs/gettingstarted.md
index 33db2249..4a06ee8b 100644
--- a/docs/gettingstarted.md
+++ b/docs/gettingstarted.md
@@ -55,10 +55,6 @@ $ bin/bench
...
```
-## Windows + IntelliJ
-
-Use sbt shell for build and import seems to work well.
-
## Contributing to Rsc
[Link](contribut... | [
"docs/gettingstarted.md"
] | [] | true | |||
twitter/rsc | 451 | issue_to_patch | Update docs for sbt version and IntelliJ | c55e4d343be87189a01f4cbeafad17514403f226 | dc26f521d27919f7386350e5f89535c8677f7bc3 | diff --git a/docs/gettingstarted.md b/docs/gettingstarted.md
index ca56d949..33db2249 100644
--- a/docs/gettingstarted.md
+++ b/docs/gettingstarted.md
@@ -7,20 +7,7 @@
Rsc has the following build dependencies:
* Java 8
- * sbt 0.13.17
-
-In addition to being compiled into JVM bytecode, Rsc is compiled with Scala... | [
"docs/gettingstarted.md"
] | [] | true | |||
twitter/rsc | 450 | issue_to_patch | pretty print functions (fix #365) | 9a5ba5a13514bc9cee8d0937ec4ec25bb4688064 | 900e3283fd4f19da015b010d5729a67a733b0431 | diff --git a/examples/core/src/main/scala/com/twitter/util/Time.scala b/examples/core/src/main/scala/com/twitter/util/Time.scala
index 5d09a087..294f2438 100644
--- a/examples/core/src/main/scala/com/twitter/util/Time.scala
+++ b/examples/core/src/main/scala/com/twitter/util/Time.scala
@@ -401,7 +401,7 @@ object Time e... | [
"examples/core/src/main/scala/com/twitter/util/Time.scala",
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/RscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/pretty/Semanticd... | [
{
"comment": "We can try an example with higher arity, `def`, and polymorphism: `def foo[A]: (A, A => A) => A = (x: A, y: A => Int) => x`",
"path": "scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"hunk": "@@ -17,6 +17,10 @@ object BetterRscCompat_Test {\n def map: mutable.Map[Int, ... | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index fe96f19e..c996a063 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -17,6 +17,... | true | ||
twitter/rsc | 450 | comment_to_fix | pretty print functions (fix #365) | We can try an example with higher arity, `def`, and polymorphism: `def foo[A]: (A, A => A) => A = (x: A, y: A => Int) => x` | 9a5ba5a13514bc9cee8d0937ec4ec25bb4688064 | 900e3283fd4f19da015b010d5729a67a733b0431 | diff --git a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
index 837ee779..1db52ddc 100644
--- a/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -17,6 ... | [
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala"
] | [
{
"comment": "We can try an example with higher arity, `def`, and polymorphism: `def foo[A]: (A, A => A) => A = (x: A, y: A => Int) => x`",
"path": "scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"hunk": "@@ -17,6 +17,10 @@ object BetterRscCompat_Test {\n def map: mutable.Map[Int, ... | true | ||
twitter/rsc | 449 | issue_to_patch | Upgrade sbt to 1.2.8 (fix #447) | 836acafb8db6163ffdf921f87e7cc42bb6105f99 | fafbd46b4af62b9d66fec039386c2e8ae039f8b0 | diff --git a/build.sbt b/build.sbt
index 389df897..1a2365cc 100644
--- a/build.sbt
+++ b/build.sbt
@@ -130,7 +130,6 @@ lazy val examplesSemantic = project
lazy val rsc = project
.in(file("rsc"))
.dependsOn(scalasig)
- .disablePlugins(BackgroundRunPlugin)
.settings(
commonSettings,
publishableSettin... | [
"build.sbt",
"project/Build.scala",
"project/build.properties"
] | [] | true | |||
twitter/rsc | 448 | issue_to_patch | pretty print tuples - issue #354 | 6226f7069c84bb75ab810755faa727565866094c | 17f02c418c3e79538a235d0f6abe6be74cc0cf30 | diff --git a/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala b/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala
index 7eae8129..7fb176b9 100644
--- a/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala
+++ b/examples/core/src/main/scala/com/twitter/util/BatchExecutor.sca... | [
"examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala",
"examples/core/src/main/scala/com/twitter/util/Credentials.scala",
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/output/src/main/scala/rsc/tests... | [] | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index ef584c6f..fe96f19e 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -254,4 +25... | true | ||
twitter/rsc | 437 | issue_to_patch | Add autoimport flag to RscCompatConfig (fix #428) | 23d0014d218b70a7e3d459e4c6476587f7d90fba | a22b4d38fc4f51ddd7bae60bd06a492c4e327790 | diff --git a/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala b/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala
index 19c1bedb..7eae8129 100644
--- a/examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala
+++ b/examples/core/src/main/scala/com/twitter/util/BatchExecutor.sca... | [
"examples/core/src/main/scala/com/twitter/util/BatchExecutor.scala",
"examples/core/src/main/scala/com/twitter/util/Credentials.scala",
"scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/RscCompat.scala",
"scalafix/rules/src/main/scala/rsc/rules/RscComp... | [] | diff --git a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
index bc8715be..ef584c6f 100644
--- a/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/BetterRscCompat.scala
@@ -1,5 +1,6 ... | true | ||
twitter/rsc | 434 | issue_to_patch | Fix scalasig from private[this] val and var in trait | Note that this will cause tests to fail for `2.11.12`, but we can worry about when that's important. | 4b410b14c46174f25d0df3193f29701669119b9e | 7e249466676d9a01fcc7919fde8fe19edf27b079 | diff --git a/examples/deps3/src/main/scala/426a.scala b/examples/deps3/src/main/scala/426a.scala
new file mode 100644
index 00000000..75978295
--- /dev/null
+++ b/examples/deps3/src/main/scala/426a.scala
@@ -0,0 +1,5 @@
+package ticket426a
+
+trait T {
+ private[this] val x: Int = 0
+}
diff --git a/examples/deps3/src/... | [
"examples/deps3/src/main/scala/426a.scala",
"examples/deps3/src/main/scala/426b.scala",
"examples/semantic/src/main/scala/426a.scala",
"examples/semantic/src/main/scala/426b.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala"
] | [
{
"comment": "This is kind of confusing. Does `method` mean a getter method should be generated--or a getter method generated elsewhere should be used here? And yet `noGetter` is true at the same time? If so, please refactor the logic so that it doesn't seem contradictory.",
"path": "rsc/src/main/scala/rsc/... | true | ||
twitter/rsc | 431 | issue_to_patch | Approximate when overriding toString is nullary (fix #425) | 9b10d7cb5118e0a0de5bf77dca4ce4a9a8662bde | 7477c90865dfbb6a10a6d77fd64273426df6fbab | diff --git a/examples/semantic/src/main/scala/425.scala b/examples/semantic/src/main/scala/425.scala
new file mode 100644
index 00000000..c5fd4ec8
--- /dev/null
+++ b/examples/semantic/src/main/scala/425.scala
@@ -0,0 +1,56 @@
+package ticket425
+
+trait T {
+ def toString: String
+}
+trait T2 {
+ override def toStri... | [
"examples/semantic/src/main/scala/425.scala",
"rsc/src/main/scala/rsc/semanticdb/Params.scala"
] | [] | true | |||
twitter/rsc | 430 | issue_to_patch | Target 2.12.8 by default | Passing ScalametaTests will likely require a good deal of effort. | 7ae5dd310119e46a43f0b698cd79a2125c47f240 | 88497afbb3e5cf9a5fdabb8a8d1083a182f9d1c5 | diff --git a/.travis.yml b/.travis.yml
index 24d5c613..f8d43afa 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -16,13 +16,13 @@ matrix:
- env:
- CI_COMMAND: ci-fmt
- env:
- - CI_SCALA_VERSION: 2.11.12
+ - CI_SCALA_VERSION: 2.12.8
- CI_COMMAND: ci-fast
- env:
- - CI_SCALA_VERSI... | [
".travis.yml",
"bin/scalafix",
"bin/scalafmt",
"build.sbt",
"examples/semantic/src/main/scala/424.scala",
"rsc/src/main/scala/rsc/outline/Outliner.scala",
"rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala",
"rsc/src/main/scala/rsc/semantics/Stdlib.scal... | [
{
"comment": "Does this mean Rsc will now be incompatible with Scala 2.11, or is 2.12 just the default but overrideable on the command line?",
"path": "rsc/src/main/scala/rsc/settings/Settings.scala",
"hunk": "@@ -6,7 +6,7 @@ import java.io._\n import java.nio.file._\n \n final case class Settings(\n- ... | diff --git a/scalafix/input/src/main/scala/rsc/tests/RscCompat.scala b/scalafix/input/src/main/scala/rsc/tests/RscCompat.scala
index f2888c19..275f6db6 100644
--- a/scalafix/input/src/main/scala/rsc/tests/RscCompat.scala
+++ b/scalafix/input/src/main/scala/rsc/tests/RscCompat.scala
@@ -181,7 +181,8 @@ object RscCompat_... | true | |
twitter/rsc | 423 | issue_to_patch | Fix a bunch of bugs relating to case class outlines | 0a10e108fe940db59bde4864ccbf024e4025ee77 | 8e0b60e6f8efedcd01d2ee561da15d6e8ecb1676 | diff --git a/examples/semantic/src/main/scala/288.scala b/examples/semantic/src/main/scala/288.scala
new file mode 100644
index 00000000..70995fe4
--- /dev/null
+++ b/examples/semantic/src/main/scala/288.scala
@@ -0,0 +1,5 @@
+package ticket288
+
+case class C[M[T]](x: Int)
+
+case class C2[M[_]](x: Int)
diff --git a/e... | [
"examples/semantic/src/main/scala/288.scala",
"examples/semantic/src/main/scala/289.scala",
"examples/semantic/src/main/scala/420.scala",
"examples/semantic/src/main/scala/421.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala",
"rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"rsc/src/main/scal... | [
{
"comment": "Where can I read about what `T: List: Option` means? Some inspection in the Scala REPL indicates this is an evidence parameter that must be supplied implicitly.",
"path": "examples/semantic/src/main/scala/289.scala",
"hunk": "@@ -0,0 +1,13 @@\n+package ticket289\n+\n+case class C[T: List](... | true | |||
twitter/rsc | 418 | issue_to_patch | Fix incorrect "this" resolution on owner name conflict (fix #417) | 161af6bf4f978aeb1281ec672785bf46f16efd29 | 31f5c076233927d9de8afbf4cb9ec7e74fe7c06f | diff --git a/examples/semantic/src/main/scala/417a.scala b/examples/semantic/src/main/scala/417a.scala
new file mode 100644
index 00000000..6435b544
--- /dev/null
+++ b/examples/semantic/src/main/scala/417a.scala
@@ -0,0 +1,10 @@
+package ticket417a
+
+object O {
+ class C {
+ class D
+ }
+}
+class C extends O.C {... | [
"examples/semantic/src/main/scala/417a.scala",
"examples/semantic/src/main/scala/417b.scala",
"examples/semantic/src/main/scala/417c.scala",
"rsc/src/main/scala/rsc/outline/Env.scala",
"rsc/src/main/scala/rsc/semanticdb/Prefixes.scala"
] | [
{
"comment": "Is there any value in also including `def bar: this.D = ???` here?",
"path": "examples/semantic/src/main/scala/417a.scala",
"hunk": "@@ -0,0 +1,10 @@\n+package ticket417a\n+\n+object O {\n+ class C {\n+ class D\n+ }\n+}\n+class C extends O.C {\n+ def foo: D = ???",
"resolving_sha... | true | |||
twitter/rsc | 414 | issue_to_patch | Roadmap: focus on outlining | c46e29f45b5851dd0ae35d762fd919068015b28d | d10b3347d8b6cc81e713e20b45d78761ff834a5e | diff --git a/docs/roadmap.md b/docs/roadmap.md
index 52acc691..458771fe 100644
--- a/docs/roadmap.md
+++ b/docs/roadmap.md
@@ -3,4 +3,7 @@
# Roadmap
+Currently, we are focused on stabilizing an outliner to unlock parallelism in Scala builds.
+An example of prior art for Java: https://github.com/google/turbine
+
... | [
"docs/roadmap.md"
] | [] | true | |||
twitter/rsc | 415 | issue_to_patch | Add Sameer Sundresh to <developers/> | Welcome to Rsc! | c46e29f45b5851dd0ae35d762fd919068015b28d | a41daed01c55aec27504f51a2e82c48ebc860fce | diff --git a/build.sbt b/build.sbt
index 85879f17..380c4f71 100644
--- a/build.sbt
+++ b/build.sbt
@@ -311,6 +311,11 @@ lazy val publishableSettings = Seq(
<name>Win Wang</name>
<url>https://github.com/WiWa</url>
</developer>
+ <developer>
+ <id>sundresh</id>
+ <name>Sameer S... | [
"build.sbt"
] | [] | true | ||
twitter/rsc | 412 | issue_to_patch | Crash on anonymous type parameters of implicit classes
```scala
object M {
implicit class C[_](x: Int) {
def m: Int = ???
}
}
```
```
error: compiler crash: None.get
java.util.NoSuchElementException: None.get
at scala.None$.get(Option.scala:347)
at scala.None$.get(Option.scala:345)
at rsc.outl... | Fix crash on anonymous type parameter to implicit class | Fix crash on anonymous type parameter to implicit class. There are a couple of TODO comments to resolve before merging this, but feel free to review (including suggestions for the TODO comments).
Closes #366 | d0045661a4db92565ad518019b7467e34478b007 | a6534f323abf1796929d295bd7d48ee6d3c489c4 | diff --git a/examples/semantic/src/main/scala/366.scala b/examples/semantic/src/main/scala/366.scala
new file mode 100644
index 00000000..0b6093d7
--- /dev/null
+++ b/examples/semantic/src/main/scala/366.scala
@@ -0,0 +1,7 @@
+package ticket366
+
+object M {
+ implicit class C[_](x: Int) {
+ def m: Int = ???
+ }
+... | [
"examples/semantic/src/main/scala/366.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala",
"rsc/src/main/scala/rsc/outline/Synthesizer.scala"
] | [
{
"comment": "so something like `rsc.semantics.Stdlib` but next to `rsc.syntax.Trees`?",
"path": "rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"hunk": "@@ -175,8 +184,21 @@ final class Synthesizer private (\n }\n val ret = {\n val core = tree.id\n- if (tparams.isEmpty) Some(core... | true | |
twitter/rsc | 412 | comment_to_fix | Fix crash on anonymous type parameter to implicit class | Not sure why it doesn't make sense? | d0045661a4db92565ad518019b7467e34478b007 | a6534f323abf1796929d295bd7d48ee6d3c489c4 | diff --git a/rsc/src/main/scala/rsc/outline/Synthesizer.scala b/rsc/src/main/scala/rsc/outline/Synthesizer.scala
index 60fe2832..16d71f2e 100644
--- a/rsc/src/main/scala/rsc/outline/Synthesizer.scala
+++ b/rsc/src/main/scala/rsc/outline/Synthesizer.scala
@@ -148,6 +148,15 @@ final class Synthesizer private (
enumV... | [
"rsc/src/main/scala/rsc/outline/Synthesizer.scala"
] | [
{
"comment": "Not sure why it doesn't make sense?",
"path": "rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"hunk": "@@ -175,8 +184,19 @@ final class Synthesizer private (\n }\n val ret = {\n val core = tree.id\n- if (tparams.isEmpty) Some(core)\n- else Some(TptParameterize(c... | true | ||
twitter/rsc | 412 | comment_to_fix | Fix crash on anonymous type parameter to implicit class | I don't think this is exhaustive; we can maybe say `case otherId =>` | d0045661a4db92565ad518019b7467e34478b007 | a6534f323abf1796929d295bd7d48ee6d3c489c4 | diff --git a/rsc/src/main/scala/rsc/outline/Synthesizer.scala b/rsc/src/main/scala/rsc/outline/Synthesizer.scala
index 60fe2832..16d71f2e 100644
--- a/rsc/src/main/scala/rsc/outline/Synthesizer.scala
+++ b/rsc/src/main/scala/rsc/outline/Synthesizer.scala
@@ -148,6 +148,15 @@ final class Synthesizer private (
enumV... | [
"rsc/src/main/scala/rsc/outline/Synthesizer.scala"
] | [
{
"comment": "I don't think this is exhaustive; we can maybe say `case otherId =>`",
"path": "rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"hunk": "@@ -175,8 +184,19 @@ final class Synthesizer private (\n }\n val ret = {\n val core = tree.id\n- if (tparams.isEmpty) Some(core)\n-... | true | ||
twitter/rsc | 413 | issue_to_patch | Error on class outlines with an init with missing type params | d0045661a4db92565ad518019b7467e34478b007 | 03b282ca5d80c0168a2e6fec6763d782a24e00f2 | diff --git a/build.sbt b/build.sbt
index 946a6a6a..85879f17 100644
--- a/build.sbt
+++ b/build.sbt
@@ -101,6 +101,11 @@ lazy val examplesDeps3 = project
lazy val examplesError = project
.in(file("examples/error"))
+ .dependsOn(examplesErrordeps)
+ .settings(commonSettings)
+
+lazy val examplesErrordeps = projec... | [
"build.sbt",
"examples/error/src/main/scala/408.scala",
"examples/error/src/main/scala/410.scala",
"examples/errordeps/src/main/scala/410.scala",
"rsc/src/main/scala/rsc/report/Messages.scala",
"rsc/src/main/scala/rsc/semanticdb/Writer.scala",
"tests/src/main/scala/rsc/tests/FileFixtures.scala",
"test... | [
{
"comment": "Do we need to check for anything related to issue #410 in method signatures? I don't think so, since either a whole type must be inferred (which we catch already) or type parameters must be provided. But maybe I'm missing some edge case?",
"path": "rsc/src/main/scala/rsc/semanticdb/Writer.scal... | diff --git a/tests/src/main/scala/rsc/tests/FileFixtures.scala b/tests/src/main/scala/rsc/tests/FileFixtures.scala
index 6ace5f7a..9c447ad3 100644
--- a/tests/src/main/scala/rsc/tests/FileFixtures.scala
+++ b/tests/src/main/scala/rsc/tests/FileFixtures.scala
@@ -23,25 +23,25 @@ trait FileFixtures extends ToolUtil {
... | true | ||
twitter/rsc | 413 | comment_to_fix | Error on class outlines with an init with missing type params | Do we need to check for anything related to issue #410 in method signatures? I don't think so, since either a whole type must be inferred (which we catch already) or type parameters must be provided. But maybe I'm missing some edge case? | d0045661a4db92565ad518019b7467e34478b007 | 03b282ca5d80c0168a2e6fec6763d782a24e00f2 | diff --git a/rsc/src/main/scala/rsc/semanticdb/Writer.scala b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
index 1cdd41c0..0c4ccd7d 100644
--- a/rsc/src/main/scala/rsc/semanticdb/Writer.scala
+++ b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
@@ -57,10 +57,41 @@ final class Writer private (
infos.put(outline.i... | [
"rsc/src/main/scala/rsc/semanticdb/Writer.scala"
] | [
{
"comment": "Do we need to check for anything related to issue #410 in method signatures? I don't think so, since either a whole type must be inferred (which we catch already) or type parameters must be provided. But maybe I'm missing some edge case?",
"path": "rsc/src/main/scala/rsc/semanticdb/Writer.scal... | true | ||
twitter/rsc | 413 | comment_to_fix | Error on class outlines with an init with missing type params | This currently allows code like `class D extends C[Int](1) with T`, which is actually invalid as per Scalac (which can only infer type parameters of the first parent). Rather than relying on Scalac always catching this kind of mistake for us, iterate over `defn.parents` and check all of the parents (e.g., in case Scala... | d0045661a4db92565ad518019b7467e34478b007 | 03b282ca5d80c0168a2e6fec6763d782a24e00f2 | diff --git a/rsc/src/main/scala/rsc/semanticdb/Writer.scala b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
index 1cdd41c0..0c4ccd7d 100644
--- a/rsc/src/main/scala/rsc/semanticdb/Writer.scala
+++ b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
@@ -57,10 +57,41 @@ final class Writer private (
infos.put(outline.i... | [
"rsc/src/main/scala/rsc/semanticdb/Writer.scala"
] | [
{
"comment": "This currently allows code like `class D extends C[Int](1) with T`, which is actually invalid as per Scalac (which can only infer type parameters of the first parent). Rather than relying on Scalac always catching this kind of mistake for us, iterate over `defn.parents` and check all of the parent... | true | ||
twitter/rsc | 413 | comment_to_fix | Error on class outlines with an init with missing type params | (Assuming `defn.parents.headOption match { ... }` has already been changed to `defn.parents.foreach { ... }`)
Add this case and comments for clarity:
```
// Parent has type parameters specified, so they don't need to be inferred.
// (scalac can tell us later if there's another problem with the type parameters,
/... | d0045661a4db92565ad518019b7467e34478b007 | 03b282ca5d80c0168a2e6fec6763d782a24e00f2 | diff --git a/rsc/src/main/scala/rsc/semanticdb/Writer.scala b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
index 1cdd41c0..0c4ccd7d 100644
--- a/rsc/src/main/scala/rsc/semanticdb/Writer.scala
+++ b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
@@ -57,10 +57,41 @@ final class Writer private (
infos.put(outline.i... | [
"rsc/src/main/scala/rsc/semanticdb/Writer.scala"
] | [
{
"comment": "(Assuming `defn.parents.headOption match { ... }` has already been changed to `defn.parents.foreach { ... }`)\r\n\r\nAdd this case and comments for clarity:\r\n```\r\n// Parent has type parameters specified, so they don't need to be inferred.\r\n// (scalac can tell us later if there's another prob... | true | ||
twitter/rsc | 413 | comment_to_fix | Error on class outlines with an init with missing type params | This case is also a problem, which currently isn't caught because it uses a `TptSelect` instead of a `TptId`:
`class D2 extends ticket410.C(1)`
In general, if the first parent is a `TptPath` instead of a `TptParameterize`, we need to check it. I think the only valid forms of `TptPath` for a class parent are `TptId`... | d0045661a4db92565ad518019b7467e34478b007 | 03b282ca5d80c0168a2e6fec6763d782a24e00f2 | diff --git a/examples/error/src/main/scala/410.scala b/examples/error/src/main/scala/410.scala
new file mode 100644
index 00000000..09615434
--- /dev/null
+++ b/examples/error/src/main/scala/410.scala
@@ -0,0 +1,39 @@
+package ticket410
+
+trait T[A]
+
+class C[A](a: A) extends T[Int] {
+ def this() = this(???)
+}
+
+... | [
"examples/error/src/main/scala/410.scala"
] | [
{
"comment": "This case is also a problem, which currently isn't caught because it uses a `TptSelect` instead of a `TptId`:\r\n`class D2 extends ticket410.C(1)`\r\n\r\nIn general, if the first parent is a `TptPath` instead of a `TptParameterize`, we need to check it. I think the only valid forms of `TptPath` fo... | true | ||
twitter/rsc | 409 | issue_to_patch | Error out when generating NoType return type for methods | Also adding a new kind of testing, i.e. checking that appropriate errors are generated. | e57e96eb429e9e497103fdfcca5626ca7397799f | 7947c3f8852f305c2b2ed5ccb772d162d15b815f | diff --git a/build.sbt b/build.sbt
index 89e6c85b..946a6a6a 100644
--- a/build.sbt
+++ b/build.sbt
@@ -99,6 +99,10 @@ lazy val examplesDeps3 = project
.dependsOn(examplesDeps2)
.settings(commonSettings)
+lazy val examplesError = project
+ .in(file("examples/error"))
+ .settings(commonSettings)
+
lazy val exa... | [
"build.sbt",
"examples/error/src/main/scala/408.scala",
"rsc/src/main/scala/rsc/Compiler.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala",
"rsc/src/main/scala/rsc/outline/Scopes.scala",
"rsc/src/main/scala/rsc/outline/Synthesizer.scala",
"rsc/src/main/scala/rsc/report/Messages.scala",
"rsc/src... | [
{
"comment": "What does rsc do earlier that prevents this from getting called for `private`/`private[this]` fields/methods?",
"path": "rsc/src/main/scala/rsc/semanticdb/Writer.scala",
"hunk": "@@ -50,10 +50,22 @@ final class Writer private (\n }\n val converter = Converter(settings, reporter, ge... | diff --git a/tests/src/main/scala/rsc/tests/FileFixtures.scala b/tests/src/main/scala/rsc/tests/FileFixtures.scala
index e46c316e..6ace5f7a 100644
--- a/tests/src/main/scala/rsc/tests/FileFixtures.scala
+++ b/tests/src/main/scala/rsc/tests/FileFixtures.scala
@@ -16,8 +16,7 @@ trait FileFixtures extends ToolUtil {
}
... | true | |
twitter/rsc | 409 | comment_to_fix | Error out when generating NoType return type for methods | What does rsc do earlier that prevents this from getting called for `private`/`private[this]` fields/methods? | e57e96eb429e9e497103fdfcca5626ca7397799f | 7947c3f8852f305c2b2ed5ccb772d162d15b815f | diff --git a/rsc/src/main/scala/rsc/semanticdb/Writer.scala b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
index fea5cd14..1cdd41c0 100644
--- a/rsc/src/main/scala/rsc/semanticdb/Writer.scala
+++ b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
@@ -50,10 +50,22 @@ final class Writer private (
}
val converte... | [
"rsc/src/main/scala/rsc/semanticdb/Writer.scala"
] | [
{
"comment": "What does rsc do earlier that prevents this from getting called for `private`/`private[this]` fields/methods?",
"path": "rsc/src/main/scala/rsc/semanticdb/Writer.scala",
"hunk": "@@ -50,10 +50,22 @@ final class Writer private (\n }\n val converter = Converter(settings, reporter, ge... | true | ||
twitter/rsc | 409 | comment_to_fix | Error out when generating NoType return type for methods | Add the following cases (and possibly other variants) and make sure they produce errors:
- `var x3 = ""`
- `private[ticket408] def y3 = 45`
| e57e96eb429e9e497103fdfcca5626ca7397799f | 7947c3f8852f305c2b2ed5ccb772d162d15b815f | diff --git a/examples/error/src/main/scala/408.scala b/examples/error/src/main/scala/408.scala
new file mode 100644
index 00000000..db4cd208
--- /dev/null
+++ b/examples/error/src/main/scala/408.scala
@@ -0,0 +1,27 @@
+package ticket408
+
+class C {
+
+ val x = ""
+
+ protected def y = 42
+
+ def z: Int = 43
+
+ pr... | [
"examples/error/src/main/scala/408.scala"
] | [
{
"comment": "Add the following cases (and possibly other variants) and make sure they produce errors:\r\n- `var x3 = \"\"`\r\n- `private[ticket408] def y3 = 45`\r\n",
"path": "examples/error/src/main/scala/408.scala",
"hunk": "@@ -0,0 +1,23 @@\n+package ticket408\n+\n+class C {\n+\n+ val x = \"\"\n+\n... | true | ||
twitter/rsc | 409 | comment_to_fix | Error out when generating NoType return type for methods | Where does rsc desugar `val x = ""` to a `DefnMethod`? | e57e96eb429e9e497103fdfcca5626ca7397799f | 7947c3f8852f305c2b2ed5ccb772d162d15b815f | diff --git a/rsc/src/main/scala/rsc/semanticdb/Writer.scala b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
index fea5cd14..1cdd41c0 100644
--- a/rsc/src/main/scala/rsc/semanticdb/Writer.scala
+++ b/rsc/src/main/scala/rsc/semanticdb/Writer.scala
@@ -50,10 +50,22 @@ final class Writer private (
}
val converte... | [
"rsc/src/main/scala/rsc/semanticdb/Writer.scala"
] | [
{
"comment": "Where does rsc desugar `val x = \"\"` to a `DefnMethod`?",
"path": "rsc/src/main/scala/rsc/semanticdb/Writer.scala",
"hunk": "@@ -50,10 +50,22 @@ final class Writer private (\n }\n val converter = Converter(settings, reporter, gensyms, symtab, outline)\n val info = converter.to... | true | ||
twitter/rsc | 406 | issue_to_patch | Goodbye, Rsc! | Wow, what a ride this has been! Thank you, everyone, who worked together
with me on Rsc - both internally and externally. I have every confidence
that I'm leaving the project in good hands. | f30fafa8d13974389ea8bb1797645e7ea37728dc | 5d86ee2e2577684f49ce1f393651d170419fa59d | diff --git a/README.md b/README.md
index 9fcaef14..caac977a 100644
--- a/README.md
+++ b/README.md
@@ -1,8 +1,7 @@
# Rsc
Reasonable Scala compiler (also known as Rsc) is an experimental Scala compiler
-focused on compilation speed. This project is developed by Eugene Burmako
-and his team at Twitter.
+focused on co... | [
"README.md"
] | [] | true | ||
twitter/rsc | 405 | issue_to_patch | Also schedule underlying tpts for existentials and refines (fix #404) | fcf12568d5d34ab0f1c2ac6589defd0d8ef3a3d7 | 7cf2817fefe33d496d4b35b601996d1bb4308cd7 | diff --git a/examples/semantic/src/main/scala/404.scala b/examples/semantic/src/main/scala/404.scala
new file mode 100644
index 00000000..deba8436
--- /dev/null
+++ b/examples/semantic/src/main/scala/404.scala
@@ -0,0 +1,5 @@
+package ticket404
+
+class C {
+ def m: List[Map[T, U] forSome { type U }] forSome { type T ... | [
"examples/semantic/src/main/scala/404.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala"
] | [] | true | |||
twitter/rsc | 403 | issue_to_patch | Stop scheduling some types multiple times | 956eefb1be02e458a64547eb170ffaf7f449a972 | 86e4d346a0317f49ce7a3811a0183300d7c4b5e8 | diff --git a/rsc/src/main/scala/rsc/outline/Scheduler.scala b/rsc/src/main/scala/rsc/outline/Scheduler.scala
index 653dd54c..529e4855 100644
--- a/rsc/src/main/scala/rsc/outline/Scheduler.scala
+++ b/rsc/src/main/scala/rsc/outline/Scheduler.scala
@@ -533,11 +533,13 @@ final class Scheduler private (
case TptBy... | [
"rsc/src/main/scala/rsc/outline/Scheduler.scala"
] | [] | true | |||
twitter/rsc | 402 | issue_to_patch | Include members inherited from self in this type (fix #401) | 86243dc301b896c0db5f4c1314eb99a1c7dd9f39 | 2dd8d3e1b620327fb1c85ce5d91b502147db823c | diff --git a/examples/semantic/src/main/scala/401.scala b/examples/semantic/src/main/scala/401.scala
new file mode 100644
index 00000000..839f70df
--- /dev/null
+++ b/examples/semantic/src/main/scala/401.scala
@@ -0,0 +1,19 @@
+package ticket401
+
+trait B1 {
+ self: C =>
+
+ def m1: T = ???
+ def m2: B1.this.T = ??... | [
"examples/semantic/src/main/scala/401.scala",
"rsc/src/main/scala/rsc/outline/Outliner.scala"
] | [] | true | |||
twitter/rsc | 400 | issue_to_patch | Reimplement overridesNonNullary (fix #399) | b5d3d50c9fd983ff2230473812dd01ec1764c46e | 28c1fb4bc10e9cc06ebf0941a6cfce6f60db3689 | diff --git a/.scalafmt.conf b/.scalafmt.conf
index 13c6ab1d..506f293b 100644
--- a/.scalafmt.conf
+++ b/.scalafmt.conf
@@ -15,6 +15,7 @@ project.excludeFilters = [
".*/target/.*",
".*/sandbox/.*",
"rsc/src/main/scala/rsc/classpath/Classpath.scala",
+ "rsc/src/main/scala/rsc/outline/Outliner.scala",
"rsc/sr... | [
".scalafmt.conf",
"examples/semantic/src/main/scala/399.scala",
"rsc/src/main/scala/rsc/outline/Outliner.scala",
"rsc/src/main/scala/rsc/semanticdb/Params.scala",
"rsc/src/main/scala/rsc/symtab/Scopifies.scala",
"rsc/src/main/scala/rsc/symtab/Symtab.scala",
"rsc/src/main/scala/rsc/util/SemanticdbUtil.sc... | [] | true | |||
twitter/rsc | 398 | issue_to_patch | Delay blocked and failed resolutions obtained from importer scopes (fix #397) | 1cfae7813949db0b90d593938dd59cbccadf34fa | eeb2c016796a70aaeca0d523fa772644a6667acd | diff --git a/examples/semantic/src/main/scala/397.scala b/examples/semantic/src/main/scala/397.scala
new file mode 100644
index 00000000..a4322d43
--- /dev/null
+++ b/examples/semantic/src/main/scala/397.scala
@@ -0,0 +1,4 @@
+package ticket397
+import M._
+object M extends X
+trait X
diff --git a/rsc/src/main/scala/rs... | [
"examples/semantic/src/main/scala/397.scala",
"rsc/src/main/scala/rsc/outline/Env.scala",
"rsc/src/main/scala/rsc/outline/Work.scala"
] | [] | true | |||
twitter/rsc | 396 | issue_to_patch | Keep track of precise reasons why sketches can be blocked | This pull request refactors the outliner to keep track of precise reasons why sketches can be blocked. Previously, from time to time we limited ourselves to approximations because our infrastructure didn't allow for matching trees to enclosing sketches. | 494a7ffe409c96ebee23d732ccc00f2a9f61bfeb | 8288b3df95c0806f2d4f6988e690a139c9279118 | diff --git a/rsc/src/main/scala/rsc/Compiler.scala b/rsc/src/main/scala/rsc/Compiler.scala
index f61065a4..209c4598 100644
--- a/rsc/src/main/scala/rsc/Compiler.scala
+++ b/rsc/src/main/scala/rsc/Compiler.scala
@@ -110,7 +110,7 @@ class Compiler(val settings: Settings, val reporter: Reporter) extends AutoClose
}
... | [
"rsc/src/main/scala/rsc/Compiler.scala",
"rsc/src/main/scala/rsc/outline/Outliner.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala",
"rsc/src/main/scala/rsc/outline/Sketch.scala",
"rsc/src/main/scala/rsc/outline/Todo.scala",
"rsc/src/main/scala/rsc/outline/Unknown.scala",
"rsc/src/main/scala/rsc/... | [] | true | ||
twitter/rsc | 394 | issue_to_patch | Fix crash when parsing 0XFFFFFFFFL (fix #393) | a1b3c9f046302b080bea4eb402d0450491a4cb33 | ccdc3d821c77a8c0b623785e2ba165ac93cdb94e | diff --git a/examples/syntactic/src/main/scala/393.scala b/examples/syntactic/src/main/scala/393.scala
new file mode 100644
index 00000000..df825606
--- /dev/null
+++ b/examples/syntactic/src/main/scala/393.scala
@@ -0,0 +1,4 @@
+class C {
+ def m1: Int = 0XFFFF
+ def m2: Long = 0XFFFFFFFFL
+}
diff --git a/rsc/src/ma... | [
"examples/syntactic/src/main/scala/393.scala",
"rsc/src/main/scala/rsc/parse/scala/Lits.scala"
] | [] | true | |||
twitter/rsc | 392 | issue_to_patch | Implement type lambdas (fix #391) | e00d8d14ecfdbadf0ca4cfa0505a87c61303abc8 | edfe0f67ae2a71025be685903d1a140b24290586 | diff --git a/examples/deps3/src/main/scala/391.scala b/examples/deps3/src/main/scala/391.scala
new file mode 100644
index 00000000..a43918d9
--- /dev/null
+++ b/examples/deps3/src/main/scala/391.scala
@@ -0,0 +1,8 @@
+package ticket391
+
+import scala.language.higherKinds
+
+class C[M[_]] {
+ def m: C[({ type L[T] = L... | [
"examples/deps3/src/main/scala/391.scala",
"examples/semantic/src/main/scala/391.scala",
"rsc/src/main/scala/rsc/outline/Outliner.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala",
"rsc/src/main/scala/rsc/scalasig/Values.scala",
"rsc/src/main/scala/rsc/semanticdb/Tpts.scala"
] | [] | true | |||
twitter/rsc | 389 | issue_to_patch | Fix crash when outlining multiple anonymous type parameters on the same definition (fix #388) | 11a5f81797cb8e28d9b9818abc7eec2a82d30fc7 | f3528c7d8c964ef4ae3adeabcb056499dc7dc4fe | diff --git a/check/src/main/scala/rsc/checkoutline/Checker.scala b/check/src/main/scala/rsc/checkoutline/Checker.scala
index 9e3b4714..95095892 100644
--- a/check/src/main/scala/rsc/checkoutline/Checker.scala
+++ b/check/src/main/scala/rsc/checkoutline/Checker.scala
@@ -9,6 +9,7 @@ import rsc.util._
import scala.colle... | [
"check/src/main/scala/rsc/checkoutline/Checker.scala",
"examples/semantic/src/main/scala/388.scala",
"rsc/src/main/scala/rsc/outline/Scheduler.scala",
"rsc/src/main/scala/rsc/symtab/Outlines.scala"
] | [] | true | |||
twitter/rsc | 387 | issue_to_patch | Stop generating equals and hashCode if they are already defined (fix #386) | 152e445f69354b709a32194f2a80a7505a1dad5d | c472aadd64589e686c0f387f42b25e30024cbdff | diff --git a/examples/deps3/src/main/scala/386.scala b/examples/deps3/src/main/scala/386.scala
new file mode 100644
index 00000000..457c2d8e
--- /dev/null
+++ b/examples/deps3/src/main/scala/386.scala
@@ -0,0 +1,6 @@
+package ticket386
+
+case class C(x: Int) {
+ override def equals(other: Any): Boolean = ???
+ overr... | [
"examples/deps3/src/main/scala/386.scala",
"examples/semantic/src/main/scala/386.scala",
"rsc/src/main/scala/rsc/outline/Synthesizer.scala"
] | [] | true | |||
twitter/rsc | 385 | issue_to_patch | Mark private constructors of value classes as notPRIVATE (fix #384) | 0ecf2442b9caeac4a1a1b50eb2fab7fb5a05b517 | 8a1c161983aea490018fef3038f3a043b0cc79ab | diff --git a/examples/deps3/src/main/scala/384.scala b/examples/deps3/src/main/scala/384.scala
new file mode 100644
index 00000000..e3981bbf
--- /dev/null
+++ b/examples/deps3/src/main/scala/384.scala
@@ -0,0 +1,3 @@
+package ticket384
+
+class C private (val value: Int) extends AnyVal
diff --git a/examples/semantic/sr... | [
"examples/deps3/src/main/scala/384.scala",
"examples/semantic/src/main/scala/384.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala"
] | [] | true | |||
twitter/rsc | 383 | issue_to_patch | Always persist PrimaryCtors regardless of their visibility (fix #382) | 701e96597bfa964902165f78f65e0fc52361614e | e25cc85bcff3bde7fb44ccc2b7541e7ae012213d | diff --git a/examples/deps3/src/main/scala/382.scala b/examples/deps3/src/main/scala/382.scala
new file mode 100644
index 00000000..ce14cd9f
--- /dev/null
+++ b/examples/deps3/src/main/scala/382.scala
@@ -0,0 +1,3 @@
+package ticket382
+
+case class C private (value: Int)
diff --git a/examples/semantic/src/main/scala/3... | [
"examples/deps3/src/main/scala/382.scala",
"examples/semantic/src/main/scala/382.scala",
"rsc/src/main/scala/rsc/scalasig/Pickle.scala",
"rsc/src/main/scala/rsc/semanticdb/Eligibility.scala"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.