repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion * ``preserve_keys``: Whether to preserve key or not (when the input is an array), by default the value is ``false``. ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/slice.rst b/doc/filters/slice.rst index eb43d99461a..3642b85d830 100644 --- a/doc/filters/slice.rst +++ b/doc/filters/slice.rst @@ -54,6 +54,28 @@ negative then the sequence will stop that many elements from the end of the variable. If it is omitted, then the sequence will have everything from...
[ "doc/filters/slice.rst" ]
[ { "comment": "```suggestion\r\n* ``preserve_keys``: Whether to preserve key or not (when the input is an array), by default the value is ``false``.\r\n```", "path": "doc/filters/slice.rst", "hunk": "@@ -63,7 +85,7 @@ Arguments\n \n * ``start``: The start of the slice\n * ``length``: The s...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion If you choose to set the third parameter ``preserve_keys`` to ``false``, the keys will be reset in each loop. ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/batch.rst b/doc/filters/batch.rst index 18a227feb39..adb2948c6a3 100644 --- a/doc/filters/batch.rst +++ b/doc/filters/batch.rst @@ -12,8 +12,8 @@ missing items: <table> {% for row in items|batch(3, 'No item') %} <tr> - {% for column in row %} - ...
[ "doc/filters/batch.rst" ]
[ { "comment": "```suggestion\r\nIf you choose to set the third parameter ``preserve_keys`` to ``false``, the keys will be reset in each loop.\r\n```", "path": "doc/filters/batch.rst", "hunk": "@@ -25,14 +25,47 @@ The above example will be rendered as:\n \n <table>\n <tr>\n- <td>a</...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion * ``preserve_keys``: Whether to preserve keys or not (defaults to ``true``) ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/batch.rst b/doc/filters/batch.rst index 18a227feb39..adb2948c6a3 100644 --- a/doc/filters/batch.rst +++ b/doc/filters/batch.rst @@ -12,8 +12,8 @@ missing items: <table> {% for row in items|batch(3, 'No item') %} <tr> - {% for column in row %} - ...
[ "doc/filters/batch.rst" ]
[ { "comment": "```suggestion\r\n* ``preserve_keys``: Whether to preserve keys or not (defaults to ``true``)\r\n```", "path": "doc/filters/batch.rst", "hunk": "@@ -41,4 +74,4 @@ Arguments\n \n * ``size``: The size of the batch; fractional numbers will be rounded up\n * ``fill``: Used to fill in missing it...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion it by explicitly specifying a supported `timezone`_: ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/date.rst b/doc/filters/date.rst index 70470f0f4d2..7ac9b8750a3 100644 --- a/doc/filters/date.rst +++ b/doc/filters/date.rst @@ -47,7 +47,7 @@ Timezone By default, the date is displayed by applying the default timezone (the one specified in php.ini or declared in Twig -- see below), but you ...
[ "doc/filters/date.rst" ]
[ { "comment": "```suggestion\r\nit by explicitly specifying a supported `timezone`_:\r\n```", "path": "doc/filters/date.rst", "hunk": "@@ -47,7 +47,7 @@ Timezone\n \n By default, the date is displayed by applying the default timezone (the one\n specified in php.ini or declared in Twig -- see below), but ...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion .. _`timezone`: https://www.php.net/manual/en/timezones.php ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/date.rst b/doc/filters/date.rst index 70470f0f4d2..7ac9b8750a3 100644 --- a/doc/filters/date.rst +++ b/doc/filters/date.rst @@ -47,7 +47,7 @@ Timezone By default, the date is displayed by applying the default timezone (the one specified in php.ini or declared in Twig -- see below), but you ...
[ "doc/filters/date.rst" ]
[ { "comment": "```suggestion\r\n.. _`timezone`: https://www.php.net/manual/en/timezones.php\r\n```", "path": "doc/filters/date.rst", "hunk": "@@ -68,11 +68,12 @@ The default timezone can also be set globally by calling ``setTimezone()``::\n Arguments\n ---------\n \n-* ``format``: The date f...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion * ``format``: The date format (default format is ``F j, Y H:i``, which will render as ``January 11, 2024 15:17``) ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/date.rst b/doc/filters/date.rst index 70470f0f4d2..7ac9b8750a3 100644 --- a/doc/filters/date.rst +++ b/doc/filters/date.rst @@ -47,7 +47,7 @@ Timezone By default, the date is displayed by applying the default timezone (the one specified in php.ini or declared in Twig -- see below), but you ...
[ "doc/filters/date.rst" ]
[ { "comment": "```suggestion\r\n* ``format``: The date format (default format is ``F j, Y H:i``, which will render as ``January 11, 2024 15:17``)\r\n```", "path": "doc/filters/date.rst", "hunk": "@@ -68,11 +68,12 @@ The default timezone can also be set globally by calling ``setTimezone()``::\n Argument...
true
twigphp/Twig
3,941
comment_to_fix
add docs & links
```suggestion The argument ``preserve_keys`` is used to reset the index during the loop. ```
804cb1b85b92d995cea958401adedb0f5ed37558
dd24d5bfd262e27588b81ed47d4ff2fd3ac692a4
diff --git a/doc/filters/slice.rst b/doc/filters/slice.rst index eb43d99461a..3642b85d830 100644 --- a/doc/filters/slice.rst +++ b/doc/filters/slice.rst @@ -54,6 +54,28 @@ negative then the sequence will stop that many elements from the end of the variable. If it is omitted, then the sequence will have everything from...
[ "doc/filters/slice.rst" ]
[ { "comment": "```suggestion\r\nThe argument ``preserve_keys`` is used to reset the index during the loop.\r\n```", "path": "doc/filters/slice.rst", "hunk": "@@ -54,6 +54,28 @@ negative then the sequence will stop that many elements from the end of the\n variable. If it is omitted, then the sequence will...
true
twigphp/Twig
4,796
issue_to_patch
Stop publishing extra package minor versions with no changes
ecb310e129f549daa3424f6565520bcc807d16f3
48733e0f098fc7bfb64a7be69f301fe5295591be
diff --git a/splitsh.json b/splitsh.json index f415dd8d4ea..20ce501c270 100644 --- a/splitsh.json +++ b/splitsh.json @@ -10,6 +10,7 @@ "string-extra": "extra/string-extra" }, "defaults": { - "git_constraint": "<1.8.2" + "git_constraint": "<1.8.2", + "tag_skip": "minor" } }
[ "splitsh.json" ]
[]
true
twigphp/Twig
4,787
issue_to_patch
Reword parent-child analogy in `doc/tags/extends.rst`
76688da07c9e293b9958c7b339a5da60c06d5600
64a70e96a6e07a1eedcb1c0e1ba644192b604637
diff --git a/doc/tags/extends.rst b/doc/tags/extends.rst index 99bac7719c6..a4d024df72e 100644 --- a/doc/tags/extends.rst +++ b/doc/tags/extends.rst @@ -71,8 +71,8 @@ value from the parent template is used instead. You can't define multiple ``block`` tags with the same name in the same template. This limitation exi...
[ "doc/tags/extends.rst" ]
[ { "comment": "I think this sentence would be more clear with the existing `which one of the blocks' content to use` than the puzzle piece analogy.", "path": "doc/tags/extends.rst", "hunk": "@@ -71,10 +71,10 @@ value from the parent template is used instead.\n \n You can't define multiple ``block`` tags ...
true
twigphp/Twig
4,787
comment_to_fix
Reword parent-child analogy in `doc/tags/extends.rst`
I think this sentence would be more clear with the existing `which one of the blocks' content to use` than the puzzle piece analogy.
76688da07c9e293b9958c7b339a5da60c06d5600
64a70e96a6e07a1eedcb1c0e1ba644192b604637
diff --git a/doc/tags/extends.rst b/doc/tags/extends.rst index 99bac7719c6..a4d024df72e 100644 --- a/doc/tags/extends.rst +++ b/doc/tags/extends.rst @@ -71,8 +71,8 @@ value from the parent template is used instead. You can't define multiple ``block`` tags with the same name in the same template. This limitation exi...
[ "doc/tags/extends.rst" ]
[ { "comment": "I think this sentence would be more clear with the existing `which one of the blocks' content to use` than the puzzle piece analogy.", "path": "doc/tags/extends.rst", "hunk": "@@ -71,10 +71,10 @@ value from the parent template is used instead.\n \n You can't define multiple ``block`` tags ...
true
twigphp/Twig
4,787
comment_to_fix
Reword parent-child analogy in `doc/tags/extends.rst`
not sure we need this `puzzle piece` analogy. Talking about `slot` instead of `hole` makes sense though. It will allow people to relate that to their knowledge of HTML shadow root which also uses that naming (it does not work exactly the same, but the idea of defining a place where content will be inserted is related)
76688da07c9e293b9958c7b339a5da60c06d5600
64a70e96a6e07a1eedcb1c0e1ba644192b604637
diff --git a/doc/tags/extends.rst b/doc/tags/extends.rst index 99bac7719c6..a4d024df72e 100644 --- a/doc/tags/extends.rst +++ b/doc/tags/extends.rst @@ -71,8 +71,8 @@ value from the parent template is used instead. You can't define multiple ``block`` tags with the same name in the same template. This limitation exi...
[ "doc/tags/extends.rst" ]
[ { "comment": "not sure we need this `puzzle piece` analogy.\n\nTalking about `slot` instead of `hole` makes sense though. It will allow people to relate that to their knowledge of HTML shadow root which also uses that naming (it does not work exactly the same, but the idea of defining a place where content will...
true
twigphp/Twig
4,786
issue_to_patch
doc: Add missing toctree entries and fix ordering
- Add missing `sequence` and `mapping` to tests/index.rst toctree - Fix alphabetical ordering of `guard`/`flush` in tags/index.rst - Add orphaned `operators_precedence` to main index.rst toctree
4d44d3cb92cc6141c198cd6bbe9ba394b9dfaa11
84a433ed28d80179f61591e31fd06fde9dcec07a
diff --git a/doc/index.rst b/doc/index.rst index 8fc8db977a8..89f6ee803fa 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -14,6 +14,7 @@ Twig deprecated recipes coding_standards + operators_precedence tags/index filters/index functions/index diff --git a/doc/tags/index.rst b/doc/tags/...
[ "doc/index.rst", "doc/tags/index.rst", "doc/tests/index.rst" ]
[]
diff --git a/doc/tests/index.rst b/doc/tests/index.rst index c63208ee74d..0d47db96fec 100644 --- a/doc/tests/index.rst +++ b/doc/tests/index.rst @@ -10,6 +10,8 @@ Tests empty even iterable + mapping null odd sameas + sequence
true
twigphp/Twig
4,784
issue_to_patch
Add two tests for error conditions in #3930
Here are two test cases for potential errors in `html_attr_merge`, asked for by @fabpot in https://github.com/twigphp/Twig/pull/3930#pullrequestreview-3956645279.
8b93364bf6bd225ee043b2076e86eab444148b25
25bfb5957c390cbeebb7a9d30239d83ec572ca18
[ "extra/html-extra/Tests/HtmlAttrTest.php" ]
[]
diff --git a/extra/html-extra/Tests/HtmlAttrTest.php b/extra/html-extra/Tests/HtmlAttrTest.php index 5c23ebe7c1e..41f704cbadf 100644 --- a/extra/html-extra/Tests/HtmlAttrTest.php +++ b/extra/html-extra/Tests/HtmlAttrTest.php @@ -13,6 +13,7 @@ use PHPUnit\Framework\TestCase; use Twig\Environment; +use Twig\Error\Run...
true
twigphp/Twig
3,930
issue_to_patch
Helper function to make dealing with HTML attributes easier I'd like to discuss adding a new function, let's say `attr()`, to make juggling with HTML attributes easier. I'm willing to work on the implementation given that the general idea is backed here and we can sketch out some details. #### Motivation One...
Add an `html_attr` function to make outputting HTML attributes easier
**Updated:** This description has been updated to reflect changes from the discussion up to https://github.com/twigphp/Twig/pull/3930#issuecomment-3870445987. This PR suggests adding an `html_attr` function and two filters `html_attr_merge` and `html_attr_type`. Together, they are intended to make it easier to colle...
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/CHANGELOG b/CHANGELOG index 1c59ed1ff0e..21e3273a031 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -3,6 +3,7 @@ * Add support for renaming variables in object destructuring (`{name: userName} = user`) * Add `html_attr_relaxed` escaping strategy that preserves :, @, [, and ] for front-end framework attribut...
[ "CHANGELOG", "doc/filters/html_attr_merge.rst", "doc/filters/html_attr_type.rst", "doc/filters/index.rst", "doc/functions/html_attr.rst", "doc/functions/index.rst", "extra/html-extra/HtmlAttr/AttributeValueInterface.php", "extra/html-extra/HtmlAttr/InlineStyle.php", "extra/html-extra/HtmlAttr/Mergea...
[ { "comment": "```suggestion\r\n new TwigFilter('html_attr_merge', 'twig_attr_merge'),\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -28,13 +29,15 @@ public function getFilters(): array\n {\n return [\n new TwigFilter('data_uri', [$this, 'dataUri'])...
diff --git a/extra/html-extra/Tests/Fixtures/html_attr.test b/extra/html-extra/Tests/Fixtures/html_attr.test new file mode 100644 index 00000000000..8946aaeda0e --- /dev/null +++ b/extra/html-extra/Tests/Fixtures/html_attr.test @@ -0,0 +1,40 @@ +--TEST-- +"html_attr" function +--TEMPLATE-- +Simple attributes: <tag {{ h...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion new TwigFilter('html_attr_merge', 'twig_attr_merge'), ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\r\n new TwigFilter('html_attr_merge', 'twig_attr_merge'),\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -28,13 +29,15 @@ public function getFilters(): array\n {\n return [\n new TwigFilter('data_uri', [$this, 'dataUri'])...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion new TwigFunction('html_attr', 'twig_attr', ['needs_environment' => true, 'is_safe' => ['html']]), ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\r\n new TwigFunction('html_attr', 'twig_attr', ['needs_environment' => true, 'is_safe' => ['html']]),\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -28,13 +29,15 @@ public function getFilters(): array\n {\n return [\n ne...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
When rebasing, you will need to convert this to a static method.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "When rebasing, you will need to convert this to a static method.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -108,4 +112,75 @@ function twig_html_classes(...$args): string\n \n return implode(' ', array_unique($classes));\n }\n+\n+function twig_attr_merge(...$arrays): a...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion throw new RuntimeError(sprintf('The "attr_merge" filter only works with arrays or "Traversable", got "%s" for argument %d.', \gettype($array), $argNumber + 1)); ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\r\n throw new RuntimeError(sprintf('The \"attr_merge\" filter only works with arrays or \"Traversable\", got \"%s\" for argument %d.', \\gettype($array), $argNumber + 1));\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -108,4 +112,75 @@ function...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Do we need a special treatment for `aria` as well?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Do we need a special treatment for `aria` as well?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -108,4 +112,75 @@ function twig_html_classes(...$args): string\n \n return implode(' ', array_unique($classes));\n }\n+\n+function twig_attr_merge(...$arrays): array\n+{\n+ ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
To be converted to a public static method as well when rebasing.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "To be converted to a public static method as well when rebasing.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -108,4 +112,75 @@ function twig_html_classes(...$args): string\n \n return implode(' ', array_unique($classes));\n }\n+\n+function twig_attr_merge(...$arrays): a...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
The `array_values` is unnecessary because `implode` ignores the keys. ```suggestion $attr['class'] = trim(implode(' ', $attr['class'])); ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "The `array_values` is unnecessary because `implode` ignores the keys.\r\n\r\n```suggestion\r\n $attr['class'] = trim(implode(' ', $attr['class']));\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -108,4 +112,75 @@ function twig_html_classes(...$args): string\n \n ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Indentation looks wrong.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Indentation looks wrong.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +127,75 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $defaultVariant);\n }\n+\n+stati...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
👀 wanted – does this make sense?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "👀 wanted – does this make sense?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,77 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $defaultVariant);\n }\...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
We can maybe have a `@param` to better describe `$arrays`?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "We can maybe have a `@param` to better describe `$arrays`?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,85 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $d...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion throw new RuntimeError(sprintf('The "attr_merge" filter only works with mappings or "Traversable", got "%s" for argument %d.', \gettype($array), $argNumber + 1)); ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\r\n throw new RuntimeError(sprintf('The \"attr_merge\" filter only works with mappings or \"Traversable\", got \"%s\" for argument %d.', \\gettype($array), $argNumber + 1));\r\n```", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,85 @@ pu...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Not guaranteed that we have a number here.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Not guaranteed that we have a number here.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,77 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $defaultVariant);\...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Not necessary if we just cast into array, right ?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Not necessary if we just cast into array, right ? ", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,77 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $defaultVa...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Can we use `[... ]` when we can ? As it's slightly more performant than array_merge
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Can we use `[... ]` when we can ? As it's slightly more performant than array_merge", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,77 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $varian...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
I'm not sure why this specific case for style.. i may have missed the reason earlier in the discussion ?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "I'm not sure why this specific case for style.. i may have missed the reason earlier in the discussion ?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +130,77 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return n...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Should this be " The `html_attr_merge` filter only…" . What if the exception is thrown when using the `html_attr` function.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Should this be \" The `html_attr_merge` filter only…\" . What if the exception is thrown when using the `html_attr` function.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -124,4 +128,96 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
why disabling auto-escaping ? We need the function to work fine in an auto-escaping context for safety (we should not encourage disabling auto-escaping in HTML templates)
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/Tests/Fixtures/html_attr.test b/extra/html-extra/Tests/Fixtures/html_attr.test new file mode 100644 index 00000000000..8946aaeda0e --- /dev/null +++ b/extra/html-extra/Tests/Fixtures/html_attr.test @@ -0,0 +1,40 @@ +--TEST-- +"html_attr" function +--TEMPLATE-- +Simple attributes: <tag {{ h...
[ "extra/html-extra/Tests/Fixtures/html_attr.test" ]
[ { "comment": "why disabling auto-escaping ? We need the function to work fine in an auto-escaping context for safety (we should not encourage disabling auto-escaping in HTML templates)", "path": "extra/html-extra/Tests/Fixtures/html_attr.test", "hunk": "@@ -0,0 +1,38 @@\n+--TEST--\n+\"html_attr\" functi...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
I think this deserves some phpdoc to explain the intent of the interface.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlAttr/AttributeValueInterface.php b/extra/html-extra/HtmlAttr/AttributeValueInterface.php new file mode 100644 index 00000000000..590b0f3a8cf --- /dev/null +++ b/extra/html-extra/HtmlAttr/AttributeValueInterface.php @@ -0,0 +1,31 @@ +<?php + +/* + * This file is part of Twig. + * + * (c...
[ "extra/html-extra/HtmlAttr/AttributeValueInterface.php" ]
[ { "comment": "I think this deserves some phpdoc to explain the intent of the interface.", "path": "extra/html-extra/HtmlAttr/AttributeValueInterface.php", "hunk": "@@ -0,0 +1,8 @@\n+<?php\n+\n+namespace Twig\\Extra\\Html\\HtmlAttr;\n+\n+interface AttributeValueInterface", "resolving_sha": "42c12fa72...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
be careful. The short ternary operator uses an empty string as it implicit `else` clause, not `null`. Are strings actually valid ?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "be careful. The short ternary operator uses an empty string as it implicit `else` clause, not `null`. Are strings actually valid ?", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,113 @@\n+``html_attr_merge``\n+===================\n+\n+.. versionadded:: 3.23\n+\n+ The ``...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
shouldn't the merging rules also mention MergeInterface ?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "shouldn't the merging rules also mention MergeInterface ?", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,113 @@\n+``html_attr_merge``\n+===================\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr_merge`` filter was added in Twig 3.23.\n+\n+The ``html_attr_mer...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
This should probably mention that classes implementing this interface need to implement either `AttributeValueInterface` or `Stringable` to be actually usable when they are the last value in the merge.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlAttr/MergeableInterface.php b/extra/html-extra/HtmlAttr/MergeableInterface.php new file mode 100644 index 00000000000..e32693fa2d4 --- /dev/null +++ b/extra/html-extra/HtmlAttr/MergeableInterface.php @@ -0,0 +1,55 @@ +<?php + +/* + * This file is part of Twig. + * + * (c) Fabien Potenc...
[ "extra/html-extra/HtmlAttr/MergeableInterface.php" ]
[ { "comment": "This should probably mention that classes implementing this interface need to implement either `AttributeValueInterface` or `Stringable` to be actually usable when they are the last value in the merge.", "path": "extra/html-extra/HtmlAttr/MergeableInterface.php", "hunk": "@@ -0,0 +1,41 @@\...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
this does not apply any escaping of values (if they contain a `;` for instance), which probably makes them unsuited to process user-controlled values. Such limitation should be explicitly documented as devs might think that passing an array `{ font-size: user_value }` could be safe to restrict that the `user_value` var...
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlAttr/InlineStyle.php b/extra/html-extra/HtmlAttr/InlineStyle.php new file mode 100644 index 00000000000..8aa36b6462f --- /dev/null +++ b/extra/html-extra/HtmlAttr/InlineStyle.php @@ -0,0 +1,70 @@ +<?php + +/* + * This file is part of Twig. + * + * (c) Fabien Potencier + * + * For the f...
[ "extra/html-extra/HtmlAttr/InlineStyle.php" ]
[ { "comment": "this does not apply any escaping of values (if they contain a `;` for instance), which probably makes them unsuited to process user-controlled values. Such limitation should be explicitly documented as devs might think that passing an array `{ font-size: user_value }` could be safe to restrict tha...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
I think we should use a `ref` link to link directly to the merging rules instead.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "I think we should use a `ref` link to link directly to the merging rules instead.", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,170 @@\n+``html_attr``\n+=============\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added in Twig 3.23.\n+\n+The ``html_attr...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Shouldn't this come _after_ the section about style attributes, so that all special kind of attributes are handled first, before the general rule for arrays ?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "Shouldn't this come _after_ the section about style attributes, so that all special kind of attributes are handled first, before the general rule for arrays ?", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,170 @@\n+``html_attr``\n+=============\n+\n+.. versionadded:: 3.23\n+\...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
special rules also apply for `style`
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "special rules also apply for `style`", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,170 @@\n+``html_attr``\n+=============\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added in Twig 3.23.\n+\n+The ``html_attr`` function renders HTML attributes from one ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion loading ? {'aria-busy': 'true', class: ['btn-loading']}, ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "```suggestion\n loading ? {'aria-busy': 'true', class: ['btn-loading']},\n```", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,129 @@\n+``html_attr_merge``\n+===================\n+\n+.. _html_attr_merge:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr_merge`` fi...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
We should probably explain how to replace existing values here.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "We should probably explain how to replace existing values here.", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,129 @@\n+``html_attr_merge``\n+===================\n+\n+.. _html_attr_merge:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr_merge`` filter was added in Twi...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion * A map of attributes ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "```suggestion\n* A map of attributes\n```", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,129 @@\n+``html_attr_merge``\n+===================\n+\n+.. _html_attr_merge:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr_merge`` filter was added in Twig 3.23.\n+\n+The ``htm...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion The filter accepts a variadic list of mapping to merge. Each argument can be: ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "```suggestion\nThe filter accepts a variadic list of mapping to merge. Each argument can be:\n```", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,129 @@\n+``html_attr_merge``\n+===================\n+\n+.. _html_attr_merge:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_at...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion Used for style attributes. Handles both maps (property - value pairs) and sequences (CSS declarations): ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_type.rst b/doc/filters/html_attr_type.rst new file mode 100644 index 00000000000..7de4c6587ca --- /dev/null +++ b/doc/filters/html_attr_type.rst @@ -0,0 +1,123 @@ +``html_attr_type`` +================== + +.. _html_attr_type: + +.. versionadded:: 3.24 + + The ``html_attr_type`` fil...
[ "doc/filters/html_attr_type.rst" ]
[ { "comment": "```suggestion\nUsed for style attributes. Handles both maps (property - value pairs) and sequences (CSS declarations):\n```", "path": "doc/filters/html_attr_type.rst", "hunk": "@@ -0,0 +1,124 @@\n+``html_attr_type``\n+==================\n+\n+.. _html_attr_type:\n+\n+.. versionadded:: 3.23\...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion * ``value``: The sequence of attributes to convert ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_type.rst b/doc/filters/html_attr_type.rst new file mode 100644 index 00000000000..7de4c6587ca --- /dev/null +++ b/doc/filters/html_attr_type.rst @@ -0,0 +1,123 @@ +``html_attr_type`` +================== + +.. _html_attr_type: + +.. versionadded:: 3.24 + + The ``html_attr_type`` fil...
[ "doc/filters/html_attr_type.rst" ]
[ { "comment": "```suggestion\n* ``value``: The sequence of attributes to convert\n```", "path": "doc/filters/html_attr_type.rst", "hunk": "@@ -0,0 +1,124 @@\n+``html_attr_type``\n+==================\n+\n+.. _html_attr_type:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr_type`` filter was added in T...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion The ``html_attr`` function renders HTML attributes from one or more mapping, ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "```suggestion\nThe ``html_attr`` function renders HTML attributes from one or more mapping,\n```", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,187 @@\n+``html_attr``\n+=============\n+\n+.. _html_attr:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion The function accepts multiple attribute maps. Internally, it uses ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "```suggestion\nThe function accepts multiple attribute maps. Internally, it uses\n```", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,187 @@\n+``html_attr``\n+=============\n+\n+.. _html_attr:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added in Twig 3....
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion Style Attribute ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "```suggestion\nStyle Attribute\n```", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,187 @@\n+``html_attr``\n+=============\n+\n+.. _html_attr:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added in Twig 3.23.\n+\n+The ``html_attr`` function renders HTML a...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion The ``style`` attribute name has special handling when its value is a sequence of objects: ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "```suggestion\nThe ``style`` attribute name has special handling when its value is a sequence of objects:\n```", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,187 @@\n+``html_attr``\n+=============\n+\n+.. _html_attr:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` func...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion {# Mappings become CSS declarations #} ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/functions/html_attr.rst b/doc/functions/html_attr.rst new file mode 100644 index 00000000000..db370cb9ffe --- /dev/null +++ b/doc/functions/html_attr.rst @@ -0,0 +1,202 @@ +``html_attr`` +============= + +.. _html_attr: + +.. versionadded:: 3.23 + + The ``html_attr`` function was added in Twig 3.24....
[ "doc/functions/html_attr.rst" ]
[ { "comment": "```suggestion\n {# Mappings become CSS declarations #}\n```", "path": "doc/functions/html_attr.rst", "hunk": "@@ -0,0 +1,187 @@\n+``html_attr``\n+=============\n+\n+.. _html_attr:\n+\n+.. versionadded:: 3.23\n+\n+ The ``html_attr`` function was added in Twig 3.23.\n+\n+The ``html_att...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Should precise if escaping is done after
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlAttr/AttributeValueInterface.php b/extra/html-extra/HtmlAttr/AttributeValueInterface.php new file mode 100644 index 00000000000..590b0f3a8cf --- /dev/null +++ b/extra/html-extra/HtmlAttr/AttributeValueInterface.php @@ -0,0 +1,31 @@ +<?php + +/* + * This file is part of Twig. + * + * (c...
[ "extra/html-extra/HtmlAttr/AttributeValueInterface.php" ]
[ { "comment": "Should precise if escaping is done after", "path": "extra/html-extra/HtmlAttr/AttributeValueInterface.php", "hunk": "@@ -0,0 +1,30 @@\n+<?php\n+\n+/*\n+ * This file is part of Twig.\n+ *\n+ * (c) Fabien Potencier\n+ *\n+ * For the full copyright and license information, please view the LIC...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Maybe list the supported values here
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Maybe list the supported values here", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -114,15 +123,134 @@ public static function htmlClasses(...$args): string\n }\n \n /**\n- * @param string|list<string|null> $base\n+ * @param string|list<string|null> ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion .. versionadded:: 3.24 ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_merge.rst b/doc/filters/html_attr_merge.rst new file mode 100644 index 00000000000..66f2efa7ab1 --- /dev/null +++ b/doc/filters/html_attr_merge.rst @@ -0,0 +1,141 @@ +``html_attr_merge`` +=================== + +.. _html_attr_merge: + +.. versionadded:: 3.24 + + The ``html_attr_merg...
[ "doc/filters/html_attr_merge.rst" ]
[ { "comment": "```suggestion\n.. versionadded:: 3.24\n```", "path": "doc/filters/html_attr_merge.rst", "hunk": "@@ -0,0 +1,141 @@\n+``html_attr_merge``\n+===================\n+\n+.. _html_attr_merge:\n+\n+.. versionadded:: 3.23", "resolving_sha": "42c12fa720e3c7baa2def7e44d58df2c38acacaf", "resol...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion .. versionadded:: 3.24 ```
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/doc/filters/html_attr_type.rst b/doc/filters/html_attr_type.rst new file mode 100644 index 00000000000..7de4c6587ca --- /dev/null +++ b/doc/filters/html_attr_type.rst @@ -0,0 +1,123 @@ +``html_attr_type`` +================== + +.. _html_attr_type: + +.. versionadded:: 3.24 + + The ``html_attr_type`` fil...
[ "doc/filters/html_attr_type.rst" ]
[ { "comment": "```suggestion\n.. versionadded:: 3.24\n```", "path": "doc/filters/html_attr_type.rst", "hunk": "@@ -0,0 +1,123 @@\n+``html_attr_type``\n+==================\n+\n+.. _html_attr_type:\n+\n+.. versionadded:: 3.23", "resolving_sha": "42c12fa720e3c7baa2def7e44d58df2c38acacaf", "resolving...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Should it be marked as `@internal` like `htmlAttrType`?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Should it be marked as `@internal` like `htmlAttrType`?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -125,4 +134,123 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $def...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
Should it be marked as `@internal` like `htmlAttrType`?
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "Should it be marked as `@internal` like `htmlAttrType`?", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -125,4 +134,123 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $def...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
We could use `match` here.
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "We could use `match` here.", "path": "extra/html-extra/HtmlExtension.php", "hunk": "@@ -125,4 +134,123 @@ public static function htmlCva(array|string $base = [], array $variants = [], ar\n {\n return new Cva($base, $variants, $compoundVariants, $defaultVariant);\n }\n+\n+ ...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion try { $value = json_encode($value, \JSON_THROW_ON_ERROR); } catch (\JsonException $e) { throw new RuntimeError(\sprintf('The "%s" attribute value cannot be JSON encoded.', $name), previous: $e); } `...
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\n try {\n $value = json_encode($value, \\JSON_THROW_ON_ERROR);\n } catch (\\JsonException $e) {\n throw new RuntimeError(\\sprintf('The \"%s\" attribute value cannot be JSON encoded.', $name), previou...
true
twigphp/Twig
3,930
comment_to_fix
Add an `html_attr` function to make outputting HTML attributes easier
```suggestion if (\is_object($value) && !$value instanceof \Stringable) { throw new RuntimeError(\sprintf('The "%s" attribute value should be a scalar, an iterable, or an object implementing "%s", got "%s".', $name, \Stringable::class, get_debug_type($value))); } $re...
9c85915a73bc804b250c9c3fcfae78fce57c124f
42c12fa720e3c7baa2def7e44d58df2c38acacaf
diff --git a/extra/html-extra/HtmlExtension.php b/extra/html-extra/HtmlExtension.php index 3fd352ba1a9..966b43327d2 100644 --- a/extra/html-extra/HtmlExtension.php +++ b/extra/html-extra/HtmlExtension.php @@ -12,9 +12,15 @@ namespace Twig\Extra\Html; use Symfony\Component\Mime\MimeTypes; +use Twig\Environment; use...
[ "extra/html-extra/HtmlExtension.php" ]
[ { "comment": "```suggestion\n if (\\is_object($value) && !$value instanceof \\Stringable) {\n throw new RuntimeError(\\sprintf('The \"%s\" attribute value should be a scalar, an iterable, or an object implementing \"%s\", got \"%s\".', $name, \\Stringable::class, get_debug_type($value)...
true
twigphp/Twig
4,779
issue_to_patch
fix MatchesBinary namespace in changelog
e56cdfdded10559e2371349c0e9b97ae973dad84
442bcd46259d9a2fa2d74ad8f07cce3b64fa8cdc
diff --git a/CHANGELOG b/CHANGELOG index 7f81ddaec6a..98e3bac5c08 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,7 +1,7 @@ # 3.24.0 (2026-XX-XX) * Deprecate not implementing the `getOperatorTokens()` method in `ExpressionParserInterface` implementations - * Deprecate passing a non-`AbstractExpression` node to `Parse...
[ "CHANGELOG" ]
[]
true
twitter/algebird
972
issue_to_patch
Update shapeless to 2.3.7
Updates [com.chuusai:shapeless](https://github.com/milessabin/shapeless) from 2.3.6 to 2.3.7. [GitHub Release Notes](https://github.com/milessabin/shapeless/releases/tag/v2.3.7) - [Version Diff](https://github.com/milessabin/shapeless/compare/v2.3.6...v2.3.7) I'll automatically update this PR to resolve conflicts as l...
b43c0f30111a67f006221620e597d4c4563bcc1a
b33c228903c2c02b7161c72ffeda4b1381bdeb1c
diff --git a/build.sbt b/build.sbt index e0199fe2a..eb7f2f620 100644 --- a/build.sbt +++ b/build.sbt @@ -297,7 +297,7 @@ lazy val algebirdGeneric = module("generic") .settings( crossScalaVersions += "2.13.5", libraryDependencies ++= Seq( - "com.chuusai" %% "shapeless" % "2.3.6", + "com.chuusai" %...
[ "build.sbt" ]
[]
true
twitter/algebird
1,045
issue_to_patch
Update junit-interface to 0.13.3
Updates [com.github.sbt:junit-interface](https://github.com/sbt/junit-interface) from 0.13.2 to 0.13.3. [GitHub Release Notes](https://github.com/sbt/junit-interface/releases/tag/v0.13.3) - [Version Diff](https://github.com/sbt/junit-interface/compare/v0.13.2...v0.13.3) I'll automatically update this PR to resolve con...
caea538651b66dacfe16faf29af6b3c2f22d4191
68f6e11b044721a912e52861710b6099345bbbca
diff --git a/build.sbt b/build.sbt index 92efc8b9c..f00574264 100644 --- a/build.sbt +++ b/build.sbt @@ -72,7 +72,7 @@ val sharedSettings = Seq( javacOptions ++= Seq("-target", "1.6", "-source", "1.6"), libraryDependencies ++= Seq( "junit" % "junit" % "4.13.2" % Test, - "com.github.sbt" % "junit-interface...
[ "build.sbt" ]
[]
true
twitter/algebird
692
issue_to_patch
bump dependencies
The scala-steward PRs 683-691 are broken due to scala 2.12.10 and I can't figure out a way to rebase them for Travis build. This PR combines them on top of #682 which fixes the build.
ebab2a2e37770086abd3719394c1114155e9162f
465475c6e7e1b99060b8ce3b0f6ef6947f34eaa6
diff --git a/build.sbt b/build.sbt index 132660026..eae361cb0 100644 --- a/build.sbt +++ b/build.sbt @@ -3,13 +3,13 @@ import algebird._ import com.typesafe.tools.mima.core._ import pl.project13.scala.sbt.JmhPlugin -val algebraVersion = "0.7.0" -val bijectionVersion = "0.9.4" -val javaEwahVersion = "1.1.4" +val alg...
[ "build.sbt" ]
[]
true
twitter/algebird
1,083
issue_to_patch
Update sbt-scalafix to 0.10.4
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.10.1 to 0.10.4. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.10.4) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.10.1...v0.10.4) I'll automatically update this PR to ...
4d9a72d568cb0dc43e7a909d91766c375be23c3f
f4655cd8813bac4d17b96e37ef866616cf85824b
diff --git a/project/plugins.sbt b/project/plugins.sbt index 11663c638..ecf6aaf5a 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,7 +12,7 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.0") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
729
issue_to_patch
Update sbt-scalafmt to 2.0.7
Updates org.scalameta:sbt-scalafmt from 2.0.6 to 2.0.7. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below. Have a fantastic day writing Scala!...
6769506d5d4301f03bc0ace651b5b4bd3b04057b
a1d29f8161feae2b4a696e1e2c04f2944aff95de
diff --git a/project/plugins.sbt b/project/plugins.sbt index 9defb2a9b..32c92f63a 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -9,7 +9,7 @@ addSbtPlugin("com.47deg" % "sbt-microsites" % "0.9.7") addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.2") addSbtPlugin("com.github.gseitz" % "sbt-release" % "...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
793
issue_to_patch
Update scalacheck-shapeless_1.14 to 1.2.5
Updates [com.github.alexarchambault:scalacheck-shapeless_1.14](https://github.com/alexarchambault/scalacheck-shapeless) from 1.2.4 to 1.2.5. [GitHub Release Notes](https://github.com/alexarchambault/scalacheck-shapeless/releases/tag/v1.2.5) - [Version Diff](https://github.com/alexarchambault/scalacheck-shapeless/compar...
62eb3b3a24be4dda360c87c71bd1d37d548b224d
dfa0a8dcfd4d03f8c3aee47262d467e79bd64450
diff --git a/build.sbt b/build.sbt index d70143fd1..86f71e747 100644 --- a/build.sbt +++ b/build.sbt @@ -322,7 +322,7 @@ lazy val algebirdGeneric = module("generic") crossScalaVersions += "2.13.1", libraryDependencies ++= Seq( "com.chuusai" %% "shapeless" % "2.3.3", - "com.github.alexarchambault" ...
[ "build.sbt" ]
[]
true
twitter/algebird
738
issue_to_patch
Update sbt-scalafix to 0.9.8
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) [from 0.9.7 to 0.9.8](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.7...v0.9.8). [Release Notes/Changelog](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.8) I'll automatically update this PR to resolve conflicts...
935f4bb5f575a07c1331fe46f01f01bcdfaf2302
1d6f534db9515974edb901dfa5f90dd9917e1b30
diff --git a/project/plugins.sbt b/project/plugins.sbt index 86aa0f473..0e85809d0 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -15,4 +15,4 @@ addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.6.0") addSbtPlugin("org.xerial.sbt" % "sbt-sonat...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
728
issue_to_patch
Update util-core to 19.10.0
Updates [com.twitter:util-core](https://github.com/twitter/util) from 6.45.0 to 19.10.0. [Release Notes/Changelog](https://github.com/twitter/util/blob/master/CHANGELOG.rst) I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just...
6769506d5d4301f03bc0ace651b5b4bd3b04057b
063696cd42da26e37a236567e7e5deb5c926914c
diff --git a/build.sbt b/build.sbt index a40caa74c..9e7d720dc 100644 --- a/build.sbt +++ b/build.sbt @@ -10,7 +10,7 @@ val paradiseVersion = "2.1.1" val quasiquotesVersion = "2.1.0" val scalaTestVersion = "3.0.8" val scalacheckVersion = "1.14.2" -val utilVersion = "6.45.0" +val utilVersion = "19.10.0" val utilVersi...
[ "build.sbt" ]
[]
true
twitter/algebird
676
issue_to_patch
Use https instead of http in urls
This PR changes every instance of an http url to its https version for security reasons.
07b185f69f5b3b1f5da1c23b84a8983ebbd921fa
8223d7640791114b5e7d0270bba42078417d8e22
diff --git a/build.sbt b/build.sbt index ef41a98b7..9d10d58d7 100644 --- a/build.sbt +++ b/build.sbt @@ -262,7 +262,7 @@ lazy val docSettings = Seq( micrositeDescription := "Abstract Algebra for Scala.", micrositeAuthor := "Algebird's contributors", micrositeHighlightTheme := "atom-one-light", - micrositeHome...
[ "build.sbt", "project/plugins.sbt", "sbt" ]
[ { "comment": "link resolved", "path": "build.sbt", "hunk": "@@ -262,7 +262,7 @@ lazy val docSettings = Seq(\n micrositeDescription := \"Abstract Algebra for Scala.\",\n micrositeAuthor := \"Algebird's contributors\",\n micrositeHighlightTheme := \"atom-one-light\",\n- micrositeHomepage := \"http:...
true
twitter/algebird
713
issue_to_patch
Remove procedure syntax
d2e13c66b82583eb850a95c6c241164fc19f6b38
4e5bb8464a991ddfa058ca87671fa038d1b75eb5
diff --git a/.scalafix.conf b/.scalafix.conf index bdcd8bd40..999c57287 100644 --- a/.scalafix.conf +++ b/.scalafix.conf @@ -1,3 +1,4 @@ rules = [ RemoveUnused + ProcedureSyntax ] diff --git a/algebird-core/src/main/scala/com/twitter/algebird/AdaptiveCache.scala b/algebird-core/src/main/scala/com/twitter/algebird...
[ ".scalafix.conf", "algebird-core/src/main/scala/com/twitter/algebird/AdaptiveCache.scala", "algebird-core/src/main/scala/com/twitter/algebird/Monoid.scala", "algebird-core/src/main/scala/com/twitter/algebird/QTree.scala", "algebird-core/src/main/scala/com/twitter/algebird/matrix/DenseMatrix.scala", "algeb...
[]
diff --git a/algebird-test/src/test/scala/com/twitter/algebird/AppendAggregatorTest.scala b/algebird-test/src/test/scala/com/twitter/algebird/AppendAggregatorTest.scala index 46cecf843..f2e3d7175 100644 --- a/algebird-test/src/test/scala/com/twitter/algebird/AppendAggregatorTest.scala +++ b/algebird-test/src/test/scala...
true
twitter/algebird
1,090
issue_to_patch
Update sbt to 1.7.3
Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from 1.7.1 to 1.7.3. [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.7.3) - [Version Diff](https://github.com/sbt/sbt/compare/v1.7.1...v1.7.3) I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If y...
f8952a2f4367219578e7c653598278db0bb76796
e980b4aa65c4c2809bc5b9fd367ff8ed9289fa3e
diff --git a/project/build.properties b/project/build.properties index 22af2628c..6a9f03889 100644 --- a/project/build.properties +++ b/project/build.properties @@ -1,1 +1,1 @@ -sbt.version=1.7.1 +sbt.version=1.7.3
[ "project/build.properties" ]
[]
true
twitter/algebird
737
issue_to_patch
Update sbt-scalafmt to 2.2.1
Updates [org.scalameta:sbt-scalafmt](https://github.com/scalameta/sbt-scalafmt) [from 2.2.0 to 2.2.1](https://github.com/scalameta/sbt-scalafmt/compare/v2.2.0...v2.2.1). [Release Notes/Changelog](https://github.com/scalameta/sbt-scalafmt/releases/tag/v2.2.1) I'll automatically update this PR to resolve conflicts as lo...
50010a036ed0af0cad48dec820888be3a702e741
ed4d1728960167546b039d04dab5f7907ec6395d
diff --git a/project/plugins.sbt b/project/plugins.sbt index aa58b5d97..86aa0f473 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -9,7 +9,7 @@ addSbtPlugin("com.47deg" % "sbt-microsites" % "0.9.7") addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.2") addSbtPlugin("com.github.gseitz" % "sbt-release" % "...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
792
issue_to_patch
Update sbt-mima-plugin to 0.7.0
Updates [com.typesafe:sbt-mima-plugin](http://github.com/lightbend/mima) from 0.6.4 to 0.7.0. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below...
62eb3b3a24be4dda360c87c71bd1d37d548b224d
c2cfaaa6136ed6062e209d84bfd802b0d5cd0806
diff --git a/project/plugins.sbt b/project/plugins.sbt index 98c513ea1..c5f2e8349 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -10,7 +10,7 @@ addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3") addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.13") addSbtPlugin("com.jsuereth" % "sbt-pgp" % "2...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
714
issue_to_patch
Fix: case classes must have a non-implicit parameter list
This triggers mima with the same issue we have seen when updating mima to the last version.
4387bd33899937a3ad1a4fa4ed161cc8561629f1
fe416cabd23c01ab956861a04cedd47ca18660e5
diff --git a/algebird-core/src/main/scala/com/twitter/algebird/Max.scala b/algebird-core/src/main/scala/com/twitter/algebird/Max.scala index af1098d0f..516b764bc 100644 --- a/algebird-core/src/main/scala/com/twitter/algebird/Max.scala +++ b/algebird-core/src/main/scala/com/twitter/algebird/Max.scala @@ -204,7 +204,7 @@...
[ "algebird-core/src/main/scala/com/twitter/algebird/Max.scala", "algebird-core/src/main/scala/com/twitter/algebird/Min.scala" ]
[ { "comment": "I guess it's backwards compat as long as people don't call `aggr.ord`?", "path": "build.sbt", "hunk": "@@ -197,6 +197,8 @@ lazy val mimaSettings = Def.settings(\n .exclude[DirectMissingMethodProblem](\"com.twitter.algebird.util.summer.HeavyHittersPercent.apply\"),\n ProblemFilter...
true
twitter/algebird
712
issue_to_patch
remove sbt wrapper and 0.13 cache settings
b65215557f46a18fe530bb4f9e6042a5cf5644b9
24681b850fddfb1dd94bbe6a7ca3bfd7254a9434
diff --git a/.travis.yml b/.travis.yml index 3e69824fd..40e96322a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,7 +36,6 @@ install: cache: directories: - - $HOME/.sbt/0.13/dependency - $HOME/.sbt/boot/scala* - $HOME/.sbt/launchers - $HOME/.ivy2/cache diff --git a/sbt b/sbt deleted file mode 100755 i...
[ ".travis.yml", "sbt" ]
[]
true
twitter/algebird
1,026
issue_to_patch
Update scala-collection-compat to 2.6.0
Updates [org.scala-lang.modules:scala-collection-compat](https://github.com/scala/scala-collection-compat) from 2.5.0 to 2.6.0. [GitHub Release Notes](https://github.com/scala/scala-collection-compat/releases/tag/v2.6.0) - [Version Diff](https://github.com/scala/scala-collection-compat/compare/v2.5.0...v2.6.0) I'll au...
1e8ba3e1e26e0b5f1f07896307ee16b3211bbb71
5649c5e9fa9ae879d7865f62271b2f9c7d7abd55
diff --git a/build.sbt b/build.sbt index 0bace9aff..92efc8b9c 100644 --- a/build.sbt +++ b/build.sbt @@ -11,7 +11,7 @@ val quasiquotesVersion = "2.1.0" val scalaTestVersion = "3.2.10" val scalaTestPlusVersion = "3.1.0.0-RC2" val scalacheckVersion = "1.15.2" -val scalaCollectionCompat = "2.5.0" +val scalaCollectionCo...
[ "build.sbt" ]
[]
true
twitter/algebird
1,022
issue_to_patch
Update scala-library, scala-reflect to 2.13.7
Updates * [org.scala-lang:scala-library](https://github.com/scala/scala.git) * [org.scala-lang:scala-reflect](https://github.com/scala/scala.git) from 2.13.6 to 2.13.7. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just ...
8ee9e2c4ca434c50c218daf96999b5d0a508dd6d
b1729e67c2ef750bff78036ada71c39affad748c
diff --git a/build.sbt b/build.sbt index 30ecdf893..0bace9aff 100644 --- a/build.sbt +++ b/build.sbt @@ -209,7 +209,7 @@ def module(name: String) = { } lazy val algebirdCore = module("core").settings( - crossScalaVersions += "2.13.6", + crossScalaVersions += "2.13.7", initialCommands := """ ...
[ "build.sbt" ]
[]
true
twitter/algebird
1,010
issue_to_patch
Update scalafmt-core to 3.0.5
Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from 3.0.4 to 3.0.5. [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.0.5) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.0.4...v3.0.5) I'll automatically update this PR to resolve conflicts as l...
a805061e7e8adf9f3f0f8b7533e4ad9b798cfde8
6fff68ad7ac660ec92b144799a7e76c0b07537e3
diff --git a/.scalafmt.conf b/.scalafmt.conf index 720a1b73e..67fa3623c 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,4 +1,4 @@ -version=3.0.4 +version=3.0.5 maxColumn = 110 docstrings.style = Asterisk newlines.alwaysBeforeMultilineDef = false
[ ".scalafmt.conf" ]
[]
true
twitter/algebird
1,028
issue_to_patch
Update sbt-scalafix to 0.9.32
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.31 to 0.9.32. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.32) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.31...v0.9.32) I'll automatically update this PR to ...
4723c5fc51db13eb9057a897517ba1f919d02555
4320c168b39d748e2d9f73a64007614aec677ad6
diff --git a/project/plugins.sbt b/project/plugins.sbt index b65057255..77833bb87 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.0.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,021
issue_to_patch
Update scalafmt-core to 3.0.8
Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from 3.0.7 to 3.0.8. [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.0.8) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.0.7...v3.0.8) I'll automatically update this PR to resolve conflicts as l...
68f80682441fd8f25704bf27071cd7c6d072bd5f
cf4a5fbc87a228be7492779a8b9496d9c2e876b5
diff --git a/.scalafmt.conf b/.scalafmt.conf index 9729d0ad0..7c0a60f39 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,4 +1,4 @@ -version=3.0.7 +version=3.0.8 maxColumn = 110 docstrings.style = Asterisk newlines.alwaysBeforeMultilineDef = false diff --git a/algebird-benchmark/src/main/scala/com/twitter/algeb...
[ ".scalafmt.conf", "algebird-benchmark/src/main/scala/com/twitter/algebird/benchmark/HLLPresentBenchmark.scala", "algebird-core/src/main/scala/com/twitter/algebird/Eventually.scala", "algebird-core/src/main/scala/com/twitter/algebird/First.scala", "algebird-core/src/main/scala/com/twitter/algebird/Interval.s...
[]
diff --git a/algebird-test/src/test/scala/com/twitter/algebird/HyperLogLogTest.scala b/algebird-test/src/test/scala/com/twitter/algebird/HyperLogLogTest.scala index 0e44cb8f1..ea3ed65f9 100644 --- a/algebird-test/src/test/scala/com/twitter/algebird/HyperLogLogTest.scala +++ b/algebird-test/src/test/scala/com/twitter/al...
true
twitter/algebird
1,017
issue_to_patch
Update scalafmt-core to 3.0.7
Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from 3.0.6 to 3.0.7. [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.0.7) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.0.6...v3.0.7) I'll automatically update this PR to resolve conflicts as l...
ef239cadf01430a3328fc9bd961f3089c2916ab7
31807d5586748228d7139e46d131fef69ec26468
diff --git a/.scalafmt.conf b/.scalafmt.conf index ec5122b68..9729d0ad0 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,4 +1,4 @@ -version=3.0.6 +version=3.0.7 maxColumn = 110 docstrings.style = Asterisk newlines.alwaysBeforeMultilineDef = false diff --git a/algebird-core/src/main/scala/com/twitter/algebird/M...
[ ".scalafmt.conf", "algebird-core/src/main/scala/com/twitter/algebird/MomentsGroup.scala" ]
[]
true
twitter/algebird
1,011
issue_to_patch
Update JavaEWAH to 1.1.13
Updates com.googlecode.javaewah:JavaEWAH from 1.1.12 to 1.1.13. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below. Configure Scala Steward for...
d45c14f7c3ea28c4b02c97814de19e90fbef54c8
a150699c3e90c3e0194c3deef0ad645d22a612c5
diff --git a/build.sbt b/build.sbt index 2581a32cf..5b921e153 100644 --- a/build.sbt +++ b/build.sbt @@ -4,7 +4,7 @@ import pl.project13.scala.sbt.JmhPlugin val algebraVersion = "2.0.0" val bijectionVersion = "0.9.7" -val javaEwahVersion = "1.1.12" +val javaEwahVersion = "1.1.13" val kindProjectorVersion = "0.13.2...
[ "build.sbt" ]
[]
true
twitter/algebird
1,016
issue_to_patch
Bump actions/checkout from 2.3.4 to 2.3.5
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v2.3.5</h2> <p>Update dependencies</p> </blockquote> </detai...
707e0537102d7d4f128f1757735512a67114f38c
14d4f74106b982b42b2c6af4188f3132a3cef321
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d3342c957..a2dc4b60e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ jobs: checks: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.4 + - uses: actions/checkout@v2.3.5 -...
[ ".github/workflows/ci.yml", ".github/workflows/release.yml" ]
[]
true
twitter/algebird
1,012
issue_to_patch
Update scalafmt-core to 3.0.6
Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from 3.0.5 to 3.0.6. [GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.0.6) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.0.5...v3.0.6) I'll automatically update this PR to resolve conflicts as l...
c8805726670aba4b819eff9a52fea3c94a9cb128
10a27c1e0418609ff48895f3e8f61e7d29d5f42d
diff --git a/.scalafmt.conf b/.scalafmt.conf index 67fa3623c..ec5122b68 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,4 +1,4 @@ -version=3.0.5 +version=3.0.6 maxColumn = 110 docstrings.style = Asterisk newlines.alwaysBeforeMultilineDef = false
[ ".scalafmt.conf" ]
[]
true
twitter/algebird
1,025
issue_to_patch
Bump actions/checkout from 2.3.5 to 2.4.0
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v2.4.0</h2> <ul> <li>Convert SSH URLs like <code>org-&lt;ORG...
160c9cfe25e8bca7306133bb94974ff0a1a571b6
5f627a26a40df6d6ae2b87d1e3777bc9f06e4269
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a2dc4b60e..351aaaa7f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,7 +5,7 @@ jobs: checks: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.5 + - uses: actions/checkout@v2.4.0 -...
[ ".github/workflows/ci.yml", ".github/workflows/release.yml" ]
[]
true
twitter/algebird
1,014
issue_to_patch
Update sbt-scoverage to 1.9.1
Updates [org.scoverage:sbt-scoverage](https://github.com/scoverage/sbt-scoverage) from 1.9.0 to 1.9.1. [GitHub Release Notes](https://github.com/scoverage/sbt-scoverage/releases/tag/v1.9.1) - [Version Diff](https://github.com/scoverage/sbt-scoverage/compare/v1.9.0...v1.9.1) I'll automatically update this PR to resolve...
33873057f8b3b287952b5a7f840d1878229af3df
11e6eb76e6bda6df552fb54df30712667a141371
diff --git a/project/plugins.sbt b/project/plugins.sbt index a01746968..e4b915aef 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -10,7 +10,7 @@ addSbtPlugin("com.eed3si9n" % "sbt-unidoc" % "0.4.3") addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.3") addSbtPlugin("com.typesafe" % "sbt-mima-plugin" ...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,023
issue_to_patch
Update github-action scala 2.13 version
160c9cfe25e8bca7306133bb94974ff0a1a571b6
e5dc7f406a6dbb74b8b8028032ab2168d42079ef
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a2dc4b60e..4416559da 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,7 @@ jobs: scala: - 2.11.12 - 2.12.15 - - 2.13.6 + - 2.13.7 test-coverage: runs-on: ubunt...
[ ".github/workflows/ci.yml" ]
[]
true
twitter/algebird
1,030
issue_to_patch
Update sbt-scalafmt to 2.4.4
Updates [org.scalameta:sbt-scalafmt](https://github.com/scalameta/sbt-scalafmt) from 2.4.3 to 2.4.4. [GitHub Release Notes](https://github.com/scalameta/sbt-scalafmt/releases/tag/v2.4.4) - [Version Diff](https://github.com/scalameta/sbt-scalafmt/compare/v2.4.3...v2.4.4) I'll automatically update this PR to resolve con...
0f9dfbd234315a64386f167cee77d56089d4093d
6f83a90ffaa2e2faa99f093aab4cfd5710a205b5
diff --git a/project/plugins.sbt b/project/plugins.sbt index 77833bb87..d51f60dda 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -7,7 +7,7 @@ resolvers ++= Seq( addSbtPlugin("com.47deg" % "sbt-microsites" % "1.3.4") addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0") -addSbtPlugin("org.scalameta"...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,147
issue_to_patch
Update sbt-scalafix to 0.11.1
## About this PR 📦 Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from `0.11.0` to `0.11.1` 📜 [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.11.1) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.11.0...v0.11.1) ## Usage ✅...
8ec8ce82007cd5d8c2a3f4141b74e192addb90ca
66924d89640c1a48df0ea7f2e739ffcc59bc3774
diff --git a/project/plugins.sbt b/project/plugins.sbt index c6942c3dd..4aa933011 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -11,7 +11,7 @@ addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.0") addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.3") addSbtPlugin("org.scoverage" % "sbt-scovera...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,116
issue_to_patch
Update sbt-scalafix to 0.11.0
## About this PR 📦 Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from `0.10.4` to `0.11.0` 📜 [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.11.0) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.10.4...v0.11.0) ## Usage ✅...
1b02953f29c9047998e50e7ff96eb3952a6c4dc6
7d3221debb40ab3dc883420d854ec69b73f3dcbc
diff --git a/project/plugins.sbt b/project/plugins.sbt index 5bff27a4b..55fec5748 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -11,7 +11,7 @@ addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.0") addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.1") addSbtPlugin("org.scoverage" % "sbt-scovera...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,061
issue_to_patch
Update sbt-scalafix to 0.10.0
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.34 to 0.10.0. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.10.0) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.34...v0.10.0) I'll automatically update this PR to ...
3cceaae19b29cc91f1f60b82d40ef20df34fdff9
f57510484ad6ca035890b7cc23ecb94062544094
diff --git a/project/plugins.sbt b/project/plugins.sbt index 69feeebd1..10abbe949 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.0.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,065
issue_to_patch
Update sbt-scalafix to 0.10.1
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.10.0 to 0.10.1. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.10.1) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.10.0...v0.10.1) I'll automatically update this PR to ...
c18a6b7c86c34e8cc7b3747fc1ea83d42c8b5410
55011f73f89f77fb6c81d2f213fd6ae840716064
diff --git a/project/plugins.sbt b/project/plugins.sbt index 18d8df595..99deee604 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.0") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,048
issue_to_patch
Update sbt-scalafix to 0.9.34
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.32 to 0.9.34. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.34) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.32...v0.9.34) I'll automatically update this PR to ...
7101c12349468b2f5bdbe7b6bbee91cbfd9614df
da9e36f08db1f3b1b169b93dd1544116dbf3c162
diff --git a/project/plugins.sbt b/project/plugins.sbt index e27ed36e7..69feeebd1 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.0.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
1,005
issue_to_patch
Update sbt-scalafix to 0.9.31
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.30 to 0.9.31. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.31) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.30...v0.9.31) I'll automatically update this PR to ...
723886ba90fe592c64eac16a0df74597546698ae
05b0e4abb6882e9efe8fffd95729ccb306ba6d7a
diff --git a/project/plugins.sbt b/project/plugins.sbt index 9148b1626..8434171de 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.0.0") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
993
issue_to_patch
Update sbt-scalafix to 0.9.30
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.29 to 0.9.30. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.30) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.29...v0.9.30) I'll automatically update this PR to ...
842d12c0e8d242fc5fba4b173f0c89acc4085be2
412e9a4af94835061ba22520aa8dc214faae7a9c
diff --git a/project/plugins.sbt b/project/plugins.sbt index f82dbd13d..740f326a5 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.2") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
983
issue_to_patch
Update sbt-scalafix to 0.9.29
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.28 to 0.9.29. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.29) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.28...v0.9.29) I'll automatically update this PR to ...
6852967febe33d6d5dc070726d706d02bb3d4acd
131979163df30e25ce6dbb9d1ad661e09f511cc0
diff --git a/project/plugins.sbt b/project/plugins.sbt index 4bf5a1801..bf5a59dd6 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.2") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
978
issue_to_patch
Update sbt-scalafix to 0.9.28
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.27 to 0.9.28. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.28) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.27...v0.9.28) I'll automatically update this PR to ...
f8e8bc539fed17f242b55078e3f56e636e210b22
475d90e88a4c1f4e45c3fce781b784c72aa68d1b
diff --git a/project/plugins.sbt b/project/plugins.sbt index 4e70722b4..48d429a4b 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.9.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
937
issue_to_patch
Update sbt-scalafix to 0.9.27
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.26 to 0.9.27. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.27) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.26...v0.9.27) I'll automatically update this PR to ...
fce81e55ae539bc85c9b10f158766ab755e9e112
fafdf7def8f6768ca63600a8d25fa78833ea7927
diff --git a/project/plugins.sbt b/project/plugins.sbt index 19be3d268..a376daf80 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
930
issue_to_patch
Update sbt-scalafix to 0.9.26
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.25 to 0.9.26. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.26) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.25...v0.9.26) I'll automatically update this PR to ...
b69930783ee9daa361921e6fc3a9aecfd263e13a
71d69a40dab8ed11ecc4dd680816271e5d9fdbd5
diff --git a/project/plugins.sbt b/project/plugins.sbt index 2a92852dd..350ab88b0 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true
twitter/algebird
911
issue_to_patch
Update sbt-scalafix to 0.9.25
Updates [ch.epfl.scala:sbt-scalafix](https://github.com/scalacenter/sbt-scalafix) from 0.9.24 to 0.9.25. [GitHub Release Notes](https://github.com/scalacenter/sbt-scalafix/releases/tag/v0.9.25) - [Version Diff](https://github.com/scalacenter/sbt-scalafix/compare/v0.9.24...v0.9.25) I'll automatically update this PR to ...
aab8e047a1b13a8831d628413bc0a0ec9df3af10
735089ed1ea279064b9f17c99ce0f631bd0c67bc
diff --git a/project/plugins.sbt b/project/plugins.sbt index 550dad77d..ad50a18e4 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -12,5 +12,5 @@ addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "0.8.1") addSbtPlugin("com.typesafe.sbt" % "sbt-ghpages" % "0.6.3") addSbtPlugin("org.scoverage" % "sbt-scove...
[ "project/plugins.sbt" ]
[]
true