Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
varvet/pundit
835
issue_to_patch
Move `Pundit::SUFFIX` to `Pundit::PolicyFinder::SUFFIX`
This sprung out of #834. We keep the old constant as an alias for backwards-compatibility. ## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have added relevant tests. - [x] I have adjusted relevant documentation. - [x] I have made sure the indivi...
3bb2021709ab9cd409f4fb201e4608e212e6f8b7
3010964f64ae30c274643d2c1150d132bfe3a68c
diff --git a/CHANGELOG.md b/CHANGELOG.md index b16cddbc..d83e138e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +## Changed + +- Deprecated `Pundit::SUFFIX`, moved it to `Pundit::PolicyFinder::SUFFIX` (#835) + ## 2.4.0 (2024-08-26) ## Changed diff --git a/lib/pundit.rb b/lib/pundi...
[ "CHANGELOG.md", "lib/pundit.rb", "lib/pundit/policy_finder.rb", "spec/policy_finder_spec.rb" ]
[]
diff --git a/spec/policy_finder_spec.rb b/spec/policy_finder_spec.rb index c387b024..2f89e04f 100644 --- a/spec/policy_finder_spec.rb +++ b/spec/policy_finder_spec.rb @@ -8,6 +8,11 @@ let(:comment) { CommentFourFiveSix.new } let(:article) { Article.new } + describe "SUFFIX" do + specify { expect(described_c...
true
varvet/pundit
834
issue_to_patch
Code janitoring (docs, test structure, dev dependencies)
These are intended to be QoL improvements for developing Pundit, and not actual changes to Pundit as it's used. ## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have made sure the individual commits are meaningful. - [x] I have added relevant lines t...
ec75796fbb6ff2e8c03e888f2c0028e10231810c
640a6377c3fee6760afc82881e3f28f06549b468
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5ed27808..eec2515b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -2,9 +2,8 @@ name: Main on: push: - branches: [ "main" ] + branches: ["main"] pull_request: - branches: [ "main" ] workflow_dispa...
[ ".github/workflows/main.yml", ".rubocop.yml", ".yardopts", "lib/generators/pundit/install/install_generator.rb", "lib/generators/pundit/install/templates/application_policy.rb.tt", "lib/generators/pundit/policy/policy_generator.rb", "lib/generators/pundit/policy/templates/policy.rb.tt", "lib/generator...
[]
diff --git a/lib/generators/test_unit/policy_generator.rb b/lib/generators/test_unit/policy_generator.rb index 89c375fa..cd0175a0 100644 --- a/lib/generators/test_unit/policy_generator.rb +++ b/lib/generators/test_unit/policy_generator.rb @@ -1,12 +1,14 @@ # frozen_string_literal: true +# @private module TestUnit +...
true
varvet/pundit
827
issue_to_patch
Release v2.4.0
## Improve `NotAuthorizedError` message to include policy class (#812) Default error message changed from: > not allowed to destroy? this Comment To include the policy class: > not allowed to Project::Admin::CommentPolicy#destroy? this Comment ## Improve `NotAuthorizedError` when record is a class Before:...
6eaaca62d123dc4c97ce451310478b9d62b2475e
6eaf8775c12e35bd7b03357835808946d42b89b2
diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f6ed6da..b16cddbc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,15 @@ ## Unreleased +## 2.4.0 (2024-08-26) + +## Changed + - Improve the `NotAuthorizedError` message to include the policy class. -Furthermore, in the case where the record passed is a class ...
[ "CHANGELOG.md", "lib/pundit/version.rb" ]
[]
true
varvet/pundit
826
issue_to_patch
Update gem release template (closes #805)
89924301e529389843327295f74eb4caa805e3b2
d1dcb2f20e6f19298c3aecd718cbfec92e79955f
diff --git a/.github/PULL_REQUEST_TEMPLATE/gem_release_template.md b/.github/PULL_REQUEST_TEMPLATE/gem_release_template.md index 15acbe92..9d1f051d 100644 --- a/.github/PULL_REQUEST_TEMPLATE/gem_release_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/gem_release_template.md @@ -1,8 +1,8 @@ ## To do -- [ ] Commit cha...
[ ".github/PULL_REQUEST_TEMPLATE/gem_release_template.md", ".github/workflows/push_gem.yml" ]
[]
true
varvet/pundit
820
issue_to_patch
Support :focus for rspec permissions blocks
I thought this issue would be nice to have so I took a stab at it: https://github.com/varvet/pundit/issues/816 Please let me know if there's anything missing!
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/CHANGELOG.md b/CHANGELOG.md index ec4bb4c9..5f6ed6da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Improve the `NotAuthorizedError` message to include the policy class. Furthermore, in the case where the record passed is a class instead of an instance, the class name is given. (#812) - ...
[ "CHANGELOG.md", "README.md", "lib/pundit/rspec.rb", "spec/dsl_spec.rb" ]
[ { "comment": "Please add the PR number (#820) here 🙂 ", "path": "CHANGELOG.md", "hunk": "@@ -4,6 +4,7 @@\n \n - Improve the `NotAuthorizedError` message to include the policy class.\n Furthermore, in the case where the record passed is a class instead of an instance, the class name is given. (#812)\n+-...
diff --git a/spec/dsl_spec.rb b/spec/dsl_spec.rb new file mode 100644 index 00000000..97c936a2 --- /dev/null +++ b/spec/dsl_spec.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +require "spec_helper" + +RSpec.describe "Pundit RSpec DSL" do + let(:fake_rspec) do + double = class_double(RSpec::ExampleGroups) + ...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
Please add the PR number (#820) here 🙂
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/CHANGELOG.md b/CHANGELOG.md index ec4bb4c9..5f6ed6da 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Improve the `NotAuthorizedError` message to include the policy class. Furthermore, in the case where the record passed is a class instead of an instance, the class name is given. (#812) - ...
[ "CHANGELOG.md" ]
[ { "comment": "Please add the PR number (#820) here 🙂 ", "path": "CHANGELOG.md", "hunk": "@@ -4,6 +4,7 @@\n \n - Improve the `NotAuthorizedError` message to include the policy class.\n Furthermore, in the case where the record passed is a class instead of an instance, the class name is given. (#812)\n+-...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
I know the `rspec` section is light on headings, so please add a heading to help visually separate the information about `:focus` from the custom descriptions-section above. I intend to add a heading for the "custom description"-section in a separate PR 🙂
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/README.md b/README.md index 10cfadb0..a1b59868 100644 --- a/README.md +++ b/README.md @@ -821,6 +821,14 @@ PostPolicy is expected to permit user with role admin to access record with ID 130 ``` +### Focus Support + +If your RSpec config has `filter_run_when_matching :focus`, you may tag the `permis...
[ "README.md" ]
[ { "comment": "I know the `rspec` section is light on headings, so please add a heading to help visually separate the information about `:focus` from the custom descriptions-section above.\r\n\r\nI intend to add a heading for the \"custom description\"-section in a separate PR 🙂 ", "path": "README.md", ...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
I'm not keen on modifying global state in a `before`-filter. It'll leak to other tests, and we want every test to be isolated from others. Might I suggest creating a double that mimics rspec behaviour here instead? ```ruby let(:fake_rspec) do double = class_double(RSpec::ExampleGroups) double.extend(::Pund...
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/spec/dsl_spec.rb b/spec/dsl_spec.rb new file mode 100644 index 00000000..97c936a2 --- /dev/null +++ b/spec/dsl_spec.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +require "spec_helper" + +RSpec.describe "Pundit RSpec DSL" do + let(:fake_rspec) do + double = class_double(RSpec::ExampleGroups) + ...
[ "spec/dsl_spec.rb" ]
[ { "comment": "I'm not keen on modifying global state in a `before`-filter. It'll leak to other tests, and we want every test to be isolated from others.\r\n\r\nMight I suggest creating a double that mimics rspec behaviour here instead?\r\n\r\n```ruby\r\nlet(:fake_rspec) do\r\n double = class_double(RSpec::Exam...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
Careful here, `hash_including` is lenient when it comes to _additional_ content. If the implementation always added `focus: true` then this test would still pass, and so would the other one. Instead of `hash_including` we want `match` here instead.
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/spec/dsl_spec.rb b/spec/dsl_spec.rb new file mode 100644 index 00000000..97c936a2 --- /dev/null +++ b/spec/dsl_spec.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +require "spec_helper" + +RSpec.describe "Pundit RSpec DSL" do + let(:fake_rspec) do + double = class_double(RSpec::ExampleGroups) + ...
[ "spec/dsl_spec.rb" ]
[ { "comment": "Careful here, `hash_including` is lenient when it comes to _additional_ content. If the implementation always added `focus: true` then this test would still pass, and so would the other one.\r\n\r\nInstead of `hash_including` we want `match` here instead.", "path": "spec/dsl_spec.rb", "hun...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
Test failures probably already caught this, but `%i` shouldn't have a comma `,` nor colon `:` 🙂
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/spec/dsl_spec.rb b/spec/dsl_spec.rb new file mode 100644 index 00000000..97c936a2 --- /dev/null +++ b/spec/dsl_spec.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +require "spec_helper" + +RSpec.describe "Pundit RSpec DSL" do + let(:fake_rspec) do + double = class_double(RSpec::ExampleGroups) + ...
[ "spec/dsl_spec.rb" ]
[ { "comment": "Test failures probably already caught this, but `%i` shouldn't have a comma `,` nor colon `:` 🙂 ", "path": "spec/dsl_spec.rb", "hunk": "@@ -0,0 +1,29 @@\n+require \"spec_helper\"\n+\n+RSpec.describe \"Pundit RSpec DSL\" do\n+ before do\n+ RSpec.configure do |config|\n+ config.inc...
true
varvet/pundit
820
comment_to_fix
Support :focus for rspec permissions blocks
Thanks for making the changes, it's looking good! I have but one small nitpick left, which I myself caused by not being clear enough in my previous comment. Sorry! I believe you should: * remove line 7 (`allow(double).to receive(:describe)`) * remove line 13 and 24 (`expect { ... }.to yield_control` }) * rebas...
85679c99b2dae09ae8e1d9e4c4dcda0c5a29a3f2
869d0661dca639f48a06ba3697679aba4a71939b
diff --git a/spec/dsl_spec.rb b/spec/dsl_spec.rb new file mode 100644 index 00000000..97c936a2 --- /dev/null +++ b/spec/dsl_spec.rb @@ -0,0 +1,30 @@ +# frozen_string_literal: true + +require "spec_helper" + +RSpec.describe "Pundit RSpec DSL" do + let(:fake_rspec) do + double = class_double(RSpec::ExampleGroups) + ...
[ "spec/dsl_spec.rb" ]
[ { "comment": "Thanks for making the changes, it's looking good!\r\n\r\nI have but one small nitpick left, which I myself caused by not being clear enough in my previous comment. Sorry!\r\n\r\nI believe you should:\r\n* remove line 7 (`allow(double).to receive(:describe)`)\r\n* remove line 13 and 24 (`expect { ....
true
varvet/pundit
824
issue_to_patch
Add additional considerations to feature request template
## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have added relevant tests. - [x] I have adjusted relevant documentation. - [x] I have made sure the individual commits are meaningful. - [x] I have added relevant lines to the CHANGELOG. PS: Thank yo...
5a202e2235c850bc548cda3ac77eaea115c55d64
2a5273fd9947f29dabb421c8214a22f462442310
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 2fcc205f..20197bab 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -2,15 +2,16 @@ name: Feature request about: Suggest an idea title: '' -labels: '' +labe...
[ ".github/ISSUE_TEMPLATE/feature_request.md" ]
[]
true
varvet/pundit
823
issue_to_patch
Add issue templates
2e3f7366938cdccaa45ebd41c0d610f8ef38cb32
aa90103e04b6a37f0108020ad17b0c481c4ca337
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..c2270f4c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,20 @@ +--- +name: Bug report +about: Create a bug report to report a problem +title: '' +labels: problem +assignees: ...
[ ".github/ISSUE_TEMPLATE/bug_report.md", ".github/ISSUE_TEMPLATE/feature_request.md" ]
[]
true
varvet/pundit
822
issue_to_patch
Update README around rspec helper description change
## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have added relevant tests. - [x] I have adjusted relevant documentation. - [x] I have made sure the individual commits are meaningful. - [x] I have added relevant lines to the CHANGELOG. PS: Thank yo...
4e84af6a44260816eee240299456912e570ba8de
4eb0ba53de1dbbfb1231cd36d4b9b71e4372ed8c
diff --git a/CHANGELOG.md b/CHANGELOG.md index 18ad81d0..ec4bb4c9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ - Improve the `NotAuthorizedError` message to include the policy class. Furthermore, in the case where the record passed is a class instead of an instance, the class name is given. (#812) +...
[ "CHANGELOG.md", "CODE_OF_CONDUCT.md", "README.md" ]
[]
true
varvet/pundit
815
issue_to_patch
Fix minor typos
``` codespell **/*.rb **/*.md -L initalize,unvalid ```
e5f88356c0ad366100b35ae2e3ae7327f8fb9002
193cd6e35ab1188487968cb279198b14b01091a8
[ "spec/authorization_spec.rb", "spec/spec_helper.rb" ]
[]
diff --git a/spec/authorization_spec.rb b/spec/authorization_spec.rb index 4ff6c19c..8bfa3fcb 100644 --- a/spec/authorization_spec.rb +++ b/spec/authorization_spec.rb @@ -169,7 +169,7 @@ def to_params(*args, **kwargs, &block) expect(controller.policy_scope(Post)).to eq :published end - it "allows polic...
true
varvet/pundit
812
issue_to_patch
Add the policy class to the `NotAuthorizedError` message
This PR fixes #681 and #647.
fecc480bc1292c5efee96507e4ec0b6308ae4edb
d84f5f0a11ad651b4c4427f89401abcae4ff2bef
diff --git a/CHANGELOG.md b/CHANGELOG.md index 96530278..18ad81d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +- Improve the `NotAuthorizedError` message to include the policy class. +Furthermore, in the case where the record passed is a class instead of an instance, the class name i...
[ "CHANGELOG.md", "CONTRIBUTING.md", "README.md", "lib/pundit.rb", "spec/pundit_spec.rb" ]
[ { "comment": "Hi! I've thought about this some more and I've got a change that's worth making.\r\n\r\nThe reasons for the change are:\r\n1. `record.to_s` works better for anonymous classes, and it's what we use in PolicyFinder so it's somewhat battle-tested.\r\n2. If there's an explicit message we should not ca...
diff --git a/spec/pundit_spec.rb b/spec/pundit_spec.rb index fadddc85..bcec8633 100644 --- a/spec/pundit_spec.rb +++ b/spec/pundit_spec.rb @@ -57,11 +57,11 @@ expect { Pundit.authorize(user, article_tag, :destroy?) }.to raise_error(Pundit::NotAuthorizedError) end - it "raises an error with a query and ...
true
varvet/pundit
812
comment_to_fix
Add the policy class to the `NotAuthorizedError` message
Hi! I've thought about this some more and I've got a change that's worth making. The reasons for the change are: 1. `record.to_s` works better for anonymous classes, and it's what we use in PolicyFinder so it's somewhat battle-tested. 2. If there's an explicit message we should not calculate a record name. ```s...
fecc480bc1292c5efee96507e4ec0b6308ae4edb
d84f5f0a11ad651b4c4427f89401abcae4ff2bef
diff --git a/lib/pundit.rb b/lib/pundit.rb index 27dd032a..a03f4d3a 100644 --- a/lib/pundit.rb +++ b/lib/pundit.rb @@ -36,7 +36,10 @@ def initialize(options = {}) @record = options[:record] @policy = options[:policy] - message = options.fetch(:message) { "not allowed to #{query} this #{record...
[ "lib/pundit.rb" ]
[ { "comment": "Hi! I've thought about this some more and I've got a change that's worth making.\r\n\r\nThe reasons for the change are:\r\n1. `record.to_s` works better for anonymous classes, and it's what we use in PolicyFinder so it's somewhat battle-tested.\r\n2. If there's an explicit message we should not ca...
true
varvet/pundit
812
comment_to_fix
Add the policy class to the `NotAuthorizedError` message
Please add the issue number here :) ```suggestion - Improve the `NotAuthorizedError` message to include the policy class. (#812) ```
fecc480bc1292c5efee96507e4ec0b6308ae4edb
d84f5f0a11ad651b4c4427f89401abcae4ff2bef
diff --git a/CHANGELOG.md b/CHANGELOG.md index 96530278..18ad81d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +- Improve the `NotAuthorizedError` message to include the policy class. +Furthermore, in the case where the record passed is a class instead of an instance, the class name i...
[ "CHANGELOG.md" ]
[ { "comment": "Please add the issue number here :)\r\n\r\n```suggestion\r\n- Improve the `NotAuthorizedError` message to include the policy class. (#812)\r\n```", "path": "CHANGELOG.md", "hunk": "@@ -2,6 +2,9 @@\n \n ## Unreleased\n \n+- Improve the `NotAuthorizedError` message to include the policy clas...
true
varvet/pundit
814
issue_to_patch
Update README.md
Replace soft deprecated [`redirect_back`](https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_back) with [`redirect_back_or_to`](https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_back_or_to) in README instructions.
e888328458fa3cba9016cc41616197fe0fb93b1c
20e0fe5d8ee883a77213054c69fb0ba7ee199b07
diff --git a/README.md b/README.md index a6807fd7..daa30138 100644 --- a/README.md +++ b/README.md @@ -510,7 +510,7 @@ class ApplicationController < ActionController::Base def user_not_authorized flash[:alert] = "You are not authorized to perform this action." - redirect_back(fallback_location: root_path) ...
[ "README.md" ]
[]
true
varvet/pundit
813
issue_to_patch
Workaround JRuby 9.4 and jruby-head are failing (only on CI)
I'll try to figure out _why_ this is needed, but in the meantime I'd like to be able to merge pull requests.
7e59b98a72850a02c0a10ec17fff425cff18d31a
6551fed4f92144df65338f4f96abb898f27b79e6
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f35bc3ec..5ed27808 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -48,7 +48,12 @@ jobs: with: rubygems: latest ruby-version: ${{ matrix.ruby-version }} - bundler-cache: true + b...
[ ".github/workflows/main.yml" ]
[]
true
varvet/pundit
776
issue_to_patch
Do not use NotImplementedError This error is not appropriate for method not implemented. https://ruby-doc.org/3.2.2/NotImplementedError.html > Raised when a feature is not implemented on the current platform. For example, methods depending on the `fsync` or `fork` system calls may raise this exception if the und...
Do not use NotImplementedError
Instead use `NoMethodError` as to indicate that the method should be defined in the class Closes #775 ## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have added relevant tests. - [x] I have adjusted relevant documentation. - [x] I have made sure...
af78b4405f07da879f7f8939303d9d544eb2bf2f
6eec6c6a9de79e89af99b957b23b683c225fffe2
diff --git a/CHANGELOG.md b/CHANGELOG.md index 84b1a6a4..2d2195d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -Nothing. +- Policy generator uses `NoMethodError` to indicate `#resolve` is not implemented (#776) ## 2.3.1 (2023-07-17) diff --git a/lib/generators/pundit/install/temp...
[ "CHANGELOG.md", "lib/generators/pundit/install/templates/application_policy.rb", "spec/generators_spec.rb" ]
[]
diff --git a/spec/generators_spec.rb b/spec/generators_spec.rb index 5f158776..e157e391 100644 --- a/spec/generators_spec.rb +++ b/spec/generators_spec.rb @@ -35,7 +35,7 @@ describe "#resolve" do it "raises a descriptive error" do scope = WidgetPolicy::Scope.new(double("User"), double("User.a...
true
varvet/pundit
809
issue_to_patch
Bump actions/checkout
GitHub is [planning to upgrade to Node 20](https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/). Versions prior to actions/checkout v3 use an outdated version of node, so we will upgrade to actions/checkout v4, where [Node 20 is the default](https://github.com/actions/checkout...
f55c44265e24ad09662cdcf4d5ba09a8949025ff
809408793714076be092065c00fbd8f2451bab01
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 89fb192a..f35bc3ec 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -42,7 +42,7 @@ jobs: allow-failure: true steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set...
[ ".github/workflows/main.yml" ]
[]
true
varvet/pundit
697
issue_to_patch
authorize is returning array with namespace, not just record > What did you do? From a Rails controller action that includes Pundit, `project = authorize([:admin, Project.first])` as is done in the Pundit README. > What did you expect to happen? After Pundit uses `Admin::ProjectPolicy` to authorize the curre...
Strip namespace when using `policy_class`
Closes #689 Closes #694 Closes #666 Using `policy_class` and namespacing are two different ways of doing the same thing (specifying which policy to use). When both are given, we ignore the namespacing and rely on policy class since it's more specific — when we do so, we need to strip the namespace when passing the...
478b7b11c43b7267e92612f90ac16f4c7439ac9c
ebd8de90e18f6836041ed78d53654c770b1bebc6
diff --git a/CHANGELOG.md b/CHANGELOG.md index 213ac525..d2af09dd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Fixed + +- Using `policy_class` and a namespaced record now passes only the record when instantiating the policy. (#697, #689, #694, #666) + ## 2.1.1 (2021-08-13) F...
[ "CHANGELOG.md", "lib/pundit.rb", "spec/pundit_spec.rb", "spec/spec_helper.rb" ]
[ { "comment": "This appears to be a breaking change, and I'm curious whether or not that was intentional. Our code uses the `authorize(record)` method below which [used to find the policy_class with `policy`](https://github.com/varvet/pundit/pull/697/files#diff-2acc48fe8302d7198f5a4aa4aaa8b4f0502d185e186a0992832...
diff --git a/spec/pundit_spec.rb b/spec/pundit_spec.rb index a380c1ef..6b8fb190 100644 --- a/spec/pundit_spec.rb +++ b/spec/pundit_spec.rb @@ -49,6 +49,11 @@ expect(Pundit.authorize(user, post, :create?, policy_class: PublicationPolicy)).to be_truthy end + it "can be given a different policy class usin...
true
varvet/pundit
788
issue_to_patch
Prevent usage of `only:` filter for limiting `after_action` filter
Starting with Rails 7.1 a new security check has been added; it checks whether referenced actions do exist for a given filter. (https://guides.rubyonrails.org/configuring.html#config-action-controller-raise-on-missing-callback-actions) Because we cannot guaranty that all controller have a index method, the given exa...
0ab259e3df99789b511c1e91a356f1f6154bb008
d65edca210e2f13c92f5d2f8344122a365d4c786
diff --git a/README.md b/README.md index 85416dc3..a6807fd7 100644 --- a/README.md +++ b/README.md @@ -360,8 +360,15 @@ authorize individual instances. ``` ruby class ApplicationController < ActionController::Base include Pundit::Authorization - after_action :verify_authorized, except: :index - after_action :ver...
[ "README.md" ]
[]
true
varvet/pundit
806
issue_to_patch
Enable custom description for permit matcher We're using RSpec output to document the permissions of all our resources. The default description is not what we want since it inspects the user and that adds noise to the output for no value. I understand that it's probably not reasonable to change the default descript...
Add customizable permit matcher description
Updates #760 by addressing feedback provided on the original PR. Closes #759
18994ac508d2853fbdda1fbfc5ec358827638193
86c72511c21cdf9b8b97bb2a314b3d8f97248aa4
diff --git a/README.md b/README.md index 29cc0bc9..85416dc3 100644 --- a/README.md +++ b/README.md @@ -783,6 +783,37 @@ describe PostPolicy do end ``` +You can customize the description used for the `permit` matcher: + +``` ruby +Pundit::RSpec::Matchers.description = + "permit the user" +``` + +given the spec + +`...
[ "README.md", "lib/pundit/rspec.rb", "spec/policies/post_policy_spec.rb" ]
[]
diff --git a/spec/policies/post_policy_spec.rb b/spec/policies/post_policy_spec.rb index 54e301e0..912fe74b 100644 --- a/spec/policies/post_policy_spec.rb +++ b/spec/policies/post_policy_spec.rb @@ -18,5 +18,32 @@ should permit(user, other_post) end.to raise_error(RSpec::Expectations::ExpectationNotMetE...
true
varvet/pundit
804
issue_to_patch
Release v2.3.2
- Add trusted publishing (rubygems) - Bump to v2.3.2 ## To do - [x] Commit changes: - [x] Bump `Pundit::VERSION` in `lib/pundit/version.rb`. - [x] Update `CHANGELOG.md`. - [ ] Run `rake release`. - [x] Open pull request 🚀 - [ ] Make an announcement in [Pundit discussions](https://github.com/varvet/pundit/discuss...
176cabb34609f25aa72ca8c3771ddbb1fa646bb2
d033604522220446af61515edef2839d42f63af5
diff --git a/.github/workflows/push_gem.yml b/.github/workflows/push_gem.yml new file mode 100644 index 00000000..67745e0c --- /dev/null +++ b/.github/workflows/push_gem.yml @@ -0,0 +1,33 @@ +name: Push Gem + +on: + workflow_dispatch: + +permissions: + contents: read + +jobs: + push: + if: github.repository == 'v...
[ ".github/workflows/push_gem.yml", "CHANGELOG.md", "lib/pundit/version.rb" ]
[]
true
varvet/pundit
797
issue_to_patch
First pass of Pundit::Context
**This should be backwards-compatible**, so let me know if this breaks _anything_. See https://github.com/varvet/pundit/discussions/774 initial draft/rationale. ## Caution * We're introducing a new method [`Pundit::Authorization#pundit`](https://github.com/varvet/pundit/blob/d7251544dc552b7fe9f95933882279ae37e56...
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit.rb b/lib/pundit.rb index 5eab334f..27dd032a 100644 --- a/lib/pundit.rb +++ b/lib/pundit.rb @@ -8,6 +8,9 @@ require "active_support/core_ext/module/introspection" require "active_support/dependencies/autoload" require "pundit/authorization" +require "pundit/context" +require "pundit/cache_stor...
[ "lib/pundit.rb", "lib/pundit/authorization.rb", "lib/pundit/cache_store/legacy_store.rb", "lib/pundit/cache_store/null_store.rb", "lib/pundit/context.rb", "spec/authorization_spec.rb", "spec/pundit_spec.rb", "spec/spec_helper.rb" ]
[ { "comment": "Not using this yet. Let's remove it.", "path": "lib/pundit/context.rb", "hunk": "@@ -0,0 +1,127 @@\n+# frozen_string_literal: true\n+\n+module Pundit\n+ class Context\n+ def initialize(user:, policy_cache: {}, scope_cache: {})\n+ @user = user\n+\n+ @policy_cache = policy_cach...
diff --git a/spec/authorization_spec.rb b/spec/authorization_spec.rb index 2995bfdb..4ff6c19c 100644 --- a/spec/authorization_spec.rb +++ b/spec/authorization_spec.rb @@ -3,10 +3,13 @@ require "spec_helper" describe Pundit::Authorization do - let(:controller) { Controller.new(user, "update", {}) } + def to_params...
true
varvet/pundit
797
comment_to_fix
First pass of Pundit::Context
Not using this yet. Let's remove it.
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit/context.rb b/lib/pundit/context.rb new file mode 100644 index 00000000..a5f86716 --- /dev/null +++ b/lib/pundit/context.rb @@ -0,0 +1,127 @@ +# frozen_string_literal: true + +module Pundit + class Context + def initialize(user:, policy_cache: CacheStore::NullStore.instance) + @user = us...
[ "lib/pundit/context.rb" ]
[ { "comment": "Not using this yet. Let's remove it.", "path": "lib/pundit/context.rb", "hunk": "@@ -0,0 +1,127 @@\n+# frozen_string_literal: true\n+\n+module Pundit\n+ class Context\n+ def initialize(user:, policy_cache: {}, scope_cache: {})\n+ @user = user\n+\n+ @policy_cache = policy_cach...
true
varvet/pundit
797
comment_to_fix
First pass of Pundit::Context
These are technically only here for backwards-compatibility. We _could_ create the cache in here, but having it like this allows us to keep the methods in `Pundit::Authorization`.
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit/context.rb b/lib/pundit/context.rb new file mode 100644 index 00000000..a5f86716 --- /dev/null +++ b/lib/pundit/context.rb @@ -0,0 +1,127 @@ +# frozen_string_literal: true + +module Pundit + class Context + def initialize(user:, policy_cache: CacheStore::NullStore.instance) + @user = us...
[ "lib/pundit/context.rb" ]
[ { "comment": "These are technically only here for backwards-compatibility. We _could_ create the cache in here, but having it like this allows us to keep the methods in `Pundit::Authorization`.", "path": "lib/pundit/context.rb", "hunk": "@@ -0,0 +1,127 @@\n+# frozen_string_literal: true\n+\n+module Pund...
true
varvet/pundit
797
comment_to_fix
First pass of Pundit::Context
Super minor and I can see the documentation has been like this for a while, so it's likely this is just the project's preference. As an infrequent reader of a library I find it comforting to see why _this specific_ bang (`!`) method is dangerous really clearly. Definitely take it or leave it. ```suggestion # Re...
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit/context.rb b/lib/pundit/context.rb new file mode 100644 index 00000000..a5f86716 --- /dev/null +++ b/lib/pundit/context.rb @@ -0,0 +1,127 @@ +# frozen_string_literal: true + +module Pundit + class Context + def initialize(user:, policy_cache: CacheStore::NullStore.instance) + @user = us...
[ "lib/pundit/context.rb" ]
[ { "comment": "Super minor and I can see the documentation has been like this for a while, so it's likely this is just the project's preference. As an infrequent reader of a library I find it comforting to see why _this specific_ bang (`!`) method is dangerous really clearly. Definitely take it or leave it.\r\n\...
true
varvet/pundit
797
comment_to_fix
First pass of Pundit::Context
Super minor, take it or leave it -- same as previous comment. ```suggestion # Retrieves the policy for the given record. Raises if not found. ```
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit/context.rb b/lib/pundit/context.rb new file mode 100644 index 00000000..a5f86716 --- /dev/null +++ b/lib/pundit/context.rb @@ -0,0 +1,127 @@ +# frozen_string_literal: true + +module Pundit + class Context + def initialize(user:, policy_cache: CacheStore::NullStore.instance) + @user = us...
[ "lib/pundit/context.rb" ]
[ { "comment": "Super minor, take it or leave it -- same as previous comment.\r\n\r\n```suggestion\r\n # Retrieves the policy for the given record. Raises if not found.\r\n```", "path": "lib/pundit/context.rb", "hunk": "@@ -0,0 +1,127 @@\n+# frozen_string_literal: true\n+\n+module Pundit\n+ class Cont...
true
varvet/pundit
797
comment_to_fix
First pass of Pundit::Context
In my case, I think I'd also like to add the `policy_class` case to the cache and to prefer retrieving from the cache when using `policy`. [PR coming your way ](https://github.com/varvet/pundit/pull/801/files)to show what I'm talking about. The question may come down to if you agree and how pundit wants to view what...
aabb3441817c23f3ae41ed1efd468411680d0f53
6f04482534f5d0cf093f2f7dd8d0ce185d297508
diff --git a/lib/pundit/context.rb b/lib/pundit/context.rb new file mode 100644 index 00000000..a5f86716 --- /dev/null +++ b/lib/pundit/context.rb @@ -0,0 +1,127 @@ +# frozen_string_literal: true + +module Pundit + class Context + def initialize(user:, policy_cache: CacheStore::NullStore.instance) + @user = us...
[ "lib/pundit/context.rb" ]
[ { "comment": "In my case, I think I'd also like to add the `policy_class` case to the cache and to prefer retrieving from the cache when using `policy`. [PR coming your way ](https://github.com/varvet/pundit/pull/801/files)to show what I'm talking about.\r\n\r\nThe question may come down to if you agree and how...
true
varvet/pundit
802
issue_to_patch
Fix broken sponsor logo in README
55f64cbe09a9da2f21988021c6a1d5848d312059
dfceb9145c2db549c71c7e93eba1ca2043fc9f9f
diff --git a/README.md b/README.md index 65fe185a..29cc0bc9 100644 --- a/README.md +++ b/README.md @@ -9,16 +9,14 @@ Pundit provides a set of helpers which guide you in leveraging regular Ruby classes and object oriented design patterns to build a straightforward, robust, and scalable authorization system. -Links: ...
[ "README.md" ]
[]
true
varvet/pundit
796
issue_to_patch
Remove support for Ruby 3.0
We can't make a new release with this just yet, because we still support Ruby 3.0 for another 30 days: https://www.ruby-lang.org/en/downloads/branches/ ## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [x] I have added relevant tests. - [x] I have adjusted ...
f13018776aa3f6e39223f8deb07a43df28c736a6
f276b6a4f1180310e88b3e7c4ceda8ccf905876b
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6589890b..89fb192a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -28,7 +28,6 @@ jobs: fail-fast: false matrix: ruby-version: - - '3.0' - '3.1' - '3.2' ...
[ ".github/workflows/main.yml", ".rubocop.yml", "CHANGELOG.md", "lib/pundit/policy_finder.rb" ]
[]
true
varvet/pundit
795
issue_to_patch
Run for 3.2 and 3.3 too. 3.0 is soon EOL
9dd051102bbce8899a2f5b059cd9692052c3bf8b
14cf7697e6aa16aefab3d9a77ebd081e0c00ea0a
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index afc481a2..6589890b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,6 +30,8 @@ jobs: ruby-version: - '3.0' - '3.1' + - '3.2' + - '3.3' - 'jruby-9.3.10' # ...
[ ".github/workflows/main.yml" ]
[]
true
varvet/pundit
686
issue_to_patch
New release? Latest release was August 2019, and since then there have been lots of commits in `master`. Would the team consider releasing a new version with all the new fixes/features?
Release 2.1.1
Friday 13th-release! Careful! The bugfix in (#626) could break existing code. If you rely on the return value for `authorize` and namespaced policies you might need to do some changes. Closes #656.
28236693701fa989872a3dd0e84df55020e7944d
0b5c0824c1d35709f992a5fc73abbacddc7bcc45
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3afaf307..213ac525 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,14 @@ ## Unreleased +## 2.1.1 (2021-08-13) + +Friday 13th-release! + +Careful! The bugfix below (#626) could break existing code. If you rely on the +return value for `authorize` and namespaced...
[ "CHANGELOG.md", "lib/pundit/version.rb" ]
[]
true
varvet/pundit
792
issue_to_patch
Qualify the `Scope` class name
I'd like to propose this small change to the generator, and the corresponding examples in the README. However, I'm very new to Pundit so I'm seeking input from others with more experience. When using the generator, it results in a `Scope < Scope` inheritance, equivalent to `Scope < ApplicationPolicy::Scope`. This...
173d85af249ae1ab133c514826f028076714cbf2
98dbab897bb0074c0fa358a25f6ec4d0d73e4bb8
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d2195d5..b509deb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +- Update `ApplicationPolicy`` generator to qualify the `Scope` class name (#792) + - Policy generator uses `NoMethodError` to indicate `#resolve` is not implemented (#776) ...
[ "CHANGELOG.md", "README.md", "lib/generators/pundit/policy/templates/policy.rb" ]
[ { "comment": "(I'm assuming v2.4.0 will be the next release?)", "path": "lib/generators/pundit/policy/templates/policy.rb", "hunk": "@@ -1,6 +1,12 @@\n <% module_namespacing do -%>\n class <%= class_name %>Policy < ApplicationPolicy\n- class Scope < Scope\n+ # NOTE: Prior to Pundit v2.4.0, the inherit...
true
varvet/pundit
792
comment_to_fix
Qualify the `Scope` class name
(I'm assuming v2.4.0 will be the next release?)
173d85af249ae1ab133c514826f028076714cbf2
98dbab897bb0074c0fa358a25f6ec4d0d73e4bb8
diff --git a/lib/generators/pundit/policy/templates/policy.rb b/lib/generators/pundit/policy/templates/policy.rb index 6798550b..a2102cb0 100644 --- a/lib/generators/pundit/policy/templates/policy.rb +++ b/lib/generators/pundit/policy/templates/policy.rb @@ -1,6 +1,12 @@ <% module_namespacing do -%> class <%= class_n...
[ "lib/generators/pundit/policy/templates/policy.rb" ]
[ { "comment": "(I'm assuming v2.4.0 will be the next release?)", "path": "lib/generators/pundit/policy/templates/policy.rb", "hunk": "@@ -1,6 +1,12 @@\n <% module_namespacing do -%>\n class <%= class_name %>Policy < ApplicationPolicy\n- class Scope < Scope\n+ # NOTE: Prior to Pundit v2.4.0, the inherit...
true
varvet/pundit
792
comment_to_fix
Qualify the `Scope` class name
Rather than adding a lengthy explanation as a comment, I thought it better to link to your illustration. If you'd prefer not to have a link to your gist, then maybe there could be a page in the repo?
173d85af249ae1ab133c514826f028076714cbf2
98dbab897bb0074c0fa358a25f6ec4d0d73e4bb8
diff --git a/lib/generators/pundit/policy/templates/policy.rb b/lib/generators/pundit/policy/templates/policy.rb index 6798550b..a2102cb0 100644 --- a/lib/generators/pundit/policy/templates/policy.rb +++ b/lib/generators/pundit/policy/templates/policy.rb @@ -1,6 +1,12 @@ <% module_namespacing do -%> class <%= class_n...
[ "lib/generators/pundit/policy/templates/policy.rb" ]
[ { "comment": "Rather than adding a lengthy explanation as a comment, I thought it better to link to your illustration. If you'd prefer not to have a link to your gist, then maybe there could be a page in the repo?", "path": "lib/generators/pundit/policy/templates/policy.rb", "hunk": "@@ -1,6 +1,12 @@\n ...
true
varvet/pundit
793
issue_to_patch
Fix CodeClimate badge
Use snippet from https://codeclimate.com/github/varvet/pundit/badges#maintainability-markdown [ci skip]
4d8cdf1c10058c12f2c175f30b408f5d5532a00b
b65c5a2bf61ced5a0ca27f38527f4757200947fb
diff --git a/README.md b/README.md index 36d74d13..790962fa 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # Pundit [![Main](https://github.com/varvet/pundit/actions/workflows/main.yml/badge.svg)](https://github.com/varvet/pundit/actions/workflows/main.yml) -[![Code Climate](https://codeclimate.com/github/v...
[ "README.md" ]
[]
true
varvet/pundit
786
issue_to_patch
Adjust GH actions workflow
I recently made a change to allow for running the workflow manually on `main`, which I did in order to double-check if a certain failure was due to a PR or if it's also failing on main. I've since disabled bypassing branch protections on `main`, so now there's a PR for this change. And finally, I noticed that if ...
482c19e00dc4c24a014bc5c83f9cb9140fa3b071
42422b57a8d98af55102cf19b8d4447f8b198d36
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 74a9c7f2..afc481a2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,12 +25,12 @@ jobs: runs-on: ubuntu-latest continue-on-error: ${{ matrix.allow-failure || false }} strategy: - fail-fast: true ...
[ ".github/workflows/main.yml", "Gemfile" ]
[]
true
varvet/pundit
784
issue_to_patch
Use multiple PR templates
See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository They were in the wrong location for multiple.
3514b3820f6ac7f01c1b73100e5c7d2848300c93
37113a1c7b63062c0bb152a21056669a619742ac
diff --git a/.github/gem_release_template.md b/.github/PULL_REQUEST_TEMPLATE/gem_release_template.md similarity index 100% rename from .github/gem_release_template.md rename to .github/PULL_REQUEST_TEMPLATE/gem_release_template.md diff --git a/.github/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_reques...
[ ".github/PULL_REQUEST_TEMPLATE/gem_release_template.md", ".github/PULL_REQUEST_TEMPLATE/pull_request_template.md" ]
[]
true
varvet/pundit
782
issue_to_patch
Use GH Actions for CI
No particular reason, although I do find GH actions a bit easier to work with for parallel/matrix runs like this. I am not fond of the bash script syntax. ## To do - [x] I have read the [contributing guidelines](https://github.com/varvet/pundit/contribute). - [ ] ~I have added relevant tests.~ - [ ] ~I have adj...
4f4655e4ae1cfe8a529e18a3981bfe8f299878c8
ec401bca4219e4a845bd945aff0a86d257f30435
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 00000000..fcee1e4b --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,105 @@ +name: Main + +on: + push: + branches: [ "main" ] + pull_request: + branches: [ "main" ] + +permissions: + contents: read + +env: +...
[ ".github/workflows/main.yml", ".rubocop.yml", ".travis.yml", "CONTRIBUTING.md", "Gemfile", "README.md", "pundit.gemspec", "spec/spec_helper.rb" ]
[]
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 192146f2..26e41b53 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,8 +1,10 @@ # frozen_string_literal: true -require "simplecov" -SimpleCov.start do - add_filter "/spec/" +if ENV["COVERAGE"] + require "simplecov" + SimpleCov.start do + ...
true
vectordotdev/vector
25,604
issue_to_patch
fix(top): handle UI events separately to prevent UI freeze
## Summary Transition to gRPC for API introduced a higher number of events, causing high load in state updater when many components are present, blocking the UI events from being sent to the channel (because it gets full fast). This introduces a separate channel for UI events to ensure they get a chance to be processe...
bcaebb2922f860e4ac55368d06daa8551837331c
7766d59bfd7ea4c39969bb59db5fd8af50588c24
diff --git a/changelog.d/25604_top_freeze.fix.md b/changelog.d/25604_top_freeze.fix.md new file mode 100644 index 0000000000000..1caed4663cf35 --- /dev/null +++ b/changelog.d/25604_top_freeze.fix.md @@ -0,0 +1,3 @@ +Fixed `vector top` freezes when using a high number of components. + +authors: esensar Quad9DNS diff --g...
[ "changelog.d/25604_top_freeze.fix.md", "lib/vector-top/src/dashboard.rs", "lib/vector-top/src/input.rs", "lib/vector-top/src/state.rs", "src/top/cmd.rs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid queuing UI redraws behind metric states**\n\nWhen metric traffic is high enough to fill `state_rx`, this prioritized UI branch still does not make the UI change visible promptly: after `handle_ui_event` r...
true
vectordotdev/vector
25,604
comment_to_fix
fix(top): handle UI events separately to prevent UI freeze
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid queuing UI redraws behind metric states** When metric traffic is high enough to fill `state_rx`, this prioritized UI branch still does not make the UI change visible promptly: after `handle_ui_event` runs, the updated state i...
bcaebb2922f860e4ac55368d06daa8551837331c
7766d59bfd7ea4c39969bb59db5fd8af50588c24
diff --git a/lib/vector-top/src/state.rs b/lib/vector-top/src/state.rs index 30fc05ef76c13..9d264d2c559f5 100644 --- a/lib/vector-top/src/state.rs +++ b/lib/vector-top/src/state.rs @@ -12,7 +12,7 @@ use ratatui::{ widgets::ListState, }; use regex::Regex; -use tokio::sync::mpsc; +use tokio::sync::{mpsc, watch}; ...
[ "lib/vector-top/src/state.rs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid queuing UI redraws behind metric states**\n\nWhen metric traffic is high enough to fill `state_rx`, this prioritized UI branch still does not make the UI change visible promptly: after `handle_ui_event` r...
true
vectordotdev/vector
25,604
comment_to_fix
fix(top): handle UI events separately to prevent UI freeze
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update input mode before throttled redraw** When a key opens a modal and the user immediately sends the next key before the next 16 ms draw tick (for example `/` followed by a typed filter character, or pasting `/foo`), `input_mode...
bcaebb2922f860e4ac55368d06daa8551837331c
7766d59bfd7ea4c39969bb59db5fd8af50588c24
diff --git a/lib/vector-top/src/dashboard.rs b/lib/vector-top/src/dashboard.rs index 9e6a1907dff36..760bfb437d824 100644 --- a/lib/vector-top/src/dashboard.rs +++ b/lib/vector-top/src/dashboard.rs @@ -633,7 +633,7 @@ pub async fn init_dashboard<'a>( url: &'a str, interval: u32, human_metrics: bool, - ...
[ "lib/vector-top/src/dashboard.rs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update input mode before throttled redraw**\n\nWhen a key opens a modal and the user immediately sends the next key before the next 16 ms draw tick (for example `/` followed by a typed filter character, or past...
true
vectordotdev/vector
25,604
comment_to_fix
fix(top): handle UI events separately to prevent UI freeze
```suggestion let state = state_rx.borrow_and_update().clone(); ``` Borrowing here holds a read lock.
bcaebb2922f860e4ac55368d06daa8551837331c
7766d59bfd7ea4c39969bb59db5fd8af50588c24
diff --git a/lib/vector-top/src/dashboard.rs b/lib/vector-top/src/dashboard.rs index 9e6a1907dff36..760bfb437d824 100644 --- a/lib/vector-top/src/dashboard.rs +++ b/lib/vector-top/src/dashboard.rs @@ -633,7 +633,7 @@ pub async fn init_dashboard<'a>( url: &'a str, interval: u32, human_metrics: bool, - ...
[ "lib/vector-top/src/dashboard.rs" ]
[ { "comment": "```suggestion\n let state = state_rx.borrow_and_update().clone();\n```\n\nBorrowing here holds a read lock.", "path": "lib/vector-top/src/dashboard.rs", "hunk": "@@ -661,7 +661,8 @@ pub async fn init_dashboard<'a>(\n \n loop {\n tokio::select! {\n- Som...
true
vectordotdev/vector
25,618
issue_to_patch
docs: fix Integration/E2E badge link in README
## Summary The Integration/E2E Test Suite badge link in `README.md` was pointing to the badge SVG URL (`/badge.svg?event=merge_group`) instead of the workflow page. Clicking the badge opened the SVG rather than the GitHub Actions workflow run list. ## Change Type - [ ] Bug fix - [ ] New feature - [ ] Dependencies - ...
6f3a5d8d2acd3f27061721cc77bf677be40368cd
32ad3c21d01f9bd5f679c5ac33e3561fecb518e4
diff --git a/README.md b/README.md index 1e5b13adf3ce2..156ae82b5615c 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,5 @@ [![Nightly](https://github.com/vectordotdev/vector/actions/workflows/nightly.yml/badge.svg)](https://github.com/vectordotdev/vector/actions/workflows/nightly.yml) -[![Integration/E2E Test Suite]...
[ "README.md" ]
[]
true
vectordotdev/vector
25,518
issue_to_patch
chore(dev): add AI-assisted component maturity evaluation skill
## Summary Tracking Vector component maturity (stable/beta/deprecated) is currently manual and ad-hoc. This adds a Claude Code skill that automates a monthly evaluation — collecting signals from git, GitHub issues, CUE metadata, and test infrastructure — and writes a structured markdown report with promotion candida...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md", ".gitignore" ]
[ { "comment": "## check-spelling / Check File Path\n\n[claude](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22091)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---", "r...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Check File Path [claude](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22091)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Check File Path\n\n[claude](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22091)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---", "r...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [maxdepth](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22099)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[maxdepth](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22099)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [oneline](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22102)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[oneline](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22102)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\n...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [claude](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22096)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[claude](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22096)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\n+...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [claude](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22097)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[claude](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22097)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\n+...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [hyperlinked](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22098)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[hyperlinked](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22098)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+-...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [mcp](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22100)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[mcp](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22100)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\n+nam...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [atlassian](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22092)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[atlassian](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22092)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [atlassian](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22093)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[atlassian](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22093)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [blockquotes](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22095)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[blockquotes](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22095)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+-...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [mcp](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22101)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[mcp](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22101)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---\n+nam...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [atlassian](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22094)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[atlassian](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22094)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,267 @@\n+---...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Add source-specific implementation mappings** When this runs for source components whose implementations live under shared directories, the only paths added are `src/sources/<name>.rs` and `src/sources/<name>`, so repo search shows...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Add source-specific implementation mappings**\n\nWhen this runs for source components whose implementations live under shared directories, the only paths added are `src/sources/<name>.rs` and `src/sources/<name...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include legacy bug labels in the bug query** For open issues that still carry the legacy `type: bug` label but have no GitHub Issue Type set, this query drops them before Phase 4, so affected components can be reported as having no...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include legacy bug labels in the bug query**\n\nFor open issues that still carry the legacy `type: bug` label but have no GitHub Issue Type set, this query drops them before Phase 4, so affected components can ...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use component labels when matching bugs** When an open bug has the component only in its GitHub labels, this command discards that signal and Phase 4's title scan won't count it for the component. I checked the current tracker and ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use component labels when matching bugs**\n\nWhen an open bug has the component only in its GitHub labels, this command discards that signal and Phase 4's title scan won't count it for the component. I checked ...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exclude integration tests from unit test counts** For components whose directory contains feature-gated `integration_tests.rs`, this recursive `rg` counts those integration tests as unit tests even though Phase 2e tracks integratio...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exclude integration tests from unit test counts**\n\nFor components whose directory contains feature-gated `integration_tests.rs`, this recursive `rg` counts those integration tests as unit tests even though Ph...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep inherited real components in the inventory** Excluding `sinks/statsd.cue` and `sources/syslog.cue` from per-component counts drops two real components from the monthly inventory whenever their inherited `development` field is ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep inherited real components in the inventory**\n\nExcluding `sinks/statsd.cue` and `sources/syslog.cue` from per-component counts drops two real components from the monthly inventory whenever their inherited...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Download an artifact the workflow actually publishes** In the current `.github/workflows/coverage.yml`, the `coverage-upload` job creates `merged-lcov.info` and uploads it only to Datadog; `rg` shows no `upload-artifact` step or ar...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Download an artifact the workflow actually publishes**\n\nIn the current `.github/workflows/coverage.yml`, the `coverage-upload` job creates `merged-lcov.info` and uploads it only to Datadog; `rg` shows no `upl...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Map shared implementation directories explicitly** Fresh evidence: this coverage-mapping step still uses the raw CUE component name as a source-path prefix, so components implemented in shared directories get `n/a` coverage even th...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Map shared implementation directories explicitly**\n\nFresh evidence: this coverage-mapping step still uses the raw CUE component name as a source-path prefix, so components implemented in shared directories ge...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Weight coverage by line counts** For any component that spans multiple files of very different sizes, averaging the per-file percentages loses the `LF`/`LH` denominators and can substantially misstate component coverage. A small fu...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Weight coverage by line counts**\n\nFor any component that spans multiple files of very different sizes, averaging the per-file percentages loses the `LF`/`LH` denominators and can substantially misstate compon...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include generated config in churn counts** This only counts commits to the hand-written component metadata file, but the actual configuration API is referenced from generated CUE such as `configuration: generated.components.sources...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include generated config in churn counts**\n\nThis only counts commits to the hand-written component metadata file, but the actual configuration API is referenced from generated CUE such as `configuration: gene...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require commonly_used before promoting** The criteria above define the production-usage proxy for stable as `commonly_used: true` plus age, but the promotion rule omits `commonly_used` entirely. As a result, any old beta component ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require commonly_used before promoting**\n\nThe criteria above define the production-usage proxy for stable as `commonly_used: true` plus age, but the promotion rule omits `commonly_used` entirely. As a result,...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [lcov](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22366)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[lcov](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22366)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [lcov](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22365)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[lcov](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22365)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [lcov](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22367)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[lcov](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22367)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [lcov](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22368)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[lcov](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22368)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [lcov](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22369)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[lcov](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22369)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
## check-spelling / Unrecognized Spelling [LCOV](#security-tab) is not a recognized word [Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22360)
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "## check-spelling / Unrecognized Spelling\n\n[LCOV](#security-tab) is not a recognized word\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22360)", "path": ".claude/skills/vector-components-maturity-eval/SKILL.md", "hunk": "@@ -0,0 +1,281 @@\n+---\n+na...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve all inherited sink development classes** When this inventory reaches inherited real sinks, the reference only calls out `statsd`/`syslog` as needing inherited `development` resolution, but repo-wide CUE inspection shows `da...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve all inherited sink development classes**\n\nWhen this inventory reaches inherited real sinks, the reference only calls out `statsd`/`syslog` as needing inherited `development` resolution, but repo-wide ...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Read generated configuration before scoring examples** For components whose `configuration` is just a generated CUE reference, this docs pass never tells the evaluator to read that generated file before deciding whether examples ex...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Read generated configuration before scoring examples**\n\nFor components whose `configuration` is just a generated CUE reference, this docs pass never tells the evaluator to read that generated file before deci...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include major legacy bugs in the bug feed** The guarantees document still defines the canonical bug set with the `type: bug` label link, and this new query only requests issues whose Issue Type field is `Bug`. Any still-open major ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include major legacy bugs in the bug feed**\n\nThe guarantees document still defines the canonical bug set with the `type: bug` label link, and this new query only requests issues whose Issue Type field is `Bug...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Page through all bug results** When the bug search has more than 500 matches, this hard cap silently drops the remaining issues before Phase 4; the `gh issue list` manual defines `--limit` as the “Maximum number of issues to fetch,...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Page through all bug results**\n\nWhen the bug search has more than 500 matches, this hard cap silently drops the remaining issues before Phase 4; the `gh issue list` manual defines `--limit` as the “Maximum nu...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require a path boundary for coverage matches** When one component name is a prefix of another, this raw `starts with` match mixes their LCOV records. For example, the real `websocket` sink and `websocket_server` sink both exist, an...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require a path boundary for coverage matches**\n\nWhen one component name is a prefix of another, this raw `starts with` match mixes their LCOV records. For example, the real `websocket` sink and `websocket_ser...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not promote components with open bugs** When a beta component has exactly one matched open bug, this rule still puts it in the stable promotion set even though the stated stable proxy above is “zero open bugs” and the skill does...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not promote components with open bugs**\n\nWhen a beta component has exactly one matched open bug, this rule still puts it in the stable promotion set even though the stated stable proxy above is “zero open ...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Pin GitHub CLI queries to the upstream repo** When the skill is run from a fork checkout or a clone without a GitHub remote, these `gh` commands use the current repository context (or fail) instead of the intended `vectordotdev/vec...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Pin GitHub CLI queries to the upstream repo**\n\nWhen the skill is run from a fork checkout or a clone without a GitHub remote, these `gh` commands use the current repository context (or fail) instead of the in...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Fetch issue bodies before severity judgment** When a bug's severity is only clear from its description, Phase 5 asks the evaluator to judge "title and description" but this bulk query stores only `number,title,url,labels`. The `gh ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Fetch issue bodies before severity judgment**\n\nWhen a bug's severity is only clear from its description, Phase 5 asks the evaluator to judge \"title and description\" but this bulk query stores only `number,t...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exempt transforms from E2E watch rule** For stable transforms, this rule treats the absence of a live external-dependency integration test as a watch signal even though transforms like `remap`, `filter`, and `route` have no externa...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exempt transforms from E2E watch rule**\n\nFor stable transforms, this rule treats the absence of a live external-dependency integration test as a watch signal even though transforms like `remap`, `filter`, and...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Add mappings for grouped integration suites** For components covered by shared or hyphenated integration suites that are not listed here, the fallback scan for the literal component name still misses real E2E tests. For example, `t...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Add mappings for grouped integration suites**\n\nFor components covered by shared or hyphenated integration suites that are not listed here, the fallback scan for the literal component name still misses real E2...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Flag severe stable bugs below the count threshold** A stable component with one or two matched crash/data-loss bugs will not be put on the watch list here unless it also has high churn or missing tests, even though the criteria abo...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Flag severe stable bugs below the count threshold**\n\nA stable component with one or two matched crash/data-loss bugs will not be put on the watch list here unless it also has high churn or missing tests, even...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not credit filtered Prometheus tests broadly** The Prometheus integration config only runs the `::prometheus::remote_write::` filter (vdev passes `test_filter` directly to cargo test), so the `scrape` and `exporter` integration ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not credit filtered Prometheus tests broadly**\n\nThe Prometheus integration config only runs the `::prometheus::remote_write::` filter (vdev passes `test_filter` directly to cargo test), so the `scrape` and...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exempt local-only sources and sinks from E2E watch rule** For sources/sinks that deliberately have no live external dependency, this marks stable components as watch solely because no `tests/integration/<name>` suite exists. I chec...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Exempt local-only sources and sinks from E2E watch rule**\n\nFor sources/sinks that deliberately have no live external dependency, this marks stable components as watch solely because no `tests/integration/<nam...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match bug reports by component aliases too** When users or labels refer to a component by its documented alias instead of the CUE filename, this matching misses the bug entirely. Several real components define aliases in their CUE ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match bug reports by component aliases too**\n\nWhen users or labels refer to a component by its documented alias instead of the CUE filename, this matching misses the bug entirely. Several real components defi...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Count inherited socket config churn** When the component is `sources/syslog` or `sinks/statsd`, this churn collection only includes the component's own CUE/generated file, even though both CUE files set `classes: sources.socket.cla...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Count inherited socket config churn**\n\nWhen the component is `sources/syslog` or `sinks/statsd`, this churn collection only includes the component's own CUE/generated file, even though both CUE files set `cla...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include tests/e2e in E2E discovery** When a source or sink is covered by the dedicated `tests/e2e/` suites, this phase never looks there because it only tells the evaluator to examine `tests/integration/`. I checked `tests/e2e/open...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include tests/e2e in E2E discovery**\n\nWhen a source or sink is covered by the dedicated `tests/e2e/` suites, this phase never looks there because it only tells the evaluator to examine `tests/integration/`. I...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use canonical component names in the E2E map** These mappings use names that do not match the inventory's CUE component IDs: the repo has `sources/docker_logs.cue` and `sources/windows_event_log.cue`, and their integration configs ...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use canonical component names in the E2E map**\n\nThese mappings use names that do not match the inventory's CUE component IDs: the repo has `sources/docker_logs.cue` and `sources/windows_event_log.cue`, and th...
true
vectordotdev/vector
25,518
comment_to_fix
chore(dev): add AI-assisted component maturity evaluation skill
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Follow the referenced generated CUE object** When a component's `configuration` points at a generated object with a different name, reading `generated/<component>.cue` scores the wrong option examples. For example, `website/cue/ref...
744931a304779d9d6a7f5ea3e3ad7333783cd264
077684a848addaccd5afb2ea480e02677db99df3
diff --git a/.claude/skills/vector-components-maturity-eval/SKILL.md b/.claude/skills/vector-components-maturity-eval/SKILL.md new file mode 100644 index 0000000000000..47c0fea744063 --- /dev/null +++ b/.claude/skills/vector-components-maturity-eval/SKILL.md @@ -0,0 +1,386 @@ +--- +name: vector-components-maturity-eval...
[ ".claude/skills/vector-components-maturity-eval/SKILL.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Follow the referenced generated CUE object**\n\nWhen a component's `configuration` points at a generated object with a different name, reading `generated/<component>.cue` scores the wrong option examples. For e...
true
vectordotdev/vector
25,612
issue_to_patch
chore(website): website updates
## Summary Consolidates several documentation and website improvements. ## Vector configuration NA ## How did you test this PR? NA ## Change Type - [ ] Bug fix - [ ] New feature - [ ] Dependencies - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## Is this a breaking change? - [ ] Yes - [x] No...
6817c0218e1af8efc484c3a74317fc1192a5a450
0083d2b33a58bd263ab860c2913fc1f18a506524
diff --git a/.github/actions/spelling/README.md b/.github/actions/spelling/README.md deleted file mode 100644 index c5c8999abc52a..0000000000000 --- a/.github/actions/spelling/README.md +++ /dev/null @@ -1,17 +0,0 @@ -# check-spelling/check-spelling configuration - -File | Purpose | Format | Info ---- | --- | --- | ---...
[ ".github/actions/spelling/README.md", ".github/actions/spelling/advice.md", ".github/actions/spelling/allow.txt", ".github/actions/spelling/candidate.patterns", ".github/actions/spelling/excludes.txt", ".github/actions/spelling/expect.txt", ".github/actions/spelling/line_forbidden.patterns", ".github/...
[]
diff --git a/tests/integration/shutdown.rs b/tests/integration/shutdown.rs index fcd456c4dc9c1..b4b3aa48961a9 100644 --- a/tests/integration/shutdown.rs +++ b/tests/integration/shutdown.rs @@ -310,7 +310,7 @@ fn configuration_path_recomputed() { // Signal reload kill(Pid::from_raw(vector.id() as i32), Signal:...
true
vectordotdev/vector
25,611
issue_to_patch
docs(rfcs): simplify RFC template and process
## Summary The RFC template and process have accumulated sections that either overlap or add friction without adding clarity. This trims redundant sections and softens process requirements that aren't enforced. ## Motivation The previous template had duplicate concepts split across separate sections (e.g., Motivatio...
bcaebb2922f860e4ac55368d06daa8551837331c
4e804ba73d0b022944827cf54da9edf49a723ad2
diff --git a/rfcs/README.md b/rfcs/README.md index 055819c005902..3d5d3586cefb1 100644 --- a/rfcs/README.md +++ b/rfcs/README.md @@ -78,20 +78,19 @@ more info navigating your solution. 1. Search GitHub for [previous issues](https://github.com/vectordotdev/vector/issues) and [RFCs](https://github.com/vectordotdev...
[ "rfcs/README.md", "rfcs/_YYYY-MM-DD-issue#-title.md" ]
[]
true
vectordotdev/vector
25,609
issue_to_patch
chore(vrl): Avoid using unnecessary LazyLock
## Summary Similar as https://github.com/vectordotdev/vrl/pull/1777 for vector ## Vector configuration N/A ## How did you test this PR? ``` cargo check ``` ## Change Type - [ ] Bug fix - [ ] New feature - [ ] Dependencies - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## Is...
212651b08e066b775a8e5e253c1d37c3715e3476
adfd819329cad50901cf238b42da49c5ba4fe482
diff --git a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs b/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs index 03ae04bec3ac6..93b6ca3f9f1e8 100644 --- a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs +++ b/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs...
[ "lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs", "lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs", "lib/vector-vrl/enrichment/src/vrl_util.rs" ]
[ { "comment": "```suggestion\n PARAMETERS\n```", "path": "lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs", "hunk": "", "resolving_sha": "adfd819329cad50901cf238b42da49c5ba4fe482", "resolving_diff": "diff --git a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs...
true
vectordotdev/vector
25,609
comment_to_fix
chore(vrl): Avoid using unnecessary LazyLock
```suggestion PARAMETERS ```
212651b08e066b775a8e5e253c1d37c3715e3476
adfd819329cad50901cf238b42da49c5ba4fe482
diff --git a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs b/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs index 03ae04bec3ac6..93b6ca3f9f1e8 100644 --- a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs +++ b/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs...
[ "lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs" ]
[ { "comment": "```suggestion\n PARAMETERS\n```", "path": "lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs", "hunk": "", "resolving_sha": "adfd819329cad50901cf238b42da49c5ba4fe482", "resolving_diff": "diff --git a/lib/vector-vrl/enrichment/src/find_enrichment_table_records.rs...
true
vectordotdev/vector
25,609
comment_to_fix
chore(vrl): Avoid using unnecessary LazyLock
```suggestion PARAMETERS ```
212651b08e066b775a8e5e253c1d37c3715e3476
adfd819329cad50901cf238b42da49c5ba4fe482
diff --git a/lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs b/lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs index 7c3a9205394ff..767b981813799 100644 --- a/lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs +++ b/lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs @@ -1,4...
[ "lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs" ]
[ { "comment": "```suggestion\n PARAMETERS\n```", "path": "lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs", "hunk": "", "resolving_sha": "adfd819329cad50901cf238b42da49c5ba4fe482", "resolving_diff": "diff --git a/lib/vector-vrl/enrichment/src/get_enrichment_table_record.rs b/l...
true