repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Same comma issue — restrictive "that" clause needs no comma.
```suggestion
Added a new `delay` transform that delays each event by a fixed duration.
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Same comma issue — restrictive \"that\" clause needs no comma.\n\n```suggestion\n\t\t\t\tAdded a new `delay` transform that delays each event by a fixed duration.\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\n+\n+releases: \"0.56... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | "via" should be "through"; "Supports" opens a fragment with an ambiguous subject.
```suggestion
- Added a new `databricks_zerobus` sink that streams log data to Databricks Unity Catalog tables through the Zerobus ingestion service. The sink supports OAuth 2.0 authentication, automatic schema fetching from Unity Cata... | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "\"via\" should be \"through\"; \"Supports\" opens a fragment with an ambiguous subject.\n\n```suggestion\n\t\t- Added a new `databricks_zerobus` sink that streams log data to Databricks Unity Catalog tables through the Zerobus ingestion service. The sink supports OAuth 2.0 authentication, automati... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | "via" should be "through"; "Supports" opens a fragment with an ambiguous subject.
```suggestion
Added a new `databricks_zerobus` sink that streams log data to Databricks Unity Catalog tables through the Zerobus ingestion service. The sink supports OAuth 2.0 authentication, automatic schema fetching from Unity Cata... | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "\"via\" should be \"through\"; \"Supports\" opens a fragment with an ambiguous subject.\n\n```suggestion\n\t\t\t\tAdded a new `databricks_zerobus` sink that streams log data to Databricks Unity Catalog tables through the Zerobus ingestion service. The sink supports OAuth 2.0 authentication, automa... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing Oxford comma before "and others".
```suggestion
- Fixed a CPU regression introduced in 0.50.0 affecting all sinks that use metric normalization such as `prometheus_remote_write`, `aws_cloudwatch_metrics`, `statsd`, and others.
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing Oxford comma before \"and others\".\n\n```suggestion\n\t\t- Fixed a CPU regression introduced in 0.50.0 affecting all sinks that use metric normalization such as `prometheus_remote_write`, `aws_cloudwatch_metrics`, `statsd`, and others.\n```",
"path": "website/cue/reference/releases/0.... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing Oxford comma before "and others".
```suggestion
Fixed a CPU regression introduced in 0.50.0 affecting all sinks that use metric normalization such as `prometheus_remote_write`, `aws_cloudwatch_metrics`, `statsd`, and others.
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing Oxford comma before \"and others\".\n\n```suggestion\n\t\t\t\tFixed a CPU regression introduced in 0.50.0 affecting all sinks that use metric normalization such as `prometheus_remote_write`, `aws_cloudwatch_metrics`, `statsd`, and others.\n```",
"path": "website/cue/reference/releases/... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing comma after introductory "Previously".
```suggestion
missing header). Previously, such malformed frames were silently decoded as
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing comma after introductory \"Previously\".\n\n```suggestion\n\t\t\t\tmissing header). Previously, such malformed frames were silently decoded as\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\n+\n+releases: \"0.56.0\": {\n+\t... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing article "an"; "in place" needs a hyphen as a compound modifier.
```suggestion
Fixed an issue during in-place reload of a sink with a disk buffer configured, where
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing article \"an\"; \"in place\" needs a hyphen as a compound modifier.\n\n```suggestion\n\t\t\t\tFixed an issue during in-place reload of a sink with a disk buffer configured, where\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metada... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Awkward phrasing with a repeated "where"; also missing article "an".
```suggestion
This fix also resolves an issue where Vector ignored SIGINT when a pipeline stall occurred.
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Awkward phrasing with a repeated \"where\"; also missing article \"an\".\n\n```suggestion\n\t\t\t\tThis fix also resolves an issue where Vector ignored SIGINT when a pipeline stall occurred.\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package me... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Avoid using "/" to mean "or".
```suggestion
The `aggregate` transform now correctly passes through or ignores metrics whose kind is not supported
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Avoid using \"/\" to mean \"or\".\n\n```suggestion\n\t\t\t\tThe `aggregate` transform now correctly passes through or ignores metrics whose kind is not supported\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\n+\n+releases: \"0.56.... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing comma after introductory "Prior to this change".
```suggestion
by the configured mode. Prior to this change, these metrics would be silently dropped, contrary to
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing comma after introductory \"Prior to this change\".\n\n```suggestion\n\t\t\t\tby the configured mode. Prior to this change, these metrics would be silently dropped, contrary to\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Missing comma after introductory "Previously".
```suggestion
The `aws_s3` and `clickhouse` sinks now correctly advertise only the `batch_encoding.codec` values they actually support: `parquet` for `aws_s3` and `arrow_stream` for `clickhouse`. Previously, the documentation and configuration schema listed both codec... | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Missing comma after introductory \"Previously\".\n\n```suggestion\n\t\t\t\tThe `aws_s3` and `clickhouse` sinks now correctly advertise only the `batch_encoding.codec` values they actually support: `parquet` for `aws_s3` and `arrow_stream` for `clickhouse`. Previously, the documentation and configu... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Remove "please" per style guide.
```suggestion
pipelines assert on specific generated usernames or TLDs, update those expectations.
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Remove \"please\" per style guide.\n\n```suggestion\n\t\t\t\tpipelines assert on specific generated usernames or TLDs, update those expectations.\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\n+\n+releases: \"0.56.0\": {\n+\tdate:... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | Number mismatch: "source" should be plural to match "sinks".
```suggestion
This notably affected sinks using a disk buffer, and sources or sinks performing
``` | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "Number mismatch: \"source\" should be plural to match \"sinks\".\n\n```suggestion\n\t\t\t\tThis notably affected sinks using a disk buffer, and sources or sinks performing\n```",
"path": "website/cue/reference/releases/0.56.0.cue",
"hunk": "@@ -0,0 +1,639 @@\n+package metadata\n+\n+release... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | **<sub><sub></sub></sub> Surface breaking entries outside the chore bucket**
Fresh evidence after the prior review is that the release template still filters changelog groups only by `.type` and never reads `.breaking` (`website/layouts/releases/single.htm... | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "**<sub><sub></sub></sub> Surface breaking entries outside the chore bucket**\n\nFresh evidence after the prior review is that the release template still filters changelog groups only by `.type` and never reads `.breaking` (`website/lay... | true | ||
vectordotdev/vector | 25,555 | comment_to_fix | chore(releasing): prepare v0.56.0 release | **<sub><sub></sub></sub> Document the bundled VRL version**
When publishing 0.56.0 with the current dependency bump, `Cargo.toml` and `Cargo.lock` now ship `vrl` 0.33.1, but the release page's VRL changelog still starts at 0.33.0. Users checking the 0.56.0... | 2a3c5d89de23ee9b65d97fd038c2eb8bdbf98578 | b1c454b406eaf8c1c5f2d88b4c321ce9c99fb68a | diff --git a/website/cue/reference/releases/0.56.0.cue b/website/cue/reference/releases/0.56.0.cue
new file mode 100644
index 0000000000000..bfb16550249b8
--- /dev/null
+++ b/website/cue/reference/releases/0.56.0.cue
@@ -0,0 +1,646 @@
+package metadata
+
+releases: "0.56.0": {
+ date: "2026-06-03"
+ codename: ""
+
... | [
"website/cue/reference/releases/0.56.0.cue"
] | [
{
"comment": "**<sub><sub></sub></sub> Document the bundled VRL version**\n\nWhen publishing 0.56.0 with the current dependency bump, `Cargo.toml` and `Cargo.lock` now ship `vrl` 0.33.1, but the release page's VRL changelog still starts at 0.33.0. U... | true | ||
vectordotdev/vector | 25,560 | issue_to_patch | docs(schemas): improve log_namespace docs and warn on log_schema | ## Summary
Docs improvements for `schema.log_namespace` and the related `log_schema`:
- Adds a `{{< warning >}}` callout in the log namespace guide for the disk buffer incompatibility.
- Adds a beta note in the `log_namespace` field description on the reference page.
- Marks the `log_namespace` field with `stat... | 067ef75e6474e885203885826f0d1f8ca2f93897 | f9c0bfb78863de295915dc19ea594dd1f920a6fa | diff --git a/lib/vector-core/src/config/global_options.rs b/lib/vector-core/src/config/global_options.rs
index d86df49803552..2eb5fd3cdbda4 100644
--- a/lib/vector-core/src/config/global_options.rs
+++ b/lib/vector-core/src/config/global_options.rs
@@ -84,7 +84,11 @@ pub struct GlobalOptions {
/// This is used if ... | [
"lib/vector-core/src/config/global_options.rs",
"src/config/schema.rs",
"website/content/en/guides/level-up/log_namespace.md",
"website/cue/reference/generated/configuration.cue"
] | [] | true | ||
vectordotdev/vector | 25,521 | issue_to_patch | fix(observability): propagate component span into spawned tasks | ## Summary
Several components spawn background `tokio` tasks (or run work on detached tasks via `concurrent_map`) without carrying the current tracing span. Vector's internal metrics/logs derive their component tags (`component_id`, `component_kind`, `component_type`) from that span, so any telemetry emitted from th... | 08b6975fc7c0384ecb72e94bceedb7622a5340db | e5ca812e4688c2f6e78155a4cc5c8de09d1013ce | diff --git a/Cargo.toml b/Cargo.toml
index c389001ed9276..35e1783159360 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1125,6 +1125,7 @@ vector-api-tests = [
"api",
"api-client-minimal",
"sources-demo_logs",
+ "sources-gcp_pubsub",
"transforms-log_to_metric",
"transforms-remap",
"transforms-route",
dif... | [
"Cargo.toml",
"changelog.d/spawned_task_component_tags.fix.md",
"lib/file-source/src/file_server.rs",
"lib/vector-buffers/src/variants/disk_v2/ledger.rs",
"lib/vector-common/Cargo.toml",
"lib/vector-common/src/lib.rs",
"lib/vector-core/src/fanout.rs",
"lib/vector-lib/src/lib.rs",
"lib/vector-stream/... | [
{
"comment": "## check-spelling / Single-line file\n\nSkipping [changelog.d/spawned\\_task\\_component_tags.fix.md](#security-tab) because file only has a single line\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22103)",
"path": "changelog.d/spawned_task_component_tag... | diff --git a/tests/vector_api/harness.rs b/tests/vector_api/harness.rs
index ba79b521bba22..e9fc94daa562f 100644
--- a/tests/vector_api/harness.rs
+++ b/tests/vector_api/harness.rs
@@ -97,7 +97,10 @@ impl TestHarness {
let mut cmd =
Command::cargo_bin("vector").map_err(|e| format!("Failed to get c... | true | |
vectordotdev/vector | 25,521 | comment_to_fix | fix(observability): propagate component span into spawned tasks | ## check-spelling / Single-line file
Skipping [changelog.d/spawned\_task\_component_tags.fix.md](#security-tab) because file only has a single line
[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22103) | 08b6975fc7c0384ecb72e94bceedb7622a5340db | e5ca812e4688c2f6e78155a4cc5c8de09d1013ce | diff --git a/changelog.d/spawned_task_component_tags.fix.md b/changelog.d/spawned_task_component_tags.fix.md
new file mode 100644
index 0000000000000..d2f5c2bb068a1
--- /dev/null
+++ b/changelog.d/spawned_task_component_tags.fix.md
@@ -0,0 +1,3 @@
+Internal telemetry (metrics and logs) emitted from work that Vector run... | [
"changelog.d/spawned_task_component_tags.fix.md"
] | [
{
"comment": "## check-spelling / Single-line file\n\nSkipping [changelog.d/spawned\\_task\\_component_tags.fix.md](#security-tab) because file only has a single line\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/22103)",
"path": "changelog.d/spawned_task_component_tag... | true | ||
vectordotdev/vector | 25,521 | comment_to_fix | fix(observability): propagate component span into spawned tasks | Would it be helpful to have a spawn_in_current_task wrapper for this common operation? It's a relatively trivial amount of code duplication, but it would simplify searching for spawns that are missing spans and potentially even block calling tokio::spawn directly without proper annotations. | 08b6975fc7c0384ecb72e94bceedb7622a5340db | e5ca812e4688c2f6e78155a4cc5c8de09d1013ce | diff --git a/src/api/grpc_server.rs b/src/api/grpc_server.rs
index 715aeecad2b8e..f582b2f82981c 100644
--- a/src/api/grpc_server.rs
+++ b/src/api/grpc_server.rs
@@ -80,7 +80,7 @@ impl GrpcServer {
let router_serving = Arc::clone(&serving);
// Spawn the server with the already-bound listener
- ... | [
"src/api/grpc_server.rs"
] | [
{
"comment": "Would it be helpful to have a spawn_in_current_task wrapper for this common operation? It's a relatively trivial amount of code duplication, but it would simplify searching for spawns that are missing spans and potentially even block calling tokio::spawn directly without proper annotations.",
... | true | ||
vectordotdev/vector | 25,521 | comment_to_fix | fix(observability): propagate component span into spawned tasks | Can we use spawn_in_current_span here and in other places that use `.in_current_span()`? | 08b6975fc7c0384ecb72e94bceedb7622a5340db | e5ca812e4688c2f6e78155a4cc5c8de09d1013ce | diff --git a/lib/file-source/src/file_server.rs b/lib/file-source/src/file_server.rs
index 87a436298ca16..17d80cf1586a4 100644
--- a/lib/file-source/src/file_server.rs
+++ b/lib/file-source/src/file_server.rs
@@ -148,7 +148,7 @@ where
let mut stats = TimingStats::default();
// Spawn the checkpoint w... | [
"lib/file-source/src/file_server.rs"
] | [
{
"comment": "Can we use spawn_in_current_span here and in other places that use `.in_current_span()`?",
"path": "lib/file-source/src/file_server.rs",
"hunk": "@@ -148,12 +148,15 @@ where\n let mut stats = TimingStats::default();\n \n // Spawn the checkpoint writer task\n- let che... | true | ||
vectordotdev/vector | 25,521 | comment_to_fix | fix(observability): propagate component span into spawned tasks | **<sub><sub></sub></sub> Enable Tokio runtime for span-preserving spawn**
When `vector-common` is built by itself or by any dependent crate that does not also enable Tokio's `rt` feature, this new helper makes the crate fail to compile because it unconditi... | 08b6975fc7c0384ecb72e94bceedb7622a5340db | e5ca812e4688c2f6e78155a4cc5c8de09d1013ce | diff --git a/lib/vector-common/src/lib.rs b/lib/vector-common/src/lib.rs
index 75849aac75884..cda7e4b921242 100644
--- a/lib/vector-common/src/lib.rs
+++ b/lib/vector-common/src/lib.rs
@@ -130,3 +130,19 @@ pub type Error = Box<dyn std::error::Error + Send + Sync + 'static>;
/// Vector's basic result type, defined in t... | [
"lib/vector-common/src/lib.rs"
] | [
{
"comment": "**<sub><sub></sub></sub> Enable Tokio runtime for span-preserving spawn**\n\nWhen `vector-common` is built by itself or by any dependent crate that does not also enable Tokio's `rt` feature, this new helper makes the crate fail to comp... | true | ||
vectordotdev/vector | 24,697 | issue_to_patch | enhancement(observability)!: Time-weight buffer utilization means | ## Summary
Under a fully loaded pipeline, the typical source will batch its received events into arrays, the size of which is currently capped at 1,000 events. The channel buffers for transforms, however, have a capacity limit of 100 events. This means their actual utilization under non-trivial load will bounce betw... | e487d6ed6fa413f2ced27780227424f02472c799 | ad4fc594ceedd548e3265c46d767fa4fa4f3101f | diff --git a/changelog.d/time-weighted-buffer-utilization-mean.breaking.md b/changelog.d/time-weighted-buffer-utilization-mean.breaking.md
new file mode 100644
index 0000000000000..24e8d0a048cf8
--- /dev/null
+++ b/changelog.d/time-weighted-buffer-utilization-mean.breaking.md
@@ -0,0 +1,9 @@
+The `*buffer_utilization_m... | [
"changelog.d/time-weighted-buffer-utilization-mean.breaking.md",
"lib/vector-buffers/src/topology/builder.rs",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-buffers/src/topology/channel/mod.rs",
"lib/vector-common/src/stats/ewma_gauge.rs",
"lib/vector-common/src/stats/mod.rs",
... | [
{
"comment": "We should mention: \n\n> This change is breaking due to the replacement of the existing `buffer_utilization_ewma_alpha` config option with `buffer_utilization_ewma_half_life_seconds`.\n\n",
"path": "changelog.d/time-weighted-buffer-utilization-mean.breaking.md",
"hunk": "@@ -0,0 +1,5 @@\n+... | true | ||
vectordotdev/vector | 24,697 | comment_to_fix | enhancement(observability)!: Time-weight buffer utilization means | We should mention:
> This change is breaking due to the replacement of the existing `buffer_utilization_ewma_alpha` config option with `buffer_utilization_ewma_half_life_seconds`.
| e487d6ed6fa413f2ced27780227424f02472c799 | ad4fc594ceedd548e3265c46d767fa4fa4f3101f | diff --git a/changelog.d/time-weighted-buffer-utilization-mean.breaking.md b/changelog.d/time-weighted-buffer-utilization-mean.breaking.md
new file mode 100644
index 0000000000000..24e8d0a048cf8
--- /dev/null
+++ b/changelog.d/time-weighted-buffer-utilization-mean.breaking.md
@@ -0,0 +1,9 @@
+The `*buffer_utilization_m... | [
"changelog.d/time-weighted-buffer-utilization-mean.breaking.md"
] | [
{
"comment": "We should mention: \n\n> This change is breaking due to the replacement of the existing `buffer_utilization_ewma_alpha` config option with `buffer_utilization_ewma_half_life_seconds`.\n\n",
"path": "changelog.d/time-weighted-buffer-utilization-mean.breaking.md",
"hunk": "@@ -0,0 +1,5 @@\n+... | true | ||
vectordotdev/vector | 24,697 | comment_to_fix | enhancement(observability)!: Time-weight buffer utilization means | ```suggestion
/// adjustments.
/// - Lower values (< 5s): Metrics update quickly but may be volatile
/// - Default (= 5s): Balanced between responsiveness and stability
/// - Higher values (> 5s): Smooth, stable metrics that filter out brief spikes
///
/// Adjust based on whether you need fast d... | e487d6ed6fa413f2ced27780227424f02472c799 | ad4fc594ceedd548e3265c46d767fa4fa4f3101f | diff --git a/lib/vector-core/src/config/global_options.rs b/lib/vector-core/src/config/global_options.rs
index 864505519c516..329cf1a58e006 100644
--- a/lib/vector-core/src/config/global_options.rs
+++ b/lib/vector-core/src/config/global_options.rs
@@ -10,6 +10,16 @@ use super::{
};
use crate::serde::bool_or_struct;
... | [
"lib/vector-core/src/config/global_options.rs"
] | [
{
"comment": "```suggestion\n /// adjustments.\n \n /// - Lower values (< 5s): Metrics update quickly but may be volatile\n /// - Default (= 5s): Balanced between responsiveness and stability\n /// - Higher values (> 5s): Smooth, stable metrics that filter out brief spikes\n ///\n /// Adjust bas... | true | ||
vectordotdev/vector | 24,627 | issue_to_patch | enhancement(observability): Add transform latency metrics | ## Summary
This adds the `component_latency_seconds` histogram and `component_latency_mean_seconds` gauge internal metrics, exposing the time an event spends in a single transform including the transform buffer.
Replaces #24612
If you'd like me to break out any of the individual commits into separate PRs to m... | 7cd3395e3049e1ce53d43e4aaf41415355c77bc4 | 8b48e6856d5fd22c17c59d2a4b5e92e9ea48d069 | diff --git a/changelog.d/component_latency-metrics.enhancement.md b/changelog.d/component_latency-metrics.enhancement.md
new file mode 100644
index 0000000000000..844a8867a6099
--- /dev/null
+++ b/changelog.d/component_latency-metrics.enhancement.md
@@ -0,0 +1,5 @@
+Added the `component_latency_seconds` histogram and
+... | [
"changelog.d/component_latency-metrics.enhancement.md",
"lib/vector-core/src/config/global_options.rs",
"lib/vector-core/src/event/array.rs",
"lib/vector-core/src/event/metadata.rs",
"lib/vector-core/src/event/proto.rs",
"lib/vector-core/src/latency.rs",
"lib/vector-core/src/lib.rs",
"lib/vector-core/... | [
{
"comment": "implementation of `on_send` calls `Instant::now` instantly and so does the next line here. I think that we can safely change on_send to get an `Instant` or `Option<Instant>` here to avoid the extra call",
"path": "src/topology/builder.rs",
"hunk": "@@ -846,6 +834,7 @@ impl<'a> Builder<'a> ... | diff --git a/src/test_util/mock/sinks/completion.rs b/src/test_util/mock/sinks/completion.rs
new file mode 100644
index 0000000000000..a390f33c9828b
--- /dev/null
+++ b/src/test_util/mock/sinks/completion.rs
@@ -0,0 +1,95 @@
+use std::sync::{Arc, Mutex};
+
+use async_trait::async_trait;
+use futures_util::{FutureExt, S... | true | |
vectordotdev/vector | 24,627 | comment_to_fix | enhancement(observability): Add transform latency metrics | implementation of `on_send` calls `Instant::now` instantly and so does the next line here. I think that we can safely change on_send to get an `Instant` or `Option<Instant>` here to avoid the extra call | 7cd3395e3049e1ce53d43e4aaf41415355c77bc4 | 8b48e6856d5fd22c17c59d2a4b5e92e9ea48d069 | diff --git a/src/topology/builder.rs b/src/topology/builder.rs
index bcf2d6a7560cc..0a8e7e2e993c0 100644
--- a/src/topology/builder.rs
+++ b/src/topology/builder.rs
@@ -22,10 +22,11 @@ use vector_lib::{
BufferType, WhenFull,
topology::{
builder::TopologyBuilder,
- channel::{Buf... | [
"src/topology/builder.rs"
] | [
{
"comment": "implementation of `on_send` calls `Instant::now` instantly and so does the next line here. I think that we can safely change on_send to get an `Instant` or `Option<Instant>` here to avoid the extra call",
"path": "src/topology/builder.rs",
"hunk": "@@ -846,6 +834,7 @@ impl<'a> Builder<'a> ... | true | ||
vectordotdev/vector | 24,627 | comment_to_fix | enhancement(observability): Add transform latency metrics | ```suggestion
// Even though we have a `send_reference` timestamp here, that reference time is when
// the events were enqueued in the `SourceSender`, not when they were pulled out of the
// `rx` stream on this end. Since those times can be quite different (due to blocking
// inherent to... | 7cd3395e3049e1ce53d43e4aaf41415355c77bc4 | 8b48e6856d5fd22c17c59d2a4b5e92e9ea48d069 | diff --git a/src/topology/builder.rs b/src/topology/builder.rs
index bcf2d6a7560cc..0a8e7e2e993c0 100644
--- a/src/topology/builder.rs
+++ b/src/topology/builder.rs
@@ -22,10 +22,11 @@ use vector_lib::{
BufferType, WhenFull,
topology::{
builder::TopologyBuilder,
- channel::{Buf... | [
"src/topology/builder.rs"
] | [
{
"comment": "```suggestion\n // Even though we have a `send_reference` timestamp here, that reference time is when\n // the events were enqueued in the `SourceSender`, not when they were pulled out of the\n // `rx` stream on this end. Since those times can be quite different (due to blocki... | true | ||
vectordotdev/vector | 24,627 | comment_to_fix | enhancement(observability): Add transform latency metrics | Adding an Instant argument to on_send here can also prevent repeated Instant::now calls here if we define `now` before calling `for_each_array_mut` | 7cd3395e3049e1ce53d43e4aaf41415355c77bc4 | 8b48e6856d5fd22c17c59d2a4b5e92e9ea48d069 | diff --git a/src/topology/builder.rs b/src/topology/builder.rs
index bcf2d6a7560cc..0a8e7e2e993c0 100644
--- a/src/topology/builder.rs
+++ b/src/topology/builder.rs
@@ -22,10 +22,11 @@ use vector_lib::{
BufferType, WhenFull,
topology::{
builder::TopologyBuilder,
- channel::{Buf... | [
"src/topology/builder.rs"
] | [
{
"comment": "Adding an Instant argument to on_send here can also prevent repeated Instant::now calls here if we define `now` before calling `for_each_array_mut`",
"path": "src/topology/builder.rs",
"hunk": "@@ -1125,6 +1154,7 @@ impl Runner {\n \n async fn send_outputs(&mut self, outputs_buf: &mut ... | true | ||
vectordotdev/vector | 24,555 | issue_to_patch | enhancement(websocket source): Micro-optimize send loop | ## Summary
Avoid calling `Utc::now()` in a loop and instead use the same timestamp for all the events.
## Vector configuration
<!-- Include Vector configuration(s) you used to test and debug your changes. -->
## How did you test this PR?
Unit tests, the change is pretty trivial.
## Change Type
- [ ] Bu... | 6f6b7ab07af4f4256d272bb8f1910027df98b195 | 64263c83fc71a6c39f4e79403f215ee9f294c3f5 | diff --git a/changelog.d/optimize-websocket-source.enhancement.md b/changelog.d/optimize-websocket-source.enhancement.md
new file mode 100644
index 0000000000000..9745ed1ebc329
--- /dev/null
+++ b/changelog.d/optimize-websocket-source.enhancement.md
@@ -0,0 +1,3 @@
+Small optimization to the `websocket` source performa... | [
"changelog.d/optimize-websocket-source.enhancement.md",
"src/sources/websocket/source.rs"
] | [] | true | ||
vectordotdev/vector | 24,497 | issue_to_patch | enhancement(observability)!: Expand internal histogram precision | ## Summary
With the introduction of internal timing measurements in seconds as histograms, the lower bound of 2^-6 (~15ms) in the internal histogram storage is no longer precise enough to properly capture the required measurements. This change extends the smallest bucket down to 2^-12 (~244us), which is the inverse ... | 6fa2b12a04d18eaa61f3d4d985884f933fb3f1c4 | 0f75f5af71888cfcea63d17191b2826e99fb8336 | diff --git a/changelog.d/expand-internal-histogram-precision.breaking.md b/changelog.d/expand-internal-histogram-precision.breaking.md
new file mode 100644
index 0000000000000..47bfb31245e3a
--- /dev/null
+++ b/changelog.d/expand-internal-histogram-precision.breaking.md
@@ -0,0 +1,5 @@
+Increased the number of buckets ... | [
"changelog.d/expand-internal-histogram-precision.breaking.md",
"lib/vector-core/src/metrics/storage.rs",
"src/sources/internal_metrics.rs"
] | [] | true | ||
vectordotdev/vector | 24,493 | issue_to_patch | enhancement(observability): Standardize buffer size metric names | ## Summary
Many of the buffer size metric names have been specified (in `docs/specs/buffer.md`) in a way that conflicts with the metric naming specification (in `docs/specs/instrumentation.md`). In particular, the latter specifies that metric names should end with a unit (ex `_bytes` or `_events`) but the former pla... | 0091dadf96d09cd7baefb1e712e1343563645690 | f8f8cdead960674283fcb23b8043f70f99f14d37 | diff --git a/changelog.d/buffer_size_metrics.deprecation.md b/changelog.d/buffer_size_metrics.deprecation.md
new file mode 100644
index 0000000000000..dd58c8f53bd27
--- /dev/null
+++ b/changelog.d/buffer_size_metrics.deprecation.md
@@ -0,0 +1,10 @@
+Buffers now emit metric names for sizes that better follow the metric ... | [
"changelog.d/buffer_size_metrics.deprecation.md",
"docs/DEPRECATION.md",
"docs/DEPRECATIONS.md",
"docs/specs/buffer.md",
"lib/vector-buffers/src/internal_events.rs",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-core/src/source_sender/tests.rs",
"src/test_util/components.rs",... | [
{
"comment": "Thanks for updating these links and this doc.",
"path": "docs/DEPRECATION.md",
"hunk": "@@ -80,7 +80,7 @@ When introducing a deprecation into Vector, the pull request introducing the dep\n the new name will be appended with the text `(formerly OldName)`.\n - Add a log message to Vector t... | diff --git a/docs/specs/buffer.md b/docs/specs/buffer.md
index 152f14ad56215..05d343a4bc0bc 100644
--- a/docs/specs/buffer.md
+++ b/docs/specs/buffer.md
@@ -42,8 +42,8 @@ _All buffers_ MUST emit a `BufferCreated` event upon creation. To avoid stale me
- `max_size_bytes` - the max size of the buffer in bytes if relev... | true | |
vectordotdev/vector | 24,493 | comment_to_fix | enhancement(observability): Standardize buffer size metric names | Thanks for updating these links and this doc. | 0091dadf96d09cd7baefb1e712e1343563645690 | f8f8cdead960674283fcb23b8043f70f99f14d37 | diff --git a/docs/DEPRECATION.md b/docs/DEPRECATION.md
index 3b4a5d8c576c5..23ef97ec2c475 100644
--- a/docs/DEPRECATION.md
+++ b/docs/DEPRECATION.md
@@ -68,8 +68,8 @@ When possible, Vector will error at start-up when a removed configuration option
When introducing a deprecation into Vector, the pull request introduc... | [
"docs/DEPRECATION.md"
] | [
{
"comment": "Thanks for updating these links and this doc.",
"path": "docs/DEPRECATION.md",
"hunk": "@@ -80,7 +80,7 @@ When introducing a deprecation into Vector, the pull request introducing the dep\n the new name will be appended with the text `(formerly OldName)`.\n - Add a log message to Vector t... | true | ||
vectordotdev/vector | 24,493 | comment_to_fix | enhancement(observability): Standardize buffer size metric names | Nice 👍 I can't actually see where this is rendered in the website though. If you add `website` to the branch name you should get a deploy preview.
I'll try to run the website locally to validate. | 0091dadf96d09cd7baefb1e712e1343563645690 | f8f8cdead960674283fcb23b8043f70f99f14d37 | diff --git a/website/cue/reference/components.cue b/website/cue/reference/components.cue
index 7d264e557ac23..2ce873c95501e 100644
--- a/website/cue/reference/components.cue
+++ b/website/cue/reference/components.cue
@@ -469,8 +469,12 @@ components: {
}
#MetricOutput: [Name=string]: {
- description: strin... | [
"website/cue/reference/components.cue"
] | [
{
"comment": "Nice 👍 I can't actually see where this is rendered in the website though. If you add `website` to the branch name you should get a deploy preview.\r\n\r\nI'll try to run the website locally to validate.",
"path": "website/cue/reference/components.cue",
"hunk": "@@ -469,8 +469,12 @@ compo... | true | ||
vectordotdev/vector | 24,493 | comment_to_fix | enhancement(observability): Standardize buffer size metric names | ```suggestion
```
I think these snuck in from your other PR. | 0091dadf96d09cd7baefb1e712e1343563645690 | f8f8cdead960674283fcb23b8043f70f99f14d37 | diff --git a/website/cue/reference/components/transforms.cue b/website/cue/reference/components/transforms.cue
index 3ad19224ce34b..6c907ecc7a649 100644
--- a/website/cue/reference/components/transforms.cue
+++ b/website/cue/reference/components/transforms.cue
@@ -20,8 +20,10 @@ components: transforms: [Name=string]: {... | [
"website/cue/reference/components/transforms.cue"
] | [
{
"comment": "```suggestion\r\n```\r\n\r\nI think these snuck in from your other PR.",
"path": "website/cue/reference/components/transforms.cue",
"hunk": "@@ -13,18 +13,22 @@ components: transforms: [Name=string]: {\n \tconfiguration: generated.components.transforms.configuration\n \n \ttelemetry: metri... | true | ||
vectordotdev/vector | 24,493 | comment_to_fix | enhancement(observability): Standardize buffer size metric names | When we write up the release notes for v0.53.0, this can get moved to the "To be removed" section with a future version. | 0091dadf96d09cd7baefb1e712e1343563645690 | f8f8cdead960674283fcb23b8043f70f99f14d37 | diff --git a/docs/DEPRECATIONS.md b/docs/DEPRECATIONS.md
index 7c9042da1a70a..e43d70d493d3d 100644
--- a/docs/DEPRECATIONS.md
+++ b/docs/DEPRECATIONS.md
@@ -15,6 +15,7 @@ For example:
## To be deprecated
- `v0.50.0` | `http-server-encoding` | The `encoding` field will be removed. Use `decoding` and `framing` instea... | [
"docs/DEPRECATIONS.md"
] | [
{
"comment": "When we write up the release notes for v0.53.0, this can get moved to the \"To be removed\" section with a future version.",
"path": "docs/DEPRECATIONS.md",
"hunk": "@@ -15,6 +15,7 @@ For example:\n ## To be deprecated\n \n - `v0.50.0` | `http-server-encoding` | The `encoding` field will b... | true | ||
vectordotdev/vector | 24,481 | issue_to_patch | enhancement(observability): Add metrics to measure total event processing time | ## Summary
This is a combination of two major changes:
1. We want to record the time at which events are ingested in order to track
latency as each travels through the topology. This is currently recorded for log
events using the Vector namespace in the `vector.ingest_timestamp` metadata
field, but we want it ... | a3bb693380ea7f7217737661b082521c5bc31a8e | 69bae9a5a32417df0f6575a81408396e36067a66 | diff --git a/Cargo.lock b/Cargo.lock
index 3d2d9ef2e2617..126d9201da048 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -12657,6 +12657,7 @@ dependencies = [
"console-subscriber",
"criterion",
"csv",
+ "dashmap",
"databend-client",
"deadpool",
"derivative",
diff --git a/Cargo.toml b/Cargo.toml
index 03be659ba98... | [
"Cargo.lock",
"Cargo.toml",
"changelog.d/event_processing_time_metrics.enhancement.md",
"docs/tutorials/lognamespacing.md",
"lib/vector-buffers/src/lib.rs",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-buffers/src/topology/channel/mod.rs",
"lib/vector-buffers/src/topology/ch... | [
{
"comment": "```suggestion\r\nThe ingest timestamp should be recorded on the event metadata using\r\n`log.metadata_mut().set_ingest_timestamp(chrono::Utc::now())`. The source type will be\r\n```",
"path": "docs/tutorials/lognamespacing.md",
"hunk": "@@ -112,7 +112,8 @@ separate namespace to the event d... | diff --git a/src/test_util/mock/mod.rs b/src/test_util/mock/mod.rs
index daf0fee5927da..01e2c6fb307b6 100644
--- a/src/test_util/mock/mod.rs
+++ b/src/test_util/mock/mod.rs
@@ -10,14 +10,16 @@ use vector_lib::{
use self::{
sinks::{
- BackpressureSinkConfig, BasicSinkConfig, ErrorSinkConfig, OneshotSinkCo... | true | |
vectordotdev/vector | 24,481 | comment_to_fix | enhancement(observability): Add metrics to measure total event processing time | ```suggestion
The ingest timestamp should be recorded on the event metadata using
`log.metadata_mut().set_ingest_timestamp(chrono::Utc::now())`. The source type will be
``` | a3bb693380ea7f7217737661b082521c5bc31a8e | 69bae9a5a32417df0f6575a81408396e36067a66 | diff --git a/docs/tutorials/lognamespacing.md b/docs/tutorials/lognamespacing.md
index de23447f796b7..ed4d0cd3a0993 100644
--- a/docs/tutorials/lognamespacing.md
+++ b/docs/tutorials/lognamespacing.md
@@ -112,7 +112,9 @@ separate namespace to the event data.
The actual value to be placed into the field.
-For the i... | [
"docs/tutorials/lognamespacing.md"
] | [
{
"comment": "```suggestion\r\nThe ingest timestamp should be recorded on the event metadata using\r\n`log.metadata_mut().set_ingest_timestamp(chrono::Utc::now())`. The source type will be\r\n```",
"path": "docs/tutorials/lognamespacing.md",
"hunk": "@@ -112,7 +112,8 @@ separate namespace to the event d... | true | ||
vectordotdev/vector | 24,481 | comment_to_fix | enhancement(observability): Add metrics to measure total event processing time | I'm worried the removal of `now` is creating a bit of an anti-pattern where `log.metadata_mut().set_ingest_timestamp(now)` *needs* to be called every time before `insert_standard_vector_source_metadata`.
Since we're already getting `&mut LogEvent` here, wouldn't it be better to have something like so:
```rs
... | a3bb693380ea7f7217737661b082521c5bc31a8e | 69bae9a5a32417df0f6575a81408396e36067a66 | diff --git a/lib/vector-core/src/config/mod.rs b/lib/vector-core/src/config/mod.rs
index c86848d7b0be5..9969fb670eebf 100644
--- a/lib/vector-core/src/config/mod.rs
+++ b/lib/vector-core/src/config/mod.rs
@@ -503,6 +503,7 @@ impl LogNamespace {
path!("source_type"),
Bytes::from_static(source_n... | [
"lib/vector-core/src/config/mod.rs"
] | [
{
"comment": "I'm worried the removal of `now` is creating a bit of an anti-pattern where `log.metadata_mut().set_ingest_timestamp(now)` *needs* to be called every time before `insert_standard_vector_source_metadata`.\r\n\r\nSince we're already getting `&mut LogEvent` here, wouldn't it be better to have somethi... | true | ||
vectordotdev/vector | 24,481 | comment_to_fix | enhancement(observability): Add metrics to measure total event processing time | This is nice and we can maybe expand it later if needed to be an array of "hooks" 👍 | a3bb693380ea7f7217737661b082521c5bc31a8e | 69bae9a5a32417df0f6575a81408396e36067a66 | diff --git a/lib/vector-buffers/src/topology/channel/sender.rs b/lib/vector-buffers/src/topology/channel/sender.rs
index e68b868e042e7..0a7116f8ceea9 100644
--- a/lib/vector-buffers/src/topology/channel/sender.rs
+++ b/lib/vector-buffers/src/topology/channel/sender.rs
@@ -8,7 +8,7 @@ use vector_common::internal_event::... | [
"lib/vector-buffers/src/topology/channel/sender.rs"
] | [
{
"comment": "This is nice and we can maybe expand it later if needed to be an array of \"hooks\" 👍 ",
"path": "lib/vector-buffers/src/topology/channel/sender.rs",
"hunk": "@@ -134,9 +134,11 @@ pub struct BufferSender<T: Bufferable> {\n base: SenderAdapter<T>,\n overflow: Option<Box<BufferSende... | true | ||
vectordotdev/vector | 24,481 | comment_to_fix | enhancement(observability): Add metrics to measure total event processing time | Is it possible to assert that the value falls within a certain range here? Not necessarily on this test, but if we have a separate test that runs exactly for 5 seconds (or something like that) and we have something like a throttle transform, we could assert that the `event_processing_time_mean_seconds` would be a certa... | a3bb693380ea7f7217737661b082521c5bc31a8e | 69bae9a5a32417df0f6575a81408396e36067a66 | diff --git a/src/topology/test/processing_time.rs b/src/topology/test/processing_time.rs
new file mode 100644
index 0000000000000..7f8e557c9571e
--- /dev/null
+++ b/src/topology/test/processing_time.rs
@@ -0,0 +1,108 @@
+use std::time::Instant;
+use tokio::{
+ sync::oneshot,
+ time::{Duration, timeout},
+};
+use ... | [
"src/topology/test/processing_time.rs"
] | [
{
"comment": "Is it possible to assert that the value falls within a certain range here? Not necessarily on this test, but if we have a separate test that runs exactly for 5 seconds (or something like that) and we have something like a throttle transform, we could assert that the `event_processing_time_mean_sec... | true | ||
vectordotdev/vector | 24,467 | issue_to_patch | enhancement(observability): Add configuration for buffer utilization EWMA alpha | ## Summary
Adds a `buffer_utilization_ewma_alpha` configuration option to the global options, allowing users to control the alpha value for the exponentially weighted moving average (EWMA) used in source and transform buffer utilization metrics.
Follow-up to #24453
## Vector configuration
<!-- Include Vector... | a5a6b5e82f3000c3d1284c8a88a7577806b3ef1d | 34e38cbe533b9f8f283ecfb7ad7d965023137bbf | diff --git a/changelog.d/utilization_ewma_alpha_configuration.enhancement.md b/changelog.d/utilization_ewma_alpha_configuration.enhancement.md
new file mode 100644
index 0000000000000..1f5c84bb9f515
--- /dev/null
+++ b/changelog.d/utilization_ewma_alpha_configuration.enhancement.md
@@ -0,0 +1,6 @@
+Added `buffer_utiliz... | [
"changelog.d/utilization_ewma_alpha_configuration.enhancement.md",
"lib/vector-buffers/src/topology/builder.rs",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-buffers/src/topology/channel/mod.rs",
"lib/vector-buffers/src/variants/in_memory.rs",
"lib/vector-core/src/config/global_... | [
{
"comment": "This doesn't have to be addressed in this PR:\r\n\r\nI don't think that `#[configurable(validation` is doing much here since we also have `check_buffer_utilization_ewma_alpha`. I think that if we added something like `inclusive = false` to `range` (so we'd get something like `#[configurable(valida... | diff --git a/src/test_util/mock/sources/basic.rs b/src/test_util/mock/sources/basic.rs
index 614f5f7387d43..c1c09477fcc38 100644
--- a/src/test_util/mock/sources/basic.rs
+++ b/src/test_util/mock/sources/basic.rs
@@ -46,7 +46,7 @@ pub struct BasicSourceConfig {
impl Default for BasicSourceConfig {
fn default() ->... | true | |
vectordotdev/vector | 24,467 | comment_to_fix | enhancement(observability): Add configuration for buffer utilization EWMA alpha | This doesn't have to be addressed in this PR:
I don't think that `#[configurable(validation` is doing much here since we also have `check_buffer_utilization_ewma_alpha`. I think that if we added something like `inclusive = false` to `range` (so we'd get something like `#[configurable(validation(range(min = 0.0, max ... | a5a6b5e82f3000c3d1284c8a88a7577806b3ef1d | 34e38cbe533b9f8f283ecfb7ad7d965023137bbf | diff --git a/lib/vector-core/src/config/global_options.rs b/lib/vector-core/src/config/global_options.rs
index e789e8ae973ab..93ad1d80f5934 100644
--- a/lib/vector-core/src/config/global_options.rs
+++ b/lib/vector-core/src/config/global_options.rs
@@ -140,6 +140,19 @@ pub struct GlobalOptions {
#[serde(skip_seria... | [
"lib/vector-core/src/config/global_options.rs"
] | [
{
"comment": "This doesn't have to be addressed in this PR:\r\n\r\nI don't think that `#[configurable(validation` is doing much here since we also have `check_buffer_utilization_ewma_alpha`. I think that if we added something like `inclusive = false` to `range` (so we'd get something like `#[configurable(valida... | true | ||
vectordotdev/vector | 24,467 | comment_to_fix | enhancement(observability): Add configuration for buffer utilization EWMA alpha | This is incorrectly removing the doc comment from the next function | a5a6b5e82f3000c3d1284c8a88a7577806b3ef1d | 34e38cbe533b9f8f283ecfb7ad7d965023137bbf | diff --git a/src/config/validation.rs b/src/config/validation.rs
index 0878eedd5948a..0b629ea9088a6 100644
--- a/src/config/validation.rs
+++ b/src/config/validation.rs
@@ -11,6 +11,14 @@ use super::{
};
use crate::config::schema;
+/// Minimum value (exclusive) for `utilization_ewma_alpha`.
+/// The alpha value mus... | [
"src/config/validation.rs"
] | [
{
"comment": "This is incorrectly removing the doc comment from the next function",
"path": "src/config/validation.rs",
"hunk": "@@ -147,8 +155,20 @@ pub fn check_resources(config: &ConfigBuilder) -> Result<(), Vec<String>> {\n }\n }\n \n-/// To avoid collisions between `output` metric tags, check t... | true | ||
vectordotdev/vector | 24,453 | issue_to_patch | enhancement(observability): Add `_utilization_mean` buffer metrics | ## Summary
The source and transform buffer utilization metrics currently measure either the
instantaneous level or a histogram, neither of which is a reliable single-valued
reflection of the actual status. For this purpose, we introduce a `mean` metric
that uses the EWMA calculations to produce a simple moving av... | 236928a042a71db77b050d5afbb392ad5d4e6cdc | 75e82439f8b64e18e782142dcbcf6a90215dd701 | diff --git a/changelog.d/buffer_utilization_mean_metrics.enhancement.md b/changelog.d/buffer_utilization_mean_metrics.enhancement.md
new file mode 100644
index 0000000000000..3a88daa924c48
--- /dev/null
+++ b/changelog.d/buffer_utilization_mean_metrics.enhancement.md
@@ -0,0 +1,3 @@
+Added moving-mean gauges for source... | [
"changelog.d/buffer_utilization_mean_metrics.enhancement.md",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-common/src/atomic.rs",
"lib/vector-common/src/lib.rs",
"lib/vector-common/src/stats.rs",
"lib/vector-core/src/metrics/recency.rs",
"lib/vector-core/src/metrics/storage.rs... | [
{
"comment": "```suggestion\r\n\t\t\tdescription: \"The mean utilization level of the buffer. The outputs of the source send data to this buffer. The mean utilization is smoothed over time using an exponentially weighted moving average (EWMA).\"\r\n```",
"path": "website/cue/reference/components/sourc... | true | ||
vectordotdev/vector | 24,453 | comment_to_fix | enhancement(observability): Add `_utilization_mean` buffer metrics | ```suggestion
description: "The mean utilization level of the buffer. The outputs of the source send data to this buffer. The mean utilization is smoothed over time using an exponentially weighted moving average (EWMA)."
``` | 236928a042a71db77b050d5afbb392ad5d4e6cdc | 75e82439f8b64e18e782142dcbcf6a90215dd701 | diff --git a/website/cue/reference/components/sources/internal_metrics.cue b/website/cue/reference/components/sources/internal_metrics.cue
index da94e39ecf645..d24a3dc22b8bd 100644
--- a/website/cue/reference/components/sources/internal_metrics.cue
+++ b/website/cue/reference/components/sources/internal_metrics.cue
@@ ... | [
"website/cue/reference/components/sources/internal_metrics.cue"
] | [
{
"comment": "```suggestion\r\n\t\t\tdescription: \"The mean utilization level of the buffer. The outputs of the source send data to this buffer. The mean utilization is smoothed over time using an exponentially weighted moving average (EWMA).\"\r\n```",
"path": "website/cue/reference/components/sourc... | true | ||
vectordotdev/vector | 24,329 | issue_to_patch | enhancement(transforms): Add internal metric to record buffer utilization | ## Summary
This builds on the work in #24272 and adds support for transform buffer utilization. Since these are input buffers they omit the `output` label used by the buffers created by the source senders.
## Vector configuration
N/A
## How did you test this PR?
Ran a quick test dumping internal metrics ... | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/changelog.d/transform-buffer-utilization-metric.enhancement.md b/changelog.d/transform-buffer-utilization-metric.enhancement.md
new file mode 100644
index 0000000000000..10242092c8956
--- /dev/null
+++ b/changelog.d/transform-buffer-utilization-metric.enhancement.md
@@ -0,0 +1,8 @@
+Added metrics to record... | [
"changelog.d/transform-buffer-utilization-metric.enhancement.md",
"lib/vector-buffers/src/topology/builder.rs",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-buffers/src/topology/channel/mod.rs",
"lib/vector-buffers/src/topology/channel/tests.rs",
"lib/vector-buffers/src/topology... | [
{
"comment": "Nit: This code is fine but is a bit duplicated. Wonder if it could be simplified a bit. I haven't checked the implementation of histogram/gauge macros, maybe it's not feasible or would produce messier code (don't spend too much time on this 😄)",
"path": "lib/vector-buffers/src/topology/chann... | diff --git a/lib/vector-buffers/src/topology/test_util.rs b/lib/vector-buffers/src/topology/test_util.rs
index 89ae4917af3aa..684aecc977764 100644
--- a/lib/vector-buffers/src/topology/test_util.rs
+++ b/lib/vector-buffers/src/topology/test_util.rs
@@ -137,7 +137,7 @@ impl error::Error for BasicError {}
/// If `mode` ... | true | |
vectordotdev/vector | 24,329 | comment_to_fix | enhancement(transforms): Add internal metric to record buffer utilization | Nit: This code is fine but is a bit duplicated. Wonder if it could be simplified a bit. I haven't checked the implementation of histogram/gauge macros, maybe it's not feasible or would produce messier code (don't spend too much time on this 😄) | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/lib/vector-buffers/src/topology/channel/limited_queue.rs b/lib/vector-buffers/src/topology/channel/limited_queue.rs
index f6fb80f8ecac9..54264e06afe60 100644
--- a/lib/vector-buffers/src/topology/channel/limited_queue.rs
+++ b/lib/vector-buffers/src/topology/channel/limited_queue.rs
@@ -8,6 +8,9 @@ use std... | [
"lib/vector-buffers/src/topology/channel/limited_queue.rs"
] | [
{
"comment": "Nit: This code is fine but is a bit duplicated. Wonder if it could be simplified a bit. I haven't checked the implementation of histogram/gauge macros, maybe it's not feasible or would produce messier code (don't spend too much time on this 😄)",
"path": "lib/vector-buffers/src/topology/chann... | true | ||
vectordotdev/vector | 24,329 | comment_to_fix | enhancement(transforms): Add internal metric to record buffer utilization | If I'm understanding this correctly only one of these two are going to exist but never both for the same component right? | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/src/test_util/components.rs b/src/test_util/components.rs
index 86a7b0defee25..8ef396b6c60cc 100644
--- a/src/test_util/components.rs
+++ b/src/test_util/components.rs
@@ -65,12 +65,36 @@ pub const HTTP_SINK_TAGS: [&str; 2] = ["endpoint", "protocol"];
/// The standard set of tags for all `AWS`-based sinks... | [
"src/test_util/components.rs"
] | [
{
"comment": "If I'm understanding this correctly only one of these two are going to exist but never both for the same component right?",
"path": "src/test_util/components.rs",
"hunk": "@@ -65,12 +65,36 @@ pub const HTTP_SINK_TAGS: [&str; 2] = [\"endpoint\", \"protocol\"];\n /// The standard set of tags... | true | ||
vectordotdev/vector | 24,329 | comment_to_fix | enhancement(transforms): Add internal metric to record buffer utilization | Why was this changed? | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/src/topology/builder.rs b/src/topology/builder.rs
index ffc8041a70724..0620ec7206623 100644
--- a/src/topology/builder.rs
+++ b/src/topology/builder.rs
@@ -22,7 +22,7 @@ use vector_lib::{
BufferType, WhenFull,
topology::{
builder::TopologyBuilder,
- channel::{Buffe... | [
"src/topology/builder.rs"
] | [
{
"comment": "Why was this changed?",
"path": "src/topology/builder.rs",
"hunk": "@@ -470,6 +471,7 @@ impl<'a> Builder<'a> {\n component_id = %key.id(),\n component_type = %transform.inner.get_component_name(),\n );\n+ let _span = span.enter();",
... | true | ||
vectordotdev/vector | 24,329 | comment_to_fix | enhancement(transforms): Add internal metric to record buffer utilization | This is new. Would the tests work before this PR if `max_event_size` were added to `SOURCE_SENDER_BUFFER_METRICS`? I assume so, but if not then we have a bug somewhere | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/src/test_util/components.rs b/src/test_util/components.rs
index 86a7b0defee25..8ef396b6c60cc 100644
--- a/src/test_util/components.rs
+++ b/src/test_util/components.rs
@@ -65,12 +65,36 @@ pub const HTTP_SINK_TAGS: [&str; 2] = ["endpoint", "protocol"];
/// The standard set of tags for all `AWS`-based sinks... | [
"src/test_util/components.rs"
] | [
{
"comment": "This is new. Would the tests work before this PR if `max_event_size` were added to `SOURCE_SENDER_BUFFER_METRICS`? I assume so, but if not then we have a bug somewhere",
"path": "src/test_util/components.rs",
"hunk": "@@ -65,12 +65,36 @@ pub const HTTP_SINK_TAGS: [&str; 2] = [\"endpoint\",... | true | ||
vectordotdev/vector | 24,329 | comment_to_fix | enhancement(transforms): Add internal metric to record buffer utilization | Should this have been changed? | 3eae9314d1ed3f80d1c1db6ba8ede1e4ccb7183d | 36219bda985325f6252c2ec4eb5e7458ae630c17 | diff --git a/src/config/diff.rs b/src/config/diff.rs
index 3ecef90ca0174..ebedf3c73d5c3 100644
--- a/src/config/diff.rs
+++ b/src/config/diff.rs
@@ -225,7 +225,7 @@ fn extract_table_component_keys(
.collect()
}
-#[cfg(test)]
+#[cfg(all(test, feature = "enrichment-tables-memory"))]
mod tests {
use crat... | [
"src/config/diff.rs"
] | [
{
"comment": "Should this have been changed?",
"path": "src/config/diff.rs",
"hunk": "@@ -225,7 +225,7 @@ fn extract_table_component_keys(\n .collect()\n }\n \n-#[cfg(test)]\n+#[cfg(all(test, feature = \"enrichment-tables-memory\"))]",
"resolving_sha": "36219bda985325f6252c2ec4eb5e7458ae630c... | true | ||
vectordotdev/vector | 24,272 | issue_to_patch | enhancement(sources): Add internal metric to record source buffer utilization | ## Summary
Added a metric to record the utilization level of the buffer that all sources send into. This new metric is called `source_sender_buffer_utilization`.
## Vector configuration
<!-- Include Vector configuration(s) you used to test and debug your changes. -->
## How did you test this PR?
PR include... | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/changelog.d/source-sender-utilization-metric.enhancement.md b/changelog.d/source-sender-utilization-metric.enhancement.md
new file mode 100644
index 0000000000000..8ad76d9c1af8a
--- /dev/null
+++ b/changelog.d/source-sender-utilization-metric.enhancement.md
@@ -0,0 +1,9 @@
+Added the following metrics to r... | [
"changelog.d/source-sender-utilization-metric.enhancement.md",
"lib/vector-buffers/src/topology/channel/limited_queue.rs",
"lib/vector-buffers/src/variants/in_memory.rs",
"lib/vector-core/src/source_sender/output.rs",
"lib/vector-core/src/source_sender/tests.rs",
"src/test_util/components.rs",
"src/test... | [
{
"comment": "```suggestion\r\n\t\t\tdescription: \"The utilization level of the buffer that the component's inputs send into.\"\r\n```\r\n\r\nThe wording here makes me think that it is a shared buffer for all sources; which I don't think is true? I thought it was one input buffer per component.",
"pa... | diff --git a/src/test_util/components.rs b/src/test_util/components.rs
index 822de8d007110..86a7b0defee25 100644
--- a/src/test_util/components.rs
+++ b/src/test_util/components.rs
@@ -7,10 +7,11 @@
//! internal events and metrics, and testing that they fit the required
//! patterns.
-use std::{env, sync::LazyLock,... | true | |
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | ```suggestion
description: "The utilization level of the buffer that the component's inputs send into."
```
The wording here makes me think that it is a shared buffer for all sources; which I don't think is true? I thought it was one input buffer per component. | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/website/cue/reference/components/sources/internal_metrics.cue b/website/cue/reference/components/sources/internal_metrics.cue
index 2acd6c2bfbc28..d03036431acf2 100644
--- a/website/cue/reference/components/sources/internal_metrics.cue
+++ b/website/cue/reference/components/sources/internal_metrics.cue
@@ ... | [
"website/cue/reference/components/sources/internal_metrics.cue"
] | [
{
"comment": "```suggestion\r\n\t\t\tdescription: \"The utilization level of the buffer that the component's inputs send into.\"\r\n```\r\n\r\nThe wording here makes me think that it is a shared buffer for all sources; which I don't think is true? I thought it was one input buffer per component.",
"pa... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | ```suggestion
Added the `source_sender_buffer_utilization` metric to record the utilization level of the buffer that all sources send into.
``` | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/changelog.d/source-sender-utilization-metric.enhancement.md b/changelog.d/source-sender-utilization-metric.enhancement.md
new file mode 100644
index 0000000000000..8ad76d9c1af8a
--- /dev/null
+++ b/changelog.d/source-sender-utilization-metric.enhancement.md
@@ -0,0 +1,9 @@
+Added the following metrics to r... | [
"changelog.d/source-sender-utilization-metric.enhancement.md"
] | [
{
"comment": "```suggestion\nAdded the `source_sender_buffer_utilization` metric to record the utilization level of the buffer that all sources send into.\n```",
"path": "changelog.d/source-sender-utilization-metric.enhancement.md",
"hunk": "@@ -0,0 +1,4 @@\n+Added a metric to record the utilization lev... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | Can this ever underflow? | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/lib/vector-buffers/src/topology/channel/limited_queue.rs b/lib/vector-buffers/src/topology/channel/limited_queue.rs
index 4320936cec750..f6fb80f8ecac9 100644
--- a/lib/vector-buffers/src/topology/channel/limited_queue.rs
+++ b/lib/vector-buffers/src/topology/channel/limited_queue.rs
@@ -11,6 +11,7 @@ use s... | [
"lib/vector-buffers/src/topology/channel/limited_queue.rs"
] | [
{
"comment": "Can this ever underflow?",
"path": "lib/vector-buffers/src/topology/channel/limited_queue.rs",
"hunk": "@@ -139,23 +212,22 @@ impl<T: InMemoryBufferable> LimitedSender<T> {\n /// with the given `item`.\n pub async fn send(&mut self, item: T) -> Result<(), SendError<T>> {\n ... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | ```suggestion
.map_err(|_| SendError(item))?;
self.inner.send_with_permit(in_use + count, permits, item);
trace!("Sent item.");
Ok(())
```
optional nit | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/lib/vector-buffers/src/topology/channel/limited_queue.rs b/lib/vector-buffers/src/topology/channel/limited_queue.rs
index 4320936cec750..f6fb80f8ecac9 100644
--- a/lib/vector-buffers/src/topology/channel/limited_queue.rs
+++ b/lib/vector-buffers/src/topology/channel/limited_queue.rs
@@ -11,6 +11,7 @@ use s... | [
"lib/vector-buffers/src/topology/channel/limited_queue.rs"
] | [
{
"comment": "```suggestion\n .map_err(|_| SendError(item))?;\n self.inner.send_with_permit(in_use + count, permits, item);\n trace!(\"Sent item.\");\n Ok(())\n```\n\noptional nit",
"path": "lib/vector-buffers/src/topology/channel/limited_queue.rs",
"hunk": "@@ -139,23 +212,22 @@ impl<T:... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | ```suggestion
let permits = match self
```
part of the other code suggestion | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/lib/vector-buffers/src/topology/channel/limited_queue.rs b/lib/vector-buffers/src/topology/channel/limited_queue.rs
index 4320936cec750..f6fb80f8ecac9 100644
--- a/lib/vector-buffers/src/topology/channel/limited_queue.rs
+++ b/lib/vector-buffers/src/topology/channel/limited_queue.rs
@@ -11,6 +11,7 @@ use s... | [
"lib/vector-buffers/src/topology/channel/limited_queue.rs"
] | [
{
"comment": "```suggestion\n let permits = match self\n```\n\npart of the other code suggestion",
"path": "lib/vector-buffers/src/topology/channel/limited_queue.rs",
"hunk": "@@ -139,23 +212,22 @@ impl<T: InMemoryBufferable> LimitedSender<T> {\n /// with the given `item`.\n pub async fn ... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | underflow possible? | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/lib/vector-buffers/src/topology/channel/limited_queue.rs b/lib/vector-buffers/src/topology/channel/limited_queue.rs
index 4320936cec750..f6fb80f8ecac9 100644
--- a/lib/vector-buffers/src/topology/channel/limited_queue.rs
+++ b/lib/vector-buffers/src/topology/channel/limited_queue.rs
@@ -11,6 +11,7 @@ use s... | [
"lib/vector-buffers/src/topology/channel/limited_queue.rs"
] | [
{
"comment": "underflow possible?",
"path": "lib/vector-buffers/src/topology/channel/limited_queue.rs",
"hunk": "@@ -172,28 +244,24 @@ impl<T: InMemoryBufferable> LimitedSender<T> {\n /// Will panic if adding ack amount overflows.\n pub fn try_send(&mut self, item: T) -> Result<(), TrySendError<... | true | ||
vectordotdev/vector | 24,272 | comment_to_fix | enhancement(sources): Add internal metric to record source buffer utilization | Most of these are actually missing from the changelog. | 870b86ffe1c1c8c609a2b7c4532a9836166392cd | 69fd96ff2fbf6f0522931ef4cc180a067e7c1fad | diff --git a/website/cue/reference/components/sources/internal_metrics.cue b/website/cue/reference/components/sources/internal_metrics.cue
index 2acd6c2bfbc28..d03036431acf2 100644
--- a/website/cue/reference/components/sources/internal_metrics.cue
+++ b/website/cue/reference/components/sources/internal_metrics.cue
@@ ... | [
"website/cue/reference/components/sources/internal_metrics.cue"
] | [
{
"comment": "Most of these are actually missing from the changelog.",
"path": "website/cue/reference/components/sources/internal_metrics.cue",
"hunk": "@@ -718,6 +718,38 @@ components: sources: internal_metrics: {\n \t\t\tdefault_namespace: \"vector\"\n \t\t\ttags: _component_tags\n \t\t}\... | true | ||
vectordotdev/vector | 24,245 | issue_to_patch | enhancement(datadog_agent source): Add request timeout support | ## Summary
This change adds support for a configurable `send_timeout_secs` option to the `datadog_agent` source. When configured, the source will reject requests with a HTTP 503 response code after the configured time when the downstream buffer cannot accept the new events in time. It defaults to no timeout, preserv... | 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/changelog.d/datadog-agent-timeout.enhancement.md b/changelog.d/datadog-agent-timeout.enhancement.md
new file mode 100644
index 0000000000000..a93475c1840f9
--- /dev/null
+++ b/changelog.d/datadog-agent-timeout.enhancement.md
@@ -0,0 +1,7 @@
+Added support for configurable request timeouts to the `datadog_a... | [
"changelog.d/datadog-agent-timeout.enhancement.md",
"lib/vector-common/src/internal_event/component_events_timed_out.rs",
"lib/vector-common/src/internal_event/mod.rs",
"lib/vector-core/src/source_sender/builder.rs",
"lib/vector-core/src/source_sender/errors.rs",
"lib/vector-core/src/source_sender/mod.rs"... | [
{
"comment": "## Unrecognized Spelling\n\n[timedout](#security-tab) is not a recognized word. \\(unrecognized-spelling\\)\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/15432)",
"path": "website/cue/reference/components/sources/datadog_agent.cue",
"hunk": "@@ -223,6... | diff --git a/src/test_util/mock/mod.rs b/src/test_util/mock/mod.rs
index 77a3c861c547e..daf0fee5927da 100644
--- a/src/test_util/mock/mod.rs
+++ b/src/test_util/mock/mod.rs
@@ -31,12 +31,12 @@ pub fn backpressure_source(counter: &Arc<AtomicUsize>) -> BackpressureSourceConf
}
pub fn basic_source() -> (SourceSender, ... | true | |
vectordotdev/vector | 24,245 | comment_to_fix | enhancement(datadog_agent source): Add request timeout support | ## Unrecognized Spelling
[timedout](#security-tab) is not a recognized word. \(unrecognized-spelling\)
[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/15432) | 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/website/cue/reference/components/sources/datadog_agent.cue b/website/cue/reference/components/sources/datadog_agent.cue
index 96e841889ab2a..52ac91a375bce 100644
--- a/website/cue/reference/components/sources/datadog_agent.cue
+++ b/website/cue/reference/components/sources/datadog_agent.cue
@@ -220,9 +220,... | [
"website/cue/reference/components/sources/datadog_agent.cue"
] | [
{
"comment": "## Unrecognized Spelling\n\n[timedout](#security-tab) is not a recognized word. \\(unrecognized-spelling\\)\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/15432)",
"path": "website/cue/reference/components/sources/datadog_agent.cue",
"hunk": "@@ -223,6... | true | ||
vectordotdev/vector | 24,245 | comment_to_fix | enhancement(datadog_agent source): Add request timeout support | Let's add another section explaining what happens when this timeout is set.
- Are events dropped?
- Impact on acknowledgements
- Is this recommended for some use case?
| 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/src/sources/datadog_agent/mod.rs b/src/sources/datadog_agent/mod.rs
index 0ee1ee8bd5ac5..ac84188df7c78 100644
--- a/src/sources/datadog_agent/mod.rs
+++ b/src/sources/datadog_agent/mod.rs
@@ -27,6 +27,7 @@ use http::StatusCode;
use hyper::{Server, service::make_service_fn};
use regex::Regex;
use serde::... | [
"src/sources/datadog_agent/mod.rs"
] | [
{
"comment": "Let's add another section explaining what happens when this timeout is set.\r\n\r\n- Are events dropped?\r\n- Impact on acknowledgements\r\n- Is this recommended for some use case?\r\n",
"path": "src/sources/datadog_agent/mod.rs",
"hunk": "@@ -150,6 +153,13 @@ pub struct DatadogAgentConfig... | true | ||
vectordotdev/vector | 24,245 | comment_to_fix | enhancement(datadog_agent source): Add request timeout support | ## Unrecognized Spelling
[timedout](#security-tab) is not a recognized word. \(unrecognized-spelling\)
[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/15452) | 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/website/cue/reference/components/sources/datadog_agent.cue b/website/cue/reference/components/sources/datadog_agent.cue
index 96e841889ab2a..52ac91a375bce 100644
--- a/website/cue/reference/components/sources/datadog_agent.cue
+++ b/website/cue/reference/components/sources/datadog_agent.cue
@@ -220,9 +220,... | [
"website/cue/reference/components/sources/datadog_agent.cue"
] | [
{
"comment": "## Unrecognized Spelling\n\n[timedout](#security-tab) is not a recognized word. \\(unrecognized-spelling\\)\n\n[Show more details](https://github.com/vectordotdev/vector/security/code-scanning/15452)",
"path": "website/cue/reference/components/sources/datadog_agent.cue",
"hunk": "@@ -220,9... | true | ||
vectordotdev/vector | 24,245 | comment_to_fix | enhancement(datadog_agent source): Add request timeout support | ```suggestion
the Agent will eventually time out the request and drop the connection. When that
``` | 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/website/cue/reference/components/sources/datadog_agent.cue b/website/cue/reference/components/sources/datadog_agent.cue
index 96e841889ab2a..52ac91a375bce 100644
--- a/website/cue/reference/components/sources/datadog_agent.cue
+++ b/website/cue/reference/components/sources/datadog_agent.cue
@@ -220,9 +220,... | [
"website/cue/reference/components/sources/datadog_agent.cue"
] | [
{
"comment": "```suggestion\r\n\t\t\t\tthe Agent will eventually time out the request and drop the connection. When that\r\n```",
"path": "website/cue/reference/components/sources/datadog_agent.cue",
"hunk": "@@ -220,9 +220,33 @@ components: sources: datadog_agent: {\n \t\t\t\tduration distribution).\n ... | true | ||
vectordotdev/vector | 24,245 | comment_to_fix | enhancement(datadog_agent source): Add request timeout support | ```suggestion
Added support for configurable request timeouts to the `datadog_agent` source.
This change also introduces two new internal metrics:
- `component_timed_out_events_total` - Counter tracking the number of events that timed out
- `component_timed_out_requests_total` - Counter tracking the number of r... | 8a8f223012fab640035e65533edf3ad94c3cd3d1 | 4d78b40effd2e1f60f85ed70c938bce576e75047 | diff --git a/changelog.d/datadog-agent-timeout.enhancement.md b/changelog.d/datadog-agent-timeout.enhancement.md
new file mode 100644
index 0000000000000..a93475c1840f9
--- /dev/null
+++ b/changelog.d/datadog-agent-timeout.enhancement.md
@@ -0,0 +1,7 @@
+Added support for configurable request timeouts to the `datadog_a... | [
"changelog.d/datadog-agent-timeout.enhancement.md"
] | [
{
"comment": "```suggestion\r\nAdded support for configurable request timeouts to the `datadog_agent` source.\r\n\r\nThis change also introduces two new internal metrics:\r\n\t- `component_timed_out_events_total` - Counter tracking the number of events that timed out\r\n\t- `component_timed_out_requests_total` ... | true | ||
vectordotdev/vector | 23,986 | issue_to_patch | enhancement(datadog_agent source): Add control for metric name splitting | ## Summary
In #13176, the `datadog_agent` source had functionality introduced to automatically split the metric series name into namespace and name components on the first period in that name. This change was done to address #12953 where a default namespace was configured being applied to a metrics sink, resulting ... | 64cb8fa7af4e67f7df30713654bbd3cdab7869ad | c37daa1af90ec86e845cf307b9a67672a28900bd | diff --git a/changelog.d/23986_datadog_agent_split_metric_namespace.enhancement.md b/changelog.d/23986_datadog_agent_split_metric_namespace.enhancement.md
new file mode 100644
index 0000000000000..dbd70462c4bc0
--- /dev/null
+++ b/changelog.d/23986_datadog_agent_split_metric_namespace.enhancement.md
@@ -0,0 +1,4 @@
+Ad... | [
"changelog.d/23986_datadog_agent_split_metric_namespace.enhancement.md",
"src/sources/datadog_agent/metrics.rs",
"src/sources/datadog_agent/mod.rs",
"src/sources/datadog_agent/tests.rs",
"website/cue/reference/components/sources/generated/datadog_agent.cue"
] | [] | true | ||
vectordotdev/vector | 21,669 | issue_to_patch | chore(config): log component graph when there's an error | <!--
Your PR title must conform to the conventional commit spec:
https://www.conventionalcommits.org/en/v1.0.0/
<type>(<scope>)!: <description>
* `type` = chore, enhancement, feat, fix, docs, revert
* `!` = OPTIONAL: signals a breaking change
* `scope` = Optional when `type` is "chore" or "docs", ... | 93e4b7828041bcd698088710c9278cd5e692b7cf | 17ad27179a32177804dc5c6915dc3a88f6241297 | diff --git a/lib/vector-core/src/config/mod.rs b/lib/vector-core/src/config/mod.rs
index 8ebc97ee7fb4b..a9f43293221e3 100644
--- a/lib/vector-core/src/config/mod.rs
+++ b/lib/vector-core/src/config/mod.rs
@@ -30,6 +30,7 @@ pub const MEMORY_BUFFER_DEFAULT_MAX_EVENTS: NonZeroUsize =
// This enum should be kept alphabeti... | [
"lib/vector-core/src/config/mod.rs",
"src/config/graph.rs"
] | [
{
"comment": "Fixes the trailing coma situation `\"Log,Metric,Trace,\"` \r\nNow: `[\"Log\", \"Metric\", \"Trace\"]` ",
"path": "lib/vector-core/src/config/mod.rs",
"hunk": "@@ -38,11 +39,9 @@ pub enum DataType {\n \n impl fmt::Display for DataType {\n fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Re... | true | ||
venmo/synx | 109 | issue_to_patch | Using xcodeproj 1.0.0 | `xcodeproj` finally reached [release 1.0.0](https://github.com/CocoaPods/Xcodeproj/releases/tag/1.0.0). I think it's time to make the change 😋
| ad94e4903b19479cb41eac275db2ef0f0aeb3932 | b3fe480c1dbcc9c5ea75ae35a87d2fc050f1434f | diff --git a/synx.gemspec b/synx.gemspec
index dc67a26..598b6ce 100644
--- a/synx.gemspec
+++ b/synx.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
spec.add_dependency "clamp", "~> 0.6"
spec.add_dependency "colorize", "~> 0.7"
- spec.add_dependency "xcodeproj", "~> 0.28.2"
+ spec.add_dependency "x... | [
"synx.gemspec"
] | [] | true | ||
venmo/synx | 98 | issue_to_patch | Add flag to disable sort groups by name, by default sorting is enabled | In request to issue #26 and for my usage :)
| 27840e25197a46fad31804bfc11ffcd3f9594097 | 7a978ffe7abd6bd33445eab34b81e66bdc71f582 | diff --git a/README.md b/README.md
index d3380ed..3001100 100644
--- a/README.md
+++ b/README.md
@@ -42,6 +42,7 @@ Synx supports the following options:
--prune, -p remove source files and image resources that are not referenced by the the Xcode project
--no-color removes all c... | [
"README.md",
"bin/synx",
"lib/synx/project.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_group.rb"
] | [
{
"comment": "What do you think about naming this `--no-sort-by-name` for consistency with the other options?\n",
"path": "bin/synx",
"hunk": "@@ -9,6 +9,7 @@ Clamp do\n option [\"--prune\", \"-p\"], :flag, \"remove source files and image resources that are not referenced by the the xcode project\"\n ... | true | ||
venmo/synx | 97 | issue_to_patch | Prune support for Swift files | Added `.swift` to prune list of supported files extension
| f2eab5b0299657585b9d531d3d3d777f4c3c1ca6 | d50d87a7e6d60cf07353622fdd311005490ae19e | diff --git a/lib/synx/xcodeproj_ext/project/object/pbx_group.rb b/lib/synx/xcodeproj_ext/project/object/pbx_group.rb
index 59ba041..fbf57b9 100644
--- a/lib/synx/xcodeproj_ext/project/object/pbx_group.rb
+++ b/lib/synx/xcodeproj_ext/project/object/pbx_group.rb
@@ -93,7 +93,7 @@ def handle_unused_entry(entry_pathname)
... | [
"lib/synx/xcodeproj_ext/project/object/pbx_group.rb"
] | [] | true | ||
venmo/synx | 86 | issue_to_patch | Getting dyld warnings when I run synx in El Capitan
dyld: warning, LC_RPATH @executable_path/../../../../../../../SharedFrameworks in /Applications/Xcode.app/Contents/SharedFrameworks/DVTFoundation.framework/Versions/A/../../..//DVTInstrumentsFoundation.framework/Versions/A/DVTInstrumentsFoundation being ignored in re... | Pin Xcodeproj to ~> 0.28.2 | Xcodeproj 0.28.2 has a few fixes for El Capitan and Xcode 7 and would close #85.
| 3cf85cc33fee8e40f9e18c2ba34eef1b92f8317f | 8bef4da1fc67c3795f2502a79c9de0e46e2b3d6c | diff --git a/synx.gemspec b/synx.gemspec
index 0811f5f..dc67a26 100644
--- a/synx.gemspec
+++ b/synx.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
spec.add_dependency "clamp", "~> 0.6"
spec.add_dependency "colorize", "~> 0.7"
- spec.add_dependency "xcodeproj", "~> 0.24.1"
+ spec.add_dependency "x... | [
"synx.gemspec"
] | [] | true | |
venmo/synx | 82 | issue_to_patch | When synx'ing, also sort entries by if they are a group/file, then name. | 2cbec4726d8d240d5ec6f7592d09184d34b1ebba | 9efde0115e824442f0d65651c58429a3f025d633 | diff --git a/lib/synx/project.rb b/lib/synx/project.rb
index ce175cc..9471e0a 100644
--- a/lib/synx/project.rb
+++ b/lib/synx/project.rb
@@ -21,6 +21,7 @@ def sync(options={})
Synx::Tabber.puts "\n\n"
Synx::Tabber.puts "Syncing files that are not included in Xcode project..".bold.white
main_group.a... | [
"lib/synx/project.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_group.rb",
"spec/synx/expected_group_structure.yml",
"spec/synx/project_spec.rb"
] | [] | diff --git a/spec/synx/expected_group_structure.yml b/spec/synx/expected_group_structure.yml
index d0f0a24..0f291db 100644
--- a/spec/synx/expected_group_structure.yml
+++ b/spec/synx/expected_group_structure.yml
@@ -1,8 +1,6 @@
+Frameworks:
+Products:
dummy:
- FolderWithGroupNotLinked:
- data.json:
- Resources... | true | ||
venmo/synx | 74 | issue_to_patch | Update README to be a tad easier to read | 34f30e7a1f7598721114fb69274636647fa861ee | 10846fb2afa16b739ed5254f6567012901eb3c76 | diff --git a/README.md b/README.md
index 6859a65..d3380ed 100644
--- a/README.md
+++ b/README.md
@@ -22,14 +22,13 @@ A command-line tool that reorganizes your Xcode project folder to match your Xco
## Usage
### Basic
-
-**WARNING: Make sure that your project is backed up through source control before doing anything... | [
"README.md"
] | [] | true | |||
venmo/synx | 73 | issue_to_patch | Update xcodeproj version dependency to match latest Cocoapods version | b627219fa93d46c0de7bd0dc009580e6b02f63bb | 8a56cf39ab5ad9ebf1aeeabd13282fb8ed7982fc | diff --git a/synx.gemspec b/synx.gemspec
index 54609cf..0811f5f 100644
--- a/synx.gemspec
+++ b/synx.gemspec
@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
spec.add_dependency "clamp", "~> 0.6"
spec.add_dependency "colorize", "~> 0.7"
- spec.add_dependency "xcodeproj", "~> 0.20.0"
+ spec.add_dependency "x... | [
"synx.gemspec"
] | [] | true | |||
venmo/synx | 63 | issue_to_patch | Fixes handling of localized project files | Made changes so synx understands Xcode's weird subfolder structure for localized files and folders (PBXVariantGroup), added a file with multiple localizations to the dummy project, and updated the tests.
| cb6a66b93d5cee26927d00a26b7c2306c46f61b1 | e9dfa3cd8e032ced89439739e5a5214f789a5833 | diff --git a/lib/synx/xcodeproj_ext.rb b/lib/synx/xcodeproj_ext.rb
index 939a332..e6d48bd 100644
--- a/lib/synx/xcodeproj_ext.rb
+++ b/lib/synx/xcodeproj_ext.rb
@@ -4,4 +4,3 @@
require "synx/xcodeproj_ext/project/object/pbx_group"
require "synx/xcodeproj_ext/project/object/abstract_object"
require "synx/xcodeproj_ex... | [
"lib/synx/xcodeproj_ext.rb",
"lib/synx/xcodeproj_ext/project/object/abstract_object.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_file_reference.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_group.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_variant_group.rb",
"spec/dummy/dummy.xcodeproj/project.pb... | [
{
"comment": "This is just converting `entry` (which is a `String`) to a `Pathname` object. It definitely is confusing, though -- i had to `pry` in the specs just to figure out why it was there. Do you mind adding a comment to reflect this, or something?\n",
"path": "lib/synx/xcodeproj_ext/project/object/pb... | diff --git a/spec/dummy/dummy.xcodeproj/project.pbxproj b/spec/dummy/dummy.xcodeproj/project.pbxproj
index c6fa148..c9a98e3 100644
--- a/spec/dummy/dummy.xcodeproj/project.pbxproj
+++ b/spec/dummy/dummy.xcodeproj/project.pbxproj
@@ -62,6 +62,7 @@
/* End PBXCopyFilesBuildPhase section */
/* Begin PBXFileReference se... | true | |
venmo/synx | 60 | issue_to_patch | Prohibit running Synx as root to avoid file permission issues. | 2cea7ca26c9ade25c805df99ccaf38c67561b9cb | 5954f1fb29b46c5a62c6b7c330ece647e99a07fb | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a2d8bbc..184409b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,11 +2,14 @@
## master
+* Prohibit running Synx as root to avoid file permission issues
+ [Mark Larsen](https://github.com/marklarr)
+ [#60](https://github.com/venmo/slather/pull/60)
+
* Add a comm... | [
"CHANGELOG.md",
"bin/synx"
] | [] | true | |||
venmo/synx | 61 | issue_to_patch | Add version command | 1f42b402d2454d6b3bb2381d935824d5f88c4057 | fdaca5b98c03455008174aa151dbf127c8c28df6 | diff --git a/CHANGELOG.md b/CHANGELOG.md
new file mode 100644
index 0000000..a2d8bbc
--- /dev/null
+++ b/CHANGELOG.md
@@ -0,0 +1,108 @@
+# CHANGELOG
+
+## master
+
+* Add a command to show the version of Synx
+ [Mark Larsen](https://github.com/marklarr)
+ [#61](https://github.com/venmo/slather/pull/61)
+
+
+## v0.0.5... | [
"CHANGELOG.md",
"bin/synx"
] | [] | true | |||
venmo/synx | 51 | issue_to_patch | /Pods should be a default exclusion
Great tool! I think it would be beneficial to have Pods in the exclusion list by default. Thoughts? | Pods as a default exclusion + Fix for Exclusion path crash | Fixes #49 and #50
| 0acb45307680034b01039b27ff6277d4fe5845f6 | 7712b3a1ffdac44b60aaf5b2250eefefdccc47fd | diff --git a/lib/synx/project.rb b/lib/synx/project.rb
index 4006821..ce175cc 100644
--- a/lib/synx/project.rb
+++ b/lib/synx/project.rb
@@ -7,7 +7,7 @@ class Project < Xcodeproj::Project
SYNXRONIZE_DIR = File.join(ENV["HOME"], '.synx')
private_constant :SYNXRONIZE_DIR
- DEFAULT_EXCLUSIONS = %W(/Librarie... | [
"lib/synx/project.rb",
"spec/synx/project_spec.rb"
] | [
{
"comment": "Good change!\n",
"path": "lib/synx/project.rb",
"hunk": "@@ -93,21 +93,20 @@ def pathname_is_inside_root_pathname?(grandchild_pathname)\n end\n \n def group_exclusions=(new_exclusions)\n- new_exclusions.each do |exclusion|\n+ @group_exclusions = new_exclusions.map do |exc... | diff --git a/spec/synx/project_spec.rb b/spec/synx/project_spec.rb
index 9d92ebb..3ec3bd4 100644
--- a/spec/synx/project_spec.rb
+++ b/spec/synx/project_spec.rb
@@ -158,7 +158,7 @@ def expected_group_structure
end
it "should add the group exclusions to the array" do
- expect(DUMMY_SYNX_TEST_PROJE... | true |
venmo/synx | 1 | issue_to_patch | First release | @benzguo
1. Should I include some before/after pictures of an example project being synxronized in the `README`?
2. I want to implement your "remove spaces from folders" idea, but I want to get this v0.1 out first :)
3. For some reason, I had an awkward time explaining what the tool does in a few sentences. Input appr... | dbdbf5aaf097ce7ec4e0dca74bf48f280354cf83 | cba16816ebaa12566759ff6e69c0f096489d7f5a | diff --git a/.gitignore b/.gitignore
index dc35849..a57c77f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -40,3 +40,7 @@ DerivedData
*.ipa
*.xcuserstate
*.DS_Store
+
+
+# Spec
+spec/test_dummy/
diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 0000000..caccdbd
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1... | [
".gitignore",
".travis.yml",
"Gemfile",
"README.md",
"bin/synx",
"docs/images/synx-Xcode.jpg",
"docs/images/synx-finder-before-after.png",
"docs/images/synx-logo.png",
"docs/images/synx.gif",
"lib/synx.rb",
"lib/synx/abstract_object.rb",
"lib/synx/pbx_file_reference.rb",
"lib/synx/pbx_group.... | [
{
"comment": "\n",
"path": "spec/dummy/dummy/AlreadySynced/FolderNotInXcodeProj/Wowwww.h",
"hunk": "@@ -0,0 +1,13 @@\n+//\n+// Wowwww.h\n+// dummy\n+//\n+// Created by Mark Larsen on 5/9/14.\n+... | diff --git a/spec/dummy/dummy.xcodeproj/project.pbxproj b/spec/dummy/dummy.xcodeproj/project.pbxproj
index 11c93d1..6c81073 100644
--- a/spec/dummy/dummy.xcodeproj/project.pbxproj
+++ b/spec/dummy/dummy.xcodeproj/project.pbxproj
@@ -7,6 +7,13 @@
objects = {
/* Begin PBXBuildFile section */
+ 8C2DEB7F191D3F5C003A1... | true | |
venmo/synx | 39 | issue_to_patch | Separate xcodeproj monkey patching | Moves all xcodeproj monkeypatching into synx/xcodeproj_ext following the directory structure of their respective class hierarchies.
It's pretty typical for Ruby projects to separate monkey patching stuff into a *_ext subdirectory like this.
| 9d7052d274ccf698eb9b9f9dc431eb3427c50478 | 7407c7ffe52b011a5a430881a1f28c007a2fd108 | diff --git a/lib/synx.rb b/lib/synx.rb
index 88f8124..f86df29 100644
--- a/lib/synx.rb
+++ b/lib/synx.rb
@@ -1,13 +1,6 @@
+require "synx/xcodeproj_ext"
require "synx/version"
require "synx/project"
-require "synx/pbx_file_reference"
-require "synx/pbx_group"
-require "synx/abstract_object"
-require "synx/abstract_tar... | [
"lib/synx.rb",
"lib/synx/xcodeproj_ext.rb",
"lib/synx/xcodeproj_ext/project/object/abstract_object.rb",
"lib/synx/xcodeproj_ext/project/object/abstract_target.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_file_reference.rb",
"lib/synx/xcodeproj_ext/project/object/pbx_group.rb",
"lib/synx/xcodeproj_ext... | [] | diff --git a/spec/synx/pbx_group_spec.rb b/spec/synx/xcodeproj_ext/project/object/pbx_group_spec.rb
similarity index 100%
rename from spec/synx/pbx_group_spec.rb
rename to spec/synx/xcodeproj_ext/project/object/pbx_group_spec.rb
| true | |
venmo/synx | 37 | issue_to_patch | Remove output from tests | `Tabber` accepts an `:output` option, which points to `$stdout` by default.
Tests set this option to a `StringIO` object instead.
If you like the output for acceptance testing, feel free to close this. But a high-level test that makes explicit assertions about the format of the output would be better imo. In fact, I m... | 9dec221cff9b0989919d3a66624375e4c49a1bcc | c9424731d1504384ce310c21171fe01290fccfa7 | diff --git a/lib/synx/project.rb b/lib/synx/project.rb
index 46ad362..4006821 100644
--- a/lib/synx/project.rb
+++ b/lib/synx/project.rb
@@ -18,7 +18,7 @@ def sync(options={})
Synx::Tabber.increase
Synx::Tabber.puts "Syncing files that are included in Xcode project...".bold.white
main_group.all_gro... | [
"lib/synx/project.rb",
"lib/synx/tabber.rb",
"spec/synx/project_spec.rb",
"spec/synx/tabber_spec.rb"
] | [] | diff --git a/spec/synx/project_spec.rb b/spec/synx/project_spec.rb
index 2c5572a..9d92ebb 100644
--- a/spec/synx/project_spec.rb
+++ b/spec/synx/project_spec.rb
@@ -95,7 +95,7 @@ def expected_group_structure
describe "with no additional options" do
before(:all) do
- DUMMY_SYNX_TEST_PROJECT.sync
+ ... | true | |
venmo/synx | 36 | issue_to_patch | Remove class variables from Tabber | @@vars are generally considered a Bad Thing in Ruby.
See http://bit.ly/1kcit9V for a quick rationale.
| 128e650e4ea6c773041506f139b98a878f6c1fcd | b031242f639166f885c3f3c081c86949afc042d8 | diff --git a/lib/synx/tabber.rb b/lib/synx/tabber.rb
index c2a5030..1d5d89c 100644
--- a/lib/synx/tabber.rb
+++ b/lib/synx/tabber.rb
@@ -1,39 +1,39 @@
module Synx
class Tabber
- @@options = {}
- @@tabbing = 0
+ @options = {}
+ @tabbing = 0
class << self
def increase(n=1)
- @@tabbi... | [
"lib/synx/tabber.rb"
] | [] | true | ||
venmo/synx | 38 | issue_to_patch | Fix various `require` and `File.join` calls. | In many cases it's safe to assume the load path will be setup correctly
at runtime, eliminating the need for absolute paths. For instance, in
your bin/synx executable, RubyGems sets the load path such that you can
just `require "synx"`. When you use RSpec, it also sets the load path to
allow you to use `require "spec_h... | 128e650e4ea6c773041506f139b98a878f6c1fcd | fa38cd75cf43a30e92188ee6c78f53b1a5bfaa98 | diff --git a/bin/synx b/bin/synx
index 1aad4af..5dfa486 100755
--- a/bin/synx
+++ b/bin/synx
@@ -1,7 +1,7 @@
#!/usr/bin/env ruby
require 'clamp'
-require File.join(File.dirname(__FILE__), '..', 'lib', 'synx')
+require 'synx'
Clamp do
| [
"bin/synx",
"spec/spec_helper.rb",
"spec/synx/pbx_group_spec.rb",
"spec/synx/project_spec.rb",
"spec/synx/tabber_spec.rb"
] | [] | diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 862c872..96d0058 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -1,11 +1,9 @@
require 'bundler/setup'
-Bundler.setup
-
require 'synx'
require 'pry'
-DUMMY_SYNX_PATH = File.join(File.dirname(__FILE__), 'dummy')
-DUMMY_SYNX_TEST_PATH = File.... | true | |
venmo/synx | 35 | issue_to_patch | Fix misspelling of 'amended' | 7e487bfad92b4f554eed1b9561db3842b8c6f506 | 173e9652157a0e28cd0848b164200a44506277d0 | diff --git a/lib/synx/pbx_file_reference.rb b/lib/synx/pbx_file_reference.rb
index c2abdc3..0bc8b26 100644
--- a/lib/synx/pbx_file_reference.rb
+++ b/lib/synx/pbx_file_reference.rb
@@ -25,10 +25,10 @@ def sync(group)
end
def output
- build_settings_ammended = "(build settings ammended: #{@s... | [
"lib/synx/pbx_file_reference.rb"
] | [] | true | |||
venmo/synx | 32 | issue_to_patch | Add support for the --no-color option. | The `colored` gem was replaced with `colorize`. It has a very similar API but comes with a few extra methods to remove or check colors.
The Tabber class has had an options hash added to it, to make further additions easier.
This partially addresses issue #28.
| 55858c507c5813e351e03e517cc41758bb3785fa | 415b1de055d25e189dd4c51b70c08168602e5172 | diff --git a/README.md b/README.md
index 66e9ae1..6859a65 100644
--- a/README.md
+++ b/README.md
@@ -41,6 +41,7 @@ Synx supports the following options:
```
--prune, -p remove source files and image resources that are not referenced by the the xcode project
+ --no-color remove... | [
"README.md",
"bin/synx",
"lib/synx.rb",
"lib/synx/project.rb",
"lib/synx/tabber.rb",
"spec/synx/tabber_spec.rb",
"synx.gemspec"
] | [
{
"comment": "Is there a test for the opposite case, where it prints colors when `no_color` is false? :)\n",
"path": "spec/synx/tabber_spec.rb",
"hunk": "@@ -55,11 +55,17 @@\n end\n \n it \"should not print anything if quiet is true\" do\n- Synx::Tabber.quiet = true\n+ Synx::Tabber.opt... | diff --git a/spec/synx/tabber_spec.rb b/spec/synx/tabber_spec.rb
index 521b092..1caf815 100644
--- a/spec/synx/tabber_spec.rb
+++ b/spec/synx/tabber_spec.rb
@@ -55,11 +55,21 @@
end
it "should not print anything if quiet is true" do
- Synx::Tabber.quiet = true
- Synx::Tabber.increase(3)
+ Synx... | true | |
venmo/synx | 31 | issue_to_patch | Document the --quiet option. | I had forgotten to update the list of options to include `--quiet`.
| 77b0f0606c36a178b52498ff81e3c6ec909b0410 | f47f0eada51c7ac2cdcce913fa7d42ff1d6f05a4 | diff --git a/README.md b/README.md
index cfeb8a5..368d034 100644
--- a/README.md
+++ b/README.md
@@ -42,6 +42,7 @@ Synx supports the following options:
```
--prune, -p remove source files and image resources that are not referenced by the the xcode project
--no-default-exclusions doesn't ... | [
"README.md"
] | [] | true | ||
venmo/synx | 30 | issue_to_patch | en.lproj syncing | - Better output during tests (lets you know which files were the offending ones)
- A test case where `en.lproj` folder is actually a group in Xcode
- Handled this new case by checking in `pbx_variant_group.rb` whether or not the `en.lproj` was a group in xcode, and then acting accordingly. The reason this case needs ... | 871c25fc12795c44e9f48735d128bed9c790b313 | 3fdd073674a8a2c81d98113ef4c7e413411282a9 | diff --git a/lib/synx/pbx_group.rb b/lib/synx/pbx_group.rb
index 46ff648..7fb63c1 100644
--- a/lib/synx/pbx_group.rb
+++ b/lib/synx/pbx_group.rb
@@ -33,9 +33,9 @@ def move_entries_not_in_xcodeproj
else
Synx::Tabber.puts "#{basename}/".green
Synx::Tabber.increase
- Dir[rea... | [
"lib/synx/pbx_group.rb",
"lib/synx/pbx_variant_group.rb",
"lib/synx/project.rb",
"spec/dummy/dummy.xcodeproj/project.pbxproj",
"spec/dummy/dummy/en.lproj/Localizable.strings",
"spec/synx/expected_file_structure.yml",
"spec/synx/expected_group_structure.yml",
"spec/synx/project_spec.rb"
] | [
{
"comment": "Reformat?\n",
"path": "lib/synx/project.rb",
"hunk": "@@ -108,6 +108,11 @@ def group_exclusions=(new_exclusions)\n @group_exclusions = new_exclusions\n end\n \n+ def has_object_for_pathname?(pathname)\n+ @unmodified_project ||= Synx::Project.open(path)\n+ @unmodified... | diff --git a/spec/dummy/dummy.xcodeproj/project.pbxproj b/spec/dummy/dummy.xcodeproj/project.pbxproj
index 43479ba..c6fa148 100644
--- a/spec/dummy/dummy.xcodeproj/project.pbxproj
+++ b/spec/dummy/dummy.xcodeproj/project.pbxproj
@@ -89,6 +89,7 @@
8C848C65190DB9B300E9727B /* en */ = {isa = PBXFileReference; lastKnown... | true | |
venmo/synx | 29 | issue_to_patch | Add support for a --quiet option. | This fixes issue #27.
| d6f7328236db653108f2332dfa338c61142c2a84 | ae8c9d12ce91d452db997d4a0af8549d6fdae4c0 | diff --git a/bin/synx b/bin/synx
index e6e0bff..8b004c6 100755
--- a/bin/synx
+++ b/bin/synx
@@ -8,11 +8,12 @@ Clamp do
parameter "xcodeproj", "Path to the xcodeproj", :attribute_name => :xcodeproj_path
option ["--prune", "-p"], :flag, "remove source files and image resources that are not referenced by the the xc... | [
"bin/synx",
"lib/synx/project.rb",
"lib/synx/tabber.rb",
"spec/synx/tabber_spec.rb"
] | [
{
"comment": "Mind moving this line into the `set_options` method?\n",
"path": "lib/synx/project.rb",
"hunk": "@@ -15,10 +15,11 @@ class Project < Xcodeproj::Project\n def sync(options={})\n set_options(options)\n presync_check\n+ Synx::Tabber.quiet = options[:quiet]",
"resolvin... | diff --git a/spec/synx/tabber_spec.rb b/spec/synx/tabber_spec.rb
index 18d9fbf..521b092 100644
--- a/spec/synx/tabber_spec.rb
+++ b/spec/synx/tabber_spec.rb
@@ -53,6 +53,13 @@
expect(Kernel).to receive(:puts).with(" Hello, world.")
Synx::Tabber.puts("Hello, world.")
end
+
+ it "should not pri... | true | |
venmo/synx | 10 | issue_to_patch | Fixes an exception being raised with aggregate targets | Fixes #6
| 79a82e8e4c68ddf005061f7410a90b9edc951ae2 | c1da4679fae2437e1a171617d5b554d4702c2b85 | diff --git a/lib/synx/pbx_file_reference.rb b/lib/synx/pbx_file_reference.rb
index c2abdc3..3e09090 100644
--- a/lib/synx/pbx_file_reference.rb
+++ b/lib/synx/pbx_file_reference.rb
@@ -48,8 +48,12 @@ def should_move?
def change_build_settings_reference
@setting_keys_changed = []
return un... | [
"lib/synx/pbx_file_reference.rb"
] | [] | true | ||
venmo/synx | 5 | issue_to_patch | Accommodate for case insensitive dir names | 571414ec9fefecba3e788cd2e0482fbdc326834a | 6477f9f0aba75e31d874872b5ecb0eb57b9ad2df | diff --git a/lib/synx/pbx_group.rb b/lib/synx/pbx_group.rb
index dc96741..30fe54b 100644
--- a/lib/synx/pbx_group.rb
+++ b/lib/synx/pbx_group.rb
@@ -68,7 +68,11 @@ def variant_groups
def handle_unused_entry(entry_pathname)
if entry_pathname.directory?
- project.pathname_to_work_pathname... | [
"lib/synx/pbx_group.rb",
"spec/dummy/dummy.xcodeproj/project.pbxproj",
"spec/dummy/dummy/folderWithGroupNotLinked/data.json",
"spec/synx/expected_file_structure.yml",
"spec/synx/expected_group_structure.yml"
] | [] | diff --git a/spec/dummy/dummy.xcodeproj/project.pbxproj b/spec/dummy/dummy.xcodeproj/project.pbxproj
index 6c81073..b661ce4 100644
--- a/spec/dummy/dummy.xcodeproj/project.pbxproj
+++ b/spec/dummy/dummy.xcodeproj/project.pbxproj
@@ -76,6 +76,7 @@
8C848C65190DB9B300E9727B /* en */ = {isa = PBXFileReference; lastKnown... | true | ||
venmo/synx | 7 | issue_to_patch | Linkify contributors. | e04a16b40e742baacc1080a7f60caefd0a476a51 | 093fac85bae16ef1e7f10ea0e3bdb1f79041b0ad | diff --git a/README.md b/README.md
index d46d807..9c94f5e 100644
--- a/README.md
+++ b/README.md
@@ -61,5 +61,5 @@ if they wanted to not sync the `OCMock/Core` and `OCMockTests` groups, and also
## Contributors
-* @vrjbndr, awesome logo!
-* @ayanonagon and @benzguo, feedback.
+* [@vrjbndr](https://github.com/vrjbn... | [
"README.md"
] | [] | true | |||
venmo/synx | 11 | issue_to_patch | Allow all abstract targets to have build settings changed | 79a82e8e4c68ddf005061f7410a90b9edc951ae2 | 2fc4fe441d8e488dfd2cdb9c8725bdb29bf40cac | diff --git a/lib/synx.rb b/lib/synx.rb
index 77c2bc9..8931932 100644
--- a/lib/synx.rb
+++ b/lib/synx.rb
@@ -3,7 +3,7 @@
require "synx/pbx_file_reference"
require "synx/pbx_group"
require "synx/abstract_object"
-require "synx/pbx_native_target"
+require "synx/abstract_target"
require "synx/pbx_variant_group"
requi... | [
"lib/synx.rb",
"lib/synx/abstract_target.rb",
"spec/dummy/dummy.xcodeproj/project.pbxproj",
"spec/dummy/dummy.xcodeproj/xcuserdata/marklarsen.xcuserdatad/xcschemes/xcschememanagement.plist",
"spec/synx/project_spec.rb"
] | [] | diff --git a/spec/dummy/dummy.xcodeproj/project.pbxproj b/spec/dummy/dummy.xcodeproj/project.pbxproj
index b661ce4..43479ba 100644
--- a/spec/dummy/dummy.xcodeproj/project.pbxproj
+++ b/spec/dummy/dummy.xcodeproj/project.pbxproj
@@ -6,6 +6,19 @@
objectVersion = 46;
objects = {
+/* Begin PBXAggregateTarget section... | true | ||
venmo/synx | 18 | issue_to_patch | be more forgiving with exclusion paths | Appends a `/` to the beginning of exclusion paths if it's not there.
ie,
`dummy` becomes `/dummy`
`/dummy` stays `/dummy`
| 4c17ccf1377282f7a8ea4581723e6e2517162fad | 1559a27783becaaa695cb71dbbbb3aec44cd7b69 | diff --git a/lib/synx/project.rb b/lib/synx/project.rb
index ec6aab0..c3bbd4d 100644
--- a/lib/synx/project.rb
+++ b/lib/synx/project.rb
@@ -79,11 +79,13 @@ def pathname_is_inside_root_pathname?(grandchild_pathname)
def group_exclusions=(new_exclusions)
new_exclusions.each do |exclusion|
+ # Group ... | [
"lib/synx/project.rb",
"spec/synx/project_spec.rb"
] | [] | diff --git a/spec/synx/project_spec.rb b/spec/synx/project_spec.rb
index e4a98aa..7396806 100644
--- a/spec/synx/project_spec.rb
+++ b/spec/synx/project_spec.rb
@@ -164,6 +164,14 @@ def expected_group_structure
expect(DUMMY_SYNX_TEST_PROJECT.group_exclusions).to eq(group_exclusions)
end
+
+ it "should ... | true | |
venmo/synx | 2 | issue_to_patch | Removing mention of Gemfile from installation instructions | Realistically, most people installing this tool will not be invoking it within the context of a Ruby application. I found these details confusing—or at the very least, unexpected—on my first read-through.
| c985ff13580219209374b51404005f4914d1e2fb | bcac8bccb4d301c9f0eb694c8e1c9f08ca99b5b9 | diff --git a/README.md b/README.md
index e2304dd..9bac2c9 100644
--- a/README.md
+++ b/README.md
@@ -17,16 +17,6 @@ A command-line tool that automagically reorganizes your Xcode project folder.
## Installation
-Add this line to your application's Gemfile:
-
- gem 'synx'
-
-And then execute:
-
- $ bundle
-
-O... | [
"README.md"
] | [] | true | ||
venmo/synx | 22 | issue_to_patch | Fix regex escaping causing sync issues on paths with special characters | Previously, with paths containing parens `(` `)`, Synx fails to sync groups as it does not believe files are within the root pathname for their project.
This fix replaces the regex with a `start_with?` check, fixing the regex issue.
Thanks to @marklarr for lots of things. :punch:
| fff31181fef9af5dd85bd5dc662217014f7b873d | 2b108d8e51ef22c3fd52d6b4973bcca84a872ba2 | diff --git a/lib/synx/project.rb b/lib/synx/project.rb
index 8cfe5c7..36203a2 100644
--- a/lib/synx/project.rb
+++ b/lib/synx/project.rb
@@ -87,7 +87,7 @@ def work_pathname_to_pathname(work_pathname)
end
def pathname_is_inside_root_pathname?(grandchild_pathname)
- grandchild_pathname.realpath.to_s =~ /... | [
"lib/synx/project.rb"
] | [] | true | ||
venmo/synx | 21 | issue_to_patch | Change Dir globbing to also find hidden files. Ignore .DS_Store. | ae1f587fd61c2b9e220599a73ee4a0d7eae46f0a | f8d024008bc9f5f1b13f5f2a7e8bf7f305bd4cb3 | diff --git a/lib/synx/pbx_group.rb b/lib/synx/pbx_group.rb
index 535c695..46ff648 100644
--- a/lib/synx/pbx_group.rb
+++ b/lib/synx/pbx_group.rb
@@ -33,7 +33,7 @@ def move_entries_not_in_xcodeproj
else
Synx::Tabber.puts "#{basename}/".green
Synx::Tabber.increase
- Dir[rea... | [
"lib/synx/pbx_group.rb",
"spec/synx/expected_file_structure.yml"
] | [] | diff --git a/spec/synx/expected_file_structure.yml b/spec/synx/expected_file_structure.yml
index 1c45667..7d7e5ea 100644
--- a/spec/synx/expected_file_structure.yml
+++ b/spec/synx/expected_file_structure.yml
@@ -7,6 +7,7 @@ dummy:
image-not-in-xcodeproj.png:
AlreadySynced:
Core Data.xcdatamodeld:
+ .xc... | true | ||
venmo/synx | 17 | issue_to_patch | Abort sync if project has groups containing a forward slash | For example, will print something like
```
Synx cannot sync projects with groups that contain '/'. Please rename the following groups before running synx again:
/dummy / stuff
/dummy / stuff/FolderWithGroupNotLinked /wow
```
also, remove `coveralls` since we aren't using the badge anymore.
| 4c17ccf1377282f7a8ea4581723e6e2517162fad | a0e53c3d36d96ae15b696b48a966fa3619c1135b | diff --git a/lib/synx/pbx_group.rb b/lib/synx/pbx_group.rb
index 30fe54b..535c695 100644
--- a/lib/synx/pbx_group.rb
+++ b/lib/synx/pbx_group.rb
@@ -124,6 +124,17 @@ def squash_duplicate_file_references
end
private :squash_duplicate_file_references
+ def groups_containing_forward_slash
+ ... | [
"lib/synx/pbx_group.rb",
"lib/synx/project.rb",
"spec/spec_helper.rb",
"spec/synx/pbx_group_spec.rb",
"spec/synx/project_spec.rb",
"spec/synx/tabber_spec.rb",
"synx.gemspec"
] | [] | diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 3012418..862c872 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -3,9 +3,13 @@
require 'synx'
require 'pry'
-require 'coveralls'
-Coveralls.wear!
+DUMMY_SYNX_PATH = File.join(File.dirname(__FILE__), 'dummy')
+DUMMY_SYNX_TEST_PATH = File.jo... | true | |
vercel-labs/agent-browser | 1,269 | issue_to_patch | Windows ARM64 installs at 0kb
<img width="691" height="300" alt="Image" src="https://github.com/user-attachments/assets/052b0bc5-fad0-4206-a437-eed262a72a40" />
Tried the global install a few times, it always comes out as 0kb
I have to go up the edit the agent-browser.cmd and change it to use the x64 version | fix: fall back to x64 binary on Windows ARM64 | ## Summary
Fixes #1256
On Windows ARM64, the postinstall script previously tried to download `agent-browser-win32-arm64.exe` from GitHub releases. Since there's no native ARM64 build in CI, this resulted in a 0-byte file and a broken install.
## Changes
- **Platform detection**: When running on Windows ARM64, the ... | c830d1b67dc18b754e305859f0ae587f858a1447 | e2f11d8f35dc91a24b18351e5f2c21f12982ff21 | diff --git a/scripts/postinstall.js b/scripts/postinstall.js
index 80fe2fccd..12281bd2a 100644
--- a/scripts/postinstall.js
+++ b/scripts/postinstall.js
@@ -33,7 +33,10 @@ function isMusl() {
// Platform detection
const osKey = platform() === 'linux' && isMusl() ? 'linux-musl' : platform();
-const platformKey = `${... | [
"scripts/postinstall.js"
] | [] | true | |
vercel-labs/agent-browser | 1,446 | issue_to_patch | Prepare v0.27.3 release | - Bump package, Cargo, and dashboard versions to 0.27.3
- Add release notes for the Windows ARM64 install fallback
- Move release extraction markers to the 0.27.3 changelog entry | 8e70c78d73688de99f55daeb6ab39ecbf325abc9 | 753b54b1d5c8938cc8b028178b51f5e67c3393b7 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5e511ef1e..f8c43b3fe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,10 +1,21 @@
# agent-browser
-## 0.27.2
+## 0.27.3
<!-- release:start -->
### Bug Fixes
+- Fixed **Windows ARM64 installs** by falling back to the Windows x64 binary during postinstall, avoidin... | [
"CHANGELOG.md",
"cli/Cargo.lock",
"cli/Cargo.toml",
"docs/src/app/changelog/page.mdx",
"package.json",
"packages/dashboard/package.json"
] | [] | true | ||
vercel-labs/agent-browser | 1,435 | issue_to_patch | chore: prepare 0.27.2 release | Bumped version and updated changelog | 688e285b8b7bdc8156f61029d66dc016d002e717 | 9ab1fe9ec6a00597134255a60bdf0ca0111f6555 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a09ddbd07..5e511ef1e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,8 +1,32 @@
# agent-browser
-## 0.27.1
+## 0.27.2
<!-- release:start -->
+### Bug Fixes
+
+- Fixed **click reliability** by scrolling off-viewport elements into view before resolving coordinates, ... | [
"CHANGELOG.md",
"cli/Cargo.lock",
"cli/Cargo.toml",
"docs/src/app/changelog/page.mdx",
"package.json",
"packages/dashboard/package.json"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.