repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
webtorrent/webtorrent | 3,057 | issue_to_patch | fix(deps): update dependency torrent-piece to v4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [torrent-piece](https://redirect.github.com/webtorrent/torrent-piece) | [`^3.0.2` β `^4.0.0`](https://renovatebot.com/d... | 5f77036a843770a7ac468824c93b062eaeacda8e | f098bcd7b8275f0d878204b6c1e0fe6b27069751 | diff --git a/package.json b/package.json
index 7fbfcaa460..e7133a5746 100644
--- a/package.json
+++ b/package.json
@@ -71,7 +71,7 @@
"streamx": "2.25.0",
"throughput": "^1.0.2",
"torrent-discovery": "^11.0.21",
- "torrent-piece": "^3.0.2",
+ "torrent-piece": "^4.0.0",
"uint8-util": "^2.2.6",
... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,056 | issue_to_patch | fix(deps): update dependency load-ip-set to ^3.0.2 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [load-ip-set](https://redirect.github.com/webtorrent/load-ip-set) | [`^3.0.1` β `^3.0.2`](https://renovatebot.com/diffs... | 5f77036a843770a7ac468824c93b062eaeacda8e | 6c7a0f212e3937381d8b040268aca50a989e725e | diff --git a/package.json b/package.json
index 7fbfcaa460..b7b17f70d5 100644
--- a/package.json
+++ b/package.json
@@ -55,7 +55,7 @@
"fsa-chunk-store": "^1.3.0",
"immediate-chunk-store": "^2.2.0",
"join-async-iterator": "^1.1.1",
- "load-ip-set": "^3.0.1",
+ "load-ip-set": "^3.0.2",
"lt_dontha... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,055 | issue_to_patch | fix(deps): update dependency bittorrent-protocol to ^5.0.4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-protocol](https://redirect.github.com/webtorrent/bittorrent-protocol) | [`^5.0.3` β `^5.0.4`](https://renov... | 48c26a8af766736498f77e47b3aac13c88750cab | 2b500cee3d19c8356e132c8ce98f88a25877ad79 | diff --git a/package.json b/package.json
index b46ee3b4b6..ed78d5f01c 100644
--- a/package.json
+++ b/package.json
@@ -43,7 +43,7 @@
"addr-to-ip-port": "^2.0.0",
"bitfield": "^5.0.1",
"bittorrent-dht": "^11.0.12",
- "bittorrent-protocol": "^5.0.3",
+ "bittorrent-protocol": "^5.0.4",
"cache-chu... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,053 | issue_to_patch | chore(deps): update babel monorepo to v7.29.7 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://redirect.github.com/babel/babel/tree/HEAD/pa... | 63327f97e413353b84c38281427806746aeca5ed | b8be3e9ecc86925a54709bf94da1b2dafbc42e56 | diff --git a/package.json b/package.json
index e396cb5fdb..fc9fb552ea 100644
--- a/package.json
+++ b/package.json
@@ -78,10 +78,10 @@
"ut_pex": "^4.0.4"
},
"devDependencies": {
- "@babel/core": "7.29.0",
- "@babel/eslint-parser": "^7.28.6",
- "@babel/plugin-syntax-import-assertions": "7.28.6",
- ... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,047 | issue_to_patch | fix: pe/mse | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
part of https://github.com... | 77a176d5d3c38a87e3c8ad3c3af3c5edb364f621 | a32547d99880e0354d21ddd4ac0b785f46080a5a | diff --git a/docs/api.md b/docs/api.md
index 5316be2f44..47ddf312ff 100644
--- a/docs/api.md
+++ b/docs/api.md
@@ -72,6 +72,7 @@ If `opts` is specified, then the default options (shown below) will be overridde
blocklist: Array|String, // List of IP's to block
downloadLimit: Number, // Max download speed (bytes/... | [
"docs/api.md",
"index.js",
"lib/conn-pool.js",
"lib/peer.js",
"lib/rarity-map.js",
"lib/torrent.js",
"test/node/encryption.js"
] | [] | diff --git a/test/node/encryption.js b/test/node/encryption.js
new file mode 100644
index 0000000000..24a288c54a
--- /dev/null
+++ b/test/node/encryption.js
@@ -0,0 +1,90 @@
+import fs from 'fs'
+import test from 'tape'
+import fixtures from 'webtorrent-fixtures'
+import MemoryChunkStore from 'memory-chunk-store'
+impo... | true | |
webtorrent/webtorrent | 3,052 | issue_to_patch | fix(deps): update webtorrent | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-protocol](https://redirect.github.com/webtorrent/bittorrent-protocol) | [`^5.0.2` β `^5.0.3`](https://renov... | 853a82b2cace7472cd7867b239c831ec844a96da | 93836d3d7b2f03ef8626d0811c26f326bcf7ac09 | diff --git a/package.json b/package.json
index d58bbb0eec..83485f7987 100644
--- a/package.json
+++ b/package.json
@@ -43,7 +43,7 @@
"addr-to-ip-port": "^2.0.0",
"bitfield": "^5.0.1",
"bittorrent-dht": "^11.0.12",
- "bittorrent-protocol": "^5.0.2",
+ "bittorrent-protocol": "^5.0.3",
"cache-chu... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,051 | issue_to_patch | fix(deps): update dependency create-torrent to ^6.1.2 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [create-torrent](https://redirect.github.com/webtorrent/create-torrent) | [`^6.1.1` β `^6.1.2`](https://renovatebot.com... | ca8576367f5138e3536670b4515dffae95cf958d | a456e3c94a53f5717ba96732e855e311264ddeac | diff --git a/package.json b/package.json
index e86aeaab4f..44000ced04 100644
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
"cache-chunk-store": "^3.2.2",
"chunk-store-iterator": "^1.0.4",
"cpus": "^1.0.3",
- "create-torrent": "^6.1.1",
+ "create-torrent": "^6.1.2",
"cross-fetch-ponyf... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,050 | issue_to_patch | fix(deps): update webtorrent | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-tracker](https://redirect.github.com/webtorrent/bittorrent-tracker) | [`11.2.2` β `11.2.3`](https://renovat... | d14c638c4bcddac7845c88ad3d5622698eee4425 | 112b779ff0f2bae9bdc43eb7ba2c277b8da5f931 | diff --git a/package.json b/package.json
index 2e1f1112dc..fc5bb794dc 100644
--- a/package.json
+++ b/package.json
@@ -51,7 +51,7 @@
"cross-fetch-ponyfill": "^1.0.3",
"debug": "^4.4.3",
"escape-html": "^1.0.3",
- "fs-chunk-store": "^5.0.0",
+ "fs-chunk-store": "^5.0.1",
"fsa-chunk-store": "^1.... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,049 | issue_to_patch | fix(deps): update dependency bittorrent-dht to ^11.0.12 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-dht](https://redirect.github.com/webtorrent/bittorrent-dht) | [`^11.0.11` β `^11.0.12`](https://renovatebot... | 1f52a371757fd7d87171c59d2fff823d91dbbd90 | 5f951d87a00aa86c157fd19f4f50dffc4ec54e12 | diff --git a/package.json b/package.json
index 3bf8c48332..8f2890539a 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,7 @@
"@webtorrent/http-node": "^1.3.0",
"addr-to-ip-port": "^2.0.0",
"bitfield": "^5.0.1",
- "bittorrent-dht": "^11.0.11",
+ "bittorrent-dht": "^11.0.12",
"bittorrent... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,832 | issue_to_patch | chore(deps): update dependency tap-parser to v18 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [tap-parser](https://redirect.github.com/tapjs/tapjs/tree/main/src/parser#readme) ([source](https://redirect.github.com... | 2818bcf87dd16271744d261b809e1c3b834425a9 | 790e26e9b8754a18c1ccf2d6c3b2e2c6fab2c577 | diff --git a/package.json b/package.json
index 0fb036703b..0959a19d24 100644
--- a/package.json
+++ b/package.json
@@ -107,7 +107,7 @@
"semantic-release": "25.0.3",
"serve-static": "2.2.1",
"stream-browserify": "^3.0.0",
- "tap-parser": "^16.0.1",
+ "tap-parser": "^18.3.4",
"tap-spec": "^5.0.0... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,039 | issue_to_patch | chore: improve tests perf and speed | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
**What changes did you make? (Give an overview)**
changes to tests so they d... | 4dc385d299a7256cebf1de3cede1cabe00662a15 | b1bf195f03e5463e521a6f369083816cd7edd4ba | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 1acd4a7aa3..873ec4ad3f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -29,9 +29,27 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: npm install
- - run: npm run build --if-present
... | [
".github/workflows/ci.yml",
".github/workflows/release.yml",
"package.json",
"test/node/basic.js",
"test/node/blocklist.js",
"test/node/download-dht-torrent.js",
"test/node/download-metadata.js",
"test/node/download-tracker-magnet.js",
"test/node/download-webseed-magnet.js",
"test/node/download-we... | [
{
"comment": "Why?",
"path": ".gitignore",
"hunk": "@@ -1,5 +1,4 @@\n node_modules/\n-package-lock.json",
"resolving_sha": "b1bf195f03e5463e521a6f369083816cd7edd4ba",
"resolving_diff": ""
}
] | diff --git a/test/node/basic.js b/test/node/basic.js
index e033f59b52..132fbf4c1f 100644
--- a/test/node/basic.js
+++ b/test/node/basic.js
@@ -44,6 +44,7 @@ test('client.add: http url to a torrent file, string', t => {
await client.remove(torrent, err => { t.error(err, 'torrent destroyed') })
t.equal(clie... | true | |
webtorrent/webtorrent | 3,036 | issue_to_patch | chore(deps): update dependency webpack-cli to v7 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [webpack-cli](https://redirect.github.com/webpack/webpack-cli/tree/main/packages/webpack-cli) ([source](https://redirec... | 30df194e3607930d250baa81d6541e02b24b0cf7 | d78a24612457a7b03ee9bfa877402477a812c898 | diff --git a/package.json b/package.json
index e815c8aa77..6885eaca08 100644
--- a/package.json
+++ b/package.json
@@ -113,7 +113,7 @@
"terser-webpack-plugin": "^5.6.0",
"timers-browserify": "^2.0.12",
"webpack": "^5.107.0",
- "webpack-cli": "^6.0.1",
+ "webpack-cli": "^7.0.2",
"webtorrent-fix... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,893 | issue_to_patch | chore(deps): update dependency airtap to v5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [airtap](https://redirect.github.com/airtap/airtap) | [`4.0.4` β `5.0.0`](https://renovatebot.com/diffs/npm/airtap/4.0.... | 30df194e3607930d250baa81d6541e02b24b0cf7 | c7d804ba871325086805bd671fc6632b51b8fc2d | diff --git a/package.json b/package.json
index e815c8aa77..a1478aa279 100644
--- a/package.json
+++ b/package.json
@@ -83,7 +83,7 @@
"@babel/plugin-syntax-import-assertions": "7.28.6",
"@babel/preset-env": "7.29.5",
"@webtorrent/semantic-release-config": "1.0.11",
- "airtap": "4.0.4",
+ "airtap": "... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,042 | issue_to_patch | chore(deps): update github/codeql-action action to v4 | > βΉοΈ **Note**
>
> This PR body was truncated due to platform limits.
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [github/codeql-action](https://redirect.github.com/github/codeql-action) | action | major | `v3` β `v4` |
---
### Release Notes
<details>
<summary>g... | 30df194e3607930d250baa81d6541e02b24b0cf7 | 6632ec2d0e9cb2dd7752ebba717e11969c23e4c5 | diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
index aeeb9c26fc..9e574a3ebd 100644
--- a/.github/workflows/codeql-analysis.yml
+++ b/.github/workflows/codeql-analysis.yml
@@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@v6
- name: Initialize CodeQL
- uses: gi... | [
".github/workflows/codeql-analysis.yml"
] | [] | true | ||
webtorrent/webtorrent | 3,037 | issue_to_patch | chore(deps): update dessant/lock-threads action to v6 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [dessant/lock-threads](https://redirect.github.com/dessant/lock-threads) | action | major | `v4` β `v6` |
---
### Release Notes
<details>
<summary>dessant/lock-threads (dessant/lock-threads)</summary>
### [`v6.0.2`](ht... | ceea5efaf27ee2fb69ffb82bf77ac1f6692d1ac5 | b02f59f8bebc18fd45ea539556a7e52232143e00 | diff --git a/.github/workflows/lock.yml b/.github/workflows/lock.yml
index 14dcf5b25c..d16e99bbf1 100644
--- a/.github/workflows/lock.yml
+++ b/.github/workflows/lock.yml
@@ -16,4 +16,4 @@ jobs:
action:
runs-on: ubuntu-latest
steps:
- - uses: dessant/lock-threads@v4
+ - uses: dessant/lock-threads... | [
".github/workflows/lock.yml"
] | [] | true | ||
webtorrent/webtorrent | 3,040 | issue_to_patch | chore(deps): update dependency webpack to ^5.107.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [webpack](https://redirect.github.com/webpack/webpack) | [`^5.107.0` β `^5.107.1`](https://renovatebot.com/diffs/npm/we... | d0aadde5d4205784aaa6684f8617371ed2c3c88e | 9d375201a05452deef662888a485fb657add93d3 | diff --git a/package.json b/package.json
index 4b8e8eb747..f9484b4d16 100644
--- a/package.json
+++ b/package.json
@@ -112,7 +112,7 @@
"tape": "^5.9.0",
"terser-webpack-plugin": "^5.6.0",
"timers-browserify": "^2.0.12",
- "webpack": "^5.107.0",
+ "webpack": "^5.107.1",
"webpack-cli": "^7.0.2",... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,980 | issue_to_patch | webtorrent-hybrid is deprecated | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
Removed webtorrent-hybri... | ceea5efaf27ee2fb69ffb82bf77ac1f6692d1ac5 | f02f14b9acc89364e9ca1f2ff7b16260b9b64da9 | diff --git a/docs/get-started.md b/docs/get-started.md
index 9047bacf65..587b03f032 100644
--- a/docs/get-started.md
+++ b/docs/get-started.md
@@ -109,10 +109,8 @@ client.add(magnetURI, { path: '/path/to/folder' }, torrent => {
### Creating a new torrent and seed it (in Node.js)
-**Note:** Seeding a torrent that c... | [
"docs/get-started.md"
] | [] | true | ||
webtorrent/webtorrent | 3,048 | issue_to_patch | fix(deps): update webtorrent | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-protocol](https://redirect.github.com/webtorrent/bittorrent-protocol) | [`^5.0.0` β `^5.0.2`](https://renov... | 846536d43450241dcaffb42c47d31d391f10e3f1 | 2d7142c28cb1e632d20e312a8b938b9bfe1ca8dc | diff --git a/package.json b/package.json
index f19cbb6ed2..ed6b1e1dc0 100644
--- a/package.json
+++ b/package.json
@@ -43,11 +43,11 @@
"addr-to-ip-port": "^2.0.0",
"bitfield": "^5.0.1",
"bittorrent-dht": "^11.0.11",
- "bittorrent-protocol": "^5.0.0",
+ "bittorrent-protocol": "^5.0.2",
"cache-c... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,953 | issue_to_patch | exception: torrent is destroyed
**What version of this package are you using?**
2.5.17
**What operating system, Node.js, and npm version?**
ubuntu node 22.11.0
**What happened?**
every once in awhile (e.g. 100 calls), I get this thrown out of context:
```
Error: torrent is destroyed
at Torrent.critical (file... | fix: bad file iterator code | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
Rewrote some code I didn't... | 0dde45421d1b65687ac3c8c563c1af6d3de619a0 | 0e5033047e0dc8d2f5b45b0cd1b854481c518b77 | diff --git a/lib/file-iterator.js b/lib/file-iterator.js
index 3055e19abd..533338053f 100644
--- a/lib/file-iterator.js
+++ b/lib/file-iterator.js
@@ -10,6 +10,7 @@ const debug = debugFactory('webtorrent:file-iterator')
* @param {Object} opts
* @param {number} opts.start iterator slice of file, starting from this b... | [
"lib/file-iterator.js",
"lib/file.js"
] | [] | true | |
webtorrent/webtorrent | 2,996 | issue_to_patch | fix: simplify service worker documentation | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
fixed docs for sw, previou... | bef8a0ccd73235077412dd85483f35912eae606f | f2360f0953aa1de36e89f8d76ad8e5d210799ade | diff --git a/README.md b/README.md
index 3ccf30054e..f94009606b 100644
--- a/README.md
+++ b/README.md
@@ -31,7 +31,7 @@ other torrent clients.
In the browser, WebTorrent uses **WebRTC** (data channels) for peer-to-peer transport.
It can be used **without** browser plugins, extensions, or installations. It's Just
-... | [
"README.md",
"docs/api.md",
"docs/faq.md",
"docs/get-started.md",
"docs/tutorials.md",
"index.js",
"test/browser/server.js"
] | [] | diff --git a/test/browser/server.js b/test/browser/server.js
index 5668e16c83..9dcb853551 100644
--- a/test/browser/server.js
+++ b/test/browser/server.js
@@ -21,7 +21,7 @@ if (!global?.process?.versions?.electron) {
return torrent.files[0].streamURL
}, 'Stream URL without server')
function check... | true | |
webtorrent/webtorrent | 2,993 | issue_to_patch | fix(deps): update dependency debug to ^4.4.3 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [debug](https://redirect.github.com/debug-js/debug) | [`^4.4.1` -> `^4.4.3`](https://renovatebot.com/diffs/npm/debug/4.... | 40c13811e30202091779f80e5b9e92b8497d2bee | fa5ae31372177ea15d1eb12bc842ce7c8afbbb1c | diff --git a/package.json b/package.json
index d3976d1469..df32db31c1 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,7 @@
"cpus": "^1.0.3",
"create-torrent": "^6.1.0",
"cross-fetch-ponyfill": "^1.0.3",
- "debug": "^4.4.1",
+ "debug": "^4.4.3",
"escape-html": "^1.0.3",
"fs-chunk... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,988 | issue_to_patch | chore(deps): update babel monorepo to v7.28.5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://redirect.github.com/babel/babel/tree/HEAD/pa... | 7909a3ecb9d02af447c1e3a580012e300374218c | 8b775e4ca090d2365b7f02d54c11276d7b36c5e9 | diff --git a/package.json b/package.json
index df32db31c1..1a3607aa9e 100644
--- a/package.json
+++ b/package.json
@@ -78,10 +78,10 @@
"ut_pex": "^4.0.4"
},
"devDependencies": {
- "@babel/core": "7.28.0",
- "@babel/eslint-parser": "^7.28.0",
+ "@babel/core": "7.28.5",
+ "@babel/eslint-parser": "^... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,994 | issue_to_patch | fix: setting throttleDownload as a float causes error | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[X ] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
This PR updates the imp... | 03e97dcbb83f29d476b9dc4a0aaa7582d2261c97 | c5fb39ec6b6f7cdb9070428f9f26a147d95d2778 | diff --git a/index.js b/index.js
index a351bf8dc6..c4ed6f9fc7 100644
--- a/index.js
+++ b/index.js
@@ -435,9 +435,9 @@ export default class WebTorrent extends EventEmitter {
*/
throttleDownload (rate) {
rate = Number(rate)
- if (isNaN(rate) || !isFinite(rate) || rate < -1) return false
- this._downloa... | [
"index.js"
] | [] | true | ||
webtorrent/webtorrent | 3,001 | issue_to_patch | perf: dont spam downloadSpeed, calculate requests correctly for webseeds | <!-- DO NOT POST LINKS OR REFERENCES TO COPYRIGHTED CONTENT IN YOUR ISSUE. -->
**What is the purpose of this pull request? (put an "X" next to item)**
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
**What changes did you make? (Give an overview)**
performance imploded
**Wh... | 52ef1754245b5699d7d71ff5de27cc3f42e96de2 | 112e4227b5e7c74c600167c7792240735259e439 | diff --git a/lib/torrent.js b/lib/torrent.js
index 6ff0780ceb..288479c1da 100644
--- a/lib/torrent.js
+++ b/lib/torrent.js
@@ -1606,9 +1606,21 @@ export default class Torrent extends EventEmitter {
// to allow function hoisting
const self = this
- const minOutstandingRequests = getBlockPipelineLength(wir... | [
"lib/torrent.js"
] | [] | true | ||
webtorrent/webtorrent | 2,998 | issue_to_patch | chore(deps): update dependency finalhandler to v2.1.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [finalhandler](https://redirect.github.com/pillarjs/finalhandler) | [`2.1.0` β `2.1.1`](https://renovatebot.com/diffs/n... | fd8f39e1560c5ae5db6b12153077877f0f33b076 | c743941f53541a502e0afc32cc4c37925d2f3e5b | diff --git a/package.json b/package.json
index 1a3607aa9e..929d540e50 100644
--- a/package.json
+++ b/package.json
@@ -98,7 +98,7 @@
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-n": "^16.6.2",
"eslint-plugin-promise": "^6.6.0",
- "finalhandler": "2.1.0",
+ "finalhandler": "2.1.1",
"networ... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,963 | issue_to_patch | fix(deps): update dependency pump to ^3.0.4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [pump](https://redirect.github.com/mafintosh/pump) | [`^3.0.2` β `^3.0.4`](https://renovatebot.com/diffs/npm/pump/3.0.2... | 02bfbc529af17371894af77eecb205e781552fe4 | 0cae405dcd00a6f4a65541feed133d1e3e07ed66 | diff --git a/package.json b/package.json
index 929d540e50..70e72a52c8 100644
--- a/package.json
+++ b/package.json
@@ -61,7 +61,7 @@
"mime": "^3.0.0",
"once": "^1.4.0",
"parse-torrent": "^11.0.18",
- "pump": "^3.0.2",
+ "pump": "^3.0.4",
"queue-microtask": "^1.2.3",
"random-iterate": "^1.... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,005 | issue_to_patch | chore(deps): update babel monorepo | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://redirect.github.com/babel/babel/tree/HEAD/pa... | efadcddd2ecf289e6cca2dfe0c6903142352e7fd | 6dd740b125b9ec205b4a97c92c11a9ec9ea349ae | diff --git a/package.json b/package.json
index 70e72a52c8..f65dad8b3a 100644
--- a/package.json
+++ b/package.json
@@ -78,10 +78,10 @@
"ut_pex": "^4.0.4"
},
"devDependencies": {
- "@babel/core": "7.28.5",
- "@babel/eslint-parser": "^7.28.5",
- "@babel/plugin-syntax-import-assertions": "7.27.1",
- ... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,025 | issue_to_patch | fix(deps): update webtorrent | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@thaunknown/simple-peer](https://redirect.github.com/thaunknown/simple-peer) | [`^10.0.11` β `^10.1.1`](https://renova... | c7793ee1f99a8384f2bb0dfd60c833fbb68550d3 | b78f9c81bfad84620f2d99f310601798237b25aa | diff --git a/package.json b/package.json
index f65dad8b3a..7b6b15ff72 100644
--- a/package.json
+++ b/package.json
@@ -38,12 +38,12 @@
},
"dependencies": {
"@silentbot1/nat-api": "^0.4.9",
- "@thaunknown/simple-peer": "^10.0.11",
+ "@thaunknown/simple-peer": "^10.1.1",
"@webtorrent/http-node": "^1... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,944 | issue_to_patch | chore(deps): update dependency webpack to ^5.107.0 | > βΉοΈ **Note**
>
> This PR body was truncated due to platform limits.
This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [webpack](https://redirect.github.com/webpack/we... | ceeca15788e01a605879686779790fa59c0070b7 | afc9501ba9166390dcae77a64c1a4c5c64c990eb | diff --git a/package.json b/package.json
index 7b6b15ff72..46697ac83c 100644
--- a/package.json
+++ b/package.json
@@ -112,7 +112,7 @@
"tape": "^5.9.0",
"terser-webpack-plugin": "^5.3.14",
"timers-browserify": "^2.0.12",
- "webpack": "^5.99.5",
+ "webpack": "^5.107.0",
"webpack-cli": "^6.0.1",... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,028 | issue_to_patch | fix(deps): update dependency bitfield to v5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bitfield](https://redirect.github.com/fb55/bitfield) | [`^4.2.0` β `^5.0.1`](https://renovatebot.com/diffs/npm/bitfiel... | 65ea9b57ccd062e7b9501819d2947ef8a316dec9 | 7a5e44d3502c84485bc431c918ab5c845a5af9c6 | diff --git a/package.json b/package.json
index 46697ac83c..4731a115b7 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
"@thaunknown/simple-peer": "^10.1.1",
"@webtorrent/http-node": "^1.3.0",
"addr-to-ip-port": "^2.0.0",
- "bitfield": "^4.2.0",
+ "bitfield": "^5.0.1",
"bittorrent... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,022 | issue_to_patch | chore(deps): update dependency serve-static to v2.2.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [serve-static](https://redirect.github.com/expressjs/serve-static) | [`2.2.0` β `2.2.1`](https://renovatebot.com/diffs/... | 64cf6c3e106065db2f8d28292fd8a4d2ace4ed5a | 4426730d8cd0feaee96bff63f9c5f83203d432d3 | diff --git a/package.json b/package.json
index 4731a115b7..842941db2f 100644
--- a/package.json
+++ b/package.json
@@ -105,7 +105,7 @@
"querystring": "^0.2.1",
"run-series": "1.1.9",
"semantic-release": "22.0.12",
- "serve-static": "2.2.0",
+ "serve-static": "2.2.1",
"stream-browserify": "^3.0... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,023 | issue_to_patch | fix(deps): update dependency uint8-util to ^2.2.6 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [uint8-util](https://redirect.github.com/ThaUnknown/uint8-util) | [`^2.2.5` β `^2.2.6`](https://renovatebot.com/diffs/n... | dff24c6ab093ec4ea5b09afe0da02e5c562cab97 | fca6f3eba5b344d8cd7e6e7031aae13276dfe135 | diff --git a/package.json b/package.json
index 842941db2f..2a13ffa347 100644
--- a/package.json
+++ b/package.json
@@ -72,7 +72,7 @@
"throughput": "^1.0.2",
"torrent-discovery": "^11.0.19",
"torrent-piece": "^3.0.2",
- "uint8-util": "^2.2.5",
+ "uint8-util": "^2.2.6",
"unordered-array-remove":... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,024 | issue_to_patch | fix(deps): update dependency streamx to v2.25.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [streamx](https://redirect.github.com/mafintosh/streamx) | [`2.22.1` β `2.25.0`](https://renovatebot.com/diffs/npm/stre... | 79c6cdbe5384675ea37c5381de266032546936f5 | 4e3044b8c8e767c69f590cb4055f5aaf83a04378 | diff --git a/package.json b/package.json
index 2a13ffa347..0a937562cd 100644
--- a/package.json
+++ b/package.json
@@ -68,7 +68,7 @@
"run-parallel": "^1.2.0",
"run-parallel-limit": "^1.1.0",
"speed-limiter": "^1.0.2",
- "streamx": "2.22.1",
+ "streamx": "2.25.0",
"throughput": "^1.0.2",
"... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,026 | issue_to_patch | fix(deps): update dependency ut_metadata to v5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [ut_metadata](https://redirect.github.com/webtorrent/ut_metadata) | [`^4.0.3` β `^5.0.0`](https://renovatebot.com/diffs... | 2343c881c3bdd478723038f5777bd2ed461c082b | 3550a8d67e372bc49dfc33c11aa0b1ceb3240ab9 | diff --git a/package.json b/package.json
index 0a937562cd..cd5d16dadb 100644
--- a/package.json
+++ b/package.json
@@ -74,7 +74,7 @@
"torrent-piece": "^3.0.2",
"uint8-util": "^2.2.6",
"unordered-array-remove": "^1.0.2",
- "ut_metadata": "^4.0.3",
+ "ut_metadata": "^5.0.0",
"ut_pex": "^4.0.4"
... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 3,021 | issue_to_patch | fix(deps): update dependency bittorrent-protocol to v5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [bittorrent-protocol](https://redirect.github.com/webtorrent/bittorrent-protocol) | [`^4.1.21` β `^5.0.0`](https://reno... | cf40b0f06581f4254d883740083e2a0182ea31f5 | b774194740ad3dca7f08075e35e7b613e4ee3e2b | diff --git a/package.json b/package.json
index cd5d16dadb..53afa4ec08 100644
--- a/package.json
+++ b/package.json
@@ -43,7 +43,7 @@
"addr-to-ip-port": "^2.0.0",
"bitfield": "^5.0.1",
"bittorrent-dht": "^11.0.11",
- "bittorrent-protocol": "^4.1.21",
+ "bittorrent-protocol": "^5.0.0",
"cache-ch... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,964 | issue_to_patch | chore(deps): update dependency eslint-plugin-import to ^2.32.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [eslint-plugin-import](https://redirect.github.com/import-js/eslint-plugin-import) | [`^2.31.0` β `^2.32.0`](https://re... | 91351a505c626ed901dd7b4c2dff14a69a559d00 | 3bc481b75d24a8b35c6253d62e41a7fcd1f11f6b | diff --git a/package.json b/package.json
index 53afa4ec08..c21085814b 100644
--- a/package.json
+++ b/package.json
@@ -95,7 +95,7 @@
"disc": "1.3.3",
"eslint": "^8.57.1",
"eslint-config-standard": "^17.1.0",
- "eslint-plugin-import": "^2.31.0",
+ "eslint-plugin-import": "^2.32.0",
"eslint-plug... | [
"package.json"
] | [] | true | ||
webtorrent/webtorrent | 2,999 | issue_to_patch | chore(deps): update dependency terser-webpack-plugin to ^5.6.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [terser-webpack-plugin](https://redirect.github.com/webpack/minimizer-webpack-plugin) | [`^5.3.14` β `^5.6.0`](https://... | 49b6665542caf268044a4821ee3e377ad269477b | b1499757b35c22714dce98bab907cddb0537ba24 | diff --git a/package.json b/package.json
index c21085814b..3cdaae0807 100644
--- a/package.json
+++ b/package.json
@@ -110,7 +110,7 @@
"tap-parser": "^16.0.1",
"tap-spec": "^5.0.0",
"tape": "^5.9.0",
- "terser-webpack-plugin": "^5.3.14",
+ "terser-webpack-plugin": "^5.6.0",
"timers-browserify"... | [
"package.json"
] | [] | true | ||
webview/webview | 1,352 | issue_to_patch | Add Zig Binding | a4caad73f0ce3e311de8c90be3f0bbfdb1530d83 | 05cfd0174d99dac07e8b2606a978b344b3fc03da | diff --git a/README.md b/README.md
index 0706795f5..e6bf54c83 100644
--- a/README.md
+++ b/README.md
@@ -486,7 +486,7 @@ Rust | [Boscop/web-view](https://github.com/Boscop/web-view)
Swift | [jakenvac/SwiftWebview](https://github.com/jakenvac/SwiftWebview)
V | [malisipi/mui](https://github.com/m... | [
"README.md"
] | [] | true | |||
webview/webview | 1,351 | issue_to_patch | Add PHP webview extension | 9a608c2ce21521f2e1006df2003970cf02871ede | bab1789641a5a3bf0978fe0c2dd5b4a8fe0428dd | diff --git a/README.md b/README.md
index af2bc3fdb..0706795f5 100644
--- a/README.md
+++ b/README.md
@@ -479,7 +479,7 @@ Node.js | [Winterreisender/webview-nodejs](https://github.com/Winterreisende
Odin | [thechampagne/webview-odin](https://github.com/thechampagne/webview-odin)
Pascal | [PierceNg/fpwe... | [
"README.md"
] | [] | true | |||
webview/webview | 1,349 | issue_to_patch | docs: use README.md as mainpage | This project now distributed on `Windows` as [webview](https://packages.msys2.org/base/mingw-w64-webview) packages via [MSYS2](https://www.msys2.org/) distro.
We use there changes as patch in https://github.com/msys2/MINGW-packages/pull/27860. | 1a447a4a5d6856f194dbb69e3762983a21fa4788 | 55a8c8ebbfd0e5a288c7652655f7b3bf8cdd388f | diff --git a/docs/api/CMakeLists.txt b/docs/api/CMakeLists.txt
index 0f22366b8..8192defa4 100644
--- a/docs/api/CMakeLists.txt
+++ b/docs/api/CMakeLists.txt
@@ -10,6 +10,7 @@ set(CONFIG_SUFFIX "")
set(DOXYFILE_HAVE_DOT YES)
set(DOXYFILE_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/output${CONFIG_SUFFIX}")
set(DOXYF... | [
"docs/api/CMakeLists.txt",
"docs/api/Doxyfile.in"
] | [] | true | ||
webview/webview | 1,307 | issue_to_patch | add MoonBit language binding | f1a9d6b6fb8bcc2e266057224887a3d628f30f90 | 08ec6745dd3349c27ec2ed530dd1bbb1ce424ded | diff --git a/README.md b/README.md
index b48d0ea9e..01d986d87 100644
--- a/README.md
+++ b/README.md
@@ -473,6 +473,7 @@ Haskell | [lettier/webviewhs](https://github.com/lettier/webviewhs)
Janet | [janet-lang/webview](https://github.com/janet-lang/webview)
Java | [webview/webview_java](https://github... | [
"README.md"
] | [] | true | |||
webview/webview | 1,331 | issue_to_patch | Add PHP binding | Add PHP language binding | 40278e3749463893bb3e7a82f348790ecbf48c23 | 7a60d71adf00b46611633286714344f7eab9e11c | diff --git a/README.md b/README.md
index 3ad70bf85..948725f6d 100644
--- a/README.md
+++ b/README.md
@@ -478,7 +478,7 @@ Node.js | [Winterreisender/webview-nodejs](https://github.com/Winterreisende
Odin | [thechampagne/webview-odin](https://github.com/thechampagne/webview-odin)
Pascal | [PierceNg/fpwe... | [
"README.md"
] | [] | true | ||
webview/webview | 1,325 | issue_to_patch | Update README: Add Ring bindings | f9cbb69abe5d875bb7c4bafe8329340462ad1ca9 | ff0c8b5a8666f867b3b2311239eb762d9394756e | diff --git a/README.md b/README.md
index b48d0ea9e..3ad70bf85 100644
--- a/README.md
+++ b/README.md
@@ -479,6 +479,7 @@ Odin | [thechampagne/webview-odin](https://github.com/thechampagne/webvie
Pascal | [PierceNg/fpwebview](http://github.com/PierceNg/fpwebview)
Python | [congzhangzh/webview_python](... | [
"README.md"
] | [] | true | |||
webview/webview | 1,343 | issue_to_patch | Avoid warning when char is unsigned | char's signedness is implementationβdefined.
[https://en.cppreference.com/w/cpp/language/types.html](https://en.cppreference.com/w/cpp/language/types.html) -> Character types ->
`The signedness of char depends on the compiler and the target platform: the defaults for ARM and PowerPC are typically unsigned, the defa... | 55b438dc11d0e46bc68526822380963ae9d362af | c01504618cc8e19536a714368ae120c4ec8e81b0 | diff --git a/core/include/webview/detail/json.hh b/core/include/webview/detail/json.hh
index 401b4768b..ff248d61c 100644
--- a/core/include/webview/detail/json.hh
+++ b/core/include/webview/detail/json.hh
@@ -183,7 +183,10 @@ constexpr bool is_json_special_char(char c) {
c == '\r' || c == '\t';
}
-constexp... | [
"core/include/webview/detail/json.hh"
] | [
{
"comment": "May be *unsigned*.",
"path": "core/include/webview/detail/json.hh",
"hunk": "@@ -183,7 +183,10 @@ constexpr bool is_json_special_char(char c) {\n c == '\\r' || c == '\\t';\n }\n \n-constexpr bool is_ascii_control_char(char c) { return c >= 0 && c <= 0x1f; }\n+constexpr bool is_asc... | true | ||
webview/webview | 1,343 | comment_to_fix | Avoid warning when char is unsigned | May be *unsigned*. | 55b438dc11d0e46bc68526822380963ae9d362af | c01504618cc8e19536a714368ae120c4ec8e81b0 | diff --git a/core/include/webview/detail/json.hh b/core/include/webview/detail/json.hh
index 401b4768b..ff248d61c 100644
--- a/core/include/webview/detail/json.hh
+++ b/core/include/webview/detail/json.hh
@@ -183,7 +183,10 @@ constexpr bool is_json_special_char(char c) {
c == '\r' || c == '\t';
}
-constexp... | [
"core/include/webview/detail/json.hh"
] | [
{
"comment": "May be *unsigned*.",
"path": "core/include/webview/detail/json.hh",
"hunk": "@@ -183,7 +183,10 @@ constexpr bool is_json_special_char(char c) {\n c == '\\r' || c == '\\t';\n }\n \n-constexpr bool is_ascii_control_char(char c) { return c >= 0 && c <= 0x1f; }\n+constexpr bool is_asc... | true | ||
webview/webview | 1,328 | issue_to_patch | Fix Policy CMP0174 warning on Windows | According to CMake documentation, the ``CONFIGURE_COMMAND`` keyword (here set to an empty string) is a no-op:
<img width="790" height="187" alt="image" src="https://github.com/user-attachments/assets/ce91fb12-5922-4368-a3e9-96bf740b29f1" />
Since CMake version 3.31, this causes a warning (example from [my CI](https... | f9cbb69abe5d875bb7c4bafe8329340462ad1ca9 | 3d0a07d1089bbdff064b3541acca12abb86fc37c | diff --git a/cmake/webview.cmake b/cmake/webview.cmake
index 897656610..e2a6acb0a 100644
--- a/cmake/webview.cmake
+++ b/cmake/webview.cmake
@@ -84,8 +84,7 @@ function(webview_fetch_mswebview2 VERSION)
endif()
set(FC_NAME microsoft_web_webview2)
FetchContent_Declare(${FC_NAME}
- URL "https://www.n... | [
"cmake/webview.cmake"
] | [] | true | ||
webview/webview | 1,322 | issue_to_patch | Use GTK compat function with WEBVIEW_HINT_FIXED | `gtk_widget_set_size_request()` was called when `WEBVIEW_HINT_FIXED` was passed into `webview_set_size()`. That function is meant to set a minimum size.
Instead we can call `gtk_window_set_default_size()` (GTK 4) or `gtk_window_resize()` (GTK 3). | 2fde37c7305863daae7cbbde97a693e53ce345ad | cb436f624e416130be9e296ddf52a5544575ec2c | diff --git a/core/include/webview/detail/backends/gtk_webkitgtk.hh b/core/include/webview/detail/backends/gtk_webkitgtk.hh
index f44db8f29..06d83e1d7 100644
--- a/core/include/webview/detail/backends/gtk_webkitgtk.hh
+++ b/core/include/webview/detail/backends/gtk_webkitgtk.hh
@@ -182,9 +182,9 @@ protected:
noresul... | [
"core/include/webview/detail/backends/gtk_webkitgtk.hh"
] | [] | true | ||
webview/webview | 1,321 | issue_to_patch | set_size documentation discrepancy (GTK 4)
I've observed some behavior that is inconsistent with what is documented for `webview_set_size()` when using GTK 4.
The documentation states the following:
```
* - GTK 4 can set a default/initial window size if done early enough;
* otherwise, this function has no effect... | Update set_size() documentation | Removes some details about expected behavior of `webview_set_size()` due to inconsistencies observed when using GTK 4.
The documentation states the following:
> GTK 4 can set a default/initial window size if done early enough;
> otherwise, this function has no effect. GTK 4 (unlike 3) can't resize
> a window af... | 2fde37c7305863daae7cbbde97a693e53ce345ad | 79b670684d2747a991c21a652be8149cc9daf75e | diff --git a/core/include/webview/api.h b/core/include/webview/api.h
index 72e6a6722..aecc050e0 100644
--- a/core/include/webview/api.h
+++ b/core/include/webview/api.h
@@ -129,13 +129,12 @@ WEBVIEW_API webview_error_t webview_set_title(webview_t w, const char *title);
* Updates the size of the native window.
*
*... | [
"core/include/webview/api.h"
] | [
{
"comment": "```suggestion\r\n * - Subsequent calls to this function may behave inconsistently across different\r\n```",
"path": "core/include/webview/api.h",
"hunk": "@@ -129,13 +129,12 @@ WEBVIEW_API webview_error_t webview_set_title(webview_t w, const char *title);\n * Updates the size of the nativ... | true | |
webview/webview | 1,321 | comment_to_fix | Update set_size() documentation | ```suggestion
* - Subsequent calls to this function may behave inconsistently across different
``` | 2fde37c7305863daae7cbbde97a693e53ce345ad | 79b670684d2747a991c21a652be8149cc9daf75e | diff --git a/core/include/webview/api.h b/core/include/webview/api.h
index 72e6a6722..aecc050e0 100644
--- a/core/include/webview/api.h
+++ b/core/include/webview/api.h
@@ -129,13 +129,12 @@ WEBVIEW_API webview_error_t webview_set_title(webview_t w, const char *title);
* Updates the size of the native window.
*
*... | [
"core/include/webview/api.h"
] | [
{
"comment": "```suggestion\r\n * - Subsequent calls to this function may behave inconsistently across different\r\n```",
"path": "core/include/webview/api.h",
"hunk": "@@ -129,13 +129,12 @@ WEBVIEW_API webview_error_t webview_set_title(webview_t w, const char *title);\n * Updates the size of the nativ... | true | ||
webview/webview | 1,318 | issue_to_patch | limited platform support
https://github.com/webview/webview/blob/f1a9d6b6fb8bcc2e266057224887a3d628f30f90/cmake/webview.cmake#L11
might be better off being the `else` branch here.
according to https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_NAME.html there are quite a few platforms that do support `webkit2g... | Alt and bsd support | With this patch all systems supporting `pkg-config` can use this library, not just `Linux` based ones. | f1a9d6b6fb8bcc2e266057224887a3d628f30f90 | 8e0c6c60545b84565bb068dacd6cd957e7206bb9 | diff --git a/cmake/webview.cmake b/cmake/webview.cmake
index 6d603cef8..897656610 100644
--- a/cmake/webview.cmake
+++ b/cmake/webview.cmake
@@ -8,7 +8,19 @@ endmacro()
macro(webview_find_dependencies)
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
list(APPEND WEBVIEW_DEPENDENCIES "-framework WebKit" dl)
- e... | [
"cmake/webview.cmake"
] | [] | true | |
webview/webview | 1,304 | issue_to_patch | Fix typo in documentation for `webview_terminate` function | f1a9d6b6fb8bcc2e266057224887a3d628f30f90 | 091dbb951002a06c0caecaf4611c19871781bef6 | diff --git a/core/include/webview/api.h b/core/include/webview/api.h
index c9101b2f4..72e6a6722 100644
--- a/core/include/webview/api.h
+++ b/core/include/webview/api.h
@@ -74,7 +74,7 @@ WEBVIEW_API webview_error_t webview_destroy(webview_t w);
WEBVIEW_API webview_error_t webview_run(webview_t w);
/**
- * Stops the... | [
"core/include/webview/api.h"
] | [] | true | |||
webview/webview | 1,288 | issue_to_patch | Remove set_owns_window() | Passing a flag in the constructor of `engine_base` is less error-prone. | d1408d5e5ab929114a51f42a7c354028ef5a0d0c | 645e5e8ce34f3d3e8b72b086b622a65ad5f3e69c | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index c829a7b3d..1a0a2c6c7 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -89,7 +89,7 @@ using namespace webkit;
clas... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edge.hh",
"core/include/webview/detail/engine_base.hh"
] | [] | true | ||
webview/webview | 1,287 | issue_to_patch | macOS: Associated webview refactor | Correctness and code readability in the macOS browser backend has been improved:
* Calls to `objc_setAssociatedObject()` have been wrapped, reducing duplicate code.
* `OBJC_ASSOCIATION_ASSIGN` has been replaced with `OBJC_ASSOCIATION_RETAIN` with an appropriate Objective-C type (`NSValue *`) rather than casting an ... | 922a796eb8fbec243ecf91e9222647c76df6c86d | 76ed14f201c920748727472c0e54c17dc90b4a33 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index ebe91d3bf..c829a7b3d 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -318,8 +318,7 @@ private:
objc_regist... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSValue.hh",
"core/include/webview/detail/platform/darwin/cocoa/cocoa.hh"
] | [] | true | ||
webview/webview | 1,286 | issue_to_patch | Sleep before retry try_create_environment for WebView2 | For Windows WebView2 engine
This patch will add 200ms delay before retry `try_create_environment` and up to 12s
This is for a very edge case but I have encountered, the controller will fail creating.
To reproduce that situation:
1. create a clear and WebView2 installed Windows image (i.e. vm image)
2. set ... | a4a77aedac8a0a2977c6ef9b5c1129d1d056e0fc | da97a870a1a39df8246f9bbcaa02d6e728d21b17 | diff --git a/core/include/webview/detail/backends/win32_edge.hh b/core/include/webview/detail/backends/win32_edge.hh
index f552d95b9..18466d787 100644
--- a/core/include/webview/detail/backends/win32_edge.hh
+++ b/core/include/webview/detail/backends/win32_edge.hh
@@ -219,6 +219,8 @@ public:
if (res == HRESULT_F... | [
"core/include/webview/detail/backends/win32_edge.hh"
] | [] | true | ||
webview/webview | 1,285 | issue_to_patch | Remove user-defined literal operators | The `_cls`, `_sel` and `_str` UDL operators/suffixes have been removed to avoid a messy situation.
The UDLs can't cleanly be used without `using namespace`, which adds noise to functions, and when used at namespace scope then we pollute the namespace. The UDLs are so widely in the `cocoa` and `webkit` namespaces tha... | e0b81bdcb712f705d8ef9035a35caa58a9e0caec | 12ded9e9c6ee8cf80f897d9b865028e9b2fa12d8 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index bc5313b95..ebe91d3bf 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -280,12 +280,14 @@ private:
// Note: ... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSBundle.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSEvent.hh",
"core/include/webview/detail/platform/darwin/cocoa/NS... | [] | true | ||
webview/webview | 1,284 | issue_to_patch | Use void return type internally in objc::release() | Corrects the return type used with `msg_send()` in `objc::release()`. This correction has no impact on behavior. | 2d6132e980670827a213c1384441cd48e93ae6c4 | 4d60c884185898c8c80b9b401338bce85832a47a | diff --git a/core/include/webview/detail/platform/darwin/objc/memory.hh b/core/include/webview/detail/platform/darwin/objc/memory.hh
index b65b109e5..4d5b95200 100644
--- a/core/include/webview/detail/platform/darwin/objc/memory.hh
+++ b/core/include/webview/detail/platform/darwin/objc/memory.hh
@@ -53,7 +53,7 @@ inlin... | [
"core/include/webview/detail/platform/darwin/objc/memory.hh"
] | [] | true | ||
webview/webview | 1,277 | issue_to_patch | macOS Objective-C refactor | This work refactors code that uses Objective-C runtime invocations and makes such code more manageable.
This initial work does the following:
* Extracts code from the Cocoa/WebKit browser backend file (`cocoa_webkit.hh`) into separate files.
* Wraps Objective-C method calls into C++ functions. Some convenience f... | 81b172099c8bdf4ba2ae6e990d3dba56a02f7695 | eb28a108dba1ba7bf7a7146cfc6bc9f3f2b1d491 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index 8fee813ca..bc5313b95 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -44,9 +44,9 @@
#include "../../types.hh"
... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSBundle.hh",
"core/include/webview/detail/platform/darwin/cocoa/NSEvent.hh",
"core/include/webview/detail/platform/darwin/cocoa/NS... | [
{
"comment": "Typo spotted: `WKWebVie_`",
"path": "core/include/webview/detail/platform/darwin/webkit/WKWebView.hh",
"hunk": "@@ -0,0 +1,115 @@\n+/*\n+ * MIT License\n+ *\n+ * Copyright (c) 2017 Serge Zaitsev\n+ * Copyright (c) 2022 Steffen AndrΓ© Langnes\n+ *\n+ * Permission is hereby granted, free of c... | true | ||
webview/webview | 1,277 | comment_to_fix | macOS Objective-C refactor | Typo spotted: `WKWebVie_` | 81b172099c8bdf4ba2ae6e990d3dba56a02f7695 | eb28a108dba1ba7bf7a7146cfc6bc9f3f2b1d491 | diff --git a/core/include/webview/detail/platform/darwin/webkit/WKWebView.hh b/core/include/webview/detail/platform/darwin/webkit/WKWebView.hh
new file mode 100644
index 000000000..ea8e207d8
--- /dev/null
+++ b/core/include/webview/detail/platform/darwin/webkit/WKWebView.hh
@@ -0,0 +1,106 @@
+/*
+ * MIT License
+ *
+ *... | [
"core/include/webview/detail/platform/darwin/webkit/WKWebView.hh"
] | [
{
"comment": "Typo spotted: `WKWebVie_`",
"path": "core/include/webview/detail/platform/darwin/webkit/WKWebView.hh",
"hunk": "@@ -0,0 +1,115 @@\n+/*\n+ * MIT License\n+ *\n+ * Copyright (c) 2017 Serge Zaitsev\n+ * Copyright (c) 2022 Steffen AndrΓ© Langnes\n+ *\n+ * Permission is hereby granted, free of c... | true | ||
webview/webview | 1,277 | comment_to_fix | macOS Objective-C refactor | Can we `using namespace cocoa;` only once at the top of the namespace declaration? Could save a lot of repetition. | 81b172099c8bdf4ba2ae6e990d3dba56a02f7695 | eb28a108dba1ba7bf7a7146cfc6bc9f3f2b1d491 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index 8fee813ca..bc5313b95 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -44,9 +44,9 @@
#include "../../types.hh"
... | [
"core/include/webview/detail/backends/cocoa_webkit.hh"
] | [
{
"comment": "Can we `using namespace cocoa;` only once at the top of the namespace declaration? Could save a lot of repetition.",
"path": "core/include/webview/detail/backends/cocoa_webkit.hh",
"hunk": "@@ -98,41 +96,42 @@ public:\n cocoa_wkwebview_engine &operator=(cocoa_wkwebview_engine &&) = delet... | true | ||
webview/webview | 1,277 | comment_to_fix | macOS Objective-C refactor | Is there a reason we can't use `#pragma once` instead of named guards? | 81b172099c8bdf4ba2ae6e990d3dba56a02f7695 | eb28a108dba1ba7bf7a7146cfc6bc9f3f2b1d491 | diff --git a/core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh b/core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh
new file mode 100644
index 000000000..671f5a8c6
--- /dev/null
+++ b/core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh
@@ -0,0 +1,107 @@
+/*
+ * MIT Licens... | [
"core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh"
] | [
{
"comment": "Is there a reason we can't use `#pragma once` instead of named guards?",
"path": "core/include/webview/detail/platform/darwin/cocoa/NSApplication.hh",
"hunk": "@@ -0,0 +1,113 @@\n+/*\n+ * MIT License\n+ *\n+ * Copyright (c) 2017 Serge Zaitsev\n+ * Copyright (c) 2022 Steffen AndrΓ© Langnes\n... | true | ||
webview/webview | 1,275 | issue_to_patch | Adjustments to handling of long-running tests | There has been a problem for some time where the first test that cold-starts an MS WebView2 instance in a GitHub Actions environment may be severely delayed and result in a timeout. The delay has been observed to range from nearly no time to a minute or longer.
While this doesn't solve the root cause, it should at l... | 615a72c3d46edf117cc90ada3d4f1a780058441a | 15dccac36dd716653f738df1d4f8bc98851c65ea | [
"core/tests/CMakeLists.txt",
"core/tests/src/functional_tests.cc",
"core/tests/src/unit_tests.cc",
"test_driver/cmake/discovery.cmake",
"test_driver/cmake/generate_includes.cmake"
] | [] | diff --git a/core/tests/CMakeLists.txt b/core/tests/CMakeLists.txt
index 8f24fcce4..93548afd6 100644
--- a/core/tests/CMakeLists.txt
+++ b/core/tests/CMakeLists.txt
@@ -4,7 +4,15 @@ if(MSVC)
add_compile_options(/utf-8)
endif()
-add_executable(webview_core_tests)
-target_sources(webview_core_tests PRIVATE src/te... | true | ||
webview/webview | 1,272 | issue_to_patch | Refactor refine to accomodate maintainers preferences | With relation to:
- #1267
- #1270
- #1271
- #1269
@SteffenL This is a draft PR to keep track of the code style and preferences we have been discussing.
The diffs here will become a lot less noisy as the above mentioned PR's are merged.
~CI is expected to fail until then.~ | 05dd816fbb3a27ade60a429b1814db95a9b9704d | 7ed7c87d9a42ad28ab85ae02cce7cc4c70ca01c4 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index 28d46febf..8fee813ca 100755
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -86,10 +86,10 @@ private:
class cocoa_wkweb... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edge.hh",
"core/include/webview/detail/engine_base.hh"
] | [] | true | ||
webview/webview | 1,271 | issue_to_patch | Ability to set initial size of the window
When calling `webview::set_size` on windows, you can see the window briefly appear at a default size before changing to the desired size, which is jarring. Ideally either:
1. The webview concstructor takes an initial size
2. The webview constructor doesn't create the window, ... | Fix no-show window issue and refactor cocoa webkit | This PR:
- Fixes an issue where the window was not showing if the user did not set a size
- Refactors cocoa_webkit to a more standardised backend code flow
| 4ecaa15ba2f4804c2b3fe626d9494ade185ca4a6 | 977eb2e40a4eed0c7f3ca8a325e52bd3a75bfc3d | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
old mode 100644
new mode 100755
index 1fe3ee582..28d46febf
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -86,39 +86,10 @@ pr... | [
"core/include/webview/detail/backends/cocoa_webkit.hh"
] | [
{
"comment": "`window_init()` can be called twice but theoretically endlessly (if not now then potentially in the future). Is that intentional?\r\n\r\nThere are a few things that prevent an endless loop but I believe the most important one is the fact that the `NSApplicationDidFinishLaunchingNotification` notif... | true | |
webview/webview | 1,271 | comment_to_fix | Fix no-show window issue and refactor cocoa webkit | `window_init()` can be called twice but theoretically endlessly (if not now then potentially in the future). Is that intentional?
There are a few things that prevent an endless loop but I believe the most important one is the fact that the `NSApplicationDidFinishLaunchingNotification` notification is only sent once.... | 4ecaa15ba2f4804c2b3fe626d9494ade185ca4a6 | 977eb2e40a4eed0c7f3ca8a325e52bd3a75bfc3d | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
old mode 100644
new mode 100755
index 1fe3ee582..28d46febf
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -86,39 +86,10 @@ pr... | [
"core/include/webview/detail/backends/cocoa_webkit.hh"
] | [
{
"comment": "`window_init()` can be called twice but theoretically endlessly (if not now then potentially in the future). Is that intentional?\r\n\r\nThere are a few things that prevent an endless loop but I believe the most important one is the fact that the `NSApplicationDidFinishLaunchingNotification` notif... | true | ||
webview/webview | 1,271 | comment_to_fix | Fix no-show window issue and refactor cocoa webkit | Is this check needed? Before, `m_window` was unconditionally initialized in the constructor's member initializer list. | 4ecaa15ba2f4804c2b3fe626d9494ade185ca4a6 | 977eb2e40a4eed0c7f3ca8a325e52bd3a75bfc3d | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
old mode 100644
new mode 100755
index 1fe3ee582..28d46febf
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -86,39 +86,10 @@ pr... | [
"core/include/webview/detail/backends/cocoa_webkit.hh"
] | [
{
"comment": "Is this check needed? Before, `m_window` was unconditionally initialized in the constructor's member initializer list.",
"path": "core/include/webview/detail/backends/cocoa_webkit.hh",
"hunk": "@@ -649,6 +597,59 @@ private:\n }\n return temp;\n }\n+ void window_init(void *window... | true | ||
webview/webview | 1,268 | issue_to_patch | Refactor cocoa_webkit for DRY get_shared_application | Adds global `m_app` which is initiated in the class constructor to reduce multiple calls to `app = get_shared_application()` | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | af4e15d5aff82db9f14235184eba29b400e40300 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index d30e9fc5c..1fe3ee582 100644
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -87,22 +87,22 @@ class cocoa_wkwebview_engin... | [
"core/include/webview/detail/backends/cocoa_webkit.hh"
] | [] | true | ||
webview/webview | 1,270 | issue_to_patch | Ability to set initial size of the window
When calling `webview::set_size` on windows, you can see the window briefly appear at a default size before changing to the desired size, which is jarring. Ideally either:
1. The webview concstructor takes an initial size
2. The webview constructor doesn't create the window, ... | Fix window rendering glitch and refactor win32 edge | This PR:
- Fixes a visual issue where the default size was set before the user size, causing a rendering glitch
- Refactors win32_edge to a more standardised backend code flow | 4ecaa15ba2f4804c2b3fe626d9494ade185ca4a6 | 3b63699f49c8fa58a887252350db827f712f18bb | diff --git a/core/include/webview/detail/backends/win32_edge.hh b/core/include/webview/detail/backends/win32_edge.hh
index 50d3b723f..0baf5f1b1 100644
--- a/core/include/webview/detail/backends/win32_edge.hh
+++ b/core/include/webview/detail/backends/win32_edge.hh
@@ -309,6 +309,202 @@ private:
class win32_edge_engine... | [
"core/include/webview/detail/backends/win32_edge.hh"
] | [] | true | |
webview/webview | 1,269 | issue_to_patch | Ability to set initial size of the window
When calling `webview::set_size` on windows, you can see the window briefly appear at a default size before changing to the desired size, which is jarring. Ideally either:
1. The webview concstructor takes an initial size
2. The webview constructor doesn't create the window, ... | Fix default size glitch and refactor webkitgtk | This PR:
- fixes a default sizing glitch behaviour at variance across Linux desktop environments
- refactors gtk_webkitgtk to a more standardised backend code flow | 4ecaa15ba2f4804c2b3fe626d9494ade185ca4a6 | 9f5656669a07bdaf465d2682898db8c0d720f381 | diff --git a/core/include/webview/detail/backends/gtk_webkitgtk.hh b/core/include/webview/detail/backends/gtk_webkitgtk.hh
index 2010803c5..b53aec164 100644
--- a/core/include/webview/detail/backends/gtk_webkitgtk.hh
+++ b/core/include/webview/detail/backends/gtk_webkitgtk.hh
@@ -99,55 +99,10 @@ private:
class gtk_w... | [
"core/include/webview/detail/backends/gtk_webkitgtk.hh"
] | [] | true | |
webview/webview | 1,267 | issue_to_patch | Enable backend refactoring | Adds methods and members to engine base that enable addressing issues and refactoring from #1249 | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | 29f77edf80b8008cf920fcf9051a405ebb2ddd05 | diff --git a/core/include/webview/detail/engine_base.hh b/core/include/webview/detail/engine_base.hh
index 53d03db2a..ae319d536 100644
--- a/core/include/webview/detail/engine_base.hh
+++ b/core/include/webview/detail/engine_base.hh
@@ -136,6 +136,7 @@ window.__webview__.onUnbind(" +
noresult set_title(const std::st... | [
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "Could this variable be more descriptive, e.g. `m_has_added_internal_init_script`?",
"path": "core/include/webview/detail/engine_base.hh",
"hunk": "@@ -200,6 +201,7 @@ protected:\n \n void add_init_script(const std::string &post_fn) {\n add_user_script(create_init_script(post_fn));\n+... | true | ||
webview/webview | 1,267 | comment_to_fix | Enable backend refactoring | Could this variable be more descriptive, e.g. `m_has_added_internal_init_script`? | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | 29f77edf80b8008cf920fcf9051a405ebb2ddd05 | diff --git a/core/include/webview/detail/engine_base.hh b/core/include/webview/detail/engine_base.hh
index 53d03db2a..ae319d536 100644
--- a/core/include/webview/detail/engine_base.hh
+++ b/core/include/webview/detail/engine_base.hh
@@ -136,6 +136,7 @@ window.__webview__.onUnbind(" +
noresult set_title(const std::st... | [
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "Could this variable be more descriptive, e.g. `m_has_added_internal_init_script`?",
"path": "core/include/webview/detail/engine_base.hh",
"hunk": "@@ -200,6 +201,7 @@ protected:\n \n void add_init_script(const std::string &post_fn) {\n add_user_script(create_init_script(post_fn));\n+... | true | ||
webview/webview | 1,267 | comment_to_fix | Enable backend refactoring | Seems like it might either be better for `engine_base` to have knowledge of whether the window is owned, or to remove this parameter and instead leave the decision up to the caller.
If you want `engine_base` to make a decision based on whether the window is owned, then it seems like the former would be the way to go... | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | 29f77edf80b8008cf920fcf9051a405ebb2ddd05 | diff --git a/core/include/webview/detail/engine_base.hh b/core/include/webview/detail/engine_base.hh
index 53d03db2a..ae319d536 100644
--- a/core/include/webview/detail/engine_base.hh
+++ b/core/include/webview/detail/engine_base.hh
@@ -136,6 +136,7 @@ window.__webview__.onUnbind(" +
noresult set_title(const std::st... | [
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "Seems like it might either be better for `engine_base` to have knowledge of whether the window is owned, or to remove this parameter and instead leave the decision up to the caller.\r\n\r\nIf you want `engine_base` to make a decision based on whether the window is owned, then it seems like the for... | true | ||
webview/webview | 1,267 | comment_to_fix | Enable backend refactoring | Here this is more like a request to set the size because the size hasn't actually been set yet, and it could in theory fail. Does it mean "size has been set" or "size has been requested"? | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | 29f77edf80b8008cf920fcf9051a405ebb2ddd05 | diff --git a/core/include/webview/detail/engine_base.hh b/core/include/webview/detail/engine_base.hh
index 53d03db2a..ae319d536 100644
--- a/core/include/webview/detail/engine_base.hh
+++ b/core/include/webview/detail/engine_base.hh
@@ -136,6 +136,7 @@ window.__webview__.onUnbind(" +
noresult set_title(const std::st... | [
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "Here this is more like a request to set the size because the size hasn't actually been set yet, and it could in theory fail. Does it mean \"size has been set\" or \"size has been requested\"?",
"path": "core/include/webview/detail/engine_base.hh",
"hunk": "@@ -136,6 +136,7 @@ window.__webv... | true | ||
webview/webview | 1,267 | comment_to_fix | Enable backend refactoring | This is just a setter so would it make sense to rename the method to something like `enable_default_size_guard()`?
Also, I would either rename `m_is_size_set` or avoid reusing it because I'm still reading this as "size has been set/requested at least once", but when seeing how it's used it becomes a bit confusing.
... | 8a6cd6aa6be304618a5009bf5168ee57a4f6b399 | 29f77edf80b8008cf920fcf9051a405ebb2ddd05 | diff --git a/core/include/webview/detail/engine_base.hh b/core/include/webview/detail/engine_base.hh
index 53d03db2a..ae319d536 100644
--- a/core/include/webview/detail/engine_base.hh
+++ b/core/include/webview/detail/engine_base.hh
@@ -136,6 +136,7 @@ window.__webview__.onUnbind(" +
noresult set_title(const std::st... | [
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "This is just a setter so would it make sense to rename the method to something like `enable_default_size_guard()`?\r\n\r\nAlso, I would either rename `m_is_size_set` or avoid reusing it because I'm still reading this as \"size has been set/requested at least once\", but when seeing how it's used i... | true | ||
webview/webview | 1,265 | issue_to_patch | Temporary run loop refactor | Avoids some excess dispatching on Windows while organizing code better. | f1f42f0f164ec931ee05fae6e8bfaeba1c87b089 | d174f1bf850d8ac064f0e7fc66615a4821614bb0 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index 2840afa7c..d30e9fc5c 100644
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -653,17 +653,14 @@ private:
return temp... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edge.hh",
"core/include/webview/detail/engine_base.hh"
] | [
{
"comment": "In terms of #1249, this event depletion will be executed when a user calls `bind`, and if this is done before `set_size`, it will cause the problematic visual glitch. We also need to handle the `dispatch_size_default` \"future\" by doing something like:\r\n```c++\r\n// We want to guard against exe... | true | ||
webview/webview | 1,265 | comment_to_fix | Temporary run loop refactor | Not sure what happened here with the double while loop... | f1f42f0f164ec931ee05fae6e8bfaeba1c87b089 | d174f1bf850d8ac064f0e7fc66615a4821614bb0 | diff --git a/core/include/webview/detail/backends/win32_edge.hh b/core/include/webview/detail/backends/win32_edge.hh
index cf5ef82fa..50d3b723f 100644
--- a/core/include/webview/detail/backends/win32_edge.hh
+++ b/core/include/webview/detail/backends/win32_edge.hh
@@ -681,10 +681,8 @@ protected:
auto res =
... | [
"core/include/webview/detail/backends/win32_edge.hh"
] | [
{
"comment": "Not sure what happened here with the double while loop...",
"path": "core/include/webview/detail/backends/win32_edge.hh",
"hunk": "@@ -857,13 +855,10 @@ private:\n }\n }\n \n- // Blocks while depleting the run loop of events.\n- void deplete_run_loop_event_queue() {\n- bool done... | true | ||
webview/webview | 1,262 | issue_to_patch | Document set_size() behavior difference between GTK 3/4 | bc21f5507e3c94e75fb2a3e2f583f503eb0f4812 | 04aba36a4313b58a64a5d633f74a7e03023f1ca8 | diff --git a/core/include/webview/api.h b/core/include/webview/api.h
index 9ad55d6a6..915660257 100644
--- a/core/include/webview/api.h
+++ b/core/include/webview/api.h
@@ -130,6 +130,9 @@ WEBVIEW_API webview_error_t webview_set_title(webview_t w, const char *title);
* supported with GTK 4 because X11-specific func... | [
"core/include/webview/api.h",
"core/include/webview/detail/platform/linux/gtk/compat.hh"
] | [] | true | |||
webview/webview | 1,261 | issue_to_patch | Mention thread safety in readme and C API doc | Updates documentation to mention current thread safety guarantees in the library.
@citkane, this may be of interest to you. | bc21f5507e3c94e75fb2a3e2f583f503eb0f4812 | 787738310fb1506ff6c278a5cdf3070b89a913cc | diff --git a/README.md b/README.md
index 6b39d8775..b48d0ea9e 100644
--- a/README.md
+++ b/README.md
@@ -380,6 +380,14 @@ Here are some of the noteworthy ways our implementation of the loader differs fr
[Customization options](#Customization) can be used to change how the library integrates the WebView2 loader.
+#... | [
"README.md",
"core/include/webview/api.h"
] | [] | true | ||
webview/webview | 1,260 | issue_to_patch | C++11 compatibility for Windows | This work makes some changes that are necessary for lowering the minimum required C++ standard on Windows from C++14 to C++11.
I can't recall why `cxx_std_14` was set instead of `cxx_std_11` for the `MSWebView2::headers` CMake target but it may have been under the wrong belief that it wouldn't work with `cxx_std_11`... | e2bd2e55c5984e43ebb3cc92fe1ebcb727917cb2 | 7a280c46d7c9a7b2083c0ca2a4c0c217eba2f0cc | diff --git a/README.md b/README.md
index 45b2fa782..458e04952 100644
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@ The most up-to-date documentation is right in the source code. Improving the doc
## Prerequisites
-Your compiler must support minimum C++11 except for platforms that require a more modern version.... | [
"README.md",
"cmake/modules/FindMSWebView2.cmake",
"core/include/webview/detail/platform/windows/com_init_wrapper.hh",
"core/include/webview/detail/platform/windows/dpi.hh",
"core/include/webview/detail/platform/windows/version.hh",
"core/include/webview/detail/platform/windows/webview2/loader.hh"
] | [] | true | ||
webview/webview | 1,259 | issue_to_patch | Update Ubuntu GHA runner image from 20.04 to 22.04 | The ubuntu-20.04 image is scheduled for removal and this change is to avoid disruption.
https://github.com/actions/runner-images/issues/11101 | e2bd2e55c5984e43ebb3cc92fe1ebcb727917cb2 | 0f5d72e9eed66d2f8bff776193391ca87a856014 | diff --git a/.github/workflows/build_matrix.csv b/.github/workflows/build_matrix.csv
index b5f8bfce9..c88933b15 100644
--- a/.github/workflows/build_matrix.csv
+++ b/.github/workflows/build_matrix.csv
@@ -27,8 +27,8 @@ package,linux,ubuntu-22.04,host,11,llvm,-15,Ninja Multi-Config,FALSE,TRUE,TRUE,F
package,linux,ubunt... | [
".github/workflows/build_matrix.csv"
] | [] | true | ||
webview/webview | 1,258 | issue_to_patch | Amalgamation fixes and tests | Amalgamation script now fails by default when a header can't be found.
Missing headers can be explicitly allowed with a comment:
#include "xyz.h" // amalgamate(skip)
This is currently only used for MS WebView2 header "WebView2.h".
Inputs can now also be paths to directories in which any file or
directory... | e2bd2e55c5984e43ebb3cc92fe1ebcb727917cb2 | 91475e6f35e10cfb6ffb1fd02792e4f45eafdc5f | diff --git a/.github/workflows/check.yaml b/.github/workflows/check.yaml
index ca2c20b8c..8fe50e46d 100644
--- a/.github/workflows/check.yaml
+++ b/.github/workflows/check.yaml
@@ -14,6 +14,7 @@ jobs:
amalgamate:
runs-on: ${{ matrix.image }}
strategy:
+ fail-fast: false
matrix:
image:
... | [
".github/workflows/check.yaml",
"README.md",
"core/CMakeLists.txt",
"core/include/webview/backends.hh",
"core/include/webview/c_api_impl.hh",
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edg... | [] | diff --git a/scripts/amalgamate/test/.gitignore b/scripts/amalgamate/test/.gitignore
new file mode 100644
index 000000000..567609b12
--- /dev/null
+++ b/scripts/amalgamate/test/.gitignore
@@ -0,0 +1,1 @@
+build/
diff --git a/scripts/amalgamate/test/main.c b/scripts/amalgamate/test/main.c
new file mode 100644
index 0000... | true | |
webview/webview | 1,253 | issue_to_patch | Add Vala binding | Implement Vala binding, but yet support embed webview as a GTK4 widget, I need help.
@SteffenL Is something I missed? | e2bd2e55c5984e43ebb3cc92fe1ebcb727917cb2 | 0a83229fb3d1dd2b041ab31f54de900e22346b44 | diff --git a/README.md b/README.md
index 45b2fa782..a0a36717b 100644
--- a/README.md
+++ b/README.md
@@ -475,6 +475,7 @@ Ruby | [Maaarcocr/webview_ruby](https://github.com/Maaarcocr/webview_ruby
Rust | [Boscop/web-view](https://github.com/Boscop/web-view)
Swift | [jakenvac/SwiftWebview](https://gi... | [
"README.md"
] | [] | true | ||
webview/webview | 1,242 | issue_to_patch | CI test timeout | Sets a 60 second timeout for tests. There used to be a timeout in the past but after the switch to CMake/CTest and the test driver rewrite, no timeout had been set.
Dummy tests that sleep the thread show that the timeout works (10s here but later changed to 60s):
```
Start 6: Temporary test to ensure that... | 48cbaf5f6cceb45b42069b0a791dff42f5f18a16 | 6087b3fd5072230f464bfaa9cd7e038c589b3da0 | diff --git a/.github/actions/cmake/action.yaml b/.github/actions/cmake/action.yaml
index 5ab3d9cb4..11599fb43 100644
--- a/.github/actions/cmake/action.yaml
+++ b/.github/actions/cmake/action.yaml
@@ -56,6 +56,10 @@ inputs:
description: CMake source directory
required: false
default: .
+ test-timeout:
+... | [
".github/actions/cmake/action.yaml"
] | [] | true | ||
webview/webview | 1,241 | issue_to_patch | Include macros.h | Re-enables code syntax highlighting in code editors for files that enable code based on whether platform/backend-specific macros are defined.
Example:
#if defined(WEBVIEW_PLATFORM_LINUX) && defined(WEBVIEW_GTK)
#endif
Without the `macros.h` header, `WEBVIEW_PLATFORM_LINUX` and `WEBVIEW_GTK` would by d... | 9a358d9453d288d2560612a6fef2cf2efe67757f | d800c1c6778098368d0fb9b9cd7fe766b823e481 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index a0ddad56a..687a0c370 100644
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -23,10 +23,13 @@
* SOFTWARE.
*/
-#if !... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edge.hh",
"core/include/webview/detail/platform/darwin/cocoa.hh",
"core/include/webview/detail/platform/darwin/objc.hh",
"core/include/webview/detail... | [] | true | ||
webview/webview | 1,236 | issue_to_patch | Corrects the `hints` parameter type for `webview_set_size` | The type definition in 'api.h' for the 'hints' parameter of `webview_set_size` is `webview_hint_t`, but this is defined as `int` in the SWIG interface. This discrepancy causes compilation warnings and errors. | 04a6cd790ea0be56ca02eb0b88dbfc16746791b8 | 8e4dccdc9f8599aca1c7eabf10e0db6a1a41edc4 | diff --git a/webview.i b/webview.i
index 9714152b1..77e56f4a3 100644
--- a/webview.i
+++ b/webview.i
@@ -15,7 +15,7 @@ extern void webview_dispatch(webview_t w, void (*fn)(webview_t w, void *arg), vo
extern void *webview_get_window(webview_t w);
extern void *webview_get_native_handle(webview_t w, webview_native_handl... | [
"webview.i"
] | [] | true | ||
webview/webview | 1,235 | issue_to_patch | chore: changed link to shield build | 3b7e27fd3ec028e1fafcd46fac994860c204505f | 734adc3bcf0d5ec8be1cc408c05cd31ac166ec8c | diff --git a/README.md b/README.md
index 86d7ca279..45b2fa782 100644
--- a/README.md
+++ b/README.md
@@ -1,7 +1,7 @@
# webview
<a href="https://discord.gg/24KMecn" title="Join the chat at Discord"><img src="https://assets-global.website-files.com/6257adef93867e50d84d30e2/636e0b5061df29d55a92d945_full_logo_blurple_R... | [
"README.md"
] | [] | true | |||
webview/webview | 1,231 | issue_to_patch | gtk: fix error unconditionally triggering for webview_set_size | Prior to this PR, the function continues to execute the error return after the if-statements, causing the error to always trigger.
| 83a4b4a5bbcb4b0ba2ca3ee226c2da1414719106 | a72282c9c2b11efaed24288423f6c31122e27360 | diff --git a/core/include/webview/detail/backends/gtk_webkitgtk.hh b/core/include/webview/detail/backends/gtk_webkitgtk.hh
index 005a1337a..fb9984961 100644
--- a/core/include/webview/detail/backends/gtk_webkitgtk.hh
+++ b/core/include/webview/detail/backends/gtk_webkitgtk.hh
@@ -228,8 +228,10 @@ protected:
gtk_... | [
"core/include/webview/detail/backends/gtk_webkitgtk.hh"
] | [] | true | ||
webview/webview | 1,232 | issue_to_patch | fix typo in api documentation | 83a4b4a5bbcb4b0ba2ca3ee226c2da1414719106 | 251f53b6a3a809de4b54bb20a818cfa0b15b74e4 | diff --git a/core/include/webview/api.h b/core/include/webview/api.h
index 3f2755557..9ad55d6a6 100644
--- a/core/include/webview/api.h
+++ b/core/include/webview/api.h
@@ -222,7 +222,7 @@ WEBVIEW_API webview_error_t webview_unbind(webview_t w, const char *name);
* @param id The identifier of the binding call. Pass a... | [
"core/include/webview/api.h"
] | [] | true | |||
webview/webview | 1,212 | issue_to_patch | Update README.md | Add a modern Python binding | c5b19403382ef089f9933ea5331c76aa35414589 | c22365ff24eadd73d1e14dd4683723cac55a4571 | diff --git a/README.md b/README.md
index a9589c16c..29d50eb41 100644
--- a/README.md
+++ b/README.md
@@ -469,7 +469,7 @@ Nim | [oskca/webview](https://github.com/oskca/webview), [neroist/webvie
Node.js | [Winterreisender/webview-nodejs](https://github.com/Winterreisender/webview-nodejs)
Odin | [the... | [
"README.md"
] | [] | true | ||
webview/webview | 1,218 | issue_to_patch | user_script does not compile with clang++ -std=c++2b or -std=c++23
### What OS are you using (`uname -a`, or Windows version)?
macos, arm64 (should not matter)
### What programming language are you using (C/C++/Go/Rust)?
Apple clang version 16.0.0 (clang-1600.0.26.3)
### What did you expect to see and what... | Add C++23 to build matrix | Adds C++23 to build matrix for PRs only.
Since PR #1217 has not been merged yet, it's included here to prove that it fixes #1215. | 0c3f8577448a2737aee6ea0fb0c386de1c435766 | 83595e033d9a09fff78d3b6a0ec2388c0a47258b | diff --git a/.github/workflows/build_matrix.csv b/.github/workflows/build_matrix.csv
index 920623967..b5f8bfce9 100644
--- a/.github/workflows/build_matrix.csv
+++ b/.github/workflows/build_matrix.csv
@@ -3,10 +3,12 @@ package,linux,ubuntu-22.04,host,11,gnu,-12,Ninja Multi-Config,FALSE,FALSE,TRUE,F
package,linux,ubunt... | [
".github/workflows/build_matrix.csv"
] | [] | true | |
webview/webview | 1,220 | issue_to_patch | Generate build matrix job IDs | Generate IDs that match line numbers in the CSV file, making it more convenient to work with the file and review changes made to it.
Not the most correct way to do it but it gets the job done. | 37997357efa83aa4926e100d63a39a6b84aecb4b | 36f2fbbf2d27a9dc83f7f4e2ba2b84b2d72c90d3 | diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index d505b5835..2d749f833 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -38,6 +38,10 @@ jobs:
const schema = require("./.github/workflows/build_matrix_schema.json");
let include = csv.lo... | [
".github/workflows/build.yaml",
".github/workflows/build_matrix.csv",
".github/workflows/build_matrix_schema.json"
] | [] | true | ||
webview/webview | 1,219 | issue_to_patch | Fix/Suppress Clang Tidy 18 issues | Fixes and suppresses new issues observed when using Clang Tidy 18. | 12945f356ef76a1e1548149808ca186463c4d8dd | 6566eaf674998b205e3330649ef79bbcc52a41e1 | diff --git a/.clang-tidy b/.clang-tidy
index a76c9c715..4ab5cb2bd 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -41,6 +41,7 @@ Checks: >
-hicpp-use-override,
-hicpp-vararg,
-misc-definitions-in-headers,
+ -misc-include-cleaner,
-misc-non-private-member-variables-in-classes,
-modernize-avoid-... | [
".clang-tidy",
"README.md",
"core/tests/src/tests.cc",
"examples/basic.cc",
"examples/bind.cc",
"test_driver/include/webview/test_driver.hh"
] | [] | diff --git a/core/tests/src/tests.cc b/core/tests/src/tests.cc
index 31fdf2587..732c45893 100644
--- a/core/tests/src/tests.cc
+++ b/core/tests/src/tests.cc
@@ -17,12 +17,12 @@ TEST_CASE("Start app loop and terminate it") {
w.run();
}
-static void cb_assert_arg(webview_t w, void *arg) {
+void cb_assert_arg(webvie... | true | |
webview/webview | 1,217 | issue_to_patch | user_script does not compile with clang++ -std=c++2b or -std=c++23
### What OS are you using (`uname -a`, or Windows version)?
macos, arm64 (should not matter)
### What programming language are you using (C/C++/Go/Rust)?
Apple clang version 16.0.0 (clang-1600.0.26.3)
### What did you expect to see and what... | Fix deletion of incomplete type user_script::impl | When compiling in C++23 mode using Clang, compilation failed in `~unique_ptr()` due to user_script::impl being an incomplete type.
Issue was observed with Clang 16 and 18 on Linux/macOS, with C++23 set via `CMAKE_CXX_STANDARD`. C++20 and earlier did not yield an error.
The issue could not be observed with GCC 13.... | c5b19403382ef089f9933ea5331c76aa35414589 | e4c9afe6bbe99c3852a6b11eb048c870501eb1a4 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index d3473fa2c..a0ddad56a 100644
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -297,8 +297,9 @@ protected:
WKUserS... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/backends/gtk_webkitgtk.hh",
"core/include/webview/detail/backends/win32_edge.hh",
"core/include/webview/detail/user_script.hh"
] | [] | true | |
webview/webview | 1,028 | issue_to_patch | Disable status bar (Windows/WebView2)
The library should in my opinion disable the status bar displayed by WebView2 on Windows. See the bottom-left corner in the following screen capture.
[status_bar.webm](https://github.com/webview/webview/assets/1543854/d3ed32e6-da88-4736-b6a7-d9cf2e274a29)
The status bar appe... | Disable status bar (Windows/WebView2) | Closes #978. | 8c149b9e7b0a1b63c9c442657a8232740685edf8 | 34446b8582b0573dce7562dae12b51598b31a79b | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 03f81f361..8f260cf00 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- New compile-time options for controlling `WEBVIEW_API` ([#893](https://github.com/webview/webview/pull... | [
"CHANGELOG.md",
"webview.h"
] | [] | true | |
webview/webview | 1,198 | issue_to_patch | Add workflow for releasing | This work adds a manually-triggered GHA workflow for creating a draft release on GitHub. Once the automated build completes successfully, a release manager should manually edit the release draft and publish it.
Existing CMake- and GHA-related have been cleaned up a bit.
Discussion:
* #1199 | b19c598d8ceb863de6079d227ea46f23a797b4f2 | 23938cbfd775dbc101093d6ab9e12120011aabbf | diff --git a/.github/workflows/cmake/action.yaml b/.github/actions/cmake/action.yaml
similarity index 99%
rename from .github/workflows/cmake/action.yaml
rename to .github/actions/cmake/action.yaml
index 990ee8926..5ab3d9cb4 100644
--- a/.github/workflows/cmake/action.yaml
+++ b/.github/actions/cmake/action.yaml
@@ -19... | [
".github/actions/cmake/action.yaml",
".github/actions/setup-env/action.yaml",
".github/workflows/build.yaml",
".github/workflows/build_matrix.csv",
".github/workflows/build_matrix_schema.json",
".github/workflows/check.yaml",
".github/workflows/ci.yaml",
".github/workflows/draft-release.yaml",
"READ... | [] | true | ||
webview/webview | 1,203 | issue_to_patch | Relax local dev requirements when using CMake | When building the project with CMake in a local development environment, i.e. when `WEBVIEW_IS_CI` is not set to TRUE, skip the tasks that use missing optional dependencies. | 960b0183a3155d0b2cdf163aef0a2cb5cb267203 | cc4c323ad91edca4f66efe292ca8746f633884b8 | diff --git a/cmake/internal.cmake b/cmake/internal.cmake
index fe613dbb0..842355d7d 100644
--- a/cmake/internal.cmake
+++ b/cmake/internal.cmake
@@ -89,13 +89,9 @@ macro(webview_init)
if(WEBVIEW_ENABLE_CHECKS AND WEBVIEW_ENABLE_CLANG_FORMAT)
# Allow skipping clang-format outside of CI environment
... | [
"cmake/internal.cmake",
"core/CMakeLists.txt",
"docs/api/CMakeLists.txt"
] | [] | true | ||
webview/webview | 1,202 | issue_to_patch | Fix amalgamation script failing on Windows | The amalgamation script fails on Windows due to file locking/sharing issues.
This work creates a temporary directory instead without keeping any temporary files open.
A CI job was also added for testing the amalgamation script with different versions of Python on different platforms so that this type of issue wil... | a96b59e790d5e5976fadaad0884b669bd390475e | 636e09bc4d6b2f6f87ab14ec8892fb771fa7567e | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 95bde6b86..0e3060af7 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -35,6 +35,45 @@ jobs:
gcovr-version: ${{ needs.vars.outputs.gcovr-version }}
pr: true
+ amalgamate:
+ needs:
+ - check
+ -... | [
".github/workflows/ci.yaml",
"README.md",
"scripts/amalgamate.py"
] | [] | true | ||
webview/webview | 1,201 | issue_to_patch | Add missing package-dev column to build matrix | d0b01f440c854269a527b60d9769fcce6d5bdcdb | ff3091616a531d18abf1d5d4c569b1587ad7ee88 | diff --git a/.github/workflows/build_matrix.csv b/.github/workflows/build_matrix.csv
index 8da19894e..8a0044468 100644
--- a/.github/workflows/build_matrix.csv
+++ b/.github/workflows/build_matrix.csv
@@ -1,54 +1,54 @@
-id,job-type,os,image,arch,cxx-std,toolchain,toolchain-executable-suffix,generator,pr-only,checks,str... | [
".github/workflows/build_matrix.csv",
".github/workflows/build_matrix_schema.json"
] | [] | true | |||
webview/webview | 1,197 | issue_to_patch | Make EventToken.h compatible with C compilers | a48b108cd237ea93e9cf04f09751f0508d8c7656 | 17ffdec1f79588192410ab0d4cf47ac4a6de4408 | diff --git a/compatibility/mingw/include/EventToken.h b/compatibility/mingw/include/EventToken.h
index 61edd4e83..3099e66ba 100644
--- a/compatibility/mingw/include/EventToken.h
+++ b/compatibility/mingw/include/EventToken.h
@@ -9,7 +9,13 @@
// matters when cross-compiling on a system with case-sensitive file names.
... | [
"compatibility/mingw/include/EventToken.h"
] | [] | true | |||
webview/webview | 1,196 | issue_to_patch | MacOS X 10.11 El Capitan webkit issues
Got error on MacOS X 10.11 El Capitan
[832:153270] *** Terminating app due to uncaught exception 'NSUnknownKeyException', reason: '[<WKPreferences 0x49139d0> setValue:forUndefinedKey:]: this class is not key value coding-compliant for the key javaScriptCanAccessClipboard.'
**... | Runtime compatibility with old macOS | These changes allow an app built with the webview library to run on older versions of macOS.
Tested with the following versions of the operating system:
* OS X El Capitan 10.11
* macOS High Sierra 10.13
* macOS Sequoia 15 | b547cdca7691340c5555df1f1a3750795f99c906 | 325950d6e3b76d26dcc986b86ae7f2109f1cbf84 | diff --git a/core/include/webview/detail/backends/cocoa_webkit.hh b/core/include/webview/detail/backends/cocoa_webkit.hh
index a876759ac..d3473fa2c 100644
--- a/core/include/webview/detail/backends/cocoa_webkit.hh
+++ b/core/include/webview/detail/backends/cocoa_webkit.hh
@@ -547,15 +547,25 @@ private:
objc::msg_s... | [
"core/include/webview/detail/backends/cocoa_webkit.hh",
"core/include/webview/detail/engine_base.hh"
] | [] | true | |
williamfiset/algorithms | 1,316 | issue_to_patch | Refactor HashTableSeparateChaining: encapsulate Entry, fix iterator, simplify API | ## Summary
- Make `Entry` a private static inner class instead of top-level package-private
- Remove redundant method aliases (`add`/`insert`/`hasKey`) β keep `put`/`containsKey`
- Add dedicated `modCount` for fail-fast iteration (was using `size` as proxy)
- Rewrite iterator so `hasNext()` is idempotent and doesn't ad... | 69b49f7436afeff2b7572c9e7e9c58b9ad001307 | f3ead5f5a480117d614af5aabff5555d1c15028d | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChaining.java b/src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChaining.java
index 3de53deb6..b954f1b75 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/hashtable/Ha... | [
"src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChaining.java",
"src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChainingTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChainingTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableSeparateChainingTest.java
index a943f95e1..07bdd0ea8 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/hash... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.