repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
williamfiset/algorithms | 1,310 | issue_to_patch | Refactor Heapsort: add docs, simplify sink with for loop | ## Summary
- Added class-level Javadoc with time/space complexity
- Replaced `while (true)` + `break` in `sink()` with a `for` loop bounded by left child index
- Applied single-line body formatting rule
- Cleaned up comments and imports
## Test plan
- [x] All 10 existing HeapsortTest tests pass
- [x] Compiles and runs... | b55346614b6e6970927bae8f180137e38362fc5d | 15c03bda0a2036684ea5c287e399ef2d4e3d1a27 | diff --git a/src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java b/src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java
index 16265099d..35d3929a0 100644
--- a/src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java
+++ b/src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java
@@ ... | [
"src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java"
] | [] | true | ||
williamfiset/algorithms | 1,306 | issue_to_patch | Refactor FloydWarshallSolver: clean up, add docs, simplify examples | ## Summary
- Refactored FloydWarshallSolver: improved Javadoc, added constructor validation, made `n` final, added proper imports
- Applied single-line body formatting rule (body on new line)
- Simplified examples from 7-node graph to compact 4-node graphs covering negative cycle detection, path reconstruction, and unr... | f238846aaed4c1b13b83b328916c8571d53eb143 | 11219a0b92d5936045a87e0ce74c811a14e2ab05 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/FloydWarshallSolver.java b/src/main/java/com/williamfiset/algorithms/graphtheory/FloydWarshallSolver.java
index 7bf794f18..73e87e550 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/FloydWarshallSolver.java
+++ b/src/main/java/com/will... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/FloydWarshallSolver.java"
] | [] | true | ||
williamfiset/algorithms | 1,303 | issue_to_patch | Refactor EulerianPathDirectedEdgesAdjacencyList: add docs, clean up code | - Add comprehensive Javadoc with complexity and use cases
- Rename graph to adj for consistency
- Add educational comments explaining Hierholzer's algorithm
- Clean up example cases and move main method to bottom
- Ensure O(n + m) time and space complexity notation | b71af5ac8ff3f515951004b02a89b9ea662f22a2 | e065edcb88acd71544751b6a4448c61683c7289e | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/EulerianPathDirectedEdgesAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/EulerianPathDirectedEdgesAdjacencyList.java
index a919bf961..1a19861b4 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/EulerianPathDir... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/EulerianPathDirectedEdgesAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,317 | issue_to_patch | Refactor HashTableOpenAddressingBase: consolidate API and enhance docs | ## Summary
- Remove `insert`/`hasKey`/`add` method aliases — callers now use `put` and `containsKey` directly
- Add `ConcurrentModificationException` check in iterator's `next()` and remove redundant `remove()` override
- Expand class-level Javadoc explaining open addressing, tombstone semantics, and lazy relocation
- ... | bc6dfd6905f470ca38eb993a5d796330a2355dcb | 5d4e421c3e1e877765934ab9ee937a3a4319f6cb | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableOpenAddressingBase.java b/src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableOpenAddressingBase.java
index efd112539..f2241d8b2 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/hashtabl... | [
"src/main/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableOpenAddressingBase.java",
"src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableDoubleHashingTest.java",
"src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableLinearProbingTest.java",
"sr... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableDoubleHashingTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/hashtable/HashTableDoubleHashingTest.java
index 9db93d8bb..1e3fe3671 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/hashtable/... | true | |
williamfiset/algorithms | 1,315 | issue_to_patch | Refactor ModPow: fix overflow, simplify loop, add tests | ## Summary
- Replace fragile `MAX`/`MIN` overflow guards with overflow-safe `mulMod` via `BigInteger`, supporting the full `long` range
- Simplify bit-mask exponentiation loop to standard binary exponentiation
- Normalize base into `[0, mod)` upfront instead of repeated `+mod % mod` in the loop
- Remove `main()` and in... | 0e0dc0622c8ad5ddbd3b86de1a7c1b6dcd141a49 | 407a9240144faf8a5754ea2c91f13e77ed358641 | diff --git a/src/main/java/com/williamfiset/algorithms/math/ModPow.java b/src/main/java/com/williamfiset/algorithms/math/ModPow.java
index 94994396d..72163afe4 100644
--- a/src/main/java/com/williamfiset/algorithms/math/ModPow.java
+++ b/src/main/java/com/williamfiset/algorithms/math/ModPow.java
@@ -1,172 +1,73 @@
/**... | [
"src/main/java/com/williamfiset/algorithms/math/ModPow.java",
"src/test/java/com/williamfiset/algorithms/math/BUILD",
"src/test/java/com/williamfiset/algorithms/math/ModPowTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/math/BUILD b/src/test/java/com/williamfiset/algorithms/math/BUILD
index 8a33dd8de..0842a265d 100644
--- a/src/test/java/com/williamfiset/algorithms/math/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/math/BUILD
@@ -58,3 +58,14 @@ java_test(
runtime_deps... | true | |
williamfiset/algorithms | 1,314 | issue_to_patch | Refactor ChineseRemainderTheorem: reuse PrimeFactorization, add tests | ## Summary
- Remove 4 duplicated private methods (`primeFactorization`, `pollardRho`, `isPrime`, `gcf`) and delegate to the shared `PrimeFactorization` class
- Simplify `ListIterator`-based prime-power grouping with a cleaner index-based loop
- Clean up Javadoc with proper `@link` references and Unicode math notation
-... | 3d3a8855d7651d0b00c9723496d40dc6153cb0c3 | 5b83014bff585576e93607ab8149e7024323ca8e | diff --git a/README.md b/README.md
index fa11a9c3f..0a054c079 100644
--- a/README.md
+++ b/README.md
@@ -239,7 +239,7 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
# Mathematics
-- [[UNTESTED] Chinese remainder theorem](src/main/java/com/williamfiset/algorithms/math/ChineseRemainderTheorem.... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/math/ChineseRemainderTheorem.java",
"src/test/java/com/williamfiset/algorithms/math/BUILD",
"src/test/java/com/williamfiset/algorithms/math/ChineseRemainderTheoremTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/math/BUILD b/src/test/java/com/williamfiset/algorithms/math/BUILD
index 138ee1134..8a33dd8de 100644
--- a/src/test/java/com/williamfiset/algorithms/math/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/math/BUILD
@@ -47,3 +47,14 @@ java_test(
runtime_deps... | true | |
williamfiset/algorithms | 1,313 | issue_to_patch | Add Dynamic Programming on DAG (Kahn's Algorithm) with test cases | This PR adds an implementation of dynamic programming on directed acyclic graphs (DAGs)
using topological sorting (Kahn's algorithm).
The implementation demonstrates how to compute values in a DAG using a DP formulation
where transitions follow a topological order.
Included:
- Kahn-based topological sort
- Ex... | 92284a1ada574c2f8c5f98d56d87e0847a064f8b | a57a08f7c2ad636175e2a589ae8135be62c87888 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
new file mode 100644
index 000000000..025fe7808
--- /dev/null
+++ b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
@@ -0,0 +1,125 @@
+pa... | [
"src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java",
"src/test/java/com/williamfiset/algorithms/dp/DagDynamicProgrammingTest.java"
] | [
{
"comment": "Let's remove the MOD",
"path": "src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java",
"hunk": "@@ -0,0 +1,133 @@\n+package com.williamfiset.algorithms.dp;\n+\n+import java.util.*;\n+\n+/**\n+ * Dynamic Programming on Directed Acyclic Graphs (DAG).\n+ *\n+ * <p>This impl... | diff --git a/src/test/java/com/williamfiset/algorithms/dp/DagDynamicProgrammingTest.java b/src/test/java/com/williamfiset/algorithms/dp/DagDynamicProgrammingTest.java
new file mode 100644
index 000000000..9fdb47326
--- /dev/null
+++ b/src/test/java/com/williamfiset/algorithms/dp/DagDynamicProgrammingTest.java
@@ -0,0 +... | true | |
williamfiset/algorithms | 1,313 | comment_to_fix | Add Dynamic Programming on DAG (Kahn's Algorithm) with test cases | Let's remove the MOD | 92284a1ada574c2f8c5f98d56d87e0847a064f8b | a57a08f7c2ad636175e2a589ae8135be62c87888 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
new file mode 100644
index 000000000..025fe7808
--- /dev/null
+++ b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
@@ -0,0 +1,125 @@
+pa... | [
"src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java"
] | [
{
"comment": "Let's remove the MOD",
"path": "src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java",
"hunk": "@@ -0,0 +1,133 @@\n+package com.williamfiset.algorithms.dp;\n+\n+import java.util.*;\n+\n+/**\n+ * Dynamic Programming on Directed Acyclic Graphs (DAG).\n+ *\n+ * <p>This impl... | true | ||
williamfiset/algorithms | 1,313 | comment_to_fix | Add Dynamic Programming on DAG (Kahn's Algorithm) with test cases | The edge weight is unused, you're implicitly using an unweighted graph | 92284a1ada574c2f8c5f98d56d87e0847a064f8b | a57a08f7c2ad636175e2a589ae8135be62c87888 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
new file mode 100644
index 000000000..025fe7808
--- /dev/null
+++ b/src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java
@@ -0,0 +1,125 @@
+pa... | [
"src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java"
] | [
{
"comment": "The edge weight is unused, you're implicitly using an unweighted graph",
"path": "src/main/java/com/williamfiset/algorithms/dp/DagDynamicProgramming.java",
"hunk": "@@ -0,0 +1,133 @@\n+package com.williamfiset.algorithms.dp;\n+\n+import java.util.*;\n+\n+/**\n+ * Dynamic Programming on Dir... | true | ||
williamfiset/algorithms | 1,312 | issue_to_patch | Refactor PrimeFactorization: Miller-Rabin, simplify, add tests | ## Summary
- Replace trial-division `isPrime` (O(√n)) with deterministic Miller-Rabin (O(k log²n)), using 12 witnesses correct for all `long` values
- Replace PriorityQueue-based loop with simple recursive `factor` method
- Add overflow-safe `mulMod` and `powMod` for modular arithmetic on large values
- Use `mulMod` in... | 4cbda50d8f955c55b4e17c41922be0b03793406d | 8dde681e60d7ad029220bdd7673461c2c40a38ed | diff --git a/src/main/java/com/williamfiset/algorithms/math/PrimeFactorization.java b/src/main/java/com/williamfiset/algorithms/math/PrimeFactorization.java
index 85c497e08..c2cbfab61 100644
--- a/src/main/java/com/williamfiset/algorithms/math/PrimeFactorization.java
+++ b/src/main/java/com/williamfiset/algorithms/math... | [
"src/main/java/com/williamfiset/algorithms/math/PrimeFactorization.java",
"src/test/java/com/williamfiset/algorithms/math/BUILD",
"src/test/java/com/williamfiset/algorithms/math/PrimeFactorizationTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/math/BUILD b/src/test/java/com/williamfiset/algorithms/math/BUILD
index 12257dace..138ee1134 100644
--- a/src/test/java/com/williamfiset/algorithms/math/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/math/BUILD
@@ -26,6 +26,17 @@ java_test(
deps = TEST_... | true | |
williamfiset/algorithms | 1,311 | issue_to_patch | Refactor Lazy and Eager Prim's MST implementations | ## Summary
- Add Javadoc explaining lazy vs eager approaches, time/space complexity
- Use `Integer.compare()` instead of subtraction in `compareTo()` to avoid overflow
- Apply single-line body formatting rule throughout
- Trim the indexed priority queue in EagerPrims to only the operations needed by the algorithm (remo... | b55346614b6e6970927bae8f180137e38362fc5d | a8fba5e080c2732f64fa2a42eefc2be6718f01f8 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/EagerPrimsAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/EagerPrimsAdjacencyList.java
index 64ba0fce2..8a38c1590 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/EagerPrimsAdjacencyList.java
+++ b/src/main/j... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/EagerPrimsAdjacencyList.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/LazyPrimsAdjacencyList.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/test/java/com/williamfiset/algorithms/graphtheory/EagerPrimsAdjacencyLi... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
index 965b96e39..b4b1519e5 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -200,5 +200,27 @... | true | |
williamfiset/algorithms | 1,308 | issue_to_patch | Refactor TopologicalSortAdjacencyList: add docs, clean up | ## Summary
- Added Javadoc with `@param`/`@return` to public methods, added space complexity
- Applied single-line body formatting rule
- Renamed Edge constructor params from `f, t, w` to `from, to, weight`
- Reordered methods so public API comes before private helpers
- Cleaned up example in main()
## Test plan
- [x]... | 96ec0eb979ce4978e3c5e01d7e19bb654940c058 | 3755e4fd1a712e376c2180d6ade4dfe3bb3c8078 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/TopologicalSortAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/TopologicalSortAdjacencyList.java
index 71d6233ad..67e9ac552 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/TopologicalSortAdjacencyList.java
+... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/TopologicalSortAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,307 | issue_to_patch | Refactor TarjanSccSolver, remove TarjanAdjacencyMatrix | ## Summary
- Refactored TarjanSccSolverAdjacencyList: renamed `visited` to `onStack`, made fields final, added Javadoc, applied single-line body rule, resolved TODO comment
- Removed redundant TarjanAdjacencyMatrix and its BUILD target
## Test plan
- [x] All 8 existing TarjanSccSolverAdjacencyListTest tests pass
- [x]... | 96ec0eb979ce4978e3c5e01d7e19bb654940c058 | f28197e94c9a36473bab1361aa37e4f33a094db3 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
index 4a5e0ef1f..111ce2c23 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -181,12 +181,6 @... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/TarjanAdjacencyMatrix.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/TarjanSccSolverAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,305 | issue_to_patch | Refactor UnionFind: rename id to parent, use recursive find | ## Summary
- Rename the `id` array to `parent` for better readability and self-documenting code
- Replace the iterative `find` with the recursive path-compression implementation
## Test plan
- [x] Verify existing UnionFind tests pass
- [x] Confirm no other files reference the old `id` field
🤖 Generated with [Claude ... | b71af5ac8ff3f515951004b02a89b9ea662f22a2 | 1cdfc65300b589262a48f10d4723788dc030ea07 | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java b/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java
index 7d0a81dec..03514f845 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java
+++ b/src/main/java... | [
"src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java"
] | [] | true | ||
williamfiset/algorithms | 1,302 | issue_to_patch | Refactor Dijkstra shortest path implementations: clean up and simplify | ## Summary
- **DijkstrasShortestPathAdjacencyList**: Replace `Comparator` field/constructor with `Comparable` on `Node` using `Double.compare`, simplify `reconstructPath` with `LinkedList.addFirst()`, unbox `Integer` loop variable, remove unused `EPS` constant, use enhanced for-loop, inline `createEmptyGraph`, mark fie... | eba25c9e50256330874bc3015d0333294bdb4834 | 05089dec085db74d91a278a60f9cf98592a8d9f7 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/DijkstrasShortestPathAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/DijkstrasShortestPathAdjacencyList.java
index f1639bc04..3305b7f66 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/DijkstrasShortestPathAd... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/DijkstrasShortestPathAdjacencyList.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/DijkstrasShortestPathAdjacencyListWithDHeap.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/test/java/com/williamfiset/algorithms/g... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
index 930c75d75..965b96e39 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -178,5 +178,27 @... | true | |
williamfiset/algorithms | 1,300 | issue_to_patch | Refactor ConnectedComponentsDfs: rename, clean up, add docs | ## Summary
- Rename `ConnectedComponentsDfsSolverAdjacencyList` to `ConnectedComponentsDfs` for brevity
- Eliminate `visited` array by reusing `componentIds` with `-1` sentinel
- Make component IDs 0-indexed for consistency with the UnionFind variant
- Add Javadoc with time/space complexity, graph diagram, and `compone... | e6cac02d2beb76a7bd04f84fd1b9a35d56bb4fc2 | 7deb954680eaff6fdcc7c99130c8e8a7f2efd0cb | diff --git a/README.md b/README.md
index 8b9547c37..d0f2bf8bf 100644
--- a/README.md
+++ b/README.md
@@ -208,7 +208,7 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
- [Bridges/cut edges (adjacency list)](src/main/java/com/williamfiset/algorithms/graphtheory/BridgesAdjacencyList.java) **- O(V+E)*... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/ConnectedComponentsDfs.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/ConnectedComponentsDfsSolverAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,299 | issue_to_patch | Refactor ConnectedComponents: rename to UnionFind, clean up | ## Summary
- Rename `ConnectedComponentsAdjacencyList` to `ConnectedComponentsUnionFind` to distinguish from the DFS-based solver
- Replace `Map<Integer, List<Edge>>` with standard `List<List<Integer>>` adjacency list, removing the unnecessary `Edge` class with its `cost` field
- Move package-level `UnionFind` class to... | f829082f48359562e087f7b60ddecb34ad906b9a | 2545dd038ba075031db8ef1cc22fe732fc6da4e1 | diff --git a/README.md b/README.md
index d48667b3e..8b9547c37 100644
--- a/README.md
+++ b/README.md
@@ -207,7 +207,7 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
- [:movie_camera:](https://www.youtube.com/watch?v=oDqjPvD54Ss) [Breadth first search (adjacency list)](src/main/java/com/williamfi... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/ConnectedComponentsAdjacencyList.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/ConnectedComponentsUnionFind.java",
"src/test/java/com/williamfiset/algorithms/gra... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
index 6a610086b..930c75d75 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -24,6 +24,17 @@ ... | true | |
williamfiset/algorithms | 1,298 | issue_to_patch | Refactor Boruvkas | ## Summary
- Fix integer overflow bug in `Edge.compareTo` — replaced `cost - other.cost` with `Integer.compare(cost, other.cost)`
- Add class-level Javadoc with algorithm steps and time/space complexity
- Remove unused `connected()` and `size()` methods from internal UnionFind
- Replace `stop` flag with clearer `merged... | 7985f2840e931a4ee7a1d3765daf48073c9e58fa | 96e9813445fcbe6353dcc1bb91e7628cb4756cd2 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/Boruvkas.java b/src/main/java/com/williamfiset/algorithms/graphtheory/Boruvkas.java
index ff3dd82f2..331bcba7c 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/Boruvkas.java
+++ b/src/main/java/com/williamfiset/algorithms/graphtheory/B... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/Boruvkas.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/BoruvkasTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BoruvkasTest.java b/src/test/java/com/williamfiset/algorithms/graphtheory/BoruvkasTest.java
index 4d0585c65..6c084c501 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BoruvkasTest.java
+++ b/src/test/java/com/williamfiset/algorithms/g... | true | |
williamfiset/algorithms | 1,297 | issue_to_patch | Refactor BridgesAdjacencyList: add docs, clean up code | ## Summary
- Enhanced Javadoc with bridge definition, `ids[u] < low[v]` condition, cross-reference to ArticulationPointsAdjacencyList, and time/space complexity
- Made `n` and `graph` fields final
- Fixed code style: single-line bodies on separate lines, `int to` instead of `Integer to` to avoid autoboxing
- Removed re... | 5a8797a12d6f4f10c1fd8f829e7f3f8ed460404b | 7279faa165c10efed1765cf424e3c1ff112ae566 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
index 44970cd21..c152046b4 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/main/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -83,13 +83,6 @@ ... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/BridgesAdjacencyList.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/BridgesAdjacencyListIterative.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/te... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
index da8231b2c..a8713d525 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -57,17 +57,6 @@ ... | true | |
williamfiset/algorithms | 1,296 | issue_to_patch | Refactor BFS, remove FastQueue and Recursive duplicates | ## Summary
- Remove `BreadthFirstSearchAdjacencyListIterativeFastQueue.java` — custom `IntQueue` is redundant with `ArrayDeque`
- Remove `BreadthFirstSearchRecursive.java` — recursive BFS with queue-passing hack, not a true recursive BFS
- Refactor `BreadthFirstSearchAdjacencyListIterative.java` — add algorithm docs, m... | 5a8797a12d6f4f10c1fd8f829e7f3f8ed460404b | d4c4bce12517ecdbc179ad995601e0ea51c0b7ae | diff --git a/README.md b/README.md
index a338ca19a..d48667b3e 100644
--- a/README.md
+++ b/README.md
@@ -204,8 +204,7 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
- [Articulation points/cut vertices (adjacency list)](src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjac... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/BreadthFirstSearchAdjacencyList.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/BreadthFirstSearchAdjacencyListIterative.java",
"src/main/java/com/williamfiset/alg... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
index da8231b2c..60c23f1bd 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/graphtheory/BUILD
@@ -46,13 +46,13 @@... | true | |
williamfiset/algorithms | 1,295 | issue_to_patch | Remove LazyPrimsAdjacencyMatrix and TopologicalSortAdjacencyMatrix | ## Summary
- Remove `LazyPrimsAdjacencyMatrix.java` — redundant with `LazyPrimsAdjacencyList` and `EagerPrimsAdjacencyList`
- Remove `TopologicalSortAdjacencyMatrix.java` — redundant with `TopologicalSortAdjacencyList`
- Remove BUILD binary targets and README entries for both
No tests depended on either file.
## Test... | 793b07a5c7e0ff566d5fe4c6327a63508f6950d2 | 13b0583723914e4d1b4afe7982afcbe2f6bff855 | diff --git a/README.md b/README.md
index 8ac28587f..a338ca19a 100644
--- a/README.md
+++ b/README.md
@@ -223,12 +223,10 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
- [:movie_camera:](https://www.youtube.com/watch?v=JZBQLXgSGfs) [Kruskal's min spanning tree algorithm (edge list, union find, la... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/LazyPrimsAdjacencyMatrix.java",
"src/main/java/com/williamfiset/algorithms/graphtheory/TopologicalSortAdjacencyMatrix.java"
] | [] | true | ||
williamfiset/algorithms | 1,294 | issue_to_patch | Remove BellmanFordAdjacencyMatrix, migrate tests to BellmanFordEdgeList | ## Summary
- Remove `BellmanFordAdjacencyMatrix.java` — redundant with `BellmanFordEdgeList` and `BellmanFordAdjacencyList`
- Migrate `FloydWarshallSolverTest` and `BreadthFirstSearchAdjacencyListIterativeTest` to use `BellmanFordEdgeList` as the test oracle
- Remove BUILD binary target and README entry
## Test plan
-... | 8de04c1dc9a2b6e4037a17f3d4ba1447637770c0 | ff8db28e6fd7d5188aec59f22f9276b75bf297a6 | diff --git a/README.md b/README.md
index 106418ddf..8ac28587f 100644
--- a/README.md
+++ b/README.md
@@ -204,7 +204,6 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
- [Articulation points/cut vertices (adjacency list)](src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjac... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/BellmanFordAdjacencyMatrix.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/BreadthFirstSearchAdjacencyListIterativeTest.java",
"src/test/java/com/williamfiset/algo... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/BreadthFirstSearchAdjacencyListIterativeTest.java b/src/test/java/com/williamfiset/algorithms/graphtheory/BreadthFirstSearchAdjacencyListIterativeTest.java
index 917ef9b92..5161f0b54 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/Bre... | true | |
williamfiset/algorithms | 1,293 | issue_to_patch | Refactor FordFulkersonDfsSolverAdjacencyList: add docs, clean up code | ## Summary
- Enhanced class-level Javadoc with algorithm steps, min-cut explanation, and complexity notes
- Fixed code style: single-line if/for bodies on separate lines, removed unnecessary local variable
- Cleaned up example methods: renamed for clarity, removed commented-out code and verbose edge-printing loops, con... | 20b7e2990081a62a41418f36c010adb0acfc8171 | 400d467f8e60a353ea3199c5d929eaca8747bb91 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/FordFulkersonDfsSolverAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/FordFulkersonDfsSolverAdjacencyList.java
index 52c41bdf6..68022982f 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheo... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/FordFulkersonDfsSolverAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,292 | issue_to_patch | Refactor BipartiteGraphCheck: add docs, remove Utils dep, add visuals | ## Summary
- Added class-level Javadoc with algorithm description (DFS 2-coloring, odd-cycle detection), O(V+E) / O(V) complexity
- Removed `@SuppressWarnings("XorPower")` — made color constants explicit literals with explanatory comment
- Removed dependency on `Utils` library — added local `createGraph()` and `addUndi... | 20b7e2990081a62a41418f36c010adb0acfc8171 | cf2d9114cec3318a738c2502bc897a1095b993f6 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyList.java
index c8f0d36df..41b8535af 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/net... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyList.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyListTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyListTest.java b/src/test/java/com/williamfiset/algorithms/graphtheory/networkflow/BipartiteGraphCheckAdjacencyListTest.java
index 4768393ae..0f1af416a 100644
--- a/src/test/java/com/williamfiset/algorithms/graphth... | true | |
williamfiset/algorithms | 1,291 | issue_to_patch | Refactor TreeCenter: simplify algorithm, add docs and tests | ## Summary
- Added class-level Javadoc with algorithm description ("peeling leaf layers"), O(V+E) / O(V) complexity
- Simplified `findTreeCenters()` — removed intermediate variables and redundant `degree[node] = 0`
- Removed `@author Modifications by` line
- Replaced `LinkedList` with `ArrayList`, cleaned up imports
- ... | 8cd42bc0b5c444cadd855e0db9331f8e5f68703f | 9b6bad1a02e1c1b1cf511333b3a950de8ba1e196 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenter.java b/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenter.java
index 132b32ea0..5eb60093c 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenter.java
+++ b/src/... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenter.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenterTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenterTest.java b/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenterTest.java
index 783c3fc17..21b92fd5d 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeCenterTest.jav... | true | |
williamfiset/algorithms | 1,289 | issue_to_patch | Remove duplicate TreeIsomorphismWithBfs | ## Summary
- Deleted `TreeIsomorphismWithBfs.java` — duplicate of `TreeIsomorphism.java`
- Deleted `TreeIsomorphismWithBfsTest.java` and its BUILD entry
- Removed cross-impl comparison test from `TreeIsomorphismTest.java` that referenced the deleted class
- Removed `java_binary` BUILD entry for the deleted class
## Te... | 8cd42bc0b5c444cadd855e0db9331f8e5f68703f | 4ba7ba2dfbd2614b09e26171c918358cbec5bba9 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD b/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
index dfaf4c961..94da029c7 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
+++ b/src/main/java/com/williamfiset/alg... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsomorphismWithBfs.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD",
"src/test/java/com/williamfiset/algorithms/graphtheory... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
index e33fc8e4e..4e0d81ceb 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
+++ b/src/test/java/com/williamfiset/alg... | true | |
williamfiset/algorithms | 1,290 | issue_to_patch | Remove duplicate LowestCommonAncestor | ## Summary
- Deleted `LowestCommonAncestor.java` — duplicate of `LowestCommonAncestorEulerTour.java`
- Deleted `LowestCommonAncestorTest.java` and its BUILD entry
- Removed `java_binary` BUILD entry for the deleted class
## Test plan
- [x] `treealgorithms` library builds successfully
- [x] `LowestCommonAncestorEulerTo... | 8cd42bc0b5c444cadd855e0db9331f8e5f68703f | 40c8bcac68a49f88f6ba55066c261a157c03c9a5 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD b/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
index dfaf4c961..57c8853be 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
+++ b/src/main/java/com/williamfiset/alg... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD",
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/LowestCommonAncestor.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD",
"src/test/java/com/williamfiset/algorithms/graphtheory/t... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD b/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
index e33fc8e4e..c6b6fb948 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/BUILD
+++ b/src/test/java/com/williamfiset/alg... | true | |
williamfiset/algorithms | 1,288 | issue_to_patch | Refactor TreeIsomorphism with docs, diagrams, and README update | ## Summary
- Added comprehensive class-level Javadoc explaining the 3-step algorithm (find centers, encode, compare), with O(V*log(V)) time / O(V) space complexity
- Made `TreeNode` fields `final`, replaced `LinkedList` with `ArrayList`, expanded wildcard import
- Added Javadoc to `treesAreIsomorphic()`, `findTreeCente... | 90a66dfe892efcd8b43eaead2bd3ad4867c98efc | 78651347ea32ee6b0f13ef2ed294fa3c12ab6782 | diff --git a/README.md b/README.md
index 1d84d63cb..106418ddf 100644
--- a/README.md
+++ b/README.md
@@ -182,7 +182,7 @@ $ java -cp classes com.williamfiset.algorithms.search.BinarySearch
### Tree algorithms
- [:movie_camera:](https://www.youtube.com/watch?v=2FFq2_je7Lg) [Rooting an undirected tree](src/main/java/c... | [
"README.md",
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsomorphism.java",
"src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsomorphismTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsomorphismTest.java b/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsomorphismTest.java
index da79f3170..c5f840141 100644
--- a/src/test/java/com/williamfiset/algorithms/graphtheory/treealgorithms/TreeIsom... | true | |
williamfiset/algorithms | 1,286 | issue_to_patch | Refactor ArticulationPointsAdjacencyList with docs and comments | ## Summary
- Added comprehensive class-level Javadoc explaining Tarjan's algorithm, the articulation point condition (`ids[u] <= low[v]`), root node rule, and O(V+E) / O(V) complexity
- Added inline comments in DFS explaining disconnected component handling, subtree disconnection condition, and back edge low-link updat... | 3ae99f7f503806114e33d66f090176fd6f04859b | f0d1c0ca9239d2729c5c230bdf3956e8c815f6bc | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjacencyList.java b/src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjacencyList.java
index bd8cc51de..d2a710b24 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjacencyLi... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/ArticulationPointsAdjacencyList.java"
] | [] | true | ||
williamfiset/algorithms | 1,287 | issue_to_patch | Refactor RootingTree with docs, final fields, and diagrams | ## Summary
- Added clear class-level Javadoc with algorithm description and O(V+E) time / O(V) space complexity
- Made `id`, `parent`, `children` fields `final` in `TreeNode`
- Replaced `LinkedList` with `ArrayList` for better cache locality
- Replaced wildcard import `java.util.*` with explicit imports
- Added Javadoc... | 3ae99f7f503806114e33d66f090176fd6f04859b | 29d58bbc59c133cdf6d71de3971d98d42bf4d5e4 | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/RootingTree.java b/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/RootingTree.java
index 38b776046..b7c6dd4c2 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/RootingTree.java
+++ b/s... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/treealgorithms/RootingTree.java"
] | [] | true | ||
williamfiset/algorithms | 1,275 | issue_to_patch | Refactor Node segment tree: add docs, simplify, expand tests | ## Summary
- Add detailed file-level header explaining lazy propagation and tree layout
- Fix package/header order, make all fields private, add Javadoc on public methods
- Remove 9 unnecessary null checks in `update()`/`sum()`/`min()` — partial overlap only occurs at internal nodes where children are guaranteed non-nu... | 2b9b29258bf95658535289bc0b80bd0280ef00e7 | df955a2e9480ee06136bc820055e155ba092b159 | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/Node.java b/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/Node.java
index 00279ac4f..59bab0eb8 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/Node.java
+++ b/src/main/java/com/will... | [
"src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/Node.java",
"src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/SegmentTreeWithPointersTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/SegmentTreeWithPointersTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/SegmentTreeWithPointersTest.java
index a2c524ce2..b1ae610be 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/segm... | true | |
williamfiset/algorithms | 1,264 | issue_to_patch | Fix IntArray bugs, add bounds checks and tests | ## Summary
- **Fix `removeAt` decrementing `capacity`** — was corrupting capacity tracking, causing premature resizes after removals
- **Fix `add()` off-by-one** — resize check `len + 1 >= capacity` wasted one slot; changed to `len == capacity`
- **Add bounds checks** to `get`, `set`, and `removeAt` (previously allowed... | 50945b325fe574add1dd6961e0ce0887d1e95b27 | f1c4aaeeff1a27d23725261441455722cef4708f | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/dynamicarray/IntArray.java b/src/main/java/com/williamfiset/algorithms/datastructures/dynamicarray/IntArray.java
index 623a5a87f..1cafae26b 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/dynamicarray/IntArray.java
+++ b/src/mai... | [
"src/main/java/com/williamfiset/algorithms/datastructures/dynamicarray/IntArray.java",
"src/test/java/com/williamfiset/algorithms/datastructures/dynamicarray/BUILD",
"src/test/java/com/williamfiset/algorithms/datastructures/dynamicarray/IntArrayTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/dynamicarray/BUILD b/src/test/java/com/williamfiset/algorithms/datastructures/dynamicarray/BUILD
new file mode 100644
index 000000000..8c29df560
--- /dev/null
+++ b/src/test/java/com/williamfiset/algorithms/datastructures/dynamicarray/BUILD
@@ -0,0 +... | true | |
williamfiset/algorithms | 1,283 | issue_to_patch | Refactor TspDynamicProgrammingIterative with docs and phase comments | ## Summary
- Added file header explaining the iterative bitmask DP approach and recurrence relation
- Added Javadoc on all public methods (`getTour`, `getTourCost`, `solve`, `combinations`)
- Labeled solve() phases: seed memo table, build subsets, close tour, reconstruct path
- Added cross-reference to `TspDynamicProgr... | ca0a498aef1062b5f6c7cb6731b397881aa781e5 | 82b7d01e8038f6bb8369712760ecc032c67b82df | diff --git a/src/main/java/com/williamfiset/algorithms/graphtheory/TspDynamicProgrammingIterative.java b/src/main/java/com/williamfiset/algorithms/graphtheory/TspDynamicProgrammingIterative.java
index a75509b8f..9bd9557d6 100644
--- a/src/main/java/com/williamfiset/algorithms/graphtheory/TspDynamicProgrammingIterative.... | [
"src/main/java/com/williamfiset/algorithms/graphtheory/TspDynamicProgrammingIterative.java"
] | [] | true | ||
williamfiset/algorithms | 1,284 | issue_to_patch | Refactor LongestPalindromeSubsequence: add iterative solver, docs, an… | Refactor LongestPalindromeSubsequence: add iterative solver, documentation, and tests.
- Synchronized with master
- Resolved build conflict in src/test/java/com/williamfiset/algorithms/dp/BUILD
- Verified all 8 DP tests pass using Bazel | 339f9519670dd229a22772ee0ea7344b7754f213 | 03334d3eff1fd3864af82e06c5c756ae603fad72 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/LongestPalindromeSubsequence.java b/src/main/java/com/williamfiset/algorithms/dp/LongestPalindromeSubsequence.java
index febab0566..8d7ceae8e 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/LongestPalindromeSubsequence.java
+++ b/src/main/java/com/will... | [
"src/main/java/com/williamfiset/algorithms/dp/LongestPalindromeSubsequence.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/LongestPalindromeSubsequenceTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index 882c1baad..9890160fd 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -94,5 +94,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,280 | issue_to_patch | Refactor 0/1 and unbounded knapsack, add tests | ## Summary
- Refactor `Knapsack_01.java`: add docs, extract `knapsackItems()` with detailed backtracking explanation, remove dead code, cross-reference unbounded variant
- Refactor `KnapsackUnbounded.java`: add docs with section headers for both implementations, explain key difference from 0/1 (same-row lookup for reus... | cc2a7494e9e7788e66bef6dc7556ddc1753eab77 | 339f9519670dd229a22772ee0ea7344b7754f213 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/KnapsackUnbounded.java b/src/main/java/com/williamfiset/algorithms/dp/KnapsackUnbounded.java
index 116d2ed1a..e985d6c6f 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/KnapsackUnbounded.java
+++ b/src/main/java/com/williamfiset/algorithms/dp/KnapsackUn... | [
"src/main/java/com/williamfiset/algorithms/dp/KnapsackUnbounded.java",
"src/main/java/com/williamfiset/algorithms/dp/Knapsack_01.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/KnapsackTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index 8c6048b94..882c1baad 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -83,5 +83,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,282 | issue_to_patch | Refactor LongestCommonSubsequence | ## Summary
- Refactored LongestCommonSubsequence with file header, Javadoc, section headers, and inline comments
- Renamed original method to `lcsIterative`, added `lcs()` convenience overloads (String and char[])
- Added recursive implementation (`lcsRecursive`) using top-down memoization with `Integer[][]`
- Added sp... | 3fc56ab119ac7a65073984fa16c38b9ccedbf0b7 | 0b3d8fe3138f5d4e126cbabd8bd9ce0eb297326b | diff --git a/src/main/java/com/williamfiset/algorithms/dp/LongestCommonSubsequence.java b/src/main/java/com/williamfiset/algorithms/dp/LongestCommonSubsequence.java
index 0477fab94..72cd602e7 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/LongestCommonSubsequence.java
+++ b/src/main/java/com/williamfiset/alg... | [
"src/main/java/com/williamfiset/algorithms/dp/LongestCommonSubsequence.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/LongestCommonSubsequenceTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index c93b6beee..8c6048b94 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -72,5 +72,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,281 | issue_to_patch | Refactor MaximumSubarray and add tests | ## Summary
- Refactored MaximumSubarray (Kadane's algorithm) with file header, Javadoc, and inline comments
- Changed internal variables to `long` to prevent overflow when summing large `int` values
- Added 15 JUnit 5 tests covering null/empty validation, single elements, all-positive/negative/zero arrays, mixed arrays... | ca0a498aef1062b5f6c7cb6731b397881aa781e5 | 9985c177ddfd5aa9965f4443d039ffb5fb19aa49 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/MaximumSubarray.java b/src/main/java/com/williamfiset/algorithms/dp/MaximumSubarray.java
index cec45d2a0..50bfb2705 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/MaximumSubarray.java
+++ b/src/main/java/com/williamfiset/algorithms/dp/MaximumSubarray.... | [
"src/main/java/com/williamfiset/algorithms/dp/MaximumSubarray.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/MaximumSubarrayTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index e19e69782..c93b6beee 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -61,5 +61,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,279 | issue_to_patch | Refactor EditDistance iterative and recursive, add tests | ## Summary
- Refactor `EditDistanceIterative.java`: add docs, null checks, simplify loop structure, cross-reference recursive variant
- Refactor `EditDistanceRecursive.java`: add docs, make fields private, replace custom `min()` with `Math.min`, remove duplicate example
- Add 14 tests in `EditDistanceIterativeTest.java... | fb7b762483df625b3fe9603b49c0d8422ab1f5c0 | 7ecd999863b1c43e2bbc8717b17a7f42041a716d | diff --git a/src/main/java/com/williamfiset/algorithms/dp/EditDistanceIterative.java b/src/main/java/com/williamfiset/algorithms/dp/EditDistanceIterative.java
index 25dfeea42..6d09fd1f9 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/EditDistanceIterative.java
+++ b/src/main/java/com/williamfiset/algorithms/d... | [
"src/main/java/com/williamfiset/algorithms/dp/EditDistanceIterative.java",
"src/main/java/com/williamfiset/algorithms/dp/EditDistanceRecursive.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/EditDistanceIterativeTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index 91a1c716e..e19e69782 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -50,5 +50,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,278 | issue_to_patch | Refactor CoinChange: replace INF sentinel with null, add docs | ## Summary
- Replace `int[][]`/`int[]` + `INF` sentinel with `Integer[][]`/`Integer[]` + `null` to eliminate edge-case bugs with large values (resolves existing TODO)
- Add file-level header explaining all three solver approaches with complexities
- Add Javadoc to all public methods and `Solution` class
- Remove dead d... | e56af39d744b0d187a2f098cd5e032c79a699921 | 0e13bab4ddc3e9bc1feecc1215a5497afc990974 | diff --git a/src/main/java/com/williamfiset/algorithms/dp/CoinChange.java b/src/main/java/com/williamfiset/algorithms/dp/CoinChange.java
index ba4a7f211..abeab4098 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/CoinChange.java
+++ b/src/main/java/com/williamfiset/algorithms/dp/CoinChange.java
@@ -1,36 +1,58 ... | [
"src/main/java/com/williamfiset/algorithms/dp/CoinChange.java"
] | [] | true | ||
williamfiset/algorithms | 1,277 | issue_to_patch | Refactor MinimumWeightPerfectMatching and add tests | ## Summary
- Refactor `MinimumWeightPerfectMatching.java`: add file-level docs, explicit imports, make fields/methods appropriately private, replace custom `getBitPosition()` with `Integer.numberOfTrailingZeros()`, remove dead `include()` method, restore `test1`/`test2` examples in `main`
- Add 11 dedicated tests in `M... | a0492d405343a777d9c7d782b29fca11e7e63ae4 | dd4aa348c7ee5b37c87d20f35d34297aa762e87d | diff --git a/src/main/java/com/williamfiset/algorithms/dp/MinimumWeightPerfectMatching.java b/src/main/java/com/williamfiset/algorithms/dp/MinimumWeightPerfectMatching.java
index 64932209a..a7258adb1 100644
--- a/src/main/java/com/williamfiset/algorithms/dp/MinimumWeightPerfectMatching.java
+++ b/src/main/java/com/will... | [
"src/main/java/com/williamfiset/algorithms/dp/MinimumWeightPerfectMatching.java",
"src/test/java/com/williamfiset/algorithms/dp/BUILD",
"src/test/java/com/williamfiset/algorithms/dp/MinimumWeightPerfectMatchingTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/dp/BUILD b/src/test/java/com/williamfiset/algorithms/dp/BUILD
index 5c6c2b8cd..91a1c716e 100644
--- a/src/test/java/com/williamfiset/algorithms/dp/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/dp/BUILD
@@ -39,5 +39,16 @@ java_test(
deps = TEST_DEPS,
)... | true | |
williamfiset/algorithms | 1,276 | issue_to_patch | Refactor all 10 linear algebra implementations | ## Summary
- Refactor all 10 files in the `linearalgebra` package applying SKILL.md conventions
- Fix package/header ordering, replace FQN `java.util.Arrays` with proper imports
- Add detailed file-level headers with algorithm explanations, use cases, and complexity
- Fix Big-O notation: `O(n^3*log(p))`, `O(m^3*log(n))... | c781fa7b5a0450af744089b00c93daf25059a7b2 | a9a04a781cb309d6e3de2f0c91819fb5e248d280 | diff --git a/.claude/SKILL.md b/.claude/SKILL.md
index 2c7e3f984..40de68a6b 100644
--- a/.claude/SKILL.md
+++ b/.claude/SKILL.md
@@ -304,6 +304,26 @@ Always use explicit multiplication and parentheses in Big-O expressions for clar
// Space: O(n)
```
+### For Loop Body on Its Own Line
+
+Always place the body of a `... | [
".claude/SKILL.md",
"src/main/java/com/williamfiset/algorithms/linearalgebra/FreivaldsAlgorithm.java",
"src/main/java/com/williamfiset/algorithms/linearalgebra/GaussianElimination.java",
"src/main/java/com/williamfiset/algorithms/linearalgebra/MatrixDeterminantLaplaceExpansion.java",
"src/main/java/com/will... | [] | true | ||
williamfiset/algorithms | 1,274 | issue_to_patch | Refactor CompactSegmentTree and add dedicated tests | ## Summary
- Add detailed file-level header explaining bottom-up array layout, use cases, and complexity
- Fix package/header ordering, replace FQN `java.util.Arrays` with proper import
- Make `UNIQUE` `static final`, add Javadoc on all public methods with `@param`/`@return`
- Add educational inline comments on `modify... | 2b9b29258bf95658535289bc0b80bd0280ef00e7 | 71359c8b339f7f25349d872f6b213426ccf7d6ba | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/CompactSegmentTree.java b/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/CompactSegmentTree.java
index eac9e5960..0c9bf9e8f 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/CompactSeg... | [
"src/main/java/com/williamfiset/algorithms/datastructures/segmenttree/CompactSegmentTree.java",
"src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/BUILD",
"src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/CompactSegmentTreeTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/BUILD b/src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/BUILD
index 7bafacfb9..f896cfcf9 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/segmenttree/BUILD
+++ b/src/test/java/com/williamfiset/alg... | true | |
williamfiset/algorithms | 1,273 | issue_to_patch | Refactor SuffixArrayFast: add docs, comments, and fix formatting | ## Summary
- Add detailed file-level header explaining the prefix doubling with radix sort approach
- Add educational inline comments throughout the dense `construct()` method
- Fix package/header ordering, replace FQN with proper import, make fields private
- Fix Big-O notation to use explicit multiplication: `O(n*log... | 973a3e73ae67c75dbb4dc9e584104b05978f8f25 | 3d6606657c0e8e7b5ee2285b03edccdd3d04ce16 | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayFast.java b/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayFast.java
index df176d81b..cfba2c852 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayFast.... | [
"src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayFast.java"
] | [] | true | ||
williamfiset/algorithms | 1,272 | issue_to_patch | Refactor SuffixArraySlow/Med, expand test coverage | ## Summary
- **Refactor SuffixArraySlow**: fix package order, add file-level header with Big-O, replace FQN `java.util.Arrays` with import, rename `min_len` to `minLen`, make `suffixes` private, add Javadoc to `construct()`
- **Refactor SuffixArrayMed**: fix package order, add file-level header with prefix doubling alg... | 33a089db098f34c0698e4a096c5cb877af37e059 | f70269deb916455ea1eda4fc5950a489c3d06208 | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayMed.java b/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayMed.java
index 23e4e9002..cb3965bb5 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayMed.jav... | [
"src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayMed.java",
"src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArraySlow.java"
] | [] | true | ||
williamfiset/algorithms | 1,271 | issue_to_patch | Refactor SuffixArraySlow and expand test coverage | ## Summary
- **Refactor SuffixArraySlow**: fix package declaration order, add file-level header with Big-O and comparison to faster variants, replace FQN `java.util.Arrays` with import, rename `min_len` to `minLen`, make `suffixes` field private, add Javadoc to `construct()`
- **Expand test coverage** (6 existing tests... | 4f8a72b793a80bd00d4afeff24db1fcb7c5da99f | 7108017f729b0c06e947305d62ea4c3f3e3f806c | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArraySlow.java b/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArraySlow.java
index 975e20e6f..91cd37910 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArraySlow.... | [
"src/main/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArraySlow.java",
"src/test/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayTest.java
index b8f7c0dc2..463cf2f73 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/suffixarray/SuffixArrayTest.... | true | |
williamfiset/algorithms | 1,270 | issue_to_patch | Remove all Gradle references, migrate comments to Bazel | ## Summary
- **Delete `build/` directory** from git tracking (193 generated Gradle artifacts) and add `build/` to `.gitignore`
- **Delete `.github/workflows/gradle.yml`** — the Gradle CI workflow is no longer needed since the project uses Bazel
- **Remove Gradle ecosystem** from `.github/dependabot.yml`
- **Replace `./... | 25b6a3acf32852fe8c71adb1ee15210bdd3d2f44 | 520ea485870da00410f9f9595c4afa0051ea3d78 | diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 560aa4f2b..7503b0e34 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -4,7 +4,3 @@ updates:
directory: "/" # Location of package manifests
schedule:
interval: "weekly"
- - package-ecosystem: "gradle"
- directo... | [
".github/dependabot.yml",
".github/workflows/gradle.yml",
".gitignore",
"build/distributions/Algorithms.tar",
"build/distributions/Algorithms.zip",
"build/libs/Algorithms.jar",
"build/reports/problems/problems-report.html",
"build/reports/tests/test/classes/com.williamfiset.algorithms.datastructures.b... | [] | diff --git a/build/reports/tests/test/classes/com.williamfiset.algorithms.datastructures.balancedtree.AVLTreeTest.html b/build/reports/tests/test/classes/com.williamfiset.algorithms.datastructures.balancedtree.AVLTreeTest.html
deleted file mode 100644
index bd414cf01..000000000
--- a/build/reports/tests/test/classes/co... | true | |
williamfiset/algorithms | 1,268 | issue_to_patch | Fix README URL checker: upgrade Ruby, add caching, allow 429s | ## Summary
- Upgrade Ruby from 3.0 to 3.2
- Use `bundler-cache: true` to replace manual gem install and cache steps
- Allow HTTP 429 (rate limit) responses with `--allow 429` to reduce flaky CI failures
- Use `GITHUB_TOKEN` to avoid unauthenticated rate limits
## Test plan
- [x] Workflow syntax is valid YAML
- [ ] Ver... | ae9c1c92804ffc4febc366ad0a70ee911d381315 | 45d5fcabc285437fe896b27c261d11dc40722e62 | diff --git a/.github/workflows/readme-url-checker.yml b/.github/workflows/readme-url-checker.yml
index 548349949..12e5853b4 100644
--- a/.github/workflows/readme-url-checker.yml
+++ b/.github/workflows/readme-url-checker.yml
@@ -1,23 +1,35 @@
# Use awesome bot to verify that all URLs in the README are valid.
name: RE... | [
".github/workflows/readme-url-checker.yml"
] | [] | true | ||
williamfiset/algorithms | 1,267 | issue_to_patch | Refactor UnionFind: add docs, fix formatting, simplify unify | ## Summary
- **Add file-level documentation** with use cases (Kruskal's, cycle detection, connected components) and O(α(n)) amortized complexity
- **Add Javadoc** with `@param`/`@return` to constructor, `find()`, and `unify()`
- **Fix package declaration order** (was after doc comment)
- **Simplify `unify()`**: find ro... | 1b6c8160765f488f56d6e756107a8fb962afa000 | a1e3c81483b7354f8df0ce11b44a2485e0dd9a2e | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java b/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java
index a52227eaa..7d0a81dec 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java
+++ b/src/main/java... | [
"src/main/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFind.java",
"src/test/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFindTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFindTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFindTest.java
index bf1bfca95..7bd3a9f2f 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/unionfind/UnionFindTest.java
+++ b/s... | true | |
williamfiset/algorithms | 1,266 | issue_to_patch | Refactor Trie: add docs, fix naming, remove dead code | ## Summary
- **Add file-level documentation** with use cases (autocomplete, prefix search) and Big-O complexity (O(L) per operation)
- **Add Javadoc** with `@param`/`@return` to all public methods (`insert`, `delete`, `contains`, `count`, `clear`)
- **Fix naming conventions**: rename snake_case variables (`created_new_... | 243710020ca279222bd8875b17a0fb26cb69fa06 | cc639981502b9de6a87922df547d166354363c8b | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/trie/Trie.java b/src/main/java/com/williamfiset/algorithms/datastructures/trie/Trie.java
index 74f5af7ed..8f5c90752 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/trie/Trie.java
+++ b/src/main/java/com/williamfiset/algorithms/d... | [
"src/main/java/com/williamfiset/algorithms/datastructures/trie/Trie.java",
"src/test/java/com/williamfiset/algorithms/datastructures/trie/TrieTest.java"
] | [] | diff --git a/src/test/java/com/williamfiset/algorithms/datastructures/trie/TrieTest.java b/src/test/java/com/williamfiset/algorithms/datastructures/trie/TrieTest.java
index b44e4b00c..1839a8b5f 100644
--- a/src/test/java/com/williamfiset/algorithms/datastructures/trie/TrieTest.java
+++ b/src/test/java/com/williamfiset/... | true | |
williamfiset/algorithms | 1,265 | issue_to_patch | Refactor stack: fix IntStack bugs, add docs, clean up | ## Summary
- **Fix 3 bugs in IntStack**: `peek()` and `pop()` on empty stack now throw `EmptyStackException` instead of `ArrayIndexOutOfBoundsException`; `push()` on full stack now throws `RuntimeException` with a clear message instead of `ArrayIndexOutOfBoundsException`
- **Add file-level documentation** with algorith... | d4e8a6465a85273466c6e342fe9cc6ea6b7de55d | 90b2507c076fd085b967a21732bc113ba962c1b5 | diff --git a/src/main/java/com/williamfiset/algorithms/datastructures/stack/ArrayStack.java b/src/main/java/com/williamfiset/algorithms/datastructures/stack/ArrayStack.java
index a831c4ca8..78355a0f5 100644
--- a/src/main/java/com/williamfiset/algorithms/datastructures/stack/ArrayStack.java
+++ b/src/main/java/com/will... | [
"src/main/java/com/williamfiset/algorithms/datastructures/stack/ArrayStack.java",
"src/main/java/com/williamfiset/algorithms/datastructures/stack/IntStack.java",
"src/main/java/com/williamfiset/algorithms/datastructures/stack/ListStack.java",
"src/main/java/com/williamfiset/algorithms/datastructures/stack/Sta... | [] | true | ||
williamfiset/algorithms | 1,263 | issue_to_patch | Fix BucketSort bug, remove gradle refs, add sorting tests | ## Summary
- **Fix BucketSort bug**: bucket index was dividing by `M` (range) instead of `N` (element count), causing all elements to land in bucket 0 and degrading to O(n log n)
- **Remove obsolete `./gradlew run` instructions** from all sorting algorithm javadocs (10 files)
- **Add dedicated test files** for BubbleSo... | ffed8f8c46c89ac3a97a019009881cd02d60c0a4 | 58dcaaddb6cf2ba56c3e89e58fe622b2049f1a32 | diff --git a/src/main/java/com/williamfiset/algorithms/sorting/BubbleSort.java b/src/main/java/com/williamfiset/algorithms/sorting/BubbleSort.java
index b2c512945..158208d44 100644
--- a/src/main/java/com/williamfiset/algorithms/sorting/BubbleSort.java
+++ b/src/main/java/com/williamfiset/algorithms/sorting/BubbleSort.... | [
"src/main/java/com/williamfiset/algorithms/sorting/BubbleSort.java",
"src/main/java/com/williamfiset/algorithms/sorting/BucketSort.java",
"src/main/java/com/williamfiset/algorithms/sorting/CountingSort.java",
"src/main/java/com/williamfiset/algorithms/sorting/Heapsort.java",
"src/main/java/com/williamfiset/... | [] | diff --git a/src/test/java/com/williamfiset/algorithms/sorting/BUILD b/src/test/java/com/williamfiset/algorithms/sorting/BUILD
index 484706ad3..51be23a74 100644
--- a/src/test/java/com/williamfiset/algorithms/sorting/BUILD
+++ b/src/test/java/com/williamfiset/algorithms/sorting/BUILD
@@ -17,6 +17,56 @@ TEST_DEPS = [
... | true | |
winsiderss/systeminformer | 2,932 | issue_to_patch | phnt: Fix time-unit docs for native timeout/interval parameters | These comments were copied from the Win32 docs and described LARGE_INTEGER/PLARGE_INTEGER time values as milliseconds, but the native APIs use 100-nanosecond units (negative = relative, positive = absolute).
Funny enough, Microsoft got it wrong too, e.g. for [`FILE_MAILSLOT_SET_INFORMATION`](https://learn.microsoft.... | 98b82ccc32250eb39f02d96a627a8b2b901cc0aa | 04fc80e4ff431a7744f1f0bfce147ed65b7a8358 | diff --git a/phnt/include/ntexapi.h b/phnt/include/ntexapi.h
index 1bcc3597347c..430ccadeeb4c 100644
--- a/phnt/include/ntexapi.h
+++ b/phnt/include/ntexapi.h
@@ -27,10 +27,11 @@ typedef struct _RTL_BITMAP* PRTL_BITMAP;
* The NtDelayExecution routine suspends the current thread until the specified condition is met.
... | [
"phnt/include/ntexapi.h",
"phnt/include/ntioapi.h",
"phnt/include/ntrtl.h"
] | [] | true | ||
winsiderss/systeminformer | 2,910 | issue_to_patch | fix: multiple memcpy calls in phlib/nativefile in nativefile.c | ## Summary
Fix critical severity security issue in `phlib/nativefile.c`.
## Vulnerability
| Field | Value |
|-------|-------|
| **ID** | V-001 |
| **Severity** | CRITICAL |
| **Scanner** | multi_agent_ai |
| **Rule** | `V-001` |
| **File** | `phlib/nativefile.c:2414` |
**Description**: Multiple memcpy calls in phlib/... | 4b36738a224de0eba033267db4b5b80ee24f77b8 | a8c85bb5d3a91b7f566e1b7e7639303e72582cbe | diff --git a/phlib/nativefile.c b/phlib/nativefile.c
index 808df762a057..9ed25ae51b97 100644
--- a/phlib/nativefile.c
+++ b/phlib/nativefile.c
@@ -2403,7 +2403,13 @@ NTSTATUS PhMoveFile(
if (!NT_SUCCESS(status))
goto CleanupExit;
- renameInfoLength = sizeof(FILE_RENAME_INFORMATION) + fileNameLength +... | [
"phlib/nativefile.c"
] | [
{
"comment": "This check is intended to detect an integer overflow in the calculation of renameInfoLength? This is an incomplete fix and can still be bypassed when fileNameLength is extremely large.\n\nExample: \n - If `fileNameLength` is 0xFFFFFFF0 then `renameInfoLength` overflows: 24 + 0xFFFFFFF0 + 2 = 10\... | true | ||
winsiderss/systeminformer | 2,910 | comment_to_fix | fix: multiple memcpy calls in phlib/nativefile in nativefile.c | This check is intended to detect an integer overflow in the calculation of renameInfoLength? This is an incomplete fix and can still be bypassed when fileNameLength is extremely large.
Example:
- If `fileNameLength` is 0xFFFFFFF0 then `renameInfoLength` overflows: 24 + 0xFFFFFFF0 + 2 = 10
- This check then beco... | 4b36738a224de0eba033267db4b5b80ee24f77b8 | a8c85bb5d3a91b7f566e1b7e7639303e72582cbe | diff --git a/phlib/nativefile.c b/phlib/nativefile.c
index 808df762a057..9ed25ae51b97 100644
--- a/phlib/nativefile.c
+++ b/phlib/nativefile.c
@@ -2403,7 +2403,13 @@ NTSTATUS PhMoveFile(
if (!NT_SUCCESS(status))
goto CleanupExit;
- renameInfoLength = sizeof(FILE_RENAME_INFORMATION) + fileNameLength +... | [
"phlib/nativefile.c"
] | [
{
"comment": "This check is intended to detect an integer overflow in the calculation of renameInfoLength? This is an incomplete fix and can still be bypassed when fileNameLength is extremely large.\n\nExample: \n - If `fileNameLength` is 0xFFFFFFF0 then `renameInfoLength` overflows: 24 + 0xFFFFFFF0 + 2 = 10\... | true | ||
winsiderss/systeminformer | 2,910 | comment_to_fix | fix: multiple memcpy calls in phlib/nativefile in nativefile.c | This function is only for display and has minimal error checking. These changes are incorrect since these overflow checks should be using intsafe (e.g. RtlSizeTToUChar)
These changes are also an incomplete fix and can still be bypassed.
Example:
* Name->Length: 10 (Passes the PR's check: 10 <= 255)
* Value->Length: 0... | 4b36738a224de0eba033267db4b5b80ee24f77b8 | a8c85bb5d3a91b7f566e1b7e7639303e72582cbe | diff --git a/phlib/nativefile.c b/phlib/nativefile.c
index 808df762a057..9ed25ae51b97 100644
--- a/phlib/nativefile.c
+++ b/phlib/nativefile.c
@@ -2403,7 +2403,13 @@ NTSTATUS PhMoveFile(
if (!NT_SUCCESS(status))
goto CleanupExit;
- renameInfoLength = sizeof(FILE_RENAME_INFORMATION) + fileNameLength +... | [
"phlib/nativefile.c"
] | [
{
"comment": "This function is only for display and has minimal error checking. These changes are incorrect since these overflow checks should be using intsafe (e.g. RtlSizeTToUChar)\n\nThese changes are also an incomplete fix and can still be bypassed.\n\nExample:\n* Name->Length: 10 (Passes the PR's check: 10... | true | ||
winsiderss/systeminformer | 2,915 | issue_to_patch | Update scan.yml | 2e1fbce70b119442c44d16f1e1d1ce697faec4f5 | 0c7cea918aacf4b3a31b1d0adb4f870af038a270 | diff --git a/.github/workflows/scan.yml b/.github/workflows/scan.yml
index 3ff54319b137..d580485d5bbb 100644
--- a/.github/workflows/scan.yml
+++ b/.github/workflows/scan.yml
@@ -34,21 +34,12 @@ jobs:
shell: cmd
run: nuget restore .\packages.config -PackagesDirectory .\packages\
- - name: Build... | [
".github/workflows/scan.yml"
] | [] | true | |||
winsiderss/systeminformer | 2,912 | issue_to_patch | Potential fixes for 3 code quality findings | d4ee3de0f62ee523ddbc9e3bda0fd7f20c400bf9 | 169a74c775db0e513fd337bcca99d4961dd15ccd | diff --git a/tools/CustomBuildTool/Build.cs b/tools/CustomBuildTool/Build.cs
index 63659c24034f..f26135444c36 100644
--- a/tools/CustomBuildTool/Build.cs
+++ b/tools/CustomBuildTool/Build.cs
@@ -296,10 +296,12 @@ public static string BuildVersionBuild()
}
/// <summary>
- /// Gets the build ve... | [
"tools/CustomBuildTool/Build.cs"
] | [] | true | |||
winsiderss/systeminformer | 2,902 | issue_to_patch | options: enforce minimum window size to prevent controls disappearing on resize | - The options dialog had no minimum size constraint - resizing too small caused all controls to collapse/disappear off-screen.
- Added `WM_SIZING` handler with `PhResizingMinimumSize` preventing the window from going below its initial dialog size (`423×247` DU, converted to pixels via `MapDialogRect` at dialog cre... | b43c14f0c6b22ac55fff1fad272a4bb799c266a8 | 7bb7ee1d460bd376049029445bcdb40c0b181323 | diff --git a/SystemInformer/options.c b/SystemInformer/options.c
index 81712fd111c1..506e02050a6c 100644
--- a/SystemInformer/options.c
+++ b/SystemInformer/options.c
@@ -125,6 +125,7 @@ static PPH_LIST SectionList = NULL;
static PPH_OPTIONS_SECTION CurrentSection = NULL;
static HWND OptionsTreeControl = NULL;
stati... | [
"SystemInformer/options.c"
] | [] | true | ||
winsiderss/systeminformer | 2,901 | issue_to_patch | ExtendedTools: add GPU memory mini-info section | - GPU memory tray icons (`GPU memory history`, `GPU memory usage (text)`) shared `EtpGpuIconMessageCallback` with GPU usage icons, so hovering them always opened the "GPU" mini-info section showing GPU node
utilization instead of VRAM data.
- Added a dedicated `EtpGpuMemoryIconMessageCallback` that routes to a new "G... | 5d0bbf70256afa85305b54448349c05f6b38ef48 | 4fb4cee63b6a81338eebe7a9063fb69f90f7833c | diff --git a/plugins/ExtendedTools/gpumini.c b/plugins/ExtendedTools/gpumini.c
index ff8a7270f4e7..c8552d634d00 100644
--- a/plugins/ExtendedTools/gpumini.c
+++ b/plugins/ExtendedTools/gpumini.c
@@ -22,6 +22,10 @@ VOID EtGpuMiniInformationInitializing(
memset(§ion, 0, sizeof(PH_MINIINFO_LIST_SECTION));
se... | [
"plugins/ExtendedTools/gpumini.c",
"plugins/ExtendedTools/gpumini.h",
"plugins/ExtendedTools/iconext.c"
] | [] | true | ||
winsiderss/systeminformer | 2,896 | issue_to_patch | hndlprp: display ALPC port state in handle properties | Display the KPH_ALPC_BASIC_INFORMATION.State field in the ALPC Port section of the handle properties dialog. Previously this field was queried but unused (noted by a TODO comment).
Adds a "State" row showing the raw value plus decoded port type (Unconnected / Server connection / Client communication / Server communi... | d0b8446f192f9905faf8e885c112eafc91b214ad | 1749d4f7f01144658a97301d093b563a465f15f6 | diff --git a/SystemInformer/hndlprp.c b/SystemInformer/hndlprp.c
index 0770a67ca010..74cb5e2e9890 100644
--- a/SystemInformer/hndlprp.c
+++ b/SystemInformer/hndlprp.c
@@ -65,6 +65,7 @@ typedef enum _PHP_HANDLE_GENERAL_INDEX
PH_HANDLE_GENERAL_INDEX_FLAGS,
PH_HANDLE_GENERAL_INDEX_SEQUENCENUMBER,
PH_HANDLE_... | [
"SystemInformer/hndlprp.c"
] | [] | true | ||
winsiderss/systeminformer | 2,897 | issue_to_patch | memsrcht: parallel memory string scan with performance optimizations | Rewrites the memory strings scan engine in `memsrcht.c` for performance and memory efficiency. All changes are self-contained to this file.
### Parallel scan (commit 1)
Pre-enumerate all committed, accessible memory regions that match the selected type mask (Private/Image/Mapped), then distribute them across N wo... | ab426c41bd9ad025009afb8ada64ef6b478d5afb | 8e80ba689d7ac7d29b3b3da57132612ef92a3e41 | diff --git a/SystemInformer/memsrcht.c b/SystemInformer/memsrcht.c
index 658a3918d968..bb8425cf86d0 100644
--- a/SystemInformer/memsrcht.c
+++ b/SystemInformer/memsrcht.c
@@ -87,6 +87,12 @@ typedef struct _PH_MEMSTRINGS_CONTEXT
PPH_LIST PrevNodeList;
PH_MEMSTRINGS_SETTINGS Settings;
+
+ ULONG ThreadCount... | [
"SystemInformer/memsrcht.c"
] | [] | true | ||
winsiderss/systeminformer | 2,898 | issue_to_patch | filepool: replace PhAllocate+memset pairs with PhAllocateZero | `PhCreateFilePool` called `PhAllocate` followed immediately by `memset(…, 0, …)` in two places within the same function. `PhAllocateZero` combines both operations, removing the redundant zeroing step.
No behaviour change. | a238762ed509c4602dac2793db2b46dd87b0c885 | edd1a34dce667a834180b4f05625198f9d5872b3 | diff --git a/phlib/filepool.c b/phlib/filepool.c
index 10fe750dcb87..63c95fe7896c 100644
--- a/phlib/filepool.c
+++ b/phlib/filepool.c
@@ -100,8 +100,7 @@ NTSTATUS PhCreateFilePool(
Parameters = &localParameters;
}
- pool = PhAllocate(sizeof(PH_FILE_POOL));
- memset(pool, 0, sizeof(PH_FILE_POOL));... | [
"phlib/filepool.c"
] | [] | true | ||
winsiderss/systeminformer | 2,899 | issue_to_patch | extlv: suppress repaints during column auto-size pass | Double-clicking a column header to auto-size all columns sends `LVM_SETCOLUMNWIDTH` in a loop, each triggering a full ListView repaint. Wrapping the loop with `WM_SETREDRAW FALSE/TRUE` and a single `InvalidateRect` at the end eliminates N−1 spurious repaints. | b47d9f3befeb64c7fb274e16f6897c2cc3e7c9ea | a6d5dc046b6991fb6117d5a4d7606e89bdae6d48 | diff --git a/phlib/extlv.c b/phlib/extlv.c
index 8deb8fab7422..30f520ad51ca 100644
--- a/phlib/extlv.c
+++ b/phlib/extlv.c
@@ -286,6 +286,8 @@ LRESULT CALLBACK PhpExtendedListViewWndProc(
if (headerCount != INT_ERROR)
{
+ ... | [
"phlib/extlv.c"
] | [] | true | ||
winsiderss/systeminformer | 2,900 | issue_to_patch | guisup: skip background erasure on combobox selection invalidation | `PhSelectComboBoxString` calls `InvalidateRect` with `bErase = TRUE` after `CB_SETCURSEL`, triggering a redundant `WM_ERASEBKGND` before `WM_PAINT`. A combobox fully repaints its own surface in `WM_PAINT`, so the erase pass is unnecessary. Pass `FALSE` instead.
The `mainwnd.c` DPI-change site (also flagged) is left ... | a76541e6cfa7a5c7ed8ac8b4ab27dc06c83d6943 | d6e18d3cbefd3a21f52b622bf0740bc54dec3dc8 | diff --git a/phlib/guisup.c b/phlib/guisup.c
index ea87d950476f..1311a9a3069b 100644
--- a/phlib/guisup.c
+++ b/phlib/guisup.c
@@ -1698,7 +1698,7 @@ LONG PhSelectComboBoxString(
ComboBox_SetCurSel(WindowHandle, index);
- InvalidateRect(WindowHandle, NULL, TRUE);
+ InvalidateRect(WindowHandle,... | [
"phlib/guisup.c"
] | [] | true | ||
winsiderss/systeminformer | 2,895 | issue_to_patch | DotNetTools: implement rate-per-second performance counters | Add 19 missing rate-per-second .NET CLR performance counters to the DotNetTools .NET Performance tab.
Counters added:
- Memory (4): Gen 0/1 Promoted Bytes/sec, Promoted Finalization-Memory/sec, Allocated Bytes/sec
- Exceptions (4): Thrown/sec, Filters/sec, Finallys/sec, Throw To Catch Depth/sec
- Jit (1): I... | d565127f3718fea443cd6a6dd31443b08c7420de | c15534e9f66a629efc7898eaff981281706a8f3a | diff --git a/plugins/DotNetTools/perfpage.c b/plugins/DotNetTools/perfpage.c
index 550c3cc0241b..0cb6f8af7b7c 100644
--- a/plugins/DotNetTools/perfpage.c
+++ b/plugins/DotNetTools/perfpage.c
@@ -117,6 +117,31 @@ typedef enum _DOTNET_INDEX
DOTNET_INDEX_SECURITY_TIMEINRTCHECKS,
DOTNET_INDEX_SECURITY_STACKWALKDE... | [
"plugins/DotNetTools/perfpage.c"
] | [] | true | ||
winsiderss/systeminformer | 2,894 | issue_to_patch | Fix DPI handling, icon scaling, and update energy metrics | This pull request improves DPI handling, icon management, and dialog initialization. The changes resolve issues with the initial implementation of DPI-awareness for icon handling, dialog sizing and font scaling.
- Replaced usages of `PhGetDpi` with `PhScaleToDisplay` for more accurate DPI scaling in dialog controls... | e082ed84217d771b7252265cd571d3955820b932 | b4106cf32a167430ecd73940b63c01c4c1910063 | diff --git a/SystemInformer/SystemInformer.def b/SystemInformer/SystemInformer.def
index d27f62641b82..5eda629a4a2a 100644
--- a/SystemInformer/SystemInformer.def
+++ b/SystemInformer/SystemInformer.def
@@ -795,11 +795,10 @@ EXPORTS
PhGetRoamingAppDataDirectory
PhGetStatusMessage
PhGetSystemDirectory
- ... | [
"SystemInformer/SystemInformer.def",
"SystemInformer/admintask.c",
"SystemInformer/appsup.c",
"SystemInformer/chcol.c",
"SystemInformer/chdlg.c",
"SystemInformer/delayhook.c",
"SystemInformer/findobj.c",
"SystemInformer/hndlprp.c",
"SystemInformer/include/phapp.h",
"SystemInformer/include/procprv.... | [] | true | ||
winsiderss/systeminformer | 2,889 | issue_to_patch | phnt: fix `DestinationString` SAL annotations | Fix warning like `warning C6001: Using uninitialized memory 'UTF8String'.` when `AllocateDestinationString` is set to `TRUE`. | bff820d7e78ce398ee4c51fb6c879b77d9d3cdce | 65a2f3abc6a8e90458d1a18a09dd71eca9809f15 | diff --git a/phnt/include/ntrtl.h b/phnt/include/ntrtl.h
index 3772f9751cfc..7e1d6c2f7a72 100644
--- a/phnt/include/ntrtl.h
+++ b/phnt/include/ntrtl.h
@@ -3069,7 +3069,7 @@ NTSYSAPI
NTSTATUS
NTAPI
RtlUpcaseUnicodeString(
- _Inout_ PUNICODE_STRING DestinationString,
+ _When_(AllocateDestinationString, _Out_) _W... | [
"phnt/include/ntrtl.h"
] | [] | true | ||
winsiderss/systeminformer | 2,883 | issue_to_patch | phnt: Revert accidental changes, fix typos | 0a12d2a1d6ed24daf9a8d619b3596e03fc2c5b70 | 88ab2400a2d5a598f7c5cb65d2252e4a71e493a8 | diff --git a/phnt/include/ntexapi.h b/phnt/include/ntexapi.h
index 459fdf51fd01..99febbbda41d 100644
--- a/phnt/include/ntexapi.h
+++ b/phnt/include/ntexapi.h
@@ -8146,7 +8146,7 @@ typedef struct _CODE_INTEGRITY_REPORT_GENERATION_HEADER
//
// Secure Kernel / Hypervisor secure time reference when this policy... | [
"phnt/include/ntexapi.h",
"phnt/include/ntintsafe.h",
"phnt/include/ntlsa.h",
"phnt/include/ntstrsafe.h"
] | [] | true | |||
winsiderss/systeminformer | 2,886 | issue_to_patch | ntfill.h: annotate dynamically resolved routine names | Added "// routine:" comments to `_Function_class_` markers for function typedefs that are resolved at runtime via `MmGetSystemRoutineAddress` or `RtlFindExportedRoutineByName`. Can be useful for readers and for docs generation.
Also, some of the pre-existing comments were incorrect (`CI_CHECK_SIGNED_FILE_EX` and `CI... | f79891bb295aa81514292d5b7783b7ca2bf89c88 | 4f3f6b12eaf549e5731db6ee6653791f4b0b7d73 | diff --git a/KSystemInformer/include/ntfill.h b/KSystemInformer/include/ntfill.h
index 372c7fbbbfe3..d5444d285e7e 100644
--- a/KSystemInformer/include/ntfill.h
+++ b/KSystemInformer/include/ntfill.h
@@ -151,7 +151,7 @@ ZwQuerySection(
extern POBJECT_TYPE *IoDriverObjectType;
extern POBJECT_TYPE *IoDeviceObjectType;
... | [
"KSystemInformer/include/ntfill.h"
] | [
{
"comment": "Could we move these to the `typedef` please? The kernel code really tries to stick to an 80 character limit whenever possible, thanks!\r\n```suggestion\r\ntypedef // routine: IoCheckFileObjectOpenedAsCopySource\r\n_Function_class_(IO_CHECK_FILE_OBJECT_OPENED_AS_COPY_SOURCE)\r\n```\r\n\r\nI did se... | true | ||
winsiderss/systeminformer | 2,886 | comment_to_fix | ntfill.h: annotate dynamically resolved routine names | Could we move these to the `typedef` please? The kernel code really tries to stick to an 80 character limit whenever possible, thanks!
```suggestion
typedef // routine: IoCheckFileObjectOpenedAsCopySource
_Function_class_(IO_CHECK_FILE_OBJECT_OPENED_AS_COPY_SOURCE)
```
I did see your note about `#define _Routin... | f79891bb295aa81514292d5b7783b7ca2bf89c88 | 4f3f6b12eaf549e5731db6ee6653791f4b0b7d73 | diff --git a/KSystemInformer/include/ntfill.h b/KSystemInformer/include/ntfill.h
index 372c7fbbbfe3..d5444d285e7e 100644
--- a/KSystemInformer/include/ntfill.h
+++ b/KSystemInformer/include/ntfill.h
@@ -151,7 +151,7 @@ ZwQuerySection(
extern POBJECT_TYPE *IoDriverObjectType;
extern POBJECT_TYPE *IoDeviceObjectType;
... | [
"KSystemInformer/include/ntfill.h"
] | [
{
"comment": "Could we move these to the `typedef` please? The kernel code really tries to stick to an 80 character limit whenever possible, thanks!\r\n```suggestion\r\ntypedef // routine: IoCheckFileObjectOpenedAsCopySource\r\n_Function_class_(IO_CHECK_FILE_OBJECT_OPENED_AS_COPY_SOURCE)\r\n```\r\n\r\nI did se... | true | ||
winsiderss/systeminformer | 2,886 | comment_to_fix | ntfill.h: annotate dynamically resolved routine names | I'm curious if we could move the "pre 6.1.7601.18519" to the "rev" line or if that would be too complicated for your parser?
```suggestion
// rev (pre 6.1.7601.18519)
// routine: CiVerifyHashInCatalog
typedef
_Function_class_(CI_VERIFY_HASH_IN_CATALOG)
``` | f79891bb295aa81514292d5b7783b7ca2bf89c88 | 4f3f6b12eaf549e5731db6ee6653791f4b0b7d73 | diff --git a/KSystemInformer/include/ntfill.h b/KSystemInformer/include/ntfill.h
index 372c7fbbbfe3..d5444d285e7e 100644
--- a/KSystemInformer/include/ntfill.h
+++ b/KSystemInformer/include/ntfill.h
@@ -151,7 +151,7 @@ ZwQuerySection(
extern POBJECT_TYPE *IoDriverObjectType;
extern POBJECT_TYPE *IoDeviceObjectType;
... | [
"KSystemInformer/include/ntfill.h"
] | [
{
"comment": "I'm curious if we could move the \"pre 6.1.7601.18519\" to the \"rev\" line or if that would be too complicated for your parser?\n\n```suggestion\n// rev (pre 6.1.7601.18519)\n// routine: CiVerifyHashInCatalog\ntypedef\n_Function_class_(CI_VERIFY_HASH_IN_CATALOG) \n```",
"path": "KSystemInform... | true | ||
winsiderss/systeminformer | 2,886 | comment_to_fix | ntfill.h: annotate dynamically resolved routine names | Oh... a note here... sorry I missed this is my last review.
This is actually the same routine name exported by `CI.dll`... they broke the signature between `6.1.7601.18519` and later versions. So this should technically be `CiCheckSignedFile` like the one before it. I personally put an `_EX` on the `typedef` so the s... | f79891bb295aa81514292d5b7783b7ca2bf89c88 | 4f3f6b12eaf549e5731db6ee6653791f4b0b7d73 | diff --git a/KSystemInformer/include/ntfill.h b/KSystemInformer/include/ntfill.h
index 372c7fbbbfe3..d5444d285e7e 100644
--- a/KSystemInformer/include/ntfill.h
+++ b/KSystemInformer/include/ntfill.h
@@ -151,7 +151,7 @@ ZwQuerySection(
extern POBJECT_TYPE *IoDriverObjectType;
extern POBJECT_TYPE *IoDeviceObjectType;
... | [
"KSystemInformer/include/ntfill.h"
] | [
{
"comment": "Oh... a note here... sorry I missed this is my last review. \n\nThis is actually the same routine name exported by `CI.dll`... they broke the signature between `6.1.7601.18519` and later versions. So this should technically be `CiCheckSignedFile` like the one before it. I personally put an `_EX` o... | true | ||
winsiderss/systeminformer | 2,882 | issue_to_patch | [WIP] Fix error message in static assert for HSTRING_REFERENCE | - [x] Review current branch changes and latest PR comment context
- [x] Run relevant existing checks/tests to establish current status
- [x] Make minimal code updates needed to complete the requested fix
- [x] Re-run targeted validation for modified area
- [x] Run final validation checks and respond to PR comment
<!--... | fedc43b6a11a31a2a8c229e850433bddab211f76 | 8209ade3988952f8fc61f3cc4d070c6ec27dd352 | diff --git a/phlib/appruntime.c b/phlib/appruntime.c
index 0ba23d1ae278..8d2cb9cb8e32 100644
--- a/phlib/appruntime.c
+++ b/phlib/appruntime.c
@@ -20,7 +20,7 @@
#endif
#ifdef __hstring_h__
-static_assert(sizeof(HSTRING_REFERENCE) == sizeof(HSTRING_HEADER), "HSTRING_REFERENCE must equal WSTRING_HEADER");
+static_ass... | [
"phlib/appruntime.c"
] | [
{
"comment": "There is another identical `static_assert` in `phlib/include/appresolver.h` where the `__hstring_h__` branch still reports \"HSTRING_REFERENCE must equal WSTRING_HEADER\" while comparing against `HSTRING_HEADER`. To fully fix the misleading diagnostic (and keep the header/API consistent), update t... | true | ||
winsiderss/systeminformer | 2,879 | issue_to_patch | phsvc/phlib: harden count-based size calculations in heap/config parsing | ## Summary
This patch hardens several count-derived size calculations that were previously used directly in privileged parsing/allocation paths.
## Security rationale
Malformed inputs can force integer wraparound in `count * sizeof(...)` arithmetic. Wrapped lengths can become smaller than intended and lead to out-of-b... | 9038cf6f89b97ff04001c6241b9657391510b5fb | fd5ebd366169924253fff5a264338c5c156592c7 | diff --git a/SystemInformer/memprv.c b/SystemInformer/memprv.c
index b3a333f0249f..893545f8e3ff 100644
--- a/SystemInformer/memprv.c
+++ b/SystemInformer/memprv.c
@@ -464,6 +464,8 @@ VOID PhpUpdateHeapRegions(
PRTL_DEBUG_INFORMATION debugBuffer = NULL;
PPH_PROCESS_DEBUG_HEAP_INFORMATION heapDebugInfo = NULL;
... | [
"SystemInformer/memprv.c",
"SystemInformer/phsvc/svcapi.c",
"phlib/native.c"
] | [] | true | ||
winsiderss/systeminformer | 2,866 | issue_to_patch | Fix potential index out of bounds exception in Zip.cs | Fixes a potential `ArgumentOutOfRangeException` in the `GetEntryNames` method in `Zip.cs`.
## Changes Made
- **`GetEntryNames`**: Replaced `names[i].Substring(length)` with a direct bounds check so `Substring(length)` is only called when `length` is within the string length, and `string.Empty` is returned otherwise.
... | b68bf77e8beb9771c45b75fbdbf095fc164e7ddd | 3dacde6869b94050c0061a874b6dec32b9a563a9 | diff --git a/tools/CustomBuildTool/Zip.cs b/tools/CustomBuildTool/Zip.cs
index 07431eea86e6..c1a54d50ad05 100644
--- a/tools/CustomBuildTool/Zip.cs
+++ b/tools/CustomBuildTool/Zip.cs
@@ -47,7 +47,8 @@ private static string[] GetEntryNames(string[] names, string sourceFolder, bool
var result = new string[na... | [
"tools/CustomBuildTool/Zip.cs"
] | [] | true | ||
winsiderss/systeminformer | 1,066 | issue_to_patch | Add support for selecting process's subtree by middle clicking it | This should fix the feature request #938 | 0deb12629f44b8b0d353ba2e8bce4825ba901307 | 0daf20fe9ffccbcb5023ed39748060244b8da732 | diff --git a/ProcessHacker/proctree.c b/ProcessHacker/proctree.c
index 23f797bdf9a4..0ed63e043b1e 100644
--- a/ProcessHacker/proctree.c
+++ b/ProcessHacker/proctree.c
@@ -4068,6 +4068,33 @@ BOOLEAN NTAPI PhpProcessTreeNewCallback(
}
}
return FALSE;
+
+ case TreeNewMiddleClick:
+ ... | [
"ProcessHacker/proctree.c",
"phlib/include/treenew.h",
"phlib/treenew.c"
] | [
{
"comment": "please add `(TheEragon)` at the end of these comments so we know who wrote them :P",
"path": "ProcessHacker/proctree.c",
"hunk": "@@ -4068,6 +4068,30 @@ BOOLEAN NTAPI PhpProcessTreeNewCallback(\n }\n }\n return FALSE;\n+\n+ case TreeNewMiddleClick:\n+ ... | true | ||
winsiderss/systeminformer | 2,853 | issue_to_patch | Handle null service config path names in service file name fallback | ## Summary
Fix a null pointer dereference in service path resolution when `QueryServiceConfigW` does not provide a usable binary path.
`PhGetServiceConfigFileName` assumed `ServicePathName` was always non-null and accessed `ServicePathName[0]` unconditionally. In practice, malformed service configuration data... | 2bd6c2921cf489b86fe56eb73d6faa47c3987a35 | e1cf70740ab7caf97c544ff9c8be1450827e798e | diff --git a/phlib/include/svcsup.h b/phlib/include/svcsup.h
index d9167954548e..09b610836112 100644
--- a/phlib/include/svcsup.h
+++ b/phlib/include/svcsup.h
@@ -372,7 +372,7 @@ PPH_STRING
NTAPI
PhGetServiceConfigFileName(
_In_ ULONG ServiceType,
- _In_ PCWSTR ServicePathName,
+ _In_opt_ PCWSTR ServicePat... | [
"phlib/include/svcsup.h",
"phlib/svcsup.c"
] | [] | true | ||
winsiderss/systeminformer | 2,847 | issue_to_patch | Fix page/IO priority in Threads tab | Zero is valid value for page/IO priority. It was previously skipped due to wrong condition. Now these checks are the same as corresponding ones in `proctree.c`. | 13792f7273568811700c49885d5034f1529889fd | d3191efc61db4696dcf93fecaa69821494c40cb7 | diff --git a/SystemInformer/thrdlist.c b/SystemInformer/thrdlist.c
index b30ad7433071..d3a2f5fd1f1b 100644
--- a/SystemInformer/thrdlist.c
+++ b/SystemInformer/thrdlist.c
@@ -475,7 +475,7 @@ VOID PhpUpdateThreadNodePagePriority(
{
ULONG pagePriorityInteger = MEMORY_PRIORITY_NORMAL + 1;
- ThreadNode->PagePrio... | [
"SystemInformer/thrdlist.c"
] | [] | true | ||
winsiderss/systeminformer | 2,807 | issue_to_patch | Add meson.build for phnt | The version is autogenerated in dist tarballs; see `tools/CustomBuildTool/Build.cs`. It follows `BUILD_MAJORVERSION` and `BUILD_MINORVERSION`, otherwise it reuses the major and minor versions from the last tag.
You need to `pip install GitPython` to correctly generate the version number.
```sh
export BUILD_MAJ... | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "This seems overkill. Does meson require strict versioning for a header-only package?",
"path": "phnt/meson.build",
"hunk": "@@ -0,0 +1,96 @@\n+project(\n+ 'phnt',\n+ 'c',\n+ meson_version: '>=0.63.0',\n+ version: run_command(\n+ '../tools/versioning/meson_version.py',",
... | true | ||
winsiderss/systeminformer | 2,807 | comment_to_fix | Add meson.build for phnt | This seems overkill. Does meson require strict versioning for a header-only package? | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "This seems overkill. Does meson require strict versioning for a header-only package?",
"path": "phnt/meson.build",
"hunk": "@@ -0,0 +1,96 @@\n+project(\n+ 'phnt',\n+ 'c',\n+ meson_version: '>=0.63.0',\n+ version: run_command(\n+ '../tools/versioning/meson_version.py',",
... | true | ||
winsiderss/systeminformer | 2,807 | comment_to_fix | Add meson.build for phnt | `pkgconfig = import('pkgconfig')` returns a Meson module, which does not support `.found()`. The `if pkgconfig.found()` conditional will error at configure time; call `pkgconfig.generate(...)` unconditionally (or gate it on an option you define) instead.
```suggestion
pkgconfig.generate(
name: 'phnt',
descripti... | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "`pkgconfig = import('pkgconfig')` returns a Meson module, which does not support `.found()`. The `if pkgconfig.found()` conditional will error at configure time; call `pkgconfig.generate(...)` unconditionally (or gate it on an option you define) instead.\n```suggestion\npkgconfig.generate(\n na... | true | ||
winsiderss/systeminformer | 2,807 | comment_to_fix | Add meson.build for phnt | Installing the `.pc` file into `get_option('datadir') / 'pkgconfig'` is non-standard and likely won’t be on `pkg-config`’s default search path. Prefer the conventional location (typically `get_option('libdir') / 'pkgconfig'`), or omit `install_dir` and let Meson pick the default.
```suggestion
``` | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "Installing the `.pc` file into `get_option('datadir') / 'pkgconfig'` is non-standard and likely won’t be on `pkg-config`’s default search path. Prefer the conventional location (typically `get_option('libdir') / 'pkgconfig'`), or omit `install_dir` and let Meson pick the default.\n```suggestion\n\... | true | ||
winsiderss/systeminformer | 2,807 | comment_to_fix | Add meson.build for phnt | PR description mentions autogenerated versioning for Meson/dist tarballs, but this `project()` call does not set a `version:` (nor is there any version-generation logic in this file). Either wire up the version generation here (or in the top-level Meson project) or adjust the PR description so it reflects what this PR ... | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "PR description mentions autogenerated versioning for Meson/dist tarballs, but this `project()` call does not set a `version:` (nor is there any version-generation logic in this file). Either wire up the version generation here (or in the top-level Meson project) or adjust the PR description so it ... | true | ||
winsiderss/systeminformer | 2,807 | comment_to_fix | Add meson.build for phnt | `phnt_srcs` contains only header files (used for `install_headers`). Renaming it to something like `phnt_headers` would better reflect its contents and avoid confusion if compilation sources are added later.
```suggestion
phnt_inc = include_directories('include')
phnt_headers = files(
'include/ntafd.h'... | 63256856407b785ec66d23bd1b51ce15f61ac76e | bfa765f1035d1c961a0cdde5fe9c7806ac70abdc | diff --git a/phnt/meson.build b/phnt/meson.build
new file mode 100644
index 000000000000..5686a56b8981
--- /dev/null
+++ b/phnt/meson.build
@@ -0,0 +1,78 @@
+project(
+ 'phnt',
+ 'c',
+ meson_version: '>=0.63.0',
+)
+
+cc = meson.get_compiler('c')
+ntdll_dep = cc.find_library('ntdll')
+
+phnt_inc = include_dir... | [
"phnt/meson.build"
] | [
{
"comment": "`phnt_srcs` contains only header files (used for `install_headers`). Renaming it to something like `phnt_headers` would better reflect its contents and avoid confusion if compilation sources are added later.\n```suggestion\n phnt_inc = include_directories('include')\n\n phnt_headers = files(... | true | ||
winsiderss/systeminformer | 2,820 | issue_to_patch | Fix thread handle names | This pull request fixes an issue where running unnamed thread handles are marked as terminated and terminated unnamed threads are marked twice.
<img width="610" height="38" alt="image" src="https://github.com/user-attachments/assets/9e54ef3e-2987-4177-bf4f-e842f20d1bdd" />
| 1a2d84bd98167e5de5035cd8e084e56d1f3dfb12 | 293a7c08fc45b1678d62e018787b32ba465c8ed9 | diff --git a/phlib/hndlinfo.c b/phlib/hndlinfo.c
index 6fe01337788a..c3df37d4f559 100644
--- a/phlib/hndlinfo.c
+++ b/phlib/hndlinfo.c
@@ -915,8 +915,8 @@ PPH_STRING PhStdGetClientIdNameEx(
BOOLEAN processIsTerminated = FALSE;
BOOLEAN threadIsTerminated = FALSE;
- PhInitializeStringRef(&processNameString... | [
"phlib/hndlinfo.c"
] | [] | true | ||
winsiderss/systeminformer | 2,816 | issue_to_patch | Add desktop heap detection | This pull request allows the memory page to recognize desktop heaps.
<img width="541" height="89" alt="image" src="https://github.com/user-attachments/assets/04240911-7c7a-4841-ac60-26798081b26c" />
| 9c3eb459fba63da430ae9b311ee11dbff9e16e1e | 6e6729055e475e272a6e3d32d4fc92c59e1c45cb | diff --git a/SystemInformer/include/memprv.h b/SystemInformer/include/memprv.h
index af9a8de449f2..bab457fedd34 100644
--- a/SystemInformer/include/memprv.h
+++ b/SystemInformer/include/memprv.h
@@ -47,6 +47,7 @@ typedef enum _PH_MEMORY_REGION_TYPE
TelemetryCoverageRegion,
ProcessParametersRegion,
LeapSe... | [
"SystemInformer/include/memprv.h",
"SystemInformer/memlist.c",
"SystemInformer/memprv.c",
"phnt/include/ntpebteb.h"
] | [
{
"comment": "Is the `DeskInfo` pointer really not already aligned to 8/16 bytes?",
"path": "SystemInformer/memprv.c",
"hunk": "@@ -1140,6 +1141,29 @@ NTSTATUS PhpUpdateMemoryRegionTypes(\n }\n #endif\n }\n+\n+ // TEB->Win32ClientInfo.DesktopBase (which nowadays is... | true | ||
winsiderss/systeminformer | 2,816 | comment_to_fix | Add desktop heap detection | Is the `DeskInfo` pointer really not already aligned to 8/16 bytes? | 9c3eb459fba63da430ae9b311ee11dbff9e16e1e | 6e6729055e475e272a6e3d32d4fc92c59e1c45cb | diff --git a/SystemInformer/memprv.c b/SystemInformer/memprv.c
index 1885f49b2fa5..b3a333f0249f 100644
--- a/SystemInformer/memprv.c
+++ b/SystemInformer/memprv.c
@@ -1096,7 +1096,7 @@ NTSTATUS PhpUpdateMemoryRegionTypes(
#endif
}
- // TEB, stack
+ // TEB, stack, desktop heap
for (i = 0; i < process-... | [
"SystemInformer/memprv.c"
] | [
{
"comment": "Is the `DeskInfo` pointer really not already aligned to 8/16 bytes?",
"path": "SystemInformer/memprv.c",
"hunk": "@@ -1140,6 +1141,29 @@ NTSTATUS PhpUpdateMemoryRegionTypes(\n }\n #endif\n }\n+\n+ // TEB->Win32ClientInfo.DesktopBase (which nowadays is... | true | ||
winsiderss/systeminformer | 2,816 | comment_to_fix | Add desktop heap detection | ```
D:\a\systeminformer\systeminformer\phnt\include\ntpebteb.h(973,5): error C2061: syntax error: identifier 'HWND' [D:\a\systeminformer\systeminformer\KSystemInformer\ksidll.vcxproj]
(compiling source file 'ksidll.c')
```
These need to go under `#if (PHNT_MODE != PHNT_MODE_KERNEL)`. | 9c3eb459fba63da430ae9b311ee11dbff9e16e1e | 6e6729055e475e272a6e3d32d4fc92c59e1c45cb | diff --git a/phnt/include/ntpebteb.h b/phnt/include/ntpebteb.h
index 97d2d3c92d1d..e72bcd7e529a 100644
--- a/phnt/include/ntpebteb.h
+++ b/phnt/include/ntpebteb.h
@@ -967,6 +967,57 @@ typedef struct _TEB_ACTIVE_FRAME_EX
#define STATIC_UNICODE_BUFFER_LENGTH 261
#define WIN32_CLIENT_INFO_LENGTH 62
+#if (PHNT_MODE != ... | [
"phnt/include/ntpebteb.h"
] | [
{
"comment": "```\nD:\\a\\systeminformer\\systeminformer\\phnt\\include\\ntpebteb.h(973,5): error C2061: syntax error: identifier 'HWND' [D:\\a\\systeminformer\\systeminformer\\KSystemInformer\\ksidll.vcxproj]\n (compiling source file 'ksidll.c')\n```\n\nThese need to go under `#if (PHNT_MODE != PHNT_MODE_KERN... | true | ||
winsiderss/systeminformer | 2,814 | issue_to_patch | phnt: minor fixes for comment | d4dff6fdc1033c1410b846686548318d0b58f925 | 90f2a4257cd98d529ef098a61adcf912d6663843 | diff --git a/phnt/include/ntldr.h b/phnt/include/ntldr.h
index e9b221a6f759..0c9a4a0a6895 100644
--- a/phnt/include/ntldr.h
+++ b/phnt/include/ntldr.h
@@ -1121,7 +1121,7 @@ LdrpResGetResourceDirectory(
*
* \param DllHandle A handle to the DLL.
* \param ResourcePath A pointer to an array of Type/Name/Language/(opt... | [
"phnt/include/ntldr.h",
"phnt/include/winsta.h"
] | [] | true | |||
winsiderss/systeminformer | 2,808 | issue_to_patch | Add NtUserCall functions | Windows 10 has several `NtUserCall*` routines (`NtUserCallOneParam`, `NtUserCallHwnd`, etc.) for invoking a list of ~140 pre-defined win32k functions by index. Windows 11 replaced each function with a dedicated syscall. This pull request adds definitions for `NtUserCall*` dispatchers (with a table of indexes for Window... | 2094b4771f2f4fbc6296e4db87920710e17390ec | f4703768c2a621afbcb290d5f49a69d4e9776636 | diff --git a/phnt/include/ntuser.h b/phnt/include/ntuser.h
index 9a010efe80fe..a7d689733b7b 100644
--- a/phnt/include/ntuser.h
+++ b/phnt/include/ntuser.h
@@ -140,13 +140,6 @@ NtUserDisableProcessWindowFiltering(
);
#endif
-NTSYSCALLAPI
-BOOL
-NTAPI
-NtUserDisableProcessWindowsGhosting(
- VOID
- );
-
NTS... | [
"phnt/include/ntuser.h"
] | [] | true | ||
winsiderss/systeminformer | 2,798 | issue_to_patch | phnt: Update RTL_USER_PROCESS_PARAMETERS Windows versions | c6ac9f7d62f5fdbb15711faf1dff3b53ad53727f | 2cef68a0270fa61f83ddc75499d191409311160d | diff --git a/phnt/include/ntrtl.h b/phnt/include/ntrtl.h
index cf5e4942c673..39c08a3c6f81 100644
--- a/phnt/include/ntrtl.h
+++ b/phnt/include/ntrtl.h
@@ -3628,13 +3628,13 @@ typedef struct _RTL_USER_PROCESS_PARAMETERS
PVOID PackageDependencyData;
ULONG ProcessGroupId;
- ULONG LoaderThreads;
- UNICODE... | [
"phnt/include/ntrtl.h"
] | [] | true | |||
winsiderss/systeminformer | 2,796 | issue_to_patch | Update ntafd.h | * Fix `AFD_ENDPOINT_FLAGS` (PDB parser has broken output)
* Add some more RIO structures. | 34a6972340e27779f5a9d13e446e62d19ca772b7 | b80ec4a6bf2653ec9750e76363a3f7751f556256 | diff --git a/phnt/include/ntafd.h b/phnt/include/ntafd.h
index b940f068c6f8..7f21421303b3 100644
--- a/phnt/include/ntafd.h
+++ b/phnt/include/ntafd.h
@@ -29,15 +29,19 @@ typedef struct _AFD_ENDPOINT_FLAGS
UCHAR ConnectionLess : 1;
UCHAR : 3;
UCHAR MessageMode : 1;
+ UC... | [
"phnt/include/ntafd.h"
] | [] | true | ||
winsiderss/systeminformer | 2,795 | issue_to_patch | phnt: correct some comments | Also corrected encoding of some punctuations. | de05627298d7b866c70bea59a2dc2f862052ffe1 | 918e6ad79ee42820676247fa5bb6a356a173af72 | diff --git a/phnt/include/ntexapi.h b/phnt/include/ntexapi.h
index c57ff1553ba6..20300843c0dc 100644
--- a/phnt/include/ntexapi.h
+++ b/phnt/include/ntexapi.h
@@ -1362,11 +1362,11 @@ NtCreateTimer2(
// rev
/**
- * The T2_SET_PARAMETERS structure configures the high‑resolution or coalescable timers,
- * and specify ... | [
"phnt/include/ntexapi.h",
"phnt/include/ntpebteb.h",
"phnt/include/ntpsapi.h",
"phnt/include/ntseapi.h"
] | [
{
"comment": "Spelling error: \"Normal-resoluion\" should be \"Normal-resolution\".\n```suggestion\n * If NoWakeTolerance > 0 --> Normal-resolution, allow up to this value of coalescing, normal power savings.\n```",
"path": "phnt/include/ntexapi.h",
"hunk": "@@ -1379,12 +1379,12 @@ typedef struct ... | true | ||
winsiderss/systeminformer | 2,795 | comment_to_fix | phnt: correct some comments | Spelling error: "Normal-resoluion" should be "Normal-resolution".
```suggestion
* If NoWakeTolerance > 0 --> Normal-resolution, allow up to this value of coalescing, normal power savings.
``` | de05627298d7b866c70bea59a2dc2f862052ffe1 | 918e6ad79ee42820676247fa5bb6a356a173af72 | diff --git a/phnt/include/ntexapi.h b/phnt/include/ntexapi.h
index c57ff1553ba6..20300843c0dc 100644
--- a/phnt/include/ntexapi.h
+++ b/phnt/include/ntexapi.h
@@ -1362,11 +1362,11 @@ NtCreateTimer2(
// rev
/**
- * The T2_SET_PARAMETERS structure configures the high‑resolution or coalescable timers,
- * and specify ... | [
"phnt/include/ntexapi.h"
] | [
{
"comment": "Spelling error: \"Normal-resoluion\" should be \"Normal-resolution\".\n```suggestion\n * If NoWakeTolerance > 0 --> Normal-resolution, allow up to this value of coalescing, normal power savings.\n```",
"path": "phnt/include/ntexapi.h",
"hunk": "@@ -1379,12 +1379,12 @@ typedef struct ... | true | ||
winsiderss/systeminformer | 2,780 | issue_to_patch | phnt: minor fixes for comment | Minor fixes for comment. | 7e0a28059fa049aa7eab39342ef7994c09f3528f | b407e96b0304fd0adba076ef579c88d1e227b97b | diff --git a/phnt/include/ntexapi.h b/phnt/include/ntexapi.h
index c63fa22cdea2..95adc5933fcd 100644
--- a/phnt/include/ntexapi.h
+++ b/phnt/include/ntexapi.h
@@ -5776,7 +5776,7 @@ typedef enum _SYSTEM_CODEINTEGRITY_IMAGE_TYPE
/**
* The SYSTEM_CODEINTEGRITY_CERTIFICATE_INFORMATION structure contains information to... | [
"phnt/include/ntexapi.h",
"phnt/include/winsta.h"
] | [] | true | ||
winsiderss/systeminformer | 2,778 | issue_to_patch | phnt: Fix ThreadQuerySetWin32StartAddress comment | According to @diversenok at https://github.com/m417z/ntdoc/pull/29#discussion_r2619425369:
> [T]he code for handling [`ThreadQuerySetWin32StartAddress`] in `NtSetInformationThread` looks like this:
> ```c
> case ThreadQuerySetWin32StartAddress:
> return STATUS_INVALID_PARAMETER;
> ```
| c750d78b7597060dca79593043c20d0185f06fea | e520ca1e10f1ca9d03a47f4abc1d951e715e0954 | diff --git a/phnt/include/ntbcd.h b/phnt/include/ntbcd.h
index 2b29114dc849..e5e196a5d58f 100644
--- a/phnt/include/ntbcd.h
+++ b/phnt/include/ntbcd.h
@@ -1575,7 +1575,7 @@ typedef enum _BcdLibraryElementTypes
/// <remarks>0x16000041</remarks>
BcdLibraryBoolean_DisplayOptionsEdit = MAKE_BCDE_DATA_TYPE(BCD_ELE... | [
"phnt/include/ntbcd.h",
"phnt/include/ntexapi.h",
"phnt/include/ntintsafe.h",
"phnt/include/ntmmapi.h",
"phnt/include/ntpsapi.h"
] | [] | true | ||
winsiderss/systeminformer | 2,752 | issue_to_patch | phnt: Small fixes for recent commits | b8c57e2b5a44282482a60efd7a9210e31ea6a7bd | 0a4b5954cf8b099eb8cfa712ccfced03092d57a9 | diff --git a/phnt/include/ntmmapi.h b/phnt/include/ntmmapi.h
index 7f0308efc433..eb82540e1499 100644
--- a/phnt/include/ntmmapi.h
+++ b/phnt/include/ntmmapi.h
@@ -1053,7 +1053,7 @@ typedef struct _SECTION_BASIC_INFORMATION
PVOID BaseAddress; // The base virtual address of the section if the section is... | [
"phnt/include/ntmmapi.h",
"phnt/include/ntpsapi.h"
] | [] | true | |||
winsiderss/systeminformer | 2,751 | issue_to_patch | phnt: Fix `RtlSetUnhandledExceptionFilter` SAL and type | - For `RtlSetUnhandledExceptionFilter`, the input UEF can be `NULL`, in this case, UEF will fallback to `RtlUnhandledExceptionFilter[2]`.
- UEF returns `LONG` (`EXCEPTION_XXX`), type is the same as `RtlUnhandledExceptionFilter[2]`, `UnhandledExceptionFilter`, `*PTOP_LEVEL_EXCEPTION_FILTER`. | f2c89614c5aeb3fda1043e14bc35df35bc1592a9 | 3c83863ae9de14f389da94d5edefcd9b6983768c | diff --git a/phnt/include/ntrtl.h b/phnt/include/ntrtl.h
index b20463e884b9..a43619e20bb7 100644
--- a/phnt/include/ntrtl.h
+++ b/phnt/include/ntrtl.h
@@ -4467,7 +4467,7 @@ RtlRemoveVectoredContinueHandler(
//
typedef _Function_class_(RTLP_UNHANDLED_EXCEPTION_FILTER)
-ULONG NTAPI RTLP_UNHANDLED_EXCEPTION_FILTER(
+L... | [
"phnt/include/ntrtl.h"
] | [] | true | ||
winsiderss/systeminformer | 2,735 | issue_to_patch | phnt: SAL and comment fixes | - `THREAD_Set_LIMITED_INFORMATION` -> `THREAD_SET_LIMITED_INFORMATION`.
- Thread / Fiber local storage custom data can be anything, including `NULL`, `_In_ ` -> `_In_opt_`. See also [TlsSetValue](https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-tlssetvalue) and [FlsSetValue](h... | 8a98940a1b1d9bb3d6e8125a88aac1315f0e9564 | 6660d3dcf0d395b95f47b1e100fdbbfb278762ee | diff --git a/phnt/include/ntpsapi.h b/phnt/include/ntpsapi.h
index 60cfbce65b62..6881b56c9e59 100644
--- a/phnt/include/ntpsapi.h
+++ b/phnt/include/ntpsapi.h
@@ -327,7 +327,7 @@ typedef enum _THREADINFOCLASS
ThreadDescriptorTableEntry, // q: DESCRIPTOR_TABLE_ENTRY (or WOW64_DESCRIPTOR_TABLE_EN... | [
"phnt/include/ntpsapi.h",
"phnt/include/ntrtl.h",
"phnt/include/winsta.h"
] | [] | true | ||
winsiderss/systeminformer | 2,732 | issue_to_patch | phnt: Fix SAL annotations | ## `RtlCreateAtomTable`
The function simply returns `STATUS_SUCCESS` if `*AtomTableHandle != NULL`. Reference:
https://github.com/reactos/reactos/blob/69ddd4e74b80038cbc72727d10cecd617c63bdbb/sdk/lib/rtl/atom.c#L150
## `RtlNtPathNameToDosPathName`
Referencne:
https://learn.microsoft.com/en-us/windows/win32/d... | cb2eee327063e1f7f9d1f358ba1cd417ef32ba0e | dac815753e241342d56090afc3ab8ba3c8cc3470 | diff --git a/phnt/include/ntrtl.h b/phnt/include/ntrtl.h
index 864839659bfb..bc9027086ce2 100644
--- a/phnt/include/ntrtl.h
+++ b/phnt/include/ntrtl.h
@@ -5463,7 +5463,7 @@ RtlNtPathNameToDosPathName(
_Reserved_ ULONG Flags,
_Inout_ PRTL_UNICODE_STRING_BUFFER Path,
_Out_opt_ PULONG Disposition, // RtlDet... | [
"phnt/include/ntrtl.h"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.