Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ytdl-org/youtube-dl
16,987
issue_to_patch
[imgur] Allow digits in filename extension
### Before submitting a *pull request* make sure you have: - [x] At least skimmed through [adding new extractor tutorial](https://github.com/rg3/youtube-dl#adding-support-for-a-new-site) and [youtube-dl coding conventions](https://github.com/rg3/youtube-dl#youtube-dl-coding-conventions) sections - [x] [Searched](https:...
79367a98208fbf01d6e04b6747a6e01d0b1f8b9a
27ffb688c567c56e64b87cc760348a9f778b5740
diff --git a/youtube_dl/extractor/imgur.py b/youtube_dl/extractor/imgur.py index 2901960a51f..ecc958a1717 100644 --- a/youtube_dl/extractor/imgur.py +++ b/youtube_dl/extractor/imgur.py @@ -12,7 +12,7 @@ class ImgurIE(InfoExtractor): - _VALID_URL = r'https?://(?:i\.)?imgur\.com/(?:(?:gallery|(?:topic|r)/[^/]+)/)...
[ "youtube_dl/extractor/imgur.py" ]
[]
true
yuliskov/SmartTube
5,874
issue_to_patch
Update vi-VN translation
b59e9f15763b229dcea4d25db9e252d2b0f12318
867927349761d1a8415c5f532a23cc92818824ee
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 2f0eb6f078..79b52dc545 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -727,4 +727,9 @@ <string name="sidebar_notification">Hiển thi thông báo ở thanh bên...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,890
issue_to_patch
Update strings.xml (Polish language) dated 20260612
Update strings.xml (Polish language) dated 20260612
94dade007a7929517ebae843700dbc9499759051
cf792b5d8d02b4e670a4b4e463fb1b3c13d3b61e
diff --git a/common/src/main/res/values-pl/strings.xml b/common/src/main/res/values-pl/strings.xml index dbffe78ecf..69899296fe 100644 --- a/common/src/main/res/values-pl/strings.xml +++ b/common/src/main/res/values-pl/strings.xml @@ -747,4 +747,5 @@ <string name="enable_conscrypt">Włącz Conscrypt</string> <strin...
[ "common/src/main/res/values-pl/strings.xml" ]
[]
true
yuliskov/SmartTube
5,876
issue_to_patch
Update it-IT translation
@yuliskov Added strings for enabling Conscrypt and network settings.
b59e9f15763b229dcea4d25db9e252d2b0f12318
e9f9680233f1b23561f0d6f9a627fdc1d6f278a7
diff --git a/common/src/main/res/values-it/strings.xml b/common/src/main/res/values-it/strings.xml index 3050a4e049..e595540039 100644 --- a/common/src/main/res/values-it/strings.xml +++ b/common/src/main/res/values-it/strings.xml @@ -743,6 +743,9 @@ <string name="app_restore_desc">NOTA: Lo zip di backup dovrebbe ...
[ "common/src/main/res/values-it/strings.xml" ]
[]
true
yuliskov/SmartTube
5,881
issue_to_patch
Update strings fr
b59e9f15763b229dcea4d25db9e252d2b0f12318
9b975902c60ec5ac6f8029a97d07e9b497e121e3
diff --git a/common/src/main/res/values-fr/strings.xml b/common/src/main/res/values-fr/strings.xml index 5596e614d4..9849444a79 100644 --- a/common/src/main/res/values-fr/strings.xml +++ b/common/src/main/res/values-fr/strings.xml @@ -744,4 +744,7 @@ <string name="player_unexpected_error">Erreur de lecture inattendu...
[ "common/src/main/res/values-fr/strings.xml" ]
[]
true
yuliskov/SmartTube
5,840
issue_to_patch
Update vi-VN strings
4c36123213400cfb2a64a106a06295ce33faaa07
b4579ecb6bc525fe31f238b3236ab986949eb152
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 37ac428c0f..6cd9e7a35a 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -724,4 +724,5 @@ <string name="color_scheme_dark_blue_oled">Xanh biển tối (OLED)</s...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,845
issue_to_patch
Update vi-VN translation strings
32fbd4cc423a437567100b29cfca639e1f6009da
4559f4373dbaed477b0c14659afcbb78b45bbcc4
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 6cd9e7a35a..2f0eb6f078 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -725,4 +725,6 @@ <string name="add_video_to_watch_later">Thêm vào Xem sau</string> ...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,866
issue_to_patch
Update galician strings.xml (gl_ES)
update strings.xml for galician language (gl_ES)
b7121295878e4af8c68ab6597f21375508e65351
366d4a6e8bdfe4113c65f88cacd226f088578d9f
diff --git a/common/src/main/res/values-gl-rES/strings.xml b/common/src/main/res/values-gl-rES/strings.xml index 29e2e81f82..2ec04d68a8 100644 --- a/common/src/main/res/values-gl-rES/strings.xml +++ b/common/src/main/res/values-gl-rES/strings.xml @@ -710,4 +710,41 @@ <string name="dont_resize_video_to_fit_dialog">No...
[ "common/src/main/res/values-gl-rES/strings.xml" ]
[]
true
yuliskov/SmartTube
5,853
issue_to_patch
ci: locks versions of actions using hashes
# ci: locks versions of actions using hashes I have pinned the versions of the actions used in the workflows with hashes. Pinning GitHub Actions to a commit hash is an effective safeguard against supply chain attacks. By referencing a specific and immutable version of an action, you prevent compromised versions f...
e22ead89d221553e47ccef74041836dc7efdc7c8
d2e851212c714c5276e4f9f53ef6be49bff02f5a
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index de47c0fe3f..a9046a4006 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -14,12 +14,12 @@ jobs: steps: - name: Checkout Code - uses: actions/checkout@v6 + uses: actions/checkout@df4cb1c069e1874edd31b...
[ ".github/workflows/CI.yml", ".github/workflows/cleanup.yml", ".github/workflows/stale.yml", ".github/workflows/virustotal_scan.yml" ]
[]
true
yuliskov/SmartTube
5,841
issue_to_patch
Change misunderstanding language
This clear_history button is actually "clear all watch history" on Youtube instead of only deleting current item! The clear_search_history button is actually "clear all search history" on Youtube instead of only deleting current item! The simplified Chinese translation is clear and correct. This misunderstandings ca...
57a701b8ac96ee505d08cf3e9a32b8b29ff27bc1
e70546409eae45f1f8e7b1bfde9997072bb0c3cb
diff --git a/common/src/main/res/values-zh-rTW/strings.xml b/common/src/main/res/values-zh-rTW/strings.xml index a07d7e29b0..c3beef18df 100644 --- a/common/src/main/res/values-zh-rTW/strings.xml +++ b/common/src/main/res/values-zh-rTW/strings.xml @@ -476,7 +476,7 @@ <string name="player_button_long_click">長按此按鈕即可設定更...
[ "common/src/main/res/values-zh-rTW/strings.xml" ]
[]
true
yuliskov/SmartTube
5,828
issue_to_patch
Update strings.xml (vi-VN)
51873a3ae6b89b2044439aa1dce817477fa29a22
c4bf3491cfd29da8315fb3f2e8f4bc0506a75f7a
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 6bc7ebb1ed..37ac428c0f 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -98,7 +98,7 @@ <string name="player_full_date">Ngày chính xác trong mô tả</string> ...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,676
issue_to_patch
Update strings.xml - vi-VN
74d75fc36c1e13936b7d4a26cb4d5e6f0eece37a
915f1419fed6eadc96d22b8b50bbf162d0c6591d
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 5c6b621246..da561eca61 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -721,4 +721,5 @@ <string name="header_blocked_channels">Kênh đã chặn</string> <s...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,774
issue_to_patch
vi-VN: Update strings.xml
1c81cc81c7554029ad13194f991e398ae6de965b
f3df173aebe1a545e75bae0ef1e4578f883daf14
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index da561eca61..6bc7ebb1ed 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -722,4 +722,5 @@ <string name="msg_no_blocked_channels">Không có kênh nào bị chặn</...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,829
issue_to_patch
Update strings fr
51873a3ae6b89b2044439aa1dce817477fa29a22
bc122c9f1e0104097fa309708d7f1932de3c1a25
diff --git a/common/src/main/res/values-fr/strings.xml b/common/src/main/res/values-fr/strings.xml index 74b89f1697..5596e614d4 100644 --- a/common/src/main/res/values-fr/strings.xml +++ b/common/src/main/res/values-fr/strings.xml @@ -738,4 +738,10 @@ <string name="fix_empty_subs_and_channels">Corriger les abonnemen...
[ "common/src/main/res/values-fr/strings.xml" ]
[]
true
yuliskov/SmartTube
5,819
issue_to_patch
Update strings.xml (Polish language) dated 20260526
Update strings.xml (Polish language) dated 20260526
ccd65cb749ed18302bfe06cb2c2dc605aee82bb8
9caa0c635bd6deaed39937e9966d3ed91c20ff4c
diff --git a/common/src/main/res/values-pl/strings.xml b/common/src/main/res/values-pl/strings.xml index 23209d91e7..875fa87e2a 100644 --- a/common/src/main/res/values-pl/strings.xml +++ b/common/src/main/res/values-pl/strings.xml @@ -116,8 +116,8 @@ <string name="repeat_mode_pause">Wstrzymaj odtwarzanie po każdym w...
[ "common/src/main/res/values-pl/strings.xml" ]
[]
true
yuliskov/SmartTube
5,809
issue_to_patch
Update strings.xml
e2270f1dac43e1575202071723019f3f1418996a
f9f4843e4952b5ef26ceeb2ab98c767ca5ca5f18
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index 9d39186753..cdefc69b66 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -741,6 +741,9 @@ <string name="fix_empty_subs_and_channels">Oprava prázdných Odbě...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,805
issue_to_patch
Add Italian strings for missing fields
Added italian translation for: - app_restore_desc - app_backup_desc - add_video_to_watch_later
ca7c76b08f10528f51213fdfab93dbf5c4198833
cef99b7aaa91ad027320597e0653bfb422e27ffe
diff --git a/common/src/main/res/values-it/strings.xml b/common/src/main/res/values-it/strings.xml index 22ecce67f7..3050a4e049 100644 --- a/common/src/main/res/values-it/strings.xml +++ b/common/src/main/res/values-it/strings.xml @@ -740,6 +740,9 @@ <string name="fix_empty_subs_and_channels">Correggi Iscrizioni e...
[ "common/src/main/res/values-it/strings.xml" ]
[]
true
yuliskov/SmartTube
5,800
issue_to_patch
Update strings fr
f670e02d14afd0c79b0bb668b9144940d3f8a870
39a0006aa18fa3bde41e28eddd17e6a9258ce8f6
diff --git a/common/src/main/res/values-fr/strings.xml b/common/src/main/res/values-fr/strings.xml index 35bf8b18e5..1fbeedd180 100644 --- a/common/src/main/res/values-fr/strings.xml +++ b/common/src/main/res/values-fr/strings.xml @@ -653,89 +653,95 @@ <string name="old_channel_look">Ancienne apparence de la page Ch...
[ "common/src/main/res/values-fr/strings.xml" ]
[]
true
yuliskov/SmartTube
5,735
issue_to_patch
Update strings.xml
54b73e088d4c05feed0ed4492131bdd7464f8824
93635fef97103b8554d992c4222acb8a25d6bdba
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index e0be6229e1..9d39186753 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -566,6 +566,7 @@ <string name="sort_by_date">Datum nahrání</string> <string...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,721
issue_to_patch
Update(Translations): Update Arabic
eb8e41751552c44776bcb30bef588b784697365d
644a0e883b7f115c38d61302f8a1172bf8a25195
diff --git a/common/src/main/res/values-ar/strings.xml b/common/src/main/res/values-ar/strings.xml index 61de5532e3..2346e91158 100644 --- a/common/src/main/res/values-ar/strings.xml +++ b/common/src/main/res/values-ar/strings.xml @@ -51,7 +51,7 @@ <string name="settings_linked_devices">الأجهزة المرتبطة</string> ...
[ "common/src/main/res/values-ar/strings.xml" ]
[]
true
yuliskov/SmartTube
5,695
issue_to_patch
Update strings.xml ja-JP
133b6c099f6752a66fcddc0f5eed2c0e34a33551
f1409eba83364c71ea04c3606df8842a2cceb2fa
diff --git a/common/src/main/res/values-ja/strings.xml b/common/src/main/res/values-ja/strings.xml index b1520d1c80..55a120661f 100644 --- a/common/src/main/res/values-ja/strings.xml +++ b/common/src/main/res/values-ja/strings.xml @@ -1,722 +1,743 @@ <?xml version="1.0" encoding="utf-8"?> <resources> - <string nam...
[ "common/src/main/res/values-ja/strings.xml" ]
[]
true
yuliskov/SmartTube
5,693
issue_to_patch
Update strings.xml
133b6c099f6752a66fcddc0f5eed2c0e34a33551
f7ffa8d5944462f33e7fd89de75ea4c63e7ec41e
diff --git a/common/src/main/res/values-it/strings.xml b/common/src/main/res/values-it/strings.xml index b46b3600a3..22ecce67f7 100644 --- a/common/src/main/res/values-it/strings.xml +++ b/common/src/main/res/values-it/strings.xml @@ -31,7 +31,7 @@ <string name="option_background_playback_off">Disabilitato</string...
[ "common/src/main/res/values-it/strings.xml" ]
[]
true
yuliskov/SmartTube
5,633
issue_to_patch
Improved QUIC support
QUIC can need cache in Cronet. CronetEngine.Builder.HTTP_CACHE_DISK_NO_HTTP do not cache HTTP response data. Maximum cache size is 2 MB. Reference GoogleChromeLabs cronet-sample https://github.com/GoogleChromeLabs/cronet-sample/blob/50221f75d16bc948235f5a8f66c853af8770732c/android/app/src/main/java/com/google/samp...
61cd2071f6f642834bc91d6949e1acae462139f9
a908d04128ed673ebf25ee1c5704590dcb76dbfe
diff --git a/exoplayer-amzn-2.10.6/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetEngineWrapper.java b/exoplayer-amzn-2.10.6/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetEngineWrapper.java index f5abadc7e6..d3346aea4f 100644 --- a/exoplayer-amzn-2.10.6/e...
[ "exoplayer-amzn-2.10.6/extensions/cronet/src/main/java/com/google/android/exoplayer2/ext/cronet/CronetEngineWrapper.java" ]
[]
true
yuliskov/SmartTube
5,659
issue_to_patch
Update strings.xml
5e76847acb9e7e3581ac2cb8f8b4551538569d99
165ae9bae90f953c7ebcfa62a653a4881d47ee4d
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index 155291b09c..e0be6229e1 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -221,6 +221,7 @@ <string name="msg_player_error_audio_renderer">Vybraný AUDIO for...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,652
issue_to_patch
Update strings.xml
eaf479f5fd4b3cbd83cdde372288aeb28fd39f9f
119a4950266d573c290e7bd2a56ebb3b465ee60a
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index e90f39bb52..155291b09c 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -31,7 +31,7 @@ <string name="option_background_playback_off">Zakázáno</string> ...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,646
issue_to_patch
Fix Channel Up/Down like/dislike not persisting state
## Problem When using Channel Up/Down mapped to Like/Dislike, the visual icon shows as selected but the state is not actually saved. After exiting and returning to the player, the like/dislike is not persisted. ## Root Cause The `likeAction` and `dislikeAction` always passed `PlayerUI.BUTTON_ON` to `onBu...
39f991641b99912b23db81602c7f5aa51a4795f8
76831f7aa818e9e6087e2c6045caea5fea87e791
diff --git a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.java b/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.java index 41a75c3f34..8280c4fa66 100644 --- a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.j...
[ "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.java" ]
[]
true
yuliskov/SmartTube
5,628
issue_to_patch
Update(Translations): Update Arabic
a87e7fdac68e347e33d8c6d5f1b846d3e2dfc8a1
4334237a907654eb4d27287a5bf476b840bfbd63
diff --git a/common/src/main/res/values-ar/strings.xml b/common/src/main/res/values-ar/strings.xml index 61b9e6efbe..61de5532e3 100644 --- a/common/src/main/res/values-ar/strings.xml +++ b/common/src/main/res/values-ar/strings.xml @@ -3,7 +3,7 @@ <string name="header_home">الصفحة الرئيسية</string> <string name="t...
[ "common/src/main/res/values-ar/strings.xml" ]
[]
true
yuliskov/SmartTube
5,630
issue_to_patch
Update strings.xml (he/iw)
Updated Hebrew translation, changes include: * Added missing strings * Converted strings to gender neutral form * Miscellaneous fixes
a87e7fdac68e347e33d8c6d5f1b846d3e2dfc8a1
ddd137ff112323a904fad1ff05c41eba3bc8051a
diff --git a/common/src/main/res/values-he/strings.xml b/common/src/main/res/values-he/strings.xml index 6e99fc62b3..e77e414d9c 100644 --- a/common/src/main/res/values-he/strings.xml +++ b/common/src/main/res/values-he/strings.xml @@ -14,54 +14,58 @@ So, make a copy of values-he and name it values-iw. Keep both in your...
[ "common/src/main/res/values-he/strings.xml", "common/src/main/res/values-iw/strings.xml" ]
[]
true
yuliskov/SmartTube
5,617
issue_to_patch
Update french
422d2d0341afb993de075bdcd003c6845c12e38d
29796b0e35635ba1e45504bcf89fb78c486ba430
diff --git a/common/src/main/res/values-fr/strings.xml b/common/src/main/res/values-fr/strings.xml index 3a03edcde3..35bf8b18e5 100644 --- a/common/src/main/res/values-fr/strings.xml +++ b/common/src/main/res/values-fr/strings.xml @@ -723,7 +723,7 @@ <string name="prefer_google_dns">Privilégier les DNS Google</strin...
[ "common/src/main/res/values-fr/strings.xml" ]
[]
true
yuliskov/SmartTube
5,597
issue_to_patch
[BUG]: Incorrect Translation ### Checklist - [x] I made sure that there are *no existing issues* - [open](https://github.com/yuliskov/SmartTube/issues) or [closed](https://github.com/yuliskov/SmartTube/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to. - [x] I have read the [FAQ](https://g...
Update Dutch strings for playlist and new features
Resolves #5287 Fix Dutch translation for local backup support message
4443622c9d3cd146c43f5c377ee163fb15210ca0
27b336185d3d8e9b859496ec621a2bc7744f5f15
diff --git a/common/src/main/res/values-nl/strings.xml b/common/src/main/res/values-nl/strings.xml index e08c677829..34f3cfc7ee 100644 --- a/common/src/main/res/values-nl/strings.xml +++ b/common/src/main/res/values-nl/strings.xml @@ -43,7 +43,7 @@ <string name="update_changelog">Wijzigingslog</string> <string na...
[ "common/src/main/res/values-nl/strings.xml" ]
[ { "comment": "```suggestion\n <string name=\"queue_respects_playback_mode\">Wachtrij respecteert afspeelmodus</string>\n```", "path": "common/src/main/res/values-nl/strings.xml", "hunk": "@@ -717,4 +717,9 @@\n <string name=\"action_debug_info\">Foutopsporingsinformatie</string>\n <string name=\"pla...
true
yuliskov/SmartTube
5,597
comment_to_fix
Update Dutch strings for playlist and new features
```suggestion <string name="queue_respects_playback_mode">Wachtrij respecteert afspeelmodus</string> ```
4443622c9d3cd146c43f5c377ee163fb15210ca0
27b336185d3d8e9b859496ec621a2bc7744f5f15
diff --git a/common/src/main/res/values-nl/strings.xml b/common/src/main/res/values-nl/strings.xml index e08c677829..34f3cfc7ee 100644 --- a/common/src/main/res/values-nl/strings.xml +++ b/common/src/main/res/values-nl/strings.xml @@ -43,7 +43,7 @@ <string name="update_changelog">Wijzigingslog</string> <string na...
[ "common/src/main/res/values-nl/strings.xml" ]
[ { "comment": "```suggestion\n <string name=\"queue_respects_playback_mode\">Wachtrij respecteert afspeelmodus</string>\n```", "path": "common/src/main/res/values-nl/strings.xml", "hunk": "@@ -717,4 +717,9 @@\n <string name=\"action_debug_info\">Foutopsporingsinformatie</string>\n <string name=\"pla...
true
yuliskov/SmartTube
5,493
issue_to_patch
Improve workflows
* Update GitHub Actions dependencies * Prevent cleanup workflow from running on forked repositories
876838d11594195a27c70b245f6ddb83106b5945
76488398cfd4406e3278679d033ba1fde58026fe
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 978bfdfd0d..9473cfbf55 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -11,7 +11,7 @@ jobs: env: HAS_SIGNING_KEY: ${{ secrets.SIGNING_KEY != '' }} HAS_VT_KEY: ${{ secrets.VIRUS_TOTAL_API_KEY != '' }} - ...
[ ".github/workflows/CI.yml", ".github/workflows/cleanup.yml", ".github/workflows/stale.yml", ".github/workflows/virustotal_scan.yml" ]
[]
true
yuliskov/SmartTube
5,567
issue_to_patch
Update strings.xml
afac9eb91c969761315f2f6702721d74447bd257
dd9bcbdd78e484b9bb70a5148a36b7ec76ddb6d5
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index 12e28f0ac7..e90f39bb52 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -733,6 +733,15 @@ <string name="player_time_stretching_desc">Zachovává přirozený ...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,557
issue_to_patch
Update strings.xml - vi-VN
6f67e3aaa0dd36cd1839b6a94d82628a34e11650
f59c236c5d9784634ca0fe187bb54a5d5a0c3ca7
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 3aa0517bde..5c6b621246 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -720,4 +720,5 @@ <string name="channel_unblocked">Đã bỏ chặn kênh</string> <stri...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
yuliskov/SmartTube
5,552
issue_to_patch
Update strings.xml (Polish language) dated 20260315
Update strings.xml (Polish language) dated 20260315
03d508d36d1dd57fbd76440f21dd03e6a419c3a9
5ac03b8177ceb83e0abd0823298d97e94afa46c6
diff --git a/common/src/main/res/values-pl/strings.xml b/common/src/main/res/values-pl/strings.xml index dac8631fec..51507c84c1 100644 --- a/common/src/main/res/values-pl/strings.xml +++ b/common/src/main/res/values-pl/strings.xml @@ -729,4 +729,8 @@ <string name="channel_unblocked">Kanał odblokowany</string> <st...
[ "common/src/main/res/values-pl/strings.xml" ]
[]
true
yuliskov/SmartTube
5,535
issue_to_patch
Update strings.xml
504acb0fa53f29e20fc362e9e39abf4f42a71f3e
da075ea1f9a584fe0e1d7c7485ca6fb0688886fb
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index 112627eb92..12e28f0ac7 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -732,9 +732,7 @@ <string name="player_time_stretching">Protahování času zvuku</st...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,503
issue_to_patch
Add Quest VR headsets to compat chart
Meta/Oculus Quest VR headsets have been added to the partial support section in the compatibility chart.
28dd2a64d4580544401437141419bf0531f51cb4
759efc1e6d017bf544aa330e9eb648b8db51fdfb
diff --git a/images/new/compatibility.png b/images/new/compatibility.png index 648699ef37..0cca11addb 100644 Binary files a/images/new/compatibility.png and b/images/new/compatibility.png differ
[ "images/new/compatibility.png" ]
[]
true
yuliskov/SmartTube
5,480
issue_to_patch
Compatibility updates
Issue #5257 pointed out that new Amazon FireTV devices no longer run Android and instead run on Amazon's new web-app based VegaOS. I have completely remade the compatibility chart to be clearer and include this change. I have also added a warning notice to the top of the Device Support section.
6b6a8e7509dd3ac9db28ba764aac6ef12e707634
29cfa4cb4200e1d74f7eab7fac5df8bafb678931
diff --git a/README.md b/README.md index 1625dc48e3..d46a52ad0b 100644 --- a/README.md +++ b/README.md @@ -48,11 +48,12 @@ Give it a try! ## Device support +> [!IMPORTANT] +> Starting in October 2025 new Amazon FireTV devices no longer run Android under the hood. SmartTube will **not** be compatibile with th...
[ "README.md", "images/new/compatibility.png" ]
[]
true
yuliskov/SmartTube
5,478
issue_to_patch
Update strings.xml
0d2a23bd6a9d81206e7fdffa93391cc42c04967d
d867368e528e166cf45a222913d087f59a7bedce
diff --git a/common/src/main/res/values-cs/strings.xml b/common/src/main/res/values-cs/strings.xml index c6f3134279..112627eb92 100644 --- a/common/src/main/res/values-cs/strings.xml +++ b/common/src/main/res/values-cs/strings.xml @@ -432,7 +432,7 @@ <string name="removed_from_playlists">Odstraněno ze sekce Playli...
[ "common/src/main/res/values-cs/strings.xml" ]
[]
true
yuliskov/SmartTube
5,469
issue_to_patch
Simplify version handling
bc141c2c3153ce94e32985564e34318cae9d3a21
ece6cfe3662e31af2c1d6a8a30ede82d1609a4eb
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index e4e427172a..978bfdfd0d 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -25,22 +25,12 @@ jobs: distribution: 'temurin' cache: 'gradle' - - name: Extract and Calculate Version + - name: Update ...
[ ".github/workflows/CI.yml" ]
[]
true
yuliskov/SmartTube
5,465
issue_to_patch
Hide "Add to playback queue" option for videos already in the playback queue
This PR addresses https://github.com/yuliskov/SmartTube/issues/5464 It hides the **Add to playback queue** option when a video is long pressed if the video has already been added to the playback queue.
eac1af89aa4eb5bc0a9eb0a4596d05844023a7b3
c7b1d1c1f8bb5081423e3a9184dcfb058a50e3af
diff --git a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java b/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java index 3e24e01b38..ff9be2aaef 100644 --- a/common/src/main/java/com/liskovsoft/smart...
[ "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/menu/VideoMenuPresenter.java" ]
[]
true
yuliskov/SmartTube
5,445
issue_to_patch
Add option to pause or stop after each video in queue
This PR adds a setting in Player -> Misc that allows playback to be paused or stopped after each video in the playback queue when "**Pause playback after each video (except queue)** or **Stop playback after one video (except queue)**" is set in the player. <img width="1506" height="849" alt="image" src="https://git...
853b2e0f1af9ac95ef378308d8f3aec8993873e6
81a86e0c8c62a39f60f9def3d0c08e9fb2c8af02
diff --git a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java b/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java index c5d6585bb5..79a9326a64 100644 --- a/common/src/main/java/com/li...
[ "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/models/playback/controllers/VideoLoaderController.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerTwea...
[]
true
yuliskov/SmartTube
5,466
issue_to_patch
Bump JDK to 17 and include universal APK in artifacts
eac1af89aa4eb5bc0a9eb0a4596d05844023a7b3
d77e33f3a7ff20d375d39545c5177460afc49eb5
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 66565d126f..35e1ebf970 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -18,10 +18,10 @@ jobs: with: submodules: recursive - - name: Set up JDK 11 + - name: Set up JDK 17 uses: actions/...
[ ".github/workflows/CI.yml" ]
[]
true
yuliskov/SmartTube
5,459
issue_to_patch
Update strings fr
0b081395462e2e17a916354255eb1d70ccedd1ab
bce29aa19113ba5c76ff3d6eaab6d5789c8d5bc7
diff --git a/common/src/main/res/values-fr/strings.xml b/common/src/main/res/values-fr/strings.xml index 07f27e31b8..3a03edcde3 100644 --- a/common/src/main/res/values-fr/strings.xml +++ b/common/src/main/res/values-fr/strings.xml @@ -728,4 +728,7 @@ <string name="channel_unblocked">Retiré de la liste noire</string>...
[ "common/src/main/res/values-fr/strings.xml" ]
[]
true
yuliskov/SmartTube
5,453
issue_to_patch
Update strings.xml
Hello Yuri, hope you doing well. Just added and translated new lines.
08cbea3437acd4ec8eb4af3a0758ccdaad8d30f9
82134d1a135246d41024c29ba3b34f3fcad48a47
diff --git a/common/src/main/res/values-az/strings.xml b/common/src/main/res/values-az/strings.xml index 60e86cd269..a761d122f7 100644 --- a/common/src/main/res/values-az/strings.xml +++ b/common/src/main/res/values-az/strings.xml @@ -692,4 +692,33 @@ <string name="import_subscriptions_group">Daxil et</string> ...
[ "common/src/main/res/values-az/strings.xml" ]
[]
true
yuliskov/SmartTube
5,442
issue_to_patch
Update strings.xml
78334e8001a32597e617df6133ae6c08ea4a02e1
2c130f8dba2bac21c2663446b18bddcbb5d1b89e
diff --git a/common/src/main/res/values-it/strings.xml b/common/src/main/res/values-it/strings.xml index da11c57291..b46b3600a3 100644 --- a/common/src/main/res/values-it/strings.xml +++ b/common/src/main/res/values-it/strings.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="utf-8"?> -<resources> +<resources xmlns:to...
[ "common/src/main/res/values-it/strings.xml" ]
[]
true
yuliskov/SmartTube
5,417
issue_to_patch
Add `ignore-updates` flag to stale bot
This PR adds the `ignore-updates` flag to the stale bot. This means it will use the creation date of an issue to determine if it is stale rather than recent activity. If you have any old actions you are currently working on you don't want to be closed we could tag them and also add a `exempt-issue-labels` flag on th...
8353ad313539c7879e1b9c9e431e49e0d824d1a9
bcda125bbecbc6622d37fcaa866894a51740d0c1
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index ac65a47e95..7257d9b962 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -16,8 +16,9 @@ jobs: with: repo-token: ${{ secrets.GITHUB_TOKEN }} operations-per-run: 3000 # This may result in rate...
[ ".github/workflows/stale.yml" ]
[]
true
yuliskov/SmartTube
5,410
issue_to_patch
Stale issues action
This PR creates a GitHub action that when manually triggered, closes all old actions as stale. @yuliskov This requires a GITHUB_TOKEN secret to be added to the repo's secrets store.
be2b67e3fcc55f6b390bd1fc8935a5f0a3b18e0a
c667abd4b197515f6673f50144283f135d2a0c6f
diff --git a/.github/ISSUE_TEMPLATE/2-feature-request.yml b/.github/ISSUE_TEMPLATE/2-feature-request.yml index 5a57ba3c19..0718bf8d5e 100644 --- a/.github/ISSUE_TEMPLATE/2-feature-request.yml +++ b/.github/ISSUE_TEMPLATE/2-feature-request.yml @@ -23,4 +23,14 @@ body: label: Describe alternatives you've considere...
[ ".github/ISSUE_TEMPLATE/2-feature-request.yml", ".github/workflows/stale.yml" ]
[]
true
yuliskov/SmartTube
5,377
issue_to_patch
feat: Configurable Speed Toggle Keybindings
- Adds a setting to key remapping category map fast forward / rewind to toggle video speed - Adds a setting to key remapping category map S key (useful when having a connected keyboard) to toggle video speed AI Disclosure: Feature implemented using AI, but tested manually using Android TV Emulator
30ad9765219385fcf9b912ffd30f35671a4dca5d
104bfc4a70bb9e9a6b0147ab575338521ed3fd51
diff --git a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java b/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java index 91aaaa2e84..78b618588e 100644 --- a/common/src/main/java/com/liskovsoft/s...
[ "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/GeneralSettingsPresenter.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/misc/PlayerKeyTranslator.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/GeneralData.java" ]
[]
true
yuliskov/SmartTube
5,391
issue_to_patch
Update and add new Slovak strings
Update and add new Slovak strings
1eedb9ff458c06e5a21b26676b342007ded78af1
e69d3f7e25f639ccb757e2725663f43d0eff67a4
diff --git a/common/src/main/res/values-sk/strings.xml b/common/src/main/res/values-sk/strings.xml index 903d08c348..f5cbe82472 100644 --- a/common/src/main/res/values-sk/strings.xml +++ b/common/src/main/res/values-sk/strings.xml @@ -81,6 +81,7 @@ <string name="player_only_ui">Iba rozhranie</string> <string ...
[ "common/src/main/res/values-sk/strings.xml" ]
[]
true
yuliskov/SmartTube
5,374
issue_to_patch
[Feature Request] Allow Variable Pitch and Speed Control Would it be possible to implement a feature that allows users to adjust video playback speed whilst also changing the audio pitch accordingly? Or better still allow independent control of speed and pitch similar to how it was implemented in NewPipe? ![Scr...
Feat: Audio time stretching
recreated from #5350 and rebased This PR is made to avoid audio distortions caused by changing the video speed. Usually, time stretching is applied to the audio to maintain pitch, this causes audio distortions. This adds a new user preference called `Audio time stretching` under `Player > misc` section, it is di...
e5ee11f6f9f40a2908cf9a57178c19b11b9a0f0a
8fc46266dbfd8bc35254addc5e5a419ffe871c9e
diff --git a/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java b/common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java index 6bd62c593f..d4b74d4fb8 100644 --- a/common/src/main/java/com/liskovsoft/sma...
[ "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/app/presenters/settings/PlayerSettingsPresenter.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/exoplayer/controller/ExoPlayerController.java", "common/src/main/java/com/liskovsoft/smartyoutubetv2/common/prefs/PlayerTweaksData.java",...
[]
true
yuliskov/SmartTube
5,316
issue_to_patch
vi-VN translation update
New strings added
481c65d8c2c76bde1a044b6b0284a2344c04a246
a4da728b60bf8c9e53163f2c440eede2d9cd8b95
diff --git a/common/src/main/res/values-vi/strings.xml b/common/src/main/res/values-vi/strings.xml index 82d7f8908c..3e578865af 100644 --- a/common/src/main/res/values-vi/strings.xml +++ b/common/src/main/res/values-vi/strings.xml @@ -710,4 +710,7 @@ <string name="play_from_start">Phát từ đầu</string> <string nam...
[ "common/src/main/res/values-vi/strings.xml" ]
[]
true
z-song/laravel-admin
4,230
issue_to_patch
Fixed the `Trying to access array offset on value of type null` error on php7.4
参见: https://twitter.com/nikita_ppv/status/1148931277216800769 PHP 7.4 will throw a notice for invalid array accesses like $null[0] or $int['bar']. Previously this silently returned null...
4ba62abaaf3554a401ce52bcfa12c169804ed350
2938fe4642291384eb4c7363c8a85e0520158428
diff --git a/resources/views/form/daterange.blade.php b/resources/views/form/daterange.blade.php index 21d05889de..6659bb03ee 100644 --- a/resources/views/form/daterange.blade.php +++ b/resources/views/form/daterange.blade.php @@ -10,14 +10,14 @@ <div class="col-lg-6"> <div class="input-gr...
[ "resources/views/form/daterange.blade.php", "resources/views/form/datetimerange.blade.php", "src/Form/Field/DateRange.php" ]
[]
true
z-song/laravel-admin
5,691
issue_to_patch
让handle路由走子后台路由
目前强制指定admin的路由，会绕后子后台的权限控制
3fb6c9ea48e2c543e5e7db81f429780a2beae4ff
5743e97f32735251dd063c9809027b9d3bd77735
diff --git a/src/Form/Field/BelongsToRelation.php b/src/Form/Field/BelongsToRelation.php index 9c41ab18d8..ee5d16a7d9 100644 --- a/src/Form/Field/BelongsToRelation.php +++ b/src/Form/Field/BelongsToRelation.php @@ -62,7 +62,7 @@ protected function getLoadUrl($multiple = 0) $selectable = str_replace('\\', '_', ...
[ "src/Form/Field/BelongsToRelation.php", "src/Form/Field/ValuePicker.php", "src/Grid/Displayers/BelongsTo.php", "src/Grid/Displayers/Modal.php" ]
[]
true
z-song/laravel-admin
5,704
issue_to_patch
修正preg_match()函数第二个参数需要为字符串
高版本的php中对preg_match()的严谨入参，如果第二个参数传`null`，则会发生以下错误。 ``` preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /vendor/laravel/framework/src/Illuminate/Routing/UrlGenerator.php on line 625 ```
3fb6c9ea48e2c543e5e7db81f429780a2beae4ff
c87428f2f5f0aa82f3b558c37a7a39c555347bb1
diff --git a/src/Auth/Database/Administrator.php b/src/Auth/Database/Administrator.php index 9f9044df45..67bf3f2fff 100644 --- a/src/Auth/Database/Administrator.php +++ b/src/Auth/Database/Administrator.php @@ -47,7 +47,7 @@ public function __construct(array $attributes = []) */ public function getAvatarAttr...
[ "src/Auth/Database/Administrator.php" ]
[]
true
z-song/laravel-admin
5,661
issue_to_patch
encode multibyte Unicode characters literally
add JSON_UNESCAPED_UNICODE bitmask to json_encode() method to encode multibyte Unicode characters (for example, Chinese characters) literally (default is to escape as \uXXXX).
27f535e824132229020cd4c6f261fa313fe09f85
c28ac163c7f3b8f81a921f8c012ee11a59baa7a6
diff --git a/src/Show/Field.php b/src/Show/Field.php index 765cb62ebb..c331d75418 100644 --- a/src/Show/Field.php +++ b/src/Show/Field.php @@ -425,7 +425,7 @@ public function json() if (json_last_error() == 0) { $field->border = false; - return '<pre><code>'.json_encode($c...
[ "src/Show/Field.php" ]
[]
true
z-song/laravel-admin
5,432
issue_to_patch
Fixed a warning in PHP 8.1.
I fixed the warnings that I encountered, although there may be others. If the value passed to functions is null, PHP8.1 will throw a warning with functions. `***(): Passing null to parameter #1 ($string) of type string is deprecated.` https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
81ff860e0592c1a742bf0efa3e975724d9fd566b
eef92fe2fde7e1d2ed2338d2220d883255f43393
diff --git a/src/Grid/Column.php b/src/Grid/Column.php index da1dbdabbe..c6ce527527 100644 --- a/src/Grid/Column.php +++ b/src/Grid/Column.php @@ -618,7 +618,7 @@ protected function useDefinedColumn() /** * Convert characters to HTML entities recursively. * - * @param array|string $item + * @pa...
[ "src/Grid/Column.php", "src/Grid/Concerns/CanHidesColumns.php", "src/Grid/Displayers/Editable.php" ]
[]
true
z-song/laravel-admin
2,363
issue_to_patch
Fixed an error when using rows in tabs
@z-song Could you try these changes? My tests were correct but it would be good if you could verify it. Displayed correctly: ![captura de pantalla 2018-08-23 a la s 16 54 21](https://user-images.githubusercontent.com/883068/44556177-bfcece80-a6f5-11e8-8f09-006fc79d2d95.png)
6b41e8c5e223e31c1c49026ef4b1d91383d4316f
5d1cd64dcc4367811bfe5d8f325e2e42f1678351
diff --git a/resources/views/form.blade.php b/resources/views/form.blade.php index cab0acff57..4da2c7444c 100644 --- a/resources/views/form.blade.php +++ b/resources/views/form.blade.php @@ -8,11 +8,7 @@ </div> <!-- /.box-header --> <!-- form start --> - @if($form->hasRows()) - {!! $form->open(...
[ "resources/views/form.blade.php", "src/Form/Row.php", "src/Form/Tab.php" ]
[]
true
z-song/laravel-admin
5,570
issue_to_patch
RTL support
I've added CSS files for adminLTE and bootstrap and wrote necessary descriptions in the ReadMe file for supporting Right To Left websites these files have added ``` \resources\assets\AdminLTE\bootstrap\css\bootstrap.rtl.min.css \resources\assets\AdminLTE\dist\css\AdminLTE.rtl.min.css ``` this file has modified ...
6c59792713d7f93fcd979432b5fc14b636f2de2c
d3b3035cc33dc6cc361c1d7e9bbaebb4237ecef8
diff --git a/README.md b/README.md index bee8f47b99..ea74e82ec4 100644 --- a/README.md +++ b/README.md @@ -84,6 +84,12 @@ Configurations ------------ The file `config/admin.php` contains an array of configurations, you can find the default configurations in there. +Right to left support +------------ +just go to th...
[ "README.md", "resources/assets/AdminLTE/bootstrap/css/bootstrap.rtl.min.css", "resources/assets/AdminLTE/dist/css/AdminLTE.rtl.min.css" ]
[]
true
z-song/laravel-admin
5,597
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/AD6aAN).
43d14884ba836e3759d3b46b6af1fe97b3f58e77
e95e80aefac002214b819f50241a0246b89ca73c
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php index ee0af6c8a0..0fa78573c9 100644 --- a/src/AdminServiceProvider.php +++ b/src/AdminServiceProvider.php @@ -5,9 +5,9 @@ use Encore\Admin\Layout\Content; use Illuminate\Routing\Router; use Illuminate\Support\Arr; -use Illuminate\Support\Str; ...
[ "src/AdminServiceProvider.php" ]
[]
true
z-song/laravel-admin
5,547
issue_to_patch
[Fix] 修复未引用Str类导致在Laravel5.5 LTS版本中报错的问题
![image](https://user-images.githubusercontent.com/16308633/159436052-d550f743-9b75-423a-842e-da4c2eae8505.png)
6727f64754f69599d44f1362a2963588c07e6f8c
04be51658c972ded826cdb4f9736a5f861fef3cc
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php index 2d7e07719b..38ebea6755 100644 --- a/src/AdminServiceProvider.php +++ b/src/AdminServiceProvider.php @@ -5,6 +5,7 @@ use Encore\Admin\Layout\Content; use Illuminate\Routing\Router; use Illuminate\Support\Arr; +use Illuminate\Support\Str; ...
[ "src/AdminServiceProvider.php" ]
[]
true
z-song/laravel-admin
5,555
issue_to_patch
[Fixed] fix typo
rt
172dd01447d5bf478011d89b0f0a506285084423
639ad606ac0a1658cc864f8e6185112ed539ad9a
diff --git a/src/Tree/Tools.php b/src/Tree/Tools.php index 8f4d03a8a8..4454230396 100644 --- a/src/Tree/Tools.php +++ b/src/Tree/Tools.php @@ -26,7 +26,7 @@ class Tools implements Renderable /** * Create a new Tools instance. * - * @param Builder $builder + * @param Tree $tree */ pub...
[ "src/Tree/Tools.php" ]
[]
true
z-song/laravel-admin
5,546
issue_to_patch
laravel9 发布语言文件
6727f64754f69599d44f1362a2963588c07e6f8c
9741233a5c0399929da0b70fe3e97842d093ef22
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php index 2d7e07719b..a61665f3e5 100644 --- a/src/AdminServiceProvider.php +++ b/src/AdminServiceProvider.php @@ -115,7 +115,11 @@ protected function registerPublishing() { if ($this->app->runningInConsole()) { $this->publis...
[ "src/AdminServiceProvider.php" ]
[ { "comment": "判断语义化版本号，推荐使用 version_compare 函数 https://www.php.net/manual/en/function.version-compare.php", "path": "src/AdminServiceProvider.php", "hunk": "@@ -115,7 +115,11 @@ protected function registerPublishing()\n {\n if ($this->app->runningInConsole()) {\n $this->publishes...
true
z-song/laravel-admin
5,540
issue_to_patch
Fix Upload File
- Update UploadField.php to support Laravel 9 since Laravel 9 using Flysystem v3 and the location of file cannot be empty
2633381495887754e3f8f5d2a878ec8af847799b
b44ceae2ad8f6c1d448123f8b68f64946833c59b
diff --git a/src/Form/Field/UploadField.php b/src/Form/Field/UploadField.php index 98339a027d..b4c31203e5 100644 --- a/src/Form/Field/UploadField.php +++ b/src/Form/Field/UploadField.php @@ -497,7 +497,7 @@ public function destroy() $this->destroyThumbnail(); } - if ($this->storage->exist...
[ "src/Form/Field/UploadField.php" ]
[]
true
z-song/laravel-admin
5,541
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/m4J39W).
3d9974ca36607ab3d129f2fc3157c2f30478d243
ab8f05ae3fab60b2fd5f24e2d86377a87e2aa674
diff --git a/src/Show/Field.php b/src/Show/Field.php index 04c705317c..765cb62ebb 100644 --- a/src/Show/Field.php +++ b/src/Show/Field.php @@ -391,11 +391,12 @@ public function badge($style = 'blue') } /** - * Show field as number - * - * @param int $decimals + * Show field as number. + ...
[ "src/Show/Field.php" ]
[]
true
z-song/laravel-admin
5,312
issue_to_patch
Exclude route from generate menu command
2c4834cf2d3160b31714292eece6df58e78c177f
f979cd568fb0808ca18714f0c686f72964c01691
diff --git a/config/admin.php b/config/admin.php index 17d87e8e24..ecc36466c9 100644 --- a/config/admin.php +++ b/config/admin.php @@ -361,6 +361,16 @@ */ 'enable_menu_search' => true, + /* + |-------------------------------------------------------------------------- + | Exclude route from generate...
[ "config/admin.php", "src/Console/GenerateMenuCommand.php" ]
[]
true
z-song/laravel-admin
5,436
issue_to_patch
fixed favicon method inconsistency with document and usages
In documents and views, `favicon()` was used like: ```php Admin::favicon('favicon.png'); ``` ```php @if(!is_null($favicon = Admin::favicon())) <link rel="shortcut icon" href="{{$favicon}}"> @endif ``` However, in **Encore\Admin\Admin**, it is inconsistently designated as `public function` rather than...
6bfc26ef858fafc2e18b71559c6347ed20ae298d
dd77dd89f0f073e78310437ba78e831a5cc6ccec
diff --git a/src/Admin.php b/src/Admin.php index ca6ffe703e..9642ea76ad 100644 --- a/src/Admin.php +++ b/src/Admin.php @@ -226,7 +226,7 @@ public function title() * * @return string|void */ - public function favicon($favicon = null) + public static function favicon($favicon = null) { ...
[ "src/Admin.php", "src/Widgets/Box.php" ]
[]
true
z-song/laravel-admin
5,516
issue_to_patch
Show validation errors when switch changed
When the state of the switch changes and there is a validation error, an empty warning appears and a JS error occurs in the console. At the same time the visual state of the switch changes. This commit displays an error message and does not change the visual state if an error occurs.
f392cc46c55bd098c1ab34af8233ac75a756c146
f1e4217a5dda4ab5315c1f145819da420991dda9
diff --git a/resources/views/grid/inline-edit/switch.blade.php b/resources/views/grid/inline-edit/switch.blade.php index dc5d701072..94d35dde72 100644 --- a/resources/views/grid/inline-edit/switch.blade.php +++ b/resources/views/grid/inline-edit/switch.blade.php @@ -22,7 +22,8 @@ data: { ...
[ "resources/views/grid/inline-edit/switch.blade.php" ]
[]
true
z-song/laravel-admin
5,507
issue_to_patch
optimization
![image](https://user-images.githubusercontent.com/5334769/150303086-2a624643-88f5-4287-8e71-52d3f7e734e8.png) There is no enough width for my screen When I use $filter->column(1 / 3);
5de9c8989d07fb031b81a317a4ea4b5fe12830b2
ee256ec5b5746f0f602b1410a6a9d099b04a3769
diff --git a/resources/views/filter/between.blade.php b/resources/views/filter/between.blade.php index 9c3b076c50..5d3531ecc0 100644 --- a/resources/views/filter/between.blade.php +++ b/resources/views/filter/between.blade.php @@ -1,6 +1,6 @@ <div class="form-group"> <label class="col-sm-2 control-label">{{$label...
[ "resources/views/filter/between.blade.php", "resources/views/filter/betweenDatetime.blade.php", "src/Admin.php" ]
[]
true
z-song/laravel-admin
5,499
issue_to_patch
Update GenerateMenuCommand.php
Generate menu fix problem url "in/route"
2bd34796aaa89150bec693c93ef7bfd8f3997b5d
926f70b3ae86a665ccca9ecc815b915197063f00
diff --git a/src/Console/GenerateMenuCommand.php b/src/Console/GenerateMenuCommand.php index bff95cd613..3140c4a44a 100644 --- a/src/Console/GenerateMenuCommand.php +++ b/src/Console/GenerateMenuCommand.php @@ -48,8 +48,8 @@ public function __construct(Router $router) */ public function handle() { - ...
[ "src/Console/GenerateMenuCommand.php" ]
[]
true
z-song/laravel-admin
5,498
issue_to_patch
将配置项 admin_https 的作用域限制到 /admin*
配置项的名称是 admin_https，那么该配置的作用域不应该超出 /admin* 的范围，即不应该去影响非后台路由，一旦这里影响了，后续想要在其他页面做 http 和 https 的兼容会很麻烦
e0e17486b07e15d5fda2230f8314ba2da2a9fe9c
6f5e80adb9d519b00579291452bf15cd2d7fd2a9
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php index 233bba360d..2d7e07719b 100644 --- a/src/AdminServiceProvider.php +++ b/src/AdminServiceProvider.php @@ -99,7 +99,8 @@ public function boot() */ protected function ensureHttps() { - if (config('admin.https') || config('...
[ "src/AdminServiceProvider.php" ]
[ { "comment": "admin 需要改成 config 中设置的变量", "path": "src/AdminServiceProvider.php", "hunk": "@@ -99,7 +99,7 @@ public function boot()\n */\n protected function ensureHttps()\n {\n- if (config('admin.https') || config('admin.secure')) {\n+ if ((config('admin.https') || config('adm...
true
z-song/laravel-admin
5,498
comment_to_fix
将配置项 admin_https 的作用域限制到 /admin*
admin 需要改成 config 中设置的变量
e0e17486b07e15d5fda2230f8314ba2da2a9fe9c
6f5e80adb9d519b00579291452bf15cd2d7fd2a9
diff --git a/src/AdminServiceProvider.php b/src/AdminServiceProvider.php index 233bba360d..2d7e07719b 100644 --- a/src/AdminServiceProvider.php +++ b/src/AdminServiceProvider.php @@ -99,7 +99,8 @@ public function boot() */ protected function ensureHttps() { - if (config('admin.https') || config('...
[ "src/AdminServiceProvider.php" ]
[ { "comment": "admin 需要改成 config 中设置的变量", "path": "src/AdminServiceProvider.php", "hunk": "@@ -99,7 +99,7 @@ public function boot()\n */\n protected function ensureHttps()\n {\n- if (config('admin.https') || config('admin.secure')) {\n+ if ((config('admin.https') || config('adm...
true
z-song/laravel-admin
5,497
issue_to_patch
Show field as number
Add number to show field as number `$show->field('price')->number()` Show `100000` as `100,000`
45c58c656fcc6a8c57423d2256f3b7a73e783441
2e07ec9aef2f6d580775c320a71842f8aa56f1c3
diff --git a/src/Show/Field.php b/src/Show/Field.php index ed3796447a..04c705317c 100644 --- a/src/Show/Field.php +++ b/src/Show/Field.php @@ -390,6 +390,21 @@ public function badge($style = 'blue') }); } + /** + * Show field as number + * + * @param int $decimals + * @param string $...
[ "src/Show/Field.php" ]
[]
true
z-song/laravel-admin
5,495
issue_to_patch
fix declaration of Encore\Admin\Form\Field\Checkbox::groups
## Env PHP 7.0.33 Laravel 5.5 ## Description 我用php7.0.33装1.8.16，刚开始我以为是版本的问题，就降了一个版本，装了1.8.15,也有这个问题。再看Requirements,是支持7.0版本的。 ```txt "Declaration of Encore\Admin\Form\Field\Checkbox::groups($groups = Array) should be compatible with Encore\Admin\Form\Field\Select::groups(array $groups)" ```
60038d6de7788a5bde0916f38fb9b707964e3d19
a9e4906e6c4d95520d55bd11d31a418df98ca820
diff --git a/src/Form/Field/Checkbox.php b/src/Form/Field/Checkbox.php index f6358761da..e4d3bb11eb 100644 --- a/src/Form/Field/Checkbox.php +++ b/src/Form/Field/Checkbox.php @@ -66,7 +66,7 @@ public function canCheckAll() * * @return $this */ - public function groups($groups = []) + public func...
[ "src/Form/Field/Checkbox.php" ]
[]
true
z-song/laravel-admin
5,496
issue_to_patch
Apply fixes from StyleCI
This pull request applies code style fixes from an analysis carried out by [StyleCI](https://github.styleci.io). --- For more information, click [here](https://github.styleci.io/analyses/PxJdDo).
7863af710a7d9081c8f3e0665eec4d71e4bf7602
190445f977949d9cd9b1706b4b7acc4e2a302805
diff --git a/src/Console/GenerateMenuCommand.php b/src/Console/GenerateMenuCommand.php index 5cfbc16626..bff95cd613 100644 --- a/src/Console/GenerateMenuCommand.php +++ b/src/Console/GenerateMenuCommand.php @@ -76,9 +76,9 @@ public function handle() $news = $routes->diffKeys($menus)->map(function ($item, $key)...
[ "src/Console/GenerateMenuCommand.php" ]
[]
true
z-song/laravel-admin
5,452
issue_to_patch
Support MultipleSelect approach for HasMany relation
8189b3ebb23433f2f6d036bb9b48b06bdc8a4480
8844940fa57d21ceeccc84922c99d8f604c5bd09
diff --git a/src/Form.php b/src/Form.php index 5bce4ce3ff..2766524e79 100644 --- a/src/Form.php +++ b/src/Form.php @@ -801,25 +801,51 @@ protected function updateRelation($relationsData) break; case $relation instanceof Relations\HasMany: case $relation instanceof ...
[ "src/Form.php", "src/Form/Field/MultipleSelect.php" ]
[]
true
z-song/laravel-admin
5,489
issue_to_patch
fix grid json column sortable error
如果grid的某一列为json，排序时会导致sql报错： SQLSTATE[42S22]: Column not found: 1054 Unknown column 'prefix_JSON_EXTRACT(json, '$.json_column')' in 'order clause' 原因是json处理后的排序字段： ![image](https://user-images.githubusercontent.com/7800865/147059235-b08f1808-ba90-429e-b496-2c1f0c1ac79c.png) 会在执行时被laravelORM的Gammer转译（增加前缀和``） 所以在增...
cfd0964cd2b752a2caefb07f4447b83ad12cf64f
048c231036e10b57084e172f63a88718739cc3a7
diff --git a/src/Grid/Model.php b/src/Grid/Model.php index 32036fb582..92d5396aea 100644 --- a/src/Grid/Model.php +++ b/src/Grid/Model.php @@ -9,6 +9,7 @@ use Illuminate\Database\Eloquent\Relations\HasMany; use Illuminate\Database\Eloquent\Relations\HasOne; use Illuminate\Database\Eloquent\Relations\Relation; +use I...
[ "src/Grid/Model.php" ]
[]
true
z-song/laravel-admin
5,480
issue_to_patch
Adds config-based route prefix to GenerateMenuCommand.php
This PR solves hard-coded route-prefix(admin) issue when execute `php artisan admin:generate-menu` command.Because this prefix value can be changed dynamically at `admin.route.prefix` value in config. ``` 'route' => [ 'prefix' => env('ADMIN_ROUTE_PREFIX', 'zero'), 'namespace' => 'App\\Admin\...
ec84a211b55ad081e2c795bfa28b6b9f43669251
e7f03ac4f81bd40c567dcbde76bc2200744aa834
diff --git a/src/Console/GenerateMenuCommand.php b/src/Console/GenerateMenuCommand.php index 65d92db7a0..5cfbc16626 100644 --- a/src/Console/GenerateMenuCommand.php +++ b/src/Console/GenerateMenuCommand.php @@ -49,17 +49,18 @@ public function __construct(Router $router) public function handle() { $ro...
[ "src/Console/GenerateMenuCommand.php" ]
[]
true
z-song/laravel-admin
5,469
issue_to_patch
replace close-icon to times-icon
修改一个图标不显示的 bug
96adcf7ea4f44434da62dd91587c1dd35e8ef003
8eff4ff06ef54cee440c294a8c385837a7cafb48
diff --git a/src/Table/Column/ExtendDisplay.php b/src/Table/Column/ExtendDisplay.php index eca5fdafdb..d35831e692 100644 --- a/src/Table/Column/ExtendDisplay.php +++ b/src/Table/Column/ExtendDisplay.php @@ -293,7 +293,7 @@ public function bool(array $map = [], $default = false) return $this->display(function (...
[ "src/Table/Column/ExtendDisplay.php" ]
[]
true
z-song/laravel-admin
5,467
issue_to_patch
去除空格
去除空格，兼容有些浏览器无法自动解析
0f7bafbd2acd4cdb2118c2a6105a6b2aa9dacb13
2bc9060f69af7e3cbf7ab55f84356a43c30c54ed
diff --git a/resources/views/login.blade.php b/resources/views/login.blade.php index bc6ad30d9b..2852ed4139 100644 --- a/resources/views/login.blade.php +++ b/resources/views/login.blade.php @@ -85,7 +85,7 @@ <!-- /.login-box --> <!-- jQuery 2.1.4 --> -<script src="{{ admin_asset("vendor/laravel-admin/AdminLTE/plug...
[ "resources/views/login.blade.php" ]
[]
true
z-song/laravel-admin
5,455
issue_to_patch
fix: permission command filter permission error
6d12f77ce5b0dff9c9ce1c2f1e4364c48d8b29cc
625704a2626e9ed573bc74c38fc132a4424e50d3
diff --git a/src/Console/PermissionCommand.php b/src/Console/PermissionCommand.php index 1985a78cbf..755c3ee56c 100644 --- a/src/Console/PermissionCommand.php +++ b/src/Console/PermissionCommand.php @@ -124,9 +124,6 @@ private function generateHttpMethod($permission) case 'delete': $http_m...
[ "src/Console/PermissionCommand.php" ]
[]
true
z-song/laravel-admin
5,454
issue_to_patch
修正Grid無法對關聯欄位使用sortable()的問題
修正Grid無法對關聯欄位使用sortable()的問題
8189b3ebb23433f2f6d036bb9b48b06bdc8a4480
8ce101702a70b583c08a3fa6046aa14b6b14a4fa
diff --git a/src/Grid/Model.php b/src/Grid/Model.php index 5949056f20..32036fb582 100644 --- a/src/Grid/Model.php +++ b/src/Grid/Model.php @@ -526,6 +526,9 @@ protected function setSort() $columnNameContainsDots = Str::contains($columnName, '.'); $isRelation = $this->queries->contains(function ($que...
[ "src/Grid/Model.php" ]
[]
true
z-song/laravel-admin
5,447
issue_to_patch
BOM 头应该放到文件头部输出
否则会循环输出 BOM头
a9f9c58569c8b6da009e8c4277fcf6db333f3be0
bc5489ea697af6896db2a8ae4ae1f5d2b3b2b8ac
diff --git a/src/Grid/Exporters/CsvExporter.php b/src/Grid/Exporters/CsvExporter.php index addb0bc1e8..04f31b07df 100644 --- a/src/Grid/Exporters/CsvExporter.php +++ b/src/Grid/Exporters/CsvExporter.php @@ -160,7 +160,7 @@ public function export() $response = function () { $handle = fopen('php://o...
[ "src/Grid/Exporters/CsvExporter.php" ]
[]
true
z-song/laravel-admin
5,443
issue_to_patch
fix: grid column label function not support boolean value
f4f69cb528d46aa9221808f92ecc8c115a05c164
9ae1d198584b172d076e94337c21400b72a973cf
diff --git a/src/Grid/Displayers/Label.php b/src/Grid/Displayers/Label.php index 713ee968e2..8e46f9ffe6 100644 --- a/src/Grid/Displayers/Label.php +++ b/src/Grid/Displayers/Label.php @@ -15,8 +15,12 @@ public function display($style = 'success') return collect((array) $this->value)->map(function ($item) use ...
[ "src/Grid/Displayers/Label.php" ]
[]
true
z-song/laravel-admin
5,441
issue_to_patch
fix: remove unwanted 'return'
1d073ce979d239f7f85799e2743dd1ec855470f7
1dff66e246d41b446c2fb5adc8b7ae77342ecf04
diff --git a/src/Grid.php b/src/Grid.php index 5e6cb1a9d7..f0e64e86b7 100644 --- a/src/Grid.php +++ b/src/Grid.php @@ -935,7 +935,5 @@ public function render() $this->callRenderingCallback(); return Admin::component($this->view, $this->variables()); - - return view($this->view, $this->variabl...
[ "src/Grid.php" ]
[]
true
z-song/laravel-admin
5,442
issue_to_patch
fix: the comment declaration has the wrong return type
1d073ce979d239f7f85799e2743dd1ec855470f7
58f21a9f4576a688710ae0ba598f9bb62c5eaa6d
diff --git a/src/Controllers/AuthController.php b/src/Controllers/AuthController.php index 027cbaf207..aa69a72223 100644 --- a/src/Controllers/AuthController.php +++ b/src/Controllers/AuthController.php @@ -186,7 +186,7 @@ protected function redirectPath() * * @param \Illuminate\Http\Request $request ...
[ "src/Controllers/AuthController.php" ]
[]
true
z-song/laravel-admin
5,440
issue_to_patch
fix: 修复使用规格选择器的 selectOne 时出现 TypeError 的问题
### 问题： 按照 [文档示例](https://laravel-admin.org/docs/zh/1.x/model-grid-spec-selector#%E5%9F%BA%E6%9C%AC%E4%BD%BF%E7%94%A8) 使用 **$selector->selectOne()** 时，会出现报错： ``` TypeError In Builder.php line 3265 : ``` ### 复现： 使用代码 ```php $grid->selector(function (Grid\Tools\Selector $selector) { $selector->select...
335f768b68663a4d0399318e5bf6927c54547c7c
7aa3ef7f8fd7722ea988abb54d63d512cc97e148
diff --git a/src/Grid/Concerns/HasSelector.php b/src/Grid/Concerns/HasSelector.php index 0648cf4c10..d6ecd8a0ab 100644 --- a/src/Grid/Concerns/HasSelector.php +++ b/src/Grid/Concerns/HasSelector.php @@ -53,12 +53,12 @@ protected function applySelectorQuery() $values = $active[$column]; - if ...
[ "src/Grid/Concerns/HasSelector.php" ]
[]
true
z-song/laravel-admin
5,435
issue_to_patch
Fix date-range field problem with Persian numbers
Same as other date and time fields make user to be able to set custom locale for data-range field Sometime it is required like when your locale is Persian and you want receive date numbers in English
81ff860e0592c1a742bf0efa3e975724d9fd566b
cf4b34d9b5bbd30290ae309d878c5c70afb5bcdf
diff --git a/src/Form/Field/DateRange.php b/src/Form/Field/DateRange.php index 6479a51687..3d12e68431 100644 --- a/src/Form/Field/DateRange.php +++ b/src/Form/Field/DateRange.php @@ -50,7 +50,7 @@ public function prepare($value) public function render() { - $this->options['locale'] = config('app.loca...
[ "src/Form/Field/DateRange.php" ]
[]
true
z-song/laravel-admin
5,424
issue_to_patch
修复表格固定列错位
e484063ef896f3017be1451528ee9f799be51251
da16945942eda7ea070715a19df8188c0f4a48b8
diff --git a/resources/views/grid/fixed-table.blade.php b/resources/views/grid/fixed-table.blade.php index 15abb8dc90..92577a0895 100644 --- a/resources/views/grid/fixed-table.blade.php +++ b/resources/views/grid/fixed-table.blade.php @@ -172,14 +172,14 @@ </style> <script> - var theadHeight = $('.table-main the...
[ "resources/views/grid/fixed-table.blade.php" ]
[]
true
z-song/laravel-admin
5,431
issue_to_patch
Put user CSS after default CSS to override them
Put user CSS after default CSS to user be able to override defaults one easily
e484063ef896f3017be1451528ee9f799be51251
139f760616d69671a44cc1ecb253582f64cffc39
diff --git a/src/Traits/HasAssets.php b/src/Traits/HasAssets.php index 190e9a77f9..69d811b218 100644 --- a/src/Traits/HasAssets.php +++ b/src/Traits/HasAssets.php @@ -112,11 +112,11 @@ public static function css($css = null, $minify = true) static::ignoreMinify($css, $minify); if (!is_null($css)) { ...
[ "src/Traits/HasAssets.php" ]
[]
true
z-song/laravel-admin
5,422
issue_to_patch
[PHPDoc] fix the return type
I found the return type is wrong during static analysis. Could you please merge it?
6ec9033cb12662c86d3c463c1706dc9fe1186282
6546b176ef4c7bdb5730338f887df2f03ab8ee0d
diff --git a/src/Grid/Selectable.php b/src/Grid/Selectable.php index 0e892b35e5..9850e1ef50 100644 --- a/src/Grid/Selectable.php +++ b/src/Grid/Selectable.php @@ -58,7 +58,7 @@ public function __construct($multiple = false, $key = '') } /** - * @return Grid + * @return void */ abstract pu...
[ "src/Grid/Selectable.php" ]
[]
true
z-song/laravel-admin
5,421
issue_to_patch
Update admin.php
feat: Make admin-skin as env editable Useful when you want to make difference between local and server/production to prevent mistakes
7f61bc0ecf2e47fafea4d023873b4a950a26b67e
210147a7cf682a71458189799d9cb80593b06d8b
diff --git a/config/admin.php b/config/admin.php index ecc36466c9..3ee051e24f 100644 --- a/config/admin.php +++ b/config/admin.php @@ -275,7 +275,7 @@ | "skin-red", "skin-red-light", "skin-black", "skin-black-light". | */ - 'skin' => 'skin-blue-light', + 'skin' => env('ADMIN_SKIN', 'skin-blue-li...
[ "config/admin.php" ]
[]
true
z-song/laravel-admin
5,414
issue_to_patch
feat: adds German translation
Adding German translation to Admin Panel controls.
cb28d1f0f072f9cadb1589ea1a7dcf39e0fae413
1aa1555d11831ce5df5740b28d44ab4619ecd07b
diff --git a/resources/lang/de/admin.php b/resources/lang/de/admin.php new file mode 100644 index 0000000000..a7d2d38e72 --- /dev/null +++ b/resources/lang/de/admin.php @@ -0,0 +1,107 @@ +<?php + +return [ + 'online' => 'Online', + 'login' => 'Anmelden', + 'logout' ...
[ "resources/lang/de/admin.php" ]
[]
true
z-song/laravel-admin
5,395
issue_to_patch
Revert #4913 "解决有时获取IP不正确问题。"
#4913 broke trusted proxies setting and introduced a security issue. ref: https://github.com/z-song/laravel-admin/pull/4913#issuecomment-909292852
753ee1354f68dbe0800df46ff8b70ad2d318d90d
3fbd636b3f4e04f315b667bd06d9f33288fab3c6
diff --git a/src/Middleware/LogOperation.php b/src/Middleware/LogOperation.php index f64ea6c2fa..f999efe2f7 100644 --- a/src/Middleware/LogOperation.php +++ b/src/Middleware/LogOperation.php @@ -20,7 +20,6 @@ class LogOperation public function handle(Request $request, \Closure $next) { if ($this->sho...
[ "src/Middleware/LogOperation.php" ]
[]
true
z-song/laravel-admin
4,913
issue_to_patch
解决有时获取IP不正确问题。
72c947795a04c9f6a5ef88bdbf419bae4625f8bc
ed27283df2a23c7a316f926ef88732092f37422a
diff --git a/src/Middleware/LogOperation.php b/src/Middleware/LogOperation.php index f999efe2f7..f64ea6c2fa 100644 --- a/src/Middleware/LogOperation.php +++ b/src/Middleware/LogOperation.php @@ -20,6 +20,7 @@ class LogOperation public function handle(Request $request, \Closure $next) { if ($this->sho...
[ "src/Middleware/LogOperation.php" ]
[]
true
z-song/laravel-admin
5,390
issue_to_patch
Fix single quote in js script (with french translations)
3dc8a8dd9dc4e9aae3529a9f0668048b9ce11017
8eca5aa83b8f27aaa4448cc133c5deafc3ca6367
diff --git a/src/Tree.php b/src/Tree.php index b1703c7c57..c109cb465b 100644 --- a/src/Tree.php +++ b/src/Tree.php @@ -220,12 +220,12 @@ public function saveOrder($serialize) protected function script() { $trans = [ - 'delete_confirm' => trans('admin.delete_confirm'), - 'save...
[ "src/Tree.php" ]
[]
true
z-song/laravel-admin
5,389
issue_to_patch
feature: add cssClasses to custom batch action button
this pull request implements a feature into BatchAction * one can add a css class to the button (a href) for styling * one can add multiple css classes to the button
e1fc23088e95b81b84cc9e3d0a4932b85f59a9d6
e63897dd05adfe2a35679f70b3e7f026da989135
diff --git a/src/Actions/BatchAction.php b/src/Actions/BatchAction.php index 6d194f1d1a..86be3b033a 100644 --- a/src/Actions/BatchAction.php +++ b/src/Actions/BatchAction.php @@ -11,6 +11,58 @@ abstract class BatchAction extends GridAction */ public $selectorPrefix = '.grid-batch-action-'; + /** + *...
[ "src/Actions/BatchAction.php" ]
[]
true
z-song/laravel-admin
5,386
issue_to_patch
remove sourceMappingURL fixing devTools warnings
When compile `toastr`, `laravel-admin` did not remove the source mapping configs, thus devTools would give a warning. ``` DevTools failed to load source map: Could not load content for /vendor/laravel-admin/toastr/build/toastr.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE ``` If the a...
480c92cb5c0d7e631be27b4a7f34c7c3713b798c
981afb56361e9137390710a71b33befade8934f1
diff --git a/resources/assets/toastr/build/toastr.min.js b/resources/assets/toastr/build/toastr.min.js index 7c0c07c2a6..9d17638cc1 100755 --- a/resources/assets/toastr/build/toastr.min.js +++ b/resources/assets/toastr/build/toastr.min.js @@ -1,2 +1,1 @@ !function(e){e(["jquery"],function(e){return function(){function...
[ "resources/assets/toastr/build/toastr.min.js" ]
[]
true
z-song/laravel-admin
5,383
issue_to_patch
Make sure `$field` is valid
当同时使用 `$form->when()` 和 `$form->embeds()` 的时候有可能会出现此处 `$field` 为 null 的情况, 兼容一下.
f8d43e3262f7c08b9b1ab4983a2dfd23ccf78cb5
85a0870568276b90574daedc966eced732e06dd8
diff --git a/src/Form/EmbeddedForm.php b/src/Form/EmbeddedForm.php index 14e367cb48..1007308457 100644 --- a/src/Form/EmbeddedForm.php +++ b/src/Form/EmbeddedForm.php @@ -181,7 +181,7 @@ protected function prepareValue($key, $record) return in_array($key, (array) $field->column()); }); - ...
[ "src/Form/EmbeddedForm.php" ]
[]
true
z-song/laravel-admin
5,385
issue_to_patch
Fix validation error, unable to submit repeatedly
## Grid 自定义操作模态框Form，添加验证规则时，错误的数据提交，无法继续正常提交 ## 场景还原 ``` public function form() { .... $this->radio('status', __('admin.status'))->options($status)->rules('required'); $this->textarea('login_remark', __('admin.Login remark'))->rules('required'); } ``` 设置验证规则后，错误的数据，按钮一直显...
f8d43e3262f7c08b9b1ab4983a2dfd23ccf78cb5
3aadabd65e871654c63c718cd5d46f079408de47
diff --git a/src/Actions/Interactor/Form.php b/src/Actions/Interactor/Form.php index 69aea6cf69..a101a6f3b4 100644 --- a/src/Actions/Interactor/Form.php +++ b/src/Actions/Interactor/Form.php @@ -617,6 +617,7 @@ protected function buildGeneralActionPromise() if (data.status === true) { ...
[ "src/Actions/Interactor/Form.php" ]
[]
true