url
stringlengths
50
53
repository_url
stringclasses
1 value
labels_url
stringlengths
64
67
comments_url
stringlengths
59
62
events_url
stringlengths
57
60
html_url
stringlengths
38
43
id
int64
597k
2.65B
node_id
stringlengths
18
32
number
int64
1
6.83k
title
stringlengths
1
296
user
dict
labels
listlengths
0
5
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
4
milestone
dict
comments
int64
0
211
created_at
stringlengths
20
20
updated_at
stringlengths
20
20
closed_at
stringlengths
20
20
author_association
stringclasses
3 values
active_lock_reason
stringclasses
4 values
body
stringlengths
0
65.6k
closed_by
dict
reactions
dict
timeline_url
stringlengths
59
62
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
is_pull_request
bool
2 classes
issue_comments
listlengths
0
30
https://api.github.com/repos/psf/requests/issues/2530
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2530/labels{/name}
https://api.github.com/repos/psf/requests/issues/2530/comments
https://api.github.com/repos/psf/requests/issues/2530/events
https://github.com/psf/requests/issues/2530
66,483,378
MDU6SXNzdWU2NjQ4MzM3OA==
2,530
__build__ out of sync? Still at 0x020503, looks like 2.5.3 rather than 2.6.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/1577132?v=4", "events_url": "https://api.github.com/users/hartwork/events{/privacy}", "followers_url": "https://api.github.com/users/hartwork/followers", "following_url": "https://api.github.com/users/hartwork/following{/other_user}", "gists_url": "https://api.github.com/users/hartwork/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hartwork", "id": 1577132, "login": "hartwork", "node_id": "MDQ6VXNlcjE1NzcxMzI=", "organizations_url": "https://api.github.com/users/hartwork/orgs", "received_events_url": "https://api.github.com/users/hartwork/received_events", "repos_url": "https://api.github.com/users/hartwork/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hartwork/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hartwork/subscriptions", "type": "User", "url": "https://api.github.com/users/hartwork", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
1
2015-04-05T21:21:27Z
2021-09-08T23:05:47Z
2015-04-06T21:54:22Z
NONE
resolved
Could it be that ``` __build__ = 0x020503 ``` at https://github.com/kennethreitz/requests/blob/master/requests/__init__.py#L46 went out of sync? It looks like 2.5.3 rather than 2.6.0. Best, Sebastian
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2530/reactions" }
https://api.github.com/repos/psf/requests/issues/2530/timeline
null
completed
null
null
false
[ "Yup, this looks wrong.\n" ]
https://api.github.com/repos/psf/requests/issues/2529
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2529/labels{/name}
https://api.github.com/repos/psf/requests/issues/2529/comments
https://api.github.com/repos/psf/requests/issues/2529/events
https://github.com/psf/requests/issues/2529
66,482,975
MDU6SXNzdWU2NjQ4Mjk3NQ==
2,529
"import requests" takes a full second?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1577132?v=4", "events_url": "https://api.github.com/users/hartwork/events{/privacy}", "followers_url": "https://api.github.com/users/hartwork/followers", "following_url": "https://api.github.com/users/hartwork/following{/other_user}", "gists_url": "https://api.github.com/users/hartwork/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hartwork", "id": 1577132, "login": "hartwork", "node_id": "MDQ6VXNlcjE1NzcxMzI=", "organizations_url": "https://api.github.com/users/hartwork/orgs", "received_events_url": "https://api.github.com/users/hartwork/received_events", "repos_url": "https://api.github.com/users/hartwork/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hartwork/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hartwork/subscriptions", "type": "User", "url": "https://api.github.com/users/hartwork", "user_view_type": "public" }
[]
closed
true
null
[]
null
8
2015-04-05T21:16:20Z
2021-09-08T12:01:07Z
2015-04-06T11:20:26Z
NONE
resolved
Hi! I noticed that the `--help` output of a tool of mine was noticably slower than that of my other tools. It took a full second to show up. I traced the lagging down to the call to `import requests` (and [worked around it](https://github.com/hartwork/backup-my-hub/commit/509b30e53cccefd39c68311e456bba813e0be455) by importing requests only after processing command line options). `import requests` takes at least a second on both the SSDed Debian and HDDed Gentoo, with version 2.5.3 as well as 2.6.0. Compared to the 30 milliseconds that other modules take to import, that's a long time: ``` # time python -c 'import requests; print requests.__file__' /usr/lib64/python2.7/site-packages/requests/__init__.pyc real 0m1.099s user 0m1.055s sys 0m0.039s # time python -c 'import argparse; print argparse.__file__' /usr/lib64/python2.7/argparse.pyc real 0m0.030s user 0m0.018s sys 0m0.010s ``` It would be great if you could work on reducing import time. Many thanks!
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2529/reactions" }
https://api.github.com/repos/psf/requests/issues/2529/timeline
null
completed
null
null
false
[ "I believe the slow part of importing requests is importing pyopenssl. In theory you could delay the import until the first time a request is made, though I'm pretty sure the team is not in favor of that approach.\n", "> I believe the slow part of importing requests is importing pyopenssl. \n\nThat makes perfect ...
https://api.github.com/repos/psf/requests/issues/2528
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2528/labels{/name}
https://api.github.com/repos/psf/requests/issues/2528/comments
https://api.github.com/repos/psf/requests/issues/2528/events
https://github.com/psf/requests/issues/2528
66,482,196
MDU6SXNzdWU2NjQ4MjE5Ng==
2,528
2.5.1 labeled latest release at GitHub (rather than 2.6.0)?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1577132?v=4", "events_url": "https://api.github.com/users/hartwork/events{/privacy}", "followers_url": "https://api.github.com/users/hartwork/followers", "following_url": "https://api.github.com/users/hartwork/following{/other_user}", "gists_url": "https://api.github.com/users/hartwork/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hartwork", "id": 1577132, "login": "hartwork", "node_id": "MDQ6VXNlcjE1NzcxMzI=", "organizations_url": "https://api.github.com/users/hartwork/orgs", "received_events_url": "https://api.github.com/users/hartwork/received_events", "repos_url": "https://api.github.com/users/hartwork/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hartwork/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hartwork/subscriptions", "type": "User", "url": "https://api.github.com/users/hartwork", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-04-05T21:05:46Z
2021-09-08T23:05:49Z
2015-04-05T22:32:01Z
NONE
resolved
Hi! Looking at https://github.com/kennethreitz/requests/releases I need to click on "Show 3 newer tags" to see 2.6.0 uncovered. 2.5.1 is marked the latest release. Is that intended? It's 2.6.0 on PyPI https://pypi.python.org/pypi/requests/ . Best, Sebastian
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2528/reactions" }
https://api.github.com/repos/psf/requests/issues/2528/timeline
null
completed
null
null
false
[ "We don't really have a consistent policy of updating GitHub's releases. For our release notes we strongly recommend looking at PyPI or our documentation.\n", "So... no fix? 2.5.1 remains the latest on GitHub?\n", "@hartwork as @Lukasa has already kindly explained, PyPI is the source of truth. Not GitHub. You m...
https://api.github.com/repos/psf/requests/issues/2527
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2527/labels{/name}
https://api.github.com/repos/psf/requests/issues/2527/comments
https://api.github.com/repos/psf/requests/issues/2527/events
https://github.com/psf/requests/issues/2527
66,447,848
MDU6SXNzdWU2NjQ0Nzg0OA==
2,527
AttributeError- LWPCookieJar instance has no attribute 'copy'
{ "avatar_url": "https://avatars.githubusercontent.com/u/4114154?v=4", "events_url": "https://api.github.com/users/zhaoguixu/events{/privacy}", "followers_url": "https://api.github.com/users/zhaoguixu/followers", "following_url": "https://api.github.com/users/zhaoguixu/following{/other_user}", "gists_url": "https://api.github.com/users/zhaoguixu/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zhaoguixu", "id": 4114154, "login": "zhaoguixu", "node_id": "MDQ6VXNlcjQxMTQxNTQ=", "organizations_url": "https://api.github.com/users/zhaoguixu/orgs", "received_events_url": "https://api.github.com/users/zhaoguixu/received_events", "repos_url": "https://api.github.com/users/zhaoguixu/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zhaoguixu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zhaoguixu/subscriptions", "type": "User", "url": "https://api.github.com/users/zhaoguixu", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-04-05T15:05:40Z
2021-09-08T23:05:48Z
2015-04-06T11:15:55Z
NONE
resolved
Hi, In version 2.x: <b>[test-case]</b> ``` python import requests from cookielib import LWPCookieJar cookiejar = LWPCookieJar() req = requests.Request('GET', 'http://httpbin.org/get', cookies=cookiejar) r = req.prepare() r.copy() ``` <b>[traceback]</b> ... AttributeError: LWPCookieJar instance has no attribute 'copy' <b>[comments]</b> It seems that not all instances of cookiejar have the copy method, but in the copy method of PreparedRequest, it call the copy method of cookies without any checks.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2527/reactions" }
https://api.github.com/repos/psf/requests/issues/2527/timeline
null
completed
null
null
false
[ "What is your proposed solution?\n", "Hi @sigmavirus24,\nThanks for quick response. This situation is a little tricky that the base CookieJar class does not supply the 'copy' method but the RequestsCookieJar does. However, in the method 'prepare_cookies' of PreparedRequests, you permit all the instances of the s...
https://api.github.com/repos/psf/requests/issues/2526
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2526/labels{/name}
https://api.github.com/repos/psf/requests/issues/2526/comments
https://api.github.com/repos/psf/requests/issues/2526/events
https://github.com/psf/requests/issues/2526
66,282,887
MDU6SXNzdWU2NjI4Mjg4Nw==
2,526
Add support for digest authentication with an HTTP proxy
{ "avatar_url": "https://avatars.githubusercontent.com/u/705937?v=4", "events_url": "https://api.github.com/users/spectrumjade/events{/privacy}", "followers_url": "https://api.github.com/users/spectrumjade/followers", "following_url": "https://api.github.com/users/spectrumjade/following{/other_user}", "gists_url": "https://api.github.com/users/spectrumjade/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/spectrumjade", "id": 705937, "login": "spectrumjade", "node_id": "MDQ6VXNlcjcwNTkzNw==", "organizations_url": "https://api.github.com/users/spectrumjade/orgs", "received_events_url": "https://api.github.com/users/spectrumjade/received_events", "repos_url": "https://api.github.com/users/spectrumjade/repos", "site_admin": false, "starred_url": "https://api.github.com/users/spectrumjade/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/spectrumjade/subscriptions", "type": "User", "url": "https://api.github.com/users/spectrumjade", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-04-04T06:25:15Z
2021-09-08T23:05:50Z
2015-04-04T06:50:25Z
NONE
resolved
Currently, requests only supports HTTP basic authentication to a proxy. It would be very useful to support digest authentication with a proxy as well. Additionally, there should be some way to signal that requests should not attempt to pass proxy credentials in plaintext before receiving the digest nonce from the proxy.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2526/reactions" }
https://api.github.com/repos/psf/requests/issues/2526/timeline
null
completed
null
null
false
[ "@justintime32 Thanks for the feature request!\n\nIt should be entirely possible to write a short authentication handler that does exactly what you need: a quick Google showed [this](http://stackoverflow.com/questions/13506455/how-to-pass-proxy-authentication-requires-digest-auth-by-using-python-requests) as the to...
https://api.github.com/repos/psf/requests/issues/2525
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2525/labels{/name}
https://api.github.com/repos/psf/requests/issues/2525/comments
https://api.github.com/repos/psf/requests/issues/2525/events
https://github.com/psf/requests/pull/2525
66,162,705
MDExOlB1bGxSZXF1ZXN0MzI1OTQxOTE=
2,525
Issue 2062: Added custom header precedence info
{ "avatar_url": "https://avatars.githubusercontent.com/u/4780134?v=4", "events_url": "https://api.github.com/users/benjaminran/events{/privacy}", "followers_url": "https://api.github.com/users/benjaminran/followers", "following_url": "https://api.github.com/users/benjaminran/following{/other_user}", "gists_url": "https://api.github.com/users/benjaminran/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/benjaminran", "id": 4780134, "login": "benjaminran", "node_id": "MDQ6VXNlcjQ3ODAxMzQ=", "organizations_url": "https://api.github.com/users/benjaminran/orgs", "received_events_url": "https://api.github.com/users/benjaminran/received_events", "repos_url": "https://api.github.com/users/benjaminran/repos", "site_admin": false, "starred_url": "https://api.github.com/users/benjaminran/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/benjaminran/subscriptions", "type": "User", "url": "https://api.github.com/users/benjaminran", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-04-03T15:06:08Z
2021-09-08T08:00:55Z
2015-04-03T15:57:54Z
CONTRIBUTOR
resolved
Let me know if anything should be adjusted.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2525/reactions" }
https://api.github.com/repos/psf/requests/issues/2525/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2525.diff", "html_url": "https://github.com/psf/requests/pull/2525", "merged_at": "2015-04-03T15:57:54Z", "patch_url": "https://github.com/psf/requests/pull/2525.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2525" }
true
[ "\\o/ This is beautiful @benjaminran! Thanks so much! :cake: :sparkles:\n", "This is a fantastic pull request. Thanks so much!\n" ]
https://api.github.com/repos/psf/requests/issues/2524
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2524/labels{/name}
https://api.github.com/repos/psf/requests/issues/2524/comments
https://api.github.com/repos/psf/requests/issues/2524/events
https://github.com/psf/requests/issues/2524
65,993,903
MDU6SXNzdWU2NTk5MzkwMw==
2,524
TypeError: __str__ returned non-string (type Error)
{ "avatar_url": "https://avatars.githubusercontent.com/u/204508?v=4", "events_url": "https://api.github.com/users/mktums/events{/privacy}", "followers_url": "https://api.github.com/users/mktums/followers", "following_url": "https://api.github.com/users/mktums/following{/other_user}", "gists_url": "https://api.github.com/users/mktums/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mktums", "id": 204508, "login": "mktums", "node_id": "MDQ6VXNlcjIwNDUwOA==", "organizations_url": "https://api.github.com/users/mktums/orgs", "received_events_url": "https://api.github.com/users/mktums/received_events", "repos_url": "https://api.github.com/users/mktums/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mktums/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mktums/subscriptions", "type": "User", "url": "https://api.github.com/users/mktums", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-04-02T19:21:20Z
2021-09-08T07:00:23Z
2015-04-02T19:28:43Z
NONE
resolved
OS X 10.9 Python 2.7.9 ``` $ pip freeze cffi==0.9.2 cryptography==0.8.1 enum34==1.0.4 gitdb==0.6.4 GitPython==0.3.6 ndg-httpsclient==0.3.3 pyasn1==0.1.7 pycparser==2.10 pyOpenSSL==0.14 requests==2.6.0 requests-toolbelt==0.3.1 six==1.9.0 smmap==0.9.0 ``` On request to website with TLS 1.0 `https://codeforge.lbl.gov/frs/download.php/409/fastbit-ibis1.3.8.tar.gz` I'm getting: ``` python Traceback (most recent call last): File "./main.py", line 118, in <module> resp = downloader.run() File "/Users/mktums/Projects/brew404/downloaders.py", line 64, in run resp = self.fetch() File "/Users/mktums/Projects/brew404/downloaders.py", line 59, in fetch resp = s.send(req, verify=verify_ssl, allow_redirects=True, timeout=20) File "/Users/mktums/.virtualenvs/brew/lib/python2.7/site-packages/requests/sessions.py", line 576, in send r = adapter.send(request, **kwargs) File "/Users/mktums/.virtualenvs/brew/lib/python2.7/site-packages/requests/adapters.py", line 370, in send timeout=timeout File "/Users/mktums/.virtualenvs/brew/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen body=body, headers=headers) File "/Users/mktums/.virtualenvs/brew/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 344, in _make_request self._raise_timeout(err=e, url=url, timeout_value=conn.timeout) File "/Users/mktums/.virtualenvs/brew/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 314, in _raise_timeout if 'timed out' in str(err) or 'did not complete (read)' in str(err): # Python 2.6 TypeError: __str__ returned non-string (type Error) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2524/reactions" }
https://api.github.com/repos/psf/requests/issues/2524/timeline
null
completed
null
null
false
[ "Thanks for reporting this! This is currently tracked under shazow/urllib3#556, so I'm going to close this issue to centralise discussion there.\n", "@Lukasa Thanks for fast reply!\n", "how to fix this bug? any ideas?\n", "@gdonzy Please read the above issue, which links to a related tracking issue.\n", "Th...
https://api.github.com/repos/psf/requests/issues/2523
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2523/labels{/name}
https://api.github.com/repos/psf/requests/issues/2523/comments
https://api.github.com/repos/psf/requests/issues/2523/events
https://github.com/psf/requests/pull/2523
65,926,630
MDExOlB1bGxSZXF1ZXN0MzI1MTE3MTI=
2,523
HTTPDigestAuth - Making it thread-safe
{ "avatar_url": "https://avatars.githubusercontent.com/u/7661068?v=4", "events_url": "https://api.github.com/users/exvito/events{/privacy}", "followers_url": "https://api.github.com/users/exvito/followers", "following_url": "https://api.github.com/users/exvito/following{/other_user}", "gists_url": "https://api.github.com/users/exvito/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/exvito", "id": 7661068, "login": "exvito", "node_id": "MDQ6VXNlcjc2NjEwNjg=", "organizations_url": "https://api.github.com/users/exvito/orgs", "received_events_url": "https://api.github.com/users/exvito/received_events", "repos_url": "https://api.github.com/users/exvito/repos", "site_admin": false, "starred_url": "https://api.github.com/users/exvito/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/exvito/subscriptions", "type": "User", "url": "https://api.github.com/users/exvito", "user_view_type": "public" }
[]
closed
true
null
[]
null
12
2015-04-02T13:36:09Z
2021-09-08T06:00:57Z
2015-10-05T14:09:45Z
CONTRIBUTOR
resolved
The existing code counts the number of 401 responses in the num_401_calls authenticator attribute. This is in place so as to ensure the necessary auth header is sent, while avoiding infinite 401 loops (issue #547). This commit makes num_401_calls an instance of threading.local() (previously an integer), using num_401_calls.value as the counter. It ensures that concurrent authentication requests get each their own counter and behave as expected (otherwise every other concurrent request would have its authentication fail).
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2523/reactions" }
https://api.github.com/repos/psf/requests/issues/2523/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2523.diff", "html_url": "https://github.com/psf/requests/pull/2523", "merged_at": "2015-10-05T14:09:45Z", "patch_url": "https://github.com/psf/requests/pull/2523.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2523" }
true
[ "@Lukasa , @kennethreitz - Per your suggestion, I just updated the PR with commit e65360d.\nThanks for your input.\n", "I think the code is racy in nearly all the areas, not just the 401 counter.\n- build_digest_header is updating a number of internal variables including nonce lastnonce, etc.\n- if there are seve...
https://api.github.com/repos/psf/requests/issues/2522
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2522/labels{/name}
https://api.github.com/repos/psf/requests/issues/2522/comments
https://api.github.com/repos/psf/requests/issues/2522/events
https://github.com/psf/requests/issues/2522
65,835,263
MDU6SXNzdWU2NTgzNTI2Mw==
2,522
Save and load session
{ "avatar_url": "https://avatars.githubusercontent.com/u/1593287?v=4", "events_url": "https://api.github.com/users/JimHokanson/events{/privacy}", "followers_url": "https://api.github.com/users/JimHokanson/followers", "following_url": "https://api.github.com/users/JimHokanson/following{/other_user}", "gists_url": "https://api.github.com/users/JimHokanson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/JimHokanson", "id": 1593287, "login": "JimHokanson", "node_id": "MDQ6VXNlcjE1OTMyODc=", "organizations_url": "https://api.github.com/users/JimHokanson/orgs", "received_events_url": "https://api.github.com/users/JimHokanson/received_events", "repos_url": "https://api.github.com/users/JimHokanson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/JimHokanson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JimHokanson/subscriptions", "type": "User", "url": "https://api.github.com/users/JimHokanson", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-04-02T04:35:04Z
2020-10-08T18:13:20Z
2015-04-02T06:07:52Z
NONE
resolved
I'd like to be able to save and load a session to disk. I think this means just saving and loading the cookies, but perhaps there are other nuances that would need to be included. I'm interested in using Robobrowser (https://github.com/jmcarp/robobrowser) which wraps requests. I'd like to be able to persist the browser between running my application, which means being able to save and load the session to disk. There is a SO post regarding how to do this. I think tellingly, the most popular answer is wrong. http://stackoverflow.com/questions/13030095/how-to-save-requests-python-cookies-to-a-file Thanks, Jim
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2522/reactions" }
https://api.github.com/repos/psf/requests/issues/2522/timeline
null
completed
null
null
false
[ "The easiest thing to do is just to pickle the whole `session` object:\n\n``` python\nimport requests, requests.utils, pickle\nsession = requests.session()\n# Make some calls\nwith open('somefile', 'w') as f:\n pickle.dump(session, f)\n```\n\n``` python\nwith open('somefile') as f:\n session = pickle.load(f)\...
https://api.github.com/repos/psf/requests/issues/2521
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2521/labels{/name}
https://api.github.com/repos/psf/requests/issues/2521/comments
https://api.github.com/repos/psf/requests/issues/2521/events
https://github.com/psf/requests/issues/2521
65,644,529
MDU6SXNzdWU2NTY0NDUyOQ==
2,521
ConnectionError and socket.gaierror occurred on IPv6-enabled system
{ "avatar_url": "https://avatars.githubusercontent.com/u/5781687?v=4", "events_url": "https://api.github.com/users/shichao-an/events{/privacy}", "followers_url": "https://api.github.com/users/shichao-an/followers", "following_url": "https://api.github.com/users/shichao-an/following{/other_user}", "gists_url": "https://api.github.com/users/shichao-an/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/shichao-an", "id": 5781687, "login": "shichao-an", "node_id": "MDQ6VXNlcjU3ODE2ODc=", "organizations_url": "https://api.github.com/users/shichao-an/orgs", "received_events_url": "https://api.github.com/users/shichao-an/received_events", "repos_url": "https://api.github.com/users/shichao-an/repos", "site_admin": false, "starred_url": "https://api.github.com/users/shichao-an/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shichao-an/subscriptions", "type": "User", "url": "https://api.github.com/users/shichao-an", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-04-01T09:32:58Z
2021-09-08T23:05:50Z
2015-04-01T19:34:44Z
NONE
resolved
I tried to make a request with a tool that uses python-requests on a Ubuntu 14.04 server with IPv6 enabled (with inet6 interface configured at `/etc/network/interfaces`) and encountered the following errors: ``` bash $ 115down Traceback (most recent call last): File "/usr/local/bin/115down", line 130, in <module> main() File "/usr/local/bin/115down", line 126, in main args.sub_num, args.count, args.sub_count, args.tasks) File "/usr/local/bin/115down", line 64, in get_entries api.login(username, password, section) File "/usr/local/lib/python2.7/dist-packages/u115/api.py", line 248, in login if self.has_logged_in: File "/usr/local/lib/python2.7/dist-packages/u115/api.py", line 297, in has_logged_in r = self.http.get(CHECKPOINT_URL) File "/usr/local/lib/python2.7/dist-packages/u115/api.py", line 56, in get r = self.session.get(url, params=params) File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get return self.request('GET', url, **kwargs) File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request resp = self.send(prep, **send_kwargs) File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send r = adapter.send(request, **kwargs) File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send raise ConnectionError(e) requests.exceptions.ConnectionError: HTTPConnectionPool(host='passport.115.com', port=80): Max retries exceeded with url: /?ct=ajax&ac=ajax_check_point (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known) Exception requests.exceptions.ConnectionError: ConnectionError(MaxRetryError("HTTPConnectionPool(host='passport.115.com', port=80): Max retries exceeded with url: /?ct=ajax&ac=ajax_check_point (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)",),) in <bound method API.__del__ of <u115.api.API object at 0x7fe060092210>> ignored ``` When disabled IPv6 by commenting relevant lines in `/etc/network/interfaces` and reboot, everything works. Anyone have any ideas?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2521/reactions" }
https://api.github.com/repos/psf/requests/issues/2521/timeline
null
completed
null
null
false
[ "`socket.gaierror` seems to suggest that you're failing a DNS lookup. Try this:\n\n``` python\nimport socket\nsocket.getaddrinfo('passport.115.com', 80)\n```\n\nin both IPv6 and IPv4 mode, and see if the problem reproduces.\n", "To reproduce,\n\n```\n>>> import socket\n>>> socket.getaddrinfo('passport.115.com', 8...
https://api.github.com/repos/psf/requests/issues/2520
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2520/labels{/name}
https://api.github.com/repos/psf/requests/issues/2520/comments
https://api.github.com/repos/psf/requests/issues/2520/events
https://github.com/psf/requests/issues/2520
65,415,631
MDU6SXNzdWU2NTQxNTYzMQ==
2,520
chardet.detect() call in models.py fails when using IronPython.
{ "avatar_url": "https://avatars.githubusercontent.com/u/11410671?v=4", "events_url": "https://api.github.com/users/dxtodorovic/events{/privacy}", "followers_url": "https://api.github.com/users/dxtodorovic/followers", "following_url": "https://api.github.com/users/dxtodorovic/following{/other_user}", "gists_url": "https://api.github.com/users/dxtodorovic/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dxtodorovic", "id": 11410671, "login": "dxtodorovic", "node_id": "MDQ6VXNlcjExNDEwNjcx", "organizations_url": "https://api.github.com/users/dxtodorovic/orgs", "received_events_url": "https://api.github.com/users/dxtodorovic/received_events", "repos_url": "https://api.github.com/users/dxtodorovic/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dxtodorovic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dxtodorovic/subscriptions", "type": "User", "url": "https://api.github.com/users/dxtodorovic", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-03-31T10:10:13Z
2021-09-08T23:05:50Z
2015-03-31T10:50:41Z
NONE
resolved
In models.py, chardet.detect(self.content)['encoding'] fails to work with IronPython with an exception: 'Expected a bytes object, not a unicode object'. It is due to a check in chardet's __init__ ( isinstance(aBuf, unicode) ) and IronPython's way of handling strings as unicode type. Excerpt from chardet's **init**: ``` def detect(aBuf): if ((version_info < (3, 0) and isinstance(aBuf, unicode)) or (version_info >= (3, 0) and not isinstance(aBuf, bytes))): raise ValueError('Expected a bytes object, not a unicode object') ``` I tried passing bytes(self.content) to chardet instead but that solution fails short because in compat.py, we are redefining bytes to str, which under IronPython is unicode. Can we perhaps add some way of handling IronPython properly or is it something that should be fixed in chardet instead?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2520/reactions" }
https://api.github.com/repos/psf/requests/issues/2520/timeline
null
completed
null
null
false
[ "I think this needs to be fixed in chardet itself, sadly. Happily, it's now under active development, over at [chardet/chardet](https://github.com/chardet/chardet), so opening the issue over there should get it promptly looked at.\n", "Actually this looks like a problem with IronPython that voids requests expecta...
https://api.github.com/repos/psf/requests/issues/2519
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2519/labels{/name}
https://api.github.com/repos/psf/requests/issues/2519/comments
https://api.github.com/repos/psf/requests/issues/2519/events
https://github.com/psf/requests/issues/2519
65,243,921
MDU6SXNzdWU2NTI0MzkyMQ==
2,519
Client Certificates w/Passphrases?
{ "avatar_url": "https://avatars.githubusercontent.com/u/6197517?v=4", "events_url": "https://api.github.com/users/tdussa/events{/privacy}", "followers_url": "https://api.github.com/users/tdussa/followers", "following_url": "https://api.github.com/users/tdussa/following{/other_user}", "gists_url": "https://api.github.com/users/tdussa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tdussa", "id": 6197517, "login": "tdussa", "node_id": "MDQ6VXNlcjYxOTc1MTc=", "organizations_url": "https://api.github.com/users/tdussa/orgs", "received_events_url": "https://api.github.com/users/tdussa/received_events", "repos_url": "https://api.github.com/users/tdussa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tdussa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tdussa/subscriptions", "type": "User", "url": "https://api.github.com/users/tdussa", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "e102d8", "default": false, "description": null...
closed
false
null
[]
{ "closed_at": null, "closed_issues": 29, "created_at": "2024-05-19T18:29:04Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4", "events_url": "https://api.github.com/users/sethmlarson/events{/privacy}", "followers_url": "https://api.github.com/users/sethmlarson/followers", "following_url": "https://api.github.com/users/sethmlarson/following{/other_user}", "gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sethmlarson", "id": 18519037, "login": "sethmlarson", "node_id": "MDQ6VXNlcjE4NTE5MDM3", "organizations_url": "https://api.github.com/users/sethmlarson/orgs", "received_events_url": "https://api.github.com/users/sethmlarson/received_events", "repos_url": "https://api.github.com/users/sethmlarson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions", "type": "User", "url": "https://api.github.com/users/sethmlarson", "user_view_type": "public" }, "description": "", "due_on": null, "html_url": "https://github.com/psf/requests/milestone/34", "id": 11073254, "labels_url": "https://api.github.com/repos/psf/requests/milestones/34/labels", "node_id": "MI_kwDOABTKOs4AqPbm", "number": 34, "open_issues": 0, "state": "open", "title": "Bankruptcy", "updated_at": "2024-05-20T14:37:16Z", "url": "https://api.github.com/repos/psf/requests/milestones/34" }
33
2015-03-30T15:55:43Z
2024-05-20T14:36:24Z
2024-05-20T14:36:23Z
NONE
null
Hi, client certificates can be specified with the "cert" parameter. If I pass an encrypted client certificate, the underlying OpenSSL call will query for the corresponding passphrase, but that is not really a feasible way of handling this for a larger session with multiple calls, because the password is obviously not cached in any way. Is there any way to pass the passphrase to a connection with API calls so it is then passed on to OpenSSL? Cheers, Toby.
{ "avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4", "events_url": "https://api.github.com/users/sethmlarson/events{/privacy}", "followers_url": "https://api.github.com/users/sethmlarson/followers", "following_url": "https://api.github.com/users/sethmlarson/following{/other_user}", "gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sethmlarson", "id": 18519037, "login": "sethmlarson", "node_id": "MDQ6VXNlcjE4NTE5MDM3", "organizations_url": "https://api.github.com/users/sethmlarson/orgs", "received_events_url": "https://api.github.com/users/sethmlarson/received_events", "repos_url": "https://api.github.com/users/sethmlarson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions", "type": "User", "url": "https://api.github.com/users/sethmlarson", "user_view_type": "public" }
{ "+1": 3, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 3, "url": "https://api.github.com/repos/psf/requests/issues/2519/reactions" }
https://api.github.com/repos/psf/requests/issues/2519/timeline
null
completed
null
null
false
[ "Hi @tdussa,\n\nIn the future, please ask _questions_ on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests). Quoting from [the docs](http://docs.python-requests.org/en/latest/api/?highlight=cert).\n\n> cert – (optional) if String, path to ssl client cert file (.pem). If Tuple, (‘cert’, ‘key...
https://api.github.com/repos/psf/requests/issues/2518
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2518/labels{/name}
https://api.github.com/repos/psf/requests/issues/2518/comments
https://api.github.com/repos/psf/requests/issues/2518/events
https://github.com/psf/requests/pull/2518
64,325,068
MDExOlB1bGxSZXF1ZXN0MzE5NDUwMjA=
2,518
shorter and faster version extraction from __init__.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/439279?v=4", "events_url": "https://api.github.com/users/deronnax/events{/privacy}", "followers_url": "https://api.github.com/users/deronnax/followers", "following_url": "https://api.github.com/users/deronnax/following{/other_user}", "gists_url": "https://api.github.com/users/deronnax/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/deronnax", "id": 439279, "login": "deronnax", "node_id": "MDQ6VXNlcjQzOTI3OQ==", "organizations_url": "https://api.github.com/users/deronnax/orgs", "received_events_url": "https://api.github.com/users/deronnax/received_events", "repos_url": "https://api.github.com/users/deronnax/repos", "site_admin": false, "starred_url": "https://api.github.com/users/deronnax/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/deronnax/subscriptions", "type": "User", "url": "https://api.github.com/users/deronnax", "user_view_type": "public" }
[]
closed
true
null
[]
null
11
2015-03-25T17:20:49Z
2021-09-08T08:00:56Z
2015-03-27T12:49:29Z
CONTRIBUTOR
resolved
@sigmavirus24 I though it could be improved a bit. Tell me what you think.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2518/reactions" }
https://api.github.com/repos/psf/requests/issues/2518/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2518.diff", "html_url": "https://github.com/psf/requests/pull/2518", "merged_at": "2015-03-27T12:49:29Z", "patch_url": "https://github.com/psf/requests/pull/2518.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2518" }
true
[ "if you think readability has been tampered too much, I'll make a pull request with this less-pure-but-softer version:\n\n```\n- for line in fd:\n- m = reg.match(line)\n- if m:\n- version = m.group(1)\n- break\n+ version = reg.search(fd.read())\n```\n", "No objections fro...
https://api.github.com/repos/psf/requests/issues/2517
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2517/labels{/name}
https://api.github.com/repos/psf/requests/issues/2517/comments
https://api.github.com/repos/psf/requests/issues/2517/events
https://github.com/psf/requests/issues/2517
64,016,384
MDU6SXNzdWU2NDAxNjM4NA==
2,517
ZeroReturnError exception on GET request to facebook.com
{ "avatar_url": "https://avatars.githubusercontent.com/u/6208933?v=4", "events_url": "https://api.github.com/users/chrj/events{/privacy}", "followers_url": "https://api.github.com/users/chrj/followers", "following_url": "https://api.github.com/users/chrj/following{/other_user}", "gists_url": "https://api.github.com/users/chrj/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/chrj", "id": 6208933, "login": "chrj", "node_id": "MDQ6VXNlcjYyMDg5MzM=", "organizations_url": "https://api.github.com/users/chrj/orgs", "received_events_url": "https://api.github.com/users/chrj/received_events", "repos_url": "https://api.github.com/users/chrj/repos", "site_admin": false, "starred_url": "https://api.github.com/users/chrj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chrj/subscriptions", "type": "User", "url": "https://api.github.com/users/chrj", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-03-24T14:51:19Z
2021-09-08T23:05:51Z
2015-03-24T15:43:04Z
NONE
resolved
Running on Python 2.7.8 with: - `pyOpenSSL==0.14` - `ndg-httpsclient==0.3.3` - `pyasn1==0.1.7` - `requests==2.5.1` When I run this: ``` python requests.get("http://www.facebook.com/", headers={"Connection" : "close"}) ``` I get the following exception: ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "[venv]/local/lib/python2.7/site-packages/requests/api.py", line 65, in get return request('get', url, **kwargs) File "[venv]/local/lib/python2.7/site-packages/requests/api.py", line 49, in request response = session.request(method=method, url=url, **kwargs) File "[venv]/local/lib/python2.7/site-packages/requests/sessions.py", line 461, in request resp = self.send(prep, **send_kwargs) File "[venv]/local/lib/python2.7/site-packages/requests/sessions.py", line 599, in send history = [resp for resp in gen] if allow_redirects else [] File "[venv]/local/lib/python2.7/site-packages/requests/sessions.py", line 192, in resolve_redirects allow_redirects=False, File "[venv]/local/lib/python2.7/site-packages/requests/sessions.py", line 610, in send r.content File "[venv]/local/lib/python2.7/site-packages/requests/models.py", line 730, in content self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes() File "[venv]/local/lib/python2.7/site-packages/requests/models.py", line 655, in generate for chunk in self.raw.stream(chunk_size, decode_content=True): File "[venv]/local/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 256, in stream data = self.read(amt=amt, decode_content=decode_content) File "[venv]/local/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 186, in read data = self._fp.read(amt) File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt) File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) File "[venv]/local/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 188, in recv data = self.connection.recv(*args, **kwargs) File "[venv]/local/lib/python2.7/site-packages/OpenSSL/SSL.py", line 995, in recv self._raise_ssl_error(self._ssl, result) File "[venv]/local/lib/python2.7/site-packages/OpenSSL/SSL.py", line 851, in _raise_ssl_error raise ZeroReturnError() OpenSSL.SSL.ZeroReturnError ``` According to the pyOpenSSL docs on `ZeroReturnError` this is an indication that remote closed the connection cleanly: http://pyopenssl.readthedocs.org/en/latest/api/ssl.html#OpenSSL.SSL.ZeroReturnError I'm guessing this exception should probably be handled somewhere along the call path instead of propagating to the caller. Running under Python 3.4.2 the request goes through.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2517/reactions" }
https://api.github.com/repos/psf/requests/issues/2517/timeline
null
completed
null
null
false
[ "This is better filed over on [urllib3](/shazow/urllib3).\n", "Also, ping @shazow \n", "This should be fixed in 2.5.2 or later but you should upgrade to 2.6.0 either way.\n", "No need to report this to urllib3 either.\n", "Confirmed. \n\nI could swear I checked for an updated version before reporting :)\n\n...
https://api.github.com/repos/psf/requests/issues/2516
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2516/labels{/name}
https://api.github.com/repos/psf/requests/issues/2516/comments
https://api.github.com/repos/psf/requests/issues/2516/events
https://github.com/psf/requests/pull/2516
63,991,614
MDExOlB1bGxSZXF1ZXN0MzE4MjQ3MDk=
2,516
Import the builtin json first.
{ "avatar_url": "https://avatars.githubusercontent.com/u/129501?v=4", "events_url": "https://api.github.com/users/ionelmc/events{/privacy}", "followers_url": "https://api.github.com/users/ionelmc/followers", "following_url": "https://api.github.com/users/ionelmc/following{/other_user}", "gists_url": "https://api.github.com/users/ionelmc/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ionelmc", "id": 129501, "login": "ionelmc", "node_id": "MDQ6VXNlcjEyOTUwMQ==", "organizations_url": "https://api.github.com/users/ionelmc/orgs", "received_events_url": "https://api.github.com/users/ionelmc/received_events", "repos_url": "https://api.github.com/users/ionelmc/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ionelmc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ionelmc/subscriptions", "type": "User", "url": "https://api.github.com/users/ionelmc", "user_view_type": "public" }
[ { "color": "eb6420", "default": false, "description": null, "id": 44501256, "name": "Breaking API Change", "node_id": "MDU6TGFiZWw0NDUwMTI1Ng==", "url": "https://api.github.com/repos/psf/requests/labels/Breaking%20API%20Change" }, { "color": "e11d21", "default": false, "d...
closed
true
null
[]
null
15
2015-03-24T13:16:12Z
2021-09-08T07:00:46Z
2015-04-02T18:41:52Z
CONTRIBUTOR
resolved
`simplejson` segfaults for me ([details](https://github.com/simplejson/simplejson/issues/114)) and it looks like it's not maintained. It should only be used as a last resort.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2516/reactions" }
https://api.github.com/repos/psf/requests/issues/2516/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2516.diff", "html_url": "https://github.com/psf/requests/pull/2516", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2516.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2516" }
true
[ "This is a very deliberate import situation. requests does not support a version of Python that lacks the standard library version. simplejson is imported first specifically because there are people who would rather it be used than the standard library's json module. As such I'm strongly -1 on including this change...
https://api.github.com/repos/psf/requests/issues/2515
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2515/labels{/name}
https://api.github.com/repos/psf/requests/issues/2515/comments
https://api.github.com/repos/psf/requests/issues/2515/events
https://github.com/psf/requests/issues/2515
63,795,326
MDU6SXNzdWU2Mzc5NTMyNg==
2,515
Can't copy-paste international URL
{ "avatar_url": "https://avatars.githubusercontent.com/u/56778?v=4", "events_url": "https://api.github.com/users/cool-RR/events{/privacy}", "followers_url": "https://api.github.com/users/cool-RR/followers", "following_url": "https://api.github.com/users/cool-RR/following{/other_user}", "gists_url": "https://api.github.com/users/cool-RR/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cool-RR", "id": 56778, "login": "cool-RR", "node_id": "MDQ6VXNlcjU2Nzc4", "organizations_url": "https://api.github.com/users/cool-RR/orgs", "received_events_url": "https://api.github.com/users/cool-RR/received_events", "repos_url": "https://api.github.com/users/cool-RR/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cool-RR/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cool-RR/subscriptions", "type": "User", "url": "https://api.github.com/users/cool-RR", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-23T18:21:47Z
2021-09-08T23:05:51Z
2015-03-23T18:29:35Z
NONE
resolved
Observe this link to an article: http://alaxon.co.il/article/%D7%9C%D7%95-%D7%99%D7%9B%D7%9C%D7%95-%D7%97%D7%AA%D7%95%D7%9C%D7%99%D7%9D-%D7%9C%D7%93%D7%91%D7%A8/ If you click it, you'll see Hebrew letters in your address bar. (At least in Chrome.) The article works. Now, try accessing it in requests: ``` >>> import requests >>> requests.get('http://alaxon.co.il/article/%D7%9C%D7%95-%D7%99%D7%9B%D7%9C%D7%95-%D7%97%D7%AA%D7%95%D7%9C%D7%99%D7%9D-%D7%9C%D7%93%D7%91%D7%A8/') Starting new HTTP connection (1): alaxon.co.il <Response [403]> ``` Why is that?
{ "avatar_url": "https://avatars.githubusercontent.com/u/56778?v=4", "events_url": "https://api.github.com/users/cool-RR/events{/privacy}", "followers_url": "https://api.github.com/users/cool-RR/followers", "following_url": "https://api.github.com/users/cool-RR/following{/other_user}", "gists_url": "https://api.github.com/users/cool-RR/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cool-RR", "id": 56778, "login": "cool-RR", "node_id": "MDQ6VXNlcjU2Nzc4", "organizations_url": "https://api.github.com/users/cool-RR/orgs", "received_events_url": "https://api.github.com/users/cool-RR/received_events", "repos_url": "https://api.github.com/users/cool-RR/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cool-RR/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cool-RR/subscriptions", "type": "User", "url": "https://api.github.com/users/cool-RR", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2515/reactions" }
https://api.github.com/repos/psf/requests/issues/2515/timeline
null
completed
null
null
false
[ "Note that I get the same 403 error response when I put the Hebrew URL in `requests.get` without the percentage escape sequences. If I put this Hebrew URL in the browser, it works fine.\n", "My mistake, this was a completely unrelated problem with the site.\n", "Heh, I was just diving in. Thanks for solving it ...
https://api.github.com/repos/psf/requests/issues/2514
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2514/labels{/name}
https://api.github.com/repos/psf/requests/issues/2514/comments
https://api.github.com/repos/psf/requests/issues/2514/events
https://github.com/psf/requests/pull/2514
63,747,071
MDExOlB1bGxSZXF1ZXN0MzE3NDA5Mjk=
2,514
Revert "Minor Patch TypeError thrown"
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
2
2015-03-23T15:11:32Z
2021-09-08T08:00:57Z
2015-03-23T15:13:14Z
CONTRIBUTOR
resolved
Reverts kennethreitz/requests#2513 The change was made to urllib3 which is vendored and to which pull requests should not be accepted.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2514/reactions" }
https://api.github.com/repos/psf/requests/issues/2514/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2514.diff", "html_url": "https://github.com/psf/requests/pull/2514", "merged_at": "2015-03-23T15:13:14Z", "patch_url": "https://github.com/psf/requests/pull/2514.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2514" }
true
[ "Further, that breaks the API of urllib3 by raising an exception that is not a urllib3 exception and would introduce a breaking change to requests.\n", "Yeah, this is straight up my bad.\n" ]
https://api.github.com/repos/psf/requests/issues/2513
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2513/labels{/name}
https://api.github.com/repos/psf/requests/issues/2513/comments
https://api.github.com/repos/psf/requests/issues/2513/events
https://github.com/psf/requests/pull/2513
63,627,017
MDExOlB1bGxSZXF1ZXN0MzE3MDUzNDg=
2,513
Minor Patch TypeError thrown
{ "avatar_url": "https://avatars.githubusercontent.com/u/1904543?v=4", "events_url": "https://api.github.com/users/ropwareJB/events{/privacy}", "followers_url": "https://api.github.com/users/ropwareJB/followers", "following_url": "https://api.github.com/users/ropwareJB/following{/other_user}", "gists_url": "https://api.github.com/users/ropwareJB/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ropwareJB", "id": 1904543, "login": "ropwareJB", "node_id": "MDQ6VXNlcjE5MDQ1NDM=", "organizations_url": "https://api.github.com/users/ropwareJB/orgs", "received_events_url": "https://api.github.com/users/ropwareJB/received_events", "repos_url": "https://api.github.com/users/ropwareJB/repos", "site_admin": true, "starred_url": "https://api.github.com/users/ropwareJB/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ropwareJB/subscriptions", "type": "User", "url": "https://api.github.com/users/ropwareJB", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-03-23T05:03:25Z
2021-09-08T08:00:57Z
2015-03-23T06:18:48Z
CONTRIBUTOR
resolved
Python2.7, str(err) was throwing a TypeError as it doesn't override the 'toString' method **str**. Wrapped offending block in a quick try block, catching only TypeError exceptions.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2513/reactions" }
https://api.github.com/repos/psf/requests/issues/2513/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2513.diff", "html_url": "https://github.com/psf/requests/pull/2513", "merged_at": "2015-03-23T06:18:48Z", "patch_url": "https://github.com/psf/requests/pull/2513.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2513" }
true
[ "Thanks! :cake:\n", "@Montycarlo please see #2514. This should have been opened at [urllib3](/shazow/urllib3) and the change needs to be much better since this will introduce a breaking change to urllib3.\n", "Sorry @Montycarlo! I should have caught that earlier. =(\n", "Sorry for wasting your time! Keep up t...
https://api.github.com/repos/psf/requests/issues/2512
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2512/labels{/name}
https://api.github.com/repos/psf/requests/issues/2512/comments
https://api.github.com/repos/psf/requests/issues/2512/events
https://github.com/psf/requests/pull/2512
63,424,725
MDExOlB1bGxSZXF1ZXN0MzE2NzM3NTk=
2,512
Expand on what 'elapsed' means.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-03-21T16:27:44Z
2021-09-08T08:00:58Z
2015-03-22T19:51:17Z
MEMBER
resolved
Resolves #2511.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2512/reactions" }
https://api.github.com/repos/psf/requests/issues/2512/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2512.diff", "html_url": "https://github.com/psf/requests/pull/2512", "merged_at": "2015-03-22T19:51:17Z", "patch_url": "https://github.com/psf/requests/pull/2512.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2512" }
true
[]
https://api.github.com/repos/psf/requests/issues/2511
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2511/labels{/name}
https://api.github.com/repos/psf/requests/issues/2511/comments
https://api.github.com/repos/psf/requests/issues/2511/events
https://github.com/psf/requests/issues/2511
63,412,190
MDU6SXNzdWU2MzQxMjE5MA==
2,511
Documentation unclear on Response.elapsed
{ "avatar_url": "https://avatars.githubusercontent.com/u/350846?v=4", "events_url": "https://api.github.com/users/jribbens/events{/privacy}", "followers_url": "https://api.github.com/users/jribbens/followers", "following_url": "https://api.github.com/users/jribbens/following{/other_user}", "gists_url": "https://api.github.com/users/jribbens/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jribbens", "id": 350846, "login": "jribbens", "node_id": "MDQ6VXNlcjM1MDg0Ng==", "organizations_url": "https://api.github.com/users/jribbens/orgs", "received_events_url": "https://api.github.com/users/jribbens/received_events", "repos_url": "https://api.github.com/users/jribbens/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jribbens/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jribbens/subscriptions", "type": "User", "url": "https://api.github.com/users/jribbens", "user_view_type": "public" }
[]
closed
true
null
[]
null
15
2015-03-21T14:36:36Z
2021-09-08T23:05:51Z
2015-03-22T19:51:17Z
NONE
resolved
The documentation says that `Response.elapsed` is "the amount of time elapsed between sending the request and the arrival of the response". However it is very unclear what this actually means - the time to the first byte of the headers, the time to the first byte of the body, the time to the end of the body, etc? What value does it, and the other corresponding values in the `Response.history` list's objects, have if the response involved one or more redirects? Does it change if you access `Response.content`? Does it make a difference if `stream` is set on the request? A great deal more clarification on what this value actually tells you would be very helpful.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2511/reactions" }
https://api.github.com/repos/psf/requests/issues/2511/timeline
null
completed
null
null
false
[ "Good point!\n\nThe most accurate answer is that it's the time taken between passing the request to `httplib` and getting the response from it. This means it's time to the end of the _headers_ and the headers are finished parsing. Therefore, each element in `Response.history` measures its own `elapsed` value. It do...
https://api.github.com/repos/psf/requests/issues/2510
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2510/labels{/name}
https://api.github.com/repos/psf/requests/issues/2510/comments
https://api.github.com/repos/psf/requests/issues/2510/events
https://github.com/psf/requests/issues/2510
63,408,132
MDU6SXNzdWU2MzQwODEzMg==
2,510
TypeError: getresponse() got an unexpected keyword argument 'buffering'
{ "avatar_url": "https://avatars.githubusercontent.com/u/350846?v=4", "events_url": "https://api.github.com/users/jribbens/events{/privacy}", "followers_url": "https://api.github.com/users/jribbens/followers", "following_url": "https://api.github.com/users/jribbens/following{/other_user}", "gists_url": "https://api.github.com/users/jribbens/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jribbens", "id": 350846, "login": "jribbens", "node_id": "MDQ6VXNlcjM1MDg0Ng==", "organizations_url": "https://api.github.com/users/jribbens/orgs", "received_events_url": "https://api.github.com/users/jribbens/received_events", "repos_url": "https://api.github.com/users/jribbens/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jribbens/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jribbens/subscriptions", "type": "User", "url": "https://api.github.com/users/jribbens", "user_view_type": "public" }
[]
closed
true
null
[]
null
10
2015-03-21T14:07:08Z
2021-09-08T21:00:47Z
2015-03-21T16:21:22Z
NONE
resolved
Firstly, please note I have already read issues #1289 and #1915. Secondly, please note that I am fully aware that the problem is that the underlying URL fetch failed due to a problem that is outside Requests' control, i.e. a network problem or failure of the remote web server. My problem is not that an exception is raised - my problem is that the _wrong_ exception is raised. According to the Requests documentation, in this circumstance a `ReadTimeout` exception should be raised, and in any event the exception should be a subclass of `RequestException`. Instead, a `TypeError` is being raised. This is fatal for my application, which needs to know _why_ the request failed and to be sure that it was indeed a network failure and not a bug in the application or Requests itself. As far as I can see, this is indeed a bug in Requests. I am using Requests 2.5.3 on Python 3.4.0 on Ubuntu 14.04.2. ``` Traceback (most recent call last): File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 372, in _make_request httplib_response = conn.getresponse(buffering=True) TypeError: getresponse() got an unexpected keyword argument 'buffering' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 374, in _make_request httplib_response = conn.getresponse() File "/usr/lib/python3.4/http/client.py", line 1147, in getresponse response.begin() File "/usr/lib/python3.4/http/client.py", line 351, in begin version, status, reason = self._read_status() File "/usr/lib/python3.4/http/client.py", line 313, in _read_status line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1") File "/usr/lib/python3.4/socket.py", line 371, in readinto return self._sock.recv_into(b) socket.timeout: timed out During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/adapters.py", line 370, in send timeout=timeout File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 597, in urlopen _stacktrace=sys.exc_info()[2]) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 245, in increment raise six.reraise(type(error), error, _stacktrace) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/packages/six.py", line 310, in reraise raise value File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen body=body, headers=headers) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 376, in _make_request self._raise_timeout(err=e, url=url, timeout_value=read_timeout) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 304, in _raise_timeout raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value) requests.packages.urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='www.libraryofbirmingham.com', port=80): Read timed out. (read timeout=30) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "./bitatawa-client.py", line 231, in check timeout=settings.getint("check-timeout", 30)) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/api.py", line 65, in get return request('get', url, **kwargs) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/api.py", line 49, in request response = session.request(method=method, url=url, **kwargs) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/sessions.py", line 461, in request resp = self.send(prep, **send_kwargs) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File "/home/jribbens/src/bitatawa/lib/python3.4/site-packages/requests/adapters.py", line 433, in send raise ReadTimeout(e, request=request) requests.exceptions.ReadTimeout: HTTPConnectionPool(host='www.libraryofbirmingham.com', port=80): Read timed out. (read timeout=30) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2510/reactions" }
https://api.github.com/repos/psf/requests/issues/2510/timeline
null
completed
null
null
false
[ "Sorry @jribbens, but you didn't read #1289 or #1915 clearly enough. I will reproduce my statements from those issues again, in the hopes that this will be the last time I have to write this down. =)\n\nThis is an unforeseen problem to do with how exception tracebacks are being reported in Python 3. PEP 3134 introd...
https://api.github.com/repos/psf/requests/issues/2509
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2509/labels{/name}
https://api.github.com/repos/psf/requests/issues/2509/comments
https://api.github.com/repos/psf/requests/issues/2509/events
https://github.com/psf/requests/issues/2509
63,366,723
MDU6SXNzdWU2MzM2NjcyMw==
2,509
Not sure if this is an issue, but how do I select a port
{ "avatar_url": "https://avatars.githubusercontent.com/u/9436380?v=4", "events_url": "https://api.github.com/users/SethDusek/events{/privacy}", "followers_url": "https://api.github.com/users/SethDusek/followers", "following_url": "https://api.github.com/users/SethDusek/following{/other_user}", "gists_url": "https://api.github.com/users/SethDusek/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/SethDusek", "id": 9436380, "login": "SethDusek", "node_id": "MDQ6VXNlcjk0MzYzODA=", "organizations_url": "https://api.github.com/users/SethDusek/orgs", "received_events_url": "https://api.github.com/users/SethDusek/received_events", "repos_url": "https://api.github.com/users/SethDusek/repos", "site_admin": false, "starred_url": "https://api.github.com/users/SethDusek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SethDusek/subscriptions", "type": "User", "url": "https://api.github.com/users/SethDusek", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-21T06:01:46Z
2021-09-08T23:05:52Z
2015-03-21T06:42:12Z
NONE
resolved
I want to connect on port 1079, but I cant find any documentation on choosing a port
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2509/reactions" }
https://api.github.com/repos/psf/requests/issues/2509/timeline
null
completed
null
null
false
[ "`r = requests.get('http://http2bin.org:8080')`\n" ]
https://api.github.com/repos/psf/requests/issues/2508
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2508/labels{/name}
https://api.github.com/repos/psf/requests/issues/2508/comments
https://api.github.com/repos/psf/requests/issues/2508/events
https://github.com/psf/requests/issues/2508
63,320,912
MDU6SXNzdWU2MzMyMDkxMg==
2,508
Session timeout doesn't accept tuple?
{ "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ghost", "id": 10137, "login": "ghost", "node_id": "MDQ6VXNlcjEwMTM3", "organizations_url": "https://api.github.com/users/ghost/orgs", "received_events_url": "https://api.github.com/users/ghost/received_events", "repos_url": "https://api.github.com/users/ghost/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "type": "User", "url": "https://api.github.com/users/ghost", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2015-03-20T22:31:35Z
2021-09-08T13:05:32Z
2015-03-21T02:01:20Z
NONE
resolved
Hi. Following the [documentation](http://docs.python-requests.org/en/latest/user/advanced/#timeouts), I've set a tuple with connect and read timeouts: ``` data = self.session.post('https://...', data=params, headers=headers, timeout=(4.5, 10), verify=False).json() ``` But what I've got is this: ``` Timeout value connect was (4.5, 10), but it must be an int or float. ``` As stated in the [developer API](http://docs.python-requests.org/en/latest/api/#request-sessions) under request method, timeout should accept float or tuple, right? Thanks
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2508/reactions" }
https://api.github.com/repos/psf/requests/issues/2508/timeline
null
completed
null
null
false
[ "Taking a look now\n\nOn Friday, March 20, 2015, Mateus Dalto Piveta notifications@github.com\nwrote:\n\n> Hi.\n> Following the documentation\n> http://docs.python-requests.org/en/latest/user/advanced/#timeouts, I've\n> set a tuple with connect and read timeouts:\n> \n> data = self.session.post('https://...,\n> ...
https://api.github.com/repos/psf/requests/issues/2507
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2507/labels{/name}
https://api.github.com/repos/psf/requests/issues/2507/comments
https://api.github.com/repos/psf/requests/issues/2507/events
https://github.com/psf/requests/issues/2507
63,276,678
MDU6SXNzdWU2MzI3NjY3OA==
2,507
Request works from command line, but not from within script.
{ "avatar_url": "https://avatars.githubusercontent.com/u/248430?v=4", "events_url": "https://api.github.com/users/egmhansen/events{/privacy}", "followers_url": "https://api.github.com/users/egmhansen/followers", "following_url": "https://api.github.com/users/egmhansen/following{/other_user}", "gists_url": "https://api.github.com/users/egmhansen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/egmhansen", "id": 248430, "login": "egmhansen", "node_id": "MDQ6VXNlcjI0ODQzMA==", "organizations_url": "https://api.github.com/users/egmhansen/orgs", "received_events_url": "https://api.github.com/users/egmhansen/received_events", "repos_url": "https://api.github.com/users/egmhansen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/egmhansen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/egmhansen/subscriptions", "type": "User", "url": "https://api.github.com/users/egmhansen", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-03-20T18:12:58Z
2021-09-08T23:05:52Z
2015-03-20T18:25:45Z
NONE
resolved
If I run the following from the command line, it works fine. If I try to run it from a script I get the AttributeError. Why is those things I said? import requests r = requests.head('https://api.github.com/user') AttributeError: 'module' object has no attribute 'head'
{ "avatar_url": "https://avatars.githubusercontent.com/u/248430?v=4", "events_url": "https://api.github.com/users/egmhansen/events{/privacy}", "followers_url": "https://api.github.com/users/egmhansen/followers", "following_url": "https://api.github.com/users/egmhansen/following{/other_user}", "gists_url": "https://api.github.com/users/egmhansen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/egmhansen", "id": 248430, "login": "egmhansen", "node_id": "MDQ6VXNlcjI0ODQzMA==", "organizations_url": "https://api.github.com/users/egmhansen/orgs", "received_events_url": "https://api.github.com/users/egmhansen/received_events", "repos_url": "https://api.github.com/users/egmhansen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/egmhansen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/egmhansen/subscriptions", "type": "User", "url": "https://api.github.com/users/egmhansen", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2507/reactions" }
https://api.github.com/repos/psf/requests/issues/2507/timeline
null
completed
null
null
false
[ "Is there a file named 'requests.py'? Python would try to import that file, not the module, in that case.\n", "Nailed it! thanks Kevin!\n" ]
https://api.github.com/repos/psf/requests/issues/2506
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2506/labels{/name}
https://api.github.com/repos/psf/requests/issues/2506/comments
https://api.github.com/repos/psf/requests/issues/2506/events
https://github.com/psf/requests/pull/2506
62,806,978
MDExOlB1bGxSZXF1ZXN0MzE0NzQ1NDY=
2,506
Expand on chunked handling.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-03-18T21:32:41Z
2021-09-08T07:00:49Z
2015-07-18T15:44:31Z
MEMBER
resolved
Once we merge in the new urllib3, this will update the docs to reflect the new best way to handle chunked transfer encoding.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2506/reactions" }
https://api.github.com/repos/psf/requests/issues/2506/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2506.diff", "html_url": "https://github.com/psf/requests/pull/2506", "merged_at": "2015-07-18T15:44:31Z", "patch_url": "https://github.com/psf/requests/pull/2506.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2506" }
true
[ "looks fine to me\n\nhow about specifying the size of a chunk? will it be possible?\n", "Yup, passing the chunk size parameter to `iter_content` will do it. What you _can't_ do is change that size from chunk to chunk.\n", "You are right! Should have checked the code.\n\nThe reason I asked because I was slightly...
https://api.github.com/repos/psf/requests/issues/2505
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2505/labels{/name}
https://api.github.com/repos/psf/requests/issues/2505/comments
https://api.github.com/repos/psf/requests/issues/2505/events
https://github.com/psf/requests/issues/2505
62,794,103
MDU6SXNzdWU2Mjc5NDEwMw==
2,505
request.files is empty after POSTing a file
{ "avatar_url": "https://avatars.githubusercontent.com/u/1389463?v=4", "events_url": "https://api.github.com/users/bepetersn/events{/privacy}", "followers_url": "https://api.github.com/users/bepetersn/followers", "following_url": "https://api.github.com/users/bepetersn/following{/other_user}", "gists_url": "https://api.github.com/users/bepetersn/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/bepetersn", "id": 1389463, "login": "bepetersn", "node_id": "MDQ6VXNlcjEzODk0NjM=", "organizations_url": "https://api.github.com/users/bepetersn/orgs", "received_events_url": "https://api.github.com/users/bepetersn/received_events", "repos_url": "https://api.github.com/users/bepetersn/repos", "site_admin": false, "starred_url": "https://api.github.com/users/bepetersn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bepetersn/subscriptions", "type": "User", "url": "https://api.github.com/users/bepetersn", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-03-18T20:41:34Z
2021-09-08T23:05:52Z
2015-03-18T21:54:34Z
NONE
resolved
Hey guys, I don't know if this is the right place to make this bug report, but I could sure use some help, I have been banging my head against a wall for a bit. See this repo where I'm reproducing my error: https://github.com/bepetersn/special-repo. Using Flask, I'm seeing weird behavior around its `request` object. After uploading a file with the requests library, e.g. `requests.post(uri, files=<my_files>)`, by the time the request propagated to my view function, `request.files` was empty. Oddly, I observed that the contents of the file itself was available under `request.form[None]`. After quite a lot of debugging, I saw that Werkzeug received roughly the following as the form/multipart-encoded data, and proceeded to try to parse it: > Content-Disposition: form-data; name_=utf-8\'\'Spirit%20Airlines%20-%20cheap%20tickets%2C%0A %20cheap%20flights%2C%20discount%20airfare%2C%20cheap%20hotels %2C%20cheap%20car%20rentals%2C%20cheap%20travel.pdf; filename_=utf- 8\'\'Spirit%20Airlines%20-%20cheap%20tickets%2C%0A%20cheap%20flights %2C%20discount%20airfare%2C%20cheap%20hotels%2C%20cheap%20car%20rentals %2C%20cheap%20travel.pdf\r\n Do you notice the little "*" characters just after the "name" and "filename" header definitions? From my sense of things, Werkzeug looks for exactly "name" and "filename", doesn't know how to parse these in their place, fails to find an attachment name, and thus doesn't create a `werkzeug.datastructures.FileStorage`. For this reason, `request.files` is empty. What does anyone think? Is requests responsible for adding these extra characters in?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 2, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 2, "url": "https://api.github.com/repos/psf/requests/issues/2505/reactions" }
https://api.github.com/repos/psf/requests/issues/2505/timeline
null
completed
null
null
false
[ "I see the line responsible here: https://github.com/kennethreitz/requests/blob/35d083e1665beff39aabe47a79cd1f867b897b0c/requests/packages/urllib3/fields.py#L45. However, it's pretty clear that it's intentional. I'm curious if anyone can point me to what purpose it has (maybe something to do with RFC 2231?), -- and...
https://api.github.com/repos/psf/requests/issues/2504
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2504/labels{/name}
https://api.github.com/repos/psf/requests/issues/2504/comments
https://api.github.com/repos/psf/requests/issues/2504/events
https://github.com/psf/requests/pull/2504
62,668,489
MDExOlB1bGxSZXF1ZXN0MzE0MjA0MjI=
2,504
fix resolve redirect to pass all original arguments
{ "avatar_url": "https://avatars.githubusercontent.com/u/391586?v=4", "events_url": "https://api.github.com/users/pvanderlinden/events{/privacy}", "followers_url": "https://api.github.com/users/pvanderlinden/followers", "following_url": "https://api.github.com/users/pvanderlinden/following{/other_user}", "gists_url": "https://api.github.com/users/pvanderlinden/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pvanderlinden", "id": 391586, "login": "pvanderlinden", "node_id": "MDQ6VXNlcjM5MTU4Ng==", "organizations_url": "https://api.github.com/users/pvanderlinden/orgs", "received_events_url": "https://api.github.com/users/pvanderlinden/received_events", "repos_url": "https://api.github.com/users/pvanderlinden/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pvanderlinden/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pvanderlinden/subscriptions", "type": "User", "url": "https://api.github.com/users/pvanderlinden", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2015-03-18T11:33:15Z
2021-09-08T08:00:50Z
2015-04-16T05:57:56Z
CONTRIBUTOR
resolved
Fix for https://github.com/kennethreitz/requests/issues/2503 It is still a bit inconsistent but as mentioned in the issue, but it otherwise will break the current public api. This makes it possible for non urllib3 adapters to accept extra arguments.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2504/reactions" }
https://api.github.com/repos/psf/requests/issues/2504/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2504.diff", "html_url": "https://github.com/psf/requests/pull/2504", "merged_at": "2015-04-16T05:57:56Z", "patch_url": "https://github.com/psf/requests/pull/2504.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2504" }
true
[ "I think I'd like the `kwargs` parameter in `resolve_redirects` to have a different name: `adapter_kwargs`, maybe?\n", "I have changed the parameter.\n", "LGTM. The one thing I'm thinking about is whether we want to allow for forward compatibility by actually storing these kwargs in a dictionary for resolve_red...
https://api.github.com/repos/psf/requests/issues/2503
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2503/labels{/name}
https://api.github.com/repos/psf/requests/issues/2503/comments
https://api.github.com/repos/psf/requests/issues/2503/events
https://github.com/psf/requests/issues/2503
62,400,729
MDU6SXNzdWU2MjQwMDcyOQ==
2,503
Redirect doesn't pass all parameters
{ "avatar_url": "https://avatars.githubusercontent.com/u/391586?v=4", "events_url": "https://api.github.com/users/pvanderlinden/events{/privacy}", "followers_url": "https://api.github.com/users/pvanderlinden/followers", "following_url": "https://api.github.com/users/pvanderlinden/following{/other_user}", "gists_url": "https://api.github.com/users/pvanderlinden/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pvanderlinden", "id": 391586, "login": "pvanderlinden", "node_id": "MDQ6VXNlcjM5MTU4Ng==", "organizations_url": "https://api.github.com/users/pvanderlinden/orgs", "received_events_url": "https://api.github.com/users/pvanderlinden/received_events", "repos_url": "https://api.github.com/users/pvanderlinden/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pvanderlinden/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pvanderlinden/subscriptions", "type": "User", "url": "https://api.github.com/users/pvanderlinden", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
4
2015-03-17T13:41:37Z
2021-09-08T23:04:52Z
2015-05-03T15:06:00Z
CONTRIBUTOR
resolved
When you write your own adapter which takes other parameters then the default adapter, resolve_redirects only pass in the parameters which the default adapter takes, this is different from the first request as it passes all parameters to the send function.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2503/reactions" }
https://api.github.com/repos/psf/requests/issues/2503/timeline
null
completed
null
null
false
[ "Good spot, we should aim to fix that. Not sure where we'll store them though.\n", "Requests currently keeps all those parameters seperatly (just in a local variables I think), instead of getting them from **kwargs invidually pass them whole kwargs to the redirect resolver? I might raise a PR for this tomorrow if...
https://api.github.com/repos/psf/requests/issues/2502
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2502/labels{/name}
https://api.github.com/repos/psf/requests/issues/2502/comments
https://api.github.com/repos/psf/requests/issues/2502/events
https://github.com/psf/requests/issues/2502
62,343,597
MDU6SXNzdWU2MjM0MzU5Nw==
2,502
Kerberos auth doesn't work when the host is an alias
{ "avatar_url": "https://avatars.githubusercontent.com/u/3543138?v=4", "events_url": "https://api.github.com/users/AndreaGiardini/events{/privacy}", "followers_url": "https://api.github.com/users/AndreaGiardini/followers", "following_url": "https://api.github.com/users/AndreaGiardini/following{/other_user}", "gists_url": "https://api.github.com/users/AndreaGiardini/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/AndreaGiardini", "id": 3543138, "login": "AndreaGiardini", "node_id": "MDQ6VXNlcjM1NDMxMzg=", "organizations_url": "https://api.github.com/users/AndreaGiardini/orgs", "received_events_url": "https://api.github.com/users/AndreaGiardini/received_events", "repos_url": "https://api.github.com/users/AndreaGiardini/repos", "site_admin": false, "starred_url": "https://api.github.com/users/AndreaGiardini/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AndreaGiardini/subscriptions", "type": "User", "url": "https://api.github.com/users/AndreaGiardini", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2015-03-17T09:29:52Z
2021-09-08T21:00:47Z
2015-11-05T18:04:23Z
NONE
resolved
Hi I'm using the request module in combination with request-kerberos. Since the server i'm querying is behind a load balancer it often happens that the authentication is done with host1 and the query on host2, leading to error 401 Unauthenticated. I manage to workaround this problem this way: ``` host = socket.gethostbyaddr(random.choice(socket.gethostbyname_ex(host)[2]))[0] ``` Don't know if i should open this issue in `requests-kerberos` as well.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2502/reactions" }
https://api.github.com/repos/psf/requests/issues/2502/timeline
null
completed
null
null
false
[ "requests-kerberos should authenticate every connection so long as you attach it as an auth handler to the _session_, not to individual requests. Ideally that should avoid this problem.\n", "Do you mean something like this?\n\n```\ns = requests.Session()\ns.auth = HTTPKerberosAuth()\ns.get('http://my.beautiful.al...
https://api.github.com/repos/psf/requests/issues/2501
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2501/labels{/name}
https://api.github.com/repos/psf/requests/issues/2501/comments
https://api.github.com/repos/psf/requests/issues/2501/events
https://github.com/psf/requests/pull/2501
62,201,326
MDExOlB1bGxSZXF1ZXN0MzEyODEzNjA=
2,501
Added myself to authors.rst
{ "avatar_url": "https://avatars.githubusercontent.com/u/3696393?v=4", "events_url": "https://api.github.com/users/yasoob/events{/privacy}", "followers_url": "https://api.github.com/users/yasoob/followers", "following_url": "https://api.github.com/users/yasoob/following{/other_user}", "gists_url": "https://api.github.com/users/yasoob/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yasoob", "id": 3696393, "login": "yasoob", "node_id": "MDQ6VXNlcjM2OTYzOTM=", "organizations_url": "https://api.github.com/users/yasoob/orgs", "received_events_url": "https://api.github.com/users/yasoob/received_events", "repos_url": "https://api.github.com/users/yasoob/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yasoob/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasoob/subscriptions", "type": "User", "url": "https://api.github.com/users/yasoob", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-16T20:30:21Z
2021-09-08T08:00:58Z
2015-03-16T20:31:09Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2501/reactions" }
https://api.github.com/repos/psf/requests/issues/2501/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2501.diff", "html_url": "https://github.com/psf/requests/pull/2501", "merged_at": "2015-03-16T20:31:09Z", "patch_url": "https://github.com/psf/requests/pull/2501.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2501" }
true
[ ":sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/2500
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2500/labels{/name}
https://api.github.com/repos/psf/requests/issues/2500/comments
https://api.github.com/repos/psf/requests/issues/2500/events
https://github.com/psf/requests/issues/2500
62,085,366
MDU6SXNzdWU2MjA4NTM2Ng==
2,500
Add config option to use system CA bundle
{ "avatar_url": "https://avatars.githubusercontent.com/u/4709746?v=4", "events_url": "https://api.github.com/users/wrycu/events{/privacy}", "followers_url": "https://api.github.com/users/wrycu/followers", "following_url": "https://api.github.com/users/wrycu/following{/other_user}", "gists_url": "https://api.github.com/users/wrycu/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/wrycu", "id": 4709746, "login": "wrycu", "node_id": "MDQ6VXNlcjQ3MDk3NDY=", "organizations_url": "https://api.github.com/users/wrycu/orgs", "received_events_url": "https://api.github.com/users/wrycu/received_events", "repos_url": "https://api.github.com/users/wrycu/repos", "site_admin": false, "starred_url": "https://api.github.com/users/wrycu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wrycu/subscriptions", "type": "User", "url": "https://api.github.com/users/wrycu", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "f7c6c7", "default": false, "description": null...
closed
true
null
[]
null
2
2015-03-16T13:43:51Z
2021-09-08T23:05:53Z
2015-03-16T15:47:27Z
NONE
resolved
I'm using requests with an internal CA which is trusted on my machines. I recently discovered that you can modify the code in certs.py to return the system CA bundle (thus allowing verified HTTPS requests), but I think this should really be an option, not a modification to the module. And since we all use venvs to dev, simply adding it to the Requests bundle is not a very elegant solution.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2500/reactions" }
https://api.github.com/repos/psf/requests/issues/2500/timeline
null
completed
null
null
false
[ "If you know the location, you can use the verify parameter on a session to set the location or you can use `REQUESTS_CA_BUNDLE` and `CURL_CA_BUNDLE`.\n\nWe used to have a way to auto-discover system bundles but there were far too many corner cases.\n", "This is another thing that can be solved by shazow/urllib3#...
https://api.github.com/repos/psf/requests/issues/2499
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2499/labels{/name}
https://api.github.com/repos/psf/requests/issues/2499/comments
https://api.github.com/repos/psf/requests/issues/2499/events
https://github.com/psf/requests/issues/2499
62,045,659
MDU6SXNzdWU2MjA0NTY1OQ==
2,499
Passing multiple certs for CA validation
{ "avatar_url": "https://avatars.githubusercontent.com/u/348449?v=4", "events_url": "https://api.github.com/users/nanonyme/events{/privacy}", "followers_url": "https://api.github.com/users/nanonyme/followers", "following_url": "https://api.github.com/users/nanonyme/following{/other_user}", "gists_url": "https://api.github.com/users/nanonyme/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/nanonyme", "id": 348449, "login": "nanonyme", "node_id": "MDQ6VXNlcjM0ODQ0OQ==", "organizations_url": "https://api.github.com/users/nanonyme/orgs", "received_events_url": "https://api.github.com/users/nanonyme/received_events", "repos_url": "https://api.github.com/users/nanonyme/repos", "site_admin": false, "starred_url": "https://api.github.com/users/nanonyme/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nanonyme/subscriptions", "type": "User", "url": "https://api.github.com/users/nanonyme", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-16T11:04:42Z
2021-09-08T23:05:53Z
2015-03-16T15:45:03Z
CONTRIBUTOR
resolved
It would be nice that requests allowed passing multiple certs for CA validation. It might be for reason or another be unfeasible to merge CA certs into one bundle. In comparison stdlib ssl you can run load_verify_locations arbitrary amount of times to load more certificate locations.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2499/reactions" }
https://api.github.com/repos/psf/requests/issues/2499/timeline
null
completed
null
null
false
[ "Requests absolutely does allow that, you just need to concatenate your various certs together into one file that you then pass to `verify`.\n", "Yeah, I was meaning without concatenating your certs together in one file. That's specifically what load_verify_locations called multiple times avoids. That's especiall...
https://api.github.com/repos/psf/requests/issues/2498
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2498/labels{/name}
https://api.github.com/repos/psf/requests/issues/2498/comments
https://api.github.com/repos/psf/requests/issues/2498/events
https://github.com/psf/requests/issues/2498
61,913,986
MDU6SXNzdWU2MTkxMzk4Ng==
2,498
Cookies + proxy
{ "avatar_url": "https://avatars.githubusercontent.com/u/10043592?v=4", "events_url": "https://api.github.com/users/vtenq/events{/privacy}", "followers_url": "https://api.github.com/users/vtenq/followers", "following_url": "https://api.github.com/users/vtenq/following{/other_user}", "gists_url": "https://api.github.com/users/vtenq/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/vtenq", "id": 10043592, "login": "vtenq", "node_id": "MDQ6VXNlcjEwMDQzNTky", "organizations_url": "https://api.github.com/users/vtenq/orgs", "received_events_url": "https://api.github.com/users/vtenq/received_events", "repos_url": "https://api.github.com/users/vtenq/repos", "site_admin": false, "starred_url": "https://api.github.com/users/vtenq/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vtenq/subscriptions", "type": "User", "url": "https://api.github.com/users/vtenq", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-15T22:44:13Z
2021-09-08T17:05:40Z
2015-03-15T22:50:39Z
NONE
resolved
I'm sending requests to some site using proxy servers for each request another proxy. I'm not a pro in this sphere, so I'm interested in a such things: - are cookies generated each time while i'm sending requests? - can site (to which i'm sending request) identify my computer based on cookies or another factor and to find out that this request and other ones where made especially from my computer?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2498/reactions" }
https://api.github.com/repos/psf/requests/issues/2498/timeline
null
completed
null
null
false
[ "1. It depends. If you aren't using a [Session object](http://docs.python-requests.org/en/latest/user/advanced/#session-objects), then yes, cookies are generated each time because we have nowhere to store them. If you _are_ using a Session object, then you should re-use the cookies, because cookies are tied to the ...
https://api.github.com/repos/psf/requests/issues/2497
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2497/labels{/name}
https://api.github.com/repos/psf/requests/issues/2497/comments
https://api.github.com/repos/psf/requests/issues/2497/events
https://github.com/psf/requests/pull/2497
61,872,088
MDExOlB1bGxSZXF1ZXN0MzEzNzI3NTg=
2,497
Requests security release policy
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 136589914, "name": "Needs Info", "node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=", "url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info" }, { "color": "fad8c7", "default": false, "description": null, ...
closed
true
null
[]
null
14
2015-03-15T17:28:25Z
2021-09-08T08:00:56Z
2015-03-27T11:03:41Z
MEMBER
resolved
In the wake of CVE-2015-2296 we should take another look at our policy for patching, releasing and publicising security vulnerabilities like this one. Although we did a great job of responding quickly and pushing out a new release, we can definitely improve. I've received feedback from a couple of places that wanted to point out ways we could improve, and I'd like to solicit public feedback from anyone who has an interest to ensure that we're doing the best we possibly can with this sort of thing. The goal here is for me to write up a document that explains, step-by-step, our policy with security issues. This will be posted publicly and we'll use it as a reference for any future events. Below is the list of points people have raised: - We probably shouldn't announce these vulnerabilities on weekends. Several people have products and projects that require them to evaluate vulnerabilities as soon as they become aware of them, and forcing those people to work on weekends does not engender positive feelings towards us. - We released and announced before we had a CVE number. This might not have been the best thing for us to do, particularly as it will have made it a bit more difficult for people to keep track of what was going on. If you have any other suggestions, please post them below. I'm going to ping some specific interested parties to ensure they see this: @sigmavirus24 @dstufft @eriol @ralphbean
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2497/reactions" }
https://api.github.com/repos/psf/requests/issues/2497/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2497.diff", "html_url": "https://github.com/psf/requests/pull/2497", "merged_at": "2015-03-27T11:03:41Z", "patch_url": "https://github.com/psf/requests/pull/2497.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2497" }
true
[ "https://alexgaynor.net/2013/oct/19/security-process-open-source-projects/\n", "Some lead time on the changes in 3bd8afbff would have been nice, yes. @alex's recommendations look quite good to me as a 'maximal effort'. If even portions of those suggestions could be adopted, it would be an improvement. Thanks f...
https://api.github.com/repos/psf/requests/issues/2496
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2496/labels{/name}
https://api.github.com/repos/psf/requests/issues/2496/comments
https://api.github.com/repos/psf/requests/issues/2496/events
https://github.com/psf/requests/pull/2496
61,801,159
MDExOlB1bGxSZXF1ZXN0MzExOTkxNzI=
2,496
Update 2.6.0 changelog with CVE number CVE-2015-2296
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-03-15T11:50:03Z
2021-09-08T08:00:59Z
2015-03-15T11:50:52Z
MEMBER
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2496/reactions" }
https://api.github.com/repos/psf/requests/issues/2496/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2496.diff", "html_url": "https://github.com/psf/requests/pull/2496", "merged_at": "2015-03-15T11:50:52Z", "patch_url": "https://github.com/psf/requests/pull/2496.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2496" }
true
[]
https://api.github.com/repos/psf/requests/issues/2495
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2495/labels{/name}
https://api.github.com/repos/psf/requests/issues/2495/comments
https://api.github.com/repos/psf/requests/issues/2495/events
https://github.com/psf/requests/issues/2495
61,781,459
MDU6SXNzdWU2MTc4MTQ1OQ==
2,495
A true SSLContext object is not available warning in 2.6.0 for python < 2.7.9
{ "avatar_url": "https://avatars.githubusercontent.com/u/484306?v=4", "events_url": "https://api.github.com/users/davecoutts/events{/privacy}", "followers_url": "https://api.github.com/users/davecoutts/followers", "following_url": "https://api.github.com/users/davecoutts/following{/other_user}", "gists_url": "https://api.github.com/users/davecoutts/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/davecoutts", "id": 484306, "login": "davecoutts", "node_id": "MDQ6VXNlcjQ4NDMwNg==", "organizations_url": "https://api.github.com/users/davecoutts/orgs", "received_events_url": "https://api.github.com/users/davecoutts/received_events", "repos_url": "https://api.github.com/users/davecoutts/repos", "site_admin": false, "starred_url": "https://api.github.com/users/davecoutts/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davecoutts/subscriptions", "type": "User", "url": "https://api.github.com/users/davecoutts", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-03-15T09:19:56Z
2021-09-08T23:04:41Z
2015-03-15T16:19:40Z
NONE
resolved
Since upgrading to from requests 2.5.3 to 2.6.0 I now see 'A true SSLContext object is not available' warnings. The test environment is Python 2.7.6 on Ubuntu 14.04.2 LTS ``` python mkvirtualenv requests260 -i requests==2.6.0 .... (requests260)dave@xxps:~$ python Python 2.7.6 (default, Mar 22 2014, 22:59:56) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import requests >>> resp = requests.get('https://github.com') /home/dave/.virtualenvs/requests260/local/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning >>> quit() ``` The [urllib3](https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning) documentation recommends the use of [PyOpenSSL](https://urllib3.readthedocs.org/en/latest/security.html#openssl-pyopenssl) for python versions earlier than 2.7.9. The **pyopenssl.inject_into_urllib3()** call is being made in [requests/**init**.py](https://github.com/kennethreitz/requests/blob/fa338da717124188b21d48df55f2fa9aca459d12/requests/__init__.py#L54) Is the requests 2.6.0 SSLContext warning expected behaviour on python versions earlier than 2.7.9 considering that PyOpenSSL is being used ?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2495/reactions" }
https://api.github.com/repos/psf/requests/issues/2495/timeline
null
completed
null
null
false
[ "That warning should not be raised unless we're not using pyOpenSSL. Can you confirm that `pip freeze` lists pyOpenSSL, ndg-httpsclient, and pyasn1?\n", "Oooops! I had convinced myself that pyOpenSSL was installed, but it wasn't.\nIf I install **ndg-httpsclient** along with **requests** I no longer see the warnin...
https://api.github.com/repos/psf/requests/issues/2494
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2494/labels{/name}
https://api.github.com/repos/psf/requests/issues/2494/comments
https://api.github.com/repos/psf/requests/issues/2494/events
https://github.com/psf/requests/pull/2494
61,762,998
MDExOlB1bGxSZXF1ZXN0MzExOTYzNDk=
2,494
"A CVE identifier"
{ "avatar_url": "https://avatars.githubusercontent.com/u/1937160?v=4", "events_url": "https://api.github.com/users/Ayrx/events{/privacy}", "followers_url": "https://api.github.com/users/Ayrx/followers", "following_url": "https://api.github.com/users/Ayrx/following{/other_user}", "gists_url": "https://api.github.com/users/Ayrx/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Ayrx", "id": 1937160, "login": "Ayrx", "node_id": "MDQ6VXNlcjE5MzcxNjA=", "organizations_url": "https://api.github.com/users/Ayrx/orgs", "received_events_url": "https://api.github.com/users/Ayrx/received_events", "repos_url": "https://api.github.com/users/Ayrx/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Ayrx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ayrx/subscriptions", "type": "User", "url": "https://api.github.com/users/Ayrx", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-15T06:47:28Z
2021-09-08T08:00:59Z
2015-03-15T11:50:47Z
NONE
resolved
I believe this is the more correct grammar?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2494/reactions" }
https://api.github.com/repos/psf/requests/issues/2494/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2494.diff", "html_url": "https://github.com/psf/requests/pull/2494", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2494.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2494" }
true
[ "I believe it is too, however a CVE has now been assigned for this, so I'm going to update the changelog to refer to it instead. Thanks for spotting it though!\n" ]
https://api.github.com/repos/psf/requests/issues/2493
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2493/labels{/name}
https://api.github.com/repos/psf/requests/issues/2493/comments
https://api.github.com/repos/psf/requests/issues/2493/events
https://github.com/psf/requests/pull/2493
61,687,095
MDExOlB1bGxSZXF1ZXN0MzExODkxOTg=
2,493
made the quickstart more reader friendly
{ "avatar_url": "https://avatars.githubusercontent.com/u/3696393?v=4", "events_url": "https://api.github.com/users/yasoob/events{/privacy}", "followers_url": "https://api.github.com/users/yasoob/followers", "following_url": "https://api.github.com/users/yasoob/following{/other_user}", "gists_url": "https://api.github.com/users/yasoob/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/yasoob", "id": 3696393, "login": "yasoob", "node_id": "MDQ6VXNlcjM2OTYzOTM=", "organizations_url": "https://api.github.com/users/yasoob/orgs", "received_events_url": "https://api.github.com/users/yasoob/received_events", "repos_url": "https://api.github.com/users/yasoob/repos", "site_admin": false, "starred_url": "https://api.github.com/users/yasoob/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasoob/subscriptions", "type": "User", "url": "https://api.github.com/users/yasoob", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-03-14T20:02:40Z
2021-09-08T08:00:59Z
2015-03-15T18:39:54Z
CONTRIBUTOR
resolved
Closes #2418
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2493/reactions" }
https://api.github.com/repos/psf/requests/issues/2493/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2493.diff", "html_url": "https://github.com/psf/requests/pull/2493", "merged_at": "2015-03-15T18:39:54Z", "patch_url": "https://github.com/psf/requests/pull/2493.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2493" }
true
[ "Can we choose a better header to set? Or a better value? I can't see how a long user-agent string will be reader friendly. Some people will now start asking why all that information is necessary and what it means and why it's important. Why not use `headers={'Connection': 'close'}`?\n", "Or just shorten the user...
https://api.github.com/repos/psf/requests/issues/2492
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2492/labels{/name}
https://api.github.com/repos/psf/requests/issues/2492/comments
https://api.github.com/repos/psf/requests/issues/2492/events
https://github.com/psf/requests/pull/2492
61,641,136
MDExOlB1bGxSZXF1ZXN0MzExODYwNjQ=
2,492
Bump version and add release notes for 2.6.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-03-14T16:42:50Z
2021-09-08T08:01:00Z
2015-03-14T16:43:32Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2492/reactions" }
https://api.github.com/repos/psf/requests/issues/2492/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2492.diff", "html_url": "https://github.com/psf/requests/pull/2492", "merged_at": "2015-03-14T16:43:32Z", "patch_url": "https://github.com/psf/requests/pull/2492.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2492" }
true
[]
https://api.github.com/repos/psf/requests/issues/2491
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2491/labels{/name}
https://api.github.com/repos/psf/requests/issues/2491/comments
https://api.github.com/repos/psf/requests/issues/2491/events
https://github.com/psf/requests/issues/2491
61,610,032
MDU6SXNzdWU2MTYxMDAzMg==
2,491
Allow some way to implement monitor callbacks for files in POST requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/1429103?v=4", "events_url": "https://api.github.com/users/cryzed/events{/privacy}", "followers_url": "https://api.github.com/users/cryzed/followers", "following_url": "https://api.github.com/users/cryzed/following{/other_user}", "gists_url": "https://api.github.com/users/cryzed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cryzed", "id": 1429103, "login": "cryzed", "node_id": "MDQ6VXNlcjE0MjkxMDM=", "organizations_url": "https://api.github.com/users/cryzed/orgs", "received_events_url": "https://api.github.com/users/cryzed/received_events", "repos_url": "https://api.github.com/users/cryzed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cryzed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cryzed/subscriptions", "type": "User", "url": "https://api.github.com/users/cryzed", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-14T13:42:53Z
2021-09-08T23:05:54Z
2015-03-14T13:56:07Z
NONE
resolved
I am currently developing a small tool to download and upload files. I am using the requests and progressbar libraries, among others. During downloading and uploading of files I want to display the progress and speed of the upload. This works very well with the download, I simply set stream=True in my request and then use iter_content on the Response object with some chunk_size and report the total loaded bytes back to the progressbar. As far as I can tell this is impossible with files sent via POST requests. I am trying to upload a single file by passing a dict as "files" to the POST request and would like to somehow implement a monitor callback that would either report how many bytes of that specific file have so far been uploaded, or how many bytes of the entire request have been uploaded -- either way works. I checked the requests internals, and the magic seems to happen in: request.models.RequestEncodingMixin._encode_files. The problem is that in the last few lines of that function, the data always seems to be read into memory all at once, making it impossible to decorate or implement the read method of the file-like object in such a way that would allow monitoring the current upload further down the line. Is there some kind of way to do what I am trying to do, and if there isn't yet, would you consider adding it? Maybe this would fit neatly into the hooks-system which doesn't seem to have that many features as of yet... EDIT: The [requests-toolbelt](https://toolbelt.readthedocs.org/en/0.3.0/user.html#monitoring-your-streaming-upload) seems to have the solution.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1429103?v=4", "events_url": "https://api.github.com/users/cryzed/events{/privacy}", "followers_url": "https://api.github.com/users/cryzed/followers", "following_url": "https://api.github.com/users/cryzed/following{/other_user}", "gists_url": "https://api.github.com/users/cryzed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cryzed", "id": 1429103, "login": "cryzed", "node_id": "MDQ6VXNlcjE0MjkxMDM=", "organizations_url": "https://api.github.com/users/cryzed/orgs", "received_events_url": "https://api.github.com/users/cryzed/received_events", "repos_url": "https://api.github.com/users/cryzed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cryzed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cryzed/subscriptions", "type": "User", "url": "https://api.github.com/users/cryzed", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2491/reactions" }
https://api.github.com/repos/psf/requests/issues/2491/timeline
null
completed
null
null
false
[ "For others looking at this, we discussed this on IRC and worked out the correct solution using the [requests-toolbelt](/sigmavirus24/requests-toolbelt).\n" ]
https://api.github.com/repos/psf/requests/issues/2490
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2490/labels{/name}
https://api.github.com/repos/psf/requests/issues/2490/comments
https://api.github.com/repos/psf/requests/issues/2490/events
https://github.com/psf/requests/issues/2490
61,575,936
MDU6SXNzdWU2MTU3NTkzNg==
2,490
411 response results in exception in Session.send
{ "avatar_url": "https://avatars.githubusercontent.com/u/3715287?v=4", "events_url": "https://api.github.com/users/ben-crowhurst/events{/privacy}", "followers_url": "https://api.github.com/users/ben-crowhurst/followers", "following_url": "https://api.github.com/users/ben-crowhurst/following{/other_user}", "gists_url": "https://api.github.com/users/ben-crowhurst/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ben-crowhurst", "id": 3715287, "login": "ben-crowhurst", "node_id": "MDQ6VXNlcjM3MTUyODc=", "organizations_url": "https://api.github.com/users/ben-crowhurst/orgs", "received_events_url": "https://api.github.com/users/ben-crowhurst/received_events", "repos_url": "https://api.github.com/users/ben-crowhurst/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ben-crowhurst/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ben-crowhurst/subscriptions", "type": "User", "url": "https://api.github.com/users/ben-crowhurst", "user_view_type": "public" }
[]
closed
true
null
[]
null
14
2015-03-14T11:59:39Z
2022-02-26T04:00:39Z
2021-11-28T03:02:39Z
NONE
resolved
Full details can be found over at [StackOverflow](http://stackoverflow.com/questions/29030398/411-response-results-in-exception-in-session-send)
{ "avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4", "events_url": "https://api.github.com/users/sethmlarson/events{/privacy}", "followers_url": "https://api.github.com/users/sethmlarson/followers", "following_url": "https://api.github.com/users/sethmlarson/following{/other_user}", "gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sethmlarson", "id": 18519037, "login": "sethmlarson", "node_id": "MDQ6VXNlcjE4NTE5MDM3", "organizations_url": "https://api.github.com/users/sethmlarson/orgs", "received_events_url": "https://api.github.com/users/sethmlarson/received_events", "repos_url": "https://api.github.com/users/sethmlarson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions", "type": "User", "url": "https://api.github.com/users/sethmlarson", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2490/reactions" }
https://api.github.com/repos/psf/requests/issues/2490/timeline
null
completed
null
null
false
[ "So this is probably a stupid question, but does that server actually work? As you discussed with @mjpieters on the question, this doesn't happen with our typical test server. Is there a server we can actually reproduce this with?\n", "The application server works with Httplib2, cURL command line tool and browser...
https://api.github.com/repos/psf/requests/issues/2489
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2489/labels{/name}
https://api.github.com/repos/psf/requests/issues/2489/comments
https://api.github.com/repos/psf/requests/issues/2489/events
https://github.com/psf/requests/pull/2489
61,569,592
MDExOlB1bGxSZXF1ZXN0MzExODIxODQ=
2,489
Don't label cookies for the target domain.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-03-14T11:31:11Z
2021-09-08T08:01:01Z
2015-03-14T12:05:48Z
MEMBER
resolved
Per a discussion @sigmavirus24 and I had on the mailing list, this change ensures that we correctly record cookie properties based on the original request, rather than the mutated version.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2489/reactions" }
https://api.github.com/repos/psf/requests/issues/2489/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2489.diff", "html_url": "https://github.com/psf/requests/pull/2489", "merged_at": "2015-03-14T12:05:48Z", "patch_url": "https://github.com/psf/requests/pull/2489.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2489" }
true
[]
https://api.github.com/repos/psf/requests/issues/2488
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2488/labels{/name}
https://api.github.com/repos/psf/requests/issues/2488/comments
https://api.github.com/repos/psf/requests/issues/2488/events
https://github.com/psf/requests/issues/2488
60,943,619
MDU6SXNzdWU2MDk0MzYxOQ==
2,488
Need documentation about "Cookies set on individual Requests through a `Session` are not persisted to the session"
{ "avatar_url": "https://avatars.githubusercontent.com/u/1499555?v=4", "events_url": "https://api.github.com/users/colinfang/events{/privacy}", "followers_url": "https://api.github.com/users/colinfang/followers", "following_url": "https://api.github.com/users/colinfang/following{/other_user}", "gists_url": "https://api.github.com/users/colinfang/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/colinfang", "id": 1499555, "login": "colinfang", "node_id": "MDQ6VXNlcjE0OTk1NTU=", "organizations_url": "https://api.github.com/users/colinfang/orgs", "received_events_url": "https://api.github.com/users/colinfang/received_events", "repos_url": "https://api.github.com/users/colinfang/repos", "site_admin": false, "starred_url": "https://api.github.com/users/colinfang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/colinfang/subscriptions", "type": "User", "url": "https://api.github.com/users/colinfang", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "0b02e1", "default": false, "description": null, "id": 19127...
closed
true
null
[]
null
2
2015-03-13T00:16:32Z
2021-09-08T23:00:42Z
2015-08-08T01:18:21Z
NONE
resolved
It took me a while to figure it out. Thought it might be a bug initially, I then came across #1791 & #1728. Since this feature by design is quite confusing. I feel it deserves some more attention apart from simply mention it in the changelog (0b68037). Can we have it as a tip/hint some where in the documentation (or quick start)? And suggest the proper way to prepare the persistent cookies.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2488/reactions" }
https://api.github.com/repos/psf/requests/issues/2488/timeline
null
completed
null
null
false
[ "Sorry, it's late here and I'm tired. Could you give an example of what you mean?\n", "So I think this is a good idea. It's not entirely clear that we don't send the custom cookies in the second request here:\n\n``` python\ns = Session()\ns.get('http://myhost.com/page1', cookies={'from-my': 'browser'})\ns.get('ht...
https://api.github.com/repos/psf/requests/issues/2487
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2487/labels{/name}
https://api.github.com/repos/psf/requests/issues/2487/comments
https://api.github.com/repos/psf/requests/issues/2487/events
https://github.com/psf/requests/pull/2487
60,814,487
MDExOlB1bGxSZXF1ZXN0MzEwMzI4NTQ=
2,487
Add return type field to entry-point docstrings
{ "avatar_url": "https://avatars.githubusercontent.com/u/55078?v=4", "events_url": "https://api.github.com/users/ulope/events{/privacy}", "followers_url": "https://api.github.com/users/ulope/followers", "following_url": "https://api.github.com/users/ulope/following{/other_user}", "gists_url": "https://api.github.com/users/ulope/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ulope", "id": 55078, "login": "ulope", "node_id": "MDQ6VXNlcjU1MDc4", "organizations_url": "https://api.github.com/users/ulope/orgs", "received_events_url": "https://api.github.com/users/ulope/received_events", "repos_url": "https://api.github.com/users/ulope/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ulope/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ulope/subscriptions", "type": "User", "url": "https://api.github.com/users/ulope", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-12T12:56:10Z
2021-09-08T08:01:02Z
2015-03-14T11:19:12Z
CONTRIBUTOR
resolved
Fixes: #2483
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2487/reactions" }
https://api.github.com/repos/psf/requests/issues/2487/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2487.diff", "html_url": "https://github.com/psf/requests/pull/2487", "merged_at": "2015-03-14T11:19:12Z", "patch_url": "https://github.com/psf/requests/pull/2487.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2487" }
true
[ ":cake: :star: :cookie: Thanks for this @ulope! Want to add yourself to AUTHORS.rst while we're here?\n", "Oh, yeah, sure. I'll push a new version momentarily.\n", "Beautiful! :cookie: :sparkles: :cake:\n\nThanks so much @ulope!\n" ]
https://api.github.com/repos/psf/requests/issues/2486
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2486/labels{/name}
https://api.github.com/repos/psf/requests/issues/2486/comments
https://api.github.com/repos/psf/requests/issues/2486/events
https://github.com/psf/requests/pull/2486
60,759,840
MDExOlB1bGxSZXF1ZXN0MzEwMDI2MzI=
2,486
Extract version from requests/__init__.py instead of importing requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
17
2015-03-12T02:02:12Z
2021-09-08T08:01:00Z
2015-03-14T11:20:33Z
CONTRIBUTOR
resolved
This works around a bug in the way setuptools' `test` command works when initially run. Closes #2462
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2486/reactions" }
https://api.github.com/repos/psf/requests/issues/2486/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2486.diff", "html_url": "https://github.com/psf/requests/pull/2486", "merged_at": "2015-03-14T11:20:33Z", "patch_url": "https://github.com/psf/requests/pull/2486.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2486" }
true
[ "Do we believe this only affects sys?\n", "## It's the only import in init and I'm hoping @wardi can help make sure this is correct.\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n", "looks like it would work, but reproducing the error is a pain. I don't yet know why it only failed on ...
https://api.github.com/repos/psf/requests/issues/2485
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2485/labels{/name}
https://api.github.com/repos/psf/requests/issues/2485/comments
https://api.github.com/repos/psf/requests/issues/2485/events
https://github.com/psf/requests/pull/2485
60,759,374
MDExOlB1bGxSZXF1ZXN0MzEwMDIzNzQ=
2,485
Import urllib3's Retry location from the right place
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
2
2015-03-12T01:55:12Z
2021-09-08T08:01:02Z
2015-03-12T06:50:33Z
CONTRIBUTOR
resolved
Importing from urllib3's top-level location causes the namespace to be urllib3.util.retry.Retry instead of requests.packages.urllib3.util.retry.Retry. Without this fix, an using requests with an un-vendored version of urllib3 will break when urllib3's retry handling kicks in. Closes shazow/urllib3#567
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2485/reactions" }
https://api.github.com/repos/psf/requests/issues/2485/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2485.diff", "html_url": "https://github.com/psf/requests/pull/2485", "merged_at": "2015-03-12T06:50:33Z", "patch_url": "https://github.com/psf/requests/pull/2485.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2485" }
true
[ "@Lukasa feel free to merge this so we can release 2.5.5 tomorrow.\n", ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2484
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2484/labels{/name}
https://api.github.com/repos/psf/requests/issues/2484/comments
https://api.github.com/repos/psf/requests/issues/2484/events
https://github.com/psf/requests/pull/2484
60,654,228
MDExOlB1bGxSZXF1ZXN0MzA5NDAzMTk=
2,484
Sanitise verb string. Now we can use unicode strings in http methods.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1284569?v=4", "events_url": "https://api.github.com/users/pawlyk/events{/privacy}", "followers_url": "https://api.github.com/users/pawlyk/followers", "following_url": "https://api.github.com/users/pawlyk/following{/other_user}", "gists_url": "https://api.github.com/users/pawlyk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pawlyk", "id": 1284569, "login": "pawlyk", "node_id": "MDQ6VXNlcjEyODQ1Njk=", "organizations_url": "https://api.github.com/users/pawlyk/orgs", "received_events_url": "https://api.github.com/users/pawlyk/received_events", "repos_url": "https://api.github.com/users/pawlyk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pawlyk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pawlyk/subscriptions", "type": "User", "url": "https://api.github.com/users/pawlyk", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 78002701, "name": "Do Not Merge", "node_id": "MDU6TGFiZWw3ODAwMjcwMQ==", "url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge" } ]
closed
true
null
[]
null
3
2015-03-11T12:58:46Z
2021-09-08T08:01:04Z
2015-03-11T14:25:05Z
NONE
resolved
There is error (`UnicodeDecodeError: 'ascii' codec can't decode...`) when use unicode string as http verb in instance Request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2484/reactions" }
https://api.github.com/repos/psf/requests/issues/2484/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2484.diff", "html_url": "https://github.com/psf/requests/pull/2484", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2484.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2484" }
true
[ "Interesting.\n\nWhy do you want to do this? RFC 7230 is pretty unambiguous about what's allowed in a HTTP METHOD: namely, `token`. The ABNF defines `token` as:\n\n```\n token = 1*tchar\n\n tchar = \"!\" / \"#\" / \"$\" / \"%\" / \"&\" / \"'\" / \"*\"\n / \"+\" / \"-\" / \".\" / \"^...
https://api.github.com/repos/psf/requests/issues/2483
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2483/labels{/name}
https://api.github.com/repos/psf/requests/issues/2483/comments
https://api.github.com/repos/psf/requests/issues/2483/events
https://github.com/psf/requests/issues/2483
60,638,350
MDU6SXNzdWU2MDYzODM1MA==
2,483
Consider adding return type documentation in docstrings
{ "avatar_url": "https://avatars.githubusercontent.com/u/55078?v=4", "events_url": "https://api.github.com/users/ulope/events{/privacy}", "followers_url": "https://api.github.com/users/ulope/followers", "following_url": "https://api.github.com/users/ulope/following{/other_user}", "gists_url": "https://api.github.com/users/ulope/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ulope", "id": 55078, "login": "ulope", "node_id": "MDQ6VXNlcjU1MDc4", "organizations_url": "https://api.github.com/users/ulope/orgs", "received_events_url": "https://api.github.com/users/ulope/received_events", "repos_url": "https://api.github.com/users/ulope/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ulope/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ulope/subscriptions", "type": "User", "url": "https://api.github.com/users/ulope", "user_view_type": "public" }
[ { "color": "0b02e1", "default": false, "description": null, "id": 191274, "name": "Contributor Friendly", "node_id": "MDU6TGFiZWwxOTEyNzQ=", "url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly" }, { "color": "5319e7", "default": false, "descrip...
closed
true
null
[]
null
4
2015-03-11T10:32:21Z
2021-09-08T23:05:49Z
2015-04-06T02:42:35Z
CONTRIBUTOR
resolved
It would be great if the docstrings of (at least) the top level entry points (`request`, `get`, `post`, etc.) could define the return type in a sphinx compatible way (`:rtype:` http://sphinx-doc.org/domains.html#info-field-lists). This would make it easier to work with requests in various IDEs and code inspection tools.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2483/reactions" }
https://api.github.com/repos/psf/requests/issues/2483/timeline
null
completed
null
null
false
[ "Sounds good to me!\n\nDo you want to open a pull request containing this change?\n", "Sure. I'll try to fit it in later in the day.\n", ":+1: \n", "Looks like this was fixed by #2487. Closing as fixed.\n" ]
https://api.github.com/repos/psf/requests/issues/2482
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2482/labels{/name}
https://api.github.com/repos/psf/requests/issues/2482/comments
https://api.github.com/repos/psf/requests/issues/2482/events
https://github.com/psf/requests/pull/2482
60,592,489
MDExOlB1bGxSZXF1ZXN0MzA5MDY1MDM=
2,482
Update urllib3 to 43b5b2b452e4344374de7d08ececcca495079b8d
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-11T00:34:50Z
2021-09-08T08:01:03Z
2015-03-11T14:52:11Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2482/reactions" }
https://api.github.com/repos/psf/requests/issues/2482/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2482.diff", "html_url": "https://github.com/psf/requests/pull/2482", "merged_at": "2015-03-11T14:52:11Z", "patch_url": "https://github.com/psf/requests/pull/2482.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2482" }
true
[ "```\n(requests)~/s/requests git:update-urllib3 ❯❯❯ py.test ✭\n=======================================================...
https://api.github.com/repos/psf/requests/issues/2481
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2481/labels{/name}
https://api.github.com/repos/psf/requests/issues/2481/comments
https://api.github.com/repos/psf/requests/issues/2481/events
https://github.com/psf/requests/issues/2481
60,481,079
MDU6SXNzdWU2MDQ4MTA3OQ==
2,481
"407 Proxy Authentication Required" after redirect with load balanced authenticated proxies
{ "avatar_url": "https://avatars.githubusercontent.com/u/291289?v=4", "events_url": "https://api.github.com/users/gsakkis/events{/privacy}", "followers_url": "https://api.github.com/users/gsakkis/followers", "following_url": "https://api.github.com/users/gsakkis/following{/other_user}", "gists_url": "https://api.github.com/users/gsakkis/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gsakkis", "id": 291289, "login": "gsakkis", "node_id": "MDQ6VXNlcjI5MTI4OQ==", "organizations_url": "https://api.github.com/users/gsakkis/orgs", "received_events_url": "https://api.github.com/users/gsakkis/received_events", "repos_url": "https://api.github.com/users/gsakkis/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gsakkis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gsakkis/subscriptions", "type": "User", "url": "https://api.github.com/users/gsakkis", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
14
2015-03-10T10:49:14Z
2021-09-08T23:05:55Z
2015-03-10T14:36:47Z
NONE
resolved
I'm having a problem I traced down to requests as the equivalent curl command works. I am running HAProxy on `localhost:5555` to load balance requests to a pool of authenticated backend http proxies as explained [here](http://serverfault.com/questions/386431/authenticated-proxies-on-haproxy-load-balancer). It works fine for fetching urls without redirection, as shown below using [httpie](https://github.com/jakubroztocil/httpie) (same behaviour observed using requests directly from the shell): ``` $ http 'http://httpbin.org/get' --proxy http:http://localhost:5555 --headers --debug HTTPie 0.9.2 HTTPie data: /home/gsakkis/.httpie Requests 2.5.3 Pygments 2.0.2 Python 2.7.6 (default, Mar 22 2014, 22:59:56) [GCC 4.8.2] linux2 >>> requests.request({'allow_redirects': False, 'auth': None, 'cert': None, 'data': OrderedDict(), 'files': DataDict(), 'headers': {'User-Agent': 'HTTPie/0.9.2'}, 'method': 'get', 'params': ParamsDict(), 'proxies': {u'http': u'http://localhost:5555'}, 'stream': True, 'timeout': 30, 'url': u'http://httpbin.org/get', 'verify': True}) HTTP/1.0 200 OK Access-Control-Allow-Credentials: true Access-Control-Allow-Origin: * Connection: keep-alive Content-Length: 269 Content-Type: application/json Date: Tue, 10 Mar 2015 10:38:37 GMT Server: nginx Via: 1.0 fl291 (squid/3.1.10) X-Cache: MISS from fl291 X-Cache-Lookup: MISS from fl291:80 ``` If I fetch a url that redirects without actually redirecting it still works, returning 302: ``` $ http 'http://httpbin.org/redirect-to?url=http://example.com/' --proxy http:http://localhost:5555 --headers --debug HTTPie 0.9.2 HTTPie data: /home/gsakkis/.httpie Requests 2.5.3 Pygments 2.0.2 Python 2.7.6 (default, Mar 22 2014, 22:59:56) [GCC 4.8.2] linux2 >>> requests.request({'allow_redirects': False, 'auth': None, 'cert': None, 'data': OrderedDict(), 'files': DataDict(), 'headers': {'User-Agent': 'HTTPie/0.9.2'}, 'method': 'get', 'params': ParamsDict(), 'proxies': {u'http': u'http://localhost:5555'}, 'stream': True, 'timeout': 30, 'url': u'http://httpbin.org/redirect-to?url=http://example.com/', 'verify': True}) HTTP/1.0 302 Moved Temporarily Access-Control-Allow-Credentials: true Access-Control-Allow-Origin: * Connection: keep-alive Content-Length: 0 Content-Type: text/html; charset=utf-8 Date: Tue, 10 Mar 2015 10:41:00 GMT Location: http://example.com/ Server: nginx Via: 1.0 mf5 (squid/3.1.10) X-Cache: MISS from mf5 X-Cache-Lookup: MISS from mf5:80 ``` However attempting to follow the redirect fails with 407: ``` $ http 'http://httpbin.org/redirect-to?url=http://example.com/' --proxy http:http://localhost:5555 --headers --follow --debug HTTPie 0.9.2 HTTPie data: /home/gsakkis/.httpie Requests 2.5.3 Pygments 2.0.2 Python 2.7.6 (default, Mar 22 2014, 22:59:56) [GCC 4.8.2] linux2 >>> requests.request({'allow_redirects': True, 'auth': None, 'cert': None, 'data': OrderedDict(), 'files': DataDict(), 'headers': {'User-Agent': 'HTTPie/0.9.2'}, 'method': 'get', 'params': ParamsDict(), 'proxies': {u'http': u'http://localhost:5555'}, 'stream': True, 'timeout': 30, 'url': u'http://httpbin.org/redirect-to?url=http://example.com/', 'verify': True}) HTTP/1.0 407 Proxy Authentication Required Connection: keep-alive Content-Length: 4 Content-Type: text/html Date: Tue, 10 Mar 2015 10:42:02 GMT Mime-Version: 1.0 Proxy-Authenticate: Basic realm="login" Server: squid/3.1.10 Via: 1.0 mf5 (squid/3.1.10) X-Cache: MISS from mf5 X-Cache-Lookup: NONE from mf5:80 X-Squid-Error: ERR_CACHE_ACCESS_DENIED 0 ``` The equivalent curl command seems to work fine though: ``` $ curl 'http://httpbin.org/redirect-to?url=http://example.com/' -s -L -x localhost:5555 -v -o /dev/null * Hostname was NOT found in DNS cache * Trying 127.0.0.1... * Connected to localhost (127.0.0.1) port 5555 (#0) > GET http://httpbin.org/redirect-to?url=http://example.com/ HTTP/1.1 > User-Agent: curl/7.35.0 > Host: httpbin.org > Accept: */* > Proxy-Connection: Keep-Alive > * HTTP 1.0, assume close after body < HTTP/1.0 302 Moved Temporarily < Server: nginx < Date: Tue, 10 Mar 2015 10:44:56 GMT < Content-Type: text/html; charset=utf-8 < Content-Length: 0 < Location: http://example.com/ < Access-Control-Allow-Origin: * < Access-Control-Allow-Credentials: true < X-Cache: MISS from fl291 < X-Cache-Lookup: MISS from fl291:80 < Via: 1.0 fl291 (squid/3.1.10) * HTTP/1.0 connection set to keep alive! < Connection: keep-alive < * Connection #0 to host localhost left intact * Issue another request to this URL: 'http://example.com/' * Hostname was found in DNS cache * Trying 127.0.0.1... * Connected to localhost (127.0.0.1) port 5555 (#1) > GET http://example.com/ HTTP/1.0 > User-Agent: curl/7.35.0 > Host: example.com > Accept: */* > Proxy-Connection: Keep-Alive > * HTTP 1.0, assume close after body < HTTP/1.0 200 OK < Accept-Ranges: bytes < Cache-Control: max-age=604800 < Content-Type: text/html < Date: Tue, 10 Mar 2015 10:44:57 GMT < ETag: "359670651" < Expires: Tue, 17 Mar 2015 10:44:57 GMT < Last-Modified: Fri, 09 Aug 2013 23:54:35 GMT < Server: ECS (cpm/F9D5) < X-Cache: HIT < x-ec-custom-error: 1 < Content-Length: 1270 < X-Cache: MISS from bv400 < X-Cache-Lookup: MISS from bv400:80 < Via: 1.0 bv400 (squid/3.1.10) * HTTP/1.0 connection set to keep alive! < Connection: keep-alive < { [data not shown] * Connection #1 to host localhost left intact ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2481/reactions" }
https://api.github.com/repos/psf/requests/issues/2481/timeline
null
completed
null
null
false
[ "Can you use tcpdump to show the HTTP packets flowing between your HAProxy instance and requests? Is this something you're familiar with doing?\n", "I have played with it occasionally but I'm far from an expert. Any particular command line I could try?\n", "Try `tcpdump -nnvvXSs 1514 -i lo port 5555` will be a ...
https://api.github.com/repos/psf/requests/issues/2480
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2480/labels{/name}
https://api.github.com/repos/psf/requests/issues/2480/comments
https://api.github.com/repos/psf/requests/issues/2480/events
https://github.com/psf/requests/issues/2480
60,340,376
MDU6SXNzdWU2MDM0MDM3Ng==
2,480
Radio streaming download: ICY causes BadStatusLine
{ "avatar_url": "https://avatars.githubusercontent.com/u/4907670?v=4", "events_url": "https://api.github.com/users/rubentorresbonet/events{/privacy}", "followers_url": "https://api.github.com/users/rubentorresbonet/followers", "following_url": "https://api.github.com/users/rubentorresbonet/following{/other_user}", "gists_url": "https://api.github.com/users/rubentorresbonet/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rubentorresbonet", "id": 4907670, "login": "rubentorresbonet", "node_id": "MDQ6VXNlcjQ5MDc2NzA=", "organizations_url": "https://api.github.com/users/rubentorresbonet/orgs", "received_events_url": "https://api.github.com/users/rubentorresbonet/received_events", "repos_url": "https://api.github.com/users/rubentorresbonet/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rubentorresbonet/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rubentorresbonet/subscriptions", "type": "User", "url": "https://api.github.com/users/rubentorresbonet", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-09T13:08:33Z
2021-09-08T23:05:55Z
2015-03-09T13:42:59Z
NONE
resolved
Hello, Even if the icy's protocol is broken, I would still need to download the streaming data of a shoutcast server. When attempting to, I get this issue: File "/usr/lib/python3/dist-packages/requests/api.py", line 55, in get return request('get', url, *_kwargs) File "/usr/lib/python3/dist-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, *_kwargs) File "/usr/lib/python3/dist-packages/requests/sessions.py", line 455, in request resp = self.send(prep, *_send_kwargs) File "/usr/lib/python3/dist-packages/requests/sessions.py", line 558, in send r = adapter.send(request, *_kwargs) File "/usr/lib/python3/dist-packages/requests/adapters.py", line 378, in send raise ConnectionError(e) requests.exceptions.ConnectionError: HTTPConnectionPool(host='streaming3.radiocat.net', port=80): Max retries exceeded with url: /;listen.mp3 (Caused by ProtocolError('Connection aborted.', BadStatusLine('ICY 200 OK\r\n',))) Any workaround or something I could do? Thanks.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2480/reactions" }
https://api.github.com/repos/psf/requests/issues/2480/timeline
null
completed
null
null
false
[ "Yes. =) Don't use a HTTP library.\n\nThat answer was a bit glib, but it's pretty accurate. Let me show you what RFC 7230 says a HTTP status line should look like:\n\n`status-line = HTTP-version SP status-code SP reason-phrase CRLF`\n\nThat first set of characters needs to be a HTTP version. If it doesn't specify a...
https://api.github.com/repos/psf/requests/issues/2479
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2479/labels{/name}
https://api.github.com/repos/psf/requests/issues/2479/comments
https://api.github.com/repos/psf/requests/issues/2479/events
https://github.com/psf/requests/issues/2479
60,266,197
MDU6SXNzdWU2MDI2NjE5Nw==
2,479
Returning json from SocketServer: ConnectionError BadStatusLine
{ "avatar_url": "https://avatars.githubusercontent.com/u/2013357?v=4", "events_url": "https://api.github.com/users/manojgudi/events{/privacy}", "followers_url": "https://api.github.com/users/manojgudi/followers", "following_url": "https://api.github.com/users/manojgudi/following{/other_user}", "gists_url": "https://api.github.com/users/manojgudi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/manojgudi", "id": 2013357, "login": "manojgudi", "node_id": "MDQ6VXNlcjIwMTMzNTc=", "organizations_url": "https://api.github.com/users/manojgudi/orgs", "received_events_url": "https://api.github.com/users/manojgudi/received_events", "repos_url": "https://api.github.com/users/manojgudi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/manojgudi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manojgudi/subscriptions", "type": "User", "url": "https://api.github.com/users/manojgudi", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-03-08T17:17:08Z
2021-09-08T23:05:56Z
2015-03-08T18:50:07Z
NONE
resolved
This worked in requests version 2.2.1, but breaks in 2.5.3 Environment: Ubuntu 12.04/x86 Python 2.7.3
{ "avatar_url": "https://avatars.githubusercontent.com/u/2013357?v=4", "events_url": "https://api.github.com/users/manojgudi/events{/privacy}", "followers_url": "https://api.github.com/users/manojgudi/followers", "following_url": "https://api.github.com/users/manojgudi/following{/other_user}", "gists_url": "https://api.github.com/users/manojgudi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/manojgudi", "id": 2013357, "login": "manojgudi", "node_id": "MDQ6VXNlcjIwMTMzNTc=", "organizations_url": "https://api.github.com/users/manojgudi/orgs", "received_events_url": "https://api.github.com/users/manojgudi/received_events", "repos_url": "https://api.github.com/users/manojgudi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/manojgudi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manojgudi/subscriptions", "type": "User", "url": "https://api.github.com/users/manojgudi", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2479/reactions" }
https://api.github.com/repos/psf/requests/issues/2479/timeline
null
completed
null
null
false
[ "@manojgudi can you give us more information. We have absolutely nothing to debug this with otherwise and will be forced to close the issue.\n", "@sigmavirus24 Thanks for prompt reply! Lemme write a script to reproduce this issue.. Gimme a day or so..\n\nThanks\n", "Turns out I didnt attach http headers when re...
https://api.github.com/repos/psf/requests/issues/2478
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2478/labels{/name}
https://api.github.com/repos/psf/requests/issues/2478/comments
https://api.github.com/repos/psf/requests/issues/2478/events
https://github.com/psf/requests/pull/2478
60,198,633
MDExOlB1bGxSZXF1ZXN0MzA3MDAxNDc=
2,478
Document Response.iter_lines() deficiencies
{ "avatar_url": "https://avatars.githubusercontent.com/u/91895?v=4", "events_url": "https://api.github.com/users/plaes/events{/privacy}", "followers_url": "https://api.github.com/users/plaes/followers", "following_url": "https://api.github.com/users/plaes/following{/other_user}", "gists_url": "https://api.github.com/users/plaes/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/plaes", "id": 91895, "login": "plaes", "node_id": "MDQ6VXNlcjkxODk1", "organizations_url": "https://api.github.com/users/plaes/orgs", "received_events_url": "https://api.github.com/users/plaes/received_events", "repos_url": "https://api.github.com/users/plaes/repos", "site_admin": false, "starred_url": "https://api.github.com/users/plaes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/plaes/subscriptions", "type": "User", "url": "https://api.github.com/users/plaes", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-03-07T09:08:03Z
2021-09-08T08:01:04Z
2015-03-07T10:03:42Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2478/reactions" }
https://api.github.com/repos/psf/requests/issues/2478/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2478.diff", "html_url": "https://github.com/psf/requests/pull/2478", "merged_at": "2015-03-07T10:03:42Z", "patch_url": "https://github.com/psf/requests/pull/2478.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2478" }
true
[ "@plaes This is a great PR. One small note however, we don't use `unittest`, we use `pytest`. This is why your test suite failed: `unittest.expectedFailure` doesn't exist in Python 2.6. Instead, use [`pytest.mark.xfail`](http://pytest.org/latest/skipping.html#mark-a-test-function-as-expected-to-fail).\n", "Oops.....
https://api.github.com/repos/psf/requests/issues/2477
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2477/labels{/name}
https://api.github.com/repos/psf/requests/issues/2477/comments
https://api.github.com/repos/psf/requests/issues/2477/events
https://github.com/psf/requests/pull/2477
60,142,170
MDExOlB1bGxSZXF1ZXN0MzA2NjkyODA=
2,477
Make Response.iter_lines() reentrant safe
{ "avatar_url": "https://avatars.githubusercontent.com/u/91895?v=4", "events_url": "https://api.github.com/users/plaes/events{/privacy}", "followers_url": "https://api.github.com/users/plaes/followers", "following_url": "https://api.github.com/users/plaes/following{/other_user}", "gists_url": "https://api.github.com/users/plaes/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/plaes", "id": 91895, "login": "plaes", "node_id": "MDQ6VXNlcjkxODk1", "organizations_url": "https://api.github.com/users/plaes/orgs", "received_events_url": "https://api.github.com/users/plaes/received_events", "repos_url": "https://api.github.com/users/plaes/repos", "site_admin": false, "starred_url": "https://api.github.com/users/plaes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/plaes/subscriptions", "type": "User", "url": "https://api.github.com/users/plaes", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-03-06T18:50:20Z
2021-09-08T08:01:05Z
2015-03-07T09:09:01Z
CONTRIBUTOR
resolved
Calling r.iter_lines() multiple times doesn't lose pending data between calls to this method.
{ "avatar_url": "https://avatars.githubusercontent.com/u/91895?v=4", "events_url": "https://api.github.com/users/plaes/events{/privacy}", "followers_url": "https://api.github.com/users/plaes/followers", "following_url": "https://api.github.com/users/plaes/following{/other_user}", "gists_url": "https://api.github.com/users/plaes/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/plaes", "id": 91895, "login": "plaes", "node_id": "MDQ6VXNlcjkxODk1", "organizations_url": "https://api.github.com/users/plaes/orgs", "received_events_url": "https://api.github.com/users/plaes/received_events", "repos_url": "https://api.github.com/users/plaes/repos", "site_admin": false, "starred_url": "https://api.github.com/users/plaes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/plaes/subscriptions", "type": "User", "url": "https://api.github.com/users/plaes", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2477/reactions" }
https://api.github.com/repos/psf/requests/issues/2477/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2477.diff", "html_url": "https://github.com/psf/requests/pull/2477", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2477.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2477" }
true
[ "This is fix for issue #2476. So either this, or documentation should mention that Response.iter_lines() is not reentrant safe.\n", "Eh, fine by me. @sigmavirus24?\n", "I feel likewise \"Eh\". This is just going to be broken if there aren't any tests for it. It also breaks the thread-safety of a response I thin...
https://api.github.com/repos/psf/requests/issues/2476
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2476/labels{/name}
https://api.github.com/repos/psf/requests/issues/2476/comments
https://api.github.com/repos/psf/requests/issues/2476/events
https://github.com/psf/requests/issues/2476
60,108,994
MDU6SXNzdWU2MDEwODk5NA==
2,476
iter_lines: Skipping first line using next(..)
{ "avatar_url": "https://avatars.githubusercontent.com/u/91895?v=4", "events_url": "https://api.github.com/users/plaes/events{/privacy}", "followers_url": "https://api.github.com/users/plaes/followers", "following_url": "https://api.github.com/users/plaes/following{/other_user}", "gists_url": "https://api.github.com/users/plaes/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/plaes", "id": 91895, "login": "plaes", "node_id": "MDQ6VXNlcjkxODk1", "organizations_url": "https://api.github.com/users/plaes/orgs", "received_events_url": "https://api.github.com/users/plaes/received_events", "repos_url": "https://api.github.com/users/plaes/repos", "site_admin": false, "starred_url": "https://api.github.com/users/plaes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/plaes/subscriptions", "type": "User", "url": "https://api.github.com/users/plaes", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-03-06T14:35:00Z
2021-09-08T23:05:56Z
2015-03-06T18:09:28Z
CONTRIBUTOR
resolved
When trying to skip first line of `response.iter_lines()` using `next()`, some extra data from following lines is also consumed. Test script: ``` python import requests from contextlib import closing with closing(requests.get('http://httpbin.org/stream/5', stream=True)) as r: skip = next(r.iter_lines()) print 'SKIP: ', skip for n, l in enumerate(r.iter_lines(), start=1): print 'PROCESS: {}'.format(n), l ``` With following output (line 1 totally missing, and line 2 being partial): ``` SKIP: {"url": "http://httpbin.org/stream/5", "headers": {"Host": "httpbin.org", "Accept-Encoding": "gzip, deflate", "Accept": "*/*", "User-Agent": "python-requests/2.4.3 CPython/2.7.9 Linux/4.0.0-rc2+"}, "args": {}, "id": 0, "origin": "xxx"} PROCESS: 1 n.org/stream/5", "headers": {"Host": "httpbin.org", "Accept-Encoding": "gzip, deflate", "Accept": "*/*", "User-Agent": "python-requests/2.4.3 CPython/2.7.9 Linux/4.0.0-rc2+"}, "args": {}, "id": 2, "origin": "xxx"} PROCESS: 2 {"url": "http://httpbin.org/stream/5", "headers": {"Host": "httpbin.org", "Accept-Encoding": "gzip, deflate", "Accept": "*/*", "User-Agent": "python-requests/2.4.3 CPython/2.7.9 Linux/4.0.0-rc2+"}, "args": {}, "id": 3, "origin": "xxx"} PROCESS: 3 {"url": "http://httpbin.org/stream/5", "headers": {"Host": "httpbin.org", "Accept-Encoding": "gzip, deflate", "Accept": "*/*", "User-Agent": "python-requests/2.4.3 CPython/2.7.9 Linux/4.0.0-rc2+"}, "args": {}, "id": 4, "origin": "xxx"} ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2476/reactions" }
https://api.github.com/repos/psf/requests/issues/2476/timeline
null
completed
null
null
false
[ "This is a tricky interaction with iterators. Most iterators don't quite behave the same way. What you need to do is the following\n\n``` py\nwith closing(requests.get('https://httpbin.org/stream/5', stream=True)) as r:\n iterator = r.iter_lines()\n print 'SKIP: ', next(iterator)\n for n, l in enumerate(it...
https://api.github.com/repos/psf/requests/issues/2475
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2475/labels{/name}
https://api.github.com/repos/psf/requests/issues/2475/comments
https://api.github.com/repos/psf/requests/issues/2475/events
https://github.com/psf/requests/issues/2475
60,052,903
MDU6SXNzdWU2MDA1MjkwMw==
2,475
Use Requests in Pycharm has a ImportError
{ "avatar_url": "https://avatars.githubusercontent.com/u/1762036?v=4", "events_url": "https://api.github.com/users/viweei/events{/privacy}", "followers_url": "https://api.github.com/users/viweei/followers", "following_url": "https://api.github.com/users/viweei/following{/other_user}", "gists_url": "https://api.github.com/users/viweei/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/viweei", "id": 1762036, "login": "viweei", "node_id": "MDQ6VXNlcjE3NjIwMzY=", "organizations_url": "https://api.github.com/users/viweei/orgs", "received_events_url": "https://api.github.com/users/viweei/received_events", "repos_url": "https://api.github.com/users/viweei/repos", "site_admin": false, "starred_url": "https://api.github.com/users/viweei/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/viweei/subscriptions", "type": "User", "url": "https://api.github.com/users/viweei", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-03-06T03:08:50Z
2021-09-08T23:05:49Z
2015-04-06T02:40:55Z
NONE
resolved
### Error: AttributeError: 'module' object has no attribute 'get' When I use Pycharm Requests, error: "AttributeError: 'module' object has no attribute 'get'" I modified file "requests\packages\urllib3\connection.py" in the 8-11 row ``` python try: # Python 3      from http.client import HTTPConnection as _HTTPConnection, HTTPException except ImportError:      from httplib import HTTPConnection as _HTTPConnection, HTTPException ``` To: ``` python py = sys.version_info if py >= (3, 0, 0): from http.client import HTTPConnection as _HTTPConnection, HTTPException else: from httplib import HTTPConnection as _HTTPConnection, HTTPException ``` It worked. ### Environment: Pycharm 4.04 Python 2.75
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2475/reactions" }
https://api.github.com/repos/psf/requests/issues/2475/timeline
null
completed
null
null
false
[ "What is PyCharm doing here? Because it seems to be totally confused.\n\nThis is a really common pattern, and it's considered good style: it's better to test for features than to do strict version checks wherever possible. The follow-on is: there's never access of an attribute called 'get' from the module you chang...
https://api.github.com/repos/psf/requests/issues/2474
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2474/labels{/name}
https://api.github.com/repos/psf/requests/issues/2474/comments
https://api.github.com/repos/psf/requests/issues/2474/events
https://github.com/psf/requests/issues/2474
59,943,083
MDU6SXNzdWU1OTk0MzA4Mw==
2,474
requests 2.5.4 mishandles WWW-Authenticate headers
{ "avatar_url": "https://avatars.githubusercontent.com/u/220082?v=4", "events_url": "https://api.github.com/users/dieterv/events{/privacy}", "followers_url": "https://api.github.com/users/dieterv/followers", "following_url": "https://api.github.com/users/dieterv/following{/other_user}", "gists_url": "https://api.github.com/users/dieterv/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dieterv", "id": 220082, "login": "dieterv", "node_id": "MDQ6VXNlcjIyMDA4Mg==", "organizations_url": "https://api.github.com/users/dieterv/orgs", "received_events_url": "https://api.github.com/users/dieterv/received_events", "repos_url": "https://api.github.com/users/dieterv/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dieterv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dieterv/subscriptions", "type": "User", "url": "https://api.github.com/users/dieterv", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-03-05T12:07:32Z
2021-09-08T23:05:57Z
2015-03-05T12:27:29Z
CONTRIBUTOR
resolved
Executing a get() with requests 2.5.4 I now stumble over an unexpected 401 error. Looking into it I see that response.headers contains: {'server': 'Microsoft-IIS/7.5', 'content-type': 'text/html', 'date': 'Thu, 05 Mar 2015 11:56:25 GMT', 'content-length': '1293', 'x-powered-by': 'ASP.NET', 'www-authenticate': 'Negotiate'} and the HttpNtlmAuth handler installed onto my session object has not kicked in. I have a feeling the "WWW-Authenticate: NTLM" header which is also in the response disappeared somewhere: ![headers](https://cloud.githubusercontent.com/assets/220082/6504440/b22c5680-c337-11e4-89bb-6f2da348c9fd.png)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2474/reactions" }
https://api.github.com/repos/psf/requests/issues/2474/timeline
null
completed
null
null
false
[ "Note the above works as expected after downgrading to requests 2.5.1.\n", "Thanks @dieterv, this is a known issue, see shazow/urllib3#561. We aim to push out a fix for this very shortly.\n" ]
https://api.github.com/repos/psf/requests/issues/2473
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2473/labels{/name}
https://api.github.com/repos/psf/requests/issues/2473/comments
https://api.github.com/repos/psf/requests/issues/2473/events
https://github.com/psf/requests/issues/2473
59,907,161
MDU6SXNzdWU1OTkwNzE2MQ==
2,473
requests can't detect the right charset
{ "avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4", "events_url": "https://api.github.com/users/gengjiawen/events{/privacy}", "followers_url": "https://api.github.com/users/gengjiawen/followers", "following_url": "https://api.github.com/users/gengjiawen/following{/other_user}", "gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gengjiawen", "id": 3759816, "login": "gengjiawen", "node_id": "MDQ6VXNlcjM3NTk4MTY=", "organizations_url": "https://api.github.com/users/gengjiawen/orgs", "received_events_url": "https://api.github.com/users/gengjiawen/received_events", "repos_url": "https://api.github.com/users/gengjiawen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions", "type": "User", "url": "https://api.github.com/users/gengjiawen", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-03-05T05:25:22Z
2021-09-08T23:05:57Z
2015-03-05T07:01:38Z
NONE
resolved
I write some code in python 3: ``` url = "http://www.kanunu8.com/book/3981/42775.html" r = requests.get(url) print(r.encoding) print(r.text) ``` from the html source code,it clearly state it's charset is gbk,but r.encoding is "ISO-8859-1". BTW,I can get the right html from urllib.request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2473/reactions" }
https://api.github.com/repos/psf/requests/issues/2473/timeline
null
completed
null
null
false
[ "Hi there!\n\nThis is a well known requests behaviour that is clearly documented. I answered this in a previous GitHub issue [here](https://github.com/kennethreitz/requests/issues/2122#issuecomment-48448778): please consult that answer.\n", "But the function`requests.utils.get_encodings_from_content` raise a exce...
https://api.github.com/repos/psf/requests/issues/2472
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2472/labels{/name}
https://api.github.com/repos/psf/requests/issues/2472/comments
https://api.github.com/repos/psf/requests/issues/2472/events
https://github.com/psf/requests/pull/2472
59,829,323
MDExOlB1bGxSZXF1ZXN0MzA0ODQ1NzU=
2,472
Avoid data duplication when creating a Request with str/bytes/bytearray input
{ "avatar_url": "https://avatars.githubusercontent.com/u/138657?v=4", "events_url": "https://api.github.com/users/scholer/events{/privacy}", "followers_url": "https://api.github.com/users/scholer/followers", "following_url": "https://api.github.com/users/scholer/following{/other_user}", "gists_url": "https://api.github.com/users/scholer/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/scholer", "id": 138657, "login": "scholer", "node_id": "MDQ6VXNlcjEzODY1Nw==", "organizations_url": "https://api.github.com/users/scholer/orgs", "received_events_url": "https://api.github.com/users/scholer/received_events", "repos_url": "https://api.github.com/users/scholer/repos", "site_admin": false, "starred_url": "https://api.github.com/users/scholer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scholer/subscriptions", "type": "User", "url": "https://api.github.com/users/scholer", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
{ "closed_at": "2015-04-06T01:57:33Z", "closed_issues": 4, "created_at": "2015-01-18T20:07:00Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }, "description": "", "due_on": null, "html_url": "https://github.com/psf/requests/milestone/23", "id": 940764, "labels_url": "https://api.github.com/repos/psf/requests/milestones/23/labels", "node_id": "MDk6TWlsZXN0b25lOTQwNzY0", "number": 23, "open_issues": 0, "state": "closed", "title": "2.6.0", "updated_at": "2015-04-06T01:57:33Z", "url": "https://api.github.com/repos/psf/requests/milestones/23" }
2
2015-03-04T17:13:10Z
2021-09-08T08:01:01Z
2015-03-14T12:43:18Z
CONTRIBUTOR
resolved
I've worked on the idea discussed in #2468 regarding avoiding duplicating the file data when creating a Request with files input that is str/bytes/bytearray and not a stream. The code currently creates a BytesIO or StringIO stream using the str/bytes/bytearray as initial input. This is then read out with fp.read() when creating a RequestField. The problem with this is that BytesIO and StringIO creates a copy of the input. Thus, if you have created a 100 MB file in memory using a bytearray which is used to create a Request, three identical copies is produced: _(1)_ The original bytearray, _(2)_ The BytesIO/StringIO object, which has its own copy, and _(3)_ The copy that is read out with fp.read() and stored in the RequestField object. If we instead of creating BytesIO/StringIO objects just pass the str/bytes/bytearray on to RequestField, we avoid making the two duplicates of the data. This yields a **30-40% performance improvement** for files larger than 5 MB when creating a Request. The end result is, as far as I've been able to tell, the same. I have created a GIST with my code for checking that the proposed change yield the same body as the old. It also has the code for evaluating performance and the results of the three ways I've compared the performance differences. https://gist.github.com/scholer/57fced2b63d1bb3130eb The tests in test_requests.py completes without failure on python 2.6 and 3.4. I don't believe any new tests are required, but let me know. **Question:** Is this really relevant? Why would you ever build a large file in memory? Large files are always read from disk or handled as some other stream. Answer: Some cloud storage services, e.g. Amazon AWS, relies on adding a "prefix" and "suffix" to the file content, which includes e.g. upload authorization tokens. You can build the file data using e.g. a BytesIO stream or a bytearray. The bytearray can be used through a memoryview, which supports Python's buffer protocol. This means that the file data can be inserted directly into the bytearray without extra memory overhead. ``` fp.readinto(mv[offset:offset+length]) ``` To my knowledge, it is not easy to read the content of one stream directly into another. For instance, appending a BytesIO with filecontent using fp.readinto(bytestream) # will fail since bytestream does not support the buffer interface Note: Although my tests says that the final body is the same with the new code as the old, I would still recommend that someone with more experience takes a look at this to make sure that it does not have any adverse effects. Thanks.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2472/reactions" }
https://api.github.com/repos/psf/requests/issues/2472/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2472.diff", "html_url": "https://github.com/psf/requests/pull/2472", "merged_at": "2015-03-14T12:43:17Z", "patch_url": "https://github.com/psf/requests/pull/2472.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2472" }
true
[ "Thanks for this!\n\nI can see no particular reason to be concerned about this patch, it seems totally reasonable to me. I'll obviously wait for @sigmavirus24 to hop in. It would also be extremely helpful to get someone who is deploying requests in anger to weigh in here.\n", "This looks fine but I'd like to test...
https://api.github.com/repos/psf/requests/issues/2471
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2471/labels{/name}
https://api.github.com/repos/psf/requests/issues/2471/comments
https://api.github.com/repos/psf/requests/issues/2471/events
https://github.com/psf/requests/issues/2471
59,803,770
MDU6SXNzdWU1OTgwMzc3MA==
2,471
duplicated headers are lost
{ "avatar_url": "https://avatars.githubusercontent.com/u/3345886?v=4", "events_url": "https://api.github.com/users/wesnm/events{/privacy}", "followers_url": "https://api.github.com/users/wesnm/followers", "following_url": "https://api.github.com/users/wesnm/following{/other_user}", "gists_url": "https://api.github.com/users/wesnm/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/wesnm", "id": 3345886, "login": "wesnm", "node_id": "MDQ6VXNlcjMzNDU4ODY=", "organizations_url": "https://api.github.com/users/wesnm/orgs", "received_events_url": "https://api.github.com/users/wesnm/received_events", "repos_url": "https://api.github.com/users/wesnm/repos", "site_admin": false, "starred_url": "https://api.github.com/users/wesnm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wesnm/subscriptions", "type": "User", "url": "https://api.github.com/users/wesnm", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-04T14:22:12Z
2021-09-08T23:05:57Z
2015-03-04T14:23:07Z
NONE
resolved
With the upgrade to 2.5.3, my application suddenly broke. I've tracked it down to a loss of headers. The response includes two "WWW-Authenticate" headers, but only one is returned in the header list. This appears to be a urllib3 bug.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2471/reactions" }
https://api.github.com/repos/psf/requests/issues/2471/timeline
null
completed
null
null
false
[ "Please file this against [urllib3](/shazow/urllib3) then.\n" ]
https://api.github.com/repos/psf/requests/issues/2470
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2470/labels{/name}
https://api.github.com/repos/psf/requests/issues/2470/comments
https://api.github.com/repos/psf/requests/issues/2470/events
https://github.com/psf/requests/issues/2470
59,646,646
MDU6SXNzdWU1OTY0NjY0Ng==
2,470
Unable to import requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/417478?v=4", "events_url": "https://api.github.com/users/xZise/events{/privacy}", "followers_url": "https://api.github.com/users/xZise/followers", "following_url": "https://api.github.com/users/xZise/following{/other_user}", "gists_url": "https://api.github.com/users/xZise/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/xZise", "id": 417478, "login": "xZise", "node_id": "MDQ6VXNlcjQxNzQ3OA==", "organizations_url": "https://api.github.com/users/xZise/orgs", "received_events_url": "https://api.github.com/users/xZise/received_events", "repos_url": "https://api.github.com/users/xZise/repos", "site_admin": false, "starred_url": "https://api.github.com/users/xZise/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xZise/subscriptions", "type": "User", "url": "https://api.github.com/users/xZise", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-03-03T14:12:47Z
2021-09-08T23:05:58Z
2015-03-04T13:49:12Z
NONE
resolved
Hi on [Travis](https://travis-ci.org/wikimedia/pywikibot-core/jobs/52812789#L742) our bot is unable to import requests 2.5.3 properly on Python 2.7 and 2.6: ``` File "/home/travis/build/wikimedia/pywikibot-core/.eggs/flickrapi-2.0-py2.7.egg/flickrapi/__init__.py", line 52, in <module> File "/home/travis/build/wikimedia/pywikibot-core/.eggs/flickrapi-2.0-py2.7.egg/flickrapi/core.py", line 13, in <module> File "/home/travis/build/wikimedia/pywikibot-core/.eggs/flickrapi-2.0-py2.7.egg/flickrapi/tokencache.py", line 10, in <module> File "/home/travis/build/wikimedia/pywikibot-core/.eggs/flickrapi-2.0-py2.7.egg/flickrapi/auth.py", line 23, in <module> File "build/bdist.linux-x86_64/egg/requests_toolbelt/__init__.py", line 19, in <module> File "build/bdist.linux-x86_64/egg/requests_toolbelt/adapters/__init__.py", line 12, in <module> File "build/bdist.linux-x86_64/egg/requests_toolbelt/adapters/ssl.py", line 12, in <module> SSLError -- exception raised for I/O errors File "/home/travis/build/wikimedia/pywikibot-core/.eggs/requests-2.5.3-py2.7.egg/requests/__init__.py", line 53, in <module> from .packages.urllib3.contrib import pyopenssl File "/tmp/easy_install-uogHkP/requests-2.5.3/requests/packages/__init__.py", line 49, in load_module ``` It seems that this only happened recently. [This run](https://travis-ci.org/wikimedia/pywikibot-core/jobs/51751467#L478) worked fine with 2.5.1. Locally I could install flickapi (2.0) and requests (2.5.3) and import them without problems on Python 2.7.8.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2470/reactions" }
https://api.github.com/repos/psf/requests/issues/2470/timeline
null
completed
null
null
false
[ "Thanks for the report!\n\nThis is a known regression in 2.5.2 and 2.5.3, with a fix being tracked under #2466.\n" ]
https://api.github.com/repos/psf/requests/issues/2469
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2469/labels{/name}
https://api.github.com/repos/psf/requests/issues/2469/comments
https://api.github.com/repos/psf/requests/issues/2469/events
https://github.com/psf/requests/issues/2469
59,631,918
MDU6SXNzdWU1OTYzMTkxOA==
2,469
RuntimeWarning when using eventlet for patching requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/5242977?v=4", "events_url": "https://api.github.com/users/imazor/events{/privacy}", "followers_url": "https://api.github.com/users/imazor/followers", "following_url": "https://api.github.com/users/imazor/following{/other_user}", "gists_url": "https://api.github.com/users/imazor/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/imazor", "id": 5242977, "login": "imazor", "node_id": "MDQ6VXNlcjUyNDI5Nzc=", "organizations_url": "https://api.github.com/users/imazor/orgs", "received_events_url": "https://api.github.com/users/imazor/received_events", "repos_url": "https://api.github.com/users/imazor/repos", "site_admin": false, "starred_url": "https://api.github.com/users/imazor/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/imazor/subscriptions", "type": "User", "url": "https://api.github.com/users/imazor", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-03-03T11:58:19Z
2018-04-23T14:41:55Z
2015-03-03T15:32:27Z
NONE
resolved
Hi, I am getting the following warning while using requests with eventlet: /usr/local/lib/python2.7/site-packages/requests/utils.py:74: RuntimeWarning: Parent module 'requests' not found while handling absolute import from netrc import netrc, NetrcParseError looking in the issue below that have similar warning https://github.com/kennethreitz/requests/issues/2014 could it be that it related to the fact (if I am not wrong) that during the eventlet patching, requests removed from the sys.path. from the eventlet docs: http://web.archive.org/web/20110723123938/http://www.eventlet.net/doc/patching.html#monkeypatching-the-standard-library eventlet.patcher.import_patched(module_name, _additional_modules, *_kw_additional_modules) Imports a module in a greened manner, so that the module’s use of networking libraries like socket will use Eventlet’s green versions instead. The only required argument is the name of the module to be imported: import eventlet httplib2 = eventlet.import_patched('httplib2') Under the hood, it works by temporarily swapping out the “normal” versions of the libraries in sys.modules for an eventlet.green equivalent. When the import of the to-be-patched module completes, the state of sys.modules is restored. Therefore, if the patched module contains the statement ‘import socket’, import_patched will have it reference eventlet.green.socket. One weakness of this approach is that it doesn’t work for late binding (i.e. imports that happen during runtime). Late binding of imports is fortunately rarely done (it’s slow and against PEP-8), so in most cases import_patched will work just fine. so I just want to verify the the warning is ok (because looks that the patched version of requests works quite fine)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2469/reactions" }
https://api.github.com/repos/psf/requests/issues/2469/timeline
null
completed
null
null
false
[ "eventlet shouldn't be affecting the import of netrc. I'm also not certain if eventlet has special case handling for requests. All eventlet should be patching is socket or httplib (or both) as far as I know, so this seems like a bug for eventlet, not us. I don't use eventlet with requests, nor does @Lukasa so neith...
https://api.github.com/repos/psf/requests/issues/2468
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2468/labels{/name}
https://api.github.com/repos/psf/requests/issues/2468/comments
https://api.github.com/repos/psf/requests/issues/2468/events
https://github.com/psf/requests/pull/2468
59,588,521
MDExOlB1bGxSZXF1ZXN0MzAzNDMwNDI=
2,468
Support for bytearray when creating Request with files argument, just like str and bytes.
{ "avatar_url": "https://avatars.githubusercontent.com/u/138657?v=4", "events_url": "https://api.github.com/users/scholer/events{/privacy}", "followers_url": "https://api.github.com/users/scholer/followers", "following_url": "https://api.github.com/users/scholer/following{/other_user}", "gists_url": "https://api.github.com/users/scholer/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/scholer", "id": 138657, "login": "scholer", "node_id": "MDQ6VXNlcjEzODY1Nw==", "organizations_url": "https://api.github.com/users/scholer/orgs", "received_events_url": "https://api.github.com/users/scholer/received_events", "repos_url": "https://api.github.com/users/scholer/repos", "site_admin": false, "starred_url": "https://api.github.com/users/scholer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scholer/subscriptions", "type": "User", "url": "https://api.github.com/users/scholer", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-03-03T03:07:04Z
2021-09-08T08:01:07Z
2015-03-03T20:01:31Z
CONTRIBUTOR
resolved
When creating a Request with files argument, the "fp" part of a file entry can currently be either (a) a str, (b) a bytes, or (c) any other object that has a .read() method that returns data. For str or bytes, StringIO or ByteIO wrapper-objects are created. When building data in-memory, a bytearray is often more convenient and memory efficient compared to immutable bytes. This simple change allows models.RequestEncodingMixin._encode_files method to use bytearray as fp in addition to the currently supported bytes and str input. This means that users do not have to worry about creating a ByteIO object. I've seen requests users creating bytes-objects from bytearrays before passing it to requests. This, of course, doubles the memory consumption and is completely unnecessary. Yes, the correct approach from the user's side would be to create a ByteIO object (instead of bytes). But not all users seem to be aware of this. Letting requests take bytearrays means that it would "just work", when the user passes these to requests, and thus avoids the potential pitfall where a user just says "requests chokes on bytearrays, so convert to str." (Actual comment from pyzotero, a principal python client module to consume Zotero's REST API). I'm not sure if this simple change requires it's own test, but I've added one just in case. It also tests for bytes objects, which was not covered by the existing test, test_can_send_nonstring_objects_with_files. Perhaps I should just expand test_can_send_nonstring_objects_with_files to also cover bytes and bytearray? It currently only covers str (which are, of course, also bytes in python 2). The test suite currently does fail in TestMorselToCookieExpires.test_expires_valid_str; however this is unrelated to this change and was also failing before, in commit 461b740d. Compatability: bytearray and the byte literal (used in the test) are both available in python 2.6 and forward. Let me know if there is anything else that you would need in order to accept this pull request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2468/reactions" }
https://api.github.com/repos/psf/requests/issues/2468/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2468.diff", "html_url": "https://github.com/psf/requests/pull/2468", "merged_at": "2015-03-03T20:01:31Z", "patch_url": "https://github.com/psf/requests/pull/2468.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2468" }
true
[ "This looks great, I see no reason not to merge this. :cake:\n\n@sigmavirus24, I'll let you pull the trigger.\n", "After further thought, I'm thinking maybe it would be better to just use the str/bytes/bytearray object that the user provided directly? This would cut the number of in-memory file data copies from 3...
https://api.github.com/repos/psf/requests/issues/2467
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2467/labels{/name}
https://api.github.com/repos/psf/requests/issues/2467/comments
https://api.github.com/repos/psf/requests/issues/2467/events
https://github.com/psf/requests/issues/2467
59,567,494
MDU6SXNzdWU1OTU2NzQ5NA==
2,467
timeout issues for chunked responses
{ "avatar_url": "https://avatars.githubusercontent.com/u/939977?v=4", "events_url": "https://api.github.com/users/zsalzbank/events{/privacy}", "followers_url": "https://api.github.com/users/zsalzbank/followers", "following_url": "https://api.github.com/users/zsalzbank/following{/other_user}", "gists_url": "https://api.github.com/users/zsalzbank/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zsalzbank", "id": 939977, "login": "zsalzbank", "node_id": "MDQ6VXNlcjkzOTk3Nw==", "organizations_url": "https://api.github.com/users/zsalzbank/orgs", "received_events_url": "https://api.github.com/users/zsalzbank/received_events", "repos_url": "https://api.github.com/users/zsalzbank/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zsalzbank/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zsalzbank/subscriptions", "type": "User", "url": "https://api.github.com/users/zsalzbank", "user_view_type": "public" }
[]
closed
true
null
[]
null
41
2015-03-02T23:11:27Z
2021-09-08T23:05:58Z
2015-03-03T18:12:39Z
NONE
resolved
When I set a timeout value for my simple GET request, the `requests.get` call takes a really long time to complete when I don't iterate over the returned content. If I iterate over the content, the `requests.get` call comes back very quickly. I've delved pretty deep into the requests source code and can't figure out what the issue is. Here is a test case to illustrate my issue: https://gist.github.com/zsalzbank/90ebcaaf94f6c34e9559 What I would expect to happen is that the non-streamed and non-iterated responses would return just as quickly as all the other tests, but instead, they take 25x longer. When the timeout is removed, the responses come back quickly as well. From my understanding of the timeout parameter, it is only timing out for the initial data response from the server. I know that some data comes back quickly because I modified the requests library and printed out the data as soon as it comes back (added a `print` after this line: https://github.com/kennethreitz/requests/blob/master/requests/models.py#L655). What is going on here? Am I doing something wrong on the server side? I know that no `Content-Length` comes back from the server, but `Connection: close` does come back. I'm not sure if this is related to #1041 (it sounds similar).
{ "avatar_url": "https://avatars.githubusercontent.com/u/939977?v=4", "events_url": "https://api.github.com/users/zsalzbank/events{/privacy}", "followers_url": "https://api.github.com/users/zsalzbank/followers", "following_url": "https://api.github.com/users/zsalzbank/following{/other_user}", "gists_url": "https://api.github.com/users/zsalzbank/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zsalzbank", "id": 939977, "login": "zsalzbank", "node_id": "MDQ6VXNlcjkzOTk3Nw==", "organizations_url": "https://api.github.com/users/zsalzbank/orgs", "received_events_url": "https://api.github.com/users/zsalzbank/received_events", "repos_url": "https://api.github.com/users/zsalzbank/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zsalzbank/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zsalzbank/subscriptions", "type": "User", "url": "https://api.github.com/users/zsalzbank", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2467/reactions" }
https://api.github.com/repos/psf/requests/issues/2467/timeline
null
completed
null
null
false
[ "Can you post your values? Because I don't see this at all:\n\nT=10, stream iter took: 0.515799999237\nT=10, stream all took: 0.428910970688\nT=10, no stream took: 0.423730134964\nT=None, stream iter took: 0.422012805939\nT=None, stream all took: 0.445449113846\nT=None, no stream took: 0.433798074722\n", "Oh _hey...
https://api.github.com/repos/psf/requests/issues/2466
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2466/labels{/name}
https://api.github.com/repos/psf/requests/issues/2466/comments
https://api.github.com/repos/psf/requests/issues/2466/events
https://github.com/psf/requests/pull/2466
59,348,333
MDExOlB1bGxSZXF1ZXN0MzAyMjY4NjI=
2,466
Only add VendorAliases for vendored dependencies
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
9
2015-02-28T16:53:27Z
2021-09-08T08:01:06Z
2015-03-04T13:49:12Z
CONTRIBUTOR
resolved
Closes #2465 Closes #2470 /cc @dstufft Let me know if I should send this to pip as well
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2466/reactions" }
https://api.github.com/repos/psf/requests/issues/2466/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2466.diff", "html_url": "https://github.com/psf/requests/pull/2466", "merged_at": "2015-03-04T13:49:12Z", "patch_url": "https://github.com/psf/requests/pull/2466.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2466" }
true
[ "I was doing some other work and a few corner cases popped into my head that this breaks. Previously the following would break\n\n``` py\nfrom requests.packages import sys\nfrom requests.packages.chardet import os\n```\n\nNow they'll happily succeed. \n", "I would be so much more comfortable if we weren't relying...
https://api.github.com/repos/psf/requests/issues/2465
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2465/labels{/name}
https://api.github.com/repos/psf/requests/issues/2465/comments
https://api.github.com/repos/psf/requests/issues/2465/events
https://github.com/psf/requests/issues/2465
59,286,371
MDU6SXNzdWU1OTI4NjM3MQ==
2,465
Issue with pyinstaller
{ "avatar_url": "https://avatars.githubusercontent.com/u/6761036?v=4", "events_url": "https://api.github.com/users/gRanger777/events{/privacy}", "followers_url": "https://api.github.com/users/gRanger777/followers", "following_url": "https://api.github.com/users/gRanger777/following{/other_user}", "gists_url": "https://api.github.com/users/gRanger777/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gRanger777", "id": 6761036, "login": "gRanger777", "node_id": "MDQ6VXNlcjY3NjEwMzY=", "organizations_url": "https://api.github.com/users/gRanger777/orgs", "received_events_url": "https://api.github.com/users/gRanger777/received_events", "repos_url": "https://api.github.com/users/gRanger777/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gRanger777/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gRanger777/subscriptions", "type": "User", "url": "https://api.github.com/users/gRanger777", "user_view_type": "public" }
[]
closed
true
null
[]
null
20
2015-02-27T20:01:10Z
2021-09-08T15:00:39Z
2015-04-06T11:19:15Z
NONE
resolved
Can't seem to wrap my head around this. having a problem compiling a windows exe in python 2.7.9 that uses the requests library and can't find anything on google about the specific error. My script runs fine from the interpreter but when i use pyinstaller, i get :ImportError: No module named 'requests.packages.chardet.sys' I can also compile windows executables that don't use requests just fine. ``` ###Sample Script ----------------Begin #!/usr/bin/python import requests r = requests.get('https://google.com') print(r.text) ----------------End ###command run to compile into windows exe ---------------Begin pyinstaller --onefile test.py OR pyinstaller test.py ---------------End ###Output ---------------Begin C:\Python27>pyinstaller test.py 76 INFO: wrote C:\Python27\test.spec 102 INFO: Testing for ability to set icons, version resources... 125 INFO: ... resource update available 129 INFO: UPX is not available. 164 INFO: Processing hook hook-os 409 INFO: Processing hook hook-time 417 INFO: Processing hook hook-cPickle 536 INFO: Processing hook hook-_sre 773 INFO: Processing hook hook-cStringIO 944 INFO: Processing hook hook-encodings 965 INFO: Processing hook hook-codecs 1687 INFO: Extending PYTHONPATH with C:\Python27 1687 INFO: checking Analysis 1687 INFO: Building Analysis because out00-Analysis.toc non existent 1688 INFO: running Analysis out00-Analysis.toc 1690 INFO: Adding Microsoft.VC90.CRT to dependent assemblies of final executable 1781 INFO: Searching for assembly x86_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21 022.8_none ... 1782 WARNING: Assembly not found 1782 ERROR: Assembly x86_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21022.8_none no t found 1954 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\python.exe 2039 INFO: Searching for assembly x86_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21 022.8_none ... 2040 WARNING: Assembly not found 2042 ERROR: Assembly x86_Microsoft.VC90.CRT_1fc8b3b9a1e18e3b_9.0.21022.8_none no t found 2263 WARNING: lib not found: MSVCR90.dll dependency of C:\Windows\system32\pytho n27.dll 2266 INFO: Analyzing C:\Python27\lib\site-packages\pyinstaller-2.1.1.dev0-py2.7. egg\PyInstaller\loader\_pyi_bootstrap.py 2284 INFO: Processing hook hook-os 2309 INFO: Processing hook hook-site 2339 INFO: Processing hook hook-encodings 2582 INFO: Processing hook hook-time 2590 INFO: Processing hook hook-cPickle 2715 INFO: Processing hook hook-_sre 2975 INFO: Processing hook hook-cStringIO 3164 INFO: Processing hook hook-codecs 3907 INFO: Processing hook hook-pydoc 4185 INFO: Processing hook hook-email 4309 INFO: Processing hook hook-httplib 4368 INFO: Processing hook hook-email.message 4517 INFO: Analyzing C:\Python27\lib\site-packages\pyinstaller-2.1.1.dev0-py2.7. egg\PyInstaller\loader\pyi_importers.py 4690 INFO: Analyzing C:\Python27\lib\site-packages\pyinstaller-2.1.1.dev0-py2.7. egg\PyInstaller\loader\pyi_archive.py 4865 INFO: Analyzing C:\Python27\lib\site-packages\pyinstaller-2.1.1.dev0-py2.7. egg\PyInstaller\loader\pyi_carchive.py 5040 INFO: Analyzing C:\Python27\lib\site-packages\pyinstaller-2.1.1.dev0-py2.7. egg\PyInstaller\loader\pyi_os_path.py 5069 INFO: Analyzing test.py 6014 INFO: Processing hook hook-requests 7263 INFO: Processing hook hook-xml 7445 INFO: Processing hook hook-xml.sax 7516 INFO: Processing hook hook-pyexpat 7646 INFO: Hidden import 'codecs' has been found otherwise 7648 INFO: Hidden import 'encodings' has been found otherwise 7648 INFO: Looking for run-time hooks 7830 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\lib\site-pack ages\win32\win32pipe.pyd 7987 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\select.p yd 8144 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\unicoded ata.pyd 8319 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\lib\site-pack ages\win32\win32wnet.pyd 8501 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\_hashlib .pyd 8671 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\bz2.pyd 8859 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\_ssl.pyd 9052 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\_ctypes. pyd 9223 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\pyexpat. pyd 9460 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\lib\site-pack ages\win32\win32api.pyd 9632 WARNING: lib not found: MSVCR90.dll dependency of C:\Python27\DLLs\_socket. pyd 9828 WARNING: lib not found: MSVCR90.dll dependency of C:\Windows\system32\pywin types27.dll 9848 INFO: Using Python library C:\Windows\system32\python27.dll 10016 INFO: Warnings written to C:\Python27\build\test\warntest.txt 10023 INFO: checking PYZ 10023 INFO: Rebuilding out00-PYZ.toc because out00-PYZ.pyz is missing 10024 INFO: Building PYZ (ZlibArchive) out00-PYZ.toc 12259 INFO: checking PKG 12261 INFO: Rebuilding out00-PKG.toc because out00-PKG.pkg is missing 12261 INFO: Building PKG (CArchive) out00-PKG.pkg 12286 INFO: checking EXE 12287 INFO: Rebuilding out00-EXE.toc because test.exe missing 12289 INFO: Building EXE from out00-EXE.toc 12292 INFO: Appending archive to EXE C:\Python27\build\test\test.exe 12296 INFO: checking COLLECT 12296 INFO: Building COLLECT out00-COLLECT.toc ---------------End ###What happens when running the executable ---------------Begin C:\Users\gRanger\Desktop\dist\test>test.exe Traceback (most recent call last): File "<string>", line 3, in <module> File "c:\python27\lib\site-packages\PyInstaller-2.1.1.dev0-py2.7.egg\PyInstall er\loader\pyi_importers.py", line 276, in load_module exec(bytecode, module.__dict__) File "C:\Users\gRanger\Desktop\build\test\out00-PYZ.pyz\requests", line 58, in <module> File "c:\python27\lib\site-packages\PyInstaller-2.1.1.dev0-py2.7.egg\PyInstall er\loader\pyi_importers.py", line 276, in load_module exec(bytecode, module.__dict__) File "C:\Users\gRanger\Desktop\build\test\out00-PYZ.pyz\requests.utils", line 26, in <module> File "c:\python27\lib\site-packages\PyInstaller-2.1.1.dev0-py2.7.egg\PyInstall er\loader\pyi_importers.py", line 276, in load_module exec(bytecode, module.__dict__) File "C:\Users\gRanger\Desktop\build\test\out00-PYZ.pyz\requests.compat", line 7, in <module> File "c:\python27\lib\site-packages\PyInstaller-2.1.1.dev0-py2.7.egg\PyInstall er\loader\pyi_importers.py", line 276, in load_module exec(bytecode, module.__dict__) File "C:\Users\gRanger\Desktop\build\test\out00-PYZ.pyz\requests.packages.char det", line 19, in <module> File "C:\Users\gRanger\Desktop\build\test\out00-PYZ.pyz\requests.packages", li ne 83, in load_module ImportError: No module named 'requests.packages.chardet.sys' ---------------End ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2465/reactions" }
https://api.github.com/repos/psf/requests/issues/2465/timeline
null
completed
null
null
false
[ "So it looks like pyinstaller isn't detecting an import of the standard library's `sys` module even though it finds `httplib`, `os` and others. You should see if anyone on [StackOverflow](https://stackoverflow.com) can help you with this (or if this is a bug in pyinstaller). It's certainly not a bug in requests tho...
https://api.github.com/repos/psf/requests/issues/2464
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2464/labels{/name}
https://api.github.com/repos/psf/requests/issues/2464/comments
https://api.github.com/repos/psf/requests/issues/2464/events
https://github.com/psf/requests/issues/2464
59,223,589
MDU6SXNzdWU1OTIyMzU4OQ==
2,464
Multiple requests suggested way
{ "avatar_url": "https://avatars.githubusercontent.com/u/4975761?v=4", "events_url": "https://api.github.com/users/nsorros/events{/privacy}", "followers_url": "https://api.github.com/users/nsorros/followers", "following_url": "https://api.github.com/users/nsorros/following{/other_user}", "gists_url": "https://api.github.com/users/nsorros/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/nsorros", "id": 4975761, "login": "nsorros", "node_id": "MDQ6VXNlcjQ5NzU3NjE=", "organizations_url": "https://api.github.com/users/nsorros/orgs", "received_events_url": "https://api.github.com/users/nsorros/received_events", "repos_url": "https://api.github.com/users/nsorros/repos", "site_admin": false, "starred_url": "https://api.github.com/users/nsorros/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nsorros/subscriptions", "type": "User", "url": "https://api.github.com/users/nsorros", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-27T11:20:25Z
2021-09-08T23:05:58Z
2015-02-27T12:58:17Z
NONE
resolved
Hi, I am trying to do multiple requests without having to wait for each one to finish. I was using grequests but i am wondering if there is a better way to handle it.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2464/reactions" }
https://api.github.com/repos/psf/requests/issues/2464/timeline
null
completed
null
null
false
[ "grequests is the best way to handle it at the moment if you like using gevent. Your other options are [trequests](https://github.com/1stvamp/trequests), [treq](https://github.com/dreid/treq), [async-requests](https://github.com/inglesp/async-requests), and there are likely some others floating around that I don't ...
https://api.github.com/repos/psf/requests/issues/2463
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2463/labels{/name}
https://api.github.com/repos/psf/requests/issues/2463/comments
https://api.github.com/repos/psf/requests/issues/2463/events
https://github.com/psf/requests/issues/2463
59,156,605
MDU6SXNzdWU1OTE1NjYwNQ==
2,463
Ampersand (&) added for no reason?
{ "avatar_url": "https://avatars.githubusercontent.com/u/100194?v=4", "events_url": "https://api.github.com/users/GAZ082/events{/privacy}", "followers_url": "https://api.github.com/users/GAZ082/followers", "following_url": "https://api.github.com/users/GAZ082/following{/other_user}", "gists_url": "https://api.github.com/users/GAZ082/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/GAZ082", "id": 100194, "login": "GAZ082", "node_id": "MDQ6VXNlcjEwMDE5NA==", "organizations_url": "https://api.github.com/users/GAZ082/orgs", "received_events_url": "https://api.github.com/users/GAZ082/received_events", "repos_url": "https://api.github.com/users/GAZ082/repos", "site_admin": false, "starred_url": "https://api.github.com/users/GAZ082/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GAZ082/subscriptions", "type": "User", "url": "https://api.github.com/users/GAZ082", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-02-26T22:41:58Z
2021-09-08T23:05:59Z
2015-02-27T02:01:04Z
NONE
resolved
Hi guys, could you confirm if this is a bug or works as intended? ``` python import requests import json url = "http://server:8080/jsonrpc?request="; headers = {'content-type': 'application/json'}; payload = {blah}; r = requests.get(url, params=json.dumps(payload), headers=headers); print(r.url); ``` It outputs the encoded string BUT for no reason adds an ampersand as below: http://server:8080/jsonrpc?request=**&**{blah} This provokes parse errors when querying XBMC/KODI server. Thanks!
{ "avatar_url": "https://avatars.githubusercontent.com/u/100194?v=4", "events_url": "https://api.github.com/users/GAZ082/events{/privacy}", "followers_url": "https://api.github.com/users/GAZ082/followers", "following_url": "https://api.github.com/users/GAZ082/following{/other_user}", "gists_url": "https://api.github.com/users/GAZ082/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/GAZ082", "id": 100194, "login": "GAZ082", "node_id": "MDQ6VXNlcjEwMDE5NA==", "organizations_url": "https://api.github.com/users/GAZ082/orgs", "received_events_url": "https://api.github.com/users/GAZ082/received_events", "repos_url": "https://api.github.com/users/GAZ082/repos", "site_admin": false, "starred_url": "https://api.github.com/users/GAZ082/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GAZ082/subscriptions", "type": "User", "url": "https://api.github.com/users/GAZ082", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2463/reactions" }
https://api.github.com/repos/psf/requests/issues/2463/timeline
null
completed
null
null
false
[ "It is indeed working as intended.\n\nThe problem is this: we have no real way of knowing what you mean when you provide part of the query string as part of the URL and part in the 'params' section. You're doing something particularly unexpected by passing parameters as a string rather than a mapping (though I susp...
https://api.github.com/repos/psf/requests/issues/2462
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2462/labels{/name}
https://api.github.com/repos/psf/requests/issues/2462/comments
https://api.github.com/repos/psf/requests/issues/2462/events
https://github.com/psf/requests/issues/2462
59,059,558
MDU6SXNzdWU1OTA1OTU1OA==
2,462
Error in `requests.packages.__init__` (version > 2.5.1)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1850488?v=4", "events_url": "https://api.github.com/users/p-p-m/events{/privacy}", "followers_url": "https://api.github.com/users/p-p-m/followers", "following_url": "https://api.github.com/users/p-p-m/following{/other_user}", "gists_url": "https://api.github.com/users/p-p-m/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/p-p-m", "id": 1850488, "login": "p-p-m", "node_id": "MDQ6VXNlcjE4NTA0ODg=", "organizations_url": "https://api.github.com/users/p-p-m/orgs", "received_events_url": "https://api.github.com/users/p-p-m/received_events", "repos_url": "https://api.github.com/users/p-p-m/repos", "site_admin": false, "starred_url": "https://api.github.com/users/p-p-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/p-p-m/subscriptions", "type": "User", "url": "https://api.github.com/users/p-p-m", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
8
2015-02-26T11:36:49Z
2021-09-08T23:05:54Z
2015-03-14T11:20:33Z
NONE
resolved
After update to requests 2.5.3 in my project I got such error. ``` File "/home/pavel/Python/projects/myproject/requests-2.5.3-py2.7.egg/requests/__init__.py", line 53, in <module> from .packages.urllib3.contrib import pyopenssl File "/tmp/easy_install-NUp7Qp/requests-2.5.3/requests/packages/__init__.py", line 49, in load_module AttributeError: 'NoneType' object has no attribute 'modules' Error in atexit._run_exitfuncs: Traceback (most recent call last): File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/usr/lib/python2.7/multiprocessing/util.py", line 284, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable Error in sys.exitfunc: Traceback (most recent call last): File "/usr/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/usr/lib/python2.7/multiprocessing/util.py", line 284, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable ``` As I understand it occurs because of adding copy of pip's machinery (https://github.com/kennethreitz/requests/commit/d61540551943df57aa0dece5e44e130309dcafec)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2462/reactions" }
https://api.github.com/repos/psf/requests/issues/2462/timeline
null
completed
null
null
false
[ "This isn't a bug in requests. [`sys.modules`](https://github.com/kennethreitz/requests/blob/461b740db6ae3d3ab1c5d975b657307f5c630fcb/requests/packages/__init__.py#L49) is something we should be able to expect to exist reasonably. The problem is that you're using multiprocessing and it is doing something bizarre to...
https://api.github.com/repos/psf/requests/issues/2461
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2461/labels{/name}
https://api.github.com/repos/psf/requests/issues/2461/comments
https://api.github.com/repos/psf/requests/issues/2461/events
https://github.com/psf/requests/issues/2461
59,025,589
MDU6SXNzdWU1OTAyNTU4OQ==
2,461
Import Error: Cannot import name certs - Second time onwards!
{ "avatar_url": "https://avatars.githubusercontent.com/u/1830169?v=4", "events_url": "https://api.github.com/users/rtindru/events{/privacy}", "followers_url": "https://api.github.com/users/rtindru/followers", "following_url": "https://api.github.com/users/rtindru/following{/other_user}", "gists_url": "https://api.github.com/users/rtindru/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rtindru", "id": 1830169, "login": "rtindru", "node_id": "MDQ6VXNlcjE4MzAxNjk=", "organizations_url": "https://api.github.com/users/rtindru/orgs", "received_events_url": "https://api.github.com/users/rtindru/received_events", "repos_url": "https://api.github.com/users/rtindru/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rtindru/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rtindru/subscriptions", "type": "User", "url": "https://api.github.com/users/rtindru", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-26T06:16:36Z
2021-09-08T23:05:59Z
2015-02-26T15:25:27Z
NONE
resolved
``` In [1]: import requests --------------------------------------------------------------------------- ImportError Traceback (most recent call last) /usr/local/python2.7/lib/python2.7/site-packages/Django-1.3.4-py2.7.egg/django/core/management/commands/shell.pyc in <module>() ----> 1 import requests /usr/local/python2.7/lib/python2.7/site-packages/requests/__init__.py in <module>() 56 pass 57 ---> 58 from . import utils 59 from .models import Request, Response, PreparedRequest 60 from .api import request, get, head, post, patch, put, delete, options /usr/local/python2.7/lib/python2.7/site-packages/requests/utils.py in <module>() 23 from . import __version__ 24 from . import certs ---> 25 from .compat import parse_http_list as _parse_list_header 26 from .compat import (quote, urlparse, bytes, str, OrderedDict, unquote, is_py2, 27 builtin_str, getproxies, proxy_bypass) /usr/local/python2.7/lib/python2.7/site-packages/requests/compat.py in <module>() 5 """ 6 ----> 7 from .packages import chardet 8 9 import sys /usr/local/python2.7/lib/python2.7/site-packages/requests/packages/__init__.py in <module>() 1 from __future__ import absolute_import 2 ----> 3 from . import urllib3 /usr/local/python2.7/lib/python2.7/site-packages/requests/packages/urllib3/__init__.py in <module>() 14 15 ---> 16 from .connectionpool import ( 17 HTTPConnectionPool, 18 HTTPSConnectionPool, /usr/local/python2.7/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py in <module>() 14 from queue import LifoQueue, Empty, Full 15 except ImportError: ---> 16 from Queue import LifoQueue, Empty, Full 17 import Queue as _ # Platform-specific: Windows 18 ImportError: cannot import name LifoQueue In [2]: import requests --------------------------------------------------------------------------- ImportError Traceback (most recent call last) /usr/local/python2.7/lib/python2.7/site-packages/Django-1.3.4-py2.7.egg/django/core/management/commands/shell.pyc in <module>() ----> 1 import requests /usr/local/python2.7/lib/python2.7/site-packages/requests/__init__.py in <module>() 56 pass 57 ---> 58 from . import utils 59 from .models import Request, Response, PreparedRequest 60 from .api import request, get, head, post, patch, put, delete, options /usr/local/python2.7/lib/python2.7/site-packages/requests/utils.py in <module>() 22 23 from . import __version__ ---> 24 from . import certs 25 from .compat import parse_http_list as _parse_list_header 26 from .compat import (quote, urlparse, bytes, str, OrderedDict, unquote, is_py2, ImportError: cannot import name certs ``` I have a module Queue that mirrors python's default Queue. This is why the LifoQueue import fails. But having failed there the first time, every successive import of requests fails at 'Cannot import certs' which I find bizarre! Also, I have not fixed the Queue conflict. Just want to know why the import error is different for the first time and the successive times are all some cert error! ![error_rep](https://cloud.githubusercontent.com/assets/1830169/6387200/16bdd6fe-bdad-11e4-96a7-d197769fd10c.png)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2461/reactions" }
https://api.github.com/repos/psf/requests/issues/2461/timeline
null
completed
null
null
false
[ "This isn't a bug in requests. If you want to know why the import machinery is working this way, you should as on python-list or StackOverflow\n" ]
https://api.github.com/repos/psf/requests/issues/2460
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2460/labels{/name}
https://api.github.com/repos/psf/requests/issues/2460/comments
https://api.github.com/repos/psf/requests/issues/2460/events
https://github.com/psf/requests/issues/2460
58,811,630
MDU6SXNzdWU1ODgxMTYzMA==
2,460
Import requests library troubleshooting
{ "avatar_url": "https://avatars.githubusercontent.com/u/3380261?v=4", "events_url": "https://api.github.com/users/theasder/events{/privacy}", "followers_url": "https://api.github.com/users/theasder/followers", "following_url": "https://api.github.com/users/theasder/following{/other_user}", "gists_url": "https://api.github.com/users/theasder/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/theasder", "id": 3380261, "login": "theasder", "node_id": "MDQ6VXNlcjMzODAyNjE=", "organizations_url": "https://api.github.com/users/theasder/orgs", "received_events_url": "https://api.github.com/users/theasder/received_events", "repos_url": "https://api.github.com/users/theasder/repos", "site_admin": false, "starred_url": "https://api.github.com/users/theasder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/theasder/subscriptions", "type": "User", "url": "https://api.github.com/users/theasder", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2015-02-24T21:53:07Z
2021-09-08T23:05:59Z
2015-02-25T19:43:08Z
NONE
resolved
Requests was installed via python3 -m pip install requests. Importing library was used to work well. But suddenly, it started to show me an error: ``` $ python3 Python 3.4.2 (v3.4.2:ab2c023a9432, Oct 5 2014, 20:42:22) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import requests Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.5.3-py3.4.egg/requests/__init__.py", line 58, in <module> from . import utils File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.5.3-py3.4.egg/requests/utils.py", line 12, in <module> import cgi File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/cgi.py", line 44, in <module> import tempfile File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/tempfile.py", line 34, in <module> import shutil as _shutil File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/shutil.py", line 14, in <module> import tarfile File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/tarfile.py", line 48, in <module> import copy File "/Users/artemdremov/Documents/grabber/copy.py", line 2, in <module> import urllib.request File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/urllib/request.py", line 102, in <module> from urllib.error import URLError, HTTPError, ContentTooShortError File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/urllib/error.py", line 14, in <module> import urllib.response File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/urllib/response.py", line 14, in <module> class addbase(tempfile._TemporaryFileWrapper): AttributeError: 'module' object has no attribute '_TemporaryFileWrapper' ``` I work under OS X 10.10.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2460/reactions" }
https://api.github.com/repos/psf/requests/issues/2460/timeline
null
completed
null
null
false
[ "That traceback seems to pass through some of your own code, specifically a module called `copy`. Is that new?\n", "To be clear, @Lukasa is talking about \n\n```\n File \"/Users/artemdremov/Documents/grabber/copy.py\", line 2, in <module>\n```\n\nI'm rather surprised though that that would even be used. I though...
https://api.github.com/repos/psf/requests/issues/2459
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2459/labels{/name}
https://api.github.com/repos/psf/requests/issues/2459/comments
https://api.github.com/repos/psf/requests/issues/2459/events
https://github.com/psf/requests/pull/2459
58,763,798
MDExOlB1bGxSZXF1ZXN0Mjk5MTI1NDE=
2,459
Update HISTORY and release version for 2.5.3
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
0
2015-02-24T16:31:49Z
2021-09-08T08:01:07Z
2015-02-24T16:32:15Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2459/reactions" }
https://api.github.com/repos/psf/requests/issues/2459/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2459.diff", "html_url": "https://github.com/psf/requests/pull/2459", "merged_at": "2015-02-24T16:32:15Z", "patch_url": "https://github.com/psf/requests/pull/2459.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2459" }
true
[]
https://api.github.com/repos/psf/requests/issues/2458
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2458/labels{/name}
https://api.github.com/repos/psf/requests/issues/2458/comments
https://api.github.com/repos/psf/requests/issues/2458/events
https://github.com/psf/requests/pull/2458
58,756,824
MDExOlB1bGxSZXF1ZXN0Mjk5MDgwMTE=
2,458
Revert "Update certificate bundle."
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
4
2015-02-24T15:44:57Z
2021-09-08T08:01:07Z
2015-02-24T16:18:16Z
CONTRIBUTOR
resolved
Reverts kennethreitz/requests#2442
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2458/reactions" }
https://api.github.com/repos/psf/requests/issues/2458/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2458.diff", "html_url": "https://github.com/psf/requests/pull/2458", "merged_at": "2015-02-24T16:18:16Z", "patch_url": "https://github.com/psf/requests/pull/2458.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2458" }
true
[ "We may need to merge this to temporarily resolve the CA problems added in 2.5.2.\n", "And then we'll cut 2.5.3\n", ":sob: \n", "Yeah. This is the worst\n" ]
https://api.github.com/repos/psf/requests/issues/2457
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2457/labels{/name}
https://api.github.com/repos/psf/requests/issues/2457/comments
https://api.github.com/repos/psf/requests/issues/2457/events
https://github.com/psf/requests/issues/2457
58,685,916
MDU6SXNzdWU1ODY4NTkxNg==
2,457
ImportError: cannot import name is_windows
{ "avatar_url": "https://avatars.githubusercontent.com/u/244702?v=4", "events_url": "https://api.github.com/users/papachoco/events{/privacy}", "followers_url": "https://api.github.com/users/papachoco/followers", "following_url": "https://api.github.com/users/papachoco/following{/other_user}", "gists_url": "https://api.github.com/users/papachoco/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/papachoco", "id": 244702, "login": "papachoco", "node_id": "MDQ6VXNlcjI0NDcwMg==", "organizations_url": "https://api.github.com/users/papachoco/orgs", "received_events_url": "https://api.github.com/users/papachoco/received_events", "repos_url": "https://api.github.com/users/papachoco/repos", "site_admin": false, "starred_url": "https://api.github.com/users/papachoco/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/papachoco/subscriptions", "type": "User", "url": "https://api.github.com/users/papachoco", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-02-24T02:45:29Z
2021-09-08T09:00:39Z
2015-02-24T02:54:06Z
NONE
resolved
I am not sure if this should be a bug for requests (2.5.2). httpie (http command) no longer works with requests 2.5.2. b/c the the method is_windows was removed from requests.compat Traceback (most recent call last): File "/Users/csanchez/Projects/nti.dataserver-buildout/bin/http", line 413, in <module> import httpie.**main** File "/Users/csanchez/Documents/workspace/nti.dataserver-buildout/eggs/httpie-0.9.1-py2.7.egg/httpie/**main**.py", line 6, in <module> from .core import main File "/Users/csanchez/Documents/workspace/nti.dataserver-buildout/eggs/httpie-0.9.1-py2.7.egg/httpie/core.py", line 21, in <module> from httpie.compat import str, bytes, is_py3 File "/Users/csanchez/Documents/workspace/nti.dataserver-buildout/eggs/httpie-0.9.1-py2.7.egg/httpie/compat.py", line 7, in <module> from requests.compat import is_windows, bytes, str, is_py3, is_py26 ImportError: cannot import name is_windows
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2457/reactions" }
https://api.github.com/repos/psf/requests/issues/2457/timeline
null
completed
null
null
false
[ "This is a bug in httpie. We cleaned up old symbols we weren't using. `requests.compat` isn't a publicly documented or exported API.\n", "I figured ..\nThanks a lot\n\nCarlos\n", "@papachoco can you please share how you solved this error?\r\n", "@ahsentaqikazmi this is an issue with httpie rather than Reques...
https://api.github.com/repos/psf/requests/issues/2456
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2456/labels{/name}
https://api.github.com/repos/psf/requests/issues/2456/comments
https://api.github.com/repos/psf/requests/issues/2456/events
https://github.com/psf/requests/issues/2456
58,684,598
MDU6SXNzdWU1ODY4NDU5OA==
2,456
Thawte (erroneously?) removed from certificate bundle
{ "avatar_url": "https://avatars.githubusercontent.com/u/565385?v=4", "events_url": "https://api.github.com/users/jimrollenhagen/events{/privacy}", "followers_url": "https://api.github.com/users/jimrollenhagen/followers", "following_url": "https://api.github.com/users/jimrollenhagen/following{/other_user}", "gists_url": "https://api.github.com/users/jimrollenhagen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jimrollenhagen", "id": 565385, "login": "jimrollenhagen", "node_id": "MDQ6VXNlcjU2NTM4NQ==", "organizations_url": "https://api.github.com/users/jimrollenhagen/orgs", "received_events_url": "https://api.github.com/users/jimrollenhagen/received_events", "repos_url": "https://api.github.com/users/jimrollenhagen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jimrollenhagen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jimrollenhagen/subscriptions", "type": "User", "url": "https://api.github.com/users/jimrollenhagen", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
6
2015-02-24T02:26:30Z
2021-09-08T23:06:00Z
2015-02-24T16:00:59Z
NONE
resolved
#2442 updated the certificate bundle and appears to have dropped Thawte from the bundle. Thawte still shows up for me both in the Mozilla bundle and the mkcert.org standard bundle. Mozilla appears to have been unchanged recently: https://hg.mozilla.org/releases/mozilla-release/log/a2ffa9047bf4/security/nss/lib/ckfw/builtins/certdata.txt So I'm not sure how this happened, but it's broken using requests for Rackspace's cloud API, and I'm sure other sites as well.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2456/reactions" }
https://api.github.com/repos/psf/requests/issues/2456/timeline
null
completed
null
null
false
[ "@Lukasa generated the certificate with mkcert.org if I recall correctly but I'm not sure the list of certificates he used. It seems we just need to add thawte\n", "Actually looks like it's [here](https://github.com/kennethreitz/requests/blob/master/requests/cacert.pem#L1710) but I see that there seem to be other...
https://api.github.com/repos/psf/requests/issues/2455
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2455/labels{/name}
https://api.github.com/repos/psf/requests/issues/2455/comments
https://api.github.com/repos/psf/requests/issues/2455/events
https://github.com/psf/requests/issues/2455
58,678,665
MDU6SXNzdWU1ODY3ODY2NQ==
2,455
CERTIFICATE_VERIFY_FAILED with 2.5.2, works with 2.5.1
{ "avatar_url": "https://avatars.githubusercontent.com/u/641278?v=4", "events_url": "https://api.github.com/users/rmcgibbo/events{/privacy}", "followers_url": "https://api.github.com/users/rmcgibbo/followers", "following_url": "https://api.github.com/users/rmcgibbo/following{/other_user}", "gists_url": "https://api.github.com/users/rmcgibbo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rmcgibbo", "id": 641278, "login": "rmcgibbo", "node_id": "MDQ6VXNlcjY0MTI3OA==", "organizations_url": "https://api.github.com/users/rmcgibbo/orgs", "received_events_url": "https://api.github.com/users/rmcgibbo/received_events", "repos_url": "https://api.github.com/users/rmcgibbo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rmcgibbo/subscriptions", "type": "User", "url": "https://api.github.com/users/rmcgibbo", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" }, { "color": "e102d8", "default": false, "description": null, "id": 117745, "...
closed
true
null
[]
null
111
2015-02-24T01:11:01Z
2021-09-08T20:00:52Z
2015-05-31T12:57:28Z
NONE
resolved
I'm having a somewhat odd issue. A get() request seems to work fine with requests-2.5.1, but after upgrading to requests 2.5.2, the same URL leads to `CERTIFICATE_VERIFY_FAILED`. cc @mpharrigan ``` $ pip install requests==2.5.1 [ ... snip, installs just fine ...] $ python -c 'import requests; print(requests.get("http://conda.binstar.org/omnia/linux-64/fftw3f-3.3.3-1.tar.bz2"))' <Response [200]> $ pip install requests==2.5.2 [ ... snip, installs just fine ...] $ python -c 'import requests; print(requests.get("http://conda.binstar.org/omnia/linux-64/fftw3f-3.3.3-1.tar.bz2"))' Traceback (most recent call last): File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen body=body, headers=headers) File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 341, in _make_request self._validate_conn(conn) File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 762, in _validate_conn conn.connect() File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 238, in connect ssl_version=resolved_ssl_version) File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/site-packages/requests/packages/urllib3/util/ssl_.py", line 256, in ssl_wrap_socket return context.wrap_socket(sock, server_hostname=server_hostname) File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/ssl.py", line 364, in wrap_socket _context=self) File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/ssl.py", line 578, in __init__ self.do_handshake() File "/Users/rmcgibbo/miniconda/envs/3.4.2/lib/python3.4/ssl.py", line 805, in do_handshake self._sslobj.do_handshake() ssl.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:600) During handling of the above exception, another exception occurred: [... snip ...] ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2455/reactions" }
https://api.github.com/repos/psf/requests/issues/2455/timeline
null
completed
null
null
false
[ "FWIW, this is with python 3.4.2 and OS X 10.10.\n", "@t-8ch seems related to the urllib3 patch to disable built-in hostname verification possibly.\n", "Would it be helpful for me to run a git-bisect or something?\n", "Not really. The change is upstream of us. Thanks for the bug though.\n", "@sigmavirus24 I...
https://api.github.com/repos/psf/requests/issues/2454
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2454/labels{/name}
https://api.github.com/repos/psf/requests/issues/2454/comments
https://api.github.com/repos/psf/requests/issues/2454/events
https://github.com/psf/requests/issues/2454
58,501,309
MDU6SXNzdWU1ODUwMTMwOQ==
2,454
SSL certificate caching
{ "avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4", "events_url": "https://api.github.com/users/RuudBurger/events{/privacy}", "followers_url": "https://api.github.com/users/RuudBurger/followers", "following_url": "https://api.github.com/users/RuudBurger/following{/other_user}", "gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/RuudBurger", "id": 38136, "login": "RuudBurger", "node_id": "MDQ6VXNlcjM4MTM2", "organizations_url": "https://api.github.com/users/RuudBurger/orgs", "received_events_url": "https://api.github.com/users/RuudBurger/received_events", "repos_url": "https://api.github.com/users/RuudBurger/repos", "site_admin": false, "starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions", "type": "User", "url": "https://api.github.com/users/RuudBurger", "user_view_type": "public" }
[]
closed
true
null
[]
null
14
2015-02-22T12:36:34Z
2021-09-08T23:06:00Z
2015-02-22T13:10:01Z
NONE
resolved
I have a question regarding caching of ssl certificates. I switched over to a sha2 certificate which has 2 intermediate certificates. This all works fine and requests is working like expected. The problem is the size of the certificates. It was a 2KB certificate before, but now with the 2 intermediate certificates in there it's at 7KB. This doesn't seem like much, but the server I'm running it on has over 25million requests each day. With the content send per requests well below 10KB. Practically doubling my traffic by just adding the new certificate. I tried searching on how the certificate are used. Is it a 1 time thing and then cached on the client side?, is the certificated send with each request? etc. But I keep finding the basics of how and what certificates do. Could you tell me how `requests` uses the certificate and if there is a way on somehow caching it in the session object for example. Making sure it doesn't get requested with each call. Maybe I'm asking something weird here, so please let me know if it just "how http works" ;)
{ "avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4", "events_url": "https://api.github.com/users/RuudBurger/events{/privacy}", "followers_url": "https://api.github.com/users/RuudBurger/followers", "following_url": "https://api.github.com/users/RuudBurger/following{/other_user}", "gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/RuudBurger", "id": 38136, "login": "RuudBurger", "node_id": "MDQ6VXNlcjM4MTM2", "organizations_url": "https://api.github.com/users/RuudBurger/orgs", "received_events_url": "https://api.github.com/users/RuudBurger/received_events", "repos_url": "https://api.github.com/users/RuudBurger/repos", "site_admin": false, "starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions", "type": "User", "url": "https://api.github.com/users/RuudBurger", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2454/reactions" }
https://api.github.com/repos/psf/requests/issues/2454/timeline
null
completed
null
null
false
[ "@RuudBurger The certificate chain is sent with each SSL handshake, which is performed for each new connection. If you use a `requests` Session it will use a connectionpool, which reuses connections for each host.\nAs you are talking to the same host only one handshake will be performed.\n", "It's not \"how HTTP ...
https://api.github.com/repos/psf/requests/issues/2453
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2453/labels{/name}
https://api.github.com/repos/psf/requests/issues/2453/comments
https://api.github.com/repos/psf/requests/issues/2453/events
https://github.com/psf/requests/pull/2453
58,391,249
MDExOlB1bGxSZXF1ZXN0Mjk3MTg1MjE=
2,453
document combination of repeated response headers
{ "avatar_url": "https://avatars.githubusercontent.com/u/6235698?v=4", "events_url": "https://api.github.com/users/requiredfield/events{/privacy}", "followers_url": "https://api.github.com/users/requiredfield/followers", "following_url": "https://api.github.com/users/requiredfield/following{/other_user}", "gists_url": "https://api.github.com/users/requiredfield/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/requiredfield", "id": 6235698, "login": "requiredfield", "node_id": "MDQ6VXNlcjYyMzU2OTg=", "organizations_url": "https://api.github.com/users/requiredfield/orgs", "received_events_url": "https://api.github.com/users/requiredfield/received_events", "repos_url": "https://api.github.com/users/requiredfield/repos", "site_admin": false, "starred_url": "https://api.github.com/users/requiredfield/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/requiredfield/subscriptions", "type": "User", "url": "https://api.github.com/users/requiredfield", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-02-20T18:25:58Z
2021-09-08T08:01:08Z
2015-02-21T10:20:57Z
CONTRIBUTOR
resolved
as explained in https://github.com/kennethreitz/requests/issues/1155#issuecomment-53229867. motivation: requests uses a dict for response headers. In a given response, the same header may appear multiple times with different values, but dicts of course allow each key to map to only one value. requests [handles this intelligently](https://github.com/kennethreitz/requests/issues/1155#issuecomment-53229867), but users will not expect this given it's not documented in any of these places: - http://docs.python-requests.org/en/latest/user/quickstart/#response-headers - http://docs.python-requests.org/en/latest/api/?highlight=headers#requests.request - http://docs.python-requests.org/en/latest/api/#requests.Response.headers (Also, they may (likely) be unfamiliar with this part of http://tools.ietf.org/html/rfc7230#section-3.2, while only actually being familiar with werkzeug and other libraries that use a multidict instead to handle repeated headers.) I think there's a perfect spot to document this behavior (right after the docs explain how the dict is already special in that it's case-insensitive), and given that #1155 will probably be closed, I figured it's a good time to document this and increase users' future understanding. Thanks for the great work on requests.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2453/reactions" }
https://api.github.com/repos/psf/requests/issues/2453/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2453.diff", "html_url": "https://github.com/psf/requests/pull/2453", "merged_at": "2015-02-21T10:20:57Z", "patch_url": "https://github.com/psf/requests/pull/2453.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2453" }
true
[ ":cake: Beautiful. =)\n", "Thanks for merging. =)\n" ]
https://api.github.com/repos/psf/requests/issues/2452
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2452/labels{/name}
https://api.github.com/repos/psf/requests/issues/2452/comments
https://api.github.com/repos/psf/requests/issues/2452/events
https://github.com/psf/requests/issues/2452
58,387,684
MDU6SXNzdWU1ODM4NzY4NA==
2,452
multiple cookie headers should be joined with semicolons
{ "avatar_url": "https://avatars.githubusercontent.com/u/6235698?v=4", "events_url": "https://api.github.com/users/requiredfield/events{/privacy}", "followers_url": "https://api.github.com/users/requiredfield/followers", "following_url": "https://api.github.com/users/requiredfield/following{/other_user}", "gists_url": "https://api.github.com/users/requiredfield/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/requiredfield", "id": 6235698, "login": "requiredfield", "node_id": "MDQ6VXNlcjYyMzU2OTg=", "organizations_url": "https://api.github.com/users/requiredfield/orgs", "received_events_url": "https://api.github.com/users/requiredfield/received_events", "repos_url": "https://api.github.com/users/requiredfield/repos", "site_admin": false, "starred_url": "https://api.github.com/users/requiredfield/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/requiredfield/subscriptions", "type": "User", "url": "https://api.github.com/users/requiredfield", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-02-20T17:56:22Z
2021-09-08T23:05:56Z
2015-03-05T14:18:27Z
CONTRIBUTOR
resolved
please see https://github.com/kennethreitz/requests/issues/1155#issuecomment-55176733
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2452/reactions" }
https://api.github.com/repos/psf/requests/issues/2452/timeline
null
completed
null
null
false
[ "This should be fixed by https://github.com/shazow/urllib3/pull/534 after we cut a new release of requests.\n", "I apologise, my original statement in #1155 is wrong. Multiple cookie headers shouldn't be joined at all: there is simply no safe way to do that.\n" ]
https://api.github.com/repos/psf/requests/issues/2451
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2451/labels{/name}
https://api.github.com/repos/psf/requests/issues/2451/comments
https://api.github.com/repos/psf/requests/issues/2451/events
https://github.com/psf/requests/issues/2451
58,264,845
MDU6SXNzdWU1ODI2NDg0NQ==
2,451
Add HTTP2 support
{ "avatar_url": "https://avatars.githubusercontent.com/u/6730980?v=4", "events_url": "https://api.github.com/users/AkshatM/events{/privacy}", "followers_url": "https://api.github.com/users/AkshatM/followers", "following_url": "https://api.github.com/users/AkshatM/following{/other_user}", "gists_url": "https://api.github.com/users/AkshatM/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/AkshatM", "id": 6730980, "login": "AkshatM", "node_id": "MDQ6VXNlcjY3MzA5ODA=", "organizations_url": "https://api.github.com/users/AkshatM/orgs", "received_events_url": "https://api.github.com/users/AkshatM/received_events", "repos_url": "https://api.github.com/users/AkshatM/repos", "site_admin": false, "starred_url": "https://api.github.com/users/AkshatM/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AkshatM/subscriptions", "type": "User", "url": "https://api.github.com/users/AkshatM", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-19T20:27:11Z
2021-09-08T23:06:00Z
2015-02-19T20:33:30Z
NONE
resolved
The [draft specification of HTTP 2.0](https://tools.ietf.org/html/draft-ietf-httpbis-http2-17#page-7) is out. As a long-term goal, there should be a way to make **requests** compatible with it.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2451/reactions" }
https://api.github.com/repos/psf/requests/issues/2451/timeline
null
completed
null
null
false
[ "Please check old issues: #2082.\n" ]
https://api.github.com/repos/psf/requests/issues/2450
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2450/labels{/name}
https://api.github.com/repos/psf/requests/issues/2450/comments
https://api.github.com/repos/psf/requests/issues/2450/events
https://github.com/psf/requests/pull/2450
58,254,164
MDExOlB1bGxSZXF1ZXN0Mjk2Mzk3MDk=
2,450
Update README to use Shields badges
{ "avatar_url": "https://avatars.githubusercontent.com/u/2434728?v=4", "events_url": "https://api.github.com/users/iKevinY/events{/privacy}", "followers_url": "https://api.github.com/users/iKevinY/followers", "following_url": "https://api.github.com/users/iKevinY/following{/other_user}", "gists_url": "https://api.github.com/users/iKevinY/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/iKevinY", "id": 2434728, "login": "iKevinY", "node_id": "MDQ6VXNlcjI0MzQ3Mjg=", "organizations_url": "https://api.github.com/users/iKevinY/orgs", "received_events_url": "https://api.github.com/users/iKevinY/received_events", "repos_url": "https://api.github.com/users/iKevinY/repos", "site_admin": false, "starred_url": "https://api.github.com/users/iKevinY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iKevinY/subscriptions", "type": "User", "url": "https://api.github.com/users/iKevinY", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-02-19T19:14:06Z
2021-09-08T09:00:55Z
2015-02-20T02:01:55Z
CONTRIBUTOR
resolved
The SVG badges served by [Shields](http://shields.io) are friendlier to retina displays and have a standardized design. ![Shields Comparison](https://cloud.githubusercontent.com/assets/2434728/6273906/0fc39ff8-b828-11e4-95e8-b7b5f80ef9e9.png)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2450/reactions" }
https://api.github.com/repos/psf/requests/issues/2450/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2450.diff", "html_url": "https://github.com/psf/requests/pull/2450", "merged_at": "2015-02-20T02:01:55Z", "patch_url": "https://github.com/psf/requests/pull/2450.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2450" }
true
[ "No objection from me. @sigmavirus24?\n", "One thing I noticed is that there's less precision in the download count – not sure if this problematic.\n", "Meh. Download counts are working exactly correctly with PyPI at the moment anyway.\n", "Thanks @iKevinY !\n", "No worries!\n" ]
https://api.github.com/repos/psf/requests/issues/2449
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2449/labels{/name}
https://api.github.com/repos/psf/requests/issues/2449/comments
https://api.github.com/repos/psf/requests/issues/2449/events
https://github.com/psf/requests/issues/2449
58,058,431
MDU6SXNzdWU1ODA1ODQzMQ==
2,449
[rfe] requests should process chunked responses transparently
{ "avatar_url": "https://avatars.githubusercontent.com/u/1662493?v=4", "events_url": "https://api.github.com/users/TomasTomecek/events{/privacy}", "followers_url": "https://api.github.com/users/TomasTomecek/followers", "following_url": "https://api.github.com/users/TomasTomecek/following{/other_user}", "gists_url": "https://api.github.com/users/TomasTomecek/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/TomasTomecek", "id": 1662493, "login": "TomasTomecek", "node_id": "MDQ6VXNlcjE2NjI0OTM=", "organizations_url": "https://api.github.com/users/TomasTomecek/orgs", "received_events_url": "https://api.github.com/users/TomasTomecek/received_events", "repos_url": "https://api.github.com/users/TomasTomecek/repos", "site_admin": false, "starred_url": "https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TomasTomecek/subscriptions", "type": "User", "url": "https://api.github.com/users/TomasTomecek", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-02-18T11:51:57Z
2021-09-08T23:05:52Z
2015-02-18T11:54:11Z
NONE
resolved
When server responds with `Transfer-Encoding: chunked`, it would be nice if `requests` would process the chunked response. Right now if I do `response.iter_lines()` I get access to chunks part where length of the chunk is encoded with optional chunk extension. It would be awesome if `requests` would provide something like `iter_chunks` where I would get access to the chunk data only. More info: http://en.wikipedia.org/wiki/Chunked_transfer_encoding http://mihai.ibanescu.net/chunked-encoding-and-python-requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2449/reactions" }
https://api.github.com/repos/psf/requests/issues/2449/timeline
null
completed
null
null
false
[ "As mentioned in the blog post you link to, `httplib` does not provide us with access to those chunks. To get them we'd have to go around `httplib` and read directly from the socket itself. That's do-able, but it's a pretty aggressive layering violation. The first place to ask for that would be in our underlying la...
https://api.github.com/repos/psf/requests/issues/2448
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2448/labels{/name}
https://api.github.com/repos/psf/requests/issues/2448/comments
https://api.github.com/repos/psf/requests/issues/2448/events
https://github.com/psf/requests/issues/2448
57,998,689
MDU6SXNzdWU1Nzk5ODY4OQ==
2,448
Use of Session for repeated requests subject to TCP timing problem
{ "avatar_url": "https://avatars.githubusercontent.com/u/1697414?v=4", "events_url": "https://api.github.com/users/pddenhar/events{/privacy}", "followers_url": "https://api.github.com/users/pddenhar/followers", "following_url": "https://api.github.com/users/pddenhar/following{/other_user}", "gists_url": "https://api.github.com/users/pddenhar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pddenhar", "id": 1697414, "login": "pddenhar", "node_id": "MDQ6VXNlcjE2OTc0MTQ=", "organizations_url": "https://api.github.com/users/pddenhar/orgs", "received_events_url": "https://api.github.com/users/pddenhar/received_events", "repos_url": "https://api.github.com/users/pddenhar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pddenhar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pddenhar/subscriptions", "type": "User", "url": "https://api.github.com/users/pddenhar", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
12
2015-02-17T23:20:28Z
2021-09-07T00:06:12Z
2015-04-06T11:13:39Z
NONE
resolved
This is a bug that I originally experienced using the InfluxDB-python client and reported [here](https://github.com/influxdb/influxdb-python/issues/103). Upon further investigation, I've been able to reproduce it using only the requests library (which InfluxDB-client uses). Running a very simple script making repeated requests to a remote URL will result in a failed request if a certain timing condition is met, resulting in a thrown `requests.exceptions.ConnectionError`. Here is the script I used to reproduce the issue: ``` import requests import time session = requests.Session() while 1: try: response = session.request( method='GET', url="http://mediaqueri.es/", timeout=15 ) print response.status_code, response.text[0:30] except Exception as e: print e, type(e) time.sleep(5) ``` The site I'm GETting is just a publicly available site that happens to be running on the Flask framework. About one in ten requests to the site will fail, and the following line will be printed by the exception handler shown above: `HTTPConnectionPool(host='mediaqueri.es', port=80): Max retries exceeded with url: / (Caused by <class 'httplib.BadStatusLine'>: '') <class 'requests.exceptions.ConnectionError'>` This exception message confused me initially, because the BadStatusLine is something that would usually indicate a HTTP status being returned that is not considered valid, which would be unusual for such a basic request to a web server. After inspecting the actual TCP traffic with Wireshark, I've found that something else is happening. Here is the packet sequence for two requests being made five seconds apart, with the second one failing: ![screenshot from 2015-02-17 17 00 15](https://cloud.githubusercontent.com/assets/1697414/6239135/87e61a8c-b6c6-11e4-9b54-1776fbaab130.png) The first request proceeds as you would expect, with a TCP connection being opened with a SYN, and then a GET and a HTTP response being received. The use of connection pooling means that the connection is kept open between the first and second and after five seconds the second GET is sent out. The issue is that the Flask web server also seems to close inactive TCP connections after five seconds, so right after that GET is sent out and probably while it's still in flight, a FIN is received from the server and duly ACKed, which closes that TCP connection without receiving the HTTP response. At that point, some RST packets arrive (indicating that a packet arrived on a socket after a FIN was sent?) and they seem to somehow end up causing a BadStatusLine HTTP error to be thrown. I understand that is a fairly involved series of events, so thank you if you've made it this far. It might even be possible that this bug is at an even lower level than the requests library, somewhere in urllib3 perhaps. In any case though, having Session requests fail because they happen to be in sync with the rate at which TCP connections close is a pretty obscure problem for an end user to handle. At the least I think throwing an exception that lists BadStatusLine as the cause is not the correct behavior. The client side is ACKing the FIN it receives from the server, which means it should not expect to receive an HTTP response on that connection after that point.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2448/reactions" }
https://api.github.com/repos/psf/requests/issues/2448/timeline
null
completed
null
null
false
[ "So I think the fundamental problem here is that neither requests nor urllib3 have any way of knowing what's happening with the actually underlying TCP connection. urllib3 at its best wraps sockets to enable TLS but doesn't really directly manage sockets beyond that very thoroughly.\n\nIt isn't as if urllib3 or req...
https://api.github.com/repos/psf/requests/issues/2447
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2447/labels{/name}
https://api.github.com/repos/psf/requests/issues/2447/comments
https://api.github.com/repos/psf/requests/issues/2447/events
https://github.com/psf/requests/issues/2447
57,680,795
MDU6SXNzdWU1NzY4MDc5NQ==
2,447
[Suggestion] allow TCP options to be set more easily
{ "avatar_url": "https://avatars.githubusercontent.com/u/348398?v=4", "events_url": "https://api.github.com/users/hoodja/events{/privacy}", "followers_url": "https://api.github.com/users/hoodja/followers", "following_url": "https://api.github.com/users/hoodja/following{/other_user}", "gists_url": "https://api.github.com/users/hoodja/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hoodja", "id": 348398, "login": "hoodja", "node_id": "MDQ6VXNlcjM0ODM5OA==", "organizations_url": "https://api.github.com/users/hoodja/orgs", "received_events_url": "https://api.github.com/users/hoodja/received_events", "repos_url": "https://api.github.com/users/hoodja/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hoodja/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hoodja/subscriptions", "type": "User", "url": "https://api.github.com/users/hoodja", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-02-14T04:32:17Z
2021-09-08T23:06:01Z
2015-02-15T15:53:00Z
NONE
resolved
First, thanks for all the work on this library - I've been using it for about a year and it is always a joy to work with! I've run into a situation where a request I'm making is running through a NAT that is not in my control, and the request takes >10m to complete. On a Linux machine I am able to retrieve the response using cURL, but it never completed using requests in python. I suspect this is because cURL sends TCP-level keepalive requests while the default initialization of requests does not. In researching how I would be able to enable keepalive on the underlying sockets, it seems like I would just need to be able to provide the `socket_options` list to `requests.adapters.HTTPAdapter` at construction, and have HTTPAdapter include that in `pool_kwargs`. I imagine this could be accomplished by adding a `**kwargs` argument to `HTTPAdapter` and passing it through / merging it into `pool_kwargs`. This issue is meant to be a discussion on the appropriateness of that solution.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2447/reactions" }
https://api.github.com/repos/psf/requests/issues/2447/timeline
null
completed
null
null
false
[ "For added context, below is a workaround that seems to work for me on Linux (but not OS X):\n\n``` python\ns = requests.Session()\n\nfrom requests.packages.urllib3.connection import HTTPConnection\nmy_socket_options = HTTPConnection.default_socket_options + [\n (socket.SOL_SOCKET, socket.SO_KEEPALIVE, 1)\n, (socke...
https://api.github.com/repos/psf/requests/issues/2446
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2446/labels{/name}
https://api.github.com/repos/psf/requests/issues/2446/comments
https://api.github.com/repos/psf/requests/issues/2446/events
https://github.com/psf/requests/issues/2446
57,653,096
MDU6SXNzdWU1NzY1MzA5Ng==
2,446
gzip response is not decoded
{ "avatar_url": "https://avatars.githubusercontent.com/u/5251753?v=4", "events_url": "https://api.github.com/users/barab-a/events{/privacy}", "followers_url": "https://api.github.com/users/barab-a/followers", "following_url": "https://api.github.com/users/barab-a/following{/other_user}", "gists_url": "https://api.github.com/users/barab-a/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/barab-a", "id": 5251753, "login": "barab-a", "node_id": "MDQ6VXNlcjUyNTE3NTM=", "organizations_url": "https://api.github.com/users/barab-a/orgs", "received_events_url": "https://api.github.com/users/barab-a/received_events", "repos_url": "https://api.github.com/users/barab-a/repos", "site_admin": false, "starred_url": "https://api.github.com/users/barab-a/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/barab-a/subscriptions", "type": "User", "url": "https://api.github.com/users/barab-a", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-02-13T20:58:10Z
2019-08-09T15:40:34Z
2015-02-13T22:46:14Z
NONE
resolved
It says in the FAQ: > Requests automatically decompresses gzip-encoded responses, and does its best to decode response content to unicode when possible. But the following code produces uncompressed data: ``` import requests response = requests.get("http://www.shopcade.com/sitemaps/sitemap_products_index.xml.gz") print response.text ``` So is this an issue of requests library or is there something wrong with the response from that site. When I download the archive via browser it decompresses well and the xml seems to be fine. Also the response headers contain the following key-value pair: ``` 'content-type': 'application/x-gzip' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2446/reactions" }
https://api.github.com/repos/psf/requests/issues/2446/timeline
null
completed
null
null
false
[ "Ah, yes. This is an easy misunderstanding to make.\n\nWhen we say gzip-encoded responses, we mean responses that are sent with `Transfer-Encoding: gzip`. That means that the body has a known type but has been compressed with gzip for transport. That does not include things whose actual content is gzip, as in the e...
https://api.github.com/repos/psf/requests/issues/2445
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2445/labels{/name}
https://api.github.com/repos/psf/requests/issues/2445/comments
https://api.github.com/repos/psf/requests/issues/2445/events
https://github.com/psf/requests/issues/2445
57,504,627
MDU6SXNzdWU1NzUwNDYyNw==
2,445
Allow a "url_prefix" to be set on Session
{ "avatar_url": "https://avatars.githubusercontent.com/u/1653275?v=4", "events_url": "https://api.github.com/users/fiatjaf/events{/privacy}", "followers_url": "https://api.github.com/users/fiatjaf/followers", "following_url": "https://api.github.com/users/fiatjaf/following{/other_user}", "gists_url": "https://api.github.com/users/fiatjaf/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/fiatjaf", "id": 1653275, "login": "fiatjaf", "node_id": "MDQ6VXNlcjE2NTMyNzU=", "organizations_url": "https://api.github.com/users/fiatjaf/orgs", "received_events_url": "https://api.github.com/users/fiatjaf/received_events", "repos_url": "https://api.github.com/users/fiatjaf/repos", "site_admin": false, "starred_url": "https://api.github.com/users/fiatjaf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fiatjaf/subscriptions", "type": "User", "url": "https://api.github.com/users/fiatjaf", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-02-12T19:08:05Z
2021-09-08T23:06:01Z
2015-02-12T19:13:25Z
NONE
resolved
So we can do something like this: ``` python COUCHDB_URL = 'https://mybigusername:myenourmouspassword@mycouchdb.provider.com/databasename/' s = requests.Session(url_prefix=COUCHDB_URL) r = s.get('/_all_docs', params=dict(include_docs=True)) r = s.get('/some_document_id') ``` The example uses the CouchDB API and it would almost entirely prevent the need for API wrappers like [this](https://github.com/adamlofts/couchdb-requests) (see it storing the url prefix [right here](https://github.com/adamlofts/couchdb-requests/blob/93e83d5e8cf7b0894de33747572789777dee845e/couchdbreq/resource.py#L80)). But extensive usage of any REST API would benefit from this.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 2, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 2, "url": "https://api.github.com/repos/psf/requests/issues/2445/reactions" }
https://api.github.com/repos/psf/requests/issues/2445/timeline
null
completed
null
null
false
[ "Duplicate of #133.\n\nIn short, we're not adding new features to the API and we're especially not going to attempt to build URLs for you when you're using a session. There are lots of other libraries that allow for similar functionality but that is not something inherently necessary in the transmission or handling...
https://api.github.com/repos/psf/requests/issues/2444
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2444/labels{/name}
https://api.github.com/repos/psf/requests/issues/2444/comments
https://api.github.com/repos/psf/requests/issues/2444/events
https://github.com/psf/requests/pull/2444
57,355,512
MDExOlB1bGxSZXF1ZXN0MjkxMTUyNjg=
2,444
Upgrade urllib3 to 490d3a227fadb626cd54a240b9d0922f849914b4
{ "avatar_url": "https://avatars.githubusercontent.com/u/48383?v=4", "events_url": "https://api.github.com/users/Yasumoto/events{/privacy}", "followers_url": "https://api.github.com/users/Yasumoto/followers", "following_url": "https://api.github.com/users/Yasumoto/following{/other_user}", "gists_url": "https://api.github.com/users/Yasumoto/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Yasumoto", "id": 48383, "login": "Yasumoto", "node_id": "MDQ6VXNlcjQ4Mzgz", "organizations_url": "https://api.github.com/users/Yasumoto/orgs", "received_events_url": "https://api.github.com/users/Yasumoto/received_events", "repos_url": "https://api.github.com/users/Yasumoto/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Yasumoto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Yasumoto/subscriptions", "type": "User", "url": "https://api.github.com/users/Yasumoto", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-02-11T18:23:53Z
2021-09-08T08:01:08Z
2015-02-23T22:01:06Z
CONTRIBUTOR
resolved
This is the release tagged at 85dfc16817df1e3604c238ad5d64f3b229e0598b
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2444/reactions" }
https://api.github.com/repos/psf/requests/issues/2444/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2444.diff", "html_url": "https://github.com/psf/requests/pull/2444", "merged_at": "2015-02-23T22:01:06Z", "patch_url": "https://github.com/psf/requests/pull/2444.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2444" }
true
[ "Tested on OS X 10.10:\n\n```\n[tw-mbp-jsmith requests (urllib_upgrade)]$ make test\n# This runs all of the tests. To run an individual test, run py.test with\n# the -k flag, like \"py.test -k test_path_is_not_double_encoded\"\npy.test test_requests.py\n==============================================================...
https://api.github.com/repos/psf/requests/issues/2443
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2443/labels{/name}
https://api.github.com/repos/psf/requests/issues/2443/comments
https://api.github.com/repos/psf/requests/issues/2443/events
https://github.com/psf/requests/issues/2443
57,228,826
MDU6SXNzdWU1NzIyODgyNg==
2,443
Scaffold an API console sample from a model
{ "avatar_url": "https://avatars.githubusercontent.com/u/109167?v=4", "events_url": "https://api.github.com/users/s-celles/events{/privacy}", "followers_url": "https://api.github.com/users/s-celles/followers", "following_url": "https://api.github.com/users/s-celles/following{/other_user}", "gists_url": "https://api.github.com/users/s-celles/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/s-celles", "id": 109167, "login": "s-celles", "node_id": "MDQ6VXNlcjEwOTE2Nw==", "organizations_url": "https://api.github.com/users/s-celles/orgs", "received_events_url": "https://api.github.com/users/s-celles/received_events", "repos_url": "https://api.github.com/users/s-celles/repos", "site_admin": false, "starred_url": "https://api.github.com/users/s-celles/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/s-celles/subscriptions", "type": "User", "url": "https://api.github.com/users/s-celles", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-10T20:05:31Z
2021-09-08T23:06:02Z
2015-02-11T03:46:44Z
NONE
resolved
Hello, I wonder if RAML http://www.sitepoint.com/raml-restful-api-modeling-language/ http://raml.org/ couldn't be use to create (scaffold) an API console sample. This idea is probably out of the scope of requests but we could talk about such idea here. Same idea for server: https://github.com/flask-restful/flask-restful/issues/394 Kind regards PS: I'm writing this about RAML but maybe API Blueprint https://apiblueprint.org/ or Swagger http://swagger.io/ are also good candidates
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2443/reactions" }
https://api.github.com/repos/psf/requests/issues/2443/timeline
null
completed
null
null
false
[ "> This idea is probably out of the scope of requests but we could talk about such idea here.\n\nIt is definitely out of the scope of requests. Since it is out of scope this is not the place to discuss it.\n" ]
https://api.github.com/repos/psf/requests/issues/2442
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2442/labels{/name}
https://api.github.com/repos/psf/requests/issues/2442/comments
https://api.github.com/repos/psf/requests/issues/2442/events
https://github.com/psf/requests/pull/2442
57,219,946
MDExOlB1bGxSZXF1ZXN0MjkwMzQ2NzE=
2,442
Update certificate bundle.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-02-10T19:05:03Z
2021-09-08T09:00:55Z
2015-02-10T19:05:56Z
MEMBER
resolved
This updates the cert bundle to what was produced by mkcert.org at Tue 10 Feb 2015 19:04:55 GMT.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2442/reactions" }
https://api.github.com/repos/psf/requests/issues/2442/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2442.diff", "html_url": "https://github.com/psf/requests/pull/2442", "merged_at": "2015-02-10T19:05:56Z", "patch_url": "https://github.com/psf/requests/pull/2442.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2442" }
true
[]
https://api.github.com/repos/psf/requests/issues/2441
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2441/labels{/name}
https://api.github.com/repos/psf/requests/issues/2441/comments
https://api.github.com/repos/psf/requests/issues/2441/events
https://github.com/psf/requests/pull/2441
56,954,028
MDExOlB1bGxSZXF1ZXN0Mjg4ODEyNjg=
2,441
Raise explicitly when exclusive parameters are provided
{ "avatar_url": "https://avatars.githubusercontent.com/u/259691?v=4", "events_url": "https://api.github.com/users/andreif/events{/privacy}", "followers_url": "https://api.github.com/users/andreif/followers", "following_url": "https://api.github.com/users/andreif/following{/other_user}", "gists_url": "https://api.github.com/users/andreif/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/andreif", "id": 259691, "login": "andreif", "node_id": "MDQ6VXNlcjI1OTY5MQ==", "organizations_url": "https://api.github.com/users/andreif/orgs", "received_events_url": "https://api.github.com/users/andreif/received_events", "repos_url": "https://api.github.com/users/andreif/repos", "site_admin": false, "starred_url": "https://api.github.com/users/andreif/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/andreif/subscriptions", "type": "User", "url": "https://api.github.com/users/andreif", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "eb6420", "default": false, "description": null, "id": 44501...
closed
true
null
[]
{ "closed_at": null, "closed_issues": 29, "created_at": "2013-11-17T11:29:34Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }, "description": null, "due_on": null, "html_url": "https://github.com/psf/requests/milestone/20", "id": 487518, "labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels", "node_id": "MDk6TWlsZXN0b25lNDg3NTE4", "number": 20, "open_issues": 12, "state": "open", "title": "3.0.0", "updated_at": "2024-05-19T18:43:00Z", "url": "https://api.github.com/repos/psf/requests/milestones/20" }
9
2015-02-08T14:52:56Z
2021-09-08T05:01:02Z
2016-01-30T03:53:32Z
NONE
resolved
It's a common case when one sends multipart request with json meta data. Currently, it is not clear that `json` argument is silently omitted. The same happens when both `data` and `json` are provided.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2441/reactions" }
https://api.github.com/repos/psf/requests/issues/2441/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2441.diff", "html_url": "https://github.com/psf/requests/pull/2441", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2441.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2441" }
true
[ "Thanks for the PR @andreif!\n\nI'm mostly -0.5 on this. I think the right approach is to fix the documentation, since that's clearly what's lacking here (in fact, I could find no examples of using the json parameter actually, and I take full blame for that).\n\nThat said, the API for multipart requests seems confu...
https://api.github.com/repos/psf/requests/issues/2440
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2440/labels{/name}
https://api.github.com/repos/psf/requests/issues/2440/comments
https://api.github.com/repos/psf/requests/issues/2440/events
https://github.com/psf/requests/pull/2440
56,813,369
MDExOlB1bGxSZXF1ZXN0Mjg4MDkzMTM=
2,440
Update to use readthedocs.org instead of rtfd.org
{ "avatar_url": "https://avatars.githubusercontent.com/u/201155?v=4", "events_url": "https://api.github.com/users/aquarion/events{/privacy}", "followers_url": "https://api.github.com/users/aquarion/followers", "following_url": "https://api.github.com/users/aquarion/following{/other_user}", "gists_url": "https://api.github.com/users/aquarion/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/aquarion", "id": 201155, "login": "aquarion", "node_id": "MDQ6VXNlcjIwMTE1NQ==", "organizations_url": "https://api.github.com/users/aquarion/orgs", "received_events_url": "https://api.github.com/users/aquarion/received_events", "repos_url": "https://api.github.com/users/aquarion/repos", "site_admin": false, "starred_url": "https://api.github.com/users/aquarion/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aquarion/subscriptions", "type": "User", "url": "https://api.github.com/users/aquarion", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-06T13:47:04Z
2021-09-08T09:00:56Z
2015-02-06T14:02:58Z
CONTRIBUTOR
resolved
https://toolbelt.rtfd.org currently causes an SSL error because the wildcard SSL cert is for *.readthedocs.org.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2440/reactions" }
https://api.github.com/repos/psf/requests/issues/2440/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2440.diff", "html_url": "https://github.com/psf/requests/pull/2440", "merged_at": "2015-02-06T14:02:58Z", "patch_url": "https://github.com/psf/requests/pull/2440.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2440" }
true
[ "Who added this link?\n\nThanks for fixing this @acquarion!\n" ]
https://api.github.com/repos/psf/requests/issues/2439
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2439/labels{/name}
https://api.github.com/repos/psf/requests/issues/2439/comments
https://api.github.com/repos/psf/requests/issues/2439/events
https://github.com/psf/requests/pull/2439
56,597,006
MDExOlB1bGxSZXF1ZXN0Mjg2ODA5OTA=
2,439
Suppress the warning if verify=False
{ "avatar_url": "https://avatars.githubusercontent.com/u/227426?v=4", "events_url": "https://api.github.com/users/zaitcev/events{/privacy}", "followers_url": "https://api.github.com/users/zaitcev/followers", "following_url": "https://api.github.com/users/zaitcev/following{/other_user}", "gists_url": "https://api.github.com/users/zaitcev/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zaitcev", "id": 227426, "login": "zaitcev", "node_id": "MDQ6VXNlcjIyNzQyNg==", "organizations_url": "https://api.github.com/users/zaitcev/orgs", "received_events_url": "https://api.github.com/users/zaitcev/received_events", "repos_url": "https://api.github.com/users/zaitcev/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zaitcev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zaitcev/subscriptions", "type": "User", "url": "https://api.github.com/users/zaitcev", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 78002701, "name": "Do Not Merge", "node_id": "MDU6TGFiZWw3ODAwMjcwMQ==", "url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge" } ]
closed
true
null
[]
null
5
2015-02-04T22:22:16Z
2021-09-08T09:00:57Z
2015-02-05T04:27:33Z
NONE
resolved
Setting verify to False differs from verify=None in being explicitly set, and therefore the warning being undesirable. See this for the a proposed alternative that involves importing implementation details of Requests onto the application: https://github.com/kennethreitz/requests/issues/2214#issuecomment-72941896 This fix avoids deep imports and pulling the knowledge of internals of Requests into the application. Fixes #2214
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2439/reactions" }
https://api.github.com/repos/psf/requests/issues/2439/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2439.diff", "html_url": "https://github.com/psf/requests/pull/2439", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2439.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2439" }
true
[ "Some notes:\n1. urllib3 is a separate project that we vendor in its entirety. This PR affects it, and so requires a separate change in that library.\n2. 'Explicit' is dependent on who you are. This is 'explicit' to the person who calls requests, but not to the person above them, if any. The warning is not just for...
https://api.github.com/repos/psf/requests/issues/2438
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2438/labels{/name}
https://api.github.com/repos/psf/requests/issues/2438/comments
https://api.github.com/repos/psf/requests/issues/2438/events
https://github.com/psf/requests/pull/2438
56,470,544
MDExOlB1bGxSZXF1ZXN0Mjg2MDgxOTQ=
2,438
add a timeout value to connection_error_invalid_port test to accelerate failure
{ "avatar_url": "https://avatars.githubusercontent.com/u/739280?v=4", "events_url": "https://api.github.com/users/colindickson/events{/privacy}", "followers_url": "https://api.github.com/users/colindickson/followers", "following_url": "https://api.github.com/users/colindickson/following{/other_user}", "gists_url": "https://api.github.com/users/colindickson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/colindickson", "id": 739280, "login": "colindickson", "node_id": "MDQ6VXNlcjczOTI4MA==", "organizations_url": "https://api.github.com/users/colindickson/orgs", "received_events_url": "https://api.github.com/users/colindickson/received_events", "repos_url": "https://api.github.com/users/colindickson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/colindickson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/colindickson/subscriptions", "type": "User", "url": "https://api.github.com/users/colindickson", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-04T02:17:49Z
2021-09-08T09:00:57Z
2015-02-04T07:01:10Z
CONTRIBUTOR
resolved
As mentioned here https://github.com/kennethreitz/requests/pull/2436 , one of the tests seemed like it was hanging. In fact, the test was just (correctly) waiting to hit its timeout value. We now give it a shorter timeout value to accelerate the testing process.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2438/reactions" }
https://api.github.com/repos/psf/requests/issues/2438/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2438.diff", "html_url": "https://github.com/psf/requests/pull/2438", "merged_at": "2015-02-04T07:01:10Z", "patch_url": "https://github.com/psf/requests/pull/2438.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2438" }
true
[ "Yeah, this feels sensible to me. :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2437
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2437/labels{/name}
https://api.github.com/repos/psf/requests/issues/2437/comments
https://api.github.com/repos/psf/requests/issues/2437/events
https://github.com/psf/requests/pull/2437
56,352,390
MDExOlB1bGxSZXF1ZXN0Mjg1MzY5Mzg=
2,437
quickstart: using a list as a value in query params
{ "avatar_url": "https://avatars.githubusercontent.com/u/912257?v=4", "events_url": "https://api.github.com/users/tomscytale/events{/privacy}", "followers_url": "https://api.github.com/users/tomscytale/followers", "following_url": "https://api.github.com/users/tomscytale/following{/other_user}", "gists_url": "https://api.github.com/users/tomscytale/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tomscytale", "id": 912257, "login": "tomscytale", "node_id": "MDQ6VXNlcjkxMjI1Nw==", "organizations_url": "https://api.github.com/users/tomscytale/orgs", "received_events_url": "https://api.github.com/users/tomscytale/received_events", "repos_url": "https://api.github.com/users/tomscytale/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tomscytale/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tomscytale/subscriptions", "type": "User", "url": "https://api.github.com/users/tomscytale", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-02-03T09:21:06Z
2021-09-08T09:00:58Z
2015-02-03T10:34:07Z
CONTRIBUTOR
resolved
Update docs - how to pass a list of values in a query
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2437/reactions" }
https://api.github.com/repos/psf/requests/issues/2437/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2437.diff", "html_url": "https://github.com/psf/requests/pull/2437", "merged_at": "2015-02-03T10:34:07Z", "patch_url": "https://github.com/psf/requests/pull/2437.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2437" }
true
[ ":cake: :star: Thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/2436
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2436/labels{/name}
https://api.github.com/repos/psf/requests/issues/2436/comments
https://api.github.com/repos/psf/requests/issues/2436/events
https://github.com/psf/requests/pull/2436
56,325,178
MDExOlB1bGxSZXF1ZXN0Mjg1MjE5Mzc=
2,436
Fix for failing test: test_connection_error
{ "avatar_url": "https://avatars.githubusercontent.com/u/739280?v=4", "events_url": "https://api.github.com/users/colindickson/events{/privacy}", "followers_url": "https://api.github.com/users/colindickson/followers", "following_url": "https://api.github.com/users/colindickson/following{/other_user}", "gists_url": "https://api.github.com/users/colindickson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/colindickson", "id": 739280, "login": "colindickson", "node_id": "MDQ6VXNlcjczOTI4MA==", "organizations_url": "https://api.github.com/users/colindickson/orgs", "received_events_url": "https://api.github.com/users/colindickson/received_events", "repos_url": "https://api.github.com/users/colindickson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/colindickson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/colindickson/subscriptions", "type": "User", "url": "https://api.github.com/users/colindickson", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-02-03T02:28:37Z
2021-09-08T09:00:57Z
2015-02-03T06:50:11Z
CONTRIBUTOR
resolved
http://fooobarbangbazbing.httpbin.org does not seem to be an unknown domain anymore. I've also split up this unit test into two tests since they test slightly different things.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2436/reactions" }
https://api.github.com/repos/psf/requests/issues/2436/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2436.diff", "html_url": "https://github.com/psf/requests/pull/2436", "merged_at": "2015-02-03T06:50:11Z", "patch_url": "https://github.com/psf/requests/pull/2436.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2436" }
true
[ "LGTM\n", "Thanks! :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2435
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2435/labels{/name}
https://api.github.com/repos/psf/requests/issues/2435/comments
https://api.github.com/repos/psf/requests/issues/2435/events
https://github.com/psf/requests/issues/2435
56,308,913
MDU6SXNzdWU1NjMwODkxMw==
2,435
ValueError: check_hostname requires server_hostname when making GET requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/1057616?v=4", "events_url": "https://api.github.com/users/jhuang314/events{/privacy}", "followers_url": "https://api.github.com/users/jhuang314/followers", "following_url": "https://api.github.com/users/jhuang314/following{/other_user}", "gists_url": "https://api.github.com/users/jhuang314/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jhuang314", "id": 1057616, "login": "jhuang314", "node_id": "MDQ6VXNlcjEwNTc2MTY=", "organizations_url": "https://api.github.com/users/jhuang314/orgs", "received_events_url": "https://api.github.com/users/jhuang314/received_events", "repos_url": "https://api.github.com/users/jhuang314/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jhuang314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jhuang314/subscriptions", "type": "User", "url": "https://api.github.com/users/jhuang314", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-02-02T23:15:23Z
2021-08-27T00:08:25Z
2015-02-03T06:52:41Z
NONE
resolved
I just built python 2.7.9 from source for RHEL5.7 and installed requests using easy_install. I get the following error when running ``` r = requests.get('https://api.github.com/user', auth=('user', 'pass')) ``` ``` Python 2.7.9 (default, Feb 2 2015, 17:03:23) [GCC 4.1.2 20080704 (Red Hat 4.1.2-52)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import requests >>> r = requests.get('https://api.github.com/user', auth=('user', 'pass')) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/api.py", line 65, in get return request('get', url, **kwargs) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/api.py", line 49, in request response = session.request(method=method, url=url, **kwargs) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/sessions.py", line 461, in request resp = self.send(prep, **send_kwargs) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/adapters.py", line 370, in send timeout=timeout File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 518, in urlopen body=body, headers=headers) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 322, in _make_request self._validate_conn(conn) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/packages/urllib3/connectionpool.py", line 727, in _validate_conn conn.connect() File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/packages/urllib3/connection.py", line 238, in connect ssl_version=resolved_ssl_version) File "/opt/python2.7/lib/python2.7/site-packages/requests-2.5.1-py2.7.egg/requests/packages/urllib3/util/ssl_.py", line 254, in ssl_wrap_socket return context.wrap_socket(sock) File "/opt/python2.7/lib/python2.7/ssl.py", line 350, in wrap_socket _context=self) File "/opt/python2.7/lib/python2.7/ssl.py", line 537, in __init__ raise ValueError("check_hostname requires server_hostname") ValueError: check_hostname requires server_hostname >>> ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2435/reactions" }
https://api.github.com/repos/psf/requests/issues/2435/timeline
null
completed
null
null
false
[ "Ok, so this happens in one of two cases: either `server_hostname` is `None`, or `ssl.HAS_SNI` is `False`. Can you print the result of `import ssl; print ssl.HAS_SNI` please?\n", "I get `False`\n", "Right, so the problem is that in Python 2.7.9 the assumption we make about `HAS_SNI` and hostname verification is...
https://api.github.com/repos/psf/requests/issues/2434
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2434/labels{/name}
https://api.github.com/repos/psf/requests/issues/2434/comments
https://api.github.com/repos/psf/requests/issues/2434/events
https://github.com/psf/requests/pull/2434
56,264,162
MDExOlB1bGxSZXF1ZXN0Mjg0ODUwNDQ=
2,434
Remove urllib3-specific section of iter_chunks
{ "avatar_url": "https://avatars.githubusercontent.com/u/82622?v=4", "events_url": "https://api.github.com/users/larsks/events{/privacy}", "followers_url": "https://api.github.com/users/larsks/followers", "following_url": "https://api.github.com/users/larsks/following{/other_user}", "gists_url": "https://api.github.com/users/larsks/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/larsks", "id": 82622, "login": "larsks", "node_id": "MDQ6VXNlcjgyNjIy", "organizations_url": "https://api.github.com/users/larsks/orgs", "received_events_url": "https://api.github.com/users/larsks/received_events", "repos_url": "https://api.github.com/users/larsks/repos", "site_admin": false, "starred_url": "https://api.github.com/users/larsks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/larsks/subscriptions", "type": "User", "url": "https://api.github.com/users/larsks", "user_view_type": "public" }
[]
closed
true
null
[]
null
8
2015-02-02T17:12:59Z
2021-09-08T08:00:56Z
2015-04-02T18:44:13Z
NONE
resolved
This commit resolves #2433 by using os.read() on self.raw.fileno() in all cases, and removes the use fo the self.raw.stream() iterator which would block rather than returning short reads.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2434/reactions" }
https://api.github.com/repos/psf/requests/issues/2434/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2434.diff", "html_url": "https://github.com/psf/requests/pull/2434", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2434.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2434" }
true
[ "I wonder if this shouldn't go into urllib3 instead, thereby giving the benefit there too. @shazow? @sigmavirus24?\n", "I'd like that.\n", "The existing documentation for `urllib3.response.stream` says:\n\n> A generator wrapper for the read() method. A call will block until\n> `amt` bytes have been read from th...
https://api.github.com/repos/psf/requests/issues/2433
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2433/labels{/name}
https://api.github.com/repos/psf/requests/issues/2433/comments
https://api.github.com/repos/psf/requests/issues/2433/events
https://github.com/psf/requests/issues/2433
56,194,102
MDU6SXNzdWU1NjE5NDEwMg==
2,433
iter_lines method will always hold the last response in the server in a buffer
{ "avatar_url": "https://avatars.githubusercontent.com/u/82622?v=4", "events_url": "https://api.github.com/users/larsks/events{/privacy}", "followers_url": "https://api.github.com/users/larsks/followers", "following_url": "https://api.github.com/users/larsks/following{/other_user}", "gists_url": "https://api.github.com/users/larsks/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/larsks", "id": 82622, "login": "larsks", "node_id": "MDQ6VXNlcjgyNjIy", "organizations_url": "https://api.github.com/users/larsks/orgs", "received_events_url": "https://api.github.com/users/larsks/received_events", "repos_url": "https://api.github.com/users/larsks/repos", "site_admin": false, "starred_url": "https://api.github.com/users/larsks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/larsks/subscriptions", "type": "User", "url": "https://api.github.com/users/larsks", "user_view_type": "public" }
[]
open
false
null
[]
{ "closed_at": null, "closed_issues": 29, "created_at": "2013-11-17T11:29:34Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }, "description": null, "due_on": null, "html_url": "https://github.com/psf/requests/milestone/20", "id": 487518, "labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels", "node_id": "MDk6TWlsZXN0b25lNDg3NTE4", "number": 20, "open_issues": 12, "state": "open", "title": "3.0.0", "updated_at": "2024-05-19T18:43:00Z", "url": "https://api.github.com/repos/psf/requests/milestones/20" }
10
2015-02-02T04:09:56Z
2019-12-11T22:42:18Z
null
NONE
null
The implementation of the `iter_lines` and `iter_content` methods in `requests` means that when receiving line-by-line data from a server in "push" mode, the latest line received from the server will almost invariably be smaller than the `chunk_size` parameter, causing the final read operation to block. A good example of this is the Kubernetes `watch` api, which produces one line of JSON output per event, like this: ``` {"type":"ADDED","object":{"kind":"Service","id":"kubernetes-ro","uid":"5718d954-a31a-11e4-8c74-20cf30467e62","creationTimestamp":"2015-01-23T11:10:25-05:00","selfLink":"/api/v1beta1/services/kubernetes-ro","resourceVersion":4,"apiVersion":"v1beta1","namespace":"default","port":80,"protocol":"TCP","labels":{"component":"apiserver","provider":"kubernetes"},"selector":null,"containerPort":0,"portalIP":"10.254.6.100"}} ``` If you compare the output of: ``` import requests r = requests.get('http://localhost:8080/api/v1beta1/watch/services', stream=True) for line in r.iter_lines(): print line ``` With the output of `curl` running against the same URL, you will see that the output from the Python code lags behind the output seen by `curl` by one line. I was able to work around this behavior by writing my own `iter_lines` method, which looks like this: ``` def iter_lines(fd, chunk_size=1024): '''Iterates over the content of a file-like object line-by-line.''' pending = None while True: chunk = os.read(fd.fileno(), chunk_size) if not chunk: break if pending is not None: chunk = pending + chunk pending = None lines = chunk.splitlines() if lines and lines[-1]: pending = lines.pop() for line in lines: yield line if pending: yield(pending) ``` This works around the problem partly by calling `os.read`, which will happily return fewer bytes than requested in `chunk_size`. With the above routing available, the following code behaves correctly: ``` import requests r = requests.get('http://localhost:8080/api/v1beta1/watch/services', stream=True) for line in iter_lines(r.raw): print line ``` This code will always print out the most recent reply from the server when it is received.
null
{ "+1": 1, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 1, "url": "https://api.github.com/repos/psf/requests/issues/2433/reactions" }
https://api.github.com/repos/psf/requests/issues/2433/timeline
null
null
null
null
false
[ "Generally speaking I'd be in favour of changing this behaviour. It's been stupid for a long time now.\n", "You also have my support. The trick is doing this in a way that's backwards compatible so we can help you out before 3.0\n", "The above change works for me with python 2.7.8 and 3.4.1 (both with `urllib3`...
https://api.github.com/repos/psf/requests/issues/2432
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2432/labels{/name}
https://api.github.com/repos/psf/requests/issues/2432/comments
https://api.github.com/repos/psf/requests/issues/2432/events
https://github.com/psf/requests/issues/2432
56,178,137
MDU6SXNzdWU1NjE3ODEzNw==
2,432
Implement limits for requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/23648?v=4", "events_url": "https://api.github.com/users/skorokithakis/events{/privacy}", "followers_url": "https://api.github.com/users/skorokithakis/followers", "following_url": "https://api.github.com/users/skorokithakis/following{/other_user}", "gists_url": "https://api.github.com/users/skorokithakis/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/skorokithakis", "id": 23648, "login": "skorokithakis", "node_id": "MDQ6VXNlcjIzNjQ4", "organizations_url": "https://api.github.com/users/skorokithakis/orgs", "received_events_url": "https://api.github.com/users/skorokithakis/received_events", "repos_url": "https://api.github.com/users/skorokithakis/repos", "site_admin": false, "starred_url": "https://api.github.com/users/skorokithakis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skorokithakis/subscriptions", "type": "User", "url": "https://api.github.com/users/skorokithakis", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "777777", "default": false, "description": null...
closed
true
null
[]
null
3
2015-02-01T21:03:40Z
2021-09-08T23:05:48Z
2015-04-06T08:41:29Z
NONE
resolved
Would anyone be interested in a `limit` parameter that timed out after X seconds or Y bytes received, as a DoS countermeasure? I want to implement one, but I'm not sure if you would accept the PR here or whether I should make it a third party library. It feels like it would be more fitting in requests itself, though.
{ "avatar_url": "https://avatars.githubusercontent.com/u/23648?v=4", "events_url": "https://api.github.com/users/skorokithakis/events{/privacy}", "followers_url": "https://api.github.com/users/skorokithakis/followers", "following_url": "https://api.github.com/users/skorokithakis/following{/other_user}", "gists_url": "https://api.github.com/users/skorokithakis/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/skorokithakis", "id": 23648, "login": "skorokithakis", "node_id": "MDQ6VXNlcjIzNjQ4", "organizations_url": "https://api.github.com/users/skorokithakis/orgs", "received_events_url": "https://api.github.com/users/skorokithakis/received_events", "repos_url": "https://api.github.com/users/skorokithakis/repos", "site_admin": false, "starred_url": "https://api.github.com/users/skorokithakis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skorokithakis/subscriptions", "type": "User", "url": "https://api.github.com/users/skorokithakis", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2432/reactions" }
https://api.github.com/repos/psf/requests/issues/2432/timeline
null
completed
null
null
false
[ "We've been in a perpetual feature freeze for some time now (see https://github.com/kennethreitz/requests/issues/1165) meaning that this would not be accepted as yet another keyword parameter. Additions like this are being added to the [requests-toolbelt](/sigmavirus24/requests-toolbelt).\n", "I'm proposing we cl...
https://api.github.com/repos/psf/requests/issues/2431
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2431/labels{/name}
https://api.github.com/repos/psf/requests/issues/2431/comments
https://api.github.com/repos/psf/requests/issues/2431/events
https://github.com/psf/requests/pull/2431
56,110,634
MDExOlB1bGxSZXF1ZXN0Mjg0MDg4Mjc=
2,431
Fixes problems with iter_lines when the delimiter is split
{ "avatar_url": "https://avatars.githubusercontent.com/u/903537?v=4", "events_url": "https://api.github.com/users/ianepperson/events{/privacy}", "followers_url": "https://api.github.com/users/ianepperson/followers", "following_url": "https://api.github.com/users/ianepperson/following{/other_user}", "gists_url": "https://api.github.com/users/ianepperson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ianepperson", "id": 903537, "login": "ianepperson", "node_id": "MDQ6VXNlcjkwMzUzNw==", "organizations_url": "https://api.github.com/users/ianepperson/orgs", "received_events_url": "https://api.github.com/users/ianepperson/received_events", "repos_url": "https://api.github.com/users/ianepperson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ianepperson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ianepperson/subscriptions", "type": "User", "url": "https://api.github.com/users/ianepperson", "user_view_type": "public" }
[ { "color": "eb6420", "default": false, "description": null, "id": 44501256, "name": "Breaking API Change", "node_id": "MDU6TGFiZWw0NDUwMTI1Ng==", "url": "https://api.github.com/repos/psf/requests/labels/Breaking%20API%20Change" } ]
closed
true
null
[]
{ "closed_at": null, "closed_issues": 29, "created_at": "2013-11-17T11:29:34Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }, "description": null, "due_on": null, "html_url": "https://github.com/psf/requests/milestone/20", "id": 487518, "labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels", "node_id": "MDk6TWlsZXN0b25lNDg3NTE4", "number": 20, "open_issues": 12, "state": "open", "title": "3.0.0", "updated_at": "2024-05-19T18:43:00Z", "url": "https://api.github.com/repos/psf/requests/milestones/20" }
8
2015-01-31T03:29:19Z
2021-09-08T01:21:36Z
2016-12-02T20:09:32Z
NONE
resolved
I ran into this problem today where my data would randomly have additional null strings from iter_lines. I added a test to show the issue, then fixed it. The only weirdness might be when no data comes back, how should iter_lines behave? Should there be a single yield of a null string, or should it just return without yielding anything? This edit performs the latter.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2431/reactions" }
https://api.github.com/repos/psf/requests/issues/2431/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2431.diff", "html_url": "https://github.com/psf/requests/pull/2431", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2431.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2431" }
true
[ "The specific issue happens when attempting to retrieve lines with a multi-byte delimiter. Very occasionally, the delimiter ends up split between data chunks. This results in the yielding of an additional null string. For reading an MJPEG data stream with `iter_lines('\\r\\n')` it was causing a garbled frame eve...