url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/2330 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2330/labels{/name} | https://api.github.com/repos/psf/requests/issues/2330/comments | https://api.github.com/repos/psf/requests/issues/2330/events | https://github.com/psf/requests/issues/2330 | 48,481,595 | MDU6SXNzdWU0ODQ4MTU5NQ== | 2,330 | Where can I download the Python, Sphinx or PyDoctor-generated documentation? | {
"avatar_url": "https://avatars.githubusercontent.com/u/3921062?v=4",
"events_url": "https://api.github.com/users/acgtyrant/events{/privacy}",
"followers_url": "https://api.github.com/users/acgtyrant/followers",
"following_url": "https://api.github.com/users/acgtyrant/following{/other_user}",
"gists_url": "https://api.github.com/users/acgtyrant/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/acgtyrant",
"id": 3921062,
"login": "acgtyrant",
"node_id": "MDQ6VXNlcjM5MjEwNjI=",
"organizations_url": "https://api.github.com/users/acgtyrant/orgs",
"received_events_url": "https://api.github.com/users/acgtyrant/received_events",
"repos_url": "https://api.github.com/users/acgtyrant/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/acgtyrant/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/acgtyrant/subscriptions",
"type": "User",
"url": "https://api.github.com/users/acgtyrant",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-11-12T07:34:06Z | 2021-09-08T23:07:02Z | 2014-11-12T07:38:18Z | NONE | resolved | I would like to [use Dash to convert the office documentation to a docset](http://kapeli.com/docsets), but I do not find any offline documentation...
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2330/reactions"
} | https://api.github.com/repos/psf/requests/issues/2330/timeline | null | completed | null | null | false | [
"You need to render the documentation. Checkout the code from this repository and run `pip install Sphinx`. Then, type `cd docs && make html`. That will build the documentation you can then point doc2dash at.\n",
"Done, thank you for your tip!\n"
] |
https://api.github.com/repos/psf/requests/issues/2329 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2329/labels{/name} | https://api.github.com/repos/psf/requests/issues/2329/comments | https://api.github.com/repos/psf/requests/issues/2329/events | https://github.com/psf/requests/issues/2329 | 48,434,475 | MDU6SXNzdWU0ODQzNDQ3NQ== | 2,329 | Can't override Content-Length | {
"avatar_url": "https://avatars.githubusercontent.com/u/2456311?v=4",
"events_url": "https://api.github.com/users/asnelzin/events{/privacy}",
"followers_url": "https://api.github.com/users/asnelzin/followers",
"following_url": "https://api.github.com/users/asnelzin/following{/other_user}",
"gists_url": "https://api.github.com/users/asnelzin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asnelzin",
"id": 2456311,
"login": "asnelzin",
"node_id": "MDQ6VXNlcjI0NTYzMTE=",
"organizations_url": "https://api.github.com/users/asnelzin/orgs",
"received_events_url": "https://api.github.com/users/asnelzin/received_events",
"repos_url": "https://api.github.com/users/asnelzin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asnelzin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asnelzin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asnelzin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-11-11T21:03:04Z | 2021-09-08T23:07:01Z | 2014-11-12T18:35:39Z | CONTRIBUTOR | resolved | Come here from https://github.com/jakubroztocil/httpie/issues/269
Looks like this code doesn't work properly:
```
>>> import requests
>>> r = requests.post('http://httpbin.org/post', headers={'Content-Length': 'not zero'})
>>> r.request.headers
{'Content-Length': '0', 'Connection': 'keep-alive', 'Accept-Encoding': 'gzip, deflate', 'Accept': '*/*', 'User- Agent': 'python-requests/2.4.3 CPython/2.7.6 Darwin/14.0.0'}
```
However, curl doing it perfectly:
```
$ curl --verbose -X POST 'http://httpbin.org/post' --header 'Content-Length:not zero'
* Hostname was NOT found in DNS cache
* Trying 50.19.91.97...
* Connected to httpbin.org (50.19.91.97) port 80 (#0)
> POST /post HTTP/1.1
> User-Agent: curl/7.37.1
> Host: httpbin.org
> Accept: */*
> Content-Length:not zero
```
Seems like a bug there.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2329/reactions"
} | https://api.github.com/repos/psf/requests/issues/2329/timeline | null | completed | null | null | false | [
"Eh, I'm on the fence. I don't think requests should be able to generate any invalid input provided to it by the user. We're in the position of making user's lives easier, and sometimes that means ignoring their mistakes.\n\nHowever, this violates our general principle of leaving the user's headers where they are. ... |
https://api.github.com/repos/psf/requests/issues/2328 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2328/labels{/name} | https://api.github.com/repos/psf/requests/issues/2328/comments | https://api.github.com/repos/psf/requests/issues/2328/events | https://github.com/psf/requests/issues/2328 | 48,146,830 | MDU6SXNzdWU0ODE0NjgzMA== | 2,328 | Add prepare hook | {
"avatar_url": "https://avatars.githubusercontent.com/u/458976?v=4",
"events_url": "https://api.github.com/users/NullSoldier/events{/privacy}",
"followers_url": "https://api.github.com/users/NullSoldier/followers",
"following_url": "https://api.github.com/users/NullSoldier/following{/other_user}",
"gists_url": "https://api.github.com/users/NullSoldier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/NullSoldier",
"id": 458976,
"login": "NullSoldier",
"node_id": "MDQ6VXNlcjQ1ODk3Ng==",
"organizations_url": "https://api.github.com/users/NullSoldier/orgs",
"received_events_url": "https://api.github.com/users/NullSoldier/received_events",
"repos_url": "https://api.github.com/users/NullSoldier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/NullSoldier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NullSoldier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/NullSoldier",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | null | [] | null | 2 | 2014-11-08T00:23:10Z | 2021-09-08T23:07:02Z | 2014-11-08T08:54:44Z | NONE | resolved | It would be nice to have a pre_prepare_request hook.
I'm doing frequent requests to an API which requires a query parameter, and a custom header. I created an HTTP adapter to provide the query parameter and the header (because session won't help me with the query parameter).
I was hoping I could also use a hook to modify the url from /bar/ -> foo.com/bar/ because urls made on this adapter shouldn't require the host since you have to use something crappy like get(get_url('/bar/')) just to prepend the host everywhere in a sensible way.
If I had a pre_prepare hook I could modify the URL here.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/458976?v=4",
"events_url": "https://api.github.com/users/NullSoldier/events{/privacy}",
"followers_url": "https://api.github.com/users/NullSoldier/followers",
"following_url": "https://api.github.com/users/NullSoldier/following{/other_user}",
"gists_url": "https://api.github.com/users/NullSoldier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/NullSoldier",
"id": 458976,
"login": "NullSoldier",
"node_id": "MDQ6VXNlcjQ1ODk3Ng==",
"organizations_url": "https://api.github.com/users/NullSoldier/orgs",
"received_events_url": "https://api.github.com/users/NullSoldier/received_events",
"repos_url": "https://api.github.com/users/NullSoldier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/NullSoldier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NullSoldier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/NullSoldier",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2328/reactions"
} | https://api.github.com/repos/psf/requests/issues/2328/timeline | null | completed | null | null | false | [
"Once upon a time requests had a hook like you describe but we removed it because almost no one was using it. You're one of the first people to request this be added back. Let me propose a different way of addressing your problem:\n\n``` python\nclass NullSoldierSession(requests.Session):\n def request(self, met... |
https://api.github.com/repos/psf/requests/issues/2327 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2327/labels{/name} | https://api.github.com/repos/psf/requests/issues/2327/comments | https://api.github.com/repos/psf/requests/issues/2327/events | https://github.com/psf/requests/issues/2327 | 48,106,439 | MDU6SXNzdWU0ODEwNjQzOQ== | 2,327 | Feature Request: Response MaxFilesize and MaxConnectionTimeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/204779?v=4",
"events_url": "https://api.github.com/users/jvanasco/events{/privacy}",
"followers_url": "https://api.github.com/users/jvanasco/followers",
"following_url": "https://api.github.com/users/jvanasco/following{/other_user}",
"gists_url": "https://api.github.com/users/jvanasco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jvanasco",
"id": 204779,
"login": "jvanasco",
"node_id": "MDQ6VXNlcjIwNDc3OQ==",
"organizations_url": "https://api.github.com/users/jvanasco/orgs",
"received_events_url": "https://api.github.com/users/jvanasco/received_events",
"repos_url": "https://api.github.com/users/jvanasco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jvanasco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvanasco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jvanasco",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 5 | 2014-11-07T17:15:13Z | 2021-09-08T23:06:09Z | 2015-01-19T09:16:19Z | CONTRIBUTOR | resolved | Total Request Timeout is a request in #1928, but I think it could be implemented at the same time as a Filesize Max.
As a user of requests, there are 2 issues I often run into:
- I don't necessarily know how large the remote file is. It is 100k or 2GB? Large files can create issues based on my machine's memory and filesystem. I can't trust the data in response headers, as it's not always provided or correct.
- I can often encounter slow connections or data streams, where information is continually provided. The current read/connection timeouts handle the amount of time between data being sent -- but not the overall amount of time.
Both of these issues can be handled by developers using the current requests API, but variants of these issues often appear on StackOverflow and this issue tracker -- and I think they could be more elegantly handled within requests and (mostly) a single chunk of code.
My suggestion is the following:
- new (default=None) arguments for `max_filesize` and `max_connectiontime`
- if either are set, the response is read in chunks (r.raw.read)
- if the full response is read, the data is transferred to the content stash
- if only a portion of the response is read, an Exception is raised. details about the connection and the read response data are available on the exception instance.
I think this logic would mostly go in `requests.apapters.HTTPAdapter.send`, but I could be wrong
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2327/reactions"
} | https://api.github.com/repos/psf/requests/issues/2327/timeline | null | completed | null | null | false | [
"There's been some discussion about max_connectiontime in the past. It is pretty difficult to do inline; the best way to implement this would probably be to put the request in a thread and put a `threading.Timer` on the thread so it either completes or fails in a specified amount of time.\n\nMaybe this could go in ... |
https://api.github.com/repos/psf/requests/issues/2326 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2326/labels{/name} | https://api.github.com/repos/psf/requests/issues/2326/comments | https://api.github.com/repos/psf/requests/issues/2326/events | https://github.com/psf/requests/pull/2326 | 48,093,227 | MDExOlB1bGxSZXF1ZXN0MjQwNTk2OTk= | 2,326 | Close sessions created in the functional API | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 6 | 2014-11-07T15:27:05Z | 2021-09-08T09:01:15Z | 2014-11-12T17:34:14Z | CONTRIBUTOR | resolved | This is related to #1882 and #1685. By calling close on the session, we
clear the PoolManager operated by the Session and close all sockets.
Fixes #1882
Partially-fixes #1685
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2326/reactions"
} | https://api.github.com/repos/psf/requests/issues/2326/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2326.diff",
"html_url": "https://github.com/psf/requests/pull/2326",
"merged_at": "2014-11-12T17:34:14Z",
"patch_url": "https://github.com/psf/requests/pull/2326.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2326"
} | true | [
"Eh, I'm +0.5. I still think that #1882 is unnecessary whining on the part of CPython, but never mind. ;)\n",
"@Lukasa it may be CPython being overly cautious but it will be a problem on PyPy. Stuff like [this](https://bugs.launchpad.net/dateutil/+bug/1376343) can cause an application to crash because there are t... |
https://api.github.com/repos/psf/requests/issues/2325 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2325/labels{/name} | https://api.github.com/repos/psf/requests/issues/2325/comments | https://api.github.com/repos/psf/requests/issues/2325/events | https://github.com/psf/requests/issues/2325 | 48,091,834 | MDU6SXNzdWU0ODA5MTgzNA== | 2,325 | How to upload a single file to a specific folder in Google Drive. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5614580?v=4",
"events_url": "https://api.github.com/users/ajoys/events{/privacy}",
"followers_url": "https://api.github.com/users/ajoys/followers",
"following_url": "https://api.github.com/users/ajoys/following{/other_user}",
"gists_url": "https://api.github.com/users/ajoys/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ajoys",
"id": 5614580,
"login": "ajoys",
"node_id": "MDQ6VXNlcjU2MTQ1ODA=",
"organizations_url": "https://api.github.com/users/ajoys/orgs",
"received_events_url": "https://api.github.com/users/ajoys/received_events",
"repos_url": "https://api.github.com/users/ajoys/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ajoys/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ajoys/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ajoys",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-11-07T15:14:31Z | 2021-09-08T23:07:03Z | 2014-11-07T15:39:33Z | NONE | resolved | Hello,
I currently in the process of trying to upload a file to a specific Google Drive folder. I have tried creating a JSON object as indicated by the Drive api, and set it as the JSON attribute in the call, however my file still gets sent to the root directory, named as "Untitled".
Here is my code:
```
title = files_to_send[0].name.split('/')[-1]
request_body = {'title':title, "parents": [{"id": path_id}]}
status = self.call.post('https://www.googleapis.com/upload/drive/v2/files', data=files_to_send[0], json=request_body)
```
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2325/reactions"
} | https://api.github.com/repos/psf/requests/issues/2325/timeline | null | completed | null | null | false | [
"Thanks for using requests!\n\nUnfortunately, this is a bug tracker, used to track bugs and feature requests. This is a usage question. You should direct your question to Stack Overflow.\n",
"Alright, sorry about that!\n",
"That's quite alright!\n"
] |
https://api.github.com/repos/psf/requests/issues/2324 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2324/labels{/name} | https://api.github.com/repos/psf/requests/issues/2324/comments | https://api.github.com/repos/psf/requests/issues/2324/events | https://github.com/psf/requests/issues/2324 | 48,083,896 | MDU6SXNzdWU0ODA4Mzg5Ng== | 2,324 | IronPython vs Six : reraise() and _getframe() | {
"avatar_url": "https://avatars.githubusercontent.com/u/1540582?v=4",
"events_url": "https://api.github.com/users/tcalmant/events{/privacy}",
"followers_url": "https://api.github.com/users/tcalmant/followers",
"following_url": "https://api.github.com/users/tcalmant/following{/other_user}",
"gists_url": "https://api.github.com/users/tcalmant/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tcalmant",
"id": 1540582,
"login": "tcalmant",
"node_id": "MDQ6VXNlcjE1NDA1ODI=",
"organizations_url": "https://api.github.com/users/tcalmant/orgs",
"received_events_url": "https://api.github.com/users/tcalmant/received_events",
"repos_url": "https://api.github.com/users/tcalmant/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tcalmant/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tcalmant/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tcalmant",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-11-07T13:54:29Z | 2021-09-08T23:07:05Z | 2014-11-07T14:11:20Z | NONE | resolved | The definition of `exec_` and `reraise()` methods from the `six` module seems to be the only thing that prevent using `requests` in IronPython.
The exact module is: requests.packages.urllib3.packages.six (around line 320)
The problem is that `sys._getframe()` is not available in IronPython.
As the `exec_` method doesn't seem to be used in `requests` nor in `urllib3`, I've made a small monkey patch to correct it, but I don't know if I have to make a pull request here or in the repository of six.
The patch declares "reraise" at module level, like for Python 3, instead of doing so calling `exec_`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2324/reactions"
} | https://api.github.com/repos/psf/requests/issues/2324/timeline | null | completed | null | null | false | [
"@tcalmant the `exec_` method is used in `six` though, which is used by `urllib3`. The latest version of six [still uses `sys._getframe`](https://bitbucket.org/gutworth/six/src/c17477e81e482d34bf3cda043b2eca643084e5fd/six.py?at=default#cl-647). You should raise this bug there and then **if you are successful** in g... |
https://api.github.com/repos/psf/requests/issues/2323 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2323/labels{/name} | https://api.github.com/repos/psf/requests/issues/2323/comments | https://api.github.com/repos/psf/requests/issues/2323/events | https://github.com/psf/requests/pull/2323 | 48,058,734 | MDExOlB1bGxSZXF1ZXN0MjQwMzkwNTI= | 2,323 | Pass strict to urllib3. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-11-07T08:22:25Z | 2021-09-08T08:00:52Z | 2014-11-07T14:12:24Z | MEMBER | resolved | This change passes `strict=True` to urllib3, and thus to httplib.
As per the documentation:
> the optional parameter strict (which defaults to a false value) causes BadStatusLine to be raised if the status line can’t be parsed as a valid HTTP/1.0 or 1.1 status line.
Merging this would mean that requests is now actively limiting itself to HTTP/1.0+, excluding HTTP/0.9 (who the hell cares?). This is _already_ requests behaviour on Python 3, it simply brings it into consistency in Python 2.
Note that, despite the fact that requests already sort of does this, this change is arguably breaking.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2323/reactions"
} | https://api.github.com/repos/psf/requests/issues/2323/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2323.diff",
"html_url": "https://github.com/psf/requests/pull/2323",
"merged_at": "2014-11-07T14:12:24Z",
"patch_url": "https://github.com/psf/requests/pull/2323.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2323"
} | true | [
"Ugh, should say that this resolves #1869.\n",
"LGTM. :+1: \n"
] |
https://api.github.com/repos/psf/requests/issues/2322 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2322/labels{/name} | https://api.github.com/repos/psf/requests/issues/2322/comments | https://api.github.com/repos/psf/requests/issues/2322/events | https://github.com/psf/requests/issues/2322 | 48,043,374 | MDU6SXNzdWU0ODA0MzM3NA== | 2,322 | requests is not happy with a shoutcast stream | {
"avatar_url": "https://avatars.githubusercontent.com/u/204779?v=4",
"events_url": "https://api.github.com/users/jvanasco/events{/privacy}",
"followers_url": "https://api.github.com/users/jvanasco/followers",
"following_url": "https://api.github.com/users/jvanasco/following{/other_user}",
"gists_url": "https://api.github.com/users/jvanasco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jvanasco",
"id": 204779,
"login": "jvanasco",
"node_id": "MDQ6VXNlcjIwNDc3OQ==",
"organizations_url": "https://api.github.com/users/jvanasco/orgs",
"received_events_url": "https://api.github.com/users/jvanasco/received_events",
"repos_url": "https://api.github.com/users/jvanasco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jvanasco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvanasco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jvanasco",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "e11d21",
"default": false,
"description": null... | closed | true | null | [] | null | 6 | 2014-11-07T03:14:23Z | 2021-09-08T23:05:56Z | 2014-11-07T08:15:19Z | CONTRIBUTOR | resolved | I have a web indexer that came across this url:
```
url = 'http://voxsc1.somafm.com:8500/'
```
Requests does not like this (2.3, 2.4.3)
```
import requests
r = requests.get(url, timeout=5)
```
this causes python to just hang.
from what I can tell, this url will somehow render/redirect on a modern browser.
the first bit of data are :
ICY 200 OK
icy-notice1:<BR>This stream requires <a href="http://www.winamp.com/">Winamp</a><BR>
icy-notice2:SHOUTcast Distributed Network Audio Server/Linux v1.9.5<BR>
icy-name:Ill Street Lounge: Classic bachelor pad, playful exotica and vintage music of tomorrow. [SomaFM]
icy-genre:Exotica Lounge
icy-url:http://somafm.com
content-type:audio/mpeg
icy-pub:1
icy-br:128
`curl -I` will give an error
`curl` will show a data stream
it would be nice if requests could detect urls like this and just stop.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2322/reactions"
} | https://api.github.com/repos/psf/requests/issues/2322/timeline | null | completed | null | null | false | [
"> it would be nice if requests could detect urls like this and just stop.\n\nWhat exactly are we supposed to detect? Using a timeout doesn't matter because the server is continuously sending data. The connection is fine. The way to prevent this from hanging your indexer is to use `stream=True`. Passing that makes ... |
https://api.github.com/repos/psf/requests/issues/2321 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2321/labels{/name} | https://api.github.com/repos/psf/requests/issues/2321/comments | https://api.github.com/repos/psf/requests/issues/2321/events | https://github.com/psf/requests/issues/2321 | 48,043,038 | MDU6SXNzdWU0ODA0MzAzOA== | 2,321 | 'verify' with custom ca bundle | {
"avatar_url": "https://avatars.githubusercontent.com/u/426784?v=4",
"events_url": "https://api.github.com/users/remram44/events{/privacy}",
"followers_url": "https://api.github.com/users/remram44/followers",
"following_url": "https://api.github.com/users/remram44/following{/other_user}",
"gists_url": "https://api.github.com/users/remram44/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/remram44",
"id": 426784,
"login": "remram44",
"node_id": "MDQ6VXNlcjQyNjc4NA==",
"organizations_url": "https://api.github.com/users/remram44/orgs",
"received_events_url": "https://api.github.com/users/remram44/received_events",
"repos_url": "https://api.github.com/users/remram44/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/remram44/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/remram44/subscriptions",
"type": "User",
"url": "https://api.github.com/users/remram44",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] | closed | true | null | [] | null | 9 | 2014-11-07T03:07:31Z | 2021-09-08T23:07:04Z | 2014-11-07T04:54:42Z | CONTRIBUTOR | resolved | It seems that currently, if 'verify' is set to the filename of a ca_bundle, a certificate that doesn't match it **will be accepted without SSLError** if it matches the global bundle. This is counter-intuitive, unclear in the documentation and prevents users from actually overriding the ca_bundle with their own.
Example:
```
openssl req -nodes -x509 -days 3650 \
-newkey rsa:2048 -keyout ca-key.pem \
-out ca-cert.pem \
-subj "/C=US/ST=New York/L=New York/O=remram.fr/CN=ca.remram.fr"
python -c "import requests; print(requests.get('https://google.com/', verify='ca-cert.pem'))"
```
My version is 2.4.3, on OS X.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2321/reactions"
} | https://api.github.com/repos/psf/requests/issues/2321/timeline | null | completed | null | null | false | [
"``` python\n~/sandbox/requests (master) python\nPython 2.7.8 (default, Aug 24 2014, 21:26:19)\n[GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.40)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n>>> import requests\n>>> r = requests.get('https://google.com', verify='..... |
https://api.github.com/repos/psf/requests/issues/2320 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2320/labels{/name} | https://api.github.com/repos/psf/requests/issues/2320/comments | https://api.github.com/repos/psf/requests/issues/2320/events | https://github.com/psf/requests/issues/2320 | 47,730,367 | MDU6SXNzdWU0NzczMDM2Nw== | 2,320 | Getting a request with a BOM mark | {
"avatar_url": "https://avatars.githubusercontent.com/u/1440143?v=4",
"events_url": "https://api.github.com/users/GP89/events{/privacy}",
"followers_url": "https://api.github.com/users/GP89/followers",
"following_url": "https://api.github.com/users/GP89/following{/other_user}",
"gists_url": "https://api.github.com/users/GP89/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GP89",
"id": 1440143,
"login": "GP89",
"node_id": "MDQ6VXNlcjE0NDAxNDM=",
"organizations_url": "https://api.github.com/users/GP89/orgs",
"received_events_url": "https://api.github.com/users/GP89/received_events",
"repos_url": "https://api.github.com/users/GP89/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GP89/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GP89/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GP89",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-11-04T16:09:20Z | 2021-09-08T23:07:06Z | 2014-11-04T17:58:22Z | NONE | resolved | I was using `requests` to get some json form a url. I noticed at the start it had a weird unicode character. The start of the response text was `u'\ufeff[{"Hos...` (the message was sent with content-type of `text/javascript; charset=utf-8`)
After looking into it a bit, it looks like it was a [BOM mark](http://en.wikipedia.org/wiki/Byte_order_mark). Looking for solutions I came across [this post](http://stackoverflow.com/a/14532226/659346) which suggests decoding the string, which would work fine using `urllib2` as it gives back the byte string. But in `requests` the response objects `text` attribute is already decoded with the BOM mark included.
I was wondering if this was something that could be addressed automatically? Or maybe it might end up biting people who expected to see that mark in the response text?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1440143?v=4",
"events_url": "https://api.github.com/users/GP89/events{/privacy}",
"followers_url": "https://api.github.com/users/GP89/followers",
"following_url": "https://api.github.com/users/GP89/following{/other_user}",
"gists_url": "https://api.github.com/users/GP89/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GP89",
"id": 1440143,
"login": "GP89",
"node_id": "MDQ6VXNlcjE0NDAxNDM=",
"organizations_url": "https://api.github.com/users/GP89/orgs",
"received_events_url": "https://api.github.com/users/GP89/received_events",
"repos_url": "https://api.github.com/users/GP89/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GP89/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GP89/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GP89",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2320/reactions"
} | https://api.github.com/repos/psf/requests/issues/2320/timeline | null | completed | null | null | false | [
"If the BOM isn't getting stripped, the problem is that we're decoding it as non-UTF-16. In such a case, the BOM is strictly unnecessary, and a leading BOM is in fact not a BOM but a unicode zero-width non-breaking space character.\n\nNow, the content-type header seems to suggest it's not a BOM, so we're doing what... |
https://api.github.com/repos/psf/requests/issues/2319 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2319/labels{/name} | https://api.github.com/repos/psf/requests/issues/2319/comments | https://api.github.com/repos/psf/requests/issues/2319/events | https://github.com/psf/requests/issues/2319 | 47,622,569 | MDU6SXNzdWU0NzYyMjU2OQ== | 2,319 | Expose retry settings available in urllib3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/202341?v=4",
"events_url": "https://api.github.com/users/neuroid/events{/privacy}",
"followers_url": "https://api.github.com/users/neuroid/followers",
"following_url": "https://api.github.com/users/neuroid/following{/other_user}",
"gists_url": "https://api.github.com/users/neuroid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/neuroid",
"id": 202341,
"login": "neuroid",
"node_id": "MDQ6VXNlcjIwMjM0MQ==",
"organizations_url": "https://api.github.com/users/neuroid/orgs",
"received_events_url": "https://api.github.com/users/neuroid/received_events",
"repos_url": "https://api.github.com/users/neuroid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/neuroid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/neuroid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/neuroid",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-11-03T17:47:04Z | 2021-09-08T23:07:07Z | 2014-11-03T17:50:46Z | NONE | resolved | Hi,
Are there any plans to expose the [retry settings available in urllib3](https://urllib3.readthedocs.org/en/latest/helpers.html#urllib3.util.retry.Retry)? The possibility of configuring the `backoff_factor` would be quite useful.
Best,
L
| {
"avatar_url": "https://avatars.githubusercontent.com/u/202341?v=4",
"events_url": "https://api.github.com/users/neuroid/events{/privacy}",
"followers_url": "https://api.github.com/users/neuroid/followers",
"following_url": "https://api.github.com/users/neuroid/following{/other_user}",
"gists_url": "https://api.github.com/users/neuroid/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/neuroid",
"id": 202341,
"login": "neuroid",
"node_id": "MDQ6VXNlcjIwMjM0MQ==",
"organizations_url": "https://api.github.com/users/neuroid/orgs",
"received_events_url": "https://api.github.com/users/neuroid/received_events",
"repos_url": "https://api.github.com/users/neuroid/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/neuroid/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/neuroid/subscriptions",
"type": "User",
"url": "https://api.github.com/users/neuroid",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2319/reactions"
} | https://api.github.com/repos/psf/requests/issues/2319/timeline | null | completed | null | null | false | [
"Yup - see https://github.com/kennethreitz/requests/pull/2216\n\n## \n\nKevin Burke\nphone: 925.271.7005 | twentymilliseconds.com\n\nOn Mon, Nov 3, 2014 at 9:47 AM, Łukasz Kawczyński notifications@github.com\nwrote:\n\n> Hi,\n> \n> Are there any plans to expose the retry settings available in urllib3\n> https://url... |
https://api.github.com/repos/psf/requests/issues/2318 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2318/labels{/name} | https://api.github.com/repos/psf/requests/issues/2318/comments | https://api.github.com/repos/psf/requests/issues/2318/events | https://github.com/psf/requests/issues/2318 | 47,557,987 | MDU6SXNzdWU0NzU1Nzk4Nw== | 2,318 | Allow parsing str url in Python2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/561729?v=4",
"events_url": "https://api.github.com/users/jichifly/events{/privacy}",
"followers_url": "https://api.github.com/users/jichifly/followers",
"following_url": "https://api.github.com/users/jichifly/following{/other_user}",
"gists_url": "https://api.github.com/users/jichifly/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jichifly",
"id": 561729,
"login": "jichifly",
"node_id": "MDQ6VXNlcjU2MTcyOQ==",
"organizations_url": "https://api.github.com/users/jichifly/orgs",
"received_events_url": "https://api.github.com/users/jichifly/received_events",
"repos_url": "https://api.github.com/users/jichifly/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jichifly/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jichifly/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jichifly",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-11-03T02:09:29Z | 2021-09-08T23:07:06Z | 2014-11-03T20:05:49Z | NONE | resolved | Is it possible to add an option to disable decoding str URL to unicode in requests.get?
I am using Python 2.7.8. After a recent update to the requests 2.4.3, I find I am not able to pass SHIFT-JIS str/bytes URL to requests.get.
I am using requests to access some Japanese websites, which require raw SHIFT-JIS encoding string as URL.
But requests.get will always decode my SHIFT-JIS str URL to UTF8 in the beginning of models.py::prepare_url, which will raise decode error. But if I pass UTF8 URL, I am not able to get correct response from those Japanese websites.
If I restore the old version code in models.py::prepare_url as follows, it will work for me like before. I am wondering is it possible to add an option to disable modifying the URL passed to requests?
```
# if isinstance(url, bytes):
# url = url.decode('utf8')
# else:
# url = unicode(url) if is_py2 else str(url)
try:
url = unicode(url)
except NameError:
# We're on Python 3.
url = str(url)
except UnicodeDecodeError:
pass
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/561729?v=4",
"events_url": "https://api.github.com/users/jichifly/events{/privacy}",
"followers_url": "https://api.github.com/users/jichifly/followers",
"following_url": "https://api.github.com/users/jichifly/following{/other_user}",
"gists_url": "https://api.github.com/users/jichifly/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jichifly",
"id": 561729,
"login": "jichifly",
"node_id": "MDQ6VXNlcjU2MTcyOQ==",
"organizations_url": "https://api.github.com/users/jichifly/orgs",
"received_events_url": "https://api.github.com/users/jichifly/received_events",
"repos_url": "https://api.github.com/users/jichifly/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jichifly/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jichifly/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jichifly",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2318/reactions"
} | https://api.github.com/repos/psf/requests/issues/2318/timeline | null | completed | null | null | false | [
"Thanks for this report!\n\nWhen you say the remote website requires SHIFT-JIS in their URL, which part of the URL do they require it in? SHIFT-JIS is totally unacceptable in the host part of the URL, so presumably it's either the path or the parameters.\n\nIf it's the parameters, I believe you can pass SHIFT-JIS b... |
https://api.github.com/repos/psf/requests/issues/2317 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2317/labels{/name} | https://api.github.com/repos/psf/requests/issues/2317/comments | https://api.github.com/repos/psf/requests/issues/2317/events | https://github.com/psf/requests/pull/2317 | 47,473,505 | MDExOlB1bGxSZXF1ZXN0MjM3MTQ4MzA= | 2,317 | Use to_native_string instead of builtin_str | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 2 | 2014-11-01T02:20:16Z | 2021-09-08T09:01:18Z | 2014-11-01T14:04:09Z | CONTRIBUTOR | resolved | Fixes #2316
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2317/reactions"
} | https://api.github.com/repos/psf/requests/issues/2317/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2317.diff",
"html_url": "https://github.com/psf/requests/pull/2317",
"merged_at": "2014-11-01T14:04:09Z",
"patch_url": "https://github.com/psf/requests/pull/2317.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2317"
} | true | [
"LGTM. :cake:\n",
":sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/2316 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2316/labels{/name} | https://api.github.com/repos/psf/requests/issues/2316/comments | https://api.github.com/repos/psf/requests/issues/2316/events | https://github.com/psf/requests/issues/2316 | 47,449,626 | MDU6SXNzdWU0NzQ0OTYyNg== | 2,316 | method = builtin_str(method) problem | {
"avatar_url": "https://avatars.githubusercontent.com/u/1753903?v=4",
"events_url": "https://api.github.com/users/gddk/events{/privacy}",
"followers_url": "https://api.github.com/users/gddk/followers",
"following_url": "https://api.github.com/users/gddk/following{/other_user}",
"gists_url": "https://api.github.com/users/gddk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gddk",
"id": 1753903,
"login": "gddk",
"node_id": "MDQ6VXNlcjE3NTM5MDM=",
"organizations_url": "https://api.github.com/users/gddk/orgs",
"received_events_url": "https://api.github.com/users/gddk/received_events",
"repos_url": "https://api.github.com/users/gddk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gddk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gddk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gddk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-10-31T22:13:00Z | 2021-09-08T23:07:07Z | 2014-11-01T14:04:09Z | NONE | resolved | In requests/sessions.py is a command:
method = builtin_str(method)
Converts method from
b’GET’
to
"b'GET’"
Which is the literal string, no longer a binary string. When requests tries to use the method "b'GET’”, it gets a 404 Not Found response.
I am using python3.4 and python-neutronclient (2.3.9) with requests (2.4.3). neutronclient is broken because it uses this "args = utils.safe_encode_list(args)" command which converts all the values to binary string, including method.
I'm not sure if this is a bug with neutronclient or a bug with requests, but I'm starting here. Seems if requests handled the method value being a binary string, we wouldn't have any problem.
Also, I tried in python2.6 and this bug doesn't exist there. Some difference between 2.6 and 3.4 makes this not work right.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2316/reactions"
} | https://api.github.com/repos/psf/requests/issues/2316/timeline | null | completed | null | null | false | [
"Ugh. This should have been caught and replaced with `to_native_str`. This is definitely a requests bug.\n"
] |
https://api.github.com/repos/psf/requests/issues/2315 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2315/labels{/name} | https://api.github.com/repos/psf/requests/issues/2315/comments | https://api.github.com/repos/psf/requests/issues/2315/events | https://github.com/psf/requests/issues/2315 | 47,349,561 | MDU6SXNzdWU0NzM0OTU2MQ== | 2,315 | elapsed time for requests.get over 2 minutes per url | {
"avatar_url": "https://avatars.githubusercontent.com/u/5601149?v=4",
"events_url": "https://api.github.com/users/jkroening/events{/privacy}",
"followers_url": "https://api.github.com/users/jkroening/followers",
"following_url": "https://api.github.com/users/jkroening/following{/other_user}",
"gists_url": "https://api.github.com/users/jkroening/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkroening",
"id": 5601149,
"login": "jkroening",
"node_id": "MDQ6VXNlcjU2MDExNDk=",
"organizations_url": "https://api.github.com/users/jkroening/orgs",
"received_events_url": "https://api.github.com/users/jkroening/received_events",
"repos_url": "https://api.github.com/users/jkroening/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkroening/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkroening/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkroening",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
}
] | closed | true | null | [] | null | 7 | 2014-10-31T00:47:45Z | 2021-09-08T23:06:57Z | 2014-11-18T05:13:09Z | NONE | resolved | I've searched high and low, but no luck on this one.
running Mac OS X Yosemite with Python 2.7.8 and Requests 2.4.3
even a simple requests.get in command line to google.com takes 75 seconds to complete.
> > > r = requests.get('http://www.google.com')
> > > r.elapsed
> > > datetime.timedelta(0, 75, 269509)
what's the deal? any thoughts? no matter what url, they all take forever to return.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5601149?v=4",
"events_url": "https://api.github.com/users/jkroening/events{/privacy}",
"followers_url": "https://api.github.com/users/jkroening/followers",
"following_url": "https://api.github.com/users/jkroening/following{/other_user}",
"gists_url": "https://api.github.com/users/jkroening/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jkroening",
"id": 5601149,
"login": "jkroening",
"node_id": "MDQ6VXNlcjU2MDExNDk=",
"organizations_url": "https://api.github.com/users/jkroening/orgs",
"received_events_url": "https://api.github.com/users/jkroening/received_events",
"repos_url": "https://api.github.com/users/jkroening/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jkroening/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jkroening/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jkroening",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2315/reactions"
} | https://api.github.com/repos/psf/requests/issues/2315/timeline | null | completed | null | null | false | [
"I just realized it doesn't happen if I run the same requests through a VPN (basically spoofing my normal IP address.) Yet my normal IP address works fine on these sites in a browser window like Chrome.\n",
"Is this consistent?\n",
"Yes. Consistent as in it always happens? Yes, every time when making the get... |
https://api.github.com/repos/psf/requests/issues/2314 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2314/labels{/name} | https://api.github.com/repos/psf/requests/issues/2314/comments | https://api.github.com/repos/psf/requests/issues/2314/events | https://github.com/psf/requests/issues/2314 | 47,259,454 | MDU6SXNzdWU0NzI1OTQ1NA== | 2,314 | Ignoring SSL errors with Session obejcts | {
"avatar_url": "https://avatars.githubusercontent.com/u/3966613?v=4",
"events_url": "https://api.github.com/users/glennzw/events{/privacy}",
"followers_url": "https://api.github.com/users/glennzw/followers",
"following_url": "https://api.github.com/users/glennzw/following{/other_user}",
"gists_url": "https://api.github.com/users/glennzw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/glennzw",
"id": 3966613,
"login": "glennzw",
"node_id": "MDQ6VXNlcjM5NjY2MTM=",
"organizations_url": "https://api.github.com/users/glennzw/orgs",
"received_events_url": "https://api.github.com/users/glennzw/received_events",
"repos_url": "https://api.github.com/users/glennzw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/glennzw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/glennzw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/glennzw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-10-30T11:35:18Z | 2021-09-08T23:07:05Z | 2014-11-05T01:00:14Z | NONE | resolved | When using a Session object the 'verify=False' option fails to ignore bad SSL:
> > > r = requests.get("https://site.com/blah", verify=False) #Works
> > >
> > > s = requests.Session()
> > > s.get('https://site.com/blah', verify=False) #Fails
> > > requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
However, this works:
> > > s = requests.Session()
> > > s.verify = False
> > > s.get('https://site.com/blah')
Request-level parameters should override session parameters.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2314/reactions"
} | https://api.github.com/repos/psf/requests/issues/2314/timeline | null | completed | null | null | false | [
"## What version of requests are you using? \n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"requests==2.4.1\n",
"I have reproduced it with requests==2.4.3, as expected:\n\n```\n>>> import requests\n>>> r = requests.get('https://my_wrong_cert/', verify=False)\n>>> r.status_code\n200... |
https://api.github.com/repos/psf/requests/issues/2313 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2313/labels{/name} | https://api.github.com/repos/psf/requests/issues/2313/comments | https://api.github.com/repos/psf/requests/issues/2313/events | https://github.com/psf/requests/issues/2313 | 47,176,990 | MDU6SXNzdWU0NzE3Njk5MA== | 2,313 | Can't use post to upload a file with Chinese characters in its name. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3011879?v=4",
"events_url": "https://api.github.com/users/sbarba/events{/privacy}",
"followers_url": "https://api.github.com/users/sbarba/followers",
"following_url": "https://api.github.com/users/sbarba/following{/other_user}",
"gists_url": "https://api.github.com/users/sbarba/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sbarba",
"id": 3011879,
"login": "sbarba",
"node_id": "MDQ6VXNlcjMwMTE4Nzk=",
"organizations_url": "https://api.github.com/users/sbarba/orgs",
"received_events_url": "https://api.github.com/users/sbarba/received_events",
"repos_url": "https://api.github.com/users/sbarba/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sbarba/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sbarba/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sbarba",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 30 | 2014-10-29T17:19:23Z | 2021-09-06T00:06:42Z | 2015-05-31T12:58:25Z | NONE | resolved | This code:
requests.post(url, files={"file": open(u"漢字.o8d", "r")})
will return a 200, but the file is never uploaded.
I can upload that file by posting in the browser so this doesn't seem to be a server-side issue. Also, if I change the name of the file to "bob" or something ASCII it works perfectly.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2313/reactions"
} | https://api.github.com/repos/psf/requests/issues/2313/timeline | null | completed | null | null | false | [
"Are you sure?\n\n``` bash\n$ echo \"file file file.\\n\" >> 漢字.o8d\n$ ls\n漢字.o8d\n```\n\n``` python\n>>> import requests\n>>> r = requests.post('http://httpbin.org/post', files={'file': open(u'漢字.o8d', 'r')})\n>>> print r.content\n{\n \"args\": {}, \n \"data\": \"\", \n \"files\": {}, \n \"form\": {\n \"fil... |
https://api.github.com/repos/psf/requests/issues/2312 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2312/labels{/name} | https://api.github.com/repos/psf/requests/issues/2312/comments | https://api.github.com/repos/psf/requests/issues/2312/events | https://github.com/psf/requests/issues/2312 | 47,065,185 | MDU6SXNzdWU0NzA2NTE4NQ== | 2,312 | SSL request hangs | {
"avatar_url": "https://avatars.githubusercontent.com/u/9436418?v=4",
"events_url": "https://api.github.com/users/ilya112358/events{/privacy}",
"followers_url": "https://api.github.com/users/ilya112358/followers",
"following_url": "https://api.github.com/users/ilya112358/following{/other_user}",
"gists_url": "https://api.github.com/users/ilya112358/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ilya112358",
"id": 9436418,
"login": "ilya112358",
"node_id": "MDQ6VXNlcjk0MzY0MTg=",
"organizations_url": "https://api.github.com/users/ilya112358/orgs",
"received_events_url": "https://api.github.com/users/ilya112358/received_events",
"repos_url": "https://api.github.com/users/ilya112358/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ilya112358/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ilya112358/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ilya112358",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2014-10-28T18:44:02Z | 2021-09-08T19:00:37Z | 2014-10-29T16:30:12Z | NONE | resolved | The following curl test works fine:
```
curl -q -k --cert client-2048.crt --key client-2048.key https://identitysso.betfair.com/api/certlogin -d "username=testuser&password=testpassword" -H "X-Application: TestKey"
```
But the following python code hangs indefinitely on requests.post:
```
import requests
print 'Request test'
payload = 'username=testuser&password=testpassword'
headers = {
'X-Application': 'TestKey',
'Content-Type': 'application/x-www-form-urlencoded' }
resp = requests.post(
'https://identitysso.betfair.com/api/certlogin',
data=payload,
cert=('client-2048.crt', 'client-2048.key'),
headers=headers )
print 'Status code: ', resp.status_code
```
Last line never reached, the script hangs, no replies, no errors. Pressing Ctrl-C does not immediately abort but after several minutes prints:
```
Traceback (most recent call last):
File "F:\LMG\test.py", line 14, in <module>
headers=headers )
File "C:\Python27\lib\site-packages\requests\api.py", line 94, in post
return request('post', url, data=data, json=json, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py", line 49, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 569, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 362, in send
timeout=timeout
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 516, in urlopen
body=body, headers=headers)
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 331, in _make_request
httplib_response = conn.getresponse(buffering=True)
File "C:\Python27\lib\httplib.py", line 1030, in getresponse
response.begin()
File "C:\Python27\lib\httplib.py", line 407, in begin
version, status, reason = self._read_status()
File "C:\Python27\lib\httplib.py", line 365, in _read_status
line = self.fp.readline()
File "C:\Python27\lib\socket.py", line 447, in readline
data = self._sock.recv(self._rbufsize)
File "C:\Python27\lib\ssl.py", line 241, in recv
return self.read(buflen)
File "C:\Python27\lib\ssl.py", line 160, in read
return self._sslobj.read(len)
KeyboardInterrupt
```
Python 2.7 under Windows 7. Requests ver. 2.4.3.
I don't have much experience with Internet connection programming, I don't even understand where to go from here. Any ideas why it doesn't work as intended?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2312/reactions"
} | https://api.github.com/repos/psf/requests/issues/2312/timeline | null | completed | null | null | false | [
"The server doesn't appear to be responding to the request. The handshake appears to have succeeded, but the server isn't sending anything back. I recommend sending _all_ the headers cURL sent.\n",
"Thanks for quick reaction, here is verbose reply from curl:\n\n```\n* Hostname was NOT found in DNS cache\n* Tryi... |
https://api.github.com/repos/psf/requests/issues/2311 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2311/labels{/name} | https://api.github.com/repos/psf/requests/issues/2311/comments | https://api.github.com/repos/psf/requests/issues/2311/events | https://github.com/psf/requests/pull/2311 | 46,989,729 | MDExOlB1bGxSZXF1ZXN0MjM0MzQ1Njc= | 2,311 | Update urllib3 to 25d150b3148 | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-10-28T04:58:54Z | 2021-09-08T09:01:19Z | 2014-10-28T05:01:19Z | CONTRIBUTOR | resolved | Summary of changes:
- fixes #2307 by raising handshake timeouts as ReadTimeout and not SSLError
- try harder to send a HTTPS request to the server if it fails halfway
- changes to error message in the Retry class (not used by requests)
- add urllib3 function to convert Url objects back into a url string (not used by requests)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2311/reactions"
} | https://api.github.com/repos/psf/requests/issues/2311/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2311.diff",
"html_url": "https://github.com/psf/requests/pull/2311",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2311.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2311"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/2310 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2310/labels{/name} | https://api.github.com/repos/psf/requests/issues/2310/comments | https://api.github.com/repos/psf/requests/issues/2310/events | https://github.com/psf/requests/issues/2310 | 46,926,078 | MDU6SXNzdWU0NjkyNjA3OA== | 2,310 | TypeError: initializer for ctype must be a pointer to same type, not cdata | {
"avatar_url": "https://avatars.githubusercontent.com/u/9384187?v=4",
"events_url": "https://api.github.com/users/ranveer0/events{/privacy}",
"followers_url": "https://api.github.com/users/ranveer0/followers",
"following_url": "https://api.github.com/users/ranveer0/following{/other_user}",
"gists_url": "https://api.github.com/users/ranveer0/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ranveer0",
"id": 9384187,
"login": "ranveer0",
"node_id": "MDQ6VXNlcjkzODQxODc=",
"organizations_url": "https://api.github.com/users/ranveer0/orgs",
"received_events_url": "https://api.github.com/users/ranveer0/received_events",
"repos_url": "https://api.github.com/users/ranveer0/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ranveer0/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ranveer0/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ranveer0",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 3 | 2014-10-27T16:22:38Z | 2021-09-08T23:06:09Z | 2015-01-19T09:16:30Z | NONE | resolved | I'm seeing an issue with requests that I couldn't find a solution to elsewhere.
I'm doing a post request to google with some data that contains client id and token info (are just python strings) but I occasionally get this error:
```
TypeError: initializer for ctype 'int(*)(int, X509_STORE_CTX *)' must be a pointer to same type, not cdata 'int(*)(int, X509_STORE_CTX *)'
```
It seems to work every other time and then it throws this error sometimes. I tried encoding all data/url into 'utf-8' but that didn't seem to help much since I still get the error sometimes. If I turn verify=False it works but I'd like to keep it on. Here is the full trace:
```
url = 'https://accounts.google.com/...'
data = {'refresh_token': ...,
'client_id': …,
'client_secret': ...,
'grant_type': 'refresh_token',
}
```
```
File "/path/to/file/file.py", line 124, in _my_function.py
response = requests.post(url, data=data)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 94, in post
return request('post', url, data=data, json=json, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 49, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 569, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 362, in send
timeout=timeout
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py", line 516, in urlopen
body=body, headers=headers)
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py", line 304, in _make_request
self._validate_conn(conn)
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py", line 722, in _validate_conn
conn.connect()
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connection.py", line 229, in connect
ssl_version=resolved_ssl_version)
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 255, in ssl_wrap_socket
ctx.set_verify(_openssl_verify[cert_reqs], _verify_callback)
File "/usr/local/lib/python2.7/dist-packages/OpenSSL/SSL.py", line 550, in set_verify
:param depth: An integer specifying the verify depth
TypeError: initializer for ctype 'int(*)(int, X509_STORE_CTX *)' must be a pointer to same type, not cdata 'int(*)(int, X509_STORE_CTX *)'
```
Using requests 2.4.2 and pyopenssl 0.14.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2310/reactions"
} | https://api.github.com/repos/psf/requests/issues/2310/timeline | null | completed | null | null | false | [
"This seems entirely to be a problem in PyOpenSSL. Have you tried upgrading to 0.15 to see if that fixes the issue?\n",
"I opened an issue with PyOpenSSL. I haven't tried updating, I can't seem to find that version I only find 0.14 version. \n",
"0.14 is the latest, 0.15 is stuck in development hell.\n"
] |
https://api.github.com/repos/psf/requests/issues/2309 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2309/labels{/name} | https://api.github.com/repos/psf/requests/issues/2309/comments | https://api.github.com/repos/psf/requests/issues/2309/events | https://github.com/psf/requests/pull/2309 | 46,860,414 | MDExOlB1bGxSZXF1ZXN0MjMzNTg2Njc= | 2,309 | Add DeprecationWarnings to inform users of plans | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-10-27T00:28:03Z | 2021-09-08T09:01:15Z | 2014-11-12T17:36:03Z | CONTRIBUTOR | resolved | After a long discussion in IRC and on several issues, the developers of
requests have decided to remove specific functions from requests.utils
in version 3.0.0. To give users ample time to prepare for this, we've
added DeprecationWarnings long in advance. See also the planning of this
in issue #2266.
My only concern with this is that these DeprecationWarnings are on by default
in Python 2.6 and off everywhere else. Should we disable them for 2.6? It's a
not insignificant portion of our user base that may be affected by this.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2309/reactions"
} | https://api.github.com/repos/psf/requests/issues/2309/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2309.diff",
"html_url": "https://github.com/psf/requests/pull/2309",
"merged_at": "2014-11-12T17:36:03Z",
"patch_url": "https://github.com/psf/requests/pull/2309.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2309"
} | true | [
":+1: :cake: LGTM.\n",
"I think we should optimize for user experience. I'm personally not a fan of deprecation warnings ever, so I'd lean towards disabling them for Python 2.6's userbase — but that's because I'm choosing explicitness over implicitness. Explicitness not in the enabling/disabling, but explicitness... |
https://api.github.com/repos/psf/requests/issues/2308 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2308/labels{/name} | https://api.github.com/repos/psf/requests/issues/2308/comments | https://api.github.com/repos/psf/requests/issues/2308/events | https://github.com/psf/requests/pull/2308 | 46,852,456 | MDExOlB1bGxSZXF1ZXN0MjMzNTUxNDE= | 2,308 | Note about read timeout errors and max_retries | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-26T19:46:54Z | 2021-09-08T09:01:16Z | 2014-11-12T17:35:24Z | CONTRIBUTOR | resolved | Update HISTORY to note this. The change was made in urllib3 and not picked up here.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2308/reactions"
} | https://api.github.com/repos/psf/requests/issues/2308/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2308.diff",
"html_url": "https://github.com/psf/requests/pull/2308",
"merged_at": "2014-11-12T17:35:24Z",
"patch_url": "https://github.com/psf/requests/pull/2308.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2308"
} | true | [
"As reported/commented on in #2307.\n",
"I'm hesitant to merge this as it essentially muddies history. You're modifying a changelog after the release has been cut. This amounts to changing history under a user's feet in future releases. If a user read the release notes for 2.4.0 and then reads the release notes f... |
https://api.github.com/repos/psf/requests/issues/2307 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2307/labels{/name} | https://api.github.com/repos/psf/requests/issues/2307/comments | https://api.github.com/repos/psf/requests/issues/2307/events | https://github.com/psf/requests/issues/2307 | 46,844,193 | MDU6SXNzdWU0Njg0NDE5Mw== | 2,307 | SSL connections with timeout dont seem to respect retries | {
"avatar_url": "https://avatars.githubusercontent.com/u/3061360?v=4",
"events_url": "https://api.github.com/users/itaiin/events{/privacy}",
"followers_url": "https://api.github.com/users/itaiin/followers",
"following_url": "https://api.github.com/users/itaiin/following{/other_user}",
"gists_url": "https://api.github.com/users/itaiin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itaiin",
"id": 3061360,
"login": "itaiin",
"node_id": "MDQ6VXNlcjMwNjEzNjA=",
"organizations_url": "https://api.github.com/users/itaiin/orgs",
"received_events_url": "https://api.github.com/users/itaiin/received_events",
"repos_url": "https://api.github.com/users/itaiin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itaiin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itaiin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itaiin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-10-26T14:25:38Z | 2021-09-08T23:04:45Z | 2015-05-31T12:57:54Z | NONE | resolved | Sending an https request with timeout, does not make retries when it gets a timeout.
Code:
``` python
import requests
s = requests.session()
s.mount('https://localhost:10000', requests.adapters.HTTPAdapter(max_retries = 3))
s.post('https://localhost:10000', timeout = 3)
```
Raises this exception (with no retries):
```
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 498, in post
return self.request('POST', url, data=data, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 456, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 559, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 382, in send
raise SSLError(e, request=request)
SSLError: _ssl.c:492: The handshake operation timed out
```
A similar request (even using the same session object) with `http` instead of `https` raises the exception `Timeout: HTTPConnectionPool(host='localhost', port=10000): Read timed out. (read timeout=1)` after 3 retries as expected.
This does not seem to be a general issue with ssl + retries - I've successfully used both
The problem was found on version 2.3.0 both on linux and windows, and also on the latest version - 2.4.3 (tried on linux only).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2307/reactions"
} | https://api.github.com/repos/psf/requests/issues/2307/timeline | null | completed | null | null | false | [
"Taking a look now\n",
"Previously (before v2.4.0) `max_retries` meant requests (specifically, the logic in urllib3 underlying requests) would retry the request if a server failed to return a response (a read timeout). After 2.4.0 (and urllib3 1.9), read timeouts are no longer retried.\n\nI made this change becau... |
https://api.github.com/repos/psf/requests/issues/2306 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2306/labels{/name} | https://api.github.com/repos/psf/requests/issues/2306/comments | https://api.github.com/repos/psf/requests/issues/2306/events | https://github.com/psf/requests/pull/2306 | 46,814,257 | MDExOlB1bGxSZXF1ZXN0MjMzNDAwMjg= | 2,306 | Fix failing test test_prepare_unicode_url | {
"avatar_url": "https://avatars.githubusercontent.com/u/125019?v=4",
"events_url": "https://api.github.com/users/ssadler/events{/privacy}",
"followers_url": "https://api.github.com/users/ssadler/followers",
"following_url": "https://api.github.com/users/ssadler/following{/other_user}",
"gists_url": "https://api.github.com/users/ssadler/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssadler",
"id": 125019,
"login": "ssadler",
"node_id": "MDQ6VXNlcjEyNTAxOQ==",
"organizations_url": "https://api.github.com/users/ssadler/orgs",
"received_events_url": "https://api.github.com/users/ssadler/received_events",
"repos_url": "https://api.github.com/users/ssadler/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssadler/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssadler/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssadler",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 6 | 2014-10-25T15:06:09Z | 2021-09-08T10:01:00Z | 2014-10-27T00:32:46Z | CONTRIBUTOR | resolved | Test was failing in case of undefined `hooks` in prepare_hooks()
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2306/reactions"
} | https://api.github.com/repos/psf/requests/issues/2306/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2306.diff",
"html_url": "https://github.com/psf/requests/pull/2306",
"merged_at": "2014-10-27T00:32:46Z",
"patch_url": "https://github.com/psf/requests/pull/2306.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2306"
} | true | [
"So one quick note. This test is failing because the _test_ is wrong, not the `prepare_hooks` method is wrong. In the test, can you pass `hooks=[]` please? That will fix this better. Sorry for the confusion. I hadn't looked closely at the commit to fix this test.\n",
"That ok? I like to avoid using [] as a defaul... |
https://api.github.com/repos/psf/requests/issues/2305 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2305/labels{/name} | https://api.github.com/repos/psf/requests/issues/2305/comments | https://api.github.com/repos/psf/requests/issues/2305/events | https://github.com/psf/requests/pull/2305 | 46,810,077 | MDExOlB1bGxSZXF1ZXN0MjMzMzg0MTc= | 2,305 | Fix 1979 digest redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/125019?v=4",
"events_url": "https://api.github.com/users/ssadler/events{/privacy}",
"followers_url": "https://api.github.com/users/ssadler/followers",
"following_url": "https://api.github.com/users/ssadler/following{/other_user}",
"gists_url": "https://api.github.com/users/ssadler/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssadler",
"id": 125019,
"login": "ssadler",
"node_id": "MDQ6VXNlcjEyNTAxOQ==",
"organizations_url": "https://api.github.com/users/ssadler/orgs",
"received_events_url": "https://api.github.com/users/ssadler/received_events",
"repos_url": "https://api.github.com/users/ssadler/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssadler/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssadler/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssadler",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-10-25T11:57:53Z | 2021-09-08T10:01:01Z | 2014-10-25T14:11:26Z | CONTRIBUTOR | resolved | Ran into #1979. I think it's reasonable to try the digest request again every time we encounter a 3xx. Also changed the state variable `num_401_calls` to a boolean `do_401`, since it's just used to see if we should try again and decrementing it on 3xx would be misleading. I assumed it would be safe to rename it since it looks like it's supposed to be hidden (not declared in constructor). I also assume that existing max redirects handler will still work. Regression test also still due.
Oh, this also fixes a previously failing test... I haven't looked into that one very deeply though.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2305/reactions"
} | https://api.github.com/repos/psf/requests/issues/2305/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2305.diff",
"html_url": "https://github.com/psf/requests/pull/2305",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2305.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2305"
} | true | [
"## Did we not merge the other PR we had for this? \n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"Hey @ssadler thanks for this, but we already had a different [PR](https://github.com/kennethreitz/requests/pull/2253) for this, which is much simpler. If you want to send a separate PR ... |
https://api.github.com/repos/psf/requests/issues/2304 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2304/labels{/name} | https://api.github.com/repos/psf/requests/issues/2304/comments | https://api.github.com/repos/psf/requests/issues/2304/events | https://github.com/psf/requests/issues/2304 | 46,799,962 | MDU6SXNzdWU0Njc5OTk2Mg== | 2,304 | [Feature] Add browser compatible TLS hostname validator | {
"avatar_url": "https://avatars.githubusercontent.com/u/772364?v=4",
"events_url": "https://api.github.com/users/Fuzion24/events{/privacy}",
"followers_url": "https://api.github.com/users/Fuzion24/followers",
"following_url": "https://api.github.com/users/Fuzion24/following{/other_user}",
"gists_url": "https://api.github.com/users/Fuzion24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Fuzion24",
"id": 772364,
"login": "Fuzion24",
"node_id": "MDQ6VXNlcjc3MjM2NA==",
"organizations_url": "https://api.github.com/users/Fuzion24/orgs",
"received_events_url": "https://api.github.com/users/Fuzion24/received_events",
"repos_url": "https://api.github.com/users/Fuzion24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Fuzion24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Fuzion24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Fuzion24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-10-25T02:43:14Z | 2021-09-08T23:07:07Z | 2014-10-25T03:02:06Z | NONE | resolved | The *.domain in browsers recursively matches subdomains. Other frameworks/languages have made this behaviour work by implementing a [compatibility mode](http://developer.android.com/reference/org/apache/http/conn/ssl/BrowserCompatHostnameVerifier.html). It would be nice to add an option here to make *.domain.com recursively match.
Here's an example:
```
requests.exceptions.SSLError: hostname 'android.clients.google.com' doesn't match either of '*.google.com', '*.android.com', '*.appengine.google.com', '*.cloud.google.com', '*.google-analytics.com', '*.google.ca', '*.google.cl', '*.google.co.in', '*.google.co.jp', '*.google.co.uk', '*.google.com.ar', '*.google.com.au', '*.google.com.br', '*.google.com.co', '*.google.com.mx', '*.google.com.tr', '*.google.com.vn', '*.google.de', '*.google.es', '*.google.fr', '*.google.hu', '*.google.it', '*.google.nl', '*.google.pl', '*.google.pt', '*.googleadapis.com', '*.googleapis.cn', '*.googlecommerce.com', '*.googlevideo.com', '*.gstatic.cn', '*.gstatic.com', '*.gvt1.com', '*.gvt2.com', '*.metric.gstatic.com', '*.urchin.com', '*.url.google.com', '*.youtube-nocookie.com', '*.youtube.com', '*.youtubeeducation.com', '*.ytimg.com', 'android.com', 'g.co', 'goo.gl', 'google-analytics.com', 'google.com', 'googlecommerce.com', 'urchin.com', 'youtu.be', 'youtube.com', 'youtubeeducation.com'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2304/reactions"
} | https://api.github.com/repos/psf/requests/issues/2304/timeline | null | completed | null | null | false | [
"This is in fact already possible if you do `pip install requests[security]`. This has to do with a feature called SNI. In the future, please research other (open and closed) issues before opening new ones.\n",
"@sigmavirus24 I think this is different than SNI.\n@Fuzion24 wants, that requests accepts certificates... |
https://api.github.com/repos/psf/requests/issues/2303 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2303/labels{/name} | https://api.github.com/repos/psf/requests/issues/2303/comments | https://api.github.com/repos/psf/requests/issues/2303/events | https://github.com/psf/requests/issues/2303 | 46,788,564 | MDU6SXNzdWU0Njc4ODU2NA== | 2,303 | Python 3.4: "ReferenceError: weakly-referenced object no longer exists" in __del__ of a class which refers to a Session object | {
"avatar_url": "https://avatars.githubusercontent.com/u/5781687?v=4",
"events_url": "https://api.github.com/users/shichao-an/events{/privacy}",
"followers_url": "https://api.github.com/users/shichao-an/followers",
"following_url": "https://api.github.com/users/shichao-an/following{/other_user}",
"gists_url": "https://api.github.com/users/shichao-an/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shichao-an",
"id": 5781687,
"login": "shichao-an",
"node_id": "MDQ6VXNlcjU3ODE2ODc=",
"organizations_url": "https://api.github.com/users/shichao-an/orgs",
"received_events_url": "https://api.github.com/users/shichao-an/received_events",
"repos_url": "https://api.github.com/users/shichao-an/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shichao-an/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shichao-an/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shichao-an",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-10-24T22:04:26Z | 2021-09-08T08:00:43Z | 2015-02-17T04:40:22Z | NONE | resolved | I got the following error when running my code in Python 3.4 (Python 2.7 and 3.3 are fine):
```
Exception ignored in: <bound method API.__del__ of <u115.api.API object at 0x109dadb00>>
Traceback (most recent call last):
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/u115/api.py", line 148, in __del__
if self.auto_logout and self.has_logged_in:
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/u115/api.py", line 195, in has_logged_in
r = self.http.get(self.passport.checkpoint_url, params=params)
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/u115/api.py", line 36, in get
r = self.session.get(url, params=params)
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/requests/sessions.py", line 469, in get
return self.request('GET', url, **kwargs)
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/requests/sessions.py", line 563, in send
adapter = self.get_adapter(url=request.url)
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/site-packages/requests/sessions.py", line 636, in get_adapter
for (prefix, adapter) in self.adapters.items():
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/_collections_abc.py", line 484, in __iter__
for key in self._mapping:
File "/Users/shichao/envs/115wangpan-dl3/lib/python3.4/collections/__init__.py", line 87, in __iter__
curr = root.next
ReferenceError: weakly-referenced object no longer exists
```
The source code is here: https://github.com/shichao-an/115wangpan/blob/master/u115/api.py#L147
I think maybe it's related to the features change in 3.4 pertinent to `__del__` and weakref:
- https://docs.python.org/3/library/gc.html#gc.garbage
- https://docs.python.org/3/library/weakref.html#comparing-finalizers-with-del-methods
I wonder if there is any workaround.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2303/reactions"
} | https://api.github.com/repos/psf/requests/issues/2303/timeline | null | completed | null | null | false | [
"I see this error too!\n",
"So this is coming out of the standard library. The standard library implementation of an OrderedDict (which is included in Python 3.4) uses a [weakref for the root reference](https://hg.python.org/cpython/file/534b26837a13/Lib/collections/__init__.py#l74). This is a bug in Python 3.4 ... |
https://api.github.com/repos/psf/requests/issues/2302 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2302/labels{/name} | https://api.github.com/repos/psf/requests/issues/2302/comments | https://api.github.com/repos/psf/requests/issues/2302/events | https://github.com/psf/requests/pull/2302 | 46,734,973 | MDExOlB1bGxSZXF1ZXN0MjMyOTQyMTA= | 2,302 | Improve instructions for running the tests | {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-24T12:57:49Z | 2021-09-08T10:01:01Z | 2014-10-24T13:43:19Z | CONTRIBUTOR | resolved | py.test must be run from inside the requests folder, otherwise it will
also try to run the tests belonging to the bundled packages.
Change-Id: Ic9ca135b2bfc08e1ada68218cee069ebfbd843fa
| {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2302/reactions"
} | https://api.github.com/repos/psf/requests/issues/2302/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2302.diff",
"html_url": "https://github.com/psf/requests/pull/2302",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2302.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2302"
} | true | [
"I've had no problems running py.test from the root directory. What bundled packages are you talking about?\n",
"Sorry, it's just me misreading the output. I thought it was failing on something in the packages folder, but it turns out it was because I created my virtualenv in the root of the git.\n"
] |
https://api.github.com/repos/psf/requests/issues/2301 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2301/labels{/name} | https://api.github.com/repos/psf/requests/issues/2301/comments | https://api.github.com/repos/psf/requests/issues/2301/events | https://github.com/psf/requests/pull/2301 | 46,734,676 | MDExOlB1bGxSZXF1ZXN0MjMyOTQwNDI= | 2,301 | Fix "TypeError: 'NoneType' object is not iterable" in prepare_hooks | {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-24T12:54:24Z | 2021-09-08T10:01:02Z | 2014-10-24T15:03:06Z | CONTRIBUTOR | resolved | This was causing one of the tests to fail.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2301/reactions"
} | https://api.github.com/repos/psf/requests/issues/2301/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2301.diff",
"html_url": "https://github.com/psf/requests/pull/2301",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2301.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2301"
} | true | [
"Which test? This should never happen, hooks should never be the none object.\n",
"@Lukasa I just ran the tests and it's arising from `test_prepare_unicode_url` because it's creating a `PreparedRequest` and then calling `prepare` without passing any hooks. This is a poorly written test, not something that should ... |
https://api.github.com/repos/psf/requests/issues/2300 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2300/labels{/name} | https://api.github.com/repos/psf/requests/issues/2300/comments | https://api.github.com/repos/psf/requests/issues/2300/events | https://github.com/psf/requests/issues/2300 | 46,712,337 | MDU6SXNzdWU0NjcxMjMzNw== | 2,300 | 404 response for a valid unicode url | {
"avatar_url": "https://avatars.githubusercontent.com/u/4245598?v=4",
"events_url": "https://api.github.com/users/alisufian/events{/privacy}",
"followers_url": "https://api.github.com/users/alisufian/followers",
"following_url": "https://api.github.com/users/alisufian/following{/other_user}",
"gists_url": "https://api.github.com/users/alisufian/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alisufian",
"id": 4245598,
"login": "alisufian",
"node_id": "MDQ6VXNlcjQyNDU1OTg=",
"organizations_url": "https://api.github.com/users/alisufian/orgs",
"received_events_url": "https://api.github.com/users/alisufian/received_events",
"repos_url": "https://api.github.com/users/alisufian/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alisufian/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alisufian/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alisufian",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-10-24T07:50:09Z | 2021-09-08T23:07:08Z | 2014-10-24T10:21:36Z | NONE | resolved | ```
In [5]: requests.get("http://www.daleelak.tv/uploads/photos/12/%D8%B3%D8%AA%D8%A7%D9%8A%D9%84.jpg")
Out[5]: <Response [404]>
```
```
curl -v "http://www.daleelak.tv/uploads/photos/12/%D8%B3%D8%AA%D8%A7%D9%8A%D9%84.jpg"
* Hostname was NOT found in DNS cache
* Trying 108.174.158.190...
* Connected to www.daleelak.tv (108.174.158.190) port 80 (#0)
> GET /uploads/photos/12/%D8%B3%D8%AA%D8%A7%D9%8A%D9%84.jpg HTTP/1.1
> User-Agent: curl/7.38.0
> Host: www.daleelak.tv
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Fri, 24 Oct 2014 07:38:58 GMT
* Server Apache is not blacklisted
< Server: Apache
< ETag: "54355-b7f9-4d6b38fce61c0"
< Accept-Ranges: bytes
< Content-Length: 47097
< Cache-Control: max-age=864000, public, must-revalidate
< Expires: Sat, 25 Oct 2014 07:38:58 GMT
< Vary: Accept-Encoding
< Content-Type: image/jpeg
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2300/reactions"
} | https://api.github.com/repos/psf/requests/issues/2300/timeline | null | completed | null | null | false | [
"i am also facing the same issue, urllib seems to be working fine with these sort of urls, but requests is returning 404 error\n",
"This has nothing to do with the URL and everything to do with the crappy web server. Observe:\n\n``` python\n>>> url = \"http://www.daleelak.tv/uploads/photos/12/%D8%B3%D8%AA%D8%A7%D... |
https://api.github.com/repos/psf/requests/issues/2299 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2299/labels{/name} | https://api.github.com/repos/psf/requests/issues/2299/comments | https://api.github.com/repos/psf/requests/issues/2299/events | https://github.com/psf/requests/pull/2299 | 46,702,204 | MDExOlB1bGxSZXF1ZXN0MjMyNzQ5NTY= | 2,299 | Cap the redirect_cache size to prevent memory abuse | {
"avatar_url": "https://avatars.githubusercontent.com/u/375744?v=4",
"events_url": "https://api.github.com/users/mattrobenolt/events{/privacy}",
"followers_url": "https://api.github.com/users/mattrobenolt/followers",
"following_url": "https://api.github.com/users/mattrobenolt/following{/other_user}",
"gists_url": "https://api.github.com/users/mattrobenolt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mattrobenolt",
"id": 375744,
"login": "mattrobenolt",
"node_id": "MDQ6VXNlcjM3NTc0NA==",
"organizations_url": "https://api.github.com/users/mattrobenolt/orgs",
"received_events_url": "https://api.github.com/users/mattrobenolt/received_events",
"repos_url": "https://api.github.com/users/mattrobenolt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mattrobenolt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mattrobenolt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mattrobenolt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2014-10-24T03:49:55Z | 2021-09-08T09:01:17Z | 2014-11-07T20:18:41Z | CONTRIBUTOR | resolved | It'd be easily possible to run out of memory from a long running process and session that does a lot of redirects. This is also potentially able to be abused if some information was known about how a service operated. Relatively unlikely, but it's a detail that users shouldn't have to think about. We can enforce something better.
And caching more than 10,000 redirects, in my opinion, is unreasonable. I'm open to a different value. Both more and less conservative.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2299/reactions"
} | https://api.github.com/repos/psf/requests/issues/2299/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2299.diff",
"html_url": "https://github.com/psf/requests/pull/2299",
"merged_at": "2014-11-07T20:18:41Z",
"patch_url": "https://github.com/psf/requests/pull/2299.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2299"
} | true | [
"I'm +1 on this. I don't really care what the maximum value is, but clearly there should be one.\n\nIf anything, I'd like to replace the data structure entirely with something like an LRU cache that has fixed maximum occupancy. I think urllib3 may have one, it might be worth taking a look at that.\n",
"@Lukasa I'... |
https://api.github.com/repos/psf/requests/issues/2298 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2298/labels{/name} | https://api.github.com/repos/psf/requests/issues/2298/comments | https://api.github.com/repos/psf/requests/issues/2298/events | https://github.com/psf/requests/pull/2298 | 46,701,180 | MDExOlB1bGxSZXF1ZXN0MjMyNzQzNjk= | 2,298 | Minor clean ups | {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
},
{
"color": "e11d21",
"default": false,
"d... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 5 | 2014-10-24T03:25:42Z | 2021-09-08T09:01:19Z | 2014-10-27T01:07:27Z | CONTRIBUTOR | resolved | Fixing some minor issues found with pylint. I've done them in separate commits in case you don't want all ofg the fixes. Feel free to squash if necessary.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2298/reactions"
} | https://api.github.com/repos/psf/requests/issues/2298/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2298.diff",
"html_url": "https://github.com/psf/requests/pull/2298",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2298.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2298"
} | true | [
"I'm +0 on this really. I don't mind it, but we do need to confirm that it hasn't broken anything.\n",
"Are there known problems with the test suite? I'm running it (against the head of the master branch, i.e. not including this PR) according to the instructions in todo.rst and I'm getting 27 failed.\n\nThis is ... |
https://api.github.com/repos/psf/requests/issues/2297 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2297/labels{/name} | https://api.github.com/repos/psf/requests/issues/2297/comments | https://api.github.com/repos/psf/requests/issues/2297/events | https://github.com/psf/requests/issues/2297 | 46,527,016 | MDU6SXNzdWU0NjUyNzAxNg== | 2,297 | Improper escaping with '#' in url | {
"avatar_url": "https://avatars.githubusercontent.com/u/1779137?v=4",
"events_url": "https://api.github.com/users/rminsk/events{/privacy}",
"followers_url": "https://api.github.com/users/rminsk/followers",
"following_url": "https://api.github.com/users/rminsk/following{/other_user}",
"gists_url": "https://api.github.com/users/rminsk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rminsk",
"id": 1779137,
"login": "rminsk",
"node_id": "MDQ6VXNlcjE3NzkxMzc=",
"organizations_url": "https://api.github.com/users/rminsk/orgs",
"received_events_url": "https://api.github.com/users/rminsk/received_events",
"repos_url": "https://api.github.com/users/rminsk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rminsk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rminsk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rminsk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-22T15:58:19Z | 2021-09-08T23:07:08Z | 2014-10-22T20:36:29Z | NONE | resolved | import requests
result = requests.get("https://localhost:8080/url/with/a.#.in/it", params={'foo': 'bar'}, verify=False)
print result.request.url
https://localhost:8080/url/with/a.?foo=bar#.in/it
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2297/reactions"
} | https://api.github.com/repos/psf/requests/issues/2297/timeline | null | completed | null | null | false | [
"Hi there!\n\nThis is a very tricky situation to resolve. The problem is that it is extremely ambiguous as to whether a user passes us an encoded or an unencoded URL. It's simply not clear whether the # sign you gave us should be treated as a fragment delimeter or not. This is particularly important because request... |
https://api.github.com/repos/psf/requests/issues/2296 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2296/labels{/name} | https://api.github.com/repos/psf/requests/issues/2296/comments | https://api.github.com/repos/psf/requests/issues/2296/events | https://github.com/psf/requests/issues/2296 | 46,526,183 | MDU6SXNzdWU0NjUyNjE4Mw== | 2,296 | Vendored version of chardet is buggy, can't detect utf-8 with bom | {
"avatar_url": "https://avatars.githubusercontent.com/u/229502?v=4",
"events_url": "https://api.github.com/users/tgs/events{/privacy}",
"followers_url": "https://api.github.com/users/tgs/followers",
"following_url": "https://api.github.com/users/tgs/following{/other_user}",
"gists_url": "https://api.github.com/users/tgs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tgs",
"id": 229502,
"login": "tgs",
"node_id": "MDQ6VXNlcjIyOTUwMg==",
"organizations_url": "https://api.github.com/users/tgs/orgs",
"received_events_url": "https://api.github.com/users/tgs/received_events",
"repos_url": "https://api.github.com/users/tgs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tgs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tgs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tgs",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 2 | 2014-10-22T15:51:26Z | 2021-09-08T23:06:09Z | 2015-01-19T09:16:40Z | NONE | resolved | [Here's the commit](https://github.com/chardet/chardet/commit/0f9030139ceeaa4c3bf590de299fe84a5895c218) that fixed it in upstream.
Because of the bug, if I fetch a UTF-8 file that starts with a BOM, I get (e.g.):
```
<?xml version="1.0" encoding="utf-8"?>
...
```
and `response.encoding` is `ISO-8859-1` or `-2`.
I think you should be able to just pull the newest version, and it will be fixed.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2296/reactions"
} | https://api.github.com/repos/psf/requests/issues/2296/timeline | null | completed | null | null | false | [
"@tgs thanks. We haven't had the reason to do a new release yet. When we do, we'll pull this in.\n\nUntil we do, if you know the encoding you can simply do `response.encoding = 'utf8'`\n",
"Sounds good, thank you!\n\nFor anyone else finding this, one workaround is to set response.encoding yourself:\n\n``` python\... |
https://api.github.com/repos/psf/requests/issues/2295 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2295/labels{/name} | https://api.github.com/repos/psf/requests/issues/2295/comments | https://api.github.com/repos/psf/requests/issues/2295/events | https://github.com/psf/requests/pull/2295 | 46,463,504 | MDExOlB1bGxSZXF1ZXN0MjMxMjk4ODc= | 2,295 | Adding a custom line delimiter to iter_lines() | {
"avatar_url": "https://avatars.githubusercontent.com/u/955663?v=4",
"events_url": "https://api.github.com/users/2deviant/events{/privacy}",
"followers_url": "https://api.github.com/users/2deviant/followers",
"following_url": "https://api.github.com/users/2deviant/following{/other_user}",
"gists_url": "https://api.github.com/users/2deviant/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2deviant",
"id": 955663,
"login": "2deviant",
"node_id": "MDQ6VXNlcjk1NTY2Mw==",
"organizations_url": "https://api.github.com/users/2deviant/orgs",
"received_events_url": "https://api.github.com/users/2deviant/received_events",
"repos_url": "https://api.github.com/users/2deviant/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2deviant/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2deviant/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2deviant",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-22T01:21:26Z | 2021-09-08T10:01:00Z | 2014-10-25T18:33:52Z | CONTRIBUTOR | resolved | Initial description is in Issue #2292 however, I shall elaborate.
It is often necessary to iterate over something other than conventional newlines, where such characters are a part of the data, for example. This is a small functionality requiring a proportionally small change in the code. Wrapping `iter_content()` in a custom iterator outside of the Requests library requires significantly more code, which is why I'm proposing this change. The effect on the performance is negligible.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2295/reactions"
} | https://api.github.com/repos/psf/requests/issues/2295/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2295.diff",
"html_url": "https://github.com/psf/requests/pull/2295",
"merged_at": "2014-10-25T18:33:52Z",
"patch_url": "https://github.com/psf/requests/pull/2295.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2295"
} | true | [
"I'm surprised we haven't seen a request for this before. I guess I'm +0.5. \n",
"i wonder if we should call it `delimeter` instead\n",
"I suppose that's a proper name for it, since `newline` does mean something specific. I have no qualms with renaming the argument to `delimiter`. Do you have any other concer... |
https://api.github.com/repos/psf/requests/issues/2294 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2294/labels{/name} | https://api.github.com/repos/psf/requests/issues/2294/comments | https://api.github.com/repos/psf/requests/issues/2294/events | https://github.com/psf/requests/issues/2294 | 46,405,726 | MDU6SXNzdWU0NjQwNTcyNg== | 2,294 | Connection reset by peer | {
"avatar_url": "https://avatars.githubusercontent.com/u/5134130?v=4",
"events_url": "https://api.github.com/users/aeos/events{/privacy}",
"followers_url": "https://api.github.com/users/aeos/followers",
"following_url": "https://api.github.com/users/aeos/following{/other_user}",
"gists_url": "https://api.github.com/users/aeos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aeos",
"id": 5134130,
"login": "aeos",
"node_id": "MDQ6VXNlcjUxMzQxMzA=",
"organizations_url": "https://api.github.com/users/aeos/orgs",
"received_events_url": "https://api.github.com/users/aeos/received_events",
"repos_url": "https://api.github.com/users/aeos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aeos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aeos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aeos",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-10-21T15:15:19Z | 2021-09-08T23:07:09Z | 2014-10-21T15:46:48Z | NONE | resolved | Hi,
Hopefully I am not using the API wrong, but I am stuck with how to fix an issue I am having. We are making hundreds of HTTP requests to an end point in a single script and after a while we receive a "Connection reset by peer" exception. I have put in a sleep and then retry recovery, but I get the same connection issue. If I restart the script, everything is fine.
From what I have read, there is connection pooling and I am worried that the second request is being dispatched on the same connection (which has been closed). I am wondering if maybe I am using the API wrong and should be closing the connection some how. My implementation is pretty straight forward:
```
with requests.Session() as s:
s.headers['Connection'] = 'close'
rs = s.request(method, url, **kwargs)
```
kwargs includes timeout=None. Should I be catching exceptions within the with block to ensure the connection is closed properly? Or is this the correct usage?
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5134130?v=4",
"events_url": "https://api.github.com/users/aeos/events{/privacy}",
"followers_url": "https://api.github.com/users/aeos/followers",
"following_url": "https://api.github.com/users/aeos/following{/other_user}",
"gists_url": "https://api.github.com/users/aeos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aeos",
"id": 5134130,
"login": "aeos",
"node_id": "MDQ6VXNlcjUxMzQxMzA=",
"organizations_url": "https://api.github.com/users/aeos/orgs",
"received_events_url": "https://api.github.com/users/aeos/received_events",
"repos_url": "https://api.github.com/users/aeos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aeos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aeos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aeos",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2294/reactions"
} | https://api.github.com/repos/psf/requests/issues/2294/timeline | null | completed | null | null | false | [
"This usage is fine.\n\nAssuming this is exactly your code, I take it you re-enter the `with` block after you've caught the exception?\n",
"the with call is executed inside a function block, I catch the exception outside the function, sleep, then call the function again.\n",
"Ok, so your problem is nothing to d... |
https://api.github.com/repos/psf/requests/issues/2293 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2293/labels{/name} | https://api.github.com/repos/psf/requests/issues/2293/comments | https://api.github.com/repos/psf/requests/issues/2293/events | https://github.com/psf/requests/issues/2293 | 46,367,258 | MDU6SXNzdWU0NjM2NzI1OA== | 2,293 | Odd HTTPS issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/204153?v=4",
"events_url": "https://api.github.com/users/gdude2002/events{/privacy}",
"followers_url": "https://api.github.com/users/gdude2002/followers",
"following_url": "https://api.github.com/users/gdude2002/following{/other_user}",
"gists_url": "https://api.github.com/users/gdude2002/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gdude2002",
"id": 204153,
"login": "gdude2002",
"node_id": "MDQ6VXNlcjIwNDE1Mw==",
"organizations_url": "https://api.github.com/users/gdude2002/orgs",
"received_events_url": "https://api.github.com/users/gdude2002/received_events",
"repos_url": "https://api.github.com/users/gdude2002/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gdude2002/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gdude2002/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gdude2002",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-10-21T08:28:23Z | 2021-09-08T23:07:09Z | 2014-10-21T12:28:28Z | NONE | resolved | It appears that Requests isn't getting the correct SSL cert on my domain, for some reason.
```
➜ ~ python
Python 2.7.6 (default, Mar 22 2014, 22:59:56)
[GCC 4.8.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> r = requests.get("https://ultros.io")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 60, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 49, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 569, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 420, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: hostname 'ultros.io' doesn't match either of 'www.archivesmc.com', 'archivesmc.com'
>>>
```
The certificate itself is fine - if you visit [the site](https://ultros.io), then you do indeed get the correct cert.
This seems to be a fairly odd one. Server is nginx, any idea what's going on here?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2293/reactions"
} | https://api.github.com/repos/psf/requests/issues/2293/timeline | null | completed | null | null | false | [
"My guess is that it's SNI related. Your webserver requires SNI-enabled clients (https://www.ssllabs.com/ssltest/analyze.html?d=ultros.io).\n",
"\"This site works only in browsers with SNI support. \" - is that what you mean?\n",
"Yes. Your webserver probably serves the \"www.archivesmc.com\" certificate for cl... |
https://api.github.com/repos/psf/requests/issues/2292 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2292/labels{/name} | https://api.github.com/repos/psf/requests/issues/2292/comments | https://api.github.com/repos/psf/requests/issues/2292/events | https://github.com/psf/requests/issues/2292 | 46,355,487 | MDU6SXNzdWU0NjM1NTQ4Nw== | 2,292 | Add custom line delimiter to iter_lines() | {
"avatar_url": "https://avatars.githubusercontent.com/u/955663?v=4",
"events_url": "https://api.github.com/users/2deviant/events{/privacy}",
"followers_url": "https://api.github.com/users/2deviant/followers",
"following_url": "https://api.github.com/users/2deviant/following{/other_user}",
"gists_url": "https://api.github.com/users/2deviant/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/2deviant",
"id": 955663,
"login": "2deviant",
"node_id": "MDQ6VXNlcjk1NTY2Mw==",
"organizations_url": "https://api.github.com/users/2deviant/orgs",
"received_events_url": "https://api.github.com/users/2deviant/received_events",
"repos_url": "https://api.github.com/users/2deviant/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/2deviant/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/2deviant/subscriptions",
"type": "User",
"url": "https://api.github.com/users/2deviant",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-21T05:14:22Z | 2021-09-08T23:06:11Z | 2015-01-18T20:13:16Z | CONTRIBUTOR | resolved | I saw a couple of requests that touched on this issue but, none that have hit it on the nose. Has adding a custom line delimiter functionality to `iter_lines()` been considered before? If so, what are the reasons for not including it? If the feature has not yet been considered, I would not mind submitting a pull request for comment.
This feature would be useful in cases when, for example, newlines are a part of data and the stream is delimited with, say `<>`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2292/reactions"
} | https://api.github.com/repos/psf/requests/issues/2292/timeline | null | completed | null | null | false | [
"I don't believe it has. It's a pretty niche feature, but I'd be open to considering a PR with it.\n",
"Fixed #2295\n"
] |
https://api.github.com/repos/psf/requests/issues/2291 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2291/labels{/name} | https://api.github.com/repos/psf/requests/issues/2291/comments | https://api.github.com/repos/psf/requests/issues/2291/events | https://github.com/psf/requests/issues/2291 | 46,347,589 | MDU6SXNzdWU0NjM0NzU4OQ== | 2,291 | Direct TLS pinning of .pem files possible? (No CA roots) | {
"avatar_url": "https://avatars.githubusercontent.com/u/7875239?v=4",
"events_url": "https://api.github.com/users/HulaHoopWhonix/events{/privacy}",
"followers_url": "https://api.github.com/users/HulaHoopWhonix/followers",
"following_url": "https://api.github.com/users/HulaHoopWhonix/following{/other_user}",
"gists_url": "https://api.github.com/users/HulaHoopWhonix/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HulaHoopWhonix",
"id": 7875239,
"login": "HulaHoopWhonix",
"node_id": "MDQ6VXNlcjc4NzUyMzk=",
"organizations_url": "https://api.github.com/users/HulaHoopWhonix/orgs",
"received_events_url": "https://api.github.com/users/HulaHoopWhonix/received_events",
"repos_url": "https://api.github.com/users/HulaHoopWhonix/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HulaHoopWhonix/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HulaHoopWhonix/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HulaHoopWhonix",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-21T02:14:05Z | 2021-09-08T23:07:09Z | 2014-10-21T03:20:24Z | NONE | resolved | How can I pin a downloaded .pem TLS cert file for a specific server directly (self-signed certificate), without using CA roots?
Is this currently possible? If yes, can you please provide an example?
I read http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verificationbut am not sure if this applies to what I'm trying to do:
<blockquote>You can also specify a local cert to use as client side certificate, as a single file (containing the private key and the certificate) or as a tuple of both file’s path:
<code>
requests.get('https://kennethreitz.com', cert=('/path/server.crt', '/path/key'))
Response [200]
</code>
</blockquote>
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2291/reactions"
} | https://api.github.com/repos/psf/requests/issues/2291/timeline | null | completed | null | null | false | [
"This is a question and as such belongs on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests).\n",
"@sigmavirus24 I am asking about a pyhton-requests functionality. Can you please give me a simple yes or no answer if this is possible?\n",
"@HulaHoopWhonix We know what you're doing, we'r... |
https://api.github.com/repos/psf/requests/issues/2290 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2290/labels{/name} | https://api.github.com/repos/psf/requests/issues/2290/comments | https://api.github.com/repos/psf/requests/issues/2290/events | https://github.com/psf/requests/pull/2290 | 46,200,104 | MDExOlB1bGxSZXF1ZXN0MjI5NzgyMDY= | 2,290 | Fix #2279. Update layout css | {
"avatar_url": "https://avatars.githubusercontent.com/u/1938009?v=4",
"events_url": "https://api.github.com/users/syedsuhail/events{/privacy}",
"followers_url": "https://api.github.com/users/syedsuhail/followers",
"following_url": "https://api.github.com/users/syedsuhail/following{/other_user}",
"gists_url": "https://api.github.com/users/syedsuhail/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/syedsuhail",
"id": 1938009,
"login": "syedsuhail",
"node_id": "MDQ6VXNlcjE5MzgwMDk=",
"organizations_url": "https://api.github.com/users/syedsuhail/orgs",
"received_events_url": "https://api.github.com/users/syedsuhail/received_events",
"repos_url": "https://api.github.com/users/syedsuhail/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/syedsuhail/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/syedsuhail/subscriptions",
"type": "User",
"url": "https://api.github.com/users/syedsuhail",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-19T08:39:50Z | 2021-09-08T10:01:03Z | 2014-10-19T09:42:28Z | CONTRIBUTOR | resolved | Updated gratipay widget iframe in both sidebarintro.html and sidebarlogo.html .
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2290/reactions"
} | https://api.github.com/repos/psf/requests/issues/2290/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2290.diff",
"html_url": "https://github.com/psf/requests/pull/2290",
"merged_at": "2014-10-19T09:42:28Z",
"patch_url": "https://github.com/psf/requests/pull/2290.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2290"
} | true | [
"@syedsuhail Quick question, why'd you change the width?\n",
"I didn't notice the change already made in sidebarintro.html. When I saw the gratipay widget was shorter in the requests page I tried adjusting the width. Then I understood the problem was in sidebarlogo.html. I checked the html build and didn't see a... |
https://api.github.com/repos/psf/requests/issues/2289 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2289/labels{/name} | https://api.github.com/repos/psf/requests/issues/2289/comments | https://api.github.com/repos/psf/requests/issues/2289/events | https://github.com/psf/requests/pull/2289 | 46,199,449 | MDExOlB1bGxSZXF1ZXN0MjI5Nzc5MDQ= | 2,289 | Fix #2288 . Change urllib3 and chardet workflow | {
"avatar_url": "https://avatars.githubusercontent.com/u/1938009?v=4",
"events_url": "https://api.github.com/users/syedsuhail/events{/privacy}",
"followers_url": "https://api.github.com/users/syedsuhail/followers",
"following_url": "https://api.github.com/users/syedsuhail/following{/other_user}",
"gists_url": "https://api.github.com/users/syedsuhail/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/syedsuhail",
"id": 1938009,
"login": "syedsuhail",
"node_id": "MDQ6VXNlcjE5MzgwMDk=",
"organizations_url": "https://api.github.com/users/syedsuhail/orgs",
"received_events_url": "https://api.github.com/users/syedsuhail/received_events",
"repos_url": "https://api.github.com/users/syedsuhail/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/syedsuhail/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/syedsuhail/subscriptions",
"type": "User",
"url": "https://api.github.com/users/syedsuhail",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-10-19T07:52:54Z | 2021-09-08T10:01:03Z | 2014-10-19T07:56:36Z | CONTRIBUTOR | resolved | This modified workflow first tries to clone the urllib3 or chardet and then removes it from requests/packages if successful. If the cloning is unsuccessful then the packages are not removed.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2289/reactions"
} | https://api.github.com/repos/psf/requests/issues/2289/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2289.diff",
"html_url": "https://github.com/psf/requests/pull/2289",
"merged_at": "2014-10-19T07:56:36Z",
"patch_url": "https://github.com/psf/requests/pull/2289.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2289"
} | true | [
"Thanks for this @syedsuhail! :cake:\n",
"Happy to contribute. This is my first successful merge. :smiley: \n",
"@syedsuhail I'm glad you chose to contribute to requests!\n"
] |
https://api.github.com/repos/psf/requests/issues/2288 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2288/labels{/name} | https://api.github.com/repos/psf/requests/issues/2288/comments | https://api.github.com/repos/psf/requests/issues/2288/events | https://github.com/psf/requests/issues/2288 | 46,198,638 | MDU6SXNzdWU0NjE5ODYzOA== | 2,288 | urllib3 and chardet makefile workflow bug | {
"avatar_url": "https://avatars.githubusercontent.com/u/1938009?v=4",
"events_url": "https://api.github.com/users/syedsuhail/events{/privacy}",
"followers_url": "https://api.github.com/users/syedsuhail/followers",
"following_url": "https://api.github.com/users/syedsuhail/following{/other_user}",
"gists_url": "https://api.github.com/users/syedsuhail/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/syedsuhail",
"id": 1938009,
"login": "syedsuhail",
"node_id": "MDQ6VXNlcjE5MzgwMDk=",
"organizations_url": "https://api.github.com/users/syedsuhail/orgs",
"received_events_url": "https://api.github.com/users/syedsuhail/received_events",
"repos_url": "https://api.github.com/users/syedsuhail/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/syedsuhail/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/syedsuhail/subscriptions",
"type": "User",
"url": "https://api.github.com/users/syedsuhail",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-10-19T06:54:05Z | 2021-09-08T23:07:53Z | 2014-10-19T07:56:37Z | CONTRIBUTOR | resolved | Currently the requests/packages/urllib3 and requests/packages/chardet are removed first before cloning from their repositories. Problem occurs when the cloning fails for some reason and requests is left without the urllib3 or chardet packages.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2288/reactions"
} | https://api.github.com/repos/psf/requests/issues/2288/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2287 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2287/labels{/name} | https://api.github.com/repos/psf/requests/issues/2287/comments | https://api.github.com/repos/psf/requests/issues/2287/events | https://github.com/psf/requests/issues/2287 | 46,153,670 | MDU6SXNzdWU0NjE1MzY3MA== | 2,287 | Revisit concerns in #2244 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-17T23:13:31Z | 2021-09-08T23:05:46Z | 2015-04-07T14:31:18Z | CONTRIBUTOR | resolved | See https://github.com/kennethreitz/requests/pull/2244 for more context:
Specific concerns are:
- Should redirects handled by the cache count against the max number of redirects? (e.g., if we set a max of 30 and find 2 redirects in the cache, the max number of redirects a user could encounter after that would be 28)
- Should history be some-how generated by the redirect cache? (i.e., should we be making responses and adding them to the final response's history?)
- Should a separate error be raised for the case where there's a loop in the cache? (When documented this would help the user realize they're stuck in a cached loop and that they may want to clear it to retry using the live site. Note: this also affects the API of `Session#resolve_redirects`.)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2287/reactions"
} | https://api.github.com/repos/psf/requests/issues/2287/timeline | null | completed | null | null | false | [
"@Lukasa is it still worth keeping this open?\n",
"I still hate the redirect cache, but I think we should talk about it at PyCon. In particular, we should talk about whether we should yank it out and instruct people to use CacheControl instead.\n"
] |
https://api.github.com/repos/psf/requests/issues/2286 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2286/labels{/name} | https://api.github.com/repos/psf/requests/issues/2286/comments | https://api.github.com/repos/psf/requests/issues/2286/events | https://github.com/psf/requests/issues/2286 | 46,094,974 | MDU6SXNzdWU0NjA5NDk3NA== | 2,286 | malformed multipart form-data | {
"avatar_url": "https://avatars.githubusercontent.com/u/1122519?v=4",
"events_url": "https://api.github.com/users/AgDude/events{/privacy}",
"followers_url": "https://api.github.com/users/AgDude/followers",
"following_url": "https://api.github.com/users/AgDude/following{/other_user}",
"gists_url": "https://api.github.com/users/AgDude/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AgDude",
"id": 1122519,
"login": "AgDude",
"node_id": "MDQ6VXNlcjExMjI1MTk=",
"organizations_url": "https://api.github.com/users/AgDude/orgs",
"received_events_url": "https://api.github.com/users/AgDude/received_events",
"repos_url": "https://api.github.com/users/AgDude/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AgDude/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AgDude/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AgDude",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 2 | 2014-10-17T12:43:31Z | 2021-09-08T23:06:08Z | 2015-01-19T09:17:00Z | NONE | resolved | I was trying to use requests to post a form to AWS S3, and continually got an error about malformed multipart/form-data. I am not an expert on http formatting standards, but I was able to make this work with python posters instead.
Requests should support the option to format as multipart/form-data even without breaking up the file (in my case the files are small, but S3 only support enctype of multipart).
For comparison, here is the request body that was generated by requests and rejected, below is the accepted request.
```
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="AWSAccessKeyId"
AKIAJGWMPJUFZ57CRWQQ
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="success_action_status"
200
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="acl"
private
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="key"
${filename}
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="signature"
hQ2NDqs9SHLoH5RtMQn9cfQITPc=
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="policy"
eyJjb25kaXRpb25zIjogW1sic3RhcnRzLXdpdGgiLCAiJGtleSIsICIiXSwgeyJhY2wiOiAicHJpdmF0ZSJ9LCB7InN1Y2Nlc3NfYWN0aW9uX3N0YXR1cyI6ICIyMDAifSwgWyJzdGFydHMtd2l0aCIsICIkQ29udGVudC1UeXBlIiwgIiJdLCBbImNvbnRlbnQtbGVuZ3RoLXJhbmdlIiwgMCwgMTA0ODU3NjAwXSwgeyJidWNrZXQiOiAiZGF0YXN5bmMtdXBsb2FkcyJ9XSwgImV4cGlyYXRpb24iOiAiMjAxNC0xMC0xOFQxMjozMjowMFoifQ==
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="Content-Type"
application/octet-stream
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="file"
This line is new
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="file"
and so is this one
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="file"
005205 6802 30 13 33.8 3.8 034344 034727 14.1 444982000133517375 0 ???????? 000000
--b12efdfeadf54d8d9041a03966c7f8d2
Content-Disposition: form-data; name="file"; filename="8b8e6cbe185e4d20b7e0586f076bb353.bvs"
--b12efdfeadf54d8d9041a03966c7f8d2--
```
The request body as generated using python poster and urllib2, which was accepted by S3:
```
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="AWSAccessKeyId"
Content-Type: text/plain; charset=utf-8
AKIAJGWMPJUFZ57CRWQQ
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="success_action_status"
Content-Type: text/plain; charset=utf-8
200
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="acl"
Content-Type: text/plain; charset=utf-8
private
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="key"
Content-Type: text/plain; charset=utf-8
${filename}
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="signature"
Content-Type: text/plain; charset=utf-8
BOanSb+x9yE0rx+Y08C7OC1bTZM=
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="policy"
Content-Type: text/plain; charset=utf-8
eyJjb25kaXRpb25zIjogW1sic3RhcnRzLXdpdGgiLCAiJGtleSIsICIiXSwgeyJhY2wiOiAicHJpdmF0ZSJ9LCB7InN1Y2Nlc3NfYWN0aW9uX3N0YXR1cyI6ICIyMDAifSwgWyJzdGFydHMtd2l0aCIsICIkQ29udGVudC1UeXBlIiwgIiJdLCBbImNvbnRlbnQtbGVuZ3RoLXJhbmdlIiwgMCwgMTA0ODU3NjAwXSwgeyJidWNrZXQiOiAiZGF0YXN5bmMtdXBsb2FkcyJ9XSwgImV4cGlyYXRpb24iOiAiMjAxNC0xMC0xOFQxMjowNDowMFoifQ==
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="Content-Type"
Content-Type: text/plain; charset=utf-8
application/octet-stream
--a6bf1e61b29f4a3980b62345e64c120f
Content-Disposition: form-data; name="file"; filename="C:/somedirectory/8b8e6cbe185e4d20b7e0586f076bb353.bvs"
Content-Type: text/plain; charset=utf-8
This line is new
and so is this one
005205 6802 30 13 33.8 3.8 034344 034727 14.1 444982000133517375 0 ???????? 000000
--a6bf1e61b29f4a3980b62345e64c120f--
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2286/reactions"
} | https://api.github.com/repos/psf/requests/issues/2286/timeline | null | completed | null | null | false | [
"Can you tell us what you're using to generate the last part of data where you're getting different form fields? (The part that generated the \"This line is new...\" data.) Without that we have no way of helping you.\n",
"That is simply a text file that was opened like `open(filename, 'rb')`. It is opened immedi... |
https://api.github.com/repos/psf/requests/issues/2285 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2285/labels{/name} | https://api.github.com/repos/psf/requests/issues/2285/comments | https://api.github.com/repos/psf/requests/issues/2285/events | https://github.com/psf/requests/issues/2285 | 46,093,195 | MDU6SXNzdWU0NjA5MzE5NQ== | 2,285 | res.json ist not a function under debian | {
"avatar_url": "https://avatars.githubusercontent.com/u/6000023?v=4",
"events_url": "https://api.github.com/users/tobiasschweizer/events{/privacy}",
"followers_url": "https://api.github.com/users/tobiasschweizer/followers",
"following_url": "https://api.github.com/users/tobiasschweizer/following{/other_user}",
"gists_url": "https://api.github.com/users/tobiasschweizer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tobiasschweizer",
"id": 6000023,
"login": "tobiasschweizer",
"node_id": "MDQ6VXNlcjYwMDAwMjM=",
"organizations_url": "https://api.github.com/users/tobiasschweizer/orgs",
"received_events_url": "https://api.github.com/users/tobiasschweizer/received_events",
"repos_url": "https://api.github.com/users/tobiasschweizer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tobiasschweizer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tobiasschweizer",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-17T12:20:32Z | 2021-09-08T23:07:53Z | 2014-10-17T13:08:03Z | NONE | resolved | Hi
If I do a HTTP request resulting in a JSON, I can access it directly in Debian 7.6
```
res = requests.get('url')
res.json['member']
```
In fact, when I call it as a function as described in the docu, it throws an error:
```
res.json()
TypeError: 'dict' object is not callable
```
So, on my system res.json is always a parsed JSON (a dict), while on other systems this is not the case.
My Python an rquests version:
Python 3.2.3 (default, Feb 20 2013, 14:44:27)
[GCC 4.7.2] on linux2
requests==0.12.1
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2285/reactions"
} | https://api.github.com/repos/psf/requests/issues/2285/timeline | null | completed | null | null | false | [
"Thanks for reporting this!\n\nThis is not a requests bug. The problem lies with your machine. The current requests version is 2.4.3, as can be seen [on PyPI](https://pypi.python.org/pypi/requests). The version you have installed, 0.12.1, was released more than two years ago. Understandably, the documentation for 2... |
https://api.github.com/repos/psf/requests/issues/2284 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2284/labels{/name} | https://api.github.com/repos/psf/requests/issues/2284/comments | https://api.github.com/repos/psf/requests/issues/2284/events | https://github.com/psf/requests/issues/2284 | 45,864,040 | MDU6SXNzdWU0NTg2NDA0MA== | 2,284 | bugs on HTTP-request nested json. | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 7 | 2014-10-15T13:12:41Z | 2021-09-08T23:06:04Z | 2015-01-19T09:18:15Z | NONE | resolved | I think, there's a bug on serializing a nested json.
for example, the following payload
{'username': 'bambang', 'device_info': {'os_version': '9.3.1', 'model': 'samsung', 'os_name': 'android'}}
would be serialized as:
"username=bambang&device_info=os_version&device_info=model&device_info=os_name"
however, sending the same json via ajax-javascript, would be serialized as:
username=bambang&device_info%5Bos_version%5D=9.3.1&device_info%5Bmodel%5D=samsung&device_info%5Bos_name%5D=android
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2284/reactions"
} | https://api.github.com/repos/psf/requests/issues/2284/timeline | null | completed | null | null | false | [
"I think you're a little confused about what JSON is. You cannot 'serialize' JSON. JSON is a serialization format, it's something you serialize _to_. What you are serializing there is a dictionary.\n\nThe second element of your confusion is that you aren't even serializing _to_ JSON. You're serializing to a format ... |
https://api.github.com/repos/psf/requests/issues/2283 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2283/labels{/name} | https://api.github.com/repos/psf/requests/issues/2283/comments | https://api.github.com/repos/psf/requests/issues/2283/events | https://github.com/psf/requests/issues/2283 | 45,809,552 | MDU6SXNzdWU0NTgwOTU1Mg== | 2,283 | vulnerability in SSL v3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-10-14T22:43:31Z | 2021-09-08T23:07:54Z | 2014-10-15T17:37:01Z | CONTRIBUTOR | resolved | Described here: http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html and here: http://chat.stackexchange.com/transcript/message/18153650#18153650
I am not sure what implications this has for requests (potentially none) but it is a good idea to look at it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2283/reactions"
} | https://api.github.com/repos/psf/requests/issues/2283/timeline | null | completed | null | null | false | [
"## I'm 100% in favor of forcing double checking that we don't use this by default and disabling it if we do\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"Checking now.\n\n## \n\nKevin Burke\nphone: 925.271.7005 | twentymilliseconds.com\n\nOn Tue, Oct 14, 2014 at 4:04 PM, Ian Cordas... |
https://api.github.com/repos/psf/requests/issues/2282 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2282/labels{/name} | https://api.github.com/repos/psf/requests/issues/2282/comments | https://api.github.com/repos/psf/requests/issues/2282/events | https://github.com/psf/requests/pull/2282 | 45,760,041 | MDExOlB1bGxSZXF1ZXN0MjI3MTc0NjY= | 2,282 | Update sidebarintro.html | {
"avatar_url": "https://avatars.githubusercontent.com/u/8458546?v=4",
"events_url": "https://api.github.com/users/morganthrapp/events{/privacy}",
"followers_url": "https://api.github.com/users/morganthrapp/followers",
"following_url": "https://api.github.com/users/morganthrapp/following{/other_user}",
"gists_url": "https://api.github.com/users/morganthrapp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/morganthrapp",
"id": 8458546,
"login": "morganthrapp",
"node_id": "MDQ6VXNlcjg0NTg1NDY=",
"organizations_url": "https://api.github.com/users/morganthrapp/orgs",
"received_events_url": "https://api.github.com/users/morganthrapp/received_events",
"repos_url": "https://api.github.com/users/morganthrapp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/morganthrapp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/morganthrapp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/morganthrapp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-10-14T14:56:11Z | 2021-09-08T10:01:04Z | 2014-10-14T15:22:48Z | CONTRIBUTOR | resolved | Fix issue #2279. "Gittip" changed to "Gratipay". Tip button extended from 48px to 60px.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2282/reactions"
} | https://api.github.com/repos/psf/requests/issues/2282/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2282.diff",
"html_url": "https://github.com/psf/requests/pull/2282",
"merged_at": "2014-10-14T15:22:48Z",
"patch_url": "https://github.com/psf/requests/pull/2282.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2282"
} | true | [
"@kennethreitz you okay with this?\n",
"<3\n",
"Yay, my first merge. :) \n",
"Thanks @morganthrapp! :cake: \n",
"Shouldn't the URLs be updated to https://gratipay.com/kennethreitz/ ?\n\nRedirect from old domain works for now for the link, not sure about the iframe.\n",
"It probably should.\nOn Oct 15, 201... |
https://api.github.com/repos/psf/requests/issues/2281 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2281/labels{/name} | https://api.github.com/repos/psf/requests/issues/2281/comments | https://api.github.com/repos/psf/requests/issues/2281/events | https://github.com/psf/requests/issues/2281 | 45,672,985 | MDU6SXNzdWU0NTY3Mjk4NQ== | 2,281 | Transfer-Encoding: chunked; API to get trailers? | {
"avatar_url": "https://avatars.githubusercontent.com/u/8687679?v=4",
"events_url": "https://api.github.com/users/davidabarrett/events{/privacy}",
"followers_url": "https://api.github.com/users/davidabarrett/followers",
"following_url": "https://api.github.com/users/davidabarrett/following{/other_user}",
"gists_url": "https://api.github.com/users/davidabarrett/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidabarrett",
"id": 8687679,
"login": "davidabarrett",
"node_id": "MDQ6VXNlcjg2ODc2Nzk=",
"organizations_url": "https://api.github.com/users/davidabarrett/orgs",
"received_events_url": "https://api.github.com/users/davidabarrett/received_events",
"repos_url": "https://api.github.com/users/davidabarrett/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidabarrett/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidabarrett/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidabarrett",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-10-13T18:41:56Z | 2021-09-08T23:07:54Z | 2014-10-13T18:43:57Z | NONE | resolved | Is there a way to process trailers using Requests?
http://tools.ietf.org/html/rfc7230#section-4.1.2
Adding a trailer, (e.g. Content-MD5) is
especially useful to detect incomplete
streamed reponses from an apache server,
otherwise its difficult (impossible?) to write
a robust client for large server responses.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2281/reactions"
} | https://api.github.com/repos/psf/requests/issues/2281/timeline | null | completed | null | null | false | [
"I'm afraid `httplib`, upon which requests is built, provides no API for obtaining trailers. This means we can't provide one either.\n\nWe are thinking of rewriting `httplib`, which would enable us to provide such support. In the meantime, I recommend you request the feature from the CPython developers.\n\nSorry we... |
https://api.github.com/repos/psf/requests/issues/2280 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2280/labels{/name} | https://api.github.com/repos/psf/requests/issues/2280/comments | https://api.github.com/repos/psf/requests/issues/2280/events | https://github.com/psf/requests/issues/2280 | 45,666,766 | MDU6SXNzdWU0NTY2Njc2Ng== | 2,280 | Requests is not properly escaping cookies | {
"avatar_url": "https://avatars.githubusercontent.com/u/84711?v=4",
"events_url": "https://api.github.com/users/erickt/events{/privacy}",
"followers_url": "https://api.github.com/users/erickt/followers",
"following_url": "https://api.github.com/users/erickt/following{/other_user}",
"gists_url": "https://api.github.com/users/erickt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erickt",
"id": 84711,
"login": "erickt",
"node_id": "MDQ6VXNlcjg0NzEx",
"organizations_url": "https://api.github.com/users/erickt/orgs",
"received_events_url": "https://api.github.com/users/erickt/received_events",
"repos_url": "https://api.github.com/users/erickt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erickt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erickt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erickt",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 2 | 2014-10-13T17:31:02Z | 2021-09-08T23:06:08Z | 2015-01-19T09:18:41Z | NONE | resolved | Requests does not appear to be escaping cookies appropriately, which triggers this bug:
``` python
>>> import requests
>>> r = requests.get('http://httpbin.org/cookies',
... cookies={
... 'escaped': '"a=b;b=c"',
... 'unescaped': 'x=y;y=z',
... })
>>> print r.text
{
"cookies": {
"escaped": "a=b;b=c",
"unescaped": "x=y",
"y": "z"
}
}
```
According to the RFC 2109 spec, cookies with reserved characters like `;` should be escaped with quotes. Here are the relevant definitions from that spec:
```
From RFC 2109:
av-pairs = av-pair *(";" av-pair)
av-pair = attr ["=" value] ; optional value
attr = token
value = word
word = token | quoted-string
cookie = "Cookie:" cookie-version
1*((";" | ",") cookie-value)
cookie-value = NAME "=" VALUE [";" path] [";" domain]
cookie-version = "$Version" "=" value
NAME = attr
VALUE = value
path = "$Path" "=" value
domain = "$Domain" "=" value
set-cookie = "Set-Cookie:" cookies
cookies = 1#cookie
cookie = NAME "=" VALUE *(";" cookie-av)
NAME = attr
VALUE = value
cookie-av = "Comment" "=" value
| "Domain" "=" value
| "Max-Age" "=" value
| "Path" "=" value
| "Secure"
| "Version" "=" 1*DIGIT
From RFC 2068:
token = 1*<any CHAR except CTLs or tspecials>
tspecials = "(" | ")" | "<" | ">" | "@"
| "," | ";" | ":" | "\" | <">
| "/" | "[" | "]" | "?" | "="
| "{" | "}" | SP | HT
quoted-string = ( <"> *(qdtext) <"> )
qdtext = <any TEXT except <">>
```
If I read requests source correctly, I believe this may actually be a bug in the upstream `cookiejar` code, which doesn't appear to escape cookies when it is added to the cookie jar. However, the `cookies` jar appears to work fine:
``` python
>>> import Cookie
>>> c=Cookie.SimpleCookie()
>>> c['escaped'] = '"a=b;b=c"'
>>> c['unescaped'] = 'a=b;b=c'
>>> print c.output()
Set-Cookie: escaped="\"a=b\073b=c\""
Set-Cookie: unescaped="a=b\073b=c"
```
You can find the method that does the quoting [here](https://hg.python.org/cpython/file/c0224ff67cdd/Lib/http/cookies.py#l225).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2280/reactions"
} | https://api.github.com/repos/psf/requests/issues/2280/timeline | null | completed | null | null | false | [
"If you tracked it upstream to the standard library, why did you open a bug here? Did you also open a bug [upstream](https://bugs.python.org)?\n",
"I wasn't completely positive if it was an upstream bug, so I wanted to\ncheck in with you first. cookielib doesn't really to be friendly to using\nit to prepare cooki... |
https://api.github.com/repos/psf/requests/issues/2279 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2279/labels{/name} | https://api.github.com/repos/psf/requests/issues/2279/comments | https://api.github.com/repos/psf/requests/issues/2279/events | https://github.com/psf/requests/issues/2279 | 45,663,906 | MDU6SXNzdWU0NTY2MzkwNg== | 2,279 | Gittip renamed to Gratipay, layout needs updating | {
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"descrip... | closed | true | null | [] | null | 0 | 2014-10-13T17:00:37Z | 2021-09-08T23:07:53Z | 2014-10-19T09:42:28Z | CONTRIBUTOR | resolved | Gittip [was renamed to Gratipay](https://github.com/gratipay/inside.gratipay.com/issues/73), and now the sidebar button is cut off:
<kbd>
</kbd>
Looks like some CSS needs adjusting.
For extra bonus points: adjust the link text in the sidebar too.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2279/reactions"
} | https://api.github.com/repos/psf/requests/issues/2279/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2278 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2278/labels{/name} | https://api.github.com/repos/psf/requests/issues/2278/comments | https://api.github.com/repos/psf/requests/issues/2278/events | https://github.com/psf/requests/issues/2278 | 45,647,239 | MDU6SXNzdWU0NTY0NzIzOQ== | 2,278 | apparent_encoding() hangs with high CPU utilization | {
"avatar_url": "https://avatars.githubusercontent.com/u/349269?v=4",
"events_url": "https://api.github.com/users/cazzerson/events{/privacy}",
"followers_url": "https://api.github.com/users/cazzerson/followers",
"following_url": "https://api.github.com/users/cazzerson/following{/other_user}",
"gists_url": "https://api.github.com/users/cazzerson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cazzerson",
"id": 349269,
"login": "cazzerson",
"node_id": "MDQ6VXNlcjM0OTI2OQ==",
"organizations_url": "https://api.github.com/users/cazzerson/orgs",
"received_events_url": "https://api.github.com/users/cazzerson/received_events",
"repos_url": "https://api.github.com/users/cazzerson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cazzerson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cazzerson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cazzerson",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-13T14:21:06Z | 2021-09-08T23:05:55Z | 2014-10-13T14:26:07Z | NONE | resolved | While processing a large set of requests, `apparent_encoding()` works well for quite a while but eventually hangs. All I have at this point is a traceback:
```
File "/opt/wsgi/.../ENV/lib/python2.7/site-packages/requests/models.py", line 637, in apparent_encoding
return chardet.detect(self.content)['encoding']
File "/opt/wsgi/.../ENV/lib/python2.7/site-packages/requests/packages/chardet/__init__.py", line 30, in detect
u.feed(aBuf)
File "/opt/wsgi/.../ENV/lib/python2.7/site-packages/requests/packages/chardet/universaldetector.py", line 128, in feed
if prober.feed(aBuf) == constants.eFoundIt:
File "/opt/wsgi/.../ENV/lib/python2.7/site-packages/requests/packages/chardet/charsetgroupprober.py", line 64, in feed
st = prober.feed(aBuf)
File "/opt/wsgi/.../ENV/lib/python2.7/site-packages/requests/packages/chardet/sjisprober.py", line 74, in feed
self._mContextAnalyzer.feed(aBuf[i + 1 - charLen:i + 3
```
I appreciate anything you can do to help.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2278/reactions"
} | https://api.github.com/repos/psf/requests/issues/2278/timeline | null | completed | null | null | false | [
"This is a duplicate of https://github.com/chardet/chardet/issues/29 which no one (who is remotely interested in the bug) has had the time to investigate or fix yet. This isn't a bug in requests.\n",
"This is also creating problems for me.\nAny work around?\n",
"@dav009 two options:\n1. Use cChardet instead of ... |
https://api.github.com/repos/psf/requests/issues/2277 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2277/labels{/name} | https://api.github.com/repos/psf/requests/issues/2277/comments | https://api.github.com/repos/psf/requests/issues/2277/events | https://github.com/psf/requests/issues/2277 | 45,600,135 | MDU6SXNzdWU0NTYwMDEzNQ== | 2,277 | make .raw more file like | {
"avatar_url": "https://avatars.githubusercontent.com/u/23225?v=4",
"events_url": "https://api.github.com/users/CarlFK/events{/privacy}",
"followers_url": "https://api.github.com/users/CarlFK/followers",
"following_url": "https://api.github.com/users/CarlFK/following{/other_user}",
"gists_url": "https://api.github.com/users/CarlFK/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CarlFK",
"id": 23225,
"login": "CarlFK",
"node_id": "MDQ6VXNlcjIzMjI1",
"organizations_url": "https://api.github.com/users/CarlFK/orgs",
"received_events_url": "https://api.github.com/users/CarlFK/received_events",
"repos_url": "https://api.github.com/users/CarlFK/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CarlFK/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CarlFK/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CarlFK",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-10-13T01:24:42Z | 2021-09-08T23:07:54Z | 2014-10-13T02:35:23Z | NONE | resolved | This is kinda half baked, but maybe there is a pattern that fits what I am looking for:
> > > r=requests.get(url)
> > > r.raw.name # AttributeError: 'HTTPResponse' object has no attribute 'name'
just like:
> > > fd = open('foo.txt')
> > > fd.name
> > > 'foo.txt'
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2277/reactions"
} | https://api.github.com/repos/psf/requests/issues/2277/timeline | null | completed | null | null | false | [
"@CarlFK what would that even return?\n",
"Beyond that, this belongs on urllib3. The `raw` attribute is a urllib3 HTTPResponse. I also see no reason to provide this. It may have a few file-like methods, but there's no reason for it to be more file-like.\n",
"The easy answer is url.\nmaybe parse it to look for s... |
https://api.github.com/repos/psf/requests/issues/2276 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2276/labels{/name} | https://api.github.com/repos/psf/requests/issues/2276/comments | https://api.github.com/repos/psf/requests/issues/2276/events | https://github.com/psf/requests/pull/2276 | 45,598,273 | MDExOlB1bGxSZXF1ZXN0MjI2MjIzMjE= | 2,276 | Attempt at #1956 DO NOT MERGE | {
"avatar_url": "https://avatars.githubusercontent.com/u/9095841?v=4",
"events_url": "https://api.github.com/users/mikecool1000/events{/privacy}",
"followers_url": "https://api.github.com/users/mikecool1000/followers",
"following_url": "https://api.github.com/users/mikecool1000/following{/other_user}",
"gists_url": "https://api.github.com/users/mikecool1000/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mikecool1000",
"id": 9095841,
"login": "mikecool1000",
"node_id": "MDQ6VXNlcjkwOTU4NDE=",
"organizations_url": "https://api.github.com/users/mikecool1000/orgs",
"received_events_url": "https://api.github.com/users/mikecool1000/received_events",
"repos_url": "https://api.github.com/users/mikecool1000/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mikecool1000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikecool1000/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mikecool1000",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-13T00:19:29Z | 2021-09-08T10:01:04Z | 2014-10-13T00:20:15Z | CONTRIBUTOR | resolved | My attempt at fixing this issue, not sure its great
| {
"avatar_url": "https://avatars.githubusercontent.com/u/9095841?v=4",
"events_url": "https://api.github.com/users/mikecool1000/events{/privacy}",
"followers_url": "https://api.github.com/users/mikecool1000/followers",
"following_url": "https://api.github.com/users/mikecool1000/following{/other_user}",
"gists_url": "https://api.github.com/users/mikecool1000/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mikecool1000",
"id": 9095841,
"login": "mikecool1000",
"node_id": "MDQ6VXNlcjkwOTU4NDE=",
"organizations_url": "https://api.github.com/users/mikecool1000/orgs",
"received_events_url": "https://api.github.com/users/mikecool1000/received_events",
"repos_url": "https://api.github.com/users/mikecool1000/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mikecool1000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikecool1000/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mikecool1000",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2276/reactions"
} | https://api.github.com/repos/psf/requests/issues/2276/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2276.diff",
"html_url": "https://github.com/psf/requests/pull/2276",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2276.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2276"
} | true | [
"@mikecool1000 why did you close this?\n",
"I just didn't want try to submit work I am unsure of\n\nSent from my iPhone\n\n> On Oct 12, 2014, at 7:16 PM, Ian Cordasco notifications@github.com wrote:\n> \n> @mikecool1000 why did you close this?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n"
] |
https://api.github.com/repos/psf/requests/issues/2275 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2275/labels{/name} | https://api.github.com/repos/psf/requests/issues/2275/comments | https://api.github.com/repos/psf/requests/issues/2275/events | https://github.com/psf/requests/issues/2275 | 45,586,595 | MDU6SXNzdWU0NTU4NjU5NQ== | 2,275 | Content-Length header not checked by requests if not enough data is sent | {
"avatar_url": "https://avatars.githubusercontent.com/u/5478285?v=4",
"events_url": "https://api.github.com/users/squareproton/events{/privacy}",
"followers_url": "https://api.github.com/users/squareproton/followers",
"following_url": "https://api.github.com/users/squareproton/following{/other_user}",
"gists_url": "https://api.github.com/users/squareproton/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/squareproton",
"id": 5478285,
"login": "squareproton",
"node_id": "MDQ6VXNlcjU0NzgyODU=",
"organizations_url": "https://api.github.com/users/squareproton/orgs",
"received_events_url": "https://api.github.com/users/squareproton/received_events",
"repos_url": "https://api.github.com/users/squareproton/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/squareproton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/squareproton/subscriptions",
"type": "User",
"url": "https://api.github.com/users/squareproton",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 4 | 2014-10-12T17:11:19Z | 2021-09-08T23:06:08Z | 2015-01-19T09:19:03Z | NONE | resolved | This is a feature request.
In our application we've noticed ~ 1 in 2500 GET requests is truncated early. The HTTP responses are typically 20K-2MB. This is certainly caused by network issues or dodgy HTTP servers and isn't a requests problem. By default requests 2.3.0 doesn't give any indication if the response body has a length smaller than the 'Content-Length' header indicated. The response object is presented as if nothing is amiss.
Requests is already doing some checks on Content-Length. When a response body is larger than a Content-Length header describes requests silently truncates the body. I've (yet) to find a way of detecting this case.
I would completely understand if the requests developers thought this type of check was outside the scope of the library - after all it is pretty easy to do this check in user code - but it seemed kind of anomalous given the super succinct high level api.
In a similar vein a Content-MD5 header check would be useful in our application but this is probably a lot more niche.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2275/reactions"
} | https://api.github.com/repos/psf/requests/issues/2275/timeline | null | completed | null | null | false | [
"Hi @squareproton \n\nLet me start off by saying that we've had this requested in the past (see: #1938) so you would do well to read that discussion to understand why we will not ever add content-length checking to requests. (This is also vaguely related to #2255 and https://github.com/sigmavirus24/requests-toolbel... |
https://api.github.com/repos/psf/requests/issues/2274 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2274/labels{/name} | https://api.github.com/repos/psf/requests/issues/2274/comments | https://api.github.com/repos/psf/requests/issues/2274/events | https://github.com/psf/requests/issues/2274 | 45,439,236 | MDU6SXNzdWU0NTQzOTIzNg== | 2,274 | update python-requests.org to SSL | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 3 | 2014-10-10T02:10:40Z | 2021-09-06T00:06:42Z | 2014-10-11T04:25:37Z | CONTRIBUTOR | resolved | it's now free if you use Cloudflare for DNS
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2274/reactions"
} | https://api.github.com/repos/psf/requests/issues/2274/timeline | null | completed | null | null | false | [
"Technically we have SSL, but it's only for ReadTheDocs.org so there's a Certificate Name mismatch. We could proxy a certificate from Heroku https://docs.readthedocs.org/en/latest/alternate_domains.html#cname-ssl \n\n```\n21:17.03 ericholscher he can proxy back to RTD from heroku as well\n21:17.06 ericholscher if... |
https://api.github.com/repos/psf/requests/issues/2273 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2273/labels{/name} | https://api.github.com/repos/psf/requests/issues/2273/comments | https://api.github.com/repos/psf/requests/issues/2273/events | https://github.com/psf/requests/pull/2273 | 45,439,100 | MDExOlB1bGxSZXF1ZXN0MjI1MzYyOTU= | 2,273 | Add Release History to the sidebar | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 3 | 2014-10-10T02:07:26Z | 2021-09-08T10:01:05Z | 2014-10-12T14:55:34Z | CONTRIBUTOR | resolved | Closes #2269
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2273/reactions"
} | https://api.github.com/repos/psf/requests/issues/2273/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2273.diff",
"html_url": "https://github.com/psf/requests/pull/2273",
"merged_at": "2014-10-12T14:55:34Z",
"patch_url": "https://github.com/psf/requests/pull/2273.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2273"
} | true | [
"Since @kennethreitz is very passionate about the docs, I want to make sure he's okay with this before we merge it @alex \n",
"Much needed :)\n",
":cake: \n"
] |
https://api.github.com/repos/psf/requests/issues/2272 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2272/labels{/name} | https://api.github.com/repos/psf/requests/issues/2272/comments | https://api.github.com/repos/psf/requests/issues/2272/events | https://github.com/psf/requests/issues/2272 | 45,362,630 | MDU6SXNzdWU0NTM2MjYzMA== | 2,272 | chunked encoding bug when release connection | {
"avatar_url": "https://avatars.githubusercontent.com/u/32542?v=4",
"events_url": "https://api.github.com/users/ilovenwd/events{/privacy}",
"followers_url": "https://api.github.com/users/ilovenwd/followers",
"following_url": "https://api.github.com/users/ilovenwd/following{/other_user}",
"gists_url": "https://api.github.com/users/ilovenwd/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ilovenwd",
"id": 32542,
"login": "ilovenwd",
"node_id": "MDQ6VXNlcjMyNTQy",
"organizations_url": "https://api.github.com/users/ilovenwd/orgs",
"received_events_url": "https://api.github.com/users/ilovenwd/received_events",
"repos_url": "https://api.github.com/users/ilovenwd/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ilovenwd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ilovenwd/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ilovenwd",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 11 | 2014-10-09T12:56:06Z | 2021-09-08T23:06:07Z | 2015-01-19T09:19:32Z | NONE | resolved | https://github.com/kennethreitz/requests/blob/master/requests/adapters.py#L404
I encounter a bug that will be fixed when remove this line.
Since the preload_content=False in HTTPResponse.from_httplib, we cannot _put_conn back to pool (where it's closed)
``` python
low_conn = conn._get_conn(timeout=timeout)
try:
low_conn.putrequest(request.method,
url,
skip_accept_encoding=True)
.....
r = low_conn.getresponse()
resp = HTTPResponse.from_httplib(
r,
pool=conn,
connection=low_conn,
preload_content=False,
decode_content=False
)
except:
# If we hit any problems here, clean up the connection.
# Then, reraise so that we can handle the actual exception.
low_conn.close()
raise
else:
# All is well, return the connection to the pool.
conn._put_conn(low_conn)
```
the code trigger this bug (just illustrate):
```
monkey.patch_all()
def data_stream(n):
for i in range(n):
x = str(i)
gevent.sleep(0)
yield x
gevent.spawn(requests.post('xxx', data=data_stream(100)))
gevent.spawn(requests.post('xxx', data=data_stream(100)))
gevent.joinall()
```
the first post gets normal response, while the second get empty response (conn closed before read content)
but result is ok if we don't use gevent.spawn
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2272/reactions"
} | https://api.github.com/repos/psf/requests/issues/2272/timeline | null | completed | null | null | false | [
"Why aren't you using grequests?\n",
"I look grequests code and find that the code is indeed what I do now use gevent.\nAlso, I need more control with the concurrency, the example code is just a simple demo.\nI think this is a bug of requests.\n",
"Can you provide something that actually allows us to reproduce ... |
https://api.github.com/repos/psf/requests/issues/2271 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2271/labels{/name} | https://api.github.com/repos/psf/requests/issues/2271/comments | https://api.github.com/repos/psf/requests/issues/2271/events | https://github.com/psf/requests/pull/2271 | 45,320,725 | MDExOlB1bGxSZXF1ZXN0MjI0NjgyNzg= | 2,271 | Fixed #2250 | {
"avatar_url": "https://avatars.githubusercontent.com/u/9095841?v=4",
"events_url": "https://api.github.com/users/mikecool1000/events{/privacy}",
"followers_url": "https://api.github.com/users/mikecool1000/followers",
"following_url": "https://api.github.com/users/mikecool1000/following{/other_user}",
"gists_url": "https://api.github.com/users/mikecool1000/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mikecool1000",
"id": 9095841,
"login": "mikecool1000",
"node_id": "MDQ6VXNlcjkwOTU4NDE=",
"organizations_url": "https://api.github.com/users/mikecool1000/orgs",
"received_events_url": "https://api.github.com/users/mikecool1000/received_events",
"repos_url": "https://api.github.com/users/mikecool1000/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mikecool1000/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikecool1000/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mikecool1000",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-10-09T02:28:13Z | 2021-09-08T10:01:06Z | 2014-10-10T18:30:18Z | CONTRIBUTOR | resolved | Fixed #2250 with #2271
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2271/reactions"
} | https://api.github.com/repos/psf/requests/issues/2271/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2271.diff",
"html_url": "https://github.com/psf/requests/pull/2271",
"merged_at": "2014-10-10T18:30:18Z",
"patch_url": "https://github.com/psf/requests/pull/2271.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2271"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/2270 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2270/labels{/name} | https://api.github.com/repos/psf/requests/issues/2270/comments | https://api.github.com/repos/psf/requests/issues/2270/events | https://github.com/psf/requests/issues/2270 | 45,300,413 | MDU6SXNzdWU0NTMwMDQxMw== | 2,270 | form url encoding data | {
"avatar_url": "https://avatars.githubusercontent.com/u/555399?v=4",
"events_url": "https://api.github.com/users/3goats/events{/privacy}",
"followers_url": "https://api.github.com/users/3goats/followers",
"following_url": "https://api.github.com/users/3goats/following{/other_user}",
"gists_url": "https://api.github.com/users/3goats/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/3goats",
"id": 555399,
"login": "3goats",
"node_id": "MDQ6VXNlcjU1NTM5OQ==",
"organizations_url": "https://api.github.com/users/3goats/orgs",
"received_events_url": "https://api.github.com/users/3goats/received_events",
"repos_url": "https://api.github.com/users/3goats/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/3goats/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/3goats/subscriptions",
"type": "User",
"url": "https://api.github.com/users/3goats",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-08T21:37:04Z | 2021-09-08T23:07:55Z | 2014-10-08T22:03:25Z | NONE | resolved | Hi I have the following data structure which needs to be sent to a web-service as form-urlencoded:
```
data = {'Properties': [{'key': 'KeyLength', 'value': '512'}], 'Category': 'keysets', 'Offset': '0', 'Limit': '100'}
I'm posting it like this:
```
```
req = requests.post('http://server1/ws1/api/data/filters/', data=data)
```
This is how it should look received after its been encoded and decoded:
```
Properties[0][key]=KeyLength&Properties[0][value]=768&Category=keysets&Offset=0&Limit=100
```
However it seems end up like this:
``
Category=keysets&Limit=100&Properties=[{'value': '512', 'key': 'KeyLength'}]&Offset=0
```
Here's how it looks in the chrome developer tools which works fine from the browser.
Can somebody please advise what I'm doing wrong.
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2270/reactions"
} | https://api.github.com/repos/psf/requests/issues/2270/timeline | null | completed | null | null | false | [
"You already asked this question on [StackOverflow](https://stackoverflow.com/questions/26266664/requests-form-urlencoded-data) which is the appropriate forum. This is a common problem and since I don't have the time to answer your question there now (and didn't look since you posted it 40 minutes ago), I'm sure so... |
https://api.github.com/repos/psf/requests/issues/2269 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2269/labels{/name} | https://api.github.com/repos/psf/requests/issues/2269/comments | https://api.github.com/repos/psf/requests/issues/2269/events | https://github.com/psf/requests/issues/2269 | 45,062,943 | MDU6SXNzdWU0NTA2Mjk0Mw== | 2,269 | Link to the changelog in the sidebar of the documentation | {
"avatar_url": "https://avatars.githubusercontent.com/u/772?v=4",
"events_url": "https://api.github.com/users/alex/events{/privacy}",
"followers_url": "https://api.github.com/users/alex/followers",
"following_url": "https://api.github.com/users/alex/following{/other_user}",
"gists_url": "https://api.github.com/users/alex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alex",
"id": 772,
"login": "alex",
"node_id": "MDQ6VXNlcjc3Mg==",
"organizations_url": "https://api.github.com/users/alex/orgs",
"received_events_url": "https://api.github.com/users/alex/received_events",
"repos_url": "https://api.github.com/users/alex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alex",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-10-07T03:13:48Z | 2021-09-04T00:06:28Z | 2014-10-12T14:55:34Z | MEMBER | resolved | Right now it's unfortunately a bit hard to find, "Community updates" is not necessarily where I would usually look for the changelog / release notes. Right now the way I find it is to search "CVE", because I know that word is on the page.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2269/reactions"
} | https://api.github.com/repos/psf/requests/issues/2269/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2268 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2268/labels{/name} | https://api.github.com/repos/psf/requests/issues/2268/comments | https://api.github.com/repos/psf/requests/issues/2268/events | https://github.com/psf/requests/pull/2268 | 44,933,787 | MDExOlB1bGxSZXF1ZXN0MjIyNjA4MzE= | 2,268 | Re-order params for backwards compat | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-10-05T23:56:27Z | 2021-09-08T10:01:08Z | 2014-10-06T09:40:03Z | CONTRIBUTOR | resolved | Address @kevinburke's concerns
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2268/reactions"
} | https://api.github.com/repos/psf/requests/issues/2268/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2268.diff",
"html_url": "https://github.com/psf/requests/pull/2268",
"merged_at": "2014-10-06T09:40:03Z",
"patch_url": "https://github.com/psf/requests/pull/2268.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2268"
} | true | [
"LGTM\n"
] |
https://api.github.com/repos/psf/requests/issues/2267 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2267/labels{/name} | https://api.github.com/repos/psf/requests/issues/2267/comments | https://api.github.com/repos/psf/requests/issues/2267/events | https://github.com/psf/requests/pull/2267 | 44,933,052 | MDExOlB1bGxSZXF1ZXN0MjIyNjA1NTQ= | 2,267 | allow unicode URLs on Python 2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/151929?v=4",
"events_url": "https://api.github.com/users/minrk/events{/privacy}",
"followers_url": "https://api.github.com/users/minrk/followers",
"following_url": "https://api.github.com/users/minrk/following{/other_user}",
"gists_url": "https://api.github.com/users/minrk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/minrk",
"id": 151929,
"login": "minrk",
"node_id": "MDQ6VXNlcjE1MTkyOQ==",
"organizations_url": "https://api.github.com/users/minrk/orgs",
"received_events_url": "https://api.github.com/users/minrk/received_events",
"repos_url": "https://api.github.com/users/minrk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/minrk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/minrk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/minrk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-10-05T23:30:52Z | 2021-09-08T10:01:07Z | 2014-10-06T09:39:54Z | CONTRIBUTOR | resolved | on Python 2 `u'é'.decode('utf8')` fails with UnicodeEncodeError, but only AttributeError is caught.
This only calls decode on known bytes objects.
includes a test that succeeds on 2.4.1 and fails on 2.4.2
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2267/reactions"
} | https://api.github.com/repos/psf/requests/issues/2267/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2267.diff",
"html_url": "https://github.com/psf/requests/pull/2267",
"merged_at": "2014-10-06T09:39:54Z",
"patch_url": "https://github.com/psf/requests/pull/2267.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2267"
} | true | [
"cc @buttscicles \n",
"FWIW this works for me.\n"
] |
https://api.github.com/repos/psf/requests/issues/2266 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2266/labels{/name} | https://api.github.com/repos/psf/requests/issues/2266/comments | https://api.github.com/repos/psf/requests/issues/2266/events | https://github.com/psf/requests/issues/2266 | 44,922,005 | MDU6SXNzdWU0NDkyMjAwNQ== | 2,266 | Move utility functions from requests.utils to requests-toolbelt | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 6 | 2014-10-05T17:08:58Z | 2021-09-08T07:00:40Z | 2017-07-30T14:06:03Z | CONTRIBUTOR | resolved | # Reasoning
requests is an _HTTP_ library, not an HTML library. Some of these utility functions are far more focused on HTML and a Response's body than on HTTP. With that said, they don't belong in requests proper. Instead they belong in a third-party library and currently the best place for that is requests-toolbelt.
# Path to removal
Step 1:
- [x] Add `DeprecationWarning`s to all of these functions in the very next possible release of requests (either 2.4.3 or 2.5.0) (See PR https://github.com/kennethreitz/requests/pull/2309)
Step 2:
Prior to releasing 3.0, remove the following functions and migrate them to [requests-toolbelt](/sigmavirus24/requests-toolbelt). Allow requests-toolbelt to release a version first and then release 3.0.
- [x] `get_encodings_from_content`
- [x] `get_unicode_from_response`
- [ ] more functions?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2266/reactions"
} | https://api.github.com/repos/psf/requests/issues/2266/timeline | null | completed | null | null | false | [
"+1000000\n",
"Why `get_unicode_from_response`?\n",
"We already provide the unicode in the response as `r.text`.\n",
"Back in the day, we had a function that would convert any Request object into a curl command string.\n\n...lol\n",
"Yeah, people have recreated that time and again. That's not ending up in t... |
https://api.github.com/repos/psf/requests/issues/2265 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2265/labels{/name} | https://api.github.com/repos/psf/requests/issues/2265/comments | https://api.github.com/repos/psf/requests/issues/2265/events | https://github.com/psf/requests/pull/2265 | 44,903,523 | MDExOlB1bGxSZXF1ZXN0MjIyNTEwMjI= | 2,265 | Remove timeout from __attrs__ | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-10-05T04:04:57Z | 2021-09-08T10:01:08Z | 2014-10-05T08:05:29Z | CONTRIBUTOR | resolved | We do not allow the user to set the timeout value on the Session any longer so
this is extraneous
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2265/reactions"
} | https://api.github.com/repos/psf/requests/issues/2265/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2265.diff",
"html_url": "https://github.com/psf/requests/pull/2265",
"merged_at": "2014-10-05T08:05:29Z",
"patch_url": "https://github.com/psf/requests/pull/2265.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2265"
} | true | [
"LGTM. :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2264 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2264/labels{/name} | https://api.github.com/repos/psf/requests/issues/2264/comments | https://api.github.com/repos/psf/requests/issues/2264/events | https://github.com/psf/requests/issues/2264 | 44,885,750 | MDU6SXNzdWU0NDg4NTc1MA== | 2,264 | ImportError: cannot import name urlencode | {
"avatar_url": "https://avatars.githubusercontent.com/u/1220668?v=4",
"events_url": "https://api.github.com/users/evanemolo/events{/privacy}",
"followers_url": "https://api.github.com/users/evanemolo/followers",
"following_url": "https://api.github.com/users/evanemolo/following{/other_user}",
"gists_url": "https://api.github.com/users/evanemolo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/evanemolo",
"id": 1220668,
"login": "evanemolo",
"node_id": "MDQ6VXNlcjEyMjA2Njg=",
"organizations_url": "https://api.github.com/users/evanemolo/orgs",
"received_events_url": "https://api.github.com/users/evanemolo/received_events",
"repos_url": "https://api.github.com/users/evanemolo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/evanemolo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evanemolo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/evanemolo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-10-04T15:22:44Z | 2021-09-08T23:07:57Z | 2014-10-05T01:27:58Z | NONE | resolved | I am running Python 2.7.8. I get the following error from `import requests`:
```
Traceback (most recent call last):
File "request_get.py", line 1, in <module>
import requests
File "/usr/local/lib/python2.7/site-packages/requests/__init__.py", line 58, in <module>
from . import utils
File "/usr/local/lib/python2.7/site-packages/requests/utils.py", line 25, in <module>
from .compat import parse_http_list as _parse_list_header
File "/usr/local/lib/python2.7/site-packages/requests/compat.py", line 7, in <module>
from .packages import chardet
File "/usr/local/lib/python2.7/site-packages/requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/__init__.py", line 10, in <module>
from .connectionpool import (
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 37, in <module>
from .request import RequestMethods
File "/usr/local/lib/python2.7/site-packages/requests/packages/urllib3/request.py", line 4, in <module>
from urllib import urlencode
ImportError: cannot import name urlencode
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1220668?v=4",
"events_url": "https://api.github.com/users/evanemolo/events{/privacy}",
"followers_url": "https://api.github.com/users/evanemolo/followers",
"following_url": "https://api.github.com/users/evanemolo/following{/other_user}",
"gists_url": "https://api.github.com/users/evanemolo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/evanemolo",
"id": 1220668,
"login": "evanemolo",
"node_id": "MDQ6VXNlcjEyMjA2Njg=",
"organizations_url": "https://api.github.com/users/evanemolo/orgs",
"received_events_url": "https://api.github.com/users/evanemolo/received_events",
"repos_url": "https://api.github.com/users/evanemolo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/evanemolo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/evanemolo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/evanemolo",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2264/reactions"
} | https://api.github.com/repos/psf/requests/issues/2264/timeline | null | completed | null | null | false | [
"``` pycon\n$ python\nPython 2.7.8 (default, Aug 24 2014, 21:26:19)\n[GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.40)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n>>> import requests\n>>> from urllib import urlencode\n>>>\n```\n\nCan you give us more information?\... |
https://api.github.com/repos/psf/requests/issues/2263 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2263/labels{/name} | https://api.github.com/repos/psf/requests/issues/2263/comments | https://api.github.com/repos/psf/requests/issues/2263/events | https://github.com/psf/requests/pull/2263 | 44,834,329 | MDExOlB1bGxSZXF1ZXN0MjIyMjIwODA= | 2,263 | Fixed #2205 | {
"avatar_url": "https://avatars.githubusercontent.com/u/3482660?v=4",
"events_url": "https://api.github.com/users/daftshady/events{/privacy}",
"followers_url": "https://api.github.com/users/daftshady/followers",
"following_url": "https://api.github.com/users/daftshady/following{/other_user}",
"gists_url": "https://api.github.com/users/daftshady/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daftshady",
"id": 3482660,
"login": "daftshady",
"node_id": "MDQ6VXNlcjM0ODI2NjA=",
"organizations_url": "https://api.github.com/users/daftshady/orgs",
"received_events_url": "https://api.github.com/users/daftshady/received_events",
"repos_url": "https://api.github.com/users/daftshady/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daftshady/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daftshady/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daftshady",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 78002701,
"name": "Do Not Merge",
"node_id": "MDU6TGFiZWw3ODAwMjcwMQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 6 | 2014-10-03T18:48:43Z | 2021-09-08T09:01:16Z | 2014-11-12T17:36:20Z | CONTRIBUTOR | resolved | Hello.
I made some fixes to `get_unicode_from_response` fixing #2205.
It now tries every encodings from meta tags by calling `get_encodings_from_content`.
Because encoding charset is case-insensitive by RFC 2616, encoding charset is appended to `tried_encodings` in lower case.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2263/reactions"
} | https://api.github.com/repos/psf/requests/issues/2263/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2263.diff",
"html_url": "https://github.com/psf/requests/pull/2263",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2263.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2263"
} | true | [
"This looks great @daftshady, thanks! :cake: I'll let @sigmavirus24 review, but I'm :+1:.\n",
"I have one concern. Once that's addressed I'll be :+1:.\n",
"@sigmavirus24 I agree with you. It's fairly reasonable to use a set here. I added another commit.\n",
"Looks great now! Thanks @daftshady!\n",
"This fun... |
https://api.github.com/repos/psf/requests/issues/2262 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2262/labels{/name} | https://api.github.com/repos/psf/requests/issues/2262/comments | https://api.github.com/repos/psf/requests/issues/2262/events | https://github.com/psf/requests/issues/2262 | 44,750,686 | MDU6SXNzdWU0NDc1MDY4Ng== | 2,262 | Proper encoding for application/json Content-Type | {
"avatar_url": "https://avatars.githubusercontent.com/u/827573?v=4",
"events_url": "https://api.github.com/users/noseworthy/events{/privacy}",
"followers_url": "https://api.github.com/users/noseworthy/followers",
"following_url": "https://api.github.com/users/noseworthy/following{/other_user}",
"gists_url": "https://api.github.com/users/noseworthy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/noseworthy",
"id": 827573,
"login": "noseworthy",
"node_id": "MDQ6VXNlcjgyNzU3Mw==",
"organizations_url": "https://api.github.com/users/noseworthy/orgs",
"received_events_url": "https://api.github.com/users/noseworthy/received_events",
"repos_url": "https://api.github.com/users/noseworthy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/noseworthy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/noseworthy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/noseworthy",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-10-02T23:19:13Z | 2021-09-08T23:07:58Z | 2014-10-03T14:10:38Z | NONE | resolved | Hello,
I've looked through open and closed issues but haven't seen this raised before. Sorry if I'm bringing up something that's already been addressed. That said, here we go:
I'm running a flask-restful app and returning JSON responses to requests. Flask-restful helpfully encodes the response body as UTF-8 and sets the Content-Type to "application/json". When i make a request to my server using requests, requests can't properly detect the encoding and it looks like this is because I haven't set the charset on the Content-Type header. However, according to [RFC 4627](http://www.ietf.org/rfc/rfc4627.txt) the encoding for application/json responses is either UTF-8, UTF-16, or UTF-32. The default is UTF-8, but you can detect which one of the three encodings is being used by looking at the first four bytes as mentioned in [RFC 4627](http://www.ietf.org/rfc/rfc4627.txt).
When requests receives a response with a Content-Type header of application/json shouldn't it try to detect the encoding as UTF-8, UTF-16, or UTF-32 and set the encoding on the response object accordingly? This would help greatly with using `response.text`. Right now I'm setting the encoding on the response object manually.
Just to note: `response.json()` works perfectly so I realize this is a bit of a corner case since users will probably just deserialize the response anyway.
Thanks for your time, and all your awesome work. I absolutely love requests.
Mike
Possibly Related Issues: #1665 #1467
Reference to @mitsuhiko's opinion on the matter: https://github.com/mitsuhiko/flask/issues/454#issuecomment-4578200
| {
"avatar_url": "https://avatars.githubusercontent.com/u/827573?v=4",
"events_url": "https://api.github.com/users/noseworthy/events{/privacy}",
"followers_url": "https://api.github.com/users/noseworthy/followers",
"following_url": "https://api.github.com/users/noseworthy/following{/other_user}",
"gists_url": "https://api.github.com/users/noseworthy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/noseworthy",
"id": 827573,
"login": "noseworthy",
"node_id": "MDQ6VXNlcjgyNzU3Mw==",
"organizations_url": "https://api.github.com/users/noseworthy/orgs",
"received_events_url": "https://api.github.com/users/noseworthy/received_events",
"repos_url": "https://api.github.com/users/noseworthy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/noseworthy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/noseworthy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/noseworthy",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2262/reactions"
} | https://api.github.com/repos/psf/requests/issues/2262/timeline | null | completed | null | null | false | [
"> requests can't properly detect the encoding\n\nWhat does `response.apparent_encoding` return? This sounds l like a bug in chardet.\n\n> The default is UTF-8, but you can detect which one of the three encodings is being used by looking at the first four bytes\n\nrequests _could_ do this, but won't because this is... |
https://api.github.com/repos/psf/requests/issues/2261 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2261/labels{/name} | https://api.github.com/repos/psf/requests/issues/2261/comments | https://api.github.com/repos/psf/requests/issues/2261/events | https://github.com/psf/requests/issues/2261 | 44,729,047 | MDU6SXNzdWU0NDcyOTA0Nw== | 2,261 | There is no straightforward way to enable debug or show the raw http request + response | {
"avatar_url": "https://avatars.githubusercontent.com/u/94108?v=4",
"events_url": "https://api.github.com/users/dequis/events{/privacy}",
"followers_url": "https://api.github.com/users/dequis/followers",
"following_url": "https://api.github.com/users/dequis/following{/other_user}",
"gists_url": "https://api.github.com/users/dequis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dequis",
"id": 94108,
"login": "dequis",
"node_id": "MDQ6VXNlcjk0MTA4",
"organizations_url": "https://api.github.com/users/dequis/orgs",
"received_events_url": "https://api.github.com/users/dequis/received_events",
"repos_url": "https://api.github.com/users/dequis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dequis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dequis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dequis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-10-02T19:30:54Z | 2021-09-08T23:07:59Z | 2014-10-02T19:40:26Z | NONE | resolved | There's this stack overflow question: http://stackoverflow.com/q/10588644/2195033
The question is about something that should be simple: Print the whole http request.
Because often it's much easier to debug something by seeing it exactly as it was sent over the wire (Figuratively. Obviously I'd prefer the unencrypted one in the case of https)
I've visited this page way too many times. Unsurprisingly, it's always the same two answers:
- "Copypaste these 20 lines into your project to enable debugging"
- "Inspect these 20 attributes one by one, or assemble the whole thing yourself"
In the comments of the second one, someone asks 'Which of these gives me "the entire request, headers included"?'. No replies to that other than the assumption that reassembling the request manually is okay. The first one kinda does the job, but it feels like the times when i copypasted activestate recipes to be able to do multipart file uploads.
Does it really have to be this way? Why not provide built-in helpers for these things?
```
requests.enable_basic_debugging_globally()
```
Or:
```
print(req.raw_request_string_as_it_is_going_to_get_sent_over_the_wire)
print(resp.raw_response_string_with_headers_and_status_line)
print(resp.raw_response_string_with_headers_and_status_line_and_also_the_request_before_it)
```
Ok, I'm not great at api design. You get the idea.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2261/reactions"
} | https://api.github.com/repos/psf/requests/issues/2261/timeline | null | completed | null | null | false | [
"Thanks for this!\n\nThis is a not entirely uncommon request. Unfortunately, I sincerely doubt it's going to happen. I've tackled a variant of this request before [here](https://github.com/kennethreitz/requests/pull/1802#issuecomment-30644444). The most relevant part is this:\n\n> This gets even worse if you consid... |
https://api.github.com/repos/psf/requests/issues/2260 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2260/labels{/name} | https://api.github.com/repos/psf/requests/issues/2260/comments | https://api.github.com/repos/psf/requests/issues/2260/events | https://github.com/psf/requests/issues/2260 | 44,663,731 | MDU6SXNzdWU0NDY2MzczMQ== | 2,260 | Ignore proxy or always use 80 port | {
"avatar_url": "https://avatars.githubusercontent.com/u/1228001?v=4",
"events_url": "https://api.github.com/users/obelyakov/events{/privacy}",
"followers_url": "https://api.github.com/users/obelyakov/followers",
"following_url": "https://api.github.com/users/obelyakov/following{/other_user}",
"gists_url": "https://api.github.com/users/obelyakov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/obelyakov",
"id": 1228001,
"login": "obelyakov",
"node_id": "MDQ6VXNlcjEyMjgwMDE=",
"organizations_url": "https://api.github.com/users/obelyakov/orgs",
"received_events_url": "https://api.github.com/users/obelyakov/received_events",
"repos_url": "https://api.github.com/users/obelyakov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/obelyakov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/obelyakov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/obelyakov",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-10-02T08:53:21Z | 2021-09-08T23:07:58Z | 2014-10-02T12:49:05Z | NONE | resolved | Hello!
I use lib and get requests with proxy on port 8080.
Example:
r=requests.get('http://www.rambler.ru/', proxies={'http:':'http://login:pass@x.x.x.x:8080', 'https:':'https://login:pass@x.x.x.x:8080'}, timeout=5)
Outgoing connections to port 80 on the server closed. And this request I freezes on this server. But running on the server where the 80 ports are open.
Also I see the blocked connection firewall on port 80.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2260/reactions"
} | https://api.github.com/repos/psf/requests/issues/2260/timeline | null | completed | null | null | false | [
"The proxies parameter should be:\n\n``` python\nproxies = { 'http': 'http://login:pass@x.x.x.x:8080', 'https': 'https://login:pass@x.x.x.x:8080' }\n```\n\nYou need to move the colons out of the first and third fields.\n",
"@Hasimir is correct. Please consult the documentation before raising bugs. =)\n",
"Sorry... |
https://api.github.com/repos/psf/requests/issues/2259 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2259/labels{/name} | https://api.github.com/repos/psf/requests/issues/2259/comments | https://api.github.com/repos/psf/requests/issues/2259/events | https://github.com/psf/requests/issues/2259 | 44,534,684 | MDU6SXNzdWU0NDUzNDY4NA== | 2,259 | HTTP Authentication Any | {
"avatar_url": "https://avatars.githubusercontent.com/u/1127463?v=4",
"events_url": "https://api.github.com/users/tarzanjw/events{/privacy}",
"followers_url": "https://api.github.com/users/tarzanjw/followers",
"following_url": "https://api.github.com/users/tarzanjw/following{/other_user}",
"gists_url": "https://api.github.com/users/tarzanjw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tarzanjw",
"id": 1127463,
"login": "tarzanjw",
"node_id": "MDQ6VXNlcjExMjc0NjM=",
"organizations_url": "https://api.github.com/users/tarzanjw/orgs",
"received_events_url": "https://api.github.com/users/tarzanjw/received_events",
"repos_url": "https://api.github.com/users/tarzanjw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tarzanjw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tarzanjw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tarzanjw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-10-01T07:15:19Z | 2021-09-08T23:08:00Z | 2014-10-01T07:51:46Z | NONE | resolved | Should `requests` supports the "ANY" authentication method for http authentication?
PHP curl supports this method: http://php.net/manual/en/function.curl-setopt.php (please search for CURLOPT_HTTPAUTH).
This method will support http authentication for both Basic and Digest. It will send the header with Basic first, and try for Digest if the server requests for Digest.
Because requests is for human, normally the client should not care about Basic or Digest.
What do you think?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2259/reactions"
} | https://api.github.com/repos/psf/requests/issues/2259/timeline | null | completed | null | null | false | [
"It's not clear to me that it's worthwhile adding this to requests proper. However, the [toolbelt project has exactly what you're looking for](http://toolbelt.readthedocs.org/en/latest/user.html#guessauth).\n",
"Thank you, this is exactly what I am looking for.\n\nP/S: In toolbelt's documentation, I think there i... |
https://api.github.com/repos/psf/requests/issues/2258 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2258/labels{/name} | https://api.github.com/repos/psf/requests/issues/2258/comments | https://api.github.com/repos/psf/requests/issues/2258/events | https://github.com/psf/requests/pull/2258 | 44,464,628 | MDExOlB1bGxSZXF1ZXN0MjIwMTQ4MTY= | 2,258 | Add json parameter | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 6 | 2014-09-30T15:59:29Z | 2021-09-07T00:06:40Z | 2014-10-05T16:46:09Z | CONTRIBUTOR | resolved | Closes #2025
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2258/reactions"
} | https://api.github.com/repos/psf/requests/issues/2258/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2258.diff",
"html_url": "https://github.com/psf/requests/pull/2258",
"merged_at": "2014-10-05T16:46:09Z",
"patch_url": "https://github.com/psf/requests/pull/2258.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2258"
} | true | [
"@Lukasa @kevinburke care to take another look at this?\n",
"LGTM\n",
"omg I'm so excited \n\n:heart: :sparkles: :cake: :rose: :cake: :sparkles: :heart:\n",
"@willingc thank you so much for your hard work on this. :cake: (Those emoji from @kennethreitz are for you ;))\n",
"Thank you @sigmavirus24 for your ... |
https://api.github.com/repos/psf/requests/issues/2257 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2257/labels{/name} | https://api.github.com/repos/psf/requests/issues/2257/comments | https://api.github.com/repos/psf/requests/issues/2257/events | https://github.com/psf/requests/pull/2257 | 44,463,621 | MDExOlB1bGxSZXF1ZXN0MjIwMTQyMTY= | 2,257 | Add json upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/1894766?v=4",
"events_url": "https://api.github.com/users/akhomchenko/events{/privacy}",
"followers_url": "https://api.github.com/users/akhomchenko/followers",
"following_url": "https://api.github.com/users/akhomchenko/following{/other_user}",
"gists_url": "https://api.github.com/users/akhomchenko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akhomchenko",
"id": 1894766,
"login": "akhomchenko",
"node_id": "MDQ6VXNlcjE4OTQ3NjY=",
"organizations_url": "https://api.github.com/users/akhomchenko/orgs",
"received_events_url": "https://api.github.com/users/akhomchenko/received_events",
"repos_url": "https://api.github.com/users/akhomchenko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akhomchenko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akhomchenko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akhomchenko",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-09-30T15:52:07Z | 2021-09-08T10:01:11Z | 2014-09-30T16:08:07Z | CONTRIBUTOR | resolved | Closes https://github.com/kennethreitz/requests/issues/2025
TODO:
- [ ] check `TODO`s
- [ ] more tests?
- [ ] `application/json` and files upload
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1894766?v=4",
"events_url": "https://api.github.com/users/akhomchenko/events{/privacy}",
"followers_url": "https://api.github.com/users/akhomchenko/followers",
"following_url": "https://api.github.com/users/akhomchenko/following{/other_user}",
"gists_url": "https://api.github.com/users/akhomchenko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akhomchenko",
"id": 1894766,
"login": "akhomchenko",
"node_id": "MDQ6VXNlcjE4OTQ3NjY=",
"organizations_url": "https://api.github.com/users/akhomchenko/orgs",
"received_events_url": "https://api.github.com/users/akhomchenko/received_events",
"repos_url": "https://api.github.com/users/akhomchenko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akhomchenko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akhomchenko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akhomchenko",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2257/reactions"
} | https://api.github.com/repos/psf/requests/issues/2257/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2257.diff",
"html_url": "https://github.com/psf/requests/pull/2257",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2257.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2257"
} | true | [
"@gagoman someone had been working on this for a while and stalled. I've opened a PR on their behalf. Did you read the entirety of the issue?\n",
"Yes, I had read an issue and there were no progress since June, so I've decided to implement it.\n",
"@sigmavirus24 reopen if it is still required.\n",
"@gagoman t... |
https://api.github.com/repos/psf/requests/issues/2256 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2256/labels{/name} | https://api.github.com/repos/psf/requests/issues/2256/comments | https://api.github.com/repos/psf/requests/issues/2256/events | https://github.com/psf/requests/issues/2256 | 44,423,818 | MDU6SXNzdWU0NDQyMzgxOA== | 2,256 | connectionpool:Setting: read timeout to None & "'Task got bad yield: <Response [200]>'" | {
"avatar_url": "https://avatars.githubusercontent.com/u/3073209?v=4",
"events_url": "https://api.github.com/users/marcoippolito/events{/privacy}",
"followers_url": "https://api.github.com/users/marcoippolito/followers",
"following_url": "https://api.github.com/users/marcoippolito/following{/other_user}",
"gists_url": "https://api.github.com/users/marcoippolito/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/marcoippolito",
"id": 3073209,
"login": "marcoippolito",
"node_id": "MDQ6VXNlcjMwNzMyMDk=",
"organizations_url": "https://api.github.com/users/marcoippolito/orgs",
"received_events_url": "https://api.github.com/users/marcoippolito/received_events",
"repos_url": "https://api.github.com/users/marcoippolito/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/marcoippolito/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/marcoippolito/subscriptions",
"type": "User",
"url": "https://api.github.com/users/marcoippolito",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-09-30T10:45:18Z | 2021-09-08T23:08:00Z | 2014-09-30T15:50:30Z | NONE | resolved | Hi,
I'm porting the already functioning (in python3.4) code
(https://github.com/KeepSafe/aiohttp/blob/master/examples/crawl.py ) into python2.76 code,
through trollius, urllib and requests.
But....the output I get is:
time python crawl_requests.py http://www.ilsole24ore.com/english-version/front-page.shtml
DEBUG:trollius:Using selector: EpollSelector
('url to do = ', 'http://www.ilsole24ore.com/english-version/front-page.shtml')
('processing:', 'http://www.ilsole24ore.com/english-version/front-page.shtml')
INFO:urllib3.connectionpool:Starting new HTTP connection (1): www.ilsole24ore.com
DEBUG:urllib3.connectionpool:Setting read timeout to None
DEBUG:urllib3.connectionpool:"GET /english-version/front-page.shtml HTTP/1.1" 200 13699
('...', 'http://www.ilsole24ore.com/english-version/front-page.shtml', 'has error', "'Task got bad yield: <Response [200]>'")
('done:', 1, '; ok:', 0)
Here is my code:
http://ipaste.org/fLj
Could pleas give me some hints in solving this issue?
Lookin forward to your helpfull hints and suggestions.
Kind regards.
Marco
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2256/reactions"
} | https://api.github.com/repos/psf/requests/issues/2256/timeline | null | completed | null | null | false | [
"This is not a requests bug. =) We do not support asyncio.\n\nThe fact that you attempted this suggests you don't have a full understanding of how asyncio functions, which is understandable because asyncio is a nightmare of complexity. The short statement is that asyncio uses an event loop, combined with futures an... |
https://api.github.com/repos/psf/requests/issues/2255 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2255/labels{/name} | https://api.github.com/repos/psf/requests/issues/2255/comments | https://api.github.com/repos/psf/requests/issues/2255/events | https://github.com/psf/requests/issues/2255 | 44,247,749 | MDU6SXNzdWU0NDI0Nzc0OQ== | 2,255 | Session requests should respect verify=False | {
"avatar_url": "https://avatars.githubusercontent.com/u/585003?v=4",
"events_url": "https://api.github.com/users/isaulv/events{/privacy}",
"followers_url": "https://api.github.com/users/isaulv/followers",
"following_url": "https://api.github.com/users/isaulv/following{/other_user}",
"gists_url": "https://api.github.com/users/isaulv/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/isaulv",
"id": 585003,
"login": "isaulv",
"node_id": "MDQ6VXNlcjU4NTAwMw==",
"organizations_url": "https://api.github.com/users/isaulv/orgs",
"received_events_url": "https://api.github.com/users/isaulv/received_events",
"repos_url": "https://api.github.com/users/isaulv/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/isaulv/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/isaulv/subscriptions",
"type": "User",
"url": "https://api.github.com/users/isaulv",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 20 | 2014-09-29T01:06:48Z | 2021-09-08T22:00:52Z | 2015-08-31T09:45:01Z | NONE | resolved | Using a website that has a self-signed cert, the following use of verify=False fails:
import requests
s = requests.Session()
r = s.get('https://selfsignedsite')
_traceback_
r = s.get('https://selfsidnedsite', verify=False)
_traceback is the same about SSL3 not finding a valid cert_
requests.get('https://selfsignedsite', verify=False)
_traceback as above_
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2255/reactions"
} | https://api.github.com/repos/psf/requests/issues/2255/timeline | null | completed | null | null | false | [
"fails in what way?\n\nOn Sunday, September 28, 2014, Isaul Vargas notifications@github.com\nwrote:\n\n> Using a website that has a self-signed cert, the following use of\n> verify=False fails:\n> import requests\n> s = requests.Session()\n> r = s.get('https://selfsignedsite')\n> \n> r = s.get('https://selfsidnedsi... |
https://api.github.com/repos/psf/requests/issues/2254 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2254/labels{/name} | https://api.github.com/repos/psf/requests/issues/2254/comments | https://api.github.com/repos/psf/requests/issues/2254/events | https://github.com/psf/requests/issues/2254 | 44,219,057 | MDU6SXNzdWU0NDIxOTA1Nw== | 2,254 | SSLError (hostname mismatch) on forge.ocamlcore.org | {
"avatar_url": "https://avatars.githubusercontent.com/u/14172?v=4",
"events_url": "https://api.github.com/users/timbertson/events{/privacy}",
"followers_url": "https://api.github.com/users/timbertson/followers",
"following_url": "https://api.github.com/users/timbertson/following{/other_user}",
"gists_url": "https://api.github.com/users/timbertson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/timbertson",
"id": 14172,
"login": "timbertson",
"node_id": "MDQ6VXNlcjE0MTcy",
"organizations_url": "https://api.github.com/users/timbertson/orgs",
"received_events_url": "https://api.github.com/users/timbertson/received_events",
"repos_url": "https://api.github.com/users/timbertson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/timbertson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timbertson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/timbertson",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-09-28T06:51:45Z | 2021-09-08T23:07:58Z | 2014-10-04T05:38:07Z | NONE | resolved | Using the latest version (2.4.1):
```
>>> requests.get('https://forge.ocamlcore.org/', stream=True)
```
Throws:
```
SSLError: hostname 'forge.ocamlcore.org' doesn't match either of 'lists.ocamlcore.org', 'ocamlcore.org'
```
The same URL shows no SSL issues in firefox or chrome, and curl also thinks it's fine:
```
$ curl -Iv 'https://forge.ocamlcore.org/'
( ... )
* Connected to forge.ocamlcore.org (87.98.154.45) port 443 (#0)
* Initializing NSS with certpath: sql:/etc/pki/nssdb
* CAfile: /etc/pki/tls/certs/ca-bundle.crt
CApath: none
* SSL connection using TLS_DHE_RSA_WITH_AES_128_CBC_SHA
* Server certificate:
* subject: E=<redacted>@gmail.com,CN=forge.ocamlcore.org,C=CH,OID.2.5.4.13=ngEw1eS9i0H4lis9
* start date: Oct 01 20:21:04 2013 GMT
* expire date: Oct 02 00:48:22 2014 GMT
* common name: forge.ocamlcore.org
* issuer: CN=StartCom Class 1 Primary Intermediate Server CA,OU=Secure Digital Certificate Signing,O=StartCom Ltd.,C=IL
> HEAD / HTTP/1.1
> User-Agent: curl/7.32.0
> Host: forge.ocamlcore.org
> Accept: */*
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
( ... )
```
I'm afraid I don't know enough about SSL certs to debug this any further, but I'm assuming that requests is missing something if firefox, chrome & curl all accept the cert.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/14172?v=4",
"events_url": "https://api.github.com/users/timbertson/events{/privacy}",
"followers_url": "https://api.github.com/users/timbertson/followers",
"following_url": "https://api.github.com/users/timbertson/following{/other_user}",
"gists_url": "https://api.github.com/users/timbertson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/timbertson",
"id": 14172,
"login": "timbertson",
"node_id": "MDQ6VXNlcjE0MTcy",
"organizations_url": "https://api.github.com/users/timbertson/orgs",
"received_events_url": "https://api.github.com/users/timbertson/received_events",
"repos_url": "https://api.github.com/users/timbertson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/timbertson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/timbertson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/timbertson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2254/reactions"
} | https://api.github.com/repos/psf/requests/issues/2254/timeline | null | completed | null | null | false | [
"This is almost certainly an SNI issue. I don't have access to a shell right now to confirm it, but I suspect you're using Python 2.\n\nIn that case you need to install three new packages. You can either do that by reinstalling requests with the `security` extension (`pip install requests[security]`) or by installi... |
https://api.github.com/repos/psf/requests/issues/2253 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2253/labels{/name} | https://api.github.com/repos/psf/requests/issues/2253/comments | https://api.github.com/repos/psf/requests/issues/2253/events | https://github.com/psf/requests/pull/2253 | 44,184,573 | MDExOlB1bGxSZXF1ZXN0MjE4OTIzNzA= | 2,253 | A fix for #1979: repeat HTTP digest authentication after redirect. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1481195?v=4",
"events_url": "https://api.github.com/users/yossigo/events{/privacy}",
"followers_url": "https://api.github.com/users/yossigo/followers",
"following_url": "https://api.github.com/users/yossigo/following{/other_user}",
"gists_url": "https://api.github.com/users/yossigo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yossigo",
"id": 1481195,
"login": "yossigo",
"node_id": "MDQ6VXNlcjE0ODExOTU=",
"organizations_url": "https://api.github.com/users/yossigo/orgs",
"received_events_url": "https://api.github.com/users/yossigo/received_events",
"repos_url": "https://api.github.com/users/yossigo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yossigo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yossigo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yossigo",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 5 | 2014-09-27T18:19:36Z | 2021-09-08T09:01:18Z | 2014-11-01T14:04:29Z | CONTRIBUTOR | resolved | This solves the following scenario:
(1) 401 (Digest authentication begins)
(2) 302 (Authenticated, response redirects to another endpoint)
(3) 401 (New endpoint also requires authentication)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2253/reactions"
} | https://api.github.com/repos/psf/requests/issues/2253/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2253.diff",
"html_url": "https://github.com/psf/requests/pull/2253",
"merged_at": "2014-11-01T14:04:29Z",
"patch_url": "https://github.com/psf/requests/pull/2253.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2253"
} | true | [
"Hey @yossigo thanks for the pull request!\n\nWhile you're here, could you fix something that I think is a bug? On [this line](https://github.com/yossigo/requests/commit/c28da22e9c42e22b303bb07da434ce65e10c0cb2#diff-9f3a95293a5d26032b1c588167760362R193) could you change it to\n\n``` python\nsetattr(self, 'num_401_c... |
https://api.github.com/repos/psf/requests/issues/2252 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2252/labels{/name} | https://api.github.com/repos/psf/requests/issues/2252/comments | https://api.github.com/repos/psf/requests/issues/2252/events | https://github.com/psf/requests/pull/2252 | 44,182,917 | MDExOlB1bGxSZXF1ZXN0MjE4OTE5NzA= | 2,252 | to use ssl connections ssl varialble must be differ than None. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3129353?v=4",
"events_url": "https://api.github.com/users/kostyll/events{/privacy}",
"followers_url": "https://api.github.com/users/kostyll/followers",
"following_url": "https://api.github.com/users/kostyll/following{/other_user}",
"gists_url": "https://api.github.com/users/kostyll/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kostyll",
"id": 3129353,
"login": "kostyll",
"node_id": "MDQ6VXNlcjMxMjkzNTM=",
"organizations_url": "https://api.github.com/users/kostyll/orgs",
"received_events_url": "https://api.github.com/users/kostyll/received_events",
"repos_url": "https://api.github.com/users/kostyll/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kostyll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kostyll/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kostyll",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-27T17:42:35Z | 2021-09-08T10:01:12Z | 2014-09-27T19:20:15Z | NONE | resolved | it's my solution of #2251
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2252/reactions"
} | https://api.github.com/repos/psf/requests/issues/2252/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2252.diff",
"html_url": "https://github.com/psf/requests/pull/2252",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2252.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2252"
} | true | [
"Hi @kostyll thanks for the change! Unfortunately this is a change that belongs upstream in [urllib3](/shazow/urllib3).\n"
] |
https://api.github.com/repos/psf/requests/issues/2251 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2251/labels{/name} | https://api.github.com/repos/psf/requests/issues/2251/comments | https://api.github.com/repos/psf/requests/issues/2251/events | https://github.com/psf/requests/issues/2251 | 44,182,878 | MDU6SXNzdWU0NDE4Mjg3OA== | 2,251 | to use ssl connections ssl varialble must be differ than None. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3129353?v=4",
"events_url": "https://api.github.com/users/kostyll/events{/privacy}",
"followers_url": "https://api.github.com/users/kostyll/followers",
"following_url": "https://api.github.com/users/kostyll/following{/other_user}",
"gists_url": "https://api.github.com/users/kostyll/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kostyll",
"id": 3129353,
"login": "kostyll",
"node_id": "MDQ6VXNlcjMxMjkzNTM=",
"organizations_url": "https://api.github.com/users/kostyll/orgs",
"received_events_url": "https://api.github.com/users/kostyll/received_events",
"repos_url": "https://api.github.com/users/kostyll/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kostyll/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kostyll/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kostyll",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-09-27T17:41:46Z | 2021-09-08T23:08:01Z | 2014-09-29T01:46:25Z | NONE | resolved | Hello, I've get the next problem
response = requests.post(self.url("translate"), data=data)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/api.py", line 92, in post
return request('post', url, data=data, *_kwargs)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/api.py", line 48, in request
return session.request(method=method, url=url, *_kwargs)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/sessions.py", line 451, in request
resp = self.send(prep, *_send_kwargs)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/sessions.py", line 562, in send
r = adapter.send(request, *_kwargs)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/adapters.py", line 362, in send
timeout=timeout
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/packages/urllib3/connectionpool.py", line 516, in urlopen
body=body, headers=headers)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/packages/urllib3/connectionpool.py", line 304, in _make_request
self._validate_conn(conn)
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/packages/urllib3/connectionpool.py", line 722, in _validate_conn
conn.connect()
File "/home/andrew/.config/sublime-text-3/Packages/RusVariablesTranslator/requests/requests/packages/urllib3/connection.py", line 169, in connect
self.sock = ssl.wrap_socket(conn, self.key_file, self.cert_file)
AttributeError: 'NoneType' object has no attribute 'wrap_socket'
....
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2251/reactions"
} | https://api.github.com/repos/psf/requests/issues/2251/timeline | null | completed | null | null | false | [
"Hey @kostyll can you tell us what version of Python you're using?\n",
"py3.3.3 - interpreter in sublime text 3. but I don't know how to import ssl(_ssl) module .... in sublime text 3 under linux python interpreter is compliled without this module ...\n",
"This is not really a bug, it's just what happens when y... |
https://api.github.com/repos/psf/requests/issues/2250 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2250/labels{/name} | https://api.github.com/repos/psf/requests/issues/2250/comments | https://api.github.com/repos/psf/requests/issues/2250/events | https://github.com/psf/requests/issues/2250 | 43,960,734 | MDU6SXNzdWU0Mzk2MDczNA== | 2,250 | Link header parsing breaks if attribute value has commas | {
"avatar_url": "https://avatars.githubusercontent.com/u/1693859?v=4",
"events_url": "https://api.github.com/users/hariharshankar/events{/privacy}",
"followers_url": "https://api.github.com/users/hariharshankar/followers",
"following_url": "https://api.github.com/users/hariharshankar/following{/other_user}",
"gists_url": "https://api.github.com/users/hariharshankar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hariharshankar",
"id": 1693859,
"login": "hariharshankar",
"node_id": "MDQ6VXNlcjE2OTM4NTk=",
"organizations_url": "https://api.github.com/users/hariharshankar/orgs",
"received_events_url": "https://api.github.com/users/hariharshankar/received_events",
"repos_url": "https://api.github.com/users/hariharshankar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hariharshankar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hariharshankar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hariharshankar",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"... | closed | true | null | [] | null | 5 | 2014-09-25T20:01:41Z | 2021-09-08T23:07:55Z | 2014-10-10T18:30:18Z | NONE | resolved | The function parse_header_links does not parse link headers correctly if the attribute value for a link has commas or semi-colons in them.
https://github.com/kennethreitz/requests/blob/master/requests/utils.py#L562
The Memento protocol (RFC 7089) allows HTTP datetime in the link attributes and the link header parser cannot parse this reliably.
For example:
``` python
>>> r = requests.get('http://mementoweb.org/timegate/http://www.google.com', allow_redirects=False)
>>> r.headers['link']
"""<http://www.google.com>;rel="original" ,
<http://mementoweb.org/timemap/link/1/http://www.google.com>;rel="timemap"; type="application/link-format",
<http://mementoweb.org/timegate/http://www.google.com>;rel="timegate",
<http://web.archive.org/web/20140911065756/http://www.google.com/>;rel="memento"; datetime="Thu, 11 Sep 2014 06:57:56 GMT",
<http://web.archive.org/web/20131004112325/http://www.google.com/>;rel="memento first"; datetime="Sat, 04 Oct 1997 22:20:27 GMT",
<http://web.archive.org/web/20121011204401/https://www.google.com/>;rel="memento last"; datetime="Sat, 11 Oct 2014 10:05:51 GMT""""
>>> r.links
{'04 Oct 1997 22:20:27 GMT': {'url': '04 Oct 1997 22:20:27 GMT'},
'11 Oct 2014 10:05:51 GMT': {'url': '11 Oct 2014 10:05:51 GMT'},
'11 Sep 2014 06:57:56 GMT': {'url': '11 Sep 2014 06:57:56 GMT'},
'memento': {'datetime': 'Thu',
'rel': 'memento',
'url': 'http://web.archive.org/web/20140911065756/http://www.google.com/'},
'memento first': {'datetime': 'Sat',
'rel': 'memento first',
'url': 'http://web.archive.org/web/20131004112325/http://www.google.com/'},
'memento last': {'datetime': 'Sat',
'rel': 'memento last',
'url': 'http://web.archive.org/web/20121011204401/https://www.google.com/'},
'original': {'rel': 'original', 'url': 'http://www.google.com'},
'timegate': {'rel': 'timegate',
'url': 'http://mementoweb.org/timegate/http://www.google.com'},
'timemap': {'rel': 'timemap',
'type': 'application/link-format',
'url': 'http://mementoweb.org/timemap/link/1/http://www.google.com'}}
```
There are third party link header parsers in the URLs below, but it would be very convenient if the requests' parse_header_links function could parse correctly.
https://bitbucket.org/azaroth42/linkheaderparser/src/c2321bf3349b94a12a37ed8c41d4e4785006ada7/parse_link.py?at=default
https://gist.github.com/mnot/210535
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2250/reactions"
} | https://api.github.com/repos/psf/requests/issues/2250/timeline | null | completed | null | null | false | [
"Yeah, we're aware of this and have had an open issue in the past for it. It's not high-priority work for us, so I'm tagging it as 'Contributor Friendly' and leaving it open for others.\n\nIf someone finds this, it was last looked at in part of #1980.\n",
"Actually your bug report is inaccurate and a bit misleadi... |
https://api.github.com/repos/psf/requests/issues/2249 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2249/labels{/name} | https://api.github.com/repos/psf/requests/issues/2249/comments | https://api.github.com/repos/psf/requests/issues/2249/events | https://github.com/psf/requests/pull/2249 | 43,959,582 | MDExOlB1bGxSZXF1ZXN0MjE4MDc5MDE= | 2,249 | fix #2247 | {
"avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4",
"events_url": "https://api.github.com/users/t-8ch/events{/privacy}",
"followers_url": "https://api.github.com/users/t-8ch/followers",
"following_url": "https://api.github.com/users/t-8ch/following{/other_user}",
"gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/t-8ch",
"id": 717901,
"login": "t-8ch",
"node_id": "MDQ6VXNlcjcxNzkwMQ==",
"organizations_url": "https://api.github.com/users/t-8ch/orgs",
"received_events_url": "https://api.github.com/users/t-8ch/received_events",
"repos_url": "https://api.github.com/users/t-8ch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/t-8ch",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-09-25T19:50:35Z | 2021-09-08T10:01:08Z | 2014-10-05T17:19:14Z | CONTRIBUTOR | resolved | We have to pass urllib3 the url without the authentication information,
else it will be parsed by httplib as a netloc and included in the request line
and Host header
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2249/reactions"
} | https://api.github.com/repos/psf/requests/issues/2249/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2249.diff",
"html_url": "https://github.com/psf/requests/pull/2249",
"merged_at": "2014-10-05T17:19:14Z",
"patch_url": "https://github.com/psf/requests/pull/2249.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2249"
} | true | [
"This _looks_ right, but it's hard for me to know because URLs are a crazy mess. I'll let @sigmavirus24 review this, he knows URLs better than I do.\n",
"So if we used a better (read: less forgiving) URL parser library we wouldn't need to split on `@` (like we do [here](https://github.com/kennethreitz/requests/pu... |
https://api.github.com/repos/psf/requests/issues/2248 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2248/labels{/name} | https://api.github.com/repos/psf/requests/issues/2248/comments | https://api.github.com/repos/psf/requests/issues/2248/events | https://github.com/psf/requests/pull/2248 | 43,949,232 | MDExOlB1bGxSZXF1ZXN0MjE4MDE0NzM= | 2,248 | docs: Clarify how to pass a custom set of CAs | {
"avatar_url": "https://avatars.githubusercontent.com/u/2631925?v=4",
"events_url": "https://api.github.com/users/jktjkt/events{/privacy}",
"followers_url": "https://api.github.com/users/jktjkt/followers",
"following_url": "https://api.github.com/users/jktjkt/following{/other_user}",
"gists_url": "https://api.github.com/users/jktjkt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jktjkt",
"id": 2631925,
"login": "jktjkt",
"node_id": "MDQ6VXNlcjI2MzE5MjU=",
"organizations_url": "https://api.github.com/users/jktjkt/orgs",
"received_events_url": "https://api.github.com/users/jktjkt/received_events",
"repos_url": "https://api.github.com/users/jktjkt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jktjkt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jktjkt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jktjkt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-25T18:12:30Z | 2021-09-08T10:01:13Z | 2014-09-25T18:28:05Z | CONTRIBUTOR | resolved | This new wording makes it hopefully easier to find how to override the
system-provided list of trusted CAs. I failed to find this through some googling
and had to resort to asking on IRC previously.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2248/reactions"
} | https://api.github.com/repos/psf/requests/issues/2248/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2248.diff",
"html_url": "https://github.com/psf/requests/pull/2248",
"merged_at": "2014-09-25T18:28:05Z",
"patch_url": "https://github.com/psf/requests/pull/2248.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2248"
} | true | [
"Thanks! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2247 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2247/labels{/name} | https://api.github.com/repos/psf/requests/issues/2247/comments | https://api.github.com/repos/psf/requests/issues/2247/events | https://github.com/psf/requests/issues/2247 | 43,923,889 | MDU6SXNzdWU0MzkyMzg4OQ== | 2,247 | requests sends HTTP auth details in Host header | {
"avatar_url": "https://avatars.githubusercontent.com/u/56778?v=4",
"events_url": "https://api.github.com/users/cool-RR/events{/privacy}",
"followers_url": "https://api.github.com/users/cool-RR/followers",
"following_url": "https://api.github.com/users/cool-RR/following{/other_user}",
"gists_url": "https://api.github.com/users/cool-RR/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cool-RR",
"id": 56778,
"login": "cool-RR",
"node_id": "MDQ6VXNlcjU2Nzc4",
"organizations_url": "https://api.github.com/users/cool-RR/orgs",
"received_events_url": "https://api.github.com/users/cool-RR/received_events",
"repos_url": "https://api.github.com/users/cool-RR/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cool-RR/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cool-RR/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cool-RR",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 22 | 2014-09-25T14:15:55Z | 2021-09-08T23:07:56Z | 2014-10-05T17:19:15Z | NONE | resolved | I noticed that the Host header of my http requests generated by `requests` have the HTTP auth credentials, like this:
```
Host: admin:viG7Xs@google.com
```
(This is when I specified them in the URL.)
Is this standard? It looks weird to me.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2247/reactions"
} | https://api.github.com/repos/psf/requests/issues/2247/timeline | null | completed | null | null | false | [
"Wow, that's wrong! I don't have my laptop right now so I can't investigate, but can anyone repro with the latest version of requests?\n",
"``` pycon\n>>> import requests\n>>> r = requests.get('https://username:foo@httpbin.org/get')\n>>> r.json()['headers']\n{'Accept': '*/*', 'Accept-Encoding': 'gzip, deflate', '... |
https://api.github.com/repos/psf/requests/issues/2246 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2246/labels{/name} | https://api.github.com/repos/psf/requests/issues/2246/comments | https://api.github.com/repos/psf/requests/issues/2246/events | https://github.com/psf/requests/issues/2246 | 43,598,962 | MDU6SXNzdWU0MzU5ODk2Mg== | 2,246 | speed limit and time out | {
"avatar_url": "https://avatars.githubusercontent.com/u/1589540?v=4",
"events_url": "https://api.github.com/users/ibroomcorn/events{/privacy}",
"followers_url": "https://api.github.com/users/ibroomcorn/followers",
"following_url": "https://api.github.com/users/ibroomcorn/following{/other_user}",
"gists_url": "https://api.github.com/users/ibroomcorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ibroomcorn",
"id": 1589540,
"login": "ibroomcorn",
"node_id": "MDQ6VXNlcjE1ODk1NDA=",
"organizations_url": "https://api.github.com/users/ibroomcorn/orgs",
"received_events_url": "https://api.github.com/users/ibroomcorn/received_events",
"repos_url": "https://api.github.com/users/ibroomcorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ibroomcorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ibroomcorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ibroomcorn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-23T07:32:49Z | 2021-09-08T23:08:03Z | 2014-09-23T09:48:35Z | NONE | resolved | requests doesn't have speed limit?
curl like this: --limit-rate
wget like this: --limit-rate
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2246/reactions"
} | https://api.github.com/repos/psf/requests/issues/2246/timeline | null | completed | null | null | false | [
"Correct.\n\nRequests simply doesn't have this low-level of control over the HTTP stack except in one specific situation: when sending a chunked upload, which we handle ourselves. In all other cases `httplib` is responsible for sending our data, and _it_ is the one that lacks a speed limit.\n\nWithout a patch to `h... |
https://api.github.com/repos/psf/requests/issues/2245 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2245/labels{/name} | https://api.github.com/repos/psf/requests/issues/2245/comments | https://api.github.com/repos/psf/requests/issues/2245/events | https://github.com/psf/requests/pull/2245 | 43,582,412 | MDExOlB1bGxSZXF1ZXN0MjE2MjE3Nzg= | 2,245 | Correct redirection introduction | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-23T02:08:53Z | 2021-09-08T10:01:14Z | 2014-09-23T06:25:26Z | CONTRIBUTOR | resolved | The history attribute contains responses, not requests.
Thanks to Yang Yang for reporting this to me via email
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2245/reactions"
} | https://api.github.com/repos/psf/requests/issues/2245/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2245.diff",
"html_url": "https://github.com/psf/requests/pull/2245",
"merged_at": "2014-09-23T06:25:26Z",
"patch_url": "https://github.com/psf/requests/pull/2245.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2245"
} | true | [
":+1: :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2244 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2244/labels{/name} | https://api.github.com/repos/psf/requests/issues/2244/comments | https://api.github.com/repos/psf/requests/issues/2244/events | https://github.com/psf/requests/pull/2244 | 43,582,135 | MDExOlB1bGxSZXF1ZXN0MjE2MjE2NzM= | 2,244 | Avoid getting stuck in a loop | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2014-09-23T02:04:04Z | 2021-09-08T03:01:07Z | 2014-09-25T02:57:38Z | CONTRIBUTOR | resolved | This prevents a case where we make a request to URL A, which 301s to B which
would then 301 back to A. Alternatively, for less simple schemes, this will
also prevent us from getting stuck in a loop, e.g., it will prevent the
following from causing an endless loop:
```
A -> B -> C -> D -> E -> F --
^ \
| /
---<------------<----------<-
```
Fixes #2231.
I tested this by cloning httpbin and hard coding a permanent redirect loop from `/relative-redirect/1` to `/relative-redirect/2` so that we could trigger this. This pull request fixes it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2244/reactions"
} | https://api.github.com/repos/psf/requests/issues/2244/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2244.diff",
"html_url": "https://github.com/psf/requests/pull/2244",
"merged_at": "2014-09-25T02:57:38Z",
"patch_url": "https://github.com/psf/requests/pull/2244.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2244"
} | true | [
"This no longer gets us stuck in a loop by causing us to actually hit the URLs that we're being forcibly redirected to, starting with the _end_ of the redirect chain.\n\nIs this what we want? Or do we want to throw an exception, e.g. `RedirectLoopError`?\n",
"## I don't think we should be adding a new exception f... |
https://api.github.com/repos/psf/requests/issues/2243 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2243/labels{/name} | https://api.github.com/repos/psf/requests/issues/2243/comments | https://api.github.com/repos/psf/requests/issues/2243/events | https://github.com/psf/requests/issues/2243 | 43,552,857 | MDU6SXNzdWU0MzU1Mjg1Nw== | 2,243 | Source code clarification sought | {
"avatar_url": "https://avatars.githubusercontent.com/u/70234?v=4",
"events_url": "https://api.github.com/users/philip-goh/events{/privacy}",
"followers_url": "https://api.github.com/users/philip-goh/followers",
"following_url": "https://api.github.com/users/philip-goh/following{/other_user}",
"gists_url": "https://api.github.com/users/philip-goh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/philip-goh",
"id": 70234,
"login": "philip-goh",
"node_id": "MDQ6VXNlcjcwMjM0",
"organizations_url": "https://api.github.com/users/philip-goh/orgs",
"received_events_url": "https://api.github.com/users/philip-goh/received_events",
"repos_url": "https://api.github.com/users/philip-goh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/philip-goh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/philip-goh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/philip-goh",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-22T21:05:16Z | 2021-09-08T23:08:04Z | 2014-09-22T21:12:35Z | NONE | resolved | I'd like some clarification as to whether the following code in [requests/api.py](https://github.com/kennethreitz/requests/blob/master/requests/api.py#L47-L48) is correct.
```
def request(method, url, **kwargs):
"""Constructs and sends a :class:`Request <Request>`.
Returns :class:`Response <Response>` object.
:param method: method for the new :class:`Request` object.
:param url: URL for the new :class:`Request` object.
:param params: (optional) Dictionary or bytes to be sent in the query string for the :class:`Request`.
:param data: (optional) Dictionary, bytes, or file-like object to send in the body of the :class:`Request`.
:param headers: (optional) Dictionary of HTTP Headers to send with the :class:`Request`.
:param cookies: (optional) Dict or CookieJar object to send with the :class:`Request`.
:param files: (optional) Dictionary of ``'name': file-like-objects`` (or ``{'name': ('filename', fileobj)}``) for multipart encoding upload.
:param auth: (optional) Auth tuple to enable Basic/Digest/Custom HTTP Auth.
:param timeout: (optional) How long to wait for the server to send data
before giving up, as a float, or a (`connect timeout, read timeout
<user/advanced.html#timeouts>`_) tuple.
:type timeout: float or tuple
:param allow_redirects: (optional) Boolean. Set to True if POST/PUT/DELETE redirect following is allowed.
:type allow_redirects: bool
:param proxies: (optional) Dictionary mapping protocol to the URL of the proxy.
:param verify: (optional) if ``True``, the SSL cert will be verified. A CA_BUNDLE path can also be provided.
:param stream: (optional) if ``False``, the response content will be immediately downloaded.
:param cert: (optional) if String, path to ssl client cert file (.pem). If Tuple, ('cert', 'key') pair.
Usage::
>>> import requests
>>> req = requests.request('GET', 'http://httpbin.org/get')
<Response [200]>
"""
session = sessions.Session()
return session.request(method=method, url=url, **kwargs)
```
It creates a temporary session but does not call `session.close()` when the session goes out of scope. Is this correct and intended? Will this leak resources as the adapters associated with the session are not closed? Could you clarify if this is correct?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2243/reactions"
} | https://api.github.com/repos/psf/requests/issues/2243/timeline | null | completed | null | null | false | [
"This is correct.\n\n`session.close()` is not mandatory. The only resource that needs to be worried about are sockets, and sockets that are leaked are closed by the Python garbage collector. There is no need to explicitly clear a `session`.\n"
] |
https://api.github.com/repos/psf/requests/issues/2242 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2242/labels{/name} | https://api.github.com/repos/psf/requests/issues/2242/comments | https://api.github.com/repos/psf/requests/issues/2242/events | https://github.com/psf/requests/issues/2242 | 43,510,896 | MDU6SXNzdWU0MzUxMDg5Ng== | 2,242 | HTTPS Session Resume!! | {
"avatar_url": "https://avatars.githubusercontent.com/u/218767?v=4",
"events_url": "https://api.github.com/users/xnulinu/events{/privacy}",
"followers_url": "https://api.github.com/users/xnulinu/followers",
"following_url": "https://api.github.com/users/xnulinu/following{/other_user}",
"gists_url": "https://api.github.com/users/xnulinu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xnulinu",
"id": 218767,
"login": "xnulinu",
"node_id": "MDQ6VXNlcjIxODc2Nw==",
"organizations_url": "https://api.github.com/users/xnulinu/orgs",
"received_events_url": "https://api.github.com/users/xnulinu/received_events",
"repos_url": "https://api.github.com/users/xnulinu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xnulinu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xnulinu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xnulinu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-09-22T16:18:45Z | 2021-09-08T23:05:00Z | 2014-09-22T16:46:36Z | NONE | resolved | This question might not be on the right project. It seems to me that the request library during HTTPS communication does not do SSL Resume. It would be nice to have SSL resume feature for optimization. May be I should ask this question to urllib3 forum?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2242/reactions"
} | https://api.github.com/repos/psf/requests/issues/2242/timeline | null | completed | null | null | false | [
"I'd love this feature, it'd be awesome. Unfortunately, we're not in a place to do it at the moment.\n\nThe standard library has an [open feature request](http://bugs.python.org/issue8106) to add support for session resumption. No-one has yet done the work here, so the standard library won't support it. PyOpenSSL a... |
https://api.github.com/repos/psf/requests/issues/2241 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2241/labels{/name} | https://api.github.com/repos/psf/requests/issues/2241/comments | https://api.github.com/repos/psf/requests/issues/2241/events | https://github.com/psf/requests/pull/2241 | 43,509,530 | MDExOlB1bGxSZXF1ZXN0MjE1OTAxNTg= | 2,241 | raise RuntimeError when a single streamed request calls *iter methods th... | {
"avatar_url": "https://avatars.githubusercontent.com/u/1518884?v=4",
"events_url": "https://api.github.com/users/tijko/events{/privacy}",
"followers_url": "https://api.github.com/users/tijko/followers",
"following_url": "https://api.github.com/users/tijko/following{/other_user}",
"gists_url": "https://api.github.com/users/tijko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tijko",
"id": 1518884,
"login": "tijko",
"node_id": "MDQ6VXNlcjE1MTg4ODQ=",
"organizations_url": "https://api.github.com/users/tijko/orgs",
"received_events_url": "https://api.github.com/users/tijko/received_events",
"repos_url": "https://api.github.com/users/tijko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tijko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tijko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tijko",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-09-22T16:10:24Z | 2021-09-08T10:01:09Z | 2014-10-05T16:48:40Z | CONTRIBUTOR | resolved | In response to issue #2240, add a check to see if the content was "consumed"
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2241/reactions"
} | https://api.github.com/repos/psf/requests/issues/2241/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2241.diff",
"html_url": "https://github.com/psf/requests/pull/2241",
"merged_at": "2014-10-05T16:48:40Z",
"patch_url": "https://github.com/psf/requests/pull/2241.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2241"
} | true | [
"Let's have a subclass of `RequestException`. My proposed name is `BodyConsumedError`: @sigmavirus24, do you have a better one?\n",
"EOFError?\n",
"I think `BodyConsumedError` is preferable to `EOFError` and `StreamConsumedError` might be even more obvious in this case.\n",
"Thoughts on making whichever error... |
https://api.github.com/repos/psf/requests/issues/2240 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2240/labels{/name} | https://api.github.com/repos/psf/requests/issues/2240/comments | https://api.github.com/repos/psf/requests/issues/2240/events | https://github.com/psf/requests/issues/2240 | 43,416,436 | MDU6SXNzdWU0MzQxNjQzNg== | 2,240 | Multiple calls to iter* fail with unhelpful error. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-09-22T06:41:32Z | 2021-09-08T23:08:05Z | 2014-09-22T16:36:53Z | MEMBER | resolved | If you call the `iter*` methods more than once for a single streamed request, it fails with an extremely unhelpful error:
``` python
>>> r = requests.get('http://www.google.com/', stream=True)
>>> [x for x in r.iter_content(1024)]
>>> [x for x in r.iter_content(1024)]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/site-packages/requests/utils.py", line 341, in iter_slices
while pos < len(string):
TypeError: object of type 'bool' has no len()
```
I think it's fine that you can't call the iter\* methods twice on a streamed response, but we can easily catch this situation so we should.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2240/reactions"
} | https://api.github.com/repos/psf/requests/issues/2240/timeline | null | completed | null | null | false | [
"I'm making a pull request with a `RuntimeError` being raised. What kind of exception would you ideally like to throw here? \n",
"I'm going to close this to centralise on #2241.\n"
] |
https://api.github.com/repos/psf/requests/issues/2239 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2239/labels{/name} | https://api.github.com/repos/psf/requests/issues/2239/comments | https://api.github.com/repos/psf/requests/issues/2239/events | https://github.com/psf/requests/issues/2239 | 43,320,398 | MDU6SXNzdWU0MzMyMDM5OA== | 2,239 | ssl and multiple subdomains | {
"avatar_url": "https://avatars.githubusercontent.com/u/128454?v=4",
"events_url": "https://api.github.com/users/seanjensengrey/events{/privacy}",
"followers_url": "https://api.github.com/users/seanjensengrey/followers",
"following_url": "https://api.github.com/users/seanjensengrey/following{/other_user}",
"gists_url": "https://api.github.com/users/seanjensengrey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/seanjensengrey",
"id": 128454,
"login": "seanjensengrey",
"node_id": "MDQ6VXNlcjEyODQ1NA==",
"organizations_url": "https://api.github.com/users/seanjensengrey/orgs",
"received_events_url": "https://api.github.com/users/seanjensengrey/received_events",
"repos_url": "https://api.github.com/users/seanjensengrey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/seanjensengrey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/seanjensengrey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/seanjensengrey",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-09-20T21:38:55Z | 2021-09-08T23:07:10Z | 2014-09-20T22:16:29Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2239/reactions"
} | https://api.github.com/repos/psf/requests/issues/2239/timeline | null | completed | null | null | false | [
"When I attempt to retrieve a url like, https://ia700306.us.archive.org/11/items/MITclassical_mech/\n\n```\nrequests.get(\"https://ia700306.us.archive.org/11/items/MITclassical_mech/\")\n```\n\nI am getting an exception\n\n```\nlib/python2.7/site-packages/requests/adapters.pyc in send(self, request, stream, timeout... | |
https://api.github.com/repos/psf/requests/issues/2238 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2238/labels{/name} | https://api.github.com/repos/psf/requests/issues/2238/comments | https://api.github.com/repos/psf/requests/issues/2238/events | https://github.com/psf/requests/pull/2238 | 43,319,264 | MDExOlB1bGxSZXF1ZXN0MjE1NDE0NjE= | 2,238 | Support bytestring URLs on Python 3.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/1097349?v=4",
"events_url": "https://api.github.com/users/joealcorn/events{/privacy}",
"followers_url": "https://api.github.com/users/joealcorn/followers",
"following_url": "https://api.github.com/users/joealcorn/following{/other_user}",
"gists_url": "https://api.github.com/users/joealcorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joealcorn",
"id": 1097349,
"login": "joealcorn",
"node_id": "MDQ6VXNlcjEwOTczNDk=",
"organizations_url": "https://api.github.com/users/joealcorn/orgs",
"received_events_url": "https://api.github.com/users/joealcorn/received_events",
"repos_url": "https://api.github.com/users/joealcorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joealcorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joealcorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joealcorn",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 6 | 2014-09-20T20:47:05Z | 2021-09-08T10:01:10Z | 2014-10-02T16:20:05Z | CONTRIBUTOR | resolved | Hi there folks.
Currently `prepare_url` will call `unicode` or `str` on the url arg depending on the python version. This works fine for most cases, but the one case it trips up on is bytestrings on python 3.x as the string representation of these is `"b'http://httpbin.org'"`. Eventually this will surface as an `InvalidSchema` exception.
I find this to be completely unexpected, and I'd imagine it's not something that's been done intentionally.
Technically this a breaking change. The possibility of passing non-strings to `prepare_url` is undocumented and untested, but regardless it may be better to go about fixing this in a different way, that's your call.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2238/reactions"
} | https://api.github.com/repos/psf/requests/issues/2238/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2238.diff",
"html_url": "https://github.com/psf/requests/pull/2238",
"merged_at": "2014-10-02T16:20:05Z",
"patch_url": "https://github.com/psf/requests/pull/2238.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2238"
} | true | [
"Thanks for this!\n\nI think we like the ability to pass non-strings to `prepare_url`. It allows people to use custom url-building classes without running into trouble. It's worth noting that you change also breaks Python 2 behaviour: previously a Python 2 `str` would get lifted to a Python 2 `unicode`, which it no... |
https://api.github.com/repos/psf/requests/issues/2237 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2237/labels{/name} | https://api.github.com/repos/psf/requests/issues/2237/comments | https://api.github.com/repos/psf/requests/issues/2237/events | https://github.com/psf/requests/pull/2237 | 43,318,390 | MDExOlB1bGxSZXF1ZXN0MjE1NDEwNjM= | 2,237 | Remove invoke from requirements.txt, docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/1097349?v=4",
"events_url": "https://api.github.com/users/joealcorn/events{/privacy}",
"followers_url": "https://api.github.com/users/joealcorn/followers",
"following_url": "https://api.github.com/users/joealcorn/following{/other_user}",
"gists_url": "https://api.github.com/users/joealcorn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joealcorn",
"id": 1097349,
"login": "joealcorn",
"node_id": "MDQ6VXNlcjEwOTczNDk=",
"organizations_url": "https://api.github.com/users/joealcorn/orgs",
"received_events_url": "https://api.github.com/users/joealcorn/received_events",
"repos_url": "https://api.github.com/users/joealcorn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joealcorn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joealcorn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joealcorn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-09-20T20:02:07Z | 2021-09-08T10:01:15Z | 2014-09-20T22:12:38Z | CONTRIBUTOR | resolved | Invoke seems to be an old, unneeded dependency
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2237/reactions"
} | https://api.github.com/repos/psf/requests/issues/2237/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2237.diff",
"html_url": "https://github.com/psf/requests/pull/2237",
"merged_at": "2014-09-20T22:12:38Z",
"patch_url": "https://github.com/psf/requests/pull/2237.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2237"
} | true | [
"You appear to be correct. Thanks for this! :cake: \n",
":cake: Thanks @buttscicles \n"
] |
https://api.github.com/repos/psf/requests/issues/2236 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2236/labels{/name} | https://api.github.com/repos/psf/requests/issues/2236/comments | https://api.github.com/repos/psf/requests/issues/2236/events | https://github.com/psf/requests/issues/2236 | 43,233,966 | MDU6SXNzdWU0MzIzMzk2Ng== | 2,236 | Would it make sense to merge responses into requests ? | {
"avatar_url": "https://avatars.githubusercontent.com/u/25111?v=4",
"events_url": "https://api.github.com/users/cournape/events{/privacy}",
"followers_url": "https://api.github.com/users/cournape/followers",
"following_url": "https://api.github.com/users/cournape/following{/other_user}",
"gists_url": "https://api.github.com/users/cournape/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cournape",
"id": 25111,
"login": "cournape",
"node_id": "MDQ6VXNlcjI1MTEx",
"organizations_url": "https://api.github.com/users/cournape/orgs",
"received_events_url": "https://api.github.com/users/cournape/received_events",
"repos_url": "https://api.github.com/users/cournape/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cournape/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cournape/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cournape",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-09-19T12:43:28Z | 2021-09-08T23:08:05Z | 2014-09-19T12:52:30Z | NONE | resolved | Hi,
requests is great, but testing code using it is a bit difficult without scaffolding. The [responses project](https://github.com/dropbox/responses) is fairly neat, but since it needs to access internals of requests, wouldn't it make sense to include the feature in requests ?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2236/reactions"
} | https://api.github.com/repos/psf/requests/issues/2236/timeline | null | completed | null | null | false | [
"## No. There are plenty of libraries that access our internals. Most (if not all) do not belong in requests core.\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"As @sigmavirus24 says, lots and lots of projects hook into requests and we very definitely don't want to include them in r... |
https://api.github.com/repos/psf/requests/issues/2235 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2235/labels{/name} | https://api.github.com/repos/psf/requests/issues/2235/comments | https://api.github.com/repos/psf/requests/issues/2235/events | https://github.com/psf/requests/issues/2235 | 43,205,423 | MDU6SXNzdWU0MzIwNTQyMw== | 2,235 | chunk size error for unicode content | {
"avatar_url": "https://avatars.githubusercontent.com/u/32542?v=4",
"events_url": "https://api.github.com/users/ilovenwd/events{/privacy}",
"followers_url": "https://api.github.com/users/ilovenwd/followers",
"following_url": "https://api.github.com/users/ilovenwd/following{/other_user}",
"gists_url": "https://api.github.com/users/ilovenwd/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ilovenwd",
"id": 32542,
"login": "ilovenwd",
"node_id": "MDQ6VXNlcjMyNTQy",
"organizations_url": "https://api.github.com/users/ilovenwd/orgs",
"received_events_url": "https://api.github.com/users/ilovenwd/received_events",
"repos_url": "https://api.github.com/users/ilovenwd/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ilovenwd/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ilovenwd/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ilovenwd",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "eb6420",
"default": false,
"description": null,
"id": 44501... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 6 | 2014-09-19T05:27:53Z | 2014-10-10T16:46:04Z | null | NONE | null | I found this code in requests/adapters.py (latest version installed by pip):
https://github.com/kennethreitz/requests/blob/master/requests/adapters.py#L383
``` python
for i in request.body:
low_conn.send(hex(len(i))[2:].encode('utf-8'))
```
if `i` is a unicode, the low_conn send utf8 encoding byte string, but the chunk size is wrong.
I think it should change to:
``` python
if isinstance(i, unicode):
i = i.encode('utf8')
low_conn.send(hex(len(i))[2:].encode('utf-8'))
```
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2235/reactions"
} | https://api.github.com/repos/psf/requests/issues/2235/timeline | null | null | null | null | false | [
"Thanks for raising this!\n\nI don't think we should do that, however. If you've passed us a unicode string we should not be guessing at what text encoding you want to use in the body. I think I'd be happier not accepting unicode at all in this case, rather than guessing that 'UTF-8' is what is meant.\n\nThis is a ... |
https://api.github.com/repos/psf/requests/issues/2234 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2234/labels{/name} | https://api.github.com/repos/psf/requests/issues/2234/comments | https://api.github.com/repos/psf/requests/issues/2234/events | https://github.com/psf/requests/issues/2234 | 43,193,961 | MDU6SXNzdWU0MzE5Mzk2MQ== | 2,234 | when setting the Accept-Encoding header to None, it is still sent as 'identity' | {
"avatar_url": "https://avatars.githubusercontent.com/u/643587?v=4",
"events_url": "https://api.github.com/users/vdanen/events{/privacy}",
"followers_url": "https://api.github.com/users/vdanen/followers",
"following_url": "https://api.github.com/users/vdanen/following{/other_user}",
"gists_url": "https://api.github.com/users/vdanen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vdanen",
"id": 643587,
"login": "vdanen",
"node_id": "MDQ6VXNlcjY0MzU4Nw==",
"organizations_url": "https://api.github.com/users/vdanen/orgs",
"received_events_url": "https://api.github.com/users/vdanen/received_events",
"repos_url": "https://api.github.com/users/vdanen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vdanen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vdanen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vdanen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-09-19T00:40:01Z | 2017-10-24T17:19:40Z | 2014-09-19T13:26:24Z | NONE | null | I am passing these headers to request:
headers = {'Content-Type': 'application/something+xml',
'Accept': 'application/something+xml',
'Host': host,
'Expect': '100-continue',
'Connection': None,
'Accept-Encoding': None}
and then using:
r = requests.put(my_url, data=strata_xml, headers=headers, auth=(user, pwd), verify=False)
the REST service on the other end does not like this header at all. Using nc, I see it sending:
PUT /myurl HTTP/1.1
Accept-Encoding: identity
Content-Length: 1200
Accept: application/something+xml
User-Agent: python-requests/2.4.1 CPython/2.7.8 Darwin/13.3.0
Host: localhost
Expect: 100-continue
Content-Type: application/something+xml
I believe that https://hg.python.org/cpython/file/d047928ae3f6/Lib/http/client.py#l1086 may offer some clue there as to why this header is not being deleted when I set it to None, but I don't know how to work-around that.
Thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/643587?v=4",
"events_url": "https://api.github.com/users/vdanen/events{/privacy}",
"followers_url": "https://api.github.com/users/vdanen/followers",
"following_url": "https://api.github.com/users/vdanen/following{/other_user}",
"gists_url": "https://api.github.com/users/vdanen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vdanen",
"id": 643587,
"login": "vdanen",
"node_id": "MDQ6VXNlcjY0MzU4Nw==",
"organizations_url": "https://api.github.com/users/vdanen/orgs",
"received_events_url": "https://api.github.com/users/vdanen/received_events",
"repos_url": "https://api.github.com/users/vdanen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vdanen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vdanen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vdanen",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2234/reactions"
} | https://api.github.com/repos/psf/requests/issues/2234/timeline | null | completed | null | null | false | [
"Essentially http.client adds \"Accept-Encoding: identity\" if there is no \"Accept-Encoding\" header present in the prepared request and this skip_accept_encoding option is not set (to clarify further)\n",
"@vdanen we remove `None` before passing the headers on to `urllib3`. `urllib3` does not do the same proces... |
https://api.github.com/repos/psf/requests/issues/2233 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2233/labels{/name} | https://api.github.com/repos/psf/requests/issues/2233/comments | https://api.github.com/repos/psf/requests/issues/2233/events | https://github.com/psf/requests/issues/2233 | 43,191,940 | MDU6SXNzdWU0MzE5MTk0MA== | 2,233 | Refactoring exception hierarchy | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "eb6420",
"default": false,
"descrip... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 5 | 2014-09-19T00:00:11Z | 2016-01-26T10:17:01Z | null | CONTRIBUTOR | null | This was mentioned in #2230 as a project for requests 3.0, but it probably should get its own thread.
I wrote a lot of words about what I'd like exception hierarchy to look like, here:
https://gist.github.com/kevinburke/b98e053a4bf9835c67bb
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2233/reactions"
} | https://api.github.com/repos/psf/requests/issues/2233/timeline | null | null | null | null | false | [
"I am in principle a strong +1 on this work. It's most definitely a breaking change, however.\n",
"I'm starting to collect issues and features for a potential 3.0 release.\n",
"Since it seems like a 3.0 release is drawing closer I'm just raising awareness to this issue which seems rather interesting. \n",
"Th... |
https://api.github.com/repos/psf/requests/issues/2232 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2232/labels{/name} | https://api.github.com/repos/psf/requests/issues/2232/comments | https://api.github.com/repos/psf/requests/issues/2232/events | https://github.com/psf/requests/issues/2232 | 43,125,798 | MDU6SXNzdWU0MzEyNTc5OA== | 2,232 | Content returned still encoded | {
"avatar_url": "https://avatars.githubusercontent.com/u/8092009?v=4",
"events_url": "https://api.github.com/users/mryan82/events{/privacy}",
"followers_url": "https://api.github.com/users/mryan82/followers",
"following_url": "https://api.github.com/users/mryan82/following{/other_user}",
"gists_url": "https://api.github.com/users/mryan82/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mryan82",
"id": 8092009,
"login": "mryan82",
"node_id": "MDQ6VXNlcjgwOTIwMDk=",
"organizations_url": "https://api.github.com/users/mryan82/orgs",
"received_events_url": "https://api.github.com/users/mryan82/received_events",
"repos_url": "https://api.github.com/users/mryan82/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mryan82/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mryan82/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mryan82",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-09-18T12:14:53Z | 2021-09-08T23:08:06Z | 2014-09-18T12:26:59Z | NONE | resolved | When I try the following, the content returned in the response is still encoded. Is this an issue with the requests module?
result = requests.get('http://aceabio.com')
result.content:
'\xff\xfe<\x00!\x00D\x00O\x00C\x00T\x00Y\x00P\x00E\x00 \x00h\x00t\x00m\x00l\x00 \xx......./\x00h\x00t\x00m\x00l\x00>\x00'
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2232/reactions"
} | https://api.github.com/repos/psf/requests/issues/2232/timeline | null | completed | null | null | false | [
"`result.content` is always a bytestring, it does not decode the text from whatever text encoding it uses.\n\nThe server has not set a text encoding in the headers, so you have three options:\n1. Set the encoding yourself. I can see that it's UTF-16, so use that:\n \n ``` python\n result.encoding = 'utf-16'\n... |
https://api.github.com/repos/psf/requests/issues/2231 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2231/labels{/name} | https://api.github.com/repos/psf/requests/issues/2231/comments | https://api.github.com/repos/psf/requests/issues/2231/events | https://github.com/psf/requests/issues/2231 | 43,116,545 | MDU6SXNzdWU0MzExNjU0NQ== | 2,231 | Endless loop in sessions.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/8166442?v=4",
"events_url": "https://api.github.com/users/fcosantos/events{/privacy}",
"followers_url": "https://api.github.com/users/fcosantos/followers",
"following_url": "https://api.github.com/users/fcosantos/following{/other_user}",
"gists_url": "https://api.github.com/users/fcosantos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fcosantos",
"id": 8166442,
"login": "fcosantos",
"node_id": "MDQ6VXNlcjgxNjY0NDI=",
"organizations_url": "https://api.github.com/users/fcosantos/orgs",
"received_events_url": "https://api.github.com/users/fcosantos/received_events",
"repos_url": "https://api.github.com/users/fcosantos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fcosantos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fcosantos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fcosantos",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-09-18T10:08:51Z | 2021-09-08T23:08:02Z | 2014-09-25T02:57:38Z | NONE | resolved | > (gdb) py-list
> 544 # Guard against that specific failure case.
> 545 if not isinstance(request, PreparedRequest):
> 546 raise ValueError('You can only send PreparedRequests.')
> 547
> 548 while request.url in self.redirect_cache:
> -549 request.url = self.redirect_cache.get(request.url)
> 550
> 551 # Set up variables needed for resolve_redirects and dispatching of hooks
> 552 allow_redirects = kwargs.pop('allow_redirects', True)
> 553 stream = kwargs.get('stream')
> 554 timeout = kwargs.get('timeout')
redirect_cache dict could have complementary key/values that forces and enless loop.
> (gdb) py-down
> # 2 Frame 0x7f645c00acd0, for file /test/libs/requests/sessions.py, line 549, in send (self=<Session(cookies=<RequestsCookieJar(_now=1410944130, _policy=<DefaultCookiePolicy(strict_rfc2965_unverifiable=True, strict_ns_domain=0, _allowed_domains=None, rfc2109_as_netscape=None, rfc2965=False, strict_domain=False, _now=1410944130, strict_ns_set_path=False, strict_ns_unverifiable=False, strict_ns_set_initial_dollar=False, hide_cookie2=False, _blocked_domains=(), netscape=True) at remote 0x7f651070c4d0>, _cookies={}, _cookies_lock=<_RLock(_Verbose__verbose=False, _RLock__owner=None, _RLock__block=<thread.lock at remote 0x7f6530772dd0>, _RLock__count=0) at remote 0x7f65105a5450>) at remote 0x7f65105a5e10>, stream=False, hooks={'response': []}, redirect_cache={'http://www.hent aiwe blog.com/': 'http://hent aiwe blog.com/', 'http://hent aiwe blog.com/': 'http://www.hent aiwe blog.com/'}, auth=None, trust_env=True, headers=<CaseInsensitiveDict(_store={'accept-encoding': ('Accept-Encoding', 'gzip, deflate'), 'accep...(truncated)
>
> ```
> request.url = self.redirect_cache.get(request.url)
> ```
Current request chain with wget:
> $ wget www.hent aiwe blog.com
> --2014-09-18 11:52:20-- http://www.hent aiwe blog.com/
> Resolving www.hent aiwe blog.com (www.hent aiwe blog.com)... 109.72.81.172
> Connecting to www.hent aiwe blog.com (www.hent aiwe blog.com)|109.72.81.172|:80... connected.
> HTTP request sent, awaiting response... 301 Moved Permanently
> Location: http://hent aiwe blog.com/ [following]
> --2014-09-18 11:52:20-- http://hent aiwe blog.com/
> Resolving hent aiwe blog.com (hent aiwe blog.com)... 109.72.81.172
> Reusing existing connection to www.hent aiwe blog.com:80.
> HTTP request sent, awaiting response... 301 Moved Permanently
> Location: http://www.hent aiwe blog.com/ [following]
> --2014-09-18 11:52:20-- http://www.hent aiwe blog.com/
> Reusing existing connection to www.hent aiwe blog.com:80.
> HTTP request sent, awaiting response... 301 Moved Permanently
> Location: http://hent aiwe blog.com/ [following]
> ...
Suggested resolution:
> ```
> redirect_count = 0
> while request.url in self.redirect_cache:
> redirect_count += 1
> if redirect_count > self.max_redirects:
> raise TooManyRedirects
> request.url = self.redirect_cache.get(request.url)
> ```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2231/reactions"
} | https://api.github.com/repos/psf/requests/issues/2231/timeline | null | completed | null | null | false | [
"Please search for issues before raising new ones. This was raised in #2207 and fixed in #2210: the fix is already in `master`.\n",
"I apologise, we didn't quite fix this. We actually have a separate bug, in that we can have a redirect loop of size greater than 1. \n\nIdeally we ought to be able to spot redirect ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.