Instruction stringclasses 1 value | Input stringlengths 79 33k | Response stringlengths 106 9.29k | __index_level_0__ int64 0 2.83k |
|---|---|---|---|
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_with_ext.
" Special treatment for extensions
" If the program name exceeds 30 characters it is not a usual ABAP program but might be
" some extension, which requires the internal addition EXTENSION TYPE
" https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm?file=abapinsert_report_internal.htm
" This e.g. occurs in case of transportable Code Inspector variants (ending with ===VC)
INSERT REPORT is_progdir-name
FROM it_source
STATE 'I'
EXTENSION TYPE is_progdir-name+30
PROGRAM TYPE is_progdir-subc.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from INSERT REPORT .. EXTENSION TYPE' ).
ENDIF.
CALL FUNCTION 'UPDATE_PROGDIR'
EXPORTING
i_progdir = is_progdir
i_progname = is_progdir-name
i_state = 'I'
EXCEPTIONS
not_executed = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error updating program directory' ).
ENDIF.
zcl_abapgit_objects_activation=>add(
iv_type = 'REPS'
iv_name = is_progdir-name ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT is_progdir-name * <-- There is a problem here
FROM it_source
STATE 'I'
```
Explanation: Potential dangerous statement INSERT REPORT. | 1,803 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete_extras.
DELETE FROM tddat WHERE tabname = iv_tabname.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
METHOD delete_extras.
DELETE FROM tddat WHERE tabname = iv_tabname. * <-- There is a problem here
ENDMETHOD.
```
Explanation: Modify only own DB tables. | 1,805 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete_extra.
DELETE FROM tddat WHERE tabname = iv_tabname.
DELETE FROM tvdir WHERE tabname = iv_tabname.
DELETE FROM tvimf WHERE tabname = iv_tabname.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM tddat WHERE tabname = iv_tabname. * <-- There is a problem here
DELETE FROM tvdir WHERE tabname = iv_tabname.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM tvdir WHERE tabname = iv_tabname.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM tvimf WHERE tabname = iv_tabname.
```
Explanation: Modify only own DB tables. | 1,807 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ZCL_ABAPGIT_OBJECT_TOBJ IMPLEMENTATION.
METHOD delete_extra.
DELETE FROM tddat WHERE tabname = iv_tabname.
DELETE FROM tvdir WHERE tabname = iv_tabname.
DELETE FROM tvimf WHERE tabname = iv_tabname.
ENDMETHOD.
METHOD read_extra.
SELECT SINGLE * FROM tddat INTO rs_tobj-tddat WHERE tabname = iv_tabname.
SELECT SINGLE * FROM tvdir INTO rs_tobj-tvdir WHERE tabname = iv_tabname.
CLEAR: rs_tobj-tvdir-gendate, rs_tobj-tvdir-gentime, rs_tobj-tvdir-devclass.
SELECT * FROM tvimf INTO TABLE rs_tobj-tvimf WHERE tabname = iv_tabname
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD update_extra.
DATA: lt_current_tvimf TYPE STANDARD TABLE OF tvimf.
FIELD-SYMBOLS: <ls_tvimf> TYPE tvimf.
MODIFY tddat FROM is_tobj-tddat.
MODIFY tvdir FROM is_tobj-tvdir.
SELECT * INTO TABLE lt_current_tvimf
FROM tvimf
WHERE tabname = is_tobj-tddat-tabname
ORDER BY PRIMARY KEY.
LOOP AT lt_current_tvimf ASSIGNING <ls_tvimf>.
READ TABLE is_tobj-tvimf WITH KEY tabname = <ls_tvimf>-tabname
event = <ls_tvimf>-event
TRANSPORTING NO FIELDS.
IF sy-subrc <> 0.
DELETE FROM tvimf
WHERE tabname = <ls_tvimf>-tabname
AND event = <ls_tvimf>-event.
ENDIF.
ENDLOOP.
MODIFY tvimf FROM TABLE is_tobj-tvimf.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
DATA: lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE luser FROM objh INTO rv_user
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
IF sy-subrc <> 0.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_objh TYPE objh,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'D'
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from OBJ_GENERATE' ).
ENDIF.
delete_extra( ls_objh-objectname ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj.
io_xml->read( EXPORTING iv_name = 'OBJH'
CHANGING cg_data = ls_objh ).
io_xml->read( EXPORTING iv_name = 'OBJT'
CHANGING cg_data = ls_objt ).
io_xml->read( EXPORTING iv_name = 'OBJS'
CHANGING cg_data = lt_objs ).
io_xml->read( EXPORTING iv_name = 'OBJSL'
CHANGING cg_data = lt_objsl ).
io_xml->read( EXPORTING iv_name = 'OBJM'
CHANGING cg_data = lt_objm ).
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'I'
iv_objecttext = ls_objt-ddtext
iv_objcateg = ls_objh-objcateg
iv_objtransp = ls_objh-objtransp
iv_devclass = iv_package
TABLES
tt_v_obj_s = lt_objs
tt_objm = lt_objm
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
* TOBJ has to be saved/generated after the DDIC tables have been
* activated - fixed with late deserialization
zcx_abapgit_exception=>raise( 'error from OBJ_GENERATE' ).
ENDIF.
CALL FUNCTION 'OBJ_SET_IMPORTABLE'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_importable = ls_objh-importable
EXCEPTIONS
object_not_defined = 1
invalid = 2
transport_error = 3
object_enqueue_failed = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from OBJ_SET_IMPORTABLE' ).
ENDIF.
* fm OBJ_GENERATE takes the defaults from the DDIC object
* set OBJTRANSP directly, should be okay looking at the code in OBJ_SET_IMPORTABLE
* locking has been done in OBJ_SET_IMPORTABLE plus recording of transport
UPDATE objh SET objtransp = ls_objh-objtransp
WHERE objectname = ls_objh-objectname
AND objecttype = ls_objh-objecttype.
io_xml->read( EXPORTING iv_name = 'TOBJ'
CHANGING cg_data = ls_tobj ).
ls_tobj-tvdir-gendate = sy-datum.
ls_tobj-tvdir-gentime = sy-uzeit.
ls_tobj-tvdir-devclass = iv_package.
update_extra( ls_tobj ).
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_objectname TYPE objh-objectname,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE objectname FROM objh INTO lv_objectname
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-late TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
rs_metadata-delete_tadir = abap_true.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lv_object_name TYPE e071-obj_name.
lv_object_name = ms_item-obj_name.
CALL FUNCTION 'TR_OBJECT_JUMP_TO_TOOL'
EXPORTING
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = lv_object_name
EXCEPTIONS
jump_not_possible = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Jump not possible. Subrc={ sy-subrc } from TR_OBJECT_JUMP_TO_TOOL| ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
CALL FUNCTION 'CTO_OBJECT_GET'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_language = mv_language
iv_sel_objt = abap_true
iv_sel_objs = abap_true
iv_sel_objsl = abap_true
iv_sel_objm = abap_true
IMPORTING
es_objh = ls_objh
es_objt = ls_objt
TABLES
tt_objs = lt_objs
tt_objsl = lt_objsl
tt_objm = lt_objm
EXCEPTIONS
object_not_defined = 1
OTHERS = 2.
IF sy-subrc = 1.
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR: ls_objh-luser,
ls_objh-ldate.
io_xml->add( iv_name = 'OBJH'
ig_data = ls_objh ).
io_xml->add( iv_name = 'OBJT'
ig_data = ls_objt ).
io_xml->add( iv_name = 'OBJS'
ig_data = lt_objs ).
io_xml->add( iv_name = 'OBJSL'
ig_data = lt_objsl ).
io_xml->add( iv_name = 'OBJM'
ig_data = lt_objm ).
ls_tobj = read_extra( ls_objh-objectname ).
io_xml->add( iv_name = 'TOBJ'
ig_data = ls_tobj ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
UPDATE objh SET objtransp = ls_objh-objtransp
```
Explanation: Modify only own DB tables. | 1,810 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD _confirm_messages.
" Temporarily suppress certain messages that are not relevant for installation
CONSTANTS lc_toolflag_set TYPE funcname VALUE 'SCWG_TOOLFLAG_SET'.
TYPES:
BEGIN OF ty_message,
id TYPE symsgid,
ty TYPE symsgty,
no TYPE symsgno,
v1 TYPE symsgv,
v2 TYPE symsgv,
v3 TYPE symsgv,
v4 TYPE symsgv,
END OF ty_message.
DATA:
ls_msg TYPE ty_message,
ls_clmcus TYPE clmcus.
FIELD-SYMBOLS <lt_msg> TYPE STANDARD TABLE.
" Auto-confirm certain messages (requires SAP Note 1609940)
PERFORM dummy IN PROGRAM saplstrd IF FOUND. "load function group STRD
ASSIGN ('(SAPLSTRD)GT_CONFIRMED_MESSAGES') TO <lt_msg>.
IF sy-subrc = 0.
" Object can only be created in package of namespace
ls_msg-id = 'TR'.
ls_msg-no = '007'.
COLLECT ls_msg INTO <lt_msg>.
" Original system set to "SAP"
ls_msg-id = 'TR'.
ls_msg-no = '013'.
COLLECT ls_msg INTO <lt_msg>.
" Make repairs in foreign namespaces only if they are urgent
ls_msg-id = 'TR'.
ls_msg-no = '852'.
COLLECT ls_msg INTO <lt_msg>.
" Make repairs in foreign namespaces only if they are urgent
ls_msg-id = 'TK'.
ls_msg-no = '016'.
COLLECT ls_msg INTO <lt_msg>.
ENDIF.
" Set tool flag to avoid messages
CALL FUNCTION 'FUNCTION_EXISTS'
EXPORTING
funcname = lc_toolflag_set
EXCEPTIONS
function_not_exist = 1
OTHERS = 2.
IF sy-subrc = 0.
CALL FUNCTION lc_toolflag_set.
ENDIF.
" Confirm message about modification mode (DT, CLM_INFORMATION)
" and backup old state (see _restore_messages)
SELECT * FROM clmcus INTO TABLE gt_clmcus WHERE username = sy-uname ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-username = sy-uname.
ls_clmcus-obj_type = 'CLAS'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-obj_type = 'INTF'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-obj_type = 'METH'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ls_clmcus-obj_type = 'CLAS'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables.
```abap
ls_clmcus-obj_type = 'INTF'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables.
```abap
ls_clmcus-obj_type = 'METH'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables. | 1,814 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD _restore_messages.
DELETE FROM clmcus WHERE username = sy-uname ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
INSERT clmcus FROM TABLE gt_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM clmcus WHERE username = sy-uname ##SUBRC_OK.
```
Explanation: Modify only own DB tables.
```abap
INSERT clmcus FROM TABLE gt_clmcus ##SUBRC_OK.
```
Explanation: Modify only own DB tables. | 1,815 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete.
_lock( iv_name = iv_name
iv_pack = iv_pack ).
DELETE FROM (mv_tabname)
WHERE name = iv_name AND pack = iv_pack.
IF sy-subrc <> 0.
zcx_abapinst_exception=>raise( 'DB delete failed' ).
ENDIF.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM (mv_tabname)
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,816 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD insert.
DATA ls_content TYPE zif_abapinst_definitions=>ty_content.
_lock( iv_name = is_inst-name
iv_pack = is_inst-pack ).
ls_content = _list_to_content( is_inst ).
INSERT (mv_tabname) FROM ls_content.
IF sy-subrc <> 0.
zcx_abapinst_exception=>raise( 'DB insert failed' ).
ENDIF.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT (mv_tabname) FROM ls_content.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,817 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD list.
DATA lt_content TYPE zif_abapinst_definitions=>ty_contents.
SELECT * FROM (mv_tabname) INTO TABLE lt_content
ORDER BY PRIMARY KEY.
IF sy-subrc = 0.
rt_list = _content_to_list( lt_content ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (mv_tabname) INTO TABLE lt_content * <-- There is a problem here
ORDER BY PRIMARY KEY.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,818 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_pack IS SUPPLIED.
SELECT * FROM (mv_tabname) INTO TABLE lt_content
WHERE name = iv_name AND pack = iv_pack
ORDER BY PRIMARY KEY.
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF iv_pack IS SUPPLIED.
SELECT * FROM (mv_tabname) INTO TABLE lt_content * <-- There is a problem here
WHERE name = iv_name AND pack = iv_pack
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,819 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD list_by_name.
DATA lt_content TYPE zif_abapinst_definitions=>ty_contents.
IF iv_pack IS SUPPLIED.
SELECT * FROM (mv_tabname) INTO TABLE lt_content
WHERE name = iv_name AND pack = iv_pack
ORDER BY PRIMARY KEY.
ELSE.
SELECT * FROM (mv_tabname) INTO TABLE lt_content
WHERE name = iv_name
ORDER BY PRIMARY KEY.
ENDIF.
IF sy-subrc = 0.
rt_list = _content_to_list( lt_content ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ELSE.
SELECT * FROM (mv_tabname) INTO TABLE lt_content * <-- There is a problem here
WHERE name = iv_name
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,820 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_name IS NOT INITIAL AND iv_pack IS NOT INITIAL.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content
WHERE name = iv_name AND pack = iv_pack.
ELSEIF iv_name IS NOT INITIAL.
``` | I found vulnerabilities in the line:
```abap
IF iv_name IS NOT INITIAL AND iv_pack IS NOT INITIAL.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content * <-- There is a problem here
WHERE name = iv_name AND pack = iv_pack.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,821 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD select.
DATA ls_content TYPE zif_abapinst_definitions=>ty_content.
IF iv_name IS NOT INITIAL AND iv_pack IS NOT INITIAL.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content
WHERE name = iv_name AND pack = iv_pack.
ELSEIF iv_name IS NOT INITIAL.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content
WHERE name = iv_name.
ELSE.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content
WHERE pack = iv_pack.
ENDIF.
IF sy-subrc = 0.
rs_inst = _content_to_inst( ls_content ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ELSEIF iv_name IS NOT INITIAL.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content * <-- There is a problem here
WHERE name = iv_name.
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
ELSE.
SELECT SINGLE * FROM (mv_tabname) INTO ls_content * <-- There is a problem here
WHERE pack = iv_pack.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,822 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD update.
DATA ls_content TYPE zif_abapinst_definitions=>ty_content.
_lock( iv_name = is_inst-name
iv_pack = is_inst-pack ).
ls_content = _list_to_content( is_inst ).
MODIFY (mv_tabname) FROM ls_content.
IF sy-subrc <> 0.
zcx_abapinst_exception=>raise( 'DB modify failed' ).
ENDIF.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY (mv_tabname) FROM ls_content.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,823 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF mt_text_new <> mt_text_old.
INSERT TEXTPOOL mv_program FROM mt_text_new LANGUAGE sy-langu.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INSERT TEXTPOOL mv_program FROM mt_text_new LANGUAGE sy-langu.
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,824 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF gv_force = abap_true OR gv_drop = abap_true.
DELETE FROM balobj WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balobjt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsub WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsubt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
ELSE.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM balobj WHERE object = /mbtools/if_definitions=>c_namespace.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM balobjt WHERE object = /mbtools/if_definitions=>c_namespace.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM balsub WHERE object = /mbtools/if_definitions=>c_namespace.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM balsubt WHERE object = /mbtools/if_definitions=>c_namespace.
```
Explanation: Modify only own DB tables. | 1,825 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD _application_log.
DATA:
ls_balobj TYPE balobj,
ls_balobjt TYPE balobjt,
ls_balsub TYPE balsub,
lt_balsub TYPE STANDARD TABLE OF balsub WITH DEFAULT KEY,
ls_balsubt TYPE balsubt,
lt_balsubt TYPE STANDARD TABLE OF balsubt WITH DEFAULT KEY.
SELECT SINGLE object FROM balobj INTO ls_balobj WHERE object = /mbtools/if_definitions=>c_namespace.
IF sy-subrc = 0.
IF gv_force = abap_true OR gv_drop = abap_true.
DELETE FROM balobj WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balobjt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsub WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsubt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
ELSE.
RETURN.
ENDIF.
ENDIF.
IF gv_drop = abap_true.
RETURN.
ENDIF.
ls_balobj-object = /mbtools/if_definitions=>c_namespace.
INSERT balobj FROM ls_balobj.
ASSERT sy-subrc >= 0.
ls_balobjt-spras = sy-langu.
ls_balobjt-object = /mbtools/if_definitions=>c_namespace.
ls_balobjt-objtxt = /mbtools/if_definitions=>c_mbt.
INSERT balobjt FROM ls_balobjt.
ASSERT sy-subrc >= 0.
ls_balsub-object = /mbtools/if_definitions=>c_namespace.
ls_balsub-subobject = 'EDD'.
APPEND ls_balsub TO lt_balsub.
ls_balsub-subobject = 'INIT'.
APPEND ls_balsub TO lt_balsub.
ls_balsub-subobject = 'LOG'.
APPEND ls_balsub TO lt_balsub.
INSERT balsub FROM TABLE lt_balsub.
ASSERT sy-subrc >= 0.
ls_balsubt-spras = sy-langu.
ls_balsubt-object = /mbtools/if_definitions=>c_namespace.
ls_balsubt-subobject = 'EDD'.
ls_balsubt-subobjtxt = 'Log for EDD API'(002).
APPEND ls_balsubt TO lt_balsubt.
ls_balsubt-subobject = 'INST'.
ls_balsubt-subobjtxt = 'Log for MBT Installer'(003).
APPEND ls_balsubt TO lt_balsubt.
ls_balsubt-subobject = 'LOG'.
ls_balsubt-subobjtxt = 'General Log'(004).
APPEND ls_balsubt TO lt_balsubt.
INSERT balsubt FROM TABLE lt_balsubt.
ASSERT sy-subrc >= 0.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT balobj FROM ls_balobj.
```
Explanation: Modify only own DB tables.
```abap
INSERT balobjt FROM ls_balobjt.
```
Explanation: Modify only own DB tables.
```abap
INSERT balsub FROM TABLE lt_balsub.
```
Explanation: Modify only own DB tables.
```abap
INSERT balsubt FROM TABLE lt_balsubt.
```
Explanation: Modify only own DB tables. | 1,826 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD sync.
" Installer persistence
CONSTANTS lc_tabname TYPE tabname VALUE 'ZMBTINST'.
DATA:
ls_inst TYPE ty_inst,
ls_cont TYPE ty_content.
ls_inst-name = io_tool->get_name( ).
ls_inst-pack = io_tool->get_package( ).
ls_inst-version = io_tool->get_version( ).
ls_inst-sem_version = /mbtools/cl_version=>convert_string_to_version( ls_inst-version ).
ls_inst-description = io_tool->get_description( ).
ls_inst-source_type = 'INTERNET'.
ls_inst-source_name = io_tool->get_url_download( ).
ls_inst-transport = ''.
ls_inst-folder_logic = 'PREFIX'.
ls_inst-installed_langu = 'E'.
ls_inst-installed_by = sy-uname.
ls_inst-installed_at = io_tool->get_last_update( abap_true ).
ls_inst-status = 'S'. "success
ls_cont = _sync_json( ls_inst ).
SELECT SINGLE * FROM (lc_tabname) INTO ls_cont WHERE name = ls_inst-name.
IF sy-subrc = 0.
UPDATE (lc_tabname) FROM ls_cont.
IF sy-subrc <> 0.
/mbtools/cx_exception=>raise( 'Error updating MBT Installer persistence'(003) ).
ENDIF.
ELSE.
INSERT (lc_tabname) FROM ls_cont.
IF sy-subrc <> 0.
/mbtools/cx_exception=>raise( 'Error inserting MBT Installer persistence'(002) ).
ENDIF.
ENDIF.
rv_result = abap_true.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE * FROM (lc_tabname) INTO ls_cont WHERE name = ls_inst-name.
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
INSERT (lc_tabname) FROM ls_cont.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,827 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF sy-subrc = 0.
UPDATE (lc_tabname) FROM ls_cont.
IF sy-subrc <> 0.
/mbtools/cx_exception=>raise( 'Error updating MBT Installer persistence'(003) ).
ENDIF.
``` | I found vulnerabilities in the line:
```abap
UPDATE (lc_tabname) FROM ls_cont.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,828 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD sync.
" Installer persistence
CONSTANTS lc_tabname TYPE tabname VALUE 'ZMBTINST'.
DATA:
ls_inst TYPE ty_inst,
ls_inst_db TYPE ty_inst,
ls_cont TYPE ty_content.
ls_inst-name = io_tool->get_name( ).
ls_inst-pack = io_tool->get_package( ).
ls_inst-version = io_tool->get_version( ).
ls_inst-sem_version = /mbtools/cl_version=>convert_string_to_version( ls_inst-version ).
ls_inst-description = io_tool->get_description( ).
ls_inst-source_type = 'INTERNET'.
ls_inst-source_name = io_tool->get_url_download( ).
ls_inst-transport = ''.
ls_inst-folder_logic = 'PREFIX'.
ls_inst-installed_langu = 'E'.
ls_inst-installed_by = sy-uname.
ls_inst-installed_at = io_tool->get_last_update( abap_true ).
ls_inst-status = 'S'. "success
ls_cont = _sync_json( ls_inst ).
SELECT SINGLE * FROM (lc_tabname) INTO CORRESPONDING FIELDS OF ls_inst_db WHERE name = ls_inst-name.
IF sy-subrc = 0.
IF ls_inst_db-pack <> ls_inst-pack.
DELETE FROM (lc_tabname) WHERE name = ls_inst-name ##SUBRC_OK.
INSERT (lc_tabname) FROM ls_cont ##SUBRC_OK.
ELSE.
UPDATE (lc_tabname) FROM ls_cont.
ENDIF.
IF sy-subrc <> 0.
/mbtools/cx_exception=>raise( 'Error updating MBT Installer persistence'(003) ).
ENDIF.
ELSE.
INSERT (lc_tabname) FROM ls_cont.
IF sy-subrc <> 0.
/mbtools/cx_exception=>raise( 'Error inserting MBT Installer persistence'(002) ).
ENDIF.
ENDIF.
COMMIT WORK.
rv_result = abap_true.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE * FROM (lc_tabname) INTO CORRESPONDING FIELDS OF ls_inst_db WHERE name = ls_inst-name.
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
INSERT (lc_tabname) FROM ls_cont.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,831 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF ls_inst_db-pack <> ls_inst-pack.
DELETE FROM (lc_tabname) WHERE name = ls_inst-name ##SUBRC_OK.
INSERT (lc_tabname) FROM ls_cont ##SUBRC_OK.
ELSE.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM (lc_tabname) WHERE name = ls_inst-name ##SUBRC_OK.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
INSERT (lc_tabname) FROM ls_cont ##SUBRC_OK.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,832 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF sy-subrc = 0.
IF ls_inst_db-pack <> ls_inst-pack.
DELETE FROM (lc_tabname) WHERE name = ls_inst-name ##SUBRC_OK.
INSERT (lc_tabname) FROM ls_cont ##SUBRC_OK.
ELSE.
UPDATE (lc_tabname) FROM ls_cont.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
UPDATE (lc_tabname) FROM ls_cont.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,833 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where) ORDER BY PRIMARY KEY.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
ASSIGN rr_data->* TO <lg_tab>.
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where) ORDER BY PRIMARY KEY. * <-- There is a problem here
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab> ORDER BY PRIMARY KEY.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,834 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab> ORDER BY PRIMARY KEY.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where) ORDER BY PRIMARY KEY.
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab> ORDER BY PRIMARY KEY. * <-- There is a problem here
ENDIF.
ENDMETHOD.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,835 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( <lg_upd> ) > 0.
UPDATE (iv_name) FROM TABLE <lg_upd>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error updating { lines( <lg_upd> ) } records into table { iv_name }| ).
ENDIF.
``` | I found vulnerabilities in the line:
```abap
UPDATE (iv_name) FROM TABLE <lg_upd>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,838 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where) ORDER BY PRIMARY KEY.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
TRY.
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where) ORDER BY PRIMARY KEY. * <-- There is a problem here
ENDLOOP.
IF lines( it_where ) = 0.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,839 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab> ORDER BY PRIMARY KEY.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab> ORDER BY PRIMARY KEY. * <-- There is a problem here
ENDIF.
CATCH cx_sy_sql_error INTO lx_sql.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,840 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
``` | I found vulnerabilities in the line:
```abap
DELETE TEXTPOOL iv_program
```
Explanation: Potential dangerous statement DELETE TEXTPOOL. | 1,841 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF it_tpool IS INITIAL.
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
FROM it_tpool "main language cannot be activated because
LANGUAGE lv_language "this woul activate the deletion of the textpool
STATE lv_state. "of the mail program -> insert empty textpool
ENDIF.
``` | I found vulnerabilities in the line:
```abap
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in * <-- There is a problem here
FROM it_tpool
LANGUAGE lv_language
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,842 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_textpool.
DATA lv_language TYPE sy-langu.
DATA lv_state TYPE c.
DATA lv_delete TYPE abap_bool.
IF iv_language IS INITIAL.
lv_language = mv_language.
ELSE.
lv_language = iv_language.
ENDIF.
IF lv_language = mv_language.
lv_state = c_state-inactive. "Textpool in main language needs to be activated
ELSE.
lv_state = c_state-active. "Translations are always active
ENDIF.
IF it_tpool IS INITIAL.
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
FROM it_tpool "main language cannot be activated because
LANGUAGE lv_language "this woul activate the deletion of the textpool
STATE lv_state. "of the mail program -> insert empty textpool
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program
FROM it_tpool
LANGUAGE lv_language
STATE lv_state.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
ENDIF.
IF lv_state = c_state-inactive. "Textpool in main language needs to be activated
zcl_abapgit_objects_activation=>add(
iv_type = 'REPT'
iv_name = iv_program
iv_delete = lv_delete ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program * <-- There is a problem here
FROM it_tpool
LANGUAGE lv_language
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,843 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_base IMPLEMENTATION.
METHOD convert_attrib_to_vseoattrib.
FIELD-SYMBOLS: <ls_attribute> LIKE LINE OF it_attributes,
<ls_vseoattrib> LIKE LINE OF rt_vseoattrib.
LOOP AT it_attributes ASSIGNING <ls_attribute>.
INSERT INITIAL LINE INTO TABLE rt_vseoattrib ASSIGNING <ls_vseoattrib>.
MOVE-CORRESPONDING <ls_attribute> TO <ls_vseoattrib>.
<ls_vseoattrib>-clsname = iv_clsname.
<ls_vseoattrib>-state = seoc_state_implemented.
<ls_vseoattrib>-exposure = <ls_attribute>-exposure.
UNASSIGN <ls_vseoattrib>.
ENDLOOP.
UNASSIGN <ls_attribute>.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~add_to_activation_list.
zcl_abapgit_objects_activation=>add_item( is_item ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_documentation.
CALL FUNCTION 'DOCU_UPD'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
no_masterlang = iv_no_masterlang
state = c_docu_state_active
TABLES
line = it_lines
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete_documentation.
CALL FUNCTION 'DOCU_DEL'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
typ = 'E'
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from DOCU_DEL' ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_interface_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_skip_test_classes.
rv_skip = mv_skip_test_classes.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_attributes.
SELECT cmpname attbusobj attkeyfld exposure
FROM seocompodf
INTO CORRESPONDING FIELDS OF TABLE rt_attributes
WHERE clsname = iv_object_name
AND ( attbusobj <> space OR attkeyfld <> space )
AND version = '1'
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions_sub.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_documentation.
DATA: lv_state TYPE dokstate,
lt_lines TYPE tlinetab.
CALL FUNCTION 'DOCU_GET'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
version_active_or_last = space " retrieve active version
IMPORTING
dokstate = lv_state
TABLES
line = lt_lines
EXCEPTIONS
no_docu_on_screen = 1
no_docu_self_def = 2
no_docu_temp = 3
ret_code = 4
OTHERS = 5.
IF sy-subrc = 0 AND lv_state = c_docu_state_active.
rt_lines = lt_lines.
ELSE.
CLEAR rt_lines.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_superclass.
SELECT SINGLE refclsname FROM vseoextend INTO rv_superclass
WHERE clsname = iv_classname.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~serialize_abap.
DATA lo_oo_serializer TYPE REF TO zcl_abapgit_oo_serializer.
CREATE OBJECT lo_oo_serializer.
CASE iv_type.
WHEN seop_ext_class_locals_def.
rt_source = lo_oo_serializer->serialize_locals_def( is_class_key ).
WHEN seop_ext_class_locals_imp.
rt_source = lo_oo_serializer->serialize_locals_imp( is_class_key ).
WHEN seop_ext_class_macros.
rt_source = lo_oo_serializer->serialize_macros( is_class_key ).
WHEN seop_ext_class_testclasses.
rt_source = lo_oo_serializer->serialize_testclasses( is_class_key ).
mv_skip_test_classes = lo_oo_serializer->are_test_classes_skipped( ).
WHEN OTHERS.
rt_source = lo_oo_serializer->serialize_abap_clif_source( is_class_key ).
ENDCASE.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions.
DATA lt_descriptions LIKE it_descriptions.
DATA lt_components TYPE seo_components.
DATA ls_description LIKE LINE OF it_descriptions.
DATA lv_lang TYPE tadir-masterlang.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
FIELD-SYMBOLS <ls_component> TYPE vseocompdf.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
" make sure to not damage VSEO* views by deleting texts of all components - an empty text must be kept!!
SELECT * FROM vseocompdf INTO TABLE lt_components
WHERE clsname = is_key-clsname
AND version <> seoc_version_deleted
AND state = seoc_state_implemented
AND alias = seox_false ORDER BY clsname cmpname version.
IF lt_components IS NOT INITIAL.
SELECT SINGLE masterlang FROM tadir INTO lv_lang
WHERE pgmid = 'R3TR' AND ( object = 'CLAS' OR object = 'INTF' )
AND obj_name = is_key-clsname. "#EC CI_GENBUFF
IF sy-subrc <> 0.
lv_lang = sy-langu.
ENDIF.
LOOP AT lt_components ASSIGNING <ls_component>.
READ TABLE lt_descriptions TRANSPORTING NO FIELDS WITH KEY
clsname = is_key-clsname
cmpname = <ls_component>-cmpname.
IF sy-subrc <> 0.
ls_description-clsname = is_key-clsname.
ls_description-cmpname = <ls_component>-cmpname.
ls_description-langu = lv_lang.
ls_description-descript = space.
APPEND ls_description TO lt_descriptions.
ENDIF.
ENDLOOP.
ENDIF.
DELETE FROM seocompotx WHERE clsname = is_key-clsname."#EC CI_SUBRC
INSERT seocompotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions_sub.
DATA lt_descriptions LIKE it_descriptions.
DATA lt_subcomponents TYPE seo_subcomponents.
DATA ls_description LIKE LINE OF it_descriptions.
DATA lv_lang TYPE tadir-masterlang.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
FIELD-SYMBOLS <ls_subcomponent> TYPE vseosubcdf.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
" make sure to not damage VSEO* views by deleting texts of all subcomponents - an empty text must be kept!!
SELECT * FROM vseosubcdf INTO TABLE lt_subcomponents
WHERE clsname = is_key-clsname
AND version <> seoc_version_deleted ORDER BY clsname cmpname sconame version.
IF lt_subcomponents IS NOT INITIAL.
SELECT SINGLE masterlang FROM tadir INTO lv_lang
WHERE pgmid = 'R3TR' AND ( object = 'CLAS' OR object = 'INTF' )
AND obj_name = is_key-clsname. "#EC CI_GENBUFF
IF sy-subrc <> 0.
lv_lang = sy-langu.
ENDIF.
LOOP AT lt_subcomponents ASSIGNING <ls_subcomponent>.
READ TABLE lt_descriptions TRANSPORTING NO FIELDS WITH KEY
clsname = is_key-clsname
cmpname = <ls_subcomponent>-cmpname
sconame = <ls_subcomponent>-sconame.
IF sy-subrc <> 0.
ls_description-clsname = is_key-clsname.
ls_description-cmpname = <ls_subcomponent>-cmpname.
ls_description-sconame = <ls_subcomponent>-sconame.
ls_description-langu = lv_lang.
ls_description-descript = space.
APPEND ls_description TO lt_descriptions.
ENDIF.
ENDLOOP.
ENDIF.
DELETE FROM seosubcotx WHERE clsname = is_key-clsname."#EC CI_SUBRC
INSERT seosubcotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM seocompotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seocompotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM seosubcotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seosubcotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables. | 1,844 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_class IMPLEMENTATION.
METHOD create_report.
zcl_abapinst_factory=>get_sap_report( )->insert_report(
iv_name = iv_program
iv_package = iv_package
it_source = it_source
iv_state = iv_state
iv_version = iv_version
iv_program_type = iv_program_type
iv_extension_type = iv_extension ).
ENDMETHOD.
METHOD delete_report.
zcl_abapinst_factory=>get_sap_report( )->delete_report( iv_program ).
ENDMETHOD.
METHOD determine_method_include.
DATA: ls_mtdkey TYPE seocpdkey.
ls_mtdkey-clsname = iv_name.
ls_mtdkey-cpdname = iv_method.
cl_oo_classname_service=>get_method_include(
EXPORTING
mtdkey = ls_mtdkey
RECEIVING
result = rv_program
EXCEPTIONS
method_not_existing = 1 ).
IF sy-subrc = 0.
RETURN.
ENDIF.
CALL FUNCTION 'SEO_METHOD_GENERATE_INCLUDE'
EXPORTING
suppress_mtdkey_check = abap_true
mtdkey = ls_mtdkey
EXCEPTIONS
not_existing = 1
model_only = 2
include_existing = 3
method_imp_not_generated = 4
method_imp_not_initialised = 5
_internal_class_not_existing = 6
_internal_method_overflow = 7
cancelled = 8
method_is_abstract_implemented = 9
method_is_final_implemented = 10
internal_error_insert_report = 11
OTHERS = 12.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_program = cl_oo_classname_service=>get_method_include( ls_mtdkey ).
ENDMETHOD.
METHOD generate_classpool.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = iv_name.
CALL FUNCTION 'SEO_CLASS_GENERATE_CLASSPOOL'
EXPORTING
clskey = ls_clskey
suppress_corr = abap_true
EXCEPTIONS
not_existing = 1
model_only = 2
class_pool_not_generated = 3
class_stment_not_generated = 4
locals_not_generated = 5
macros_not_generated = 6
public_sec_not_generated = 7
protected_sec_not_generated = 8
private_sec_not_generated = 9
typeref_not_generated = 10
class_pool_not_initialised = 11
class_stment_not_initialised = 12
locals_not_initialised = 13
macros_not_initialised = 14
public_sec_not_initialised = 15
protected_sec_not_initialised = 16
private_sec_not_initialised = 17
typeref_not_initialised = 18
_internal_class_overflow = 19
OTHERS = 20.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD get_method_includes.
" get method includes for implemented interfaces
" this will contain also leftover includes for deleted interface methods
rt_includes = cl_oo_classname_service=>get_all_method_includes( iv_classname ).
ENDMETHOD.
METHOD init_scanner.
DATA: lx_exc TYPE REF TO cx_root,
lv_message TYPE string,
lv_classname TYPE abap_abstypename.
FIELD-SYMBOLS: <lv_line> TYPE i.
TRY.
ro_scanner = cl_oo_source_scanner_class=>create_class_scanner(
clif_name = iv_name
source = it_source ).
ro_scanner->scan( ).
CATCH cx_clif_scan_error.
zcx_abapgit_exception=>raise( 'error initializing CLAS scanner' ).
CATCH cx_root INTO lx_exc.
lv_classname = cl_abap_classdescr=>get_class_name( lx_exc ).
IF lv_classname = '\CLASS=CX_OO_CLIF_SCAN_ERROR_DETAIL'.
ASSIGN lx_exc->('SOURCE_POSITION-LINE') TO <lv_line>.
ASSERT sy-subrc = 0.
lv_message = |{ lx_exc->get_text( ) }, line { <lv_line> }|.
ELSE.
lv_message = lx_exc->get_text( ).
ENDIF.
zcx_abapgit_exception=>raise( lv_message ).
ENDTRY.
ENDMETHOD.
METHOD repair_classpool.
CALL FUNCTION 'SEO_CLASS_REPAIR_CLASSPOOL'
EXPORTING
clskey = is_key
EXCEPTIONS
not_existing = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing class { is_key-clsname }| ).
ENDIF.
ENDMETHOD.
METHOD repair_redefinitions.
" Same logic as SE24 > Utilities > Clean-up > Redefinitions (LSEODCCO)
DATA:
lt_inheritance TYPE vseoextend,
lt_redefinitions TYPE seor_redefinitions_r,
ls_cpdkey TYPE seocpdkey,
lv_tabix TYPE sy-tabix,
lv_exposure TYPE n LENGTH 1,
lv_update TYPE abap_bool,
lv_local_component TYPE abap_bool.
FIELD-SYMBOLS <ls_redef> TYPE seoredef.
CALL FUNCTION 'SEO_CLASS_TYPEINFO_GET'
EXPORTING
clskey = is_key
version = seoc_version_active
IMPORTING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
is_interface = 2
model_only = 3
OTHERS = 4.
IF sy-subrc <> 0.
RETURN.
ENDIF.
" check redefinitions validity
LOOP AT lt_redefinitions ASSIGNING <ls_redef>.
lv_tabix = sy-tabix.
ls_cpdkey-clsname = is_key-clsname.
ls_cpdkey-cpdname = <ls_redef>-mtdname.
CALL FUNCTION 'SEO_COMPONENT_BY_INHERITANCE'
EXPORTING
cpdkey = ls_cpdkey
version = seoc_version_active
IMPORTING
exposure = lv_exposure
is_local_component = lv_local_component
EXCEPTIONS
not_existing = 1
model_only = 2
OTHERS = 3.
IF sy-subrc <> 0.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ELSEIF <ls_redef>-exposure <> lv_exposure.
<ls_redef>-exposure = lv_exposure.
lv_update = abap_true.
ELSEIF lv_local_component = abap_true AND <ls_redef>-attvalue IS INITIAL AND
<ls_redef>-mtdabstrct IS INITIAL AND <ls_redef>-mtdfinal IS INITIAL.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ENDIF.
ENDLOOP.
IF lv_update = abap_true.
CALL FUNCTION 'SEO_INHERITANC_CHANGE_F_DATA'
EXPORTING
save = abap_false
CHANGING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
deleted = 2
is_comprising = 3
is_implementing = 4
not_changed = 5
db_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
CALL FUNCTION 'SEO_CLIF_SAVE_ALL'
EXPORTING
cifkey = is_key
EXCEPTIONS
not_existing = 1
nothing_to_do = 2
access_error = 3
db_error = 4
error_in_code_generation = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD update_cs_number_of_methods.
" Indirect access to keep downward compatibility
DATA lr_cache_entry TYPE REF TO data.
FIELD-SYMBOLS: <lg_cache_entry> TYPE any,
<lg_field> TYPE any.
TRY.
CREATE DATA lr_cache_entry TYPE ('SEO_CS_CACHE').
CATCH cx_sy_create_data_error.
* does not exist in some older systems
RETURN.
ENDTRY.
ASSIGN lr_cache_entry->* TO <lg_cache_entry>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_classname.
ASSIGN COMPONENT 'NO_OF_METHOD_IMPLS' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_number_of_impl_methods.
MODIFY ('SEO_CS_CACHE') FROM <lg_cache_entry>.
ENDMETHOD.
METHOD update_full_class_include.
CONSTANTS: lc_class_source_extension TYPE c LENGTH 2 VALUE 'CS',
lc_include_program_type TYPE c LENGTH 1 VALUE 'I',
lc_active_version TYPE r3state VALUE 'A'.
create_report( iv_program = cl_oo_classname_service=>get_cs_name( iv_classname )
iv_package = iv_package
it_source = it_source
iv_extension = lc_class_source_extension
iv_program_type = lc_include_program_type
iv_state = lc_active_version
iv_version = iv_version ).
" Assuming that all methods that were scanned are implemented
update_cs_number_of_methods( iv_classname = iv_classname
iv_number_of_impl_methods = lines( it_methods ) ).
ENDMETHOD.
METHOD update_meta.
DATA: lo_update TYPE REF TO cl_oo_class_section_source,
lx_error TYPE REF TO cx_oo_source_save_failure,
ls_clskey TYPE seoclskey,
lv_scan_error TYPE abap_bool.
ls_clskey-clsname = iv_name.
TRY.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = ls_clskey
version = seoc_version_active.
CREATE OBJECT lo_update TYPE ('CL_OO_CLASS_SECTION_SOURCE')
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
source = it_source
suppress_constrctr_generation = abap_true
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3 ##SUBRC_OK.
CATCH cx_sy_dyn_call_param_not_found.
* downport to 702, see https://github.com/abapGit/abapGit/issues/933
* this will READ REPORT instead of using it_source, which should be okay
CREATE OBJECT lo_update TYPE cl_oo_class_section_source
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
lo_update->set_dark_mode( abap_true ).
TRY.
CALL METHOD lo_update->('SET_AMDP_SUPPORT')
EXPORTING
enabled = abap_true.
CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
* AMDP not supported in this system, ignore error
ENDTRY.
lo_update->scan_section_source(
RECEIVING
scan_error = lv_scan_error
EXCEPTIONS
scan_abap_source_error = 1
OTHERS = 2 ).
IF sy-subrc <> 0 OR lv_scan_error = abap_true.
zcx_abapgit_exception=>raise( |CLAS, error while scanning source. Subrc = { sy-subrc }| ).
ENDIF.
* this will update the SEO* database tables
TRY.
lo_update->revert_scan_result( ).
CATCH cx_oo_source_save_failure INTO lx_error.
zcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
IF iv_exposure = seoc_exposure_public.
generate_classpool( iv_name ).
ENDIF.
ENDMETHOD.
METHOD update_report.
DATA lv_type TYPE c LENGTH 1.
lv_type = zcl_abapgit_oo_base=>c_include_program_type.
IF iv_program+30 = srext_ext_class_pool.
lv_type = zcl_abapgit_oo_base=>c_cp_program_type.
ENDIF.
rv_updated = zcl_abapinst_factory=>get_sap_report( )->update_report(
iv_name = iv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_source
iv_program_type = lv_type ).
ENDMETHOD.
METHOD update_source_index.
CONSTANTS:
lc_version_active TYPE r3state VALUE 'A',
lc_version_inactive TYPE r3state VALUE 'I'.
" dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA lo_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT lo_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname
version = lc_version_active
scanner = io_scanner.
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname
version = lc_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
RETURN.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
DATA:
lt_vseoattrib TYPE seoo_attributes_r,
ls_class_key TYPE seoclskey,
ls_properties TYPE vseoclass,
lt_attributes TYPE zif_abapgit_oo_object_fnc=>ty_obj_attribute_tt.
FIELD-SYMBOLS: <lv_clsname> TYPE seoclsname.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE cg_properties TO <lv_clsname>.
ASSERT sy-subrc = 0.
" Get existing class properties and attributes and check if the class
" needs to be created/updated (or is the same)
IF iv_check = abap_true.
ls_class_key-clsname = <lv_clsname>.
ls_properties = zif_abapgit_oo_object_fnc~get_class_properties( ls_class_key ).
lt_attributes = zif_abapgit_oo_object_fnc~read_attributes( <lv_clsname> ).
IF ls_properties = cg_properties AND lt_attributes = it_attributes.
RETURN.
ENDIF.
ENDIF.
lt_vseoattrib = convert_attrib_to_vseoattrib(
iv_clsname = <lv_clsname>
it_attributes = it_attributes ).
" Hardcode STATE (#2612)
ls_properties = cg_properties.
ls_properties-state = seoc_state_implemented.
TRY.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
suppress_dialog = abap_true " Parameter missing in 702
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
zcl_abapgit_sotr_handler=>create_sotr(
iv_package = iv_package
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>create_sots(
iv_package = iv_package
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
" SEO_CLASS_DELETE_COMPLETE deletes OTR usage, only
" Use handler to also delete OTR header and texts
zcl_abapgit_sotr_handler=>delete_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
zcl_abapgit_sots_handler=>delete_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
CALL FUNCTION 'SEO_CLASS_DELETE_COMPLETE'
EXPORTING
clskey = is_deletion_key
EXCEPTIONS
not_existing = 1
is_interface = 2
db_error = 3
no_access = 4
other = 5
OTHERS = 6.
IF sy-subrc = 1.
* ignore deletion of objects that does not exist
* this can happen when the SXCI object is deleted before the implementing CLAS
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
DATA: lv_updated TYPE abap_bool,
lv_program TYPE program,
lo_scanner TYPE REF TO cl_oo_source_scanner_class,
lt_methods TYPE cl_oo_source_scanner_class=>type_method_implementations,
lt_incls TYPE seop_methods_w_include,
lv_method LIKE LINE OF lt_methods,
lt_public TYPE seop_source_string,
lt_source TYPE seop_source_string.
"Buffer needs to be refreshed,
"otherwise standard SAP CLIF_SOURCE reorder methods alphabetically
CALL FUNCTION 'SEO_BUFFER_INIT'.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = is_key
version = seoc_version_inactive.
lo_scanner = init_scanner(
it_source = it_source
iv_name = is_key-clsname ).
* public
lt_public = lo_scanner->get_public_section_source( ).
IF lt_public IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_pubsec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_public ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_public
it_source = lt_public ).
ENDIF.
ENDIF.
* protected
lt_source = lo_scanner->get_protected_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prosec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_protected
it_source = lt_source ).
ENDIF.
ENDIF.
* private
lt_source = lo_scanner->get_private_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prisec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_private
it_source = lt_source ).
ENDIF.
ENDIF.
* methods
lt_methods = lo_scanner->get_method_implementations( ).
lt_incls = get_method_includes( is_key-clsname ).
LOOP AT lt_methods INTO lv_method.
TRY.
lt_source = lo_scanner->get_method_impl_source( lv_method ).
CATCH cx_oo_clif_component.
zcx_abapgit_exception=>raise( 'error from GET_METHOD_IMPL_SOURCE' ).
ENDTRY.
lv_program = determine_method_include(
iv_name = is_key-clsname
iv_method = lv_method ).
update_report(
iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
" If method was implemented before, remove from list
DELETE lt_incls WHERE cpdkey-clsname = is_key-clsname AND cpdkey-cpdname = lv_method.
ENDLOOP.
* full class include
update_full_class_include( iv_classname = is_key-clsname
iv_package = iv_package
iv_version = iv_version
it_source = it_source
it_methods = lt_methods ).
" If there are leftover method includes, then class needs to be repaired
" which will delete the obsolete includes
IF lt_incls IS NOT INITIAL.
repair_classpool( is_key ).
repair_redefinitions( is_key ).
ENDIF.
update_source_index(
iv_clsname = is_key-clsname
io_scanner = lo_scanner ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = is_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2
is_interface = 3
no_text = 4
inconsistent = 5
OTHERS = 6.
rv_exists = boolc( sy-subrc = 0 OR sy-subrc = 4 ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
DATA: lv_program TYPE syrepid.
IF lines( it_local_definitions ) > 0.
lv_program = cl_oo_classname_service=>get_ccdef_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_definitions ).
ENDIF.
IF lines( it_local_implementations ) > 0.
lv_program = cl_oo_classname_service=>get_ccimp_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_implementations ).
ENDIF.
IF lines( it_local_macros ) > 0.
lv_program = cl_oo_classname_service=>get_ccmac_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_macros ).
ENDIF.
lv_program = cl_oo_classname_service=>get_ccau_name( is_key-clsname ).
IF lines( it_local_test_classes ) > 0.
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_test_classes ).
ELSE.
" Drop the include to remove left-over test classes
delete_report( lv_program ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
CALL FUNCTION 'SEO_CLIF_GET'
EXPORTING
cifkey = is_class_key
version = seoc_version_active
IMPORTING
class = rs_class_properties
EXCEPTIONS
not_existing = 1
deleted = 2
model_only = 3
OTHERS = 4.
IF sy-subrc = 1.
RETURN. " in case only inactive version exists
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR:
" TODO 2023-08-01: Clear rs_class_properties-state (#2612)
rs_class_properties-uuid,
rs_class_properties-author,
rs_class_properties-createdon,
rs_class_properties-changedby,
rs_class_properties-changedon,
rs_class_properties-r3release,
rs_class_properties-chgdanyby,
rs_class_properties-chgdanyon,
rs_class_properties-clsfinal,
rs_class_properties-clsabstrct,
rs_class_properties-exposure,
rs_class_properties-version.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
* note: includes returned might not exist
* method cl_oo_classname_service=>GET_ALL_CLASS_INCLUDES does not exist in 702
DATA: lv_class_name TYPE seoclsname,
lt_methods TYPE seop_methods_w_include.
FIELD-SYMBOLS: <ls_method> LIKE LINE OF lt_methods.
lv_class_name = iv_object_name.
APPEND cl_oo_classname_service=>get_ccdef_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccmac_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccimp_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_cl_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccau_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_pubsec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prosec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prisec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_classpool_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ct_name( lv_class_name ) TO rt_includes.
* skip the CS include, as it is sometimes generated on the fly instead of
* when the methods are changed
cl_oo_classname_service=>get_all_method_includes(
EXPORTING
clsname = lv_class_name
RECEIVING
result = lt_methods
EXCEPTIONS
class_not_existing = 1 ).
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Class { lv_class_name } not existing| ).
ENDIF.
LOOP AT lt_methods ASSIGNING <ls_method>.
APPEND <ls_method>-incname TO rt_includes.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
INSERT TEXTPOOL lv_cp
FROM it_text_pool
LANGUAGE iv_language
STATE iv_state.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
zcl_abapgit_objects_activation=>add( iv_type = 'REPT'
iv_name = lv_cp ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
zcl_abapgit_sotr_handler=>read_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>read_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
READ TEXTPOOL lv_cp INTO rt_text_pool LANGUAGE iv_language. "#EC CI_READ_REP
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INSERT TEXTPOOL lv_cp
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,846 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF ls_vseoclass-category = '40'.
UPDATE seoclassdf SET category = '40' WHERE clsname = ls_vseoclass-clsname.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
UPDATE seoclassdf SET category = '40' WHERE clsname = ls_vseoclass-clsname.
```
Explanation: Modify only own DB tables. | 1,847 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD update_func_group_short_text.
" We update the short text directly.
" SE80 does the same in
" Program SAPLSEUF / LSEUFF07
" FORM GROUP_CHANGE
UPDATE tlibt SET areat = iv_short_text
WHERE spras = mv_language AND area = iv_group.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE tlibt SET areat = iv_short_text
```
Explanation: Modify only own DB tables. | 1,848 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_idoc IMPLEMENTATION.
METHOD clear_idoc_segement_field.
FIELD-SYMBOLS <lg_any_field> TYPE any.
ASSIGN COMPONENT iv_fieldname OF STRUCTURE cg_structure TO <lg_any_field>.
IF sy-subrc = 0.
CLEAR <lg_any_field>.
ENDIF.
ENDMETHOD.
METHOD clear_idoc_segement_fields.
clear_idoc_segement_field( EXPORTING iv_fieldname = 'DEVC'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PLAST'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PWORK'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PRESP'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'CREDATE'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'CRETIME'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'LDATE'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'LTIME'
CHANGING cg_structure = cg_structure ).
ENDMETHOD.
METHOD constructor.
super->constructor( is_item = is_item
iv_language = iv_language ).
mv_idoctyp = ms_item-obj_name.
ENDMETHOD.
METHOD is_closed.
DATA ls_idoc TYPE ty_idoc.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_idoc-attributes
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
rv_closed = boolc( sy-subrc = 0 AND ls_idoc-attributes-closed = abap_true ).
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
DATA: ls_attributes TYPE edi_iapi01.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_attributes
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_user = ls_attributes-plast.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
CALL FUNCTION 'IDOCTYPE_DELETE'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
lock_error = 2
action_not_possible = 3
transport_error = 4
db_error = 5
no_authority = 6
OTHERS = 7.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA: ls_idoc TYPE ty_idoc,
lv_transport TYPE trkorr,
ls_edbas TYPE edbas,
ls_attributes TYPE edi_iapi05.
io_xml->read(
EXPORTING
iv_name = 'IDOC'
CHANGING
cg_data = ls_idoc ).
MOVE-CORRESPONDING ls_idoc-attributes TO ls_attributes.
IF zif_abapgit_object~exists( ) = abap_false.
CALL FUNCTION 'IDOCTYPE_CREATE'
EXPORTING
pi_idoctyp = mv_idoctyp
pi_devclass = iv_package
pi_attributes = ls_attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
object_exists = 2
syntax_error = 3
segment_error = 4
transport_error = 5
db_error = 6
no_authority = 7
OTHERS = 8.
ELSE.
IF is_closed( ) = abap_true.
CALL FUNCTION 'IDOCTYPE_UNCLOSE'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
action_not_possible = 2
db_error = 3
no_authority = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
CALL FUNCTION 'IDOCTYPE_UPDATE'
EXPORTING
pi_idoctyp = mv_idoctyp
pi_attributes = ls_attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
object_exists = 2
syntax_error = 3
segment_error = 4
transport_error = 5
db_error = 6
no_authority = 7
OTHERS = 8.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
IF ls_idoc-attributes-closed = abap_true.
IF iv_transport IS NOT INITIAL.
lv_transport = iv_transport.
CALL FUNCTION 'IDOCTYPE_CLOSE'
EXPORTING
pi_idoctyp = mv_idoctyp
CHANGING
pc_order = lv_transport
EXCEPTIONS
object_not_found = 1
action_not_possible = 2
db_error = 3
no_authority = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
" IDOCTYPE_CLOSE saves current release but it should be same as in repo
SELECT SINGLE * FROM edbas INTO ls_edbas WHERE idoctyp = mv_idoctyp.
ls_edbas-released = ls_idoc-attributes-released.
ls_edbas-applrel = ls_idoc-attributes-applrel.
ls_edbas-closed = ls_idoc-attributes-closed.
UPDATE edbas FROM ls_edbas.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error updating IDOC { mv_idoctyp }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
CALL FUNCTION 'IDOCTYPE_EXISTENCE_CHECK'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
db_error = 2
OTHERS = 3.
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lt_bdcdata TYPE TABLE OF bdcdata.
FIELD-SYMBOLS: <ls_bdcdata> LIKE LINE OF lt_bdcdata.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-program = 'SAPMSED5'.
<ls_bdcdata>-dynpro = '0010'.
<ls_bdcdata>-dynbegin = abap_true.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'SED5STRUC-OBJECT'.
<ls_bdcdata>-fval = ms_item-obj_name.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'SED5STRUC-SELECT_ORG'.
<ls_bdcdata>-fval = abap_true.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'BDC_OKCODE'.
<ls_bdcdata>-fval = '=DISP'.
zcl_abapgit_objects_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'WE30'
it_bdcdata = lt_bdcdata ).
rv_exit = abap_true.
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_idoc TYPE ty_idoc.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_idoc-attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
clear_idoc_segement_fields( CHANGING cg_structure = ls_idoc-attributes ).
io_xml->add( iv_name = 'IDOC'
ig_data = ls_idoc ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
UPDATE edbas FROM ls_edbas.
```
Explanation: Modify only own DB tables. | 1,849 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
ls_t100 TYPE t100,
lt_t100t TYPE TABLE OF t100t,
lt_t100_texts TYPE ty_t100_texts,
lt_t100u TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100_text> TYPE ty_t100_text.
lv_msg_id = ms_item-obj_name.
SELECT * FROM t100u INTO TABLE lt_t100u
WHERE arbgb = lv_msg_id ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
ii_xml->read( EXPORTING iv_name = 'T100_TEXTS'
CHANGING cg_data = lt_t100_texts ).
ii_xml->read( EXPORTING iv_name = 'T100T'
CHANGING cg_data = lt_t100t ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100_texts ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100t ).
MODIFY t100t FROM TABLE lt_t100t. "#EC CI_SUBRC
LOOP AT lt_t100_texts ASSIGNING <ls_t100_text>.
"check if message exists
READ TABLE lt_t100u TRANSPORTING NO FIELDS
WITH KEY arbgb = lv_msg_id msgnr = <ls_t100_text>-msgnr BINARY SEARCH.
CHECK sy-subrc = 0. "if original message doesn't exist no translations added
MOVE-CORRESPONDING <ls_t100_text> TO ls_t100.
ls_t100-arbgb = lv_msg_id.
MODIFY t100 FROM ls_t100.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY t100t FROM TABLE lt_t100t.
```
Explanation: Modify only own DB tables. | 1,859 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_msag IMPLEMENTATION.
METHOD delete_documentation.
DATA: lv_key_s TYPE dokhl-object.
CLEAR lv_key_s.
CALL FUNCTION 'DOCU_OBJECT_NAME_CONCATENATE'
EXPORTING
docu_id = c_longtext_id_msag
element = iv_message_id
addition = ' '
IMPORTING
object = lv_key_s
EXCEPTIONS
OTHERS = 0.
CALL FUNCTION 'DOKU_DELETE_ALL'
EXPORTING
doku_id = c_longtext_id_msag
doku_object = lv_key_s
generic_use = 'X'
suppress_authority = space
suppress_enqueue = space
suppress_transport = space
EXCEPTIONS
header_without_text = 1
index_without_header = 2
no_authority_for_devclass_xxxx = 3
no_docu_found = 4
object_is_already_enqueued = 5
object_is_enqueued_by_corr = 6
user_break = 7.
ENDMETHOD.
METHOD delete_msgid.
delete_documentation( iv_message_id ).
DELETE FROM t100a WHERE arbgb = iv_message_id.
IF sy-subrc = 0 OR sy-subrc = 4.
CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
EXPORTING
object = iv_message_id
operation = 'DELETE'
program = space
type = 'CN'.
DELETE FROM t100o WHERE arbgb = iv_message_id.
DELETE FROM t100t WHERE arbgb = iv_message_id. "#EC CI_NOFIRST
DELETE FROM t100u WHERE arbgb = iv_message_id.
DELETE FROM t100x WHERE arbgb = iv_message_id.
DELETE FROM t100 WHERE arbgb = iv_message_id.
ENDIF.
ENDMETHOD.
METHOD deserialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
ls_t100 TYPE t100,
lt_t100t TYPE TABLE OF t100t,
lt_t100_texts TYPE ty_t100_texts,
lt_t100u TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100_text> TYPE ty_t100_text.
lv_msg_id = ms_item-obj_name.
SELECT * FROM t100u INTO TABLE lt_t100u
WHERE arbgb = lv_msg_id ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
ii_xml->read( EXPORTING iv_name = 'T100_TEXTS'
CHANGING cg_data = lt_t100_texts ).
ii_xml->read( EXPORTING iv_name = 'T100T'
CHANGING cg_data = lt_t100t ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100_texts ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100t ).
MODIFY t100t FROM TABLE lt_t100t. "#EC CI_SUBRC
LOOP AT lt_t100_texts ASSIGNING <ls_t100_text>.
"check if message exists
READ TABLE lt_t100u TRANSPORTING NO FIELDS
WITH KEY arbgb = lv_msg_id msgnr = <ls_t100_text>-msgnr BINARY SEARCH.
CHECK sy-subrc = 0. "if original message doesn't exist no translations added
MOVE-CORRESPONDING <ls_t100_text> TO ls_t100.
ls_t100-arbgb = lv_msg_id.
MODIFY t100 FROM ls_t100.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD free_access_permission.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = iv_message_id
object_class = 'T100'.
ENDMETHOD.
METHOD serialize_longtexts_msag.
DATA: lv_doku_object_name TYPE dokhl-object,
lt_doku_object_names TYPE STANDARD TABLE OF dokhl-object
WITH NON-UNIQUE DEFAULT KEY,
lt_dokil TYPE zif_abapgit_definitions=>ty_dokil_tt,
ls_dokil LIKE LINE OF lt_dokil,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
FIELD-SYMBOLS: <ls_t100> TYPE t100.
IF lines( it_t100 ) = 0.
RETURN.
ENDIF.
LOOP AT it_t100 ASSIGNING <ls_t100>.
lv_doku_object_name = <ls_t100>-arbgb && <ls_t100>-msgnr.
INSERT lv_doku_object_name INTO TABLE lt_doku_object_names.
ENDLOOP.
IF mo_i18n_params->ms_params-main_language_only = abap_true.
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND masterlang = abap_true
ORDER BY PRIMARY KEY.
ELSE.
lt_language_filter = mo_i18n_params->build_language_filter( ).
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND langu IN lt_language_filter
ORDER BY PRIMARY KEY.
ENDIF.
CLEAR ls_dokil-dokstate.
MODIFY lt_dokil FROM ls_dokil TRANSPORTING dokstate WHERE dokstate IS NOT INITIAL.
IF lines( lt_dokil ) > 0.
serialize_longtexts( ii_xml = ii_xml
it_dokil = lt_dokil ).
ENDIF.
ENDMETHOD.
METHOD serialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
lt_t100_texts TYPE ty_t100_texts,
lt_t100t TYPE TABLE OF t100t,
lt_i18n_langs TYPE TABLE OF langu,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
lv_msg_id = ms_item-obj_name.
IF mo_i18n_params->ms_params-main_language_only = abap_true.
RETURN. " skip
ENDIF.
" Collect additional languages
" Skip main lang - it has been already serialized and also technical languages
lt_language_filter = mo_i18n_params->build_language_filter( ).
SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs
FROM t100t
WHERE arbgb = lv_msg_id
AND sprsl IN lt_language_filter
AND sprsl <> mv_language
ORDER BY langu. "#EC CI_BYPASS "#EC CI_GENBUFF
SORT lt_i18n_langs ASCENDING.
IF lines( lt_i18n_langs ) > 0.
SELECT * FROM t100t INTO CORRESPONDING FIELDS OF TABLE lt_t100t
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
SELECT * FROM t100 INTO CORRESPONDING FIELDS OF TABLE lt_t100_texts
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
SORT lt_t100t BY sprsl ASCENDING.
SORT lt_t100_texts BY sprsl msgnr ASCENDING.
ii_xml->add( iv_name = 'I18N_LANGS'
ig_data = lt_i18n_langs ).
ii_xml->add( iv_name = 'T100T'
ig_data = lt_t100t ).
ii_xml->add( iv_name = 'T100_TEXTS'
ig_data = lt_t100_texts ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE lastuser FROM t100a INTO rv_user
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0 OR rv_user = ''.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_t100a TYPE t100a,
lv_frozen TYPE abap_bool,
lv_message_id TYPE arbgb.
* parameter SUPPRESS_DIALOG doesnt exist in all versions of FM RS_DELETE_MESSAGE_ID
* replaced with a copy
lv_message_id = ms_item-obj_name.
IF ms_item-obj_name = space.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."blank message id
ENDIF.
SELECT SINGLE * FROM t100a INTO ls_t100a WHERE arbgb = ms_item-obj_name.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."not found
ENDIF.
CLEAR lv_frozen.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
authority_check = 'X'
global_lock = 'X'
mode = 'MODIFY'
object = lv_message_id
object_class = 'T100'
IMPORTING
frozen = lv_frozen
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0 OR lv_frozen <> space.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
zcl_abapinst_factory=>get_cts_api( )->insert_transport_object(
iv_object = 'MSAG'
iv_obj_name = lv_message_id
iv_package = iv_package
iv_language = mv_language
iv_mode = zif_abapgit_cts_api=>c_transport_mode-delete ).
delete_msgid( lv_message_id ).
free_access_permission( lv_message_id ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
* fm RPY_MESSAGE_ID_INSERT almost works, but not in older versions
DATA: ls_t100a TYPE t100a,
ls_t100t TYPE t100t,
ls_t100u TYPE t100u,
lt_t100 TYPE TABLE OF t100,
lt_before TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100> LIKE LINE OF lt_t100.
io_xml->read( EXPORTING iv_name = 'T100A'
CHANGING cg_data = ls_t100a ).
io_xml->read( EXPORTING iv_name = 'T100'
CHANGING cg_data = lt_t100 ).
corr_insert( iv_package ).
SELECT * FROM t100u INTO TABLE lt_before
WHERE arbgb = ls_t100a-arbgb ORDER BY msgnr. "#EC CI_GENBUFF "#EC CI_BYPASS
LOOP AT lt_t100 ASSIGNING <ls_t100>.
DELETE lt_before WHERE msgnr = <ls_t100>-msgnr.
MODIFY t100 FROM <ls_t100>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
CLEAR ls_t100u.
MOVE-CORRESPONDING <ls_t100> TO ls_t100u ##ENH_OK.
ls_t100u-name = sy-uname.
ls_t100u-datum = sy-datum.
ls_t100u-selfdef = '3'.
MODIFY t100u FROM ls_t100u.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100U modify failed' ).
ENDIF.
ENDLOOP.
ls_t100a-masterlang = mv_language.
ls_t100a-lastuser = sy-uname.
ls_t100a-respuser = sy-uname.
ls_t100a-ldate = sy-datum.
ls_t100a-ltime = sy-uzeit.
MODIFY t100a FROM ls_t100a.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100A modify failed' ).
ENDIF.
ls_t100t-sprsl = mv_language.
ls_t100t-arbgb = ls_t100a-arbgb.
ls_t100t-stext = ls_t100a-stext.
MODIFY t100t FROM ls_t100t.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100T modify failed' ).
ENDIF.
LOOP AT lt_before INTO ls_t100u.
DELETE FROM t100 WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
DELETE FROM t100u WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
ENDLOOP.
deserialize_longtexts( ii_xml = io_xml
iv_longtext_id = c_longtext_id_msag ).
IF mo_i18n_params->is_lxe_applicable( ) = abap_false.
deserialize_texts( io_xml ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_arbgb TYPE t100a-arbgb.
SELECT SINGLE arbgb FROM t100a INTO lv_arbgb
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
DATA: lv_argument TYPE seqg3-garg.
lv_argument = |{ ms_item-obj_name }|.
OVERLAY lv_argument WITH ' '.
lv_argument = lv_argument && '*'.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = |ES_MSGSI|
iv_argument = lv_argument ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Covered by zcl_abapinst_objects=>JUMP
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: lv_msg_id TYPE rglif-message_id,
ls_inf TYPE t100a,
lt_source TYPE ty_t100s.
lv_msg_id = ms_item-obj_name.
SELECT SINGLE * FROM t100a INTO ls_inf
WHERE arbgb = lv_msg_id. "#EC CI_GENBUFF
IF sy-subrc <> 0.
RETURN.
ENDIF.
CLEAR ls_inf-respuser.
SELECT * FROM t100 INTO TABLE lt_source
WHERE sprsl = mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
CLEAR: ls_inf-lastuser,
ls_inf-ldate,
ls_inf-ltime.
io_xml->add( iv_name = 'T100A'
ig_data = ls_inf ).
io_xml->add( ig_data = lt_source
iv_name = 'T100' ).
serialize_longtexts_msag( it_t100 = lt_source
ii_xml = io_xml ).
IF mo_i18n_params->is_lxe_applicable( ) = abap_false.
serialize_texts( io_xml ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
MODIFY t100a FROM ls_t100a.
```
Explanation: Modify only own DB tables.
```abap
MODIFY t100t FROM ls_t100t.
```
Explanation: Modify only own DB tables. | 1,862 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_nspc IMPLEMENTATION.
METHOD add_to_transport.
DATA: li_sap_package TYPE REF TO zif_abapgit_sap_package.
li_sap_package = zcl_abapinst_factory=>get_sap_package( iv_package ).
IF li_sap_package->are_changes_recorded_in_tr_req( ) = abap_true.
corr_insert( iv_package ).
ENDIF.
ENDMETHOD.
METHOD deserialize_texts.
DATA:
ls_trnspacett TYPE trnspacett,
lt_i18n_langs TYPE TABLE OF langu,
lt_nspc_texts TYPE ty_nspc_texts.
FIELD-SYMBOLS:
<lv_lang> LIKE LINE OF lt_i18n_langs,
<ls_nspc_text> LIKE LINE OF lt_nspc_texts.
ii_xml->read( EXPORTING iv_name = 'I18N_LANGS'
CHANGING cg_data = lt_i18n_langs ).
ii_xml->read( EXPORTING iv_name = 'NSPC_TEXTS'
CHANGING cg_data = lt_nspc_texts ).
SORT lt_i18n_langs.
SORT lt_nspc_texts BY spras. " Optimization
LOOP AT lt_i18n_langs ASSIGNING <lv_lang>.
ls_trnspacett-namespace = iv_namespace.
READ TABLE lt_nspc_texts ASSIGNING <ls_nspc_text> WITH KEY spras = <lv_lang>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |NSPC_TEXTS cannot find lang { <lv_lang> } in XML| ).
ENDIF.
MOVE-CORRESPONDING <ls_nspc_text> TO ls_trnspacett.
MODIFY trnspacett FROM ls_trnspacett.
IF sy-subrc <> 0.
INSERT trnspacett FROM ls_trnspacett.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting text for namespace| ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD serialize_texts.
DATA:
ls_trnspacett TYPE trnspacett,
lt_nspc_texts TYPE ty_nspc_texts,
lt_i18n_langs TYPE TABLE OF langu.
FIELD-SYMBOLS:
<lv_lang> LIKE LINE OF lt_i18n_langs,
<ls_nspc_text> LIKE LINE OF lt_nspc_texts.
IF mo_i18n_params->ms_params-main_language_only = abap_true.
RETURN.
ENDIF.
" Collect additional languages, skip main lang - it was serialized already
SELECT DISTINCT spras AS langu FROM trnspacett INTO TABLE lt_i18n_langs
WHERE namespace = ms_item-obj_name AND spras <> mv_language
ORDER BY langu. "#EC CI_SUBRC
LOOP AT lt_i18n_langs ASSIGNING <lv_lang>.
SELECT SINGLE * FROM trnspacett INTO ls_trnspacett
WHERE namespace = ms_item-obj_name AND spras = <lv_lang>.
IF sy-subrc = 0.
APPEND INITIAL LINE TO lt_nspc_texts ASSIGNING <ls_nspc_text>.
MOVE-CORRESPONDING ls_trnspacett TO <ls_nspc_text>.
ENDIF.
ENDLOOP.
SORT lt_i18n_langs ASCENDING.
SORT lt_nspc_texts BY spras ASCENDING.
IF lines( lt_i18n_langs ) > 0.
ii_xml->add( iv_name = 'I18N_LANGS'
ig_data = lt_i18n_langs ).
ii_xml->add( iv_name = 'NSPC_TEXTS'
ig_data = lt_nspc_texts ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE changeuser FROM trnspacet INTO rv_user
WHERE namespace = ms_item-obj_name.
IF sy-subrc <> 0.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
RETURN. " not supported
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA:
ls_nspc TYPE ty_nspc,
ls_nspc_text TYPE ty_nspc_text,
lv_modifiable TYPE abap_bool,
ls_trnspacet TYPE trnspacet,
ls_trnspacett TYPE trnspacett.
io_xml->read( EXPORTING iv_name = 'NSPC'
CHANGING cg_data = ls_nspc ).
io_xml->read( EXPORTING iv_name = 'NSPC_TEXT'
CHANGING cg_data = ls_nspc_text ).
add_to_transport( iv_package ).
SELECT SINGLE * FROM trnspacet INTO ls_trnspacet WHERE namespace = ls_nspc-namespace.
IF sy-subrc = 0.
" For existing namespace, check if it's modifiable (SE03)
SELECT SINGLE editflag FROM trnspace INTO lv_modifiable WHERE namespace = ls_nspc-namespace.
IF sy-subrc = 0 AND lv_modifiable = abap_false.
zcx_abapgit_exception=>raise( |Namespace is not modifiable| ).
ENDIF.
" keep existing role
ls_trnspacet-replicense = ls_nspc-replicense.
ls_trnspacet-sscrflag = ls_nspc-sscrflag.
ls_trnspacet-sapflag = ls_nspc-sapflag.
ls_trnspacet-gen_only = ls_nspc-gen_only.
ls_trnspacet-changeuser = sy-uname.
ls_trnspacet-changedate = sy-datum.
MODIFY trnspacet FROM ls_trnspacet.
ELSE.
MOVE-CORRESPONDING ls_nspc TO ls_trnspacet.
ls_trnspacet-role = 'C'. " customer repair license
ls_trnspacet-changeuser = sy-uname.
ls_trnspacet-changedate = sy-datum.
INSERT trnspacet FROM ls_trnspacet.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting namespace| ).
ENDIF.
SELECT SINGLE * FROM trnspacett INTO ls_trnspacett
WHERE namespace = ls_nspc-namespace AND spras = mv_language.
IF sy-subrc = 0.
ls_trnspacett-descriptn = ls_nspc_text-descriptn.
ls_trnspacett-owner = ls_nspc_text-owner.
MODIFY trnspacett FROM ls_trnspacett.
ELSE.
MOVE-CORRESPONDING ls_nspc_text TO ls_trnspacett.
ls_trnspacett-namespace = ls_nspc-namespace.
INSERT trnspacett FROM ls_trnspacett.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting text for namespace| ).
ENDIF.
deserialize_texts( ii_xml = io_xml
iv_namespace = ls_nspc-namespace ).
" Fill trnspace and trnspacel tables
CALL FUNCTION 'TR_ACTIVATE_NAMESPACE'
EXPORTING
iv_namespace = ls_nspc-namespace
EXCEPTIONS
deletion_not_allowed = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error activating namespace| ).
ENDIF.
" Make namespace modifiable
UPDATE trnspace SET editflag = abap_true WHERE namespace = ls_nspc-namespace.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA lv_namespace TYPE trnspace-namespace.
lv_namespace = ms_item-obj_name.
CALL FUNCTION 'TR_CHECK_NAMESPACE'
EXPORTING
iv_namespace = lv_namespace
EXCEPTIONS
namespace_not_valid = 1
OTHERS = 2.
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = zif_abapgit_object~exists( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Launch general maintenance for namespaces
CALL FUNCTION 'VIEW_MAINTENANCE_CALL'
EXPORTING
action = 'S'
view_name = 'V_TRNSPACE'
no_warning_for_clientindep = 'X'
variant_for_selection = 'STANDARD'
EXCEPTIONS
client_reference = 1
foreign_lock = 2
invalid_action = 3
no_clientindependent_auth = 4
no_database_function = 5
no_editor_function = 6
no_show_auth = 7
no_tvdir_entry = 8
no_upd_auth = 9
only_show_allowed = 10
system_failure = 11
unknown_field_in_dba_sellist = 12
view_not_found = 13
OTHERS = 14.
rv_exit = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA:
ls_nspc TYPE ty_nspc,
ls_nspc_text TYPE ty_nspc_text.
SELECT SINGLE * FROM trnspacet INTO CORRESPONDING FIELDS OF ls_nspc
WHERE namespace = ms_item-obj_name.
SELECT SINGLE * FROM trnspacett INTO CORRESPONDING FIELDS OF ls_nspc_text
WHERE namespace = ms_item-obj_name AND spras = mv_language.
io_xml->add( iv_name = 'NSPC'
ig_data = ls_nspc ).
io_xml->add( iv_name = 'NSPC_TEXT'
ig_data = ls_nspc_text ).
serialize_texts( io_xml ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
MODIFY trnspacet FROM ls_trnspacet.
```
Explanation: Modify only own DB tables.
```abap
INSERT trnspacet FROM ls_trnspacet.
```
Explanation: Modify only own DB tables.
```abap
ls_trnspacett-namespace = ls_nspc-namespace.
INSERT trnspacett FROM ls_trnspacett. * <-- There is a problem here
ENDIF.
```
Explanation: Modify only own DB tables.
```abap
UPDATE trnspace SET editflag = abap_true WHERE namespace = ls_nspc-namespace.
```
Explanation: Modify only own DB tables. | 1,866 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_para IMPLEMENTATION.
METHOD unlock.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = iv_paramid
object_class = 'PARA'.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
* looks like "changed by user" is not stored in the database
rv_user = c_user_unknown.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
" We can't use FM RS_PARAMETER_DELETE because of the popup to confirm
"Therefore we have to reimplement most of the FMs logic
DATA lv_paramid TYPE tpara-paramid.
lv_paramid = ms_item-obj_name.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
global_lock = abap_true
language_upd_exit = 'RS_PARAMETER_LANGUAGE_EXIT' " Name FuBa for maintenance language change
object = lv_paramid
object_class = ms_item-obj_type
suppress_language_check = space
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
SELECT COUNT(*) FROM cross
WHERE ( type = 'P' OR type = 'Q' ) AND name = lv_paramid.
IF sy-subrc = 0.
unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ELSE.
SELECT COUNT(*) FROM dd04l BYPASSING BUFFER
WHERE memoryid = lv_paramid
AND as4local = 'A'.
IF sy-subrc = 0.
unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ENDIF.
ENDIF.
unlock( lv_paramid ).
zcl_abapinst_factory=>get_cts_api( )->insert_transport_object(
iv_object = 'PARA'
iv_obj_name = lv_paramid
iv_package = iv_package
iv_language = mv_language
iv_mode = zif_abapgit_cts_api=>c_transport_mode-delete ).
DELETE FROM tpara WHERE paramid = lv_paramid.
DELETE FROM tparat WHERE paramid = lv_paramid.
CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
EXPORTING
object = lv_paramid
operation = 'DELETE'
type = 'CR'.
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
* see fm RS_PARAMETER_ADD and RS_PARAMETER_EDIT
DATA: lv_mode TYPE c LENGTH 1,
ls_tpara TYPE tpara,
ls_tparat TYPE tparat.
SELECT SINGLE * FROM tpara INTO ls_tpara
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc = 0.
lv_mode = 'M'.
ELSE.
lv_mode = 'I'.
ENDIF.
io_xml->read( EXPORTING iv_name = 'TPARA'
CHANGING cg_data = ls_tpara ).
CALL FUNCTION 'RS_CORR_INSERT'
EXPORTING
object = ms_item-obj_name
object_class = 'PARA'
mode = lv_mode
global_lock = abap_true
devclass = iv_package
master_language = mv_language
suppress_dialog = abap_true
EXCEPTIONS
cancelled = 1
permission_failure = 2
unknown_objectclass = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
MODIFY tpara FROM ls_tpara. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
io_xml->read(
EXPORTING iv_name = 'TPARAT'
CHANGING cg_data = ls_tparat ).
MODIFY tparat FROM ls_tparat. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_paramid TYPE tpara-paramid.
SELECT SINGLE paramid FROM tpara INTO lv_paramid
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-ddic TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'EEUDB'
iv_argument = ms_item-obj_name
iv_prefix = 'PA' ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Covered by zcl_abapinst_objects=>JUMP
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_tpara TYPE tpara,
ls_tparat TYPE tparat.
SELECT SINGLE * FROM tpara INTO ls_tpara
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0.
RETURN.
ENDIF.
SELECT SINGLE * FROM tparat INTO ls_tparat
WHERE paramid = ms_item-obj_name
AND sprache = mv_language. "#EC CI_GENBUFF "#EC CI_SUBRC
io_xml->add( iv_name = 'TPARA'
ig_data = ls_tpara ).
io_xml->add(
iv_name = 'TPARAT'
ig_data = ls_tparat ).
" Here only the original language is serialized,
" so it should be present for the moment. LXEs are just translations
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM tpara WHERE paramid = lv_paramid.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM tparat WHERE paramid = lv_paramid.
```
Explanation: Modify only own DB tables.
```abap
MODIFY tpara FROM ls_tpara.
```
Explanation: Modify only own DB tables.
```abap
MODIFY tparat FROM ls_tparat.
```
Explanation: Modify only own DB tables. | 1,868 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT lt_segment_definitions ASSIGNING <ls_segment_definition>.
ls_segment_definition = <ls_segment_definition>.
<ls_segment_definition>-segmentheader-presp = sy-uname.
<ls_segment_definition>-segmentheader-pwork = sy-uname.
CALL FUNCTION 'SEGMENT_READ'
EXPORTING
segmenttyp = <ls_segment_definition>-segmentdefinition-segtyp
IMPORTING
result = lv_result
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0 OR lv_result <> 0.
CALL FUNCTION 'SEGMENT_CREATE'
IMPORTING
segmentdefinition = <ls_segment_definition>-segmentdefinition
TABLES
segmentstructure = <ls_segment_definition>-segmentstructures
CHANGING
segmentheader = <ls_segment_definition>-segmentheader
devclass = lv_package
EXCEPTIONS
OTHERS = 1.
ELSE.
CALL FUNCTION 'SEGMENT_MODIFY'
CHANGING
segmentheader = <ls_segment_definition>-segmentheader
devclass = lv_package
EXCEPTIONS
OTHERS = 1.
IF sy-subrc = 0.
CALL FUNCTION 'SEGMENTDEFINITION_MODIFY'
TABLES
segmentstructure = <ls_segment_definition>-segmentstructures
CHANGING
segmentdefinition = <ls_segment_definition>-segmentdefinition
EXCEPTIONS
OTHERS = 1.
ENDIF.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
IF ls_segment_definition-segmentdefinition-closed = abap_true.
IF lv_transport IS NOT INITIAL.
CALL FUNCTION 'SEGMENTDEFINITION_CLOSE'
EXPORTING
segmenttyp = ls_segment_definition-segmentdefinition-segtyp
CHANGING
order = lv_transport
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
" SEGMENTDEFINITION_CLOSE saves current release but it should be same as in repo
SELECT SINGLE * FROM edisdef INTO ls_edisdef
WHERE segtyp = ls_segment_definition-segmentdefinition-segtyp
AND version = ls_segment_definition-segmentdefinition-version.
ls_edisdef-released = ls_segment_definition-segmentdefinition-released.
ls_edisdef-applrel = ls_segment_definition-segmentdefinition-applrel.
ls_edisdef-closed = ls_segment_definition-segmentdefinition-closed.
UPDATE edisdef FROM ls_edisdef.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error updating IDOC segment {
<ls_segment_definition>-segmentdefinition-segtyp }| ).
ENDIF.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
UPDATE edisdef FROM ls_edisdef.
```
Explanation: Modify only own DB tables. | 1,871 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_tobj IMPLEMENTATION.
METHOD delete_extra.
DELETE FROM tddat WHERE tabname = iv_tabname.
DELETE FROM tvdir WHERE tabname = iv_tabname.
DELETE FROM tvimf WHERE tabname = iv_tabname.
ENDMETHOD.
METHOD read_extra.
SELECT SINGLE * FROM tddat INTO rs_tobj-tddat WHERE tabname = iv_tabname.
SELECT SINGLE * FROM tvdir INTO rs_tobj-tvdir WHERE tabname = iv_tabname.
CLEAR: rs_tobj-tvdir-gendate, rs_tobj-tvdir-gentime, rs_tobj-tvdir-devclass.
SELECT * FROM tvimf INTO TABLE rs_tobj-tvimf WHERE tabname = iv_tabname
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD update_extra.
DATA: lt_current_tvimf TYPE STANDARD TABLE OF tvimf.
FIELD-SYMBOLS: <ls_tvimf> TYPE tvimf.
MODIFY tddat FROM is_tobj-tddat.
MODIFY tvdir FROM is_tobj-tvdir.
SELECT * INTO TABLE lt_current_tvimf
FROM tvimf
WHERE tabname = is_tobj-tddat-tabname
ORDER BY PRIMARY KEY.
LOOP AT lt_current_tvimf ASSIGNING <ls_tvimf>.
READ TABLE is_tobj-tvimf WITH KEY tabname = <ls_tvimf>-tabname
event = <ls_tvimf>-event
TRANSPORTING NO FIELDS.
IF sy-subrc <> 0.
DELETE FROM tvimf
WHERE tabname = <ls_tvimf>-tabname
AND event = <ls_tvimf>-event.
ENDIF.
ENDLOOP.
MODIFY tvimf FROM TABLE is_tobj-tvimf.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
DATA: lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE luser FROM objh INTO rv_user
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
IF sy-subrc <> 0.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_objh TYPE objh,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
IF ls_objh-objecttype = 'L'.
zcx_abapgit_exception=>raise( |Use transaction SOBJ to delete transport objects { ls_objh-objectname }| ).
ENDIF.
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_korrnum = iv_transport
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'D'
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
delete_extra( ls_objh-objectname ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj.
io_xml->read( EXPORTING iv_name = 'OBJH'
CHANGING cg_data = ls_objh ).
io_xml->read( EXPORTING iv_name = 'OBJT'
CHANGING cg_data = ls_objt ).
io_xml->read( EXPORTING iv_name = 'OBJS'
CHANGING cg_data = lt_objs ).
io_xml->read( EXPORTING iv_name = 'OBJSL'
CHANGING cg_data = lt_objsl ).
io_xml->read( EXPORTING iv_name = 'OBJM'
CHANGING cg_data = lt_objm ).
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_korrnum = iv_transport
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'I'
iv_objecttext = ls_objt-ddtext
iv_objcateg = ls_objh-objcateg
iv_objtransp = ls_objh-objtransp
iv_devclass = iv_package
TABLES
tt_v_obj_s = lt_objs
tt_objm = lt_objm
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
* TOBJ has to be saved/generated after the DDIC tables have been
* activated - fixed with late deserialization
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CALL FUNCTION 'OBJ_SET_IMPORTABLE'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_importable = ls_objh-importable
EXCEPTIONS
object_not_defined = 1
invalid = 2
transport_error = 3
object_enqueue_failed = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
* fm OBJ_GENERATE takes the defaults from the DDIC object
* set OBJTRANSP directly, should be okay looking at the code in OBJ_SET_IMPORTABLE
* locking has been done in OBJ_SET_IMPORTABLE plus recording of transport
UPDATE objh SET objtransp = ls_objh-objtransp
WHERE objectname = ls_objh-objectname
AND objecttype = ls_objh-objecttype.
io_xml->read( EXPORTING iv_name = 'TOBJ'
CHANGING cg_data = ls_tobj ).
ls_tobj-tvdir-gendate = sy-datum.
ls_tobj-tvdir-gentime = sy-uzeit.
ls_tobj-tvdir-devclass = iv_package.
update_extra( ls_tobj ).
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_objectname TYPE objh-objectname,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE objectname FROM objh INTO lv_objectname
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-late TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lv_object_name TYPE e071-obj_name.
lv_object_name = ms_item-obj_name.
CALL FUNCTION 'TR_OBJECT_JUMP_TO_TOOL'
EXPORTING
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = lv_object_name
EXCEPTIONS
jump_not_possible = 1
OTHERS = 2.
rv_exit = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
CALL FUNCTION 'CTO_OBJECT_GET'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_language = mv_language
iv_sel_objt = abap_true
iv_sel_objs = abap_true
iv_sel_objsl = abap_true
iv_sel_objm = abap_true
IMPORTING
es_objh = ls_objh
es_objt = ls_objt
TABLES
tt_objs = lt_objs
tt_objsl = lt_objsl
tt_objm = lt_objm
EXCEPTIONS
object_not_defined = 1
OTHERS = 2.
IF sy-subrc = 1.
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR: ls_objh-luser,
ls_objh-ldate.
SORT lt_objs BY objectname objecttype tabname.
SORT lt_objsl BY objectname objecttype trwcount.
SORT lt_objm BY objectname objecttype method.
io_xml->add( iv_name = 'OBJH'
ig_data = ls_objh ).
io_xml->add( iv_name = 'OBJT'
ig_data = ls_objt ).
io_xml->add( iv_name = 'OBJS'
ig_data = lt_objs ).
io_xml->add( iv_name = 'OBJSL'
ig_data = lt_objsl ).
io_xml->add( iv_name = 'OBJM'
ig_data = lt_objm ).
ls_tobj = read_extra( ls_objh-objectname ).
IF ls_tobj-tvdir-detail = ``.
" to prevent xslt serialization error,
" force clear if numc field is empty
CLEAR ls_tobj-tvdir-detail.
ENDIF.
io_xml->add( iv_name = 'TOBJ'
ig_data = ls_tobj ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
UPDATE objh SET objtransp = ls_objh-objtransp
```
Explanation: Modify only own DB tables. | 1,876 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD add.
DATA ls_table TYPE zif_abapgit_persistence=>ty_content.
validate_entry_type( iv_type ).
ls_table-type = iv_type.
ls_table-value = iv_value.
ls_table-data_str = iv_data.
INSERT (c_tabname) FROM ls_table. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT (c_tabname) FROM ls_table.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,880 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete.
lock( iv_type = iv_type
iv_value = iv_value ).
" Ignore errors since record might not exist
DELETE FROM (c_tabname)
WHERE type = iv_type
AND value = iv_value.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM (c_tabname)
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,881 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD update.
DATA lv_data LIKE iv_data.
IF iv_data CS '<?xml'.
lv_data = validate_and_unprettify_xml( iv_data ).
ELSE.
lv_data = iv_data.
ENDIF.
lock( iv_type = iv_type
iv_value = iv_value ).
UPDATE (c_tabname) SET data_str = lv_data
WHERE type = iv_type
AND value = iv_value.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'DB update failed' ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE (c_tabname) SET data_str = lv_data
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 1,887 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_sap_report IMPLEMENTATION.
METHOD authorization_check.
IF is_item IS NOT INITIAL.
TRY.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
abap_langu_version_upon_insert = is_item-abap_language_version " does not exist on lower releases
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_sap_report~delete_report.
authorization_check(
iv_mode = 'DELETE'
is_item = is_item ).
DELETE REPORT iv_name.
IF sy-subrc <> 0 AND iv_raise_error = abap_true.
zcx_abapgit_exception=>raise( |Error deleting report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_sap_report~insert_report.
ASSERT iv_state CA ' AI'.
ASSERT iv_program_type CA ' 1FIJKMST'.
authorization_check(
iv_mode = 'MODIFY'
is_item = is_item ).
IF iv_state IS INITIAL.
INSERT REPORT iv_name FROM it_source.
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state.
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state
PROGRAM TYPE iv_program_type.
ELSE.
INSERT REPORT iv_name FROM it_source
STATE iv_state
EXTENSION TYPE iv_extension_type
PROGRAM TYPE iv_program_type.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error inserting report { iv_name }| ).
ENDIF.
" In lower releases, INSERT REPORT does not support setting ABAP Language version (VERSION)
" Therefore, update the flag directly
UPDATE progdir SET uccheck = iv_version WHERE name = iv_name AND state = iv_state.
ENDMETHOD.
METHOD zif_abapgit_sap_report~read_progdir.
DATA ls_sapdir TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = iv_name
i_state = iv_state
IMPORTING
e_progdir = ls_sapdir
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
MOVE-CORRESPONDING ls_sapdir TO rs_progdir.
CLEAR: rs_progdir-edtx,
rs_progdir-cnam,
rs_progdir-cdat,
rs_progdir-unam,
rs_progdir-udat,
rs_progdir-levl,
rs_progdir-vern,
rs_progdir-rmand,
rs_progdir-sdate,
rs_progdir-stime,
rs_progdir-idate,
rs_progdir-itime,
rs_progdir-varcl,
rs_progdir-state.
ENDMETHOD.
METHOD zif_abapgit_sap_report~read_report.
ASSERT iv_state CA ' AI'.
authorization_check(
iv_mode = 'SHOW'
is_item = is_item ).
IF iv_state IS INITIAL.
READ REPORT iv_name INTO rt_source.
ELSE.
READ REPORT iv_name INTO rt_source STATE iv_state.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error reading report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_sap_report~update_progdir.
DATA ls_progdir_new TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = is_progdir-name
i_state = iv_state
IMPORTING
e_progdir = ls_progdir_new
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error reading program directory' ).
ENDIF.
ls_progdir_new-ldbname = is_progdir-ldbname.
ls_progdir_new-dbna = is_progdir-dbna.
ls_progdir_new-dbapl = is_progdir-dbapl.
ls_progdir_new-rload = is_progdir-rload.
ls_progdir_new-fixpt = is_progdir-fixpt.
ls_progdir_new-appl = is_progdir-appl.
ls_progdir_new-rstat = is_progdir-rstat.
ls_progdir_new-uccheck = is_progdir-uccheck.
ls_progdir_new-sqlx = is_progdir-sqlx.
ls_progdir_new-clas = is_progdir-clas.
ls_progdir_new-secu = is_progdir-secu.
CALL FUNCTION 'UPDATE_PROGDIR'
EXPORTING
i_progdir = ls_progdir_new
i_progname = ls_progdir_new-name
i_state = ls_progdir_new-state
EXCEPTIONS
not_executed = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error updating program directory' ).
ENDIF.
" Function UPDATE_PROGDIR does not update VARCL, so we do it here
SELECT SINGLE * FROM progdir INTO ls_progdir_new
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state.
IF sy-subrc = 0 AND is_progdir-varcl <> ls_progdir_new-varcl.
UPDATE progdir SET varcl = is_progdir-varcl
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state. "#EC CI_SUBRC
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_sap_report~update_report.
DATA lt_new TYPE string_table.
DATA lt_old TYPE string_table.
lt_new = it_source.
lt_old = zif_abapgit_sap_report~read_report( iv_name ).
IF lt_old <> lt_new.
zif_abapgit_sap_report~insert_report(
iv_name = iv_name
it_source = it_source
iv_state = iv_state
iv_program_type = iv_program_type
iv_extension_type = iv_extension_type
iv_package = iv_package
iv_version = iv_version
is_item = is_item ).
rv_updated = abap_true.
ELSE.
rv_updated = abap_false.
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE REPORT iv_name.
```
Explanation: Potential dangerous statement DELETE REPORT.
```abap
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSE.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
UPDATE progdir SET uccheck = iv_version WHERE name = iv_name AND state = iv_state.
```
Explanation: Modify only own DB tables. | 1,888 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_state IS INITIAL.
INSERT REPORT iv_name FROM it_source.
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT iv_name FROM it_source.
```
Explanation: Potential dangerous statement INSERT REPORT. | 1,889 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete_sotr.
DATA lt_sotr_use TYPE ty_sotr_use_tt.
FIELD-SYMBOLS <ls_sotr_use> LIKE LINE OF lt_sotr_use.
lt_sotr_use = get_sotr_usage( iv_pgmid = iv_pgmid
iv_object = iv_object
iv_obj_name = iv_obj_name ).
" Remove any usage to ensure deletion, see function module BTFR_CHECK
DELETE sotr_use FROM TABLE lt_sotr_use ##SUBRC_OK.
LOOP AT lt_sotr_use ASSIGNING <ls_sotr_use> WHERE concept IS NOT INITIAL.
CALL FUNCTION 'SOTR_DELETE_CONCEPT'
EXPORTING
concept = <ls_sotr_use>-concept
EXCEPTIONS
no_entry_found = 1
text_not_found = 2
invalid_package = 3
text_not_changeable = 4
text_enqueued = 5
no_correction = 6
parameter_error = 7
OTHERS = 8.
IF sy-subrc > 2.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE sotr_use FROM TABLE lt_sotr_use ##SUBRC_OK.
```
Explanation: Modify only own DB tables. | 1,891 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete_sots.
DATA lt_sots_use TYPE ty_sots_use_tt.
FIELD-SYMBOLS <ls_sots_use> LIKE LINE OF lt_sots_use.
lt_sots_use = get_sots_usage( iv_pgmid = iv_pgmid
iv_object = iv_object
iv_obj_name = iv_obj_name ).
" Remove any usage to ensure deletion, see function module BTFR_CHECK
DELETE sotr_useu FROM TABLE lt_sots_use ##SUBRC_OK.
LOOP AT lt_sots_use ASSIGNING <ls_sots_use> WHERE concept IS NOT INITIAL.
CALL FUNCTION 'BTFR_DELETE_SINGLE_TEXT'
EXPORTING
concept = <ls_sots_use>-concept
flag_string = abap_true
EXCEPTIONS
text_not_found = 1 "ok
invalid_package = 3
text_not_changeable = 4
text_enqueued = 5
no_correction = 6
parameter_error = 7
OTHERS = 8.
IF sy-subrc > 2.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE sotr_useu FROM TABLE lt_sots_use ##SUBRC_OK.
```
Explanation: Modify only own DB tables. | 1,892 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD _confirm_messages.
" Temporarily suppress certain messages that are not relevant for installation
CONSTANTS lc_toolflag_set TYPE funcname VALUE 'SCWG_TOOLFLAG_SET'.
DATA ls_clmcus TYPE clmcus.
" Set tool flag to avoid messages
CALL FUNCTION 'FUNCTION_EXISTS'
EXPORTING
funcname = lc_toolflag_set
EXCEPTIONS
function_not_exist = 1
OTHERS = 2.
IF sy-subrc = 0.
CALL FUNCTION lc_toolflag_set.
ENDIF.
" Confirm message about modification mode (DT, CLM_INFORMATION)
" and backup old state (see _restore_messages)
SELECT * FROM clmcus INTO TABLE gt_clmcus WHERE username = sy-uname ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-username = sy-uname.
ls_clmcus-obj_type = 'CLAS'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-obj_type = 'INTF'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ls_clmcus-obj_type = 'METH'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK.
CHECK sy-subrc >= 0. "abaplint
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ls_clmcus-obj_type = 'CLAS'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables.
```abap
ls_clmcus-obj_type = 'INTF'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables.
```abap
ls_clmcus-obj_type = 'METH'.
INSERT clmcus FROM ls_clmcus ##SUBRC_OK. * <-- There is a problem here
CHECK sy-subrc >= 0.
```
Explanation: Modify only own DB tables. | 1,893 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT lt_sotr_head ASSIGNING <ls_sotr_head>.
DELETE FROM sotr_use WHERE concept = <ls_sotr_head>-concept.
CALL FUNCTION 'BTFR_DELETE_SINGLE_TEXT'
EXPORTING
concept = <ls_sotr_head>-concept
corr_num = gs_inst-transport
use_korrnum_immediatedly = lv_use_korr
flag_string = abap_false
EXCEPTIONS
text_not_found = 1
invalid_package = 2
text_not_changeable = 3
text_enqueued = 4
no_correction = 5
parameter_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
CONTINUE.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM sotr_use WHERE concept = <ls_sotr_head>-concept.
```
Explanation: Modify only own DB tables. | 1,895 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT lt_sotr_head ASSIGNING <ls_sotr_head>.
DELETE FROM sotr_useu WHERE concept = <ls_sotr_head>-concept.
CALL FUNCTION 'BTFR_DELETE_SINGLE_TEXT'
EXPORTING
concept = <ls_sotr_head>-concept
corr_num = gs_inst-transport
use_korrnum_immediatedly = lv_use_korr
flag_string = abap_true
EXCEPTIONS
text_not_found = 1
invalid_package = 2
text_not_changeable = 3
text_enqueued = 4
no_correction = 5
parameter_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
CONTINUE.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM sotr_useu WHERE concept = <ls_sotr_head>-concept.
```
Explanation: Modify only own DB tables. | 1,896 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD _application_log.
DATA:
ls_balobj TYPE balobj,
ls_balobjt TYPE balobjt,
ls_balsub TYPE balsub,
lt_balsub TYPE STANDARD TABLE OF balsub WITH DEFAULT KEY,
ls_balsubt TYPE balsubt,
lt_balsubt TYPE STANDARD TABLE OF balsubt WITH DEFAULT KEY.
SELECT SINGLE object FROM balobj INTO ls_balobj WHERE object = /mbtools/if_definitions=>c_namespace.
IF sy-subrc = 0.
IF gv_force = abap_true OR gv_drop = abap_true.
DELETE FROM balobj WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balobjt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsub WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
DELETE FROM balsubt WHERE object = /mbtools/if_definitions=>c_namespace.
ASSERT sy-subrc >= 0.
ELSE.
RETURN.
ENDIF.
ENDIF.
IF gv_drop = abap_true.
RETURN.
ENDIF.
ls_balobj-object = /mbtools/if_definitions=>c_namespace.
INSERT balobj FROM ls_balobj.
ASSERT sy-subrc >= 0.
ls_balobjt-spras = sy-langu.
ls_balobjt-object = /mbtools/if_definitions=>c_namespace.
ls_balobjt-objtxt = /mbtools/if_definitions=>c_mbt.
INSERT balobjt FROM ls_balobjt.
ASSERT sy-subrc >= 0.
ls_balsub-object = /mbtools/if_definitions=>c_namespace.
ls_balsub-subobject = 'EDD'.
APPEND ls_balsub TO lt_balsub.
ls_balsub-subobject = 'INST'.
APPEND ls_balsub TO lt_balsub.
ls_balsub-subobject = 'LOG'.
APPEND ls_balsub TO lt_balsub.
INSERT balsub FROM TABLE lt_balsub.
ASSERT sy-subrc >= 0.
ls_balsubt-spras = sy-langu.
ls_balsubt-object = /mbtools/if_definitions=>c_namespace.
ls_balsubt-subobject = 'EDD'.
ls_balsubt-subobjtxt = 'Log for EDD API'(002).
APPEND ls_balsubt TO lt_balsubt.
ls_balsubt-subobject = 'INST'.
ls_balsubt-subobjtxt = 'Log for MBT Installer'(003).
APPEND ls_balsubt TO lt_balsubt.
ls_balsubt-subobject = 'LOG'.
ls_balsubt-subobjtxt = 'General Log'(004).
APPEND ls_balsubt TO lt_balsubt.
INSERT balsubt FROM TABLE lt_balsubt.
ASSERT sy-subrc >= 0.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT balobj FROM ls_balobj.
```
Explanation: Modify only own DB tables.
```abap
INSERT balobjt FROM ls_balobjt.
```
Explanation: Modify only own DB tables.
```abap
INSERT balsub FROM TABLE lt_balsub.
```
Explanation: Modify only own DB tables.
```abap
INSERT balsubt FROM TABLE lt_balsubt.
```
Explanation: Modify only own DB tables. | 1,911 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where).
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
ASSIGN rr_data->* TO <lg_tab>.
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where). * <-- There is a problem here
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,912 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab>.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where).
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab>. * <-- There is a problem here
ENDIF.
ENDMETHOD.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,913 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where).
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
TRY.
LOOP AT it_where INTO lv_where.
SELECT * FROM (iv_name) APPENDING TABLE <lg_tab> WHERE (lv_where). * <-- There is a problem here
ENDLOOP.
IF lines( it_where ) = 0.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,916 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab>.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
ENDLOOP.
IF lines( it_where ) = 0.
SELECT * FROM (iv_name) INTO TABLE <lg_tab>. * <-- There is a problem here
ENDIF.
CATCH cx_sy_sql_error INTO lx_sql.
```
Explanation: Potential dangerous statement Dynamic SQL. | 1,917 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_base IMPLEMENTATION.
METHOD convert_attrib_to_vseoattrib.
FIELD-SYMBOLS: <ls_attribute> LIKE LINE OF it_attributes,
<ls_vseoattrib> LIKE LINE OF rt_vseoattrib.
LOOP AT it_attributes ASSIGNING <ls_attribute>.
INSERT INITIAL LINE INTO TABLE rt_vseoattrib ASSIGNING <ls_vseoattrib>.
MOVE-CORRESPONDING <ls_attribute> TO <ls_vseoattrib>.
<ls_vseoattrib>-clsname = iv_clsname.
<ls_vseoattrib>-state = seoc_state_implemented.
<ls_vseoattrib>-exposure = <ls_attribute>-exposure.
UNASSIGN <ls_vseoattrib>.
ENDLOOP.
UNASSIGN <ls_attribute>.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~add_to_activation_list.
zcl_abapgit_objects_activation=>add_item( is_item ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_documentation.
CALL FUNCTION 'DOCU_UPD'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
no_masterlang = iv_no_masterlang
state = c_docu_state_active
TABLES
line = it_lines
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete_documentation.
CALL FUNCTION 'DOCU_DEL'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
typ = 'E'
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from DOCU_DEL' ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_interface_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_skip_test_classes.
rv_skip = mv_skip_test_classes.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_attributes.
SELECT cmpname attbusobj attkeyfld exposure
FROM seocompodf
INTO CORRESPONDING FIELDS OF TABLE rt_attributes
WHERE clsname = iv_object_name
AND ( attbusobj <> space OR attkeyfld <> space )
AND version = '1'
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions_sub.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_documentation.
DATA: lv_state TYPE dokstate,
lt_lines TYPE tlinetab.
CALL FUNCTION 'DOCU_GET'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
version_active_or_last = space " retrieve active version
IMPORTING
dokstate = lv_state
TABLES
line = lt_lines
EXCEPTIONS
no_docu_on_screen = 1
no_docu_self_def = 2
no_docu_temp = 3
ret_code = 4
OTHERS = 5.
IF sy-subrc = 0 AND lv_state = c_docu_state_active.
rt_lines = lt_lines.
ELSE.
CLEAR rt_lines.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_superclass.
SELECT SINGLE refclsname FROM vseoextend INTO rv_superclass
WHERE clsname = iv_classname.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~serialize_abap.
DATA lo_oo_serializer TYPE REF TO zcl_abapgit_oo_serializer.
CREATE OBJECT lo_oo_serializer.
CASE iv_type.
WHEN seop_ext_class_locals_def.
rt_source = lo_oo_serializer->serialize_locals_def( is_class_key ).
WHEN seop_ext_class_locals_imp.
rt_source = lo_oo_serializer->serialize_locals_imp( is_class_key ).
WHEN seop_ext_class_macros.
rt_source = lo_oo_serializer->serialize_macros( is_class_key ).
WHEN seop_ext_class_testclasses.
rt_source = lo_oo_serializer->serialize_testclasses( is_class_key ).
mv_skip_test_classes = lo_oo_serializer->are_test_classes_skipped( ).
WHEN OTHERS.
rt_source = lo_oo_serializer->serialize_abap_clif_source( is_class_key ).
ENDCASE.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions.
DATA lt_descriptions LIKE it_descriptions.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
DELETE FROM seocompotx WHERE clsname = is_key-clsname. "#EC CI_SUBRC
INSERT seocompotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions_sub.
DATA lt_descriptions LIKE it_descriptions.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
DELETE FROM seosubcotx WHERE clsname = is_key-clsname. "#EC CI_SUBRC
INSERT seosubcotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM seocompotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seocompotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM seosubcotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seosubcotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables. | 1,922 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_class IMPLEMENTATION.
METHOD create_report.
INSERT REPORT iv_program FROM it_source EXTENSION TYPE iv_extension STATE iv_version PROGRAM TYPE iv_program_type.
ASSERT sy-subrc = 0.
ENDMETHOD.
METHOD delete_report.
DELETE REPORT iv_program ##SUBRC_OK.
ENDMETHOD.
METHOD determine_method_include.
DATA: ls_mtdkey TYPE seocpdkey.
ls_mtdkey-clsname = iv_name.
ls_mtdkey-cpdname = iv_method.
cl_oo_classname_service=>get_method_include(
EXPORTING
mtdkey = ls_mtdkey
RECEIVING
result = rv_program
EXCEPTIONS
method_not_existing = 1 ).
IF sy-subrc = 0.
RETURN.
ENDIF.
CALL FUNCTION 'SEO_METHOD_GENERATE_INCLUDE'
EXPORTING
suppress_mtdkey_check = abap_true
mtdkey = ls_mtdkey
EXCEPTIONS
not_existing = 1
model_only = 2
include_existing = 3
method_imp_not_generated = 4
method_imp_not_initialised = 5
_internal_class_not_existing = 6
_internal_method_overflow = 7
cancelled = 8
method_is_abstract_implemented = 9
method_is_final_implemented = 10
internal_error_insert_report = 11
OTHERS = 12.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_program = cl_oo_classname_service=>get_method_include( ls_mtdkey ).
ENDMETHOD.
METHOD generate_classpool.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = iv_name.
CALL FUNCTION 'SEO_CLASS_GENERATE_CLASSPOOL'
EXPORTING
clskey = ls_clskey
suppress_corr = abap_true
EXCEPTIONS
not_existing = 1
model_only = 2
class_pool_not_generated = 3
class_stment_not_generated = 4
locals_not_generated = 5
macros_not_generated = 6
public_sec_not_generated = 7
protected_sec_not_generated = 8
private_sec_not_generated = 9
typeref_not_generated = 10
class_pool_not_initialised = 11
class_stment_not_initialised = 12
locals_not_initialised = 13
macros_not_initialised = 14
public_sec_not_initialised = 15
protected_sec_not_initialised = 16
private_sec_not_initialised = 17
typeref_not_initialised = 18
_internal_class_overflow = 19
OTHERS = 20.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD get_method_includes.
" get method includes for implemented interfaces
" this will contain also leftover includes for deleted interface methods
rt_includes = cl_oo_classname_service=>get_all_method_includes( iv_classname ).
ENDMETHOD.
METHOD init_scanner.
DATA: lx_exc TYPE REF TO cx_root,
lv_message TYPE string,
lv_classname TYPE abap_abstypename.
FIELD-SYMBOLS: <lv_line> TYPE i.
TRY.
ro_scanner = cl_oo_source_scanner_class=>create_class_scanner(
clif_name = iv_name
source = it_source ).
ro_scanner->scan( ).
CATCH cx_clif_scan_error.
zcx_abapgit_exception=>raise( 'error initializing CLAS scanner' ).
CATCH cx_root INTO lx_exc.
lv_classname = cl_abap_classdescr=>get_class_name( lx_exc ).
IF lv_classname = '\CLASS=CX_OO_CLIF_SCAN_ERROR_DETAIL'.
ASSIGN lx_exc->('SOURCE_POSITION-LINE') TO <lv_line>.
ASSERT sy-subrc = 0.
lv_message = |{ lx_exc->get_text( ) }, line { <lv_line> }|.
ELSE.
lv_message = lx_exc->get_text( ).
ENDIF.
zcx_abapgit_exception=>raise( lv_message ).
ENDTRY.
ENDMETHOD.
METHOD repair_classpool.
CALL FUNCTION 'SEO_CLASS_REPAIR_CLASSPOOL'
EXPORTING
clskey = is_key
EXCEPTIONS
not_existing = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing class { is_key-clsname }| ).
ENDIF.
ENDMETHOD.
METHOD repair_redefinitions.
" Same logic as SE24 > Utilities > Clean-up > Redefinitions (LSEODCCO)
DATA:
lt_inheritance TYPE vseoextend,
lt_redefinitions TYPE seor_redefinitions_r,
ls_cpdkey TYPE seocpdkey,
lv_tabix TYPE sy-tabix,
lv_exposure TYPE n LENGTH 1,
lv_update TYPE abap_bool,
lv_local_component TYPE abap_bool.
FIELD-SYMBOLS <ls_redef> TYPE seoredef.
CALL FUNCTION 'SEO_CLASS_TYPEINFO_GET'
EXPORTING
clskey = is_key
version = seoc_version_active
IMPORTING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
is_interface = 2
model_only = 3
OTHERS = 4.
IF sy-subrc <> 0.
RETURN.
ENDIF.
" check redefinitions validity
LOOP AT lt_redefinitions ASSIGNING <ls_redef>.
lv_tabix = sy-tabix.
ls_cpdkey-clsname = is_key-clsname.
ls_cpdkey-cpdname = <ls_redef>-mtdname.
CALL FUNCTION 'SEO_COMPONENT_BY_INHERITANCE'
EXPORTING
cpdkey = ls_cpdkey
version = seoc_version_active
IMPORTING
exposure = lv_exposure
is_local_component = lv_local_component
EXCEPTIONS
not_existing = 1
model_only = 2
OTHERS = 3.
IF sy-subrc <> 0.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ELSEIF <ls_redef>-exposure <> lv_exposure.
<ls_redef>-exposure = lv_exposure.
lv_update = abap_true.
ELSEIF lv_local_component = abap_true AND <ls_redef>-attvalue IS INITIAL AND
<ls_redef>-mtdabstrct IS INITIAL AND <ls_redef>-mtdfinal IS INITIAL.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ENDIF.
ENDLOOP.
IF lv_update = abap_true.
CALL FUNCTION 'SEO_INHERITANC_CHANGE_F_DATA'
EXPORTING
save = abap_false
CHANGING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
deleted = 2
is_comprising = 3
is_implementing = 4
not_changed = 5
db_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
CALL FUNCTION 'SEO_CLIF_SAVE_ALL'
EXPORTING
cifkey = is_key
EXCEPTIONS
not_existing = 1
nothing_to_do = 2
access_error = 3
db_error = 4
error_in_code_generation = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD update_cs_number_of_methods.
" Indirect access to keep downward compatibility
DATA lr_cache_entry TYPE REF TO data.
FIELD-SYMBOLS: <lg_cache_entry> TYPE any,
<lg_field> TYPE any.
TRY.
CREATE DATA lr_cache_entry TYPE ('SEO_CS_CACHE').
CATCH cx_sy_create_data_error.
* does not exist in some older systems
RETURN.
ENDTRY.
ASSIGN lr_cache_entry->* TO <lg_cache_entry>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_classname.
ASSIGN COMPONENT 'NO_OF_METHOD_IMPLS' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_number_of_impl_methods.
MODIFY ('SEO_CS_CACHE') FROM <lg_cache_entry>.
ENDMETHOD.
METHOD update_full_class_include.
CONSTANTS: lc_class_source_extension TYPE c LENGTH 2 VALUE 'CS',
lc_include_program_type TYPE c LENGTH 1 VALUE 'I',
lc_active_version TYPE r3state VALUE 'A'.
create_report( iv_program = cl_oo_classname_service=>get_cs_name( iv_classname )
it_source = it_source
iv_extension = lc_class_source_extension
iv_program_type = lc_include_program_type
iv_version = lc_active_version ).
" Assuming that all methods that were scanned are implemented
update_cs_number_of_methods( iv_classname = iv_classname
iv_number_of_impl_methods = lines( it_methods ) ).
ENDMETHOD.
METHOD update_meta.
DATA: lo_update TYPE REF TO cl_oo_class_section_source,
lx_error TYPE REF TO cx_oo_source_save_failure,
ls_clskey TYPE seoclskey,
lv_scan_error TYPE abap_bool.
ls_clskey-clsname = iv_name.
TRY.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = ls_clskey
version = seoc_version_active.
CREATE OBJECT lo_update TYPE ('CL_OO_CLASS_SECTION_SOURCE')
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
source = it_source
suppress_constrctr_generation = abap_true
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3 ##SUBRC_OK.
CATCH cx_sy_dyn_call_param_not_found.
* downport to 702, see https://github.com/abapGit/abapGit/issues/933
* this will READ REPORT instead of using it_source, which should be okay
CREATE OBJECT lo_update TYPE cl_oo_class_section_source
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
lo_update->set_dark_mode( abap_true ).
TRY.
CALL METHOD lo_update->('SET_AMDP_SUPPORT')
EXPORTING
enabled = abap_true.
CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
* AMDP not supported in this system, ignore error
ENDTRY.
lo_update->scan_section_source(
RECEIVING
scan_error = lv_scan_error
EXCEPTIONS
scan_abap_source_error = 1
OTHERS = 2 ).
IF sy-subrc <> 0 OR lv_scan_error = abap_true.
zcx_abapgit_exception=>raise( |CLAS, error while scanning source. Subrc = { sy-subrc }| ).
ENDIF.
* this will update the SEO* database tables
TRY.
lo_update->revert_scan_result( ).
CATCH cx_oo_source_save_failure INTO lx_error.
zcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
IF iv_exposure = seoc_exposure_public.
generate_classpool( iv_name ).
ENDIF.
ENDMETHOD.
METHOD update_report.
DATA: lt_old TYPE string_table.
READ REPORT iv_program INTO lt_old.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Fatal error. Include { iv_program } should have been created previously!| ).
ENDIF.
IF lt_old <> it_source.
INSERT REPORT iv_program FROM it_source.
ASSERT sy-subrc = 0.
rv_updated = abap_true.
ELSE.
rv_updated = abap_false.
ENDIF.
ENDMETHOD.
METHOD update_source_index.
CONSTANTS:
lc_version_active TYPE r3state VALUE 'A',
lc_version_inactive TYPE r3state VALUE 'I'.
" dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA lo_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT lo_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname
version = lc_version_active
scanner = io_scanner.
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname
version = lc_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
RETURN.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
DATA:
lt_vseoattrib TYPE seoo_attributes_r,
ls_class_key TYPE seoclskey,
ls_properties TYPE vseoclass,
lt_attributes TYPE zif_abapgit_definitions=>ty_obj_attribute_tt.
FIELD-SYMBOLS: <lv_clsname> TYPE seoclsname.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE cg_properties TO <lv_clsname>.
ASSERT sy-subrc = 0.
" Get existing class properties and attributes and check if the class
" needs to be created/updated (or is the same)
IF iv_check = abap_true.
ls_class_key-clsname = <lv_clsname>.
ls_properties = zif_abapgit_oo_object_fnc~get_class_properties( ls_class_key ).
lt_attributes = zif_abapgit_oo_object_fnc~read_attributes( <lv_clsname> ).
IF ls_properties = cg_properties AND lt_attributes = it_attributes.
RETURN.
ENDIF.
ENDIF.
lt_vseoattrib = convert_attrib_to_vseoattrib(
iv_clsname = <lv_clsname>
it_attributes = it_attributes ).
" Hardcode STATE (#2612)
ls_properties = cg_properties.
ls_properties-state = seoc_state_implemented.
TRY.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
suppress_dialog = abap_true " Parameter missing in 702
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
zcl_abapgit_sotr_handler=>create_sotr(
iv_package = iv_package
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>create_sots(
iv_package = iv_package
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
" SEO_CLASS_DELETE_COMPLETE deletes OTR usage, only
" Use handler to also delete OTR header and texts
zcl_abapgit_sotr_handler=>delete_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
zcl_abapgit_sots_handler=>delete_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
CALL FUNCTION 'SEO_CLASS_DELETE_COMPLETE'
EXPORTING
clskey = is_deletion_key
EXCEPTIONS
not_existing = 1
is_interface = 2
db_error = 3
no_access = 4
other = 5
OTHERS = 6.
IF sy-subrc = 1.
* ignore deletion of objects that does not exist
* this can happen when the SXCI object is deleted before the implementing CLAS
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
DATA: lv_updated TYPE abap_bool,
lv_program TYPE program,
lo_scanner TYPE REF TO cl_oo_source_scanner_class,
lt_methods TYPE cl_oo_source_scanner_class=>type_method_implementations,
lt_incls TYPE seop_methods_w_include,
lv_method LIKE LINE OF lt_methods,
lt_public TYPE seop_source_string,
lt_source TYPE seop_source_string.
"Buffer needs to be refreshed,
"otherwise standard SAP CLIF_SOURCE reorder methods alphabetically
CALL FUNCTION 'SEO_BUFFER_INIT'.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = is_key
version = seoc_version_inactive.
lo_scanner = init_scanner(
it_source = it_source
iv_name = is_key-clsname ).
* public
lt_public = lo_scanner->get_public_section_source( ).
IF lt_public IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_pubsec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
it_source = lt_public ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_public
it_source = lt_public ).
ENDIF.
ENDIF.
* protected
lt_source = lo_scanner->get_protected_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prosec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_protected
it_source = lt_source ).
ENDIF.
ENDIF.
* private
lt_source = lo_scanner->get_private_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prisec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_private
it_source = lt_source ).
ENDIF.
ENDIF.
* methods
lt_methods = lo_scanner->get_method_implementations( ).
lt_incls = get_method_includes( is_key-clsname ).
LOOP AT lt_methods INTO lv_method.
TRY.
lt_source = lo_scanner->get_method_impl_source( lv_method ).
CATCH cx_oo_clif_component.
zcx_abapgit_exception=>raise( 'error from GET_METHOD_IMPL_SOURCE' ).
ENDTRY.
lv_program = determine_method_include(
iv_name = is_key-clsname
iv_method = lv_method ).
update_report(
iv_program = lv_program
it_source = lt_source ).
" If method was implemented before, remove from list
DELETE lt_incls WHERE cpdkey-clsname = is_key-clsname AND cpdkey-cpdname = lv_method.
ENDLOOP.
* full class include
update_full_class_include( iv_classname = is_key-clsname
it_source = it_source
it_methods = lt_methods ).
" If there are leftover method includes, then class needs to be repaired
" which will delete the obsolete includes
IF lt_incls IS NOT INITIAL.
repair_classpool( is_key ).
repair_redefinitions( is_key ).
ENDIF.
update_source_index(
iv_clsname = is_key-clsname
io_scanner = lo_scanner ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = is_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2
is_interface = 3
no_text = 4
inconsistent = 5
OTHERS = 6.
rv_exists = boolc( sy-subrc = 0 OR sy-subrc = 4 ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
DATA: lv_program TYPE programm.
IF lines( it_local_definitions ) > 0.
lv_program = cl_oo_classname_service=>get_ccdef_name( is_key-clsname ).
update_report( iv_program = lv_program
it_source = it_local_definitions ).
ENDIF.
IF lines( it_local_implementations ) > 0.
lv_program = cl_oo_classname_service=>get_ccimp_name( is_key-clsname ).
update_report( iv_program = lv_program
it_source = it_local_implementations ).
ENDIF.
IF lines( it_local_macros ) > 0.
lv_program = cl_oo_classname_service=>get_ccmac_name( is_key-clsname ).
update_report( iv_program = lv_program
it_source = it_local_macros ).
ENDIF.
lv_program = cl_oo_classname_service=>get_ccau_name( is_key-clsname ).
IF lines( it_local_test_classes ) > 0.
update_report( iv_program = lv_program
it_source = it_local_test_classes ).
ELSE.
" Drop the include to remove left-over test classes
delete_report( lv_program ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
CALL FUNCTION 'SEO_CLIF_GET'
EXPORTING
cifkey = is_class_key
version = seoc_version_active
IMPORTING
class = rs_class_properties
EXCEPTIONS
not_existing = 1
deleted = 2
model_only = 3
OTHERS = 4.
IF sy-subrc = 1.
RETURN. " in case only inactive version exists
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR:
" TODO 2023-08-01: Clear rs_class_properties-state (#2612)
rs_class_properties-uuid,
rs_class_properties-author,
rs_class_properties-createdon,
rs_class_properties-changedby,
rs_class_properties-changedon,
rs_class_properties-r3release,
rs_class_properties-chgdanyby,
rs_class_properties-chgdanyon,
rs_class_properties-clsfinal,
rs_class_properties-clsabstrct,
rs_class_properties-exposure,
rs_class_properties-version.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
* note: includes returned might not exist
* method cl_oo_classname_service=>GET_ALL_CLASS_INCLUDES does not exist in 702
DATA: lv_class_name TYPE seoclsname,
lt_methods TYPE seop_methods_w_include.
FIELD-SYMBOLS: <ls_method> LIKE LINE OF lt_methods.
lv_class_name = iv_object_name.
APPEND cl_oo_classname_service=>get_ccdef_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccmac_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccimp_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_cl_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccau_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_pubsec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prosec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prisec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_classpool_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ct_name( lv_class_name ) TO rt_includes.
* skip the CS include, as it is sometimes generated on the fly instead of
* when the methods are changed
cl_oo_classname_service=>get_all_method_includes(
EXPORTING
clsname = lv_class_name
RECEIVING
result = lt_methods
EXCEPTIONS
class_not_existing = 1 ).
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Class { lv_class_name } not existing| ).
ENDIF.
LOOP AT lt_methods ASSIGNING <ls_method>.
APPEND <ls_method>-incname TO rt_includes.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
INSERT TEXTPOOL lv_cp
FROM it_text_pool
LANGUAGE iv_language
STATE iv_state.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
zcl_abapgit_objects_activation=>add( iv_type = 'REPT'
iv_name = lv_cp ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
zcl_abapgit_sotr_handler=>read_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>read_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
READ TEXTPOOL lv_cp INTO rt_text_pool LANGUAGE iv_language. "#EC CI_READ_REP
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INSERT TEXTPOOL lv_cp
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,924 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
ls_t100 TYPE t100,
lt_t100t TYPE TABLE OF t100t,
lt_t100_texts TYPE ty_t100_texts,
lt_t100u TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100_text> TYPE ty_t100_text.
lv_msg_id = ms_item-obj_name.
SELECT * FROM t100u INTO TABLE lt_t100u
WHERE arbgb = lv_msg_id ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
ii_xml->read( EXPORTING iv_name = 'T100_TEXTS'
CHANGING cg_data = lt_t100_texts ).
ii_xml->read( EXPORTING iv_name = 'T100T'
CHANGING cg_data = lt_t100t ).
zcl_abapgit_lxe_texts=>trim_tab_w_saplang_by_iso(
EXPORTING
it_iso_filter = ii_xml->i18n_params( )-translation_languages
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100_texts ).
zcl_abapgit_lxe_texts=>trim_tab_w_saplang_by_iso(
EXPORTING
it_iso_filter = ii_xml->i18n_params( )-translation_languages
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100t ).
MODIFY t100t FROM TABLE lt_t100t. "#EC CI_SUBRC
LOOP AT lt_t100_texts ASSIGNING <ls_t100_text>.
"check if message exists
READ TABLE lt_t100u TRANSPORTING NO FIELDS
WITH KEY arbgb = lv_msg_id msgnr = <ls_t100_text>-msgnr BINARY SEARCH.
CHECK sy-subrc = 0. "if original message doesn't exist no translations added
MOVE-CORRESPONDING <ls_t100_text> TO ls_t100.
ls_t100-arbgb = lv_msg_id.
MODIFY t100 FROM ls_t100.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY t100t FROM TABLE lt_t100t.
```
Explanation: Modify only own DB tables. | 1,935 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_msag IMPLEMENTATION.
METHOD delete_documentation.
DATA: lv_key_s TYPE dokhl-object.
CLEAR lv_key_s.
CALL FUNCTION 'DOCU_OBJECT_NAME_CONCATENATE'
EXPORTING
docu_id = c_longtext_id_msag
element = iv_message_id
addition = ' '
IMPORTING
object = lv_key_s
EXCEPTIONS
OTHERS = 0.
CALL FUNCTION 'DOKU_DELETE_ALL'
EXPORTING
doku_id = c_longtext_id_msag
doku_object = lv_key_s
generic_use = 'X'
suppress_authority = space
suppress_enqueue = space
suppress_transport = space
EXCEPTIONS
header_without_text = 1
index_without_header = 2
no_authority_for_devclass_xxxx = 3
no_docu_found = 4
object_is_already_enqueued = 5
object_is_enqueued_by_corr = 6
user_break = 7.
ENDMETHOD.
METHOD delete_msgid.
delete_documentation( iv_message_id ).
DELETE FROM t100a WHERE arbgb = iv_message_id.
IF sy-subrc = 0 OR sy-subrc = 4.
CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
EXPORTING
object = iv_message_id
operation = 'DELETE'
program = space
type = 'CN'.
DELETE FROM t100o WHERE arbgb = iv_message_id.
DELETE FROM t100t WHERE arbgb = iv_message_id. "#EC CI_NOFIRST
DELETE FROM t100u WHERE arbgb = iv_message_id.
DELETE FROM t100x WHERE arbgb = iv_message_id.
DELETE FROM t100 WHERE arbgb = iv_message_id.
ENDIF.
ENDMETHOD.
METHOD deserialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
ls_t100 TYPE t100,
lt_t100t TYPE TABLE OF t100t,
lt_t100_texts TYPE ty_t100_texts,
lt_t100u TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100_text> TYPE ty_t100_text.
lv_msg_id = ms_item-obj_name.
SELECT * FROM t100u INTO TABLE lt_t100u
WHERE arbgb = lv_msg_id ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
ii_xml->read( EXPORTING iv_name = 'T100_TEXTS'
CHANGING cg_data = lt_t100_texts ).
ii_xml->read( EXPORTING iv_name = 'T100T'
CHANGING cg_data = lt_t100t ).
zcl_abapgit_lxe_texts=>trim_tab_w_saplang_by_iso(
EXPORTING
it_iso_filter = ii_xml->i18n_params( )-translation_languages
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100_texts ).
zcl_abapgit_lxe_texts=>trim_tab_w_saplang_by_iso(
EXPORTING
it_iso_filter = ii_xml->i18n_params( )-translation_languages
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100t ).
MODIFY t100t FROM TABLE lt_t100t. "#EC CI_SUBRC
LOOP AT lt_t100_texts ASSIGNING <ls_t100_text>.
"check if message exists
READ TABLE lt_t100u TRANSPORTING NO FIELDS
WITH KEY arbgb = lv_msg_id msgnr = <ls_t100_text>-msgnr BINARY SEARCH.
CHECK sy-subrc = 0. "if original message doesn't exist no translations added
MOVE-CORRESPONDING <ls_t100_text> TO ls_t100.
ls_t100-arbgb = lv_msg_id.
MODIFY t100 FROM ls_t100.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD free_access_permission.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = iv_message_id
object_class = 'T100'.
ENDMETHOD.
METHOD serialize_longtexts_msag.
DATA: lv_doku_object_name TYPE dokhl-object,
lt_doku_object_names TYPE STANDARD TABLE OF dokhl-object
WITH NON-UNIQUE DEFAULT KEY,
lt_dokil TYPE zif_abapgit_definitions=>ty_dokil_tt,
ls_dokil LIKE LINE OF lt_dokil,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
FIELD-SYMBOLS: <ls_t100> TYPE t100.
IF lines( it_t100 ) = 0.
RETURN.
ENDIF.
LOOP AT it_t100 ASSIGNING <ls_t100>.
lv_doku_object_name = <ls_t100>-arbgb && <ls_t100>-msgnr.
INSERT lv_doku_object_name INTO TABLE lt_doku_object_names.
ENDLOOP.
IF ii_xml->i18n_params( )-main_language_only = abap_true.
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND masterlang = abap_true
ORDER BY PRIMARY KEY.
ELSE.
lt_language_filter = zcl_abapinst_factory=>get_environment( )->get_system_language_filter( ).
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND langu IN lt_language_filter
ORDER BY PRIMARY KEY.
ENDIF.
CLEAR ls_dokil-dokstate.
MODIFY lt_dokil FROM ls_dokil TRANSPORTING dokstate WHERE dokstate IS NOT INITIAL.
IF lines( lt_dokil ) > 0.
serialize_longtexts( ii_xml = ii_xml
it_dokil = lt_dokil ).
ENDIF.
ENDMETHOD.
METHOD serialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
lt_t100_texts TYPE ty_t100_texts,
lt_t100t TYPE TABLE OF t100t,
lt_i18n_langs TYPE TABLE OF langu,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
lv_msg_id = ms_item-obj_name.
IF ii_xml->i18n_params( )-main_language_only = abap_true.
RETURN. " skip
ENDIF.
" Collect additional languages
" Skip main lang - it has been already serialized and also technical languages
lt_language_filter = zcl_abapinst_factory=>get_environment( )->get_system_language_filter( ).
zcl_abapgit_lxe_texts=>add_iso_langs_to_lang_filter(
EXPORTING it_iso_filter = ii_xml->i18n_params( )-translation_languages
CHANGING ct_language_filter = lt_language_filter ).
SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs
FROM t100t
WHERE arbgb = lv_msg_id
AND sprsl IN lt_language_filter
AND sprsl <> mv_language. "#EC CI_BYPASS "#EC CI_GENBUFF
SORT lt_i18n_langs ASCENDING.
IF lines( lt_i18n_langs ) > 0.
SELECT * FROM t100t INTO CORRESPONDING FIELDS OF TABLE lt_t100t
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id. "#EC CI_GENBUFF
SELECT * FROM t100 INTO CORRESPONDING FIELDS OF TABLE lt_t100_texts
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
SORT lt_t100t BY sprsl ASCENDING.
SORT lt_t100_texts BY sprsl msgnr ASCENDING.
ii_xml->add( iv_name = 'I18N_LANGS'
ig_data = lt_i18n_langs ).
ii_xml->add( iv_name = 'T100T'
ig_data = lt_t100t ).
ii_xml->add( iv_name = 'T100_TEXTS'
ig_data = lt_t100_texts ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE lastuser FROM t100a INTO rv_user
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0 OR rv_user = ''.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_t100a TYPE t100a,
lv_frozen TYPE abap_bool,
lv_message_id TYPE arbgb.
* parameter SUPPRESS_DIALOG doesnt exist in all versions of FM RS_DELETE_MESSAGE_ID
* replaced with a copy
lv_message_id = ms_item-obj_name.
IF ms_item-obj_name = space.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."blank message id
ENDIF.
SELECT SINGLE * FROM t100a INTO ls_t100a WHERE arbgb = ms_item-obj_name.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."not found
ENDIF.
CLEAR lv_frozen.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
authority_check = 'X'
global_lock = 'X'
mode = 'MODIFY'
object = lv_message_id
object_class = 'T100'
IMPORTING
frozen = lv_frozen
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0 OR lv_frozen <> space.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
zcl_abapinst_factory=>get_cts_api( )->insert_transport_object(
iv_object = 'MSAG'
iv_obj_name = lv_message_id
iv_package = iv_package
iv_language = mv_language
iv_mode = zif_abapgit_cts_api=>c_transport_mode-delete ).
delete_msgid( lv_message_id ).
free_access_permission( lv_message_id ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
* fm RPY_MESSAGE_ID_INSERT almost works, but not in older versions
DATA: ls_t100a TYPE t100a,
ls_t100t TYPE t100t,
ls_t100u TYPE t100u,
lt_t100 TYPE TABLE OF t100,
lt_before TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100> LIKE LINE OF lt_t100.
io_xml->read( EXPORTING iv_name = 'T100A'
CHANGING cg_data = ls_t100a ).
io_xml->read( EXPORTING iv_name = 'T100'
CHANGING cg_data = lt_t100 ).
corr_insert( iv_package ).
SELECT * FROM t100u INTO TABLE lt_before
WHERE arbgb = ls_t100a-arbgb ORDER BY msgnr. "#EC CI_GENBUFF "#EC CI_BYPASS
LOOP AT lt_t100 ASSIGNING <ls_t100>.
DELETE lt_before WHERE msgnr = <ls_t100>-msgnr.
MODIFY t100 FROM <ls_t100>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
CLEAR ls_t100u.
MOVE-CORRESPONDING <ls_t100> TO ls_t100u ##ENH_OK.
ls_t100u-name = sy-uname.
ls_t100u-datum = sy-datum.
ls_t100u-selfdef = '3'.
MODIFY t100u FROM ls_t100u.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100U modify failed' ).
ENDIF.
ENDLOOP.
ls_t100a-masterlang = mv_language.
ls_t100a-lastuser = sy-uname.
ls_t100a-respuser = sy-uname.
ls_t100a-ldate = sy-datum.
ls_t100a-ltime = sy-uzeit.
MODIFY t100a FROM ls_t100a.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100A modify failed' ).
ENDIF.
ls_t100t-sprsl = mv_language.
ls_t100t-arbgb = ls_t100a-arbgb.
ls_t100t-stext = ls_t100a-stext.
MODIFY t100t FROM ls_t100t.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100T modify failed' ).
ENDIF.
LOOP AT lt_before INTO ls_t100u.
DELETE FROM t100 WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
DELETE FROM t100u WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
ENDLOOP.
deserialize_longtexts( ii_xml = io_xml
iv_longtext_id = c_longtext_id_msag ).
IF io_xml->i18n_params( )-translation_languages IS INITIAL OR io_xml->i18n_params( )-use_lxe = abap_false.
deserialize_texts( io_xml ).
ELSE.
deserialize_lxe_texts( io_xml ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_arbgb TYPE t100a-arbgb.
SELECT SINGLE arbgb FROM t100a INTO lv_arbgb
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
DATA: lv_argument TYPE seqg3-garg.
lv_argument = |{ ms_item-obj_name }|.
OVERLAY lv_argument WITH ' '.
lv_argument = lv_argument && '*'.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = |ES_MSGSI|
iv_argument = lv_argument ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Covered by zcl_abapinst_objects=>JUMP
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: lv_msg_id TYPE rglif-message_id,
ls_inf TYPE t100a,
lt_source TYPE ty_t100s.
lv_msg_id = ms_item-obj_name.
SELECT SINGLE * FROM t100a INTO ls_inf
WHERE arbgb = lv_msg_id. "#EC CI_GENBUFF
IF sy-subrc <> 0.
RETURN.
ENDIF.
CLEAR ls_inf-respuser.
SELECT * FROM t100 INTO TABLE lt_source
WHERE sprsl = mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
CLEAR: ls_inf-lastuser,
ls_inf-ldate,
ls_inf-ltime.
io_xml->add( iv_name = 'T100A'
ig_data = ls_inf ).
io_xml->add( ig_data = lt_source
iv_name = 'T100' ).
serialize_longtexts_msag( it_t100 = lt_source
ii_xml = io_xml ).
IF io_xml->i18n_params( )-translation_languages IS INITIAL OR io_xml->i18n_params( )-use_lxe = abap_false.
serialize_texts( io_xml ).
ELSE.
serialize_lxe_texts( io_xml ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
MODIFY t100a FROM ls_t100a.
```
Explanation: Modify only own DB tables.
```abap
MODIFY t100t FROM ls_t100t.
```
Explanation: Modify only own DB tables. | 1,938 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_nspc IMPLEMENTATION.
METHOD add_to_transport.
DATA: li_sap_package TYPE REF TO zif_abapgit_sap_package.
li_sap_package = zcl_abapinst_factory=>get_sap_package( iv_package ).
IF li_sap_package->are_changes_recorded_in_tr_req( ) = abap_true.
corr_insert( iv_package ).
ENDIF.
ENDMETHOD.
METHOD deserialize_texts.
DATA:
ls_trnspacett TYPE trnspacett,
lt_i18n_langs TYPE TABLE OF langu,
lt_nspc_texts TYPE ty_nspc_texts.
FIELD-SYMBOLS:
<lv_lang> LIKE LINE OF lt_i18n_langs,
<ls_nspc_text> LIKE LINE OF lt_nspc_texts.
ii_xml->read( EXPORTING iv_name = 'I18N_LANGS'
CHANGING cg_data = lt_i18n_langs ).
ii_xml->read( EXPORTING iv_name = 'NSPC_TEXTS'
CHANGING cg_data = lt_nspc_texts ).
SORT lt_i18n_langs.
SORT lt_nspc_texts BY spras. " Optimization
LOOP AT lt_i18n_langs ASSIGNING <lv_lang>.
ls_trnspacett-namespace = iv_namespace.
READ TABLE lt_nspc_texts ASSIGNING <ls_nspc_text> WITH KEY spras = <lv_lang>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |NSPC_TEXTS cannot find lang { <lv_lang> } in XML| ).
ENDIF.
MOVE-CORRESPONDING <ls_nspc_text> TO ls_trnspacett.
MODIFY trnspacett FROM ls_trnspacett.
IF sy-subrc <> 0.
INSERT trnspacett FROM ls_trnspacett.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting text for namespace| ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD serialize_texts.
DATA:
ls_trnspacett TYPE trnspacett,
lt_nspc_texts TYPE ty_nspc_texts,
lt_i18n_langs TYPE TABLE OF langu.
FIELD-SYMBOLS:
<lv_lang> LIKE LINE OF lt_i18n_langs,
<ls_nspc_text> LIKE LINE OF lt_nspc_texts.
IF ii_xml->i18n_params( )-main_language_only = abap_true.
RETURN.
ENDIF.
" Collect additional languages, skip main lang - it was serialized already
SELECT DISTINCT spras AS langu FROM trnspacett INTO TABLE lt_i18n_langs
WHERE namespace = ms_item-obj_name AND spras <> mv_language. "#EC CI_SUBRC
LOOP AT lt_i18n_langs ASSIGNING <lv_lang>.
SELECT SINGLE * FROM trnspacett INTO ls_trnspacett
WHERE namespace = ms_item-obj_name AND spras = <lv_lang>.
IF sy-subrc = 0.
APPEND INITIAL LINE TO lt_nspc_texts ASSIGNING <ls_nspc_text>.
MOVE-CORRESPONDING ls_trnspacett TO <ls_nspc_text>.
ENDIF.
ENDLOOP.
SORT lt_i18n_langs ASCENDING.
SORT lt_nspc_texts BY spras ASCENDING.
IF lines( lt_i18n_langs ) > 0.
ii_xml->add( iv_name = 'I18N_LANGS'
ig_data = lt_i18n_langs ).
ii_xml->add( iv_name = 'NSPC_TEXTS'
ig_data = lt_nspc_texts ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE changeuser FROM trnspacet INTO rv_user
WHERE namespace = ms_item-obj_name.
IF sy-subrc <> 0.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
RETURN. " not supported
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA:
ls_nspc TYPE ty_nspc,
ls_nspc_text TYPE ty_nspc_text,
lv_modifiable TYPE abap_bool,
ls_trnspacet TYPE trnspacet,
ls_trnspacett TYPE trnspacett.
io_xml->read( EXPORTING iv_name = 'NSPC'
CHANGING cg_data = ls_nspc ).
io_xml->read( EXPORTING iv_name = 'NSPC_TEXT'
CHANGING cg_data = ls_nspc_text ).
add_to_transport( iv_package ).
SELECT SINGLE * FROM trnspacet INTO ls_trnspacet WHERE namespace = ls_nspc-namespace.
IF sy-subrc = 0.
" For existing namespace, check if it's modifiable (SE03)
SELECT SINGLE editflag FROM trnspace INTO lv_modifiable WHERE namespace = ls_nspc-namespace.
IF sy-subrc = 0 AND lv_modifiable = abap_false.
zcx_abapgit_exception=>raise( |Namespace is not modifiable| ).
ENDIF.
" keep existing role
ls_trnspacet-replicense = ls_nspc-replicense.
ls_trnspacet-sscrflag = ls_nspc-sscrflag.
ls_trnspacet-sapflag = ls_nspc-sapflag.
ls_trnspacet-gen_only = ls_nspc-gen_only.
ls_trnspacet-changeuser = sy-uname.
ls_trnspacet-changedate = sy-datum.
MODIFY trnspacet FROM ls_trnspacet.
ELSE.
MOVE-CORRESPONDING ls_nspc TO ls_trnspacet.
ls_trnspacet-role = 'C'. " customer repair license
ls_trnspacet-changeuser = sy-uname.
ls_trnspacet-changedate = sy-datum.
INSERT trnspacet FROM ls_trnspacet.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting namespace| ).
ENDIF.
SELECT SINGLE * FROM trnspacett INTO ls_trnspacett
WHERE namespace = ls_nspc-namespace AND spras = mv_language.
IF sy-subrc = 0.
ls_trnspacett-descriptn = ls_nspc_text-descriptn.
ls_trnspacett-owner = ls_nspc_text-owner.
MODIFY trnspacett FROM ls_trnspacett.
ELSE.
MOVE-CORRESPONDING ls_nspc_text TO ls_trnspacett.
ls_trnspacett-namespace = ls_nspc-namespace.
INSERT trnspacett FROM ls_trnspacett.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error upserting text for namespace| ).
ENDIF.
deserialize_texts( ii_xml = io_xml
iv_namespace = ls_nspc-namespace ).
" Fill trnspace and trnspacel tables
CALL FUNCTION 'TR_ACTIVATE_NAMESPACE'
EXPORTING
iv_namespace = ls_nspc-namespace
EXCEPTIONS
deletion_not_allowed = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error activating namespace| ).
ENDIF.
" Make namespace modifiable
UPDATE trnspace SET editflag = abap_true WHERE namespace = ls_nspc-namespace.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA lv_namespace TYPE trnspace-namespace.
lv_namespace = ms_item-obj_name.
CALL FUNCTION 'TR_CHECK_NAMESPACE'
EXPORTING
iv_namespace = lv_namespace
EXCEPTIONS
namespace_not_valid = 1
OTHERS = 2.
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = zif_abapgit_object~exists( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Launch general maintenance for namespaces
CALL FUNCTION 'VIEW_MAINTENANCE_CALL'
EXPORTING
action = 'S'
view_name = 'V_TRNSPACE'
no_warning_for_clientindep = 'X'
variant_for_selection = 'STANDARD'
EXCEPTIONS
client_reference = 1
foreign_lock = 2
invalid_action = 3
no_clientindependent_auth = 4
no_database_function = 5
no_editor_function = 6
no_show_auth = 7
no_tvdir_entry = 8
no_upd_auth = 9
only_show_allowed = 10
system_failure = 11
unknown_field_in_dba_sellist = 12
view_not_found = 13
OTHERS = 14.
rv_exit = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA:
ls_nspc TYPE ty_nspc,
ls_nspc_text TYPE ty_nspc_text.
SELECT SINGLE * FROM trnspacet INTO CORRESPONDING FIELDS OF ls_nspc
WHERE namespace = ms_item-obj_name.
SELECT SINGLE * FROM trnspacett INTO CORRESPONDING FIELDS OF ls_nspc_text
WHERE namespace = ms_item-obj_name AND spras = mv_language.
io_xml->add( iv_name = 'NSPC'
ig_data = ls_nspc ).
io_xml->add( iv_name = 'NSPC_TEXT'
ig_data = ls_nspc_text ).
serialize_texts( io_xml ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
MODIFY trnspacet FROM ls_trnspacet.
```
Explanation: Modify only own DB tables.
```abap
INSERT trnspacet FROM ls_trnspacet.
```
Explanation: Modify only own DB tables.
```abap
ls_trnspacett-namespace = ls_nspc-namespace.
INSERT trnspacett FROM ls_trnspacett. * <-- There is a problem here
ENDIF.
```
Explanation: Modify only own DB tables.
```abap
UPDATE trnspace SET editflag = abap_true WHERE namespace = ls_nspc-namespace.
```
Explanation: Modify only own DB tables. | 1,942 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_para IMPLEMENTATION.
METHOD unlock.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = iv_paramid
object_class = 'PARA'.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
* looks like "changed by user" is not stored in the database
rv_user = c_user_unknown.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
" We can't use FM RS_PARAMETER_DELETE because of the popup to confirm
"Therefore we have to reimplement most of the FMs logic
DATA: lv_paramid TYPE tpara-paramid,
ls_transpkey TYPE trkey.
lv_paramid = ms_item-obj_name.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
global_lock = abap_true
language_upd_exit = 'RS_PARAMETER_LANGUAGE_EXIT' " Name FuBa for maintenance language change
object = lv_paramid
object_class = ms_item-obj_type
suppress_language_check = space
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
SELECT COUNT(*) FROM cross
WHERE ( type = 'P' OR type = 'Q' ) AND name = lv_paramid.
IF sy-subrc = 0.
unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ELSE.
SELECT COUNT(*) FROM dd04l BYPASSING BUFFER
WHERE memoryid = lv_paramid
AND as4local = 'A'.
IF sy-subrc = 0.
unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ENDIF.
ENDIF.
unlock( lv_paramid ).
zcl_abapinst_factory=>get_cts_api( )->insert_transport_object(
iv_object = 'PARA'
iv_obj_name = lv_paramid
iv_package = iv_package
iv_language = mv_language
iv_mode = zif_abapgit_cts_api=>c_transport_mode-delete ).
DELETE FROM tpara WHERE paramid = lv_paramid.
DELETE FROM tparat WHERE paramid = lv_paramid.
CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
EXPORTING
object = lv_paramid
operation = 'DELETE'
type = 'CR'.
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
* see fm RS_PARAMETER_ADD and RS_PARAMETER_EDIT
DATA: lv_mode TYPE c LENGTH 1,
ls_tpara TYPE tpara,
ls_tparat TYPE tparat.
SELECT SINGLE * FROM tpara INTO ls_tpara
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc = 0.
lv_mode = 'M'.
ELSE.
lv_mode = 'I'.
ENDIF.
io_xml->read( EXPORTING iv_name = 'TPARA'
CHANGING cg_data = ls_tpara ).
CALL FUNCTION 'RS_CORR_INSERT'
EXPORTING
object = ms_item-obj_name
object_class = 'PARA'
mode = lv_mode
global_lock = abap_true
devclass = iv_package
master_language = mv_language
suppress_dialog = abap_true
EXCEPTIONS
cancelled = 1
permission_failure = 2
unknown_objectclass = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
MODIFY tpara FROM ls_tpara. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
io_xml->read(
EXPORTING iv_name = 'TPARAT'
CHANGING cg_data = ls_tparat ).
MODIFY tparat FROM ls_tparat. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
IF io_xml->i18n_params( )-translation_languages IS NOT INITIAL AND io_xml->i18n_params( )-use_lxe = abap_true.
deserialize_lxe_texts( io_xml ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_paramid TYPE tpara-paramid.
SELECT SINGLE paramid FROM tpara INTO lv_paramid
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-ddic TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
DATA: lv_argument TYPE seqg3-garg.
lv_argument = |PA{ ms_item-obj_name }|.
OVERLAY lv_argument WITH ' '.
lv_argument = lv_argument && '*'.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'EEUDB'
iv_argument = lv_argument ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Covered by zcl_abapinst_objects=>JUMP
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_tpara TYPE tpara,
ls_tparat TYPE tparat.
SELECT SINGLE * FROM tpara INTO ls_tpara
WHERE paramid = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0.
RETURN.
ENDIF.
SELECT SINGLE * FROM tparat INTO ls_tparat
WHERE paramid = ms_item-obj_name
AND sprache = mv_language. "#EC CI_GENBUFF "#EC CI_SUBRC
io_xml->add( iv_name = 'TPARA'
ig_data = ls_tpara ).
io_xml->add(
iv_name = 'TPARAT'
ig_data = ls_tparat ).
" Here only the original language is serialized,
" so it should be present for the moment. LXEs are just translations
IF io_xml->i18n_params( )-translation_languages IS NOT INITIAL AND io_xml->i18n_params( )-use_lxe = abap_true.
serialize_lxe_texts( io_xml ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM tpara WHERE paramid = lv_paramid.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM tparat WHERE paramid = lv_paramid.
```
Explanation: Modify only own DB tables.
```abap
MODIFY tpara FROM ls_tpara.
```
Explanation: Modify only own DB tables.
```abap
MODIFY tparat FROM ls_tparat.
```
Explanation: Modify only own DB tables. | 1,944 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_tobj IMPLEMENTATION.
METHOD delete_extra.
DELETE FROM tddat WHERE tabname = iv_tabname.
DELETE FROM tvdir WHERE tabname = iv_tabname.
DELETE FROM tvimf WHERE tabname = iv_tabname.
ENDMETHOD.
METHOD read_extra.
SELECT SINGLE * FROM tddat INTO rs_tobj-tddat WHERE tabname = iv_tabname.
SELECT SINGLE * FROM tvdir INTO rs_tobj-tvdir WHERE tabname = iv_tabname.
CLEAR: rs_tobj-tvdir-gendate, rs_tobj-tvdir-gentime, rs_tobj-tvdir-devclass.
SELECT * FROM tvimf INTO TABLE rs_tobj-tvimf WHERE tabname = iv_tabname
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD update_extra.
DATA: lt_current_tvimf TYPE STANDARD TABLE OF tvimf.
FIELD-SYMBOLS: <ls_tvimf> TYPE tvimf.
MODIFY tddat FROM is_tobj-tddat.
MODIFY tvdir FROM is_tobj-tvdir.
SELECT * INTO TABLE lt_current_tvimf
FROM tvimf
WHERE tabname = is_tobj-tddat-tabname
ORDER BY PRIMARY KEY.
LOOP AT lt_current_tvimf ASSIGNING <ls_tvimf>.
READ TABLE is_tobj-tvimf WITH KEY tabname = <ls_tvimf>-tabname
event = <ls_tvimf>-event
TRANSPORTING NO FIELDS.
IF sy-subrc <> 0.
DELETE FROM tvimf
WHERE tabname = <ls_tvimf>-tabname
AND event = <ls_tvimf>-event.
ENDIF.
ENDLOOP.
MODIFY tvimf FROM TABLE is_tobj-tvimf.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
DATA: lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE luser FROM objh INTO rv_user
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
IF sy-subrc <> 0.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_objh TYPE objh,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
IF ls_objh-objecttype = 'L'.
zcx_abapgit_exception=>raise( |Use transaction SOBJ to delete transport objects { ls_objh-objectname }| ).
ENDIF.
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_korrnum = iv_transport
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'D'
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
delete_extra( ls_objh-objectname ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj.
io_xml->read( EXPORTING iv_name = 'OBJH'
CHANGING cg_data = ls_objh ).
io_xml->read( EXPORTING iv_name = 'OBJT'
CHANGING cg_data = ls_objt ).
io_xml->read( EXPORTING iv_name = 'OBJS'
CHANGING cg_data = lt_objs ).
io_xml->read( EXPORTING iv_name = 'OBJSL'
CHANGING cg_data = lt_objsl ).
io_xml->read( EXPORTING iv_name = 'OBJM'
CHANGING cg_data = lt_objm ).
CALL FUNCTION 'OBJ_GENERATE'
EXPORTING
iv_korrnum = iv_transport
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_maint_mode = 'I'
iv_objecttext = ls_objt-ddtext
iv_objcateg = ls_objh-objcateg
iv_objtransp = ls_objh-objtransp
iv_devclass = iv_package
TABLES
tt_v_obj_s = lt_objs
tt_objm = lt_objm
EXCEPTIONS
illegal_call = 1
object_not_found = 2
generate_error = 3
transport_error = 4
object_enqueue_failed = 5
OTHERS = 6.
IF sy-subrc <> 0.
* TOBJ has to be saved/generated after the DDIC tables have been
* activated - fixed with late deserialization
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CALL FUNCTION 'OBJ_SET_IMPORTABLE'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_importable = ls_objh-importable
EXCEPTIONS
object_not_defined = 1
invalid = 2
transport_error = 3
object_enqueue_failed = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
* fm OBJ_GENERATE takes the defaults from the DDIC object
* set OBJTRANSP directly, should be okay looking at the code in OBJ_SET_IMPORTABLE
* locking has been done in OBJ_SET_IMPORTABLE plus recording of transport
UPDATE objh SET objtransp = ls_objh-objtransp
WHERE objectname = ls_objh-objectname
AND objecttype = ls_objh-objecttype.
io_xml->read( EXPORTING iv_name = 'TOBJ'
CHANGING cg_data = ls_tobj ).
ls_tobj-tvdir-gendate = sy-datum.
ls_tobj-tvdir-gentime = sy-uzeit.
ls_tobj-tvdir-devclass = iv_package.
update_extra( ls_tobj ).
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_objectname TYPE objh-objectname,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
SELECT SINGLE objectname FROM objh INTO lv_objectname
WHERE objectname = ms_item-obj_name(lv_type_pos)
AND objecttype = ms_item-obj_name+lv_type_pos. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-late TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lv_object_name TYPE e071-obj_name.
lv_object_name = ms_item-obj_name.
CALL FUNCTION 'TR_OBJECT_JUMP_TO_TOOL'
EXPORTING
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = lv_object_name
EXCEPTIONS
jump_not_possible = 1
OTHERS = 2.
rv_exit = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_objh TYPE objh,
ls_objt TYPE objt,
lt_objs TYPE tt_objs,
lt_objsl TYPE tt_objsl,
lt_objm TYPE tt_objm,
ls_tobj TYPE ty_tobj,
lv_type_pos TYPE i.
lv_type_pos = strlen( ms_item-obj_name ) - 1.
ls_objh-objectname = ms_item-obj_name(lv_type_pos).
ls_objh-objecttype = ms_item-obj_name+lv_type_pos.
CALL FUNCTION 'CTO_OBJECT_GET'
EXPORTING
iv_objectname = ls_objh-objectname
iv_objecttype = ls_objh-objecttype
iv_language = mv_language
iv_sel_objt = abap_true
iv_sel_objs = abap_true
iv_sel_objsl = abap_true
iv_sel_objm = abap_true
IMPORTING
es_objh = ls_objh
es_objt = ls_objt
TABLES
tt_objs = lt_objs
tt_objsl = lt_objsl
tt_objm = lt_objm
EXCEPTIONS
object_not_defined = 1
OTHERS = 2.
IF sy-subrc = 1.
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR: ls_objh-luser,
ls_objh-ldate.
io_xml->add( iv_name = 'OBJH'
ig_data = ls_objh ).
io_xml->add( iv_name = 'OBJT'
ig_data = ls_objt ).
io_xml->add( iv_name = 'OBJS'
ig_data = lt_objs ).
io_xml->add( iv_name = 'OBJSL'
ig_data = lt_objsl ).
io_xml->add( iv_name = 'OBJM'
ig_data = lt_objm ).
ls_tobj = read_extra( ls_objh-objectname ).
IF ls_tobj-tvdir-detail = ``.
" to prevent xslt serialization error,
" force clear if numc field is empty
CLEAR ls_tobj-tvdir-detail.
ENDIF.
io_xml->add( iv_name = 'TOBJ'
ig_data = ls_tobj ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
UPDATE objh SET objtransp = ls_objh-objtransp
```
Explanation: Modify only own DB tables. | 1,952 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete_sots.
DATA:
ls_sots TYPE ty_sots,
lt_sots_use TYPE ty_sots_use_tt.
FIELD-SYMBOLS <ls_sots_use> LIKE LINE OF lt_sots_use.
lt_sots_use = get_sots_usage( iv_pgmid = iv_pgmid
iv_object = iv_object
iv_obj_name = iv_obj_name ).
" Remove any usage to ensure deletion, see function module BTFR_CHECK
DELETE sotr_useu FROM TABLE lt_sots_use ##SUBRC_OK.
LOOP AT lt_sots_use ASSIGNING <ls_sots_use> WHERE concept IS NOT INITIAL.
CALL FUNCTION 'BTFR_DELETE_SINGLE_TEXT'
EXPORTING
concept = <ls_sots_use>-concept
flag_string = abap_true
EXCEPTIONS
text_not_found = 1 "ok
invalid_package = 3
text_not_changeable = 4
text_enqueued = 5
no_correction = 6
parameter_error = 7
OTHERS = 8.
IF sy-subrc > 2.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE sotr_useu FROM TABLE lt_sots_use ##SUBRC_OK.
```
Explanation: Modify only own DB tables. | 1,965 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF it_tpool IS INITIAL.
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
FROM it_tpool "main language cannot be activated because
LANGUAGE lv_language "this would activate the deletion of the textpool
STATE lv_state. "of the mail program -> insert empty textpool
ENDIF.
``` | I found vulnerabilities in the line:
```abap
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in * <-- There is a problem here
FROM it_tpool
LANGUAGE lv_language
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 1,999 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_textpool.
DATA lv_language TYPE sy-langu.
DATA lv_state TYPE c.
DATA lv_delete TYPE abap_bool.
IF iv_language IS INITIAL.
lv_language = mv_language.
ELSE.
lv_language = iv_language.
ENDIF.
IF lv_language = mv_language.
lv_state = c_state-inactive. "Textpool in main language needs to be activated
ELSE.
lv_state = c_state-active. "Translations are always active
ENDIF.
IF it_tpool IS INITIAL.
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
FROM it_tpool "main language cannot be activated because
LANGUAGE lv_language "this would activate the deletion of the textpool
STATE lv_state. "of the mail program -> insert empty textpool
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program
FROM it_tpool
LANGUAGE lv_language
STATE lv_state.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
ENDIF.
IF lv_state = c_state-inactive. "Textpool in main language needs to be activated
zcl_abapgit_objects_activation=>add(
iv_type = 'REPT'
iv_name = iv_program
iv_delete = lv_delete ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program * <-- There is a problem here
FROM it_tpool
LANGUAGE lv_language
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 2,000 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_idoc IMPLEMENTATION.
METHOD clear_idoc_segement_field.
FIELD-SYMBOLS <lg_any_field> TYPE any.
ASSIGN COMPONENT iv_fieldname OF STRUCTURE cg_structure TO <lg_any_field>.
IF sy-subrc = 0.
CLEAR <lg_any_field>.
ENDIF.
ENDMETHOD.
METHOD clear_idoc_segement_fields.
clear_idoc_segement_field( EXPORTING iv_fieldname = 'DEVC'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PLAST'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PWORK'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'PRESP'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'CREDATE'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'CRETIME'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'LDATE'
CHANGING cg_structure = cg_structure ).
clear_idoc_segement_field( EXPORTING iv_fieldname = 'LTIME'
CHANGING cg_structure = cg_structure ).
ENDMETHOD.
METHOD constructor.
super->constructor(
is_item = is_item
iv_language = iv_language
io_files = io_files
io_i18n_params = io_i18n_params ).
mv_idoctyp = ms_item-obj_name.
ENDMETHOD.
METHOD is_closed.
DATA ls_idoc TYPE ty_idoc.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_idoc-attributes
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
rv_closed = boolc( sy-subrc = 0 AND ls_idoc-attributes-closed = abap_true ).
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
DATA: ls_attributes TYPE edi_iapi01.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_attributes
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_user = ls_attributes-plast.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
CALL FUNCTION 'IDOCTYPE_DELETE'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
lock_error = 2
action_not_possible = 3
transport_error = 4
db_error = 5
no_authority = 6
OTHERS = 7.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
DATA: ls_idoc TYPE ty_idoc,
lv_transport TYPE trkorr,
ls_edbas TYPE edbas,
ls_attributes TYPE edi_iapi05.
io_xml->read(
EXPORTING
iv_name = 'IDOC'
CHANGING
cg_data = ls_idoc ).
MOVE-CORRESPONDING ls_idoc-attributes TO ls_attributes.
IF zif_abapgit_object~exists( ) = abap_false.
CALL FUNCTION 'IDOCTYPE_CREATE'
EXPORTING
pi_idoctyp = mv_idoctyp
pi_devclass = iv_package
pi_attributes = ls_attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
object_exists = 2
syntax_error = 3
segment_error = 4
transport_error = 5
db_error = 6
no_authority = 7
OTHERS = 8.
ELSE.
IF is_closed( ) = abap_true.
CALL FUNCTION 'IDOCTYPE_UNCLOSE'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
action_not_possible = 2
db_error = 3
no_authority = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
CALL FUNCTION 'IDOCTYPE_UPDATE'
EXPORTING
pi_idoctyp = mv_idoctyp
pi_attributes = ls_attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
object_exists = 2
syntax_error = 3
segment_error = 4
transport_error = 5
db_error = 6
no_authority = 7
OTHERS = 8.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
IF ls_idoc-attributes-closed = abap_true.
IF iv_transport IS NOT INITIAL.
lv_transport = iv_transport.
CALL FUNCTION 'IDOCTYPE_CLOSE'
EXPORTING
pi_idoctyp = mv_idoctyp
CHANGING
pc_order = lv_transport
EXCEPTIONS
object_not_found = 1
action_not_possible = 2
db_error = 3
no_authority = 4
OTHERS = 5.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
" IDOCTYPE_CLOSE saves current release but it should be same as in repo
SELECT SINGLE * FROM edbas INTO ls_edbas WHERE idoctyp = mv_idoctyp.
ls_edbas-released = ls_idoc-attributes-released.
ls_edbas-applrel = ls_idoc-attributes-applrel.
ls_edbas-closed = ls_idoc-attributes-closed.
UPDATE edbas FROM ls_edbas.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error updating IDOC { mv_idoctyp }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
CALL FUNCTION 'IDOCTYPE_EXISTENCE_CHECK'
EXPORTING
pi_idoctyp = mv_idoctyp
EXCEPTIONS
object_not_found = 1
db_error = 2
OTHERS = 3.
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump.
DATA: lt_bdcdata TYPE TABLE OF bdcdata.
FIELD-SYMBOLS: <ls_bdcdata> LIKE LINE OF lt_bdcdata.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-program = 'SAPMSED5'.
<ls_bdcdata>-dynpro = '0010'.
<ls_bdcdata>-dynbegin = abap_true.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'SED5STRUC-OBJECT'.
<ls_bdcdata>-fval = ms_item-obj_name.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'SED5STRUC-SELECT_ORG'.
<ls_bdcdata>-fval = abap_true.
APPEND INITIAL LINE TO lt_bdcdata ASSIGNING <ls_bdcdata>.
<ls_bdcdata>-fnam = 'BDC_OKCODE'.
<ls_bdcdata>-fval = '=DISP'.
zcl_abapgit_objects_factory=>get_gui_jumper( )->jump_batch_input(
iv_tcode = 'WE30'
it_bdcdata = lt_bdcdata ).
rv_exit = abap_true.
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: ls_idoc TYPE ty_idoc.
CALL FUNCTION 'IDOCTYPE_READ'
EXPORTING
pi_idoctyp = mv_idoctyp
IMPORTING
pe_attributes = ls_idoc-attributes
TABLES
pt_syntax = ls_idoc-t_syntax
EXCEPTIONS
object_not_found = 1
db_error = 2
no_authority = 3
OTHERS = 4.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
clear_idoc_segement_fields( CHANGING cg_structure = ls_idoc-attributes ).
io_xml->add( iv_name = 'IDOC'
ig_data = ls_idoc ).
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
UPDATE edbas FROM ls_edbas.
```
Explanation: Modify only own DB tables. | 2,003 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_object_msag IMPLEMENTATION.
METHOD delete_documentation.
DATA: lv_key_s TYPE dokhl-object.
CLEAR lv_key_s.
CALL FUNCTION 'DOCU_OBJECT_NAME_CONCATENATE'
EXPORTING
docu_id = c_longtext_id_msag
element = iv_message_id
addition = ' '
IMPORTING
object = lv_key_s
EXCEPTIONS
OTHERS = 0.
CALL FUNCTION 'DOKU_DELETE_ALL'
EXPORTING
doku_id = c_longtext_id_msag
doku_object = lv_key_s
generic_use = 'X'
suppress_authority = space
suppress_enqueue = space
suppress_transport = space
EXCEPTIONS
header_without_text = 1
index_without_header = 2
no_authority_for_devclass_xxxx = 3
no_docu_found = 4
object_is_already_enqueued = 5
object_is_enqueued_by_corr = 6
user_break = 7.
ENDMETHOD.
METHOD delete_msgid.
delete_documentation( iv_message_id ).
DELETE FROM t100a WHERE arbgb = iv_message_id.
IF sy-subrc = 0 OR sy-subrc = 4.
CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
EXPORTING
object = iv_message_id
operation = 'DELETE'
program = space
type = 'CN'.
DELETE FROM t100o WHERE arbgb = iv_message_id.
DELETE FROM t100t WHERE arbgb = iv_message_id. "#EC CI_NOFIRST
DELETE FROM t100u WHERE arbgb = iv_message_id.
DELETE FROM t100x WHERE arbgb = iv_message_id.
DELETE FROM t100 WHERE arbgb = iv_message_id.
ENDIF.
ENDMETHOD.
METHOD deserialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
ls_t100 TYPE t100,
lt_t100t TYPE TABLE OF t100t,
lt_t100_texts TYPE ty_t100_texts,
lt_t100u TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100_text> TYPE ty_t100_text.
lv_msg_id = ms_item-obj_name.
SELECT * FROM t100u INTO TABLE lt_t100u
WHERE arbgb = lv_msg_id ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
ii_xml->read( EXPORTING iv_name = 'T100_TEXTS'
CHANGING cg_data = lt_t100_texts ).
ii_xml->read( EXPORTING iv_name = 'T100T'
CHANGING cg_data = lt_t100t ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100_texts ).
mo_i18n_params->trim_saplang_keyed_table(
EXPORTING
iv_lang_field_name = 'SPRSL'
CHANGING
ct_tab = lt_t100t ).
MODIFY t100t FROM TABLE lt_t100t. "#EC CI_SUBRC
LOOP AT lt_t100_texts ASSIGNING <ls_t100_text>.
"check if message exists
READ TABLE lt_t100u TRANSPORTING NO FIELDS
WITH KEY arbgb = lv_msg_id msgnr = <ls_t100_text>-msgnr BINARY SEARCH.
CHECK sy-subrc = 0. "if original message doesn't exist no translations added
MOVE-CORRESPONDING <ls_t100_text> TO ls_t100.
ls_t100-arbgb = lv_msg_id.
MODIFY t100 FROM ls_t100.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD free_access_permission.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = 'FREE'
object = iv_message_id
object_class = 'T100'.
ENDMETHOD.
METHOD serialize_longtexts_msag.
DATA: lv_doku_object_name TYPE dokhl-object,
lt_doku_object_names TYPE STANDARD TABLE OF dokhl-object
WITH NON-UNIQUE DEFAULT KEY,
lt_dokil TYPE zif_abapgit_definitions=>ty_dokil_tt,
ls_dokil LIKE LINE OF lt_dokil,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
FIELD-SYMBOLS: <ls_t100> TYPE t100.
IF lines( it_t100 ) = 0.
RETURN.
ENDIF.
LOOP AT it_t100 ASSIGNING <ls_t100>.
lv_doku_object_name = <ls_t100>-arbgb && <ls_t100>-msgnr.
INSERT lv_doku_object_name INTO TABLE lt_doku_object_names.
ENDLOOP.
IF mo_i18n_params->ms_params-main_language_only = abap_true.
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND masterlang = abap_true
ORDER BY PRIMARY KEY.
ELSE.
lt_language_filter = mo_i18n_params->build_language_filter( ).
SELECT * FROM dokil
INTO TABLE lt_dokil
FOR ALL ENTRIES IN lt_doku_object_names
WHERE id = c_longtext_id_msag
AND object = lt_doku_object_names-table_line
AND langu IN lt_language_filter
ORDER BY PRIMARY KEY.
ENDIF.
CLEAR ls_dokil-dokstate.
MODIFY lt_dokil FROM ls_dokil TRANSPORTING dokstate WHERE dokstate IS NOT INITIAL.
IF lines( lt_dokil ) > 0.
serialize_longtexts( ii_xml = ii_xml
it_dokil = lt_dokil ).
ENDIF.
ENDMETHOD.
METHOD serialize_texts.
DATA: lv_msg_id TYPE rglif-message_id,
lt_t100_texts TYPE ty_t100_texts,
lt_t100t TYPE TABLE OF t100t,
lt_i18n_langs TYPE TABLE OF langu,
lt_language_filter TYPE zif_abapgit_environment=>ty_system_language_filter.
lv_msg_id = ms_item-obj_name.
IF mo_i18n_params->ms_params-main_language_only = abap_true.
RETURN. " skip
ENDIF.
" Collect additional languages
" Skip main lang - it has been already serialized and also technical languages
lt_language_filter = mo_i18n_params->build_language_filter( ).
SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs
FROM t100t
WHERE arbgb = lv_msg_id
AND sprsl IN lt_language_filter
AND sprsl <> mv_language
ORDER BY langu. "#EC CI_BYPASS "#EC CI_GENBUFF
SORT lt_i18n_langs ASCENDING.
IF lines( lt_i18n_langs ) > 0.
SELECT * FROM t100t INTO CORRESPONDING FIELDS OF TABLE lt_t100t
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
SELECT * FROM t100 INTO CORRESPONDING FIELDS OF TABLE lt_t100_texts
WHERE sprsl IN lt_language_filter
AND sprsl <> mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
SORT lt_t100t BY sprsl ASCENDING.
SORT lt_t100_texts BY sprsl msgnr ASCENDING.
ii_xml->add( iv_name = 'I18N_LANGS'
ig_data = lt_i18n_langs ).
ii_xml->add( iv_name = 'T100T'
ig_data = lt_t100t ).
ii_xml->add( iv_name = 'T100_TEXTS'
ig_data = lt_t100_texts ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE lastuser FROM t100a INTO rv_user
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0 OR rv_user = ''.
rv_user = c_user_unknown.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~delete.
DATA: ls_t100a TYPE t100a,
lv_frozen TYPE abap_bool,
lv_message_id TYPE arbgb.
* parameter SUPPRESS_DIALOG doesn't exist in all versions of FM RS_DELETE_MESSAGE_ID
* replaced with a copy
lv_message_id = ms_item-obj_name.
IF ms_item-obj_name = space.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."blank message id
ENDIF.
SELECT SINGLE * FROM t100a INTO ls_t100a WHERE arbgb = ms_item-obj_name.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from (copy of) RS_DELETE_MESSAGE_ID' )."not found
ENDIF.
CLEAR lv_frozen.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
authority_check = 'X'
global_lock = 'X'
mode = 'MODIFY'
object = lv_message_id
object_class = 'T100'
IMPORTING
frozen = lv_frozen
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0 OR lv_frozen <> space.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
zcl_abapinst_factory=>get_cts_api( )->insert_transport_object(
iv_object = 'MSAG'
iv_obj_name = lv_message_id
iv_package = iv_package
iv_language = mv_language
iv_mode = zif_abapgit_cts_api=>c_transport_mode-delete ).
delete_msgid( lv_message_id ).
free_access_permission( lv_message_id ).
ENDMETHOD.
METHOD zif_abapgit_object~deserialize.
* fm RPY_MESSAGE_ID_INSERT almost works, but not in older versions
DATA: ls_t100a TYPE t100a,
ls_t100t TYPE t100t,
ls_t100u TYPE t100u,
lt_t100 TYPE TABLE OF t100,
lt_before TYPE TABLE OF t100u.
FIELD-SYMBOLS: <ls_t100> LIKE LINE OF lt_t100.
io_xml->read( EXPORTING iv_name = 'T100A'
CHANGING cg_data = ls_t100a ).
io_xml->read( EXPORTING iv_name = 'T100'
CHANGING cg_data = lt_t100 ).
corr_insert( iv_package ).
SELECT * FROM t100u INTO TABLE lt_before
WHERE arbgb = ls_t100a-arbgb ORDER BY msgnr. "#EC CI_GENBUFF "#EC CI_BYPASS
LOOP AT lt_t100 ASSIGNING <ls_t100>.
DELETE lt_before WHERE msgnr = <ls_t100>-msgnr.
MODIFY t100 FROM <ls_t100>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100 modify failed' ).
ENDIF.
CLEAR ls_t100u.
MOVE-CORRESPONDING <ls_t100> TO ls_t100u ##ENH_OK.
ls_t100u-name = sy-uname.
ls_t100u-datum = sy-datum.
ls_t100u-selfdef = '3'.
MODIFY t100u FROM ls_t100u.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100U modify failed' ).
ENDIF.
ENDLOOP.
ls_t100a-masterlang = mv_language.
ls_t100a-lastuser = sy-uname.
ls_t100a-respuser = sy-uname.
ls_t100a-ldate = sy-datum.
ls_t100a-ltime = sy-uzeit.
MODIFY t100a FROM ls_t100a.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100A modify failed' ).
ENDIF.
ls_t100t-sprsl = mv_language.
ls_t100t-arbgb = ls_t100a-arbgb.
ls_t100t-stext = ls_t100a-stext.
MODIFY t100t FROM ls_t100t.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'MSAG: Table T100T modify failed' ).
ENDIF.
LOOP AT lt_before INTO ls_t100u.
DELETE FROM t100 WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
DELETE FROM t100u WHERE arbgb = ls_t100u-arbgb
AND msgnr = ls_t100u-msgnr. "#EC CI_SUBRC
ENDLOOP.
deserialize_longtexts( ii_xml = io_xml
iv_longtext_id = c_longtext_id_msag ).
IF mo_i18n_params->is_lxe_applicable( ) = abap_false.
deserialize_texts( io_xml ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~exists.
DATA: lv_arbgb TYPE t100a-arbgb.
SELECT SINGLE arbgb FROM t100a INTO lv_arbgb
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
ENDMETHOD.
METHOD zif_abapgit_object~get_comparator.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_order.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~get_deserialize_steps.
APPEND zif_abapgit_object=>gc_step_id-abap TO rt_steps.
ENDMETHOD.
METHOD zif_abapgit_object~get_metadata.
rs_metadata = get_metadata( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
DATA: lv_argument TYPE seqg3-garg.
lv_argument = |{ ms_item-obj_name }|.
OVERLAY lv_argument WITH ' '.
lv_argument = lv_argument && '*'.
rv_is_locked = exists_a_lock_entry_for( iv_lock_object = |ES_MSGSI|
iv_argument = lv_argument ).
ENDMETHOD.
METHOD zif_abapgit_object~jump.
" Covered by zcl_abapinst_objects=>JUMP
ENDMETHOD.
METHOD zif_abapgit_object~map_filename_to_object.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~map_object_to_filename.
RETURN.
ENDMETHOD.
METHOD zif_abapgit_object~serialize.
DATA: lv_msg_id TYPE rglif-message_id,
ls_inf TYPE t100a,
lt_source TYPE ty_t100s.
lv_msg_id = ms_item-obj_name.
SELECT SINGLE * FROM t100a INTO ls_inf
WHERE arbgb = lv_msg_id. "#EC CI_GENBUFF
IF sy-subrc <> 0.
RETURN.
ENDIF.
CLEAR ls_inf-respuser.
SELECT * FROM t100 INTO TABLE lt_source
WHERE sprsl = mv_language
AND arbgb = lv_msg_id
ORDER BY PRIMARY KEY. "#EC CI_SUBRC "#EC CI_GENBUFF
CLEAR: ls_inf-lastuser,
ls_inf-ldate,
ls_inf-ltime.
io_xml->add( iv_name = 'T100A'
ig_data = ls_inf ).
io_xml->add( ig_data = lt_source
iv_name = 'T100' ).
serialize_longtexts_msag( it_t100 = lt_source
ii_xml = io_xml ).
IF mo_i18n_params->is_lxe_applicable( ) = abap_false.
serialize_texts( io_xml ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
MODIFY t100a FROM ls_t100a.
```
Explanation: Modify only own DB tables.
```abap
MODIFY t100t FROM ls_t100t.
```
Explanation: Modify only own DB tables. | 2,016 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT is_internal-segment_definitions ASSIGNING <ls_segment_definition>.
ls_segment_definition = <ls_segment_definition>.
<ls_segment_definition>-segmentheader-presp = sy-uname.
<ls_segment_definition>-segmentheader-pwork = sy-uname.
CALL FUNCTION 'SEGMENT_READ'
EXPORTING
segmenttyp = <ls_segment_definition>-segmentdefinition-segtyp
IMPORTING
result = lv_result
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0 OR lv_result <> 0.
CALL FUNCTION 'SEGMENT_CREATE'
IMPORTING
segmentdefinition = <ls_segment_definition>-segmentdefinition
TABLES
segmentstructure = <ls_segment_definition>-segmentstructures
CHANGING
segmentheader = <ls_segment_definition>-segmentheader
devclass = lv_package
EXCEPTIONS
OTHERS = 1.
ELSE.
CALL FUNCTION 'SEGMENT_MODIFY'
CHANGING
segmentheader = <ls_segment_definition>-segmentheader
devclass = lv_package
EXCEPTIONS
OTHERS = 1.
IF sy-subrc = 0.
CALL FUNCTION 'SEGMENTDEFINITION_MODIFY'
TABLES
segmentstructure = <ls_segment_definition>-segmentstructures
CHANGING
segmentdefinition = <ls_segment_definition>-segmentdefinition
EXCEPTIONS
OTHERS = 1.
ENDIF.
ENDIF.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
IF ls_segment_definition-segmentdefinition-closed = abap_true.
IF lv_transport IS NOT INITIAL.
CALL FUNCTION 'SEGMENTDEFINITION_CLOSE'
EXPORTING
segmenttyp = ls_segment_definition-segmentdefinition-segtyp
CHANGING
order = lv_transport
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
" SEGMENTDEFINITION_CLOSE saves current release but it should be same as in repo
SELECT SINGLE * FROM edisdef INTO ls_edisdef
WHERE segtyp = ls_segment_definition-segmentdefinition-segtyp
AND version = ls_segment_definition-segmentdefinition-version.
ls_edisdef-released = ls_segment_definition-segmentdefinition-released.
ls_edisdef-applrel = ls_segment_definition-segmentdefinition-applrel.
ls_edisdef-closed = ls_segment_definition-segmentdefinition-closed.
UPDATE edisdef FROM ls_edisdef.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error updating IDOC segment {
<ls_segment_definition>-segmentdefinition-segtyp }| ).
ENDIF.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
UPDATE edisdef FROM ls_edisdef.
```
Explanation: Modify only own DB tables. | 2,025 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_base IMPLEMENTATION.
METHOD convert_attrib_to_vseoattrib.
FIELD-SYMBOLS: <ls_attribute> LIKE LINE OF it_attributes,
<ls_vseoattrib> LIKE LINE OF rt_vseoattrib.
LOOP AT it_attributes ASSIGNING <ls_attribute>.
INSERT INITIAL LINE INTO TABLE rt_vseoattrib ASSIGNING <ls_vseoattrib>.
MOVE-CORRESPONDING <ls_attribute> TO <ls_vseoattrib>.
<ls_vseoattrib>-clsname = iv_clsname.
<ls_vseoattrib>-state = seoc_state_implemented.
<ls_vseoattrib>-exposure = <ls_attribute>-exposure.
UNASSIGN <ls_vseoattrib>.
ENDLOOP.
UNASSIGN <ls_attribute>.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~add_to_activation_list.
zcl_abapgit_objects_activation=>add_item( is_item ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_documentation.
CALL FUNCTION 'DOCU_UPD'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
no_masterlang = iv_no_masterlang
state = c_docu_state_active
TABLES
line = it_lines
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete_documentation.
CALL FUNCTION 'DOCU_DEL'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
typ = 'E'
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from DOCU_DEL' ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_interface_properties.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_skip_test_classes.
rv_skip = mv_skip_test_classes.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_attributes.
SELECT cmpname attbusobj attkeyfld exposure
FROM seocompodf
INTO CORRESPONDING FIELDS OF TABLE rt_attributes
WHERE clsname = iv_object_name
AND ( attbusobj <> space OR attkeyfld <> space )
AND version = '1'
ORDER BY PRIMARY KEY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seocompotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_descriptions_sub.
FIELD-SYMBOLS <ls_description> LIKE LINE OF rt_descriptions.
IF iv_language IS INITIAL.
" load all languages
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ELSE.
" load main language
SELECT * FROM seosubcotx INTO TABLE rt_descriptions
WHERE clsname = iv_object_name
AND langu = iv_language
AND descript <> ''
ORDER BY PRIMARY KEY. "#EC CI_SUBRC
ENDIF.
LOOP AT rt_descriptions ASSIGNING <ls_description>.
CLEAR <ls_description>-clsname.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_documentation.
DATA: lv_state TYPE dokstate,
lt_lines TYPE tlinetab.
CALL FUNCTION 'DOCU_GET'
EXPORTING
id = iv_id
langu = iv_language
object = iv_object_name
version_active_or_last = space " retrieve active version
IMPORTING
dokstate = lv_state
TABLES
line = lt_lines
EXCEPTIONS
no_docu_on_screen = 1
no_docu_self_def = 2
no_docu_temp = 3
ret_code = 4
OTHERS = 5.
IF sy-subrc = 0 AND lv_state = c_docu_state_active.
rt_lines = lt_lines.
ELSE.
CLEAR rt_lines.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_superclass.
SELECT SINGLE refclsname FROM vseoextend INTO rv_superclass
WHERE clsname = iv_classname.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~serialize_abap.
DATA lo_oo_serializer TYPE REF TO zcl_abapgit_oo_serializer.
CREATE OBJECT lo_oo_serializer.
CASE iv_type.
WHEN seop_ext_class_locals_def.
rt_source = lo_oo_serializer->serialize_locals_def( is_class_key ).
WHEN seop_ext_class_locals_imp.
rt_source = lo_oo_serializer->serialize_locals_imp( is_class_key ).
WHEN seop_ext_class_macros.
rt_source = lo_oo_serializer->serialize_macros( is_class_key ).
WHEN seop_ext_class_testclasses.
rt_source = lo_oo_serializer->serialize_testclasses( is_class_key ).
mv_skip_test_classes = lo_oo_serializer->are_test_classes_skipped( ).
WHEN OTHERS.
rt_source = lo_oo_serializer->serialize_abap_clif_source( is_class_key ).
ENDCASE.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions.
DATA lt_descriptions LIKE it_descriptions.
DATA lt_components TYPE seo_components.
DATA ls_description LIKE LINE OF it_descriptions.
DATA lv_lang TYPE tadir-masterlang.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
FIELD-SYMBOLS <ls_component> TYPE vseocompdf.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
" make sure to not damage VSEO* views by deleting texts of all components - an empty text must be kept!!
SELECT * FROM vseocompdf INTO TABLE lt_components
WHERE clsname = is_key-clsname
AND version <> seoc_version_deleted
AND state = seoc_state_implemented
AND alias = seox_false ORDER BY clsname cmpname version.
IF lt_components IS NOT INITIAL.
SELECT SINGLE masterlang FROM tadir INTO lv_lang
WHERE pgmid = 'R3TR' AND ( object = 'CLAS' OR object = 'INTF' )
AND obj_name = is_key-clsname. "#EC CI_GENBUFF
IF sy-subrc <> 0.
lv_lang = sy-langu.
ENDIF.
LOOP AT lt_components ASSIGNING <ls_component>.
READ TABLE lt_descriptions TRANSPORTING NO FIELDS WITH KEY
clsname = is_key-clsname
cmpname = <ls_component>-cmpname.
IF sy-subrc <> 0.
ls_description-clsname = is_key-clsname.
ls_description-cmpname = <ls_component>-cmpname.
ls_description-langu = lv_lang.
ls_description-descript = space.
APPEND ls_description TO lt_descriptions.
ENDIF.
ENDLOOP.
ENDIF.
DELETE FROM seocompotx WHERE clsname = is_key-clsname."#EC CI_SUBRC
INSERT seocompotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~update_descriptions_sub.
DATA lt_descriptions LIKE it_descriptions.
DATA lt_subcomponents TYPE seo_subcomponents.
DATA ls_description LIKE LINE OF it_descriptions.
DATA lv_lang TYPE tadir-masterlang.
FIELD-SYMBOLS <ls_description> LIKE LINE OF it_descriptions.
FIELD-SYMBOLS <ls_subcomponent> TYPE vseosubcdf.
lt_descriptions = it_descriptions.
LOOP AT lt_descriptions ASSIGNING <ls_description>.
<ls_description>-clsname = is_key-clsname.
ENDLOOP.
" make sure to not damage VSEO* views by deleting texts of all subcomponents - an empty text must be kept!!
SELECT * FROM vseosubcdf INTO TABLE lt_subcomponents
WHERE clsname = is_key-clsname
AND version <> seoc_version_deleted ORDER BY clsname cmpname sconame version.
IF lt_subcomponents IS NOT INITIAL.
SELECT SINGLE masterlang FROM tadir INTO lv_lang
WHERE pgmid = 'R3TR' AND ( object = 'CLAS' OR object = 'INTF' )
AND obj_name = is_key-clsname. "#EC CI_GENBUFF
IF sy-subrc <> 0.
lv_lang = sy-langu.
ENDIF.
LOOP AT lt_subcomponents ASSIGNING <ls_subcomponent>.
READ TABLE lt_descriptions TRANSPORTING NO FIELDS WITH KEY
clsname = is_key-clsname
cmpname = <ls_subcomponent>-cmpname
sconame = <ls_subcomponent>-sconame.
IF sy-subrc <> 0.
ls_description-clsname = is_key-clsname.
ls_description-cmpname = <ls_subcomponent>-cmpname.
ls_description-sconame = <ls_subcomponent>-sconame.
ls_description-langu = lv_lang.
ls_description-descript = space.
APPEND ls_description TO lt_descriptions.
ENDIF.
ENDLOOP.
ENDIF.
DELETE FROM seosubcotx WHERE clsname = is_key-clsname."#EC CI_SUBRC
INSERT seosubcotx FROM TABLE lt_descriptions. "#EC CI_SUBRC
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~syntax_check.
ASSERT 0 = 1. "Subclass responsibility
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM seocompotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seocompotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM seosubcotx WHERE clsname = is_key-clsname.
```
Explanation: Modify only own DB tables.
```abap
INSERT seosubcotx FROM TABLE lt_descriptions.
```
Explanation: Modify only own DB tables. | 2,034 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS zcl_abapgit_oo_class IMPLEMENTATION.
METHOD create_report.
zcl_abapinst_factory=>get_sap_report( )->insert_report(
iv_name = iv_program
iv_package = iv_package
it_source = it_source
iv_state = iv_state
iv_version = iv_version
iv_program_type = iv_program_type
iv_extension_type = iv_extension ).
ENDMETHOD.
METHOD delete_report.
zcl_abapinst_factory=>get_sap_report( )->delete_report( iv_program ).
ENDMETHOD.
METHOD determine_method_include.
DATA: ls_mtdkey TYPE seocpdkey.
ls_mtdkey-clsname = iv_name.
ls_mtdkey-cpdname = iv_method.
cl_oo_classname_service=>get_method_include(
EXPORTING
mtdkey = ls_mtdkey
RECEIVING
result = rv_program
EXCEPTIONS
method_not_existing = 1 ).
IF sy-subrc = 0.
RETURN.
ENDIF.
CALL FUNCTION 'SEO_METHOD_GENERATE_INCLUDE'
EXPORTING
suppress_mtdkey_check = abap_true
mtdkey = ls_mtdkey
EXCEPTIONS
not_existing = 1
model_only = 2
include_existing = 3
method_imp_not_generated = 4
method_imp_not_initialised = 5
_internal_class_not_existing = 6
_internal_method_overflow = 7
cancelled = 8
method_is_abstract_implemented = 9
method_is_final_implemented = 10
internal_error_insert_report = 11
OTHERS = 12.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_program = cl_oo_classname_service=>get_method_include( ls_mtdkey ).
ENDMETHOD.
METHOD generate_classpool.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = iv_name.
CALL FUNCTION 'SEO_CLASS_GENERATE_CLASSPOOL'
EXPORTING
clskey = ls_clskey
suppress_corr = abap_true
EXCEPTIONS
not_existing = 1
model_only = 2
class_pool_not_generated = 3
class_stment_not_generated = 4
locals_not_generated = 5
macros_not_generated = 6
public_sec_not_generated = 7
protected_sec_not_generated = 8
private_sec_not_generated = 9
typeref_not_generated = 10
class_pool_not_initialised = 11
class_stment_not_initialised = 12
locals_not_initialised = 13
macros_not_initialised = 14
public_sec_not_initialised = 15
protected_sec_not_initialised = 16
private_sec_not_initialised = 17
typeref_not_initialised = 18
_internal_class_overflow = 19
OTHERS = 20.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD get_method_includes.
" get method includes for implemented interfaces
" this will contain also leftover includes for deleted interface methods
rt_includes = cl_oo_classname_service=>get_all_method_includes( iv_classname ).
ENDMETHOD.
METHOD init_scanner.
DATA: lx_exc TYPE REF TO cx_root,
lv_message TYPE string,
lv_classname TYPE abap_abstypename.
FIELD-SYMBOLS: <lv_line> TYPE i.
TRY.
ro_scanner = cl_oo_source_scanner_class=>create_class_scanner(
clif_name = iv_name
source = it_source ).
ro_scanner->scan( ).
CATCH cx_clif_scan_error.
zcx_abapgit_exception=>raise( 'error initializing CLAS scanner' ).
CATCH cx_root INTO lx_exc.
lv_classname = cl_abap_classdescr=>get_class_name( lx_exc ).
IF lv_classname = '\CLASS=CX_OO_CLIF_SCAN_ERROR_DETAIL'.
ASSIGN lx_exc->('SOURCE_POSITION-LINE') TO <lv_line>.
ASSERT sy-subrc = 0.
lv_message = |{ lx_exc->get_text( ) }, line { <lv_line> }|.
ELSE.
lv_message = lx_exc->get_text( ).
ENDIF.
zcx_abapgit_exception=>raise( lv_message ).
ENDTRY.
ENDMETHOD.
METHOD repair_classpool.
CALL FUNCTION 'SEO_CLASS_REPAIR_CLASSPOOL'
EXPORTING
clskey = is_key
EXCEPTIONS
not_existing = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing class { is_key-clsname }| ).
ENDIF.
ENDMETHOD.
METHOD repair_redefinitions.
" Same logic as SE24 > Utilities > Clean-up > Redefinitions (LSEODCCO)
DATA:
lt_inheritance TYPE vseoextend,
lt_redefinitions TYPE seor_redefinitions_r,
ls_cpdkey TYPE seocpdkey,
lv_tabix TYPE sy-tabix,
lv_exposure TYPE n LENGTH 1,
lv_update TYPE abap_bool,
lv_local_component TYPE abap_bool.
FIELD-SYMBOLS <ls_redef> TYPE seoredef.
CALL FUNCTION 'SEO_CLASS_TYPEINFO_GET'
EXPORTING
clskey = is_key
version = seoc_version_active
IMPORTING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
is_interface = 2
model_only = 3
OTHERS = 4.
IF sy-subrc <> 0.
RETURN.
ENDIF.
" check redefinitions validity
LOOP AT lt_redefinitions ASSIGNING <ls_redef>.
lv_tabix = sy-tabix.
ls_cpdkey-clsname = is_key-clsname.
ls_cpdkey-cpdname = <ls_redef>-mtdname.
CALL FUNCTION 'SEO_COMPONENT_BY_INHERITANCE'
EXPORTING
cpdkey = ls_cpdkey
version = seoc_version_active
IMPORTING
exposure = lv_exposure
is_local_component = lv_local_component
EXCEPTIONS
not_existing = 1
model_only = 2
OTHERS = 3.
IF sy-subrc <> 0.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ELSEIF <ls_redef>-exposure <> lv_exposure.
<ls_redef>-exposure = lv_exposure.
lv_update = abap_true.
ELSEIF lv_local_component = abap_true AND <ls_redef>-attvalue IS INITIAL AND
<ls_redef>-mtdabstrct IS INITIAL AND <ls_redef>-mtdfinal IS INITIAL.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ENDIF.
ENDLOOP.
IF lv_update = abap_true.
CALL FUNCTION 'SEO_INHERITANC_CHANGE_F_DATA'
EXPORTING
save = abap_false
CHANGING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
deleted = 2
is_comprising = 3
is_implementing = 4
not_changed = 5
db_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
CALL FUNCTION 'SEO_CLIF_SAVE_ALL'
EXPORTING
cifkey = is_key
EXCEPTIONS
not_existing = 1
nothing_to_do = 2
access_error = 3
db_error = 4
error_in_code_generation = 5
OTHERS = 6.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD update_cs_number_of_methods.
" Indirect access to keep downward compatibility
DATA lr_cache_entry TYPE REF TO data.
FIELD-SYMBOLS: <lg_cache_entry> TYPE any,
<lg_field> TYPE any.
TRY.
CREATE DATA lr_cache_entry TYPE ('SEO_CS_CACHE').
CATCH cx_sy_create_data_error.
* does not exist in some older systems
RETURN.
ENDTRY.
ASSIGN lr_cache_entry->* TO <lg_cache_entry>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_classname.
ASSIGN COMPONENT 'NO_OF_METHOD_IMPLS' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_number_of_impl_methods.
MODIFY ('SEO_CS_CACHE') FROM <lg_cache_entry>.
ENDMETHOD.
METHOD update_full_class_include.
CONSTANTS: lc_class_source_extension TYPE c LENGTH 2 VALUE 'CS',
lc_include_program_type TYPE c LENGTH 1 VALUE 'I',
lc_active_version TYPE r3state VALUE 'A'.
create_report( iv_program = cl_oo_classname_service=>get_cs_name( iv_classname )
iv_package = iv_package
it_source = it_source
iv_extension = lc_class_source_extension
iv_program_type = lc_include_program_type
iv_state = lc_active_version
iv_version = iv_version ).
" Assuming that all methods that were scanned are implemented
update_cs_number_of_methods( iv_classname = iv_classname
iv_number_of_impl_methods = lines( it_methods ) ).
ENDMETHOD.
METHOD update_meta.
DATA: lo_update TYPE REF TO cl_oo_class_section_source,
lx_error TYPE REF TO cx_oo_source_save_failure,
ls_clskey TYPE seoclskey,
lv_scan_error TYPE abap_bool.
ls_clskey-clsname = iv_name.
TRY.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = ls_clskey
version = seoc_version_active.
CREATE OBJECT lo_update TYPE ('CL_OO_CLASS_SECTION_SOURCE')
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
source = it_source
suppress_constrctr_generation = abap_true
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3 ##SUBRC_OK.
CATCH cx_sy_dyn_call_param_not_found.
* downport to 702, see https://github.com/abapGit/abapGit/issues/933
* this will READ REPORT instead of using it_source, which should be okay
CREATE OBJECT lo_update TYPE cl_oo_class_section_source
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
lo_update->set_dark_mode( abap_true ).
TRY.
CALL METHOD lo_update->('SET_AMDP_SUPPORT')
EXPORTING
enabled = abap_true.
CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
* AMDP not supported in this system, ignore error
ENDTRY.
lo_update->scan_section_source(
RECEIVING
scan_error = lv_scan_error
EXCEPTIONS
scan_abap_source_error = 1
OTHERS = 2 ).
IF sy-subrc <> 0 OR lv_scan_error = abap_true.
zcx_abapgit_exception=>raise( |CLAS, error while scanning source. Subrc = { sy-subrc }| ).
ENDIF.
* this will update the SEO* database tables
TRY.
lo_update->revert_scan_result( ).
CATCH cx_oo_source_save_failure INTO lx_error.
zcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
IF iv_exposure = seoc_exposure_public.
generate_classpool( iv_name ).
ENDIF.
ENDMETHOD.
METHOD update_report.
DATA lv_type TYPE c LENGTH 1.
lv_type = zcl_abapgit_oo_base=>c_include_program_type.
IF iv_program+30 = srext_ext_class_pool.
lv_type = zcl_abapgit_oo_base=>c_cp_program_type.
ENDIF.
rv_updated = zcl_abapinst_factory=>get_sap_report( )->update_report(
iv_name = iv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_source
iv_program_type = lv_type ).
ENDMETHOD.
METHOD update_source_index.
CONSTANTS:
lc_version_active TYPE r3state VALUE 'A',
lc_version_inactive TYPE r3state VALUE 'I'.
" dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA lo_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT lo_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname
version = lc_version_active
scanner = io_scanner.
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname
version = lc_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
RETURN.
ENDTRY.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create.
DATA:
lt_vseoattrib TYPE seoo_attributes_r,
ls_class_key TYPE seoclskey,
ls_properties TYPE vseoclass,
lt_attributes TYPE zif_abapgit_oo_object_fnc=>ty_obj_attribute_tt.
FIELD-SYMBOLS: <lv_clsname> TYPE seoclsname.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE cg_properties TO <lv_clsname>.
ASSERT sy-subrc = 0.
" Get existing class properties and attributes and check if the class
" needs to be created/updated (or is the same)
IF iv_check = abap_true.
ls_class_key-clsname = <lv_clsname>.
ls_properties = zif_abapgit_oo_object_fnc~get_class_properties( ls_class_key ).
lt_attributes = zif_abapgit_oo_object_fnc~read_attributes( <lv_clsname> ).
IF ls_properties = cg_properties AND lt_attributes = it_attributes.
RETURN.
ENDIF.
ENDIF.
lt_vseoattrib = convert_attrib_to_vseoattrib(
iv_clsname = <lv_clsname>
it_attributes = it_attributes ).
" Hardcode STATE (#2612)
ls_properties = cg_properties.
ls_properties-state = seoc_state_implemented.
TRY.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
suppress_dialog = abap_true " Parameter missing in 702
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
ENDTRY.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
zcl_abapgit_sotr_handler=>create_sotr(
iv_package = iv_package
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>create_sots(
iv_package = iv_package
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~delete.
" SEO_CLASS_DELETE_COMPLETE deletes OTR usage, only
" Use handler to also delete OTR header and texts
zcl_abapgit_sotr_handler=>delete_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
zcl_abapgit_sots_handler=>delete_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
CALL FUNCTION 'SEO_CLASS_DELETE_COMPLETE'
EXPORTING
clskey = is_deletion_key
EXCEPTIONS
not_existing = 1
is_interface = 2
db_error = 3
no_access = 4
other = 5
OTHERS = 6.
IF sy-subrc = 1.
* ignore deletion of objects that does not exist
* this can happen when the SXCI object is deleted before the implementing CLAS
RETURN.
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~deserialize_source.
DATA: lv_updated TYPE abap_bool,
lv_program TYPE program,
lo_scanner TYPE REF TO cl_oo_source_scanner_class,
lt_methods TYPE cl_oo_source_scanner_class=>type_method_implementations,
lt_incls TYPE seop_methods_w_include,
lv_method LIKE LINE OF lt_methods,
lt_public TYPE seop_source_string,
lt_source TYPE seop_source_string.
"Buffer needs to be refreshed,
"otherwise standard SAP CLIF_SOURCE reorder methods alphabetically
CALL FUNCTION 'SEO_BUFFER_INIT'.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = is_key
version = seoc_version_inactive.
lo_scanner = init_scanner(
it_source = it_source
iv_name = is_key-clsname ).
* public
lt_public = lo_scanner->get_public_section_source( ).
IF lt_public IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_pubsec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_public ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_public
it_source = lt_public ).
ENDIF.
ENDIF.
* protected
lt_source = lo_scanner->get_protected_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prosec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_protected
it_source = lt_source ).
ENDIF.
ENDIF.
* private
lt_source = lo_scanner->get_private_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prisec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_private
it_source = lt_source ).
ENDIF.
ENDIF.
* methods
lt_methods = lo_scanner->get_method_implementations( ).
lt_incls = get_method_includes( is_key-clsname ).
LOOP AT lt_methods INTO lv_method.
TRY.
lt_source = lo_scanner->get_method_impl_source( lv_method ).
CATCH cx_oo_clif_component.
zcx_abapgit_exception=>raise( 'error from GET_METHOD_IMPL_SOURCE' ).
ENDTRY.
lv_program = determine_method_include(
iv_name = is_key-clsname
iv_method = lv_method ).
update_report(
iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
" If method was implemented before, remove from list
DELETE lt_incls WHERE cpdkey-clsname = is_key-clsname AND cpdkey-cpdname = lv_method.
ENDLOOP.
* full class include
update_full_class_include( iv_classname = is_key-clsname
iv_package = iv_package
iv_version = iv_version
it_source = it_source
it_methods = lt_methods ).
" If there are leftover method includes, then class needs to be repaired
" which will delete the obsolete includes
IF lt_incls IS NOT INITIAL.
repair_classpool( is_key ).
repair_redefinitions( is_key ).
ENDIF.
update_source_index(
iv_clsname = is_key-clsname
io_scanner = lo_scanner ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~exists.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = is_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2
is_interface = 3
no_text = 4
inconsistent = 5
OTHERS = 6.
rv_exists = boolc( sy-subrc = 0 OR sy-subrc = 4 ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~generate_locals.
DATA: lv_program TYPE syrepid.
IF lines( it_local_definitions ) > 0.
lv_program = cl_oo_classname_service=>get_ccdef_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_definitions ).
ENDIF.
IF lines( it_local_implementations ) > 0.
lv_program = cl_oo_classname_service=>get_ccimp_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_implementations ).
ENDIF.
IF lines( it_local_macros ) > 0.
lv_program = cl_oo_classname_service=>get_ccmac_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_macros ).
ENDIF.
lv_program = cl_oo_classname_service=>get_ccau_name( is_key-clsname ).
IF lines( it_local_test_classes ) > 0.
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_test_classes ).
ELSE.
" Drop the include to remove left-over test classes
delete_report( lv_program ).
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_class_properties.
CALL FUNCTION 'SEO_CLIF_GET'
EXPORTING
cifkey = is_class_key
version = seoc_version_active
IMPORTING
class = rs_class_properties
EXCEPTIONS
not_existing = 1
deleted = 2
model_only = 3
OTHERS = 4.
IF sy-subrc = 1.
RETURN. " in case only inactive version exists
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR:
" TODO 2023-08-01: Clear rs_class_properties-state (#2612)
rs_class_properties-uuid,
rs_class_properties-author,
rs_class_properties-createdon,
rs_class_properties-changedby,
rs_class_properties-changedon,
rs_class_properties-r3release,
rs_class_properties-chgdanyby,
rs_class_properties-chgdanyon,
rs_class_properties-clsfinal,
rs_class_properties-clsabstrct,
rs_class_properties-exposure,
rs_class_properties-version.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~get_includes.
* note: includes returned might not exist
* method cl_oo_classname_service=>GET_ALL_CLASS_INCLUDES does not exist in 702
DATA: lv_class_name TYPE seoclsname,
lt_methods TYPE seop_methods_w_include.
FIELD-SYMBOLS: <ls_method> LIKE LINE OF lt_methods.
lv_class_name = iv_object_name.
APPEND cl_oo_classname_service=>get_ccdef_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccmac_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccimp_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_cl_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccau_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_pubsec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prosec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prisec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_classpool_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ct_name( lv_class_name ) TO rt_includes.
* skip the CS include, as it is sometimes generated on the fly instead of
* when the methods are changed
cl_oo_classname_service=>get_all_method_includes(
EXPORTING
clsname = lv_class_name
RECEIVING
result = lt_methods
EXCEPTIONS
class_not_existing = 1 ).
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Class { lv_class_name } not existing| ).
ENDIF.
LOOP AT lt_methods ASSIGNING <ls_method>.
APPEND <ls_method>-incname TO rt_includes.
ENDLOOP.
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
INSERT TEXTPOOL lv_cp
FROM it_text_pool
LANGUAGE iv_language
STATE iv_state.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
zcl_abapgit_objects_activation=>add( iv_type = 'REPT'
iv_name = lv_cp ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_sotr.
zcl_abapgit_sotr_handler=>read_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
zcl_abapgit_sots_handler=>read_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~read_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
READ TEXTPOOL lv_cp INTO rt_text_pool LANGUAGE iv_language. "#EC CI_READ_REP
ENDMETHOD.
METHOD zif_abapgit_oo_object_fnc~syntax_check.
DATA:
ls_clskey TYPE seoclskey,
lv_syntaxerror TYPE abap_bool.
ls_clskey-clsname = to_upper( iv_object_name ).
CALL FUNCTION 'SEO_CLASS_CHECK_CLASSPOOL'
EXPORTING
clskey = ls_clskey
suppress_error_popup = abap_true
IMPORTING
syntaxerror = lv_syntaxerror
EXCEPTIONS
_internal_class_not_existing = 1
error_message = 2 " suppress S-message
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
IF lv_syntaxerror = abap_true.
zcx_abapgit_exception=>raise( |Class { ls_clskey-clsname } has syntax errors | ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INSERT TEXTPOOL lv_cp
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 2,036 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CASE <ls_e071>-object.
WHEN 'SICF'. " ICF Service
SELECT SINGLE icf_docu FROM icfdocu INTO ls_e071_txt-text
WHERE icf_name = <ls_e071>-obj_name(15)
AND icfparguid = <ls_e071>-obj_name+15(25)
AND icf_langu = sy-langu.
WHEN 'TOBJ' OR 'OBJM'. " Transport object or AIM
lv_len = strlen( <ls_e071>-obj_name ) - 1.
lv_objectname = <ls_e071>-obj_name(lv_len).
lv_objecttype = <ls_e071>-obj_name+lv_len(1).
CALL FUNCTION 'CTO_OBJECT_GET_DDIC_TEXT'
EXPORTING
iv_objectname = lv_objectname
iv_objecttype = lv_objecttype
iv_language = sy-langu
IMPORTING
es_objt = ls_objt
ev_objt_doesnt_exist = lv_objt.
IF lv_objt IS INITIAL.
ls_e071_txt-text = ls_objt-ddtext.
ELSE.
SELECT SINGLE ddtext FROM objt INTO ls_e071_txt-text
WHERE language = sy-langu
AND objectname = lv_objectname
AND objecttype = lv_objecttype.
ENDIF.
WHEN 'OBJA'. " After import method (api)
lv_tabname = 'SLAPITX'.
SELECT SINGLE description FROM (lv_tabname) INTO ls_e071_txt-text
WHERE language = sy-langu
AND api_id = <ls_e071>-obj_name.
WHEN 'DOCU'. " Documentation
ls_e071_txt-text = ls_e071_txt-name.
WHEN 'DOCT'. " General Text
ls_e071_txt-text = ls_e071_txt-name.
WHEN 'DOCV'. " Documentation (Independent)
ls_e071_txt-text = ls_e071_txt-name.
WHEN 'NSPC'. " Namespace
SELECT SINGLE descriptn FROM trnspacett INTO ls_e071_txt-text
WHERE spras = sy-langu
AND namespace = <ls_e071>-obj_name.
WHEN 'CDAT'. " View Cluster Maintenance: Data
lv_objectname = <ls_e071>-obj_name.
lv_objecttype = <ls_e071>-object(1).
CALL FUNCTION 'CTO_OBJECT_GET_DDIC_TEXT'
EXPORTING
iv_objectname = lv_objectname
iv_objecttype = lv_objecttype
iv_language = sy-langu
IMPORTING
es_objt = ls_objt
ev_objt_doesnt_exist = lv_objt.
IF lv_objt IS INITIAL.
ls_e071_txt-text = ls_objt-ddtext.
ENDIF.
WHEN 'TDAT'. " Customizing: Table Contents
SELECT SINGLE ddtext FROM objt INTO ls_e071_txt-text
WHERE language = sy-langu
AND objectname = <ls_e071>-obj_name
AND objecttype = 'T'.
WHEN 'STCS'. " Task List
SELECT SINGLE descr FROM stc_scn_hdr_t INTO ls_e071_txt-text
WHERE langu = sy-langu
AND scenario_id = <ls_e071>-obj_name.
WHEN 'BMFR'. " Application component
SELECT SINGLE name FROM df14t INTO ls_e071_txt-text
WHERE langu = sy-langu
AND addon = ''
AND fctr_id = <ls_e071>-obj_name
AND as4local = 'A'.
WHEN 'AOBJ'. " Archiving object
SELECT SINGLE objtext FROM arch_txt INTO ls_e071_txt-text
WHERE langu = sy-langu
AND object = <ls_e071>-obj_name.
WHEN 'AVAS'. " Classification
SELECT SINGLE trobjtype sobj_name FROM cls_assignment
INTO (lv_obj_type, lv_obj_name)
WHERE guid = <ls_e071>-obj_name ##WARN_OK.
IF sy-subrc = 0.
CONCATENATE lv_obj_type lv_obj_name INTO ls_e071_txt-text
SEPARATED BY space.
ENDIF.
WHEN 'SFBF' OR 'SFB2'. " Business Function
SELECT SINGLE name80 FROM sfw_bft INTO ls_e071_txt-text
WHERE spras = sy-langu
AND bfunction = <ls_e071>-obj_name.
WHEN 'SFBS' OR 'SFB1'. " Business Set
SELECT SINGLE name80 FROM sfw_bst INTO ls_e071_txt-text
WHERE spras = sy-langu
AND bset = <ls_e071>-obj_name.
WHEN 'SFSW'. " Switch
SELECT SINGLE name80 FROM sfw_switcht INTO ls_e071_txt-text
WHERE spras = sy-langu
AND switch_id = <ls_e071>-obj_name.
WHEN 'WGRP'. " Object Type Group
SELECT SINGLE group_name FROM objtypegroups_t INTO ls_e071_txt-text
WHERE language = sy-langu
AND objtype_group = <ls_e071>-obj_name
AND ai_version = 'A'.
WHEN 'CUS0'. " IMG Activity
SELECT SINGLE text FROM cus_imgact INTO ls_e071_txt-text
WHERE spras = sy-langu
AND activity = <ls_e071>-obj_name.
WHEN 'CUS1'. " Customizing Activity
SELECT SINGLE text FROM cus_actt INTO ls_e071_txt-text
WHERE spras = sy-langu
AND act_id = <ls_e071>-obj_name.
WHEN 'CUS2'. " Customizing Attributes
SELECT SINGLE text FROM cus_atrt INTO ls_e071_txt-text
WHERE spras = sy-langu
AND attr_id = <ls_e071>-obj_name.
WHEN 'NROB'. " Number Range
SELECT SINGLE txt FROM tnrot INTO ls_e071_txt-text
WHERE object = <ls_e071>-obj_name
AND langu = sy-langu.
WHEN 'JOBD'. " Job Definition
lv_tabname = 'STJR_JOBD_ROOT'.
CALL FUNCTION 'DB_EXISTS_TABLE'
EXPORTING
tabname = lv_tabname
IMPORTING
subrc = lv_subrc.
IF lv_subrc = 0.
SELECT SINGLE btcjob_name FROM (lv_tabname) INTO ls_e071_txt-text
WHERE name = <ls_e071>-obj_name.
ENDIF.
WHEN 'WAPP'. " BSP Page
SELECT SINGLE descript FROM o2pagdirt INTO ls_e071_txt-text
WHERE applname = <ls_e071>-obj_name(30)
AND pagekey = <ls_e071>-obj_name+30(*)
AND langu = sy-langu.
WHEN 'VCLS'. " View Cluster
SELECT SINGLE text FROM vcldirt INTO ls_e071_txt-text
WHERE vclname = <ls_e071>-obj_name
AND spras = sy-langu.
WHEN 'VARI' OR 'VARX'. " Variants
ls_e071_txt-text = get_variant_text( <ls_e071>-obj_name ).
WHEN 'SUSC'. " Authorization object class
SELECT SINGLE ctext FROM tobct INTO ls_e071_txt-text
WHERE oclss = <ls_e071>-obj_name
AND langu = sy-langu.
WHEN 'W3HT'. " WWW HTML Templates
SELECT SINGLE text FROM wwwdata INTO ls_e071_txt-text
WHERE relid = 'HT'
AND objid = <ls_e071>-obj_name
AND srtf2 = 0.
WHEN 'W3MI'. " WWW Mime
SELECT SINGLE text FROM wwwdata INTO ls_e071_txt-text
WHERE relid = 'MI'
AND objid = <ls_e071>-obj_name
AND srtf2 = 0.
WHEN 'AVAR'. " Activation Variants
SELECT SINGLE descript FROM aab_var_propt INTO ls_e071_txt-text
WHERE name = <ls_e071>-obj_name
AND local = ''
AND langu = sy-langu.
WHEN 'SHI5'. " Gen. hierarchy storage extrension name
SELECT SINGLE text FROM ttree_extt INTO ls_e071_txt-text
WHERE extension = <ls_e071>-obj_name
AND spras = sy-langu.
WHEN OTHERS.
ASSERT 0 = 1. " Check class constructor
ENDCASE.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE description FROM (lv_tabname) INTO ls_e071_txt-text
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,063 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lv_subrc = 0.
SELECT SINGLE btcjob_name FROM (lv_tabname) INTO ls_e071_txt-text
WHERE name = <ls_e071>-obj_name.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE btcjob_name FROM (lv_tabname) INTO ls_e071_txt-text
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,064 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CASE <ls_e071>-object.
WHEN 'SICF'. " ICF Service
SELECT SINGLE icf_docu FROM icfdocu INTO ls_e071_txt-text
WHERE icf_name = <ls_e071>-obj_name(15)
AND icfparguid = <ls_e071>-obj_name+15(25)
AND icf_langu = sy-langu.
WHEN 'TOBJ' OR 'OBJM'. " Transport object or AIM
lv_len = strlen( <ls_e071>-obj_name ) - 1.
lv_objectname = <ls_e071>-obj_name(lv_len).
lv_objecttype = <ls_e071>-obj_name+lv_len(1).
CALL FUNCTION 'CTO_OBJECT_GET_DDIC_TEXT'
EXPORTING
iv_objectname = lv_objectname
iv_objecttype = lv_objecttype
iv_language = sy-langu
IMPORTING
es_objt = ls_objt
ev_objt_doesnt_exist = lv_objt.
IF lv_objt IS INITIAL.
ls_e071_txt-text = ls_objt-ddtext.
ELSE.
SELECT SINGLE ddtext FROM objt INTO ls_e071_txt-text
WHERE language = sy-langu
AND objectname = lv_objectname
AND objecttype = lv_objecttype.
ENDIF.
WHEN 'OBJA'. " After import method (api)
lv_tabname = 'SLAPITX'.
SELECT SINGLE description FROM (lv_tabname) INTO ls_e071_txt-text
WHERE language = sy-langu
AND api_id = <ls_e071>-obj_name.
WHEN 'DOCU' " Documentation
OR 'DOCT' " General Text
OR 'DOCV' " Documentation (Independent)
OR 'DSYS'. " Chapter of a Book Structure
ls_e071_txt-text = get_documentation_text(
iv_object = <ls_e071>-object
iv_obj_name = <ls_e071>-obj_name ).
WHEN 'NSPC'. " Namespace
SELECT SINGLE descriptn FROM trnspacett INTO ls_e071_txt-text
WHERE spras = sy-langu
AND namespace = <ls_e071>-obj_name.
WHEN 'CDAT'. " View Cluster Maintenance: Data
lv_objectname = <ls_e071>-obj_name.
lv_objecttype = <ls_e071>-object(1).
CALL FUNCTION 'CTO_OBJECT_GET_DDIC_TEXT'
EXPORTING
iv_objectname = lv_objectname
iv_objecttype = lv_objecttype
iv_language = sy-langu
IMPORTING
es_objt = ls_objt
ev_objt_doesnt_exist = lv_objt.
IF lv_objt IS INITIAL.
ls_e071_txt-text = ls_objt-ddtext.
ENDIF.
WHEN 'TDAT'. " Customizing: Table Contents
SELECT SINGLE ddtext FROM objt INTO ls_e071_txt-text
WHERE language = sy-langu
AND objectname = <ls_e071>-obj_name
AND objecttype = 'T'.
WHEN 'STCS'. " Task List
SELECT SINGLE descr FROM stc_scn_hdr_t INTO ls_e071_txt-text
WHERE langu = sy-langu
AND scenario_id = <ls_e071>-obj_name.
WHEN 'BMFR'. " Application component
SELECT SINGLE name FROM df14t INTO ls_e071_txt-text
WHERE langu = sy-langu
AND addon = ''
AND fctr_id = <ls_e071>-obj_name
AND as4local = 'A'.
WHEN 'AOBJ'. " Archiving object
SELECT SINGLE objtext FROM arch_txt INTO ls_e071_txt-text
WHERE langu = sy-langu
AND object = <ls_e071>-obj_name.
WHEN 'AVAS'. " Classification
SELECT SINGLE trobjtype sobj_name FROM cls_assignment
INTO (lv_obj_type, lv_obj_name)
WHERE guid = <ls_e071>-obj_name ##WARN_OK.
IF sy-subrc = 0.
CONCATENATE lv_obj_type lv_obj_name INTO ls_e071_txt-text
SEPARATED BY space.
ENDIF.
WHEN 'SFBF' OR 'SFB2'. " Business Function
SELECT SINGLE name80 FROM sfw_bft INTO ls_e071_txt-text
WHERE spras = sy-langu
AND bfunction = <ls_e071>-obj_name.
WHEN 'SFBS' OR 'SFB1'. " Business Set
SELECT SINGLE name80 FROM sfw_bst INTO ls_e071_txt-text
WHERE spras = sy-langu
AND bset = <ls_e071>-obj_name.
WHEN 'SFSW'. " Switch
SELECT SINGLE name80 FROM sfw_switcht INTO ls_e071_txt-text
WHERE spras = sy-langu
AND switch_id = <ls_e071>-obj_name.
WHEN 'WGRP'. " Object Type Group
SELECT SINGLE group_name FROM objtypegroups_t INTO ls_e071_txt-text
WHERE language = sy-langu
AND objtype_group = <ls_e071>-obj_name
AND ai_version = 'A'.
WHEN 'CUS0'. " IMG Activity
SELECT SINGLE text FROM cus_imgact INTO ls_e071_txt-text
WHERE spras = sy-langu
AND activity = <ls_e071>-obj_name.
WHEN 'CUS1'. " Customizing Activity
SELECT SINGLE text FROM cus_actt INTO ls_e071_txt-text
WHERE spras = sy-langu
AND act_id = <ls_e071>-obj_name.
WHEN 'CUS2'. " Customizing Attributes
SELECT SINGLE text FROM cus_atrt INTO ls_e071_txt-text
WHERE spras = sy-langu
AND attr_id = <ls_e071>-obj_name.
WHEN 'NROB'. " Number Range
SELECT SINGLE txt FROM tnrot INTO ls_e071_txt-text
WHERE object = <ls_e071>-obj_name
AND langu = sy-langu.
WHEN 'JOBD'. " Job Definition
lv_tabname = 'STJR_JOBD_ROOT'.
CALL FUNCTION 'DB_EXISTS_TABLE'
EXPORTING
tabname = lv_tabname
IMPORTING
subrc = lv_subrc.
IF lv_subrc = 0.
SELECT SINGLE btcjob_name FROM (lv_tabname) INTO ls_e071_txt-text
WHERE name = <ls_e071>-obj_name.
ENDIF.
WHEN 'WAPP'. " BSP Page
SELECT SINGLE descript FROM o2pagdirt INTO ls_e071_txt-text
WHERE applname = <ls_e071>-obj_name(30)
AND pagekey = <ls_e071>-obj_name+30(*)
AND langu = sy-langu.
WHEN 'VCLS'. " View Cluster
SELECT SINGLE text FROM vcldirt INTO ls_e071_txt-text
WHERE vclname = <ls_e071>-obj_name
AND spras = sy-langu.
WHEN 'VARI' OR 'VARX'. " Variants
ls_e071_txt-text = get_variant_text( <ls_e071>-obj_name ).
WHEN 'SUSC'. " Authorization object class
SELECT SINGLE ctext FROM tobct INTO ls_e071_txt-text
WHERE oclss = <ls_e071>-obj_name
AND langu = sy-langu.
WHEN 'W3HT'. " WWW HTML Templates
SELECT SINGLE text FROM wwwdata INTO ls_e071_txt-text
WHERE relid = 'HT'
AND objid = <ls_e071>-obj_name
AND srtf2 = 0.
WHEN 'W3MI'. " WWW Mime
SELECT SINGLE text FROM wwwdata INTO ls_e071_txt-text
WHERE relid = 'MI'
AND objid = <ls_e071>-obj_name
AND srtf2 = 0.
WHEN 'AVAR'. " Activation Variants
SELECT SINGLE descript FROM aab_var_propt INTO ls_e071_txt-text
WHERE name = <ls_e071>-obj_name
AND local = ''
AND langu = sy-langu.
WHEN 'SHI5'. " Gen. hierarchy storage extension name
SELECT SINGLE text FROM ttree_extt INTO ls_e071_txt-text
WHERE extension = <ls_e071>-obj_name
AND spras = sy-langu.
WHEN OTHERS.
ASSERT 0 = 1. " Check class constructor
ENDCASE.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE description FROM (lv_tabname) INTO ls_e071_txt-text
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,065 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD appinfoset_create_entity.
DATA: ls_appinfo TYPE /mindset/cl_fiori_moni_mpc_ext=>ts_appinfo,
ls_appinfo_db TYPE /mindset/appinfo.
io_data_provider->read_entry_data( IMPORTING es_data = ls_appinfo ).
ls_appinfo_db = CORRESPONDING #( ls_appinfo ).
ls_appinfo_db-user_id = sy-uname.
GET TIME STAMP FIELD ls_appinfo_db-log_time.
INSERT /mindset/appinfo FROM ls_appinfo_db.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT /mindset/appinfo FROM ls_appinfo_db.
```
Explanation: Modify only own DB tables. | 2,067 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD flpinfoset_create_entity.
DATA: ls_flpinfo TYPE /mindset/cl_fiori_moni_mpc_ext=>ts_flpinfo,
ls_flpinfo_db TYPE /mindset/flpinfo.
io_data_provider->read_entry_data( IMPORTING es_data = ls_flpinfo ).
ls_flpinfo_db = CORRESPONDING #( ls_flpinfo ).
ls_flpinfo_db-user_id = sy-uname.
GET TIME STAMP FIELD ls_flpinfo_db-log_time.
INSERT /mindset/flpinfo FROM ls_flpinfo_db.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT /mindset/flpinfo FROM ls_flpinfo_db.
```
Explanation: Modify only own DB tables. | 2,068 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD appinfoset_create_entity.
DATA: ls_appinfo TYPE /mindset/cl_fiori_moni_mpc_ext=>ts_appinfo,
ls_appinfo_db TYPE /mindset/appinfo,
ls_flpinfo_db TYPE /mindset/flpinfo.
*** FILL appinfo and flpinfo every time a user clicks a semantic object
io_data_provider->read_entry_data( IMPORTING es_data = ls_appinfo ).
ls_appinfo_db = CORRESPONDING #( ls_appinfo ).
ls_flpinfo_db = CORRESPONDING #( ls_appinfo ).
ls_appinfo_db-user_id = sy-uname.
GET TIME STAMP FIELD ls_appinfo_db-log_time.
GET TIME STAMP FIELD ls_flpinfo_db-log_time.
INSERT /mindset/appinfo FROM ls_appinfo_db.
INSERT /mindset/flpinfo FROM ls_flpinfo_db.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT /mindset/appinfo FROM ls_appinfo_db.
```
Explanation: Modify only own DB tables.
```abap
INSERT /mindset/appinfo FROM ls_appinfo_db.
INSERT /mindset/flpinfo FROM ls_flpinfo_db. * <-- There is a problem here
ENDMETHOD.
```
Explanation: Modify only own DB tables. | 2,069 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD flpinfoset_create_entity.
DATA: ls_flpinfo TYPE /mindset/cl_fiori_moni_mpc_ext=>ts_flpinfo,
ls_flpinfo_db TYPE /mindset/flpinfo.
io_data_provider->read_entry_data( IMPORTING es_data = ls_flpinfo ).
ls_flpinfo_db = CORRESPONDING #( ls_flpinfo ).
ls_flpinfo_db-user_id = sy-uname.
GET TIME STAMP FIELD ls_flpinfo_db-log_time.
INSERT /mindset/flpinfo FROM ls_flpinfo_db.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
GET TIME STAMP FIELD ls_flpinfo_db-log_time.
INSERT /mindset/flpinfo FROM ls_flpinfo_db. * <-- There is a problem here
ENDMETHOD.
```
Explanation: Modify only own DB tables. | 2,070 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE spras = @sy-langu
AND (where_cond). "#EC CI_SUBRC
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,073 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_data_by_table.
DATA: description_component TYPE string,
table_name TYPE tabname,
table TYPE REF TO data,
checkfield TYPE dd08v-fieldname,
table_ref TYPE REF TO cl_abap_tabledescr,
keys TYPE ddfields,
structure TYPE REF TO cl_abap_structdescr.
FIELD-SYMBOLS:
<table_values> TYPE ANY TABLE,
<texttable_value> TYPE ANY TABLE.
table_name = i_customizing-tabname.
description_component = i_customizing-description_field.
CREATE DATA table TYPE TABLE OF (table_name).
ASSIGN table->* TO <table_values>.
table_ref ?= cl_abap_tabledescr=>describe_by_data( <table_values> ).
structure ?= table_ref->get_table_line_type( ).
structure->get_ddic_field_list(
RECEIVING
p_field_list = keys " List of Dictionary Descriptions for the Components
EXCEPTIONS
not_found = 1 " Type could not be found
no_ddic_type = 2 " Typ is not a dictionary type
OTHERS = 3
).
DELETE keys WHERE keyflag <> abap_true.
DATA(components) = structure->get_components( ).
DATA(where_cond) = me->build_where_condition( i_customizing ).
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE spras = @sy-langu
AND (where_cond). "#EC CI_SUBRC
ELSE.
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE (where_cond)."#EC CI_SUBRC
DATA(texttable) = get_texttable(
EXPORTING
i_table_name = table_name
IMPORTING
e_checkfield = checkfield ).
ENDIF.
IF texttable IS INITIAL.
checkfield = i_customizing-data_element.
ELSE.
CREATE DATA table TYPE TABLE OF (texttable).
ASSIGN table->* TO <texttable_value>.
DATA: test TYPE string.
SELECT *
FROM (texttable)
INTO TABLE @<texttable_value>
WHERE spras = @sy-langu
AND (test). "#EC CI_SUBRC
ENDIF.
LOOP AT <table_values> ASSIGNING FIELD-SYMBOL(<table_value>).
APPEND INITIAL LINE TO r_value_help ASSIGNING FIELD-SYMBOL(<value_help>).
ASSIGN COMPONENT checkfield OF STRUCTURE <table_value> TO FIELD-SYMBOL(<value>).
if sy-subrc <> 0.
continue.
endif.
<value_help>-search_help = i_customizing-id.
<value_help>-value = <value>.
IF <texttable_value> IS ASSIGNED.
LOOP AT <texttable_value> ASSIGNING FIELD-SYMBOL(<texttable>).
ASSIGN COMPONENT checkfield OF STRUCTURE <texttable> TO FIELD-SYMBOL(<t_id_value>).
if sy-subrc <> 0.
continue.
endif.
CHECK <t_id_value> = <value>.
ASSIGN COMPONENT description_component OF STRUCTURE <texttable> TO FIELD-SYMBOL(<description>).
if sy-subrc <> 0.
continue.
endif.
<value_help>-description = <description>.
DELETE TABLE <texttable_value> FROM <texttable>.
EXIT.
ENDLOOP.
ELSE.
ASSIGN COMPONENT description_component OF STRUCTURE <table_value> TO <description>.
if sy-subrc <> 0.
continue.
endif.
<value_help>-description = <description>.
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ELSE.
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
SELECT * * <-- There is a problem here
FROM (texttable)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,074 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_ACTIONS.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_ACTIONS WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_ACTIONS WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,075 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_ACTPARA.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_ACT_PARAM WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_ACT_PARAM WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,076 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_ENTITY.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_ENTITY WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_ENTITY WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,077 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_NAV.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_NAV WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_NAV WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,078 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_PROP.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_PROPERTY WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_PROPERTY WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,079 |
Find vulnerabilities in this ABAP code snippet. | ```abap
FORM GET_DATA_ZODATA_V_PROPTXT.
PERFORM VIM_FILL_WHERETAB.
*.read data from database.............................................*
REFRESH TOTAL.
CLEAR TOTAL.
SELECT * FROM ZODATA_PROP_TXTS WHERE
(VIM_WHERETAB) .
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM ZODATA_PROP_TXTS WHERE
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,080 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE <table_values>
WHERE spras = sy-langu
AND (where_cond).
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,081 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_data_by_table.
DATA: description_component TYPE string,
table_name TYPE tabname,
table TYPE REF TO data,
checkfield TYPE dd08v-fieldname,
table_ref TYPE REF TO cl_abap_tabledescr,
keys TYPE ddfields,
structure TYPE REF TO cl_abap_structdescr.
FIELD-SYMBOLS:
<table_values> TYPE ANY TABLE,
<texttable_value> TYPE ANY TABLE.
table_name = i_customizing-tabname.
description_component = i_customizing-description_field.
CREATE DATA table TYPE TABLE OF (table_name).
ASSIGN table->* TO <table_values>.
table_ref ?= cl_abap_tabledescr=>describe_by_data( <table_values> ).
structure ?= table_ref->get_table_line_type( ).
structure->get_ddic_field_list(
RECEIVING
p_field_list = keys " List of Dictionary Descriptions for the Components
EXCEPTIONS
not_found = 1 " Type could not be found
no_ddic_type = 2 " Typ is not a dictionary type
OTHERS = 3
).
DELETE keys WHERE keyflag <> abap_true.
DATA(components) = structure->get_components( ).
DATA(where_cond) = me->build_where_condition( i_customizing ).
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE <table_values>
WHERE spras = sy-langu
AND (where_cond).
ELSE.
SELECT *
FROM (table_name)
INTO TABLE <table_values>
WHERE (where_cond).
DATA(texttable) = get_texttable(
EXPORTING
i_table_name = table_name
IMPORTING
e_checkfield = checkfield ).
ENDIF.
IF texttable IS INITIAL.
checkfield = i_customizing-data_element.
ELSE.
CREATE DATA table TYPE TABLE OF (texttable).
ASSIGN table->* TO <texttable_value>.
DATA: test TYPE string.
SELECT *
FROM (texttable)
INTO TABLE <texttable_value>
WHERE spras = sy-langu
AND (test).
ENDIF.
LOOP AT <table_values> ASSIGNING FIELD-SYMBOL(<table_value>).
APPEND INITIAL LINE TO r_value_help ASSIGNING FIELD-SYMBOL(<value_help>).
ASSIGN COMPONENT checkfield OF STRUCTURE <table_value> TO FIELD-SYMBOL(<value>).
<value_help>-search_help = i_customizing-id.
<value_help>-value = <value>.
IF <texttable_value> IS ASSIGNED.
LOOP AT <texttable_value> ASSIGNING FIELD-SYMBOL(<texttable>).
ASSIGN COMPONENT checkfield OF STRUCTURE <texttable> TO FIELD-SYMBOL(<t_id_value>).
CHECK <t_id_value> = <value>.
ASSIGN COMPONENT description_component OF STRUCTURE <texttable> TO FIELD-SYMBOL(<description>).
<value_help>-description = <description>.
DELETE TABLE <texttable_value> FROM <texttable>.
EXIT.
ENDLOOP.
ELSE.
ASSIGN COMPONENT description_component OF STRUCTURE <table_value> TO <description>.
<value_help>-description = <description>.
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ELSE.
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
SELECT * * <-- There is a problem here
FROM (texttable)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,082 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE spras = @sy-langu
AND (where_cond). "#EC CI_SUBRC
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,083 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_data_by_table.
DATA: description_component TYPE string,
table_name TYPE tabname,
table TYPE REF TO data,
checkfield TYPE dd08v-fieldname,
table_ref TYPE REF TO cl_abap_tabledescr,
keys TYPE ddfields,
structure TYPE REF TO cl_abap_structdescr.
FIELD-SYMBOLS:
<table_values> TYPE ANY TABLE,
<texttable_value> TYPE ANY TABLE.
table_name = i_customizing-tabname.
description_component = i_customizing-description_field.
CREATE DATA table TYPE TABLE OF (table_name).
ASSIGN table->* TO <table_values>.
table_ref ?= cl_abap_tabledescr=>describe_by_data( <table_values> ).
structure ?= table_ref->get_table_line_type( ).
structure->get_ddic_field_list(
RECEIVING
p_field_list = keys " List of Dictionary Descriptions for the Components
EXCEPTIONS
not_found = 1 " Type could not be found
no_ddic_type = 2 " Typ is not a dictionary type
OTHERS = 3
).
DELETE keys WHERE keyflag <> abap_true.
DATA(components) = structure->get_components( ).
DATA(where_cond) = me->build_where_condition( i_customizing ).
IF line_exists( components[ name = 'SPRAS' ] ) AND line_exists( keys[ fieldname = 'SPRAS' ] ).
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE spras = @sy-langu
AND (where_cond). "#EC CI_SUBRC
ELSE.
SELECT *
FROM (table_name)
INTO TABLE @<table_values>
WHERE (where_cond)."#EC CI_SUBRC
DATA(texttable) = get_texttable(
EXPORTING
i_table_name = table_name
IMPORTING
e_checkfield = checkfield ).
ENDIF.
IF texttable IS INITIAL.
checkfield = i_customizing-data_element.
ELSE.
CREATE DATA table TYPE TABLE OF (texttable).
ASSIGN table->* TO <texttable_value>.
DATA: test TYPE string.
SELECT *
FROM (texttable)
INTO TABLE @<texttable_value>
WHERE spras = @sy-langu
AND (test). "#EC CI_SUBRC
ENDIF.
LOOP AT <table_values> ASSIGNING FIELD-SYMBOL(<table_value>).
APPEND INITIAL LINE TO r_value_help ASSIGNING FIELD-SYMBOL(<value_help>).
ASSIGN COMPONENT checkfield OF STRUCTURE <table_value> TO FIELD-SYMBOL(<value>).
if sy-subrc <> 0.
continue.
endif.
<value_help>-search_help = i_customizing-id.
<value_help>-value = <value>.
IF <texttable_value> IS ASSIGNED.
LOOP AT <texttable_value> ASSIGNING FIELD-SYMBOL(<texttable>).
ASSIGN COMPONENT checkfield OF STRUCTURE <texttable> TO FIELD-SYMBOL(<t_id_value>).
if sy-subrc <> 0.
continue.
endif.
CHECK <t_id_value> = <value>.
ASSIGN COMPONENT description_component OF STRUCTURE <texttable> TO FIELD-SYMBOL(<description>).
if sy-subrc <> 0.
continue.
endif.
<value_help>-description = <description>.
DELETE TABLE <texttable_value> FROM <texttable>.
EXIT.
ENDLOOP.
ELSE.
ASSIGN COMPONENT description_component OF STRUCTURE <table_value> TO <description>.
if sy-subrc <> 0.
continue.
endif.
<value_help>-description = <description>.
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ELSE.
SELECT * * <-- There is a problem here
FROM (table_name)
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
SELECT * * <-- There is a problem here
FROM (texttable)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,084 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD read_dyn_table_with_language.
SELECT *
FROM (iv_table_name)
INTO TABLE @et_table_data
WHERE spras = @iv_spras
AND (it_where_condition). "#EC CI_SUBRC
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
METHOD read_dyn_table_with_language.
SELECT * * <-- There is a problem here
FROM (iv_table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,095 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD read_dyn_table.
SELECT *
FROM (iv_table_name)
INTO TABLE @et_table_data
WHERE (it_where_condition). "#EC CI_SUBRC
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
METHOD read_dyn_table.
SELECT * * <-- There is a problem here
FROM (iv_table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,096 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF s_internal-belnr IS NOT INITIAL.
SET PARAMETER ID 'BLN' FIELD s_internal-belnr.
SET PARAMETER ID 'BUK' FIELD s_internal-bukrs.
SET PARAMETER ID 'GJR' FIELD s_internal-budat(4).
CALL TRANSACTION 'FB03' AND SKIP FIRST SCREEN.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
CALL TRANSACTION 'FB03' AND SKIP FIRST SCREEN.
```
Explanation: Add an authority check to CALL TRANSACTION. | 2,127 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD read_table.
FIELD-SYMBOLS <fs> TYPE STANDARD TABLE.
DATA dref TYPE REF TO data.
CREATE DATA dref TYPE STANDARD TABLE OF (mv_table) WITH DEFAULT KEY.
ASSIGN dref->* TO <fs>.
ASSERT sy-subrc = 0.
" dont check SUBRC, the table might be empty
SELECT * FROM (mv_table) ORDER BY PRIMARY KEY INTO TABLE @<fs> ##SUBRC_OK.
rv_json = to_json( dref ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (mv_table) ORDER BY PRIMARY KEY INTO TABLE @<fs> ##SUBRC_OK.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,128 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD save_table.
FIELD-SYMBOLS <fs> TYPE STANDARD TABLE.
DATA dref TYPE REF TO data.
CREATE DATA dref TYPE STANDARD TABLE OF (mv_table) WITH DEFAULT KEY.
ASSIGN dref->* TO <fs>.
ASSERT sy-subrc = 0.
CALL TRANSFORMATION id SOURCE XML iv_json RESULT data = <fs>.
MODIFY (mv_table) FROM TABLE @<fs> ##SUBRC_OK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY (mv_table) FROM TABLE @<fs> ##SUBRC_OK.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,129 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO 100 ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,137 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO 100 ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,139 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO 100 ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,140 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
* CREATE DATA mt_table_del TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
* CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO '100' ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,141 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
* CREATE DATA mt_table_del TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
* CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO 100 ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,143 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.