Instruction stringclasses 1 value | Input stringlengths 79 33k | Response stringlengths 106 9.29k | __index_level_0__ int64 0 2.83k |
|---|---|---|---|
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
* CREATE DATA mt_table_del TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO 100 ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,145 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
* CREATE DATA mt_table_del TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
CREATE DATA ms_table_row TYPE HANDLE new_struct_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>
UP TO '100' ROWS.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,156 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF <del> IS NOT INITIAL.
DELETE (mv_table) FROM TABLE <table>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
CLEAR: mt_table_del.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
DELETE (mv_table) FROM TABLE <table>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,158 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(type_desc) = cl_abap_typedescr=>describe_by_name( mv_table ).
DATA(struct_desc) = CAST cl_abap_structdescr( type_desc ).
DATA(table_desc) = cl_abap_tabledescr=>create(
p_line_type = struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
DATA: o_table TYPE REF TO data.
CREATE DATA o_table TYPE HANDLE table_desc.
FIELD-SYMBOLS <table> TYPE ANY TABLE.
ASSIGN o_table->* TO <table>.
MOVE-CORRESPONDING <del> TO <table>.
IF <del> IS NOT INITIAL.
DELETE (mv_table) FROM TABLE <table>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
CLEAR: mt_table_del.
ENDIF.
ENDIF.
MOVE-CORRESPONDING <tab> TO <table>.
MODIFY (mv_table) FROM TABLE <table>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
client->message_toast_display( `message toast message` ).
ENDIF.
client->view_model_update( ).
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
MODIFY (mv_table) FROM TABLE <table>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,159 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
mt_comp = VALUE cl_abap_structdescr=>component_table(
* ( name = 'SELKZ'
* type = CAST #( cl_abap_datadescr=>describe_by_data( selkz ) ) )
( name = 'ROW_ID'
type = CAST #( cl_abap_datadescr=>describe_by_data( index ) ) ) ).
APPEND LINES OF comp TO mt_comp.
DATA(new_struct_desc) = cl_abap_structdescr=>create( mt_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create(
p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
DATA: o_table TYPE REF TO data.
CREATE DATA o_table TYPE HANDLE new_table_desc.
FIELD-SYMBOLS <table> TYPE ANY TABLE.
ASSIGN o_table->* TO <table>.
SELECT * FROM (mv_table) INTO CORRESPONDING FIELDS OF TABLE <table>.
lo_tab ?= cl_abap_tabledescr=>describe_by_data( <table> ).
CREATE DATA mt_table TYPE HANDLE lo_tab.
ASSIGN mt_table->* TO <fs_tab>.
<fs_tab> = <table>.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (mv_table) INTO CORRESPONDING FIELDS OF TABLE <table>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,160 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_count.
DATA(o_type_desc) = cl_abap_typedescr=>describe_by_name( tabname ).
DATA(o_struct_desc) = CAST cl_abap_structdescr( o_type_desc ).
DATA(new_table_desc) = cl_abap_tabledescr=>create(
p_line_type = o_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
DATA: o_table TYPE REF TO data.
CREATE DATA o_table TYPE HANDLE new_table_desc.
FIELD-SYMBOLS <table> TYPE ANY TABLE.
ASSIGN o_table->* TO <table>.
SELECT * FROM (tabname) INTO CORRESPONDING FIELDS OF TABLE <table>.
result = lines( <table> ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (tabname) INTO CORRESPONDING FIELDS OF TABLE <table>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,161 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF i_log_numbers IS NOT INITIAL.
SELECT mandt lognumber msgnumber record_number
FROM /usi/bal_data
INTO TABLE database_keys
FOR ALL ENTRIES IN i_log_numbers
WHERE lognumber EQ i_log_numbers-table_line.
DELETE /usi/bal_data FROM TABLE database_keys.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
DELETE /usi/bal_data FROM TABLE database_keys.
```
Explanation: Modify only own DB tables. | 2,162 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS /usi/cl_bal_data_cont_coll_dao DEFINITION
PUBLIC
FINAL
CREATE PUBLIC .
PUBLIC SECTION.
INTERFACES /usi/if_bal_data_cont_coll_dao.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES ty_db_record TYPE /usi/bal_data .
TYPES:
ty_db_records TYPE SORTED TABLE OF ty_db_record WITH UNIQUE KEY lognumber msgnumber record_number .
CONSTANTS db_connection TYPE dbcon_name VALUE 'R/3*SAP_2TH_CONNECT_APPL_LOG'.
DATA db_records TYPE ty_db_records .
METHODS convert_xml_to_db
IMPORTING
!i_log_number TYPE balognr
!i_message_number TYPE /usi/bal_message_number
!i_serialized_data_cont_coll TYPE /usi/bal_xml_string
RETURNING
VALUE(r_result) TYPE ty_db_records .
METHODS convert_db_to_xml
IMPORTING
!i_db_records TYPE ty_db_records
RETURNING
VALUE(r_result) TYPE /usi/bal_xml_string .
ENDCLASS.
CLASS /USI/CL_BAL_DATA_CONT_COLL_DAO IMPLEMENTATION.
METHOD /usi/if_bal_data_cont_coll_dao~delete_collections.
TYPES: BEGIN OF ty_database_key,
mandt TYPE mandt,
lognumber TYPE balognr,
msgnumber TYPE /usi/bal_message_number,
record_number TYPE indx_srtf2,
END OF ty_database_key,
ty_database_keys TYPE STANDARD TABLE OF ty_database_key WITH NON-UNIQUE DEFAULT KEY.
DATA database_keys TYPE ty_database_keys.
IF i_log_numbers IS NOT INITIAL.
SELECT mandt lognumber msgnumber record_number
FROM /usi/bal_data
INTO TABLE database_keys
FOR ALL ENTRIES IN i_log_numbers
WHERE lognumber EQ i_log_numbers-table_line.
DELETE /usi/bal_data FROM TABLE database_keys.
ENDIF.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~get_collection.
DATA: db_records TYPE ty_db_records.
SELECT mandt
lognumber
msgnumber
record_number
used_bytes
data
FROM /usi/bal_data
INTO CORRESPONDING FIELDS OF TABLE db_records
CONNECTION (db_connection)
WHERE lognumber EQ i_log_number
AND msgnumber EQ i_message_number.
IF sy-subrc NE 0.
RAISE EXCEPTION TYPE /usi/cx_bal_not_found
EXPORTING
textid = /usi/cx_bal_not_found=>no_db_entries_found.
ENDIF.
r_result = convert_db_to_xml( db_records ).
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~insert_collection_into_buffer.
DATA: new_records TYPE ty_db_records,
message_parameter_1 TYPE symsgv,
message_parameter_2 TYPE symsgv.
FIELD-SYMBOLS <new_record> TYPE ty_db_record.
IF i_serialized_data_cont_coll IS INITIAL.
RETURN.
ENDIF.
new_records = convert_xml_to_db(
i_log_number = i_log_number
i_message_number = i_message_number
i_serialized_data_cont_coll = i_serialized_data_cont_coll
).
LOOP AT new_records ASSIGNING <new_record>.
INSERT <new_record> INTO TABLE db_records.
IF sy-subrc NE 0.
WRITE i_log_number TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
WRITE i_message_number TO message_parameter_2 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_invalid_input
EXPORTING
textid = /usi/cx_bal_invalid_input=>duplicate_buffer_entry
param1 = message_parameter_1
param2 = message_parameter_2.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~save_buffer_to_db.
DATA message_parameter_1 TYPE symsgv.
IF db_records IS INITIAL.
RETURN.
ENDIF.
INSERT /usi/bal_data
CONNECTION (db_connection)
FROM TABLE db_records.
IF sy-subrc EQ 0.
CLEAR db_records.
COMMIT CONNECTION (db_connection).
ELSE.
CLEAR db_records.
WRITE sy-subrc TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_db_error
EXPORTING
textid = /usi/cx_bal_db_error=>/usi/cx_bal_db_error
param1 = message_parameter_1.
ENDIF.
ENDMETHOD.
METHOD convert_db_to_xml.
DATA binary_data TYPE xstring.
FIELD-SYMBOLS <db_record> TYPE ty_db_record.
LOOP AT i_db_records ASSIGNING <db_record>.
CONCATENATE binary_data <db_record>-data(<db_record>-used_bytes) INTO binary_data IN BYTE MODE.
ENDLOOP.
IMPORT serialized_data_cont_coll TO r_result FROM DATA BUFFER binary_data.
ENDMETHOD.
METHOD convert_xml_to_db.
DATA: db_record TYPE ty_db_record,
binary_data TYPE xstring,
bytes_per_record TYPE int4.
bytes_per_record = xstrlen( db_record-data ).
EXPORT serialized_data_cont_coll FROM i_serialized_data_cont_coll TO DATA BUFFER binary_data.
WHILE binary_data IS NOT INITIAL.
db_record-record_number = sy-index.
db_record-lognumber = i_log_number.
db_record-msgnumber = i_message_number.
db_record-data = binary_data.
IF xstrlen( binary_data ) GE bytes_per_record.
db_record-used_bytes = bytes_per_record.
ELSE.
db_record-used_bytes = xstrlen( binary_data ).
ENDIF.
INSERT db_record INTO TABLE r_result.
SHIFT binary_data LEFT BY bytes_per_record PLACES IN BYTE MODE.
ENDWHILE.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
SELECT mandt
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
INSERT /usi/bal_data
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,163 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD run_productive.
DATA: deleted_entries TYPE int4.
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
IF sy-subrc EQ 0.
deleted_entries = sy-dbcnt.
CALL FUNCTION 'ABAP4_COMMIT_WORK'.
ENDIF.
MESSAGE s023(/usi/bal) WITH deleted_entries.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
```
Explanation: Modify only own DB tables. | 2,164 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS /usi/cl_bal_data_cont_coll_dao DEFINITION PUBLIC FINAL CREATE PUBLIC.
PUBLIC SECTION.
INTERFACES /usi/if_bal_data_cont_coll_dao.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES: ty_db_record TYPE /usi/bal_data,
ty_db_records TYPE SORTED TABLE OF ty_db_record WITH UNIQUE KEY lognumber msgnumber record_number.
CONSTANTS db_connection TYPE dbcon_name VALUE 'R/3*SAP_2TH_CONNECT_APPL_LOG'.
DATA db_records TYPE ty_db_records.
METHODS convert_xml_to_db
IMPORTING
i_log_number TYPE balognr
i_message_number TYPE /usi/bal_message_number
i_serialized_data_cont_coll TYPE /usi/bal_xml_string
RETURNING
VALUE(r_result) TYPE ty_db_records.
METHODS convert_db_to_xml
IMPORTING
i_db_records TYPE ty_db_records
RETURNING
VALUE(r_result) TYPE /usi/bal_xml_string.
ENDCLASS.
CLASS /usi/cl_bal_data_cont_coll_dao IMPLEMENTATION.
METHOD /usi/if_bal_data_cont_coll_dao~delete_collections.
TYPES: BEGIN OF ty_database_key,
mandt TYPE mandt,
lognumber TYPE balognr,
msgnumber TYPE /usi/bal_message_number,
record_number TYPE indx_srtf2,
END OF ty_database_key,
ty_database_keys TYPE STANDARD TABLE OF ty_database_key WITH NON-UNIQUE DEFAULT KEY.
DATA database_keys TYPE ty_database_keys.
IF i_log_numbers IS NOT INITIAL.
SELECT mandt lognumber msgnumber record_number
FROM /usi/bal_data
INTO TABLE database_keys
FOR ALL ENTRIES IN i_log_numbers
WHERE lognumber EQ i_log_numbers-table_line.
DELETE /usi/bal_data FROM TABLE database_keys.
ENDIF.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~get_collection.
DATA: db_records TYPE ty_db_records.
SELECT mandt
lognumber
msgnumber
record_number
used_bytes
data
FROM /usi/bal_data
INTO CORRESPONDING FIELDS OF TABLE db_records
CONNECTION (db_connection)
WHERE lognumber EQ i_log_number
AND msgnumber EQ i_message_number.
IF sy-subrc NE 0.
RAISE EXCEPTION TYPE /usi/cx_bal_not_found
EXPORTING
textid = /usi/cx_bal_not_found=>no_db_entries_found.
ENDIF.
r_result = convert_db_to_xml( db_records ).
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~insert_collection_into_buffer.
DATA: new_records TYPE ty_db_records,
message_parameter_1 TYPE symsgv,
message_parameter_2 TYPE symsgv.
FIELD-SYMBOLS <new_record> TYPE ty_db_record.
IF i_serialized_data_cont_coll IS INITIAL.
RETURN.
ENDIF.
new_records = convert_xml_to_db( i_log_number = i_log_number
i_message_number = i_message_number
i_serialized_data_cont_coll = i_serialized_data_cont_coll ).
LOOP AT new_records ASSIGNING <new_record>.
INSERT <new_record> INTO TABLE db_records.
IF sy-subrc NE 0.
WRITE i_log_number TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
WRITE i_message_number TO message_parameter_2 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_invalid_input
EXPORTING
textid = /usi/cx_bal_invalid_input=>duplicate_buffer_entry
param1 = message_parameter_1
param2 = message_parameter_2.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~save_buffer_to_db.
DATA message_parameter_1 TYPE symsgv.
IF db_records IS INITIAL.
RETURN.
ENDIF.
INSERT /usi/bal_data
CONNECTION (db_connection)
FROM TABLE db_records.
IF sy-subrc EQ 0.
CLEAR db_records.
COMMIT CONNECTION (db_connection).
ELSE.
CLEAR db_records.
WRITE sy-subrc TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_db_error
EXPORTING
textid = /usi/cx_bal_db_error=>/usi/cx_bal_db_error
param1 = message_parameter_1.
ENDIF.
ENDMETHOD.
METHOD convert_db_to_xml.
DATA binary_data TYPE xstring.
FIELD-SYMBOLS <db_record> TYPE ty_db_record.
LOOP AT i_db_records ASSIGNING <db_record>.
CONCATENATE binary_data <db_record>-data(<db_record>-used_bytes) INTO binary_data IN BYTE MODE.
ENDLOOP.
IMPORT serialized_data_cont_coll TO r_result FROM DATA BUFFER binary_data.
ENDMETHOD.
METHOD convert_xml_to_db.
DATA: db_record TYPE ty_db_record,
binary_data TYPE xstring,
bytes_per_record TYPE int4.
bytes_per_record = xstrlen( db_record-data ).
EXPORT serialized_data_cont_coll FROM i_serialized_data_cont_coll TO DATA BUFFER binary_data.
WHILE binary_data IS NOT INITIAL.
db_record-record_number = sy-index.
db_record-lognumber = i_log_number.
db_record-msgnumber = i_message_number.
db_record-data = binary_data.
IF xstrlen( binary_data ) GE bytes_per_record.
db_record-used_bytes = bytes_per_record.
ELSE.
db_record-used_bytes = xstrlen( binary_data ).
ENDIF.
INSERT db_record INTO TABLE r_result.
SHIFT binary_data LEFT BY bytes_per_record PLACES IN BYTE MODE.
ENDWHILE.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
SELECT mandt
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
INSERT /usi/bal_data
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,166 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD run_productive.
DATA: message_text TYPE bapi_msg,
outdated_client_entries TYPE int4,
outdated_user_entries TYPE int4.
DELETE FROM /usi/bal_lv_clnt WHERE endda LT sy-datum.
IF sy-subrc EQ 0.
outdated_client_entries = sy-dbcnt.
CALL FUNCTION 'ABAP4_COMMIT_WORK'.
ENDIF.
MESSAGE s026(/usi/bal) WITH outdated_client_entries c_table_names-client INTO message_text.
write_and_display_message_text( message_text ).
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
IF sy-subrc EQ 0.
outdated_user_entries = sy-dbcnt.
CALL FUNCTION 'ABAP4_COMMIT_WORK'.
ENDIF.
MESSAGE s026(/usi/bal) WITH outdated_user_entries c_table_names-user INTO message_text.
write_and_display_message_text( message_text ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM /usi/bal_lv_clnt WHERE endda LT sy-datum.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
```
Explanation: Modify only own DB tables. | 2,167 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS /usi/cl_bal_data_cont_coll_dao DEFINITION PUBLIC FINAL CREATE PUBLIC.
PUBLIC SECTION.
INTERFACES /usi/if_bal_data_cont_coll_dao.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES: ty_db_record TYPE /usi/bal_data,
ty_db_records TYPE SORTED TABLE OF ty_db_record WITH UNIQUE KEY lognumber msgnumber record_number.
CONSTANTS db_connection TYPE dbcon_name VALUE 'R/3*SAP_2TH_CONNECT_APPL_LOG'.
DATA db_records TYPE ty_db_records.
METHODS convert_xml_to_db
IMPORTING
i_log_number TYPE balognr
i_message_number TYPE /usi/bal_message_number
i_serialized_data_cont_coll TYPE /usi/bal_xml_string
RETURNING
VALUE(r_result) TYPE ty_db_records.
METHODS convert_db_to_xml
IMPORTING
i_db_records TYPE ty_db_records
RETURNING
VALUE(r_result) TYPE /usi/bal_xml_string.
ENDCLASS.
CLASS /usi/cl_bal_data_cont_coll_dao IMPLEMENTATION.
METHOD /usi/if_bal_data_cont_coll_dao~delete_collections.
TYPES: BEGIN OF ty_database_key,
mandt TYPE mandt,
lognumber TYPE balognr,
msgnumber TYPE /usi/bal_message_number,
record_number TYPE indx_srtf2,
END OF ty_database_key,
ty_database_keys TYPE STANDARD TABLE OF ty_database_key WITH NON-UNIQUE DEFAULT KEY.
DATA database_keys TYPE ty_database_keys.
IF i_log_numbers IS NOT INITIAL.
SELECT mandt lognumber msgnumber record_number
FROM /usi/bal_data
INTO TABLE database_keys
FOR ALL ENTRIES IN i_log_numbers
WHERE lognumber EQ i_log_numbers-table_line.
DELETE /usi/bal_data FROM TABLE database_keys.
ENDIF.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~get_collection.
DATA db_records TYPE ty_db_records.
SELECT mandt
lognumber
msgnumber
record_number
used_bytes
data
FROM /usi/bal_data
INTO CORRESPONDING FIELDS OF TABLE db_records
CONNECTION (db_connection)
WHERE lognumber EQ i_log_number
AND msgnumber EQ i_message_number.
IF sy-subrc NE 0.
RAISE EXCEPTION TYPE /usi/cx_bal_not_found
EXPORTING
textid = /usi/cx_bal_not_found=>no_db_entries_found.
ENDIF.
r_result = convert_db_to_xml( db_records ).
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~insert_collection_into_buffer.
DATA: new_records TYPE ty_db_records,
message_parameter_1 TYPE symsgv,
message_parameter_2 TYPE symsgv.
FIELD-SYMBOLS <new_record> TYPE ty_db_record.
IF i_serialized_data_cont_coll IS INITIAL.
RETURN.
ENDIF.
new_records = convert_xml_to_db( i_log_number = i_log_number
i_message_number = i_message_number
i_serialized_data_cont_coll = i_serialized_data_cont_coll ).
LOOP AT new_records ASSIGNING <new_record>.
INSERT <new_record> INTO TABLE db_records.
IF sy-subrc NE 0.
WRITE i_log_number TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
WRITE i_message_number TO message_parameter_2 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_invalid_input
EXPORTING
textid = /usi/cx_bal_invalid_input=>duplicate_buffer_entry
param1 = message_parameter_1
param2 = message_parameter_2.
ENDIF.
ENDLOOP.
ENDMETHOD.
METHOD /usi/if_bal_data_cont_coll_dao~save_buffer_to_db.
DATA message_parameter_1 TYPE symsgv.
IF db_records IS INITIAL.
RETURN.
ENDIF.
INSERT /usi/bal_data
CONNECTION (db_connection)
FROM TABLE db_records.
IF sy-subrc EQ 0.
COMMIT CONNECTION (db_connection).
CLEAR db_records.
ELSE.
WRITE sy-subrc TO message_parameter_1 LEFT-JUSTIFIED NO-ZERO.
RAISE EXCEPTION TYPE /usi/cx_bal_db_error
EXPORTING
textid = /usi/cx_bal_db_error=>/usi/cx_bal_db_error
param1 = message_parameter_1.
ENDIF.
ENDMETHOD.
METHOD convert_db_to_xml.
DATA binary_data TYPE xstring.
FIELD-SYMBOLS <db_record> TYPE ty_db_record.
LOOP AT i_db_records ASSIGNING <db_record>.
CONCATENATE binary_data <db_record>-data(<db_record>-used_bytes) INTO binary_data IN BYTE MODE.
ENDLOOP.
IMPORT serialized_data_cont_coll TO r_result FROM DATA BUFFER binary_data.
ENDMETHOD.
METHOD convert_xml_to_db.
DATA: db_record TYPE ty_db_record,
binary_data TYPE xstring,
bytes_per_record TYPE int4.
bytes_per_record = xstrlen( db_record-data ).
EXPORT serialized_data_cont_coll FROM i_serialized_data_cont_coll TO DATA BUFFER binary_data COMPRESSION ON.
WHILE binary_data IS NOT INITIAL.
db_record-record_number = sy-index.
db_record-lognumber = i_log_number.
db_record-msgnumber = i_message_number.
db_record-data = binary_data.
IF xstrlen( binary_data ) GE bytes_per_record.
db_record-used_bytes = bytes_per_record.
ELSE.
db_record-used_bytes = xstrlen( binary_data ).
ENDIF.
INSERT db_record INTO TABLE r_result.
SHIFT binary_data LEFT BY bytes_per_record PLACES IN BYTE MODE.
ENDWHILE.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
SELECT mandt
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
INSERT /usi/bal_data
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,170 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD run_productive.
DATA: message_text TYPE bapi_msg,
outdated_client_entries TYPE int4,
outdated_user_entries TYPE int4.
DELETE FROM /usi/bal_lv_clnt WHERE endda LT sy-datum.
IF sy-subrc EQ 0.
outdated_client_entries = sy-dbcnt.
ENDIF.
MESSAGE s026(/usi/bal) WITH outdated_client_entries c_table_names-client INTO message_text.
write_and_display_message_text( message_text ).
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
IF sy-subrc EQ 0.
outdated_user_entries = sy-dbcnt.
ENDIF.
MESSAGE s026(/usi/bal) WITH outdated_user_entries c_table_names-user INTO message_text.
write_and_display_message_text( message_text ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM /usi/bal_lv_clnt WHERE endda LT sy-datum.
```
Explanation: Modify only own DB tables.
```abap
DELETE FROM /usi/bal_lv_user WHERE endda LT sy-datum.
```
Explanation: Modify only own DB tables. | 2,171 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD upload.
*-----------------------------------------------------------------------------*
* upload ALV layout from local files
*
* Popup with all ALV layouts from download files
* in the specified local directory
* Displays Report, Handle, Log Group, layout, Description,
* Download date and system (derived from file name)
* User can select one or multiple layouts for upload
* ( user-independent and user-dependent)
* After succesful upload: Popup asking user if user independent layouts
* should be transported.
* If yes: standard dialog for customizing transport as in layout admin
*
* # Important Notes
* - Upload is done to the specified target report.
* No check if source and target report are equal( enables
* copying variants from one report to another )
* - Upload of user layout does not check user existence
* - No authority check (except the check in the used SAP functions)
* - No check at upload if layout already exists. It will be overwritten
*-----------------------------------------------------------------------------*
DATA:
lt_dbfieldcat TYPE STANDARD TABLE OF ltdxdata,
lt_dbsortinfo TYPE STANDARD TABLE OF ltdxdata,
lt_dbfilter TYPE STANDARD TABLE OF ltdxdata,
lt_dblayout TYPE STANDARD TABLE OF ltdxdata,
lt_ltdxt TYPE STANDARD TABLE OF ltdxt,
ls_ltdxt TYPE ltdxt,
lt_ltdxkey TYPE STANDARD TABLE OF ltdxkey,
ls_ltdxkey TYPE ltdxkey,
lt_skeys TYPE tt_skeys,
ls_skeys TYPE t_skeys,
lv_subrc TYPE sysubrc,
lv_filter TYPE string,
lt_files TYPE STANDARD TABLE OF char255,
lv_file TYPE char255,
lv_text70 TYPE text70,
lv_count TYPE i,
lv_pos TYPE i,
lv_answer TYPE c,
lv_msgtx TYPE msgtx ##NEEDED,
lv_filen TYPE string.
FIELD-SYMBOLS:
<ltdxt> TYPE ltdxt,
<skeys> TYPE t_skeys.
lv_filter = '*' && c_suffix_desc && c_ftype.
" get list 'Main' ALV files (*_desc.txt) from direcoty
cl_gui_frontend_services=>directory_list_files(
EXPORTING
directory = iv_pathn
filter = lv_filter " *_desc.txt
files_only = 'X'
CHANGING
file_table = lt_files
count = lv_count
EXCEPTIONS
cntl_error = 1
directory_list_files_failed = 2
wrong_parameter = 3
error_no_gui = 4
not_supported_by_gui = 5
OTHERS = 6
).
IF sy-subrc NE 0.
" Method &1 was executed, sy-subrc = &2.
MESSAGE e174(strex) WITH 'DIRECTORY_LIST_FILES' sy-subrc. " into lv_msgtx.
ENDIF.
" process *_desc.txt files (each represents one downloaded ALV layout)
LOOP AT lt_files INTO lv_file.
CLEAR: ls_skeys, lt_ltdxt, ls_ltdxt.
" read keys and description from *_desc.txt file
lv_filen = lv_file.
upload_file( EXPORTING iv_pathn = iv_pathn
iv_fname = lv_filen
CHANGING ct_table = lt_ltdxt
cv_subrc = lv_subrc ).
IF lv_subrc NE 0.
" Error while uploading file '&1' &2
MESSAGE e164(sprx) WITH lv_filen lv_subrc.
msg_add( ).
CONTINUE.
ENDIF.
IF lt_ltdxt IS INITIAL.
" should never be
CONTINUE.
ENDIF.
" get Layout key and description
READ TABLE lt_ltdxt INTO ls_ltdxt WITH KEY langu = sy-langu.
IF sy-subrc NE 0.
" fallback: use first other language
READ TABLE lt_ltdxt INTO ls_ltdxt INDEX 1.
ENDIF.
MOVE-CORRESPONDING ls_ltdxt TO ls_skeys.
CHECK ls_skeys-variant IS NOT INITIAL. " should always be
" Keep Layout data in LT_SKEYS
ls_skeys-filen = lv_file.
" Keep descriptions
ls_skeys-ltdxt = lt_ltdxt.
" get upload data and source system from file name
IF lv_file CP '*_20++++++_+++_*'.
lv_pos = sy-fdpos + 1.
ls_skeys-aedat = lv_filen+lv_pos(8).
lv_pos = lv_pos + 9.
ls_skeys-sysid = lv_filen+lv_pos(3).
ENDIF.
IF ls_skeys-report EQ iv_repid.
ls_skeys-sortf = 1.
ELSE.
ls_skeys-sortf = 2.
ENDIF.
APPEND ls_skeys TO lt_skeys.
ENDLOOP. "at lt_files
" sort variants: target report first,
" variants with same key by download date (newest first)
SORT lt_skeys BY sortf report
log_group handle
variant username
aedat DESCENDING.
" let user select the layouts for upload (sets SELXX)
variants_select( EXPORTING iv_repid = iv_repid
iv_downl = ' ' "upload mode
CHANGING ct_skeys = lt_skeys ).
" process selected layouts
LOOP AT lt_skeys ASSIGNING <skeys> WHERE selxx = 'X'.
CLEAR: lt_dbfieldcat, lt_dbsortinfo, lt_dbfilter, lt_dblayout.
MOVE-CORRESPONDING <skeys> TO ls_ltdxkey.
" get variant keys from LTDXT-table (all descr. have same variant key)
READ TABLE <skeys>-ltdxt INTO ls_ltdxt INDEX 1.
MOVE-CORRESPONDING ls_ltdxt TO ls_ltdxkey.
" set target report ( we allow upload to different report)
ls_ltdxkey-report = iv_repid.
" adjust description keys
LOOP AT lt_ltdxt ASSIGNING <ltdxt>.
<ltdxt>-report = iv_repid.
ENDLOOP.
" TODO later? check source = target report with confirmation popup
" TODO later? check user existence for user layout
lv_filen = <skeys>-filen.
REPLACE c_suffix_desc IN lv_filen WITH c_suffix_fcat.
upload_file( EXPORTING iv_pathn = iv_pathn
iv_fname = lv_filen
CHANGING ct_table = lt_dbfieldcat
cv_subrc = lv_subrc ).
IF lv_subrc <> 0. "Read Field catalog file ok? (always required)
" Method &1 was executed, sy-subrc = &2.
MESSAGE e174(strex) WITH 'GUI_UPLOAD' lv_subrc. " into lv_msgtx.
" and abort processing
ENDIF.
IF lt_dbfieldcat IS INITIAL.
" for safety, table should never be empty here
CONTINUE.
ENDIF.
" read sort criteria from *_sort.txt file
" ignore SUBRC, file doesnt need to exist
lv_filen = <skeys>-filen.
REPLACE c_suffix_desc IN lv_filen WITH c_suffix_sort.
upload_file( EXPORTING iv_pathn = iv_pathn
iv_fname = lv_filen
CHANGING ct_table = lt_dbsortinfo ).
" read filter criteria from *_filt.txt file
" ignore SUBRC, file doesnt need to exist
lv_filen = <skeys>-filen.
REPLACE c_suffix_desc IN lv_filen WITH c_suffix_filt.
upload_file( EXPORTING iv_pathn = iv_pathn
iv_fname = lv_filen
CHANGING ct_table = lt_dbfilter ).
" read layout setting from *_layo.txt file
" ignore SUBRC, file doesnt need to exist
lv_filen = <skeys>-filen.
REPLACE c_suffix_desc IN lv_filen WITH c_suffix_layo.
upload_file( EXPORTING iv_pathn = iv_pathn
iv_fname = lv_filen
CHANGING ct_table = lt_dblayout ).
" write layout to DB
CALL FUNCTION 'LT_DBDATA_WRITE_TO_LTDX'
EXPORTING
* I_TOOL = 'LT'
is_varkey = ls_ltdxkey
* IS_VARIANT = IS_VARIANT
TABLES
t_dbfieldcat = lt_dbfieldcat
t_dbsortinfo = lt_dbsortinfo
t_dbfilter = lt_dbfilter
t_dblayout = lt_dblayout
EXCEPTIONS
not_found = 1
wrong_relid = 2
OTHERS = 3.
CHECK sy-subrc EQ 0. "should always be
" insert/update descriptions to DB
MODIFY ltdxt FROM TABLE <skeys>-ltdxt.
" success message layout
CONCATENATE ls_ltdxkey-handle ls_ltdxkey-log_group
ls_ltdxkey-variant ls_ltdxkey-username
INTO lv_text70 SEPARATED BY space.
" Variant &1 saved
MESSAGE s116(coat) WITH lv_text70 INTO lv_msgtx.
msg_add( ).
<skeys>-up_ok = 'X'. "set success flag
ENDLOOP. " AT lt_skeys
" set up table for transport
LOOP AT lt_skeys INTO ls_skeys
WHERE up_ok = 'X'
AND username IS INITIAL. "user dependent varinats are not transportable
MOVE-CORRESPONDING ls_skeys TO ls_ltdxkey.
ls_ltdxkey-type = '*'. "needed for transport
APPEND ls_ltdxkey TO lt_ltdxkey.
ENDLOOP. "at lt_skey INTO ls_skeys WHERE up_ok = 'X'.
IF lt_ltdxkey IS INITIAL.
RETURN. "--------------------------------> exit method
ENDIF.
CALL FUNCTION 'POPUP_TO_CONFIRM'
EXPORTING
titlebar = 'Transport Layouts'(020)
text_question = 'Do you want to transport the uploaded user independent layouts?'(021)
default_button = '2' "No
* display_cancel_button = 'X'
IMPORTING
answer = lv_answer " to hold the FM's return value
EXCEPTIONS
text_not_found = 1
OTHERS = 2.
IF sy-subrc <> 0.
MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4 INTO lv_msgtx.
msg_add( ).
ENDIF.
IF lv_answer NE '1'.
RETURN. "--------------------------------> exit method
ENDIF.
CALL FUNCTION 'LT_VARIANTS_TRANSPORT'
TABLES
t_variants = lt_ltdxkey
EXCEPTIONS
client_unknown = 1
no_transports_allowed = 2
variants_table_empty = 3
no_transport_order_selected = 4
OTHERS = 5.
IF sy-subrc EQ 1
OR sy-subrc EQ 2
OR sy-subrc EQ 5.
MESSAGE ID sy-msgid TYPE 'E' NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
INTO lv_msgtx.
msg_add( ).
ENDIF.
ENDMETHOD. "upload.
``` | I found vulnerabilities in the line:
```abap
MODIFY ltdxt FROM TABLE <skeys>-ltdxt.
```
Explanation: Modify only own DB tables. | 2,172 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE nont_name = ms_item-obj_name AND version = 'I'.
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE nont_name = ms_item-obj_name AND version = 'A'.
ENDIF.
rv_user = lv_user.
CATCH cx_root INTO lx_error.
Lcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
TRY.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE nont_name = ms_item-obj_name AND version = 'I'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,173 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE nont_name = ms_item-obj_name AND version = 'A'.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE nont_name = ms_item-obj_name AND version = 'A'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,174 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE ront_name = ms_item-obj_name AND version = 'I'.
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE ront_name = ms_item-obj_name AND version = 'A'.
ENDIF.
rv_user = lv_user.
CATCH cx_root INTO lx_error.
Lcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
TRY.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE ront_name = ms_item-obj_name AND version = 'I'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,175 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE ront_name = ms_item-obj_name AND version = 'A'.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE ront_name = ms_item-obj_name AND version = 'A'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,176 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_unconverted_repo_ids.
DATA lt_cs_ids TYPE ty_repo_ids.
DATA lv_repo_id LIKE LINE OF rt_repo_ids.
DATA lv_index TYPE i.
SELECT value FROM (Lcl_abapgit_persistence_db=>c_tabname)
INTO TABLE rt_repo_ids
WHERE type = Lcl_abapgit_persistence_db=>c_type_repo.
SELECT value FROM (Lcl_abapgit_persistence_db=>c_tabname)
INTO TABLE lt_cs_ids
WHERE type = Lcl_abapgit_persistence_db=>c_type_repo_csum.
LOOP AT rt_repo_ids INTO lv_repo_id.
lv_index = sy-tabix.
READ TABLE lt_cs_ids TRANSPORTING NO FIELDS WITH KEY table_line = lv_repo_id.
IF sy-subrc = 0. " Already converted
DELETE rt_repo_ids INDEX lv_index.
ENDIF.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT value FROM (Lcl_abapgit_persistence_db=>c_tabname) * <-- There is a problem here
INTO TABLE rt_repo_ids
```
Explanation: Potential dangerous statement Dynamic SQL.
```abap
WHERE type = Lcl_abapgit_persistence_db=>c_type_repo.
SELECT value FROM (Lcl_abapgit_persistence_db=>c_tabname) * <-- There is a problem here
INTO TABLE lt_cs_ids
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,177 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT mt_object_table ASSIGNING <ls_table>.
lv_where = get_where_clause( <ls_table>-tobj_name ).
ASSERT NOT lv_where IS INITIAL.
DELETE FROM (<ls_table>-tobj_name) WHERE (lv_where).
IF <ls_table>-tobj_name = lv_primary.
ASSERT sy-dbcnt <= 1. "Just to be on the very safe side
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM (<ls_table>-tobj_name) WHERE (lv_where).
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,178 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT mt_object_table ASSIGNING <ls_table>.
CREATE DATA lr_ref TYPE STANDARD TABLE OF (<ls_table>-tobj_name).
ASSIGN lr_ref->* TO <lt_data>.
io_xml->read(
EXPORTING
iv_name = <ls_table>-tobj_name
CHANGING
cg_data = <lt_data> ).
apply_fill_logic(
EXPORTING
iv_table = <ls_table>-tobj_name
iv_package = iv_package
CHANGING
ct_data = <lt_data> ).
INSERT (<ls_table>-tobj_name) FROM TABLE <lt_data>.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error inserting data, { <ls_table>-tobj_name }| ).
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
INSERT (<ls_table>-tobj_name) FROM TABLE <lt_data>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,179 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT mt_object_table ASSIGNING <ls_object_table>.
CREATE DATA lr_ref TYPE STANDARD TABLE OF (<ls_object_table>-tobj_name).
ASSIGN lr_ref->* TO <lt_data>.
lv_where = get_where_clause( <ls_object_table>-tobj_name ).
SELECT * FROM (<ls_object_table>-tobj_name)
INTO TABLE <lt_data>
WHERE (lv_where)
ORDER BY PRIMARY KEY.
apply_clear_logic( EXPORTING iv_table = <ls_object_table>-tobj_name
CHANGING ct_data = <lt_data> ).
io_xml->add(
iv_name = <ls_object_table>-tobj_name
ig_data = <lt_data> ).
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (<ls_object_table>-tobj_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,181 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD validate.
DATA: lv_where TYPE string,
lv_primary TYPE objsl-tobj_name,
lr_ref TYPE REF TO data.
FIELD-SYMBOLS: <lt_data> TYPE STANDARD TABLE.
lv_primary = get_primary_table( ).
CREATE DATA lr_ref TYPE STANDARD TABLE OF (lv_primary).
ASSIGN lr_ref->* TO <lt_data>.
io_xml->read(
EXPORTING
iv_name = lv_primary
CHANGING
cg_data = <lt_data> ).
IF lines( <lt_data> ) = 0.
Lcx_abapgit_exception=>raise( |Primary table { lv_primary } not found in imported container| ).
ELSEIF lines( <lt_data> ) <> 1.
Lcx_abapgit_exception=>raise( |Primary table { lv_primary } contains more than one instance!| ).
ENDIF.
lv_where = get_where_clause( lv_primary ).
* validate that max one local instance was affected by the import
SELECT COUNT(*) FROM (lv_primary) WHERE (lv_where).
IF sy-dbcnt > 1.
Lcx_abapgit_exception=>raise( |More than one instance exists locally in primary table { lv_primary }| ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT COUNT(*) FROM (lv_primary) WHERE (lv_where).
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,182 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'I'.
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'A'.
ENDIF.
rv_user = lv_user.
CATCH cx_root INTO lx_error.
Lcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
TRY.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'I'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,183 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'A'.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,184 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( <lg_del> ) > 0.
DELETE (iv_name) FROM TABLE <lg_del>.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error deleting { lines( <lg_del> ) } records from table { iv_name }| ).
ENDIF.
``` | I found vulnerabilities in the line:
```abap
DELETE (iv_name) FROM TABLE <lg_del>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,187 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( <lg_ins> ) > 0.
INSERT (iv_name) FROM TABLE <lg_ins>.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error inserting { lines( <lg_ins> ) } records into table { iv_name }| ).
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INSERT (iv_name) FROM TABLE <lg_ins>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,188 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lines( <lg_upd> ) > 0.
UPDATE (iv_name) FROM TABLE <lg_upd>.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error updating { lines( <lg_upd> ) } records into table { iv_name }| ).
ENDIF.
``` | I found vulnerabilities in the line:
```abap
UPDATE (iv_name) FROM TABLE <lg_upd>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,189 |
Find vulnerabilities in this ABAP code snippet. | ```abap
class LCL_ABAPGIT_OO_CLASS implementation.
*"* method's implementations
*include methods.
METHOD create_report.
Lcl_abapgit_factory=>get_sap_report( )->insert_report(
iv_name = iv_program
iv_package = iv_package
it_source = it_source
iv_state = iv_state
iv_version = iv_version
iv_program_type = iv_program_type
iv_extension_type = iv_extension ).
ENDMETHOD.
METHOD delete_report.
Lcl_abapgit_factory=>get_sap_report( )->delete_report( iv_program ).
ENDMETHOD.
METHOD determine_method_include.
DATA: ls_mtdkey TYPE seocpdkey.
ls_mtdkey-clsname = iv_name.
ls_mtdkey-cpdname = iv_method.
cl_oo_classname_service=>get_method_include(
EXPORTING
mtdkey = ls_mtdkey
RECEIVING
result = rv_program
EXCEPTIONS
method_not_existing = 1 ).
IF sy-subrc = 0.
RETURN.
ENDIF.
CALL FUNCTION 'SEO_METHOD_GENERATE_INCLUDE'
EXPORTING
suppress_mtdkey_check = abap_true
mtdkey = ls_mtdkey
EXCEPTIONS
not_existing = 1
model_only = 2
include_existing = 3
method_imp_not_generated = 4
method_imp_not_initialised = 5
_internal_class_not_existing = 6
_internal_method_overflow = 7
cancelled = 8
method_is_abstract_implemented = 9
method_is_final_implemented = 10
internal_error_insert_report = 11
OTHERS = 12.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
rv_program = cl_oo_classname_service=>get_method_include( ls_mtdkey ).
ENDMETHOD.
METHOD generate_classpool.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = iv_name.
CALL FUNCTION 'SEO_CLASS_GENERATE_CLASSPOOL'
EXPORTING
clskey = ls_clskey
suppress_corr = abap_true
EXCEPTIONS
not_existing = 1
model_only = 2
class_pool_not_generated = 3
class_stment_not_generated = 4
locals_not_generated = 5
macros_not_generated = 6
public_sec_not_generated = 7
protected_sec_not_generated = 8
private_sec_not_generated = 9
typeref_not_generated = 10
class_pool_not_initialised = 11
class_stment_not_initialised = 12
locals_not_initialised = 13
macros_not_initialised = 14
public_sec_not_initialised = 15
protected_sec_not_initialised = 16
private_sec_not_initialised = 17
typeref_not_initialised = 18
_internal_class_overflow = 19
OTHERS = 20.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD get_method_includes.
" get method includes for implemented interfaces
" this will contain also leftover includes for deleted interface methods
rt_includes = cl_oo_classname_service=>get_all_method_includes( iv_classname ).
ENDMETHOD.
METHOD init_scanner.
DATA: lx_exc TYPE REF TO cx_root,
lv_message TYPE string,
lv_classname TYPE abap_abstypename.
FIELD-SYMBOLS: <lv_line> TYPE i.
TRY.
ro_scanner = cl_oo_source_scanner_class=>create_class_scanner(
clif_name = iv_name
source = it_source ).
ro_scanner->scan( ).
CATCH cx_clif_scan_error.
Lcx_abapgit_exception=>raise( 'error initializing CLAS scanner' ).
CATCH cx_root INTO lx_exc.
lv_classname = cl_abap_classdescr=>get_class_name( lx_exc ).
IF lv_classname = '\CLASS=CX_OO_CLIF_SCAN_ERROR_DETAIL'.
ASSIGN lx_exc->('SOURCE_POSITION-LINE') TO <lv_line>.
ASSERT sy-subrc = 0.
lv_message = |{ lx_exc->get_text( ) }, line { <lv_line> }|.
ELSE.
lv_message = lx_exc->get_text( ).
ENDIF.
Lcx_abapgit_exception=>raise( lv_message ).
ENDTRY.
ENDMETHOD.
METHOD repair_classpool.
CALL FUNCTION 'SEO_CLASS_REPAIR_CLASSPOOL'
EXPORTING
clskey = is_key
EXCEPTIONS
not_existing = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error repairing class { is_key-clsname }| ).
ENDIF.
ENDMETHOD.
METHOD repair_redefinitions.
" Same logic as SE24 > Utilities > Clean-up > Redefinitions (LSEODCCO)
DATA:
lt_inheritance TYPE vseoextend,
lt_redefinitions TYPE seor_redefinitions_r,
ls_cpdkey TYPE seocpdkey,
lv_tabix TYPE sy-tabix,
lv_exposure TYPE n LENGTH 1,
lv_update TYPE abap_bool,
lv_local_component TYPE abap_bool.
FIELD-SYMBOLS <ls_redef> TYPE seoredef.
CALL FUNCTION 'SEO_CLASS_TYPEINFO_GET'
EXPORTING
clskey = is_key
version = seoc_version_active
IMPORTING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
is_interface = 2
model_only = 3
OTHERS = 4.
IF sy-subrc <> 0.
RETURN.
ENDIF.
" check redefinitions validity
LOOP AT lt_redefinitions ASSIGNING <ls_redef>.
lv_tabix = sy-tabix.
ls_cpdkey-clsname = is_key-clsname.
ls_cpdkey-cpdname = <ls_redef>-mtdname.
CALL FUNCTION 'SEO_COMPONENT_BY_INHERITANCE'
EXPORTING
cpdkey = ls_cpdkey
version = seoc_version_active
IMPORTING
exposure = lv_exposure
is_local_component = lv_local_component
EXCEPTIONS
not_existing = 1
model_only = 2
OTHERS = 3.
IF sy-subrc <> 0.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ELSEIF <ls_redef>-exposure <> lv_exposure.
<ls_redef>-exposure = lv_exposure.
lv_update = abap_true.
ELSEIF lv_local_component = abap_true AND <ls_redef>-attvalue IS INITIAL AND
<ls_redef>-mtdabstrct IS INITIAL AND <ls_redef>-mtdfinal IS INITIAL.
DELETE lt_redefinitions INDEX lv_tabix.
lv_update = abap_true.
ENDIF.
ENDLOOP.
IF lv_update = abap_true.
CALL FUNCTION 'SEO_INHERITANC_CHANGE_F_DATA'
EXPORTING
save = abap_false
CHANGING
inheritance = lt_inheritance
redefinitions = lt_redefinitions
EXCEPTIONS
not_existing = 1
deleted = 2
is_comprising = 3
is_implementing = 4
not_changed = 5
db_error = 6
OTHERS = 7.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
CALL FUNCTION 'SEO_CLIF_SAVE_ALL'
EXPORTING
cifkey = is_key
EXCEPTIONS
not_existing = 1
nothing_to_do = 2
access_error = 3
db_error = 4
error_in_code_generation = 5
OTHERS = 6.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error repairing redefinitions for { is_key-clsname }| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD update_cs_number_of_methods.
" Indirect access to keep downward compatibility
DATA lr_cache_entry TYPE REF TO data.
FIELD-SYMBOLS: <lg_cache_entry> TYPE any,
<lg_field> TYPE any.
TRY.
CREATE DATA lr_cache_entry TYPE ('SEO_CS_CACHE').
CATCH cx_sy_create_data_error.
* does not exist in some older systems
RETURN.
ENDTRY.
ASSIGN lr_cache_entry->* TO <lg_cache_entry>.
ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_classname.
ASSIGN COMPONENT 'NO_OF_METHOD_IMPLS' OF STRUCTURE <lg_cache_entry>
TO <lg_field>.
ASSERT sy-subrc = 0.
<lg_field> = iv_number_of_impl_methods.
MODIFY ('SEO_CS_CACHE') FROM <lg_cache_entry>.
ENDMETHOD.
METHOD update_full_class_include.
CONSTANTS: lc_class_source_extension TYPE c LENGTH 2 VALUE 'CS',
lc_include_program_type TYPE c LENGTH 1 VALUE 'I',
lc_active_version TYPE r3state VALUE 'A'.
create_report( iv_program = cl_oo_classname_service=>get_cs_name( iv_classname )
iv_package = iv_package
it_source = it_source
iv_extension = lc_class_source_extension
iv_program_type = lc_include_program_type
iv_state = lc_active_version
iv_version = iv_version ).
" Assuming that all methods that were scanned are implemented
update_cs_number_of_methods( iv_classname = iv_classname
iv_number_of_impl_methods = lines( it_methods ) ).
ENDMETHOD.
METHOD update_meta.
DATA: lo_update TYPE REF TO cl_oo_class_section_source,
lx_error TYPE REF TO cx_oo_source_save_failure,
ls_clskey TYPE seoclskey,
lv_scan_error TYPE abap_bool.
ls_clskey-clsname = iv_name.
TRY.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = ls_clskey
version = seoc_version_active.
CREATE OBJECT lo_update TYPE ('CL_OO_CLASS_SECTION_SOURCE')
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
source = it_source
suppress_constrctr_generation = abap_true
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3 ##SUBRC_OK.
CATCH cx_sy_dyn_call_param_not_found.
* downport to 702, see https://github.com/abapGit/abapGit/issues/933
* this will READ REPORT instead of using it_source, which should be okay
CREATE OBJECT lo_update TYPE cl_oo_class_section_source
EXPORTING
clskey = ls_clskey
exposure = iv_exposure
state = 'A'
EXCEPTIONS
class_not_existing = 1
read_source_error = 2
OTHERS = 3.
ENDTRY.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
lo_update->set_dark_mode( abap_true ).
TRY.
CALL METHOD lo_update->('SET_AMDP_SUPPORT')
EXPORTING
enabled = abap_true.
CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
* AMDP not supported in this system, ignore error
ENDTRY.
lo_update->scan_section_source(
RECEIVING
scan_error = lv_scan_error
EXCEPTIONS
scan_abap_source_error = 1
OTHERS = 2 ).
IF sy-subrc <> 0 OR lv_scan_error = abap_true.
Lcx_abapgit_exception=>raise( |CLAS, error while scanning source. Subrc = { sy-subrc }| ).
ENDIF.
* this will update the SEO* database tables
TRY.
lo_update->revert_scan_result( ).
CATCH cx_oo_source_save_failure INTO lx_error.
Lcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
IF iv_exposure = seoc_exposure_public.
generate_classpool( iv_name ).
ENDIF.
ENDMETHOD.
METHOD update_report.
DATA lv_type TYPE c LENGTH 1.
lv_type = Lcl_abapgit_oo_base=>c_include_program_type.
IF iv_program+30 = srext_ext_class_pool.
lv_type = Lcl_abapgit_oo_base=>c_cp_program_type.
ENDIF.
rv_updated = Lcl_abapgit_factory=>get_sap_report( )->update_report(
iv_name = iv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_source
iv_program_type = lv_type ).
ENDMETHOD.
METHOD update_source_index.
CONSTANTS:
lc_version_active TYPE r3state VALUE 'A',
lc_version_inactive TYPE r3state VALUE 'I'.
" dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA lo_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT lo_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname
version = lc_version_active
scanner = io_scanner.
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname
version = lc_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
RETURN.
ENDTRY.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~create.
DATA:
lt_vseoattrib TYPE seoo_attributes_r,
ls_class_key TYPE seoclskey,
ls_properties TYPE vseoclass,
lt_attributes TYPE Lif_abapgit_definitions=>ty_obj_attribute_tt.
FIELD-SYMBOLS: <lv_clsname> TYPE seoclsname.
ASSIGN COMPONENT 'CLSNAME' OF STRUCTURE cg_properties TO <lv_clsname>.
ASSERT sy-subrc = 0.
" Get existing class properties and attributes and check if the class
" needs to be created/updated (or is the same)
IF iv_check = abap_true.
ls_class_key-clsname = <lv_clsname>.
ls_properties = Lif_abapgit_oo_object_fnc~get_class_properties( ls_class_key ).
lt_attributes = Lif_abapgit_oo_object_fnc~read_attributes( <lv_clsname> ).
IF ls_properties = cg_properties AND lt_attributes = it_attributes.
RETURN.
ENDIF.
ENDIF.
lt_vseoattrib = convert_attrib_to_vseoattrib(
iv_clsname = <lv_clsname>
it_attributes = it_attributes ).
" Hardcode STATE (#2612)
ls_properties = cg_properties.
ls_properties-state = seoc_state_implemented.
TRY.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
suppress_dialog = abap_true " Parameter missing in 702
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
EXPORTING
devclass = iv_package
overwrite = abap_true
version = seoc_version_active
CHANGING
class = ls_properties
attributes = lt_vseoattrib
EXCEPTIONS
existing = 1
is_interface = 2
db_error = 3
component_error = 4
no_access = 5
other = 6
OTHERS = 7.
ENDTRY.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~create_sotr.
Lcl_abapgit_sotr_handler=>create_sotr(
iv_package = iv_package
io_xml = ii_xml ).
Lcl_abapgit_sots_handler=>create_sots(
iv_package = iv_package
io_xml = ii_xml ).
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~delete.
" SEO_CLASS_DELETE_COMPLETE deletes OTR usage, only
" Use handler to also delete OTR header and texts
Lcl_abapgit_sotr_handler=>delete_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
Lcl_abapgit_sots_handler=>delete_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = is_deletion_key-clsname ).
CALL FUNCTION 'SEO_CLASS_DELETE_COMPLETE'
EXPORTING
clskey = is_deletion_key
EXCEPTIONS
not_existing = 1
is_interface = 2
db_error = 3
no_access = 4
other = 5
OTHERS = 6.
IF sy-subrc = 1.
* ignore deletion of objects that does not exist
* this can happen when the SXCI object is deleted before the implementing CLAS
RETURN.
ELSEIF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~deserialize_source.
DATA: lv_updated TYPE abap_bool,
lv_program TYPE program,
lo_scanner TYPE REF TO cl_oo_source_scanner_class,
lt_methods TYPE cl_oo_source_scanner_class=>type_method_implementations,
lt_incls TYPE seop_methods_w_include,
lv_method LIKE LINE OF lt_methods,
lt_public TYPE seop_source_string,
lt_source TYPE seop_source_string.
"Buffer needs to be refreshed,
"otherwise standard SAP CLIF_SOURCE reorder methods alphabetically
CALL FUNCTION 'SEO_BUFFER_INIT'.
CALL FUNCTION 'SEO_BUFFER_REFRESH'
EXPORTING
cifkey = is_key
version = seoc_version_inactive.
lo_scanner = init_scanner(
it_source = it_source
iv_name = is_key-clsname ).
* public
lt_public = lo_scanner->get_public_section_source( ).
IF lt_public IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_pubsec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_public ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_public
it_source = lt_public ).
ENDIF.
ENDIF.
* protected
lt_source = lo_scanner->get_protected_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prosec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_protected
it_source = lt_source ).
ENDIF.
ENDIF.
* private
lt_source = lo_scanner->get_private_section_source( ).
IF lt_source IS NOT INITIAL.
lv_program = cl_oo_classname_service=>get_prisec_name( is_key-clsname ).
lv_updated = update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
IF lv_updated = abap_true.
update_meta( iv_name = is_key-clsname
iv_exposure = seoc_exposure_private
it_source = lt_source ).
ENDIF.
ENDIF.
* methods
lt_methods = lo_scanner->get_method_implementations( ).
lt_incls = get_method_includes( is_key-clsname ).
LOOP AT lt_methods INTO lv_method.
TRY.
lt_source = lo_scanner->get_method_impl_source( lv_method ).
CATCH cx_oo_clif_component.
Lcx_abapgit_exception=>raise( 'error from GET_METHOD_IMPL_SOURCE' ).
ENDTRY.
lv_program = determine_method_include(
iv_name = is_key-clsname
iv_method = lv_method ).
update_report(
iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = lt_source ).
" If method was implemented before, remove from list
DELETE lt_incls WHERE cpdkey-clsname = is_key-clsname AND cpdkey-cpdname = lv_method.
ENDLOOP.
* full class include
update_full_class_include( iv_classname = is_key-clsname
iv_package = iv_package
iv_version = iv_version
it_source = it_source
it_methods = lt_methods ).
" If there are leftover method includes, then class needs to be repaired
" which will delete the obsolete includes
IF lt_incls IS NOT INITIAL.
repair_classpool( is_key ).
repair_redefinitions( is_key ).
ENDIF.
update_source_index(
iv_clsname = is_key-clsname
io_scanner = lo_scanner ).
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~exists.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = is_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2
is_interface = 3
no_text = 4
inconsistent = 5
OTHERS = 6.
rv_exists = boolc( sy-subrc = 0 OR sy-subrc = 4 ).
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~generate_locals.
DATA: lv_program TYPE syrepid.
IF lines( it_local_definitions ) > 0.
lv_program = cl_oo_classname_service=>get_ccdef_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_definitions ).
ENDIF.
IF lines( it_local_implementations ) > 0.
lv_program = cl_oo_classname_service=>get_ccimp_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_implementations ).
ENDIF.
IF lines( it_local_macros ) > 0.
lv_program = cl_oo_classname_service=>get_ccmac_name( is_key-clsname ).
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_macros ).
ENDIF.
lv_program = cl_oo_classname_service=>get_ccau_name( is_key-clsname ).
IF lines( it_local_test_classes ) > 0.
update_report( iv_program = lv_program
iv_package = iv_package
iv_version = iv_version
it_source = it_local_test_classes ).
ELSE.
" Drop the include to remove left-over test classes
delete_report( lv_program ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~get_class_properties.
CALL FUNCTION 'SEO_CLIF_GET'
EXPORTING
cifkey = is_class_key
version = seoc_version_active
IMPORTING
class = rs_class_properties
EXCEPTIONS
not_existing = 1
deleted = 2
model_only = 3
OTHERS = 4.
IF sy-subrc = 1.
RETURN. " in case only inactive version exists
ELSEIF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
CLEAR:
" TODO 2023-08-01: Clear rs_class_properties-state (#2612)
rs_class_properties-uuid,
rs_class_properties-author,
rs_class_properties-createdon,
rs_class_properties-changedby,
rs_class_properties-changedon,
rs_class_properties-r3release,
rs_class_properties-chgdanyby,
rs_class_properties-chgdanyon,
rs_class_properties-clsfinal,
rs_class_properties-clsabstrct,
rs_class_properties-exposure,
rs_class_properties-version.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~get_includes.
* note: includes returned might not exist
* method cl_oo_classname_service=>GET_ALL_CLASS_INCLUDES does not exist in 702
DATA: lv_class_name TYPE seoclsname,
lt_methods TYPE seop_methods_w_include.
FIELD-SYMBOLS: <ls_method> LIKE LINE OF lt_methods.
lv_class_name = iv_object_name.
APPEND cl_oo_classname_service=>get_ccdef_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccmac_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccimp_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_cl_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ccau_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_pubsec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prosec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_prisec_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_classpool_name( lv_class_name ) TO rt_includes.
APPEND cl_oo_classname_service=>get_ct_name( lv_class_name ) TO rt_includes.
* skip the CS include, as it is sometimes generated on the fly instead of
* when the methods are changed
cl_oo_classname_service=>get_all_method_includes(
EXPORTING
clsname = lv_class_name
RECEIVING
result = lt_methods
EXCEPTIONS
class_not_existing = 1 ).
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Class { lv_class_name } not existing| ).
ENDIF.
LOOP AT lt_methods ASSIGNING <ls_method>.
APPEND <ls_method>-incname TO rt_includes.
ENDLOOP.
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~insert_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
INSERT TEXTPOOL lv_cp
FROM it_text_pool
LANGUAGE iv_language
STATE iv_state.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
Lcl_abapgit_objects_activation=>add( iv_type = 'REPT'
iv_name = lv_cp ).
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~read_sotr.
Lcl_abapgit_sotr_handler=>read_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
Lcl_abapgit_sots_handler=>read_sots(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
io_i18n_params = io_i18n_params
io_xml = ii_xml ).
ENDMETHOD.
METHOD Lif_abapgit_oo_object_fnc~read_text_pool.
DATA: lv_cp TYPE program.
lv_cp = cl_oo_classname_service=>get_classpool_name( iv_class_name ).
READ TEXTPOOL lv_cp INTO rt_text_pool LANGUAGE iv_language. "#EC CI_READ_REP
ENDMETHOD.
endclass. "ZCL_ABAPGIT_OO_CLASS implementation
``` | I found vulnerabilities in the line:
```abap
INSERT TEXTPOOL lv_cp
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 2,192 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD add.
DATA ls_table TYPE Lif_abapgit_persistence=>ty_content.
validate_entry_type( iv_type ).
ls_table-type = iv_type.
ls_table-value = iv_value.
ls_table-data_str = iv_data.
INSERT (c_tabname) FROM ls_table. "#EC CI_SUBRC
ASSERT sy-subrc = 0.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT (c_tabname) FROM ls_table.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,193 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD delete.
lock( iv_type = iv_type
iv_value = iv_value ).
" Ignore errors since record might not exist
DELETE FROM (c_tabname)
WHERE type = iv_type
AND value = iv_value.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
DELETE FROM (c_tabname)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,194 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD modify.
DATA: ls_content TYPE Lif_abapgit_persistence=>ty_content.
lock( iv_type = iv_type
iv_value = iv_value ).
ls_content-type = iv_type.
ls_content-value = iv_value.
ls_content-data_str = iv_data.
MODIFY (c_tabname) FROM ls_content.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'DB modify failed' ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY (c_tabname) FROM ls_content.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,198 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD read.
SELECT SINGLE data_str FROM (c_tabname) INTO rv_data
WHERE type = iv_type
AND value = iv_value.
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE Lcx_abapgit_not_found.
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE data_str FROM (c_tabname) INTO rv_data
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,199 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD update.
DATA lv_data LIKE iv_data.
IF iv_data CS '<?xml'.
lv_data = validate_and_unprettify_xml( iv_data ).
ELSE.
lv_data = iv_data.
ENDIF.
lock( iv_type = iv_type
iv_value = iv_value ).
UPDATE (c_tabname) SET data_str = lv_data
WHERE type = iv_type
AND value = iv_value.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'DB update failed' ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE (c_tabname) SET data_str = lv_data
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,200 |
Find vulnerabilities in this ABAP code snippet. | ```abap
class LCL_ABAPGIT_SAP_REPORT implementation.
*"* method's implementations
*include methods.
METHOD Lif_abapgit_sap_report~read_progdir.
DATA ls_sapdir TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = iv_name
i_state = iv_state
IMPORTING
e_progdir = ls_sapdir
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
MOVE-CORRESPONDING ls_sapdir TO rs_progdir.
CLEAR: rs_progdir-edtx,
rs_progdir-cnam,
rs_progdir-cdat,
rs_progdir-unam,
rs_progdir-udat,
rs_progdir-levl,
rs_progdir-vern,
rs_progdir-rmand,
rs_progdir-sdate,
rs_progdir-stime,
rs_progdir-idate,
rs_progdir-itime,
rs_progdir-varcl,
rs_progdir-state.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~update_progdir.
DATA ls_progdir_new TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = is_progdir-name
i_state = iv_state
IMPORTING
e_progdir = ls_progdir_new
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'Error reading program directory' ).
ENDIF.
ls_progdir_new-ldbname = is_progdir-ldbname.
ls_progdir_new-dbna = is_progdir-dbna.
ls_progdir_new-dbapl = is_progdir-dbapl.
ls_progdir_new-rload = is_progdir-rload.
ls_progdir_new-fixpt = is_progdir-fixpt.
ls_progdir_new-appl = is_progdir-appl.
ls_progdir_new-rstat = is_progdir-rstat.
ls_progdir_new-uccheck = is_progdir-uccheck.
ls_progdir_new-sqlx = is_progdir-sqlx.
ls_progdir_new-clas = is_progdir-clas.
ls_progdir_new-secu = is_progdir-secu.
CALL FUNCTION 'UPDATE_PROGDIR'
EXPORTING
i_progdir = ls_progdir_new
i_progname = ls_progdir_new-name
i_state = ls_progdir_new-state
EXCEPTIONS
not_executed = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'Error updating program directory' ).
ENDIF.
" Function UPDATE_PROGDIR does not update VARCL, so we do it here
SELECT SINGLE * FROM progdir INTO ls_progdir_new
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state.
IF sy-subrc = 0 AND is_progdir-varcl <> ls_progdir_new-varcl.
UPDATE progdir SET varcl = is_progdir-varcl
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state. "#EC CI_SUBRC
ENDIF.
ENDMETHOD.
METHOD authorization_check.
IF is_item IS NOT INITIAL.
TRY.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
abap_langu_version_upon_insert = is_item-abap_language_version " does not exist on lower releases
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
ENDTRY.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~delete_report.
authorization_check(
iv_mode = 'DELETE'
is_item = is_item ).
DELETE REPORT iv_name.
IF sy-subrc <> 0 AND iv_raise_error = abap_true.
Lcx_abapgit_exception=>raise( |Error deleting report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~insert_report.
ASSERT iv_state CA ' AI'.
ASSERT iv_program_type CA ' 1FIJKMST'.
authorization_check(
iv_mode = 'MODIFY'
is_item = is_item ).
IF iv_state IS INITIAL.
INSERT REPORT iv_name FROM it_source.
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state.
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state
PROGRAM TYPE iv_program_type.
ELSE.
INSERT REPORT iv_name FROM it_source
STATE iv_state
EXTENSION TYPE iv_extension_type
PROGRAM TYPE iv_program_type.
ENDIF.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error inserting report { iv_name }| ).
ENDIF.
" In lower releases, INSERT REPORT does not support setting ABAP Language version (VERSION)
" Therefore, update the flag directly
UPDATE progdir SET uccheck = iv_version WHERE name = iv_name AND state = iv_state.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~read_report.
ASSERT iv_state CA ' AI'.
authorization_check(
iv_mode = 'SHOW'
is_item = is_item ).
IF iv_state IS INITIAL.
READ REPORT iv_name INTO rt_source.
ELSE.
READ REPORT iv_name INTO rt_source STATE iv_state.
ENDIF.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error reading report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~update_report.
DATA lt_new TYPE string_table.
DATA lt_old TYPE string_table.
lt_new = it_source.
lt_old = Lif_abapgit_sap_report~read_report( iv_name ).
IF lt_old <> lt_new.
Lif_abapgit_sap_report~insert_report(
iv_name = iv_name
it_source = it_source
iv_state = iv_state
iv_program_type = iv_program_type
iv_extension_type = iv_extension_type
iv_package = iv_package
iv_version = iv_version
is_item = is_item ).
rv_updated = abap_true.
ELSE.
rv_updated = abap_false.
ENDIF.
ENDMETHOD.
endclass. "ZCL_ABAPGIT_SAP_REPORT implementation
``` | I found vulnerabilities in the line:
```abap
DELETE REPORT iv_name.
```
Explanation: Potential dangerous statement DELETE REPORT.
```abap
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSE.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,201 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD deserialize_textpool.
DATA lv_language TYPE sy-langu.
DATA lv_state TYPE c.
DATA lv_delete TYPE abap_bool.
IF iv_language IS INITIAL.
lv_language = mv_language.
ELSE.
lv_language = iv_language.
ENDIF.
IF lv_language = mv_language.
lv_state = c_state-inactive. "Textpool in main language needs to be activated
ELSE.
lv_state = c_state-active. "Translations are always active
ENDIF.
IF it_tpool IS INITIAL.
IF iv_is_include = abap_false OR lv_state = c_state-active.
DELETE TEXTPOOL iv_program "Remove initial description from textpool if
LANGUAGE lv_language "original program does not have a textpool
STATE lv_state.
lv_delete = abap_true.
ELSE.
INSERT TEXTPOOL iv_program "In case of includes: Deletion of textpool in
FROM it_tpool "main language cannot be activated because
LANGUAGE lv_language "this woul activate the deletion of the textpool
STATE lv_state. "of the mail program -> insert empty textpool
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program
FROM it_tpool
LANGUAGE lv_language
STATE lv_state.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
ENDIF.
ENDIF.
IF lv_state = c_state-inactive. "Textpool in main language needs to be activated
Lcl_abapgit_objects_activation=>add(
iv_type = 'REPT'
iv_name = iv_program
iv_delete = lv_delete ).
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
ENDIF.
ELSE.
INSERT TEXTPOOL iv_program * <-- There is a problem here
FROM it_tpool
LANGUAGE lv_language
```
Explanation: Potential dangerous statement INSERT TEXTPOOL. | 2,205 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD main_2.
DATA shrinker TYPE REF TO zcl_shrinker.
DATA(include_does_not_exist) = CONV string( 'Include &1 does not exist. Create it manually as empty.'(001) ).
SELECT SINGLE * FROM trdir WHERE name = @p_def INTO @DATA(trdir_def).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = include_does_not_exist msgv1 = p_def.
ENDIF.
SELECT SINGLE * FROM trdir WHERE name = @p_imp INTO @DATA(trdir_imp).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = include_does_not_exist msgv1 = p_def.
ENDIF.
"**********************************************************************
"* Copy database tables
"**********************************************************************
objects_to_copy = VALUE #(
( object = 'TABL' source_obj_name = 'ZSHRINKER_GTT_EC' target_obj_name = p_tab_ec )
( object = 'TABL' source_obj_name = 'ZSHRINKER_GTT_IN' target_obj_name = p_tab_in )
( object = 'TABL' source_obj_name = 'ZSHRINKER_GTT_MP' target_obj_name = p_tab_mp ) ).
shrinker = zcl_shrinker=>create( ).
shrinker->copy_objects(
EXPORTING
source_package = p_frdevc
target_package = p_todevc
user_exit = me
objects = objects_to_copy ).
"**********************************************************************
"* Classes and interfaces all together in DEF and IMP includes
"**********************************************************************
shrinker = zcl_shrinker=>create( ).
DATA(abap_code) = shrinker->get_one_abap_code(
package_range = VALUE #( ( sign = 'I' option = 'EQ' low = p_frdevc ) )
range_of_obj_type = VALUE #( sign = 'I' option = 'EQ' ( low = 'CLAS' ) ( low = 'INTF' ) ( low = 'PROG' ) )
global_replacements = VALUE #( ( posix_regex = '\<Z(.._SHRINKER\w*)' with = 'L$1' start_of_abap_word = abap_true member_interface_prefix = abap_true )
( LINES OF VALUE #( FOR <object_to_copy> IN objects_to_copy
( posix_regex = <object_to_copy>-source_obj_name with = <object_to_copy>-target_obj_name ) ) ) ) ).
DATA(header_lines) = VALUE string_table(
( `********************************************************************************` )
( `* ` )
( `* LICENSE and NOTICE ` )
( `* ` )
( |* See include program { p_licens WIDTH = 30 } | )
( `* ` )
( `********************************************************************************` ) ).
INSERT LINES OF header_lines
INTO abap_code-def_abap_source_code
INDEX 1.
INSERT LINES OF header_lines
INTO abap_code-imp_abap_source_code
INDEX 1.
DATA(syntax_check) = shrinker->syntax_check( VALUE #(
( `REPORT.` )
( LINES OF abap_code-def_abap_source_code )
( LINES OF abap_code-imp_abap_source_code ) ) ).
IF syntax_check-mess IS NOT INITIAL.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = 'Syntax error &1'(001) msgv1 = syntax_check-mess.
ENDIF.
INSERT REPORT p_def FROM abap_code-def_abap_source_code DIRECTORY ENTRY trdir_def.
INSERT REPORT p_imp FROM abap_code-imp_abap_source_code DIRECTORY ENTRY trdir_imp.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT p_imp FROM abap_code-imp_abap_source_code DIRECTORY ENTRY trdir_imp.
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,206 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT kit_load_status INTO ls_load_status.
GENERATE REPORT ls_load_status-progname MESSAGE ls_load_status-gen_message.
ls_load_status-gen_result = sy-subrc.
MODIFY kit_load_status FROM ls_load_status.
RAISE EVENT program_generated EXPORTING progname = ls_load_status-progname
subrc = sy-subrc
counter = sy-tabix
total = lines( kit_load_status ).
" the following is needed to avoid PXA_NO_FREE_SPACE dump
" (see note 302500 Transaction SGEN terminates with PXA_NO_FREE_SPACE)
" when there are many GENERATE REPORT executed
ADD 1 TO l_commit_count.
IF i_commit_frequency > 0 AND l_commit_count = i_commit_frequency.
COMMIT WORK.
l_commit_count = 0.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
GENERATE REPORT ls_load_status-progname MESSAGE ls_load_status-gen_message.
```
Explanation: Potential dangerous statement GENERATE REPORT.
```abap
MODIFY kit_load_status FROM ls_load_status.
```
Explanation: Modify only own DB tables. | 2,207 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
ku_program = ls_load_status-progname.
EXEC SQL.
UPDATE repoload
SET sdat = :ku_date
stime = :ku_time
WHERE prog = :ku_program
ENDEXEC.
DATA exc_ref TYPE REF TO cx_sy_native_sql_error.
CATCH cx_sy_native_sql_error INTO exc_ref.
DATA error_text TYPE string.
error_text = exc_ref->get_text( ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
EXEC SQL.
```
Explanation: Potential dangerous statement EXEC SQL. | 2,208 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_empty_prog_batch_input.
TYPES tt_bdcdata TYPE STANDARD TABLE OF bdcdata WITH EMPTY KEY.
DATA(bdcdata) = VALUE tt_bdcdata(
( program = 'SAPLWBABAP' dynpro = '0100' dynbegin = 'X' )
( fnam = 'RS38M-PROGRAMM ' fval = program_name )
( fnam = 'RS38M-FUNC_EDIT' fval = 'X' )
( fnam = 'BDC_OKCODE' fval = '=NEW' )
( program = 'SAPLSEDTATTR' dynpro = '0200' dynbegin = 'X' )
( fnam = 'RS38M-REPTI' fval = program_description )
( fnam = 'TRDIR-SUBC' fval = program_type )
( fnam = 'BDC_OKCODE' fval = '=DROPDOWN_ENTER_SC' ) " Click on button to select program type
( program = 'SAPLSEDTATTR' dynpro = '0200' dynbegin = 'X' )
( LINES OF COND #( WHEN program_type = '1' THEN VALUE #(
( fnam = 'TRDIR-UCCHECK' fval = 'X' ) " ABAP Version/Unicode check. X = classic ABAP program Unicode-enabled.
( fnam = 'TRDIR-FIXPT' fval = 'X' ) ) ) )" Fixed decimal point numbers. X = Yes.
( fnam = 'BDC_OKCODE' fval = '=CONT' )
( program = 'SAPLSTRD' dynpro = '0100' dynbegin = 'X' )
( fnam = 'KO007-L_DEVCLASS' fval = package_name ) " Package name
( fnam = 'BDC_OKCODE' fval = '=ADD' )
( program = 'SAPLS38E' dynpro = '0400' dynbegin = 'X' )
( fnam = 'BDC_OKCODE' fval = '/EWB_BACK' )
( program = 'SAPLWBABAP' dynpro = '0100' dynbegin = 'X' )
( fnam = 'BDC_OKCODE' fval = '=BACK' )
).
DATA(ctu_params) = VALUE ctu_params( dismode = 'E' defsize = 'X' ).
CALL TRANSACTION 'SE38'
USING bdcdata
OPTIONS FROM ctu_params.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL TRANSACTION 'SE38'
```
Explanation: Add an authority check to CALL TRANSACTION. | 2,209 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF incl_def IS NOT INITIAL.
INSERT REPORT incl_def FROM abap_of_zabapgit_oo-def_abap_source_code DIRECTORY ENTRY trdir_def.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT incl_def FROM abap_of_zabapgit_oo-def_abap_source_code DIRECTORY ENTRY trdir_def.
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,210 |
Find vulnerabilities in this ABAP code snippet. | ```abap
DO p_nb_imp TIMES.
IF sy-index < p_nb_imp.
DATA(last_line) = first_line + total_include_lines - 1.
ELSE.
last_line = lines( abap_of_zabapgit_oo-imp_abap_source_code ).
ENDIF.
" make sure to not split an ABAP statement in the middle.
WHILE last_line < lines( abap_of_zabapgit_oo-imp_abap_source_code )
AND abap_of_zabapgit_oo-imp_abap_source_code[ last_line ] NP '*.'.
ADD 1 TO last_line.
ENDWHILE.
DATA(abap_source_code) = VALUE zcl_shrinker=>ty_abap_source_code(
( LINES OF header_lines )
( LINES OF abap_of_zabapgit_oo-imp_abap_source_code FROM first_line TO last_line ) ).
incl_impx = EXACT #( |{ incl_imp }{ sy-index }| ).
trdir_imp-name = incl_impx.
INSERT REPORT incl_impx FROM abap_source_code DIRECTORY ENTRY trdir_imp.
first_line = last_line + 1.
ENDDO.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT incl_impx FROM abap_source_code DIRECTORY ENTRY trdir_imp.
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,211 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF standalo IS NOT INITIAL.
INSERT REPORT standalo FROM abap_of_zabapgit_standalone DIRECTORY ENTRY trdir_standalo.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT standalo FROM abap_of_zabapgit_standalone DIRECTORY ENTRY trdir_standalo.
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,212 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT kit_load_status INTO ls_load_status.
GENERATE REPORT ls_load_status-progname MESSAGE ls_load_status-gen_message.
ls_load_status-gen_result = sy-subrc.
MODIFY kit_load_status FROM ls_load_status.
RAISE EVENT program_generated EXPORTING progname = ls_load_status-progname
subrc = sy-subrc
counter = sy-tabix
total = lines( kit_load_status ).
" the following is needed to avoid PXA_NO_FREE_SPACE dump
" (see note 302500 Transaction SGEN terminates with PXA_NO_FREE_SPACE)
" when there are many GENERATE REPORT executed
ADD 1 TO l_commit_count.
IF i_commit_frequency > 0 AND l_commit_count = i_commit_frequency.
COMMIT WORK.
l_commit_count = 0.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
GENERATE REPORT ls_load_status-progname MESSAGE ls_load_status-gen_message.
```
Explanation: Potential dangerous statement GENERATE REPORT. | 2,213 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD main.
DATA(include_does_not_exist) = CONV string( 'Include &1 does not exist. Create it manually as empty.'(001) ).
SELECT SINGLE * FROM trdir WHERE name = @p_def INTO @DATA(trdir_def).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = include_does_not_exist msgv1 = p_def.
ENDIF.
SELECT SINGLE * FROM trdir WHERE name = @p_imp INTO @DATA(trdir_imp).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = include_does_not_exist msgv1 = p_def.
ENDIF.
DATA(shrinker) = zcl_shrinker=>create( ).
DATA(abap_code) = shrinker->get_one_abap_code(
package_range = VALUE #( ( sign = 'I' option = 'EQ' low = p_devc ) )
global_replacements = VALUE #( ( posix_regex = '\<Z(.._SHRINKER\w*)' with = 'L$1' start_of_abap_word = abap_true member_interface_prefix = abap_true ) ) ).
DATA(header_lines) = VALUE string_table(
( `********************************************************************************` )
( `* ` )
( `* LICENSE and NOTICE ` )
( `* ` )
( `* See include program ZSHRINKER_LICENSE ` )
( `* ` )
( `********************************************************************************` ) ).
INSERT LINES OF header_lines
INTO abap_code-def_abap_source_code
INDEX 1.
INSERT LINES OF header_lines
INTO abap_code-imp_abap_source_code
INDEX 1.
DATA(syntax_check) = shrinker->syntax_check( VALUE #(
( `REPORT.` )
( LINES OF abap_code-def_abap_source_code )
( LINES OF abap_code-imp_abap_source_code ) ) ).
IF syntax_check-mess IS NOT INITIAL.
RAISE EXCEPTION TYPE zcx_shrinker EXPORTING text = 'Syntax error &1'(001) msgv1 = syntax_check-mess.
ENDIF.
INSERT REPORT p_def FROM abap_code-def_abap_source_code DIRECTORY ENTRY trdir_def.
DELETE REPORT p_def STATE 'I'.
INSERT REPORT p_imp FROM abap_code-imp_abap_source_code DIRECTORY ENTRY trdir_imp.
DELETE REPORT p_imp STATE 'I'.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT p_def FROM abap_code-def_abap_source_code DIRECTORY ENTRY trdir_def.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
DELETE REPORT p_def STATE 'I'.
```
Explanation: Potential dangerous statement DELETE REPORT.
```abap
INSERT REPORT p_imp FROM abap_code-imp_abap_source_code DIRECTORY ENTRY trdir_imp.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
DELETE REPORT p_imp STATE 'I'.
```
Explanation: Potential dangerous statement DELETE REPORT. | 2,215 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD main_2.
" LOGIC:
" 1. Convert all classes and interfaces into many lines.
" Append this interface (with anything you like instead of abapmerge 0.15.0...:
" ****************************************************
" INTERFACE lif_abapmerge_marker.
" * abapmerge 0.15.0 - 2023-03-19T11:05:04.771Z
" ENDINTERFACE.
" ****************************************************
" 2. Replace all "@@abapmerge include <MIME-object-name>.w3mi.data.<MIME-file-type> > <abapstatement$$>" and its next ABAP statement
" with each line of <filename> replaced with <abapstatement$$> where '$$' contains the <filename> line.
" 3. Replace all "@@abapmerge include-cua <filename> <variablename>"
" with the details of the each line of <filename> replaced with <abapstatement$$> where '$$' contains the <filename> line.
" 4. Read ZABAPGIT, replace the INCLUDE lines with the code of the corresponding source units,
" insert all previous lines from the line 2.
DATA(include_does_not_exist) = CONV string( 'Include/program &1 does not exist. Create it manually as empty.'(001) ).
SELECT SINGLE * FROM trdir WHERE name = @standalo INTO @DATA(trdir_standalo).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE lcx_shrinker EXPORTING text = include_does_not_exist msgv1 = standalo.
ENDIF.
SELECT SINGLE * FROM trdir WHERE name = @incl_def INTO @DATA(trdir_def).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE lcx_shrinker EXPORTING text = include_does_not_exist msgv1 = incl_def.
ENDIF.
DATA(incl_impx) = EXACT progname( |{ incl_imp }1| ).
SELECT SINGLE * FROM trdir WHERE name = @incl_impx INTO @DATA(trdir_imp).
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE lcx_shrinker EXPORTING text = include_does_not_exist msgv1 = incl_impx.
ENDIF.
"=================================
" All classes and interfaces
"=================================
shrinker_classes_interfaces = lcl_shrinker=>create( me ).
DATA(abap_of_zabapgit_oo) = shrinker_classes_interfaces->get_one_abap_code(
package_range = s_devc[]
range_of_obj_type = VALUE #( sign = 'I' option = 'EQ' ( low = 'CLAS' ) ( low = 'INTF' ) )
global_replacements = VALUE #(
( posix_regex = '\<Z(.._ABAPGIT\w*)' with = 'L$1' start_of_abap_word = abap_true member_interface_prefix = abap_true )
( posix_regex = `'Z(.._ABAPGIT)` with = `'L$1` )
( posix_regex = `\(Z(.._ABAPGIT)` with = `(L$1` ) " SELECT * FROM (zcl_abapgit_persistence_db=>c_tabname)
( posix_regex = `'Z(IF_APACK)` with = `'L$1` ) " CONSTANTS c_apack_interface_cust TYPE seoclsname VALUE 'ZIF_APACK_MANIFEST' ##NO_TEXT.
) ).
replace_abapmerge( CHANGING abap_source_code = abap_of_zabapgit_oo-imp_abap_source_code ).
DATA(header_lines) = VALUE string_table(
( `********************************************************************************` )
( `* ` )
( `* LICENSE and NOTICE ` )
( `* ` )
( `* See include program ZSHRINKER_DEMO_ABAPGIT_LICENSE ` )
( `* ` )
( `********************************************************************************` ) ).
INSERT LINES OF header_lines
INTO abap_of_zabapgit_oo-def_abap_source_code
INDEX 1.
INSERT LINES OF VALUE string_table(
( `` )
( `****************************************************` )
( `INTERFACE lif_abapmerge_marker. ` )
( `* ZSHRINKER_DEMO_ABAPGIT 2023 ` )
( `ENDINTERFACE. ` )
( `****************************************************` )
) INTO TABLE abap_of_zabapgit_oo-def_abap_source_code.
DATA(syntax_check_oo) = shrinker_classes_interfaces->syntax_check( VALUE #(
( `REPORT.` )
( LINES OF abap_of_zabapgit_oo-def_abap_source_code )
( LINES OF abap_of_zabapgit_oo-imp_abap_source_code ) ) ).
IF syntax_check_oo-mess IS NOT INITIAL.
RAISE EXCEPTION TYPE lcx_shrinker EXPORTING text = 'Syntax error &1'(002) msgv1 = syntax_check_oo-mess.
ENDIF.
"=================================
" ZABAPGIT
"=================================
DATA(shrinker_zabapgit_standalone) = lcl_shrinker=>create( me ).
DATA(abap_of_zabapgit_standalone) = shrinker_zabapgit_standalone->get_abap_for_program(
program_name = 'ZABAPGIT'
global_replacements = VALUE #( ( posix_regex = '\<Z(.._ABAPGIT\w*)' with = 'L$1' start_of_abap_word = abap_true member_interface_prefix = abap_true ) ) ).
INSERT LINES OF header_lines
INTO abap_of_zabapgit_standalone
INDEX 1.
DATA(syntax_check) = shrinker_zabapgit_standalone->syntax_check( abap_of_zabapgit_standalone ).
IF syntax_check-mess IS NOT INITIAL.
RAISE EXCEPTION TYPE lcx_shrinker EXPORTING text = 'Syntax error &1'(002) msgv1 = syntax_check-mess.
ENDIF.
"=================================
" Replace code of includes and program
"=================================
INSERT REPORT incl_def FROM abap_of_zabapgit_oo-def_abap_source_code DIRECTORY ENTRY trdir_def.
DELETE REPORT incl_def STATE 'I'.
" To write 5 includes
DATA(total_includes) = 5.
DATA(total_include_lines) = lines( abap_of_zabapgit_oo-imp_abap_source_code ) DIV total_includes.
DATA(first_line) = 1.
DO total_includes TIMES.
IF sy-index < total_includes.
DATA(last_line) = first_line + total_include_lines - 1.
ELSE.
last_line = lines( abap_of_zabapgit_oo-imp_abap_source_code ).
ENDIF.
" make sure to not split an ABAP statement in the middle.
WHILE last_line < lines( abap_of_zabapgit_oo-imp_abap_source_code )
AND abap_of_zabapgit_oo-imp_abap_source_code[ last_line ] NP '*.'.
ADD 1 TO last_line.
ENDWHILE.
DATA(abap_source_code) = VALUE lcl_shrinker=>ty_abap_source_code(
( LINES OF header_lines )
( LINES OF abap_of_zabapgit_oo-imp_abap_source_code FROM first_line TO last_line ) ).
incl_impx = EXACT #( |{ incl_imp }{ sy-index }| ).
trdir_imp-name = incl_impx.
INSERT REPORT incl_impx FROM abap_source_code DIRECTORY ENTRY trdir_imp.
DELETE REPORT incl_impx STATE 'I'.
first_line = last_line + 1.
ENDDO.
INSERT REPORT standalo FROM abap_of_zabapgit_standalone DIRECTORY ENTRY trdir_standalo.
DELETE REPORT standalo STATE 'I'.
COMMIT WORK.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT incl_def FROM abap_of_zabapgit_oo-def_abap_source_code DIRECTORY ENTRY trdir_def.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
DELETE REPORT incl_def STATE 'I'.
```
Explanation: Potential dangerous statement DELETE REPORT.
```abap
INSERT REPORT standalo FROM abap_of_zabapgit_standalone DIRECTORY ENTRY trdir_standalo.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
DELETE REPORT standalo STATE 'I'.
```
Explanation: Potential dangerous statement DELETE REPORT. | 2,216 |
Find vulnerabilities in this ABAP code snippet. | ```abap
DO total_includes TIMES.
IF sy-index < total_includes.
DATA(last_line) = first_line + total_include_lines - 1.
ELSE.
last_line = lines( abap_of_zabapgit_oo-imp_abap_source_code ).
ENDIF.
" make sure to not split an ABAP statement in the middle.
WHILE last_line < lines( abap_of_zabapgit_oo-imp_abap_source_code )
AND abap_of_zabapgit_oo-imp_abap_source_code[ last_line ] NP '*.'.
ADD 1 TO last_line.
ENDWHILE.
DATA(abap_source_code) = VALUE lcl_shrinker=>ty_abap_source_code(
( LINES OF header_lines )
( LINES OF abap_of_zabapgit_oo-imp_abap_source_code FROM first_line TO last_line ) ).
incl_impx = EXACT #( |{ incl_imp }{ sy-index }| ).
trdir_imp-name = incl_impx.
INSERT REPORT incl_impx FROM abap_source_code DIRECTORY ENTRY trdir_imp.
DELETE REPORT incl_impx STATE 'I'.
first_line = last_line + 1.
ENDDO.
``` | I found vulnerabilities in the line:
```abap
INSERT REPORT incl_impx FROM abap_source_code DIRECTORY ENTRY trdir_imp.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
DELETE REPORT incl_impx STATE 'I'.
```
Explanation: Potential dangerous statement DELETE REPORT. | 2,217 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'A'.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
IF lv_user IS INITIAL.
SELECT SINGLE changed_by INTO lv_user * <-- There is a problem here
FROM (c_table_name)
WHERE evtb_name = ms_item-obj_name AND version = 'A'.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,237 |
Find vulnerabilities in this ABAP code snippet. | ```abap
class LCL_ABAPGIT_SAP_REPORT implementation.
*"* method's implementations
*include methods.
METHOD authorization_check.
IF is_item IS NOT INITIAL.
TRY.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
abap_langu_version_upon_insert = is_item-abap_language_version " does not exist on lower releases
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
CATCH cx_sy_dyn_call_param_not_found.
CALL FUNCTION 'RS_ACCESS_PERMISSION'
EXPORTING
mode = iv_mode
object = is_item-obj_name
object_class = is_item-obj_type
suppress_corr_check = abap_true
suppress_language_check = abap_true
suppress_extend_dialog = abap_true
EXCEPTIONS
canceled_in_corr = 1
enqueued_by_user = 2
enqueue_system_failure = 3
illegal_parameter_values = 4
locked_by_author = 5
no_modify_permission = 6
no_show_permission = 7
permission_failure = 8
request_language_denied = 9
OTHERS = 10.
ENDTRY.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~delete_report.
authorization_check(
iv_mode = 'DELETE'
is_item = is_item ).
DELETE REPORT iv_name.
IF sy-subrc <> 0 AND iv_raise_error = abap_true.
Lcx_abapgit_exception=>raise( |Error deleting report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~insert_report.
ASSERT iv_state CA ' AI'.
ASSERT iv_program_type CA ' 1FIJKMST'.
authorization_check(
iv_mode = 'MODIFY'
is_item = is_item ).
IF iv_state IS INITIAL.
INSERT REPORT iv_name FROM it_source.
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state.
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source
STATE iv_state
PROGRAM TYPE iv_program_type.
ELSE.
INSERT REPORT iv_name FROM it_source
STATE iv_state
EXTENSION TYPE iv_extension_type
PROGRAM TYPE iv_program_type.
ENDIF.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error inserting report { iv_name }| ).
ENDIF.
" In lower releases, INSERT REPORT does not support setting ABAP Language version (VERSION)
" Therefore, update the flag directly
UPDATE progdir SET uccheck = iv_version WHERE name = iv_name AND state = iv_state.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~read_progdir.
DATA ls_sapdir TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = iv_name
i_state = iv_state
IMPORTING
e_progdir = ls_sapdir
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise_t100( ).
ENDIF.
MOVE-CORRESPONDING ls_sapdir TO rs_progdir.
CLEAR: rs_progdir-edtx,
rs_progdir-cnam,
rs_progdir-cdat,
rs_progdir-unam,
rs_progdir-udat,
rs_progdir-levl,
rs_progdir-vern,
rs_progdir-rmand,
rs_progdir-sdate,
rs_progdir-stime,
rs_progdir-idate,
rs_progdir-itime,
rs_progdir-varcl,
rs_progdir-state.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~read_report.
ASSERT iv_state CA ' AI'.
authorization_check(
iv_mode = 'SHOW'
is_item = is_item ).
IF iv_state IS INITIAL.
READ REPORT iv_name INTO rt_source.
ELSE.
READ REPORT iv_name INTO rt_source STATE iv_state.
ENDIF.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( |Error reading report { iv_name }| ).
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~update_progdir.
DATA ls_progdir_new TYPE progdir.
CALL FUNCTION 'READ_PROGDIR'
EXPORTING
i_progname = is_progdir-name
i_state = iv_state
IMPORTING
e_progdir = ls_progdir_new
EXCEPTIONS
not_exists = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'Error reading program directory' ).
ENDIF.
ls_progdir_new-ldbname = is_progdir-ldbname.
ls_progdir_new-dbna = is_progdir-dbna.
ls_progdir_new-dbapl = is_progdir-dbapl.
ls_progdir_new-rload = is_progdir-rload.
ls_progdir_new-fixpt = is_progdir-fixpt.
ls_progdir_new-appl = is_progdir-appl.
ls_progdir_new-rstat = is_progdir-rstat.
ls_progdir_new-uccheck = is_progdir-uccheck.
ls_progdir_new-sqlx = is_progdir-sqlx.
ls_progdir_new-clas = is_progdir-clas.
ls_progdir_new-secu = is_progdir-secu.
CALL FUNCTION 'UPDATE_PROGDIR'
EXPORTING
i_progdir = ls_progdir_new
i_progname = ls_progdir_new-name
i_state = ls_progdir_new-state
EXCEPTIONS
not_executed = 1
OTHERS = 2.
IF sy-subrc <> 0.
Lcx_abapgit_exception=>raise( 'Error updating program directory' ).
ENDIF.
" Function UPDATE_PROGDIR does not update VARCL, so we do it here
SELECT SINGLE * FROM progdir INTO ls_progdir_new
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state.
IF sy-subrc = 0 AND is_progdir-varcl <> ls_progdir_new-varcl.
UPDATE progdir SET varcl = is_progdir-varcl
WHERE name = ls_progdir_new-name
AND state = ls_progdir_new-state. "#EC CI_SUBRC
ENDIF.
ENDMETHOD.
METHOD Lif_abapgit_sap_report~update_report.
DATA lt_new TYPE string_table.
DATA lt_old TYPE string_table.
lt_new = it_source.
lt_old = Lif_abapgit_sap_report~read_report( iv_name ).
IF lt_old <> lt_new.
Lif_abapgit_sap_report~insert_report(
iv_name = iv_name
it_source = it_source
iv_state = iv_state
iv_program_type = iv_program_type
iv_extension_type = iv_extension_type
iv_package = iv_package
iv_version = iv_version
is_item = is_item ).
rv_updated = abap_true.
ELSE.
rv_updated = abap_false.
ENDIF.
ENDMETHOD.
endclass. "ZCL_ABAPGIT_SAP_REPORT implementation
``` | I found vulnerabilities in the line:
```abap
DELETE REPORT iv_name.
```
Explanation: Potential dangerous statement DELETE REPORT.
```abap
ELSEIF iv_program_type IS INITIAL AND iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state.
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSEIF iv_extension_type IS INITIAL.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT.
```abap
ELSE.
INSERT REPORT iv_name FROM it_source * <-- There is a problem here
STATE iv_state
```
Explanation: Potential dangerous statement INSERT REPORT. | 2,243 |
Find vulnerabilities in this ABAP code snippet. | ```abap
if iv_doc_id-target_table = 'CUSTOMER_H'.
select single O~guid from crmd_customer_h as c
left join crmd_orderadm_h as o on c~guid = o~guid and o~process_type = @iv_type
where (cond_syntax) into @ev_guid.
endif.
``` | I found vulnerabilities in the line:
```abap
select single O~guid from crmd_customer_h as c
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,288 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_doc_id-target_table = 'CUSTOMER_H'.
SELECT SINGLE o~guid FROM crmd_customer_h AS c
LEFT JOIN crmd_orderadm_h AS o ON c~guid = o~guid AND o~process_type = @iv_type
WHERE (cond_syntax) INTO @ev_guid.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE o~guid FROM crmd_customer_h AS c
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,289 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD set_creation_info.
* update creating information
DATA(lv_posting_date) = iv_doc_properties-posting_date.
DATA(lv_created_at) = iv_doc_properties-created_at.
DATA(lv_created_by) = iv_doc_properties-created_by.
UPDATE crmd_orderadm_h
SET posting_date = @lv_posting_date,
created_at = @lv_created_at,
created_by = @lv_created_by
WHERE guid EQ @iv_guid.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE crmd_orderadm_h
```
Explanation: Modify only own DB tables. | 2,290 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD set_creation_info.
* update creating information
DATA(lv_posting_date) = iv_doc_properties-posting_date.
DATA(lv_created_at) = iv_doc_properties-created_at.
DATA(lv_created_by) = iv_doc_properties-created_by.
DATA(lv_changed_at) = iv_doc_properties-changed_at.
DATA(lv_changed_by) = iv_doc_properties-changed_by.
UPDATE crmd_orderadm_h
SET posting_date = @lv_posting_date,
created_at = @lv_created_at,
created_by = @lv_created_by,
changed_at = @lv_changed_at,
changed_by = @lv_changed_by
WHERE guid EQ @iv_guid.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE crmd_orderadm_h
```
Explanation: Modify only own DB tables. | 2,292 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF iv_doc_guid-target_table = 'CUSTOMER_H'.
SELECT SINGLE c~guid FROM crmd_customer_h AS c
WHERE (cond_syntax) INTO @ev_guid.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT SINGLE c~guid FROM crmd_customer_h AS c
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,294 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT et_context INTO ls_cr_context.
"fill in context of cr with retrofit cd data.
ls_cr_context-item_guid = iv_guid. "new document guig
"find mapping for target guid
CALL METHOD zcl_solmove_helper=>find_doc
EXPORTING
iv_doc_guid = lv_doc_guid
IMPORTING
ev_guid = lv_found_guid
EXCEPTIONS
error_mapping = 1
others = 2
.
IF sy-subrc <> 0.
* Implement suitable error handling here
ENDIF.
SET UPDATE TASK LOCAL.
MODIFY tsocm_cr_context FROM ls_cr_context.
IF sy-subrc = 0.
COMMIT WORK.
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
MODIFY tsocm_cr_context FROM ls_cr_context.
```
Explanation: Modify only own DB tables. | 2,295 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF <del> IS NOT INITIAL.
DELETE (mv_table) FROM TABLE @<del_org>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
CLEAR <del>.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
DELETE (mv_table) FROM TABLE @<del_org>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,305 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF line_exists( mt_dfies[ keyflag = abap_false ] ).
MODIFY (mv_table) FROM TABLE @<tab_org>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
client->message_toast_display( `Save successful` ).
CLEAR mv_change_active.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
MODIFY (mv_table) FROM TABLE @<tab_org>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,306 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
IF <del> IS ASSIGNED.
IF <del> IS NOT INITIAL.
DELETE (mv_table) FROM TABLE @<del_org>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
CLEAR <del>.
ENDIF.
ENDIF.
ENDIF.
IF line_exists( mt_dfies[ keyflag = abap_false ] ).
MODIFY (mv_table) FROM TABLE @<tab_org>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
client->message_toast_display( `Save successful` ).
CLEAR mv_change_active.
ENDIF.
ELSE.
DELETE (mv_table) FROM TABLE @<tab_org>.
INSERT (mv_table) FROM TABLE @<tab_org>.
IF sy-subrc = 0.
COMMIT WORK AND WAIT.
client->message_toast_display( `Save successful` ).
CLEAR mv_change_active.
ENDIF.
ENDIF.
CATCH cx_root INTO DATA(cx). " TODO: variable is assigned but never used (ABAP cleaner)
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
DELETE (mv_table) FROM TABLE @<tab_org>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
INSERT (mv_table) FROM TABLE @<tab_org>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,307 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
DATA(new_struct_desc) = cl_abap_structdescr=>create( t_comp ).
DATA(new_table_desc) = cl_abap_tabledescr=>create( p_line_type = new_struct_desc
p_table_kind = cl_abap_tabledescr=>tablekind_std ).
CREATE DATA mt_table TYPE HANDLE new_table_desc.
CREATE DATA mt_table_del TYPE HANDLE new_table_desc.
CREATE DATA mt_table_tmp TYPE HANDLE new_table_desc.
CREATE DATA mt_table_org TYPE HANDLE new_table_desc.
ASSIGN mt_table->* TO <table>.
SELECT *
FROM (mv_table)
INTO CORRESPONDING FIELDS OF TABLE @<table>.
SORT <table>.
CATCH cx_root.
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,308 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF lcl_this=>fields IS NOT INITIAL.
SELECT (lcl_this=>fields)
FROM (pv_ddic_type)
INTO CORRESPONDING FIELDS OF TABLE alv_table
UP TO 10 ROWS.
ELSE.
``` | I found vulnerabilities in the line:
```abap
SELECT (lcl_this=>fields)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,309 |
Find vulnerabilities in this ABAP code snippet. | ```abap
*&---------------------------------------------------------------------*
*& Report ZAESOP_TALV_DEMO_05
*&---------------------------------------------------------------------*
*& cell color / style & checkbox & light
*&---------------------------------------------------------------------*
REPORT zaesop_talv_demo_05.
*----------------------------------------------------------------------*
* 类定义
*----------------------------------------------------------------------*
CLASS lcl_this DEFINITION CREATE PUBLIC.
PUBLIC SECTION.
"定义此结构是为了方便读者理解本例中系统会构造出什么样的内表
TYPES: BEGIN OF ty_ekko.
INCLUDE TYPE ekko.
TYPES: box(1) TYPE c,
light(4) TYPE c,
style TYPE lvc_t_styl,
color TYPE lvc_t_scol.
TYPES: END OF ty_ekko.
TYPES tty_ekko TYPE STANDARD TABLE OF ty_ekko WITH DEFAULT KEY.
CLASS-DATA: ddic TYPE tabname VALUE 'EKKO',
fields(1024) TYPE c VALUE 'EBELN BUKRS BSTYP BSART LOEKZ AEDAT ERNAM'.
CLASS-METHODS main.
ENDCLASS.
*----------------------------------------------------------------------*
* START-OF-SELECTION.
*----------------------------------------------------------------------*
START-OF-SELECTION.
lcl_this=>main( ).
*----------------------------------------------------------------------*
* 类实施
*----------------------------------------------------------------------*
CLASS lcl_this IMPLEMENTATION.
METHOD main.
DATA: key TYPE zstalv_key.
"ALV类型：全屏
key-type = 'TALV'.
"数据字典类型 可动态指定
key-ddic_type = lcl_this=>ddic.
"ALV内表checkbox_name列的列名
key-checkbox_name = 'BOX'.
"ALV内表信号灯列的列名
key-light_name = 'LIGHT'.
"ALV内表单元格颜色内表的列名
key-color_table_name = 'COLOR'.
"ALV内表style控制列的列名
key-style_table_name = 'STYLE'.
"工厂模式生成TALV并直接展示
zcl_talv_factory=>get_talv( key )->display( ).
ENDMETHOD.
ENDCLASS.
FORM frm_9000_handle_on_pbo USING talv TYPE REF TO zcl_talv_parent
CHANGING alv_table TYPE STANDARD TABLE.
talv->save_fields( 'BOX LIGHT EBELN BUKRS BSTYP BSART LOEKZ AEDAT ERNAM' ).
PERFORM frm_9000_set_style USING talv
CHANGING alv_table.
talv->refresh( ).
ENDFORM.
FORM frm_9000_handle_retrieve USING pv_ddic_type TYPE tabname
CHANGING alv_table TYPE STANDARD TABLE.
IF lcl_this=>fields IS NOT INITIAL.
SELECT (lcl_this=>fields)
FROM (pv_ddic_type)
INTO CORRESPONDING FIELDS OF TABLE alv_table
UP TO 10 ROWS.
ELSE.
SELECT *
FROM (pv_ddic_type)
INTO CORRESPONDING FIELDS OF TABLE alv_table
UP TO 10 ROWS.
ENDIF.
ENDFORM.
FORM frm_9000_handle_changed_over USING talv TYPE REF TO zcl_talv_parent
pv_modified TYPE char01
pt_good_cells TYPE lvc_t_modi
CHANGING alv_table TYPE STANDARD TABLE.
PERFORM frm_9000_set_style USING talv
CHANGING alv_table.
talv->refresh( ).
ENDFORM.
*&---------------------------------------------------------------------*
*& Form frm_9000_set_style
*&---------------------------------------------------------------------*
*& text
*&---------------------------------------------------------------------*
FORM frm_9000_set_style USING talv TYPE REF TO zcl_talv_parent
CHANGING alv_table TYPE STANDARD TABLE.
FIELD-SYMBOLS <table> TYPE lcl_this=>tty_ekko.
ASSIGN alv_table TO <table>.
LOOP AT <table> ASSIGNING FIELD-SYMBOL(<table_line>).
DATA(index) = sy-tabix.
"设置style color前先清空一下，防止被别的地方设置的在此错误应用
talv->clear_line_style_table( ).
talv->clear_line_color_table( ).
IF <table_line>-box <> abap_true.
<table_line>-light = icon_led_red.
talv->add_line_style( style = zcl_gui_alv_grid=>mc_style_disabled
)->add_line_color( 3 ).
ELSE.
<table_line>-light = icon_led_green.
talv->add_line_style( style = zcl_gui_alv_grid=>mc_style_disabled
)->add_line_style( fieldname = 'BUKRS'"指定列名则只对该列生效，不指定则全部列生效
style = zcl_gui_alv_grid=>mc_style_enabled
style2 = zcl_gui_alv_grid=>mc_style_hotspot
style4 = zcl_gui_alv_grid=>mc_style4_link ).
talv->add_line_color( fieldname = 'BUKRS' col = 6
)->add_line_color( fieldname = 'BUKRS' col = 5 ).
ENDIF.
talv->add_line_style( fieldname = CONV fieldname( talv->get_key_info( 'CHECKBOX_NAME' ) )"不冻结选择框
style = zcl_gui_alv_grid=>mc_style_enabled ).
"针对指定行修改
talv->set_style_for_single_line( index ).
talv->set_color_for_single_line( index ).
ENDLOOP.
ENDFORM.
``` | I found vulnerabilities in the line:
```abap
SELECT *
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,310 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_table_by_fieldcat1.
CONSTANTS: con_report(60) TYPE c VALUE 'REPORT GENENERATED_SUBROUTINE_POOL.',
con_form(60) TYPE c VALUE 'FORM TABLE_CREATE.',
con_form2(60) TYPE c VALUE 'FORM TABLE_CREATE USING OBJECT',
con_begin(60) TYPE c VALUE 'DATA: BEGIN OF GENTAB OCCURS 0.',
con_checkbox(60) TYPE c VALUE 'DATA: CHECKBOX(1) TYPE C.',
con_light(60) TYPE c VALUE 'DATA: LIGHT(4) TYPE C.',
con_cellcolor(60) TYPE c VALUE 'DATA: CELLCOLOR TYPE LVC_T_SCOL.',
con_style(60) TYPE c VALUE 'DATA: STYLE_TABLE TYPE LVC_T_STYL.',
con_end(60) TYPE c VALUE 'DATA: END OF GENTAB.',
con_endform(60) TYPE c VALUE 'ENDFORM.',
con_reference(60) TYPE c VALUE 'DATA: POINTER TYPE REF TO DATA.',
con_create(60) TYPE c VALUE 'CREATE DATA POINTER LIKE STANDARD TABLE OF GENTAB.'.
DATA: fieldcat TYPE kkblo_fieldcat.
DATA: string(60) TYPE c.
DATA: report LIKE sy-repid.
DATA: message(240) TYPE c,
line TYPE i,
word(72) TYPE c.
DATA: code_line TYPE string.
DATA: source_code TYPE string_table.
DATA: form(30) TYPE c VALUE 'TABLE_CREATE'.
DATA: outlen TYPE lvc_outlen. "Y9CK020977
CALL FUNCTION 'K_KKB_FIELDCAT_COMPLETE'
EXPORTING
i_tabname = tabname
CHANGING
ct_fieldcat = fieldcats[]
EXCEPTIONS
OTHERS = 1.
IF sy-subrc NE 0.
MESSAGE ID sy-msgid
TYPE sy-msgty
NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
ENDIF.
code_line = con_report.
APPEND code_line TO source_code.
IF object IS INITIAL.
code_line = con_form.
ELSE.
code_line = con_form2.
CONCATENATE code_line
'TYPE REF TO'
class_name
'.'
INTO code_line SEPARATED BY space.
ENDIF.
APPEND code_line TO source_code.
code_line = con_begin.
APPEND code_line TO source_code.
IF checkbox_name IS NOT INITIAL.
code_line = con_checkbox.
"使用指定的checkbox name
REPLACE 'CHECKBOX' IN code_line WITH checkbox_name.
APPEND code_line TO source_code.
ENDIF.
IF light_name IS NOT INITIAL.
code_line = con_light.
"使用指定的light name
REPLACE 'LIGHT' IN code_line WITH light_name.
APPEND code_line TO source_code.
ENDIF.
IF cell_color_table_name IS NOT INITIAL.
code_line = con_cellcolor.
"使用指定的cell color table name
REPLACE 'CELLCOLOR' IN code_line WITH cell_color_table_name.
APPEND code_line TO source_code.
ENDIF.
IF style_table IS NOT INITIAL.
code_line = con_style.
"使用指定的style table name
REPLACE 'STYLE_TABLE' IN code_line WITH style_table.
APPEND code_line TO source_code.
ENDIF.
*<<< YI3K081678 get invalid signs to check fieldnames
DATA: l_space TYPE string,
fieldname TYPE string,
field_mess TYPE string,
subrc TYPE sy-subrc.
l_space = cl_abap_char_utilities=>get_simple_spaces_for_cur_cp( ).
CONCATENATE l_space ':' INTO l_space.
CONCATENATE l_space ';' INTO l_space.
CONCATENATE l_space '.' INTO l_space.
*>>> YI3K081678
SORT fieldcats BY col_pos ASCENDING.
LOOP AT fieldcats INTO fieldcat.
*<<< YI3K081678 check fieldnames
fieldname = fieldcat-fieldname.
IF fieldname CA l_space.
field_mess = fieldname.
subrc = '1'.
* message raised outside the loop
ELSE.
*>>> YI3K081678
CLEAR code_line.
IF NOT fieldcat-ref_fieldname IS INITIAL.
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
fieldcat-ref_tabname
INTO code_line SEPARATED BY space.
CONCATENATE code_line
'-'
fieldcat-ref_fieldname
'.'
INTO code_line.
ELSE.
IF fieldcat-datatype = 'CHAR'. "Y6AK044662 " #EC CI_UTCL_OK
* >>Y6AK037383
IF length_in_byte EQ abap_true.
CLASS cl_abap_char_utilities DEFINITION LOAD.
fieldcat-intlen = fieldcat-intlen / cl_abap_char_utilities=>charsize.
ENDIF.
* <<Y6AK037383
IF fieldcat-ddic_outputlen > 0. ">>B20K8A0Q9G
outlen = fieldcat-ddic_outputlen. "Y6AK044662
ENDIF.
IF fieldcat-intlen > 0.
IF fieldcat-ddic_outputlen > fieldcat-intlen.
outlen = fieldcat-ddic_outputlen.
ELSE.
outlen = fieldcat-intlen.
ENDIF.
ENDIF.
IF outlen = 0.
outlen = fieldcat-outputlen.
ENDIF. "<<B20K8A0Q9G
CONCATENATE 'DATA:'
fieldcat-fieldname
INTO code_line SEPARATED BY space.
CONCATENATE code_line '(' outlen ').' "B20K8A0Q9G
INTO code_line.
ELSEIF fieldcat-datatype = 'NUMC'. "Y6AK044662 " #EC CI_UTCL_OK
IF length_in_byte EQ abap_true.
CLASS cl_abap_char_utilities DEFINITION LOAD.
fieldcat-intlen = fieldcat-intlen / cl_abap_char_utilities=>charsize.
ENDIF.
IF fieldcat-ddic_outputlen > 0.
outlen = fieldcat-ddic_outputlen.
ENDIF.
IF fieldcat-intlen > 0.
IF fieldcat-ddic_outputlen > fieldcat-intlen.
outlen = fieldcat-ddic_outputlen.
ELSE.
outlen = fieldcat-intlen.
ENDIF.
ENDIF.
IF outlen = 0.
outlen = fieldcat-outputlen.
ENDIF. "<<B20K8A0Q9G
CONCATENATE 'DATA:'
fieldcat-fieldname
INTO code_line SEPARATED BY space.
CONCATENATE code_line '(' outlen ')'
INTO code_line.
CONCATENATE code_line 'TYPE N.'
INTO code_line SEPARATED BY space. "Y6AK044662
ELSEIF fieldcat-datatype = 'CURR'. "#EC CI_UTCL_OK
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
fieldcat-inttype
'DECIMALS 2.'
INTO code_line SEPARATED BY space.
ELSEIF fieldcat-datatype EQ 'INT1' "#EC CI_UTCL_OK
OR fieldcat-inttype EQ 'B'
OR fieldcat-inttype EQ 'b'.
fieldcat-inttype = 'I'.
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
'INT1' "#EC NOTEXT
'.'
INTO code_line SEPARATED BY space. "B20K8A0MOD
ELSEIF fieldcat-datatype EQ 'INT2' " #EC CI_UTCL_OK
OR fieldcat-inttype EQ 's'.
fieldcat-inttype = 'I'.
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
'INT2' "#EC NOTEXT
'.'
INTO code_line SEPARATED BY space. "B20K8A0MOD
ELSEIF fieldcat-datatype EQ 'INT8' " #EC CI_UTCL_OK
OR fieldcat-inttype EQ '8'.
fieldcat-inttype = '8'.
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
'INT8' "#EC NOTEXT
'.'
INTO code_line SEPARATED BY space. " YI3K487344
ELSEIF fieldcat-datatype EQ 'UTCL' " #EC CI_UTCL_OK
OR fieldcat-inttype EQ 'p'.
fieldcat-inttype = 'p'.
CONCATENATE 'DATA:'
fieldcat-fieldname
'TYPE'
'UTCL' "#EC NOTEXT
'.'
INTO code_line SEPARATED BY space. " YI3K487344
ELSE.
IF NOT fieldcat-intlen IS INITIAL AND fieldcat-inttype NE 'g'. "B20K8A0MOD
IF fieldcat-inttype = 'F' AND fieldcat-intlen NE 8.
fieldcat-intlen = 8.
ENDIF.
IF fieldcat-inttype = 'D' AND fieldcat-intlen NE 8.
fieldcat-intlen = 8.
ENDIF.
IF fieldcat-inttype = 'T' AND fieldcat-intlen NE 6.
fieldcat-intlen = 6.
ENDIF.
IF fieldcat-inttype EQ 'P'.
DATA: l_leng TYPE lvc_outlen.
IF length_in_byte EQ abap_true.
l_leng = fieldcat-intlen.
ELSE.
* if fieldcat-no_sign is initial.
* l_leng = ( fieldcat-intlen / 2 ) + 1 .
* else.
l_leng = ( fieldcat-intlen + 1 ) / 2.
* endif.
ENDIF.
CONCATENATE fieldcat-fieldname
'('
l_leng
')'
INTO string.
ELSE.
CONCATENATE fieldcat-fieldname
'('
fieldcat-intlen
')'
INTO string.
ENDIF.
ELSE.
string = fieldcat-fieldname.
ENDIF.
IF fieldcat-inttype EQ 'g'. "B20K8A0MOD " #EC CI_UTCL_OK
CONCATENATE 'DATA:'
string
'TYPE'
'String' "#EC NOTEXT
'.'
INTO code_line SEPARATED BY space. "B20K8A0MOD
ELSE.
CONCATENATE 'DATA:'
string
'TYPE'
fieldcat-inttype '.'
INTO code_line SEPARATED BY space.
ENDIF.
IF fieldcat-inttype = 'P' AND NOT fieldcat-decimals IS
INITIAL.
REPLACE '.' WITH 'DECIMALS' INTO code_line.
CONCATENATE code_line
fieldcat-decimals
'.'
INTO code_line SEPARATED BY space.
ENDIF.
ENDIF.
ENDIF.
APPEND code_line TO source_code.
ENDIF. "YI3K081678
ENDLOOP.
*<<< YI3K081678 single (!) message incorrect fieldname
IF subrc EQ '1'.
MESSAGE i538(0k) WITH field_mess 'FIELDNAME'.
CLEAR subrc.
ENDIF.
*>>> YI3K081678
code_line = con_end.
APPEND code_line TO source_code.
CLEAR code_line.
IF class_name IS NOT INITIAL.
code_line = con_reference.
APPEND code_line TO source_code.
code_line = con_create.
APPEND code_line TO source_code.
IF NOT object IS INITIAL.
CONCATENATE 'CALL METHOD OBJECT->'
class_method
INTO code_line.
CONCATENATE code_line
'EXPORTING IP_TABLE = POINTER.'
INTO code_line SEPARATED BY space.
ELSE.
CONCATENATE 'CALL METHOD ZCL_DYNAMIC_TOOL=>'
class_method
INTO code_line.
CONCATENATE code_line 'EXPORTING IP_TABLE = POINTER.'
INTO code_line SEPARATED BY space.
ENDIF.
ENDIF.
APPEND code_line TO source_code.
code_line = con_endform.
APPEND code_line TO source_code.
report = sy-cprog.
CATCH SYSTEM-EXCEPTIONS generate_subpool_dir_full = 9.
GENERATE SUBROUTINE POOL source_code
NAME report
MESSAGE message
LINE line
WORD word. "#EC CI_GENERATE
ENDCATCH.
CASE sy-subrc.
WHEN 0.
WHEN 9.
MESSAGE x000(0k) WITH 'GENERATE_SUBPOOL_DIR_FULL'.
WHEN OTHERS.
MESSAGE x000(0k) WITH message line word.
ENDCASE.
*****Unicode_2003
IF NOT message IS INITIAL.
MESSAGE e000(0k) WITH message line word.
ENDIF.
*****Unicode_2003
IF object IS INITIAL.
PERFORM (form) IN PROGRAM (report).
ELSE.
PERFORM (form) IN PROGRAM (report) USING object.
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
GENERATE SUBROUTINE POOL source_code
```
Explanation: Potential dangerous statement GENERATE SUBROUTINE. | 2,311 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,312 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-entries_attr IS INITIAL.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
WHERE (lv_query)
INTO TABLE @lt_code.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
WHERE (lv_query)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,313 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code_obj).
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,314 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ycl_trm_transport_request_db IMPLEMENTATION.
METHOD yif_trm_transport_request_db~set_ignore_cache.
ai_ignore_cache = im_ignore_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_data_by_attr.
IF im_s_tr_query_by_attr IS INITIAL.
RETURN.
ENDIF.
DATA(lv_query) = |tr~transportrequestid IN @im_s_tr_query_by_attr-transportrequestid| &&
| AND tr~transportrequesttype IN @im_s_tr_query_by_attr-type| &&
| AND tr~transportrequestcategory IN @im_s_tr_query_by_attr-category| &&
| AND tr~transportrequestowner IN @im_s_tr_query_by_attr-owner| &&
| AND tr~transportrequeststatus IN @im_s_tr_query_by_attr-status| &&
| AND tr~lastchangedate IN @im_s_tr_query_by_attr-lastchangedate| &&
| AND tr~lastchangetime IN @im_s_tr_query_by_attr-lastchangetime| &&
| AND tr~transportrequestparentid IN @im_s_tr_query_by_attr-parentid| .
IF im_s_tr_query_by_attr-entries_attr IS INITIAL.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
WHERE (lv_query)
INTO TABLE @lt_code.
ENDIF.
ELSE.
lv_query = lv_query &&
| AND trobj~objectid IN @im_s_tr_query_by_attr-entries_attr-objectid| &&
| AND trobj~ObjectType IN @im_s_tr_query_by_attr-entries_attr-ObjectType| &&
| AND trobj~ObjectName IN @im_s_tr_query_by_attr-entries_attr-ObjectName| &&
| AND trobj~LockStatus IN @im_s_tr_query_by_attr-entries_attr-LockStatus|.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
WHERE (lv_query)
INTO TABLE @lt_code_obj.
ENDIF.
* lt_code = CORRESPONDING #( lt_code_obj DISCARDING DUPLICATES MAPPING transportrequestid = transportrequestid ).
lt_code = CORRESPONDING #( lt_code_obj ).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
ENDIF.
re_t_code = VALUE #( FOR <data> IN lt_code ( code = <data>-transportrequestid ) ).
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_by_description.
SELECT text~transportrequestid
FROM yc_transportrequesttext AS text
WHERE description IN @im_s_tr_query_by_description-description
INTO TABLE @DATA(lt_code).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
re_t_code = lt_code.
ENDMETHOD.
METHOD yif_trm_transport_request_db~load_cache.
yif_trm_transport_request_db~check_exists_list( im_t_codes ).
"delivery document cache
DATA(lt_transport_request) = yif_trm_transport_request_db~fetch_data_list( im_t_codes ).
yif_trm_transport_request_db~fetch_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_custo_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_text_list( im_t_codes ).
IF im_s_load_cache_params-fetch_all_data EQ abap_true OR im_s_load_cache_params-tasks EQ abap_true.
DATA(lt_task) = yif_trm_transport_request_db~query_tr_data_by_attr( im_s_tr_query_by_attr = VALUE #( parentid = VALUE #( FOR code IN im_t_codes ( sign = 'I' option = 'EQ' low = code ) ) ) ).
IF lt_task IS NOT INITIAL.
yif_trm_transport_request_db~load_cache( EXPORTING im_t_codes = lt_task
im_s_load_cache_params = im_s_load_cache_params ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text_list.
IF ai_ignore_cache = abap_true.
re_t_text = fetch_text_from_db( im_t_transport_request ).
ELSE.
re_t_text = fetch_text_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text.
DATA(lt_text) = yif_trm_transport_request_db~fetch_text_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_text = lt_text[ 1 ]-text.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries_list.
IF ai_ignore_cache = abap_true.
re_t_entries = fetch_entries_from_db( im_t_transport_request ).
ELSE.
re_t_entries = fetch_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data_list.
IF ai_ignore_cache = abap_true.
re_t_data = fetch_data_from_db( im_t_transport_request ).
ELSE.
re_t_data = fetch_data_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data.
DATA(lt_data) = yif_trm_transport_request_db~fetch_data_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_s_data = lt_data[ 1 ]-data.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries_list.
IF ai_ignore_cache = abap_true.
re_t_custo_entries = fetch_custo_entries_from_db( im_t_transport_request ).
ELSE.
re_t_custo_entries = fetch_custo_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_custo_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_custo_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_customizing.
rs_customizing = ai_s_customizing.
IF rs_customizing IS NOT INITIAL.
RETURN.
ENDIF.
DATA lt_r_name TYPE RANGE OF tvarvc-name.
lt_r_name = VALUE #( ( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_dev_name )
).
SELECT name, low FROM tvarvc
WHERE name IN @lt_r_name
INTO TABLE @DATA(lt_customizing).
IF NOT line_exists( lt_customizing[ 1 ] ).
RETURN.
ENDIF.
ai_s_customizing-rfc_to_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name ]-low OPTIONAL ).
ai_s_customizing-rfc_to_productive = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_quality_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_dev = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_dev_name ]-low OPTIONAL ).
rs_customizing = ai_s_customizing.
ENDMETHOD.
METHOD yif_trm_transport_request_db~clear_cache.
REFRESH:
ai_t_exists_cache,
ai_t_data_cache,
ai_t_entries_cache,
ai_t_custo_entries_cache,
ai_t_text_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists_list.
IF ai_ignore_cache = abap_true.
re_t_exists = fetch_exists_from_db( im_t_transport_request ).
ELSE.
re_t_exists = fetch_exists_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists.
DATA(lt_exists) = yif_trm_transport_request_db~check_exists_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
re_exists = lt_exists[ 1 ]-exists.
ENDMETHOD.
METHOD fetch_text_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_texts TYPE STANDARD TABLE OF yc_transportrequesttext WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trtext~*
FROM yc_transportrequesttext AS trtext
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trtext~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_texts.
re_t_text = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
text = FILTER #( lt_texts USING KEY sorted_key WHERE transportrequestid = <tr>-code
)
)
).
ENDMETHOD.
METHOD fetch_text_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_texts.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_text_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_text.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_text_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_text_from_db( lt_missing_codes ).
ENDIF.
re_t_text = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_text,
ai_t_text_cache.
ENDMETHOD.
METHOD fetch_exists_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_palau TYPE yif_trm_transport_request_db~typ_t_code.
SELECT tr~transportrequestid AS code
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~transportrequestid EQ @im_t_transport_request-code
INTO TABLE @lt_palau.
re_t_exists = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
exists = COND #( WHEN line_exists( lt_palau[ KEY sorted_key code = <tr>-code ] )
THEN abap_true
ELSE abap_false
)
)
).
ENDMETHOD.
METHOD fetch_exists_and_merge.
DATA: lt_cached_exists TYPE yif_trm_transport_request_db~typ_t_exists.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_exists) = ai_t_exists_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_exists TO re_t_exists.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_exists = FILTER #( ai_t_exists_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_exists USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_exists) = fetch_exists_from_db( lt_missing_codes ).
ENDIF.
re_t_exists = lt_cached_exists.
APPEND LINES OF lt_fetched_exists TO: re_t_exists,
ai_t_exists_cache.
ENDMETHOD.
METHOD fetch_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_hangar TYPE STANDARD TABLE OF yc_transportrequestobject WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trentries~*
FROM yc_transportrequestobject AS trentries
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_hangar.
re_t_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_hangar USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_entries_from_db( lt_missing_codes ).
re_t_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_entries,
ai_t_entries_cache.
ENDMETHOD.
METHOD fetch_data_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
SELECT tr~*
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~transportrequestid = @im_t_transport_request-code
INTO TABLE @DATA(lt_data).
re_t_data = VALUE #( FOR <data> IN lt_data ( code = <data>-transportrequestid
data = <data> ) ).
ENDMETHOD.
METHOD fetch_data_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_data.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_data_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_data.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_data_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_data_from_db( lt_missing_codes ).
ENDIF.
re_t_data = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_data,
ai_t_data_cache.
ENDMETHOD.
METHOD fetch_custo_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_llica TYPE STANDARD TABLE OF yc_transportrequestobjectcusto WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trcustoentries~*
FROM yc_transportrequestobjectcusto AS trcustoentries
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trcustoentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_llica.
re_t_custo_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_llica USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_custo_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_custo_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_custo_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_custo_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_custo_entries_from_db( lt_missing_codes ).
re_t_custo_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_custo_entries,
ai_t_custo_entries_cache.
ENDMETHOD.
METHOD create.
IF as_o_db_interface IS NOT BOUND.
as_o_db_interface = NEW ycl_trm_transport_request_db( ).
ENDIF.
re_o_db = as_o_db_interface.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,315 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ycl_trm_transport_request_db IMPLEMENTATION.
METHOD yif_trm_transport_request_db~set_ignore_cache.
ai_ignore_cache = im_ignore_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_data_by_attr.
IF im_s_tr_query_by_attr IS INITIAL.
RETURN.
ENDIF.
DATA(lv_query) = |tr~transportrequestid IN @im_s_tr_query_by_attr-transportrequestid| &&
| AND tr~transportrequesttype IN @im_s_tr_query_by_attr-type| &&
| AND tr~transportrequestcategory IN @im_s_tr_query_by_attr-category| &&
| AND tr~transportrequestowner IN @im_s_tr_query_by_attr-owner| &&
| AND tr~transportrequeststatus IN @im_s_tr_query_by_attr-status| &&
| AND tr~lastchangedate IN @im_s_tr_query_by_attr-lastchangedate| &&
| AND tr~lastchangetime IN @im_s_tr_query_by_attr-lastchangetime| &&
| AND tr~transportrequestparentid IN @im_s_tr_query_by_attr-parentid| .
IF im_s_tr_query_by_attr-entries_attr IS INITIAL.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
WHERE (lv_query)
INTO TABLE @lt_code.
ENDIF.
ELSE.
lv_query = lv_query &&
| AND trobj~objectid IN @im_s_tr_query_by_attr-entries_attr-objectid| &&
| AND trobj~ObjectType IN @im_s_tr_query_by_attr-entries_attr-ObjectType| &&
| AND trobj~ObjectName IN @im_s_tr_query_by_attr-entries_attr-ObjectName| &&
| AND trobj~LockStatus IN @im_s_tr_query_by_attr-entries_attr-LockStatus|.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
FOR ALL ENTRIES IN @im_s_tr_query_by_attr-code
WHERE tr~transportrequestid EQ @im_s_tr_query_by_attr-code-code
AND (lv_query)
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
WHERE (lv_query)
INTO TABLE @lt_code_obj.
ENDIF.
* lt_code = CORRESPONDING #( lt_code_obj DISCARDING DUPLICATES MAPPING transportrequestid = transportrequestid ).
lt_code = CORRESPONDING #( lt_code_obj ).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
ENDIF.
re_t_code = VALUE #( FOR <data> IN lt_code ( code = <data>-transportrequestid ) ).
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_by_description.
SELECT text~transportrequestid
FROM yc_transportrequesttext AS text
WHERE description IN @im_s_tr_query_by_description-description
INTO TABLE @DATA(lt_code).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
re_t_code = lt_code.
ENDMETHOD.
METHOD yif_trm_transport_request_db~load_cache.
yif_trm_transport_request_db~check_exists_list( im_t_codes ).
"delivery document cache
DATA(lt_transport_request) = yif_trm_transport_request_db~fetch_data_list( im_t_codes ).
yif_trm_transport_request_db~fetch_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_custo_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_text_list( im_t_codes ).
IF im_s_load_cache_params-fetch_all_data EQ abap_true OR im_s_load_cache_params-tasks EQ abap_true.
DATA(lt_task) = yif_trm_transport_request_db~query_tr_data_by_attr( im_s_tr_query_by_attr = VALUE #( parentid = VALUE #( FOR code IN im_t_codes ( sign = 'I' option = 'EQ' low = code ) ) ) ).
IF lt_task IS NOT INITIAL.
yif_trm_transport_request_db~load_cache( EXPORTING im_t_codes = lt_task
im_s_load_cache_params = im_s_load_cache_params ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text_list.
IF ai_ignore_cache = abap_true.
re_t_text = fetch_text_from_db( im_t_transport_request ).
ELSE.
re_t_text = fetch_text_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text.
DATA(lt_text) = yif_trm_transport_request_db~fetch_text_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_text = lt_text[ 1 ]-text.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries_list.
IF ai_ignore_cache = abap_true.
re_t_entries = fetch_entries_from_db( im_t_transport_request ).
ELSE.
re_t_entries = fetch_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data_list.
IF ai_ignore_cache = abap_true.
re_t_data = fetch_data_from_db( im_t_transport_request ).
ELSE.
re_t_data = fetch_data_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data.
DATA(lt_data) = yif_trm_transport_request_db~fetch_data_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_s_data = lt_data[ 1 ]-data.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries_list.
IF ai_ignore_cache = abap_true.
re_t_custo_entries = fetch_custo_entries_from_db( im_t_transport_request ).
ELSE.
re_t_custo_entries = fetch_custo_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_custo_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_custo_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_customizing.
rs_customizing = ai_s_customizing.
IF rs_customizing IS NOT INITIAL.
RETURN.
ENDIF.
DATA lt_r_name TYPE RANGE OF tvarvc-name.
lt_r_name = VALUE #( ( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_dev_name )
).
SELECT name, low FROM tvarvc
WHERE name IN @lt_r_name
INTO TABLE @DATA(lt_customizing).
IF NOT line_exists( lt_customizing[ 1 ] ).
RETURN.
ENDIF.
ai_s_customizing-rfc_to_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name ]-low OPTIONAL ).
ai_s_customizing-rfc_to_productive = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_quality_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_dev = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_dev_name ]-low OPTIONAL ).
rs_customizing = ai_s_customizing.
ENDMETHOD.
METHOD yif_trm_transport_request_db~clear_cache.
REFRESH:
ai_t_exists_cache,
ai_t_data_cache,
ai_t_entries_cache,
ai_t_custo_entries_cache,
ai_t_text_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists_list.
IF ai_ignore_cache = abap_true.
re_t_exists = fetch_exists_from_db( im_t_transport_request ).
ELSE.
re_t_exists = fetch_exists_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists.
DATA(lt_exists) = yif_trm_transport_request_db~check_exists_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
re_exists = lt_exists[ 1 ]-exists.
ENDMETHOD.
METHOD fetch_text_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_texts TYPE STANDARD TABLE OF yc_transportrequesttext WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trtext~*
FROM yc_transportrequesttext AS trtext
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trtext~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_texts.
re_t_text = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
text = FILTER #( lt_texts USING KEY sorted_key WHERE transportrequestid = <tr>-code
)
)
).
ENDMETHOD.
METHOD fetch_text_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_texts.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_text_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_text.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_text_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_text_from_db( lt_missing_codes ).
ENDIF.
re_t_text = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_text,
ai_t_text_cache.
ENDMETHOD.
METHOD fetch_exists_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_code TYPE yif_trm_transport_request_db~typ_t_code.
SELECT tr~transportrequestid AS code
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~transportrequestid EQ @im_t_transport_request-code
INTO TABLE @lt_code.
re_t_exists = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
exists = COND #( WHEN line_exists( lt_code[ KEY sorted_key code = <tr>-code ] )
THEN abap_true
ELSE abap_false
)
)
).
ENDMETHOD.
METHOD fetch_exists_and_merge.
DATA: lt_cached_exists TYPE yif_trm_transport_request_db~typ_t_exists.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_exists) = ai_t_exists_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_exists TO re_t_exists.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_exists = FILTER #( ai_t_exists_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_exists USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_exists) = fetch_exists_from_db( lt_missing_codes ).
ENDIF.
re_t_exists = lt_cached_exists.
APPEND LINES OF lt_fetched_exists TO: re_t_exists,
ai_t_exists_cache.
ENDMETHOD.
METHOD fetch_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_entries TYPE STANDARD TABLE OF yc_transportrequestobject WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trentries~*
FROM yc_transportrequestobject AS trentries
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_entries.
re_t_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_entries USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_entries_from_db( lt_missing_codes ).
re_t_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_entries,
ai_t_entries_cache.
ENDMETHOD.
METHOD fetch_data_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
SELECT tr~*
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~transportrequestid = @im_t_transport_request-code
INTO TABLE @DATA(lt_data).
re_t_data = VALUE #( FOR <data> IN lt_data ( code = <data>-transportrequestid
data = <data> ) ).
ENDMETHOD.
METHOD fetch_data_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_data.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_data_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_data.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_data_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_data_from_db( lt_missing_codes ).
ENDIF.
re_t_data = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_data,
ai_t_data_cache.
ENDMETHOD.
METHOD fetch_custo_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_entries TYPE STANDARD TABLE OF yc_transportrequestobjectcusto WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trcustoentries~*
FROM yc_transportrequestobjectcusto AS trcustoentries
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trcustoentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_entries.
re_t_custo_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_entries USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_custo_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_custo_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_custo_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_custo_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_custo_entries_from_db( lt_missing_codes ).
re_t_custo_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_custo_entries,
ai_t_custo_entries_cache.
ENDMETHOD.
METHOD create.
IF as_o_db_interface IS NOT BOUND.
as_o_db_interface = NEW ycl_trm_transport_request_db( ).
ENDIF.
re_o_db = as_o_db_interface.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,319 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN @im_s_tr_query_by_attr-code AS code
ON tr~transportrequestid EQ code~code
WHERE (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN @im_s_tr_query_by_attr-code AS code
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,320 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-entries_attr IS INITIAL.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN @im_s_tr_query_by_attr-code AS code
ON tr~transportrequestid EQ code~code
WHERE (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
WHERE (lv_query)
INTO TABLE @lt_code.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
WHERE (lv_query)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,321 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
INNER JOIN @im_s_tr_query_by_attr-code AS code
ON tr~transportrequestid EQ code~code
WHERE (lv_query)
INTO TABLE @DATA(lt_code_obj).
ELSE.
``` | I found vulnerabilities in the line:
```abap
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,322 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ycl_trm_transport_request_db IMPLEMENTATION.
METHOD yif_trm_transport_request_db~set_ignore_cache.
ai_ignore_cache = im_ignore_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_data_by_attr.
IF im_s_tr_query_by_attr IS INITIAL.
RETURN.
ENDIF.
DATA(lv_query) = |tr~transportrequestid IN @im_s_tr_query_by_attr-transportrequestid| &&
| AND tr~transportrequesttype IN @im_s_tr_query_by_attr-type| &&
| AND tr~transportrequestcategory IN @im_s_tr_query_by_attr-category| &&
| AND tr~transportrequestowner IN @im_s_tr_query_by_attr-owner| &&
| AND tr~transportrequeststatus IN @im_s_tr_query_by_attr-status| &&
| AND tr~lastchangedate IN @im_s_tr_query_by_attr-lastchangedate| &&
| AND tr~lastchangetime IN @im_s_tr_query_by_attr-lastchangetime| &&
| AND tr~transportrequestparentid IN @im_s_tr_query_by_attr-parentid| .
IF im_s_tr_query_by_attr-entries_attr IS INITIAL.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN @im_s_tr_query_by_attr-code AS code
ON tr~transportrequestid EQ code~code
WHERE (lv_query)
INTO TABLE @DATA(lt_code).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
WHERE (lv_query)
INTO TABLE @lt_code.
ENDIF.
ELSE.
lv_query = lv_query &&
| AND trobj~objectid IN @im_s_tr_query_by_attr-entries_attr-objectid| &&
| AND trobj~ObjectType IN @im_s_tr_query_by_attr-entries_attr-ObjectType| &&
| AND trobj~ObjectName IN @im_s_tr_query_by_attr-entries_attr-ObjectName| &&
| AND trobj~LockStatus IN @im_s_tr_query_by_attr-entries_attr-LockStatus|.
IF im_s_tr_query_by_attr-code IS NOT INITIAL.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
INNER JOIN @im_s_tr_query_by_attr-code AS code
ON tr~transportrequestid EQ code~code
WHERE (lv_query)
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
ON tr~transportrequestid EQ trobj~transportrequestid
WHERE (lv_query)
INTO TABLE @lt_code_obj.
ENDIF.
lt_code = CORRESPONDING #( lt_code_obj DISCARDING DUPLICATES MAPPING transportrequestid = transportrequestid ).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
ENDIF.
re_t_code = VALUE #( FOR <data> IN lt_code ( code = <data>-transportrequestid ) ).
ENDMETHOD.
METHOD yif_trm_transport_request_db~query_tr_by_description.
SELECT text~transportrequestid
FROM yc_transportrequesttext AS text
WHERE description IN @im_s_tr_query_by_description-description
INTO TABLE @DATA(lt_code).
lt_code = CORRESPONDING #( lt_code DISCARDING DUPLICATES MAPPING transportrequestid = transportrequestid ).
SORT lt_code BY transportrequestid.
DELETE ADJACENT DUPLICATES FROM lt_code COMPARING transportrequestid.
re_t_code = lt_code.
ENDMETHOD.
METHOD yif_trm_transport_request_db~load_cache.
yif_trm_transport_request_db~check_exists_list( im_t_codes ).
"delivery document cache
DATA(lt_transport_request) = yif_trm_transport_request_db~fetch_data_list( im_t_codes ).
yif_trm_transport_request_db~fetch_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_custo_entries_list( im_t_codes ).
yif_trm_transport_request_db~fetch_text_list( im_t_codes ).
IF im_s_load_cache_params-fetch_all_data EQ abap_true OR im_s_load_cache_params-tasks EQ abap_true.
DATA(lt_task) = yif_trm_transport_request_db~query_tr_data_by_attr( im_s_tr_query_by_attr = VALUE #( parentid = VALUE #( FOR code IN im_t_codes ( sign = 'I' option = 'EQ' low = code ) ) ) ).
IF lt_task IS NOT INITIAL.
yif_trm_transport_request_db~load_cache( EXPORTING im_t_codes = lt_task
im_s_load_cache_params = im_s_load_cache_params ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text_list.
IF ai_ignore_cache = abap_true.
re_t_text = fetch_text_from_db( im_t_transport_request ).
ELSE.
re_t_text = fetch_text_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_text.
DATA(lt_text) = yif_trm_transport_request_db~fetch_text_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_text = lt_text[ 1 ]-text.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries_list.
IF ai_ignore_cache = abap_true.
re_t_entries = fetch_entries_from_db( im_t_transport_request ).
ELSE.
re_t_entries = fetch_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data_list.
IF ai_ignore_cache = abap_true.
re_t_data = fetch_data_from_db( im_t_transport_request ).
ELSE.
re_t_data = fetch_data_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_data.
DATA(lt_data) = yif_trm_transport_request_db~fetch_data_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_s_data = lt_data[ 1 ]-data.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries_list.
IF ai_ignore_cache = abap_true.
re_t_custo_entries = fetch_custo_entries_from_db( im_t_transport_request ).
ELSE.
re_t_custo_entries = fetch_custo_entries_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_custo_entries.
DATA(lt_data) = yif_trm_transport_request_db~fetch_custo_entries_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
TRY.
re_t_custo_entries = lt_data[ 1 ]-entries.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ENDMETHOD.
METHOD yif_trm_transport_request_db~fetch_customizing.
rs_customizing = ai_s_customizing.
IF rs_customizing IS NOT INITIAL.
RETURN.
ENDIF.
DATA lt_r_name TYPE RANGE OF tvarvc-name.
lt_r_name = VALUE #( ( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_quality_name )
( sign = 'I' option = 'EQ' low = yif_trm_transport_request_db=>c_customizing-request_target_dev_name )
).
SELECT name, low FROM tvarvc
WHERE name IN @lt_r_name
INTO TABLE @DATA(lt_customizing).
IF NOT line_exists( lt_customizing[ 1 ] ).
RETURN.
ENDIF.
ai_s_customizing-rfc_to_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_quality_name ]-low OPTIONAL ).
ai_s_customizing-rfc_to_productive = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-rfc_to_productive_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_quality = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_quality_name ]-low OPTIONAL ).
ai_s_customizing-request_target_system_dev = VALUE #( lt_customizing[ name = yif_trm_transport_request_db=>c_customizing-request_target_dev_name ]-low OPTIONAL ).
rs_customizing = ai_s_customizing.
ENDMETHOD.
METHOD yif_trm_transport_request_db~clear_cache.
REFRESH:
ai_t_exists_cache,
ai_t_data_cache,
ai_t_entries_cache,
ai_t_custo_entries_cache,
ai_t_text_cache.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists_list.
IF ai_ignore_cache = abap_true.
re_t_exists = fetch_exists_from_db( im_t_transport_request ).
ELSE.
re_t_exists = fetch_exists_and_merge( im_t_transport_request ).
ENDIF.
ENDMETHOD.
METHOD yif_trm_transport_request_db~check_exists.
DATA(lt_exists) = yif_trm_transport_request_db~check_exists_list( VALUE #( ( code = im_o_transport_request->get_code( ) ) ) ).
re_exists = lt_exists[ 1 ]-exists.
ENDMETHOD.
METHOD fetch_text_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_texts TYPE STANDARD TABLE OF yc_transportrequesttext WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trtext~*
FROM yc_transportrequesttext AS trtext
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trtext~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_texts.
re_t_text = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
text = FILTER #( lt_texts USING KEY sorted_key WHERE transportrequestid = <tr>-code
)
)
).
ENDMETHOD.
METHOD fetch_text_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_texts.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_text_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_text.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_text_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_text_from_db( lt_missing_codes ).
ENDIF.
re_t_text = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_text,
ai_t_text_cache.
ENDMETHOD.
METHOD fetch_exists_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_code TYPE yif_trm_transport_request_db~typ_t_code.
SELECT tr~TransportRequestId AS code
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~TransportRequestId EQ @im_t_transport_request-code
INTO TABLE @lt_code.
re_t_exists = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
exists = COND #( WHEN line_exists( lt_code[ KEY sorted_key code = <tr>-code ] )
THEN abap_true
ELSE abap_false
)
)
).
ENDMETHOD.
METHOD fetch_exists_and_merge.
DATA: lt_cached_exists TYPE yif_trm_transport_request_db~typ_t_exists.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_exists) = ai_t_exists_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_exists TO re_t_exists.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_exists = FILTER #( ai_t_exists_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_exists USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_exists) = fetch_exists_from_db( lt_missing_codes ).
ENDIF.
re_t_exists = lt_cached_exists.
APPEND LINES OF lt_fetched_exists TO: re_t_exists,
ai_t_exists_cache.
ENDMETHOD.
METHOD fetch_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_entries TYPE STANDARD TABLE OF yc_transportrequestobject WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trentries~*
FROM yc_transportrequestobject AS trentries
FOR ALL ENTRIES IN @im_t_transport_request
WHERE trentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_entries.
re_t_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_entries USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_entries_from_db( lt_missing_codes ).
re_t_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_entries,
ai_t_entries_cache.
ENDMETHOD.
METHOD fetch_data_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
SELECT tr~*
FROM yc_transportrequest AS tr
FOR ALL ENTRIES IN @im_t_transport_request
WHERE tr~transportrequestid = @im_t_transport_request-code
INTO TABLE @DATA(lt_data).
re_t_data = VALUE #( FOR <data> IN lt_data ( code = <data>-transportrequestid
data = <data> ) ).
ENDMETHOD.
METHOD fetch_data_and_merge.
DATA: lt_cached_data TYPE yif_trm_transport_request_db~typ_t_data.
IF lines( im_t_transport_request ) EQ 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
TRY.
DATA(ls_cached_data) = ai_t_data_cache[ KEY sorted_key code = lv_code ].
APPEND ls_cached_data TO re_t_data.
RETURN.
CATCH cx_sy_itab_line_not_found.
ENDTRY.
ELSE.
lt_cached_data = FILTER #( ai_t_data_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_data USING KEY sorted_key WHERE code = code ).
IF lt_missing_codes IS NOT INITIAL.
DATA(lt_fetched_data) = fetch_data_from_db( lt_missing_codes ).
ENDIF.
re_t_data = lt_cached_data.
APPEND LINES OF lt_fetched_data TO: re_t_data,
ai_t_data_cache.
ENDMETHOD.
METHOD fetch_custo_entries_from_db.
IF im_t_transport_request IS INITIAL.
RETURN.
ENDIF.
DATA lt_entries TYPE STANDARD TABLE OF yc_transportrequestobjectcusto WITH DEFAULT KEY
WITH NON-UNIQUE SORTED KEY sorted_key COMPONENTS transportrequestid.
SELECT trcustoentries~*
FROM yc_transportrequestobjectcusto AS trcustoentries
for all entries in @im_t_transport_request
where trcustoentries~transportrequestid = @im_t_transport_request-code
INTO TABLE @lt_entries.
re_t_custo_entries = VALUE #( FOR <tr> IN im_t_transport_request ( code = <tr>-code
entries = FILTER #( lt_entries USING KEY sorted_key WHERE transportrequestid = <tr>-code ) ) ).
ENDMETHOD.
METHOD fetch_custo_entries_and_merge.
DATA: lt_cached_entries TYPE yif_trm_transport_request_db~typ_t_custo_entries.
IF lines( im_t_transport_request ) = 1.
DATA(lv_code) = im_t_transport_request[ 1 ]-code.
ASSIGN ai_t_custo_entries_cache[ KEY sorted_key code = lv_code ] TO FIELD-SYMBOL(<entries_cache>).
IF sy-subrc IS INITIAL.
APPEND <entries_cache> TO lt_cached_entries.
ENDIF.
ELSE.
lt_cached_entries = FILTER #( ai_t_custo_entries_cache IN im_t_transport_request USING KEY sorted_key WHERE code = code ).
ENDIF.
DATA(lt_missing_codes) = FILTER #( im_t_transport_request EXCEPT IN lt_cached_entries USING KEY sorted_key WHERE code = code ).
DATA(lt_fetched_entries) = fetch_custo_entries_from_db( lt_missing_codes ).
re_t_custo_entries = lt_cached_entries.
APPEND LINES OF lt_fetched_entries TO: re_t_custo_entries,
ai_t_custo_entries_cache.
ENDMETHOD.
METHOD create.
IF as_o_db_interface IS NOT BOUND.
as_o_db_interface = NEW ycl_trm_transport_request_db( ).
ENDIF.
re_o_db = as_o_db_interface.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
INTO TABLE @DATA(lt_code_obj).
ELSE.
SELECT tr~transportrequestid * <-- There is a problem here
FROM yc_transportrequest AS tr
INNER JOIN yc_transportrequestobject AS trobj
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,323 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD navigate_to_request.
DATA: ls_rseumod TYPE rseumod,
ls_old_rseumod TYPE rseumod,
lt_param TYPE STANDARD TABLE OF rfc_spagpa WITH DEFAULT KEY.
CALL FUNCTION 'RS_WORKBENCH_CUSTOMIZING'
EXPORTING
suppress_dialog = 'X'
IMPORTING
setting = ls_old_rseumod.
ls_rseumod = ls_old_rseumod.
ls_rseumod-wbo_screen = '7'.
UPDATE rseumod FROM ls_rseumod.
lt_param = VALUE #( ( parid = 'KOR' parval = iv_request ) ).
CALL FUNCTION 'ABAP4_CALL_TRANSACTION' STARTING NEW TASK 'TEST'
EXPORTING
tcode = 'SE01'
skip_screen = 'X'
TABLES
spagpa_tab = lt_param.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
UPDATE rseumod FROM ls_rseumod.
```
Explanation: Modify only own DB tables. | 2,324 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD refresh_tms_txt.
DATA ls_tmsbuftxt TYPE tmsbuftxt.
SELECT SINGLE * FROM tmsbuftxt INTO ls_tmsbuftxt WHERE trkorr EQ gv_trkorr.
CHECK sy-subrc EQ 0.
SELECT SINGLE as4text FROM e07t INTO ls_tmsbuftxt-text WHERE trkorr EQ gv_trkorr.
SELECT SINGLE as4user FROM e070 INTO ls_tmsbuftxt-owner WHERE trkorr EQ gv_trkorr.
SELECT SINGLE client FROM e070c INTO ls_tmsbuftxt-srccli WHERE trkorr EQ gv_trkorr.
" there's no standard way to update buffer text table other than clearing the buffer as a whole?
MODIFY tmsbuftxt FROM ls_tmsbuftxt.
COMMIT WORK AND WAIT.
" don't raise exception if it fails!!
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
MODIFY tmsbuftxt FROM ls_tmsbuftxt.
```
Explanation: Modify only own DB tables. | 2,325 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD add_namespace.
DATA: ls_trnspacet TYPE trnspacet,
ls_trnspacett TYPE trnspacett.
ls_trnspacet-namespace = iv_namespace.
ls_trnspacet-role = 'C'.
ls_trnspacet-changeuser = sy-uname.
ls_trnspacet-changedate = sy-datum.
ls_trnspacet-replicense = iv_replicense.
INSERT trnspacet FROM ls_trnspacet.
IF sy-subrc <> 0.
zcx_trm_exception=>raise( iv_reason = zcx_trm_exception=>c_reason-insert_error ).
ENDIF.
LOOP AT it_texts INTO ls_trnspacett.
CHECK ls_trnspacett-spras IS NOT INITIAL.
ls_trnspacett-namespace = iv_namespace.
INSERT trnspacett FROM ls_trnspacett.
IF sy-subrc <> 0.
zcx_trm_exception=>raise( iv_reason = zcx_trm_exception=>c_reason-insert_error ).
ENDIF.
ENDLOOP.
CALL FUNCTION 'TR_ACTIVATE_NAMESPACE'
EXPORTING
iv_namespace = iv_namespace
EXCEPTIONS
deletion_not_allowed = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_trm_exception=>raise( ).
ENDIF.
UPDATE trnspace SET editflag = 'X' WHERE namespace = iv_namespace.
COMMIT WORK AND WAIT.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
INSERT trnspacet FROM ls_trnspacet.
```
Explanation: Modify only own DB tables.
```abap
UPDATE trnspace SET editflag = 'X' WHERE namespace = iv_namespace.
```
Explanation: Modify only own DB tables. | 2,326 |
Find vulnerabilities in this ABAP code snippet. | ```abap
LOOP AT it_texts INTO ls_trnspacett.
CHECK ls_trnspacett-spras IS NOT INITIAL.
ls_trnspacett-namespace = iv_namespace.
INSERT trnspacett FROM ls_trnspacett.
IF sy-subrc <> 0.
zcx_trm_exception=>raise( iv_reason = zcx_trm_exception=>c_reason-insert_error ).
ENDIF.
ENDLOOP.
``` | I found vulnerabilities in the line:
```abap
INSERT trnspacett FROM ls_trnspacett.
```
Explanation: Modify only own DB tables. | 2,327 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_r3trans_info.
TYPES: ty_cmd TYPE c LENGTH 254,
BEGIN OF ty_result,
line(255),
END OF ty_result.
DATA: cmd TYPE ty_cmd,
result TYPE STANDARD TABLE OF ty_result.
cmd = 'R3trans'.
CALL 'SYSTEM' ID 'COMMAND' FIELD cmd
ID 'TAB' FIELD result.
IF sy-subrc <> 12. "Fatal errors have occurred, R3trans sets to 12 when running without options
zcx_trm_exception=>raise( iv_reason = zcx_trm_exception=>c_reason-r3trans_cmd_error ).
ENDIF.
CONCATENATE LINES OF result INTO rv_r3trans SEPARATED BY cl_abap_char_utilities=>newline.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL 'SYSTEM' ID 'COMMAND' FIELD cmd
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,328 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ZCL_TLOG IMPLEMENTATION.
METHOD abort.
add_from_string( content = content type = 'A' ).
log = me.
ENDMETHOD.
METHOD add_from_bapi.
collector->add_from_bapi(
EXPORTING
it_bapiret = it_bapiret
is_bapiret = is_bapiret
if_cumulate = if_cumulate
IMPORTING
ef_add_error = ef_add_error
ef_add_warning = ef_add_warning ).
ENDMETHOD.
METHOD add_from_exception.
collector->add_from_exception( io_exception = io_exception
if_cumulate = if_cumulate
id_detlevel = id_detlevel
id_probclass = id_probclass
id_tabname = id_tabname
id_fieldname = id_fieldname
id_value = id_value
id_index = id_index
id_intreno = id_intreno
id_context = id_context ).
ENDMETHOD.
METHOD add_from_string.
CHECK get_level( type ) >= me->level.
CONCATENATE sy-uzeit ':' content INTO content.
cl_reca_string_services=>raise_string_as_symsg(
EXPORTING
id_string = content
id_msgty = type
EXCEPTIONS
message = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
add_from_symsg( level = get_level( type ) ).
ENDIF.
IF auto_commit = abap_true.
commit( )."for system store
ENDIF.
ENDMETHOD. "#EC CI_VALPAR
METHOD add_from_symsg.
collector->add_symsg( EXPORTING if_cumulate = abap_true id_detlevel = level IMPORTING es_message = message ).
ENDMETHOD.
METHOD commit.
"调用对象方法, 保存消息到数据库
collector->store(
EXPORTING
if_in_update_task = abap_false
EXCEPTIONS
error = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
RAISING error.
ENDIF.
"提交到数据库
cf_reca_storable=>commit( ).
tlog = me.
ENDMETHOD.
METHOD constructor.
me->object = object.
me->subobject = subobject.
me->identity = identity.
IF is_valid_level( level ).
me->level = level.
ELSE.
me->level = '9'.
ENDIF.
"创建日志对象 gi_msglist, 传入为日志类型、子类型、外部信息
collector = cf_reca_message_list=>create(
id_object = me->object "(SLG0)
id_subobject = me->subobject " (SLG0)
id_extnumber = me->identity "external info
id_deldate = del_date
if_delnotbefore = del_not_before ).
me->auto_commit = auto_commit.
ENDMETHOD.
METHOD debug.
IF uname IS NOT SUPPLIED.
uname = sy-uname.
ENDIF.
##NO_TEXT add_from_string( content = 'Started debug mode by - ' && uname type = 'A' ).
log = me.
##NO_BREAK BREAK-POINT.
ENDMETHOD.
METHOD display_as_alv_popup.
DATA msg_list TYPE re_t_msg.
msg_list = get_msg_list( ). "#EC CI_CONV_OK
DATA: salv TYPE REF TO cl_salv_table.
salv = get_salv( CHANGING table = msg_list ).
salv->set_screen_popup( start_column = start_column
start_line = start_line
end_column = end_column
end_line = end_line ).
salv->display( ).
ENDMETHOD.
METHOD display_in_slg1.
DATA: profile TYPE bal_s_prof.
IF sy-batch IS NOT INITIAL.
RETURN.
ENDIF.
CALL FUNCTION 'BAL_DSP_PROFILE_SINGLE_LOG_GET'
IMPORTING
e_s_display_profile = profile.
CALL FUNCTION 'BAL_DSP_LOG_DISPLAY'
EXPORTING
i_s_display_profile = profile
i_t_log_handle = VALUE bal_t_logh( ( collector->get_handle( ) ) )
i_amodal = amodal
EXCEPTIONS
profile_inconsistent = 1
internal_error = 2
no_data_available = 3
no_authority = 4
OTHERS = 5. "#EC CI_SUBRC
IF sy-subrc <> 0.
MESSAGE ID sy-msgid
TYPE sy-msgty
NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
ENDIF.
tlog = me.
ENDMETHOD.
METHOD error.
add_from_string( content = content type = 'E' ).
log = me.
ENDMETHOD.
METHOD free.
##NO_TEXT info( sy-uname && ' leave this transaction.' ).
IF collector IS BOUND.
collector->free( ).
ENDIF.
CLEAR: level,
object,
subobject,
identity,
collector,
instance.
ENDMETHOD.
METHOD get_collector.
collector = me->collector.
ENDMETHOD.
METHOD get_instance.
IF instance IS NOT BOUND.
CREATE OBJECT instance
EXPORTING
object = object
subobject = subobject
identity = identity
level = level
del_date = del_date
del_not_before = del_not_before
auto_commit = auto_commit.
ENDIF.
log_instance = instance.
ENDMETHOD.
METHOD get_level.
"当日志级别大于等于控制打印级时, 输出日志, 否则不输出, 以节约系统资源
"日志级别 1 - 9, 1表示该日志最为概略, 9表示该日志最为细节
TRANSLATE type TO UPPER CASE.
CASE type.
WHEN 'A'.
level = '9'.
WHEN 'E'.
level = '8'.
WHEN 'W'.
level = '7'.
WHEN 'I'.
level = '6'.
WHEN 'S'.
level = '5'.
WHEN OTHERS.
level = '9'.
ENDCASE.
ENDMETHOD.
METHOD get_msg_list.
collector->get_list( IMPORTING et_list = msg_list ).
ENDMETHOD.
METHOD get_salv.
TRY.
cl_salv_table=>factory(
IMPORTING
r_salv_table = salv
CHANGING
t_table = table ).
CATCH cx_salv_msg ##NO_HANDLER.
ENDTRY.
IF salv IS BOUND.
salv->get_columns( )->set_optimize( abap_true ).
salv->get_functions( )->set_all( ).
TRY.
salv->get_columns(:
)->get_column( 'CONTEXT' )->set_visible( abap_false ),
)->get_column( 'PARAMS' )->set_visible( abap_false ).
CATCH cx_salv_not_found ##NO_HANDLER.
ENDTRY.
ENDIF.
ENDMETHOD.
METHOD info.
add_from_string( content = content type = 'I' ).
log = me.
ENDMETHOD.
METHOD is_valid_level.
##NEEDED
DATA: numc TYPE n LENGTH 1,
type TYPE dd01v-datatype.
CALL FUNCTION 'NUMERIC_CHECK'
EXPORTING
string_in = level
IMPORTING
string_out = numc
htype = type.
IF type = 'NUMC'.
IF level >= 1 AND level <= 9.
is_valid_level = abap_true.
ENDIF.
ENDIF.
ENDMETHOD.
METHOD success.
add_from_string( content = content type = 'S' ).
log = me.
ENDMETHOD.
METHOD warning.
add_from_string( content = content type = 'W' ).
log = me.
ENDMETHOD.
METHOD get_se91_message.
CALL FUNCTION 'RPY_MESSAGE_COMPOSE'
EXPORTING
message_id = id
message_number = num
message_var1 = var1
message_var2 = var2
message_var3 = var3
message_var4 = var4
IMPORTING
message_text = message
EXCEPTIONS
message_not_found = 1
OTHERS = 2. "#EC CI_SUBRC
IF sy-subrc <> 0.
* me->warning( iv_msg_id && iv_msg_num && TEXT-e05 ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~add_log.
DATA kv TYPE ty_kv.
kv-key = lines( dynpro_info ) + 1.
kv-value1 = dynnr.
kv-value2 = ucomm.
GET TIME STAMP FIELD kv-timstmp.
APPEND kv TO dynpro_info.
CASE to_upper( type ).
WHEN 'S'.
success( content ).
WHEN 'I'.
info( content ).
WHEN 'W'.
warning( content ).
WHEN 'E'.
error( content ).
WHEN 'A'.
abort( content ).
WHEN 'D'.
debug( ).
WHEN OTHERS.
success( content ).
ENDCASE.
instance = me.
"SAP标准日志增加时，如果点击频率过快，会导致新增不了，这个时候无法保证自增表和SAP条目一致
IF collector->count( ) <> lines( dynpro_info ).
DELETE dynpro_info INDEX lines( dynpro_info ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~clear.
CLEAR dynpro_info.
collector->clear( ).
instance = me.
ENDMETHOD.
METHOD zif_tlog~save_log.
instance = me.
CHECK if_commit = abap_true.
DATA logs TYPE STANDARD TABLE OF ztscreen_log.
MOVE-CORRESPONDING get_msg_list( ) TO logs. "#EC CI_CONV_OK
DATA lv_name_text TYPE ad_namtext.
##WARN_OK
SELECT SINGLE adrp~name_text
FROM usr21
INNER JOIN adrp
ON usr21~persnumber = adrp~persnumber
INTO lv_name_text
WHERE usr21~bname = sy-uname. "#EC CI_SUBRC
* DATA is_webgui TYPE c.
* CALL FUNCTION 'GUI_GET_DESKTOP_INFO' ##FM_OLDED
* EXPORTING
* type = 5
* CHANGING
* return = is_webgui.
* "后台和非SAP GUI都不记录IP
* IF is_webgui IS NOT INITIAL AND sy-batch = abap_false.
* DATA ip TYPE string.
* ip = cl_gui_frontend_services=>get_ip_address( ).
* ENDIF.
DATA ip TYPE string.
ip = zcl_tlog=>get_ip( ).
DATA opcode(1) TYPE x VALUE 5.
DATA terminal TYPE ztscreen_log-terminal.
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
ID 'TERMINAL' FIELD terminal. "#EC CI_CCALL
FIELD-SYMBOLS <log> LIKE LINE OF logs.
FIELD-SYMBOLS <dynpro_info> LIKE LINE OF dynpro_info.
LOOP AT logs ASSIGNING <log>.
<log>-guid = guid.
<log>-line = sy-tabix.
IF symbol IS INITIAL.
<log>-symbol = get_symbol( <log>-msgty ).
ELSE.
<log>-symbol = symbol.
ENDIF.
<log>-sid = sy-sysid.
<log>-cprog = sy-cprog.
##WARN_OK
READ TABLE dynpro_info ASSIGNING <dynpro_info> WITH KEY key = sy-tabix. "#EC CI_STDSEQ
IF sy-subrc = 0.
<log>-dynnr = <dynpro_info>-value1.
<log>-ucomm = <dynpro_info>-value2.
ENDIF.
<log>-instance = sy-host.
<log>-crnam = sy-uname.
<log>-name_text = lv_name_text.
CONVERT TIME STAMP <log>-time_stmp
TIME ZONE sy-zonlo
INTO DATE <log>-crdat
TIME <log>-crtim.
<log>-monat = <log>-crdat+4(2).
<log>-ip = ip.
<log>-terminal = terminal.
<log>-tcode = sy-tcode.
<log>-message = get_se91_message( id = <log>-msgid
num = <log>-msgno
var1 = <log>-msgv1
var2 = <log>-msgv2
var3 = <log>-msgv3
var4 = <log>-msgv4 ).
IF NOT <log>-message CS 'PAI'.
CLEAR <log>-ucomm.
ENDIF.
ENDLOOP.
INSERT ztscreen_log FROM TABLE logs.
IF sy-subrc <> 0.
MESSAGE 'ERROR OCCURED WHEN INSERT DATA TO DB' TYPE 'S' DISPLAY LIKE 'E'.
* zcx_tscreen=>raise_text( 'ERROR OCCURED WHEN INSERT DATA TO DB' ).
ENDIF.
ENDMETHOD.
METHOD get_symbol.
CASE msgty.
WHEN 'S'.
symbol = icon_okay.
WHEN 'I'.
symbol = icon_led_yellow.
WHEN 'W'.
symbol = icon_message_warning_small.
WHEN 'E'.
symbol = icon_incomplete.
WHEN 'A'.
symbol = icon_cancel.
WHEN 'D'.
symbol = icon_alert.
WHEN OTHERS.
symbol = icon_message_information_small.
ENDCASE.
ENDMETHOD.
METHOD zif_tlog~commit.
commit( ).
instance = me.
ENDMETHOD.
METHOD zif_tlog~show_log.
CASE style.
WHEN '2'.
display_as_alv_popup( ).
WHEN OTHERS.
display_in_slg1( ).
ENDCASE.
instance = me.
ENDMETHOD.
METHOD set_level.
CHECK is_valid_level( level ).
me->level = level.
ENDMETHOD.
METHOD get_ip.
DATA is_webgui TYPE c.
CALL FUNCTION 'GUI_GET_DESKTOP_INFO' ##FM_OLDED
EXPORTING
type = 5
CHANGING
return = is_webgui.
"后台和非SAP GUI都不记录IP
IF is_webgui IS NOT INITIAL AND sy-batch = abap_false.
ip = cl_gui_frontend_services=>get_ip_address( ).
ENDIF.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,347 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CASE tcode.
WHEN 'ME23N'.
SET PARAMETER ID 'BES' FIELD value.
CALL TRANSACTION tcode AND SKIP FIRST SCREEN. "#EC CI_CALLTA
WHEN 'MM03'.
DATA ematn TYPE ekpo-ematn.
ematn = value.
CALL FUNCTION 'MMPUR_MATERIAL_DISPLAY'
EXPORTING
im_matnr = ematn
* im_werks = lv_werks
* im_lgort = lv_lgort
EXCEPTIONS
error_message = 1
OTHERS = 2.
IF sy-subrc NE 0.
read_sysmsg( abap_true ).
ENDIF.
WHEN OTHERS.
"这里没有处理的事务，就在子类自行重写补充
ENDCASE.
``` | I found vulnerabilities in the line:
```abap
CALL TRANSACTION tcode AND SKIP FIRST SCREEN.
```
Explanation: Add an authority check to CALL TRANSACTION. | 2,348 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ZCL_TLOG IMPLEMENTATION.
METHOD abort.
add_from_string( content = content type = 'A' ).
log = me.
ENDMETHOD.
METHOD add_from_bapi.
collector->add_from_bapi(
EXPORTING
it_bapiret = it_bapiret
is_bapiret = is_bapiret
if_cumulate = if_cumulate
IMPORTING
ef_add_error = ef_add_error
ef_add_warning = ef_add_warning ).
ENDMETHOD.
METHOD add_from_exception.
collector->add_from_exception( io_exception = io_exception
if_cumulate = if_cumulate
id_detlevel = id_detlevel
id_probclass = id_probclass
id_tabname = id_tabname
id_fieldname = id_fieldname
id_value = id_value
id_index = id_index
id_intreno = id_intreno
id_context = id_context ).
ENDMETHOD.
METHOD add_from_string.
CHECK get_level( type ) >= me->level.
CONCATENATE sy-uzeit ':' content INTO content.
cl_reca_string_services=>raise_string_as_symsg(
EXPORTING
id_string = content
id_msgty = type
EXCEPTIONS
message = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
add_from_symsg( level = get_level( type ) ).
ENDIF.
IF auto_commit = abap_true.
commit( )."for system store
ENDIF.
ENDMETHOD. "#EC CI_VALPAR
METHOD add_from_symsg.
collector->add_symsg( EXPORTING if_cumulate = abap_true id_detlevel = level IMPORTING es_message = message ).
ENDMETHOD.
METHOD commit.
"调用对象方法, 保存消息到数据库
collector->store(
EXPORTING
if_in_update_task = abap_false
EXCEPTIONS
error = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
RAISING error.
ENDIF.
"提交到数据库
cf_reca_storable=>commit( ).
tlog = me.
ENDMETHOD.
METHOD constructor.
me->object = object.
me->subobject = subobject.
me->identity = identity.
IF is_valid_level( level ).
me->level = level.
ELSE.
me->level = '9'.
ENDIF.
"创建日志对象 gi_msglist, 传入为日志类型、子类型、外部信息
collector = cf_reca_message_list=>create(
id_object = me->object "(SLG0)
id_subobject = me->subobject " (SLG0)
id_extnumber = me->identity "external info
id_deldate = del_date
if_delnotbefore = del_not_before ).
me->auto_commit = auto_commit.
ENDMETHOD.
METHOD debug.
IF uname IS NOT SUPPLIED.
uname = sy-uname.
ENDIF.
##NO_TEXT add_from_string( content = 'Started debug mode by - ' && uname type = 'A' ).
log = me.
##NO_BREAK BREAK-POINT.
ENDMETHOD.
METHOD display_as_alv_popup.
DATA msg_list TYPE re_t_msg.
msg_list = get_msg_list( ). "#EC CI_CONV_OK
DATA: salv TYPE REF TO cl_salv_table.
salv = get_salv( CHANGING table = msg_list ).
salv->set_screen_popup( start_column = start_column
start_line = start_line
end_column = end_column
end_line = end_line ).
salv->display( ).
ENDMETHOD.
METHOD display_in_slg1.
DATA: profile TYPE bal_s_prof.
IF sy-batch IS NOT INITIAL.
RETURN.
ENDIF.
CALL FUNCTION 'BAL_DSP_PROFILE_SINGLE_LOG_GET'
IMPORTING
e_s_display_profile = profile.
CALL FUNCTION 'BAL_DSP_LOG_DISPLAY'
EXPORTING
i_s_display_profile = profile
i_t_log_handle = VALUE bal_t_logh( ( collector->get_handle( ) ) )
i_amodal = amodal
EXCEPTIONS
profile_inconsistent = 1
internal_error = 2
no_data_available = 3
no_authority = 4
OTHERS = 5. "#EC CI_SUBRC
IF sy-subrc <> 0.
MESSAGE ID sy-msgid
TYPE sy-msgty
NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
ENDIF.
tlog = me.
ENDMETHOD.
METHOD error.
add_from_string( content = content type = 'E' ).
log = me.
ENDMETHOD.
METHOD free.
##NO_TEXT info( sy-uname && ' leave this transaction.' ).
IF collector IS BOUND.
collector->free( ).
ENDIF.
CLEAR: level,
object,
subobject,
identity,
collector,
instance.
ENDMETHOD.
METHOD get_collector.
collector = me->collector.
ENDMETHOD.
METHOD get_instance.
IF instance IS NOT BOUND.
CREATE OBJECT instance
EXPORTING
object = object
subobject = subobject
identity = identity
level = level
del_date = del_date
del_not_before = del_not_before
auto_commit = auto_commit.
ENDIF.
log_instance = instance.
ENDMETHOD.
METHOD get_level.
"当日志级别大于等于控制打印级时, 输出日志, 否则不输出, 以节约系统资源
"日志级别 1 - 9, 1表示该日志最为概略, 9表示该日志最为细节
TRANSLATE type TO UPPER CASE.
CASE type.
WHEN 'A'.
level = '9'.
WHEN 'E'.
level = '8'.
WHEN 'W'.
level = '7'.
WHEN 'I'.
level = '6'.
WHEN 'S'.
level = '5'.
WHEN OTHERS.
level = '9'.
ENDCASE.
ENDMETHOD.
METHOD get_msg_list.
collector->get_list( IMPORTING et_list = msg_list ).
ENDMETHOD.
METHOD get_salv.
TRY.
cl_salv_table=>factory(
IMPORTING
r_salv_table = salv
CHANGING
t_table = table ).
CATCH cx_salv_msg ##NO_HANDLER.
ENDTRY.
IF salv IS BOUND.
salv->get_columns( )->set_optimize( abap_true ).
salv->get_functions( )->set_all( ).
TRY.
salv->get_columns(:
)->get_column( 'CONTEXT' )->set_visible( abap_false ),
)->get_column( 'PARAMS' )->set_visible( abap_false ).
CATCH cx_salv_not_found ##NO_HANDLER.
ENDTRY.
ENDIF.
ENDMETHOD.
METHOD info.
add_from_string( content = content type = 'I' ).
log = me.
ENDMETHOD.
METHOD is_valid_level.
##NEEDED DATA: numc TYPE n LENGTH 1,
type TYPE dd01v-datatype.
CALL FUNCTION 'NUMERIC_CHECK'
EXPORTING
string_in = level
IMPORTING
string_out = numc
htype = type.
IF type = 'NUMC'.
is_valid_level = abap_true.
ENDIF.
ENDMETHOD.
METHOD success.
add_from_string( content = content type = 'S' ).
log = me.
ENDMETHOD.
METHOD warning.
add_from_string( content = content type = 'W' ).
log = me.
ENDMETHOD.
METHOD get_se91_message.
CALL FUNCTION 'RPY_MESSAGE_COMPOSE'
EXPORTING
message_id = id
message_number = num
message_var1 = var1
message_var2 = var2
message_var3 = var3
message_var4 = var4
IMPORTING
message_text = message
EXCEPTIONS
message_not_found = 1
OTHERS = 2. "#EC CI_SUBRC
IF sy-subrc <> 0.
* me->warning( iv_msg_id && iv_msg_num && TEXT-e05 ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~add_log.
DATA kv TYPE ty_kv.
kv-key = lines( dynpro_info ) + 1.
kv-value1 = dynnr.
kv-value2 = ucomm.
GET TIME STAMP FIELD kv-timstmp.
APPEND kv TO dynpro_info.
CASE to_upper( type ).
WHEN 'S'.
success( content ).
WHEN 'I'.
info( content ).
WHEN 'W'.
warning( content ).
WHEN 'E'.
error( content ).
WHEN 'A'.
abort( content ).
WHEN 'D'.
debug( ).
WHEN OTHERS.
success( content ).
ENDCASE.
instance = me.
"SAP标准日志增加时，如果点击频率过快，会导致新增不了，这个时候无法保证自增表和SAP条目一致
IF collector->count( ) <> lines( dynpro_info ).
DELETE dynpro_info INDEX lines( dynpro_info ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~clear.
CLEAR dynpro_info.
collector->clear( ).
instance = me.
ENDMETHOD.
METHOD zif_tlog~save_log.
instance = me.
CHECK if_commit = abap_true.
DATA logs TYPE STANDARD TABLE OF ztscreen_log.
MOVE-CORRESPONDING get_msg_list( ) TO logs. "#EC CI_CONV_OK
DATA lv_name_text TYPE ad_namtext.
SELECT SINGLE adrp~name_text
FROM usr21
INNER JOIN adrp
ON usr21~persnumber = adrp~persnumber
INTO lv_name_text
WHERE usr21~bname = sy-uname. "#EC CI_SUBRC
DATA is_webgui TYPE c.
CALL FUNCTION 'GUI_GET_DESKTOP_INFO' ##FM_OLDED
EXPORTING
type = 5
CHANGING
return = is_webgui.
"后台和非SAP GUI都不记录IP
IF is_webgui IS NOT INITIAL AND sy-batch = abap_false.
DATA ip TYPE string.
ip = cl_gui_frontend_services=>get_ip_address( ).
ENDIF.
DATA opcode(1) TYPE x VALUE 5.
DATA terminal TYPE ztscreen_log-terminal.
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
ID 'TERMINAL' FIELD terminal."#EC CI_CCALL
FIELD-SYMBOLS <log> LIKE LINE OF logs.
FIELD-SYMBOLS <dynpro_info> LIKE LINE OF dynpro_info.
LOOP AT logs ASSIGNING <log>.
<log>-guid = guid.
<log>-line = sy-tabix.
IF symbol IS INITIAL.
<log>-symbol = get_symbol( <log>-msgty ).
ELSE.
<log>-symbol = symbol.
ENDIF.
<log>-sid = sy-sysid.
<log>-cprog = sy-cprog.
READ TABLE dynpro_info ASSIGNING <dynpro_info> WITH KEY key = sy-tabix. "#EC CI_STDSEQ
IF sy-subrc = 0.
<log>-dynnr = <dynpro_info>-value1.
<log>-ucomm = <dynpro_info>-value2.
ENDIF.
<log>-instance = sy-host.
<log>-crnam = sy-uname.
<log>-name_text = lv_name_text.
CONVERT TIME STAMP <log>-time_stmp
TIME ZONE sy-zonlo
INTO DATE <log>-crdat
TIME <log>-crtim.
<log>-monat = <log>-crdat+4(2).
<log>-ip = ip.
<log>-terminal = terminal.
<log>-tcode = sy-tcode.
<log>-message = get_se91_message( id = <log>-msgid
num = <log>-msgno
var1 = <log>-msgv1
var2 = <log>-msgv2
var3 = <log>-msgv3
var4 = <log>-msgv4 ).
IF NOT <log>-message CS 'PAI'.
CLEAR <log>-ucomm.
ENDIF.
ENDLOOP.
INSERT ztscreen_log FROM TABLE logs.
IF sy-subrc <> 0.
MESSAGE 'ERROR OCCURED WHEN INSERT DATA TO DB' TYPE 'S' DISPLAY LIKE 'E'.
* zcx_tscreen=>raise_text( 'ERROR OCCURED WHEN INSERT DATA TO DB' ).
ENDIF.
ENDMETHOD.
METHOD get_symbol.
CASE msgty.
WHEN 'S'.
symbol = icon_okay.
WHEN 'I'.
symbol = icon_led_yellow.
WHEN 'W'.
symbol = icon_message_warning_small.
WHEN 'E'.
symbol = icon_incomplete.
WHEN 'A'.
symbol = icon_cancel.
WHEN 'D'.
symbol = icon_alert.
WHEN OTHERS.
symbol = icon_message_information_small.
ENDCASE.
ENDMETHOD.
METHOD zif_tlog~commit.
commit( ).
instance = me.
ENDMETHOD.
METHOD zif_tlog~show_log.
CASE style.
WHEN '2'.
display_as_alv_popup( ).
WHEN OTHERS.
display_in_slg1( ).
ENDCASE.
instance = me.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,349 |
Find vulnerabilities in this ABAP code snippet. | ```abap
CLASS ZCL_TLOG IMPLEMENTATION.
METHOD abort.
add_from_string( content = content type = 'A' ).
log = me.
ENDMETHOD.
METHOD add_from_bapi.
collector->add_from_bapi(
EXPORTING
it_bapiret = it_bapiret
is_bapiret = is_bapiret
if_cumulate = if_cumulate
IMPORTING
ef_add_error = ef_add_error
ef_add_warning = ef_add_warning ).
ENDMETHOD.
METHOD add_from_exception.
collector->add_from_exception( io_exception = io_exception
if_cumulate = if_cumulate
id_detlevel = id_detlevel
id_probclass = id_probclass
id_tabname = id_tabname
id_fieldname = id_fieldname
id_value = id_value
id_index = id_index
id_intreno = id_intreno
id_context = id_context ).
ENDMETHOD.
METHOD add_from_string.
CHECK get_level( type ) >= me->level.
CONCATENATE sy-uzeit ':' content INTO content.
cl_reca_string_services=>raise_string_as_symsg(
EXPORTING
id_string = content
id_msgty = type
EXCEPTIONS
message = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
add_from_symsg( level = get_level( type ) ).
ENDIF.
IF auto_commit = abap_true.
commit( )."for system store
ENDIF.
ENDMETHOD. "#EC CI_VALPAR
METHOD add_from_symsg.
collector->add_symsg( EXPORTING if_cumulate = abap_true id_detlevel = level IMPORTING es_message = message ).
ENDMETHOD.
METHOD commit.
"调用对象方法, 保存消息到数据库
collector->store(
EXPORTING
if_in_update_task = abap_false
EXCEPTIONS
error = 1
OTHERS = 2 ).
IF sy-subrc <> 0.
MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4
RAISING error.
ENDIF.
"提交到数据库
cf_reca_storable=>commit( ).
tlog = me.
ENDMETHOD.
METHOD constructor.
me->object = object.
me->subobject = subobject.
me->identity = identity.
IF is_valid_level( level ).
me->level = level.
ELSE.
me->level = '9'.
ENDIF.
"创建日志对象 gi_msglist, 传入为日志类型、子类型、外部信息
collector = cf_reca_message_list=>create(
id_object = me->object "(SLG0)
id_subobject = me->subobject " (SLG0)
id_extnumber = me->identity "external info
id_deldate = del_date
if_delnotbefore = del_not_before ).
me->auto_commit = auto_commit.
ENDMETHOD.
METHOD debug.
IF uname IS NOT SUPPLIED.
uname = sy-uname.
ENDIF.
##NO_TEXT add_from_string( content = 'Started debug mode by - ' && uname type = 'A' ).
log = me.
##NO_BREAK BREAK-POINT.
ENDMETHOD.
METHOD display_as_alv_popup.
DATA msg_list TYPE re_t_msg.
msg_list = get_msg_list( ). "#EC CI_CONV_OK
DATA: salv TYPE REF TO cl_salv_table.
salv = get_salv( CHANGING table = msg_list ).
salv->set_screen_popup( start_column = start_column
start_line = start_line
end_column = end_column
end_line = end_line ).
salv->display( ).
ENDMETHOD.
METHOD display_in_slg1.
DATA: profile TYPE bal_s_prof.
IF sy-batch IS NOT INITIAL.
RETURN.
ENDIF.
CALL FUNCTION 'BAL_DSP_PROFILE_SINGLE_LOG_GET'
IMPORTING
e_s_display_profile = profile.
CALL FUNCTION 'BAL_DSP_LOG_DISPLAY'
EXPORTING
i_s_display_profile = profile
i_t_log_handle = VALUE bal_t_logh( ( collector->get_handle( ) ) )
i_amodal = amodal
EXCEPTIONS
profile_inconsistent = 1
internal_error = 2
no_data_available = 3
no_authority = 4
OTHERS = 5. "#EC CI_SUBRC
IF sy-subrc <> 0.
MESSAGE ID sy-msgid
TYPE sy-msgty
NUMBER sy-msgno
WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
ENDIF.
tlog = me.
ENDMETHOD.
METHOD error.
add_from_string( content = content type = 'E' ).
log = me.
ENDMETHOD.
METHOD free.
##NO_TEXT info( sy-uname && ' leave this transaction.' ).
IF collector IS BOUND.
collector->free( ).
ENDIF.
CLEAR: level,
object,
subobject,
identity,
collector,
instance.
ENDMETHOD.
METHOD get_collector.
collector = me->collector.
ENDMETHOD.
METHOD get_instance.
IF instance IS NOT BOUND.
CREATE OBJECT instance
EXPORTING
object = object
subobject = subobject
identity = identity
level = level
del_date = del_date
del_not_before = del_not_before
auto_commit = auto_commit.
ENDIF.
log_instance = instance.
ENDMETHOD.
METHOD get_level.
"当日志级别大于等于控制打印级时, 输出日志, 否则不输出, 以节约系统资源
"日志级别 1 - 9, 1表示该日志最为概略, 9表示该日志最为细节
TRANSLATE type TO UPPER CASE.
CASE type.
WHEN 'A'.
level = '9'.
WHEN 'E'.
level = '8'.
WHEN 'W'.
level = '7'.
WHEN 'I'.
level = '6'.
WHEN 'S'.
level = '5'.
WHEN OTHERS.
level = '9'.
ENDCASE.
ENDMETHOD.
METHOD get_msg_list.
collector->get_list( IMPORTING et_list = msg_list ).
ENDMETHOD.
METHOD get_salv.
TRY.
cl_salv_table=>factory(
IMPORTING
r_salv_table = salv
CHANGING
t_table = table ).
CATCH cx_salv_msg ##NO_HANDLER.
ENDTRY.
IF salv IS BOUND.
salv->get_columns( )->set_optimize( abap_true ).
salv->get_functions( )->set_all( ).
TRY.
salv->get_columns(:
)->get_column( 'CONTEXT' )->set_visible( abap_false ),
)->get_column( 'PARAMS' )->set_visible( abap_false ).
CATCH cx_salv_not_found ##NO_HANDLER.
ENDTRY.
ENDIF.
ENDMETHOD.
METHOD info.
add_from_string( content = content type = 'I' ).
log = me.
ENDMETHOD.
METHOD is_valid_level.
##NEEDED DATA: numc TYPE n LENGTH 1,
type TYPE dd01v-datatype.
CALL FUNCTION 'NUMERIC_CHECK'
EXPORTING
string_in = level
IMPORTING
string_out = numc
htype = type.
IF type = 'NUMC'.
is_valid_level = abap_true.
ENDIF.
ENDMETHOD.
METHOD success.
add_from_string( content = content type = 'S' ).
log = me.
ENDMETHOD.
METHOD warning.
add_from_string( content = content type = 'W' ).
log = me.
ENDMETHOD.
METHOD get_se91_message.
CALL FUNCTION 'RPY_MESSAGE_COMPOSE'
EXPORTING
message_id = id
message_number = num
message_var1 = var1
message_var2 = var2
message_var3 = var3
message_var4 = var4
IMPORTING
message_text = message
EXCEPTIONS
message_not_found = 1
OTHERS = 2. "#EC CI_SUBRC
IF sy-subrc <> 0.
* me->warning( iv_msg_id && iv_msg_num && TEXT-e05 ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~add_log.
DATA kv TYPE ty_kv.
kv-key = lines( dynpro_info ) + 1.
kv-value1 = dynnr.
kv-value2 = ucomm.
GET TIME STAMP FIELD kv-timstmp.
APPEND kv TO dynpro_info.
CASE to_upper( type ).
WHEN 'S'.
success( content ).
WHEN 'I'.
info( content ).
WHEN 'W'.
warning( content ).
WHEN 'E'.
error( content ).
WHEN 'A'.
abort( content ).
WHEN 'D'.
debug( ).
WHEN OTHERS.
success( content ).
ENDCASE.
instance = me.
"SAP标准日志增加时，如果点击频率过快，会导致新增不了，这个时候无法保证自增表和SAP条目一致
IF collector->count( ) <> lines( dynpro_info ).
DELETE dynpro_info INDEX lines( dynpro_info ).
ENDIF.
ENDMETHOD.
METHOD zif_tlog~clear.
CLEAR dynpro_info.
collector->clear( ).
instance = me.
ENDMETHOD.
METHOD zif_tlog~save_log.
instance = me.
CHECK if_commit = abap_true.
DATA logs TYPE STANDARD TABLE OF ztscreen_log.
MOVE-CORRESPONDING get_msg_list( ) TO logs. "#EC CI_CONV_OK
DATA lv_name_text TYPE ad_namtext.
SELECT SINGLE adrp~name_text
FROM usr21
INNER JOIN adrp
ON usr21~persnumber = adrp~persnumber
INTO lv_name_text
WHERE usr21~bname = sy-uname. "#EC CI_SUBRC
DATA is_webgui TYPE c.
CALL FUNCTION 'GUI_GET_DESKTOP_INFO'
EXPORTING
type = 5
CHANGING
return = is_webgui.
"后台和非SAP GUI都不记录IP
IF is_webgui IS NOT INITIAL AND sy-batch = abap_false.
DATA ip TYPE string.
ip = cl_gui_frontend_services=>get_ip_address( ).
ENDIF.
DATA opcode(1) TYPE x VALUE 5.
DATA terminal TYPE ztscreen_log-terminal.
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
ID 'TERMINAL' FIELD terminal.
FIELD-SYMBOLS <log> LIKE LINE OF logs.
FIELD-SYMBOLS <dynpro_info> LIKE LINE OF dynpro_info.
LOOP AT logs ASSIGNING <log>.
<log>-guid = guid.
<log>-line = sy-tabix.
IF symbol IS INITIAL.
<log>-symbol = get_symbol( <log>-msgty ).
ELSE.
<log>-symbol = symbol.
ENDIF.
<log>-sid = sy-sysid.
<log>-cprog = sy-cprog.
READ TABLE dynpro_info ASSIGNING <dynpro_info> WITH KEY key = sy-tabix. "#EC CI_STDSEQ
IF sy-subrc = 0.
<log>-dynnr = <dynpro_info>-value1.
<log>-ucomm = <dynpro_info>-value2.
ENDIF.
<log>-instance = sy-host.
<log>-crnam = sy-uname.
<log>-name_text = lv_name_text.
CONVERT TIME STAMP <log>-time_stmp
TIME ZONE sy-zonlo
INTO DATE <log>-crdat
TIME <log>-crtim.
<log>-monat = <log>-crdat+4(2).
<log>-ip = ip.
<log>-terminal = terminal.
<log>-tcode = sy-tcode.
<log>-message = get_se91_message( id = <log>-msgid
num = <log>-msgno
var1 = <log>-msgv1
var2 = <log>-msgv2
var3 = <log>-msgv3
var4 = <log>-msgv4 ).
IF NOT <log>-message CS 'PAI'.
CLEAR <log>-ucomm.
ENDIF.
ENDLOOP.
INSERT ztscreen_log FROM TABLE logs.
IF sy-subrc <> 0.
MESSAGE 'ERROR OCCURED WHEN INSERT DATA TO DB' TYPE 'S' DISPLAY LIKE 'E'.
* zcx_tscreen=>raise_text( 'ERROR OCCURED WHEN INSERT DATA TO DB' ).
ENDIF.
ENDMETHOD.
METHOD get_symbol.
CASE msgty.
WHEN 'S'.
symbol = icon_okay.
WHEN 'I'.
symbol = icon_led_yellow.
WHEN 'W'.
symbol = icon_message_warning_small.
WHEN 'E'.
symbol = icon_incomplete.
WHEN 'A'.
symbol = icon_cancel.
WHEN 'D'.
symbol = icon_alert.
WHEN OTHERS.
symbol = icon_message_information_small.
ENDCASE.
ENDMETHOD.
ENDCLASS.
``` | I found vulnerabilities in the line:
```abap
CALL 'ThUsrInfo' ID 'OPCODE' FIELD opcode
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,351 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF blacklist IS NOT INITIAL.
dynsel = | EXECTYPE = 'PROG' AND EXECNAME = '{ s_varid-report }' |.
SELECT COUNT(*) FROM (ablm_blacklist)
WHERE (dynsel).
CHECK sy-subrc NE 0.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT COUNT(*) FROM (ablm_blacklist)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,352 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD tree_initialize.
DATA:
ls_tree_group TYPE ts_tree_group,
lv_ok TYPE abap_bool,
lo_struc TYPE REF TO cl_abap_structdescr, " TODO class attributes
ls_comp TYPE REF TO abap_compdescr,
lv_len TYPE string,
lv_dec TYPE string,
lv_type TYPE string,
lt_code TYPE stringtab,
lv_line TYPE string,
lv_message TYPE string,
lv_pos TYPE i. "#EC NEEDED
FIELD-SYMBOLS:
<ls_row_match> TYPE any,
<lv_any> TYPE any.
" The same key and base fields
LOOP AT ct_row_match ASSIGNING <ls_row_match>.
MOVE-CORRESPONDING <ls_row_match> TO ls_tree_group.
" Yes create new program on fly
IF ls_tree_group-if_where IS NOT INITIAL.
lv_ok = abap_true.
ENDIF.
ENDLOOP.
" Raise event
SET HANDLER catch_prepare_tree.
tree_raise_prepare(
ir_tree = ir_tree
iv_level = 0 ).
CLEAR mt_func.
" No need in program
CHECK lv_ok = abap_true.
ASSIGN ir_tree->data->* TO <lv_any>.
lo_struc ?= cl_abap_typedescr=>describe_by_data( <lv_any> ).
" Structure declaration
APPEND `REPORT DYNAMIC_IF. TYPES: BEGIN OF TS_ROW, ` TO lt_code.
LOOP AT lo_struc->components REFERENCE INTO ls_comp.
" Convert to strings
lv_len = ls_comp->length.
lv_dec = ls_comp->decimals.
CASE ls_comp->type_kind.
" Convert to string
WHEN cl_abap_typedescr=>typekind_char OR cl_abap_typedescr=>typekind_clike OR
cl_abap_typedescr=>typekind_csequence OR cl_abap_typedescr=>typekind_string.
lv_type = 'STRING'.
" Integer, byte, short
WHEN cl_abap_typedescr=>typekind_int OR cl_abap_typedescr=>typekind_int1 OR cl_abap_typedescr=>typekind_int2.
lv_type = 'INT4'.
" Use mask and don't delete dots in ZCL_XTT_REPLACE_BLOCK=>get_as_string
WHEN cl_abap_typedescr=>typekind_num OR cl_abap_typedescr=>typekind_numeric.
CONCATENATE ` n LENGTH ` lv_len INTO lv_type. "#EC NOTEXT thanks to Zhukov, Evgenii No need ` DECIMALS ` lv_dec
" Double
WHEN cl_abap_typedescr=>typekind_packed OR cl_abap_typedescr=>typekind_float OR
'/' OR 'a' OR 'e'. " cl_abap_typedescr=>typekind_decfloat OR cl_abap_typedescr=>typekind_decfloat16 OR cl_abap_typedescr=>typekind_decfloat34.
lv_type = ` p LENGTH 16 DECIMALS 5`. "#EC NOTEXT No need to be spcific
" Date
WHEN cl_abap_typedescr=>typekind_date.
lv_type = 'SYDATUM'.
" Time
WHEN cl_abap_typedescr=>typekind_time.
lv_type = 'SYUZEIT'.
WHEN OTHERS.
CONTINUE.
ENDCASE.
CONCATENATE ls_comp->name ` TYPE ` lv_type `,` INTO lv_type. "#EC NOTEXT
APPEND lv_type TO lt_code.
ENDLOOP.
APPEND 'END OF TS_ROW.' TO lt_code. "#EC NOTEXT
" Global structure
APPEND '' TO lt_code.
APPEND 'DATA: ROW TYPE TS_ROW.' TO lt_code. "#EC NOTEXT
APPEND '' TO lt_code.
" Generate FORMs
LOOP AT ct_row_match ASSIGNING <ls_row_match>.
MOVE-CORRESPONDING <ls_row_match> TO ls_tree_group.
CHECK ls_tree_group-if_where IS NOT INITIAL.
" Name of FORM
ls_tree_group-if_form = sy-tabix.
CONDENSE ls_tree_group-if_form.
CONCATENATE `F_` ls_tree_group-if_form INTO ls_tree_group-if_form.
" Change form name
ASSIGN COMPONENT 'IF_FORM' OF STRUCTURE <ls_row_match> TO <lv_any>.
<lv_any> = ls_tree_group-if_form.
" FORM declaration
CONCATENATE `FORM ` ls_tree_group-if_form ` USING is_row TYPE ANY CHANGING cv_ok TYPE abap_bool.` INTO lv_line. "#EC NOTEXT
APPEND lv_line TO lt_code.
APPEND 'MOVE-CORRESPONDING is_row TO row.' TO lt_code. "#EC NOTEXT
CONCATENATE `IF ` ls_tree_group-if_where `. cv_ok = 'X'. ENDIF.` INTO lv_line. "#EC NOTEXT
APPEND lv_line TO lt_code.
APPEND 'ENDFORM.' TO lt_code. "#EC NOTEXT
APPEND '' TO lt_code.
ENDLOOP.
GENERATE SUBROUTINE POOL lt_code NAME ev_program
MESSAGE lv_message
LINE lv_pos. "#EC CI_GENERATE. <--- in lt_code[]
" Ooops! wrong syntax in if_show of if_hide!
IF sy-subrc <> 0.
MESSAGE lv_message TYPE 'X'.
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
GENERATE SUBROUTINE POOL lt_code NAME ev_program
```
Explanation: Potential dangerous statement GENERATE SUBROUTINE. | 2,354 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD tree_initialize.
DATA:
ls_tree_group TYPE ts_tree_group,
lv_ok TYPE abap_bool,
lo_struc TYPE REF TO cl_abap_structdescr, " TODO class attributes
ls_comp TYPE REF TO abap_compdescr,
lv_len TYPE string,
lv_dec TYPE string,
lv_type TYPE string,
lt_code TYPE stringtab,
lv_line TYPE string,
lv_message TYPE string,
lv_pos TYPE i. "#EC NEEDED
FIELD-SYMBOLS:
<ls_row_match> TYPE any,
<lv_any> TYPE any.
" The same key and base fields
LOOP AT ct_row_match ASSIGNING <ls_row_match>.
MOVE-CORRESPONDING <ls_row_match> TO ls_tree_group.
" Yes create new program on fly
IF ls_tree_group-if_where IS NOT INITIAL.
lv_ok = abap_true.
ENDIF.
ENDLOOP.
" Raise event
SET HANDLER catch_prepare_tree.
tree_raise_prepare(
ir_tree = ir_tree
iv_level = 0 ).
CLEAR mt_func.
" No need in program
CHECK lv_ok = abap_true.
ASSIGN ir_tree->data->* TO <lv_any>.
lo_struc ?= cl_abap_typedescr=>describe_by_data( <lv_any> ).
" Structure declaration
APPEND `REPORT DYNAMIC_IF. TYPES: BEGIN OF TS_ROW, ` TO lt_code.
LOOP AT lo_struc->components REFERENCE INTO ls_comp.
" Convert to strings
lv_len = ls_comp->length.
lv_dec = ls_comp->decimals.
CASE ls_comp->type_kind.
" Convert to string
WHEN cl_abap_typedescr=>typekind_char OR cl_abap_typedescr=>typekind_clike OR
cl_abap_typedescr=>typekind_csequence OR cl_abap_typedescr=>typekind_string.
lv_type = 'STRING'.
" Integer, byte, short
WHEN cl_abap_typedescr=>typekind_int OR cl_abap_typedescr=>typekind_int1 OR cl_abap_typedescr=>typekind_int2.
lv_type = 'INT4'.
" Use mask and don't delete dots in ZCL_XTT_REPLACE_BLOCK=>get_as_string
WHEN cl_abap_typedescr=>typekind_num OR cl_abap_typedescr=>typekind_numeric.
CONCATENATE ` n LENGTH ` lv_len ` DECIMALS ` lv_dec INTO lv_type. "#EC NOTEXT
" Double
WHEN cl_abap_typedescr=>typekind_packed OR cl_abap_typedescr=>typekind_float OR
'/' OR 'a' OR 'e'. " cl_abap_typedescr=>typekind_decfloat OR cl_abap_typedescr=>typekind_decfloat16 OR cl_abap_typedescr=>typekind_decfloat34.
lv_type = ` p LENGTH 16 DECIMALS 5`. "#EC NOTEXT No need to be spcific
" Date
WHEN cl_abap_typedescr=>typekind_date.
lv_type = 'SYDATUM'.
" Time
WHEN cl_abap_typedescr=>typekind_time.
lv_type = 'SYUZEIT'.
WHEN OTHERS.
CONTINUE.
ENDCASE.
CONCATENATE ls_comp->name ` TYPE ` lv_type `,` INTO lv_type. "#EC NOTEXT
APPEND lv_type TO lt_code.
ENDLOOP.
APPEND 'END OF TS_ROW.' TO lt_code. "#EC NOTEXT
" Global structure
APPEND '' TO lt_code.
APPEND 'DATA: ROW TYPE TS_ROW.' TO lt_code. "#EC NOTEXT
APPEND '' TO lt_code.
" Generate FORMs
LOOP AT ct_row_match ASSIGNING <ls_row_match>.
MOVE-CORRESPONDING <ls_row_match> TO ls_tree_group.
CHECK ls_tree_group-if_where IS NOT INITIAL.
" Name of FORM
ls_tree_group-if_form = sy-tabix.
CONDENSE ls_tree_group-if_form.
CONCATENATE `F_` ls_tree_group-if_form INTO ls_tree_group-if_form.
" Change form name
ASSIGN COMPONENT 'IF_FORM' OF STRUCTURE <ls_row_match> TO <lv_any>.
<lv_any> = ls_tree_group-if_form.
" FORM declaration
CONCATENATE `FORM ` ls_tree_group-if_form ` USING is_row TYPE ANY CHANGING cv_ok TYPE abap_bool.` INTO lv_line. "#EC NOTEXT
APPEND lv_line TO lt_code.
APPEND 'MOVE-CORRESPONDING is_row TO row.' TO lt_code. "#EC NOTEXT
CONCATENATE `IF ` ls_tree_group-if_where `. cv_ok = 'X'. ENDIF.` INTO lv_line. "#EC NOTEXT
APPEND lv_line TO lt_code.
APPEND 'ENDFORM.' TO lt_code. "#EC NOTEXT
APPEND '' TO lt_code.
ENDLOOP.
GENERATE SUBROUTINE POOL lt_code NAME ev_program
MESSAGE lv_message
LINE lv_pos. "#EC CI_GENERATE. <--- in lt_code[]
" Ooops! wrong syntax in if_show of if_hide!
IF sy-subrc <> 0.
MESSAGE lv_message TYPE 'X'.
ENDIF.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
GENERATE SUBROUTINE POOL lt_code NAME ev_program
```
Explanation: Potential dangerous statement GENERATE SUBROUTINE. | 2,355 |
Find vulnerabilities in this ABAP code snippet. | ```abap
method OVCABSET_GET_ENTITYSET.
DATA: lt_cab TYPE STANDARD TABLE OF zovcab.
DATA: ls_cab TYPE zovcab.
DATA: ls_entityset LIKE LINE OF et_entityset.
DATA: lt_orderby TYPE STANDARD TABLE OF string.
DATA: ld_orderby TYPE string.
" montando orderby dinâmico
LOOP AT it_order INTO DATA(ls_order).
TRANSLATE ls_order-property TO UPPER CASE.
TRANSLATE ls_order-order TO UPPER CASE.
IF ls_order-order = 'DESC'.
ls_order-order = 'DESCENDING'.
ELSE.
ls_order-order = 'ASCENDING'.
ENDIF.
APPEND |{ ls_order-property } { ls_order-order }|
TO lt_orderby.
ENDLOOP.
CONCATENATE LINES OF lt_orderby INTO ld_orderby SEPARATED BY ''.
" ordenação obrigatória caso nenhuma seja definida
IF ld_orderby = '' .
ld_orderby = 'OrdemId ASCENDING'.
ENDIF.
SELECT *
FROM zovcab
WHERE (IV_FILTER_STRING)
ORDER BY (ld_orderby)
``` | I found vulnerabilities in the line:
```abap
SELECT * * <-- There is a problem here
FROM zovcab
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,357 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF replace_select = abap_false.
SELECT * FROM (table_name) INTO TABLE @<initial_data>
ORDER BY PRIMARY KEY.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (table_name) INTO TABLE @<initial_data>
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,358 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
validate( IMPORTING result = DATA(result)
duplicates = DATA(duplicates)
inserted = DATA(inserted)
deleted = DATA(deleted)
before_modified = DATA(before_modified)
modified = DATA(modified) ).
"Abort with message if data is invalid
IF result = c_validation-incorrect_values.
"^Message already displayed by ALV GRID
RETURN.
ELSEIF result = c_validation-duplicates.
messages->show_duplicates( table_name = table_name duplicates = duplicates mandant_col_name = table_fields->mandant_field ).
RETURN.
ENDIF.
IF messages->confirm_save( ) = abap_false.
RETURN.
ENDIF.
"---EXTENSION CALL---
extension->before_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
"Again with unnecessary "FieLDs-sYmBOls"
FIELD-SYMBOLS <modified> TYPE table.
FIELD-SYMBOLS <inserted> TYPE table.
FIELD-SYMBOLS <deleted> TYPE table.
ASSIGN modified->* TO <modified>.
ASSIGN inserted->* TO <inserted>.
ASSIGN deleted->* TO <deleted>.
"Actual db changes
DELETE (table_name) FROM TABLE @<deleted>.
IF table_fields->key_fields_only = abap_true.
"^Can't use modify if all fields are key fields. Also in this case it's impossible to have modified entries.
INSERT (table_name) FROM TABLE @<inserted> ACCEPTING DUPLICATE KEYS.
ELSE.
MODIFY (table_name) FROM TABLE @<modified>.
MODIFY (table_name) FROM TABLE @<inserted>.
ENDIF.
"Change doc creation
IF change_doc_type <> space.
create_change_doc( inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
ENDIF.
"Commmit all and check for errors
COMMIT WORK AND WAIT.
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_zabap_table_edit EXPORTING custom_message = |SAP LUW commit returned { sy-subrc }|.
ENDIF.
"---EXTENSION CALL---
extension->after_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
messages->save_ok( ).
prepare_initial_data( ).
reset_grid( ).
in_edit_mode = abap_false.
display( ).
CATCH zcx_zabap_table_edit INTO DATA(zcx).
ROLLBACK WORK.
messages->save_error( zcx->get_text( ) ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
DELETE (table_name) FROM TABLE @<deleted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<modified>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<inserted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,359 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF table_fields->key_fields_only = abap_true.
"^Can't use modify if all fields are key fields. Also in this case it's impossible to have modified entries.
INSERT (table_name) FROM TABLE @<inserted> ACCEPTING DUPLICATE KEYS.
ELSE.
``` | I found vulnerabilities in the line:
```abap
INSERT (table_name) FROM TABLE @<inserted> ACCEPTING DUPLICATE KEYS.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,360 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD commad_change_document.
DATA(selected_row) = get_selected_row_index( ).
DATA batch_input TYPE TABLE OF bdcdata.
APPEND VALUE #( program = 'RSSCD100' dynpro = '1000' dynbegin = 'X' fnam = 'BDC_CURSOR' fval = 'TABNAME' ) TO batch_input.
APPEND VALUE #( fnam = 'OBJEKT' fval = '' ) TO batch_input.
APPEND VALUE #( fnam = 'OBJEKTID' fval = table_name ) TO batch_input.
APPEND VALUE #( fnam = 'TABNAME' fval = table_name ) TO batch_input.
IF selected_row > 0.
"Build and fill tabkey of selected record
FIELD-SYMBOLS <modified_data_ext> TYPE table.
ASSIGN modified_data_ext->* TO <modified_data_ext>.
"Create key struct to cast to cdtabkey - needed to extract just key fields
table_fields->get_keys_structure( EXPORTING include_index_field = abap_false IMPORTING struct = DATA(key_struct) ).
DATA key_line TYPE REF TO data.
CREATE DATA key_line TYPE HANDLE key_struct.
FIELD-SYMBOLS <key_line> TYPE any.
ASSIGN key_line->* TO <key_line>.
<key_line> = CORRESPONDING #( <modified_data_ext>[ selected_row ] ).
DATA tabkey TYPE cdtabkey.
tabkey = <key_line>.
APPEND VALUE #( fnam = 'TABKEY' fval = tabkey ) TO batch_input.
ELSE.
"Clear in case of leftovers from previous call
APPEND VALUE #( fnam = 'TABKEY' fval = '' ) TO batch_input.
ENDIF.
CALL TRANSACTION 'RSSCD100' USING batch_input MODE 'E' UPDATE 'S'.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL TRANSACTION 'RSSCD100' USING batch_input MODE 'E' UPDATE 'S'.
```
Explanation: Add an authority check to CALL TRANSACTION. | 2,361 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_change_doc.
DATA(cd) = NEW zcl_zabap_change_document( objectclass = CONV #( table_name ) objectid = CONV #( table_name ) ).
cd->open( ).
cd->change_multi( EXPORTING force_cd_on_all_fields = COND #( WHEN change_doc_type = 'F' THEN abap_true ELSE abap_false )
table_name = table_name
deleted = cd->create_table_with_indicator( table_name = table_name original_table = deleted indicator = 'D' )
inserted = cd->create_table_with_indicator( table_name = table_name original_table = inserted indicator = 'I' )
before_modified = cd->create_table_with_indicator( table_name = table_name original_table = before_modified indicator = 'U' )
modified = cd->create_table_with_indicator( table_name = table_name original_table = modified ) ).
"Some SAP magic to get initial t-code
DATA: original_tcode TYPE sytcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
cd->close( tcode = original_tcode ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,362 |
Find vulnerabilities in this ABAP code snippet. | ```abap
START-OF-SELECTION.
"Check if it's correct table
SELECT SINGLE tabclass FROM dd02l WHERE tabname = @p_tabnam INTO @DATA(tabclass).
IF tabclass = 'VIEW'.
p_disedi = abap_true.
ELSEIF tabclass <> 'TRANSP'.
MESSAGE s001(zabap_table_edit) DISPLAY LIKE 'E'.
LEAVE LIST-PROCESSING.
ENDIF.
"Get description
DATA original_tcode TYPE tcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
SELECT SINGLE ttext FROM tstct WHERE sprsl = @sy-langu AND tcode = @original_tcode INTO @DATA(description).
"Create extensions
DATA extensions TYPE zcl_zabap_table_edit=>t_config-ext.
IF p_class IS NOT INITIAL.
TRY.
DATA extension_inst TYPE REF TO object.
CREATE OBJECT extension_inst TYPE (p_class).
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_commands.
extensions-commands = CAST #( extension_inst ).
ENDIF.
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_config.
extensions-config = CAST #( extension_inst ).
ENDIF.
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_data.
extensions-data = CAST #( extension_inst ).
ENDIF.
CATCH cx_sy_create_object_error INTO DATA(create_object_error).
MESSAGE create_object_error TYPE 'S' DISPLAY LIKE 'E'.
RETURN.
ENDTRY.
ENDIF.
DATA(table_edit) = NEW zcl_zabap_table_edit( VALUE #( display_text = description table_name = p_tabnam change_doc_type = p_cd
disable_cd_view = p_discdv disable_editing = COND #( WHEN to_upper( p_tabnam(1) ) CA 'YZ' THEN p_disedi ELSE abap_true )
disable_text_table = p_distt ext = extensions disable_selection = p_dissel show_selection_first = p_asksel
documentation = VALUE #( name = p_docnam class = p_doccla ) ) ).
table_edit->display( ).
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,363 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_change_doc.
DATA(cd) = zcl_zabap_table_edit_factory=>get_change_doc( objectclass = CONV #( config-table_name ) objectid = CONV #( config-table_name ) ).
cd->open( ).
cd->change_multi( force_cd_on_all_fields = xsdbool( config-change_doc_type = 'F' )
table_name = config-table_name
deleted = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-deleted indicator = 'D' )
inserted = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-inserted indicator = 'I' )
before_modified = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-before_modified indicator = 'U' )
modified = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-modified ) ).
"Some SAP magic to get initial t-code
DATA: original_tcode TYPE sytcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
cd->close( tcode = original_tcode ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,364 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF execute_default_select = abap_true.
"---SELECTION---
DATA(where) = table-selection->get_where_cond( ).
SELECT * FROM (config-table_name) WHERE (where) ORDER BY PRIMARY KEY INTO TABLE @<initial_data>.
"TODO maintenance view
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (config-table_name) WHERE (where) ORDER BY PRIMARY KEY INTO TABLE @<initial_data>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,365 |
Find vulnerabilities in this ABAP code snippet. | ```abap
IF <initial_data> IS INITIAL.
SELECT * FROM (table_name) INTO TABLE @<initial_data>
ORDER BY PRIMARY KEY.
ENDIF.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (table_name) INTO TABLE @<initial_data>
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,368 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
validate( IMPORTING result = DATA(result) duplicates = DATA(duplicates) inserted = DATA(inserted)
deleted = DATA(deleted) before_modified = DATA(before_modified) modified = DATA(modified) ).
"Abort with message if data is invalid
IF result = c_validation-incorrect_values.
"^Message already displayed by ALV GRID
RETURN.
ELSEIF result = c_validation-duplicates.
messages->show_duplicates( table_name = table_name duplicates = duplicates mandant_col_name = table_fields->mandant_field ).
RETURN.
ENDIF.
IF messages->confirm_save( ) = abap_false.
RETURN.
ENDIF.
"---EXTENSION CALL---
extension->before_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
"Again with unnecessary "FieLDs-sYmBOls"
FIELD-SYMBOLS <modified> TYPE table.
FIELD-SYMBOLS <inserted> TYPE table.
FIELD-SYMBOLS <deleted> TYPE table.
ASSIGN modified->* TO <modified>.
ASSIGN inserted->* TO <inserted>.
ASSIGN deleted->* TO <deleted>.
"Actual db changes
DELETE (table_name) FROM TABLE @<deleted>.
IF table_fields->key_fields_only = abap_true.
"^Can't use modify if all fields are key fields. Also in this case it's impossible to have modified entries.
INSERT (table_name) FROM TABLE @<inserted> ACCEPTING DUPLICATE KEYS.
ELSE.
MODIFY (table_name) FROM TABLE @<modified>.
MODIFY (table_name) FROM TABLE @<inserted>.
ENDIF.
"Change doc creation
IF change_doc_type <> space.
create_change_doc( inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
ENDIF.
"Commmit all and check for errors
COMMIT WORK AND WAIT.
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_zabap_table_edit EXPORTING custom_message = |SAP LUW commit returned { sy-subrc }|.
ENDIF.
"---EXTENSION CALL---
extension->after_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
messages->save_ok( ).
prepare_initial_data( ).
reset_grid( ).
in_edit_mode = abap_false.
display( ).
CATCH zcx_zabap_table_edit INTO DATA(zcx).
ROLLBACK WORK.
messages->save_error( zcx->get_text( ) ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
DELETE (table_name) FROM TABLE @<deleted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<modified>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<inserted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,369 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD get_text_elements_cache.
assign_to_table_fs extended->* <extended>.
"Build where clause
DATA(where) = |{ ttable-field-lang } = @SY-LANGU|.
LOOP AT ttable-key_mapping REFERENCE INTO DATA(key) WHERE NOT text = ttable-field-mandant.
where = |{ where } AND { ttable-name }~{ key->text } = @<extended>-{ key->original }|. "<extended> must be the same as in extended assignment name
ENDLOOP.
"Create text table to store data
DATA text_table TYPE REF TO data.
CREATE DATA text_table TYPE TABLE OF (ttable-name).
assign_to_table_fs text_table->* <text_table>.
SELECT * FROM (ttable-name)
FOR ALL ENTRIES IN @<extended>
WHERE (where)
INTO CORRESPONDING FIELDS OF TABLE @<text_table>.
"Build cache
create_and_assign_data text_key ttable-struct-key <text_key>.
LOOP AT <text_table> ASSIGNING FIELD-SYMBOL(<text_row>).
create_and_assign_data text_non_key ttable-struct-non_key <text_non_key>. "Must be recreated every time, since reference is stored
<text_key> = CORRESPONDING #( <text_row> ).
DATA(text_key_string) = ||.
text_key_string = <text_key>.
<text_non_key> = CORRESPONDING #( <text_row> ).
INSERT VALUE #( k = text_key_string val = text_non_key ) INTO TABLE cache.
ENDLOOP.
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (ttable-name)
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,373 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_change_doc.
DATA(cd) = zcl_zabap_table_edit_factory=>get_change_doc( objectclass = CONV #( config-table_name ) objectid = CONV #( ttable-name ) ).
cd->open( ).
cd->change_multi( force_cd_on_all_fields = xsdbool( config-change_doc_type = 'F' )
table_name = ttable-name
deleted = cd->create_table_with_indicator( table_name = ttable-name original_table = deleted indicator = 'D' )
inserted = cd->create_table_with_indicator( table_name = ttable-name original_table = inserted indicator = 'I' )
before_modified = cd->create_table_with_indicator( table_name = ttable-name original_table = before_modified indicator = 'U' )
modified = cd->create_table_with_indicator( table_name = ttable-name original_table = modified ) ).
"Some SAP magic to get initial t-code
DATA: original_tcode TYPE sytcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
cd->close( tcode = original_tcode ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,374 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD prepare_initial_data.
CREATE DATA initial_data TYPE TABLE OF (table_name).
table_fields->get_table_with_add_fields( EXPORTING additional_fields = additional_fields IMPORTING table = DATA(table) ).
CREATE DATA modified_data_ext TYPE HANDLE table.
FIELD-SYMBOLS <initial_data> TYPE table.
ASSIGN initial_data->* TO <initial_data>.
SELECT * FROM (table_name) INTO TABLE @<initial_data>.
SORT <initial_data> ASCENDING.
"---EXTENSION CALL---
extension->initial_data( CHANGING initial_data = initial_data ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
SELECT * FROM (table_name) INTO TABLE @<initial_data>.
```
Explanation: Potential dangerous statement Dynamic SQL. | 2,375 |
Find vulnerabilities in this ABAP code snippet. | ```abap
TRY.
validate( IMPORTING result = DATA(result) duplicates = DATA(duplicates) inserted = DATA(inserted)
deleted = DATA(deleted) before_modified = DATA(before_modified) modified = DATA(modified) ).
"Abort with message if data is invalid
IF result = c_validation-incorrect_values.
"^Message already displayed by ALV GRID
RETURN.
ELSEIF result = c_validation-duplicates.
messages->show_duplicates( table_name = table_name duplicates = duplicates mandant_col_name = table_fields->mandant_field ).
RETURN.
ENDIF.
IF messages->confirm_save( ) = abap_false.
RETURN.
ENDIF.
"---EXTENSION CALL---
extension->before_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
"Again with unnecessary "FieLDs-sYmBOls"
FIELD-SYMBOLS <modified> TYPE table.
FIELD-SYMBOLS <inserted> TYPE table.
FIELD-SYMBOLS <deleted> TYPE table.
ASSIGN modified->* TO <modified>.
ASSIGN inserted->* TO <inserted>.
ASSIGN deleted->* TO <deleted>.
"Actual db changes
DELETE (table_name) FROM TABLE @<deleted>.
IF table_fields->key_fields_only = abap_true.
"^Can't use modify if all fields are key fields. Also in this case it's impossible to have modified entries.
INSERT (table_name) FROM TABLE @<inserted> ACCEPTING DUPLICATE KEYS.
ELSE.
MODIFY (table_name) FROM TABLE @<modified>.
MODIFY (table_name) FROM TABLE @<inserted>.
ENDIF.
"Change doc creation
IF change_doc_type <> space.
create_change_doc( inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
ENDIF.
"Commmit all and check for errors
COMMIT WORK AND WAIT.
IF sy-subrc <> 0.
RAISE EXCEPTION TYPE zcx_exception EXPORTING custom_message = |SAP LUW commit returned { sy-subrc }|.
ENDIF.
"---EXTENSION CALL---
extension->after_save( CHANGING inserted = inserted deleted = deleted before_modified = before_modified modified = modified ).
messages->save_ok( ).
prepare_initial_data( ).
reset_grid( ).
in_edit_mode = abap_false.
display( ).
CATCH zcx_exception INTO DATA(zcx).
ROLLBACK WORK.
messages->save_error( zcx->get_text( ) ).
ENDTRY.
``` | I found vulnerabilities in the line:
```abap
DELETE (table_name) FROM TABLE @<deleted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<modified>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL.
```abap
MODIFY (table_name) FROM TABLE @<inserted>.
```
Explanation: Modify only own DB tables | Potential dangerous statement Dynamic SQL. | 2,376 |
Find vulnerabilities in this ABAP code snippet. | ```abap
START-OF-SELECTION.
"Check if it's correct table
SELECT SINGLE tabclass FROM dd02l WHERE tabname = @p_tabnam INTO @DATA(tabclass).
IF tabclass <> 'TRANSP'.
MESSAGE s001(zabap_table_edit) DISPLAY LIKE 'E'.
LEAVE LIST-PROCESSING.
ENDIF.
"Get description
DATA original_tcode TYPE tcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
SELECT SINGLE ttext FROM tstct WHERE sprsl = @sy-langu AND tcode = @original_tcode INTO @DATA(description).
"Create extensions
DATA extensions TYPE zcl_zabap_table_edit=>t_config-ext.
IF p_class IS NOT INITIAL.
TRY.
DATA extension_inst TYPE REF TO object.
CREATE OBJECT extension_inst TYPE (p_class).
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_commands.
extensions-commands = CAST #( extension_inst ).
ENDIF.
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_config.
extensions-config = CAST #( extension_inst ).
ENDIF.
IF extension_inst IS INSTANCE OF zif_zabap_table_edit_data.
extensions-data = CAST #( extension_inst ).
ENDIF.
CATCH cx_sy_create_object_error INTO DATA(create_object_error).
MESSAGE create_object_error TYPE 'S' DISPLAY LIKE 'E'.
RETURN.
ENDTRY.
ENDIF.
DATA(table_edit) = NEW zcl_zabap_table_edit( VALUE #( display_text = description table_name = p_tabnam change_doc_type = p_cd
disable_cd_view = p_discdv disable_editing = COND #( WHEN to_upper( p_tabnam(1) ) CA 'YZ' THEN p_disedi ELSE abap_true )
disable_text_table = p_distt ext = extensions ) ).
table_edit->display( ).
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,380 |
Find vulnerabilities in this ABAP code snippet. | ```abap
METHOD create_change_doc.
DATA(cd) = zcl_zabap_table_edit_factory=>get_change_doc( objectclass = CONV #( config-table_name ) objectid = CONV #( config-table_name ) ).
cd->open( ).
cd->change_multi( force_cd_on_all_fields = COND #( WHEN config-change_doc_type = 'F' THEN abap_true ELSE abap_false )
table_name = config-table_name
deleted = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-deleted indicator = 'D' )
inserted = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-inserted indicator = 'I' )
before_modified = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-before_modified indicator = 'U' )
modified = cd->create_table_with_indicator( table_name = config-table_name original_table = compared-modified ) ).
"Some SAP magic to get initial t-code
DATA: original_tcode TYPE sytcode.
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
cd->close( tcode = original_tcode ).
ENDMETHOD.
``` | I found vulnerabilities in the line:
```abap
CALL 'GET_PARAM_TCOD' ID 'PTCOD' FIELD original_tcode.
```
Explanation: Potential dangerous statement KERNEL CALL. | 2,381 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.