patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -903,8 +903,12 @@ export class AmpStoryPage extends AMP.BaseElement {
* @private
*/
isAutoplaySupported_() {
- VideoUtils.resetIsAutoplaySupported();
- return VideoUtils.isAutoplaySupported(this.win, getMode(this.win).lite);
+ // We should not be detecting support each time, since it's slow.
+ ... | [AmpStoryPage->[setState->[NOT_ACTIVE,BOOKEND_STATE,dev,PAUSED,PLAYING],isAutoplaySupported_->[resetIsAutoplaySupported,getMode,isAutoplaySupported],constructor->[resolve,timerFor,getAmpdoc,NOT_ACTIVE,getStoreService,mutatorForDoc,platformFor,promise,getMediaPerformanceMetricsService,debounce,reject],emitProgress_->[di... | Check if autoplay is supported on this device. | @gmajoulet @Enriqe Resetting cache and checking again has the same effect as newly detecting each time, so I'm doing that instead. However, I'm curious about the issue that prompted introducing `resetIsAutoplaySupported` on #23754. There may be an underlying race condition in whatever cached result. |
@@ -41,6 +41,8 @@
internal RoutingComponent Routing { get; }
+ internal RecoverabilityComponent Recoverability { get; }
+
internal ReceiveConfiguration Receiving => receiving ?? throw new InvalidOperationException("Receive component is not enabled since this endpoint is configured to run in... | [FeatureConfigurationContext->[AddSatelliteReceiver->[AddSatelliteReceiver],RegisterStartupTask->[RegisterStartupTask]]] | Creates a new instance of the . Summary for . | Is this used anywhere? |
@@ -117,6 +117,7 @@ type Plan struct {
preview bool // true if this plan is to be previewed rather than applied.
depGraph *graph.DependencyGraph // the dependency graph of the old snapshot
providers *providers.Registry // the p... | [generateURN->[Target],Execute->[Execute],generateEventURN->[generateURN],GetProvider->[GetProvider]] | Events is an interface that can be used to hook interesting engine and plans. | surprised this isn't avialable off of the Plan (or some other engine object already). @pgavlin ? |
@@ -194,3 +194,7 @@ class User(AbstractUser):
def allows_editing_by(self, user):
return user.is_staff or user.is_superuser or user.pk == self.pk
+
+ def has_akismet_submission_permission(self):
+ return (self.groups.filter(permissions__codename=u'add_revisionakismetsubmission').exists() or
+ ... | [UserBan->[__unicode__->[_],ForeignKey,DateField,TextField,BooleanField],User->[is_beta_tester->[values_list],has_legacy_username->[search],wiki_revisions->[prefetch_related],active_ban->[filter],CharField,_,URLField,RegexValidator,NamespacedTaggableManager,TextField]] | Returns True if the given user is a staff or superuser. | Please use this instead: `self.has_perm('wiki.add_revisionakismetsubmission)`, which does the equivalent and more. Or, this method can go away if the `@permission_required` decorator is used on the view. |
@@ -123,7 +123,9 @@ public class MRJobLauncher extends AbstractJobLauncher {
}
public MRJobLauncher(Properties jobProps, Configuration conf) throws Exception {
- super(jobProps, ImmutableMap.<String, String> of());
+ super(jobProps, FileSystem
+ .get(URI.create(jobProps.getProperty(Configuratio... | [MRJobLauncher->[TaskRunner->[run->[runWorkUnits,setup]],close->[close],prepareJobInput->[close],collectOutputTaskStates->[close]]] | Creates a new instance of the MR job. This method creates the job directory if it does not already exist. | Can you move the creation of the `FileSystem` into its own method (something like `buildFileSystem`), so that the `super` declaration isn't so long. |
@@ -35,6 +35,7 @@ def train(model, quantizer, device, train_loader, optimizer):
loss = F.nll_loss(output, target)
loss.backward()
optimizer.step()
+ quantizer.update_step()
if batch_idx % 100 == 0:
print('{:2.0f}% Loss {}'.format(100 * batch_idx / len(train_loade... | [train->[train,step,to,nll_loss,print,backward,len,format,item,enumerate,model,zero_grad],main->[manual_seed,train,Normalize,Compose,Mnist,parameters,device,print,SGD,QAT_Quantizer,format,compress,ToTensor,test,range,DataLoader,MNIST],Mnist->[forward->[conv1,relu3,relu1,fc2,fc1,relu2,log_softmax,max_pool2d,conv2,view],... | Train a model on the given device. | i think it is a little strange to call both `optimizer.step()` and `quantizer.update_step()`. If `update_step()` is called every time `optimizer.step()` is called, then i think the api `update_step()` can be deleted. |
@@ -1107,6 +1107,15 @@ resource "aws_cloudwatch_event_target" "test" {
input_transformer {
input_paths = {
time = "$.time"
+ severity : "$.detail.severity",
+ Finding_ID : "$.detail.id",
+ instanceId : "$.detail.resource.instanceDetails.instanceId",
+ port : "$.detail.service.action.n... | [ParallelTest,Printf,ListRules,StringValue,TestCheckResourceAttrPair,Meta,RandomWithPrefix,Sprintf,TestCheckResourceAttr,RootModule,ComposeTestCheckFunc,Errorf,RemoveTargets,Int64,ListTargetsByRule,RandString,AddTestSweepers,Bool] | requires the schedule to be defined. | It would be good here to have one test that passes, plus a test that has more than 10 paths to demonstrate that it fails, using `ExpectError` in the test step |
@@ -5,7 +5,7 @@ echo 'RFC1628 ';
$load_data = snmpwalk_group($device, 'upsOutputPercentLoad', 'UPS-MIB');
foreach ($load_data as $index => $data) {
- $load_oid = ".1.3.6.1.2.1.33.1.4.4.1.5.$index";
+ $load_oid = ".1.3.6.1.2.1.33.1.4.4.1.5.".$index.".0";
$divisor = get_device_divisor($device, $pre_cache['... | [No CFG could be retrieved] | Get the percentage load of all UPS - MIB sensors. | We've not had any complaints about these and I feel this might break things (doesn't look like we have any test data, I do though and none of it shows with a .0) |
@@ -45,6 +45,8 @@ import org.apache.hadoop.fs.PathFilter;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
+import org.apache.commons.io.FilenameUtils;
+
import java.io.File;
import java.io.IOException;
import java.io.Serializable;
| [HoodieTableMetaClient->[initializeBootstrapDirsIfNotExists->[getHadoopConf,initializeBootstrapDirsIfNotExists,getFs],equals->[equals],getFs->[getFs],getMarkerFolderPath->[getTempFolderPath],getArchivePath->[getMetaPath],initTableType->[initTableType],getCommitTimeline->[getTableType,getCommitTimeline],reload->[HoodieT... | Imports a single Hoodie table. Create a HoodieTableMetaClient that can be used to get the meta - data. | `java.io.File` is not needed anymore, remove it |
@@ -101,10 +101,17 @@ void AddCustomUtilitiesToPython()
class_<GeometryUtilities, bases<Process> >("GeometryUtilities", init<ModelPart&>())
.def("ComputeUnitSurfaceNormals", &GeometryUtilities::ComputeUnitSurfaceNormals)
.def("ProjectNodalVariableOnUnitSurfaceNormals", &GeometryUtilities::Projec... | [AddCustomUtilitiesToPython->[>]] | AddCustomUtilitiesToPython - add custom utilities to the object. ----------------------------------------------------------- // General utility methods for all objects of type NestedSequence. Missing file io. | Naming: UpdateMeshAccording**To**InputVariable ? |
@@ -755,6 +755,7 @@ const (
defaultSchedulerMaxWaitingOperator = 5
defaultLeaderSchedulePolicy = "count"
defaultStoreLimitMode = "manual"
+ defaultEnableJointConsensus = true
)
func (c *ScheduleConfig) adjust(meta *configMetaData) error {
| [MigrateDeprecatedFlags->[migrateConfigurationMap],Parse->[Parse],RewriteFile->[GetConfigFile],IsDefined->[IsDefined],Adjust->[CheckUndecoded,Parse,IsDefined,Validate,Child],parseDeprecatedFlag->[IsDefined],adjustLog->[IsDefined],adjust->[Child,Validate,adjust,IsDefined],Parse] | adjust is used to set the default values for the schedule config This function is called by the configuration manager to set the default values for all configuration options. | will we start it by default? |
@@ -46,7 +46,7 @@ module Stories
Articles::Feeds::Basic.new(user: nil, page: @page, tag: params[:tag]).feed
else
Articles::Feeds::LargeForemExperimental.new(user: current_user, page: @page, tag: params[:tag])
- .default_home_feed(user_signed_in: user_signed_in?)
+ .default_hom... | [FeedsController->[latest_feed->[latest_feed,new],signed_in_base_feed->[feed_strategy,feed],timeframe_feed->[top_articles_by_timeframe,new],optimized_signed_in_feed->[more_comments_minimal_weight_randomized_at_end,new],assign_feed_stories->[user_signed_in?,decorate_collection,in?],add_pinned_article->[decorate,nil?,pre... | This method returns the base feed object for the current signed - out user. | Given that this is the `signed_out_base_feed` method and we already performed the `user_signed_in?` check-in `assign_feed_stories` to even get to this point we can hard-code the value to `false`. |
@@ -15,6 +15,14 @@
#if defined(OPENSSL_THREADS) && !defined(CRYPTO_TDEBUG) && defined(OPENSSL_SYS_WINDOWS)
+# ifdef OPENSSL_USE_APPLINK
+int CRYPTO_THREAD_register_stop_function(DWORD key, void (*cleanup)(void *));
+void CRYPTO_THREAD_unregister_stop_function(DWORD key);
+# else
+#define CRYPTO_THREAD_register_sto... | [CRYPTO_THREAD_get_local->[SetLastError,GetLastError,TlsGetValue],CRYPTO_THREAD_cleanup_local->[TlsFree],CRYPTO_THREAD_unlock->[LeaveCriticalSection],CRYPTO_THREAD_get_current_id->[GetCurrentThreadId],CRYPTO_atomic_add->[InterlockedExchangeAdd],CRYPTO_THREAD_write_lock->[EnterCriticalSection],CRYPTO_atomic_read->[Inter... | This method returns a CRYPTO_RWLOCK object if it can be obtained from a previous. | This is not reliable way to determine that target is DLL. There are targets that don't engage it [in shared build], mingw64 and ARM. Applink per se is something one wants to get rid of. It was introduced as assistant for legacy applications, and one really shouldn't encourage its usage. One might also recognize the pos... |
@@ -147,6 +147,7 @@ public class V20161125161400_AlertReceiversMigrationTest {
alarmCallbackId,
matchingStreamId,
EmailAlarmCallback.class.getCanonicalName(),
+ "Email Alert Callback",
new HashMap<>(),
new Date(),
... | [V20161125161400_AlertReceiversMigrationTest->[verifyMigrationCompletedWasPosted->[verifyMigrationCompletedWasPosted]]] | Migrate single qualifying stream. Checks if all the fields of the stream are equal. | Also "Notification" ? |
@@ -105,14 +105,12 @@ public class DruidProcessingModule implements Module
@Provides
@LazySingleton
@Global
- public NonBlockingPool<ByteBuffer> getIntermediateResultsPool(DruidProcessingConfig config)
+ public BlockingPool<ByteBuffer> getIntermediateResultsPool(DruidProcessingConfig config)
{
verify... | [DruidProcessingModule->[getIntermediateResultsPool->[OffheapBufferGenerator,verifyDirectMemory,intermediateComputeSizeBytes,getNumThreads,poolCacheMaxCount],getBackgroundExecutorService->[build,newFixedThreadPool,getNumBackgroundThreads,sameThreadExecutor],verifyDirectMemory->[getMessage,intermediateComputeSizeBytes,g... | Returns a pool of intermediate buffer objects. | does this mean `poolCacheMaxCount` needs to be removed from docs? |
@@ -2942,9 +2942,13 @@ class TestLimitedReviewerQueue(QueueTest, LimitedReviewerBase):
def setUp(self):
super(TestLimitedReviewerQueue, self).setUp()
- self.expected_names = ['Nominated old']
self.url = reverse('editors.queue_nominated')
+ for addon in self.generate_files().valu... | [QueueTest->[_test_queue_count->[generate_files],generate_file->[generate_files],_test_get_queue->[get_queue,generate_files],setUp->[login_as_editor,login_as_senior_editor]],TestQueueSearchVersionSpecific->[test_age_of_submission->[search,named_addons,update_beiber]],TestWhiteboard->[test_whiteboard_addition->[get_addo... | Set up the object. | just FYI, this will give you a randomly ordered list. For this test it's ok but most of time you should rely on a predictably ordered list to guarantee that the test will pass all the time. |
@@ -1788,8 +1788,10 @@ def _AddNShape(op):
def _SelectShape(op):
"""Shape function for SelectOp."""
# The inputs 'then' and 'else' must have the same shape.
- # The input 'cond' must either have the same shape as 'then' and
- # 'else', or be a vector if 'then' and 'else' are at least vectors.
+ # The input 'c... | [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],_ReductionDims->[range],reduce_all->[_ReductionDims],truediv->[cast],to_int64->[cast],_as_indexed_slices_list->[_as_indexed_slices,cast],cast->[cast],saturate_cast->[cast],reduced_shape->[range,to_int32],reduce_min->[_ReductionDims],square->[s... | Shape function for SelectOp. | You also have to update the C++ shape function in the array_ops.cc definition of the Select op |
@@ -39,10 +39,18 @@ import {
escapeCssSelectorIdent,
} from '../../../src/dom';
import {clamp} from '../../../src/utils/math';
+import {
+ concat as concatTransition,
+ numeric,
+ scale,
+ setStyles as setStylesTransition,
+ translate,
+} from '../../../src/transition';
import {dev, user} from '../../../src/... | [No CFG could be retrieved] | A mix of AMP - specific key - handlers and classes. region Header Functions. | I'm going to give a vote for using the default import in this case. When both `transition` and `styles` functions are imported, I think I find it easier to keep track of these methods when they're namespaced like `tr.setStyles(blah)` and `st.setStyles(blah)` but do what you think is most ergonomic. |
@@ -48,8 +48,11 @@ import io.micrometer.core.instrument.MeterRegistry;
*
* @since 5.0.2
*
+ * @deprecated - micrometer metrics are now in-built.
+ *
* @see org.springframework.integration.support.management.IntegrationManagementConfigurer
*/
+@Deprecated
public class MicrometerMetricsFactory implements Metri... | [MicrometerMetricsFactory->[setTimerTagProvider->[notNull],setCounterTagProvider->[notNull],setReceiveCounterNameProvider->[notNull],setReceiveCounterTagProvider->[notNull],createChannelMetrics->[DefaultMessageChannelMetrics,counter,timer,apply],setTimerNameProvider->[notNull],setErrorCounterNameProvider->[notNull],set... | Provides a factory to create Micrometer metrics. errorCounterTagPro - errorCounterTagPro. | Ooh! This is really big change in the current point release. We even said in blog post that it can be enabled, by it's not by default - the next `5.1`. Also there is some doc already and you didn't fix it for this deprecation. |
@@ -317,8 +317,8 @@ namespace System.ComponentModel.Design
}
break;
case WindowMessages.WM_REFLECT + WindowMessages.WM_NOTIFY:
- ComCtl32.NMTREEVIEW nmtv = Marshal.PtrToStructure<ComCtl32.NMTREEVIEW>(m.LParam);
- ... | [ObjectSelectorEditor->[Selector->[OnAfterSelect->[ChooseSelectedNodeIfEqual],Clear->[Clear],SetSelection->[SetSelection],OnKeyDown->[ChooseSelectedNodeIfEqual,OnKeyDown,SetValue],Start->[SetSelection],OnKeyPress->[OnKeyPress],ChooseSelectedNodeIfEqual->[SetValue,EqualsToValue],OnNodeMouseClick->[ChooseSelectedNodeIfEq... | Override WndProc to handle the missing message. | we're not using anything from `NMTREEVIEW` here, so we can just use `NMHDR` |
@@ -167,7 +167,7 @@ internal static partial class Interop
int gLength,
byte[] y,
int yLength,
- byte[] x,
+ byte[]? x,
int xLength);
}
}
| [Interop->[Crypto->[DsaSignatureFieldSize->[DsaSizeQ,DsaEncodedSignatureSize],DsaSign->[DsaSign],DsaEncodedSignatureSize->[DsaSizeSignature],DsaVerify->[DsaVerify],DsaKeySize->[DsaSizeP]]]] | DsaKeyCreateByExplicitParameters - DsaKeyCreateByExplicitParameters is a non. | Why is x the only one that's nullable? Is it fundamentally different in that regard from p, q, g, and y? |
@@ -608,9 +608,10 @@ class Procedures(object):
model_part.AddNodalSolutionStepVariable(EULER_ANGLES)
# CONTROL MODULE
- model_part.AddNodalSolutionStepVariable(TARGET_STRESS)
- model_part.AddNodalSolutionStepVariable(REACTION_STRESS)
- model_part.AddNodalSolutionStepVariable... | [MaterialTest->[MeasureForcesAndPressure->[MeasureForcesAndPressure],Initialize->[MaterialTest,Initialize],PrintChart->[PrintChart],FinalizeGraphs->[FinalizeGraphs],PrintGraph->[PrintGraph],GenerateGraphics->[GenerateGraphics],PrepareDataForGraph->[PrepareDataForGraph]],KratosPrintInfo->[Flush],KratosPrint->[Flush],Kra... | Adds all variables that are required for the cluster. This method is called by the DualMPI model when it is not needed. | I agree that control module variables should only be added when somebody uses the control module, but we need to think of a cleaner way to do it. With that if statement, the usage of control module depends on whether you print the control module variables or not, which is not the most appropriate (you could perfectly b... |
@@ -413,6 +413,10 @@ public class GobblinMultiTaskAttempt {
}
if (task == null) {
+ if (e instanceof RetryException) {
+ // Indicating task being null due to failure in creation even after retrying.
+ failureInTaskCreation = false;
+ }
// task could... | [GobblinMultiTaskAttempt->[commit->[apply->[call->[commit]]],runAndOptionallyCommitTaskAttempt->[commit,run,isSpeculativeExecutionSafe],runWorkUnits->[runAndOptionallyCommitTaskAttempt,GobblinMultiTaskAttempt,taskSuccessfulInPriorAttempt],createTaskWithRetry->[call->[createTaskRunnable],call],isSpeculativeExecutionSafe... | Runs the work units in the order they were added. if the task is not submitted and there is no task in the queue then it will be. | failureInTaskCreation -> isTaskCreatedSuccessfully? |
@@ -136,6 +136,8 @@ def train_model_from_file(parameter_filename: str,
If ``True``, we will try to recover a training run from an existing serialization
directory. This is only intended for use when something actually crashed during the middle
of a run. For continuing training a model on ne... | [train_model->[datasets_from_params,create_serialization_dir]] | This function is a wrapper around the train_model function that loads the params from a file. | Minor nit: maybe `If ``True``, we will overwrite the serialization directory if it already exists.` |
@@ -78,3 +78,18 @@ func WithTTL(ttl time.Duration) WriterOption {
w.ttl = ttl
}
}
+
+// StorageOptions returns the fileset storage options for the config.
+func StorageOptions(conf *serviceenv.Configuration) []StorageOption {
+ var opts []StorageOption
+ if conf.StorageMemoryThreshold > 0 {
+ opts = append(opts,... | [NewWeighted] | w. ttl = ttl. | Moved from `serviceenv` to avoid a circular reference. |
@@ -3,5 +3,15 @@ FactoryGirl.define do
sequence(:rubric_criterion_name) { |n| "Rubric criterion #{n}" }
association :assignment, factory: :rubric_assignment
weight 1.0
+ level_0_name 'Poor'
+ level_0_description 'This criterion was not satisifed whatsoever.'
+ level_1_name 'Satisfactory'
+ le... | [factory,association,weight,sequence,define] | Sequence of rubric criterion names. | Final newline missing. |
@@ -1,13 +1,12 @@
<?php
// .1.3.6.1.2.1.33.1.1.2.0 = STRING: "TRIPP LITE PDUMH20HVATNET"
+// .1.3.6.1.2.1.33.1.1.2.0 = STRING: "SU1500XL"
// .1.3.6.1.2.1.33.1.1.4.0 = STRING: "12.04.0052"
// .1.3.6.1.2.1.33.1.1.5.0 = STRING: "sysname.company.com"
// .1.3.6.1.4.1.850.100.1.1.4.0 = STRING: "9942AY0AC796000912"
//... | [No CFG could be retrieved] | This function returns the diagnostic information for the USPP - 2 agent. | change the preg_split to an str_replace or a preg_match()... |
@@ -48,13 +48,14 @@ func fetchDeviceName(major, minor uint64) (bool, string, error) {
if !ok {
return nil
}
- devID := infoT.Rdev
+ devID = uint64(infoT.Rdev)
+
// do some bitmapping to extract the major and minor device values
// The odd duplicated logic here is to deal with 32 and 64 bit values.
... | [Sys,Info,IsDir,Name,WalkDir,Wrap,Type] | finds the next device in the system which can be negative. | I'm not sure these explicit casts to `uint64()` are necessary here? |
@@ -22,12 +22,8 @@ type QueueSettings struct {
BatchLength int
ConnectionString string
Type string
- Network string
- Addresses string
- Password string
QueueName string
SetName string
- DBIndex int
WrapIfNecessary bool
MaxAttempts in... | [MustBool,MustInt,Fields,Atoi,SplitN,Key,IsAbs,Join,Section,Name,ToSlash,ToLower,MustString,MustDuration,Sprintf,Keys,String,Fatal,NewKey] | GetQueueSettings returns the QueueSettings for a given queue name. missing fields in queue. | do we have reverences in example.ini or ohter docs left? |
@@ -1810,7 +1810,7 @@ func SimulateIncomingHeads(t *testing.T, args SimulateIncomingHeadsArgs) (cleanu
defer cancel()
chTimeout := time.After(args.Timeout)
- chDone := make(chan struct{})
+ chDone = make(chan struct{})
go func() {
current := int64(args.StartBlock)
for {
| [NewBox->[NewBox],StartAndConnect->[Start],Get->[Get],Delete->[Delete],NewClientAndRenderer->[MustSeedNewSession],NewHTTPClient->[MustSeedNewSession],Start->[Start],Post->[Post],Patch->[Patch],Put->[Put],Get,FailNow,NewHTTPClient,Post,Patch] | This function is a helper function that builds the full chain of heads from the given arguments. OnNewLongestChain returns a function that can be used to connect a new chain to. | Why pass it in as an argument if it's reassigned? (The external chDone will refer to a different channel) |
@@ -125,6 +125,12 @@ func PreviewThenPrompt(ctx context.Context, kind apitype.UpdateKind, stack Stack
return changes, nil
}
+ if !changes.HasChanges() {
+ close(eventsChannel)
+
+ os.Exit(0)
+ }
+
// Otherwise, ensure the user wants to proceed.
err := confirmBeforeUpdating(kind, stack, events, op.Opts)
c... | [Wrapf,Colorize,Sprintf,ResourceChanges,IgnoreError,TrimSpace,String,Errorf,Assert,AskOne,WriteString,RenderDiffEvent] | confirmBeforeUpdating is the main function that performs the update of the cloud - link. Create a prompt to ask the user to perform a specific action on a resource. | i'm not sure i like the idea of our code just calling Exit as it's going along. Can we not just return gracefully and have hte app exit naturally? |
@@ -38,6 +38,7 @@
#include <openssl/cmperr.h>
#include <openssl/cterr.h>
#include <openssl/asyncerr.h>
+#include <openssl/kdferr.h>
#include <openssl/storeerr.h>
#include <openssl/esserr.h>
#include "internal/propertyerr.h"
| [No CFG could be retrieved] | This function is a utility method that can be used to provide a list of possible errors in This function is called to include all error strings from the library. | Why this include? |
@@ -114,6 +114,16 @@ export function installServiceInEmbedScope(embedWin, id, service) {
);
registerServiceInternal(embedWin, embedWin, id, () => service);
getServiceInternal(embedWin, id); // Force service to build.
+ const ampdocFieExperimentOn = isExperimentOn(topWin, 'ampdoc-fie');
+ if (ampdocFieExperim... | [No CFG could be retrieved] | Registers a service in the top - level window. Register a builder for a given node or doc. | Should we put the above code in an `else` block? |
@@ -365,12 +365,12 @@ func (c *Controller) finalizeShootDeletion(ctx context.Context, gardenClient kub
return reconcile.Result{}, c.removeFinalizerFrom(ctx, gardenClient, shoot)
}
-func (c *Controller) isSeedAvailable(seed *gardencorev1beta1.Seed) error {
+func (c *Controller) isSeedReadyForMigration(seed *gardenc... | [checkSeedAndSyncClusterResource->[syncClusterResourceToSeed],finalizeShootDeletion->[deleteClusterResourceFromSeed],durationUntilNextShootSync->[respectSyncPeriodOverwrite,reconcileInMaintenanceOnly],deleteShoot->[checkSeedAndSyncClusterResource,syncClusterResourceToSeed,respectSyncPeriodOverwrite,initializeOperation]... | finalizeShootDeletion deletes the cluster resource from the seed and then reconciles the shoot Check if a Shoot can be reconciled failedOrIgnored checks if the Shoot is failed or ignored. If it is it will check if the seed is up - to - date then sync the Cluster resource with the cluster Check if the shoot cluster stat... | Can you rename the `isSeedAvailable` function to `isSeedReadyForMigration` or something similar? It wasn't clear from the name and I had to check where this thing is actually called. |
@@ -100,6 +100,7 @@ define([
* @param {Clock} [options.clock=new Clock()] The clock to use to control current time.
* @param {ImageryProvider} [options.imageryProvider=new BingMapsImageryProvider()] The imagery provider to serve as the base layer. If set to false, no imagery provider will be added.
* ... | [No CFG could be retrieved] | A widget containing a Cesium scene. Creates a Cesium widget with a Cesium imagery provider and Cesium. | This should be `[options.skyBoxSources]` you don't need the explicit undefined. |
@@ -36,7 +36,7 @@ from spack.util.environment import *
import spack.util.spack_json as sjson
-class Python(Package):
+class Python(AutotoolsPackage):
"""The Python programming language."""
homepage = "http://www.python.org"
| [Python->[setup_dependent_package->[_load_distutil_vars],deactivate->[write_easy_install_pth,python_ignore],activate->[write_easy_install_pth,python_ignore]]] | Creates a new object with the given version. Returns a list of all sequence numbers that are compatible with the IANA standard. | Can you remove this change? The package isn't setup to use `AutotoolsPackage`. |
@@ -1403,9 +1403,9 @@ public class MustFightBattle extends DependentBattle implements BattleStepString
private void queryRetreat(final boolean defender, final RetreatType retreatType, final IDelegateBridge bridge,
Collection<Territory> availableTerritories) {
- boolean subs;
- boolean planes;
- boo... | [MustFightBattle->[transporting->[transporting],showCasualties->[isEmpty],attackerRetreatSubs->[getAttackerRetreatTerritories,canAttackerRetreatSubs],defenderRetreatSubs->[canDefenderRetreatSubs],attackAirOnNonSubs->[fire],getBattleExecutables->[execute->[determineStepStrings,shouldEndBattleDueToMaxRounds,updateDefendi... | Query the retreat. region Submerge Submerge SubDeferment SubDeferment SubDeferment Sub if attacker retreat non subs then it s over. This method is called when a player retains a battery. It will remove amph. | Those lines should probably be merged with the declaration |
@@ -39,7 +39,7 @@ func NewPermanentUnboxingError(inner error) UnboxingError {
type PermanentUnboxingError struct{ inner error }
func (e PermanentUnboxingError) Error() string {
- return fmt.Sprintf("error unboxing chat message: %s", e.inner.Error())
+ return e.inner.Error()
}
func (e PermanentUnboxingError) IsP... | [VersionNumber->[VersionNumber],IsCritical->[IsCritical],Error->[Error],InternalError->[Inner,Error,InternalError],ExportType->[ExportType],VersionKind->[VersionKind],Inner] | Error returns the error message of the error. | don't think this should make it's way up to the user |
@@ -2619,10 +2619,12 @@ bool Blockchain::get_transactions(const t_ids_container& txs_ids, t_tx_container
try
{
cryptonote::blobdata tx;
- if (m_db->get_tx_blob(tx_hash, tx))
+ bool res = pruned ? m_db->get_pruned_tx_blob(tx_hash, tx) : m_db->get_tx_blob(tx_hash, tx);
+ if (res)
{
... | [No CFG could be retrieved] | Check if a block has a header that is not already in the database. This function returns the most recent common block hash along with up to up to up to BLOCK. | Minor, but in my code I'd probably use a separate result boolean for a different call, so that I can declare each of them as const values and can check their statuses independently at the same time via either logging or a debugger. |
@@ -14,11 +14,14 @@
* @param array $args An array of arguments to pass through vsprintf().
* @param string $language Optionally, the standard language code
* (defaults to site/user default, then English)
+ * @param bool $quiet If set to true, no notices will be logged... | [reload_all_translations->[getVariable]] | Echo a message with a given language. | This should be "false may be returned" |
@@ -0,0 +1,17 @@
+class Reauthn
+ def initialize(params)
+ @params = params
+ end
+
+ def call
+ reauthn.present? && reauthn == 'true'
+ end
+
+ private
+
+ attr_reader :params
+
+ def reauthn
+ params[:reauthn]
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Small nit: why also check for `present?`? Checking against the literal `'true'` should be enough, otherwise it'll be `nil` and `nil != 'true'` |
@@ -204,7 +204,7 @@ class Settings {
}
// If we set the disabled option to true, clear the queues.
- if ( ( 'disable' === $setting || 'network_disable' === $setting ) && ! ! $value ) {
+ if ( ( 'disable' === $setting || 'network_disable' === $setting ) && (bool) $value ) {
$listener = Listener::get_i... | [Settings->[update_settings->[reset]]] | Updates the current network settings. | We could drop the `(bool)` entirely, PHP implicitly casts to bool in this situation anyway. |
@@ -83,7 +83,7 @@ class NettyProcessor {
//.addNativeImageSystemProperty("io.netty.noUnsafe", "true")
// Use small chunks to avoid a lot of wasted space. Default is 16mb * arenas (derived from core count)
// Since buffers are cached to threads, the malloc overhead is t... | [NettyProcessor->[registerQualifiers->[build],build->[build]]] | Build a NativeImageConfigItem. This method is called by the code that is responsible for registering the necessary classes in the system This method is called to register all Netty native epoll and kqueue classes. | If it's just about gRPC, shouldn't we have a build item that allows to increment that and we would collect them and add what's needed here? Because AFAICS we reduced it to avoid some wasted space? |
@@ -206,9 +206,9 @@ namespace System.IO.Tests
buffer.GetSpan().Clear();
await RandomAccess.ReadAsync(handle, new Memory<byte>[] { firstHalf, secondHalf }, 0);
- }
- Assert.Equal(content, await File.ReadAllBytesAsync(filePath));
+ Assert.True(buf... | [RandomAccess_NoBuffering->[Task->[Memory,SystemPageSize,ReadAllBytes,Slice,Asynchronous,Min,ReadAsync,GetSpan,ReadAllBytesAsync,SequenceEqual,CreateNew,GetBytes,GetTestFilePath,Equal,nameof,WriteAllBytes,None,Allocate,OpenHandle,GetFileOptions,Read,WriteAsync,Write,ReadWrite,Clear,CopyTo,Open,Length,True],FileOptions-... | Reads and writes segments that are exactly one page long and not yet bufferable. | Does ReadAsync guarantee it'll return all the data in this case? Can we validate the returned value? |
@@ -586,6 +586,10 @@ void ContentFeatures::deSerialize(std::istream &is)
try {
node_dig_prediction = deSerializeString(is);
+ u8 tmp_leveled_max = readU8(is);
+ if (is.eof()) /* readU8 doesn't throw exceptions so we have to do this */
+ throw SerializationError("");
+ leveled_max = tmp_leveled_max;
} catc... | [No CFG could be retrieved] | Reads all of the data from the specified input stream. Get the texture and shader flags texture for a given node. | What if `readU8` reads the last byte? Shouldn't this be checked before reading the byte? |
@@ -118,6 +118,10 @@ public abstract class KafkaJobStatusMonitor extends HighLevelConsumer<byte[], by
private final Retryer<Void> persistJobStatusRetryer;
+ private final ScheduledExecutorService scheduler;
+
+ private final ArrayList<ScheduledFuture> futuresList;
+
public KafkaJobStatusMonitor(String topic... | [KafkaJobStatusMonitor->[startUp->[startUp],jobStatusTableName->[jobStatusTableName],shutDown->[shutDown],createMetrics->[createMetrics]]] | Creates a KafkaJobStatusMonitor. Parse the configuration map for the retry time out. | with these (and a few other names), I recommend naming semantically, rather than merely after the abstraction; e.g. `metricRemovalScheduler`, `pendingRemovalFutures`, etc. choice is yours... I find that better conveys context--even anticipating disambiguation, if/when we again use the same tool (i.e. class) to unrelate... |
@@ -33,6 +33,14 @@ public class KafkaWriterConfigurationKeys {
static final String FAILURE_ALLOWANCE_PCT_CONFIG = "writer.kafka.failureAllowancePercentage";
static final double FAILURE_ALLOWANCE_PCT_DEFAULT = 20.0;
+ public static final String WRITER_KAFKA_KEYED_CONFIG = "writer.kafka.keyed";
+ public static ... | [No CFG could be retrieved] | Configuration keys for a KafkaWriter. This is a static property that can be used to define the default values for the configuration of. | Can use `getName()` in case this pattern gets copied and attached to a nested class since `getCanonicalName()` returns a name that does not work for instantiating nested classes. |
@@ -102,6 +102,9 @@ final class DocumentationNormalizer implements NormalizerInterface, CacheableSup
private $identifiersExtractor;
+ private $openApiBackwardCompatibility;
+ private $openApiNormalizer;
+
/**
* @param SchemaFactoryInterface|ResourceClassResolverInterface|null $jsonSchemaFactor... | [DocumentationNormalizer->[addRequestBody->[addSchemas],updatePutOperation->[addSchemas],addSubresourceOperation->[addSchemas,addPaginationParameters],updateGetOperation->[addSchemas],getPathOperation->[getPath],updatePostOperation->[addSchemas]]] | Creates an instance of the class. | Can't we just change the wiring in the extension instead of injecting `backward_compatibility` here? |
@@ -405,6 +405,16 @@ func (c *Container) Signal(ctx context.Context, num int64) error {
return c.startGuestProgram(ctx, "kill", fmt.Sprintf("%d", num))
}
+func (c *Container) ReloadConfig(ctx context.Context) error {
+ defer trace.End(trace.Begin(c.ExecConfig.ID))
+
+ if c.vm == nil {
+ return fmt.Errorf("vm not ... | [RefreshFromHandle->[String],OnEvent->[onStop,refresh,Remove,String,updateState],refresh->[refresh],stop->[transitionState,stop,SetState],start->[start,SetState,transitionState],Error->[Error],Remove->[Remove,updateState],String] | Signal sends a signal to the container. | should be in `base.go` as we may need to invoke it during commit |
@@ -618,14 +618,6 @@ public class RemoteFileTemplate<F> implements RemoteFileOperations<F>, Initializ
this.name = name;
}
- public InputStream getStream() {
- return this.stream;
- }
-
- public String getName() {
- return this.name;
- }
-
}
}
| [RemoteFileTemplate->[afterPropertiesSet->[setBeanFactory],sendFileToRemoteDirectory->[exists,append,rename],invoke->[getSession,get,remove],append->[append],exists->[exists],getSession->[getSession,get],remove->[remove],get->[get],execute->[getSession,get],payloadToInputStream->[exists],list->[list],send->[send],renam... | Gets the stream of the object. | `StreamHolder` ctor must be protected to avoid synthetic ctor. |
@@ -87,13 +87,13 @@ drpc_listener_run(void *arg)
while (is_listener_running()) {
int rc;
- /* instant timeout - don't hog the xstream */
+ /* instant timeout */
rc = drpc_progress(ctx, 0);
if (rc != DER_SUCCESS && rc != -DER_TIMEDOUT) {
D_ERROR("dRPC listener progress error: %d\n", rc);
}
- dss... | [bool->[ABT_mutex_lock,ABT_mutex_unlock],int->[setup_listener_ctx,dss_ult_create,drpc_close,drpc_progress_context_create,unlink,asprintf,drpc_listen,ABT_thread_join,dss_abterr2der,drpc_progress_context_close,set_listener_running,D_ERROR],drpc_listener_fini->[ABT_thread_free,D_FREE,ABT_mutex_free,dss_abterr2der,D_ERROR,... | run the dRPC listener. | The zero timeout and the yield call defeat the purpose of a dedicated thread, don't they? We would like the listener to block indefinitely (or a couple seconds, if needed) in the poll call, while binding it to the same CPU as the system xstream. |
@@ -0,0 +1,15 @@
+(function() {
+ 'use strict';
+
+ angular
+ .module('<%=angularAppName%>')
+ .config(alertServiceConfig);
+
+ alertServiceConfig.$inject = ['AlertServiceProvider'];
+
+
+ function alertServiceConfig(AlertServiceProvider) {
+ // set below to true to make alerts look lik... | [No CFG could be retrieved] | No Summary Found. | Remove extra line break. |
@@ -119,6 +119,13 @@ export default Mixin.create(UppyS3Multipart, {
this._reset();
return false;
}
+
+ // for a single file, we want to override file meta with the
+ // data property (which may be computed), to override any keys
+ // specified by this.data (such as na... | [No CFG could be retrieved] | The actual file type meta Upload the file if it is using S3Uploads. | Now I'm wondering: is `Object.keys(this.data).length` necessary? Imo even `this.data` part isn't strictly required (`deepMerge()` does `value || {}`) |
@@ -31,10 +31,11 @@ const DOCKER_ELASTICSEARCH = 'elasticsearch:2.4.1';
const DOCKER_KAFKA = 'wurstmeister/kafka:0.10.1.1';
const DOCKER_ZOOKEEPER = 'wurstmeister/zookeeper:3.4.6';
const DOCKER_SONAR = 'sonarqube:6.4-alpine';
-const DOCKER_JHIPSTER_CONSOLE = 'jhipster/jhipster-console:v2.0.1';
-const DOCKER_JHIPSTER... | [No CFG could be retrieved] | Reads a single element from the System. region Public API Methods. | Shouldnt this be called, `DOCKER_COMPOSE_RELEASE_VERSION` or something clearer |
@@ -84,7 +84,9 @@ public class ClusterUtils {
String remoteGroup = map.get(Constants.GROUP_KEY);
String remoteRelease = map.get(Constants.RELEASE_KEY);
map.putAll(localMap);
- map.put(Constants.GROUP_KEY, remoteGroup);
+ if (!map.containsKey(Constants.GROUP_K... | [ClusterUtils->[mergeUrl->[size,putAll,isNotEmpty,add,endsWith,get,getParameters,addParameters,remove,length,put,keySet]]] | Merges the remote url with the local url. This method is called when a consumer group value has not been filtered by group. Add an extra key to the remoteUrl and the localUrl. | I think we should only check `StringUtils.isNotEmpty(remoteGroup)` but not `!map.containsKey(Constants.GROUP_KEY)` |
@@ -682,6 +682,14 @@ func Uninstall(context Context, components []string, log Log) keybase1.Uninstall
log.Debug("Uninstalling components: %s", components)
+ if libkb.IsIn(string(ComponentNameRedirector), components, false) {
+ err = libnativeinstaller.UninstallRedirector(context.GetRunMode(), log)
+ componentRe... | [CheckPlist,MakeParentDirs,ListServices,GetRuntimeDir,TempDir,CombineErrors,Info,WaitForServiceInfoFile,HasPrefix,GetServiceInfoPath,Uninstall,Itoa,ReadFile,New,GetCacheDir,EvalSymlinks,UninstallKBNM,IsIn,UninstallMountDir,GetMountDir,Sys,GetLogDir,UninstallCommandLinePrivileged,NewPlist,FileExists,MustParse,Dir,Status... | InstallKBNM installs the KBNM NativeMessaging whitelist and uninstalls all components. UninstallUpdaterService uninstalls the updater service. | Looks like should `s/uninstalling mount dir/stopping rediector/` here? |
@@ -1153,7 +1153,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
maxPriority, ignoreDirective, previousCompileContext);
compile.$$addScopeClass($compileNodes);
var namespace = null;
- return function publicLinkFn(scope, cloneConnectFn, transcludeControlle... | [No CFG could be retrieved] | The compile function is the main entry point for the link function. It is the main entry link node. | Why change the order of these parameters? |
@@ -50,3 +50,10 @@ class KeyCurveName(str, Enum):
p_384 = "P-384" #: The NIST P-384 elliptic curve, AKA SECG curve SECP384R1.
p_521 = "P-521" #: The NIST P-521 elliptic curve, AKA SECG curve SECP521R1.
p_256_k = "P-256K" #: The SECG SECP256K1 elliptic curve.
+
+
+class WellKnownIssuerNames(str, Enum):... | [No CFG could be retrieved] | The NIST P - 384 elliptic curve. | Does sphinx resolve this link? |
@@ -64,10 +64,12 @@ function queue_run(&$argv, &$argc) {
// delivering
- require_once 'include/salmon.php';
+ include_once 'include/salmon.php';
- $r = q("SELECT * FROM `queue` WHERE `id` = %d LIMIT 1",
- intval($queue_id));
+ $r = q(
+ "SELECT * FROM `queue` WHERE `id` = %d LIMIT 1",
+ intval($queue_id)
+ )... | [No CFG could be retrieved] | This function is called when a queue is ready to be run. It will attempt to deliver This function is called by worker thread to check if a queue item is known to be dead if there is a user in the queue and there is a contact in the queue it will This function is called by the queue_deliver hook to deliver a message to ... | Please revert this line. |
@@ -153,6 +153,7 @@ def parse_specs(args, **kwargs):
concretize = kwargs.get('concretize', False)
normalize = kwargs.get('normalize', False)
tests = kwargs.get('tests', False)
+ reuse = kwargs.get('reuse', False)
try:
sargs = args
| [require_cmd_name->[cmd_name],require_python_name->[python_name],all_commands->[cmd_name],display_specs->[fmt->[gray_hash],format_list->[fmt],get_arg,iter_groups,format_list],get_module->[python_name,require_cmd_name,get_module],get_command->[python_name,require_cmd_name,get_module]] | Convenience function for parsing arguments from specs. Handles common exceptions and dies if there are errors. | This should probably be `policy=reuse`, so that we have the option for multiple policies later. |
@@ -16,6 +16,9 @@ from phone_number_helper import PhoneNumberUriReplacer
from phone_number_testcase import PhoneNumberCommunicationTestCase
from _shared.testcase import BodyReplacerProcessor
+SKIP_PHONE_NUMBER_TESTS = True
+PHONE_NUMBER_TEST_SKIP_REASON= "Phone Number Administration live tests infra not ready yet"
... | [PhoneNumberAdministrationClientTest->[test_create_search->[create_search,CreateSearchOptions],test_update_capabilities->[update_capabilities,iter,NumberUpdateCapabilities],test_configure_number->[PstnConfiguration,configure_number],test_purchase_search->[purchase_search],test_cancel_search->[cancel_search],test_list_p... | This method initializes the class variables. This method is called from the command line. It is called from the command line. It Method to register all of the names of all components in order to provide their default values. | Just wondering if there is a way for us to have this defined somewhere at global level rather than doing it in every file? |
@@ -180,3 +180,16 @@ export function areMarginsChanged(margins, change) {
(change.bottom !== undefined && change.bottom != margins.bottom) ||
(change.left !== undefined && change.left != margins.left);
}
+
+/**
+ * @param {!LayoutRectDef} r1
+ * @param {!LayoutRectDef} r2
+ * @return {boolean}
+ */
+expo... | [No CFG could be retrieved] | Check if change is not margins. | Not allowed by `@param` types above. Either remove or change types. |
@@ -161,4 +161,17 @@ abstract class WebsiteController extends Controller
return $this->get('sulu_http_cache.cache_lifetime.enhancer');
}
+
+ /**
+ * {@inheritdoc}
+ */
+ public static function getSubscribedServices()
+ {
+ $subscribedServices = parent::getSubscribedServices();
+ ... | [WebsiteController->[renderBlock->[renderBlock,mergeGlobals,loadTemplate,get],getCacheTimeLifeEnhancer->[has,get],renderStructure->[renderBlock,renderView,getCacheTimeLifeEnhancer,getAttributes,getRequestFormat,enhance,renderPreview,getRequest,exists,getView],getRequest->[getCurrentRequest],getAttributes->[resolve,get]... | Get cache time life enhancer. | this method should configure the minimal container that is passed to the controller. unfortunately apparently the method does not affect anything right now and the controller still receives the complete container |
@@ -21,7 +21,8 @@ namespace System.Text.Json.Serialization
// Today only typeof(object) can have polymorphic writes.
// In the future, this will be check for !IsSealed (and excluding value types).
CanBePolymorphic = TypeToConvert == typeof(object);
-
+ IsValueType = Typ... | [JsonConverter->[TryWrite->[TryWriteAsObject,OnTryWrite],TryRead->[OnTryRead]]] | Creates a JsonConverter that converts an object or value to or from JSON. Get or set the T value. | I think you can remove `HandleNullValue` and `ShouldHandleNullValue` and use `IsValueType` directly. |
@@ -121,11 +121,11 @@ public class Instrumenter<REQUEST, RESPONSE> {
spanBuilder.setStartTimestamp(startTimeExtractor.extract(request));
}
- AttributesBuilder attributesBuilder = Attributes.builder();
+ UnsafeAttributes attributesBuilder = new UnsafeAttributes();
for (AttributesExtractor<? supe... | [Instrumenter->[shouldStart->[fromContextOrNull,extract,recordSuppressedSpan],start->[setAttribute,build,start,setParent,extract,startSpan,forEach,onStart,with,builder,setStartTimestamp],end->[setAttribute,extractCause,recordException,onEnd,build,end,fromContext,extract,forEach,setStatus,builder],getTracer,instance]] | Starts a new context with the specified parent context and request. | any ideas how we can init the `SpanBuilder` with the already built `Attributes` map, to avoid this copy? |
@@ -100,12 +100,16 @@ abstract class AbstractAmqpInboundAdapterParser extends AbstractSingleBeanDefini
builder.addConstructorArgValue(listenerContainerBeanDef);
}
IntegrationNamespaceUtils.setReferenceIfAttributeDefined(builder, element, "message-converter");
-
+
IntegrationNamespaceUtils.configureHeader... | [AbstractAmqpInboundAdapterParser->[doParse->[getAttribute,hasText,assertNoContainerAttributes,configureChannels,setValueIfAttributeDefined,configureHeaderMapper,buildListenerContainer,addConstructorArgReference,addConstructorArgValue,setReferenceIfAttributeDefined],assertNoContainerAttributes->[hasText,getAttribute,er... | This method is overridden to add the necessary configuration to the BeanDefinitionBuilder. | How about to move these new lines before one about setting 'message-converter', to make the code more more logical and consistent? |
@@ -91,4 +91,3 @@ def trace(self, message, *args, **kwargs):
logging.addLevelName(TRACE, "TRACE")
logging.Logger.trace = trace
-initialize_logging()
| [initialize_logging->[TokenURLFilter],set_verbosity->[set_all_logger_level],initialize_logging] | Initialize the logging system. | Even though the `@memoize` decorator is on this function, it's still getting called twice, like python is creating two different instances of it. Don't really understand it. But we also don't need to call it here. |
@@ -76,13 +76,15 @@ public class JmsMessageProducerInstrumentation implements TypeInstrumentation {
MessageDestination messageDestination =
tracer().extractDestination(message, defaultDestination);
- span = tracer().startProducerSpan(messageDestination, message);
- scope = tracer().startPr... | [JmsMessageProducerInstrumentation->[typeMatcher->[named,implementsInterface],ProducerAdvice->[stopSpan->[endExceptionally,reset,end,close],onEnter->[getDestination,incrementCallDepth,startProducerScope,startProducerSpan,extractDestination]],ProducerWithDestinationAdvice->[stopSpan->[endExceptionally,reset,end],onEnter... | This method is called when a method enter is called. | oh, good find, can you open an issue for this? |
@@ -103,6 +103,9 @@ func PrepareJoinCluster(cfg *Config) error {
existed := false
for _, m := range listResp.Members {
+ if len(m.Name) == 0 {
+ return errors.New("exsist a member that the join is not completed")
+ }
if m.Name == cfg.Name {
existed = true
}
| [Join,Error,Sprintf,AddEtcdMember,New,Close,WithStack,Readdirnames,ToTLSConfig,Open,Split,ListEtcdMembers] | PrepareJoinCluster prepares a new cluster object. List returns a list of all members with a specific ID. | How about `there is a member that has not been joined successfully`? PTAL @CaitinChen |
@@ -98,7 +98,7 @@ public final class ParameterModelsLoaderDelegate {
ParameterDeclarationContext declarationContext,
ParameterGroupDeclarer parameterGroupDeclarer) {
List<ParameterDeclarer> declarerList = new ArrayList<>();
- ch... | [ParameterModelsLoaderDelegate->[declaredAsGroup->[declare],declare->[declare]]] | Declares all the parameters of the given component. Parse an extension parameter and return a list of all possible declarer. | This seems to be checked in ParameterModelValidator, I think it is better if it keeps failing there. |
@@ -174,6 +174,12 @@ module Dependabot
dependency_source_details.fetch(:type) == "provider"
end
+ def lockfile_dependency?
+ return false if dependency_source_details.nil?
+
+ dependency_source_details.fetch(:type) == "lockfile"
+ end
+
def dependency_source_details
... | [UpdateChecker->[updated_requirements->[updated_requirements],all_provider_versions->[all_provider_versions],all_module_versions->[all_module_versions],git_dependency?->[git_dependency?]]] | Checks if a given is a provider dependency. | Is this method used? |
@@ -58,6 +58,7 @@ type Service struct {
Channel string
Site string
PreviousHealth string `db:"previous_health"`
+ UpdateStrategy string `db:"update_strategy"`
LastEventOccurredAt time.Time `db:"last_event_occurred_at"`
HealthUpdatedAt time.Time `db:"health_update... | [FullReleaseString->[Sprintf]] | FullReleaseString returns a string representation of the service. | I'm a little surprised about db struct tags here; in `pkg/storage/postgres`, I understand them. Here? Not really. |
@@ -17,7 +17,7 @@ module GobiertoBudgets
{term: { code: conditions[:code] }},
{missing: { field: 'functional_code'}},
{missing: { field: 'custom_code'}},
- {term: { ine_code: conditions[:place].id }}
+ {term: { ine_code: conditions[:site].organization_id }}
]
... | [all->[functional_codes_for_economic_budget_line],compare->[search],any_data?->[search],budget_line_query->[search,for_ranking],top_differences->[search],search->[search]] | This method retrieves the first missing object based on the given conditions. | Space inside { missing.<br>Space inside } missing. |
@@ -51,13 +51,17 @@ class ResolveRequirementsTaskBase(Task):
else:
target_set_id = 'no_targets'
+ # We need to ensure that we are resolving for only the current platform if we are
+ # including local python dist targets that have native extensions.
+ maybe_platforms = ['current'] if sel... | [ResolveRequirementsTaskBase->[merge_pexes->[merged_pex]]] | Resolve requirements against this interpreter. Return a PEX object with the path to the file containing the missing requirements. | ditto. tho this code path is slightly less important than the one above (because presumably this is the path called for things like `run` or `test` which execute locally), a user would probably expect e.g. an unsatisfiable transitive dep for e.g. `linux-x86_64` to manifest as a failure in `test` locally on an OSX machi... |
@@ -178,6 +178,9 @@ class FeatureContext extends BehatContext implements ClosuredContextInterface {
* @param array $parameters context parameters (set them up through behat.yml)
*/
public function __construct( array $parameters ) {
+ if ( getenv( 'RESTFUL_TEST_DBHOST' ) ) {
+ self::$db_settings['dbhost'] = g... | [FeatureContext->[install_wp->[download_wp,create_db,create_run_dir,create_config]]] | This method is called when the constructor is called. | Let's rename this to `WP_CLI_TEST_DBHOST` |
@@ -421,6 +421,9 @@ const forbiddenTerms = {
'cidForDoc|cidForDocOrNull': {
message: requiresReviewPrivacy,
whitelist: [
+ // CID service is not allowed in amp4ads. No usage should there be
+ // in extensions listed in the amp4ads spec:
+ // https://amp.dev/documentation/guides-and-tutorials... | [No CFG could be retrieved] | Extension modules. JS API for AMP. | Is `'src/service/url-replacements-impl.js',` an exception? It's very possible that amp4ads use some other service which then use cid service. But I guess that's fine, because we reject the cid service in amp4ads anyway. |
@@ -159,7 +159,7 @@ class CmdMetricsDiff(CmdBase):
def add_parser(subparsers, parent_parser):
- METRICS_HELP = "Commands to add, manage, collect and display metrics."
+ METRICS_HELP = "Commands to add, manage, collect, and display metrics."
metrics_parser = subparsers.add_parser(
"metrics",
| [CmdMetricsShow->[run->[show_metrics]],add_parser->[add_parser],CmdMetricsDiff->[run->[_show_diff]]] | Adds a parser to subparsers to add manage and collect metrics. Command line interface for handling command - line options. Adds command line options for the command - line utility to show changes in metrics between a commit "Show output in JSON format. | Are you sure comma is needed here? `and` is not really joining two independent clauses. |
@@ -33,6 +33,6 @@ namespace System.Text.Json.Serialization
/// <returns>
/// An instance of a <see cref="JsonConverter{T}"/> where T is compatible with <paramref name="typeToConvert"/>.
/// </returns>
- public abstract JsonConverter CreateConverter(Type typeToConvert, JsonSerializerOpt... | [JsonConverterFactory->[JsonConverter->[CreateConverter,Assert,CanConvert]]] | Create a converter for the given type. | @steveharter would know better, but I don't see why `options` should be nullable here. |
@@ -4,9 +4,7 @@
/* jshint unused:false */
/* jshint ignore:start */
-import React from "react";
-import ReactDom from "react-dom";
-import AlgoliaSearcher from "./kb-search/wp-seo-kb-search.js";
+import intialiseAlgoliaSearch from "./kb-search/wp-seo-kb-search-init";
/* jshint ignore:end */
( function() {
| [No CFG could be retrieved] | Detects the wrong use of variables in title and description templates. missing - variables. | We use American English, which means `initialise` should be written as `initialize`. There is also a typo in the varname. |
@@ -956,13 +956,13 @@ void tool_change(const uint8_t tmp_extruder, bool no_move/*=false*/) {
#if ENABLED(SINGLENOZZLE)
#if FAN_COUNT > 0
- singlenozzle_fan_speed[active_extruder] = thermalManager.fan_speed[0];
- thermalManager.fan_speed[0] = singlenozzle_fan_speed[tmp_extrude... | [No CFG could be retrieved] | Updates the current position and updates the soft end stops if necessary. This function is called when the user pauses or moves the element in the array. | are you sure of this "!" ? uint16_t singlenozzle_temp[EXTRUDERS]; its always 2 ? |
@@ -306,6 +306,16 @@ define([
this._releaseGltfJson = defaultValue(options.releaseGltfJson, false);
this._animationIds = undefined;
+ // Undocumented options
+ this._precreatedAttributes = options.precreatedAttributes;
+ this._vertexShaderLoaded = options.vertexShaderLoaded;
+ ... | [No CFG could be retrieved] | Creates a new Model object based on a given binary glTF file. The n - tuple of glTF and n - tuple of glTF. | I can help you set up some test data for when we merge this into the 3d-tiles branch and need to confirm it still works after fixing the merge conflicts. |
@@ -42,6 +42,11 @@ export const RTC_VENDORS = {
macros: ['CID'],
disableKeyAppend: true,
},
+ prebid_appnexus : {
+ url: 'https://prebid.adnxs.com/pbs/v1/openrtb2/amp?tag_id=PLACEMENT_ID',
+ macros : ['PLACEMENT_ID'],
+ disableKeyAppend: true,
+ }
};
// DO NOT MODIFY: Setup for tests
| [No CFG could be retrieved] | Provides a list of vendors that can be used to retrieve a specific . | If you're going to do a name with underscores, you'll have to quote the string. You have some lint violations you need to fix as well, but otherwise looks good |
@@ -360,5 +360,13 @@ task_list = [
"task": "twitter",
"tags": [ "All", "ChitChat" ],
"description": "Twitter data from: https://github.com/Marsan-Ma/chat_corpus/. No train/valid/test split was provided so 10k for valid and 10k for test was chosen at random."
- }
+ },
+ {
+ "i... | [No CFG could be retrieved] | Twitter data from Marsan Ma. | This needs to say *which* dump (there are many dumps of wikipedia) |
@@ -153,6 +153,8 @@ func (r *RegionScatterer) scatterRegion(region *core.RegionInfo) *operator.Opera
}
scatterWithSameEngine(ordinaryPeers, r.ordinaryEngine)
+ // FIXME: target leader only consider the ordinary engine.
+ targetLeader := r.collectAvailableLeaderStores(targetPeers, r.ordinaryEngine)
for engine, p... | [collectAvailableStores->[newFilter],scatterRegion->[put,reset]] | scatterRegion returns a scatter operator that scatters the given region into the given region. scatter region is a special case where the region is a scatter region and the other nodes are. | What about creating an issue to track this (Ignore me if already). |
@@ -346,10 +346,10 @@ define(['../../Core/destroyObject',
* @alias Animation
* @constructor
*
- * @param {DOM Node} parentNode The parent HTML DOM node for this widget.
+ * @param {Element|String} container The DOM element or DOM element ID, that will contain the widget.
* @param {Animat... | [No CFG could be retrieved] | An animation is a widget that provides a time and time surrounded by a shuttle ring Animation function. | I think you need a comma after "The DOM element". |
@@ -174,7 +174,14 @@ bool ValueInfo::TryGetInt64ConstantValue(int64 *const intValueRef, const bool is
int32 int32ValueRef;
if (TryGetIntConstantValue(&int32ValueRef, false))
{
- *intValueRef = (isUnsigned) ? (uint)int32ValueRef : int32ValueRef;
+ if (isUnsigned)
+ ... | [UpdateIntBoundsForLessThan->[UpdateIntBoundsForLessThanOrEqual],UpdateIntBoundsForGreaterThan->[UpdateIntBoundsForGreaterThanOrEqual],IsGreaterThanOrEqualTo->[IsGreaterThanOrEqualTo],DetermineArrayBoundCheckHoistability->[DetermineSymBoundOffsetOrValueRelativeToLandingPad,SetCompatibleBoundCheck,SetLoop,SetLoopCount],... | TryGetInt64ConstantValue - Get int64 constant. | That's a very subtle bug hahaha I guess implicit conversion warning would have caught this. Would `*intValueRef = (isUnsigned) ? (int64)(uint)int32ValueRef : (int64)int32ValueRef;` have also been a valid fix ? |
@@ -461,11 +461,13 @@ abt_fini(void)
static int
server_init(int argc, char *argv[])
{
- uint64_t bound;
- int64_t diff;
- unsigned int ctx_nr;
- char hostname[256] = { 0 };
- int rc;
+ static struct d_tm_node_t *startup_dur;
+ static struct d_tm_node_t *started_ts;
+ uint64_t bound;
+ int64_t diff;
+ unsig... | [int->[setenv,crt_finalize,printf,hwloc_bitmap_asprintf,hwloc_bitmap_set,daos_errno2der,nanosleep,dss_self_rank,hwloc_get_nbobjs_by_depth,hwloc_get_type_depth,pl_fini,drpc_init,server_init_state_fini,hwloc_topology_load,D_ERROR,dss_set_start_epoch,free,set_abt_max_num_xstreams,dss_module_init_all,strnlen,strtoul,ABT_in... | Initialize the server init all modules This function is called from DSS_INIT_STATE_SET_UP DSS_ DSS DSS DSS DSS DSS DSS DSS DSS DSS. | Might be worthwhile to add a metric for the rank as well. If we're looking at an aggregated tree of metrics it would be useful to see the ranks in it. Could also be a way to query for rank via metrics rather than scraping logs or whatever. |
@@ -141,12 +141,12 @@ class AutotestRunJob < ApplicationJob
# tests executed locally or remotely with authentication
mkdir_command = "mktemp -d --tmpdir='#{server_path}'"
server_path = ssh.exec!(mkdir_command).strip # create temp subfolder
- # copy all files using passwordless scp (natively, t... | [AutotestRunJob->[enqueue_test_run->[export_group_repo,repo_files_available?],perform->[enqueue_test_run]]] | Enqueue a single test run. create temp folder and copy all files from params_file to server_path if necessary. | Layout/SpaceInsideArrayLiteralBrackets: Do not use space inside array brackets. |
@@ -869,6 +869,9 @@ class TextAnalyticsClient(TextAnalyticsClientBase):
combine multiple Text Analytics actions into one call. Otherwise, we recommend you use
the action specific endpoints, for example :func:`analyze_sentiment`.
+ .. note:: The following actions are supported with resources c... | [TextAnalyticsClient->[recognize_entities->[_check_string_index_type_arg,process_http_response_error,pop,update,_validate_input,entities_recognition_general],analyze_sentiment->[_check_string_index_type_arg,process_http_response_error,pop,update,sentiment,ValueError,_validate_input],extract_key_phrases->[key_phrases,_v... | Starts a long - running operation to perform a variety of text analysis actions over a set Retrieves a list of entities in a batch of Text Analytics objects. This method returns a list of all objects in the order specified. | Perhaps create an issue to remove this language once the feature is widely available and inline a link to it here as a TODO? |
@@ -1183,7 +1183,7 @@ class LoggedIO:
while True:
try:
tag, key, offset, _ = next(iterator)
- except IntegrityError:
+ except IntegrityError: # KILLING? because found to be "not committed"?
return False
except StopIteration:
... | [Repository->[prepare_txn->[_read_integrity,prepare_txn,open_index,check_transaction],check_can_create_repository->[AlreadyExists],_update_index->[CheckNeeded],get_transaction_id->[get_index_transaction_id,check_transaction],get->[ObjectNotFound,get_transaction_id,open_index],check_transaction->[CheckNeeded,get_index_t... | Check if a segment ends with a COMMIT_TAG. | Yes, these two are an inherent (though I think not very important) issue in a transacted store; it's difficult to tell an aborted transaction (which can of course have partial writes and all that) from a corrupted completed transaction. This is mitigated in two/threeish ways: - 1.0: only one commit is left alive, and i... |
@@ -101,6 +101,13 @@ module View
h('td.right', @game.format_currency(@player.cash - committed)),
]),
]) if committed.positive?
+
+ trs.concat([
+ h(:tr, [
+ h(:td, 'Bidding tokens'),
+ h('td.right', "#{@game.active_step.bidding_toke... | [Player->[render_priority_deal->[h],render_corporation_shares->[h,dig,logo,president?,sum,name,simple_logo],render->[h,empty?,any?,render_minors,can_act?],render_next_sr_position->[next_sr_position,h,ordinal],render_body->[h,any?],render_title->[name,color_for,h],render_info->[priority_deal_player,num_certs,render_next... | Renders a node with info about a node in the game graph. Renders a n - node header depending on the user s preference. | Using round state would be better than active_step for managing bidding tokens. |
@@ -1,4 +1,4 @@
<!-- <%= t('notices.dap_participation') %> -->
<% dap_source = 'https://dap.digitalgov.gov/Universal-Federated-Analytics-Min.js?agency=GSA&subagency=TTS' %>
-<%= nonced_javascript_tag({src: dap_source, async: true, id: '_fed_an_ua_tag'}) do %>
+<%= backwards_compatible_javascript_tag(src: dap_source, ... | [No CFG could be retrieved] | Find the nexus tag in the DAP. | I've heard that every time you get rid of optional `{` in ruby, an angel gets its wings |
@@ -64,12 +64,6 @@ public abstract class ParseSpec
return dimensionsSpec;
}
- @PublicApi
- public void verify(List<String> usedCols)
- {
- // do nothing
- }
-
public Parser<String, Object> makeParser()
{
return null;
| [ParseSpec->[hashCode->[hashCode],equals->[equals]]] | Returns dimensions spec if any. | This `verify` method is useful for making sure that people's transforms, dimensions, metrics, etc are derived from fields they specified (to help detect errors & typos). But I see why you removed it -- info about transforms isn't available at this point in the code. It probably makes sense to add this functionality bac... |
@@ -854,7 +854,6 @@ func (pkg *pkgContext) genHeader(w io.Writer, goImports []string, importedPackag
pkgName = path.Base(pkg.mod)
}
- fmt.Fprintf(w, "// nolint: lll\n")
fmt.Fprintf(w, "package %s\n\n", pkgName)
var imports []string
| [genResource->[plainType,getDefaultValue,inputType,outputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[getTypeImports,add],genConfig->[genHeader,getDefaultValue,getImport... | genHeader writes a header for the package package and imports. Returns a new object that represents the result of a call to the method. | This is mostly unrelated to other changes here - but part of overall cleaning up codegen. |
@@ -1426,12 +1426,17 @@ def setup_volume_source_space(subject, fname=None, pos=5.0, mri=None,
"""
subjects_dir = get_subjects_dir(subjects_dir)
+ if overwrite is not None:
+ raise ValueError("Parameter 'overwrite' is deprecated. Use "
+ "mne.write_source_spaces instead.")
... | [morph_source_spaces->[_ensure_src_subject,_get_vertex_map_nn,SourceSpaces,_get_hemi,_ensure_src],_get_morph_src_reordering->[_get_vertex_map_nn],read_source_spaces->[_read_source_spaces_from_tree],setup_volume_source_space->[SourceSpaces,write_source_spaces],get_volume_labels_from_aseg->[_get_lut],write_source_spaces-... | Setup a volume source space with grid spacing or discrete source space. Create a single node in the system. Check if a is present in the Freesurfer lookup table. Get a non - discrete or discrete base - space object from the BEM or SUR Compute a source space that contains a sequence of data in the MRI_VOXEL. | We should do these deprecations in `setup_source_space` and `make_forward_solution`, too |
@@ -670,6 +670,16 @@ public class MustFightBattle extends AbstractBattle implements BattleStepStrings
return steps;
}
+ /**
+ * @return true if the attacker can retreat one or more units
+ */
+ public boolean canAttackerRetreatSome() {
+ return canAttackerRetreat()
+ || ( m_battleSite.isWater... | [MustFightBattle->[transporting->[transporting],showCasualties->[isEmpty],attackerRetreatSubs->[getAttackerRetreatTerritories,canAttackerRetreatSubs],defenderRetreatSubs->[canDefenderRetreatSubs],attackAirOnNonSubs->[fire],getBattleExecutables->[execute->[determineStepStrings,shouldEndBattleDueToMaxRounds,updateDefendi... | Determines the list of strings that should be displayed for the next step. Checks if the attacker is transportable. attacker subs sneak attack and defender subs if they fire FIRST in comb region Attacking Subscriptions private Collection<Unit> units = new ArrayList<Unit>(); private int nextOrder = 0 ; Add a stack of IE... | Please rename: `canAttackerRetreatSome` -> `canAnyAttackersRetreat` |
@@ -11,9 +11,9 @@ import (
)
func init() {
- if err := mb.Registry.AddMetricSet("memcached", "stats", New); err != nil {
- panic(err)
- }
+ mb.Registry.MustAddMetricSet("memcached", "stats", New,
+ mb.DefaultMetricSet(),
+ )
}
type MetricSet struct {
| [Fetch->[Write,NewScanner,Apply,Host,DialTimeout,Close,Module,Scan,Split,Config,Text],AddMetricSet,Beta] | stats import imports and returns a metricset with the given name. | No host parser here? |
@@ -18,17 +18,10 @@ import (
"context"
"k8s.io/apimachinery/pkg/api/meta"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
)
-// Object is wrapper interface combining runtime.Object and metav1.Object interfaces together.
-type Obj... | [IsNoMatchError,ObjectKeyFromObject,Delete,String,IgnoreNotFound] | ObjectName returns the name of the object that was found in the object store. DeleteObject deletes an object from the Kubernetes API. It ignores not found errors and no match. | Why was this removed? If I remember correctly, at least some extensions might use it. |
@@ -2111,7 +2111,7 @@ class BuilderFrame(wx.Frame):
# namespace:
name = exp.namespace.makeValid(
name, prefix='routine')
- if oldName in self.exp.routines.keys():
+ if oldName in list(self.exp.routines.keys()):
# Swap old with new names
... | [RoutinesNotebook->[addRoutinePage->[RoutineCanvas],redrawRoutines->[addRoutinePage,removePages],createNewRoutine->[addRoutinePage],__init__->[__init__]],ExportFileDialog->[__init__->[__init__]],ReadmeFrame->[__init__->[makeMenus,__init__]],ComponentsPanel->[onAddToFavorites->[addComponentButton],onRightClick->[getInde... | renames a Routine. | I don't understand these changes, could someone explain? Why the explicit conversion? |
@@ -859,10 +859,11 @@ class ReviewBase(object):
self.set_files(amo.STATUS_DISABLED, files, hide_disabled_file=True)
self.log_action(action_id, version=version, files=files,
timestamp=timestamp)
- # Unset needs_human_review on those versions, we consider that... | [ReviewUnlisted->[process_public->[set_files,notify_email,log_action]],ReviewHelper->[set_data->[set_data]],ReviewerQueueTable->[render_addon_name->[increment_item]],ViewUnlistedAllListTable->[render_authors->[safe_substitute],render_guid->[safe_substitute],render_addon_name->[increment_item,safe_substitute]],ModernAdd... | Reject a list of versions. Assign incentive score to user. | I moved this and changed the code to update each version separately because the queryset is in a weird state after going through the loop - it's as if it's empty as soon as you try to act on it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.