patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -48,11 +48,11 @@ class SniffTest(AllenNlpTestCase):
"description": "If you liked the music we [V: were] playing last night , you will absolutely love what we 're playing tomorrow !",
"tags": ["O", "O", "O", "O", "O", "O", "B-V", "O", "O", "O", "O", "O", "O", "O", "O", "O", "O", "O... | [SniffTest->[test_coreference_resolution->[print,predict_json,DEFAULT_MODELS],test_machine_comprehension->[predict_json,DEFAULT_MODELS],test_ner->[predict_json,DEFAULT_MODELS],test_textual_entailment->[predict_json,DEFAULT_MODELS],test_constituency_parsing->[predict_json,DEFAULT_MODELS],test_semantic_role_labeling->[pr... | Test semantic role labeling. The last night music is not a music. Last night music is not a real music. | It's pretty cool that the new model picks up this case - I hadn't thought that the previous model was incorrect, but in this sentence, "will" is a light verb and doesn't really hold any semantic meaning (I think). Progress |
@@ -223,7 +223,7 @@ post:
}
end:
- vos_update_end(ioh, rdone->ro_version, &rdone->ro_dkey, rc, NULL);
+ rc = vos_update_end(ioh, rdone->ro_version, &rdone->ro_dkey, rc, NULL);
return rc;
}
| [No CFG could be retrieved] | rebuild dkey and eph punch dkeys and akeys before rebuild buf and rdone buffer for read - only header. | will it over-write the rc in above code? may use ret and rc = rc ? : ret;? |
@@ -34,6 +34,10 @@ class Relion(CMakePackage):
homepage = "http://http://www2.mrc-lmb.cam.ac.uk/relion"
url = "https://github.com/3dem/relion"
+ version('2.0.3', git='https://github.com/3dem/relion.git',
+ commit='50505945ec46c25ddebf7292492df7de331a2696')
+ version('v.2.1-beta-1',... | [Relion->[variant,depends_on,version]] | Creates a object that can be used to build a single object in a system. Add cmake_args to the command line arguments. | no need for `v.` here, also put it above `2.0.3`, where you can add `preferred=true` if you want to keep it as default. |
@@ -81,7 +81,7 @@ public class OldFileSystemNotebookRepo implements OldNotebookRepo {
@Override
public List<NotebookRepoSettingsInfo> getSettings(AuthenticationInfo subject) {
LOGGER.warn("getSettings is not implemented for HdfsNotebookRepo");
- return null;
+ return Collections.emptyList();
}
... | [OldFileSystemNotebookRepo->[list->[list,Path,getName,OldNoteInfo,add],updateSettings->[warn],init->[Path,makeQualified,getName,getString,FileSystemStorage,getNotebookDir,info,tryMkDir],getSettings->[warn],get->[readFile,Path,fromJson,toString],close->[warn],remove->[Path,toString,delete],save->[Path,toJson,toString,ge... | This method is used to retrieve the settings for a given subject. | Not related to this PR, I think it is time to move these Old NotebookRepo |
@@ -50,6 +50,9 @@ public class HoodieIndexConfig extends DefaultHoodieConfig {
public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL =
"hoodie.bloom.index.input.storage" + ".level";
public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL = "MEMORY_AND_DISK_SER";
+ public static final Strin... | [HoodieIndexConfig->[Builder->[build->[HoodieIndexConfig]]]] | This class is used to configure the Hoodie index. Creates a builder for the Hoodie index configuration. | rename to "hoodie.bloom.index.dynamic.bloomfilter" or "hoodie.bloom.index.auto.tune.bloomfilter" ? to make it clearer it's about the bloom filter and not the index checking.. Also this should probably belong in storage config? since its about how we write the parquet file right |
@@ -341,7 +341,7 @@ void galaxold_state::scramblb_map(address_map &map)
map(0x7000, 0x7000).portr("IN2");
map(0x7001, 0x7001).w(FUNC(galaxold_state::galaxold_nmi_enable_w));
map(0x7002, 0x7002).w(FUNC(galaxold_state::galaxold_coin_counter_w));
- map(0x7003, 0x7003).w(FUNC(galaxold_state::scrambold_background_enab... | [No CFG could be retrieved] | 0x07ff - > 0x7ff - > 0x7ff - > 0x80000000 - > 0x80000000 - > 0x80000000 - >. | This line can't possibly compile. |
@@ -60,13 +60,7 @@ class _CliCredentials(object):
if _AccessToken is None: # import failed
raise ImportError("You need to install 'azure-core' to use CLI credentials in this context")
- if len(scopes) != 1:
- raise ValueError("Multiple scopes are not supported: {}".format(scop... | [get_azure_cli_credentials->[_CliCredentials,get_cli_profile],_CliCredentials->[get_token->[_get_cred],signed_session->[_get_cred,signed_session]]] | Get an access token. | We don't need scopes any more? |
@@ -28,12 +28,12 @@ class Completer:
"""
- def __init__(self):
- self._iter: Iterator[str]
+ def __init__(self) -> None:
+ self._iter: Iterator[Optional[str]]
self._original_completer: Optional[Callable]
self._original_delims: str
- def complete(self, text, state):
+ ... | [Completer->[__exit__->[set_completer_delims,set_completer],complete->[next,iglob],__enter__->[parse_and_bind,get_completer_delims,set_completer,get_completer,set_completer_delims]]] | Initializes the object. | Is it `Optional`? It looks to me like like `iglob` just won't yield a value if there's nothing available. |
@@ -30,7 +30,12 @@ class State(Serializable):
"""
if type(self) == type(other):
assert isinstance(other, State) # this assertion is here for MyPy only
- return self.data == other.data
+ eq = True
+ for attr in self.__dict__:
+ if attr.start... | [State->[is_failed->[isinstance],is_running->[isinstance],is_pending->[isinstance],__hash__->[id],__eq__->[isinstance,type],__repr__->[,type],is_successful->[isinstance],is_finished->[isinstance],__init__->[utcnow]]] | Check if two states are equal. | This will raise errors if someone (for whatever reason) added an after-the-fact attribute to their state object that doesn't exist on the other one. I suggest `getattr(self, attr) == getattr(other, attr, object())` -- this will allow missing (or extra) attributes to be compared safely, and object() is never equal to an... |
@@ -21,7 +21,7 @@ namespace NServiceBus
/// <returns></returns>
public static IExcludesBuilder Except(string assemblyExpression)
{
- return new AllAssemblies { assembliesToExclude = new List<string>(new[] { assemblyExpression })};
+ return new AllAssemblies {assembliesTo... | [AllAssemblies->[IEnumerator->[GetEnumerator],GetEnumerator->[GetEnumerator]]] | Creates a new ExcludesBuilder that excludes the given assembly expression. | How does this work? I've never seen this syntax! How does it work for readony! |
@@ -105,7 +105,7 @@ public class ParallelIndexTuningConfig extends IndexTuningConfig
@JsonProperty("maxRowsInMemory") @Nullable Integer maxRowsInMemory,
@JsonProperty("maxBytesInMemory") @Nullable Long maxBytesInMemory,
@JsonProperty("maxTotalRows") @Deprecated @Nullable Long maxTotalRows,
- @... | [ParallelIndexTuningConfig->[hashCode->[hashCode],defaultConfig->[ParallelIndexTuningConfig],equals->[equals]]] | This property is used to configure parallel index tuning. Maximum number of parse exceptions that should be saved before the last parse. | do we need to update any docs if `numShards` is deprecated now. |
@@ -165,6 +165,7 @@ class Guardian
end
alias :can_move_posts? :can_moderate?
alias :can_see_flags? :can_moderate?
+ alias :can_close? :can_moderate?
def can_tag?(topic)
return false if topic.blank?
| [Guardian->[can_revoke_moderation?->[moderator?],allowed_theme_repo_import?->[blank?,admin?],can_approve?->[is_staff?,approved?],is_not_me?->[blank?,is_me?],can_do?->[method_name_for,authenticated?],can_activate?->[is_staff?],can_see_groups_members?->[blank?],can_send_multiple_invites?->[staff?],can_tag?->[blank?],can_... | Checks if a topic can be tagged with this broker. | Do we need this alias here? I don't see it being used in the PR. |
@@ -160,6 +160,12 @@ class AmpAccordion extends AMP.BaseElement {
header.addEventListener('click', this.clickHandler_.bind(this));
header.addEventListener('keydown', this.keyDownHandler_.bind(this));
+ content.addEventListener('rendersubtreeactivation', event => {
+ const section = event.tar... | [No CFG could be retrieved] | Handle action action. Generate a sessionStorage key based on amp - accordion element id. | This is probably too simplistic for our needs. Not sure if we have an array of sections already handy here. If we do - we could just add listeners directly to those elements. |
@@ -281,7 +281,7 @@ class modSociete extends DolibarrModules
$this->export_sql_end[$r] .=' LEFT JOIN '.MAIN_DB_PREFIX.'c_payment_term as payterm ON s.cond_reglement = payterm.rowid';
$this->export_sql_end[$r] .=' LEFT JOIN '.MAIN_DB_PREFIX.'c_paiement as paymode ON s.mode_reglement = paymode.id';
$this->export... | [modSociete->[init->[trans,_init,load],__construct->[fetch_object,query]]] | Constructor for the module object - - - - - - - - - - - - - - - - - - Descripion de la variable de la permission Helps to set the rights of the object. Liefert une permission pour le utilisateurs internes Liefert une permission par defaut Envia les rights de la permission Export all the fields of a sale. | Why limiting to firt level of subordinates. You can make $subordinatesids = $user->getAllChildIds() and make into select count(subronidatesids) ? ' OR sc.fk_user IN ('.$subronidatesids.')' : ''; Also, the result return something not consistent with other screens. The export return also third of subordinates but not all... |
@@ -16,7 +16,7 @@
function response (response) {
var headers = Object.keys(response.headers()).filter(function (header) {
- return header.endsWith('app-alert') || header.endsWith('app-params');
+ return header.indexOf('app-alert', header.length - 'app-alert'.length)... | [No CFG could be retrieved] | Notification interceptor. | Very similar line (using `endsWith`) exists at `_alert-error.directive.js`. It could need to be changed as well. |
@@ -27,4 +27,10 @@ $scale_max = '100';
$nototal = 1;
+if (Config::get('webui.graph_processor_last_values')) {
+ $use_last_values = true;
+} else {
+ $use_last_values = false;
+}
+
require 'includes/html/graphs/generic_multi_line.inc.php';
| [No CFG could be retrieved] | This function is used to set the nototal property of the graph. | Getting warmer, remove the option and just set `$use_last_values = true;` |
@@ -299,3 +299,17 @@ def test_find_binary_on_path_without_bash(rule_runner: RuleRunner) -> None:
assert os.path.exists(os.path.join(binary_dir_abs, binary_name))
assert binary_paths.first_path is not None
assert binary_paths.first_path.path == binary_path_abs
+
+
+def test_find_binary_file_pa... | [test_argv_executable->[run_process],rule_runner->[new_rule_runner],test_cache_scope_per_restart->[run2,new_rule_runner,run1],which_binary_path] | Test that locating a binary on a path that does not include bash works. | These days, `tmp_path` is often favored over `tmpdir`. They're basically the same thing, except `tmp_path` gives you a stdlib `pathlib.Path` object instead of a `py.path.Path` object. |
@@ -14,14 +14,14 @@ from .image_list import ImageList
@torch.jit.unused
-def _onnx_get_num_anchors_and_pre_nms_top_n(ob, orig_pre_nms_top_n):
- # type: (Tensor, int) -> Tuple[int, int]
+def _onnx_get_num_anchors_and_pre_nms_top_n(ob: Tensor, orig_pre_nms_top_n: int) -> Tuple[int, int]:
from torch.onnx impo... | [concat_box_prediction_layers->[permute_and_flatten],RegionProposalNetwork->[_get_top_n_idx->[pre_nms_top_n,_onnx_get_num_anchors_and_pre_nms_top_n],forward->[concat_box_prediction_layers,assign_targets_to_anchors,filter_proposals,compute_loss],filter_proposals->[post_nms_top_n,_get_top_n_idx]]] | Returns the number anchors and the number of anchors in the given object. | Forced to cast for mypy. |
@@ -26,9 +26,10 @@ def test_new(base_url, selenium):
assert 'iframe' not in content
# content edit remains
assert 'Pumpkin' in content
- # check contents of draft
- draft_content = editor.draft_content(selenium.current_url)
- assert 'Pumpkin' in draft_content
+ # wait for throttled draft func... | [test_new->[login_moderator_user,AdminLogin,edit_source,write_title,editor,content_source,draft_content,publish,article_content,NewPage]] | Test if new page is not published. | This should be ``page.editor().is_draft_container_displayed``. |
@@ -92,6 +92,17 @@ public class ParserUtils
return input;
}
+ public static boolean isValidTimeZone(String timeZone)
+ {
+ for (String tz : TimeZone.getAvailableIDs()) {
+ if (tz.equals(timeZone)) {
+ return true;
+ }
+ }
+
+ return false;
+ }
+
/**
* Return a function to g... | [ParserUtils->[stripQuotes->[length,trim,charAt],generateFieldNames->[add,getDefaultColumnName],findDuplicates->[toLowerCase,newHashSet,add,contains],validateFields->[findDuplicates,toString,isEmpty,ParseException],getMultiValueFunction->[toList,emptyToNull,contains,collect]]] | strip quotes from a string. | Suggested to prepare a static map from `String` to joda-time's `DateTimeZone`, using `TimeZone.getAvailableIDs()` as keys. Then add a method `tryConvertToTimeZone(string)`, that is implemented just as `map.get()`, i. e. it returns `null` if time zone appears to not be valid. And then use this method in `TimestampParser... |
@@ -153,7 +153,7 @@ class FileCopier(object):
filenames = {f.lower(): f for f in filenames}
pattern = pattern.lower()
- files_to_copy = fnmatch.filter(filenames, pattern)
+ files_to_copy = [n for n in filenames if fnmatch.fnmatchcase(n, pattern)]
for exclude in exclude... | [report_copied_files->[splitext,basename,len,defaultdict,items,join,info,ext_files],FileCopier->[link_folders->[relpath,readlink,symlink,mkdir,ConanException,append,exists,dirname,str,startswith,realpath,rmdir,join,isabs,remove],_copy->[link_folders,abspath,basename,dirname,_filter_files,extend,startswith,join,_copy_fi... | Returns a list of the files matching the patterns and the list of the files that are linked. | This is broken, ``filter`` is doing internally some ``os.path.normcase``, which changes / => \\ path in Windows too |
@@ -167,9 +167,6 @@ func (r *LogFile) wait() {
}
func (r *LogFile) Close() {
- // Make sure reader is only closed once
- r.singleClose.Do(func() {
- close(r.done)
- // Note: File reader is not closed here because that leads to race conditions
- })
+ close(r.done)
+ // Note: File reader is not closed here because ... | [wait->[After,Duration],Close->[Do],errorChecks->[Size,Stat,Continuable,Name,IsSameFile,Since,Err,Debug],Read->[Name,Now,errorChecks,wait,Read,Debug],Seek,Now] | Close closes the log file. | why remove the `sync.Once` here? Can we guarantee only one go-routine calling Close just once now? |
@@ -708,14 +708,14 @@ public final class StorageContainerManager extends ServiceRuntimeInfoImpl
}
// The node here will try to fetch the cluster id from any of existing
// running SCM instances.
- // TODO: need to avoid failover to local SCM Node here
- final ScmInfo scmInfo = HAUtils.getScmInfo(co... | [StorageContainerManager->[getDatanodeRpcAddress->[getDatanodeRpcAddress],getRuleStatus->[getRuleStatus],stop->[unregisterMXBean,getSecurityProtocolServer,stop],createSCM->[StorageContainerManager,createSCM],join->[getSecurityProtocolServer,join],getClientRpcPort->[getClientRpcAddress],start->[getSecurityProtocolServer... | This method is called by the OzoneManager to bootstrap the SCM. | Here we need to call SCMHANodeDetails.loadSCMHAConfig(conf); Which will set node specific config key and then call getLocalNodeDetails to find localNodeId. Then this localNodeId can be removed. |
@@ -557,6 +557,11 @@ void CardReader::checkautostart() {
if (!isDetected()) initsd();
+ #if ENABLED(EEPROM_SETTINGS) && DISABLED(FLASH_EEPROM_EMULATION)
+ SERIAL_ECHOLNPGM("Loading settings from SD");
+ (void)settings.load();
+ #endif
+
if (isDetected()
#if ENABLED(POWER_LOSS_RECOVERY)
&& ... | [No CFG could be retrieved] | Find the next non - empty segment in the path and print it to the output. Reads a n - bit file from the DOS and returns a n - bit integer. | This also seems a very strange place to insert this. And redundant . |
@@ -209,8 +209,14 @@ func loginWithBrowser(ctx context.Context, d diag.Sink, cloudURL string, opts di
accessToken := <-c
+ username, err := client.NewClient(cloudURL, accessToken, d).GetPulumiAccountName(ctx)
+ if err != nil {
+ return nil, err
+ }
+
// Save the token and return the backend
- if err = workspac... | [CloudConsoleURL->[CloudURL],CreateStack->[CreateStack],runEngineAction->[Refresh,Update,Destroy],tryNextUpdate->[CloudURL],GetPolicyPack->[CloudURL,Name,parsePolicyPackReference],GetStack->[GetStack],CancelCurrentUpdate->[GetStack],GetLatestConfiguration->[GetLatestConfiguration],RenameStack->[RenameStack,ParseStackRe... | Login logs into the target cloud and returns a backend for it. IsValidAccessToken checks if the token is valid and if it is stores it. If it is. | Similar to other times when we create new accounts to store in the workspace, should we be setting `LastUsed` on the `AccountObject` here? |
@@ -5,6 +5,10 @@ module TwoFactorAuthentication
prepend_before_action :authenticate_scope!
+ def show
+ @delivery_method = 'recovery-code'
+ end
+
def create
result = RecoveryCodeForm.new(current_user, params[:code]).submit
| [RecoveryCodeVerificationController->[create->[track_event,handle_invalid_otp,merge,submit],prepend_before_action,include]] | create a new n - item object based on the current user s recovery code. | `recovery_code` is more consistent with the rest of our URLs |
@@ -246,7 +246,10 @@ func vchToModel(op trace.Operation, vch *vm.VirtualMachine, d *data.Data, execut
}
model.Runtime.PowerState = string(powerState)
- model.Runtime.DockerHost, model.Runtime.AdminPortal = getAddresses(vchConfig)
+ model.Runtime.DockerHost, model.Runtime.AdminPortal, err = getAddresses(executor, ... | [Handle->[FromContext,Context,StatusCode,Error,NewGetTargetTargetVchVchIDOK,WithPayload,NewGetTargetTargetDatacenterDatacenterVchVchIDDefault,NewGetTargetTargetVchVchIDDefault,NewGetTargetTargetDatacenterDatacenterVchVchIDOK],IPRange,NewDispatcher,GetBuild,PowerState,PEM,CIDR,Encode,HasPrefix,Errorf,SplitN,ShortVersion... | Endpoint returns a model. Endpoint object that represents the object that represents the . asBytes returns a ValueBytes object given a value in the order of units. | How about logging `err` instead of "No client IP assigned." (In this case, it's basically the same message, but if we ever add another error to `getAddresses`, this might be misleading.) |
@@ -39,7 +39,7 @@ checkbox_button_group = CheckboxButtonGroup(labels=["Option 1", "Option 2", "Opt
radio_button_group = RadioButtonGroup(labels=["Option 1", "Option 2", "Option 3"], active=0)
-text_input = TextInput(placeholder="Enter value ...")
+text_input = TextInput(placeholder="Enter value ...", title="<b>tex... | [mk_tab->[capitalize,scatter,figure,Panel],add_root,Tabs,mk_tab,RadioButtonGroup,RadioGroup,Slider,view,Row,Document,TextInput,Select,AutocompleteInput,CheckboxButtonGroup,Paragraph,Dropdown,range,DatePicker,PreText,Toggle,print,Button,open,file_html,MultiSelect,write,validate,RangeSlider,WidgetBox,Div,CheckboxGroup] | Creates a plot of the individual network components of the network network. Creates a basic example of the number of unique components in the network. | Users may depend on the fact that `title` used to accept raw strings. This is a breaking change. A bigger concern, however, is mixing raw strings with HTML, which never is a good idea (refer to PHP and a ton of other language/frameworks to see how this works out). Raw strings and HTML have to be separated to avoid user... |
@@ -149,13 +149,13 @@
}
}
- async Task ProcessFile(ILearningTransportTransaction transaction, string messageId)
+ async Task<bool> ProcessFile(ILearningTransportTransaction transaction, string messageId)
{
try
{
var message = awai... | [LearningTransportMessagePump->[Task->[UtcNow,IsCancellationRequested,BeginTransaction,FileToProcess,RetryRequired,CurrentCount,Set,Rollback,InputQueue,Error,onError,TryGetValue,ClearPendingOutgoingOperations,CompletedTask,GetCreationTimeUtc,Combine,Release,RequiredTransactionMode,Ignore,GetTransaction,Dispose,FromSeco... | Inner process for a file. check if we can find a node in the tree. | This should be updated to use `bodyDir` and the new consts as well. |
@@ -274,7 +274,7 @@ class ProgressBar(object):
if not self._need_update(): return
if self.start_time is None:
- raise RuntimeError('You must call "start" before calling "update"')
+ raise ArgumentError('You must call "start" before calling "update"')
now = time.time(... | [ProgressBar->[_format_line->[_format_widgets],finish->[update],start->[update],update->[_format_line,_need_update]]] | Updates the ProgressBar to a new value. | Leave as RuntimeError here too. |
@@ -154,12 +154,9 @@ crt_hdlr_ctl_get_uri_cache(crt_rpc_t *rpc_req)
if (rc != 0)
D_GOTO(out, rc);
- rc = d_hash_table_traverse(&grp_priv->gp_uri_lookup_cache,
- crt_ctl_get_uri_cache_size_cb, &nuri);
- if (rc != 0)
- D_GOTO(out, 0);
-
- D_ALLOC_ARRAY(uri_cache.grp_cache, nuri);
+ /* calculate max possible... | [No CFG could be retrieved] | get_uri_cache - get_uri_cache_size_cb - get_ get uri cache request. | I'm having trouble following this code, it's traverersing a hash table, and copying in up to CRT_SRV_CONTEXT_NUM per hash-table entry by the looks of it, so this buffer could potentialy be over-run? |
@@ -213,12 +213,13 @@ final class DnsQueryContext {
.append(" (no stack trace available)");
final DnsNameResolverException e;
- if (cause != null) {
- e = new DnsNameResolverException(nameServerAddr, question(), buf.toString(), cause);
+ if (cause == null) {
+ ... | [DnsQueryContext->[setSuccess->[nameServerAddr],setFailure->[question,nameServerAddr],query->[question,nameServerAddr]]] | Set failure. | IIUC this may not always be true. This method is also called when a write failure occurs (from `onQueryWriteCompletion`), right? Consider passing this exception (or some indication as to what the exception is) in to this method where the root cause is known instead of trying to infer it here. |
@@ -734,7 +734,7 @@ class Grouping < ActiveRecord::Base
total = 0
#find the unique test scripts for this submission
- test_script_ids = TestScriptResult.select(:test_script_id).where(:grouping_id => self.id)
+ test_script_ids = TestResult.select(:test_script_id).where(:grouping_id => self.id)
#... | [Grouping->[deletable_by?->[is_valid?],update_repository_permissions->[is_valid?],grant_repository_permissions->[write_repo_permissions?],remove_member->[membership_status],add_tas->[assign_all_tas],revoke_repository_permissions_for_membership->[write_repo_permissions?],remove_rejected->[membership_status],assign_tas_b... | get the total number of test script marks that have been added to this group by this group. | Line is too long. [87/80]<br>Use the new Ruby 1.9 hash syntax.<br>Redundant `self` detected. |
@@ -68,7 +68,7 @@ export default class WalletsList extends Component {
console.log('fetch all wallet txs took', (end - start) / 1000, 'sec');
} catch (error) {
noErr = false;
- alert(error);
+ console.log(error);
}
if (noErr) this.redrawScreen();
});
| [No CFG could be retrieved] | Component that handles the initial state of the component. check if the last card is in the wallet and if so fetch the wallet balance. | does it mean that electrum errors wont throw alerts anymore? it will be silent? |
@@ -23,6 +23,7 @@ log = olympia.core.logger.getLogger('z.editors.auto_approve')
class Command(BaseCommand):
help = 'Auto-approve add-ons based on predefined criteria'
+ lock_name = 'auto-approve' # Name of the atomic_lock() used.
post_review = False
def add_arguments(self, parser):
| [Command->[approve->[process_public,ReviewHelper],process->[approve,check_is_locked,int,set_reviewing_cache,get_verdict_display,update,create_summary_for_version,items,info,unicode,switch_is_active,clear_reviewing_cache],log_final_summary->[info],fetch_candidates->[filter],add_arguments->[add_argument],handle->[int,Com... | Handle command arguments. | This looks constant-like so should it be a constant? |
@@ -199,4 +199,18 @@ class Extends
edit_wopi_file_on_result: 99,
edit_wopi_file_on_step: 100
}.freeze
+
+ ACTIVITY_GROUPS = {
+ projects: [*0..7],
+ task_results: [*23..26, 40, 41, 42, 99],
+ task: [*8..14, 35, 36, 37, 53, 54, *58..69],
+ task_protocol: [*15..22, 45, 46, 47, 38, 39, 100],
+ ... | [Extends->[freeze]] | This is the main entry point for the edit window. | Hm.. Let's check if we can get activity group from 'subject', because this is really hard to maintain |
@@ -41,7 +41,8 @@ public class GroupDaoTest extends AbstractDaoTestCase {
@Before
public void setUp() {
- this.session = getMyBatis().openSession(false);
+ dbTester.truncateTables();
+ this.session = dbTester.myBatis().openSession(false);
this.system2 = mock(System2.class);
this.dao = new Gro... | [GroupDaoTest->[select_by_key->[setupData,selectByKey,parseDate,isNotNull,isEqualTo],insert->[setupData,thenReturn,insert,getTime,checkTables,commit,setDescription],setUp->[openSession,GroupDao,mock],find_by_user_login->[setupData,hasSize,isEmpty],tearDown->[close]]] | Sets up the object. | please add an @After method to close the connection |
@@ -224,6 +224,8 @@ SCHEMA = {
"row_limit": All(Coerce(int), Range(1)),
"row_cleanup_quota": All(Coerce(int), Range(0, 100)),
},
+ # section for experimental features
+ "feature": {Optional("parametrization", default=False): Bool},
}
COMPILED_SCHEMA = Schema(SCHEMA)
| [merge->[merge],_lower_keys->[_lower_keys],Config->[load->[validate],_load_paths->[resolve->[RelPath]],edit->[load,_save_paths,ConfigError,_save_config,load_one,load_config_to_level,validate],_save_config->[_get_tree],init->[Config],files->[get_dir],load_one->[_load_config],load_config_to_level->[load_one],validate->[C... | Construct a configuration object that manages the configuration of a DVC repo. Creates a class instance for the object. | Maybe `experimental` after all? Just to emphasize that this is for experimental features. `feature` could potentially be used for non-experimental but opt-in features. |
@@ -3952,6 +3952,16 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
return vm;
}
+ @Override
+ public Boolean checkIfDynamicScalingCanBeEnabled(ServiceOffering offering, VirtualMachineTemplate template, Long zoneId) {
+ Boolean canEnableDynamicScaling = o... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],getNetworkForOvfNetworkMapping->[getDef... | Creates a new virtual machine. find the next free node in the system check if the size of the custom disk offerings is within the allowed limits check if the template has a specific lease finds a key pair in the system or a template that can be used to deploy a find SSH key pair This method checks if there is a NIC in ... | Can this method also accept a VM as a parameter and check if the VM is scalable as well? |
@@ -178,8 +178,12 @@ class Trainer:
A ``Dataset`` to train on. The dataset should have already been indexed.
validation_dataset : ``Dataset``, optional, (default = None).
A ``Dataset`` to evaluate on. The dataset should have already been indexed.
- patience : int, optional (def... | [Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_re... | Initialize a new object with the given parameters. Required parameter. This class is called to initialize the object with the given . Initialize the object with a cuda cuda device or cuda device. | in `from_params` the default value is 2 if not specified, so how would patience be `None`? I think that could only be the case if people explicitly put `"patience": null` in the config file? I don't know that I like the idea of having nulls in the config file |
@@ -115,13 +115,14 @@ Rails.application.configure do
config.action_mailer.delivery_method = :smtp
config.action_mailer.perform_deliveries = true
+ sendgrid_api_key_present = ENV["SENDGRID_API_KEY"].present?
config.action_mailer.default_url_options = { host: protocol + config.app_domain }
ActionMailer::Ba... | [app_domain,perform_deliveries,new,formatter,log_tags,compile,headers,freeze,consider_all_requests_local,asset_host,log_formatter,cache_classes,use,deprecation,dump_schema_after_migration,logger,fallbacks,enabled,to_i,force_ssl,delivery_method,eager_load,default_url_options,read_encrypted_secrets,delete_suffix,present?... | This method is called from the Rails Rails application when it is not installed. | Should this _actually_ be `"apikey"`? |
@@ -34,7 +34,7 @@ public class FruitResource {
@GET
@Produces(MediaType.APPLICATION_JSON)
public CompletionStage<JsonArray> listFruits() {
- return client.query("SELECT * FROM fruits").thenApply(pgRowSet -> {
+ return client.query("SELECT * FROM fruits").thenApplyAsync(pgRowSet -> {
... | [FruitResource->[setupDb->[join],listFruits->[add,JsonArray,thenApply,toJson],toJson->[put,getString]]] | List all fruits that have a . | We don't recommend using async without executor as it may behave very differently in containers. But as it's an IT, should not matter too much. |
@@ -44,7 +44,7 @@ public abstract class SCMRevisionState implements Action {
So instead, here we opt to a design where we tell SCM upfront about what we are comparing
against (baseline), and have it give us the new state and degree of change in PollingResult.
*/
-
+ @SuppressFBWarnings("MS_SHOULD... | [SCMRevisionState->[None]] | The SCMRevisionState class is used to store the state of the given . | This looks like it should be final. |
@@ -77,7 +77,7 @@ class ContentTwigExtension extends AbstractExtension implements ContentTwigExten
];
}
- public function load($uuid)
+ public function load($uuid, bool $includeExtensions = true, array $includedProperties = null)
{
if (!$uuid) {
return;
| [ContentTwigExtension->[loadParent->[load],load->[load]]] | Returns a list of functions that can be used to load a node in the content system. | another possibility would be a `array $properties` parameter that matches the semantic of the `properties` param of the `page_selection` |
@@ -16,6 +16,7 @@ namespace Pulumi.Automation
public PulumiFnInline(Func<CancellationToken, Task<IDictionary<string, object?>>> program)
{
this._program = program;
+ this.DiscoveryAssembly = Assembly.GetEntryAssembly();
}
internal override async Task<Excepti... | [PulumiFnInline->[InvokeAsync->[ConfigureAwait],_program]] | Invoke the exception program asynchronously. | I waffled a bit on what the delegate-driven inline program should use as the default assembly, if anything. It can be hard to nail down a single assembly since delegates can be chained and added to from different assemblies and we don't know where it was started. I wanted to do `GetCallingAssembly()` in the `PulumiFn.C... |
@@ -18,18 +18,6 @@ import User from "discourse/models/user";
import showModal from "discourse/lib/show-modal";
const Post = RestModel.extend({
- // TODO: Remove this once one instantiate all `Discourse.Post` models via the store.
- siteSettings: computed({
- get() {
- return Discourse.SiteSettings;
- }... | [No CFG could be retrieved] | Imports a single post model. Replies if the topic has been deleted. | These old ways of achieving the same thing are no longer necessary. |
@@ -3854,8 +3854,14 @@ zpool_history_unpack(char *buf, uint64_t bytes_read, uint64_t *leftover,
/* add record to nvlist array */
(*numrecords)++;
if (ISP2(*numrecords + 1)) {
- *records = realloc(*records,
+ tmp = realloc(*records,
*numrecords * 2 * sizeof (nvlist_t *));
+ if (tmp == NULL) {
+ ... | [No CFG could be retrieved] | unpacks the buffer of nvlists unpacking each record into records and stores the resulting records Retrieves the history of a command from a zpool. | I believe we need to decrements `numrecords` in the error case. This should only be incremented when we've successfully add a new record to `records`. |
@@ -314,8 +314,12 @@ def handle_secretrequest(
already_received_secret_request = initiator_state.received_secret_request
+ # lock.amount includes the fees, transfer_description.amount is the actual
+ # payment amount, for the transfer to be valid and the unlock allowed the
+ # target must receive an a... | [send_lockedtransfer->[send_lockedtransfer,get_initial_lock_expiration],handle_onchain_secretreveal->[events_for_unlock_lock],state_transition->[handle_secretrequest,handle_onchain_secretreveal,handle_offchain_secretreveal,handle_block],try_new_route->[next_channel_from_routes],handle_offchain_secretreveal->[events_for... | Handles a secret request. This function returns a transition result that will transition to the next node if there is no next. | Shouldn't the `state_change.amount` be equal to `initiator_state.transfer_description.amount` provided that all mediators on the route to target deducted their fees? why would a mediator not deduct their fee? |
@@ -0,0 +1,13 @@
+# coding=utf-8
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Co... | [No CFG could be retrieved] | No Summary Found. | Does this version need to be updated? |
@@ -222,6 +222,15 @@ class BatchedStreamingWrite<ErrorT, ElementT>
/** The list of unique ids for each BigQuery table row. */
private transient Map<String, List<String>> uniqueIdsForTableRows;
+ private @Nullable DatasetService datasetService;
+
+ private DatasetService getDatasetService(PipelineOptio... | [BatchedStreamingWrite->[getDatasetService->[getDatasetService]]] | Start bundle. | nit: should this be transient? |
@@ -39,6 +39,18 @@ public class ValueProviderUtils {
}
+ static org.mule.runtime.extension.api.values.ValueBuilder cloneAndEnrichValue(org.mule.runtime.api.value.Value value,
+ Map<Integer, String> partOrderMapping) {
+ Value sdkV... | [ValueProviderUtils->[cloneAndEnrichValue->[cloneAndEnrichValue]]] | Creates a new instance of the Class that will be used to build a new object from the Clones and enriched values of the . | why is this needed? Doesn't the need for this disappears if adaptation is done in a single place and in the correct direction? |
@@ -14,9 +14,13 @@ def download(app, ref, package_ids, remote, recipe, recorder, remotes):
hook_manager.execute("pre_download", reference=ref, remote=remote)
try:
- ref = remote_manager.get_recipe(ref, remote)
+ if not ref.revision:
+ ref = remote_manager.get_latest_recipe_revision(... | [_download_binaries->[_download->[info,get_package,str,PackageReference],_download,ThreadPool,join,close,info,map],download->[get_recipe,conanfile,list,keys,info,_download_binaries,search_packages,RecipeNotFoundException,str,load_basic,retrieve_exports_sources,ScopedOutput,isinstance,warn,ref_layout,full_str,execute]] | Download a single package. | This ``cache.get_recipe_revision(ref)`` when ref contains revision, and that is supposed to return just 1 revision, the passed one, is a bit confusing to read. Maybe is worth to add an explicit ``bool recipe_revision_exist(ref)`? |
@@ -19,11 +19,6 @@ def _bundle(rel_path):
return Bundle(pc)
-def _globs(rel_path):
- pc = ParseContext(rel_path=rel_path, type_aliases={})
- return Globs(pc)
-
-
class JvmAppTest(TestBase):
def test_simple(self):
binary_target = self.make_target(":foo-binary", JvmBinary, main="com.example.... | [JvmAppTest->[test_binary_via_dependencies->[create_app],test_binary_via_binary->[create_app],test_not_a_binary->[create_app],create_app->[_bundle],test_too_many_binaries_via_deps->[create_app],test_too_many_binaries_mixed->[create_app],test_no_binary->[create_app],test_degenerate_binaries->[create_app]],BundleTest->[t... | Return a Globs object for the given path. | I removed all uses of `Globs` and the concept of globs in general from this file because this is a unit test and we expect the engine to have already expanded all globs. That expansion of globs cannot be tested in this unit test because it happens in `engine/legacy/structs.py`. |
@@ -57,9 +57,11 @@ class CompilerArgsGenerator(Generator):
# Necessary in the "cl" invocation before specify the rest of linker flags
flags.append(visual_linker_option_separator)
- the_os = (self.conanfile.settings.get_safe("os_build") or
- self.conanfile.settings.get... | [CompilerArgsGenerator->[content->[visual_runtime,sysroot_flag,get_safe,format_include_paths,format_frameworks,append,extend,architecture_flag,format_library_paths,format_framework_paths,cppstd_flag,build_type_define,format_libraries,join,_libcxx_flags,format_defines,rpath_flags,build_type_flags],compiler->[get_safe],_... | Returns the content of the command line. Returns a string with the flags that should be included in the build_info. | This is also a bit complicated to read, you already checked the ``settings_build`` in the ``get_build_os_arch()`` call. |
@@ -640,7 +640,7 @@ RtpsUdpDataLink::associated(const RepoId& local_id, const RepoId& remote_id,
RtpsWriter_rch writer = rw->second;
g.release();
writer->update_max_sn(remote_id, max_sn);
- writer->add_reader(make_rch<ReaderInfo>(remote_id, remote_durable));
+ writer->add_reader(make_rch<... | [No CFG could be retrieved] | Add locators to the list of locators to be added. - - - - - - - - - - - - - - - - - -. | Can we just rename this variable to participant_flags since that makes it clear what we're dealing with? |
@@ -486,7 +486,8 @@ namespace System.Data.SqlTypes
// m_data1 = *pInt++; // lo part
// m_data2 = *pInt++; // mid part
- int[] bits = decimal.GetBits(value);
+ Span<int> bits = stackalloc int[4];
+ decimal.GetBits(value, bits);
uint sgnscl;
... | [SqlDecimal->[BActualPrec->[BGetPrecUI4,BGetPrecUI8],DivByULong->[AssertValid],AddULong->[FGt10_38],MpDiv1->[MpNormalize],MakeInteger->[DivByULong,AssertValid],SetToZero->[AssertValid],GetHashCode->[CalculatePrecision,AdjustScale],EComparison->[AssertValid,LAbsCmp,AdjustScale],SqlInt32->[AssertValid],FGt10_38->[ToStrin... | This class is used to create an object from a binary string. Creates a new object from the given integer. | Nit: do we need an assert that `GetBits` returns 4? I think the call site is fine but was curious as to what best practice dictates. |
@@ -225,10 +225,10 @@
corners = [bottomLeft, topLeft, topRight];
}
- var x1 = (originalImgW / 2) + corners[1][0];
- var y1 = (originalImgH / 2) + corners[1][1];
- var x2 = (originalImgW / 2) + corners[2][0];
- var y2 = (originalImgH / 2) + corners[0][1];
+ var x1 = ((zoomAffectedUnrotatedIm... | [No CFG could be retrieved] | finds the corners of the box that are not rotated Get the data of the annotation. | I suspect the "unzoom" should happen before the translation. (In general translations should happen first/last) |
@@ -192,6 +192,10 @@ public class DeployVMCmd extends BaseAsyncCreateCustomIdCmd implements SecurityG
+ " Example: dhcpoptionsnetworklist[0].dhcp:114=url&dhcpoptionsetworklist[0].networkid=networkid&dhcpoptionsetworklist[0].dhcp:66=www.test.com")
private Map dhcpOptionsNetworkList;
+ @Parameter(n... | [DeployVMCmd->[execute->[getStartVm,getCommandName],getAccountName->[getAccountName],getDomainId->[getDomainId]]] | get the account name. | Come on! Do not give a name ending in list for an attribute that is a map. It is misleading. What is the structure of this attribute? A map of maps?! |
@@ -111,7 +111,14 @@ func indexHandler(httpPathPrefix string, content *IndexPageContent) http.Handler
}
}
-func configHandler(actualCfg interface{}, defaultCfg interface{}) http.HandlerFunc {
+func (cfg *Config) configHandler(actualCfg interface{}, defaultCfg interface{}) http.HandlerFunc {
+ if cfg.CustomConfigHa... | [GetContent->[Lock,Unlock],AddLink->[Lock,Unlock],Path,MetadataHandler,NewGaugeVec,RemoteReadHandler,Merge,With,NewAPI,Wrap,Handler,Error,NewRouter,WithPrefix,New,YAMLMarshalUnmarshal,GetContent,Funcs,MustCompile,Methods,Join,Execute,Must,NewHistogramVec,DiffConfig,WriteYAMLResponse,Get,Register,Query,Use,NewWallTimeMi... | ×ðððððððð NewQuerierHandler returns a handler that can be used to fulfill the querier service. | I'm curious (again) why this needs to be lazy/late evaluated (Not a leading question, genuinely curious) - might be nice not to have to do this unless really necessary, as there becomes a burden to support dynamically swapping out the provider. I can see that downstream implementations would have to be careful to not e... |
@@ -359,6 +359,7 @@ class SimpleCodegenTask(Task):
synthetic_target = self.context.add_new_target(
address=self._get_synthetic_address(target, synthetic_target_dir),
target_type=synthetic_target_type,
+ type_alias=synthetic_target_type.alias(),
dependencies=synthetic_extra_dependencies,
... | [SimpleCodegenTask->[execute->[codegen_targets,get_fingerprint_strategy,_validate_sources_globs,_do_validate_sources_present],_inject_synthetic_target->[synthetic_target_dir,synthetic_target_extra_dependencies,synthetic_target_type,_get_synthetic_address,synthetic_target_extra_exports],_capture_sources->[synthetic_targ... | Create a synthetic target and return a synthetic target. This method is called by the build - graph. It will walk the transitive dependee. | This is assuming the target type has defined an `alias` classmethod, which many do, but not all. Could we add a check with `hasattr` here? |
@@ -0,0 +1,8 @@
+"""Shared logic between our three mypy parser files.
+"""
+
+
+def special_function_elide_names(name: str) -> bool:
+ if name == "__init__" or name == "__new__":
+ return False
+ return name.startswith("__") and name.endswith("__")
| [No CFG could be retrieved] | No Summary Found. | Style nit: In single-line docstrings, we keep both `"""`s on the same line (e.g. `"""Doc string."""`). |
@@ -122,7 +122,7 @@ class MastheadForm extends ContextSettingsForm {
* @copydoc ListbuilderHandler::deleteEntry()
*/
function deleteEntry($request, $rowId) {
- if (isset($this->categories[$rowId['name']])) unset($this->categories[$rowId['name']]);
+ if (isset($this->categories[$rowId])) unset($this->categorie... | [MastheadForm->[fetch->[getSite,assign,getSetting],updateEntry->[insertEntry,deleteEntry],initData->[getContext,getData,getEnabled,setData,getPath],execute->[getContext,updateObject,getData,getUserVar,getEnabled,setData,setEnabled]]] | Delete a category entry. | this was working before? |
@@ -522,6 +522,11 @@ module.exports = JhipsterServerGenerator.extend({
this.camelizedBaseName = _.camelize(this.baseName);
this.slugifiedBaseName = _.slugify(this.baseName);
this.lowercaseBaseName = this.baseName.toLowerCase();
+
+ this.mainClass = _.capital... | [No CFG could be retrieved] | Configuration of the application. The configuration for the jhipster package. | We need to do this check for angular app name ad well, currently we always append App to basename for that |
@@ -31,8 +31,9 @@ class Context(DotDict, threading.local):
The `Context` is a `DotDict` subclass, and can be instantiated the same way.
Args:
- - *args (Any):
- - *kwargs (Any):
+ - *args (Any): arguments to provide to the `DotDict` constructor (e.g.,
+ an initial dictionary)... | [Context->[__call__->[copy,clear,update],__init__->[super,update]],Context] | Initialize a sequence with a sequence of sequence numbers. | I'm back and forth on whether this should be set here or in the flow runner |
@@ -466,9 +466,11 @@ func (r *regionsInfo) randLeaderRegion(storeID uint64) *metapb.Region {
}
// TODO: if costs too much time, we may refactor the rand leader region way.
- if cost := time.Now().Sub(start); cost > maxRandRegionTime {
+ cost := time.Now().Sub(start)
+ if cost > maxRandRegionTime {
log.Warnf("s... | [heartbeatVersion->[addRegion,innerGetRegion,removeRegion],update->[removeStoreRegion],getStores->[clone],updateStoreStatus->[leaderRegionCount,regionCount],getStore->[clone],heartbeat->[heartbeatVersion,heartbeatConfVer,update],heartbeatConfVer->[updateRegion],removeRegion->[remove],clone->[clone]] | randLeaderRegion returns a random leader region. | Seems warn log can be removed? |
@@ -100,10 +100,10 @@ DEFINE_RUN_ONCE_STATIC(init_info_strings)
add_seeds_string("getrandom-syscall");
#endif
#ifdef OPENSSL_RAND_SEED_DEVRANDOM
- add_seeds_stringlist("random-device", { DEVRANDOM, NULL });
+ add_seeds_stringlist("random-device", DEVRANDOM);
#endif
#ifdef OPENSSL_RAND_SEED_EG... | [No CFG could be retrieved] | Adds seeds to the list of strings that can be used to generate random number generator. function to return the name of the given n - tuple. | @levitte I guess that `add_seeds_stringlist()` went into 096978f09908 without ever being expanded, let alone compiled? |
@@ -1008,3 +1008,7 @@ def extract_type_maps(graph: Graph) -> Dict[str, Dict[Expression, Type]]:
# This is used to export information used only by the testmerge harness.
return {id: state.type_map() for id, state in graph.items()
if state.tree}
+
+
+def is_verbose(manager: BuildManager) -> bool:
+... | [find_symbol_tables_recursive->[find_symbol_tables_recursive,update],reprocess_nodes->[verify_dependencies],update_single_isolated->[update],lookup_target->[lookup_target]] | Extract type maps from the given graph. | I think this should use `>=` instead of `>` for this to be an identical transformation if `DEBUG_FINE_GRAINED` is false. |
@@ -744,4 +744,12 @@ public class TypeConverterDelegatingAdvancedCache<K, V> extends AbstractDelegati
return returned;
}
+ @Override
+ public AdvancedCache<K, V> lockAs(Object lockOwner) {
+ AdvancedCache<K, V> returned = super.lockAs(lockOwner);
+ if (returned != this && returned instanceof ... | [TypeConverterDelegatingAdvancedCache->[replaceAll->[replaceAll,convertFunction],convertFunction->[boxKey,unboxKey,unboxValue],compute->[boxKey,compute,convertFunction,unboxValue],cacheEntrySet->[TypeConverterEntrySet,cacheEntrySet],computeIfAbsent->[computeIfAbsent,boxKey,convertFunction,unboxValue],remove->[boxValue,... | Override withSubject to add the subject to the cache if it is not already present. | why isn't the `entryFactory` copied simply in the wrapper function? |
@@ -44,13 +44,13 @@ namespace System.Xml
public abstract partial class XmlWriter : IDisposable
{
// Helper buffer for WriteNode(XmlReader, bool)
- private char[] _writeNodeBuffer;
+ private char[]? _writeNodeBuffer;
// Constants
private const int WriteNodeBufferSize ... | [XmlWriter->[WriteNmToken->[WriteString],WriteElementString->[WriteStartElement,WriteElementString,WriteEndElement,WriteString],WriteName->[WriteString],WriteNode->[WriteAttributes,WriteEndElement,WriteStartAttribute,WriteEntityRef,WriteCData,WriteEndAttribute,WriteStartElement,WriteComment,WriteFullEndElement,WriteCha... | Abstract class for XML writers that writes out the specified start tag and associates it with the WriteStartElement implements the XML - RPC interface. | In all above overloads `XmlWriterSettings settings` is nullable |
@@ -47,8 +47,10 @@ class GiftCard(CountableDjangoObjectType):
@traced_resolver
def resolve_user(root: models.GiftCard, info):
requestor = get_user_or_app_from_context(info.context)
- if requestor_has_access(requestor, root.user, AccountPermissions.MANAGE_USERS):
- return root.user
+... | [GiftCard->[resolve_user->[requestor_has_access,PermissionDenied,get_user_or_app_from_context],resolve_code->[has_perm],String,Field]] | Resolve a user and code. | `traced_resolver` should only be used in more complex resolvers or when fetching relations, should be dropped here |
@@ -151,3 +151,15 @@ def execute(shell_cmd):
logger.error('Error output from %s:\n%s', base_cmd, err)
return (err, out)
+
+def list_hooks(dir_path):
+ """List paths to all hooks found in dir_path in sorted order.
+
+ :param str dir_path: directory to search
+
+ :returns: `list` of `str`
+ :r... | [post_hook->[append,info,_run_hook],_run_hook->[execute],deploy_hook->[renew_hook],run_saved_post_hooks->[info,_run_hook],renew_hook->[info,_run_hook,warning,join],validate_hook->[split,\n,HookCommandNotFound,format,exists,_prog],_prog->[exe_exists,basename,path_surgery],pre_hook->[info,_run_hook,add],validate_hooks->[... | Execute a command. | This is a nit, and very unlikely something we should go through the effort to "fix": In python, sorted() prioritizes capitalized characters, as they appear in ASCII table but shells give lowercase a priority, so filesystem listing gives different results than sorted(). |
@@ -135,9 +135,11 @@ func doArchive(r *ArchiveRequest) (*models.RepoArchiver, error) {
if err == nil {
if archiver.Status == models.RepoArchiverGenerating {
archiver.Status = models.RepoArchiverReady
- return archiver, models.UpdateRepoArchiverStatus(ctx, archiver)
+ if err = models.UpdateRepoArchiverStatu... | [GetArchiveName->[ReplaceAll,String],Commit,UpdateRepoArchiverStatus,Close,CreateArchive,CloseWithError,Is,RepoPath,Has,Error,Stat,MatchString,OpenRepository,Save,IsCommitExist,GetRepoArchiver,CreateUniqueQueue,New,GetBranchCommitID,Errorf,RelativePath,MustCompile,Trace,HasSuffix,TxDBContext,IsTagExist,IsBranchExist,Cr... | doArchive archives a single branch into a repository. OpenRepository opens a git repository and creates it if it doesn t already exist. | Need when archive already exist in storage, but for some reason the record in db not founded(so it created within tx session and then all changes rollbacked here). |
@@ -14,11 +14,14 @@ import (
var (
// This variable will allow us to add a test so that if the mappings.NodeState.Index
// changes we might need to add some migration bits over here
- a2CurrentNodeStateIndex = "node-state-5"
+ a2CurrentNodeStateIndex = "node-state-6"
- // The previous NodeState index: This chang... | [migrateBerlinToCurrent->[finish],migrateNodeStateToCurrent->[finish,updateErr,taskCompleted,update]] | New returns a new status object from the given variable. Start is a helper function that is called when the migration is started. It is called by. | Adding a new migration from node-state-5 to node-state-6. |
@@ -48,10 +48,11 @@ def test_generalization_across_time():
"""Test time generalization decoding
"""
from sklearn.svm import SVC
- from sklearn.linear_model import RANSACRegressor, LinearRegression
+ from sklearn.kernel_ridge import KernelRidge
from sklearn.preprocessing import LabelEncoder
... | [test_decoding_time->[make_epochs,predict],test_generalization_across_time->[make_epochs,SVC_proba]] | Test time generalization across time. missing - 1 - 1 - 1 - 1 - 1 - 1 - 1 - 1 - Missing key - value pairs. Test for the case where the scores are not equal to the epochs and the test times are Score a single node in the model with a sequence of epochs. | KR is faster than Ransac and output the same dimensionality. |
@@ -78,8 +78,14 @@ describe Discourse do
let(:plugin1) { plugin_class.new.tap { |p| p.enabled = true; p.path = "my-plugin-1" } }
let(:plugin2) { plugin_class.new.tap { |p| p.enabled = false; p.path = "my-plugin-1" } }
- before { Discourse.plugins.append(plugin1, plugin2) }
- after { Discourse.plugins.... | [old_method_caller->[old_method],old_method_caller,assert_readonly_mode_disabled] | requires that Discourse. base_url and Discourse. base_port are set Requires that the plugin is installed and that the plugin is installed. | Doesn't this change the behaviour of the assertion? `contain_exactly` asserts that the array contains only the two plugins while the latter asserts that the array includes the given plugins but does not ensure it does not contain other plugins. |
@@ -173,6 +173,17 @@ class ShippingMethod(ModelWithMetadata):
)
+class ShippingMethodZipCode(models.Model):
+ shipping_method = models.ForeignKey(
+ ShippingMethod, on_delete=models.PROTECT, related_name="zip_codes"
+ )
+ start = models.CharField(max_length=32)
+ end = models.CharField(m... | [ShippingMethodQueryset->[applicable_shipping_methods_for_instance->[applicable_shipping_methods],applicable_shipping_methods->[applicable_shipping_methods_by_channel,_applicable_price_based_methods,_applicable_weight_based_methods]],ShippingMethod->[__repr__->[_get_weight_type_display]]] | Creates a Field object for the given object. Additional fields for adding a minimum and maximum order price. | The value which you get for the `end` can be blank/null. Not sure if the field will be able to handle it. |
@@ -61,7 +61,15 @@ public class NettyFutureInstrumentation implements TypeInstrumentation {
public static void wrapListener(
@Advice.Argument(value = 0, readOnly = false)
GenericFutureListener<? extends Future<?>> listener) {
- listener = FutureListenerWrappers.wrap(Java8BytecodeBridge.c... | [NettyFutureInstrumentation->[typeMatcher->[named,implementsInterface],RemoveListenersAdvice->[wrapListener->[getWrapper]],AddListenersAdvice->[wrapListener->[currentContext,wrap]],RemoveListenerAdvice->[wrapListener->[getWrapper]],classLoaderOptimization->[hasClassesNamed],AddListenerAdvice->[wrapListener->[currentCon... | Wraps a listener in a FutureListener. | I think it's good to add the phrasing "We only want to wrap user callbacks" |
@@ -163,6 +163,7 @@ public class MuleProperties {
public static final String OBJECT_CONNECTIVITY_TESTING_SERVICE = "_muleConnectivityTestingService";
public static final String OBJECT_CONFIGURATION_COMPONENT_LOCATOR = "_muleConfigurationComponentLocator";
public static final String OBJECT_POLICY_MANAGER = "_mu... | [No CFG could be retrieved] | Returns the name of the object that should be used to create the MuleContext. | Is this a `provider`, `registry` or `manager`? I see all three terms are used. I wouldn't use `manager` personally, I prefer `provider`, although `registry` is better than `manager. |
@@ -123,7 +123,7 @@ namespace System.DirectoryServices.Protocols
}
}
- internal static int StartTls(ConnectionHandle ldapHandle, ref int ServerReturnValue, ref IntPtr Message, IntPtr ServerControls, IntPtr ClientControls) => Interop.Ldap.ldap_start_tls(ldapHandle, ref ServerReturnValue, r... | [LdapPal->[CreateDirectorySortControl->[ldap_create_sort_control],ParseResultReferral->[ldap_parse_result_referral],PtrToString->[PtrToStringAnsi],FreeMessage->[ldap_msgfree],GetLastErrorFromConnection->[ldap_get_option_int,LDAP_OPT_ERROR_NUMBER],RenameDirectoryEntry->[ldap_rename],BindToDirectory->[LDAP_SASL_SIMPLE,ld... | This is a wrapper for the LDAP method that binds to a directory. | I know a little bit more now, so I think I shouldn't be modifying the signature of this method, but should just pass the relevant arguments from `LdapPal.StartTls()` to `Interop.Ldap.ldap_start_tls()`, and ignore the rest. Is that correct? |
@@ -279,6 +279,18 @@ describe('Layout', () => {
expect(div.children.length).to.equal(0);
});
+ it('layout=flex-item', () => {
+ div.setAttribute('layout', 'flex-item');
+ div.setAttribute('width', 100);
+ div.setAttribute('height', 200);
+ expect(applyLayout_(div)).to.equal(Layout.FLEX_ITEM);
+ ... | [No CFG could be retrieved] | Tests that a div has a layout and should have natural dimensions. The AMPAL extension for AMPAL. | We need another test (or modify this one) to show that width/height are set. |
@@ -764,6 +764,9 @@ ShaderInfo generate_shader(std::string name, u8 material_type, u8 drawtype,
else
shaders_header += "0\n";
+ if (g_settings->getBool("tone_mapping"))
+ shaders_header += "#define ENABLE_TONE_MAPPING\n";
+
if(pixel_program != "")
pixel_program = shaders_header + pixel_program;
if(vertex... | [No CFG could be retrieved] | The shader that is used to render the water is defined by the user. Create the high level shaders for the missing vertex pixel and geometry shaders. | Doesn't this have to be #define ENABLE_TONE_MAPPING 1 for ATI shaders? |
@@ -221,6 +221,18 @@ main(int argc, char **argv)
" %" PRIu64 " rc: %d\n",
pool_handles[i][j].cookie, rc);
}
+
+ uuid_unparse(c_uuid, cstr);
+ printf("Opening container %s\n",cstr);
+ rc = daos_cont_open(pool_handles[i][j], c_uuid, DAOS_COO_RW,
+ &cont_handles[i][j], NULL, NULL);
+... | [main->[cleanup_handles,parse_pool_handles,print_usage]] | - - - - - - - - - - - - - - - - - - This function creates the container and pool handles. This method is called by the daemon when it is unable to create a container. | (style) space required after that ',' (ctx:VxV) |
@@ -210,7 +210,8 @@ class AmpVideo extends AMP.BaseElement {
this.propagateAttributes(ATTRS_TO_PROPAGATE_ON_LAYOUT, this.video_,
/* opt_removeMissingAttrs */ true);
- this.getRealChildNodes().forEach(child => {
+ const children = scopedQuerySelectorAll(this.element, 'source, track');
+ Array.pr... | [No CFG could be retrieved] | Attaches a callback to the video element. Adds video children to the video element. | do children = toArray(...) then use forEach ( toArray is in type.js) |
@@ -0,0 +1,15 @@
+package org.jboss.resteasy.reactive.client.handlers;
+
+import org.jboss.resteasy.reactive.client.impl.RestClientRequestContext;
+import org.jboss.resteasy.reactive.client.spi.ClientRestHandler;
+
+/**
+ * This Handler is invoked before ClientResponseFilters handler. It changes the abort handler chain... | [No CFG could be retrieved] | No Summary Found. | I just looked at the server case and in that case (in accordance to the spec) the following happens: If there is an exception mapper, then the response filters **are** executed. If there is no exception mapper, then the response filter are **not** executed. Is there are a good reason to follow a different strategy here... |
@@ -96,7 +96,7 @@ function item_redir_and_replace_images($body, $images, $cid) {
function localize_item(&$item){
$extracted = item_extract_images($item['body']);
- if($extracted['images'])
+ if ($extracted['images'])
$item['body'] = item_redir_and_replace_images($extracted['body'], $extracted['images'], $item['... | [localize_item->[attributes],get_responses->[get_id],conversation->[add_thread,get_template_data]] | Localize an item activities - > activity - > activity - > activity - > activity - > activity - > Parses the link of an object. This function is used to translate a link tag to a translation string. SELECT * FROM item - contact - contact parse a node in the tree and add any marked images to the item add sparkle links to... | Standards: Please add a space before braces. |
@@ -56,7 +56,7 @@ public class CompositeConfiguration extends AbstractConfiguration {
}
@Override
- protected Object getInternalProperty(String key) {
+ public Object getInternalProperty(String key) {
Configuration firstMatchingConfiguration = null;
for (Configuration config : config... | [CompositeConfiguration->[containsKey->[containsKey],addConfigurationFirst->[addConfiguration]]] | Gets the property from the configuration list. | Is it better to do a non-empty check and remove the try block? |
@@ -33,9 +33,9 @@ class RawBrainVision(BaseRaw):
----------
vhdr_fname : str
Path to the EEG header file.
- montage : str | None | instance of Montage
- Path or instance of montage containing electrode positions.
- If None, sensor locations are (0,0,0). See the documentation of
+ ... | [read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_check_hdr_version]] | Construct a BrainVision object from a given BrainVision EEG header A function to provide a way to specify the id of the special event that should be used. | True is not possible anymore |
@@ -506,6 +506,10 @@ export const adConfig = {
renderStartImplemented: true,
},
+ kuadio: {
+ renderStartImplemented: true,
+ },
+
ligatus: {
prefetch: 'https://ssl.ligatus.com/render/ligrend.js',
renderStartImplemented: true,
| [No CFG could be retrieved] | Provides a list of urls to preload and preload AMP. Provides a list of urls to the tags that are currently available on the page. | are you sure you are firing this method in your script? I couldn't get the listener to activate |
@@ -46,3 +46,13 @@ ALTER TABLE identity.config ADD COLUMN
id_token_expiry VARCHAR(4096)`)
return err
}
+
+// AddRotationTokenExpiryConfig adds expiry fields for the rotation token lifespan to the server config
+// DO NOT MODIFY THIS FUNCTION
+// IT HAS BEEN USED IN A RELEASED MIGRATION
+func AddRotationTokenExpiry... | [EnsureStack,ExecContext] | id_token_expiry VARCHAR ( 4096 ). | Just curious: how are pachyderm migrations maintained/tested? How did you know that this migration was necessary? Just deductive reasoning or did an automated test catch it somehow? |
@@ -275,6 +275,7 @@ if __name__ == "__main__":
'and "notice" (if available) field to {yaml_file} for each ' \
'missing license. Dependency List: [{dep_list}]'.format(
dep_list=','.join(sorted(no_licenses)), yaml_file=dep_url_yaml)
+ logging.error(how_to)
... | [execute->[pull_source_code,pull_from_url],pull_source_code->[pull_from_url],write_to_csv] | This function pulls license for all dependencies. Urls to maven repo for some dependencies. | error messages are printed out at L313, this is duplicate. |
@@ -267,3 +267,17 @@ def as_json(func):
return str(return_value)
return return_as_json
+
+
+def deferred_df_to_pcollection(df):
+ assert isinstance(df, DeferredBase), '{} is not a DeferredBase'.format(df)
+
+ # The proxy is used to output a DataFrame with the correct columns.
+ #
+ # TODO(BEAM-11064): O... | [progress_indicated->[run_within_progress_indicator->[ProgressIndicator]],ProgressIndicator->[__init__->[obfuscate]],to_element_list->[elements]] | A decorator convert python objects returned by callables to json string. | Is the proxy basically the `pcoll.element_type`? Will this be redundant? |
@@ -322,4 +322,8 @@ class FrozenOrderedSet(_AbstractOrderedSet[T]):
return cast(FrozenOrderedSet[T], super().symmetric_difference(*others))
def __hash__(self) -> int:
- return hash(self._items)
+ if self._hash is None:
+ self._hash = 0
+ for item in self._items.keys()... | [_AbstractOrderedSet->[intersection->[intersection],index->[index],symmetric_difference->[union],difference->[union]],OrderedSet->[pop->[pop],clear->[clear],update->[add]]] | Return a hash value for the list. | Good idea to do lazy hashing! |
@@ -212,10 +212,11 @@ public final class ErrorBuilder {
private final ErrorType errorType;
private final Message muleMessage;
private final List<Error> errors;
+ private final List<Error> suppressedErrors;
private ErrorImplementation(Throwable exception, String description, String detailedDescr... | [ErrorBuilder->[builder->[ErrorBuilder],ErrorImplementation->[toString->[toString]]]] | Creates an instance of Error based on the supplied parameters. Get the error type. | this will have to be considered in DataSense tests |
@@ -28,5 +28,6 @@
<% end %>
<%= render "shared/webcomponents_loader_script" %>
-<%= javascript_packs_with_chunks_tag "clipboardCopy", "articleForm", defer: true %>
<%= render "articles/v2_form", article: @article, organizations: @organizations, version: @version %>
+
+<%= javascript_packs_with_chunks_tag "clipboar... | [No CFG could be retrieved] | Renders the . | Changing the order shouldn't matter since it is deferred. Can you consistently get it working with this change in order? |
@@ -93,8 +93,7 @@ func eventsMapping(r mb.ReporterV2, info elasticsearch.Info, content []byte) err
continue
}
- // Write name here as full name only available as key
- event.MetricSetFields["name"] = name
+ event.MetricSetFields["id"] = id
r.Event(event)
}
| [Str,Int,Error,Dict,Apply,Unmarshal,Err,Event,Wrap,Bool,Put] | missing node schema. | Was this a "bug" before? |
@@ -0,0 +1,18 @@
+/*
+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com
+ * The software in this package is published under the terms of the CPAL v1.0
+ * license, a copy of which has been included with this distribution in the
+ * LICENSE.txt file.
+ */
+package org.mule.sdk.api.runtime.co... | [No CFG could be retrieved] | No Summary Found. | how is this related tho this pr? |
@@ -154,6 +154,7 @@ define([
--numberOfActiveRequestsByServer[request.serverKey];
request.state = RequestState.RECEIVED;
request.deferred.resolve(results);
+ requestLoadedEvent.raiseEvent();
};
}
| [No CFG could be retrieved] | Creates a new object that represents the state of the request and the priority function. cancelRequest - cancel a request. | To be consistent with `TaskProcessor`, should the `raiseEvent` should go before the `resolve`? |
@@ -43,6 +43,7 @@ type HomeFinder interface {
ServiceSpawnDir() (string, error)
SandboxCacheDir() string // For macOS
InfoDir() string
+ IsNonstandardHome() (bool, error)
}
func (b Base) getHome() string {
| [appDir->[Join],dirHelper->[Join,Home,getenv],deriveFromTemp->[Split,Unsplit,getenv],InfoDir->[getHome,CacheDir,appDir,RuntimeDir],SandboxCacheDir->[isIOS,appDir,Home],Unsplit->[Join],CacheDir->[Home,appDir,dirHelper],Normalize->[Unsplit,Split],Split->[Split],ConfigDir->[Home,sharedHome,appDir,dirHelper],DataDir->[Home... | getHome returns the home directory of the user. | Unrelated to this PR but having both `Home` and `getHome` in this struct hierarchy is weird. Did I get it correctly, that `getHome` is solely for getting "configured home" via either config or command line? |
@@ -258,8 +258,11 @@ int DH_set0_key(DH *dh, BIGNUM *pub_key, BIGNUM *priv_key)
dh->pub_key = pub_key;
}
if (priv_key != NULL) {
+ int bits = BN_num_bits(priv_key);
+
BN_clear_free(dh->priv_key);
dh->priv_key = priv_key;
+ dh->length = bits;
}
dh->dirty_cnt... | [EVP_PKEY_CTX_set_dhx_rfc5114->[EVP_PKEY_CTX_set_dh_rfc5114],dh_ffc_params_fromdata->[dh_get0_params]] | set 0 key. | It strikes me as a bit odd to use a temporary variable here when you don't up in the `if (q != NULL)` body. |
@@ -1308,9 +1308,9 @@ namespace cryptonote
std::vector<crypto::hash> tx_hashes{};
tx_hashes.resize(tx_blobs.size());
- cryptonote::transaction tx{};
for (std::size_t i = 0; i < tx_blobs.size(); ++i)
{
+ cryptonote::transaction tx{};
if (!parse_and_validate_tx_from_blob(tx_blobs[i], ... | [No CFG could be retrieved] | handles the incoming transactions and transactions that have been verified by the user. Add new transactions to the pool. | Crap. The internal memory gets freed every cycle, but there is no easier fix. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.