patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -227,7 +227,7 @@ function _conferenceWillJoin({ getState }, next, action) {
const { conference } = action;
const state = getState();
- const { callUUID } = state['features/base/config'];
+ const { callUUID, callHandle } = state['features/base/config'];
const url = getInviteURL(state);
con... | [No CFG could be retrieved] | Provides a way to handle the case where a specific is being dispatched. Returns the value of the which is being dispatched in the specified store. | Again, alphabetical sorting! I'll take care of this one during the merge. |
@@ -19,9 +19,18 @@ import org.jasig.cas.ticket.proxy.ProxyTicket;
* @author Misagh Moayyed
* @since 4.1
*/
+@Entity
+@DiscriminatorValue("PGT")
public final class ProxyGrantingTicketImpl extends TicketGrantingTicketImpl implements ProxyGrantingTicket {
private static final long serialVersionUID = -812690992... | [ProxyGrantingTicketImpl->[grantProxyTicket->[getId,updateServiceAndTrackSession,getCountOfUses,ProxyTicketImpl]]] | Creates a proxy granting ticket. Grant proxy ticket. | Could we use `ProxyGrantingTicket.PREFIX` instead? |
@@ -360,9 +360,6 @@ class NodeController extends RestController implements ClassResourceInterface, S
$webspace = $this->getWebspace($request);
$template = $this->getRequestParameter($request, 'template', true);
- $isShadow = $this->getRequestParameter($request, 'shadowOn', false);
- $s... | [NodeController->[putAction->[getLanguage,getWebspace],getTreeForUuid->[getLanguage,getWebspace],postAction->[getLanguage,getWebspace],cgetAction->[getLanguage,getTreeForUuid,getWebspace,getNodesByIds],postTriggerAction->[getLanguage,getWebspace],putIndex->[getLanguage,getWebspace],getLocale->[getLanguage],getNodesById... | Updates a node request with the specified uuid. | Why did you have to remove these lines here? |
@@ -286,6 +286,7 @@ class AmpImaVideo extends AMP.BaseElement {
}
if (videoEvent == ImaPlayerData.IMA_PLAYER_DATA) {
this.playerData_ = /** @type {!ImaPlayerData} */ (eventData['data']);
+ this.element.dispatchCustomEvent(VideoEvents.LOADEDMETADATA);
return;
}
if (videoEvent == 'f... | [No CFG could be retrieved] | Sends a command to the player through postMessage. This method is used to send a command to the device. | > when two lines end mayhem. |
@@ -120,7 +120,9 @@ func NewRun(
}
cost := &assets.Link{}
- cost.Set(job.MinPayment)
+ if job.MinPayment != nil {
+ cost.Set(job.MinPayment)
+ }
for i, taskRun := range run.TaskRuns {
adapter, err := adapters.For(taskRun.TaskSpec, store)
| [Ended,Now,Duration,Merge,Uint32From,IsZero,Wrap,GetError,Set,NewRun,Add,MinimumContractPayment,PendingConfirmations,NewBig,ToInt,Started,MinContractPayment,Errorw,Unconfirmed,Infow,Cmp,GetTxReceipt,PendingBridge,PendingConnection,Errorf,ApplyResult,CreateJobRun,HasError,After,Sub,SetError,Text,NextTaskRun,Hex,MinConfs... | Creates a new run with the given job ID and a new run with the given job ID Requires that the payment is present for the runs that are required to run. | This works :+1: but looks to me like job.MinPayment should have a default value? |
@@ -174,7 +174,7 @@ public class Trash implements GobblinTrash {
* @throws IOException
*/
@Override
- public boolean moveToTrash(Path path) throws IOException {
+ public synchronized boolean moveToTrash(Path path) throws IOException {
Path fullyResolvedPath = path.isAbsolute() ? path : new Path(this.f... | [Trash->[moveToTrash->[Path,getParent,getWorkingDirectory,isAbsolute,mergePaths,mkdirs,rename,currentTimeMillis,exists,suffix],createTrashLocation->[Path,replaceAll,IllegalArgumentException,makeQualified,isAbsolute,ensureTrashLocationExists,toString,getHomeDirectory,info,containsKey],ensureTrashLocationExists->[Path,cr... | Move a file or directory to the trash. | please don't make this synchronized, it will slow down `Trash`. |
@@ -0,0 +1,5 @@
+class AddHiddenByCommentableUserToComments < ActiveRecord::Migration[5.2]
+ def change
+ add_column :comments, :hidden_by_commentable_user, :boolean, default: false
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Probably doesn't need an index right? |
@@ -513,6 +513,7 @@ class RemoteRepository:
self.chunkid_to_msgids = {}
self.ignore_responses = set()
self.responses = {}
+ self.async_responses = {}
self.ratelimit = SleepingBandwidthLimiter(args.remote_ratelimit * 1024 if args and args.remote_ratelimit else 0)
self.... | [handle_remote_line->[write],cache_if_remote->[RepositoryNoCache,RepositoryCache],RemoteRepository->[get_many->[call_many],call_many->[handle_error->[InvalidRPCMethod,PathNotAllowed,RPCError],UnexpectedRPCDataFormatFromServer,pop_preload_msgid,named_to_positional,handle_error,write,ConnectionClosed],__init__->[do_open-... | Initialize the object. Reads a sequence number from the server and returns it. TypeError is a cosmetic side effect of older borg servers. | call this `async_errors`? |
@@ -280,8 +280,6 @@ class NetworkTraceLoggingPolicy(SansIOHTTPPolicy):
_LOGGER.debug("Request method: %r", http_request.method)
_LOGGER.debug("Request headers:")
for header, value in http_request.headers.items():
- if header.lower() == 'authorization... | [HttpLoggingPolicy->[on_request->[_redact_query_param,_redact_header],on_response->[_redact_header]],ContentDecodePolicy->[deserialize_from_text->[_json_attemp],deserialize_from_http_generics->[deserialize_from_text],on_response->[deserialize_from_http_generics]]] | Logs HTTP request to the DEBUG logger. | This seems like a pretty fundamental change... or this is okay because this is only for debugging? |
@@ -192,6 +192,7 @@ public class Connection {
* @return
* A new {@link Connection} object that includes the transport encryption.
*/
+ @SuppressFBWarnings(value = "STATIC_IV", justification = "Not used. We should just remove it.")
public Connection encryptConnection(SecretKey sessionKey, ... | [Connection->[writeObject->[writeObject],readBoolean->[readBoolean],readKey->[readUTF],detectKeyAlgorithm->[detectKeyAlgorithm],verifyIdentity->[readObject,readKey,readUTF],close->[close],writeUTF->[writeUTF],encryptConnection->[Connection],readUTF->[readUTF],writeBoolean->[writeBoolean],writeKey->[writeUTF],readObject... | Creates a connection with the given session key and encryption algorithm. | Perhaps start deprecating this if we should remove it |
@@ -157,8 +157,7 @@ public class ReliefImageBreaker {
tracker.waitForAll();
return img;
} catch (final InterruptedException e) {
- ClientLogger.logQuietly("interrupted while loading images", e);
- return loadImage();
+ Thread.currentThread().interrupt();
}
}
... | [ReliefImageBreaker->[handleCommandLineArgs->[getValue],loadImage->[loadImage]]] | Load the image from the user s input. | This call was removed because it seemed wrong to recursively call into the same method after it was just interrupted. It now simply falls through to the failure case after re-interrupting the current thread. |
@@ -93,7 +93,7 @@ module CodeBlockParser
next if el.name == "code"
if el.search("code").empty?
- el.swap(Html::ParseEmoji.call(el.to_html))
+ el.swap(Html::ParseEmoji.call(el.to_html)) if el.parent.present?
else
el.children = escape_colon_emojis_in_codeblock(el.children.to_... | [escape_colon_emojis_in_codeblock->[escape_colon_emojis_in_codeblock]] | Recursively escape all emojis in a codeblock. | There is already a spec written for this feature which still passes for this change. From what I understand, this code was trying to perform swap on parentless text dom that mainly consists of newline ("\n\n\n\n\n"). It was never meant to work so they added a proper `RuntimeError` |
@@ -374,6 +374,17 @@ class TestBook(unittest.TestCase):
self.assertIsNotNone(output)
print(str(program))
+ def test_sampled_softmax_with_cross_entropy(self):
+ program = Program()
+ with program_guard(program):
+ logits = layers.data(name='Logits', shape=[256], dtype=... | [TestBook->[test_adaptive_pool3d->[adaptive_pool3d,data,assertIsNotNone,program_guard,Program],test_get_places->[get_places,print,str,assertIsNotNone,program_guard,Program],test_grid_sampler->[grid_sampler,print,data,str,assertIsNotNone,program_guard,Program],test_lod_reset->[print,data,str,lod_reset,program_guard,Prog... | Test image - to - sequence embedding and nce. | you are following very bad example... |
@@ -30,6 +30,8 @@ public interface PersistedService {
<T extends Persisted> String save(T model) throws ValidationException;
+ <T extends Persisted> String saveWithoutEvents(T model) throws ValidationException;
+
@Nullable
<T extends Persisted> String saveWithoutValidation(T model);
| [No CFG could be retrieved] | Save a model without validation. | I think it would be cleaner to move this method to the `InputService` interface, then you don't need to implement a redundant method in `PersistedServiceImpl`. |
@@ -194,14 +194,8 @@ def _detect_os_arch(result, output):
else:
output.error("Your ARM '%s' architecture is probably not defined in settings.yml\n"
"Please check your conan.conf and settings.yml files" % arch)
- elif the_os == 'AIX':
- proces... | [detect_defaults_settings->[_detect_os_arch,_detect_compiler_version],_sun_cc_compiler->[_execute],_gcc_compiler->[_execute],_get_default_compiler->[_clang_compiler,_sun_cc_compiler,_gcc_compiler],_detect_compiler_version->[_get_default_compiler,_get_profile_compiler_version],_clang_compiler->[_execute]] | Detects the OS and architecture and returns a list of strings. | Here you are overriding the value of `arch` to `None` if the processor isn't `powerpc` or `rs6000` |
@@ -267,15 +267,15 @@ static ossl_ssize_t bio_nread(BIO *bio, char **buf, size_t num_)
static int bio_write(BIO *bio, const char *buf, int num_)
{
+ if (!bio->init || buf == NULL || num_ <= 0)
+ return 0;
+
size_t num = num_;
size_t rest;
struct bio_bio_st *b;
BIO_clear_retry_flags(b... | [int->[bio_destroy_pair,OPENSSL_zalloc,BIO_clear_retry_flags,BIO_set_retry_read,OPENSSL_free,memcpy,bio_write,strlen,assert,BIO_set_retry_write,OPENSSL_malloc,ERR_raise],BIO_ctrl_reset_read_request->[BIO_ctrl],BIO_nread->[BIO_ctrl,ERR_raise],BIO_nread0->[BIO_ctrl,ERR_raise],BIO_nwrite->[BIO_ctrl,ERR_raise],BIO_ctrl_get... | write num bytes of data from bio to buf. | This cannot be moved here - we do not allow code before declarations. |
@@ -73,7 +73,11 @@ define([
var inertialCartesian = Matrix3.multiplyByVector(toInertial, cartesian, updateTransformCartesian3Scratch5);
var inertialDeltaCartesian = Matrix3.multiplyByVector(toInertialDelta, deltaCartesian, updateTransformCartesian3Scratch6);
- ... | [No CFG could be retrieved] | Computes the inertial and inertial vectors for a given time. northUpViewing from deep space. | Looking at this more closely, the result here gets fed straight into `Cartesian3.magnitude` and not used again. So I don't think the `invertVelocity` flag needs to be checked here at all, as magnitude yields an absolute value. The flag does need to be checked in the VVLH section below for `yBasis`. |
@@ -71,3 +71,8 @@ func (c *Context) CloneGlobalContextWithLogTags(g *libkb.GlobalContext, k string
c.NetContext = netCtx
return g.CloneWithNetContextAndNewLogger(netCtx)
}
+
+func (c *Context) ShallowCopy() *Context {
+ tmp := *c
+ return &tmp
+}
| [CloneGlobalContextWithLogTags->[CloneWithNetContextAndNewLogger,GetNetContext,WithLogTag],HasUI->[Sprintf],GetNetContext->[TODO]] | CloneGlobalContextWithLogTags clones the global context with log tags. | line 55 should be context.Background() |
@@ -41,9 +41,10 @@ public class Route implements Serializable, Iterable<Territory> {
private final List<Territory> steps = new ArrayList<>();
public Route(final List<Territory> territories) {
- this(
- territories.get(0),
- territories.subList(1, territories.size()).toArray(new Territory[territ... | [Route->[getMiddleSteps->[numberOfSteps],getFuelCostsAndIfChargedFlatFuelCost->[add],equals->[equals],join->[Route,add],getScrambleFuelCostCharge->[getMovementFuelCostCharge,Route,add],getFuelChanges->[add],getTerritoryBeforeEnd->[getStart,getTerritoryAtStep],getSteps->[numberOfSteps],anyMatch->[anyMatch],hasNoSteps->[... | Creates a route from a list of territory and a sequence of steps. Join two routes. | One downside I see is that we have two constructors now with differing implementations. Perhaps debatable, but it can be easier to reason about a class when there is one constructor that has logic and all the other constructors invoke that constructor. If there is an update for example to how this class is initialized,... |
@@ -616,7 +616,7 @@ def add_input_distortions(flip_left_right, random_crop, random_scale,
"""
jpeg_data = tf.placeholder(tf.string, name='DistortJPGInput')
- decoded_image = tf.image.decode_jpeg(jpeg_data)
+ decoded_image = tf.image.decode_jpeg(jpeg_data,channels=MODEL_INPUT_DEPTH)
decoded_image_as_float =... | [get_bottleneck_path->[get_image_path],get_random_distorted_bottlenecks->[get_image_path,run_bottleneck_on_image],get_random_cached_bottlenecks->[get_or_create_bottleneck],main->[create_inception_graph,get_random_distorted_bottlenecks,should_distort_images,get_random_cached_bottlenecks,cache_bottlenecks,add_final_train... | Adds the input distortions to the image. Decode jpeg with no padding. JPEG data distort_result . | Style nit: add a space between the `,` and `channels`. |
@@ -46,6 +46,15 @@ import org.jasig.cas.validation.Assertion;
*/
public interface CentralAuthenticationService {
+ /**
+ * The identifier of the application the client is trying to access. In almost all cases,
+ * this will be the URL of the application.
+ */
+ public static final String PROTO... | [No CFG could be retrieved] | Implements the CentralAuthenticationService interface. The ticketGrantingTicketId parameter specifies the ticket granting ticket that was associated with the. | These specific to the CAS protocol and shouldn't be here (they are also web-specific) |
@@ -68,8 +68,8 @@ $assets = array (
65 => '_inc/build/jetpack-connection-banner.min.js',
66 => '_inc/build/style.min.css',
67 => '_inc/build/masterbar/tracks-events.min.js',
- 68 => '_inc/build/sharedaddy/admin-sharing.min.js',
- 69 => '_inc/build/sharedaddy/sharing.min.js',
+ 68 => '_inc/build/sharingbutto... | [No CFG could be retrieved] | This module is used to load all JS files that are required by the Jetpack library JS files that are required for the menu - checkboxes. | This file is also automatically generated, so we don't need to update it here. |
@@ -23,10 +23,15 @@ import java.util.Collection;
import java.util.HashMap;
import java.util.List;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
public class HttpResponseHeaderBuilder
{
+ private Logger logger = LoggerFactory.getLogger(getClass());
private List<String> calculatedHeadersNam... | [HttpResponseHeaderBuilder->[addContentType->[addSimpleValue],setContentLenght->[removeHeader,addSimpleValue],addSimpleValue->[failIfHeaderDoesNotSupportMultipleValues],getHeader->[get]]] | Returns a collection of all the tokens in this cache. | logger should be static and final |
@@ -642,12 +642,11 @@ get_object_layout(struct pl_jump_map *jmap, struct pl_obj_layout *layout,
}
rc = 0;
- if (out_list != NULL) {
+ D_INIT_LIST_HEAD(&local_list);
+ if (out_list != NULL)
remap_list = out_list;
- } else {
- D_INIT_LIST_HEAD(&local_list);
+ else
remap_list = &local_list;
- }
dom_size =... | [No CFG could be retrieved] | Get the object layout of a node. - 1 ) - 1 ) - 1 ) - 1 ) - 1 ) - 1 ). | What does this actually fix? Just a false positive? |
@@ -175,8 +175,7 @@ namespace Microsoft.Win32.SafeHandles
}
internal static SafeFileHandle Open(string fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, long preallocationSize,
- Interop.Sys.Permissions openPermissions = Defa... | [SafeFileHandle->[DirectoryExists->[S_IFMT,S_IFDIR,Stat,Mode],GetCanSeek->[SEEK_CUR,LSeek,False,Undefined,Assert,True],CanLockTheFile->[Write,LOCK_SH,cifs,smb,nfs,Assert,smb2,LOCK_EX,TryGetFileSystemType],Init->[DeleteOnClose,Size,POSIX_FADV_SEQUENTIAL,S_IFMT,GetExceptionForIoErrno,CanLockTheFile,IO_DiskFull_Path_Alloc... | This method opens a file with the specified path mode access share and options. | Isn't this actually a bug? Shouldn't `createOpenException` be passed through instead of it being dropped and `null` being passed in on line 182? cc @adamsitnik @carlossanlop @Jozkee |
@@ -168,7 +168,7 @@ class KafkaExactlyOnceSink<K, V> extends PTransform<PCollection<KV<K, V>>, PColl
.apply("Assign sequential ids", ParDo.of(new Sequencer<>()))
.apply("Persist ids", GroupByKey.create())
.apply(
- String.format("Write to Kafka topic '%s'", spec.getTopic()),
+ String.... | [KafkaExactlyOnceSink->[ExactlyOnceWriter->[setup->[ensureEOSSupport],ShardWriter->[commitTxn->[ShardMetadata]]]]] | Expands the input collection into a new collection with the given number of shards. | Code executes on the graph build time. get() does not work for runtime values there (which would be the case for templates, right?). You can check if the value is available and not include it in the transform name. |
@@ -158,7 +158,6 @@ class Pruner(Compressor):
def __init__(self, model, config_list):
super().__init__(model, config_list)
- self.mask_dict = {}
def calc_mask(self, layer, config):
"""
| [QuantGrad->[backward->[quant_backward]],Compressor->[detect_modules_to_compress->[LayerInfo],compress->[detect_modules_to_compress]],Pruner->[_instrument_layer->[new_forward->[calc_mask]],export_model->[detect_modules_to_compress]]] | Initialize the pruning model. | input arguments are not consistent with other places |
@@ -120,10 +120,7 @@ public class PassivationManagerImpl extends AbstractPassivationManager {
}
int count = container.sizeIncludingExpired();
- Iterable<MarshallableEntry> iterable = () -> new IteratorMapper<>(container.iterator(), e -> {
- return marshalledEntryFactory.create(e.getKey(), e... | [PassivationManagerImpl->[passivateAsync->[doPassivate,isL1Key]]] | Passivate all entries in the cache to disk. | Unnecessary cast to `InternalCacheEntry` |
@@ -104,6 +104,16 @@ if (zen_not_null($action)) {
$template_split = new splitPageResults($_GET['page'], MAX_DISPLAY_SEARCH_RESULTS, $template_query_raw, $template_query_numrows);
$templates = $db->Execute($template_query_raw);
foreach ($templates as $template) {
+ ... | [bindVars,Execute,display_count,display_links,RecordCount,read,close,infoBox,insert_ID] | Displays a table of the nag objects that are related to a template. Print . | Not a fan of adding this `missing` element. Why not just call `continue` here, instead of later? Or unset the `$template` entry from the `$templates` array? |
@@ -176,7 +176,8 @@ class Llvm(CMakePackage, CudaPackage):
# Universal dependency
depends_on("python@2.7:2.8", when="@:4+python")
depends_on("python", when="@5:+python")
- depends_on("z3", when="@9:")
+ # While not required for @8:9, cmake can find a z3 on the system, causing failures:
+ depends... | [Llvm->[validate_detected_spec->[format],filter_detected_exes->[append,any],determine_version->[group,search,debug,Executable,compile,compiler],fc->[join,extra_attributes],codesign_check->[join_path,satisfies,Executable,copy,codesign,RuntimeError,mkdir,which,setup],f77->[join,extra_attributes],setup_run_environment->[j... | Creates a variant. Find all non - terminal non - terminal non - terminal non - terminal non - terminal non. | Could you add one thing here, since z3 is now on the required list back to 8, add the cmake define to use it: `LLVM_ENABLE_Z3_SOLVER`. In principle it should be on if found, but if we're requiring it, I'd rather have it in the build so we find out if something goes wrong with the dependency. |
@@ -630,6 +630,15 @@ export function getErrorReportData(
data['ae'] = accumulatedErrorMessages.join(',');
data['fr'] = self.location.originalHash || self.location.hash;
+ // TODO(https://github.com/ampproject/error-tracker/issues/129): Remove once
+ // all clients are serving a version with pre-throttling.
+ ... | [No CFG could be retrieved] | Determines if a JS tag is on the page and if it is non - AMP JS Determines if a JS engine is currently running on the stack. | I don't think we can ever remove this, since we don't wan the reporting function to throttle canary. |
@@ -88,6 +88,13 @@ public class WindowingIntTest {
@Before
public void before() {
+ final long currentTimeMillis = System.currentTimeMillis();
+
+ // set the batch to be in the middle of a ten second window
+ batch0SentMs = currentTimeMillis - (currentTimeMillis % TimeUnit.SECONDS.toMillis(10)) + (5001... | [WindowingIntTest->[assertTableCanBeUsedAsSource->[assertOutputOf]]] | This method is executed before any test. | nit: can be final. |
@@ -475,6 +475,16 @@ class Toolbox extends Component<Props, State> {
this.props.dispatch(toggleDialog(VideoQualityDialog));
}
+ /**
+ * Dispaches an action to toggle tile view.
+ *
+ * @private
+ * @returns {void}
+ */
+ _doToggleTileView() {
+ this.props.dispatch(toggle... | [No CFG could be retrieved] | Callback invoked to display the specified . Dispatches an action to toggle the local participant s raised hand state. | Is there a reason for this extra method? |
@@ -458,9 +458,14 @@ public class NewestSegmentFirstIterator implements CompactionSegmentIterator
this.segments = segments;
}
- public List<DataSegment> getSegments()
+ List<DataSegment> getSegments()
{
return segments;
}
+
+ int size()
+ {
+ return segments.size();
+ ... | [NewestSegmentFirstIterator->[findSegmentsToCompact->[findSegmentsToCompact],checkCompactableSizeForLastSegmentOrReturn->[findSegmentsToCompact],next->[hasNext],QueueEntry->[getDataSource->[getDataSource]]]] | Returns the list of segments that are not in the list. | can we call this getSize() and explicitly list if it is public/private/protected? |
@@ -139,6 +139,7 @@ public class DefaultPersistentMetadataCacheManager implements MetadataCacheManag
if (isBlank(keyHash)) {
clearMetadataCaches();
} else {
+ LOGGER.debug(format("Removing cache in OS with ID '%s'", key));
metadataStore.get().remove(key);
}
... | [DefaultPersistentMetadataCacheManager->[disposeAllMatches->[dispose]]] | Disposes all the elements with a prefix matching the given key. | Check if debug level is enabled in the logger before logging. Also, is string formatting necessary or does the .debug method accept extra arguments for formatting? |
@@ -0,0 +1,18 @@
+package org.ray.streaming.runtime;
+
+import org.ray.runtime.RayNativeRuntime;
+import org.ray.runtime.util.JniUtils;
+
+public class TestHelper {
+
+ public static void loadNativeLibraries() {
+ // load core_worker_library_java before load streaming_java
+ try {
+ Class.forName(RayNativeR... | [No CFG could be retrieved] | No Summary Found. | The above code snippet is repeated many times. Can you make it a helper function? |
@@ -77,7 +77,12 @@ public:
void JustDied(Unit* /*killer*/) override
{
- _JustDied();
+ events.Reset();
+ if (instance)
+ {
+ instance->SetBossState(DATA_OVERLORD_WYRMTHALAK, DONE);
+ instance->SaveToDB();
+ }
... | [boss_overlord_wyrmthalak->[boss_overlordwyrmthalakAI->[JustDied->[_JustDied],UpdateAI->[DoCastVictim,SelectTarget,ExecuteEvent,ScheduleEvent,DoMeleeAttackIfReady,HasUnitState,HealthBelowPct,UpdateVictim,SummonCreature,AI,Update],Reset->[_Reset],EnterCombat->[ScheduleEvent,_EnterCombat]]]] | JustDied is called when a unit is just died. | this is the only line actually required |
@@ -315,6 +315,12 @@ def handle_contract_send_channelsettle(
# be a race condition when both nodes try to settle
# at the same time.
pass
+ except ChannelOutdatedError as e:
+ log.debug(
+ f'{e.args}. '
+ f'Current channel identifier: {e.current_channel_id}, '
... | [on_raiden_event->[handle_transfersentsuccess,handle_send_revealsecret,handle_send_balanceproof,handle_send_processed,handle_send_refundtransfer,handle_contract_send_channelclose,handle_send_lockedtransfer,handle_contract_send_channelupdate,handle_send_secretrequest,handle_transfersentfailed,handle_contract_send_channe... | Handle a channel settle event. This function is called when a node receives a n - node event. Handle contract send channelsettle. | I'd prefer the two channel ids to be keyword arguments. This would be more like we use structlog in general. |
@@ -11,7 +11,7 @@ load "debug_helpers.rb"
load "util.rb"
# Application version
-ALAVETELI_VERSION = '0.22.4.3'
+ALAVETELI_VERSION = '0.22.4.4'
# Add new inflection rules using the following format
# (all these examples are active by default):
| [env,force_ssl,dirname,default_url_options,set_locales,push,default_locale,domain,available_locales,join,require,configurations,load] | This module loads all of the common library helper functions and adds some basic configuration that is used This is a static function that requires all of the required modules to be loaded. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -196,7 +196,9 @@ static bool SetSessionKey(AgentConnection *conn)
return false;
}
- conn->session_key = (unsigned char *) bp->d;
+ buf = malloc(BN_num_bytes(bp));
+ BN_bn2bin(bp, buf);
+ conn->session_key = buf;
return true;
}
| [bool->[CfSessionKeySize,BN_clear_free,Log,BN_rand,BN_new],AuthenticateAgent->[BN_bn2mpi,ReceiveTransaction,xmalloc,SetSessionKey,BN_mpi2bn,BN_rand,HavePublicKeyByIP,BN_new,KeyBinaryHash,SendTransaction,memcpy,assert,GetErrorStr,LastSaw,RSA_private_decrypt,BN_free,CfEnterpriseOptions,RSA_new,HashesMatch,Log,RSA_free,Cr... | Set the session key for the agent send the public key if we don t have it sendbuffer is the buffer to be encrypted len is the length of the buffer Check if we have a counter challenge and if so send the response to the client This function checks if a key is available in the client s RSA network and if so it if we have... | where is `conn->session_key` freed? |
@@ -257,6 +257,9 @@ func (a *APIServer) runUserCode(ctx context.Context, logger *taggedLogger, envir
}
func (a *APIServer) uploadOutput(ctx context.Context, tag string, logger *taggedLogger, inputs []*Input) error {
+ defer func(start time.Time) {
+ logger.Logf("uploading output for inputs (%v) took %v\n", inputs,... | [Write->[Logf,Write],downloadData->[Logf],Process->[cleanUpData,getTaggedLogger,Logf,downloadData,uploadOutput,runUserCode],uploadOutput->[Logf],runUserCode->[userLogger,Logf],Write] | uploadOutput uploads all files in the output directory to the output directory. pathWithInput - Path of the input file that is not already in PFS. This function is used to write a single object to the object store. | Same here, no need for logging `inputs`, they're already present in the `LogMessage` |
@@ -4426,7 +4426,11 @@ namespace tools
return false;
}
- if (!m_wallet->set_daemon(req.address, boost::none, req.trusted, std::move(ssl_options)))
+ boost::optional<epee::net_utils::http::login> daemon_login{};
+ if (!req.username.empty() || !req.password.empty())
+ daemon_login.emplace(req.... | [No CFG could be retrieved] | Initializes the SSL connection. API for handling log level requests. | `if (!req.username.empty() || !req.password.empty())` - I think the empty string for username is valid in the HTTP login spec. |
@@ -154,6 +154,10 @@ module.exports = yeoman.Base.extend({
var path = this.destinationPath(this.directoryPath + this.appsFolders[i]+'/.yo-rc.json');
var fileData = this.fs.readJSON(path);
var config = fileData['generator-jhipster'];
+ //t... | [No CFG could be retrieved] | Creates a list of application names to be included in the Docker Compose configuration. Prompts the user which applications do you want to use with clustered databases. | All application type should set the`baseName` and hence this should never happen, for appType `uaa` we should set the basename while generating the app appropriately in server or app generator |
@@ -527,8 +527,8 @@ export class AmpStoryPage extends AMP.BaseElement {
} else {
let mediaElement;
try {
- mediaElement = scopedQuerySelector(
- this.element, `#${autoAdvanceAfter}`);
+ mediaElement =
+ this.win.document.getElementById(`${autoAdvanceAfter}`);
... | [No CFG could be retrieved] | Determines if the page should be automatically advancing. Gets adjacent page ids. | just use '' if no interpolation is occurring |
@@ -139,7 +139,9 @@ func main() {
})
ec2NodeID2, err := gatewayNodesClient.Create(suite.ctx, &gwnodes.Node{
Name: "inspec-target-rhel7-acceptance.cd.chef.co",
- Tags: []*query.Kv{},
+ Tags: []*query.Kv{
+ {Key: "environment", Value: "test-env"},
+ },
TargetConfig: &gwnodes.TargetConfig{
Backend: "ssh... | [Create,Println,Dial,ConfigFromViper,Background,ReadInConfig,SetConfigFile,SecureConnFactoryHabWithDeploymentServiceCerts,NewClientsFactory,Fatal,SecretClient,DecodeString,NewNodesServiceClient,Getenv,GetId,ComplianceJobsServiceClient] | Creates two nodes and their secrets for the users. Creates three scan jobs for the given secret ID. | this is so the `load_scan_jobs` command will add some nodes with env values by default |
@@ -180,7 +180,7 @@ router.get('/ecommerce-nested-menu', function(req, res) {
'menu': [
{
'title': 'Clothing, Shoes, Jewelry \u0026 Watches',
- 'image': 'https://cdn.orvis.com/images/082119_w_new.jpg',
+ 'image': 'https://picsum.photos/id/535/367/267',
'content': [
... | [No CFG could be retrieved] | Get a list of items and a next url. Menu for all possible non - standard non - standard non - standard non - standard non -. | In a future PR can we make these served by the same system providing the JSON? |
@@ -1776,6 +1776,10 @@ public class KafkaSupervisor implements Supervisor
void createNewTasks() throws JsonProcessingException
{
+ if (spec.isSuspended()) {
+ return;
+ }
+
// update the checkpoints in the taskGroup to latest ones so that new tasks do not read what is already published
task... | [KafkaSupervisor->[emitLag->[getHighestCurrentOffsets],buildRunTask->[RunNotice],checkCurrentTaskState->[taskIds],getRandomId->[toString],addDiscoveredTaskToPendingCompletionTaskGroups->[TaskData,TaskGroup],createKafkaTasksForGroup->[getRandomId],start->[toString],GracefulShutdownNotice->[handle->[handle]],checkPending... | Creates new tasks for all partitions. Checks if a new task was created and if so schedules a run event. | Is this needed, since `createNewTasks()` is only called when not suspended? |
@@ -77,12 +77,15 @@ class SIPPackage(PackageBase):
args = self.configure_args()
+ python_include_dir = 'python' + str(spec['python'].version.up_to(2))
+
args.extend([
'--verbose',
'--confirm-license',
'--qmake', spec['qt'].prefix.bin.qmake,
- ... | [SIPPackage->[import_module_test->[python],configure->[python,configure_file],install_sip->[python]]] | Configure the package. | The `python` package has a `python_include_dir` attribute you should be able to query. |
@@ -129,6 +129,12 @@ class LicenseRadioSelect(forms.RadioSelect):
class LicenseForm(AMOModelForm):
+ # Hack to restore behavior from pre Django 1.10 times.
+ # Django 1.10 enabled `required` rendering for required widgets. That
+ # wasn't the case before, this should be fixed properly but simplifies
+ ... | [CheckCompatibilityForm->[clean_application->[version_choices_for_app_id]],CompatForm->[AppVersionChoiceField],NewUploadForm->[clean->[_clean_upload]],LicenseForm->[LicenseRadioSelect],DescribeForm->[__init__->[_has_field]]] | Create a radio select with a specific license. This is the main entry point for the license form. It is called by the constructor to. | If we're going to eventually fix this, can we log the "fix properly" issue and link to it here? |
@@ -74,10 +74,12 @@ trait IdentifierManagerTrait
throw new PropertyNotFoundException(sprintf('Invalid identifier "%s", "%s" has not been found.', $id, $propertyName));
}
- $doctrineTypeName = $doctrineClassMetadata->getTypeOfField($propertyName);
+ if ($this->should... | [normalizeIdentifiers->[getIdentifier,create,getClassMetadata,isIdentifier,convertToPHPValue,getTypeOfField,getDatabasePlatform]] | Normalizes the given identifier to a proper key - value array. | Why don't you use the `getAttribute` method directly? |
@@ -591,9 +591,8 @@ function $RouteProvider() {
if (angular.isFunction(templateUrl)) {
templateUrl = templateUrl(nextRoute.params);
}
- templateUrl = $sce.getTrustedResourceUrl(templateUrl);
if (angular.isDefined(templateUrl)) {
- ... | [No CFG could be retrieved] | nextRoute - > nextRoute parseRoute - parse a route. | Is this a behavior change? |
@@ -120,6 +120,7 @@ namespace ProtoCore.AssociativeGraph
public int exprUID { get; set; }
public int ssaExprID { get; set; }
public int modBlkUID { get; set; }
+ public string CallSiteIdentifier { get; set; }
public List<ProtoCore.AssociativeGraph.UpdateNode> dimensionNodeList... | [UpdateNodeRef->[IsEqual->[IsEqual]],DependencyGraph->[GetGraphNodesAtScope->[GetGraphNodeKey],Push->[GetGraphNodeKey],GetExecutionStatesAtScope->[GetGraphNodesAtScope],RemoveNodesFromScope->[GetGraphNodeKey]],UpdateNode->[IsEqual->[IsEqual]]] | This namespace is used to create an UpdateBlock object. GraphNode properties are protected by the graph node itself. | About naming, CallSite or Callsite? I see Callsite in elsewhere. |
@@ -17,13 +17,6 @@ import java.util.concurrent.atomic.LongAdder;
public class InfinispanQueryStatisticsInfo implements InfinispanQueryStatisticsInfoMBean {
private final SearchIntegrator sf;
- private final LongAdder searchQueryExecutionCount = new LongAdder();
- private final LongAdder searchQueryTotalTime ... | [InfinispanQueryStatisticsInfo->[getSearchQueryExecutionCount->[getSearchQueryExecutionCount],getObjectsLoadedCount->[getObjectsLoadedCount],getObjectLoadingTotalTime->[getObjectLoadingTotalTime],isStatisticsEnabled->[isStatisticsEnabled],getSearchQueryExecutionMaxTime->[getSearchQueryExecutionMaxTime],getSearchVersion... | This method is used to add statistics from the Hibernate Search statistics object. searchQueryExecutionMaxTime - set max time for search query execution. | This class and InfinispanQueryStatisticsInfoMBean were introduced as a workaround for HSEARCH-1461. I believe they need to be removed. |
@@ -0,0 +1,14 @@
+"""Certbot main public entry point."""
+from certbot._internal import main as internal_main
+
+
+def main(cli_args=None):
+ """Command line argument parsing and main script execution.
+
+ :returns: result of requested command
+
+ :raises errors.Error: OS errors triggered by wrong permissions
... | [No CFG could be retrieved] | No Summary Found. | I'd like to improve these docs. (Should `cli_args` include `sys.argv[0]`? What return values can be expected?) Since this was just copied from the internal function though, I'm fine doing it later. |
@@ -8,6 +8,8 @@ module Idv
ACTIONS = {
reset: Idv::Actions::ResetAction,
+ verify_document: Idv::Actions::VerifyDocumentAction,
+ verify_document_status: Idv::Actions::VerifyDocumentStatusAction,
}.freeze
def initialize(controller, session, _name)
| [CaptureDocFlow->[freeze]] | Initialize the index. | reason this is needed: these polling actions for async work were missing from the hybrid flow |
@@ -626,6 +626,13 @@ class DeleteInvoice(ModelDeleteMutation):
error_type_class = InvoiceError
error_type_field = "invoice_errors"
+ @classmethod
+ def perform_mutation(cls, _root, info, **data):
+ invoice_pk = copy.copy(cls.get_instance(info, **data).pk)
+ response = super().per... | [clean_refund_payment->[clean_payment],OrderVoid->[perform_mutation->[OrderVoid,clean_void_payment,try_payment_action]],RequestInvoice->[perform_mutation->[RequestInvoice]],clean_order_capture->[clean_payment],OrderMarkAsPaid->[perform_mutation->[clean_billing_address,try_payment_action,OrderMarkAsPaid]],SendInvoiceEma... | CreateInvoice creates a new invoice from a given invoice. Get the object that holds the number of the item. | Why we use `copy` here? |
@@ -54,7 +54,7 @@ export class StandardActions {
this.ampdoc = ampdoc;
/** @const @private {!./action-impl.ActionService} */
- this.actions_ = Services.actionServiceForDoc(ampdoc);
+ this.actions_ = Services.actionServiceForDoc(ampdoc.getHeadNode());
/** @const @private {!./resources-impl.Resou... | [No CFG could be retrieved] | A standard action service that provides a list of actions that can be performed on the top of Adds global method handlers to AMP. | Ditto: I have some concerns about the head node for shadow docs. |
@@ -152,7 +152,7 @@ function tax_by_thirdparty($type, $db, $y, $date_start, $date_end, $modetax, $di
$sql.= " ".MAIN_DB_PREFIX."societe as s,";
$sql.= " ".MAIN_DB_PREFIX.$invoicedettable." as d" ;
$sql.= " LEFT JOIN ".MAIN_DB_PREFIX."product as p on d.fk_product = p.rowid";
- $sql.= " WHERE f.enti... | [tax_by_thirdparty->[query,idate,jdate,fetch_array],tax_prepare_head->[trans],tax_by_rate->[query,idate,jdate,fetch_array]] | This function is used to calculate the tax of a third party tax. count on delivery date This function is used to find all products that are valid or paid. SQL for reading all the data. A query to find all products that are not payment or facture. | @atm-quentin getEntity('invoice') instead please !!! |
@@ -2289,6 +2289,7 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
String hostName = cmd.getHostName();
Map<String,String> details = cmd.getDetails();
Account caller = CallContext.current().getCallingAccount();
+ List<Long> securityGroupIdList = getS... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getVmId],loadVmDetailsInMapForExternalDhcpIp->[VmAndCountDetails],expungeVm->[e... | Updates a virtual machine. take care of the data volumes as well as the details as well. | Shouldn't there be a check for NULL here? |
@@ -16,7 +16,11 @@ class Wannier90(MakefilePackage):
"""
homepage = 'http://wannier.org'
url = 'http://wannier.org/code/wannier90-2.0.1.tar.gz'
+ # Newer versions are here
+ new_url = 'https://github.com/wannier-developers/wannier90/archive/v3.1.0.tar.gz'
+ version('3.1.0', sha256='40651a9832e... | [Wannier90->[install->[install,join_path,mkdirp,install_tree],edit->[,join_path,dirname,copy,filter_file,items,getmodule],makefile_name->[join_path,satisfies],depends_on,version]] | Creates a new object with the name of the given object. Package - level functions for the given object. | This url doesn't appear to be used anywhere. I would replace the `url` above with this one so that `spack versions` and `spack checksum` will work correctly. |
@@ -95,9 +95,10 @@ def psd_array_welch(x, sfreq, fmin=0, fmax=np.inf, n_fft=256, n_overlap=0,
Returns
-------
- psds : ndarray, shape (..., n_freqs) or
+ psds : ndarray, shape (..., n_freqs)
The power spectral densities. All dimensions up to the last will
- be the same as input.
+ ... | [psd_array_welch->[_check_nfft],psd_welch->[_check_psd_data,psd_array_welch],psd_multitaper->[_check_psd_data]] | Compute power spectral density using Welch s method. Calculate the PSD of the nanmean window of the data. | Might as well change to ``PSDs`` here too. |
@@ -1416,6 +1416,15 @@ add_domains_to_pool_buf(struct pool_map *map, struct pool_buf *map_buf,
map_comp.co_fseq = 1;
map_comp.co_nr = node.fdn_val.dom->fd_children_nr;
+ if (map != NULL) {
+ already_in_map = pool_map_find_domain(map,
+ PO_COMP_TP_RACK,
+ map_comp.co_id,
+ ... | [No CFG could be retrieved] | find the next node in the tree Allocate the pool attribute buffers. | why not use the domain status in the pool map? or I miss sth? |
@@ -1779,11 +1779,16 @@ public abstract class AMQPMessage extends RefCountMessage implements org.apache.
@Override
public String toString() {
+ MessageDataScanningStatus scanningStatus = getDataScanningStatus();
+ Map<String, Object> applicationProperties = scanningStatus == MessageDataScanningStatu... | [AMQPMessage->[setRoutingType->[setMessageAnnotation,removeMessageAnnotation],scanForMessageSection->[scanForMessageSection],getGroupID->[ensureMessageDataScanned],cachedAddressSimpleString->[cachedAddressSimpleString],getObjectProperty->[getAMQPUserID,getGroupID,getObjectProperty,getGroupSequence,getConnectionID],clea... | Returns a string representation of the object. | This is probably the first one I could believe there might be a valid path to hitting, though I could also believe its again just a situation that we should enforce doesnt occur since it isnt expected to be possible in actual (vs broken test) usage. |
@@ -155,4 +155,8 @@ public abstract class AbstractVisitor implements Visitor {
public Object visitUnknownCommand(InvocationContext ctx, VisitableCommand command) throws Throwable {
return handleDefault(ctx, command);
}
+
+ public Object visitDistributedExecuteCommand(InvocationContext ctx, Distribut... | [AbstractVisitor->[visitUnknownCommand->[handleDefault],visitInvalidateL1Command->[visitInvalidateCommand],visitLockControlCommand->[handleDefault]]] | Handle an unknown command. | DistributedExecuteCommand does not need to be visitable, it's just an RPC command. |
@@ -10,7 +10,7 @@
<h1>Partner With <img src="<%= asset_path "rainbowdev.svg" %>" /> </h1>
<h3>🚀 Reach</h3>
<p>
- DEV serves millions of unique visitors per month. This highly-targeted developer audience is comprised of registered members (<%= User.count %>) and visitors from the open web — many of whom vi... | [No CFG could be retrieved] | A UI element for a single unique identifier. This is a simple example of how to generate a mutually positive outcome with a community. | I don't think there's ever a good reason to display the exact count updated by the millisecond for things like the size of an entire table. This estimate also is accurate enough, see the algorithm up there |
@@ -57,6 +57,7 @@ def rule_runner() -> RuleRunner:
rule_runner = RuleRunner(
rules=[
*go_mod.rules(),
+ *pkg_analyzer.rules(),
*first_party_pkg.rules(),
*third_party_pkg.rules(),
*sdk.rules(),
| [test_go_package_dependency_inference->[get_deps],test_generate_package_targets->[gen_third_party_tgt],test_determine_main_pkg_for_go_binary->[get_main]] | Return a RuleRunner instance that runs all rules that match a missing rule. | Not blocking, but I think you can remove this |
@@ -131,7 +131,7 @@ func NewDeployer(client kclientset.Interface, images imageclientinternal.Interfa
getDeployments: func(namespace, configName string) (*kapi.ReplicationControllerList, error) {
return client.Core().ReplicationControllers(namespace).List(metav1.ListOptions{LabelSelector: appsutil.ConfigSelector(... | [RunDeployer->[NewForConfig,Deploy,Errorf,InClusterConfig],Deploy->[strategyFor,Fprintf,IsCompleteDeployment,Fprintln,UniversalDecoder,Scale,Deploy,ByLatestVersionDesc,NewConditionReachedErr,DecodeDeploymentConfig,Sort,NewRetryParams,DeploymentVersionFor,Errorf,getDeployment,getDeployments,DeploymentDesiredReplicas,Lab... | NewDeployer creates a new Deployer from a Kubernetes client. - the last component in the cluster. | I'm inclined to say we should stop using `kubectl.Scaler` here and instead use direct scale client on a rc and put that manual bit of code responsible for scaling into the deployer. Although I'm might be wrong. |
@@ -48,6 +48,16 @@ def get_joined_path(new_entries, env=None, env_var='PATH', delimiter=':', prepen
return delimiter.join(path_dirs)
+def _os_encode(u, enc=sys.getfilesystemencoding()):
+ """Turns a `unicode` into `bytes` via encoding."""
+ return u.encode(enc, 'strict')
+
+
+def _os_decode(b, enc=sys.getfiles... | [open_zip->[InvalidZipPath],environment_as->[setenv],stdio_as->[_stdio_stream_as],hermetic_environment_as->[_restore_env,environment_as,_purge_env]] | Update the environment to the supplied values. | Is using `sys.getfilesystemencoding` preferred to specifying `UTF8` explicitly? |
@@ -843,6 +843,9 @@ public class DeckPicker extends NavigationDrawerActivity implements
} else if (resultCode == RESULT_DB_ERROR) {
handleDbError();
return;
+ } else if (resultCode == RESULT_MODEL_CORRUPT) {
+ showDbCorruptDialog();
+ return;
}
... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],onRequestPermissionsResult->[onRequestPermissionsResult,handleStartup],undo->[undoTaskListener],mediaCheck->[mediaCheckListener],MediaCheckListener->[actualOnPostExecute->[showMediaCheckDialog]],updateDeckList->[updateDeckListListener,updateDeckList],onDestroy->[on... | Override onActivityResult to handle the result of the action. This method shows the Snackbar that shows the save operation successful or not. | We already have a dialog for a DB error. Is there a reason we're not using this? |
@@ -104,8 +104,11 @@ public class TerminateSessionAction extends AbstractAction {
manager.logout();
final HttpSession session = request.getSession();
- if (session != null) {
+ if (session != null) {
+ final Object requestedUrl=request.getSession().getAttribute("... | [TerminateSessionAction->[destroyApplicationSession->[debug,logout,getPac4jProfileManager,invalidate,getSession],terminate->[destroyApplicationSession,RuntimeException,removeCookie,debug,getMessage,destroyTicketGrantingTicket,putLogoutRequests,getHttpServletRequestFromExternalWebflowContext,getTicketGrantingTicketId,re... | Destroy the application session. | You should use the pac4j constant: `Pac4jConstants.pac4jRequestedUrl`. |
@@ -129,9 +129,15 @@ public class ServerDaemon implements Daemon {
setSessionTimeout(Integer.valueOf(properties.getProperty(SESSION_TIMEOUT, "30")));
} catch (final IOException e) {
LOG.warn("Failed to load configuration from server.properties file", e);
+ } finally {
+ ... | [ServerDaemon->[destroy->[destroy],stop->[stop],main->[ServerDaemon],start->[start],getResource->[getResource]]] | Initializes the server daemon. Setup the daemon. | Some logging here for this behavior would be nice. |
@@ -55,10 +55,10 @@ func (s *scanner) Start(done <-chan struct{}) (<-chan Event, error) {
s.config.ScanRatePerSec,
s.config.MaxFileSize)
- s.tokenBucket = ratelimit.NewBucketWithRate(
- float64(s.config.ScanRateBytesPerSec)/2., // Fill Rate
- int64(s.config.MaxFileSizeBytes)) // Max Capacity
- ... | [walkDir->[IsNotExist,throttle,newScanEvent,IsDir,Mode,Walk,New,Now,IsExcludedPath,Since,Warnw],throttle->[Take,NewTimer],scan->[walkDir,Warnw,EvalSymlinks,Infow,Now,Debugw,LoadUint64,Since,Debug],Start->[scan,Debugf,NewBucketWithRate,With,TakeAvailable],newScanEvent->[AddUint64],With,AddUint32,NewLogger] | Start starts the scanner. It returns a channel that will receive events on the channel. | Not sure we were using half the `ScanRateBytesPerSec` before? Everything else seems OK for the migration. |
@@ -112,6 +112,10 @@ class Process {
if ( $r->return_code || ! empty( $r->STDERR ) ) {
throw new \RuntimeException( $r );
}
+ // But do it right if testing.
+ if ( ! empty( $this->env['BEHAT_RUN'] ) && ! empty( $r->stderr ) ) {
+ throw new \RuntimeException( $r );
+ }
return $r;
}
| [Process->[run_check->[run]]] | Runs the command and returns the result. | Can we perform this check where `run_check()` is called, instead of modifying the `Process` class itself? |
@@ -218,6 +218,7 @@ const options_entry emu_options::s_option_entries[] =
{ OPTION_HTTP, "0", OPTION_BOOLEAN, "enable HTTP server" },
{ OPTION_HTTP_PORT, "8080", OPTION_INTEGER, "HTTP server port" },
{ OPTION_HTTP_ROOT, ... | [No CFG could be retrieved] | Options for the command line interface PUBLIC FUNCTIONS For the system name of the class. | This definitely shouldn't be added. |
@@ -44,11 +44,16 @@ func ImageExists(w http.ResponseWriter, r *http.Request) {
runtime := r.Context().Value("runtime").(*libpod.Runtime)
name := utils.GetName(r)
- _, err := runtime.ImageRuntime().NewFromLocal(name)
+ ir := abi.ImageEngine{Libpod: runtime}
+ report, err := ir.Exists(r.Context(), name)
if err !=... | [Context,RemoveAll,Value,StatusText,Commit,InternalServerError,TempFile,Tar,GetImage,ErrorsToStrings,NewFromLocal,Close,TempDir,GetConfig,IsReadOnly,Wrap,LoadImage,PushImageToHeuristicDestination,Copy,Error,Save,ParseBool,Cause,New,ParseDockerReference,TagImage,GetSystemContext,GetImages,GetName,Errorf,ImageNotFound,Pa... | ImageExists returns a list of images in the system returns the image tree. | This looks like a breaking change to the API |
@@ -330,8 +330,12 @@ class Telegram(RPCHandler):
statlist, head = self._rpc._rpc_status_table(
self._config['stake_currency'], self._config.get('fiat_display_currency', ''))
- message = tabulate(statlist, headers=head, tablefmt='simple')
- self._send_msg(f"<pre>{mes... | [authorized_only->[wrapper->[int,exception,command_handler,get,info]],Telegram->[_count->[debug,tabulate,str,_rpc_count,_send_msg,format,items],_reload_config->[_send_msg,_rpc_reload_config,format],_stop->[_send_msg,_rpc_stop,format],_stopbuy->[_send_msg,format,_rpc_stopbuy],_delete_trade->[RPCException,,int,len,str,_s... | _status_table - Shows status of the n - th n - th n - Send a message to the server. | in principle great - except that it doesn't work / send the 2nd message. I think the problem is in this line - you're limiting the upper range to 1 (`max(x, 1)`) - so at maximum, 1 message can be sent. Also, in case of 52 trades (for example) - i'd have `52 / 50 = 1.04` - using "int" on this is 1 ... while in reality, ... |
@@ -303,6 +303,9 @@ namespace System.Text.Json.Serialization.Tests
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<DateTimeOffset>(unexpectedString));
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<DateTimeOffset?>(unexpectedString));
+ Assert.Throws<J... | [ValueTests->[SingleToInt32Bits->[SingleToInt32Bits]]] | Tests if the value of the object is not serializable. This method throws an exception if the input is not serializable. | Due to other logic, we should be fine, but a few more nullable `TimeSpan` tests would be good. E.g. deserializing `null` into a non-nullable `TimeSpan` should fail, but should be fine for nullable `TimeSpan?`. |
@@ -73,7 +73,10 @@ final class EpollEventLoop extends SingleThreadEventLoop {
try {
this.epollFd = epollFd = Native.epollCreate();
this.eventFd = eventFd = Native.eventFd();
- Native.epollCtlAdd(epollFd, eventFd, Native.EPOLLIN);
+ // IMPORTANT:
+ // I... | [EpollEventLoop->[closeAll->[epollWait,add],remove->[remove],epollWait->[epollWait],run->[epollWait]]] | Creates an EpollEventLoop group. Adds a new to the EventLoop. | as we not comsume it's -> because we do not consume its |
@@ -19,3 +19,13 @@ class PyPox(PythonPackage):
depends_on('python@2.5:2.8,3.1:')
depends_on('py-setuptools@0.6:', type='build')
+
+ def url_for_version(self, version):
+ url = self.list_url
+ if version >= Version('0.2.5'):
+ url += 'pox-{0}.tar.gz'
+ else:
+ ur... | [PyPox->[depends_on,version]] | requires_on - returns list of packages that are available on the current environment. | This version is not in Spack |
@@ -139,3 +139,18 @@ def test_secure_origin(location, trusted, expected):
logger = MockLogger()
finder._validate_secure_origin(logger, location)
assert logger.called == expected
+
+
+def test_get_formatted_locations_basic_auth():
+ """
+ Test that basic authentication credentials defined in URL
+ ... | [test_base_url->[HTMLPage],TestLink->[test_splitext->[Link],test_ext_query->[Link],test_filename->[Link],test_is_wheel_false->[Link],test_is_wheel->[Link],test_ext->[Link],test_fragments->[Link],test_ext_fragment->[Link],test_no_ext->[Link],parametrize],test_sort_locations_file_not_find_link->[_sort_locations,PipSessio... | Test that a secure origin is available. | Not for this PR but `get_formatted_locations` needs tests. |
@@ -68,6 +68,8 @@ RSpec.configure do |config|
config.before(:each, js: true) do
allow(Figaro.env).to receive(:domain_name).and_return('127.0.0.1')
+ server = Capybara.current_session.server
+ Rails.application.routes.default_url_options[:host] = "#{server.host}:#{server.port}"
end
config.before(... | [current_driver,start,reset!,domain_name,clear_calls,infer_spec_type_from_file_location!,to,use_default_driver,host,before,add_filter,with,require,load_seed,include,use_transactional_fixtures,enable,each,around,puts,locale,clear_messages,stub_request,run,configure,maintain_test_schema!,exit,and_return,expand_path] | Initialize the configuration for the Nova - Nix. missing feature - name config around. | love this lil patch, I'd been super frustrated by the `example.com` stuff before |
@@ -1,4 +1,11 @@
-<div id="title_bar"><h1><%=I18n.t('notes.title') %></h1></div>
+<%= javascript_include_tag 'help_system' %>
+
+<div id="title_bar">
+ <h1><%=I18n.t('notes.title') %><span class="title-help notes_help"></span></h1>
+</div>
+
+<p class="help-message-title notes_help"><%= t("notes.help")%></p>
+<div c... | [No CFG could be retrieved] | Renders the list of notes for a single user. Debugging function for showing the list of all the n - ary nodes. | Spaces in the `I18n.t` tag. |
@@ -19,6 +19,15 @@ config.integrations.rack.http_events.silence_request = lambda do |_rack_env, rac
rack_request.path.match?(/^\/page_views\/\d{1,9}/)
end
+config.integrations.rack.user_context.custom_user_hash = lambda do |rack_env|
+ session_user_id = rack_env["rack.session"].to_h["warden.user.user.key"]&.firs... | [instance,match?,silence,collapse_into_single_event,silence_request,lambda,development?] | Check if the request is a page view and if so add additional configuration options. | can we change this key to be `user_id` so that it is clear what kind of ID it is? |
@@ -582,11 +582,13 @@ namespace ProtoCore.AssociativeGraph
{
public int startpc { get; set; }
public int endpc { get; set; }
+ public int updateStartPC { get; set; }
public UpdateBlock()
{
startpc = Constants.kInvalidIndex;
endpc = Constants.kI... | [UpdateNodeRef->[Equals->[Equals]],DependencyGraph->[GetGraphNodesAtScope->[GetGraphNodeKey],Push->[GetGraphNodeKey],GetExecutionStatesAtScope->[GetGraphNodesAtScope],RemoveNodesFromScope->[GetGraphNodeKey]],Utils->[UpdateDependencyGraph->[UpdateDependencyGraph],GetRedefinedGraphNodes->[IsGraphNodeRedefined]],UpdateNod... | GraphNode is a class that represents a graphnode in a graph that is associated with a Property to be used in the constructor of a languageblock or construct. | Could we have a better name for this new property to describe it properly? |
@@ -36,6 +36,7 @@ func RemoveContainer(w http.ResponseWriter, r *http.Request) {
query := struct {
Force bool `schema:"force"`
Ignore bool `schema:"ignore"`
+ Depend bool `schema:"depend"`
Link bool `schema:"link"`
Timeout *uint `schema:"timeout"`
DockerVolumes... | [Context,Value,StatusText,CreatedTime,InternalServerError,StartedTime,GetContainers,WorkingDir,Hostname,FinishedTime,Signal,LogPath,ContainerKill,Itoa,Error,Format,Marshal,Cause,UTC,GetName,RootFsSize,Errorf,HumanDuration,RWSize,State,Since,ContainerWait,Labels,Debugf,SplitN,ID,HasHealthCheck,Wrapf,Join,Unix,StopSignal... | RemoveContainer removes a container from the container manager. Get the unique id from the URL query. | I don't think we want this in the compat API, the return type won't make it clear that multiple containers were removed. Having it only in the fancy version that can already to multiple containers seems better? |
@@ -42,6 +42,11 @@ func (p *StripNewline) Next() (reader.Message, error) {
L := message.Content
message.Content = L[:len(L)-lineEndingChars(L)]
+ if len(message.Original) > 0 {
+ O := message.Original
+ message.Original = O[:len(O)-lineEndingChars(O)]
+ }
+
return message, err
}
| [Next->[Next]] | Next returns the next message in the reader. | Minor detail, but maybe we don't want to strip the newline here? Right now the multiline reader inserts a separator, after this one has been removed. => we don't report the original, but some modified contents. We can simply concatenate `message.Original` if we were not strip newlines here. |
@@ -1916,12 +1916,11 @@ void Creature::Respawn(bool force)
UpdateObjectVisibility(false);
}
-void Creature::ForcedDespawn(uint32 timeMSToDespawn)
+void Creature::ForcedDespawn(uint32 timeMSToDespawn, Seconds forceRespawnTimer)
{
if (timeMSToDespawn)
{
- ForcedDespawnDelayEvent* pEvent = new Fo... | [RefreshSwimmingFlag->[CanEnterWater],DespawnOrUnsummon->[ForcedDespawn],LoadCreatureFromDB->[Create,_GetHealthMod],UpdateEntry->[InitEntry],IsImmunedToSpellEffect->[HasMechanicTemplateImmunity],IsImmunedToSpell->[HasMechanicTemplateImmunity],InitEntry->[GetFirstValidModelId],IsMovementPreventedByCasting->[HasSpellFocu... | Checks if a specific creature has already been respawned. protected int m_respawnedTime ;. | Why do we use seconds here? Wouldnt Milliseconds make more sense incase the user wants to force respawn it in f.ex 1.5s? |
@@ -996,6 +996,12 @@ public class KVMStorageProcessor implements StorageProcessor {
primaryStore.getUuid());
if (state == DomainInfo.DomainState.VIR_DOMAIN_RUNNING && !primaryStorage.isExternalSnapshot()) {
final DomainSnapshot snap = vm.snapsho... | [KVMStorageProcessor->[backupSnapshot->[backupSnapshotForObjectStore],attachVolume->[attachOrDetachDisk],cloneVolumeFromBaseTemplate->[templateToPrimaryDownload],configure->[getDefaultStorageScriptsDir,configure],dettachIso->[attachOrDetachISO],attachOrDetachDisk->[attachOrDetachDevice],createTemplateFromVolumeOrSnapsh... | Backup a snapshot of a single object store. This method takes a snapshot of the RBD and creates a snapshot of the RBD. This method is called when a snapshot is created from vm snapshot or when vm snapshot is removed delete a snapshot on a virtual machine. | When we need to delete a snapshot, is it a KVM/libvirt requirement to suspend the domain? Could it be something to do with old/archaic libvirt/qemu-img version? |
@@ -16,6 +16,11 @@ dfuse_cb_setattr(fuse_req_t req, struct dfuse_inode_entry *ie,
DFUSE_TRA_DEBUG(ie, "flags %#x", to_set);
+ if (to_set & (FUSE_SET_ATTR_UID | FUSE_SET_ATTR_GID)) {
+ DFUSE_TRA_INFO(ie, "File uid/gid support not enabled");
+ D_GOTO(err, rc = ENOTSUP);
+ }
+
if (to_set & FUSE_SET_ATTR_MODE) {
... | [dfuse_cb_setattr->[D_GOTO,DFUSE_REPLY_ERR_RAW,dfs_osetattr,DFUSE_TRA_DEBUG,DFUSE_TRA_WARNING,DFUSE_REPLY_ATTR]] | dfuse_cb_setattr - callback for fuse_setattr DFUSE_REPLY_ATTR - reply handler. | This is interesting because some of the datamover tools (`dcp --preserve`) will try to copy the ownership. It's simple enough for `dcp` to just ignore `chown` for DFS. But a dfuse path is just seen as a POSIX path to `dcp`, so the `chown` call will always fail if a dfuse path is given as the destination to `dcp --prese... |
@@ -1,5 +1,11 @@
# frozen_string_literal: true
-Dir["#{Rails.root}/lib/freedom_patches/*.rb"].each do |f|
- require(f)
+RUN_WITHOUT_PREPARE = ["#{Rails.root}/lib/freedom_patches/rails_multisite.rb"]
+RUN_WITHOUT_PREPARE.each { |path| require(path) }
+
+Rails.application.reloader.to_prepare do
+ Dir["#{Rails.root}/... | [each,require] | requires all of the files in the same directory as the Freedom gem. | What was the problem that you ran into with the `rails_multisite` freedom patch? |
@@ -581,7 +581,7 @@ public class CacheLoaderInterceptor<K, V> extends JmxStatsCommandInterceptor {
Publisher<CacheEntry<K, V>> publisher = flowable
.map(me -> (CacheEntry<K, V>) PersistenceUtil.convert(me, iceFactory));
// This way we don't subscribe to the flowable until after the f... | [CacheLoaderInterceptor->[visitReadOnlyKeyCommand->[visitDataCommand],visitReadWriteKeyCommand->[visitDataCommand],visitReadWriteManyEntriesCommand->[visitManyDataCommand],visitReadWriteKeyValueCommand->[visitDataCommand],WrappedEntrySet->[contains->[contains,toEntry],remove->[remove,toEntry],innerIterator->[stream,ite... | This method is called from the inner iterator. | Does doubling the fetch size make a significant difference to performance? I'm not against the change, just curious. |
@@ -50,6 +50,11 @@
<% else %>
<h1><%= @episode.title %></h1>
<% end %>
+ <% if @episode.published_at.present? %>
+ <time class="published-at" datetime="<%= @episode.decorate.published_timestamp %>">
+ <%= @episode.decorate.readable_publish_date %>
+ </time>
+ <% e... | [No CFG could be retrieved] | Renders the n - ary card. Displays a menu with the podcast s nagios. | Btw, you can check it a bit shorter `@episode.published_at?` |
@@ -2530,6 +2530,17 @@ public class DoFnSignatures {
return signatureForDoFn(doFn).usesState() || requiresTimeSortedInput(doFn);
}
+ private static boolean containsBundleFinalizer(List<Parameter> parameters) {
+ return parameters.stream().anyMatch(parameter -> parameter instanceof BundleFinalizerParameter... | [DoFnSignatures->[getStateSpecOrThrow->[format],analyzeTimerFamilyDeclarations->[create],analyzeProcessElementMethod->[of,getExtraParameters,addParameter,create,setParameter],analyzeStateDeclarations->[of,create,getType],analyzeExtraParameter->[of,getAnnotations,doFnStartBundleContextTypeOf,hasParameter,doFnProcessCont... | Checks if the given DoFn is used in a state or in a state - level context. | Technically, the design of the class is to use `parameter.match(new Cases() { ... })` but I'll accept this. |
@@ -185,6 +185,9 @@ public class MailReceiverFactoryBean implements FactoryBean<MailReceiver>, Dispo
}
receiver.setMaxFetchSize(this.maxFetchSize);
receiver.setSelectorExpression(selectorExpression);
+ if (this.userFlag != null) {
+ receiver.setUserFlag(this.userFlag);
+ }
if (isPop3) {
if (this.i... | [MailReceiverFactoryBean->[destroy->[destroy],createReceiver->[setShouldDeleteMessages,setSearchTermStrategy,setShouldMarkMessagesAsRead,setBeanFactory,verifyProtocol,setSession,setMaxFetchSize,setJavaMailProperties,setSelectorExpression,isShouldMarkMessagesAsRead]]] | Creates a receiver based on the configuration. This method is called after all properties have been set. | Are we OK with **empty** flag? (I can fix on merge) |
@@ -76,7 +76,7 @@ $search_no_email = GETPOST("search_no_email", 'int');
if (!empty($conf->socialnetworks->enabled)) {
foreach ($socialnetworks as $key => $value) {
if ($value['active']) {
- $search_{$key} = GETPOST("search_".$key, 'alpha');
+ $search_[$key] = GETPOST("search_".$key, 'alpha');
}
}
}
| [fetch,selectMassAction,select_country,fetch_object,jdate,order,getNomUrl,selectarray,initHooks,plimit,showRoles,LibPubPriv,executeHooks,loadLangs,select_categories,escape,showCheckAddButtons,close,showFilterAndCheckAddButtons,free,query,fetch_name_optionals_label,getLibStatut,trans,num_rows,getOptionalsFromPost,multiS... | Get the restricted area of a contact. Get the values of the nation_number component. | curly bracket are used for arrays so an array called 'search_' Here we want to edit the variable call $search_abc where abc is value of $key. |
@@ -41,8 +41,11 @@ def _prepare_topo_plot(inst, ch_type, layout):
layout = find_layout(info) # XXX : why not passing ch_type???
elif layout == 'auto':
layout = None
-
- clean_ch_names = _clean_names(info['ch_names'])
+ if ch_type in ['hbo', 'hbr', 'fnirs_raw', 'fnirs_od']:
+ # The n... | [_init_anim->[set_values,_check_outlines,_hide_frame,_autoshrink,_GridData,_draw_outlines],plot_ica_components->[plot_ica_components,_check_outlines,_prepare_topo_plot,_add_colorbar,plot_topomap,_autoshrink],plot_arrowmap->[_trigradient,_prepare_topo_plot,plot_topomap,_check_outlines],_plot_topomap->[set_locations,_che... | Prepare topo plot. finds the topomap coordinates of the picks and merges the grads and the. | _clean_names is used in a number of places. I would rather avoid the branching here to make sure it's consistent with other places. How specific are NIRS channel names? What ch name breaks it? |
@@ -40,6 +40,7 @@ func TestConfig(t *testing.T) {
config: []byte(`{
"host": "localhost:3000",
"max_header_size": 8,
+ "idle_timeout": 4s,
"read_timeout": 3s,
"write_timeout": 4s,
"shutdown_timeout": 9s,
| [Unpack,Equal,NewConfigFrom,Sprintf,shouldOverwrite,isEnabled,NoError,NotNil,NewConfig,memoizedSmapMapper,Nil,Run] | TestConfig tests if a configuration is valid Config object for missing header. | odd that this whitespace didn't cause intake issues |
@@ -1,6 +1,7 @@
module DocAuth
class Response
- attr_reader :errors, :exception, :extra, :pii_from_doc
+ attr_reader :errors, :exception, :pii_from_doc
+ attr_accessor :extra # so we can chain extra analytics
def initialize(success:, errors: [], exception: nil, extra: {}, pii_from_doc: {})
@s... | [Response->[merge->[new,exception,merge,extra,success?,pii_from_doc,errors],to_h->[merge],attr_reader]] | Initialize a new object with all the attributes of the next object. | I'm not sure I like this `attr_accessor` ... I like the idea of immutable response objects --- if we want to combine stuff in, how about we use `#merge` to combine in new ones? Also techincally since `extra` is a hash, which is mutable by default, we could modify the `extra` with just an `attr_reader` still (not that I... |
@@ -58,6 +58,12 @@ RSpec.configure do |config|
config.before(:suite) do
Rails.application.load_seed
+
+ begin
+ REDIS_POOL.with { |client| client.clear }
+ rescue => connection_error
+ fail "#{connection_error}: It appears Redis is not running, but it is required for (some) specs to run"
+ ... | [current_driver,start,domain_name,clear_calls,infer_spec_type_from_file_location!,to,use_default_driver,host,before,add_filter,require,load_seed,include,use_transactional_fixtures,enable,each,around,puts,locale,call,clear_messages,stub_request,run,configure,maintain_test_schema!,exit,and_return,expand_path] | Checks for pending migrations before tests are run. Examples of how to use the feature - level configuration. | @solipet Does this still accomplish what you wanted? I'm not totally sure yet if doing a `.clear` will mess up the test suite in any way. |
@@ -56,4 +56,9 @@ if __name__ == "__main__":
if not pkg_path:
pkg_path = args.target_package
- check_call(["apistubgen", "--pkg-path", pkg_path,], cwd=args.work_dir)
+ cmds = ["apistubgen", "--pkg-path", pkg_path]
+ if args.out_path:
+ cmds.extend(["--out-path", os.path.join(args... | [get_package_wheel_path->[get_package_details,find_whl,join,getenv],abspath,add_argument,get_package_wheel_path,ArgumentParser,getLogger,parse_args,join,check_call] | Check if the package_path is set in args. | For my understanding where do we install the apistubgen code from azure-sdk-tools repo? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.