patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -452,7 +452,11 @@ func (c *Container) Signal(ctx context.Context, num int64) error {
}
if num == int64(syscall.SIGKILL) {
- return c.containerBase.kill(ctx)
+ err := c.containerBase.kill(ctx)
+ if err == nil {
+ publishContainerEvent(c.ExecConfig.ID, time.Now(), events.ContainerPoweredOff)
+ }
+ return ... | [OnEvent->[onStop,refresh,Remove,String,updateState],refresh->[refresh],stop->[transitionState,stop,SetState],LogReader->[Error],start->[start,SetState,transitionState],Error->[Error],Remove->[Remove,updateState],String] | Signal sends a signal to the container. | Wouldn't this result in the powered off event getting published twice in some cases? |
@@ -184,7 +184,7 @@ print '</tr>';
print '<tr class="oddeven"><td>'.$langs->trans("LDAPFieldFirstName").'</td><td>';
print '<input size="25" type="text" name="fieldfirstname" value="'.$conf->global->LDAP_FIELD_FIRSTNAME.'">';
print '</td><td>'.$langs->trans("LDAPFieldFirstNameExample").'</td>';
-print '<td align="ri... | [initAsSpecimen,rollback,connect_bind,dump_content,getRecords,trans,begin,delete,close,add,commit,_load_ldap_dn,load,_load_ldap_info] | This function prints a list of checkboxes that can be used to select a field. This function prints the login samba checkbox and password checkbox. | If selection of the key that is the common key to make sync is removed, how can we know what is the "common" key between the 2 systems ? |
@@ -1,6 +1,10 @@
<% content_for :title, t('students.account_settings') %>
-<% if @current_user.student? %>
- <%= form_with url: 'update_settings', method: 'patch', model: @current_user, local: true do |f| %>
+<%= form_with url: 'update_settings', method: 'patch', model: User, local: true do |f| %>
+ <p>
+ <%= f.l... | [No CFG could be retrieved] | Displays a list of key pairs that the user is allowed to manage Displays a table showing the key pair that was created. | You can check for other uses of the `:language` string, but now we should move it to `models/users/en.yml` under `attributes` as well. |
@@ -113,7 +113,14 @@ export default class JitsiStreamBackgroundEffect {
this._outputCanvasCtx.globalCompositeOperation = 'destination-over';
if (this._options.virtualBackground.isVirtualBackground) {
- this._outputCanvasCtx.drawImage(this._virtualImage, 0, 0);
+ this._virtualIm... | [No CFG could be retrieved] | Draws the run Tensorflow Interference. Loop function to render the background mask. | As discussed, this won't work and we'll work on a proper "object-fit cover" rendering of the background image in the canvas. |
@@ -166,6 +166,7 @@ public class SqlQueryExecution
this.schedulerStats = requireNonNull(schedulerStats, "schedulerStats is null");
this.statsCalculator = requireNonNull(statsCalculator, "statsCalculator is null");
this.costCalculator = requireNonNull(costCalculator, "costCalculato... | [SqlQueryExecution->[SqlQueryExecutionFactory->[createQueryExecution->[getSession,SqlQueryExecution]],recordHeartbeat->[recordHeartbeat],getQueryInfo->[getQueryId],analyze->[analyze],getExecutionStartTime->[getExecutionStartTime],addStateChangeListener->[addStateChangeListener],getUserMemoryReservation->[getUserMemoryR... | Construct a new instance of the class. | add a dedicate state change listener here for dynamic filtering that would: * register * deregister query when it's done |
@@ -300,6 +300,8 @@ func RegisterShootCreationFrameworkFlags() *ShootCreationConfig {
flag.StringVar(&newCfg.networkingServices, "networking-services", "", "the spec.networking.services to use for this shoot. Optional.")
flag.StringVar(&newCfg.networkingNodes, "networking-nodes", "", "the spec.networking.nodes to u... | [newShootFramework->[NewShootFramework],InitializeShootWithFlags->[Sprintf,GetCloudProfile,Join,Errorf],CreateShoot->[newShootFramework,InitializeShootWithFlags,Error,Infof,CreateShoot,ShootKubeconfigSecretName,DumpState,GetName,Fatalf,createShootResource],AfterEach->[CurrentGinkgoTestDescription,DumpState],StringVar,S... | Flags for the shoot. ----------- Config for the shoot creation. | Why we have `allowPrivilegedContainersFlag` and `allowPrivilegedContainers`? Can't we just have `flag.BoolVar` for `allowPrivilegedContainers`? |
@@ -449,14 +449,15 @@ func NewV2(cfg Config, clientConfig client.Config, limits *validation.Overrides,
i := &Ingester{
cfg: cfg,
clientConfig: clientConfig,
- metrics: newIngesterMetrics(registerer, false, cfg.ActiveSeriesMetricsEnabled),
limits: limits,
chunkStore: nil,
use... | [v2LabelValues->[Close,Querier],Head->[Head],v2QueryStreamChunks->[ChunkQuerier,Close],Blocks->[Blocks],Close->[Close],getMemorySeriesMetric->[Head],createTSDB->[Compact,Head,updateCachedShippedBlocks,setLastUpdate],PreCreation->[Head],v2LifecyclerFlush->[shipBlocks,compactBlocks],closeAllTSDB->[Close],v2QueryStreamSam... | NewV2 returns a new Ingester that uses Cortex block storage instead of chunks central_ingester_oldest_unshipped_block_timestamp_seconds. | [question, cause I'm unsure] Default `RateUpdatePeriod` is 15s. I'm wondering if it's a good setting for this use case. Basically we could get 15x spike in 1 single second (and we'll accept it) but then we'll reject any sample for the next 14s, right? |
@@ -593,7 +593,9 @@ if ($action == 'create' || $action == 'confirm_paiement' || $action == 'add_paie
print '<td align="right">'.$alreadypayedlabel.'</td>';
print '<td align="right">'.$remaindertopay.'</td>';
print '<td align="right">'.$langs->trans('PaymentAmount').'</... | [fetch,addPaymentToBank,create,formconfirm,fetch_object,getSommePaiement,jdate,getNomUrl,rollback,begin,initHooks,select_comptes,load,plimit,getSumCreditNotesUsed,transnoentities,executeHooks,loadLangs,select_types_paiements,close,selectDate,free,query,trans,num_rows,hasDelay,fetch_thirdparty,commit,getSumDepositsUsed] | Print a list of all possible payment units for a given facture. Get the ith in the database. | $objp seems not defined. printObjectLineTitle is a hook dedicated to show the sublines of an object (lines of an invoice, lines of an order). May be you want to use the hood printFieldListTitle ? |
@@ -0,0 +1,15 @@
+<?php
+/**
+ * Inline Help FAB icon template.
+ *
+ * @package automattic/jetpack
+ */
+
+// phpcs:disable VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable
+?>
+
+<div class="a8c-faux-inline-help">
+ <a class="a8c-faux-inline-help__button" href="<?php echo esc_url( $args['href'] ); ?>"... | [No CFG could be retrieved] | No Summary Found. | This is no longer needed, right? |
@@ -309,7 +309,7 @@ public class DataTypeBuilderTestCase extends AbstractMuleTestCase {
DataType.builder().type(custom.loadClass(Message.class.getName())).build();
custom = null;
- new PollingProber().check(new JUnitLambdaProbe(() -> {
+ new PollingProber(10000, 100).check(new JUnitLambdaProbe(() -> {... | [DataTypeBuilderTestCase->[cacheClean->[loadClass->[loadClass]]]] | Cache clean. | Can constants be used here? Are there any existing contasts in abstract test cases? |
@@ -169,6 +169,14 @@ function updateReporters(config) {
if (argv.saucelabs) {
config.reporters.push('saucelabs');
}
+
+ const testTypeAllowList = ['unit', 'integration'];
+ if (isTravisPushBuild() && testTypeAllowList.includes(config.testType)) {
+ config.reporters.push('json-result');
+ config.jsonR... | [No CFG could be retrieved] | Creates a new object with the unit test paths and the test reporters. The main entry point for the karma plugin. | nit: wrap the array in `new Set()` and use `allowedTestTypes.has(config.testType)`. Approving to unblock |
@@ -1,6 +1,5 @@
<% title "O RLY Parody Book Generator" %>
<%= stylesheet_link_tag "application", media: "all" %>
-<link href='https://fonts.googleapis.com/css?family=Roboto' rel='stylesheet' type='text/css'>
<%= javascript_include_tag "application" %>
<%= content_for :page_meta do %>
| [No CFG could be retrieved] | Efficiently generates a single NI - Link object. Displays a hidden block of content that is not part of the system. | Just another fix sneaked in. |
@@ -149,7 +149,7 @@ namespace System.Text.Json.Tests
}
[Fact]
- // https://github.com/dotnet/corefx/issues/39067.
+ // https://github.com/dotnet/runtime/issues/30095.
public static void Regression39067_TestingDateTimeMinValue()
{
string jsonString = @"""0... | [Utf8JsonReaderTests->[TestingStringsConversionToDateTimeOffset->[TokenType,TryGetDateTimeOffset,Equal,nameof,ValidISO8601Tests,BytesConsumed,GetDateTimeOffset,String,Parse,Read,GetBytes,Length,True],TestingDateTimeMaxValue->[TokenType,Equal,Length,JsonSerializer,BytesConsumed,String,Parse,Read,TryGetDateTime,GetBytes,... | Tests that a date time is in a valid state. | Same issue here (test name with issue number no longer matches, we should remove the number). |
@@ -43,6 +43,6 @@ class MfaConfirmationController < ApplicationController
def handle_max_password_attempts_reached
analytics.track_event(Analytics::PASSWORD_MAX_ATTEMPTS)
sign_out
- redirect_to root_url, alert: t('errors.max_password_attempts_reached')
+ redirect_to root_url, flash: { error: t('error... | [MfaConfirmationController->[handle_max_password_attempts_reached->[track_event,redirect_to,t],password->[require],create->[valid_password?],handle_valid_password->[redirect_to,login_two_factor_authenticator_url,user_two_factor_authentication_url,totp_enabled?],handle_invalid_password->[redirect_to,t,to_i],before_actio... | If the user has reached the max password attempts then redirect to the root page. If the. | TIL `redirect_to` can also set the flash! |
@@ -19,9 +19,9 @@
<li>When you're ready to publish, set the published variable to <strong>true.</strong></li>
</ul>
-<p><em><b>We have two editor versions</b>. If you'd prefer to edit title and tags etc. as separate fields, switch to the "rich + markdown" option in <a href="/settings/customization">/settings/cust... | [No CFG could be retrieved] | A simple example of how to display a unique identifier. List of all possible links to the canonical version of the content. | Should we be using `→` rather than the `->` here? |
@@ -81,7 +81,8 @@ module.exports = {
}
}
- let {buttonLabel, defaultPath, filters, properties, title} = options
+ let {buttonLabel, defaultPath, filters, properties, title,
+ message} = options
if (properties == null) {
properties = ['openFile']
| [No CFG could be retrieved] | The main function that displays the user s access key. Open a dialog with the given options. | This is fine to keep on a single line, we don't enforce hard line length limits in JS. |
@@ -109,6 +109,16 @@ class Libfabric(AutotoolsPackage):
sha256='3b78d0ca1b223ff21b7f5b3627e67e358e3c18b700f86b017e2233fee7e88c2e',
placement='fabtests', when='@1.4.2')
+ conflicts('@1.9.0', when='platform=darwin',
+ msg='This distribution is missing critical files')
+
+ ... | [Libfabric->[install->[working_dir,Executable,isdir,super,format,configure,make],autoreconf->[which,working_dir,bash],installcheck->[satisfies,working_dir,Executable,isdir,make,fi_info],setup_build_environment->[prepend_path],configure_args->[append,format],depends_on,resource,version,patch,when,variant]] | Add build environment variables for the build process. | Alternatively, we could switch the checksums for all previous releases to download the tar.bz2 version and get rid of this function. That would make the package simpler. |
@@ -33,3 +33,5 @@ class AutotoolsGen:
else:
build_env.save_sh("conanbuildenv.sh")
run_env.save_sh("conanrunenv.sh")
+
+ self.toolchain.generate()
| [AutotoolsGen->[generate->[run_environment,build_environment],run_environment->[run_environment],build_environment->[build_environment]]] | Generate a new build environment. | This is confusing, as it will generate an extra, unused file. Move the AutotoolsToolchain CONAN_TOOLCHAIN_ARGS_FILE functionality to its own method, and call just that method. |
@@ -186,6 +186,12 @@ public class RStudio implements EntryPoint
RootLayoutPanel.get(),
dismissProgressAnimation);
}
+ else if (DataViewerSatellite.NAME.equals(view))
+ {
+ RStudioGinjector.I... | [RStudio->[ensureStylesInjected->[ensureStylesInjected],delayLoadApplication->[onFailure->[execute]]]] | delayLoadApplication - Loads the application and activates it if it is not loaded. | Awesome that you created a satellite for his!!! I'm assuming even in the presence of multiple data views in the Source pane that there is only ever one satellite that just switches datasets as necessary. Is that correct? |
@@ -1320,9 +1320,6 @@ CELERY_DISABLE_RATE_LIMITS = True
# Super temporary. Or Not.
MARKETPLACE = False
-# Name of view to use for homepage.
-HOME = 'addons.views.home'
-
# Default file storage mechanism that holds media.
DEFAULT_FILE_STORAGE = 'amo.utils.LocalFileStorage'
| [read_only_mode->[list,insert,get,tuple,index,Exception],lazy_langs->[dict,lower],JINJA_CONFIG->[MemcachedBytecodeCache],path,abspath,lazy,basename,dict,gethostname,dirname,client_from_dict_config,join,lower] | The client to use. The timeout in seconds for a single non - zero object. | Is a kitten revived when a setting is removed? :) |
@@ -23,6 +23,7 @@ namespace Friendica\Module\Api\Friendica;
use Friendica\DI;
use Friendica\Module\BaseApi;
+require_once __DIR__ . '/../../../../include/api.php';
/**
* api/friendica
| [No CFG could be retrieved] | Creates a class which implements the action. | why do we need this here? |
@@ -190,7 +190,7 @@ func printPlan(result *planResult) (ResourceChanges, error) {
actions := newPreviewActions(result.Options)
_, _, _, err := result.Walk(actions, true)
if err != nil {
- return nil, errors.Wrapf(err, "An error occurred while advancing the preview")
+ return nil, errors.New("An error occurred w... | [Close->[Close],Chdir->[Wrapf,Chdir,IgnoreError,Getwd],Walk->[Next,IgnoreError,Apply,Start,Close,Assert],IsObject,IsAssets,GetProject,Old,ArrayValue,NewArchiveProperty,Assertf,BoolValue,DiffLinesToChars,DiffMain,IsBool,PropertyKey,NewEvalSource,NewPlan,IsNull,Diff,Walk,IsOutput,Color,Strings,preludeEvent,Itoa,NewAssetP... | Generate a plan that creates a resource and returns it. walking the iterator until we get a non - nil error. | Nit, should this be lower case like our other error messages? |
@@ -416,10 +416,10 @@ describe('IntersectionObserver', () => {
const messages = [];
const ioInstance = new IntersectionObserver(element, testIframe);
insert(testIframe);
- sandbox.stub(testIframe.contentWindow, 'postMessage', message => {
+ testIframe.contentWindow.postMessage = message => {
... | [No CFG could be retrieved] | This test tests that the element has an intersection with another element. Copy because arg is modified in place. | FMI: Why stubbing is a cause of problems here? |
@@ -442,7 +442,7 @@ public class CoreExtensionModelTestCase {
public void scatterGather() {
final ConstructModel scatterGatherModel = coreExtensionModel.getConstructModel("scatterGather").get();
-
+ // assertOutputsListOfMessages(scatterGatherModel);
assertThat(scatterGatherModel.getAllParameterModels... | [CoreExtensionModelTestCase->[tryScope->[getName,getAllParameterModels,isRequired,get,getType,hasSize,is,instanceOf,assertThat,getExpressionSupport],assertComponentDeterminesOutput->[hasDynamicType,getType,is,instanceOf,assertThat],consistentWithManifest->[getName,getVendor,getDescription,getCategory,is,assertThat,getV... | test method for scatterGather This method checks that the routeModel has a name minOccurs maxOccurs and all parameterModels. | remove? add a TODO? |
@@ -0,0 +1,10 @@
+# -*- encoding : utf-8 -*-
+class RemoveCommentTypeFromComment < ActiveRecord::Migration
+ def up
+ remove_column :comments, :comment_type
+ end
+
+ def down
+ add_column :comments, :comment_type, :string, :null => false, :default => 'request'
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Line is too long. [87/80] |
@@ -2979,7 +2979,12 @@ Spdp::SpdpTransport::handle_input(ACE_HANDLE h)
DCPS::RcHandle<Spdp> outer = outer_.lock();
if (outer) {
- outer->data_received(data, plist, remote);
+ if (valid_size(remote)) {
+ outer->data_received(data, plist, remote);
+ } else {
+ ... | [No CFG could be retrieved] | DDS - has_MINIMUM_BIT DDS - has_MINIMUM_BIT - - - - - - - - - - - - - - - - - -. | Move this up as far as it can go -- in other words, why not check `remote`'s validity right after that object is written to? |
@@ -79,6 +79,10 @@ final class ItemMutationResolverFactory implements ResolverFactoryInterface
$normalizationContext = $resourceMetadata->getGraphqlAttribute($operationName ?? '', 'normalization_context', [], true);
$normalizationContext['attributes'] = $this->fieldsToAttributes($info);
+ ... | [ItemMutationResolverFactory->[validate->[validate]]] | Creates a callback that will create a new node in the graph. Normalizes an item and returns it if it is a . | you should store the result of `lcfirst($resourceMetadata->getShortName())` in a variable instead of computing it 3 times. |
@@ -13,7 +13,6 @@ namespace System.Net.WebSockets.Client.Tests
{
private static readonly Lazy<bool> s_WebSocketSupported = new Lazy<bool>(InitWebSocketSupported);
public static bool WebSocketsSupported { get { return s_WebSocketSupported.Value; } }
-
public static async Task TestEcho(
... | [WebSocketHelper->[Task->[Count,NormalClosure,SendAsync,CloseStatus,GetTextFromBuffer,CloseAsync,CloseStatusDescription,Closed,Token,GetBufferFromText,Null,State,EndOfMessage,Array,Equal,CloseSent,Offset,MessageType,CloseReceived,ReceiveAsync,WriteLine,GetConnectedWebSocket,Open,Length,True],GetConnectedWebSocket->[Tot... | Sends a message to the connected WebSocket and waits for a response. Check if the close status is normal closure and close message is equal to cws. Close. | Revert this change |
@@ -0,0 +1,4 @@
+package libvirt
+
+type MachineVM struct {
+}
| [No CFG could be retrieved] | No Summary Found. | If this is nonfunctional, it can probably be left out. |
@@ -27,4 +27,4 @@
* @return {function(number):T}
* @template T
*/
-var TransitionDef = function(unusedNormtime, unusedCompleted) {};
+const TransitionDef = function(unusedNormtime, unusedCompleted) {};
| [No CFG could be retrieved] | Telephone number transition. | Shouldn't be linting. |
@@ -238,6 +238,13 @@ func (t *UIThreadLoader) mergeLocalRemoteThread(ctx context.Context, remoteThrea
newMsg.GetMessageID())
return true
}
+ // If the message was exploded by someone, include it
+ if newMsg.Valid().ExplodedBy() != nil &&
+ (oldMsg.Valid().ExplodedBy() == nil || *newMsg.Valid().ExplodedB... | [GetMessagesRemote->[GetMessagesRemote],waitForOnline->[IsOffline],Load->[messageIDControlToPagination,makeRi],LoadNonblock->[setUIStatus,singleFlightConv,applyPagerModeOutgoing,waitForOnline,isConsolidateMsg,dispatchOldPagesJob,makeRi,mergeLocalRemoteThread,applyPagerModeIncoming,shouldIgnoreError,messageIDControlToPa... | mergeLocalRemoteThread merges a remote thread into a local thread. This is a helper function that is used to determine if a message is in the local thread unknown get thread cb mode. | what includes an exploded message that just ran out of time? |
@@ -11,7 +11,7 @@ RSpec.describe Articles::ActiveThreadsQuery, type: :query do
article = create(:article, tags: "discuss", score: described_class::MINIMUM_SCORE + 1)
create(:article, published_at: 2.days.ago, tags: "discuss", score: described_class::MINIMUM_SCORE + 1)
- result = described_cla... | [call,path,create,context,to,days,describe,before,ago,eq,now,it,require] | Describe the active - threads query returns any article when no higher - quality article could be found. | Likewise, we no longer need `options{...}` in the spec either (same goes for line `22`). |
@@ -241,6 +241,15 @@ class V00_MarkeplaceAdapter {
fromBlock: this.blockEpoch
})
+ // if an account is passed in, we're looking for the listing state at the time
+ // that account made an offer, so find the block number of the offer
+ // and ignore any "ListingUpdated" events after that block num... | [No CFG could be retrieved] | Get the raw listing data for a given listingId. Get the list item from the list. | I may not fully get what's going on here, but it seems that it may cause trouble to use `account` for getting old versions of a listing. For example, couldn't an account have multiple offers open on the same listing? E.g. I bought one beanie baby, but then the next day the seller got green ones in stock so I decided to... |
@@ -103,7 +103,7 @@ class DirectoryLuceneV4 extends Directory implements DirectoryExtensions {
*/
@Override
public void close() {
- isOpen = false;
+ // Note the we don't really keep track of this anymore
}
@Override
| [DirectoryLuceneV4->[createOutput->[createOutput],renameFile->[renameFile],fileExists->[fileExists],openInput->[openInput],fileLength->[fileLength],deleteFile->[deleteFile]]] | Close the object. | we loose the ability to close the Infinispan directory. is it the expected? |
@@ -783,10 +783,14 @@ def random_string() -> str:
return binascii.hexlify(os.urandom(8)).decode('ascii')
+def compute_md5_hash(text: str) -> str:
+ return hashlib.md5(text.encode('utf-8')).hexdigest()
+
+
def write_cache(id: str, path: str, tree: MypyFile,
dependencies: List[str], suppress... | [load_graph->[State,parse_file,has_new_submodules],strongly_connected_components->[dfs->[dfs],dfs],order_ascc->[order_ascc],State->[parse_file->[parse_file,read_with_python_encoding,wrap_context,all_imported_modules_in_file,check_blockers,log],patch_parent->[trace,log],wrap_context->[check_blockers],__init__->[find_cac... | Writes a cache file for a module. Write the meta data to a temporary file. | This probably shouldn't have "md5" in its name -- just `compute_hash()` sounds better, in case we want to switch hash implementations in the future. |
@@ -137,10 +137,14 @@ size_t ossl_crngt_get_entropy(PROV_DRBG *drbg,
OSSL_SELF_TEST_DESC_RNG);
}
- while ((q = rand_pool_bytes_needed(pool, 1)) > 0 && attempts-- > 0) {
- s = q > sizeof(buf) ? sizeof(buf) : q;
- if (!crngt_get_entropy(libctx, crngt_glob->crngt_poo... | [ossl_crngt_cleanup_entropy->[OPENSSL_secure_clear_free],ossl_crngt_get_entropy->[OSSL_SELF_TEST_free,rand_pool_add,OSSL_SELF_TEST_new,rand_pool_new,ossl_lib_ctx_get_data,OSSL_SELF_TEST_onbegin,prov_crngt_compare_previous,memcpy,PROV_LIBCTX_OF,rand_pool_detach,OSSL_SELF_TEST_onend,OPENSSL_cleanse,crngt_get_entropy,OSSL... | Get entropy of a given node. if md == crngt_glob. crngt_prev sz == 0 mem. | Don't we still need to do this if we used the `buf` in the last iteration of the loop above? |
@@ -24,7 +24,7 @@ function get_salmon_key($uri,$keyhash) {
// We have found at least one key URL
// If it's inline, parse it - otherwise get the key
- if(count($ret)) {
+ if(count($ret) > 0) {
for($x = 0; $x < count($ret); $x ++) {
if(substr($ret[$x],0,5) === 'data:') {
if(strstr($ret[$x],','))
| [slapper->[get_curl_code,get_curl_headers]] | Get the salmon key for a given uri Returns a list of all the possible values for the current request. | Standards: Could you please add a space after the `if`? |
@@ -239,10 +239,17 @@ public class StateProviderImpl implements StateProvider {
// no need to filter out state transfer generated transactions because there should not be any such transactions running for any of the requested segments
for (CacheTransaction tx : transactions) {
+ ... | [StateProviderImpl->[startOutboundTransfer->[getCacheTopology],getCacheTopology->[getCacheTopology],onTaskCompletion->[removeTransfer]]] | Collect all transactions that are not running on any of the requested segments. | Should be '==' instead of '<=', in order to skip txs started after state transfer. |
@@ -59,13 +59,13 @@ if(!$install) {
Config::load();
if ($a->max_processes_reached() OR $a->maxload_reached()) {
- header($_SERVER["SERVER_PROTOCOL"].' 503 Service Temporarily Unavailable');
+ header($_SERVER["SERVER_PROTOCOL"] . ' 503 Service Temporarily Unavailable');
header('Retry-After: 120');
- header('... | [is_backend,query,get_scheme,save_timestamp,loadHTML,init_page_end,max_processes_reached,appendChild,init_pagehead,maxload_reached,saveHTML,loadXML,importNode] | Load configuration file which contains our DB credentials. The main entry point for the . | Standards: Can you please add a space after commas? |
@@ -68,7 +68,7 @@ class FlinkUberJarJobServer(abstract_job_service.AbstractJobServiceServicer):
'the scheme is specified. If using a local file path, make sure '
'the file exists; you may have to first build the job server '
'using `./gradlew runners:flink:%s:job-server:shad... | [FlinkBeamJob->[_get_state->[get,delete_jar],get_metrics->[get],get_message_stream->[get,get_state_stream],delete_jar->[delete],run->[post],get_state->[_get_state],post->[request],get->[request],get_state_stream->[_state_iter->[get_state],_state_iter],delete->[request],cancel->[post]],FlinkUberJarJobServer->[create_bea... | Returns the executable jar. | Is the server always up when we make this call? |
@@ -25,7 +25,7 @@ public class JmsRequestResponseTestCase extends AbstractJmsFunctionalTestCase {
@Test
public void testNotSendiningCorrelationIDWithTemporaryQueue() throws Exception {
InternalMessage response =
- flowRunner("JMSNoCorrelationIDTemporaryQueue").nonBlocking().withPayload(TEST_MESSAGE).r... | [JmsRequestResponseTestCase->[testNotSendiningCorrelationIDWithFixedQueue->[getMessage,verify,assertEchoResponse],testNotSendiningCorrelationIDWithTemporaryQueue->[getMessage,verify,assertEchoResponse],testSendiningCorrelationIDWithTemporaryQueue->[assertFixedEchoResponse,getMessage,verify],assertFixedEchoResponse->[ge... | Test not sending correlation id with temporary queue. | should this class extend the new abstract class to continue testing the non blocking scenarios? |
@@ -19,4 +19,4 @@
/**
* Package contains classes related to S3 security responses.
*/
-package org.apache.hadoop.ozone.om.request.s3.security;
+package org.apache.hadoop.ozone.om.response.s3.security;
| [No CFG could be retrieved] | Package contains classes related to S3 security responses. | This might go into a separate pull request and we may commit it way before the branch is commited. |
@@ -437,6 +437,11 @@ static WRITE_TRAN ossl_statem_server13_write_transition(SSL *s)
st->hand_state = TLS_ST_SW_CERT_REQ;
return WRITE_TRAN_CONTINUE;
}
+ if (s->ext.extra_tickets_expected > 0) {
+ st->hand_state = TLS_ST_SW_SESSION_TICKET;
+ s->ext.extra_t... | [No CFG could be retrieved] | This function is the write transition of the server side. It is called by the write_ Private methods for the handshake state machine. | Is it feasible to move this decrement into the ticket processing itself? I've tried (not 100% successfully) to avoid side effects in the transition functions as much as possible. |
@@ -327,7 +327,7 @@ public class KafkaLookupExtractorFactory implements LookupExtractorFactory
}
@Override
- public boolean replaces(@Nullable LookupExtractorFactory other)
+ public boolean equals(@Nullable Object other)
{
if (this == other) {
return false;
| [KafkaLookupExtractorFactory->[getCompletedEventCount->[get],start->[getKafkaTopic,getKafkaProperties],get->[getCacheKey->[get],isInjective,get],replaces->[getKafkaTopic,getConnectTimeout,isInjective,getKafkaProperties],close->[getKafkaTopic,close]]] | Checks if this lookup extractor factory replaces the given one. | I explicitly had this as replaces so as to differentiate it from the java object `equals` method. And to make it extremely specific in what the boolean value means. |
@@ -262,6 +262,11 @@ export class VariableService {
this.register_('EXPERIMENT_BRANCHES', (opt_expName) =>
experimentBranchesMacro(this.ampdoc_.win, opt_expName)
);
+
+ // Returns the content of a meta tag in the ampdoc
+ this.register_('AMPDOC_META', (meta, defaultValue = '') => {
+ return ... | [VariableService->[getMacros->[CUMULATIVE_LAYOUT_SHIFT,FIRST_VIEWPORT_READY,dev,FIRST_INPUT_DELAY,MAKE_BODY_VISIBLE,performanceFor,isInFie,cookieReader,LARGEST_CONTENTFUL_PAINT_VISIBLE,getConsentStateStr,FIRST_CONTENTFUL_PAINT_VISIBLE],constructor->[round,trim,dict,viewportForDoc,String,toUpperCase,stringToBool,toLower... | A macro that can be used to determine if a tag is missing. Returns a promise that resolves to the viewport. getScrollTop. | Is this transformed by babel or closure? |
@@ -395,7 +395,7 @@ define([
* Query parameters appended to the url.
*
* @memberof Resource.prototype
- * @type {Object}
+ * @type {*}
*
* @readonly
*/
| [No CFG could be retrieved] | Creates a new Resource object if the given resource is a String or a Resource object if the The base class for the object. | Revert this one |
@@ -65,7 +65,7 @@ namespace System
case PlatformID.Unix: os = "Unix "; break;
case PlatformID.Xbox: os = "Xbox "; break;
case PlatformID.MacOSX: os = "Mac OS X "; break;
- case PlatformID.Other: os = "Other"; break;
+ ... | [OperatingSystem->[Unix,Format,nameof,Win32S,Win32NT,Empty,Major,IsNullOrEmpty,Xbox,Minor,Other,WinCE,Fail,ToString,Win32Windows,MacOSX,Arg_EnumIllegalVal]] | Private method for getting the version string. | What test should have caught this? |
@@ -184,11 +184,12 @@ def main():
render_start = time.time()
+ frames_processed += 1
if len(boxes) and args.raw_output_message:
- log.info('Detected boxes:')
- log.info(' Class ID | Confidence | XMIN | YMIN | XMAX | YMAX ')
+ log.debug(' --... | [build_argparser->[add_argument_group,ArgumentParser,add_argument],main->[round,get_type,Visualizer,check_model,asarray,basicConfig,reportMeans,fps,RuntimeError,transpose,info,requests,infer,int,imshow,open_images_capture,min,postprocessor,visualizer,Presenter,build_argparser,VideoWriter,with_suffix,time,add_extension,... | Main function for the IRAF filter. This function is a loop that reads the image and returns the n - th image in the Start a object. find next key in the window. | In some demos, object_detection for instance, frames counting in raw outputs starts with 0, in others, like here it starts with 1. I think it should always start with 0, like in cpp demos. |
@@ -176,6 +176,9 @@ int ACE_TMAIN (int argc, ACE_TCHAR *argv[])
ACE_OS::sleep (1);
}
+ // Let reader acknowledge the data.
+ ACE_OS::sleep (3);
+
// ----------------------------------------------
// Now switch first reader/subscriber from A to B
// and it should be conne... | [No CFG could be retrieved] | This function is called from DDS when a new message arrives. It will wait for This method is called when the listener servant has received more messages than expected messages. | Is there another mechanism we could use here? |
@@ -122,10 +122,13 @@ def search_packages_info(query):
yield package
-def print_results(distributions, list_files=False, verbose=False):
+def print_results(distributions, list_files=False, verbose=False, json=False):
"""
Print the informations from installed distributions found.
"""
+ if ... | [ShowCommand->[__init__->[add_option,insert_option_group,super],run->[warning,print_results,search_packages_info]],print_results->[get,strip,join,requires,info,enumerate],search_packages_info->[requires,join,startswith,get_metadata,append,len,sorted,isinstance,feed,close,canonicalize_name,relpath,split,FeedParser,get,s... | Print the informations from installed distributions. | It would seem cleaner to have 2 functions: `print_header_format` (the legacy one) and `print_json` |
@@ -33,9 +33,7 @@ class LegacyAddressMapper(AddressMapper):
self._build_root = build_root
def scan_build_files(self, base_path):
- subject = DescendantAddresses(base_path)
- selector = SelectDependencies(BuildFiles, BuildDirs, field_types=(Dir,))
- request = self._scheduler.selection_request([(select... | [LegacyAddressMapper->[scan_addresses->[_internal_scan_specs]]] | Scan build files for build files that are not dependencies of base_path. | I think this method is now unused inside pants itself. It's not marked public. Could I just remove it rather than adjusting to it's use case? I think it is also untested, which makes me |
@@ -117,7 +117,6 @@ class Checkout(CountableDjangoObjectType):
"created",
"discount_name",
"gift_cards",
- "is_shipping_required",
"last_change",
"note",
"quantity",
| [Checkout->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]]] | The Checkout class is a base class for all fields of a countable DjangoObjectType. Relations for nodes. | Is it expected? |
@@ -0,0 +1,15 @@
+using Robust.Shared.GameObjects;
+
+namespace Content.Server.GameObjects.Components.Sound
+{
+ /// <summary>
+ /// Simple sound emitter that emits sound on ActivateInWorld
+ /// </summary>
+ [RegisterComponent]
+ public class EmitSoundOnActivateComponent : BaseEmitSoundComponent
+ {
... | [No CFG could be retrieved] | No Summary Found. | has to also add this one, since UseInHand has no Activate functionality |
@@ -100,7 +100,7 @@ define([
* @param {ModelAnimationLoop} [options.loop=ModelAnimationLoop.NONE] Determines if and how the animation is looped.
* @returns {ModelAnimation} The animation that was added to the collection.
*
- * @exception {DeveloperError} Animations are not loaded. Wait for the {@... | [No CFG could be retrieved] | This method is used to add a new model animation to the animation collection. provide all properties and events. | Typo here and throughout, `Model#readtPromise`. I would have just fixed it, but I wanted to ask if the `{@link Model#readtPromise}` markup in the `DeveloperError` below resolves to a link in our exception display? |
@@ -1,5 +1,5 @@
/*
- * Copyright 2016 The OpenSSL Project Authors. All Rights Reserved.
+ * Copyright 2016-2017 The OpenSSL Project Authors. All Rights Reserved.
*
* Licensed under the OpenSSL license (the "License"). You may not use
* this file except in compliance with the License. You can obtain a copy
| [test_main->[TEST_error,strcmp,run_tests,ADD_TEST],int->[myOpenSSL_version_num,shlib_sym,TEST_int_eq,TEST_ptr,mySSL_CTX_free,shlib_close,GetProcAddress,mySSL_CTX_new,shlib_load,dlsym,myTLS_method,FreeLibrary,LoadLibraryA,myERR_get_error,dlopen,TEST_true,dlclose]] | Creates a typedef for the given n - tuple. returns 0 if the object is not found - 1 if the object is not found - 1. | done. I checked the Copyright headers in that directory and I wanted to ask if that one is correct: x509_dup_cert_test.c: * Copyright (c) 2017 Oracle and/or its affiliates. All rights reserved. |
@@ -282,8 +282,14 @@ class Optimizer(object):
# This is a default implementation of apply_gradients() that can be shared
# by most optimizers. It relies on the subclass implementing the following
# methods: _create_slots(), _prepare(), _apply_dense(), and _apply_sparse().
+
+ grads_to_tensors_list = ... | [Optimizer->[_get_or_make_slot->[_slot_dict],_zeros_slot->[_slot_dict]]] | This method is the second part of minimize. It returns an Operation that applies the specified gradients colocate all ops created in _apply_dense or _apply_sparse depending on. | I think this line is redundant now. (It was previously necessary in order to be able to iterate over the argument twice, when the argument was a generator expression. However, you now only iterate over it once.) |
@@ -17,7 +17,7 @@ func ComplianceReport(in <-chan message.Compliance) <-chan message.Compliance {
out := make(chan message.Compliance, 100)
go func() {
for msg := range in {
- logrus.WithFields(logrus.Fields{"report_id": msg.Report.ReportUuid}).Info("Processing Compliance Report")
+ logrus.WithFields(logrus.... | [CurrentTime,GetStatistics,GetRelease,FinishProcessingCompliance,Sprintf,Debug,GetName,GetDuration,Parse,Errorf,ReportProfilesFromInSpecProfiles,Info,GetPlatform,WithFields] | ComplianceReport imports and returns a channel of message. Compliance messages. This function is called to populate the InspecReport fields of the passed in message. | Switched some messages to Debug to remove some of the log clutter. |
@@ -696,6 +696,12 @@ class _BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin,
-------
evoked : instance of Evoked
The averaged epochs.
+
+ Notes
+ -----
+ Computes an average of ALL epochs in the instance, even if
+ they correspond to differ... | [EpochsArray->[__init__->[_detrend_offset_decim,drop_bad_epochs]],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],_BaseEpochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_goo... | Compute the average of epochs and standard errors over epochs. | I don't like the all caps, just make it "all". |
@@ -9,5 +9,8 @@ module Constants
Organization
Extensions
].freeze
+
+ VALID_URL = %r{\A(http|https)://([/|.\w\s-])*.[a-z]{2,5}(:[0-9]{1,5})?(/.*)?\z}.freeze
+ URL_MESSAGE = "must be a valid URL".freeze
end
end
| [freeze] | Freeze all the elements of an organization. | the ultimate URL regexp :D |
@@ -494,6 +494,9 @@ ds_mgmt_create_pool(uuid_t pool_uuid, const char *group, char *tgt_dev,
struct mgmt_svc *svc;
d_rank_list_t *rank_list;
uuid_t *tgt_uuids = NULL;
+ d_rank_list_t *filtered_targets = NULL;
+ d_rank_list_t *pg_ranks = NULL;
+ uint32_t pg_size;
int rc;
int rc_cleanup;
| [No CFG could be retrieved] | This function deletes the specified nvme or nvme pool from the rdb. allocate service and target pools. | Does this problem occur only with the new Go MS or also with the current C MS? The C MS guarantees that the local crt primary group on the service leader always matches the system map. (If an error occurs when updating the leader's local crt primary group, the leader steps down.) Hence, it just needs to check if the in... |
@@ -17,10 +17,12 @@ import (
"fmt"
"strconv"
+ "go.uber.org/zap"
+
+ log "github.com/pingcap/log"
"github.com/pingcap/pd/server/cache"
"github.com/pingcap/pd/server/core"
"github.com/pingcap/pd/server/schedule"
- log "github.com/sirupsen/logrus"
)
func init() {
| [Schedule->[GetName],createOperator->[GetName],transferLeaderIn->[GetName],transferLeaderOut->[GetName]] | newBalanceLeaderScheduler creates a scheduler that tends to keep leaders on each store in opController returns a function that returns the name of the node with the given id. | Remove empty line? |
@@ -24,7 +24,7 @@ module GobiertoAdmin
end
def test_content_block_record_update_records
- with_javascript do
+ with(js: true) do
with_signed_in_admin(admin) do
with_current_site(site) do
visit @path
| [ContentBlockRecordTest->[test_content_block_record_remove_attachments->[visit,trigger,within,with_signed_in_admin,all,find,has_content?,assert,has_no_content?,click_button,with_javascript,first,with_current_site,last],site->[sites],test_content_block_record_update_records->[visit,fill_in,trigger,within,with_signed_in_... | This test is used to test if a content block record update records are present. | Block has too many lines. [31/25] |
@@ -410,14 +410,13 @@ public class Schema implements Serializable {
// Returns the type of this field.
public abstract TypeName getTypeName();
+ // Whether this type is nullable.
+ public abstract Boolean getNullable();
+
// For container types (e.g. ARRAY), returns the type of the contained elem... | [Schema->[fromFields->[Schema],of->[build],Builder->[addFields->[addFields],build->[Schema]],typesEqual->[typesEqual,equals],equals->[equals],equivalent->[equivalent],builder->[Builder],assignableTo->[equivalent],assignableToIgnoreNullable->[equivalent],Field->[of->[build],withType->[build],typesEqual->[equals,getNulla... | The type of the field in the map. | I wonder if a convenience method `FieldType nullable() { return toBuilder().setNullable(true).build(); }` would make sense |
@@ -600,8 +600,8 @@ void Server::handleCommand_InventoryAction(NetworkPacket* pkt)
<< std::endl;
std::istringstream is(datastring, std::ios_base::binary);
// Create an action
- InventoryAction *a = InventoryAction::deSerialize(is);
- if (!a) {
+ std::unique_ptr<InventoryAction> a(InventoryAction::deSerialize(is)... | [handleCommand_Interact->[process_PlayerPos,checkInteractDistance],handleCommand_PlayerPos->[process_PlayerPos]] | Handle an incoming command that is an inventory action. This method is called by a player when a move action is received from another player. Delete an action from a craftpreview to a craftresult This function is called by the action system when a action is not handled by a player. | unique_ptr overrides bool() such that this line did not need to change. ie: `!a` and `!a.get()` are equivalent |
@@ -1643,7 +1643,7 @@ public /*transient*/ abstract class Computer extends Actionable implements Acces
*/
@CLIResolver
public static Computer resolveForCLI(
- @Argument(required=true,metaVar="NAME",usage="Agent name, or empty string for master") String name) throws CmdLineException {
+ ... | [Computer->[getDescription->[getNode],getActions->[getActions],getACL->[getACL],isOnline->[isOffline],relocateOldLogs->[getName,relocateOldLogs],getMonitorData->[getName],setNode->[getNumExecutors],_doScript->[getChannel,getACL,_doScript],updateByXml->[getNode],remove->[remove],waitUntilOnline->[isOnline],waitUntilOffl... | Resolves a given node in the ComputerSet. | Is something missing after "throws"? |
@@ -320,8 +320,9 @@ def plot_trans(info, trans='auto', subject=None, subjects_dir=None,
show EEG sensors in their digitized locations or projected onto the
scalp, or a list of these options including ``[]`` (equivalent of
False).
- dig : bool
- If True, plot the digitization points.... | [plot_dipole_locations->[_toggle_mlab_render,_create_mesh_surf],plot_source_estimates->[_limits_to_control_points],_sensor_shape->[_make_tris_fan],plot_trans->[_create_mesh_surf]] | Plot the head sensor and source space alignment in 3D. Plots a single in the MegCoils GUI. Missing - imports the MLB from Megutils. Return a object. Get a missing - nans nans in a given frame. get the n - th non - zero n - th non - zero n - th non Brain and any skull surface. | "fiducials" to plot fiducial points only. -> Use "mri_fiducials" to plot fiducial points only. |
@@ -334,7 +334,7 @@ zfs_retire_recv(fmd_hdl_t *hdl, fmd_event_t *ep, nvlist_t *nvl,
*/
if (strcmp(class, "resource.fs.zfs.removed") == 0 ||
(strcmp(class, "resource.fs.zfs.statechange") == 0 &&
- state == VDEV_STATE_REMOVED)) {
+ (state == VDEV_STATE_REMOVED || state == VDEV_STATE_FAULTED))) {
cha... | [int->[zpool_close,zpool_get_prop_int],nvlist_t->[fmd_module_hdl,nvlist_lookup_uint64,find_vdev,nvlist_lookup_nvlist_array,fmd_hdl_debug],zpool_handle_t->[zpool_close,zpool_iter,zpool_get_config,find_vdev,nvlist_lookup_nvlist],boolean_t->[free,nvlist_add_string,nvlist_free,zpool_get_config,basename,nvlist_add_nvlist_ar... | zfs_retire_recv - recv callback for zfs_retire_recv zfs_vdev_open - zfs. zfs. statechange. z pair - switch to zfs faults and return the action This function is called from FM daemon when a ZFS fault is detected. | This doesn't seem quite right There are different states for REMOVED and FAULTED vdevs and the logic here is only for handling removed vdevs. The code for handling faulted vdevs is at the end of this function. We should figure out why it's occasionally not kicking in a spare. Perhaps it's not in the FM_SUSPECT_FAULT_LI... |
@@ -2,5 +2,5 @@
</div>
<div class="wrapLeft">
<h2><%= I18n.t("admins.edit_admin") %></h2>
-<%= render :partial => "layouts/userform" %>
+<%= render :partial => "layouts/userform", :locals => { :controller => 'admins', :action => 'edit'} %>
</div>
| [No CFG could be retrieved] | Hierarchical element that contains a single unique identifier. | I'm sorry to mention that now that you have a ship, but could you please reformat the code using max 80 char ? Else, I'll patch it, but I'd rather see dev take good habits right now, then to patch everything again :) |
@@ -2628,7 +2628,8 @@ public class BigQueryIO {
public TableReference getOrCreateTable(BigQueryOptions options, String tableSpec)
throws IOException {
TableReference tableReference = parseTableSpec(tableSpec);
- if (!createdTables.contains(tableSpec)) {
+ if (!createdTables.contains(table... | [BigQueryIO->[displayTable->[TableRefToTableSpec],PassThroughThenCleanup->[expand->[apply]],verifyTablePresence->[getTable,toTableSpec],BigQueryQuerySource->[populateDisplayData->[populateDisplayData],create->[BigQueryQuerySource],TableRefToJson,TableRefToProjectId],TransformingSource->[getEstimatedSizeBytes->[getEstim... | Get or create a table in BigQuery. | swap check order? `createdTables` is a concurrent data structure. |
@@ -20,6 +20,7 @@ namespace Dynamo.UI.Views
{
// See OnExpanderButtonMouseLeftButtonUp for details.
private bool ignoreMouseEnter;
+ private LibraryDragAndDrop drag_drop = new LibraryDragAndDrop();
public LibraryView()
{
| [LibraryView->[StartDrag->[Copy,DataContext,DoDragDrop,OriginalSource,Model],OnSubCategoryListViewPreviewKeyDown->[Handled],OnExpanderButtonMouseLeftButtonUp->[DataContext,SetDataContext],OnExpanderButtonMouseLeftButtonDown->[GetPosition],OnClassButtonCollapse->[Handled,IsSelected],ExpandCategory->[ExpandCategory,Items... | Implementation of the base class for handling missing properties. When a mouse wheel is pressed it scrolls the library view vertically. | Maybe call this `dragDropHelper`? |
@@ -163,10 +163,12 @@ static void checkException(JNIEnv *env) {
static void ffi_fun(ffi_cif *cif, void *ret, void **args, void *user_data) {
JNIEnv* env = getCurrentEnv();
- static jmethodID ffiFunImpl0 = NULL;
+ static jmethodID acceptFun = NULL;
static jclass cls = NULL;
- if (ffiFunImpl0 == NUL... | [No CFG could be retrieved] | Returns the JNI environment which can be used by the caller. - FFI - CIF - CIF - CIF - CIF - CIF. | I'd wrote it as `(jlong)(intptr_t)&retAndArgs[0]` for clarity. |
@@ -159,11 +159,8 @@ import org.slf4j.LoggerFactory;
* <li><b>How many shards are generated per pane:</b> This is controlled by <i>sharding</i>, using
* {@link Write#withNumShards} or {@link Write#withSharding}. The default is runner-specific,
* so the number of shards will vary based on runner beha... | [FileIO->[MatchConfiguration->[withEmptyMatchTreatment->[build],continuously->[build]],Match->[filepattern->[filepattern,build],withConfiguration->[build],expand->[withConfiguration,getConfiguration],withEmptyMatchTreatment->[withConfiguration,withEmptyMatchTreatment],populateDisplayData->[populateDisplayData,getConfig... | This method writes a set of elements from a given window and pane to a file. How a given set of elements is written to a shard. | bounded and unbounded? I think normally we refer to 'bounded' for batch pipelines. Do we support this for both? |
@@ -710,7 +710,7 @@ test_log(void **state)
setenv("D_LOG_MASK", "T2=WARN", 1);
setenv("DD_MASK", "trace", 1);
d_log_sync_mask();
- D_STRNDUP(logmask, "T2=WARN", 32);
+ D_STRNDUP(logmask, "T2=WARN", 8);
assert_non_null(logmask);
rc = d_log_setmasks(logmask, -1);
| [No CFG could be retrieved] | Test debug mask bits. Get the debug bits of the specified node. | why not D_STRNDUP_S ? |
@@ -613,6 +613,11 @@ static BOOL VIRTUALReleaseMemory( PCMI pMemoryToBeReleased )
}
}
+ if (pVirtualMemoryLastFound->startBoundary >= pMemoryToBeReleased->startBoundary)
+ {
+ pVirtualMemoryLastFound = NULL;
+ }
+
#if MMAP_IGNORES_HINT
// We've removed the block from our allocated ... | [No CFG could be retrieved] | Internal method to remove a non - critical section from the virtual memory list. Convert win32 protection flags to internal flags. | Why >=? Should this not be == instead? |
@@ -633,6 +633,14 @@ func translateSpan(span pdata.Span, metadata model.Metadata, event *model.Span)
event.DB = &db
case isMessagingSpan:
event.Type = "messaging"
+ event.Subtype = message.System
+ event.Action = message.Operation
+ event.Name = message.Name()
+ // TODO: This is what we want to do? Followin... | [convertResourceSpans->[At,Resource,Len,InstrumentationLibrarySpans,convertInstrumentationLibrarySpans],convertSpan->[ParentSpanID,AsTime,HexString,Status,IsEmpty,NewLogger,Seconds,At,Name,TraceID,Sub,EndTime,Kind,SpanID,Len,StartTime,Events,After],convert->[convertResourceSpans,At,ResourceSpans,Len],ConsumeTraces->[Pr... | parse the event type and the destination service from the peer address unless peer. service was specified parseSamplerAttributes parses the sampler type and the probability of the event and updates the. | We use the OpenTelemetry span's name everywhere else - I think we should do the same here (and not set `event.Name` here.) |
@@ -231,6 +231,9 @@ func (g *generator) GenFunctionCallExpression(w io.Writer, expr *model.FunctionC
g.genNYI(w, "ReadFile")
case "readDir":
contract.Failf("unlowered toJSON function expression @ %v", expr.SyntaxNode().Range())
+ case "secret":
+ // TODO: generate an appropriate type assertion
+ g.Fgenf(w, "p... | [rewriteThenForAllApply->[argumentTypeName],genApply->[genAnonymousFunctionExpression,argumentTypeName],argumentTypeName->[argumentTypeName],GenFunctionCallExpression->[GenFunctionCallExpression],GenTemplateExpression->[GenLiteralValueExpression],genLiteralValueExpression->[genLiteralValueExpression],GenUnaryOpExpressi... | GenFunctionCallExpression generates code for a function call expression. genNYI - generate NYI functions for apply generate a function call that returns a string. | I'll follow an issue to track fixing this. |
@@ -87,14 +87,13 @@ static int check_content(CMS_ContentInfo *cms)
static void do_free_upto(BIO *f, BIO *upto)
{
- if (upto) {
+ if (upto != NULL) {
BIO *tbio;
do {
tbio = BIO_pop(f);
BIO_free(f);
f = tbio;
- }
- while (f && f != upto);
+ ... | [CMS_sign_receipt->[CMS_sign],CMS_compress->[CMS_final],CMS_decrypt->[CMS_decrypt_set1_pkey],CMS_verify_receipt->[CMS_verify]] | free upto - free all BIOs f - f - upto - f -. | Is there a reason you wanna walk past NULL? |
@@ -134,3 +134,12 @@ func TestReadSearchResult_invalid(t *testing.T) {
func newTestClient(url string) *Client {
return newTestClientAuth(url, "", "")
}
+
+func (r QueryResult) String() string {
+ out, err := json.Marshal(r)
+ if err != nil {
+ logp.Warn("failed to marshal QueryResult (%v): %#v", err, r)
+ return ... | [Nil,Equal,Error] | newTestClient creates a new client with the given URL. | ah, was only used for testing? |
@@ -31,6 +31,8 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Map;
+import javax.sql.rowset.serial.SerialException;
+
public class KsqlDelimitedDeserializer implements Deserializer<GenericRow> {
private final Schema schema;
| [KsqlDelimitedDeserializer->[enforceFieldType->[parseDouble,parseInt,type,parseBoolean,parseLong,KsqlException],deserialize->[ArrayList,enforceFieldType,schema,SerializationException,size,get,String,GenericRow,isEmpty,add,KsqlException,getRecords]]] | This class is used to deserialize a delimited list of records from a CSV file. Reads the next record from the CSV file. | not sure why this was added? |
@@ -51,6 +51,15 @@ def _import_h5py():
return h5py
+def get_matfile_version():
+ """Triage import path based on SciPy version."""
+ try:
+ from scipy.io.matlab.miobase import get_matfile_version
+ except ModuleNotFoundError: # scipy 1.8
+ from scipy.io._matlab.miobase import get_matfile... | [_handle_scipy_ndarray->[_check_for_scipy_mat_struct],_handle_hdf5_group->[_hdf5todict],_handle_hdf5_dataset->[_hdf5todict],_todict_from_np_struct->[_check_for_scipy_mat_struct],_handle_hdf5_strings->[_convert_string_hdf5],_check_for_scipy_mat_struct->[_check_for_scipy_mat_struct],_hdf5todict->[_import_h5py,_hdf5todict... | Recursively converts a hdf5 object to a python dictionary. | This might actually be a good function to have in the `scipy.io.matlab` namespace, any interest in making a PR to SciPy to add it @drammock ? |
@@ -225,7 +225,7 @@ namespace System.Text.Encodings.Web
{
if (!_allowedCharacters.IsUnicodeScalarAllowed(ptr[idx]))
{
- goto Return;
+ return idx;
}
... | [UnsafeRelaxedJavaScriptEncoder->[FindFirstCharacterToEncodeUtf8->[WillEncode],TryEncodeUnicodeScalar->[WillEncode]]] | This method is called to find the first character that can be encoded in UTF - 8. This method checks if there is a unicode codepoint that needs to be escaped within the 16 bytes. | @kunalspathak I made those changes in an attempt to improve overall clarity, however I can't help but think that there might be a legitimate performance reason for using `goto` instead of inlining the return statement. |
@@ -20,6 +20,7 @@ import java.util.regex.Pattern;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
+
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
| [ConfigurableGlobDatasetFinder->[findDatasets->[newArrayList,isPresent,matches,add,globStatus,datasetAtPath,info,getPath],requiredProperties->[newArrayList],Path,of,getProperty,checkArgument,getLogger,requiredProperties,isNullOrEmpty,absent,compile,containsKey]] | Package that contains all the necessary imports for a given object. Logger for the dataset. | Missing license head. |
@@ -56,12 +56,8 @@ func (s *testClusterSuite) TestCluster(c *C) {
c2 := &metapb.Cluster{}
r := config.ReplicationConfig{
- EnablePlacementRules: true,
- MaxReplicas: 6,
+ MaxReplicas: 6,
}
- // Cannot set the replicas when placement rules is enabled.
- c.Assert(s.svr.SetReplicationConfig(r), NotNil)... | [SetUpSuite->[Sprintf,GetAddr],TestCluster->[Sprintf,testGetClusterStatus,SetReplicationConfig,Assert],testGetClusterStatus->[Sprintf,Now,SetReplicationConfig,Assert,IsZero,After],TearDownSuite->[cleanup]] | TestCluster tests cluster consistency. | Why remove it? |
@@ -173,12 +173,12 @@ public class LuceneSearchTest {
assertThat(results).isNotEmpty();
}
- @Test
+ //@Test
public void canDeleteNull() throws IOException {
// give
// looks like a bug in web UI: it tries to delete a note twice (after it has just been deleted)
// when
- noteSearchServic... | [LuceneSearchTest->[canIndexAndQueryByParagraphTitle->[query,newNoteWithParagraph,isNotEmpty,isAtLeast,drainEvents,contains],indexParagraphUpdatedOnNoteSave->[setText,newNoteWithParagraph,isFalse,isNotEmpty,isEqualTo,resultForQuery,newNoteWithParagraphs,drainEvents,getLastParagraph,saveNote],indexNoteNameUpdatedOnNoteS... | This method checks if the given note can be indexed and re - indexed. | A null check in `deleteNoteIndex` should be sufficient to re-enable this test. |
@@ -190,8 +190,9 @@ function dropListenSentinel(listenSentinel) {
/**
* Registers the global listenFor event listener if it has yet to be.
* @param {!Window} parentWin
+ * @param {string=} typeKey Key to index event type.
*/
-function registerGlobalListenerIfNeeded(parentWin) {
+function registerGlobalListenerIf... | [No CFG could be retrieved] | Determines if a window is a descendant of another window. Listens for a message of type type and calls the listeners. | Are you sure this will perform the way you expect? My fear is that the first to call will impose what typeKey is required. |
@@ -68,9 +68,3 @@ def update_products_minimal_variant_prices_of_discount_task(discount_pk: int):
def update_products_minimal_variant_prices_task(product_ids: List[int]):
products = Product.objects.filter(pk__in=product_ids)
update_products_minimal_variant_prices(products)
-
-
-@app.task
-def update_all_produ... | [update_products_minimal_variant_prices_of_catalogues_task->[update_products_minimal_variant_prices_of_catalogues],update_product_minimal_variant_price_task->[update_product_minimal_variant_price,get],update_variants_names->[filter,get,_update_variants_names],update_products_minimal_variant_prices_task->[filter,update_... | Update all productsimal variant prices. | AFAIK this task was created to future usage from celery beat. But I am not sure. You can ask @derenio |
@@ -86,6 +86,8 @@ public class SwapSummaryFieldMap implements Record {
public static SwapSummary getSwapSummary(final Record record, final ResourceClaimManager claimManager) {
final int flowFileCount = (Integer) record.getFieldValue(SwapSchema.FLOWFILE_COUNT);
final long flowFileSize = (Long) rec... | [SwapSummaryFieldMap->[getSwapSummary->[getFieldValue]]] | Get the swap summary. | Cannot case these from `Long` to `long` because they may be `null`. Anything swap files that were written out in a previous version will not have these fields. So these need to be checked for `null` and if it is `null` can default to 0 perhaps? I tried starting up with swap files generated from the `main` branch just t... |
@@ -343,6 +343,8 @@ module.exports = JhipsterClientGenerator.extend({
this.template(ANGULAR_DIR + 'blocks/config/_compile.config.ts', ANGULAR_DIR + 'blocks/config/compile.config.ts', this, {});
this.template(ANGULAR_DIR + 'blocks/config/_uib-pager.config.ts', ANGULAR_DIR + 'blocks/config/uib-p... | [No CFG could be retrieved] | Template functions for all blocks. Package for activate page. | put the pipes under `components/util` plz |
@@ -53,7 +53,7 @@ public class BenchmarkResourceGroup
@Benchmark
public Object benchmark(BenchmarkData data)
{
- data.getRoot().processQueuedQueries();
+ data.getRoot().updateGroupsAndProcessQueuedQueries();
return data.getRoot();
}
| [BenchmarkResourceGroup->[main->[build,run],benchmark->[processQueuedQueries,getRoot],BenchmarkData->[setup->[DataSize,getOrCreateSubGroup,setHardConcurrencyLimit,build,setSoftMemoryLimit,setMaxQueuedQueries,run,RootInternalResourceGroup,valueOf],tearDown->[shutdownNow],newSingleThreadExecutor]]] | Benchmarks a series of queued queries. | What are the benchmark results for large trees? |
@@ -9081,12 +9081,9 @@ def crop_tensor(x, shape=None, offsets=None, name=None):
return out
-def affine_grid(theta, out_shape, name=None):
+def affine_grid(theta, out_shape, name=None, align_corners=True,
+ use_cudnn=True):
"""
- :alias_main: paddle.nn.functional.affine_grid
- :alias: pad... | [reduce_sum->[reduce_sum],ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],crop_tensor->[_attr_shape_check,_attr_offsets_check],slice->[slice],reshape->[get_attr_shape],resize_trilinear->[image_resize],mul->[mul],py_func->[PyFuncRegistry],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op_in_dyg... | Generates a grid of x y coordinates using the parameters of the affine transformation that correspond to Returns a sequence of random variables with a single non - zero value. | put `name` last, remove `use_cudnn` a new version should be be add in nn.functional since arguments have changed |
@@ -60,8 +60,9 @@ export class AmpAutoAds extends AMP.BaseElement {
const placements = getPlacementsFromConfigObj(this.win, configObj);
const attributes = Object.assign(adNetwork.getAttributes(),
getAttributesFromConfigObj(configObj));
- const adTracker = new AdTracker(getExistingAds(this.... | [No CFG could be retrieved] | Provides a base class for the target number of ads for the page. AmpAutoAd Load AMP - Auto - Ads config from a remote server. | Why not just pass in the `adNetwork`? |
@@ -46,6 +46,7 @@ namespace PythonNodeModelsWpf
nodeModel.CodeMigrated += OnNodeModelCodeMigrated;
InitializeComponent();
+ this.DataContext = this;
if (Dynamo.Configuration.DebugModes.IsEnabled("PythonEngineSelectionUIDebugMode"))
{
| [ScriptEditorWindow->[OnEngineChanged->[UpdateScript],OnRunClicked->[UpdateScript],OnMigrationAssistantClicked->[UpdateScript]]] | ScriptEditorWindow creates a new instance of ScriptEditorWindow. DynamoViewModel. ShowTabsAndSpacesInScriptEditor. | DataContext was null before |
@@ -35,3 +35,18 @@ func (s *Stellar) Upkeep(ctx context.Context) error {
}
func (s *Stellar) OnLogout() {}
+
+func (s *Stellar) SetServerDefinitions(ctx context.Context, def stellar1.StellarServerDefinitions) error {
+ s.cachedServerConf = def
+ return nil
+}
+
+func (s *Stellar) GetServerDefinitions(ctx context.Co... | [Upkeep->[G],CreateWalletGated->[G],CreateWalletSoft->[G],SetStellar,NewContextified] | OnLogout is called when the user logs out. | Should be threadsafe |
@@ -14,6 +14,7 @@
* limitations under the License.
*/
+const ANIMATION_TIME = 50;
const config = describes.sandboxed.configure().ifChrome();
config.run('amp-fx-collection', {}, function () {
const css = `
| [No CFG could be retrieved] | Displays a hidden element with a hidden class and a animation to fade in the dialog when the Animation is not visible if it is spread over 50% of the viewport. | Where is this default defined on the runtime code? |
@@ -117,7 +117,7 @@ final class ApiPlatformExtension extends Extension implements PrependExtensionIn
}
/**
- * Enables JSON-LD and Hydra support.
+ * Enables JSON-LD, HAL and Hydra support.
*
* @param XmlFileLoader $loader
*/
| [ApiPlatformExtension->[load->[load],enableJsonLd->[load]]] | Enable jsonld and hydra. | Why the change here? `hal.xml` is not being loaded here... |
@@ -54,6 +54,13 @@ class PythonSolver:
"""
pass
+ def AddAdditionalHistoricalVariables(self, list_additional_variables):
+ """This function adds additional historical variables to the ModelPart
+ Those can e.g. be needed by processes or utilities.
+ It has to be called BEFORE... | [PythonSolver->[ValidateSettings->[GetDefaultParameters]]] | Add the Variables and Dofs to the ModelPart . | I completely forgot, this fct cannot return a list as a solver might have multiple ModelParts! Instead it should be a map with name-mp to name-var thx to pybind this should also work from c++ |
@@ -660,11 +660,10 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
this.extensions_./*OK*/installExtensionForDoc(
this.getAmpDoc(), 'amp-analytics');
}
-
const refreshInterval = Number(responseHeaders.get('amp-force-refresh'));
- if (refreshInterval && !getPublisherSpecifiedR... | [AmpAdNetworkDoubleclickImpl->[extractSize->[getPublisherSpecifiedRefreshInterval,width,height,extractAmpAnalyticsConfig,get,setGoogleLifecycleVarsFromHeaders,Number],getBlockParameters_->[serializeTargeting_,dev,user,isInManualExperiment,Number,assign,join,googleBlockParameters,getMultiSizeDimensions,map],constructor-... | Extract the size from the response headers. | I don't think you need this here given layoutCallback would just trigger refresh naturally. Also, why did you remove the getPublisherSpecifiedRefreshInterval? |
@@ -156,6 +156,17 @@ namespace Internal.Runtime.CompilerServices
[Intrinsic]
[NonVersionable]
[MethodImpl(MethodImplOptions.AggressiveInlining)]
+ internal static ref T Add<T>(ref T source, nint elementOffset)
+ {
+ return ref Unsafe.Add(ref source, (IntPtr)(void*)ele... | [No CFG could be retrieved] | Adds an element offset to the given reference and returns the resulting object. Checks if the memory address referenced by the given references is greater than the memory address referenced by. | Once C# adds native ints, these overloads will be deleted because of they will be redundant with the IntPtr ones. |
@@ -411,6 +411,18 @@ func (host *defaultHost) SignalCancellation() error {
return result
}
+func (host *defaultHost) CloseProvider(provider Provider) error {
+ // NOTE: we're abusing loadPlugin in order to ensure proper synchronization.
+ _, err := host.loadPlugin(func() (interface{}, error) {
+ if err := provide... | [GetRequiredPlugins->[LanguageRuntime,GetRequiredPlugins],EnsurePlugins->[LanguageRuntime,Analyzer,Provider],LanguageRuntime->[loadPlugin],SignalCancellation->[SignalCancellation],Close->[Close],Analyzer->[loadPlugin],Provider->[loadPlugin]] | SignalCancellation signals that all resources are cancelled and shuts down the host s gRPC server. | should we rename `loadPlugin`, then? |
@@ -138,7 +138,7 @@ func (s *ProjectState) CreateProject(ctx context.Context,
return nil, status.Error(codes.InvalidArgument, err.Error())
}
return nil, status.Errorf(codes.Internal,
- "error retrieving project with ID %q: %s", req.Id, err.Error())
+ "error creating project with ID %q: %s", req.Id, err.Er... | [ListProjects->[ListProjects],DeleteRule->[DeleteRule],CreateProject->[CreateProject],UpdateRule->[UpdateRule],CreateRule->[CreateRule],ListProjectsForIntrospection->[ListProjects],GetProject->[GetProject],ListRulesForProject->[ListRulesForProject],UpdateProject->[UpdateProject]] | CreateProject creates a new project in the store. | PR Bonus: correct the error text. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.