patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -34,10 +34,6 @@ public class AsyncContextImpl implements AsyncContext {
private RpcContext storedServerContext;
public AsyncContextImpl() {
- }
-
- public AsyncContextImpl(CompletableFuture<Object> future) {
- this.future = future;
this.storedContext = RpcContext.getContext();
... | [AsyncContextImpl->[write->[IllegalStateException,stop,isAsyncStarted,complete,completeExceptionally],start->[set],stop->[compareAndSet],isAsyncStarted->[get],signalContextSwitch->[restoreContext,restoreServerContext],getContext,getLogger,getServerContext,AtomicBoolean]] | Writes the given value to the response. | as RpcContext.getContext() and RpcContext.getServerContext() is are per thread specific and can be available to caller using based on thread, so should we store them as separate member variable of this class? What do you say? |
@@ -142,8 +142,8 @@ class Version(OnChangeMixin, ModelBase):
parsed_data = utils.parse_addon(upload, addon)
license_id = None
if channel == amo.RELEASE_CHANNEL_LISTED:
- previous_version = addon.find_latest_version_including_rejected(
- channel=channel)
+ ... | [update_status->[update_status],Version->[is_public->[is_public],transformer->[rollup,_compat_map],is_allowed_upload->[compatible_platforms],from_upload->[VersionCreateError,from_upload],transformer_activity->[rollup],delete->[save],VersionManager],inherit_nomination->[reset_nomination_time],License->[LicenseManager],V... | Create a new version from an upload. This method is called by the upload thread. It is called by the upload thread. It. | There's an argument to exclude Beta because after #4529 beta versions don't get the details step where we'd ask for confirmation of the license. (Though they'd get one anyway because of lines below). |
@@ -1069,15 +1069,14 @@ static uint64_t dw_dma_work(void *data, uint64_t delay)
tracev_dma("wrk");
- /* skip if channel is not running */
if (p->chan[i].status != COMP_STATE_ACTIVE) {
trace_dma_error("eDs");
- goto out;
+ /* skip if channel is not running */
+ return 0;
}
dw_dma_process_block(&p->ch... | [inline->[io_reg_update_bits,interrupt_disable,DW_CFG_HIGH,DW_CFG_LOW,dw_write,interrupt_unregister,dma_irq,dma_base,DW_CTRL_LOW,DW_CTLH_CLASS,interrupt_enable,dma_get_drvdata,DW_CTRL_HIGH,io_reg_write,interrupt_register,CHAN_ENABLE,DW_DAR,DW_SAR,trace_event,cpu_get_id,io_reg_read],int->[spin_unlock_irq,atomic_init,ARR... | This function is called from the DMA thread. | @libinyang You are just removing the error case while still keeping the trace_dma_error. That doesn't seem to address the root cause, does it? |
@@ -1,3 +1,11 @@
+'''Two scatter plots one representing # Cylinders vs. MPG and the second graph representing acceleration vs. MPG
+
+.. bokeh-example-metadata::
+ :apis: bokeh.plotting.Figure.circle
+ :refs: :ref:`plotting_scatter` > :ref:`plotting_scatter_circle`
+ :keywords: scatter, acceleration, mpg, cyli... | [ColumnDataSource,show,output_file,circle,row,jitter,figure] | Plot a row of linked brushing examples for a single node. | This leaves out the best part about the linked brushing! Take it for a test run with `python examples/plotting/file/linked_brushing.py` |
@@ -24,6 +24,8 @@ abstract class BaseXmlFormatLoader extends FileLoader
const SCHEMA_URI = '';
+ const SCHEME_PATH = '';
+
const SCALE_MODE_DEFAULT = 'outbound';
const SCALE_RETINA_DEFAULT = false;
| [BaseXmlFormatLoader->[getOptionsFromFormatNode->[getParametersFromNode]]] | This class is a base class for all of the types which contain the common part of all Checks if the given resource supports a node. | normally set in the extended classes. as used in L166 with `static` the correct values from the extended classes is used. |
@@ -417,6 +417,7 @@ class Group extends BaseObject
'grouppage' => 'group/',
'$edittext' => L10n::t('Edit group'),
'$ungrouped' => $every === 'contacts' ? L10n::t('Contacts not in any group') : '',
+ '$ungrouped_selected' => (($group_id === 'none') ? 'group-selected' : ''),
'$createtext' => L10n::t('Cr... | [No CFG could be retrieved] | This function returns a sidebar widget for the given group and contacts. Group administration interface. | What's the difference between `$group_id === ''` and `$group_id === 'none'`? |
@@ -44,7 +44,7 @@ if TICI:
"./loggerd": 60.0,
"selfdrive.controls.controlsd": 26.0,
"./camerad": 25.0,
- "selfdrive.locationd.locationd": 21.0,
+ "./locationd": 3.2,
"selfdrive.controls.plannerd": 12.0,
"selfdrive.locationd.paramsd": 5.0,
"./_dmonitoringmodeld": 10.0,
| [TestOnroad->[test_cpu_usage->[check_cpu_usage]],check_cpu_usage->[cputime_total]] | Get CPU usage by process. Print the warning of the n - core processes that are not in the last_proc. | this one can be deleted, it's close enough to the C2 baseline |
@@ -167,6 +167,7 @@ class TestManagement(FormRecognizerTest):
error = op.error
assert error.code
assert error.message
+ assert error.details
@FormRecognizerPreparer()
@DocumentModelAdministrationClientPreparer()
| [TestManagement->[test_delete_model_empty_model_id->[raises,delete_model],test_get_form_recognizer_client_v2->[RequestsTransport,AzureKeyCredential,begin_recognize_receipts_from_url,get_account_properties,FormTrainingClient,get_form_recognizer_client],test_get_document_analysis_client->[RequestsTransport,AzureKeyCreden... | Test for get_operations. | Not asserting for the inner error? |
@@ -709,3 +709,14 @@ class NetworkClusterPrinterOutputDevice(NetworkPrinterOutputDevice.NetworkPrinte
@pyqtSlot(int, result=str)
def formatDuration(self, seconds):
return Duration(seconds).getDisplayString(DurationFormat.Format.Short)
+
+ ## For cluster below
+ def _get_plugin_directory_name(s... | [NetworkClusterPrinterOutputDevice->[sendPrintJob->[connect],_compressGcode->[_compressDataAndNotifyQt],_notifyFinishedPrintJobs->[__get_username],_notifyConfigurationChangeRequired->[__filterOurPrintJobs],_showRequestSucceededMessage->[connect],_onFinished->[_finishedPrintersRequest,_finishedPrintJobsRequest,_finished... | Format a duration in seconds. | Codestyle is wrong. Please change this. |
@@ -478,6 +478,16 @@ func (b *cloudBackend) Logout() error {
return workspace.DeleteAccessToken(b.CloudURL())
}
+// DoesProjectExist returns true if a project with the given name exists in this backend, or false otherwise.
+func (b *cloudBackend) DoesProjectExist(ctx context.Context, projectName string) (bool, err... | [GetStack->[GetStack],RenameStack->[RenameStack],GetLogs->[GetStack],CloudConsoleURL->[CloudURL],tryNextUpdate->[CloudURL],GetPolicyPack->[CloudURL,Name,parsePolicyPackReference],CancelCurrentUpdate->[GetStack],GetLatestConfiguration->[GetLatestConfiguration],GetStackTags->[GetStack],GetStackResourceOutputs->[GetStackR... | Logout returns a stack with the given id. | When we get to adding the ideal experience for #2421 (prompting for the owner), I think we'll need to modify this to allow passing the owner to `DoesProjectExist` since this is always only checking if the project exists in the user's account. |
@@ -165,6 +165,13 @@ module TwoFactorAuthenticatable
end
end
+ def resend_otp_code_path
+ otp_send_path(otp_delivery_selection_form: {
+ otp_method: @delivery_method,
+ resend: true
+ })
+ end
+
def reenter_phone_number_path
if context == 'id... | [phone_changed->[perform_later,create_user_event],update_invalid_user->[max_login_attempts?,second_factor_attempts_count,now,second_factor_locked_at,save],old_phone->[phone],authenticate_user->[authenticate_user!],reset_attempt_count_if_user_no_longer_locked_out->[no_longer_blocked_from_entering_2fa_code?,update],phone... | display_phone_to_deliver_to Display the phone number to deliver to . | I'd probably just put this one one line, if it fits. (looks like it would?) |
@@ -130,6 +130,15 @@
<button class="btn btn-primary float-right">Submit</button>
</div>
</div>
+ <div class="row">
+ <% if article.discussion_lock %>
+ Locked by: <%= article.discussion_lock.user_id %>
+ Locked: <%= article.discussion_lock.created_at %>
+ Reason: <%= ... | [No CFG could be retrieved] | Renders a hidden hidden input that is not part of the booster s list of categories. This method is used to find email messages that have not been sent in any of the following. | _Ignore this for right now, this is me messing with Admin_ |
@@ -118,7 +118,7 @@ func Migrate(ctx *context.APIContext, form auth.MigrateRepoForm) {
RepoName: form.RepoName,
Description: form.Description,
Private: form.Private || setting.Repository.ForcePrivate,
- Mirror: form.Mirror,
+ Mirror: form.Mirror && !setting.Repository.DisableM... | [NotifyMigrateRepository,IsErrNameCharsNotAllowed,GetUserByID,MigrateRepository,Stack,CreateRepository,Error,GetErrMsg,URLSanitizedError,New,IsErrReachLimitOfRepo,IsErrNameReserved,IsErrInvalidCloneAddr,HasError,IsOrganization,Trace,JSON,MaxCreationLimit,IsTwoFactorAuthError,IsErrNamePatternNotAllowed,IsOwnedBy,Contain... | if is a function that returns a single object which can be used to migrate a single create a new repository and return it. | I would had prefered to return an error |
@@ -500,7 +500,7 @@ export class ManualAdvancement extends AdvancementConfig {
// <span>).
const target = dev().assertElement(event.target);
- if (this.isInScreenSideEdge_(event, pageRect)) {
+ if (this.isInStoryPageSideEdge_(event, pageRect)) {
event.preventDefault();
return false;
... | [No CFG could be retrieved] | Checks if an element has to be descendant of a page or an attachment of a page. Checks if an element is inside of the bottom of the screen. | Second arg, `pageRect` can be removed here since you're using `storeService` in the function. |
@@ -33,6 +33,12 @@ func (g DashboardHandler) Append(router *mux.Router) {
Handler(http.StripPrefix("/dashboard/", http.FileServer(g.Assets)))
}
+func (g DashboardHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ // allow iframes from our domains only
+ w.Header().Set("Content-Security-Policy", "frame... | [Append->[Path,Handler,Error,HandlerFunc,FileServer,StripPrefix,WithoutContext,Redirect,PathPrefix,Methods],Get,Parse] | Append adds the dashboard to the router. | Is this something that we could configure with a default? I'm just thinking worst case scenario, if something happened to those records, users could temporarily override with a CLI arg, rather than having to use a rebuilt binary/image. |
@@ -251,7 +251,7 @@ func (bt *osquerybeat) Run(b *beat.Beat) error {
}
}
- setManagerPayload := func(itypes []string) {
+ setManagerPayload := func() {
if b.Manager != nil {
b.Manager.SetPayload(map[string]interface{}{
"osquery_version": distro.OsquerydVersion(),
| [Run->[initContext,Run,close],Stop->[close],execute->[executeQuery],executeQuery->[executeQueryWithLimiter]] | Run starts the osquerybeat Connect to the osqueryd socket and connect to the socket and connect to the socket. osquery - child process. | Shall we turn this into a method? This `Run` is becoming quite big. |
@@ -67,8 +67,8 @@ public final class MonitoringUtil {
private static final String JOB_MESSAGE_DETAILED = "JOB_MESSAGE_DETAILED";
private static final String JOB_MESSAGE_DEBUG = "JOB_MESSAGE_DEBUG";
- private String projectId;
- private Messages messagesClient;
+ private final String projectId;
+ private fin... | [MonitoringUtil->[getJobMessages->[getJobMessages,TimeStampComparator]]] | A utility class that provides a utility class to provide monitoring information about the given job. Log the message in the log. | If the `projectId` was available from the `dataflowClient` then we could get rid of the duplication of these fields in multiple places. |
@@ -56,10 +56,6 @@ EMPTY_GRAD_OP_LIST = [
# Special cases do not need to check grad
NO_NEED_CHECK_GRAD_CASES = [
- 'TestLookupTableOpWithPadding',
- 'TestLookupTableOpWithTensorIdsAndPadding',
- 'TestLookupTableOpWithPadding',
- 'TestLookupTableOpWithTensorIdsAndPadding',
'TestSeqMaxPool2DInference... | [No CFG could be retrieved] | This function is a wrapper for the various functions that are used in the FPN model. ED_CHECK_GRAD_CASES = [. | Other cases in `NO_NEED_CHECK_GRAD_CASES` will use the `skip_check_grad_ci` wrapper later? |
@@ -284,6 +284,7 @@ class PortableRunnerTestWithExternalEnv(PortableRunnerTest):
return options
+@pytest.mark.skipif(sys.platform == "win32", reason="does not run on windows")
class PortableRunnerTestWithSubprocesses(PortableRunnerTest):
_use_subprocesses = True
| [PortableRunnerTest->[create_pipeline->[create_options,get_runner],_create_job_endpoint->[_start_local_runner_subprocess_job_service],create_options->[_get_job_endpoint,get_pipeline_name],test_pardo_state_with_custom_key_coder->[AddIndex,create_pipeline,Input],_start_local_runner_subprocess_job_service->[_pick_unused_p... | Create options for portable runner. | Can we add a TODO(BEAM-....) and include an error that happens in the Jira? Does the error happen on all Python versions? Similarly for other errors. |
@@ -19,7 +19,6 @@ public interface IAbstractPlaceDelegate extends IAbstractMoveDelegate<UndoablePl
@RemoteActionCode(13)
String placeUnits(Collection<Unit> units, Territory at, BidMode bidMode);
- @RemoteActionCode(12)
default String placeUnits(final Collection<Unit> units, final Territory at) {
return... | [placeUnits->[placeUnits]] | placeUnits method for remote action. | Technically not needed, this method is only ever invoked in test code, so the annotation is redundant |
@@ -68,6 +68,8 @@ def filter_checkout_search(qs, _, value):
filter_option = Q(Exists(users.filter(id=OuterRef("user_id"))))
+ filter_option |= Q(metadata__icontains=value)
+
if checkout_id := get_checkout_token_from_query(value):
filter_option |= Q(token=checkout_id)
| [filter_checkout_search->[filter_checkout_by_payment,get_checkout_token_from_query,get_payment_id_from_query]] | Filter the given queryset by a user_id or a token. | `__icontains` is a performance killer, use `__ilike` instead. |
@@ -274,6 +274,16 @@ public class Help extends BasePresenter implements ShowHelpHandler
openCheatSheet("sparklyr_cheat_sheet");
}
+ void onOpenPurrrCheatSheet()
+ {
+ openCheatSheet("purrr_cheat_sheet");
+ }
+
+ void onBrowseCheatSheets()
+ {
+ globalDisplay_.openWindow("https://w... | [Help->[onNavigate->[getUrl],home->[showHelp],onSelection->[showHelp],onActivateHelp->[focus],onRefreshHelp->[refresh],onListChanged->[getHistory,addLink,getLinks,clearLinks,navigated,showHelp,getUrl],showHelp->[showHelp],onShowHelp->[showHelp],onHelpBack->[back],onHelpPopout->[popout],onPrintHelp->[print],onHelpForwar... | onOpenSparklyrCheatSheet - open sparklyr_cheat. | Should we omit the protocol here? (so that `http` vs. `https` can be automatically chosen?) |
@@ -7,6 +7,13 @@ Fabricator(:user_second_factor_totp, from: :user_second_factor) do
method UserSecondFactor.methods[:totp]
end
+Fabricator(:user_second_factor_webauthn, from: :user_second_factor) do
+ user
+ data 'TODO (martin) - fill this in with a good approximation'
+ enabled true
+ method UserSecondFactor... | [method,enabled,methods,data] | Tenant - second - factor fabricator. | No time like the present :) |
@@ -120,7 +120,8 @@ RSpec.describe ApplicationHelper, type: :helper do
end
it "has the correct text in the a tag" do
- expect(helper.collection_link(collection)).to have_text("#{collection.slug} (#{collection.articles.published.size} Part Series)")
+ expect(helper.collection_link(collection)).to
+... | [create,let,be,size,describe,slug,it,to,have_selector,before,have_text,require,to_s,start_with,have_link,path,context,build,eq,and_return] | works when called with an URI object has the correct text in the a tag and link name in the a tag and the email. | `The expect syntax does not support operator matchers, so you must pass a matcher to` I think maybe this multiline syntax doesn't work? |
@@ -33,7 +33,7 @@ class PrettyHelpFormatter(optparse.IndentedHelpFormatter):
def format_option_strings(self, option):
return self._format_option_strings(option, ' <%s>', ', ')
- def _format_option_strings(self, option, mvarfmt=' <%s>', optsep=', '):
+ def _format_option_strings(self, option, mvarf... | [PrettyHelpFormatter->[__init__->[__init__]],UpdatingDefaultsHelpFormatter->[expand_default->[expand_default]],ConfigOptionParser->[_update_defaults->[check_default,_get_ordered_configuration_items],get_default_values->[_update_defaults],__init__->[__init__]]] | Format the option strings for the command line. | This change is incorrect. It changes the default value for `_format_option_strings` but not the value that calls it above (and potentially other callers). Moreover, the docstring states that it's evaluated using the `%` operator, which no longer matches the implementation. |
@@ -0,0 +1,12 @@
+from paddle.trainer_config_helpers import *
+from paddle.trainer.config_parser import parse_config as parse
+from paddle.trainer_config_helpers.config_parser_utils import \
+ parse_network_config as parse_network
+from paddle.trainer_config_helpers.config_parser_utils import \
+ parse_optimizer_... | [No CFG could be retrieved] | No Summary Found. | import * paddle.v2 package -- paddle.trianer_config_helpers symbols? mnist demo copy-n-paste mnist demo "" copy demo paddle.v2 |
@@ -246,9 +246,14 @@ duns_resolve_lustre_path(const char *path, struct duns_attr_t *attr)
#endif
#define UUID_REGEX "([a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}){1}"
-#define DAOS_FORMAT "^daos://"UUID_REGEX"/"UUID_REGEX"[/]?"
-#define DAOS_FORMAT_NO_PREFIX "^[/]+"UUID_REGEX"/"UUID_... | [No CFG could be retrieved] | END of function parse_nhs - - - - - - - - - - - - - - - - - -. | (style) line over 80 characters |
@@ -33,10 +33,16 @@ const commonOptions = {
desc: 'Compose with a generator at current project',
type: Boolean,
},
+ regenerate: {
+ desc: 'Regenerate a generator at current project',
+ type: Boolean,
+ },
+ configure: {
+ desc: 'Configure the generator',
+ type: Boolean,
+ },
};
module... | [No CFG could be retrieved] | description - Compose with a generator at current project. | Regenerate the entire generators sequence? |
@@ -879,7 +879,10 @@ export class AmpA4A extends AMP.BaseElement {
creative.slice(metadataStart + METADATA_STRING.length, metadataEnd));
const ampRuntimeUtf16CharOffsets =
metaDataObj['ampRuntimeUtf16CharOffsets'];
- if (!isValidOffsetArray(ampRuntimeUtf16CharOffsets)) {
+ if (!isArra... | [AmpA4A->[constructor->[dev,AmpAdUIHandler,AmpAdXOriginIframeHandler],verifyCreativeSignature_->[then,some,user,reject,verifySignature,map],onLayoutMeasure->[headers,resolve,user,checkStillCurrent,isAdPositionAllowed,cancellation,isCryptoAvailable,creative,bytes,signature,viewerForDoc,arrayBuffer],preconnectCallback->[... | Get the AMP AMP metadata for a creative. Get the meta data from the AMP AMP AMP AMP AMP AMP. | Why did you inline this and get rid of the function? Just b/c it's only used here these days? I still think it makes the code more readable, but if you'd rather kill it, no problem. But I think you want to convert all of the `&&` to `||` here. |
@@ -35,7 +35,7 @@ func ValidateJob(j models.JobSpec, store *store.Store) error {
}
// ValidateAdapter checks that the bridge type doesn't have a duplicate or invalid name
-func ValidateAdapter(bt *models.BridgeType, store *store.Store) (err error) {
+func ValidateAdapter(bt *models.BridgeTypeRequest, store *store.S... | [MinimumServiceDuration,Now,MaximumServiceDuration,Merge,MinimumContractPayment,Add,NewTaskType,Cmp,New,CoerceEmptyToNil,Dev,Address,After,NewJSONAPIErrorsWith,Until,Unix,NewJSONAPIErrors,MinimumRequestExpiration,ToLower,For,Sprintf,String,GetFirstAccount] | ValidateJob checks that a JobSpec has at least one Initiator and one Task and that EmptyToNil checks if the Initiator is valid and returns a non - nil error if. | Should we rename this `ValidateBridgeType`? Seems inconsistent. |
@@ -47,9 +47,10 @@ class Ftrl(optimizer_v2.OptimizerV2):
$$n_{t,i} = n_{t-1,i} + g_{t,i}^{2}$$
$$\sigma_{t,i} = (\sqrt{n_{t,i}} - \sqrt{n_{t-1,i}}) / \alpha$$
$$z_{t,i} = z_{t-1,i} + g_{t,i} - \sigma_{t,i} * w_{t,i}$$
- $$w_{t,i} = - ((\beta+\sqrt{n_{t,i}}) / \alpha + 2 * \lambda_{2})^{-1} *
- (z... | [Ftrl->[_resource_apply_dense->[,ResourceApplyFtrl,get_slot,_fallback_apply_state,ResourceApplyFtrlV2],_resource_apply_sparse->[,ResourceSparseApplyFtrlV2,get_slot,_fallback_apply_state,ResourceSparseApplyFtrl],_prepare_local->[apply_state,_get_hyper,dict,cast,super,identity],_create_slots->[add_slot,constant_initializ... | Efficiently compute FTRL for variable index. Required parameters for the operation. | Please align this with the $$ above |
@@ -141,12 +141,12 @@ namespace Microsoft.Extensions.DependencyModel
string depsJsonFile = Path.ChangeExtension(assemblyLocation, DepsJsonExtension);
bool depsJsonFileExists = _fileSystem.File.Exists(depsJsonFile);
-
+#if !NET5_0_OR_GREATER
if (!depsJsonFileExists)
... | [DependencyContextLoader->[DependencyContext->[IsEntryAssembly]]] | Returns the path to the dependencies. json file. | Why are we making this change? |
@@ -206,12 +206,14 @@ export class VisibilityModel {
this.dispose();
return;
}
- if (this.repeatInterval_) {
+ const totalContinuousMax = Math.max(
+ this.spec_.totalTimeMin, this.spec_.continuousTimeMin);
+ if (totalContinuousMax >= MIN_REPEAT_INTERVAL) {
const now = Date.now(... | [No CFG could be retrieved] | Replies the event promise. Refreshes the counter on visible reset. | We should be able to get rid of this repeat scheduler since we removed the repeatInterval support. Instead, we can call refresh after eventResolver . |
@@ -82,7 +82,8 @@ setup(
'msrestazure>=0.4.32,<2.0.0',
'azure-common~=1.1',
'msrest>=0.6.17,<2.0.0',
- 'azure-core<2.0.0,>=1.6.0'
+ 'azure-core<2.0.0,>=1.6.0',
+ "isodate>=0.6.0",
],
extras_require={
":python_version<'3.0'": ['azure-nspkg', 'futures'],
| [find_packages,setup,search,replace,read,format,join,RuntimeError,open,Exception] | This function is used to install the required packages. | do we want it to be "< 1.0.0" as well? if the dependency in autorest is just >=0.6.0, then I probably think it's good for now, but still we'd better to double-check with anna or laurent on this. |
@@ -583,6 +583,7 @@ func (f *specialUseFilter) Target(opt opt.Options, store *core.StoreInfo) bool {
const (
specialUseKey = "specialUse"
specialUseHotRegion = "hotRegion"
+ specialUseReserved = "reserved"
)
-var allSpecialUses = []string{specialUseHotRegion}
+var allSpecialUses = []string{specialUseHotR... | [filterMoveRegion->[GetSendingSnapCount,IsBusy,GetReceivingSnapCount,GetApplyingSnapCount,IsAvailable,GetMaxSnapshotCount],filter->[GetSendingSnapCount,GetID,IsBusy,GetReceivingSnapCount,GetMaxPendingPeerCount,GetPendingPeerCount,GetApplyingSnapCount,GetMaxSnapshotCount,DownTime,GetMaxStoreDownTime],Source->[IsTombston... | region HotRegion - related functions. | Can `hot region` scheduler balance to the reserved store? |
@@ -0,0 +1,11 @@
+from django.conf.urls import url
+
+from . import views
+
+
+urlpatterns = [
+ url(r'^$', views.collection_list, name='collection-list'),
+ url(r'^add$', views.collection_create, name='collection-add'),
+ url(r'^(?P<collection_pk>[0-9]+)/edit/$',
+ views.collection_update, name='collec... | [No CFG could be retrieved] | No Summary Found. | Please include trailing slashes. |
@@ -7,6 +7,7 @@ import numpy as np
import os
import os.path as op
from scipy import sparse, linalg
+from functools import partial
from .fiff.constants import FIFF
from .fiff.tree import dir_tree_find
| [read_source_spaces->[read_source_spaces_from_tree],setup_volume_source_space->[SourceSpaces,write_source_spaces],read_source_spaces_from_tree->[SourceSpaces],write_source_spaces->[_write_source_spaces_to_fid],setup_source_space->[SourceSpaces,write_source_spaces],_read_one_source_space->[_add_patch_info],_add_interpol... | Create a single tag from a list of objects. A class to provide information about the creation of a file. | please import partial from .fixes |
@@ -19,7 +19,7 @@ Rails.application.configure do
# Ensures that a master key has been made available in either ENV["RAILS_MASTER_KEY"]
# or in config/master.key. This key is used to decrypt credentials (and other encrypted files).
# config.require_master_key = true
-
+
# Disable serving static files from ... | [fetch,new,formatter,log_tags,compile,lambda,consider_all_requests_local,asset_host,log_formatter,cache_classes,imgix,deprecation,r301,dump_schema_after_migration,logger,fallbacks,enabled,force_ssl,delivery_method,eager_load,default_url_options,present?,except,perform_caching,custom_options,insert_before,proc,log_level... | Configuration for a single application. Configure the object. | Layout/TrailingWhitespace: Trailing whitespace detected. |
@@ -254,6 +254,13 @@ static ssize_t sysctl_random(char *buf, size_t buflen)
# endif
# if defined(OPENSSL_RAND_SEED_GETRANDOM)
+
+# if defined(__linux) && !defined(__NR_getrandom)
+# if defined(__arm__) && defined(__NR_SYSCALL_BASE)
+# define __NR_getrandom (__NR_SYSCALL_BASE+384)
+# endif
+# endi... | [No CFG could be retrieved] | Reads a variable number of bytes from the system and returns it. This function is used to find the entropy of a given node. | Should there be a kernel version check as well? It's probably not critical since the system call will fail and other entropy sources will be tried. Otherwise, this looks good. |
@@ -36,6 +36,11 @@ public class OpenTelemetryInstaller implements ComponentInstaller {
OpenTelemetrySdk sdk = OpenTelemetrySdkAutoConfiguration.initialize();
OpenTelemetrySdkAccess.internalSetForceFlush(
(timeout, unit) -> sdk.getSdkTracerProvider().forceFlush().join(timeout, unit));
+
+ i... | [OpenTelemetryInstaller->[beforeByteBuddyAgent->[installAgentTracer],copySystemProperties->[getProperty,equals,clearProperty,setProperty,forEach,containsKey,asJavaProperties,startsWith],installAgentTracer->[getBooleanProperty,copySystemProperties,info,join,internalSetForceFlush,initialize],getLogger]] | Installs the agent tracer. | What do you think about creating a separate `ComponentInstaller` in the `:instrumentation:runtime-metrics:javaagent` module? This way we could avoid adding instrumentation code (well, sort of) to javaagent-tooling module. |
@@ -19,9 +19,10 @@ class CategoryInput(graphene.InputObjectType):
ID of the parent category. If empty, category will be top level
category.''')
slug = graphene.String(description='Category slug')
+ seo_fields = SeoInput(description='Search engine optimization fields.')
-class CategoryCreat... | [ProductUpdateMutation->[Arguments->[ProductInput]],CollectionAddProducts->[mutate->[CollectionAddProducts]],CategoryUpdateMutation->[Arguments->[CategoryInput]],ProductVariantUpdateMutation->[Arguments->[ProductVariantInput]],ProductImageUpdate->[Arguments->[ProductImageInput]],ProductImageReorder->[mutate->[ProductIm... | This module provides a base class for creating a new category. Delete a category from a model. | Just `seo` here would be fine. |
@@ -196,7 +196,7 @@ func (ldm *LayerDownloader) DownloadLayers(ctx context.Context, ic *ImageC) erro
return err
}
} else {
- if err := updateRepositoryCache(ic); err != nil {
+ if err := UpdateRepositoryCache(ic); err != nil {
return err
}
}
| [makeDownloadFuncFromDownload->[result],run->[WriteProgress],makeDownloadFunc->[result,unregisterDownload],DownloadLayers->[registerDownload,result,stop,run]] | DownloadLayers downloads all the layers in the store. makeDownloadFuncFromDownload creates a download function from a given existing download and a list of. | I would even rename it to UpdateRepoCache. |
@@ -32,12 +32,13 @@ class PantsRunner(object):
self._start_time = start_time
def run(self):
+ ExceptionSink.reset_exiter(self._exiter)
options_bootstrapper = OptionsBootstrapper(env=self._env, args=self._args)
bootstrap_options = options_bootstrapper.get_bootstrap_options()
global_bootstrap_... | [PantsRunner->[run->[create,reset_log_location,RemotePantsRunner,reset_exiter,set_start_time,for_global_scope,get_bootstrap_options,format,warn,run,OptionsBootstrapper]],getLogger] | Run pants - n - node. | nit: I think whitespace between the `ExceptionSink` commands and the options bootstrapping would make this a little easier to read. |
@@ -1306,6 +1306,8 @@ module Engine
home_token_locations(corporation)
end
+ return unless hexes
+
@round.pending_tokens << {
entity: corporation,
hexes: hexes,
| [Base->[format_revenue_currency->[format_currency],process_to_action->[process_action],end_game!->[format_currency],current_entity->[current_entity],par_price_str->[format_currency],log_cost_discount->[format_currency],float_corporation->[format_currency],after_par->[format_currency,place_home_token,all_companies_with_... | if a corporation has a next token assume it s their home token assume it s their home. | National railways may not have a home token to lay. Continue on without placing a token if they have no home hex. |
@@ -25,7 +25,8 @@ export function nonSensitiveDataPostMessage(type, opt_object) {
}
const object = opt_object || {};
object.type = type;
- object.sentinel = window.context.amp3pSentinel;
+ object.sentinel = window.context.sentinel ? window.context.sentinel :
+ window.context.amp3pSentinel;
window.par... | [No CFG could be retrieved] | Post message to parent frame. Listens for message events and dispatches to listeners registered on the window. | `object.sentinel = window.context.sentinel || window.context.amp3pSentinel;` |
@@ -80,9 +80,10 @@ namespace Content.Server.GameTicking
[ViewVariables] private Type _presetType;
- [ViewVariables] private DateTime _pauseTime;
+ [ViewVariables] private IGameTiming _pauseTime;
[ViewVariables] private bool _roundStartCountdownHasNotStartedYetDueToNoPlayers;
- ... | [GameTicker->[ToggleDisallowLateJoin->[UpdateLateJoinStatus],SetStartPreset->[SetStartPreset,TryGetPreset,StartRound],SpawnPlayer->[SpawnPlayer,ApplyCharacterProfile,MakeObserve],Initialize->[Initialize],PlayerStatusChanged->[PlayerStatusChanged],TogglePause->[PauseStart],StartRound->[RestartRound,ReqWindowAttentionAll... | Base class for all the game ticker methods. property to set the run level. | This needs to be a `TimeSpan`. |
@@ -110,7 +110,13 @@ class BaseRegressionMetric(PerImageEvaluationMetric):
return self.value_differ(next(iter(annotation.value.values())), prediction.value)
diff_dict = OrderedDict()
for key in annotation.value:
- diff = self.value_differ(annotation.value[key], ... | [RootMeanSquaredError->[update->[update]],FacialLandmarksNormedError->[parameters->[update],reset->[reset],configure->[update],update->[update]],BaseRegressionMetric->[reset->[reset],update->[update]],BaseRegressionOnIntervals->[parameters->[update],reset->[_create_meta],configure->[update],update->[update]],Percentage... | Calculate diff regression rep for the given annotation and prediction. | could you please create helper-function to_float for this case to avoid code duplication? |
@@ -23,9 +23,10 @@ import (
"github.com/spf13/cobra"
rbacv1 "k8s.io/api/rbac/v1"
+ rbacv1beta1 "k8s.io/api/rbac/v1beta1"
+ rbacv1alpha1 "k8s.io/api/rbac/v1alpha1"
corev1client "k8s.io/client-go/kubernetes/typed/core/v1"
rbacv1client "k8s.io/client-go/kubernetes/typed/rbac/v1"
- "k8s.io/kubernetes/pkg/api/lega... | [RunReconcile->[ClusterRoleBindings,Infof,ClusterRoles,ConvertToVersion,GetObjectKind,GetObject,V,Visit,Run,PrintObject,Namespaces],Validate->[New],Complete->[DefaultNamespace,NamespaceParam,ContinueOnError,ToRESTConfig,Do,ToRawKubeConfigLoader,FilenameParam,New,NewBuilder,ToPrinter,NewForConfig,Flatten,Namespace,WithS... | END of function list_tasks NumberOfResources - Prints all resources in the system that are not in the system. | ~~nit: reorder to the top with "errors"~~ (forgot this is already wrong in upstream) |
@@ -1130,6 +1130,17 @@ func (a *apiServer) scaleUpWorkers(ctx context.Context, deploymentName string, p
return err
}
+func (a *apiServer) workerServiceIP(ctx context.Context, deploymentName string) (string, error) {
+ service, err := a.kubeClient.Services(a.namespace).Get(deploymentName)
+ if err != nil {
+ retur... | [DeletePipeline->[DeleteJob],AddShard->[pipelineWatcher,jobWatcher],jobManager->[updateJobState,InspectJob,scaleUpWorkers],CreatePipeline->[validatePipeline],pipelineWatcher->[setPipelineCancel,deletePipelineCancel],RestartDatum->[InspectJob],jobWatcher->[setJobCancel,deleteJobCancel],pipelineManager->[scaleDownWorkers... | scaleUpWorkers scales up all workers in the given deployment create a k8s repo and a k8s deployment This function is called when a job is completed. It will check if there s a running new processing job This function is called by the scheduler when a pipeline is being created. | This is more of a question, but am I right in understanding that we can't simply use the service's name and expect it to be resolved into the correct IP? Is that something that requires a k8s DNS setup? |
@@ -301,15 +301,11 @@ func (mod *modContext) genInit(exports []string) string {
child = child[match[2]:match[3]]
}
}
- if i > 0 {
- fmt.Fprintf(w, ",\n")
+ if child != "config" {
+ fmt.Fprintf(w, " %s,\n", PyName(child))
}
- fmt.Fprintf(w, " '%s'", PyName(child))
}
- fmt.Fprintf... | [gen->[genHeader,add],genResource->[genHeader,has,add],genFunction->[genHeader,genAwaitableType],genPropertyConversionTables->[genHeader],genInit->[genHeader,submodulesExist],genNestedStructureBullets->[genNestedStructureBullets],genConfig->[genHeader],genHeader,genPropertyConversionTables,add,gen] | genInit generates the init. py file for the package. Print out the string representation of the NestedNode objects in the given way. | @pgavlin, do you know why we skip config? Avoiding side-effects or something else? |
@@ -189,9 +189,8 @@ namespace Dynamo.UpdateManager
private bool forceUpdate;
private string updateFileLocation;
private int currentDownloadProgress = -1;
-
- private readonly ILogger logger;
- private readonly DynamoModel dynamoModel;
+ private static IUpdateManager insta... | [UpdateManager->[IsStableBuild->[IsDailyBuild],IsDailyBuild->[GetVersionString],CheckForProductUpdate]] | NotificationObject - A class that represents a single object that can be used to manage the product - A AvailableVersion object that represents the . | Yay for removing dependencies! |
@@ -324,7 +324,11 @@ func (se *stepExecutor) executeStep(workerID int, step Step) error {
func (se *stepExecutor) log(workerID int, msg string, args ...interface{}) {
if logging.V(stepExecutorLogLevel) {
message := fmt.Sprintf(msg, args...)
- logging.V(stepExecutorLogLevel).Infof("StepExecutor worker(%d): %s", w... | [worker->[executeChain,log],ExecuteParallel->[ExecuteSerial,Wait],WaitForCompletion->[Wait],worker] | log logs a message if the worker is not in the log. | This edit is not good, need `if logging.V(stepExecutorLogLevel)`. |
@@ -202,8 +202,9 @@ namespace DynamoInstallDetective
public virtual IEnumerable<string> GetProductNameList()
{
- var key = OpenKey(REG_KEY64);
- return key.GetSubKeyNames().Where(s => s.Contains(ProductLookUpName));
+ return RegUtils.GetInstalledProducts().Select(s =... | [DynamoProducts->[LookUpDynamoProducts->[GetProductNameList],LookUpAndInitProducts->[CompareTo]],InstalledProductLookUp->[GetInstallLocationFromProductName->[GetInstallLocation],InstalledProduct->[Equals->[],GetHashCode->[],ExistsAtPath],GetInstallLocationFromProductCode->[GetInstallLocation,GetDisplayName]],InstalledP... | Get product name list from registry. | Match against the displayName (i.e `s.Value.Item1`) |
@@ -140,7 +140,9 @@ class XCodeCLITools(Subsystem):
return Linker(
path_entries=self.path_entries(),
exe_filename='ld',
- library_dirs=[])
+ library_dirs=[],
+ linking_library_dirs=[],
+ extra_args=['-mmacosx-version-min=10.11'])
@memoized_method
def c_compiler(self):
| [get_ld->[linker],get_clang_plusplus->[cpp_compiler],get_assembler->[assembler],get_clang->[c_compiler],XCodeCLITools->[c_compiler->[lib_dirs,include_dirs,path_entries],assembler->[path_entries],linker->[path_entries],include_dirs->[_get_existing_subdirs],_get_existing_subdirs->[XCodeToolsUnavailable],path_entries->[_g... | Returns a linker that can be used to link a node into a node. | The 10.11 seems arbitrarty / tied to Pants current min version support. Does this deserve to be lifted out to a constant used to generate all such flags? |
@@ -629,7 +629,7 @@ func (http *httpPlugin) collectHeaders(m *message) interface{} {
func (http *httpPlugin) setBody(result common.MapStr, m *message) {
if m.sendBody && len(m.body) > 0 {
- result["body"] = string(m.body)
+ result["body.content"] = string(m.body)
}
}
| [ReceivedFin->[PrepareForNewMessage],extractParameters->[Parse,hideSecrets],doParse->[PrepareForNewMessage,messageComplete],GapInStream->[messageComplete,messageGap],Expired->[handleHTTP,PrepareForNewMessage,flushRequests,flushResponses,correlate],correlate->[flushResponses]] | setBody sets the body field of the message. | Probably better user here `result.Put("body.content", string(m.body)` so it creates the correct object. |
@@ -49,13 +49,16 @@ func newConfigLsCmd() *cobra.Command {
return getConfig(stackName, key)
}
- return listConfig(stackName)
+ return listConfig(stackName, showSecrets)
}),
}
lsCmd.PersistentFlags().StringVarP(
&stack, "stack", "s", "",
"Target a specific stack instead of all of this proje... | [Value,ExactArgs,Secure,Wrap,HasPrefix,Strings,RunFunc,StringVarP,Errorf,AddCommand,Contains,QName,ParseModuleMember,NewSecureValue,NewValue,Printf,Sprintf,EncryptValue,RangeArgs,String,ModuleMember,MaximumNArgs,PersistentFlags] | NewConfigCmd returns a Command instance for the new command NewConfigTextCmd returns a command to set a specific stack s configuration key. | This is probably fine. But I imagine we'll want all of our flag descriptions to be complete sentences? e.g. ending with a period? |
@@ -349,8 +349,6 @@ frappe.router = {
push_state(url) {
// change the URL and call the router
if (window.location.pathname !== url) {
- // cleanup any remenants of v1 routing
- window.location.hash = '';
// push state so the browser looks fine
history.pushState(null, null, url);
| [No CFG could be retrieved] | The route that will be routed to is the route that will be routed to. get route name from url. | Removing this line fixes unnecessary `hashchange` triggers and unexpected behaviors in certain cases while going back. |
@@ -50,6 +50,10 @@ class Group(AbstractGroup):
Should items be arrange vertically (``False``) or horizontally
in-line (``True``).
""")
+
+ callback = Instance(Callback, help="""
+ A callback to run in the browser whenever a group is manipulated.
+ """)
class CheckboxGroup(Group):
"""... | [CheckboxGroup->[List],RadioButtonGroup->[Int],RadioGroup->[Int],CheckboxButtonGroup->[List],AbstractGroup->[on_click->[handler,on_change],List],Group->[Bool]] | Create a base class for groups with items rendered as check boxes and radio boxes. | To be precise about I this, I think for now it would be better to add this just to the two subclasses I linked in the issue, not all of the `AbstractGroup` subclasses seem to have the callback machinery. But those two do. |
@@ -836,6 +836,12 @@ class Conf
// Note: Set MAIN_SECURITY_CSRF_TOKEN_RENEWAL_ON_EACH_CALL=1 to have a renewal of token at each page call instead of each session (not recommended)
}
+ // To bypass MAIN_ANTIVIRUS_* constants
+ if (defined('MAIN_ANTIVIRUS_BYPASS_COMMAND_AND_PARAM')) {
+ define("MAIN_ANT... | [Conf->[setValues->[free,query,setValues,decrypt,num_rows,fetch_object]]] | Set all global constants in the current object This function is called when a module is activated by a module. It initializes the tabs property This function is used to add a module constant to the list of modules. | If you make a "define" here it means it was never defined before or you will get an error. We should not have define inside code, only at top begin and we must check before it is not already defined. You should use and test your constant MAIN_ANTIVIRUS_BYPASS_COMMAND_AND_PARAM just after to replace `if (defined('MAIN_A... |
@@ -100,7 +100,7 @@ def execute(args, parser):
env.add_channels(args.channel)
if args.file is None:
- print(env.to_yaml())
+ print(json.dumps(env.to_dict())) if args.json else print(env.to_yaml())
else:
fp = open(args.file, 'wb')
- env.to_yaml(stream=fp)
+ env.t... | [configure_parser->[add_argument,add_parser_json,set_defaults,add_parser_prefix,add_parser],execute->[remove_channels,dedent,print,from_environment,get,add_channels,get_prefix,CondaEnvException,open,to_yaml]] | Execute the command. | For printing the json there is a function that already exists called `stdout_json`. It will also do a pretty printing of the json, so I think that one should be used. The `import json` above can be replaced with `from conda.cli.common import stdout_json`. And then the `json.dumps(env.to_dict())` can be replaced with `s... |
@@ -734,14 +734,14 @@ class RandomResizedCrop(torch.nn.Module):
@staticmethod
def get_params(
- img: Tensor, scale: Tuple[float, float], ratio: Tuple[float, float]
+ img: Tensor, scale: List[float], ratio: List[float]
) -> Tuple[int, int, int, int]:
"""Get parameters for ... | [RandomAffine->[__call__->[get_params]],RandomPerspective->[__call__->[get_params]],RandomCrop->[forward->[get_params]],RandomResizedCrop->[forward->[get_params]],ColorJitter->[get_params->[Compose,Lambda]],RandomRotation->[__call__->[get_params]],RandomErasing->[forward->[get_params]]] | Get parameters for a random sized crop. | The changes in this function seem unrelated to the whole goal of the PR. For the next time, can you please factor them out in a different PR? |
@@ -544,8 +544,8 @@ class TestUploadCompatCheck(BaseUploadTest):
def setUp(self):
super(TestUploadCompatCheck, self).setUp()
assert self.client.login(username='del@icio.us', password='password')
- self.app = Application.objects.get(pk=amo.FIREFOX.id)
- self.appver = AppVersion.objec... | [TestCompatibilityResults->[test_validation_success->[validate],test_validation_error->[validate],test_hide_validation_traceback->[validate]],TestUploadCompatCheck->[upload->[fake_xpi],test_js_upload_validates_compatibility->[upload,poll_upload_status_url],test_compat_result_report->[upload,poll_upload_status_url],test... | Set up the object. | Not consistent with the one above `FIREFOX.id` |
@@ -226,7 +226,7 @@ namespace Dynamo
/// <param name="path"></param>
public void TagRenderPackageForPath(string path)
{
- var packages = new List<RenderPackage>();
+ var packages = new List<IRenderPackage>();
//This also isn't thread safe
fore... | [VisualizationManager->[OnRenderPackageAggregationCompleted->[OnResultsReadyToVisualize],WorkspaceRemoved->[OnResultsReadyToVisualize],Clear->[OnResultsReadyToVisualize],SelectionChanged->[OnRenderComplete],OnNodeModelRenderPackagesReady->[OnRenderComplete],ClearVisualizationsAndRestart->[Start,Clear],TagRenderPackageF... | This method is called when a tag of a package is not found in the workspace. | Let's remove this empty param. |
@@ -263,6 +263,14 @@ public class SqlStandardAccessControl
}
}
+ @Override
+ public void checkCanSetTableAuthorization(ConnectorSecurityContext context, SchemaTableName tableName, PrestoPrincipal principal)
+ {
+ if (!isTableOwner(context, tableName)) {
+ denySetTableAuthoriza... | [SqlStandardAccessControl->[checkCanCreateViewWithSelectFromColumns->[checkCanSelectFromColumns],hasAdminOptionForRoles->[isAdmin],hasAnyTablePermission->[isAdmin],isDatabaseOwner->[isAdmin],hasGrantOptionForPrivilege->[isAdmin],checkTablePermission->[isAdmin]]] | Check whether a column can be renamed or selected. | Is this a Hive behavior? What about being an owner of a schema that contains that table, would that allow to change the owner of table? |
@@ -435,8 +435,8 @@ func (conn *Connection) execHTTPRequest(req *http.Request) (int, []byte, error)
req.SetBasicAuth(conn.Username, conn.Password)
}
- if conn.APIKey != "" {
- req.Header.Add("Authorization", "ApiKey "+conn.APIKey)
+ if conn.encodedAPIKey != "" {
+ req.Header.Add("Authorization", "ApiKey "+conn... | [Test->[Connect],LoadJSON->[Request],getVersion->[Ping],Close] | execHTTPRequest executes the given request and returns the response status code the object and an error. | nit: We still have an unnecessary alloc + copy here. If we initialize `encodedAPIKey = "ApiKey " + ...`, then we can just pass it to `Header` as is. |
@@ -301,7 +301,7 @@ public class KsqlResource {
StructuredDataSource dataSource = ksqlEngine.getMetaStore().getSource(name);
if (dataSource == null) {
- throw new Exception(String.format("Could not find data stream/table '%s' in the metastore",
+ throw new Exception(String.format("Could not find S... | [KsqlResource->[registerDdlCommandTasks->[execute],listRegisteredTopics->[getKsqlTopics],distributeStatement->[distributeStatement],getStatementExecutionPlan->[getStatementExecutionPlan]]] | Describe a source in the metastore. | I know this was here already, but throwing `Exception` - really? above too |
@@ -33,7 +33,11 @@ import org.junit.Test;
public class HadoopIngestionSpecTest
{
- private static final ObjectMapper jsonMapper = new DefaultObjectMapper();
+ private static final ObjectMapper jsonMapper;
+ static {
+ jsonMapper = new DefaultObjectMapper();
+ jsonMapper.setInjectableValues(new InjectableVa... | [HadoopIngestionSpecTest->[testPartitionsSpecMaxPartitionSize->[assertTrue,propagate,getTargetPartitionSize,getPartitionsSpec,getMaxPartitionSize,getPartitionDimension,jsonReadWriteRead,assertEquals,isDeterminingPartitions],testDefaultSettings->[propagate,isCleanupOnFailure,jsonReadWriteRead,isDeterminingPartitions,ass... | Checks that the specified object is valid for the given granularity. | Injected ObjectMappers should be tagged with `@Json` or `@Smile`. Is there somewhere that is not doing this? |
@@ -270,6 +270,7 @@ class ParallelDo(object):
for in_var_name in op.input(iname):
if in_var_name not in local_inputs:
params.append(in_var_name)
+ params = list(set(params))
return [parent_block.var(name) for name in params]
| [IfElseBlockGuard->[__exit__->[__exit__],__enter__->[__enter__],__init__->[block]],DynamicRNN->[_parent_block_->[block],block->[array_write,block,increment,less_than,array_to_lod_tensor],static_input->[_assert_in_rnn_block_,shrink_memory],update_memory->[_assert_in_rnn_block_],__init__->[While],output->[_assert_in_rnn_... | Returns a list of the parameters of the . | @reyoung Duplications of the parameter names will be taken care by backward. parallel_do only needs a unique list. |
@@ -125,7 +125,7 @@ func nodeMatchesAllConditions(node backend.Node, conditions []*iam_v2.Condition)
if !foundMatch {
return false
}
- case iam_v2.ProjectRuleConditionAttributes_CHEF_TAGS:
+ case iam_v2.ProjectRuleConditionAttributes_CHEF_TAG:
foundMatch := false
for _, projectRole := range condi... | [Debug,ListRulesForAllProjects,WithError,SliceContains,Fatal,WithFields] | Check if the given condition is a match for the given node. | (nothing to do with this PR just a question to myself and @lancewf) Do we need this `foundMatch` logic? why not just return `true` in like `121` like the other functions? (I might be missing something) |
@@ -3673,7 +3673,7 @@ JITManager::HandleServerCallResult(HRESULT hr, RemoteCallType callType)
// we should not have RPC failure if JIT process is still around
// since this is going to be a failfast, lets wait a bit in case server is in process of terminating
- if (WaitForSingleObject(GetJITManager()->Ge... | [No CFG could be retrieved] | Handle the result of a server call. #region ethernet. js. | How frequently are we seeing this fail fast? In any case since we will fail fast should this be a bit more higher (say 2-5 sec). Also can you have it as a #define instead of a hardcoded number |
@@ -3962,7 +3962,7 @@ def reverse_sequence(input,
>>> seq_lengths = [7, 2, 3, 5]
>>> input = [[1, 2, 3, 4, 5, 0, 0, 0], [1, 2, 0, 0, 0, 0, 0, 0],
... [1, 2, 3, 4, 0, 0, 0, 0], [1, 2, 3, 4, 5, 6, 7, 8]]
- >>> output = reverse_sequence(input, seq_lens, seq_dim=1, batch_dim=0)
+ >>> output = reverse_se... | [identity->[identity],reverse_sequence->[reverse_sequence],zeros->[_constant_if_small,fill,reshape],reshape->[reshape],boolean_mask->[concat,_apply_mask_1d,shape,reshape],extract_image_patches->[extract_image_patches],rank_internal->[size,rank],_SliceHelperVar->[_slice_helper],repeat_with_axis->[expand_dims,concat,resh... | Reverses variable length slices. This op first slices input and for each slice along Reverses the sequence of the missing values along the specified axis. | Could you please update the code to call `tf.reverse_sequence` instead of just `reverse_sequence` |
@@ -44,4 +44,9 @@ class Ucx(AutotoolsPackage):
config_args.append('--enable-mt')
else:
config_args.append('--disable-mt')
+ if '+cuda' in spec:
+ config_args.append('--with-cuda={0}'.format(spec['cuda'].prefix))
+ if '+gdrcopy' in spec:
+ config_arg... | [Ucx->[configure_args->[append],variant,depends_on,version]] | Returns a list of command line options for the object. | Can these be disabled with `--without`? |
@@ -39,3 +39,9 @@ type SnapshotMutation interface {
// persisted. See the comments on SnapshotProvider.BeginMutation for more details.
End(snapshot *deploy.Snapshot) error
}
+
+// Context provides cancellation, termination, and eventing options for an engine operation.
+type Context struct {
+ Cancel *cancel.Conte... | [No CFG could be retrieved] | Not persisted. | 'Context' is possible teh vaguest name ever. :D |
@@ -57,6 +57,10 @@ public class NumberValidationTestCase extends ValidationTestCase {
@Test
public void validateNumber() throws Exception {
+
+ // This test will be ignored when the Allure framework is used because of this issue MULE-10805
+ assumeThat(System.getProperty("allure.profile.is.activated", "fa... | [NumberValidationTestCase->[configureNumberValidationRunner->[withVariable],validateNumber->[flowRunner,configureNumberValidationRunner,invalidNumberType,assertValid,lowerThan,greaterThan,assertInvalid,name],parameters->[Short,asList,shortValue],toString]] | Checks that the number is valid. | If you use an assumption you will never be aware that this test is not running. The test will show as Passed while it didn't actually run. We should use an @ Ignore and place a TODO tag. |
@@ -461,11 +461,7 @@ export class ResourcesImpl {
resource.getState() != ResourceState.NOT_BUILT &&
!element.reconstructWhenReparented()
) {
- // With IntersectionObserver, no need to request remeasure
- // on reuse since initial intersection callback will trigger soon.
- if (!this.int... | [No CFG could be retrieved] | Returns a resource object for the given element. MISSING - 1. | Not sure this actually matters in practice but reducing divergence just in case. |
@@ -102,4 +102,14 @@ public class DnsAddressResolverGroup extends AddressResolverGroup<InetSocketAddr
.nameServerAddresses(nameServerAddresses)
.build();
}
+
+ /**
+ * Creates a new {@link AddressResolver}. Override this method to create an alternative {@link AddressResolve... | [DnsAddressResolverGroup->[newResolver->[newResolver]]] | Creates a name resolver based on the given configuration. | Formatting seems a bit odd... can you fix this ? |
@@ -135,8 +135,11 @@ void jsonPrint(const QueryData& q) {
printf("[\n");
for (size_t i = 0; i < q.size(); ++i) {
std::string row_string;
-
- if (serializeRowJSON(q[i], row_string).ok()) {
+ RowTyped rt;
+ for (const auto& col : q[i]) {
+ rt[col.first] = col.second;
+ }
+ if (serializeRowJ... | [prettyPrint->[generateHeader,generateRow,generateToken]] | Print the JSON representation of the QueryData. | Can't you just do `RowType rt(q[i])`, instead of the loop below? |
@@ -68,8 +68,14 @@ def test_ping_unreachable(raiden_network):
assert async_result.wait(2) is None, "The message was dropped, it can't be acknowledged"
- for message in messages:
- assert decode(message) == ping_message
+ # Raiden node will start pinging as soon as a new channel
+ # is establis... | [test_ping->[setup_messages_cb,sha3,Ping,send_raw_with_result,wait,decode,isinstance,sign,encode,next],test_ping_unreachable->[setup_messages_cb,Ping,send_raw_with_result,wait,decode,sign,encode],test_receive_mediated_before_deposit->[raises,next_block,dict,deposit,sleep,RaidenAPI,transfer_and_wait,token_addresses,chan... | Test that the raiden network is unreachable. Wait until back channel can transfer a non - zero amount. | This check is unrelated to the unit test "test_ping_unreachable". Please write a new unit test, give it a proper name and if you want a docstring specifying the regression it's fixing. |
@@ -793,7 +793,7 @@ if ($mode == 'standard')
if ($nextmonth > 12) { $nextmonth = 1; $nextyear++; }
// For month
- $link = "<a href='".$_SERVER["PHP_SELF"]."?account=".$account.($_GET["option"] != 'all' ? '' : '&option=all')."&year=".$prevyear."&month=".$prevmonth."'>".img_previous('', 'class="valignbottom"')."</a... | [fetch,setBgColor,SetData,fetch_object,jdate,draw,SetLegend,getNomUrl,show,setBgColorGrid,SetMaxValue,fetch_row,SetMinValue,load,SetHorizTickIncrement,SetHideXGrid,SetShading,transnoentities,GetCeilMaxValue,loadLangs,SetTitle,escape,close,free,query,SetWidth,SetType,GetFloorMinValue,trans,num_rows,SetLegendWidthMin,Set... | Navigation links for a single node. Print a sequence number in a calendar. | It seems you didn' cancel this PR. Can you try to resubmit with this commit (not related to the PR) |
@@ -62,6 +62,12 @@ public class HllSketchToEstimatePostAggregator implements PostAggregator
return name;
}
+ @Override
+ public ValueType getType()
+ {
+ return ValueType.DOUBLE;
+ }
+
@JsonProperty
public PostAggregator getField()
{
| [HllSketchToEstimatePostAggregator->[compute->[compute],getDependentFields->[getDependentFields],equals->[equals]]] | Gets the name and field of a . | Should it be `round ? ValueType.LONG : ValueType.DOUBLE`? |
@@ -189,6 +189,15 @@ class ClientCache(SimplePaths):
self._settings = settings
return self._settings
+ @property
+ def plugins(self):
+ """Returns a list of plugins inside the plugins folder"""
+ plugins = []
+ for plugin_name in os.listdir(self.plugins_path):
+ ... | [ClientCache->[package_lock->[_no_locks],conanfile_lock_files->[_no_locks],conanfile_write_lock->[_no_locks],conanfile_read_lock->[_no_locks]],_mix_settings_with_env->[get_env_value,get_setting_name]] | Returns a dictionary containing all the possible settings without values. | `if os.path.isfile(plugin_name)` Also, don't forget to mention in the docs that any py file there will be considered a plugin, and suggest subfolders. |
@@ -81,6 +81,8 @@ final class ItemNormalizer extends AbstractItemNormalizer
* {@inheritdoc}
*
* @throws RuntimeException
+ *
+ * @return object
*/
public function denormalize($data, $class, $format = null, array $context = [])
{
| [ItemNormalizer->[normalize->[getHalCacheKey,populateRelation,getComponents,getIriFromItem,getResourceClass,initContext],populateRelation->[getAttributesMetadata,normalize,getRelationIri,getAttributeValue,getObjectClass,isMaxDepthReached],isMaxDepthReached->[getMaxDepth],getComponents->[isResourceClass,create,isCollect... | Denormalizes the given data. | This is the only weird thing in this PR. Lol... Because PHP-CS-Fixer only knows about what's in the current file. (It does not parse parent classes / interfaces.) And of course when we bump to PHP 7.2, we can add the `object` return type. |
@@ -1246,8 +1246,7 @@ public class ConsoleProxyManagerImpl extends ManagerBase implements ConsoleProxy
Map<String, String> configs = _configDao.getConfiguration("management-server", params);
- String value = configs.get(Config.ConsoleProxyCmdPort.key());
- value = configs.get("consoleproxy.ss... | [ConsoleProxyManagerImpl->[createProxyInstance->[getDefaultNetworkForCreation],handleResetSuspending->[resumeLastManagementState,stopProxy],isPoolReadyForScan->[isZoneReady],scanPool->[checkCapacity],stopProxy->[stop],allocCapacity->[startNew,startProxy,assignProxyFromStoppedPool],resumeLastManagementState->[getManagem... | Configures the console proxy manager. Internal method to find the next available object in the system. This method is called when a console proxy is created. | You can use `org.apache.commons.lang3.BooleanUtils.toBoolean(String)`. |
@@ -158,7 +158,7 @@ public class SftpServerTests {
server.stop(true);
}
}
-
+
private PublicKey decodePublicKey() throws Exception {
InputStream stream = new ClassPathResource("id_rsa.pub").getInputStream();
byte[] decodeBuffer = Base64.decodeBase64(StreamUtils.copyToByteArray(stream));
| [SftpServerTests->[testUcPw->[createFileSystemView->[getProperty,mkdirs,getUsername,File,NativeFileSystemView],setPort,setHost,start,setUser,getSession,SimpleGeneratorHostKeyProvider,setUpDefaultServer,findAvailableServerSocket,PasswordAuthenticator,setPassword,setSubsystemFactories,asList,NativeFileSystemFactory,setPa... | This test method is used to test that the public key is valid. This method is used to decode the public key from the input stream. | What's going on with your STS? Seems for me it has option to remove trailing whitespaces |
@@ -75,7 +75,7 @@ class InsertDeleteEntity(object):
from azure.core.exceptions import ResourceNotFoundError, ResourceExistsError
from azure.core import MatchConditions
- table_client = TableClient(account_url=self.account_url, credential=self.access_key, table_name=self.table_name)
+ t... | [InsertDeleteEntity->[create_entity->[create_entity],delete_entity->[create_entity,delete_entity]],main->[clean_up,InsertDeleteEntity,create_entity,delete_entity],main] | Delete the entity with the specified entity key. | For the samples, can we move the instantiation of the credential out onto a separate line? Helps with readability. |
@@ -18,6 +18,7 @@ module Idv
log_vendor(vendor, results, stage)
proofer_result = vendor.proof(@applicant)
results = merge_results(results, proofer_result)
+ results[:timed_out] = true if proofer_result.timed_out?
break unless proofer_result.success?
end
| [Agent->[log_vendor->[class,vendor_name,inspect,push],proofer_attribute?->[attribute?],proof->[new,success?,log_vendor,each,merge_results,proof],merge_results->[merge,to_h],initialize->[symbolize_keys]]] | Returns a list of results for a in the applicant. | Style: another option would be `results[:timed_out] = proofer_result.timed_out?` (assuming `#timed_out?` always returns `true` or `false`). |
@@ -31,8 +31,8 @@ module Search
end
def paginate_hits(hits, params)
- start = (params[:per_page] + 1) * params[:page]
- hits[start, params[:per_page]]
+ start = params[:per_page] * params[:page]
+ hits[start, params[:per_page]] || []
end
def index_settings
| [ChatChannelMembership->[index_settings->[production?],search_documents->[search,dig,paginate_hits,as_hash,set_query_size,map],search->[search],set_query_size->[to_i],freeze]] | Paginate hits based on number of hits and parameters. | Arrays start with index 0 and we start with page 0, so we don't need the `+1`. |
@@ -75,7 +75,8 @@ func (opt *installReadyDockerConfigSecret) Install(dockerClient dockerhelper.Int
dockerConfigJsonBytes, err := ioutil.ReadFile(path.Join(home, ".docker", "config.json"))
if err != nil {
- return fmt.Errorf("Error reading $HOME/.docker/config.json: %v", err)
+ glog.Warningf("Error reading $HOME... | [Install->[DiscardContainer,Copy,ReadFile,New,HostPid,Errorf,NewHelper,PollImmediate,NewError,Join,Infof,SaveContainerLogs,Privileged,Name,Entrypoint,Command,HostNetwork,Image,NewRunHelper,Getenv,Run,WithCause]] | Install creates a secret in the specified base directory and installs it into the specified image. check rc is 0. | why are you returning? |
@@ -56,6 +56,12 @@ class Kratos_Execute_Test:
# If we integrate it in the model part we cannot use combined solvers
self.solver.AddDofs()
+ if self.problem_type == "fluid":
+ self.Model = {self.ProjectParameters["problem_data"]["model_part_name"].GetString(): self.main_model_part}... | [Kratos_Execute_Test->[Solve->[PrintOutput,ExecuteAfterOutputStep,Clear,ExecuteFinalize,Is,Solve,ExecuteFinalizeSolutionStep,ProjectParameters,Initialize,IsOutputStep,ExecuteInitializeSolutionStep,CloneTimeStep,ExecuteBeforeOutputStep,ExecuteInitialize,ExecuteBeforeSolutionLoop],__init__->[PrintOutput,SetValue,AddDofs,... | Initialize the object with the data from the KratosMultiphysics project. Initialize the object Model and initialize it with the values from the project parameters. Get the submodel part in the object Model. | why don't you use `Model` here too? then you could remove the if block |
@@ -144,7 +144,7 @@ public class UnitTestDatabaseManager {
PooledConnectionFactory pcf = (PooledConnectionFactory) connectionFactory;
try {
Thread.sleep(500); // C3P0 needs a little delay before reporting the correct number of connections. Bah!
- assertEquals(pcf.getPooledDat... | [UnitTestDatabaseManager->[configureSimpleConnectionFactory->[username],extractTestName->[getMethodName,indexOf,getStackTrace,replace,getClassName],buildTableManipulation->[timestampColumnType],rowCount->[prepareStatement,RuntimeException,releaseConnection,getInt,getConnection,safeClose,executeQuery,next],verifyConnect... | Verify that there are no leaks in the connection pool. | ouch... can we get rid of this sleep? |
@@ -69,7 +69,7 @@ def _check_channels_ordered(raw, freqs):
"""Check channels followed expected fNIRS format."""
# Every second channel should be same SD pair
# and have the specified light frequencies.
- picks = _picks_to_idx(raw.info, 'fnirs_od')
+ picks = _picks_to_idx(raw.info, 'fnirs_od', exclu... | [source_detector_distances->[norm,_picks_to_idx,array],short_channels->[source_detector_distances],_channel_frequencies->[_picks_to_idx,empty],_check_channels_ordered->[int,_picks_to_idx,groups,RuntimeError,match]] | Check if the channels followed expected fNIRS format. | At some stage of processing, do we need to do something about pairs of channels where only one is marked bad? Basically whatever processing step(s) actually combine the data from two channels should probably "spread the badness", i.e., if one of them is marked bad before the operation, the operation can do its thing, b... |
@@ -223,6 +223,10 @@ public abstract class AbstractExtensionObjectFactory<T> extends AbstractAnnotate
if (valueResolver != null) {
builder.addPropertyResolver(objectField.getName(), valueResolver);
+ } else if (field.isRequired() && !field.getAnnotation(FlattenedTypeAnnotation.class).isPresent())... | [AbstractExtensionObjectFactory->[toValueResolver->[toValueResolver],resolveParameters->[toValueResolver,getParameters],getParametersAsResolverSet->[getParametersAsResolverSet,getParameters],resolveParameterGroups->[resolveParameterGroups]]] | Resolve parameters. | Error message shouldn't contain the terms class or field. From the user's point of view, he's missing a parameter. He doesn't know about the internal structure |
@@ -98,6 +98,7 @@ module Users
)
create_user_event(:piv_cac_enabled)
Funnel::Registration::AddMfa.call(current_user.id, 'piv_cac')
+ session[:needs_to_setup_piv_cac_after_sign_in] = false
redirect_to after_sign_in_path_for(current_user)
end
| [PivCacAuthenticationSetupController->[render_error->[new],user_piv_cac_form->[new],render_prompt->[new],authorize_piv_cac_disable->[piv_cac_enabled?]]] | if piv_cac is enabled for the user create a new piv_c. | Before, this wasn't being set while processing a valid PIV submission, causing the `after_sign_in_path_for(current_user)` to put the user back to the PIV setup screen, even though they just set it up. |
@@ -347,7 +347,11 @@ describes.realWin(
impl.goCallback(1, /*animate*/ false);
impl.goCallback(-1, /*animate*/ false);
- const updateInViewportSpy = sandbox.spy(impl, 'updateInViewport');
+ const ownerImpl = Services.ownersForDoc(impl.element);
+ const updateInViewport... | [No CFG could be retrieved] | The following methods are defined on the carousel interface. This method checks that the updateInViewportSpy method is called. | move this to beforeEach to avoid code duplications |
@@ -11,7 +11,9 @@ def Factory(settings, Model):
"model_part_name" : "MainModelPart",
"file_settings" : {},
"nodal_results_settings" : {},
- "time_tag_precision" : 4
+ "element_results_settings" : {},
+ "time_tag_precision" :... | [Factory->[PrimalBossakInput,TemporalInputProcess,input_time_settings,AddInput,AddEmptyValue,ValidateAndAssignDefaults,isinstance,Parameters,settings,HDF5ParallelFileFactory,Exception]] | Factory for creating a temporal input process for writing a transient primal solution to HDF5. | Can't we replace DEFAULT_NAME with the model part name like you did in the other files? This would eliminate this if statement. |
@@ -71,7 +71,7 @@ func (t *timestampOracle) setTSOPhysical(next time.Time) {
t.tsoMux.Lock()
defer t.tsoMux.Unlock()
// make sure the ts won't fall back
- if typeutil.SubTimeByWallClock(next, t.tsoMux.physical) >= updateTimestampGuard {
+ if typeutil.SubTimeByWallClock(next, t.tsoMux.physical).Milliseconds() >= 0... | [saveTimestamp->[getTimestampPath],resetUserTimestamp->[saveTimestamp],UpdateTimestamp->[getTSO,setTSOPhysical,saveTimestamp],SyncTimestamp->[saveTimestamp,setTSOPhysical,loadTimestamp],getTS->[getTSO,generateTSO],loadTimestamp->[getTimestampPath]] | setTSOPhysical sets the next timestamp in the tsoMux to be the next timestamp. | How about changing the implementation of `SubTimeByWallClock`? |
@@ -171,6 +171,11 @@ uint32_t EspClass::getFreeHeap(void)
return system_get_free_heap_size();
}
+uint16_t EspClass::getMaxFreeBlockSize(void)
+{
+ return system_get_free_heap_size();
+}
+
uint32_t EspClass::getChipId(void)
{
return system_get_chip_id();
| [getFlashChipSizeByChipId->[getFlashChipId],eraseConfig->[getFlashChipSize],checkFlashConfig->[getFlashChipSize,getFlashChipRealSize],wdtEnable->[wdtEnable],getFreeSketchSpace->[getSketchSize],getSketchMD5->[getSketchSize,flashRead],updateSketch->[restart]] | get free heap size and chip id. | What's the difference between this and the return via maxBlock pointer in getHeapFragmentation? |
@@ -128,11 +128,11 @@ public class PutKudu extends AbstractProcessor {
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
- protected static final PropertyDescriptor INSERT_OPERATION = new Builder()
- .name("Insert Operation")
+ protected static final PropertyDescriptor OPE... | [PutKudu->[insertRecordToKudu->[getSchema,newInsert,buildPartialRow,getRow],createClient->[getLogger,getPrincipal,loginKerberosUser,buildClient,getKeytab,execute],onScheduled->[getValue,openTable,createClient,debug,asInteger,valueOf,asControllerService],onTrigger->[trigger,getLogger,get,isEmpty,execute],getSupportedPro... | This service is used to provide a record reader for a kudu session. description The maximum number of FlowFiles to process in a single execution. | Is this a compatibility break? Is there a way to support the old name too? Perhaps just change the display name? |
@@ -130,6 +130,12 @@ func DeleteUploads(uploads ...*Upload) (err error) {
}
if err := os.Remove(localPath); err != nil {
+ i := 0
+ for i < 5 && strings.Contains(err.Error(), "The process cannot access the file because it is being used by another process") {
+ <-time.After(100 * time.Millisecond)
+ er... | [IsFile,Dir,Commit,Find,Close,Delete,In,Copy,New,Errorf,Create,Join,Remove,Where,Get,NewSession,MkdirAll,Write,LocalPath,Begin,String,Insert] | DeleteUploadByUUID deletes a single upload by UUID. | I imagine this string will be affected by the localization setting of Windows. Are there error codes available? |
@@ -237,7 +237,7 @@ class ActionCancelRoute(StateChange):
)
-class ReceiveLockExpired(StateChange):
+class ReceiveLockExpired(AuthenticatedSenderStateChange):
""" A LockExpired message received. """
def __init__(
| [ActionInitInitiator->[__ne__->[__eq__]],ReceiveLockExpired->[__ne__->[__eq__]],ReceiveTransferRefund->[__ne__->[__eq__]],ActionInitMediator->[__ne__->[__eq__]],ReceiveSecretReveal->[__ne__->[__eq__]],ActionInitTarget->[__ne__->[__eq__]],ReceiveTransferRefundCancelRoute->[__ne__->[__eq__]],ReceiveSecretRequest->[__ne__... | Initialize a lease object. | These guys should be calling `super().__init__()`, and then you will need to add the authenticated address to the constructors/`__eq__`/`__str__` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.