patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -721,5 +721,7 @@ def plot_topo_image_epochs(epochs, layout=None, sigma=0., vmin=None, fig_facecolor=fig_facecolor, font_color=font_color, border=border, x_label='Time (s)', y_label='Epoch', unified=True, img=True) + if fig_background is not None: +...
[_plot_timeseries_unified->[_compute_scalings],_erfimage_imshow_unified->[_compute_scalings],_plot_evoked_topo->[_plot_topo,set_ylim],plot_topo_image_epochs->[_plot_topo],_imshow_tfr_unified->[_compute_scalings],_plot_topo->[_iter_topography]]
Plot the topographic image on the given epochs. Plots a single image of the missing block image across sensors.
to save some work, do the `if fig_background is not None:` check in `add_background_image`, i.e. do nothing if it's `None`, do something if it's not. That way these functions can just make a call instead of each of them doing the same logic
@@ -282,14 +282,14 @@ function admin_page_federation(&$a) { foreach ($platforms as $p) { // get a total count for the platform, the name and version of the // highest version and the protocol tpe - $c = q('SELECT COUNT(*) AS `total`, `platform`, `network`, `version` FROM `gserver` + $c = qu('SELECT COUNT(*) A...
[admin_page_logs->[get_baseurl],admin_page_summary->[get_baseurl],admin_page_dbsync->[get_baseurl],admin_page_plugins->[get_baseurl],admin_page_users_post->[get_baseurl],admin_page_site_post->[get_baseurl,set_baseurl,get_path],admin_page_themes->[get_baseurl],admin_page_site->[get_baseurl,get_hostname,get_path],admin_p...
the admin_page_federation function - - - - - - - - - - - - - - - - - - This function is used to display the administration actions for a Friendica node. Get all the nagios from the current platform.
[standards] Please fix SQL query indentation (two tabs instead of one expected)
@@ -28,7 +28,7 @@ <% end %> -<div class="podcast-episode-container" data-meta="<%= @episode.decorate.mobile_player_metadata.to_json %>"> +<div id="main-content" class="podcast-episode-container" data-meta="<%= @episode.decorate.mobile_player_metadata.to_json %>"> <div class="hero"> <% image_url = Images::O...
[No CFG could be retrieved]
Return a list of all possible tags for a single episode. Displays a hidden block of content that can be found in the podcast s sequence.
Just a small change to request - can we also change this to a `<main>` element (and the closing tag)? This will help any users of assistive technology who navigate by landmarks on the page
@@ -71,7 +71,7 @@ public class DefaultAuthenticationEventExecutionPlan implements AuthenticationEv public Set<AuthenticationHandler> getAuthenticationHandlersForTransaction(final AuthenticationTransaction transaction) { final AuthenticationHandler[] handlers = authenticationHandlerPrincipalResolverMap.key...
[DefaultAuthenticationEventExecutionPlan->[registerAuthenticationHandlerWithPrincipalResolvers->[registerAuthenticationHandlerWithPrincipalResolver]]]
Gets authentication handlers for a given authentication transaction.
Please review the relevant section in the master branch and backport accordingly. Thank you.
@@ -64,3 +64,18 @@ evoked.plot(titles=dict(grad='Evoked Response Gradiometers'), ylim=ylim, residual.pick_types(meg='grad', exclude='bads') residual.plot(titles=dict(grad='Residuals Gradiometers'), ylim=ylim, proj=True) + +############################################################################### ...
[read_evokeds,max,regularize,print,read_forward_solution,read_cov,data_path,gamma_map,dict,plot,pick_types,crop,plot_sparse_source_estimates,abs]
Plot the residuals of the residuals.
can you clarify why you need to pass forward and not just the src?
@@ -3099,9 +3099,16 @@ def _read_one_epoch_file(f, tree, preload): if drop_log is None: drop_log = ((),) * len(events) + # as of v1.0, Epochs support Annotations which require raw_sfreq + # to be stored. However, for backwards compatibility if raw_sfreq + # is None (not found) in the fi...
[BaseEpochs->[standard_error->[average],plot_drop_log->[plot_drop_log],equalize_event_counts->[drop,drop_bad],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_good_epoch,_project_epoch],drop_bad->[_reject_setup],get_data->[_get_data],crop->[_set_times],to_data_frame->[copy,get_data],reset_drop_log_selection->[...
Read a single FIF file. read_tag - read the next n - sample CTF tag. Reads the data_tag and returns a . Returns a tuple of information data data_tag events event_id tmin tmax epoch shape.
Do you actually need to do this here? Even if it's `None`, the `BaseEpochs` should be able to use `raw_sfreq=None` as this alias already.
@@ -76,13 +76,15 @@ int EVP_CIPHER_param_to_asn1(EVP_CIPHER_CTX *c, ASN1_TYPE *type) goto err; /* ... but, we should get a return size too! */ - if (params[0].return_size != 0 + if (OSSL_PARAM_modified(params) + && params[0].return_size != 0 && (der = OPENSS...
[EVP_Cipher->[EVP_CIPHER_CTX_block_size],EVP_CIPHER_CTX_block_size->[EVP_CIPHER_block_size],EVP_CIPHER_CTX_iv_length->[EVP_CIPHER_iv_length,EVP_CIPHER_flags],EVP_MD_meth_dup->[EVP_MD_meth_new],EVP_CIPHER_mode->[EVP_CIPHER_flags],char->[EVP_CIPHER_nid]]
This method checks if the passed - in EVP - CIPHER parameter has been set get the buffer size and the actual value.
Style nit: I think the intention is clearer if you make the argument `&params[0]`
@@ -691,14 +691,14 @@ public class PutDatabaseRecord extends AbstractProcessor { final Object[] values = currentRecord.getValues(); final List<DataType> dataTypes = currentRecord.getSchema().getDataTypes(); - List<ColumnDescription> columns = tableSchema.ge...
[PutDatabaseRecord->[checkValuesForRequiredColumns->[getNormalizedColumnNames],putToDatabase->[executeSQL,executeDML,getStatementType],normalizeKeyColumnNamesAndCheckForValues->[getNormalizedColumnNames],customValidate->[customValidate],TableSchema->[from->[from,getColumns,normalizeColumnName,TableSchema],normalizeColu...
Executes a DML query. This method is used to generate the SQL for each batch of records. private final PreparedStatement preparedSqlAndColumns ; private int currentBatchSize = 0 ;.
Is it required NPE/IOE checks?
@@ -239,7 +239,9 @@ class ReadOnlyMiddleware(MiddlewareMixin): if writable_method: return JsonResponse({'error': self.ERROR_MSG}, status=503) elif request.method == 'POST': - return render(request, 'amo/read-only.html', status=503) + response = render(request...
[SetRemoteAddrFromForwardedFor->[process_request->[is_request_from_cdn]],CommonMiddleware->[process_request->[safe_query_string]]]
Process a request to retrieve a single node.
this reads weird - what's going on with the read-only case that we have to force `.render()` on the response before returning?
@@ -1482,12 +1482,12 @@ namespace Dynamo.Models /// <param name="maxTesselationDivisions">The maximum number of /// tessellation divisions to use for regenerating render packages.</param> /// - public void RequestVisualUpdate(int maxTesselationDivisions) + public void RequestV...
[NodeModel->[BuildAst->[BuildOutputAst],Save->[SaveNode],AddToLabelMap->[AddToLabelMap],Warning->[Warning],p_PortDisconnected->[DisconnectOutput,DisconnectInput,ValidateConnections],Load->[LoadNode],GetPortVerticalOffset->[GetPortIndexAndType],ClearRuntimeError->[ClearTooltipText],RegisterAllPorts->[RegisterInputPorts,...
This method is called when a node is requested to produce geometric output.
i remember 'async' suffix normally means it is waitable?
@@ -59,8 +59,8 @@ func resourceAwsWafv2WebACL() *schema.Resource { MaxItems: 1, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ - "allow": wafv2EmptySchema(), - "block": wafv2EmptySchema(), + "allow": wafv2AllowConfigSchema(), + "block": wafv2BlockConfigSchema(), }, ...
[StringLenBetween,GetChange,IgnoreAws,DeleteWebACL,StringInSlice,Set,NonRetryableError,Wafv2ListTags,Int64Value,GetOk,New,HasChanges,All,HasChange,Errorf,SetId,MustCompile,RetryableError,RemoveDefaultConfig,MergeTags,GetWebACL,ErrCodeEquals,IgnoreConfig,Id,Int64,Get,UpdateWebACL,Split,Map,RateBasedStatementAggregateKey...
This function is a static factory function for creating a new resource that uses the wafv2 Required by Waf - v2.
let's also add these newly defined blocks in `wafv2_web_acl.html.markdown`
@@ -141,6 +141,18 @@ public class DefaultHttp2ConnectionDecoder implements Http2ConnectionDecoder { frameReader.close(); } + /** + * Calculate the threshold in bytes which should trigger a {@code GO_AWAY} if a set of headers exceeds this amount. + * @param maxHeaderListSize + * <a hr...
[DefaultHttp2ConnectionDecoder->[unconsumedBytes->[unconsumedBytes],PrefaceFrameListener->[verifyPrefaceReceived->[prefaceReceived],onPingRead->[verifyPrefaceReceived,onPingRead],onSettingsRead->[FrameReadListener,onSettingsRead,prefaceReceived],onUnknownFrame->[onUnknownFrame0],onHeadersRead->[onHeadersRead,verifyPref...
Close the frame reader and read the next unconditional byte.
maybe just `1.5 * maxHeaderListSize` to make it more immediately clear? Also, do you need to take into account overflow? I guess it's a long so maybe not?
@@ -661,8 +661,14 @@ int EVP_PKEY_set_type_str(EVP_PKEY *pkey, const char *str, int len) return pkey_set_type(pkey, NULL, EVP_PKEY_NONE, str, len, NULL); } +#ifndef OPENSSL_NO_DEPRECATED_3_0 int EVP_PKEY_set_alias_type(EVP_PKEY *pkey, int type) { + if (!evp_pkey_is_legacy(pkey)) { + ERR_raise(ERR_LI...
[No CFG could be retrieved]
private private key region Public Key Alias.
Isn't this likely to break existing applications that call this function?
@@ -846,10 +846,16 @@ class FreqtradeBot(object): trade.open_order_id = order_id trade.close_rate_requested = limit trade.sell_reason = sell_reason.value + Trade.session.flush() + self.notify_sell(trade) - profit_trade = trade.calc_profit(rate=limit) + def notify_sel...
[FreqtradeBot->[execute_buy->[get_target_bid,_get_min_pair_stake_amount],cleanup->[cleanup],process_maybe_execute_buy->[create_trade],handle_timedout_limit_buy->[handle_buy_order_full_cancel],create_trade->[_get_trade_stake_amount]]]
Executes a limit sell for the given trade and limit critical critical critical critical critical critical critical This function is called when a new node is created.
what prevents you to fetch the real value (average) instead of requested value?
@@ -65,7 +65,13 @@ class LonelyMeetingExperience extends PureComponent<Props> { * @inheritdoc */ render() { - const { _isInviteFunctionsDiabled, _isLonelyMeeting, _styles, t } = this.props; + const { + _isInviteFunctionsDiabled, + _isLonelyMeeting, + _styl...
[No CFG could be retrieved]
Constructor for a lonely meeting experience. Displays a button with the specified name in the Redux component.
You could just return null if this is set.
@@ -113,6 +113,9 @@ def get_supported(versions=None, noarch=False): for arch in arches: supported.append(('%s%s' % (impl, versions[0]), abi, arch)) + # Major Python version + platform; e.g. binaries not using the Python API + supported.append(('py%s' % (versions[0][0]), 'no...
[get_platform->[get_platform],get_supported->[get_platform,get_abbr_impl],get_supported]
Returns a list of supported tags for each version. This function returns a list of all possible missing missing keys.
PEP 8 failure - line too long
@@ -182,6 +182,9 @@ class TestRun(MypycDataSuite): print(line) assert False, 'Compile error' + # Check that serialization works on this IR + check_serialization_roundtrip(ir) + setup_file = os.path.abspath(os.path.join(workdir, 'setup.py')) ...
[chdir_manager->[chdir,getcwd],TestRun->[run_case->[max,copyfile,CompilerOptions,assert_test_output,join,remove,Errors,abspath,Options,copy,glob,splitlines,flush_errors,system,getoption,append,print,dirname,show_c,construct_groups,len,chdir_manager,setdefault,compile_modules_to_c,format,BuildSource,open,relpath,write,b...
Run the test case. Add a single module to the list of modules to be built and compile it. Check if a node has a specific suffix.
Nice, this is a clever way to test serialization -- without writing any new tests! Have you checked that the existing tests cover all the interesting cases? What about things like multiple SCCs that depend on each other in different ways.
@@ -39,6 +39,7 @@ public class CreatePipelineCommand private final ReplicationFactor factor; private final ReplicationType type; private final List<DatanodeDetails> nodelist; + private final List<Integer> priorityList; public CreatePipelineCommand(final PipelineID pipelineID, final ReplicationType...
[CreatePipelineCommand->[getFromProtobuf->[getFromProtobuf,CreatePipelineCommand,getType]]]
Creates a new instance of CreatePipelineCommand that creates a new datanode in the specified pipeline. Replies the type of the command.
I consider that, should move `RatisPipelineProvider.getPriorityList()`, `HIGH_PRIORITY`, `LOW_PRIORITY` here, and replace priorityList in Ctor param as suggestedLeader. We can minimize the existence of `priorityList`, and the calculation logic of priority in `RatisPipelineProvider` is a little bit weird.
@@ -269,6 +269,10 @@ class SuluMediaExtension extends Extension implements PrependExtensionInterface $loader->load('services.xml'); $loader->load('command.xml'); + if (SvgImagine::class) { + $loader->load('services_imagine_svg.xml'); + } + if ('auto' === $config['ad...
[SuluMediaExtension->[configureStorage->[load],load->[load]]]
Loads the configuration for the media. Adds the parameters for the collection type. This method is called when the configuration is not installed. It is called by the Symfony extension.
Are you missing a `class_exists` call or something like that around this? I get an error currently, saying that the `Contao\ImagineSvg\Imagine` class cannot be loaded, if the package is not installed...
@@ -94,7 +94,7 @@ class TestReviewNotesSerializerOutput(TestCase, LogMixin): # Comments should be the santized text rather than the actual content. assert result['comments'] == amo.LOG.REQUEST_SUPER_REVIEW.sanitize assert result['comments'].startswith( - 'The addon has been flagged...
[TestReviewNotesSerializerOutput->[test_should_not_highlight->[serialize,log],test_basic->[serialize],setUp->[log],test_log_entry_without_details->[serialize],test_url_for_developers->[serialize],test_sanitized_activity_detail_not_exposed_to_developer->[serialize,log],test_url_for_admins->[serialize],test_url_for_yours...
Test that the santized activity detail is not exposed to the developer.
This is a reviewer review :) - Admin Review being the alternate name for Super Review
@@ -97,10 +97,11 @@ public class MeasureQuery { } MeasureQuery that = (MeasureQuery) o; return Objects.equals(analysisUuid, that.analysisUuid) && - Objects.equals(componentUuids, that.componentUuids) && - Objects.equals(metricIds, that.metricIds) && - Objects.equals(metricKeys, that....
[MeasureQuery->[Builder->[build->[MeasureQuery]],copyWithSubsetOfComponentUuids->[MeasureQuery],equals->[equals]]]
Compares two MeasureQuery objects.
using `Objects.equals` on non nullable `analysisUuid` is useless
@@ -63,6 +63,8 @@ def plot_ica_sources(ica, inst, picks=None, exclude=None, start=None, Whether to halt program execution until the figure is closed. Useful for interactive selection of components in raw and epoch plotter. For evoked, this parameter has no effect. Defaults to False. + igno...
[plot_ica_properties->[_create_properties_layout,set_title_and_labels]]
Plots the estimated latent sources given the unmixing matrix. Plots raw sources and evoked sources.
Double negatives are tough, how about `show_first_samp=False` by default, and `show_first_samp=True` means show times relative to `first_samp`?
@@ -288,13 +288,13 @@ frappe.ui.form.MultiSelectDialog = Class.extend({ page_length: this.page_length + 1, query: this.get_query ? this.get_query().query : '', as_dict: 1 - } + }; frappe.call({ type: "GET", - method:'frappe.desk.search.search_widget', + method: 'frappe.desk.search.search_widget...
[No CFG could be retrieved]
This method retrieves the results of the search. This method is called when a date field is found in the result object. It will add.
Previously we would sort based on Date field, it seems like you removed a few statements with respect to it but not all. I'd suggest to handle it better
@@ -0,0 +1,14 @@ +module Api + module V0 + module Admin + class ConfigsController < ApiController + before_action :authenticate! + before_action :authorize_super_admin + + def show + @site_configs = SiteConfig.all + end + end + end + end +end
[No CFG could be retrieved]
No Summary Found.
I'm not sure we should enable OAuth2 here for now, maybe we can use `authenticate_with_api_key_or_current_user!` ?
@@ -133,6 +133,7 @@ namespace CoreNodeModels SelectedMetricConversion = ConversionMetricUnit.Length; ShouldDisplayPreviewCore = true; IsSelectionFromBoxEnabled = true; + Warning("Convert Between Units " + Properties.Resources.ConversionNodeObsoleteMessage, true); ...
[DynamoConvert->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]]]
DynamoConvert creates a DynamoConvert object that converts a number of units into a number This method is called to select the input node from the conversion tree.
I don't think you need to do this if the node is obsolete - or does that only work for ZT nodes?
@@ -5,9 +5,13 @@ # Licensed under the MIT License. See License.txt in the project root for # license information. # -------------------------------------------------------------------------- -import pytest -from azure.core.credentials import AccessToken +from datetime import datetime, timedelta +import os +import ...
[FormRecognizerTest->[generate_fake_token->[FakeTokenCredential]]]
Creates a class which can be used to test a specific type of access needed by the user Create a resource in the form.
you can also assert that if not include_text_content, these properties are None
@@ -998,6 +998,9 @@ def _fill_ufunc_db(ufunc_db): ufunc_db[np.negative].update({ 'm->m': npdatetime.timedelta_neg_impl, }) + ufunc_db[np.positive].update({ + 'm->m': npdatetime.timedelta_pos_impl, + }) ufunc_db[np.absolute].update({ 'm->m': npdatetime.timedelta_abs_impl, ...
[get_ufunc_info->[_lazy_init_db],get_ufuncs->[_lazy_init_db]]
Fill ufunc_db with values from nanomagnetic - to - non - nan ufunc_db is a mapping of ufunc to ufunc_db ufunc_db is a mapping of ufunc to ufunc_db. ufunc_db is a mapping of ufunc to ufunc_db. This function is used to find ufunc_db for all possible ufuncs.
Not here, but sometime it'd be good to wire in `M->M`, will probably need to patch the loop selection in `numpy_support` for that.
@@ -363,8 +363,8 @@ func resourceName(r *schema.Resource) string { return strings.Title(tokenToName(r.Token)) } -func getLanguageDocHelper(lang string) codegen.DocLanguageHelper { - if h, ok := docHelpers[lang]; ok { +func getLanguageDocHelper(dctx *docGenContext, lang string) codegen.DocLanguageHelper { + if h, o...
[genResource->[genNestedTypes,genLookupParams,genConstructors,getProperties,getConstructorResourceInfo,genResourceHeader],gen->[getModuleFileName,genResource,add],getPropertiesWithIDPrefixAndExclude->[typeString],genIndex->[getModuleFileName],genConstructors->[genConstructorTS,genConstructorPython,genConstructorGo,genC...
contains returns true if the given token is already in the typeUsageInfo. get the name of the module that should be used for the language.
Nit: I have a _slight_ preference for making this (and other functions that take a `*docGenContext` as their first param) methods on `*docGenContext`
@@ -10,10 +10,14 @@ import ( "github.com/joeshaw/multierror" + "github.com/elastic/beats/libbeat/common/wait" "github.com/elastic/beats/libbeat/logp" ) -var debugK = "event_reporter" +var ( + debugK = "event_reporter" + reportJitter = 2 * time.Second +) // EventReporter is an object that will period...
[Stop->[Info,Wait],worker->[Stop,Unlock,NewTicker,reportEvents,Lock,Done],reportEvents->[sendBatchEvents,Errorf,Debugf],Start->[Info,worker,Add],sendBatchEvents->[Err,sendEvents],sendEvents->[EventType,SendEvents,Now],AddEvent->[Lock,Unlock],Named]
NewEventReporter returns an object that will periodically send asyncronously events to the endpoint reportEvents reports events to the kibana events channel.
Use 300ms instead to align with the testing load from @mattapperson
@@ -55,9 +55,10 @@ public class BaseRedisProperties implements Serializable { private int port = 6379; /** - * Connection timeout in milliseconds. + * Command timeout, default from Lettuce is 60s. */ - private int timeout = 2000; + @DurationCapable + private String timeout; /**...
[BaseRedisProperties->[RedisSentinelProperties,RedisPoolProperties,RedisClusterProperties]]
A class that represents a single Redis node type. ReadFromTypes - Read from the type of the node.
I think it might be good to assign a default value here, even if the default is picked up from somewhere else if left unassigned. This will show up in the docs and makes it easy for someone to figure out what the actual value is without having to parse code, and will also help drive the configuration metadata.
@@ -49,7 +49,6 @@ setup( 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6',...
[find_packages,setup,search,replace,read,format,RuntimeError,join,open]
Package name version and long description.
is there a reason for this? curious
@@ -0,0 +1,17 @@ +class FacebookService + def initialize(user) + @user = user + end + + def provider + @provider ||= @user.providers.find_by(name: 'facebook') + end + + def client + @client ||= Koala::Facebook::API.new(provider.token) + end + + def uids + client.get_connections(:me, :friends).map { |...
[No CFG could be retrieved]
No Summary Found.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
@@ -132,7 +132,7 @@ class DataTables(object): df = df[df["drv"] == self.drive_filter] if self.class_filter: df = df[df["class"] == self.class_filter] - self.source.data = ColumnDataSource.from_df(df) + self.source.data = ColumnDataSource._data_from_df(df) self.s...
[DataTables->[update_data->[store_document,from_df],create->[IntEditor,add_glyph,TableColumn,SelectEditor,Select,StringEditor,mpg,DataRange1d,BoxSelectTool,DataTable,hplot,NumberFormatter,add_tools,sorted,add_layout,Plot,vplot,NumberEditor,LinearAxis,Circle,StringFormatter,HoverTool,on_change,Grid],on_class_change->[up...
Update data based on filter parameters.
This is problematic. Our examples should never rely on private APIs.
@@ -37,10 +37,13 @@ export function getAdCid(adElement) { * @param {!./service/ampdoc-impl.AmpDoc|!Node} ampDoc * @param {string} clientIdScope * @param {string=} opt_clientIdCookieName + * @param {number=} opt_timeout * @return {!Promise<string|undefined>} A promise for a CID or undefined. */ export functio...
[No CFG could be retrieved]
Get a CID from the AMP doc. The object that is returned by the constructor.
Instead of finiteNumber, can you just round up to nearest whole number and consider adding warn? Otherwise the number is just not honored. Also are you positive the typing is passed correctly given this is parsed from a string? Perhaps parseInt is sufficient which will cut the decimals?
@@ -1125,7 +1125,8 @@ public class UpdateSite { return deps; } - + + @Exported public boolean isForNewerHudson() { try { return requiredCore!=null && new VersionNumber(requiredCore).isNewerThan(
[UpdateSite->[updateDirectlyNow->[getId],getMetadataUrlForDownloadable->[getUrl],getJsonSignatureValidator->[getJsonSignatureValidator],getDataFile->[getId],getUpdates->[getData],verifySignature->[verifySignature],getPlugin->[getData],Data->[getJSONObject],Warning->[isRelevantToVersion->[includes],equals->[equals],isRe...
Returns the list of plugins that are required to be installed. Checks if the version string is a sequence of private versions.
Should probably be exported with a `Jenkins` name (or more neutrally, `Core`).
@@ -76,6 +76,12 @@ public class JNLPLauncher extends ComputerLauncher { private boolean webSocket; + /** + * @see #getInboundAgentUrl() + */ + @NonNull + public static final String CUSTOM_INBOUND_URL_PROPERTY = "jenkins.agent.inboundUrl"; + /** * Constructor. * @param tunnel T...
[JNLPLauncher->[isJavaWebStartSupported->[isRunningWithJava8OrBelow],readResolve->[getDisabledDefaults],getWorkDirOptions->[toCommandLineString],DescriptorImpl->[isWorkDirSupported->[getClass,equals],getDisplayName->[JNLPLauncher_displayName],doCheckWebSocket->[ok,error,isSupported,fixEmptyAndTrim,getTcpSlaveAgentListe...
A class that runs a single . JNLP Launcher for the given .
should be `@Restricted`
@@ -543,7 +543,7 @@ class HParams(object): return self.override_from_dict(values_map) def override_from_dict(self, values_dict): - """Override hyperparameter values, parsing new values from a dictionary. + """Override existing hyperparameter values, parsing new values from a dictionary. Args: ...
[_process_scalar_value->[_parse_fail,_reuse_fail],_process_list_value->[_parse_fail,_reuse_fail],parse_values->[parse_bool->[_parse_fail],_process_scalar_value,_process_list_value,_parse_fail],HParams->[__repr__->[__str__],override_from_dict->[set_hparam],set_from_map->[override_from_dict],from_proto->[HParams],set_hpa...
Override hyperparameter values parsing new values from a dictionary.
this line is over 80 chars long; please shorten.
@@ -651,13 +651,8 @@ spec: clientPort: format: int32 type: integer - defragmentationSchedule: - description: DefragmentationSchedule defines the cron standard - schedule for defragmentation of etcd. - ...
[Deploy->[MakeUnique,AddAllAndSerialize,Must,CreateForSeed,InjectAnnotations,Int32,String,NewRegistry,MustParse],WaitCleanup->[WithTimeout,WaitUntilDeleted],Wait->[WithTimeout,WaitUntilHealthy],Destroy->[ConfirmDeletion,IsNoMatchError,List,DeleteForSeed,Errorf,IsNotFound,IgnoreNotFound]]
This function returns a description of the given secret name. Options for kubeadm - container.
Why was this removed?
@@ -400,8 +400,8 @@ public abstract class SslContext { X509Certificate[] trustCertCollection, TrustManagerFactory trustManagerFactory, X509Certificate[] keyCertChain, PrivateKey key, String keyPassword, KeyManagerFactory keyManagerFactory, Iterable<String> ciphers, CipherSuiteFilt...
[SslContext->[toPrivateKeyInternal->[toPrivateKey],newClientContextInternal->[defaultClientProvider,verifyNullSslContextProvider],newHandler->[newEngine],newClientContext->[newClientContext],getPrivateKeyFromByteBuffer->[generateKeySpec],toX509CertificatesInternal->[toX509Certificates],newServerContext->[newServerConte...
Creates a new server context.
add the provider to the message
@@ -378,9 +378,11 @@ bool t_rpc_command_executor::show_status() { % (unsigned)hfres.version % get_fork_extra_info(hfres.earliest_height, ires.height, ires.target) % (hfres.state == cryptonote::HardFork::Ready ? "up to date" : hfres.state == cryptonote::HardFork::UpdateNeeded ? "update needed" : "out of d...
[string->[],print_transaction_pool_long->[get_human_time_ago],print_transaction_pool_short->[get_human_time_ago],print_block_by_hash->[print_block_header],print_transaction_pool_stats->[get_human_time_ago],print_peer_list->[print_peer],print_block_by_height->[print_block_header]]
Check if the status of the command is available. if we have a node in the chain we can find it in the chain and return true.
Unbalanced braces on the last 2 lines. 4 left, 3 right. Cause error caught by compiler. /home/tdprime/bitmonero/src/daemon/rpc_command_executor.cpp: In member function 'bool daemonize::t_rpc_command_executor::show_status()': /home/tdprime/bitmonero/src/daemon/rpc_command_executor.cpp:386:38: error: invalid operands of ...
@@ -32,10 +32,6 @@ RSpec.describe Authentication::Providers, type: :service do end describe ".enabled" do - it "lists all available providers" do - expect(described_class.available).to eq(described_class.enabled) - end - context "when one of the available providers is disabled" do it "onl...
[to,enabled,context,get!,be,describe,eq,it,require,raise_error,and_return]
checks that the given authentication provider class is enabled.
why did we lose this?
@@ -10,6 +10,10 @@ func TestAccAWSGuardDuty(t *testing.T) { "basic": testAccAwsGuardDutyDetector_basic, "import": testAccAwsGuardDutyDetector_import, }, + "Member": { + "basic": testAccAwsGuardDutyMember_basic, + "import": testAccAwsGuardDutyMember_import, + }, } for group, m := range testCases...
[Run]
TestAccAWSGuardDuty tests if an object has a specific .
I assume there can be more than 1 member per AWS account, so we don't need to make these tests synchronous? Unless I'm mistaken...
@@ -185,4 +185,10 @@ public class KotlinCoroutineIntegrationProcessor { } }); } + + private static HandlerChainCustomizer flowCustomizer() { + return new FixedHandlersChainCustomizer( + List.of(new FlowToPublisherHandler(), new PublisherResponseHandler()), + ...
[KotlinCoroutineIntegrationProcessor->[createCoroutineInvoker->[parameters,throwException,size,returnType,returnValue,getMethodCreator,toString,StringBuilder,invokeVirtualMethod,name,isInterface,flags,GeneratedClassGizmoAdaptor,kind,getMethodParam,readArrayValue,invoker,append,sha1,getName,loadNull,ClassCreator,invokeI...
Build a flow support.
I can't find the FlowToPublisherHandler class anywhere.
@@ -0,0 +1,5 @@ +'use strict'; + +module.exports = { + name: 'this' +};
[No CFG could be retrieved]
No Summary Found.
`ignore: true` I think additional bonus points!
@@ -508,8 +508,14 @@ public class CardBrowser extends NavigationDrawerActivity implements getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_HIDDEN); - // set the currently selected deck - selectDropDownItem(getDeckPositionFromDeckId(getIntent().getLongExtra("defa...
[CardBrowser->[updateList->[updatePreviewMenuItem],onCollectionLoaded->[onCollectionLoaded],onDestroy->[onDestroy],onNavigationPressed->[onNavigationPressed],onCreate->[onCreate],onOptionsItemSelected->[onClick->[changeDeck],onOptionsItemSelected,getSelectedCardIds],onCheck->[updateMultiselectMenu],updateCardsInList->[...
Load the collection of cards. Load the default value for column 1 selection and create a list view of the card list view Creates a new adapter mapping the data in mCards to the column 2 of the main m Set the list view to show the last known card that is selected on the list view.
This could be ALL_DECKS_ID again to avoid the magical zero here I think?
@@ -777,7 +777,7 @@ def run_subprocess(command, verbose=None, *args, **kwargs): "that you use '$HOME' instead of '~'.") warnings.warn(msg) - logger.info("Running subprocess: %s" % str(command)) + logger.info("Running subprocess: %s" % ' '.join(command)) try: p = subprocess...
[ProgressBar->[update_with_increment_value->[update]],_chunk_read->[ProgressBar],_fetch_file->[_chunk_read,_fetch_file,_chunk_read_ftp_resume],_get_stim_channel->[get_config],set_config->[get_config_path],_chunk_write->[update_with_increment_value],get_config->[get_config_path],_TempDir->[__new__->[__new__]],object_dif...
Run command using subprocess. Popen and wait for command to complete. Returns the output of the command if it succeeds. Otherwise raises subprocess. CalledProcessError.
@agramfort can you share a screenshot or print of output generated here?
@@ -1607,6 +1607,12 @@ def img_conv_layer(input, filter_size, num_filters, param_attr.attr["initial_std"] = init_w param_attr.attr["initial_strategy"] = 0 param_attr.attr["initial_smart"] = False + + if trans: + lt = LayerType.CONVTRANS_LAYER + else: + lt = LayerType.C...
[recurrent_group->[mixed_layer,identity_projection,is_single_input,targetInlink_in_inlinks,memory],fc_layer->[LayerOutput],scaling_layer->[LayerOutput],last_seq->[LayerOutput],regression_cost->[LayerOutput,__cost_input__],img_cmrnorm_layer->[__img_norm_layer__],conv_shift_layer->[LayerOutput],slope_intercept_layer->[La...
A basic convolution layer for a 2D image. The x dimension of the stride. Or input a tuple for two image dimensions. Or input Creates a single layer.
lt = LayerType.CONVTRANS_LAYER if trans else LayerType.CONV_LAYER
@@ -720,6 +720,10 @@ RtpsUdpTransport::IceEndpoint::choose_send_socket(const ACE_INET_Addr& destinati void RtpsUdpTransport::IceEndpoint::send(const ACE_INET_Addr& destination, const STUN::Message& message) { + if (destination == transport.config().rtps_relay_address()) { + ++transport.relay_message_counts_.stun...
[No CFG could be retrieved]
This function returns the address of the network interface that the message should be sent to. Checks if the agent is reachable and registers the STUN message.
same question about success & failure here... and for rtps_send increments.
@@ -46,6 +46,14 @@ module.exports = function (context) { } } + // Permit object destructuring, since that is similar to membership access. + if ( + parent.type === 'Property' && + parent.parent.type === 'ObjectPattern' + ) { + return; + } + context.repor...
[No CFG could be retrieved]
Checks if the node is on the left side of the tree and reports it if so.
Shouldn't we only permit destructure-rename, that way we avoid allowing standalone identifiers to take on the bad format?
@@ -11,7 +11,7 @@ namespace System.Text.Json.Serialization.Converters /// </summary> internal sealed class JsonObjectDefaultConverter<T> : JsonObjectConverter<T> { - internal override bool OnTryRead(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options, ref ReadStack state, ...
[JsonObjectDefaultConverter->[OnTryWrite->[ClassType,Value,ShouldWritePreservedReferences,WriteStartObject,ProcessedStartToken,EnumeratorIndex,ShouldSerialize,DataExtensionProperty,ProcessedEndToken,ShouldFlush,WriteReferenceForObject,WriteEndObject,SupportContinuation,WriteNullValue,Assert,Ref,GetMemberAndWriteJson,En...
This method is called when a JSON object is read from the JSON stream. It reads all This method is called from the constructor to read a value from the JSON stream. Reads a single object property or a value from the JSON and sets the member.
This may become protected (instead of just internal) and I don't think we want to say this shouldn't be null. Also what's the difference between `DisallowNull` and `[MaybeNullWhen(false)]`?
@@ -579,8 +579,8 @@ OSSL_CMP_MSG *ossl_cmp_rr_new(OSSL_CMP_CTX *ctx) return NULL; } -OSSL_CMP_MSG *ossl_cmp_rp_new(OSSL_CMP_CTX *ctx, OSSL_CMP_PKISI *si, - OSSL_CRMF_CERTID *cid, int unprot_err) +OSSL_CMP_MSG *ossl_cmp_rp_new(OSSL_CMP_CTX *ctx, const OSSL_CMP_PKISI *si, + ...
[ossl_cmp_pkiconf_new->[ossl_cmp_msg_create,OSSL_CMP_MSG_free],ossl_cmp_pollReq_new->[ossl_cmp_msg_create,OSSL_CMP_MSG_free],OSSL_CMP_MSG_read->[OSSL_CMP_MSG_new,OSSL_CMP_MSG_free],ossl_cmp_rr_new->[ossl_cmp_msg_create,OSSL_CMP_MSG_free],ossl_cmp_pollRep_new->[ossl_cmp_msg_create,OSSL_CMP_MSG_free],ossl_cmp_msg_gen_pus...
This function checks if a message is available in the chain and if so returns it. If This function creates a new message and checks if the message is correct and returns it.
Adding `const` to internal API's seems like a not-important change for post-beta release. Similarly, renaiming a parameter.
@@ -377,6 +377,10 @@ class Grouping < ApplicationRecord !current_submission_used.nil? end + def has_non_empty_submission? + has_submission? && !current_submission_used.is_empty + end + def marking_completed? !current_result.nil? && current_result.marking_state == Result::MARKING_STATES[:complete]...
[Grouping->[deletable_by?->[is_valid?],test_runs_instructors->[pluck_test_runs,group_hash_list,filter_test_runs],has_files_in_submission?->[has_submission?],due_date->[due_date],test_runs_students_simple->[filter_test_runs],remove_member->[membership_status],remove_rejected->[membership_status],test_runs_students->[plu...
Returns true if the current group has at least one submission node with the given name.
Naming/PredicateName: Rename has_non_empty_submission? to non_empty_submission?.
@@ -131,7 +131,10 @@ func (nc *NatsClient) Connect() error { "max_retries": nc.retries, }).Error("Unable to connect to server") - time.Sleep(5 * time.Second) + baseSleep := int64(uint32(1) << tries) + randomization := rand.Int63n(baseSleep) + totalSleep := baseSleep + randomization + time.Sleep(time.Durat...
[tryConnect->[Connect],Close->[Close],ConnectAndPublish->[Connect],ConnectAndSubscribe->[Connect]]
Connect attempts to connect to the NATS server using the provided TLS configuration.
Randomized exponential backoff. This breaks up simultaneous requests over time as it keeps retrying.
@@ -396,6 +396,13 @@ def label_src_vertno_sel(label, src): src_sel = np.searchsorted(vertno[1], vertno_sel) + len(vertno[0]) vertno[0] = np.array([]) vertno[1] = vertno_sel + elif label.hemi == 'both': + vertno_sel_lh = np.intersect1d(vertno[0], label.lh.vertices) + src_sel_l...
[read_source_spaces->[read_source_spaces_from_tree],_read_one_source_space->[patch_info]]
Label the vertices in the source space and return the indices of the selected vertices in the s.
is this code block covered by a test?
@@ -40,9 +40,13 @@ class ReachabilityAnalyzer(TraverserVisitor): self.cur_mod_id = mod_id self.cur_mod_node = file self.options = options + self.is_global_scope = True for i, defn in enumerate(file.defs): + if isinstance(defn, (ClassDef, FuncDef)): + ...
[ReachabilityAnalyzer->[visit_file->[enumerate,assert_will_always_fail,accept,isinstance],visit_if_stmt->[accept,infer_reachability_of_if_statement],visit_for_stmt->[accept],visit_block->[super]]]
Visit a MypyFile and find the missing node.
What about just saying `node.is_top_level = self.is_global_scope` (here and below)?
@@ -11,6 +11,8 @@ { public static AssemblyScanningComponent Initialize(Configuration configuration, SettingsHolder settings) { + var assemblyScannerSettings = configuration.AssemblyScannerConfiguration; + var shouldScanBinDirectory = configuration.UserProvidedTypes == null...
[AssemblyScanningComponent->[Configuration->[SetDefaultAvailableTypes->[SetDefault],settings]]]
Initializes the assembly scanning component.
This can be reverted and moved back to where it was before.
@@ -23,7 +23,7 @@ const ( // FirstEpoch is the number of the first epoch. FirstEpoch = 1 // GenesisShardNum is the number of shard at genesis - GenesisShardNum = 4 + GenesisShardNum = 1 // GenesisShardSize is the size of each shard at genesis GenesisShardSize = 100 // GenesisShardHarmonyNodes is the number ...
[Reshard->[cuckooResharding,sortCommitteeBySize,assignNewNodes],assignNewNodes->[sortCommitteeBySize],Reshard]
Package containing all of the basic information about a single non - zero number of non - zero nanononononononononononononononononon.
this is for debugging only?
@@ -177,7 +177,8 @@ crt_proc_daos_prop_t(crt_proc_t proc, crt_proc_op_t proc_op, daos_prop_t **data) prop->dpp_reserv = tmp; rc = crt_proc_prop_entries(proc, proc_op, prop); if (rc) { - daos_prop_free(prop); + D_FREE(prop->dpp_entries); + D_FREE(prop); return rc; } *data = prop;
[crt_proc_daos_prop_t->[daos_prop_alloc,D_FREE,D_FREE_PTR,crt_proc_uint32_t,daos_prop_free,crt_proc_prop_entries,D_ERROR],crt_proc_struct_daos_acl->[daos_acl_get_size,d_iov_set,DECODING,crt_proc_d_iov_t,D_ERROR],int->[crt_proc_struct_daos_acl,D_ALLOC,D_FREE,DECODING,crt_proc_d_rank_list_t,crt_proc_memcpy,FREEING,crt_pr...
This function is used to convert DAOS_PROC_ENCODE DAOS This function is used to create a property object for a given proc_op.
This change fixes the crash and will want backporting.
@@ -132,7 +132,7 @@ define([ * @param {Number[]} array The array to pack into. * @param {Number} [startingIndex=0] The index into the array at which to start packing the elements. */ - BoxGeometry.pack = function(value, array, startingIndex) { + BoxGeometry.pack = function (value, array, startin...
[No CFG could be retrieved]
Creates a new BoxGeometry with the specified number of elements packed into an array. Retrieves an object from a packed array.
There are a lot of new spacing changes in this file and we don't want. Did WebStorm autoformat these?
@@ -26,6 +26,8 @@ from paddle.fluid.op import Operator import paddle.fluid as fluid from paddle.fluid import Program, program_guard +paddle.enable_static() + def output_hist(out): hist, _ = np.histogram(out, range=(-5, 10))
[TestUniformRandomOpSelectedRowsShapeTensor->[check_with_place->[output_hist],test_check_output->[get_places,check_with_place]],TestUniformRandomOp_attr_tensor->[verify_output->[output_hist],setUp->[init_attrs]],TestUniformDtype->[test_default_dtype->[test_default_fp32,test_default_fp64]],TestUniformOpError->[test_erro...
Calculate histogram of the output of the N - D histogram.
Why need this?
@@ -243,6 +243,10 @@ public class DelegatedClientAuthenticationAction extends AbstractAuthenticationA } } + private boolean isLogoutRequest(final HttpServletRequest request) { + return request.getParameter(SAML2ServiceProviderMetadataResolver.LOGOUT_ENDPOINT_PARAMETER) != null; + } + p...
[DelegatedClientAuthenticationAction->[doExecute->[doExecute]]]
Handle exception.
This method should be used line 456 as well.
@@ -98,11 +98,10 @@ public class InternalCacheFactory<K, V> extends AbstractNamedCacheComponentFacto converter = new WrappedByteArrayConverter(); cache = new TypeConverterDelegatingAdvancedCache<>(cache, converter); } - bootstrap(cacheName, cache, configuration, globalComponentRegistry);...
[InternalCacheFactory->[createCache->[createAndWire,simpleCache,RuntimeException,createSimpleCache],construct->[UnsupportedOperationException],createSimpleCache->[bootstrapComponents->[PersistenceManagerStub,registerComponent,Factory,ActivationManagerStub,PassivationManagerStub],cacheComponents->[getOrCreateComponent],...
Creates a cache with the given name and configuration. This is a class - level method that is used to register the components that are needed by.
Can be removed now
@@ -1608,11 +1608,12 @@ void wallet2::process_new_blockchain_entry(const cryptonote::block& b, const cry m_callback->on_new_block(height, b); } //---------------------------------------------------------------------------------------------------- -void wallet2::get_short_chain_history(std::list<crypto::hash>& id...
[No CFG could be retrieved]
private int m_local_bc_height ; private int sz = m_blockchain. size ;.
Is `blockchain_size` guaranteed to be no less than `m_blockchain.offset()`?
@@ -231,10 +231,13 @@ class Archives(abc.MutableMapping): archives = [x for x in self.values() if regex.match(x.name) is not None] for sortkey in reversed(sort_by): archives.sort(key=attrgetter(sortkey)) - if reverse or last: + if reverse: archives.reverse() - ...
[get_cache_dir->[write,get_home_dir],hostname_is_unique->[yes],Location->[to_key_filename->[get_keys_dir],parse->[replace_placeholders,get],_parse->[normpath_special]],get_security_dir->[get_home_dir],BaseFormatter->[format_item->[get_item_data]],json_print->[json_dump],open_item->[ChunkIteratorFileWrapper],decode_dict...
List all archives in this repository.
if last is bigger than len(archives), this will get negative and will malfunction.
@@ -478,7 +478,7 @@ export class AppStorage { * @param limit {Integer} How many txs return, starting from the earliest. Default: all of them. * @return {Array} */ - getTransactions(index, limit = Infinity) { + getTransactions(index, limit = Infinity, includeWalletsWithHideTransactionsEnabled = true) { ...
[No CFG could be retrieved]
Get all transactions in all wallets. If no index is provided - only for all wall Get a sum of all balances of all wallets.
lets invert this flag and we wont have to modify `screen/wallets/list.js`
@@ -2,6 +2,12 @@ When(/^I click "(.+)" button$/) do |button| click_on(button) end +When(/^I click "(.+)" button within "(.+)"$/) do |button, container| + within(find(container)) do + click_on button + end +end + Given(/^Show me the page$/) do save_and_open_page end
[visit,update_attribute,fetch,create,have_xpath,have_current_path,join,first,should,to,have_content,click_link,set,click,find_by_id,sleep,click_on,id,within,find_by_email,find_by_name,attach_file]
JS action for handling missing user - missing - user - missing - user - missing - user expensive operation needs some time.
I think we already have a similar method somewhere
@@ -208,10 +208,16 @@ public class MachoDumpReader extends AbstractCoreReader implements ILibraryDepen private final List<IMemoryRange> memoryRanges = new LinkedList<>(); private final List<IOSStackFrame> stackFrames = new LinkedList<>(); - public OSXThread(long tid, ThreadCommand.ThreadState thread) + public...
[MachoDumpReader->[processModuleFile->[getMemoryRangesWithOffset],readMachFile->[MachFile64],getThreads->[OSXThread],readCore->[getMemoryRangesWithOffset,isMACHO],isMACHO->[isMACHO],executablePathHint->[getMemoryRanges,getProperties],getSignalNumber->[getThreads],getReaderForFile->[getReaderForFile,MachoDumpReader,isMA...
Returns the thread id of this thread.
Why do we want to merge registers from multiple `ThreadState` objects?
@@ -163,7 +163,7 @@ class DataRange(Range): """) - renderers = Either(List(Instance(DataRenderer)), Auto, help=""" + renderers = Either(List(Instance(Model)), Auto, help=""" An explicit list of renderers to autorange against. If unset, defaults to all renderers on a plot. """)
[DataRange->[List,Instance,Either],FactorRange->[_check_duplicate_factors->[repr,Counter,join],__init__->[list,super,ValueError],Float,error,MinMaxBounds,FactorSeq,Enum,Nullable,Readonly],DataRange1d->[__init__->[super,get],MinMaxBounds,Enum,Nullable,Either,Bool],Range1d->[__init__->[super,ValueError,len],Nullable,Eith...
Create a base class for all data range types. Required argument.
Why is this necessary?
@@ -56,6 +56,10 @@ public class KafkaSupervisorReport extends SupervisorReport this.durationSeconds = durationSeconds; this.activeTasks = Lists.newArrayList(); this.publishingTasks = Lists.newArrayList(); + this.latestOffsets = latestOffsets; + this.minimumLag = minimumLag; + this.ag...
[KafkaSupervisorReport->[KafkaSupervisorReportPayload]]
Gets the data source for a .
Could put @Nulllable annotation for these fields
@@ -259,10 +259,6 @@ func NewApplication(config *orm.Config, ethClient eth.Client, advisoryLocker pos } ) - if config.Dev() { - logger.Warn("Chainlink is running in DEVELOPMENT mode. This is a security risk if enabled in production.") - } - if config.Dev() || config.FeatureFluxMonitorV2() { delegates[job.F...
[NewBox->[NewBox],ArchiveJob->[ArchiveJob],stop->[Stop],Start->[Start],AddServiceAgreement->[AddJob],AddJob->[AddJob]]
Creates a sub - service for the chainlink - v2 - v2 - v2 on - chain reporting.
This moved to local_client to avoid log spew in tests
@@ -138,4 +138,8 @@ public class ActiveMQProtonConnectionCallback implements AMQPConnectionCallback return new ProtonSessionIntegrationCallback(this, manager, connection, this.connection, closeExecutor); } + @Override + public void sendSASLSupported() { + connection.write(ActiveMQBuffers.wrappedBu...
[ActiveMQProtonConnectionCallback->[createSessionCallback->[ProtonSessionIntegrationCallback],getSASLMechnisms->[AnonymousServerSASL,getSecurityStore,ActiveMQPlainSASL,authenticate],getExeuctor->[getExecutor],onTransport->[operationComplete->[countDown],ChannelBufferWrapper,write,outputDone,ChannelFutureListener,await,...
Create a new session callback for the given connection.
Is there a link you could add here as a Doc? just for future reference?
@@ -107,3 +107,11 @@ func (m *MetricSet) loadStatus(db *sql.DB) (map[string]string, error) { return galeraStatus, nil } + +// Close closes the database connection and prevents future queries. +func (m *MetricSet) Close() error { + if m.db == nil { + return errors.New("invalid database handle") + } + return errors...
[Fetch->[HostData,loadStatus,Module,Wrap,Config,NewDB],loadStatus->[Scan,Close,Next,Query],MakeDebug,MustAddMetricSet,WithHostParser]
loadStatus loads the global status from the database.
It should not be an error to have a nil `db`. This means that it never fetched or it never successfully initialized the DB client. In any case there's nothing for `Close()` to do, but it's not an error.
@@ -1465,6 +1465,8 @@ public class ModifyKeyboardShortcutsWidget extends ModalDialogBase private Pair<Integer, Integer> lastSelectedIndices_; private boolean swallowNextKeyUpEvent_; + private static final String RESET_BUTTON_ID = "rstudio_kybrd_shrtcts_rst"; + private ThemedButton resetButton_; privat...
[ModifyKeyboardShortcutsWidget->[createMainWidget->[onPreviewNativeEvent->[test->[getElement,equals]],resetState],showToolTip->[getElement,bindNativeClickToSelectRow,describeCommand],shortcutInput->[shortcutInput],embedIcon->[getElement],sort->[compare->[getName,getKeySequence],sort],getAppCommandName->[getId],collectS...
Provides a key that can be used to identify a keyboard. Input icon and showChoice.
For consistency, should define the constant in `ElementIds.java` and use the appropriate `assignElementId()` overload to apply it. Someday we should decentralize this so it's not all in this single source file but until we do let's follow the same pattern.
@@ -92,11 +92,11 @@ public class PersistentTokenRememberMeServices extends private static final int TOKEN_VALIDITY_SECONDS = 60 * 60 * 24 * TOKEN_VALIDITY_DAYS; - private static final int UPGRADED_TOKEN_VALIDITY_SECONDS = 5; + private static final long UPGRADED_TOKEN_VALIDITY_MILLIS = 5_000l; + + ...
[No CFG could be retrieved]
Provides a base class for all the persistent token based remember me services. Get the user log in if the user is upgraded.
This number isn't big enough to add the underscore, it will just confuse novice users. I would rather just use `5000L`
@@ -449,6 +449,7 @@ bool RosSupervisor::virtualRealityHeadsetIsUsedCallback(webots_ros::get_bool::Re return true; } +// cppcheck-suppress constParameter bool RosSupervisor::nodeGetIdCallback(webots_ros::node_get_id::Request &req, webots_ros::node_get_id::Response &res) { assert(this); if (!req.node)
[worldReloadCallback->[assert,worldReload],fieldGetBoolCallback->[assert,getType,getMFBool,getSFBool],nodeAddForceWithOffsetCallback->[assert,addForceWithOffset],fieldInsertBoolCallback->[assert,getType,insertMFBool],nodeGetContactPointCallback->[assert,getContactPoint],virtualRealityHeadsetIsUsedCallback->[assert,virt...
Virtual reality headset is used callback.
It is strange that the warning appears only to those few functions and not all the others. Do you have an explanation for this?
@@ -101,6 +101,14 @@ class RoleMakerBase(object): """ raise NotImplementedError("Please implement this method in child class") + def node_num(self): + """ + Get the training node number + Returns: + int: node num + """ + raise NotImplementedError("Ple...
[PaddleCloudRoleMaker->[_all_reduce->[_barrier],role_id->[is_worker,server_index,worker_index,is_server],_init_gloo_env->[init_gloo_instance],_all_gather->[_barrier],generate_role->[_ps_env,_collective_env,_init_gloo_env]],UserDefinedRoleMaker->[generate_role->[_init_gloo_env,_user_defined_collective_env,_user_defined_...
Get current server index.
what is the difference between `node_num` and `worker_num`
@@ -65,6 +65,14 @@ class SearchReplacer { if ( is_string( $data ) && ( $unserialized = @unserialize( $data ) ) !== false ) { $data = $this->_run( $unserialized, true, $recursion_level + 1 ); } + + elseif ( is_string( $data ) && ( $unserialized = $this->base64_check_and_decode( $data ) ) !== false ) { ...
[SearchReplacer->[_run->[_run],run->[_run]]]
This method recursively processes the data and stores it in the object Serialize the object.
Where is this function defined?
@@ -101,8 +101,13 @@ int RAND_load_file(const char *file, long bytes) else n = RAND_FILE_SIZE; i = fread(buf, 1, n, in); +#ifdef EINTR + if (i <= 0 && errno != EINTR) + break; +#else if (i <= 0) break; +#endif RAND_add(buf, i, (double)i); ...
[RAND_load_file->[OPENSSL_cleanse,openssl_fopen,fclose,S_ISREG,RANDerr,RAND_add,fread,stat,ERR_add_error_data],RAND_write_file->[OPENSSL_cleanse,fwrite,openssl_fopen,fclose,S_ISREG,chmod,RANDerr,RAND_bytes,fdopen,open,stat,ERR_add_error_data],char->[strcat,strlen,getenv,GetEnvironmentVariableW,_alloca,strcpy,OPENSSL_is...
Rand_load_file - Load file with bytes.
as far as I remember the discussion on the previous PR, EINTR sets the FILE into an error state, that must be cleared explicitly, all in all that is possible but....
@@ -80,6 +80,8 @@ print_usage(int rank) print_message("daos_test -v|--rebuild_simple\n"); print_message("daos_test -b|--drain_simple\n"); print_message("daos_test -N|--nvme_recovery\n"); + print_message("daos_test -I|--DFS unit\n"); + print_message("daos_test -F|--DFS functional\n"); print_message...
[No CFG could be retrieved]
Prints a message for all of the command line options. runs all tests specified in the command line.
(style) code indent should use tabs where possible
@@ -962,10 +962,9 @@ func TestQueryLimitsWithBlocksStorageRunningInMicroServices(t *testing.T) { res, err = c.Push(series4) require.NoError(t, err) require.Equal(t, 200, res.StatusCode) - _, err = c.QueryRange("{__name__=~\"series_.+\"}", series1Timestamp, series4Timestamp.Add(1*time.Hour), blockRangePeriod) ...
[NewDynamoDB,NewCompositeCortexService,LabelNames,NewSingleBinary,WaitSumMetrics,NewMemcached,Now,Close,NewS3ClientForMinio,NewTableManager,LabelValues,Instances,DeleteBlocks,Add,Done,Greater,NewScenario,FormatBool,NetworkHTTPEndpoint,Error,NetworkEndpoint,NewDistributor,NewCompactor,HTTPEndpoint,NewClient,NewIngester,...
TestHashCollisionHandling tests the series for the network. CortexSchemaConfig is the main entry point for cortex schema. It is the main.
For some reason after this change, err.Error() is returning encoded strings rather than plain strings, so the assert contains no longer works. Instead of checking the response string, I checked for 500 like we do in some other tests. Is there a better way to do this?
@@ -99,6 +99,9 @@ class CI_Cache_redis extends CI_Driver */ public function delete($key) { + // This is for not leaving garbage keys within the Redis auxilary set. + $this->_redis->sRemove('_ci_redis_serialized', $key); + return ($this->_redis->delete($key) === 1); }
[CI_Cache_redis->[delete->[delete],get->[get],get_metadata->[get]]]
Delete an item from the cache.
What if the delete fails?
@@ -180,6 +180,18 @@ public class ParserTest { assertEquals("Hello world <strong>", engine.parse("Hello {name} {[<strong>]}").data("name", "world").render()); } + @Test + public void testRemoveStandaloneLines() { + Engine engine = Engine.builder().addDefaults().removeStandaloneLines(true).b...
[ParserTest->[find->[get],testUnterminatedTag->[assertParserError],testEscapingDelimiters->[build,assertEquals,render],testSectionEndValidation->[assertParserError],testWithTemplateLocator->[assertNotNull,getMessage,build,getTemplate,getOrigin,assertEquals,fail],testTypeInfos->[build,getExpressions,assertExpr,parse],te...
Test if there is a data in the data section of a template.
So, this appears to validate that the description: > A *standalone line* is a line that contains only section tags (e.g. `{#each}` and `{/each}`), parameter declarations (e.g. `{@org.acme.Foo foo}`) and whitespace characters. has a confusing `and`. I initially thought this applied to empty lines as well, but this test ...
@@ -12,9 +12,9 @@ class Apex(CMakePackage): homepage = "http://github.com/khuck/xpress-apex" url = "http://github.com/khuck/xpress-apex/archive/v0.1.tar.gz" - version('0.1', sha256='bb0be37f8f8133fe492998515bcf66a4df452c28a995d317228fbed9b18e6a92') + version('0.1', sha256='efd10f38a61ebdb9f8ade...
[Apex->[depends_on,version]]
Creates a CMakePackage object for the given object.
It looks like there are dozens of newer releases. Can you contact the developers and find out why the checksum changed?
@@ -90,4 +90,8 @@ public abstract class AbstractSubscribableChannel extends AbstractMessageChannel protected abstract MessageDispatcher getDispatcher(); + protected boolean canShortCircuitDispatcher() { + return false; + } + }
[AbstractSubscribableChannel->[doSend->[getMessage,dispatch,MessageDeliveryException,getFullChannelName],unsubscribe->[adjustCounterIfNecessary,removeHandler,getRequiredDispatcher],adjustCounterIfNecessary->[getHandlerCount,addAndGet,getFullChannelName,info,isInfoEnabled],subscribe->[adjustCounterIfNecessary,addHandler...
Get the message dispatcher.
Since this is considered on a per-sending basis, what is the reason for having this set to true only for a DirectChannel?
@@ -1114,12 +1114,9 @@ class ICA(object): ica = FastICA(**kwargs) ica.fit(data[:, sel]) - # For ICA the only thing to store is the unmixing matrix - if not hasattr(ica, 'sources_'): - self.unmixing_matrix_ = ica.unmixing_matrix_ - else: - self.unmixing_matr...
[run_ica->[decompose_raw,ICA,_detect_artifacts],ICA->[pick_sources_epochs->[_get_sources_epochs],plot_sources_epochs->[get_sources_epochs],sources_as_epochs->[get_sources_epochs,_export_info],sources_as_raw->[get_sources_raw],pick_sources_raw->[_get_sources_raw],plot_sources_raw->[get_sources_raw],find_sources_epochs->...
Aux function to decompose data from sklearn. A function that picks a sequence of components from the source list and stores it in self D = pca_restored - pca_reappend - pca_pre.
@agramfort This line causes a failing test. If I remove it the plot shown above looks fine again.
@@ -81,6 +81,11 @@ namespace CoreclrTestLib } } + if (platform != "android") + { + cmdStr += " --target ios-simulator-64"; + } + using (Process process = new Process()) ...
[MobileAppHandler->[InstallMobileApp->[HandleMobileApp],UninstallMobileApp->[HandleMobileApp],HandleMobileApp->[Now,ConvertCmd2Arg,CopyToAsync,WaitAll,Token,WaitForExit,Flush,Start,IsWindows,Combine,UseShellExecute,Create,ExitCode,Kill,IsNullOrEmpty,RedirectStandardOutput,CreateDirectory,GetEnvironmentVariable,ToString...
Handle a mobile app. Checks if a specific node - system action is required and if so runs the command. xharness timeout command.
why not add this into the `else` directly above?
@@ -90,6 +90,11 @@ class ModelPartController: def UpdateMeshAccordingInputVariable(self, InputVariable): self.mesh_controller.UpdateMeshAccordingInputVariable(InputVariable) + if self.model_settings["damping"]["recalculate_damping"].GetBool(): + self.damping_utility = KSO.DampingUtilit...
[ModelPartController->[__ImportOptimizationModelPart->[SetMinimalBufferSize],Initialize->[Initialize],UpdateMeshAccordingInputVariable->[UpdateMeshAccordingInputVariable]]]
Update the mesh according to the input variable.
In case you recalculate the weights, you do not initialize a damping_utility in the initialize function. Instead, you initialize it here AFTER the mesh is updated. That is very confusing and only makes sense because in the first time "UpdateMeshAccordingInputVariable" is called in the opt algorithms, the shape update i...
@@ -227,7 +227,7 @@ public class PhysicalPlanBuilderTest { functionRegistry, overrideProperties, metaStore, - new QueryIdGenerator(), + new DefaultQueryIdGenerator(), testKafkaStreamsBuilder, queryCloseCallback );
[PhysicalPlanBuilderTest->[shouldAddMetricsInterceptorsToExistingList->[buildPhysicalPlanBuilder,getCalls,buildPhysicalPlan],getNodeByName->[getNodeByName],execute->[execute],shouldBuildPersistentQueryWithCorrectSchema->[buildPhysicalPlan],shouldMakePersistentQuery->[buildPhysicalPlan],shouldAddMetricsInterceptors->[ge...
Build a PhysicalPlanBuilder with a sequence of properties.
ideally pass in a mock, decoupling this test from any specific implementation.
@@ -131,7 +131,7 @@ module AlaveteliTextMasker # Replace censor items censor_rules = options[:censor_rules] || [] text = censor_rules.reduce(text) { |text, rule| rule.apply_to_binary(text) } - raise "internal error in apply_binary_masks" if text.size != orig_size + raise "internal error in apply_bi...
[apply_text_masks->[reduce,inject,gsub,apply_to_text],apply_binary_masks->[email_find_regexp,gsub!,size,force_encoding,gsub,scan,reduce,raise,apply_to_binary,map!,each,dup],uncompress_pdf->[run],apply_pdf_masks->[apply_binary_masks,uncompress_pdf,warn,blank?,compress_pdf],apply_masks->[apply_pdf_masks,apply_text_masks,...
Find UCS - 2 email addresses and replace UCS - 2 email with the UCS.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
@@ -43,7 +43,9 @@ import androidx.test.ext.junit.runners.AndroidJUnit4; import static com.ichi2.libanki.Utils.nonEmptyFields; import static org.junit.Assert.assertEquals; - +/* @RequiresApi(api = Build.VERSION_CODES.O) + * java.nio.file.Paths#get + */ @RunWith(AndroidJUnit4.class) public class UtilsTest {
[UtilsTest->[nonEmptyFieldsTest->[nonEmptyFields,assertEquals,put,add],test_stripHTML_will_remove_tags->[replace,asList,assertEquals,stripHTML],testInvalidPaths->[File,assertFalse,fail,isInside],test_stripHTML_will_remove_comments->[replace,asList,assertEquals,stripHTML],testSplit->[assertArrayEquals,splitFields],testZ...
Test zip with path traversal.
We can fix this one
@@ -1048,6 +1048,15 @@ class ICA(ContainsMixin): if threshold is None: threshold = 0.25 if isinstance(inst, BaseRaw): + reject_by_annotation = 'omit' if reject_by_annotation else None + start, stop = _check_start_stop(inst, start, stop) + + ...
[_find_sources->[get_score_funcs],run_ica->[fit,ICA,_detect_artifacts],get_score_funcs->[_make_xy_sfunc],corrmap->[get_components,_find_max_corrs,_plot_corrmap],_sort_components->[copy],ICA->[_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten],_transform_raw->[_pre_whiten,_transform],_fit_e...
This routine is used to detect ECG related components. Returns the indices of the non - zero related components in the network. scores a single object and returns the scores of the missing components.
This is a bit dangerous because things like `raw.times` will not be updated properly. A better fix (and one that avoids the preloading that this forces) is probably to make `create_ecg_epochs` capable of handling Annotations properly.
@@ -1100,7 +1100,11 @@ final class DefaultChannelHandlerContext implements ChannelHandlerContext, Resou // Ensure we never update when the handlerState is REMOVE_COMPLETE already. // oldState is usually ADD_PENDING but can also be REMOVE_COMPLETE when an EventExecutor is used that is not // e...
[DefaultChannelHandlerContext->[channel->[channel],connect->[executor,connect],invokeChannelReadComplete->[incrementInboundOperations],invokeDisconnect->[incrementOutboundOperations],close->[executor,close],findAndInvokeRegister->[isProcessOutboundDirectly,executeOutboundReentrance],invokeFlush0->[decrementOutboundOper...
This method is called when the state of the event is ADD_PENDING or REMOVE_COMPLETE.
The existing logic here looks incorrect, shouldn't it be a conditional update, i.e. not set it back to `ADD_COMPLETE` if it's already `REMOVE_COMPLETE`? The new logic looks better though!
@@ -95,7 +95,8 @@ class UserHistory < ActiveRecord::Base embeddable_host_update: 74, embeddable_host_destroy: 75, web_hook_deactivate: 76, - change_theme_setting: 77 + change_theme_setting: 77, + disable_theme_component: 78 ) end
[UserHistory->[previous_value_is_json?->[new_value_is_json?],for->[actions],staff_action_records->[actions],exists_for_user?->[actions]]]
Enumerate all actions of the user. Get all staff actions that are defined in the system. finds all the tags in the system that are not defined in the configuration.
hmmm so we have a record for "disable" we should also have one for "enable"
@@ -43,17 +43,6 @@ def use_master(): multidb.pinning._locals.pinned = old -@contextlib.contextmanager -def skip_cache(): - """Within this context, no queries come from cache.""" - old = getattr(_locals, 'skip_cache', not settings.CACHE_MACHINE_ENABLED) - _locals.skip_cache = True - try: - ...
[SearchMixin->[index->[_get_index],search->[_get_index],unindex->[_get_index]],RawQuerySet->[__len__->[__iter__]],SaveUpdateMixin->[update->[get_unfiltered_manager]],OnChangeMixin->[_send_changes->[_NoChangeInstance,update],save->[_send_changes],update->[_send_changes]],_NoChangeInstance->[save->[save],update->[update]...
Context manager to skip cache.
Maybe this should be called `BaseQuerySet` instead. Would be less confusing than having 2 `TransformQuerySet`.
@@ -42,7 +42,8 @@ dfuse_cb_setxattr(fuse_req_t req, struct dfuse_inode_entry *inode, if (rc) D_GOTO(err, rc); - if (dattr.da_type != DAOS_PROP_CO_LAYOUT_POSIX) + if (dattr.da_type != DAOS_PROP_CO_LAYOUT_POSIX && + dattr.da_type != DAOS_PROP_CO_LAYOUT_HDF5) D_GOTO(err, rc = ENOTSUP); }
[dfuse_cb_setxattr->[D_GOTO,DFUSE_REPLY_ZERO,DFUSE_REPLY_ERR_RAW,dfs_setxattr,DFUSE_TRA_DEBUG,duns_parse_attr,strcmp]]
dfuse_cb_setxattr - DUNS extended attribute setter.
It looks like duns_parse_attr() already does this check anyway so we could probably just remove this from here.
@@ -101,6 +101,7 @@ public class JettyServerModule extends JerseyServletModule private static final Logger log = new Logger(JettyServerModule.class); private static final AtomicInteger ACTIVE_CONNECTIONS = new AtomicInteger(); + private static final AtomicReference<ThreadPool> JETTY_SERVER_THREAD_POOL = new At...
[JettyServerModule->[makeAndInitializeServer->[start->[start],stop->[stop]],IdentityCheckOverrideSslContextFactory->[getTrustManagers->[getTrustManagers]]]]
Configure servlets.
Why is `AtomicReference` used ? Thread pool of jetty is initialized during start up and won't be changed. I think we could declare this variable as `QueuedThreadPool` directly.
@@ -216,15 +216,6 @@ public class RegistrationInfoImpl implements RegistrationInfo { return properties; } - public ExtensionPointImpl getExtensionPoint(String name) { - for (ExtensionPointImpl xp : extensionPoints) { - if (xp.name.equals(name)) { - return xp; - ...
[RegistrationInfoImpl->[checkExtensions->[getName],deactivate->[getComponent,getExtensionPoint,deactivate],equals->[getName,equals],unregister->[destroy],stop->[stop],reload->[reload],createComponentInstance->[toString],start->[start,getName],hashCode->[hashCode],activate->[getName,getExtensionPoint,createComponentInst...
Returns the properties and state of the extension point with the specified name.
then you should explain why it is nevertheless done
@@ -23,6 +23,7 @@ class H2ORuleFitEstimator(H2OEstimator): algo = "rulefit" supervised_learning = True + @deprecated_params({'Lambda': 'lambda_'}) def __init__(self, model_id=None, # type: Optional[Union[None, str, H2OEstimator]] training_frame=None, # type: Opt...
[H2ORuleFitEstimator->[remove_duplicates->[assert_is_type,get],algorithm->[Enum,assert_is_type,get],ignored_columns->[assert_is_type,get],training_frame->[_validate,get],model_type->[Enum,assert_is_type,get],rule_generation_ntrees->[assert_is_type,get],auc_type->[Enum,assert_is_type,get],response_column->[assert_is_typ...
Initialize a new H2OModel from a sequence of n - grams. Parameters for training and prediction. This class is the base class for the H2O rule fit estimate.
Why do you use underscore at the end of the parameter?
@@ -18,7 +18,7 @@ extern unsigned int OPENSSL_ia32cap_P[4]; -# if defined(OPENSSL_CPUID_OBJ) && !defined(OPENSSL_NO_ASM) && !defined(I386_ONLY) +# if defined(OPENSSL_CPUID_OBJ) /* * Purpose of these minimalistic and character-type-agnostic subroutines
[No CFG could be retrieved]
Creates a type - specific object. WCHAR value - WCHAR value of length 48.
Why are these removed - maybe add line in the commit message?
@@ -292,7 +292,7 @@ func CommandFor(basename string) *cobra.Command { case "kubectl": cmd = NewCmdKubectl(basename, out) default: - cmd = NewCommandCLI(basename, basename, in, out, errout) + cmd = NewCommandCLI("oc", "oc", in, out, errout) } if cmd.UsageFunc() == nil {
[NewCmdRun,NewCmdVersion,NewCmdAnnotate,NewCmdLinkSecret,NewCmdPolicy,NewCmdProxy,NewCmdCompletion,New,Infof,Lookup,NewCmdProcess,ActsAsRootCommand,NewCmdSecrets,NewCmdNewApplication,NewCmdBuildLogs,NewCmdVolume,NewCommandAdmin,NewCmdEdit,NewCmdSet,NewCmdServiceAccounts,NewCmdIdle,NewCmdDelete,NewCmdWhoAmI,NewCmdPatch,...
NewInviteCommand returns a new command object for the given command name.
I think this is still not the right approach. This path is executed by all commands that are build from our repo, this includes `oc`, `openshift`, `oadm`. Make sure to check them all.