patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -147,6 +147,8 @@ type Enum struct {
Comment string
// Name for the enum.
Name string
+ // DeprecationMessage indicates whether or not the value is deprecated.
+ DeprecationMessage string
}
func (t *EnumType) String() string {
| [bindProperties->[bindType],bindResourceType->[bindResourceTypeDetails],bindEnumTypeDetails->[bindType],bindObjectType->[bindObjectTypeDetails],bindType->[String,bindType,bindPrimitiveType],bindEnumType->[bindEnumTypeDetails],bindObjectTypeDetails->[bindProperties],bindEnumValues->[String],String->[String],bindProperti... | String returns the string representation of the enum type. | Since this isn't a boolean value, it might be worth clarifying that a non-empty string indicates that the enum is deprecated. |
@@ -5,7 +5,3 @@
# Code generated by Microsoft (R) AutoRest Code Generator.
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------
-
-from ._digitaltwins_client_async import DigitalTwinsClient
-
-__all__ = ['Digi... | [No CFG could be retrieved] | This source code is for Microsoft Digital Twins API. | This shouldn't have been removed - the client still needs to be exported in the `aio` namespace. |
@@ -932,10 +932,14 @@ def read_ch_connectivity(fname, picks=None):
Returns
-------
- ch_connectivity : scipy.sparse matrix
+ ch_connectivity : scipy.sparse matrix, shape (n_channels, n_channels)
The connectivity matrix.
ch_names : list
The list of channel names present in connec... | [ContainsMixin->[__contains__->[_contains_ch_type]],_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels->[rename_channels],plot_sensors->[plot_senso... | Parse FieldTrip neighbors. mat file and return the connectivity matrix. Returns connectivity and ch_names for all picks. | Somewhere -- probably in a Notes section here -- we should say how these two functions are related. Perhaps we should say that `find_ch_connectivity` is generally preferred as it's more general? |
@@ -478,6 +478,18 @@ class AttributeQuerySet(models.QuerySet):
| Q(attributevariant__product_type_id=product_type_pk)
)
+ @staticmethod
+ def user_has_access_to_all(user):
+ return user.is_active and user.has_perm("product.manage_products")
+
+ def get_public_attributes(self):
+ ... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],is_digital->[is_shipping_required],get_first_image->[get_first_image]],Product->[is_in_stock->[is_in_stock]]] | Get all attributes assigned to a product type. | Are you going to use `get_public_attributes`, `user_has_access_to_all` somewhere else? If not I think that you can leave only `get_visible_to_user` method. And another important question is: Are you sure that we want to show different attributes for admin users and for the rest of customers? It could lead to a strange ... |
@@ -982,6 +982,18 @@ public final class PlatformDependent {
return vmName.startsWith("ibm j9") || vmName.startsWith("eclipse openj9");
}
+ /**
+ * Returns {@code true} if the running JVM is <a href="https://www.ikvm.net">IKVM.NET</a>, {@code false} otherwise.
+ */
+ public static boolean i... | [PlatformDependent->[getLong->[getLong],newConcurrentDeque->[javaVersion],unsafeUnavailabilityCause0->[getUnsafeUnavailabilityCause,hasUnsafe,isAndroid],reallocateMemory->[reallocateMemory],equals->[hasUnsafe,equals],Mpsc->[hasUnsafe],getInt->[getInt],getContextClassLoader->[getContextClassLoader],getByte->[getByte],fr... | J9Jvm0 returns true if the JVM is running on J9. This method is called to determine the maximum direct memory size. | Specify a locale to toUpperCase. |
@@ -2260,7 +2260,6 @@ bool DynamicData::skip_all()
break;
}
}
- release_chains();
return good;
} else { // Union
const DynamicType_rch disc_type = get_base_type(descriptor_.discriminator_type);
| [No CFG could be retrieved] | Checks if the given type is a member of the given type. Find the member in the list of dynamic type members. | Why are these calls removed? They must be kept to release the intermediate message block chains it created. Otherwise, there can be memory leak. |
@@ -0,0 +1,12 @@
+class CreateThemeSettings < ActiveRecord::Migration[5.1]
+ def change
+ create_table :theme_settings do |t|
+ t.string :name, limit: 255, null: false
+ t.integer :data_type, null: false
+ t.text :value
+ t.references :theme, foreign_key: true, null: false
+
+ t.timestamps ... | [No CFG could be retrieved] | No Summary Found. | oh ... we usually do not include these in our tables |
@@ -266,10 +266,11 @@ def create_agent_from_model_file(model_file, opt_overides=None):
The agent
"""
opt = {}
- opt['model_file'] = model_file
- if opt_overides is None:
- opt_overides = {}
- opt['override'] = opt_overides
+ add_datapath_and_model_args(opt)
+ opt['model_file'] =... | [create_agent->[compare_init_model_opts,create_agent_from_opt_file],create_agent_from_opt_file->[upgrade_opt,compare_init_model_opts],create_agents_from_shared->[create_agent_from_shared]] | Create a new agent from a model file. Add the n - node weights to the new_opt dictionary. | so this is really the fundamental change in this pr right? |
@@ -419,6 +419,8 @@ class VarianceScaling(Initializer):
With `distribution="uniform"`, samples are drawn from a uniform distribution
within [-limit, limit], with `limit = sqrt(3 * scale / n)`.
+ `distribution="normal"` is a deprecated alias for "truncated_normal".
+
Args:
scale: Scaling factor (positiv... | [ConvolutionOrthogonal3D->[_block_orth->[matmul->[matmul],matmul,cast],__call__->[_orthogonal_kernel],_matrix_conv->[matmul],_orthogonal_kernel->[_block_orth,_matrix_conv,matmul,_dict_to_tensor,_symmetric_projection,_orthogonal_matrix]],ConvolutionOrthogonal1D->[__call__->[_orthogonal_kernel],_orthogonal_kernel->[_bloc... | Creates a variance scaling initializer for the . Constructor for object. | If you want, you can use @deprecated_arg_values to formally encode this (with a warning). But I think what you did here is fine. |
@@ -155,13 +155,14 @@ def plot_topo(evoked, layout, layout_scale=0.945, title=None):
Parameters
----------
- evoked : Evoked
+ evoked : list of Evoked | Evoked
The evoked response to plot.
layout : instance of Layout
System specific sensor positions
layout_scale: float
... | [plot_topo_power->[_plot_topo],plot_topo_tfr->[_plot_topo],plot_topo_image_epochs->[_plot_topo],plot_topo_phase_lock->[_plot_topo],plot_source_estimate->[SurfaceViewer],_plot_topo->[_clean_names],plot_topo->[_plot_topo]] | Plots a 2D topography of evoked responses at a specific sensor location. | add a line below with the short description. The colors used to plot each evoked dataset. |
@@ -240,6 +240,16 @@ class ApplicationController < ActionController::Base # rubocop:disable Metrics/C
render template, **opts, layout: 'base'
end
+ def user_needs_sign_up_completed_page?
+ issuer = sp_session[:issuer]
+ return false unless issuer
+ !user_has_identity_for_issuer?(issuer)
+ end
+
+ ... | [ApplicationController->[after_multiple_2fa_sign_up->[after_sign_in_path_for],two_factor_enabled?->[two_factor_enabled?],confirm_two_factor_authenticated->[user_fully_authenticated?]]] | Renders a full width block of a . | This change means that IAL2 users won't have to provide explicit consent to share new attributes with an SP if an SP requests an attribute that it has not requested before. |
@@ -229,6 +229,9 @@ public class ForkingTaskRunner implements TaskRunner, TaskLogStreamer
final File taskDir = taskConfig.getTaskDir(task.getId());
final File attemptDir = new File(taskDir, attemptUUID);
+ task.getContext().put(INDEX_TASK_DIR, t... | [ForkingTaskRunner->[ForkingTaskRunnerWorkItem->[getDataSource->[getDataSource]]],QuotableWhiteSpaceSplitter->[iterator->[iterator]]] | Runs a task in a separate thread. Add a task to the task info. Add the necessary command line parameters to the task. This method is called when a task is created. Checks if a task has exited and if so returns it. | I don't think you need these context params, you can get the `TaskConfig` by calling `toolbox.getConfig()` in `HadoopIndexTask.run()`. |
@@ -134,6 +134,18 @@ class Gcc(AutotoolsPackage, GNUMirrorPackage):
destination='newlibsource',
when='+nvptx',
fetch_options=timeout)
+ resource(name='newlib-amdgcn',
+ url='ftp://sourceware.org/pub/newlib/newlib-3.3.0.tar.gz',
+ sha256='58dd9e3eaedf5... | [Gcc->[url_for_version->[replace,Version,super],write_rpath_specs->[join_path,gcc,write,set_install_permissions,startswith,format,warn,open],validate_detected_spec->[format,items,satisfies],filter_detected_exes->[any,basename,append,str,islink,platform],determine_version->[group,search,debug,get_compiler_version_output... | Creates a new object with the given name and URL. Creates a resource object for a single n - tuple of objects. | What will happen if both nvptx and amdgcn are enabled? They seem to extract into the same destination. |
@@ -94,4 +94,13 @@ public class AlarmCallbackConfigurationServiceMJImpl implements AlarmCallbackCon
throw new IllegalArgumentException("Supplied output must be of implementation type AlarmCallbackConfigurationAVImpl, not " + callback.getClass());
}
}
+
+ // Remove duplicated ID stored in `... | [AlarmCallbackConfigurationServiceMJImpl->[count->[count],create->[create],getForStream->[getForStreamId]]] | Returns implementation of callback or throws exception if not found. | I'd rather move this method into `AlarmCallbacksMigrationPeriodical` than "pollute" the public interface of `AlarmCallbackConfigurationServiceMJImpl` and having to cast the injected `AlarmCallbackConfigurationService` in that periodical. |
@@ -314,3 +314,13 @@ func isNetRetryable(err error) bool {
netErr, ok := err.(net.Error)
return ok && netErr.Temporary()
}
+
+// TestIsNotExist is a defensive method for checking to make sure IsNotExist is
+// satisfying its semantics.
+func TestIsNotExist(c Client) error {
+ _, err := c.Reader(uuid.NewWithoutDash... | [Close->[Close,IsIgnorable],Write->[Write,Error,Infof,String,RetryNotify],Read->[Error,Infof,String,RetryNotify,Read],isRetryable,ReadFile,Sprintf,Parse,Errorf,Temporary,NewExponentialBackOff] | Returns true if the error is a temporary net. Error and false otherwise. | but are you defensive enough to defend against UUID collision |
@@ -328,6 +328,11 @@ def test_fasterrcnn_double():
assert "scores" in out[0]
assert "labels" in out[0]
+ # check input backpropagation
+ model_input[0].requires_grad = True
+ out = model(model_input)[0]
+ assert len(out) == 3
+
def test_googlenet_eval():
# replacement for models.googlene... | [test_detection_model->[check_out->[_get_expected_file,_assert_expected],_check_jit_scriptable,check_out],test_googlenet_eval->[_check_jit_scriptable],test_fasterrcnn_switch_devices->[checkOut],test_segmentation_model->[check_out->[_get_expected_file,_assert_expected],_check_jit_scriptable,check_out,_check_fx_compatibl... | Test for the double - type cross - validation of the nanoseconds. | Can we use `_check_input_backprop` here as well? |
@@ -1643,7 +1643,8 @@ GenericAgentConfig *GenericAgentConfigNewDefault(AgentType agent_type)
// TODO: system state, perhaps pull out as param
config->tty_interactive = isatty(0) && isatty(1);
- config->color = false;
+ const char *color_env = getenv("CFENGINE_COLOR");
+ config->color = (color_env &... | [No CFG could be retrieved] | Create a new agent - specific configuration object. Method to set the fields of the GenericAgentConfig object. | Should we also support the usual panoply of "true", "yes", "on" values ? (If so, the "is this environment variable set to a true value" test should obviously go in a function, so that it can be shared by all environment variables tested this way.) Not worth it if all other environment variables only care about "1 or no... |
@@ -311,13 +311,14 @@ class Evoked(ProjMixin, ContainsMixin, UpdateChannelsMixin,
clim=None, xlim='tight', proj=False, units=None,
scalings=None, titles=None, axes=None, cmap='RdBu_r',
colorbar=True, mask=None, mask_style=None,
- mask_cmap='G... | [_read_evoked->[_get_entries,_get_aspect],grand_average->[copy],combine_evoked->[_check_evokeds_ch_names_times],EvokedArray->[__init__->[copy]],Evoked->[__neg__->[copy],detrend->[detrend]],read_evokeds->[Evoked,_get_evoked_node]] | Plot a single image of the object. | I see that we call it everywhere show_names and not show_ch_names `git grep show_names` |
@@ -205,7 +205,7 @@ def allocate_class(builder: IRBuilder, cdef: ClassDef) -> Value:
MAGIC_TYPED_DICT_CLASSES = (
'typing._TypedDict',
'typing_extensions._TypedDict',
-) # type: Final[Tuple[str, ...]]
+) # type: Final
def populate_non_ext_bases(builder: IRBuilder, cdef: ClassDef) -> Value:
| [generate_attr_defaults->[leave_method,attr_type,reversed,coerce,accept,is_class_var,is_object_rprimitive,is_optional_type,is_dataclass,is_constant,warning,append,enter_method,isinstance,SetAttr,Return,true,self,is_none_rprimitive,add],create_ne_from_eq->[has_method,gen_glue_ne_method],load_non_ext_class->[finish_non_e... | Create a base class tuple of a non - extension class. | This changes the semantics, so we want to preserve the type. We want this to be an arbitrary-length tuple instead of a fixed-length tuple. |
@@ -19,7 +19,7 @@ namespace System.Security.AccessControl
}
internal FileSystemSecurity(bool isContainer, string name, AccessControlSections includeSections, bool isDirectory)
- : base(isContainer, s_ResourceType, name, includeSections, _HandleErrorCode, isDirectory)
+ : base(i... | [FileSystemSecurity->[RemoveAccessRuleAll->[RemoveAccessRuleAll],Persist->[Persist],AddAccessRule->[AddAccessRule],RemoveAccessRuleSpecific->[RemoveAccessRuleSpecific],RemoveAuditRuleAll->[RemoveAuditRuleAll],SetAuditRule->[SetAuditRule],RemoveAuditRule->[RemoveAuditRule],AddAuditRule->[AddAuditRule],RemoveAccessRule->... | Creates an abstract class that wraps a NativeObjectSecurity object. missing exception - if not found - if not found - if not found - if not found. | `\\?\` is added if the path is too long. `GetFullPath` will throw if it's an invalid path. |
@@ -36,8 +36,9 @@ import org.nuxeo.runtime.transaction.TransactionHelper;
// TODO: "org.nuxeo.ecm.core.management" is missing but creates test failures
@Deploy({"org.nuxeo.runtime.jtajca", "org.nuxeo.ecm.core.io", "org.nuxeo.ecm.automation.server",
"org.nuxeo.ecm.automation.io", "org.nuxeo.ecm.webengine.core... | [RepositoryElasticSearchFeature->[afterMethodRun->[afterMethodRun],initialize->[initialize]]] | This method is called after the method is run. It is called after the method is run. | Thanks this fix the pb for elasticsearch feature, still the output of the t&p contains dozen of core management component missing in other modules. I don't really see the point of deploying probes by default it is just one more deps for tests. |
@@ -94,7 +94,7 @@ namespace System.Xml
// Writes the start of an attribute.
- protected internal virtual Task WriteStartAttributeAsync(string prefix, string localName, string ns)
+ protected internal virtual Task WriteStartAttributeAsync(string? prefix, string localName, string? ns)
... | [XmlWriter->[Task->[Root,Value,WriteAttributeStringAsyncHelper,VerifyNMTOKEN,ArgumentException,Xml_UndefNamespace,XmlDeclaration,WriteNodeAsync_CallSyncReader,MoveToFirstChild,IsSuccess,EndElement,Clone,Attribute,Settings,CallTaskFuncWhenFinishAsync,CanReadValueChunk,ProcessingInstruction,Async,IsDefault,Format,EncodeA... | implement the interface. | Most APIs below accepting `string text` allows null text |
@@ -55,7 +55,11 @@ def get_all(path, follow_symlinks=True):
return {}
-libc_name = find_library('c')
+libc_name = None
+try:
+ libc_name = find_library('c')
+except:
+ pass # workaround for systems like android where find_library doesn't work
if libc_name is None:
# find_library didn't wor... | [_listxattr_inner->[_check],listxattr->[func->[listxattr],_listxattr_inner,split_string0,split_lstring],setxattr->[func->[setxattr],_setxattr_inner],_setxattr_inner->[_check],getxattr->[func->[getxattr],_getxattr_inner],_getxattr_inner->[_check]] | Get all the xattrs of a C library. test_extract_capabilities test but also allows xattrs to work with fakeroot on Linux. | this could be also in the except block. |
@@ -54,10 +54,14 @@ class CmdConfig(CmdBaseNoRepo):
if self.args.value is None and not self.args.unset:
conf = self.config.load_one(self.args.level)
+ prefix = self._config_file_prefix(
+ self.args.show_origin, self.config, self.args.level
+ )
+
... | [CmdConfig->[_check->[ConfigError],_format_config->[flatten],__init__->[super,Config],run->[any,error,_check,edit,load_one,_format_config,join,info,warning]],add_parser->[add_argument,add_parser,set_defaults,append_doc_link],_name_type->[bool,ArgumentTypeError,group,match],add_argument,ArgumentParser,getLogger,add_mutu... | Checks if a exists in the config. | `git config` won't care about `--show-origin` in this scenario, right? |
@@ -10,8 +10,7 @@ class ArticleDashboard < Administrate::BaseDashboard
ATTRIBUTE_TYPES = {
user: Field::BelongsTo,
user_id: UserIdField,
- second_user_id: Field::Number,
- third_user_id: Field::Number,
+ co_author_ids: Field::Number,
organization: Field::BelongsTo,
id: Field::Number,
... | [ArticleDashboard->[display_resource->[title,id],freeze,keys],require] | The base dashboard class for the model. Creates a list of attributes that will be displayed on the model s show page. | should this be `Field::Select` ? |
@@ -355,10 +355,10 @@ public interface ConnectorMetadata
default Optional<ConnectorNewTableLayout> getInsertLayout(ConnectorSession session, ConnectorTableHandle tableHandle)
{
ConnectorTableProperties properties = getTableProperties(session, tableHandle);
+ Map<ColumnHandle, String> columnNam... | [beginInsert->[beginInsert],getTableProperties->[usesLegacyTableLayouts,getTableLayouts,getTableLayout],getViews->[listViews]] | Gets insert layout. | it';s not a loop |
@@ -319,6 +319,8 @@ class ConanInstaller(object):
self._registry.set_ref(conan_ref, node.binary_remote.name)
elif node.binary == BINARY_CACHE:
output.success('Already installed!')
+ _handle_system_requirements(conan_file, package_ref, sel... | [build_id->[build_id],_ConanPackageBuilder->[_build_package->[build],__init__->[build_id]],ConanInstaller->[_download_package->[_handle_system_requirements],_build_package->[prepare_build,package,_ConanPackageBuilder,build],_build->[raise_package_not_found_error],_handle_node_cache->[_build_package,package]]] | Handle a node cache entry. | This shouldn't be done here. System requirements are installed: - On download of packages - On build Sucessive installations shouldn't install them again, and it can make installing the deps graph very slow for already cached deps. |
@@ -101,8 +101,11 @@ namespace System.Windows.Forms
/// Creates a new picture with all default properties and no Image. The default PictureBox.SizeMode
/// will be PictureBoxSizeMode.NORMAL.
/// </summary>
- public PictureBox()
+ /// <param name="httpClient">Http client instan... | [PictureBox->[Load->[Load,InstallNewImage],ToString->[ToString],OnHandleDestroyed->[OnHandleDestroyed],OnHandleCreated->[OnHandleCreated],StopAnimate->[Animate],GetResponseCallback->[PostCompleted],OnPaint->[OnPaint,Load,Animate,LoadAsync],EndInit->[Load],OnResize->[OnResize],ResetImage->[InstallNewImage],OnEnabledChan... | private static readonly object s_loadingCompletedState s_loadingProgressChangedState = 0x Missing border style for the control. | I'm not entirely sure designers will understand that constructor when generating/parsing Designer.cs files, did you test that? |
@@ -58,7 +58,7 @@ public class DeltaGenerator implements Serializable {
private static Logger log = LoggerFactory.getLogger(DeltaGenerator.class);
- private DeltaConfig deltaOutputConfig;
+ private DFSDeltaConfig deltaOutputConfig;
private transient JavaSparkContext jsc;
private transient SparkSession sp... | [DeltaGenerator->[adjustRDDToGenerateExactNumUpdates->[getPartitionToCountMap,getAdjustedPartitionsCount],generateUpdates->[generateInserts]]] | This class creates a delta generator for the given key generator. This is a temporary function that can be used to create an anonymous function for the delta writer. | What is the purpose behind this change ? |
@@ -81,9 +81,12 @@ export function showErrorNotification(props: Object) {
export function showNotification(props: Object = {}, timeout: ?number) {
return function(dispatch: Function, getState: Function) {
const { notifications } = getState()['features/base/config'];
- const shouldDisplay = !notifi... | [No CFG could be retrieved] | Displays a notification for the given . A throttled internal function that takes the internal list of participant names and triggers the display of a. | please check if this breaks the web, since it has no notion of feature flags |
@@ -16,6 +16,8 @@ class DarwinConfigurator(configurator.ApacheConfigurator):
vhost_root="/etc/apache2/other",
vhost_files="*.conf",
logs_root="/var/log/apache2",
+ ctlpath="apachectl",
+ binpath="/usr/sbin/httpd",
version_cmd=['/usr/sbin/httpd', '-v'],
apache_c... | [DarwinConfigurator->[dict,resource_filename],provider] | Configure MACOS specific ApacheConfigurator. | This is currently correctly fixed in `configurator.py`, but if we switch back to `ctlpath`, but this will need to be fixed in this file. |
@@ -11,10 +11,10 @@ module.exports = async (ctx) => {
title: '中华人民共和国农业农村部 - 数据 - 最新发布',
link: `http://zdscxx.moa.gov.cn:8080/nyb/pc/index.jsp`,
item: data.map((item) => ({
- title: `${item.title}`,
- description: `${item.content}`,
+ title: item.title,
+ ... | [No CFG could be retrieved] | title description link page. | Why change the type from `string` to `Date`? |
@@ -101,7 +101,7 @@ class StatementClientV1
this.timeZone = session.getTimeZone();
this.query = query;
this.requestTimeoutNanos = session.getClientRequestTimeout();
- this.user = session.getUser();
+ this.user = session.getPrincipal();
this.clientCapabilities = Joiner.o... | [StatementClientV1->[finalStatusInfo->[isRunning],getStats->[getStats],httpDelete->[close],cancelLeafStage->[isClientAborted],advance->[isRunning,isClientAborted],currentData->[isRunning]]] | This method returns a map of roles to client selected statements. Q ueryText q ueryTypeText. | perhaps rename the field to `principal`. |
@@ -190,14 +190,8 @@ export class AmpGeo extends AMP.BaseElement {
}
this.mode_ = mode.GEO_OVERRIDE;
}
- } else if (
- preRenderMatch &&
- !Services.urlForDoc(this.element).isProxyOrigin(this.win.location)
- ) {
- // pre-rendered by a publisher case, if we're a cache we ign... | [AmpGeo->[addToBody_->[findCountry_,clearPreRender_,matchCountryGroups_]]] | Find a country code in the page. Handle a missing missing key. | @jridgewell could we get away with not guarding this with `isExperimentOn`? this is why i wanted to add a special `i-amp-geo-ssr` class to detect. i could also do a `prerenderHtmlMatch` if we can assume that having geo classes on html is a sign that we ssr'd it |
@@ -33,7 +33,8 @@ class InstallCommand extends Command
new InputOption('prefer-source', null, InputOption::VALUE_NONE, 'Forces installation from package sources when possible, including VCS information.'),
new InputOption('prefer-dist', null, InputOption::VALUE_NONE, 'Forces installati... | [InstallCommand->[execute->[disableCustomInstallers,getOption,setOutputProgress,getComposer,run,getIO,setOptimizeAutoloader],configure->[setHelp]]] | Configures the command options for the command. | This `no-dev` option is simply ignored, isn't it ? |
@@ -2727,6 +2727,9 @@ define([
var uniformState = context.uniformState;
var drawingBufferPosition = SceneTransforms.transformWindowToDrawingBuffer(this, windowPosition, scratchPosition);
+ if (this.pickTranslucentDepth) {
+ renderForPickDepth(this, drawingBufferPosition);
+ ... | [No CFG could be retrieved] | Creates a pick position object from the depth buffer and the window coordinates. Picks the i - th camera. | Perhaps rename to `renderTranslucentDepthForPick`? |
@@ -28,5 +28,10 @@ namespace MonoGameContentProcessors.Processors
return context.BuildAsset<TextureContent, TextureContent>(texture, typeof(MGTextureProcessor).Name, processorParameters, null, null);
}
+
+ protected override ExternalReference<CompiledEffectContent> BuildEffect(ExternalReference... | [MGMaterialProcessor->[BuildTexture->[BuildTexture]]] | BuildTexture builds an external reference of a texture. | Looks like you may have an extra closing brace there. Edit: Nope, just different indenting. |
@@ -57,7 +57,12 @@ func NewLanguageRuntime(host Host, ctx *Context, runtime string,
var args []string
for k, v := range options {
- args = append(args, fmt.Sprintf("-%s=%t", k, v))
+ fmtstr := "-%s=%t"
+ // the prebuilt option specifies a string with an executable name
+ if k == "prebuilt" {
+ fmtstr = "-%s... | [Run->[Run],Close->[Close],GetRequiredPlugins->[GetRequiredPlugins],GetPluginInfo->[GetPluginInfo]] | NewLanguageRuntime creates a new instance of a language host plugin. PluginInfo returns information about the required plugins. | I'd prefer not to special case this. Can we instead typeswitch on `v` and handle the `bool` and `string` cases for now? I can imagine we may want to support arrays as well, but happy to leave that for the future. Also - do we need to quote this? `%q`? |
@@ -1175,13 +1175,14 @@ public class NotebookTest implements JobListenerFactory{
// create private note
Note notePrivate = notebook.createNote(new AuthenticationInfo("user1"));
+ notePrivate.setName("1111");
// only user1 have notePrivate right after creation
notes1 = notebook.getAllN... | [NotebookTest->[delete->[delete],getParagraphJobListener->[afterStatusChange->[onStatusChanged]]]] | Test whether the user is public and not the note of the user is private. This method checks if the user1 and user2 have all rights and if they have all. | I think `setName` may not be the perfect solution because Id would be less than `1111`. How about modifying `note1.contains(notePrivate.getId())`? |
@@ -98,12 +98,9 @@ public class StaticFileResource implements ResourceHandler {
responseBuilder.addProcessedDate(now);
responseBuilder.header("Expires", DateUtils.toRFC1123(now.getTime() + TimeUnit.SECONDS.toMillis(CACHE_MAX_AGE_SECONDS)));
- String mediaType = APPLICATION_OCTET_STREAM_TYPE;
- ... | [StaticFileResource->[serveFile->[resolve],resolve->[resolve]]] | Serve a file. | can't his be the default coming from the resolver instead of null ? |
@@ -155,3 +155,12 @@ class WandBCallback(LogWriterCallback):
def close(self) -> None:
super().close()
self.wandb.finish() # type: ignore
+
+ def state_dict(self) -> Dict[str, Any]:
+ return {
+ "run_id": self._run_id,
+ }
+
+ def load_state_dict(self, state_dict: D... | [WandBCallback->[log_scalars->[_log],log_tensors->[items,cpu,_log,Histogram],on_start->[init,super,watch,join,save],close->[super,finish],_log->[log,items],__init__->[abspath,from_file,dict,super,warning]],register,getLogger] | Closes the Wandb and closes the underlying Wandb object. | I love it when a plan comes together. I'm not sure we had any callbacks using state dicts when we put in support for those? |
@@ -34,7 +34,8 @@ public final class ConnectSchemas {
* @param columns the list of columns.
* @return the Struct schema.
*/
- public static ConnectSchema columnsToConnectSchema(final List<? extends SimpleColumn> columns) {
+ public static ConnectSchema columnsToConnectSchema(final List<? extends SimpleCol... | [ConnectSchemas->[columnsToConnectSchema->[sqlToConnectConverter,text,type,build,toConnectSchema,field,struct]]] | Columns to connect schema. | what is `name`? if not the name of each column, what is it? |
@@ -59,6 +59,11 @@ namespace Dynamo.Controls
private set
{
viewModel = value;
+ this.MouseLeave += (s, e) =>
+ {
+ if (viewModel.OnMouseLeave != null)
+ viewModel.OnMouseLeave();
+ };
... | [NodeView->[ExpandPreviewControl->[IsMouseOver,IsTestMode,IsCondensed,Expanded,TransitionToState],NodeViewReady->[OnNodeViewReady],OnPreviewControlMouseLeave->[GetPosition,Condensed,Control,IsInTransition,StaysOpen,IsMouseInsideNodeOrPreview,Captured,TransitionToState,Modifiers],OnNodeViewMouseEnter->[BeginInvoke,Loade... | A partial class for displaying the top - level view of a node. Initialize the shared dictionary resources. | hmmm... shouldn't we unsubscribe this somewhere else.... |
@@ -0,0 +1,17 @@
+/*
+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com
+ * The software in this package is published under the terms of the CPAL v1.0
+ * license, a copy of which has been included with this distribution in the
+ * LICENSE.txt file.
+ */
+package org.mule.module.launcher;
+... | [No CFG could be retrieved] | No Summary Found. | why not the Disposable interface the Lifecycle API already has? If there's a compeling reason, then maybe a different name could avoid confussion |
@@ -198,6 +198,7 @@ function locate_wp_config() {
$path = realpath( $path );
}
+ WP_CLI::debug( "WP CONFIG : $path" );
return $path;
}
| [iterator_map->[add_transform],mustache_render->[render],format_items->[display_items]] | Locates the WordPress configuration file. | IMO, `WP CONFIG` is rather ambiguous. It should be either more precise - `wp-config.php` - or more verbose - `WordPress configuration file`. |
@@ -65,12 +65,12 @@ function common_content(App $a)
return;
}
- if (!$cid && Profile::getMyURL()) {
- $contact = DBA::selectFirst('contact', ['id'], ['nurl' => normalise_link(Profile::getMyURL()), 'uid' => $uid]);
+ if (!$cid &&Model\Profile::getMyURL()) {
+ $contact = DBA::selectFirst('contact', ['id'], ['nur... | [common_content->[setPagerTotal]] | common content of all contacts get all common friends and the contacts that are in common View a contact. | Code standards: Please keep the space after commas. |
@@ -287,9 +287,9 @@ class TestLinearMultipointConstraints(KratosUnittest.TestCase):
# Applying boundary conditions
self._apply_BCs()
# Applying constraints
- self._apply_mpc_constraints()
+ self._advanced_apply_mpc_constraints()
# Solving the system of equations
- ... | [TestLinearConstraints->[test_constraints->[_create_strategy,_apply_material_properties,inner_prod,_add_variables,_solve_with_strategy]],TestLinearMultipointConstraints->[test_MPC_Constraints->[_setup_model_part,_apply_mpc_constraints,_solve,_reset,_apply_material_properties,_check_results,_add_variables,_apply_BCs,_se... | Test for MPC constraints. | so this is the actual change right? |
@@ -236,11 +236,13 @@ static u16 getSmoothLightCombined(const v3s16 &p, MeshMakeData *data)
}
}
- if(light_count == 0)
- return 0xffff;
+ if(light_count == 0) {
+ light_day = light_night = 0;
+ } else {
+ light_day /= light_count;
+ light_night /= light_count;
+ }
- light_day /= light_count;
- light_night ... | [getInteriorLight->[getInteriorLight], m_minimap_mapblock->[final_color_blend,get_sunlight_color],void->[getNodeTile,getFaceLight,getSmoothLight],append->[append],final_color_blend->[final_color_blend,get_sunlight_color],getNodeTile->[getNodeTileN],getFaceLight->[getFaceLight],fill->[fillBlockDataBegin,fillBlockData],a... | Get the smooth light combined. This function converts the light values into the light values. | Space. Also can be written as `if (!light_count) {` Unsure which style is preferred. |
@@ -22,7 +22,7 @@ def split_by_language(instance_list):
@DataIterator.register("same_language")
-class SameLanguageIterator(BucketIterator):
+class SameLanguageIteratorStub:
"""
Splits batches into batches containing the same language.
The language of each instance is determined by looking at the 'l... | [SameLanguageIterator->[_create_batches->[split_by_language]]] | Creates batches of all instances in the dataset. Yields excess batches. | I'm confused about why we have two basically identical iterators in the first place (homogenous batch, and same language). Any idea why, or why we need to maintain these two separately going forward? Also, you've still used `Stub` instead of `Shim` on these two classes. |
@@ -212,7 +212,7 @@ export const scrollable = () => {
</p>
</>
)}
- <button on="tap:lightbox.close">Close</button>
+ <button slot="close-button">Close</button>
</amp-lightbox>
<div class="buttons">
<button on="tap:lightbox">Open</butt... | [No CFG could be retrieved] | Generalized version of that is used by all of the methods in the base class Ejecuta un nuevo nuevo nuevo nuevo. | Does this need on="tap.lightbox.close"? |
@@ -25,6 +25,7 @@ __all__ = [
import numpy as np
+from ...framework import get_default_dtype
from ...fluid.dygraph import layers
from ...fluid.initializer import Normal
from .. import functional as F
| [Conv3D->[__init__->[_get_default_param_initializer]],Conv2D->[__init__->[_get_default_param_initializer]]] | Creates a callable object of the type which is used to construct a callable object of Input and Output are in NCHW format. | should be handled internally |
@@ -4006,7 +4006,7 @@ replace_failed_replicas(struct pool_svc *svc, struct pool_map *map)
if (replacement.rl_nr > 0)
ds_rsvc_add_replicas_s(&svc->ps_rsvc, &replacement,
ds_rsvc_get_md_cap());
- ds_rsvc_remove_replicas_s(&svc->ps_rsvc, &failed);
+ ds_rsvc_remove_replicas_s(&svc->ps_rsvc, &failed, false ... | [No CFG could be retrieved] | find the next unknown node in the list of failed replicas and replace them with new ones Updates the specified in the specified pool service. | @liw Here, in `replace_failed_replicas`, is the idea that we already know the rank failed, so we don't need to stop it? |
@@ -1158,12 +1158,8 @@ def vertex_to_mni(vertices, hemis, subject, subjects_dir=None, mode=None,
@verbose
-def _read_talxfm(subject, subjects_dir, mode=None, verbose=None):
- """Read MNI transform from FreeSurfer talairach.xfm file.
-
- Adapted from freesurfer m-files. Altered to deal with Norig
- and Tor... | [get_volume_labels_from_src->[get_volume_labels_from_aseg],morph_source_spaces->[_ensure_src_subject,_get_vertex_map_nn,SourceSpaces,_get_hemi,_ensure_src],_get_morph_src_reordering->[_get_vertex_map_nn],read_source_spaces->[_read_source_spaces_from_tree],setup_volume_source_space->[SourceSpaces],get_volume_labels_from... | Read MNI transform from FreeSurfer talairach. xfm file vox_mri_t and t1. mgz are missing if they are extract the MRI_VOXEL to MRI_VOXEL to RAS. | This does not use `mode` other than checking valid, that should be moved (back) to `_read_talxfm` |
@@ -53,7 +53,7 @@ class SchemaUtils {
.build();
/** Convert DataCatalog schema to Beam schema. */
- static Schema fromDataCatalog(com.google.cloud.datacatalog.v1beta1.Schema dcSchema) {
+ public static Schema fromDataCatalog(com.google.cloud.datacatalog.v1beta1.Schema dcSchema) {
return fromColum... | [SchemaUtils->[getBeamFieldType->[fromColumnsList]]] | This method converts a Data Catalog schema to a Schema that is compatible with the Beam Schema. | Rather than making these functions public so our internal code can use them, could we try to move the internal code into Beam? I think it should be possible to move it into DataCatalogTableProvider |
@@ -33,7 +33,8 @@ public final class ConnectorCommandResponseHandler {
final JsonObject connectorInfoEntity,
final CompletableFuture<Void> cf
) {
- if (connectorInfoEntity.getString("@type").equals("connector_info")) {
+ if (connectorInfoEntity.containsKey("statementText")
+ && connectorIn... | [ConnectorCommandResponseHandler->[handleDropConnectorResponse->[IllegalStateException,completeExceptionally,complete,equals],handleListConnectorsResponse->[isPresent,IllegalStateException,get,complete,getListConnectorsResponse,completeExceptionally],handleCreateConnectorResponse->[IllegalStateException,completeExcepti... | Handles the connector info response. | Changed the logic for this because it was failing in the unit tests. |
@@ -92,9 +92,6 @@ namespace Dynamo.Views
DataContextChanged += OnWorkspaceViewDataContextChanged;
- Loaded += OnWorkspaceViewLoaded;
- Unloaded += OnWorkspaceViewUnloaded;
-
// view of items to drag
draggedSelectionTemplate = (DataTemplate)FindResource("D... | [WorkspaceView->[vm_ZoomAtViewportPoint->[AdjustZoomForCurrentZoomAmount,Point],OnWorkspaceViewDataContextChanged->[removeViewModelsubscriptions],vm_ZoomToFitView->[vm_ZoomChanged,vm_CurrentOffsetChanged],OnWorkspaceViewUnloaded->[removeViewModelsubscriptions],vm_CurrentOffsetChanged->[Point],HidePopUp->[ShowHideNodeAu... | private static final int MAX_COUNTER_OF_DEPENDENCIES = 0 Control - Controls the menu and the menu context menu. | The `OnWorkspaceViewDataContextChanged` will be triggered in both cases so I do not see them as must have. |
@@ -212,13 +212,11 @@ void MPMParticlePenaltyCouplingInterfaceCondition::CalculateInterfaceContactForc
if (Is(CONTACT))
{
// Apply only in the normal direction
- array_1d<double, 3 > & unit_normal_vector = this->GetValue(MPC_NORMAL);
- ParticleMechanicsMathUtilities<double>::Normalize(u... | [No CFG could be retrieved] | Get the material point of the node region Public API Methods. | is m_unit_normal normalized? Can you always Normalize to make sure? This is essentially needed if we do a coupling with FEM, cause FEM will only send the direction. |
@@ -218,6 +218,7 @@ public class QueryEndpoint {
metrics.recordRowsProcessed(
Optional.ofNullable(r).map(PullQueryResult::getTotalRowsProcessed).orElse(0L),
sourceType, planType, routingNodeType);
+ pullBandRateLimiter.add(responseBytes);
});
});
| [QueryEndpoint->[KsqlQueryHandle->[start->[start],getColumnTypes->[colTypesFromSchema],getQueryId->[getQueryId],getColumnNames->[colNamesFromSchema]],KsqlPullQueryHandle->[getColumnTypes->[colTypesFromSchema],getColumnNames->[colNamesFromSchema],stop->[stop],start->[start,onException],getQueryId->[getQueryId]]]] | Creates a pull query publisher for the given query sequence number. if statement routing plannerOptions and pullQueryMetrics are null then it will be called. | We would need to call `system time` to record metrics above, maybe we can just get one system time once to save the number of currentSystimeMillis? |
@@ -152,10 +152,8 @@ public class SelectRules
return;
}
- // Only push in sorts that can be used by the Select query.
- final List<OrderByColumnSpec> orderBys = limitSpec.getColumns();
- if (orderBys.isEmpty() ||
- (orderBys.size() == 1 && orderBys.get(0).getDimension().equals(... | [SelectRules->[rules->[DruidSelectSortRule,of,DruidSelectProjectionRule],DruidSelectSortRule->[onMatch->[transformTo,size,equals,getRowOrder,rel,toLimitSpec,getColumns,isEmpty,withQueryBuilder,withLimitSpec],matches->[rel,getLimitSpec,getGrouping],none,operand],DruidSelectProjectionRule->[onMatch->[size,getPlannerConte... | On match. | how a sql to retrieve the latest 10 records is handled after druid select query is totally removed from rules? > select a,b,c from datasource order by __time desc limit 10 This sql can be translated to druid select query with descending=true and should be fast if limit is a small number. If we don't handle this kind of... |
@@ -110,7 +110,9 @@ public class AgentInstaller {
setBootstrapPackages(config);
- runBeforeAgentListeners(agentListeners, config);
+ AutoConfiguredOpenTelemetrySdk autoConfiguredSdk = installOpenTelemetrySdk(config);
+
+ runBeforeAgentListeners(agentListeners, config, autoConfiguredSdk);
AgentB... | [AgentInstaller->[StrictContextStressor->[attach->[attach],close->[close],current->[current],wrap->[close]],installBytebuddyAgent->[installBytebuddyAgent],ClassLoadListener->[onComplete->[run]]]] | Installs a bytebuddy agent. | `installOpenTelemetrySdk(Config)` is `@Nullable` because config may dictate a noop `OpenTelemetry`. But how is a noop `OpenTelemetry` different than just deactivating the agent altogether via `otel.javaagent.enabled=false`? |
@@ -485,7 +485,8 @@ OpenDDS::DCPS::TcpConnection::on_active_connection_established()
sizeof(ACE_UINT32)) == -1) {
// TBD later - Anything we are supposed to do to close the connection.
ACE_ERROR_RETURN((LM_ERROR,
- "(%P|%t) ERROR: Unable to send address string l... | [No CFG could be retrieved] | Creates a connection object from the given connection object. This method is called on the acceptor side when a lost connection is detected. | "ERROR" should go before the method name, that's how it normally is in OpenDDS. |
@@ -560,3 +560,6 @@ if (
"Make sure you've added storefront address to ALLOWED_CLIENT_HOSTS "
"if ENABLE_ACCOUNT_CONFIRMATION_BY_EMAIL is enabled."
)
+
+
+ENABLE_OPENTRACING = get_bool_from_env("ENABLE_OPENTRACING", False)
| [get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],pgettext_lazy,join,config,warn,int,init,get_list,insert,parse,append,dirname,__import__,normpath,get_currency_fraction,_,ImproperlyConfigured,DjangoIntegration,get,get_bool_from_env] | Make sure you have added storefront address to ALLOWED_CLIENT_HOSTS if EN. | Isn't not having a global tracer enough to disable reporting? |
@@ -146,6 +146,7 @@ class ArchivableFilesFinderTest extends \PHPUnit_Framework_TestCase
public function testHgExcludes()
{
+ $this->markTestSkipped('Mercurial test does not work.');
// Ensure that Mercurial is available for testing.
if (!$this->isProcessAvailable('hg')) {
... | [ArchivableFilesFinderTest->[assertArchivableFiles->[getArchivableFiles]]] | Test if the given hg ignores files are archived and removed. | This must be removed. These tests are passing on Travis. |
@@ -58,13 +58,13 @@ static void do_notify(void)
uint32_t flags;
struct ipc_msg *msg;
- tracev_ipc("Not");
-
spin_lock_irq(&_ipc->lock, flags);
msg = _ipc->shared_ctx->dsp_msg;
if (msg == NULL)
goto out;
+ trace_ipc("ipc: not rx -> 0x%x", msg->header);
+
/* copy the data returned from DSP */
if (msg... | [No CFG could be retrieved] | This is a wrapper around the above methods to provide a more flexible way to get the This function is called when a message is received from the host. | for my education, have we stopped using the 3 letter code for errors? If yes, we might want to revisit all the drivers to provide more meaningful information that Sst or ssr for SSP start / resume |
@@ -9140,7 +9140,7 @@ def affine_grid(theta, out_shape, name=None):
out = helper.create_variable_for_type_inference(theta.dtype)
ipts = {'Theta': theta}
- attrs = {}
+ attrs = {"align_corners": align_corners, "use_cudnn": use_cudnn}
if isinstance(out_shape, Variable):
ipts['OutputShape']... | [reduce_sum->[reduce_sum],ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],crop_tensor->[_attr_shape_check,_attr_offsets_check],slice->[slice],reshape->[get_attr_shape],resize_trilinear->[image_resize],mul->[mul],py_func->[PyFuncRegistry],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op_in_dyg... | Generates a grid of x y coordinates using the parameters of the affine transformation that correspond to Returns a sequence of random variables with a single non - zero value. | add fast path for dygraph mode, see the API guide line |
@@ -0,0 +1,18 @@
+# Generated by Django 3.2.5 on 2021-08-30 08:09
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ("payment", "0032_auto_20210827_0717"),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name="payment",... | [No CFG could be retrieved] | No Summary Found. | Can we merge these migrations into one? |
@@ -40,9 +40,16 @@ namespace ProtoCore
public Executable DSExecutable { get; private set; }
public Options RuntimeOptions { get; private set; }
+ public RuntimeStatus RuntimeStatus { get; set; }
public RuntimeMemory RuntimeMemory { get; set; }
- private ProtoCore.Runtime.Con... | [RuntimeCore->[context,DebugProps,DSExecutable,RuntimeOptions]] | Create a new object for the given object. | make property name start with caps |
@@ -145,7 +145,9 @@ class CoderRegistry(object):
'and for custom key classes, by writing a '
'deterministic custom Coder. Please see the '
'documentation for more details.' % (key_coder, op_name))
- if isinstance(key_coder, (coders.PickleCoder, self._fall... | [CoderRegistry->[register_coder->[_register_coder_internal]],CoderRegistry] | Verifies that the key coder is deterministic. | Robert: do we really want to replace FastPrimitivesCoder with DeterministicPickleCoder? I think the only thing here should be PickleCoder, and including FastPrimitivesCoder is an oversight. |
@@ -79,7 +79,7 @@ public class InterpreterSetting {
*
* @param o interpreterSetting from interpreterSettingRef
*/
- public InterpreterSetting(InterpreterSetting o) {
+ public InterpreterSetting(InterpreterSetting o, ZeppelinConfiguration conf) {
this(generateId(), o.getName(), o.getGroup(), o.getInte... | [InterpreterSetting->[closeAndRmoveAllInterpreterGroups->[closeAndRemoveInterpreterGroup],closeAndRemoveInterpreterGroup->[getInterpreterProcessKey],getInterpreterGroup->[getId,getInterpreterProcessKey]]] | Returns the id of the node. | It remains ZeppelinConfiguration. Could you check it again? |
@@ -371,11 +371,11 @@ class RaidenService:
message.sign(self.private_key, self.address)
- def register_payment_network(self, registry_address, from_block=None):
+ def install_payment_network_filters(self, payment_network_id, from_block=None):
proxies = get_relevant_proxies(
self... | [RaidenService->[handle_state_change->[get_block_number],close_and_settle->[leave_all_token_networks],leave_all_token_networks->[get_block_number],register_payment_network->[handle_state_change],start->[start],mediate_mediated_transfer->[mediator_init,handle_state_change],sign->[sign],target_mediated_transfer->[target_... | Sign a message with this token network. | From the usage it seems that `payment_network_id` is an address, can you add a type annotation. (for `from_block`as well pls) |
@@ -480,9 +480,12 @@ def _unpack_epochs(epochs):
@verbose
-def _get_whitener(A, pca, ch_type, verbose=None):
+def _get_whitener(A, pca, ch_type, ncov_rank=None, verbose=None):
# whitening operator
- rnk = rank(A)
+ if ncov_rank is None:
+ rnk = rank(A)
+ else:
+ rnk = ncov_rank
eig... | [write_cov->[save],Covariance->[__iadd__->[_check_covs_algebra],__add__->[_check_covs_algebra]],_get_whitener->[rank],whiten_evoked->[prepare_noise_cov],compute_covariance->[Covariance,_check_n_samples],read_cov->[Covariance],compute_whitener->[prepare_noise_cov],prepare_noise_cov->[_get_whitener],compute_raw_data_cova... | Get the eigenvector and eigvec of a single node where the node is not in. | I would call it just rank |
@@ -593,6 +593,8 @@ def remove_dead_block(block, lives, call_table, arg_aliases, alias_map,
stmt = f(stmt, lives, lives_n_aliases, arg_aliases, alias_map, func_ir,
typemap)
if stmt is None:
+ if config.DEBUG_ARRAY_OPT >= 2:
+ print("State... | [find_build_sequence->[require,get_definition],mk_loop_header->[mk_unique_var],mk_alloc->[mk_unique_var],find_global_value->[find_global_value,get_definition],rename_labels->[find_topo_order],resolve_func_from_module->[resolve_mod->[get_definition,resolve_mod],resolve_mod],gen_np_call->[get_np_ufunc_typ,mk_unique_var],... | Remove dead code from a block. Remove from the node if it has a missing unused variable. | Perhaps all these ought to also print the statement that was removed? |
@@ -1,7 +1,12 @@
+import logging
import os
-from unittest.mock import Mock, patch
+from unittest.mock import ANY, Mock, patch
+import pytest
import requests
+from graphene import Node
+
+from saleor.payment import PaymentError
@patch("saleor.payment.gateways.np_atobarai.api_helpers.requests.request")
| [test_process_payment_authorized->[Mock,np_atobarai_plugin,process_payment],test_process_payment_refused->[Mock,np_atobarai_plugin,process_payment],test_process_payment_error->[Mock,np_atobarai_plugin,join,process_payment],patch] | Test process payment authorized. | Would be good to have unified way of imports between files. Looks like in the rest of the test files you're using relative. |
@@ -5304,8 +5304,18 @@ void Spell::EffectDispelMechanic(SpellEffIndex effIndex)
if (!aura->GetApplicationOfTarget(unitTarget->GetGUID()))
continue;
if (roll_chance_i(aura->CalcDispelChance(unitTarget, !unitTarget->IsFriendlyTo(m_caster))))
+ {
if ((aura->GetSpellInfo()... | [EffectEnchantItemPerm->[DoCreateItem],EffectPull->[EffectNULL],SendLoot->[SendLoot],EffectScriptEffect->[DoCreateItem],EffectOpenLock->[SendLoot],EffectCreateItem2->[DoCreateItem],EffectDisEnchant->[SendLoot],EffectCreateItem->[DoCreateItem],EffectLearnPetSpell->[EffectLearnSpell]] | if a unit is a dispense in the target and it is a mechanic. | are you sure this is not affecting other spells? looks like generic code in a generic function.. |
@@ -220,8 +220,16 @@ export class LiveListManager {
/**
* @param {!Window} win
- * @return {!LiveListManager}
*/
export function installLiveListManager(win) {
- return fromClass(win, 'liveListManager', LiveListManager);
+ registerServiceBuilder(win, 'liveListManager', LiveListManager);
+}
+
+/**
+ * @param {!... | [No CFG could be retrieved] | Installs the LiveListManager class. | `liveListManagerFor` is more consistent with existing method naming. |
@@ -181,7 +181,8 @@ function stats_footer() {
function stats_get_options() {
$options = get_option( 'stats_options' );
- if ( !isset( $options['version'] ) || $options['version'] < STATS_VERSION )
+ if ( ( !isset( $options['version'] ) || $options['version'] < STATS_VERSION ) &&
+ ( is_admin() || defined( 'DOING... | [stats_admin_bar_menu->[add_menu],stats_build_view_data->[get_queried_object_id],stats_print_wp_remote_error->[get_error_messages,get_error_codes]] | Get options for stats. | Since you're touching that old code, could you add in a space before `isset` to respect WP coding standards, as well as curly braces? |
@@ -3,6 +3,17 @@
class ApplicationRecord < ActiveRecord::Base
self.abstract_class = true
+ def self.find_by_graphql_id(graphql_id)
+ type_name, item_id = GraphQL::Schema::UniqueWithinType.decode(graphql_id)
+ type_name = case type_name
+ when "Record" then "Checkin"
+ else
+ type_name
+ end
+... | [ApplicationRecord->[abstract_class]] | returns false if the resource is not a root resource. | end at 12, 4 is not aligned with case at 8, 16. |
@@ -82,6 +82,7 @@ func (s *Server) CreateDataBagItem(ctx context.Context, req *request.CreateDataB
return &response.CreateDataBagItem{
Name: req.Name,
+ Id: req.Data.Fields["id"].GetStringValue(),
}, nil
}
| [GetDataBagItems->[GetPage,createClient,Do,GetSearchQuery,GetPerPage,NewQuery,GetQ],DeleteDataBag->[createClient,Validate,Delete,New],UpdateDataBagItem->[createClient,Error,Validate,New,UpdateItem],GetDataBags->[List,createClient,Validate,New],CreateDataBag->[createClient,Validate,New,Create],GetDataBagItem->[createCli... | CreateDataBagItem creates a new data bag item A helper method to return a non - nil cID from a cID network. | `req.Data` should be in the validation rules as required filed since we need to send back the `id`. |
@@ -22,7 +22,11 @@ import {dev} from '../src/log';
*/
export function _ping_(global, data) {
global.document.getElementById('c').textContent = data.ping;
-
+ if (!data.nativeIo) {
+ const nullIO = () => {};
+ nullIO.prototype = null;
+ global.IntersectionObserver = nullIO;
+ }
if (data.ad_container)... | [No CFG could be retrieved] | Private functions - Check if a specific is present in the UI and if so update on context content available. | to be explicit, data.nativeIntersectionObserver |
@@ -75,8 +75,10 @@ public class NodeService extends NodeImplBase {
.build());
responseObserver.onCompleted();
- } catch (Exception e) {
+ } catch (IOException e) {
responseObserver.onError(e);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
}
... | [NodeService->[nodeUnpublishVolume->[executeCommand]]] | nodePublishVolume - Executes mount command which is used to publish a node in s3. | i think we want to do responseObserver.onError(e); as well here |
@@ -107,6 +107,12 @@ void Database_SQLite3::openDatabase()
throw FileNotGoodException("Cannot open database file");
}
+ if (sqlite3_busy_handler(m_database, sqlite3BusyHandler, busy_handler_data) != SQLITE_OK) {
+ errorstream << "SQLite3 database failed to set busy handler: "
+ << sqlite3_errmsg(m_database) <... | [No CFG could be retrieved] | Reads the database and creates the necessary tables. - - - - - - - - - - - - - - - - - -. | You may want to use the `SQLOK` macro to shorten this. |
@@ -2335,7 +2335,7 @@ namespace System.Windows.Forms.Tests
control.HandleCreated += (sender, e) => createdCallCount++;
Size size = control.SingleMonthSize;
- Assert.True(size.Width >= 176);
+ Assert.True(size.Width >= 169);
Assert.True(size.Height >= 153);
... | [MonthCalendarTests->[InvalidGetMinReqRectMonthCalendar->[WndProc->[WndProc]],CustomGetMinReqRectMonthCalendar->[WndProc->[WndProc]],SubMonthCalendar->[OnFontChanged->[OnFontChanged],OnHandleDestroyed->[OnHandleDestroyed],OnClick->[OnClick],OnHandleCreated->[OnHandleCreated],OnForeColorChanged->[OnForeColorChanged],Get... | This method checks that the method of MonthCalendar is called with a handle and returns expected values. | My calendar is slightly smaller, dunno what the difference is since we have no screenshots. |
@@ -309,14 +309,14 @@ crt_init_opt(crt_group_id_t grpid, uint32_t flags, crt_init_options_t *opt)
struct timeval now;
unsigned int seed;
const char *path;
- bool server;
+ bool server = false;
bool provider_found = false;
int plugin_idx;
int prov;
bool set_sep = false;
int max_num_ctx = 256;
- ui... | [int->[D_GOTO,setenv,srand,mem_pin_workaround,D_ASSERT,D_RWLOCK_INIT,DP_RC,d_timeus_secdiff,rand,d_tm_add_metric,D_CASSERT,D_WARN,D_DEBUG,D_FREE,D_MUTEX_INIT,D_ALLOC_ARRAY,D_ERROR,d_getenv_int,dump_envariables,getpid,D_INFO],inline->[getpid,strlen,D_DEBUG],crt_na_ofi_config_init->[D_STRNDUP,D_GOTO,inet_ntop,D_FREE,geti... | Initializes a new object with the given options. This function is called from CRT_Gdata. It is called from CRT_ get environment variables This function is called to add a new rule to the list of rules that are defined in This function is called to set the server name to 1 This function is called by the rpc_register fun... | This isn't needed. |
@@ -91,7 +91,7 @@ def fingerprint(logcan, sendcan, has_relay):
fw_candidates, car_fw = set(), []
cloudlog.warning("VIN %s", vin)
- Params().put("CarVin", vin)
+ put_nonblocking("CarVin", vin)
finger = gen_empty_fingerprint()
candidate_cars = {i: all_known_cars() for i in [0, 1]} # attempt fingerpri... | [get_car->[fingerprint],fingerprint->[only_toyota_left],_get_interface_names,load_interfaces] | Fingerprint a single message on both bus 0 and 1. magic number of cars. | We can't use the asynchronous version here, since boardd is waiting for the vin to be set and change the safety mode. |
@@ -1114,7 +1114,8 @@ if ($id > 0)
$events[]=array('method' => 'getContacts', 'url' => dol_buildpath('/core/ajax/contacts.php?showempty=1',1), 'htmlname' => 'contactid', 'params' => array('add-customer-contact' => 'disabled'));
// TODO Refresh also list of project if $conf->global->PROJECT_ALLOW_TO_LINK_FROM_OT... | [fetch,create,select_projects,form_project,formconfirm,showOutputField,select_contacts,select_date,getNomUrl,rollback,select_type_actions,createFromClone,select_dolusers,begin,initHooks,form_select_status_action,fetch_contact,load,Create,select_thirdparty_list,executeHooks,update,setOptionalsFromPost,setProject,close,s... | Displays a list of related company and contacts Print the list of projects that can be selected from the form. | Why changing this ? The function select_company must be used in priority. This function follow the setup to decide if we load all database to show the page of just thirdparties after typing some keys. select_thirdparty_list is already called bu select_company if setup "Wait you press a key before loading content of thi... |
@@ -165,8 +165,14 @@ namespace System.Security.Cryptography.Asn1
}
int sizeLimit = Marshal.SizeOf(backingType);
- Span<byte> stackSpan = stackalloc byte[sizeLimit];
- ReadOnlyMemory<byte> saveData = _data;
+ ReadOnlySpan<byte> saveData = _data;
+ S... | [AsnReader->[Enum->[Cryptography_Asn_NamedBitListRequiresFlagsEnum,Cryptography_Asn_NamedBitListValueTooBig,InterpretNamedBitListReversed,Format,nameof,SizeOf,Cryptography_Der_Invalid_Encoding,Name,TryCopyBitStringBytes,IsDefined,ToObject,CER,Slice,DER,ReadNamedBitListValue,PrimitiveBitString,GetEnumUnderlyingType],Int... | Reads a named bit list value. Missing bits in a NamedBitList are used in the C# EXTERNAL structure. | Was using raw pointers here instead of stackallocing directly to a `Span<T>` intentional? |
@@ -349,9 +349,10 @@ class ClassLoader
$first = $class[0];
if (isset($this->prefixLengthsPsr4[$first])) {
foreach ($this->prefixLengthsPsr4[$first] as $prefix => $length) {
+ $logicalPath=substr($logicalPathPsr4, $length);
if (0 === strpos($class, $prefix))... | [ClassLoader->[findFile->[findFileWithExtension],loadClass->[findFile]]] | Finds a file with the given extension. Returns a new instance of the class that will be used to create the class. | this could even be moved into the `if` below, but before the `foreach` |
@@ -21,6 +21,7 @@ class Console extends \Asika\SimpleConsole\Console
'extract' => __NAMESPACE__ . '\Console\Extract',
'globalcommunityblock' => __NAMESPACE__ . '\Console\GlobalCommunityBlock',
'globalcommunitysilence' => __NAMESPACE__ . '\Console\GlobalCommunitySilence',
+ 'install' ... | [Console->[getSubConsole->[out,setOption,getOption],doExecute->[getHelp,getOption,getArgument,out,getSubConsole,setOption,execute]]] | Creates a console instance for a specific node. Generates a messages. php file from a strings. po file from a strings. php file. | Please rename command to `autoinstall`. |
@@ -2603,8 +2603,8 @@ class DFRN
$item["parent-uri"] = $item["uri"];
$inreplyto = $xpath->query("thr:in-reply-to", $entry);
- if (!empty($inreplyto->item[0])) {
- foreach ($inreplyto->item[0]->attributes as $attributes) {
+ if (is_object($inreplyto->item(0))) {
+ foreach ($inreplyto->item(0)->attributes a... | [DFRN->[mail->[appendChild,saveXML,createElement],itemFeed->[setAttribute,createElementNS,saveXML,appendChild],relocate->[appendChild,saveXML,createElement],fsuggest->[appendChild,saveXML,createElement],fetchauthor->[item,query,evaluate],processRelocation->[item],import->[registerNamespace,query,loadXML],transmit->[get... | Process an entry in the header. This function is used to convert an avatar into a bbcode This function is used to store the data from the Diaspora in a different table Transform an XML fragment into an array of attributes. | Wait, what is this notation? |
@@ -130,7 +130,7 @@ public class GetAzureEventHub extends AbstractProcessor {
.name("Event Hub Message Enqueue Time")
.description("A timestamp (ISO-8061 Instant) formatted as YYYY-MM-DDThhmmss.sssZ (2016-01-01T01:01:01.000Z) from which messages "
+ "should have been enque... | [GetAzureEventHub->[receiveEvents->[getReceiver],onTrigger->[receiveEvents],onScheduled->[setupReceiver]]] | This is a convenience method for creating a PropertyDescriptor that can be used to update the number of Relationship. Builder. | Why are you doing this change? The description says we expect ISO-8061. |
@@ -1322,7 +1322,7 @@ namespace Internal.TypeSystem.Interop
ILEmitter emitter = _ilCodeStreams.Emitter;
ILCodeLabel lNullArray = emitter.NewCodeLabel();
- MethodDesc getRawSzArrayDataMethod = InteropTypes.GetRuntimeHelpers(Context).GetKnownMethod("GetRawSzArrayData", null);
+ ... | [BlittableArrayMarshaller->[EmitCleanupManaged->[EmitCleanupManaged],ReInitNativeTransform->[StoreNativeValue],AllocAndTransformManagedToNative->[AllocManagedToNative,LoadNativeValue,EmitElementCount,StoreNativeValue,LoadManagedValue],TransformNativeToManaged->[TransformNativeToManaged]],Marshaller->[EmitMarshalFieldNa... | AllocAndTransformManagedToNative implementation. | Does this mean we have a test hole? |
@@ -39,6 +39,12 @@ module Idv
private
+ def update_tracking
+ analytics.track_event(Analytics::IDV_USPS_ADDRESS_LETTER_REQUESTED)
+ create_user_event(:usps_mail_sent, current_user)
+ Db::ProofingComponent::Add.call(current_user.id, :address_check, 'gpo_letter')
+ end
+
def submit_form... | [UspsController->[attempter->[current_user,new],create->[redirect_to,pending_profile_requires_verification?,track_event,create_user_event,address_verification_mechanism],pii_to_h->[parse],flash_error->[redirect_to],form_response->[new],add_proofing_cost->[call,id],pii->[update_hash_with_non_address_pii,update_hash_with... | submit form and perform resolution if successful. | this proofing component will be overwritten if they decide to switch to phone |
@@ -26,13 +26,8 @@ public interface PolicyTemplate extends Artifact<PolicyTemplateDescriptor> {
*/
void dispose();
- /**
- * @return plugins deployed only inside the policy template
- */
- List<ArtifactPlugin> getArtifactPlugins();
-
/**
* @return plugins the policy depends on
*/
- List<Artif... | [No CFG could be retrieved] | Dispose of the artifact plugins. | Can't remove this. This is API |
@@ -730,6 +730,9 @@ class AdminForm(happyforms.ModelForm):
_choices = [(k, v) for k, v in amo.ADDON_TYPE.items()
if k != amo.ADDON_ANY]
type = forms.ChoiceField(choices=_choices)
+ reputation = forms.ChoiceField(
+ label=_(u'Reputation'),
+ choices=[('', '')] + [(i, unicode(i... | [CheckCompatibilityForm->[clean_application->[version_choices_for_app_id]],CompatForm->[AppVersionChoiceField],NewUploadForm->[clean->[_clean_upload]],ProfileForm->[_Form],check_paypal_id->[check_paypal_id],LicenseForm->[LicenseRadioSelect],DescribeForm->[__init__->[_has_field]]] | Initialize the admin form with a sequence of unique IDs. | The choices are fixed between -3 and +4? Are they arbitrary values or is there logic behind it? |
@@ -99,11 +99,9 @@ std::shared_ptr<PlatformProcess> PlatformProcess::getLauncherProcess() {
try {
handle = reinterpret_cast<HANDLE>(static_cast<std::uintptr_t>(
std::stoull(*launcher_handle, nullptr, 16)));
- }
- catch (std::invalid_argument e) {
+ } catch (std::invalid_argument e) {
return std... | [launchExtension->[unsetEnvVar,c_str,end,str,begin,data,push_back,setEnvVar],operator==->[nativeHandle],duplicateHandle->[duplicateHandle],PlatformPidType->[GetCurrentProcess],operator!=->[nativeHandle],launchWorker->[unsetEnvVar,find,GetCurrentProcessId,c_str,end,str,begin,data,setEnvVar,push_back],getLauncherProcess-... | Returns the handle of the process that is currently running on the system. | Don't we usually try to catch exceptions as `const` references? |
@@ -1,12 +1,9 @@
class UserExport < ActiveRecord::Base
belongs_to :user
+ belongs_to :upload, dependent: :destroy
def self.remove_old_exports
UserExport.where('created_at < ?', 2.days.ago).find_each do |user_export|
- file_name = "#{user_export.file_name}-#{user_export.id}.csv.gz"
- file_path =... | [UserExport->[remove_old_exports->[find_each,destroy!,exist?,file_name,id,base_directory,delete],base_directory->[root,current_db,join],belongs_to]] | remove old exports with id > = 2 days. | I think we can nuke `UserExport.base_directory` from our code base as well. We do need to think about how to clean up that folder which is left around. |
@@ -335,7 +335,7 @@ public class TransformCorrelatedInPredicateToJoin
return new Decorrelated(
decorrelated.getCorrelatedPredicates(),
new ProjectNode(
- node.getId(), // FIXME should I reuse or not?
+ ... | [TransformCorrelatedInPredicateToJoin->[apply->[apply],DecorrelatingVisitor->[visitProject->[decorrelate],visitFilter->[decorrelate]]]] | This method is called for each node in the tree that is a Decorrelated node. | just a thought: In general I am not sure I know why we tend to reuse node ids. What benefits does it give? It is not always possible, so more coherent would be to use new id always. CC: @sopel39? |
@@ -115,11 +115,12 @@ class DaemonPantsRunner(ProcessManager):
(ChunkType.STDOUT, ChunkType.STDERR),
None,
(stdout_isatty, stderr_isatty)
- ) as ((stdout, stderr), writer),\
- NailgunStreamStdinReader.open(sock, stdin_isatty) as stdin,\
- stdio_as(stdout=stdou... | [DaemonPantsRunner->[pre_fork->[pre_fork],post_fork_child->[exit,set_finalizer,_raise_deferred_exc,_nailgunned_stdio,_setup_sigint_handler]]] | Redirects stdio to the connected socket speaking the nailgun protocol. | this should probably move inside the `def finalizer` block? |
@@ -48,6 +48,13 @@ class Ftgl(AutotoolsPackage):
depends_on('glu')
depends_on('freetype@2.0.9:')
+ # Currently, "make install" will fail if the docs weren't built
+ #
+ # FIXME: Can someone with autotools experience fix the build system
+ # so that it doesn't fail when that happens?
+ ... | [Ftgl->[configure_directory->[join],when,depends_on,version]] | Returns the directory where the configuration files should be stored. | This should probably be `type='build'` |
@@ -186,8 +186,8 @@ namespace DotNetNuke.UI.Skins
/// -----------------------------------------------------------------------------
private Containers.Container LoadContainerByPath(string containerPath)
{
- if (containerPath.ToLower().IndexOf("/skins/") != -1 || containerPath.ToLow... | [Pane->[LoadContainerFromCookie->[LoadContainerByPath],ProcessPane->[CanCollapsePane],LoadModuleContainer->[LoadContainerFromCookie,LoadContainerFromPane,LoadContainerByPath,LoadNoContainer,LoadContainerFromQueryString],InjectModule->[IsVesionableModule,LoadModuleContainer],LoadContainerFromPane->[LoadContainerByPath],... | load a container by path. | Please use `String#IndexOf(String, StringComparison)` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.