patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -156,7 +156,7 @@ public abstract class Interpreter {
@ZeppelinApi
public List<InterpreterCompletion> completion(String buf, int cursor,
InterpreterContext interpreterContext) throws InterpreterException {
- return null;
+ return new ArrayList<>();
}
/**
| [Interpreter->[getHook->[getClassName,getHook],setProperty->[setProperty],getProperty->[getProperty],unregisterHook->[getClassName,unregisterHook],getInterpreterInTheSameSessionByClassName->[open,getInterpreterInTheSameSessionByClassName],replaceContextParameters->[setProperty,getProperty],registerHook->[getClassName,r... | This method is called when a node is found in the tree. | do we need mutable List here? If not, can we use `Collections.emptyList()` ? |
@@ -45,6 +45,7 @@ __all__ = (
'NodeCoordinates',
'NodesAndAdjacentNodes',
'NodesAndLinkedEdges',
+ 'NodesAndLinkedEdgesAndLinkedNodes',
'NodesOnly',
'StaticLayoutProvider',
)
| [GraphCoordinates->[Instance],StaticLayoutProvider->[Dict,Seq,Either],LayoutProvider->[edge_coordinates->[EdgeCoordinates],node_coordinates->[NodeCoordinates]],getLogger] | A class that represents a single node in the cartesian space. | As noted by @bryevdv we may need to take a step back to ensure the design and nomenclature is consistent here. I see this new policy as being a union of `NodesAndLinkedEdges` and `NodesAndAdjacentNodes`, so my vote would be `NodesAndLinkedEdgesAndAdjacentNodes`. Would appreciate more input on this. |
@@ -147,6 +147,6 @@ public class DruidCluster
public boolean hasTier(String tier)
{
MinMaxPriorityQueue<ServerHolder> servers = historicals.get(tier);
- return (servers == null) || servers.isEmpty();
+ return (servers != null) && !servers.isEmpty();
}
}
| [DruidCluster->[addRealtime->[add],hasRealtimes->[isEmpty],isEmpty->[isEmpty],hasHistoricals->[isEmpty],hasTier->[isEmpty],addHistorical->[add]]] | Checks if the given tier is in the historical. | This logic flipped? |
@@ -20,7 +20,9 @@ class Bazaar(VersionControl):
def __init__(self, url=None, *args, **kwargs):
super(Bazaar, self).__init__(url, *args, **kwargs)
urlparse.non_hierarchical.extend(['lp'])
- urlparse.uses_fragment.extend(['lp'])
+ # Python >= 2.7.4, 3.3 doesn't have uses_fragment
+ ... | [Bazaar->[get_src_requirement->[get_revision,get_url,get_tag_revs]]] | Initialize Bazaar with a URL and revision number. | 3.3 fails on this line as well, it doesn't have non_hierarchical either. |
@@ -299,6 +299,10 @@ void ClassAuditLog(const Promise *pp, Attributes attr, char *str, char status, c
{
PR_KEPT++;
VAL_KEPT += attr.transaction.value_kept;
+
+#ifdef HAVE_NOVA
+ EnterpriseTrackTotalCompliance(pp, 'c');
+#endif
}
MarkPromiseHandleDone(pp)... | [bool->[IsStrIn],BeginAudit->[memset,ClassAuditLog],EndAudit->[BooleanControl,CfOut,time,cf_ctime,memset,GetVariable,fclose,strlen,ClassAuditLog,snprintf,TrackValue,fopen,Chop,fprintf,PromiseLog],AuditStatusMessage->[WriterWriteF],ClassAuditLog->[NotePromiseCompliance,OpenDB,IsPromiseValuableForStatus,SummarizeTransact... | Method to log a single object in the audit log. SummarizeTransaction - sums all promises in a transaction. A function to handle a missing key in the system. if ap has no version or date or comment set to 0. | why 'c'? kept is spelled with 'k' and the code uses 'k' in the signatures everywhere, such as #define cfr_kept_internal "ki" |
@@ -210,6 +210,7 @@ func NewApplication(config *orm.Config, ethClient eth.Client, advisoryLocker pos
shutdownSignal: shutdownSignal,
balanceMonitor: balanceMonitor,
explorerClient: explorerClient,
+ monitoringEndpoint: monitoringEndpoint,
// NOTE: Can keep things clean b... | [NewBox->[NewBox],ArchiveJob->[ArchiveJob],stop->[Stop],AwaitRun->[AwaitRun],Start->[Start],AddServiceAgreement->[AddJob],AddJob->[AddJob]] | Creates a new instance of the off - chain reporting service. setupConfig sets up the object that will be used to manage the number of records in the. | Why keep a reference to it on the application? |
@@ -104,6 +104,17 @@ class FundCommand extends BaseCommand
$io->write("");
$io->write("Please consider following these links and sponsoring the work of package authors!");
$io->write("Thank you!");
+ } elseif ($format === 'json') {
+ $fundingJson = array();
+ ... | [FundCommand->[insertFundingData->[getFunding,getPrettyName],execute->[isDefaultBranch,write,getName,getRepositories,getFunding,loadPackages,getComposer,getPackages,getLocalRepository,getIO,insertFundingData],configure->[setDescription]]] | Executes the command. Writes a line to the console. | this is still wrong. The list of packages is not per vendor but per url. Otherwise, you loose all except the ones of the last link. |
@@ -823,12 +823,14 @@ public final class ReadOnlyHttp2Headers implements Http2Headers {
for (; i < current.length; i += 2) {
AsciiString roName = current[i];
if (roName.hashCode() == nameHash && roName.contentEqualsIgnoreCase(name)) {
- next = current[i ... | [ReadOnlyHttp2Headers->[getLong->[getLong,get0],contains->[contains,get],containsShort->[contains],method->[get],clientHeaders->[ReadOnlyHttp2Headers],get->[get,get0],getInt->[getInt,get0],getDouble->[getDouble,get0],getByte->[getByte,get0],containsByte->[contains],getChar->[getChar,get0],containsTimeMillis->[contains]... | Calculate next header in the list. | revert... I think this still needs to remain here. |
@@ -163,7 +163,16 @@ crt_proc_daos_prop_t(crt_proc_t proc, daos_prop_t **data)
*data = prop;
return rc;
case CRT_PROC_FREE:
- daos_prop_free(*data);
+ prop = *data;
+ if (prop == NULL)
+ return 0;
+ if (prop->dpp_nr == 0 || prop->dpp_entries == NULL) {
+ D_FREE_PTR(prop);
+ return 0;
+ }
+ crt_proc_... | [crt_proc_daos_prop_t->[daos_prop_alloc,crt_proc_uint32_t,daos_prop_free,crt_proc_prop_entries,D_ERROR,crt_proc_get_op],crt_proc_struct_daos_acl->[daos_acl_get_size,d_iov_set,daos_acl_free,memset,crt_proc_d_iov_t,D_ERROR,crt_proc_get_op],int->[crt_proc_uint32_t,crt_proc_uint64_t,crt_proc_struct_daos_acl,crt_proc_d_stri... | -DER_INVAL -DER_INVAL -DER_INVAL -DER_ MAX_NUM_PROCS - 1. | We should have switched to D_FREE() and be removing D_FREE_PTR() but that can wait for a cleanup patch. |
@@ -66,6 +66,7 @@ public class MetricsEmittingExecutorService extends ForwardingListeningExecutorS
{
if (delegate instanceof PrioritizedExecutorService) {
emitter.emit(metricBuilder.build("segment/scan/pending", ((PrioritizedExecutorService) delegate).getQueueSize()));
+ emitter.emit(metricBuilder.b... | [MetricsEmittingExecutorService->[execute->[execute],submit->[submit]]] | Emit metrics for the delegate service if it is a PrioritizedExecutorService. | Suggest calling this `query/merge/buffersUsed`. Presumably, the other metric (merge buffer wait time) would be something like `query/merge/wait`. |
@@ -185,6 +185,7 @@ namespace Dynamo.ViewModels
public void UpdateSizeFromView(double w, double h)
{
this._model.SetSize(w,h);
+ MoveNoteAbovePinnedNode();
}
private bool CanSelect(object parameter)
| [NoteViewModel->[CanPinToNode->[Any,PinnedNode,FirstOrDefault,Count,Selection,GUID],SelectionOnCollectionChanged->[RaiseCanExecuteChanged],CanUngroupNote->[Any,ContainsModel,IsSelected,GUID,Annotations],CanSelect->[Contains],CanCreateGroup->[Any,Where,ContainsModel,IsSelected,GUID,Annotations],UpdateSizeFromView->[SetS... | Updates the size of the DynamoDb model based on the view. | @reddyashish - this fixes the issue where a pinned note is positioned wrong when opening the graph |
@@ -56,9 +56,9 @@ public class FileSystemLogger {
private void logEncoding(Logger logger, Charset charset) {
if (!fs.isDefaultJvmEncoding()) {
- logger.info("Source encoding: " + charset.displayName() + ", default locale: " + Locale.getDefault());
+ logger.info("Source encoding: {}, default locale: ... | [FileSystemLogger->[doLog->[sources,logDir,tests,logPaths,logEncoding,workDir,encoding,baseDir],logDir->[info,getAbsolutePath],log->[doLog,getLogger,getClass],logEncoding->[displayName,getDefault,warn,info,isDefaultJvmEncoding],logPaths->[hasNext,StringBuilder,append,iterator,toString,PathResolver,isEmpty,info,isBlank,... | log encoding and paths. | a Supplier can be used to avoid a call to displayName() and Locale.getDefault() if INFO level is disabled. |
@@ -277,8 +277,8 @@ class Reader : public Teuchos::Reader {
break;
}
case Teuchos::YAML::PROD_BMAP_FSEQ: {
- TEUCHOS_ASSERT(rhs.at(4).type() == typeid(Array<Scalar>) ||
- rhs.at(4).type() == typeid(Array<Array<Scalar> >));
+ TEUCHOS_ASSERT(rhs.at(4).type() == typeid(std::... | [No CFG could be retrieved] | map_first_item maps the first item of the list to the right of the list Parse the list of items in the rhs array. | @ibaned, why are all of these being switched over from Teuchos::Array to std::vector? Teuchos::Array just uses std::vector in non-debug checking mode but has very strong runtime checking in a debug-mode build. |
@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+class UserAssignment < ApplicationRecord
+ belongs_to :assignable, polymorphic: true
+ belongs_to :user_role
+ belongs_to :user
+ belongs_to :assigned_by, foreign_key: 'assigned_by_id', class_name: 'User'
+end
| [No CFG could be retrieved] | No Summary Found. | Rails/InverseOf: Specify an :inverse_of option. |
@@ -29,7 +29,7 @@ managed_processes = {
"calibrationd": "selfdrive.calibrationd.calibrationd",
"loggerd": "selfdrive.loggerd.loggerd",
"logmessaged": "selfdrive.logmessaged",
- #"boardd": "selfdrive.boardd.boardd",
+ "boardd": "selfdrive.boardd.boardd",
"logcatd": ("logcatd", ["./logcatd"]),
"boardd": ... | [manager_test->[start_managed_process,kill_managed_process,manager_prepare],manager_thread->[kill_managed_process,start_managed_process],main->[manager_test,manager_init,manager_thread,manager_prepare,cleanup_all_processes],cleanup_all_processes->[kill_managed_process],main] | Creates a new process that can be launched by a child process. Catch exceptions and start managed process. | This should be removed, not enabled. |
@@ -95,13 +95,14 @@ class BatchTuner(Tuner):
def import_data(self, data):
"""Import additional data for tuning
+
Parameters
----------
data:
a list of dictionarys, each of which has at least two keys, 'parameter' and 'value'
"""
- if len(self.value... | [BatchTuner->[is_valid->[isinstance,RuntimeError,len],generate_parameters->[NoMoreTrialError,len],import_data->[info,remove,len],update_search_space->[is_valid]],getLogger] | Import additional data for batch tuning. | The space after `LOGGER` |
@@ -0,0 +1,15 @@
+class UserSocialFriendsQuery
+ def initialize(user)
+ @user = user
+ end
+
+ def all
+ provider = @user.providers.first
+ uids = case provider.name
+ when 'twitter' then TwitterService.new(@user).uids
+ when 'facebook' then FacebookService.new(@user).uids
+ end
+
+ User.... | [No CFG could be retrieved] | No Summary Found. | Indent `when` as deep as `case`.<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -479,8 +479,10 @@ class TorchGeneratorAgent(TorchAgent, ABC):
else:
# this is not a shared instance of this class, so do full init
self.criterion = self.build_criterion()
- # ensure all distributed copies will always be in sync
- self.model = self.build_model(... | [SearchBlocklist->[add->[_add_literal],items->[items]],TreeSearch->[_get_hyp_from_finished->[_HypothesisTail],advance->[_block_ngrams,select_paths,_block_block_list,_HypothesisTail],_block_block_list->[items],get_rescored_finished->[_get_hyp_from_finished,_get_pretty_hypothesis,_HypothesisTail]],TorchGeneratorModel->[f... | Initialize the object with the given options. Synchronize model parameters with the current model. | remember that bug with the instability stuff? is this not re-introducing it? |
@@ -76,6 +76,7 @@ class AzureMgmtTestCase(AzureTestCase):
replay_patches=replay_patches,
**kwargs
)
+ self.recording_processors.append(self.re_replacer)
def _setup_scrubber(self):
constants_to_scrub = ["SUBSCRIPTION_ID", "TENANT_ID"]
| [AzureMgmtPreparer->[create_random_name->[get_preparer_resource_name,super],create_mgmt_client->[get,create_basic_client],__init__->[super]],AzureMgmtTestCase->[setUp->[_setup_scrubber,super],_setup_scrubber->[getattr,get_settings_value,hasattr,register_name_pair],create_mgmt_client->[assertRaises,get,create_basic_clie... | Initialize a new AzureMgmtTestCase with the specified parameters. | Do you need access to the `RENameReplacer` specifically? I think you can replace this with: `self.recording_processors.append(RENameReplacer())` and remove the `self.re_replacer` line. |
@@ -52,7 +52,6 @@ import com.google.zetasql.resolvedast.ResolvedNodes.ResolvedLiteral;
import com.google.zetasql.resolvedast.ResolvedNodes.ResolvedOrderByScan;
import com.google.zetasql.resolvedast.ResolvedNodes.ResolvedParameter;
import com.google.zetasql.resolvedast.ResolvedNodes.ResolvedProjectScan;
-import io.gr... | [ExpressionConverter->[convertResolvedStructFieldAccess->[convertRexNodeFromResolvedExpr],convertResolvedCast->[convertRexNodeFromResolvedExpr],convertRexNodeFromResolvedExprWithRefScan->[convertRexNodeFromResolvedExprWithRefScan],convertResolvedParameter->[convertValueToRexNode],convertRexNodeFromResolvedExpr->[conver... | package for google. protobuf. DdlType Imports all the classes that implement SQL Operator mapping table. | :+1: Thanks. This actually adds quite a bit of complexity elsewhere. |
@@ -351,12 +351,6 @@ class AccountPermissions(object):
self.update = update or ('u' in _str)
self.process = process or ('p' in _str)
- def __or__(self, other):
- return AccountPermissions(_str=str(self) + str(other))
-
- def __add__(self, other):
- return AccountPermissions(_str=... | [AccountPermissions->[__or__->[AccountPermissions],__add__->[AccountPermissions]],Services->[__or__->[Services],__add__->[Services]],DictMixin->[items->[items],__ne__->[__eq__],update->[update]],ResourceTypes->[__or__->[ResourceTypes],__add__->[ResourceTypes]],Services,ResourceTypes,AccountPermissions] | Initialize a new object with the specified flags. | We should construct `self._str` in here, and keep it around (or use directly the input from `from_string`. Then we can return it in `__str__`. This should keep the "non-lossy" behaviour discussed in the review |
@@ -94,6 +94,8 @@ public class StateTransferManagerImpl implements StateTransferManager {
persistentStateChecksum = Optional.empty();
}
+ float capacityFactor = globalConfiguration.isZeroCapacityNode() ? 0.0f : configuration.clustering().hash().capacityFactor();
+
CacheJoinInfo joinInfo =... | [StateTransferManagerImpl->[forwardCommandIfNeeded->[getCacheTopology],isStateTransferInProgress->[isStateTransferInProgress],isStateTransferInProgressForKey->[isStateTransferInProgressForKey],getCacheTopology->[getCacheTopology],ownsData->[ownsData],getFirstTopologyAsMember->[getFirstTopologyAsMember],doTopologyUpdate... | This method is called when the cache is started. | I really wish this was set in the `HashConfigurationBuilder#create` method instead, so we don't have to worry about all the references. But we don't have access to the `GlobalConfiguration` there as far as I know. :( |
@@ -71,4 +71,14 @@ public class InstrumentedExtractorDecorator<S, D> extends InstrumentedExtractorB
public long getHighWatermark() {
return this.embeddedExtractor.getHighWatermark();
}
+
+ @Override
+ public void close()
+ throws IOException {
+ try {
+ this.embeddedExtractor.close();
+ } f... | [InstrumentedExtractorDecorator->[getSchema->[getSchema],readRecord->[readRecord],readRecordImpl->[readRecord],getExpectedRecordCount->[getExpectedRecordCount],getMetricContext->[getMetricContext],getHighWatermark->[getHighWatermark]]] | Returns the high watermark of the embedded extractor. | You're right the embedded constructs are not being closed. However, another way of closing them would be to call in the constructor: this.embeddedExtractor = this.closer.register(extractor); Then they would be closed automatically by the super.close() method. |
@@ -10,6 +10,9 @@ func (at Kind) String() string {
}
const (
+ // ProxyUpdate is the event kind used to trigger an update to subscribed proxies
+ ProxyUpdate Kind = "proxy-update"
+
// ScheduleProxyBroadcast is used by other modules to request the dispatcher to schedule a global proxy broadcast
ScheduleProxyBro... | [No CFG could be retrieved] | announcements provides the types and constants that are used to contextualize events received from the. | Is this functionally different from `ScheduleProxyBroadcast`? |
@@ -95,9 +95,10 @@ public class RequestHandlerCircuitBreakerAdvice extends AbstractRequestHandlerAd
private static final long serialVersionUID = 1L;
- public CircuitBreakerOpenException(String message) {
+ private CircuitBreakerOpenException(String message) {
super(message);
}
+
}
}
| [RequestHandlerCircuitBreakerAdvice->[AdvisedMetadata->[AtomicInteger],doInvoke->[AdvisedMetadata,debug,incrementAndGet,setLastFailure,get,getLastFailure,isDebugEnabled,set,currentTimeMillis,CircuitBreakerOpenException,unwrapExceptionIfNecessary,putIfAbsent,execute]]] | Creates a CircuitBreakerOpenException. | Technically this exception should be moved on top. It might be useful for end-application rely on the exception thrown. Otherwise, please, explain the reason to hide it here and throw to the caller from `doInvoke()`. |
@@ -535,13 +535,13 @@ class _BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin,
# Detrend
if self.detrend is not None:
picks = pick_types(self.info, meg=True, eeg=True, stim=False,
- ref_meg=False, eog=False, ecg=False,
+ ... | [EpochsArray->[__init__->[_detrend_offset_decim,drop_bad_epochs]],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],_BaseEpochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_goo... | This function is a private method that performs the detrend baseline correct offset and decim iteration. | BTW. What are these reference MEG channels used for? Here they are not detrended, but baselining is applied. |
@@ -580,10 +580,14 @@ func (t *tether) launch(session *SessionConfig) error {
extraconfig.EncodeWithPrefix(t.sink, session, prefix)
}()
- // Special case here because UID/GID lookup need to be done
- // on the appliance...
- if len(session.User) > 0 {
- session.Cmd.SysProcAttr = getUserSysProcAttr(session.User)... | [Start->[processSessions,initializeSessions,cleanup,setup,setHostname,setLogLevel,setNetworks,reloadExtensions,setMounts]] | launch launches a session This function is called by the daemon to start a container process. It is called by the. | Maybe session.Started should be set to this same error message? |
@@ -360,7 +360,8 @@ public class HoodieAppendHandle<T extends HoodieRecordPayload, I, K, O> extends
header.put(HoodieLogBlock.HeaderMetadataType.SCHEMA, writeSchemaWithMetaFields.toString());
List<HoodieLogBlock> blocks = new ArrayList<>(2);
if (recordList.size() > 0) {
- blocks.add(HoodieDa... | [HoodieAppendHandle->[getIndexedRecord->[isUpdateRecord],appendDataAndDeleteBlocks->[processAppendResult],write->[init],close->[close,appendDataAndDeleteBlocks],updateWriteStat->[makeFilePath],updateWriteStatus->[updateWriteStat,updateRuntimeStats,updateWriteCounts],writeToBuffer->[getIndexedRecord,needsUpdateLocation]... | Append data and delete blocks. | Can we add a overloaded method to HoodieDataBlock.getBlock(). One same as in master (non virtual key path) and another one for virtual key path. probably good to call the 2nd one only when populateMetaFields is set to false here. |
@@ -135,7 +135,12 @@ def get_platform():
if result == "linux_x86_64" and _is_running_32bit():
# 32 bit Python program (running on a 64 bit Linux): pip should only
# install and run 32 bit compiled extensions in that case.
- result = "linux_i686"
+ machine = platform.machine()
+
+ ... | [get_impl_tag->[get_impl_ver,get_abbr_impl],get_abi_tag->[get_impl_ver,get_flag,get_abbr_impl,get_config_var],get_impl_ver->[get_abbr_impl,get_config_var],get_platform->[get_platform,_is_running_32bit],get_darwin_arches->[_supports_arch->[_supports_arch],_supports_arch],get_supported->[get_abi_tag,get_platform,get_darw... | Get the platform name of the current system. | Maybe add a conditional with warning here, if `machine != "i686"`? |
@@ -165,10 +165,10 @@ function assertTarget(name, target, config) {
* @return {string} The vendor's iframe URL
*/
export function assertVendor(vendor) {
- user().assert(ANALYTICS_CONFIG &&
- ANALYTICS_CONFIG[vendor] &&
- ANALYTICS_CONFIG[vendor]['transport'] &&
- ANALYTICS_CONFIG[vendor]['transport... | [No CFG could be retrieved] | Assert that the vendor has an iframe URL. | Can we make this error message a little more helpful? `Unknown or invalid vendor ${vendor}, note that vendor must use transport: iframe` |
@@ -180,4 +180,6 @@ public class BasicAuthenticationFilter implements Filter {
public void destroy() {
}
+
+ private static final Logger LOGGER = Logger.getLogger(BasicAuthenticationFilter.class.getName());
}
| [BasicAuthenticationFilter->[doFilter->[doFilter]]] | Destroy the managed object. | :nit: class fields should come before methods. |
@@ -1309,7 +1309,6 @@ class PackageBase(six.with_metaclass(PackageMeta, PackageViewMixin, object)):
tty.debug('No fetch required for {0}: package has no code.'
.format(self.name))
- start_time = time.time()
checksum = spack.config.get('config:checksum')
fet... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],setup_build_environment->[_get_legacy_environment_method],cache_extra_test_sources->[copy],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_uninstall->[uninstall_b... | Fetch a package. | Previously, "fetch time" would include the time that Spack waited at the prompt for the user to confirm or deny no-checksum/deprecated versions. |
@@ -430,7 +430,7 @@ func (h *balanceHotRegionsScheduler) selectDestStore(candidateStoreIDs []uint64,
return
}
-func (h *balanceHotRegionsScheduler) adjustBalanceLimit(storeID uint64, storesStat core.StoreHotRegionsStat) {
+func (h *balanceHotRegionsScheduler) adjustBalanceLimit(storeID uint64, storesStat core.Stor... | [balanceByLeader->[allowBalanceLeader],Schedule->[GetName],balanceByPeer->[allowBalanceRegion],balanceHotReadRegions->[GetName],balanceHotWriteRegions->[GetName]] | selectDestStore selects the destination store based on the given source and destination store IDs. | Kind complicated to pass a callback... why not let it return the new limit? |
@@ -79,9 +79,11 @@ public class Http11To2UpgradeHandler extends ApplicationProtocolNegotiationHandl
}
private void configureHttp1(ChannelPipeline pipeline) {
- final HttpServerCodec httpCodec = new HttpServerCodec(MAX_INITIAL_LINE_SIZE, MAX_HEADER_SIZE, restServer.getConfiguration().maxContentLength());
... | [Http11To2UpgradeHandler->[maxContentLength->[maxContentLength],configurePipeline->[configurePipeline]]] | Configures the HTTP 1 pipeline. | Should we only optionally add this if the level is > 0? |
@@ -2019,7 +2019,7 @@ namespace System.Windows.Forms
// we want to use the new DisplayMember even if there is no data source
RefreshItems();
- if (SelectionMode != SelectionMode.None && DataManager != null)
+ if (SelectionMode != SelectionMode.None && DataManager is not... | [ListBox->[FindString->[FindString],OnFontChanged->[OnFontChanged],WmReflectMeasureItem->[OnMeasureItem],Sort->[NativeClear,NativeAdd,NativeSetSelected,Sort,CheckNoDataSource,GetSelected],GetSelected->[CheckIndex],OnHandleDestroyed->[OnHandleDestroyed],ToString->[ToString],OnDisplayMemberChanged->[OnDisplayMemberChange... | Override OnDisplayMemberChanged to refresh the items in the list if there is a data source. | ``is not SelectionMode.None`` (There is possibly a lot more I missed on the if's) |
@@ -388,7 +388,7 @@ public class ParDoSchemaTest implements Serializable {
new DoFn<Inferred, String>() {
@ProcessElement
public void process(@Element Row row, OutputReceiver<String> r) {
- r.output(row.getString(0) + ":" + row.ge... | [ParDoSchemaTest->[testReadAndWriteMultiOutput->[MyPojo],testNestedSchema->[process->[getIntegerField,getStringField]],testSchemaFieldSelectionNested->[process->[getInts,getIntegerField,getStringField]],testReadAndWrite->[MyPojo],testReadAndWriteWithSchemaRegistry->[MyPojo],testSimpleSchemaPipeline->[MyPojo],testUnmatc... | Inferred schema pipeline. | So basically it is not safe to use AutoValue with Schemas. Should we convert the example to use a Pojo instead (like it previously did)? Should we throw an error that schemas do not work deterministically in this case? |
@@ -35,6 +35,10 @@ from raiden.transfer.mediated_transfer.state_change import (
from raiden.transfer.state import (
BalanceProofSignedState,
BalanceProofUnsignedState,
+<<<<<<< HEAD
+=======
+ ChainState,
+>>>>>>> Extended messages for failed test assertions
ChannelState,
HashTimeLockState,
... | [assert_synced_channel_state->[assert_channel_values,assert_deposit,assert_balance_proof]] | This module is used to provide a way to create a new object from a given object. Returns the target state of a transfer. | I don't know if this should be in or out, but has to be one of these. |
@@ -174,10 +174,11 @@ def _handle_get_page_fail(link, reason, url, meth=None):
meth("Could not fetch URL %s: %s - skipping", link, reason)
-def _get_html_page(link, session=None):
+def _get_html_page(link, session=None, unresponsive_hosts=None):
if session is None:
raise TypeError(
- "... | [PackageFinder->[_sort_locations->[sort_path],_get_index_urls_locations->[mkurl_pypi_url],find_all_candidates->[_sort_locations,_validate_secure_origin,_get_index_urls_locations],_get_pages->[_get_html_page],find_requirement->[find_all_candidates],_link_package_versions->[_log_skipped_link],_package_versions->[_sort_li... | Get the HTML page with a . Return a response object with a timeout if the response is not a 200 response. | I feel the `=None` default is unnecessary. Is there a case `unresponsive_hosts` *should* be `None`? Even if there is, why does it need a default, instead of being passed explicitly? |
@@ -174,7 +174,7 @@ function getFirefoxArgs(config) {
const args = [];
if (config.headless) {
- args.push('-headless');
+ args.push('--headless');
}
return args;
}
| [ItConfig->[run->[apply]],EndToEndFixture->[setup->[getController,setWindowRect,navigateToEnvironment,ampDriver,getConfig,controller,toggleExperiments],teardown->[dispose,switchToParent]],environments,create,headless,size,describeFunc,createBrowserDescribe,getChromeArgs,describe,isTravisBuild,toggleExperiment,browsers,... | Creates a new with the given browser name and arguments. Helper class to skip E2E tests in a specific environment. | Nice catch! Does this mean we no longer need `xvfb` In`.travis.yml`? |
@@ -35,7 +35,6 @@ namespace NServiceBus.AcceptanceTests.Hosting
public MyFeatureThatOverridesHostInformationDefaults()
{
EnableByDefault();
- DependsOn("UnicastBus");
Defaults(s =>
{
// remove the override, ... | [When_feature_overrides_hostid->[Task->[Run,NotSet,IsTrue],MyFeatureThatOverridesHostInformationDefaults->[NotSet,TryRemove,GetField,NonPublic,NewGuid,EnableByDefault,GetValue,DependsOn,Defaults,Set,Instance,s,HasSetting],MyMessageHandler->[Task->[FromResult,Done]],MyEndpoint->[UsingCustomIdentifier,NewGuid]]] | Provides a basic configuration for a specific . The class is used to determine if a command is a . | Since we have `DependsOnOptionally` shouldn't this have thrown? |
@@ -51,6 +51,9 @@ namespace System.Diagnostics.Tracing
public override string ToString() => $"IncrementingEventCounter '{Name}' Increment {_increment}";
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:RequiresUnreferencedCode",
+ Justification = "IncrementingCounterPayload t... | [No CFG could be retrieved] | Creates a new IncrementingEventCounter object. Updates the value of the object. | Similar justification message here as above - explain that the DynamicDependency makes this safe. |
@@ -628,7 +628,12 @@ func (a *APIServer) Status(ctx context.Context, _ *types.Empty) (*pps.WorkerStat
}
// Cancel cancels the currently running datum
-func (a *APIServer) Cancel(ctx context.Context, request *CancelRequest) (*CancelResponse, error) {
+func (a *APIServer) Cancel(ctx context.Context, request *CancelRe... | [Write->[Logf,Write],downloadData->[Logf],Process->[cleanUpData,getTaggedLogger,Logf,downloadData,uploadOutput,runUserCode],uploadOutput->[Logf],runUserCode->[userLogger,Logf],Write] | Cancel cancels the job. | Same here as with Status. |
@@ -70,6 +70,7 @@ public class LookupDimensionSpec implements DimensionSpec
@JsonProperty("retainMissingValue") boolean retainMissingValue,
@JsonProperty("replaceMissingValueWith") String replaceMissingValueWith,
@JsonProperty("name") String name,
+ @JsonProperty("mapName") String mapName,
... | [LookupDimensionSpec->[getCacheKey->[getCacheKey],hashCode->[hashCode,getName,getLookup],preservesOrdering->[preservesOrdering],equals->[equals,getName,getDimension,getOutputName,getLookup]]] | A DimensionSpec is a base class for all of the properties that are used to lookup a Get the output name of the . | why is this changing the API ? not all the lookups will have a map name ? |
@@ -16,8 +16,8 @@ from pants.task.console_task import ConsoleTask
class FileDeps(ConsoleTask):
"""List all source and BUILD files a target transitively depends on.
- Files are listed with absolute paths and any BUILD files implied in the transitive closure of
- targets are also included.
+ Files may be listed ... | [FileDeps->[console_output->[list,sources_relative_to_buildroot,has_sources,keys,chain,update,globs_relative_to_buildroot,get_options,set,isinstance,_full_path,add],register_options->[register,super],_full_path->[get_buildroot,join]]] | Register options for FileDeps. | Let's call this `absolute` not `abs` |
@@ -40,6 +40,8 @@ class User < ApplicationRecord
SEARCH_CLASS = Search::User
DATA_SYNC_CLASS = DataSync::Elasticsearch::User
+ DELETED_USER = User.new(username: "[deleted user]", name: "[Deleted User]")
+
acts_as_followable
acts_as_follower
| [User->[check_for_username_change->[path],send_welcome_notification->[send_welcome_notification],blocked_by?->[blocking?],auditable?->[any_admin?],blocking?->[blocking?],resave_articles->[path]]] | The config values are not valid but can be used in a different way. Data model that can be used to create a user. | Not sure how I feel about this as a constant here. It's nice bc it is very accessible but at the same time we currently only using this in a view which makes it feel like it should be in a helper. Maybe @vaidehijoshi has some thoughts. |
@@ -232,6 +232,8 @@ final class FieldsBuilder implements FieldsBuilderInterface
$args = [];
if (!$input && null === $mutationName && !$isStandardGraphqlType && $this->typeBuilder->isCollection($type)) {
+ $propertyResourceMetadata = $this->resourceMetadataFactory->create($clas... | [FieldsBuilder->[convertFilterArgsToTypes->[convertFilterArgsToTypes],mergeFilterArgs->[mergeFilterArgs],convertType->[convertType]]] | Returns the configuration for a resource field. Returns a tuple of the GraphQL type and the description of a node in the filter tree. | Why property? Maybe we could use `$resourceMetadata` and rename the argument in `$parentResourceMetadata`? |
@@ -265,7 +265,12 @@ class Order(CountableDjangoObjectType):
@staticmethod
def resolve_fulfillments(self, info):
- return self.fulfillments.all().order_by('pk')
+ context_kwargs = getattr(info.context, 'kwargs', {})
+ if context_kwargs.get('ignore_cancelled_fulfillment', False):
+ ... | [Order->[resolve_payments->[all],resolve_can_finalize->[can_finalize_draft_order],resolve_available_shipping_methods->[get_subtotal,applicable_shipping_methods],resolve_fulfillments->[all],resolve_subtotal->[get_subtotal],resolve_lines->[all],resolve_is_shipping_required->[is_shipping_required],resolve_number->[str],re... | Resolve the list of all the fulfilled objects. | I'm not 100% convinced about assigning arbitrary variables to `info.context` which in Graphene is a Django request object, but honestly, I also don't see a better idea how to customize the resolver behavior for `me` query. What about a different approach - would it make sense if we excluded canceled fulfillments for un... |
@@ -36,7 +36,7 @@ public class DefaultTextHeaders extends DefaultConvertibleHeaders<CharSequence,
}
};
- private static final HashCodeGenerator<CharSequence> CHARSEQUECE_CASE_SENSITIVE_HASH_CODE_GENERATOR =
+ private static final HashCodeGenerator<CharSequence> CHARSEQUENCE_CASE_SENSITIVE_HASH_COD... | [DefaultTextHeaders->[contains->[contains],SingleHeaderValuesComposer->[objectEscaper->[escape->[convertObject]],commaSeparate->[escape],addObject->[objectEscaper],set->[set,charSequenceEscaper],addEscapedValue->[set,add],add->[charSequenceEscaper],setObject->[objectEscaper,set]],setInt->[setInt],addObject->[addObject]... | Convert the object to a CharSequence. | It's probably better dropping `CHARSEQUENCE_` at all? It's private and we all know it's for `CharSequence`. |
@@ -57,6 +57,11 @@ class HubTest(TestCase):
assert self.client.login(email='regular@mozilla.com')
assert self.client.get(self.url).status_code == 200
self.user_profile = UserProfile.objects.get(id=999)
+ not_their_addon = addon_factory(users=[user_factory()])
+ AddonUser.unfilte... | [TestRemoveLocale->[test_remove_version_locale->[post],test_bad_request->[post],test_delete_default_locale->[post],test_success->[post]],TestUpload->[test_create_fileupload->[post],test_fileupload_metadata->[post],test_upload_unlisted_addon->[post],test_redirect->[post],test_fileupload_validation->[post],test_login_req... | Initialize the object. | Nit: It actually *is* their addon, isn't it? It's just that the `AddonUser` record has them listed as deleted. |
@@ -148,7 +148,9 @@ public class QueryTranslationTest {
}
static Stream<TestCase> buildTestCases() {
- return EndToEndEngineTestUtil.findTestCases(QUERY_VALIDATION_TEST_DIR)
+ List<String> testFiles = EndToEndEngineTestUtil.getTestFilesParam();
+
+ return EndToEndEngineTestUtil.findTestCases(QUERY_VALI... | [QueryTranslationTest->[createRecordFromNode->[getSerdeSupplier],createTopicFromNode->[getSerdeSupplier],createTopicFromStatement->[getSerdeSupplier,addNames],addNames->[addNames]]] | Build test cases. | nit: `final` and elsewhere |
@@ -469,6 +469,7 @@ class CheckoutComplete(BaseMutation):
class Arguments:
checkout_id = graphene.ID(description="Checkout ID", required=True)
+ store_source = graphene.Boolean(default_value=False)
class Meta:
description = (
| [CheckoutUpdateVoucher->[perform_mutation->[CheckoutUpdateVoucher]],CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save]],CheckoutCreate->[perform_mutation->[save,CheckoutCreate,clean_input],save->[save],Arguments->[CheckoutCreateInput],clean_input->[check_lines_quantity]],CheckoutShippi... | Create a mutation that will create a new order and save it to the database. Validate that the is valid. | Missing field description, it should say something like "Determines whether to store the payment method for future usage". "Method" or "source" - I'm not sure which one we want to stick to, but it should be used consistently. |
@@ -3092,12 +3092,12 @@ def iternext_numpy_getitem(context, builder, sig, args):
arrcls = context.make_array(arrty)
arr = arrcls(context, builder, value=flatiter.array)
- res = flatiter.setitem(context, builder, arrty, arr, index, value)
+ _ = flatiter.setitem(context, builder, arrty, arr, index, valu... | [np_array->[assign_sequence_to_array,compute_sequence_shape,_empty_nd_impl,check_sequence_shape],array_shape->[make_array],get_array_memory_extents->[offset_bounds_from_strides,compute_memory_extents],numpy_empty_nd->[_parse_empty_args,_empty_nd_impl],normalize_index->[make_array,load_item],maybe_copy_source->[src_geti... | This is the default implementation of numpy. iternext. | assignment can be removed? |
@@ -32,10 +32,10 @@ import { <%=jhiPrefixCapitalized%>TrackerService } from '../tracker/tracker.serv
@Injectable({providedIn: 'root'})
export class AccountService {
- private userIdentity: any;
+ private userIdentity: Account;
private authenticated = false;
private authenticationState = new Subject... | [No CFG could be retrieved] | Creates an object that represents an user identity in a system. API endpoint for UAA. | I think we can remove `userIdentity`, `authenticated` and `accountCache$` variables and provide getter methods to derive the state from `authenticationState` subject. |
@@ -670,13 +670,14 @@ func TestValidateSource(t *testing.T) {
// 3
{
t: fielderrors.ValidationErrorTypeInvalid,
- path: "binary",
+ path: "git",
source: &buildapi.BuildSource{
Git: &buildapi.GitBuildSource{
URI: "https://example.com/repo.git",
},
Binary: &buildapi.BinaryBuildSo... | [Repeat,Errorf,Fatalf,NewFieldInvalid,NewFieldRequired] | TestValidateSource tests if a build object has a valid build id. File returns a description of the object that represents a single file in the build source. | i have to assume some new validation tests are in order using image-sourced buildconfigs, even if they are only valid ones. |
@@ -36,10 +36,12 @@ if ($device['os'] == 'comware') {
foreach ($comware_oids as $index => $entry) {
if (is_numeric($entry['hh3cTransceiverTemperature']) && $entry['hh3cTransceiverTemperature'] != 2147483647) {
$oid = '.1.3.6.1.4.1.25506.2.70.1.1.1.15.' . $index;
- ... | [No CFG could be retrieved] | This function is used to find the correct number of ethernet ports for a given device. Temperature Sensor Sensor. | The formatting of this seems unnecessary. |
@@ -91,7 +91,6 @@ public final class TicketGrantingTicketResource extends Resource {
final String serviceTicketId = this.centralAuthenticationService.grantServiceTicket(this.ticketGrantingTicketId, new SimpleWebApplicationServiceImpl(serviceUrl, this.httpClient));
getResponse().setEntity(servi... | [TicketGrantingTicketResource->[init->[init,Variant,add,get],acceptRepresentation->[getMessage,error,getEntityAsForm,setEntity,setStatus,grantServiceTicket,SimpleWebApplicationServiceImpl,getFirstValue],removeRepresentations->[destroyTicketGrantingTicket,setStatus],getLogger]] | Accept a Representation of a ServiceTicketGrantingTicket. | why not keep a log.info ? |
@@ -76,8 +76,9 @@ def analyze_member_access(name: str,
if method.is_property:
assert isinstance(method, OverloadedFuncDef)
first_item = cast(Decorator, method.items[0])
+ plugin = chk.plugin if chk is not None else None
return analyze_var(na... | [add_class_tvars->[add_class_tvars],analyze_class_attribute_access->[handle_partial_attribute_type],bind_self->[expand,bind_self],analyze_member_access->[analyze_member_access]] | Analyzes a member of a base object. Analyzes a member access. Analyzes the access level of a node. Analyze the member access. Check if a node has a missing attribute. | I don't think chk can ever be None. The type should probably be adjusted. |
@@ -83,7 +83,6 @@ function create_pv() {
}
basedir="%[2]s"
-setup_pv_dir "${basedir}/registry"
for i in $(seq -f "%%04g" 1 %[1]d); do
create_pv "${basedir}" "pv${i}"
| [Install->[IsNotExist,ClientImage,Join,Batch,Stat,Infof,Create,NewForConfig,Errorf,IsNotFound,BaseDir,Get,ClusterAdminClientConfig,Jobs],PollImmediate,Create,Sprintf,AddRole,ServiceAccounts,AddSCC,MakeUsername,Core,SecurityContextConstraints,Errorf,IsNotFound,RetryOnConflict,Get,Security] | Create a persistent volume if it doesn t already exist Determines if a job has already been created and if so returns it. | is the registry component also doing the chcon, or was that along with the chmod resulting in the issue? |
@@ -23,8 +23,6 @@ namespace NServiceBus
if (typeof(XContainer).IsAssignableFrom(t))
{
- typesBeingInitialized.Add(t);
-
return;
}
| [XmlSerializerCache->[InitType->[InitType],GetAllPropertiesForType->[GetAllPropertiesForType]]] | Initialize a type. This method checks if a type is already in the process of initializing it. | @timbussmann As discussed on the call, once you verify this change and why this line was here in the first place, I think this is good to go. |
@@ -251,8 +251,7 @@ pool_target_addr_list_append(struct pool_target_addr_list *addr_list,
if (pool_target_addr_found(addr_list, addr))
return 0;
- D_REALLOC(new_addrs, addr_list->pta_addrs, (addr_list->pta_number + 1) *
- sizeof(*addr_list->pta_addrs));
+ D_REALLOC_ARRAY(new_addrs, addr_list->pta_addrs, ad... | [No CFG could be retrieved] | - DAOS_RPC_FORMAT - DAOS_RPC_FORMAT - D finds the first n - th target address in the pool and returns the index of the. | (style) line over 80 characters |
@@ -780,7 +780,7 @@ namespace Dynamo.Utilities
var guidEnd = new Guid(guidEndAttrib.Value);
int startIndex = Convert.ToInt16(intStartAttrib.Value);
int endIndex = Convert.ToInt16(intEndAttrib.Value);
- int portType = Convert.ToInt16(portT... | [CustomNodeManager->[AddDirectoryToSearchPath->[Contains],IsInitialized->[Guid,IsInitialized],SetNodeInfo->[Guid],GetDefinitionFromPath->[Contains,GetNodePath],Refactor->[Guid,SetNodeInfo,Refactor],RemoveTypesLoadedFromFolder->[Guid],SetFunctionDefinition->[Remove],Guid->[Guid,Contains],Remove->[Guid],GetNodeInstance->... | Get the function definition from the specified path. endregionregion - loads a node definition from the XML file. region Private functions This function creates a version object from the nodes connectors and notes. | Convert.ToInt16 and then immediately case it to a PortType. That's not usually needed with enums, is there something odd about portTypeAttrib.Value? |
@@ -15,10 +15,15 @@ class OpenidConnectRedirector
@redirect_uri = redirect_uri
@service_provider = service_provider
@state = state
- @errors = errors
+ @errors = errors || ActiveModel::Errors.new(self)
@error_attr = error_attr
end
+ def valid?
+ validate
+ errors.blank?
+ end
+
... | [OpenidConnectRedirector->[validated_input_redirect_uri->[redirect_uri_matches_sp_redirect_uri?]]] | Initialize a new instance of the object. | CodeClimate is complaining here but I don't think there's a straightforward solution (especially since we need the reference to `self`...which we can't get until after the object is initialized....) so I think we should just add this to the `.reek` to ignore. Sorry! |
@@ -68,7 +68,7 @@ public class RestClientsContainer {
public RestClientData(List<RestClientInfo> clients, List<PossibleRestClientInfo> possibleClients) {
this.clients = clients;
- this.possibleClients = possibleClients;
+ this.possibleClients = possibleClients; // TODO: pre... | [RestClientsContainer->[getClientData->[getClientData]]] | This class is used to provide a list of rest clients. | this is not related to this PR, I just didn't want to lose this TODO |
@@ -1312,6 +1312,9 @@ public class UserManagerImpl implements UserManager, MultiTenantUserManager, Adm
checkPasswordValidity(userModel);
String schema = dirService.getDirectorySchema(userDirectoryName);
+ // If trying to create the user with groups, check that the groups exist
+ ... | [UserManagerImpl->[handleEvent->[invalidateAllPrincipals,invalidatePrincipal],notifyUserChanged->[notifyRuntime,notifyCore],getTopLevelGroups->[getTopLevelGroups],getUsersInGroupAndSubGroups->[getUsersInGroupAndSubGroups,appendSubgroups],updateGroup->[notifyGroupChanged,getGroupId,updateGroup],getPrincipalUsingCache->[... | create a new user in the user directory. | Formatting: only one empty line. |
@@ -15,7 +15,8 @@ except ImportError: # python < 3.3
from azure.core.credentials import AccessToken
from azure.identity._authn_client import AuthnClient
from six.moves.urllib_parse import urlparse
-from helpers import mock_response
+
+from helpers import mock_response, Request
def test_authn_client_deserializa... | [test_request_url->[mock_send->[validate_url],validate_url]] | test_authn_client_deserialization - test authentication Request a token. | I looked through the file, not seeing where `Request` is used, am I missing it? |
@@ -132,6 +132,11 @@ abstract class AbstractContactController extends RestController implements Class
$this->addTag($contact, $tag);
}
}
+
+ // process details
+ if (!is_null($request->get('bankAccounts'))) {
+ $this->processBankAccounts($contact, $request... | [AbstractContactController->[addUrl->[addUrl],processAddresses->[updateAddress,createAddress,checkAndSetMainAddress],addBankAccount->[addBankAccount],addNewContactRelations->[getContactManager],addTag->[addTag],addPhone->[addPhone],addEmail->[addEmail],addNote->[addNote],updateBankAccount->[getBooleanValue],addFax->[ad... | Adds all new relations for a contact. | Please don't start using `is_null`, we almost (?) always used `=== null` until now, which is also a little bit faster. |
@@ -771,7 +771,7 @@ func (s *objBlockAPIServer) ListBlock(request *pfsclient.ListBlockRequest, listB
func (s *objBlockAPIServer) isNotFoundErr(err error) bool {
// GG golang
- patterns := []string{"not found", "not exist", "NotFound", "NotExist", "404"}
+ patterns := []string{"not found", "not exist", "NotFound", ... | [splitKey->[getGeneration],readObjectIndex->[isNotFoundErr,readProto,setObjectIndex],GetTag->[GetObject],PutObject->[prettyObjPath],InspectTag->[InspectObject],indexPath->[indexDir],tagGetter->[isNotFoundErr,readProto],Close->[Close],Write->[Write],Read->[Read,Write],DeleteObjects->[InspectObject,isNotFoundErr],tagPath... | isNotFoundErr returns true if the error is a not found error. | added the windows error string matching |
@@ -313,6 +313,10 @@ class OpTest(unittest.TestCase):
idx = find_actual(sub_out_name, fetch_list)
actual = outs[idx]
actual_t = np.array(actual)
+ # paddle float16 is exposed to python as uint16 type
+ # reinterpret the... | [create_op->[__create_var__],OpTest->[_calc_output->[feed_var,append_input_output],check_output->[check_output_with_place],check_grad_with_place->[__assert_is_close,get_numeric_gradient,create_op],_create_var_descs_->[create_var],check_output_customized->[calc_output],_get_gradient->[create_var,_create_var_descs_,_nump... | Checks that the output of the operator has a missing missing value in place. Assert that actual and expect have the same lod as the last one. | Why not just expose to python as float16 directly? |
@@ -32,6 +32,8 @@ module.exports = class huobipro extends Exchange {
'fetchMyTrades': true,
'withdraw': true,
'fetchCurrencies': true,
+ 'fetchDeposits': 'emulated',
+ 'fetchWithdrawals': 'emulated',
},
'timeframe... | [No CFG could be retrieved] | Provides a base class for accessing the Huobi API. https://api. huobi. pro. | I think this property should be `true` because `fetchDeposits` actually is not emulated (same for `fetchWithdrawals`). |
@@ -1063,7 +1063,7 @@ def crop_to_bounding_box(image, offset_height, offset_width, target_height,
'image.resize_with_crop_or_pad',
v1=['image.resize_with_crop_or_pad', 'image.resize_image_with_crop_or_pad'])
@dispatch.add_dispatch_support
-def resize_image_with_crop_or_pad(image, target_height, target_width)... | [resize_image_with_pad_v2->[_resize_fn->[resize_images_v2],_resize_image_with_pad_common],encode_png->[encode_png],_resize_images_common->[_ImageDimensions],resize_bicubic->[resize_bicubic],crop_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],resize_image_with_crop_or_pad->[max_->[_is_tensor... | Resizes an image by either crops or pads the image or padding it evenly Internal function to find a missing control - flow control control - flow control control - flow control Resizes a single object. | There are two places in the docstring that need to be updated. Where it says `"...padding it evenly with zeros"` and `"...this op centrally pads with 0 along..."`. Could you update the description please? |
@@ -12,7 +12,7 @@
<% end %>
</div>
- <%= form_tag(admin_creator_settings_path, method: "post", class: "relative z-elevate p-4") do %>
+ <%= form_tag(admin_creator_settings_path, method: "post", class: "relative z-elevate p-4", "data-action": "submit->creator-settings#formValidations") do %>
<... | [No CFG could be retrieved] | Renders a single - user id that can be used to create a new user. Renders the n - node . | We should not be able to submit the form if the brand color contrast is low, this function caters for this. |
@@ -79,6 +79,10 @@ struct ik_rec {
umem_off_t ir_val_off;
};
+static char **test_group_args;
+int test_group_start;
+int test_group_stop;
+
#define IK_TREE_CLASS 100
#define POOL_NAME "/mnt/daos/btree-test"
#define POOL_SIZE ((1024 * 1024 * 1024ULL))
| [No CFG could be retrieved] | The btr_root struct is a wrapper around the btr_root struct. d_iov_t - key_iov - key list of entries in the. | sorry, these next two should also be static |
@@ -147,7 +147,7 @@ func NewApplication(config *orm.Config, ethClient eth.Client, advisoryLocker pos
jobSubscriber := services.NewJobSubscriber(store, runManager)
gasUpdater := services.NewGasUpdater(store)
promReporter := services.NewPromReporter(store.DB.DB())
- logBroadcaster := log.NewBroadcaster(ethClient, s... | [NewBox->[NewBox],ArchiveJob->[ArchiveJob],stop->[Stop],AwaitRun->[AwaitRun],Start->[Start],AddServiceAgreement->[AddJob],AddJob->[AddJob]] | NewServices returns a new instance of services. Service Creates an instance of the job. | `store.DB` ought to work fine |
@@ -511,7 +511,7 @@ class ContentDecodePolicy(SansIOHTTPPolicy):
:type response_encoding: str
"""
# Accept "text" because we're open minded people...
- JSON_REGEXP = re.compile(r'^(application|text)/([0-9a-z+.]+\+)?json$')
+ JSON_REGEXP = re.compile(r'^(application|text)/([0-9a-z+.-]+\+)?json$')
... | [HttpLoggingPolicy->[on_request->[_redact_query_param,_redact_header],on_response->[_redact_header]],ContentDecodePolicy->[deserialize_from_text->[_json_attemp],deserialize_from_http_generics->[deserialize_from_text],on_response->[deserialize_from_http_generics]]] | Initialize a new response_encoding lease. | Do we need to constrain the "middle" part? What about: ^(application|text)/(.+)?\+json$ (I didn't check where we are using the captures, but if we are, they also look odd since we are capturing the '+') |
@@ -3156,8 +3156,8 @@ public final class OzoneManager extends ServiceRuntimeInfoImpl
* All the classes which use/ store MetadataManager should also be updated
* with the new MetadataManager instance.
*/
- void reloadOMState(long newSnapshotIndex,
- long newSnapShotTermIndex) throws IOException {
+ vo... | [OzoneManager->[completeMultipartUpload->[buildAuditMessageForFailure,buildAuditMessageForSuccess,completeMultipartUpload],getVolumeInfo->[checkAcls,getVolumeInfo],loginOMUserIfSecurityEnabled->[loginOMUser],join->[join],hasAcls->[checkAcls,getRemoteUser],allocateBlock->[checkAcls,allocateBlock],deleteBucket->[checkAcl... | Reloads the OM state from the new snapshot index and the new snapshot index. | NIT: SnapShot -> Snapshot |
@@ -54,6 +54,7 @@ var (
_checkpointCommand,
_containerExistsCommand,
_contInspectSubCommand,
+ _cpCommand,
_diffCommand,
_exportCommand,
_createCommand,
| [AddCommand,Replace,SetUsageTemplate] | contInspectSubCommand is a command that displays the low level information on a container. init initializes the commands for the wait command. | @baude does this need to be added to mainCommands in cmd/podman/main.go too? |
@@ -2495,9 +2495,6 @@ func (c *Container) getOCICgroupPath() (string, error) {
}
return c.config.CgroupParent, nil
case c.config.CgroupsMode == cgroupSplit:
- if c.config.CgroupParent != "" {
- return c.config.CgroupParent, nil
- }
selfCgroup, err := utils.GetOwnCgroup()
if err != nil {
return "",... | [getHosts->[getRootNetNsDepCtr],makeBindMounts->[getRootNetNsDepCtr],generatePasswdAndGroup->[generateGroupEntry,generatePasswdEntry],generateSpec->[getUserOverrides],checkpoint->[exportCheckpoint,checkpointRestoreSupported],restore->[importCheckpoint,checkpointRestoreSupported,prepare,importPreCheckpoint]] | getOCICgroupPath returns the path to the cgroup that the container is in. | for this, if the container is joining a pod and `usePodCgroup` is specified, would that override this here or cause a conflict? |
@@ -60,6 +60,7 @@ class Hwloc(AutotoolsPackage):
depends_on('libpciaccess', when='+pci')
depends_on('libxml2', when='+libxml2')
depends_on('pkg-config', type='build')
+ depends_on('libpciaccess', when=(sys.platform != 'darwin'))
def url_for_version(self, version):
return "http://www.op... | [Hwloc->[url_for_version->[up_to],variant,depends_on,version]] | Return a URL for the given version of hwloc. | This line should be removed now, right? |
@@ -14,9 +14,9 @@ namespace Dynamo.PythonMigration
private ViewLoadedParams ViewLoaded { get; set; }
// A dictionary to mark Custom Nodes if they have a IronPython dependency or not.
- private static Dictionary<Guid, CNPythonDependency> CustomNodePythonDependency = new Dictionary<Guid, CNPyt... | [GraphPythonDependencies->[CustomNodesContainIronPythonDependency->[CustomNodesContainIronPythonDependency]]] | Creates an instance of the GraphPythonDependencies class. This method is called when a custom node is created. | is this internal for testing or so it can be called from some other assembly? |
@@ -194,6 +194,10 @@ func (pe *planExecutor) Execute(callerCtx context.Context, opts Options, preview
err = execError("failed", preview)
} else if canceled {
err = execError("canceled", preview)
+ } else if pendingReplaces != nil {
+ // If execution completed successfully, we may have leftover resources that w... | [reportError->[RawMessage,Errorf,Diag,Error],retirePendingDeletes->[RawMessage,Infoln,Infof,WithCancel,Ctx,V,ScheduleDeletes,ExecuteParallel,SignalCompletion,Errored,Err,Require,GeneratePendingDeletes,WaitForCompletion,Wait,URN],Execute->[generateEventURN,GenerateDeletes,ScheduleDeletes,Iterate,ExecuteParallel,refresh,... | Execute executes the plan This is the main loop of the planExecutor. It is the main loop of the plan Schedule deletes gives us a list of lists of steps that can safely be executed in parallel. error message for failure and cancellation. | > If execution completed successfully, we may have leftover resources that were pending replacment but never re-registered. How can this happen? |
@@ -1546,6 +1546,8 @@ export class AmpStoryPlayer {
this.pageScroller_ &&
this.pageScroller_.onTouchStart(event.timeStamp, coordinates.clientY);
+ this.rootEl_.classList.remove(CLASS_NO_NAVIGATION_TRANSITION);
+
this.element_.dispatchEvent(
createCustomEvent(
this.win_,
| [No CFG could be retrieved] | Dispatches end of stories event when appropiate. onTouchMove - AmpStudio touchmove. | I think we should find a better place to remove this class. There will be no animation if e.g.: 1. User navigates with a button to a different story that uses `go(1, null, {animate: false})` 2. User clicks* through a story and player navigates to the next story. 3. Expected: an animation will show 4. Actual: no animati... |
@@ -89,7 +89,7 @@ module.exports = yeoman.Base.extend({
if(file.isDirectory()) {
if(shelljs.test('-f', file.name + '/.yo-rc.json')) {
var fileData = this.fs.readJSON(file.name + '/.yo-rc.json');
- ... | [No CFG could be retrieved] | Displays a message to the user if the user has provided a non - empty name. This function checks if there is an application in the appsFolders array and if so removes it. | this check is not required if we set a baseName appropriately |
@@ -340,9 +340,9 @@ func getK8sMasterVars(cs *api.ContainerService) (map[string]interface{}, error)
} else {
masterVars["primaryAvailabilitySetName"] = ""
}
- masterVars["primaryScaleSetName"] = ""
masterVars["vmType"] = "standard"
}
+ masterVars["primaryScaleSetName"] = cs.Properties.GetPrimaryScaleSet... | [IsAvailabilitySets,AnyAgentUsesVirtualMachineScaleSets,AreAgentProfilesCustomVNET,IsCustomVNET,GetAgentVMPrefix,FormatBool,GetCustomEnvironmentJSON,IsAzureStackCloud,HasStorageAccountDisks,IsStorageAccount,IsWindows,IsVirtualMachineScaleSets,Bool,PrivateJumpboxProvision,IsHostedMasterProfile,HasWindows,IsFeatureEnable... | This function is used to generate a list of variables that can be used to configure a master Generates a kubeconfig for the Master. | We can just set this variable using the getter now that the getter returns an empty string if the primary agent pool is not vmss. |
@@ -6,6 +6,16 @@ import logging
import time
from azure.core.polling import PollingMethod
+from azure.keyvault.certificates import KeyVaultCertificate, CertificateOperation
+
+try:
+ from typing import TYPE_CHECKING
+except ImportError:
+ TYPE_CHECKING = False
+
+if TYPE_CHECKING:
+ # pylint: disable=ungrou... | [CreateCertificatePoller->[run->[_update_status]]] | Create a class that polls for a key vault certificate. | We can move these inside the `if TYPE_CHECKING:` block since they're only referenced in typehints |
@@ -167,12 +167,17 @@ function filterWhitelistedLinks(markdown) {
* @return {Promise} Used to wait until the async link checker is done.
*/
function runLinkChecker(markdownFile) {
+ // `-TEMPLATE` is a common suffix for files that may have interpolation
+ // tokens, possibly as part of their links. So we skip th... | [No CFG could be retrieved] | Runs a single check on a given markdown file. | Can the interpolation tokens in the template file be surrounded by backticks? If so, this exemption will become unnecessary. |
@@ -125,8 +125,7 @@ public class UserActionPanel extends ActionPanel {
int row = 0;
final JScrollPane choiceScroll = new JScrollPane(getUserActionButtonPanel(userChoiceDialog));
choiceScroll.setBorder(BorderFactory.createEtchedBorder());
- choiceScroll.setPreferredSize(getUserActionScrollPaneP... | [UserActionPanel->[getOtherPlayerFlags->[getOtherPlayers,getFlag,JPanel,JLabel,add,ImageIcon],getUserActionScrollPanePreferredSize->[getPreferredSize,getScreenSize,Dimension],getActionButtonText->[getCostPu,getText,getButtonText],actionPerformed->[GridBagConstraints,getUserActionScrollPanePreferredSize,pack,of,invokeLa... | Display a dialog with a dialog with a user choice button. | This line change alone should already fix the issue |
@@ -50,8 +50,10 @@ import org.apache.gobblin.util.SerializationUtils;
public class SingleTask {
private static final Logger _logger = LoggerFactory.getLogger(SingleTask.class);
+ public static final String MAX_RETRY_WAITING_FOR_INIT_KEY = "maxRetryBlockedOnTaskAttemptInit";
+ public static final int DEFAULT_MAX... | [SingleTask->[getJobBroker->[build],getConfigFromJobState->[getProperties,parseProperties],getWorkUnits->[flattenWorkUnits,newArrayList,getName,get,endsWith,getWorkUnits,addAll,add],run->[cleanMetrics,setProp,debug,getJobBroker,build,getConfigFromJobState,runAndOptionallyCommitTaskAttempt,info,getKey,defaultScopeInstan... | Produces a standalone unit that can be used to run a single task. This method is the main entry point for the job. It is the entry point. | Why do we have to eagerly initialize workunits? |
@@ -135,14 +135,14 @@ public class CommandAwareRpcDispatcher extends RpcDispatcher {
* @param recipients Guaranteed not to be null. Must <b>not</b> contain self.
*/
public RspList<Object> invokeRemoteCommands(final List<Address> recipients, final ReplicableCommand command, final ResponseMode mode, final ... | [CommandAwareRpcDispatcher->[handle->[isValid],executeCommandFromLocalCluster->[handle],processCalls->[marshallCall,constructMessage],FutureCollator->[watchFuture->[SenderContainer]],broadcastRemoteCommands->[invokeRemoteCommands],processSingleCall->[marshallCall,constructMessage]]] | Invoke a command on a list of remote nodes. | Seems to me like you removed the anycasting param because it is not used. It would make sense to have it in a different commit, as it is not related to this change change and makes review easier. For the future .. ;) +1 for cleaning the code as you see issues! |
@@ -67,4 +67,15 @@ public class QueuedQueryMetadata extends QueryMetadata {
public int hashCode() {
return Objects.hash(rowQueue, super.hashCode());
}
+
+ public void setLimitHandler(final OutputNode.LimitHandler limitHandler) {
+ getOutputNode().setLimitHandler(limitHandler);
+ }
+
+ private class Sta... | [QueuedQueryMetadata->[hashCode->[hashCode],equals->[equals]]] | Returns hashCode of this object. | Not for this PR, but this may be worth implementing for the `PersistentQueryMetadata` as well, and then update the metrics for the number of persistent queries, if a query stops running all of a sudden. |
@@ -41,10 +41,10 @@ import org.nuxeo.ecm.core.schema.types.Type;
* @author <a href="mailto:bjalon@nuxeo.com">Benjamin JALON</a>
* @since 5.7
*/
-@Operation(id = AddEntryToMultiValuedProperty.ID, category = Constants.CAT_DOCUMENT, label = "Add entry into multi-valued metadata", description = "Add value into the fi... | [AddEntryToMultiValuedProperty->[addValueIntoList->[add,contains,addAll],run->[checkFieldType,getValue,getProperty,save,addValueIntoList,saveDocument,getType,setValue,asList]]] | Method to add a single entry into a multi - valued field. Reads the n - ary value from the database. | You must keep the old alias as well. |
@@ -23,6 +23,8 @@ const globby = require('globby');
const {gitCommitterEmail} = require('../common/git');
const {isTravisBuild, travisJobNumber} = require('../common/travis');
+const argv = require('minimist')(process.argv.slice(2));
+
const TEST_SERVER_PORT = 8081;
const COMMON_CHROME_FLAGS = [
| [No CFG could be retrieved] | Creates an environment hash for a given node ID. This is a hack to prevent the cache busting and retransforming of the file. | nit: Move to line 18 so it can live with the other require statements. |
@@ -89,7 +89,7 @@ public class State implements WritableShim {
* @param otherState the other {@link State} instance
*/
public void addAll(State otherState) {
- addAll(otherState.properties);
+ addAll(otherState.specProperties);
}
/**
| [State->[contains->[getProperty],write->[getProperty],getPropAsShort->[getProp],appendToListProp->[setProp],getPropAsShortWithRadix->[getProp],appendToSetProp->[addAll,setProp],getPropAsBoolean->[getProp],getPropAsSet->[getProp],getPropAsCaseInsensitiveSet->[getProp],getPropAsJsonArray->[getProp],getPropAsLong->[getPro... | add all properties from another state. | I think we should propagate the otherState's commonProps to this state's specProps if they are not already in this state's commonProps. |
@@ -1285,6 +1285,13 @@ class Jetpack_Core_Json_Api_Endpoints {
* @return array|WP_Error Result from WPCOM API or error.
*/
public static function scan_state() {
+
+ if ( ! isset( $_GET['_cacheBuster'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Recommended
+ $scan_state = get_site_transient( '... | [Jetpack_Core_Json_Api_Endpoints->[remote_authorize->[remote_authorize],build_connect_url->[build_connect_url]]] | Get the current scan state. | Should we use `get_transient` here, since our products are per site, not per network? Same below for `set_site_transient`? |
@@ -247,7 +247,7 @@ class MessageHandler:
balance_proof = balanceproof_from_envelope(message)
lock_expired = ReceiveLockExpired(
sender=balance_proof.sender,
- balance_proof=balance_proof,
+ balance_proof=balance_proof, # type: ignore
secrethash=message... | [MessageHandler->[handle_message_withdrawrequest->[ReceiveWithdrawRequest,CanonicalIdentifier],handle_message_secretrequest->[ReceiveSecretRequest],handle_message_withdraw_confirmation->[ReceiveWithdrawConfirmation,CanonicalIdentifier],handle_message_unlock->[balanceproof_from_envelope,ReceiveUnlock],handle_message_del... | Handle a LockExpired message. | What is the error you're getting without this ignore? |
@@ -32,6 +32,7 @@ namespace Microsoft.NET.HostModel.Bundle
public readonly Manifest BundleManifest;
private readonly TargetInfo Target;
private readonly BundleOptions Options;
+ private readonly bool _macosCodesign;
public Bundler(string hostName,
str... | [Bundler->[ShouldExclude->[ShouldExclude],FileType->[IsAssembly],AddToBundle->[ShouldCompress],GenerateBundle->[IsHost,AddToBundle,ShouldExclude,ShouldIgnore]]] | Creates a Bundler which bundles a managed app and its dependencies into the host native binary. NetCoreApplicationCompatMode - > NetCoreApplicationCompatMode. | Nit: I know the style in the file is weird, but I would prefer for it to be consistent over any specific style (or we could change the style for everything in the file to be consistent) |
@@ -9,6 +9,7 @@ import (
// OptionalFeatures is a struct to enable/disable optional features
type OptionalFeatures struct {
// FeatureName bool
+ BackpressureEnabled bool
}
var (
| [Do,New] | featureflags import imports the featureflags package into the features struct. | The flag should be just the feature name without Enabled/Disabled. Could you change this to `Backpressure` |
@@ -45,7 +45,7 @@ import org.springframework.util.StringUtils;
*
* @since 2.0
*/
-@ManagedResource
+@IntegrationManagedResource
public class MessageHistoryConfigurer implements SmartLifecycle, BeanFactoryAware {
private final Log logger = LogFactory.getLog(this.getClass());
| [MessageHistoryConfigurer->[start->[getTrackableComponents],stop->[getTrackableComponents,stop],setComponentNamePatternsString->[setComponentNamePatterns]]] | This class imports all the components and registers the message history. Sets the component name patterns. | And why have you removed `@ManagedResource` here ? I may not be interested in handlers/channels metrics, but want to manage this component from JMX too |
@@ -71,7 +71,7 @@ class PythonNativeCode(Subsystem):
def _native_target_matchers(self):
return {
Exactly(PythonDistribution): self.pydist_has_native_sources,
- Exactly(NativeLibrary): self.native_target_has_native_sources,
+ SubclassesOf(NativeLibrary): self.native_target_has_native_sources,
... | [ensure_setup_requires_site_dir->[SetupRequiresSiteDir],PythonNativeCode->[check_build_for_current_platform_only->[get_targets_by_declared_platform,_any_targets_have_native_sources,PythonNativeCodeError]]] | Checks if any native sources are satisfied by any of the requirements. | In the current world, all public targets exposed by register.py's can be subclassed for purposes you-know-not making Exactly on these Target types probably never advised. It seems like you'd stll want to operate on a `class FoursquarePythonDistribution(PythonDistribution)` that might add information used by a Foursquar... |
@@ -17,7 +17,7 @@
angular.module('zeppelinWebApp')
.controller('ParagraphCtrl', function($scope,$rootScope, $route, $window, $element, $routeParams, $location,
- $timeout, $compile, websocketMsgSrv) {
+ $timeout, $compile, websocketMs... | [No CFG could be retrieved] | A directive that initializes the n - th element in the main scope. function to render the data in the last data. | Where is Notification defined? |
@@ -54,6 +54,8 @@
#include "quantum.h"
#include <util/atomic.h>
#include "outputselect.h"
+#include "velocikey.h"
+#include "rgblight_reconfig.h"
#ifdef NKRO_ENABLE
#include "keycode_config.h"
| [No CFG could be retrieved] | The function that is used to configure a specific keycode. Get the names of the objects in the header that are not part of the Ada -. | This should be ifdef'd I think. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.