patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -4,12 +4,13 @@
frappe.ui.form.on("Email Queue", {
refresh: function(frm) {
if (["Not Sent","Partially Sent"].indexOf(frm.doc.status)!=-1) {
- frm.add_custom_button("Send Now", function() {
+ let button = frm.add_custom_button("Send Now", function() {
frappe.call({
method: 'frappe.email.doctype.e... | [No CFG could be retrieved] | Adds custom buttons to the email queue. | Just a question: Variables declared using `let` are not not initialised until their definition is evaluated. So why does using `button` while initialising it work? :exploding_head: |
@@ -70,6 +70,8 @@ module Annict
# rubocop:enable Metrics/LineLength
r301 %r{\A/track}, "/"
+ r301 /\A(.*)\z/, "#{ENV['ANNICT_JP_URL']}$1", host: Rails.env.development? ? "annict.jpd" : "annict.jp"
+
maintenance_file = File.join(Rails.root, "public", "maintenance.html")
send_file /(.*)... | [Application->[allow,enforce_available_locales,queue_adapter,join,send_file,insert_after,freeze,root,factory_bot,system_tests,r301,exist?,generators,autoload_paths,origins,eager_load_paths,resource,default_locale,test_framework,insert_before,proc,strip,available_locales,load_defaults],groups,each,require_relative,requi... | Rails 5. 5 The middleware for the middleware that can be used to configure the middleware for the middleware. | Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division. |
@@ -13,6 +13,6 @@ p = Plot(plot_width=150, plot_height=HEIGHT,
for i, style in enumerate(ARROW_HEADS):
p.add_layout(Arrow(x_start=0.2, y_start=i, x_end=0.2, y_end=i, end=style()))
- p.add_layout(Label(x=0.2, x_offset=20, y=i, text=[style.__name__], text_baseline='middle', text_align='left'))
+ p.add_layou... | [Range1d,show,output_file,Label,len,Arrow,add_layout,Plot,enumerate,style] | Add arrow and label to the plot. | I also added this small docs example fix. Arrow `text` is no longer a `DataSpec` |
@@ -19,8 +19,10 @@ class Canu(MakefilePackage):
version('1.5', sha256='06e2c6d7b9f6d325b3b468e9c1a5de65e4689aed41154f2cee5ccd2cef0d5cf6')
depends_on('gnuplot', type='run')
- depends_on('jdk', type='run')
+ depends_on('java', type='run')
depends_on('perl', type='run')
+ # build fail when using ... | [Canu->[install->[working_dir,make,format],patch->[filter_file,format],depends_on,version]] | Patch canu. pl with the new one. | Does `canu` depend on boost or vendor boost? I can't find a reference that says you need to install boost as a dependency. |
@@ -267,7 +267,7 @@ static int _circle_events_button_pressed(struct dt_iop_module_t *module, float p
else if(!gui->creation_continuous)
dt_masks_set_edit_mode(crea_module, DT_MASKS_EDIT_FULL);
dt_masks_iop_update(crea_module);
- gui->creation_module = NULL;
+ // gui->creation_module = N... | [float->[sinf,MIN,cosf,dt_alloc_align_float],GSList->[dt_mouse_action_create_simple,_],void->[g_list_next,g_list_append,cairo_move_to,cairo_arc,dt_conf_get_float,cairo_save,dt_masks_calculate_source_pos_value,fabs,dt_conf_get_and_sanitize_float,MIN,memcpy,malloc,cairo_set_line_cap,dt_masks_point_in_form_near,dt_draw_se... | _circle_events_button_pressed - called from the mouse button handler. private void calc_center_value ( void add a missing - point - group circle add some stuff This method is called from the init method of the component. | should be removed |
@@ -152,6 +152,7 @@ public class StreamerUtil {
// actually Flink cleaning is always with parallelism 1 now
.withCleanerParallelism(20)
.archiveCommitsWith(conf.getInteger(FlinkOptions.ARCHIVE_MIN_COMMITS), conf.getInteger(FlinkOptions.ARCHIVE_MAX_COMMITS))... | [StreamerUtil->[getHadoopConf->[getHadoopConf],initTableIfNotExists->[getHadoopConf],createWriteClient->[getHadoopConf,getHoodieClientConfig],getSourceSchema->[getSourceSchema]]] | Get the Hoodie configuration from the given configuration. MAX_SIZE is the maximum size of the log file in bytes. | Isn't `HoodieCleaningPolicy.KEEP_LATEST_COMMITS` the default value ? |
@@ -927,6 +927,7 @@ class DBA
*/
public static function transaction() {
if (!self::performCommit()) {
+ /// @TODO Shouldn't we better prevent this incorrect invocation rather than failing silently?
return false;
}
| [DBA->[lastInsertId->[lastInsertId],close->[close],fetch->[fetch],rollback->[rollback],columnCount->[columnCount]]] | Begin a transaction. | We are committing here for safety precautions, because you can only start a new transaction when you aren't in one. This should not happen. But failing at this stage would create much more harm than just silently ignoring it. |
@@ -1217,7 +1217,7 @@ namespace DSCore
/// </summary>
/// <param name="list">List to permute.</param>
/// <param name="length">Length of each permutation.</param>
- /// <returns name="perm">Permutations of the list of the given length.</returns>
+ /// <returns name="permutations... | [List->[IndexOf->[IndexOf],FirstIndexOf->[IndexOf],Count->[Count],DistinctComparer->[Eq->[Equals]],GetCombinations->[Singleton,GetCombinations],GetPermutations->[Singleton,GetPermutations],FilterByMaskHelper->[FilterByMaskHelper],IndexInList->[Count],CountBool->[CountBool],Contains->[Contains],AllTrue->[AllTrue],LastIt... | Get the permutations of the given list. | Include return type in description? |
@@ -276,8 +276,12 @@ func (pkg *pkgContext) inputType(t schema.Type, optional bool) string {
var typ string
switch t := t.(type) {
case *schema.EnumType:
+ var enumType string
+ if optional {
+ enumType = "*"
+ }
// Since enum type is itself an input
- return pkg.tokenToEnum(t.Token)
+ return enumType +... | [genResource->[getConstValue,plainType,outputType,getDefaultValue,inputType],tokenToEnum->[tokenToPackage],genType->[genInputTypes,genOutputTypes,genPlainType,detailsForType,tokenToType],plainType->[tokenToType,tokenToResource,plainType],genFunction->[genPlainType],outputType->[tokenToType,tokenToResource,outputType],g... | inputType returns the input type for the given type. nope - if we need to do this in a way that s not a problem. | Nit: `enumType` doesn't feel like an obvious name. Is it more of a `modifier` thing, or `prefix`, or `nullable`? |
@@ -102,6 +102,18 @@ public class FindInFilesDialog extends ModalDialog<FindInFilesDialog.State>
return this.filePatterns;
}-*/;
+ public final String[] getExcludeFilePatterns()
+ {
+ return JsUtil.toStringArray(getExcludeFilePatternsNative());
+ }
+
+ private native JsArr... | [FindInFilesDialog->[setState->[gitIgnore,isCaseSensitive,isRegex,getFilePatterns,getQuery,getPath,manageFilePattern],setDirectory->[getPath],collectInput->[createState,getPath]]] | Returns a native version of the file patterns that are used to match the results of the filter. | Should this be `[]` since the function returns an array? |
@@ -214,16 +214,8 @@ class WPSEO_Configuration_Page {
* @return Yoast_Notification
*/
private static function get_notification() {
- $message = __( 'The configuration wizard helps you to easily configure your site to have the optimal SEO settings.', 'wordpress-seo' );
- $message .= '<br/>';
- $message .= sp... | [WPSEO_Configuration_Page->[remove_notification->[remove_notification],add_notification->[add_notification],show_wizard->[enqueue_assets]]] | Get the notification object. | Although it appears we don't have a PHPCS rule to enforce it, I think we have some coding style best practice to align this kind of things for better readability. |
@@ -602,6 +602,8 @@ public class StreamingModeExecutionContext extends DataflowExecutionContext<Step
.setTimer(
StateNamespaces.window(windowCoder, window),
timerId,
+ timerId,
+ cleanupTime,
cleanupTime,
TimeDomain.EVENT_T... | [StreamingModeExecutionContext->[fetchSideInput->[fetchSideInput],StreamingModeSideInputReader->[isEmpty->[isEmpty],contains->[contains],of->[StreamingModeSideInputReader]],flushState->[getSerializedKey,flushState],StepContext->[start->[getSerializedKey,getWorkToken],addBlockingSideInputs->[addBlockingSideInput],getSid... | Sets a state cleanup timer. | default to empty string |
@@ -388,3 +388,16 @@ func (w *Worker) subtaskFunc(subtaskKey string, processFunc ProcessFunc) subtask
}
}
}
+
+// TaskCount returns how many subtasks are in the queue and how many are claimed.
+func (w *Worker) TaskCount(ctx context.Context) (int64, int64, error) {
+ subTasks, rev, err := w.subtaskCol.ReadOnly(ct... | [taskFunc->[subtaskFunc,Unmarshal,ReadOnly,Close,Watch,WatchOne,runSubtask,Err,Done],RunSubtasksChan->[AddInt64,Printf,createSubtask,LoadInt64,deleteSubtasks,New,WithCancel,Go,ReadOnly,Unmarshal,WatchOneF,Err,runSubtaskBlock,Is,Wait],subtaskFunc->[Printf,ReadWrite,Error,NewSTM,Claim,IsErrNotFound,Get,Is,Err,Update],del... | subtaskFunc returns a function that can be used to create a subtask that runs on This function is called by the processFunc in the subtask callback. It will process the. | There should probably be names for the 2 int64s, so they can be distinguished by looking at the signature. Use `_` for the error. |
@@ -0,0 +1,6 @@
+/**
+ * The namespace of the i18n/translation keys.
+ *
+ * @type {string}
+ */
+export const _TNS = 'deepLinking';
| [No CFG could be retrieved] | No Summary Found. | Do you think this is useful to have as a constant? I ask because we haven't worried about this before. You might be better off just making this a function instead, too. |
@@ -66,10 +66,10 @@ class BooleanAttribute extends WebViewAttribute {
}
setValue (value) {
- if (!value) {
- return this.webViewImpl.webviewNode.removeAttribute(this.name)
+ if (value) {
+ this.webViewImpl.webviewNode.setAttribute(this.name, '')
} else {
- return this.webViewImpl.webvi... | [No CFG could be retrieved] | Creates a property on the WebViewNode object and adds it to the WebViewNode object Attribute that specifies whether the webview should be autosized. | Looks like the behavior didn't change in the refactor, but it seems weird. Why would the presence of a `value` mean setting the name attribute to an empty string? |
@@ -173,10 +173,12 @@ public class KeycloakAuthenticationPlugin implements NuxeoAuthenticationPlugin,
*/
private Set<String> getRoles(AccessToken token, String keycloakNuxeoApp) {
Set<String> allRoles = new HashSet<>();
- Set<String> roles = token.getRealmAccess().getRoles();
- if (rol... | [KeycloakAuthenticationPlugin->[getRoles->[getRoles]]] | Get the roles from the realm and resource. | Another possible variant, to avoid calling `realmAccess.getRoles()` twice in case it's costly (I don't know), is: Set<String> roles; if (realmAccess != null && (roles = realmAccess.getRoles()) != null) { allRoles.addAll(roles); } Up to you if you want to change it. |
@@ -270,10 +270,10 @@ public interface Log extends BasicLogger {
@Message(value = "Unexpected error in AsyncStoreCoordinator thread. AsyncCacheWriter is dead!", id = 55)
void unexpectedErrorInAsyncStoreCoordinator(@Cause Throwable t);
- @SuppressWarnings("deprecation")
- @LogMessage(level = ERROR)
- @Me... | [No CFG could be retrieved] | Unexpected error in AsyncStoreCoordinator thread. | Should we just remove this? Or are we reserving log message ids? |
@@ -252,6 +252,9 @@ const (
// DefaultAzureStackFaultDomainCount set to 3 as Azure Stack today has minimum 4 node deployment.
DefaultAzureStackFaultDomainCount = 3
+
+ // DefaultAzureStackEtcdDiskSizeGT10Nodes = size for Kubernetes master etcd disk volumes in GB if > 10 nodes
+ DefaultAzureStackEtcdDiskSizeGT10No... | [No CFG could be retrieved] | This function returns a variable that can be used to define the default values for the given node. | the naming "GT10Nodes" doesn't really apply here since there's only one default size |
@@ -100,11 +100,15 @@ def find(f: Callable[[T], bool], seq: Sequence[T]) -> T:
class ASTConverter(ast35.NodeTransformer):
- def __init__(self, pyversion: Tuple[int, int], custom_typing_module: str = None) -> None:
+ def __init__(self,
+ pyversion: Tuple[int, int],
+ is_stub,
+... | [TypeConverter->[visit_Str->[parse_type_comment],visit_List->[visit_list],visit_Tuple->[visit_list],visit_Subscript->[visit_list]],parse->[parse],ASTConverter->[visit_Delete->[visit_list],visit_While->[as_block],visit_If->[as_block],visit_BinOp->[from_operator],visit_ClassDef->[stringify_name,find,visit_list,fix_functi... | Initialize the object. | Need type annotation here. |
@@ -11,8 +11,11 @@ from utils.decorators import (
@pytest.mark.smoke
+@pytest.mark.login
@pytest.mark.nondestructive
def test_dashboard(base_url, selenium):
+ admin = AdminLogin(selenium, base_url).open()
+ admin.login_new_user()
page = DashboardPage(selenium, base_url).open()
first_row = page.fi... | [test_dashboard_open_details->[open_first_details,DashboardPage,wait_for_first_details_diff_displayed],test_dashboard_in_mm->[DashboardPage],test_macros_search_all_by_form->[MacroDashboardPage,parse_qs,xfail,manual_search,urlparse],test_dashboard->[DashboardPage],test_macros_search_en_by_form->[MacroDashboardPage,parse... | Test if dashboard is present. | Nice catch! It would have been easy to forget this! |
@@ -29,11 +29,16 @@ import com.google.inject.Inject;
import com.google.inject.name.Named;
import com.linkedin.restli.common.ComplexResourceKey;
import com.linkedin.restli.common.EmptyRecord;
+import com.linkedin.restli.common.HttpStatus;
import com.linkedin.restli.server.CreateResponse;
import com.linkedin.restli.... | [FlowConfigsResource->[getHeaders->[getValue,entrySet,getKey,Properties,contains,put],create->[createFlowConfig],get->[setFlowName,getFlowName,getFlowGroup,getFlowConfig],update->[setFlowName,getFlowName,getFlowGroup,updateFlowConfig],delete->[getHeaders,setFlowName,deleteFlowConfig,getFlowGroup,getFlowName],getLogger,... | Produces a resource which can be used to manage a complex resource. Provides a resource that can be used to retrieve a single resource. | Why is the name not matching the value? Is the idea that this resource handler is a config generator? |
@@ -53,6 +53,12 @@ const REPLACED_MEDIA_ATTRIBUTE = 'replaced-media';
const DOM_MEDIA_ELEMENT_ID_PREFIX = 'i-amphtml-media-';
+/**
+ * @const {string}
+ */
+const POOL_MEDIA_ELEMENT_PROPERTY_NAME = 'i-amphtml-media-pool';
+
+
/**
* @const {!Array<string>}
*/
| [No CFG could be retrieved] | Provides a function to export an element with a specific number of elements. A class that exports a list of media elements that can be allocated by the pool. | This looks like a CSS class. AFAIK the convention for element props is `__AMP__FOO__`. See action-impl.js for an example. |
@@ -161,6 +161,9 @@ func NewCmdMigrateAPIStorage(name, fullName string, f *clientcmd.Factory, in io.
Long: internalMigrateStorageLong,
Example: fmt.Sprintf(internalMigrateStorageExample, fullName),
Run: func(cmd *cobra.Command, args []string) {
+ apiextensioninstall.Install(legacyscheme.GroupFactoryRegist... | [save->[Raw,Body,Error,Infof,Do,Resource,DefaultRetriable,Name,V,NamespaceIfScoped,Get,Refresh,Put],Validate->[Validate],Run->[Visit,Visitor],Complete->[Complete],Examples,Sprintf,LongDesc,Validate,NewString,CheckErr,Run,Complete,Bind] | Commands for managing the stored version of API objects. Complete - completes the migration. | need a follow up to figure out what we need to do to revert this... migrate shouldn't need registered types... it reads into unstructured and puts back |
@@ -168,6 +168,7 @@ func (pe *planExecutor) Execute(callerCtx context.Context, opts Options, preview
// Set up a step generator for this plan.
pe.stepGen = newStepGenerator(pe.plan, opts, updateTargetsOpt, replaceTargetsOpt)
+ pe.plan.current = pe.stepGen.resourceStates
// Retire any pending deletes that are ... | [retirePendingDeletes->[reportExecResult],Execute->[reportExecResult,checkTargets,reportError],refresh->[reportExecResult,checkTargets]] | Execute executes the plan Iterate over the source and return a cancellable context. This function handles the case where the source iterator sends us an error and we should continue processing This function is called by the executor to check if all the steps have completed and if so. | a couple of things: 1. if the stepGen already gives access to the resourceStates, and the executor gives access to the stepGen, why do we need to place this on the plan itself? 2. i presume this means that resourceStates is mutable and changes over time. Is htat ok? are there any concerns about the semantics of that as... |
@@ -745,12 +745,14 @@ Loop:
break Loop
default:
}
- if err := proto.Unmarshal(reader.Record(), record); err != nil {
+ m, err := decodeRecord(reader.Record(), WALRecordType1, record)
+ if err != nil {
// We don't return here in order to close/drain all the channels and
// make sure all goroutines e... | [Log->[Log],performCheckpoint->[Stop,Log],run->[Stop,Log],checkpointSeries->[Log],Log] | END of function ProcessWALSamples break - Finds the last in the record. | Same here, an error is returned so basically ignore this? |
@@ -314,12 +314,12 @@ def _make_sliced_model(model, stop_layer):
return new_model
-@pytest.mark.parametrize("model_name", ["densenet121", "densenet169", "densenet201", "densenet161"])
-def test_memory_efficient_densenet(model_name):
+@pytest.mark.parametrize("model_fn", [models.densenet121, models.densenet169,... | [test_detection_model->[check_out->[_get_expected_file,_assert_expected],_check_jit_scriptable,check_out,_check_input_backprop],test_googlenet_eval->[_check_jit_scriptable,_check_input_backprop],test_quantized_classification_model->[_check_jit_scriptable,_assert_expected,_check_fx_compatible],test_fasterrcnn_switch_dev... | Test memoryefficient densenet model. | Replace the `models.__dict__[model_name]` with a direct call to the `model_fn`. This means that now we could make calls to arbitrary methods, not necessarily from `models`. |
@@ -22,6 +22,8 @@ use Symfony\Component\HttpKernel\KernelInterface;
class CacheClearCommand extends BaseCacheClearCommand
{
+ protected static $defaultName = 'cache:clear';
+
/**
* {@inheritdoc}
*/
| [CacheClearCommand->[execute->[create,setContainer,get,getParameter,getEnvironment,success,getContainer,isDebug,comment]]] | Configure the node. | The names are now initialized lazy, that's why they have to be defined static (so that they are available at runtime). |
@@ -16,6 +16,7 @@ import AppRoutes from './routes';
export interface IAppProps {
location: any;
isAuthenticated?: boolean;
+ isAdmin: boolean;
<%_ if (enableTranslation) { _%>
currentLocale: string;
<%_ } _%>
| [No CFG could be retrieved] | The base component for all application - specific components. The object is a mapping of the state of the application and the dispatch to the. | I would like to do it differently so that role management is generic. So let me update this part |
@@ -222,6 +222,15 @@ if (!empty($conf->contrat->enabled)) {
if (is_array($extrafields->attribute_label) && count($extrafields->attribute_label)) $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."fichinter_extrafields as ef on (f.rowid = ef.fk_object)";
if (empty($conf->global->FICHINTER_DISABLE_DETAILS) && $atleastonefieldinlines... | [fetch,selectMassAction,fetch_object,jdate,order,getDocumentsLink,getNomUrl,initHooks,load,plimit,executeHooks,loadLangs,LibStatut,showCheckAddButtons,close,multiSelectArrayWithCheckbox,free,query,fetch_name_optionals_label,trans,num_rows,getOptionalsFromPost,selectarray,showFilterButtons,showdocuments] | Select all fields from the Fichinter table. WHERE f. entity IN ( intervention. | The relation fichinter - invoice is a n-n relation like most relation object-object defined by llx_element_element table. Adding such a left join will generate a lof of duplicate record. I recommand to NOT change the $sql and later, into the code that show the link, to do: if (! empty($arrayfields['inter.facref']['chec... |
@@ -906,7 +906,7 @@ public class ParquetIO {
}
}
- public void makeProgress() throws Exception {
+ public void makeProgress() throws IOException {
progress += approximateRecordSize;
if (progress > totalWork) {
throw new IOException("Making progress out of range")... | [ParquetIO->[Parse->[from->[from,build],withSplit->[build],withConfiguration->[build],expand->[getFilepattern,build]],Read->[withConfiguration->[build],expand->[getAvroDataModel,getEncoderSchema,getFilepattern,isSplittable,getProjectionSchema,withAvroDataModel,withProjection],withSplit->[build],populateDisplayData->[po... | Make progress. | Using a more specific exception in lieu of broad `Exception` |
@@ -35,7 +35,16 @@ static ESS_SIGNING_CERT *ess_SIGNING_CERT_new_init(X509 *signcert,
STACK_OF(X509) *certs);
static ESS_CERT_ID *ess_CERT_ID_new_init(X509 *cert, int issuer_needed);
static int ts_TST_INFO_content_new(PKCS7 *p7);
-static int ESS_add_signing_cert(PKC... | [TS_RESP_create_response->[TS_RESP_CTX_set_status_info,TS_RESP_CTX_add_failure_info,TS_RESP_CTX_set_status_info_cond],ASN1_OBJECT->[TS_RESP_CTX_set_status_info,TS_RESP_CTX_add_failure_info],TS_TST_INFO->[TS_RESP_CTX_set_status_info_cond],TS_RESP_CTX_set_status_info_cond->[TS_RESP_CTX_set_status_info],int->[TS_RESP_CTX_... | - - - - - - - - - - - - - - - - - - Default callback for response generation. | Inconsistent naming... why capitalize some function names and not others? |
@@ -1006,12 +1006,8 @@ def _prepare_mne_browse_epochs(params, projs, n_channels, n_epochs, scalings,
if title is None or len(title) == 0:
title = ''
fig = figure_nobar(facecolor='w', figsize=size, dpi=80)
- fig.canvas.set_window_title('mne_browse_epochs')
+ fig.canvas.set_window_title(t... | [_mouse_click->[plot_epochs_image,_pick_bad_epochs,_plot_window],_toggle_labels->[_plot_vert_lines],_epochs_navigation_onclick->[_draw_epochs_axes],_pick_and_combine->[pair_and_combine->[combine],pair_and_combine,combine],_prepare_epochs_image_axes->[_make_epochs_image_axis_grid],_plot_onkey->[_plot_traces,_plot_update... | Prepare the mne_browse_epochs window. Plots a block of nanoseconds for each channel. Plots the missing block block number on a given axis. Add a vertical scroll bar to the plot of the missing block. Create a plot of the n - block block - specific data. | FYI can be shorter as `title or "Epochs"` but no need to change |
@@ -1034,10 +1034,11 @@ namespace System.Windows.Forms
}
try
{
- byte[] bytes = new byte[size];
- stream.Position = 0;
- stream.Read(bytes, 0, size);
- Marshal.Copy(bytes, 0, ptr, size);
+ unsafe
+ ... | [DataObject->[SetData->[SetData],GetCanonicalFormatEtc->[GetCanonicalFormatEtc],ContainsFileDropList->[GetDataPresent],EnumDAdvise->[EnumDAdvise],DataStore->[GetData->[GetData,GetMappedFormats],SetData->[SetData],GetFormats->[GetFormats,GetMappedFormats,GetDistinctStrings],GetDataPresent->[GetFormats,GetDataPresent]],F... | SaveStreamToHandle saves a stream of bytes to a given handle. | This should be separate change |
@@ -49,6 +49,11 @@ namespace Microsoft.Xna.Framework
if (version >= 205 && CurrentPlatform.OS == OS.Windows && Debugger.IsAttached)
Sdl.SetHint("SDL_WINDOWS_DISABLE_THREAD_NAMING", "1");
+ // https://wiki.libsdl.org/SDL_DropEvent
+ // SDL_DROPTEXT, SDL_DROPBEGIN, an... | [SdlGamePlatform->[Present->[Present],EndScreenDeviceChange->[EndScreenDeviceChange],BeginScreenDeviceChange->[BeginScreenDeviceChange],BeforeInitialize->[BeforeInitialize],Dispose->[Dispose]]] | Creates a new instance of SdlGamePlatform. override OnPresentationChanged to handle the UI updates. | You don't need to check this, we already request that SDL version is 2.0.5 or higher few lines above. |
@@ -415,9 +415,16 @@ func TestSpecificKind(t *testing.T) {
}
}
+// Keep this in sync with the respective upstream set
+var nonInternalRoundTrippableTypes = sets.NewString("List", "ListOptions", "PodExecOptions", "PodAttachOptions")
+
+// TestTypes will try to roundtrip all OpenShift and Kubernetes stable api types... | [DeepCopy,ParseDockerImageReference,DeepEqual,FuzzerFor,ObjectGoPrintSideBySide,RandString,Encode,CodecFor,RandUint64,IsNotRegisteredError,ValidateUserName,UID,Fuzz,New,ValidateNamespaceName,NewIntOrStringFromString,Funcs,Errorf,Logf,TypeAccessor,SetKind,ValidateGroupName,Contains,TypeOf,Name,PkgPath,Int63,KnownTypes,D... | TestSpecificKind - Tests the object that serializes from and into the registry API. unexpectedly test for the types that are not a TypeMeta and can t be tested. | Sorry, this isn't obvious to me. These are somehow broken? Also, anything that needs to stay in sync should have a unit test to make sure it stays in sync. |
@@ -33,10 +33,10 @@ type Config struct {
Fifocache FifoCacheConfig `yaml:"fifocache,omitempty"`
// This is to name the cache metrics properly.
- Prefix string `yaml:"prefix,omitempty"`
+ Prefix string `yaml:"prefix,omitempty" doc:"hidden"`
// For tests to inject specific implementations.
- Cache Ca... | [RegisterFlagsWithPrefix->[RegisterFlagsWithPrefix]] | RegisterFlagsWithPrefix registers flags with a given prefix. | Why is this "hidden"? |
@@ -211,11 +211,11 @@ char *Rlist2String(Rlist *list, char *sep)
for (rp = list; rp != NULL; rp = rp->next)
{
- strcat(line, RlistScalarValue(rp));
+ strlcat(line, RlistScalarValue(rp), sizeof(line));
if (rp->next)
{
- strcat(line, sep);
+ strlcat(line... | [No CFG could be retrieved] | PackageActionFromString - returns the first package action found in the string s. Get the next signal from the list of known signal types. | I'm not cherry-picking this one because this is a very generic utility function and who knows what truncation can cause. Please add a `Log(ERR, "internal limit reached ...")` or similar in the case truncation happens. |
@@ -521,7 +521,7 @@ uint16_t max_display_update_time = 0;
if (currentScreen == lcd_status_screen)
doubleclick_expire_ms = millis() + DOUBLECLICK_MAX_INTERVAL;
}
- else if (screen == lcd_status_screen && currentScreen == lcd_main_menu && PENDING(millis(), doubleclick_expire_ms) &&... | [No CFG could be retrieved] | Private function for the main screen. Initialize custom characters that may be used in the current display. | How does babystepping behave when there's no active printing? Did we already add code to activate steppers when babysteps are received? (I think so ) |
@@ -254,6 +254,15 @@ def _get_activities(request, action):
def _get_items(action, addons):
+ if not isinstance(addons, (list, tuple)):
+ # MySQL 8.0.21 (and maybe higher) doesn't optimize the join with
+ # double # subquery the ActivityLog.objects.for_addons(addons) below
+ # would generate... | [submit_version_source->[_submit_source],upload_for_version->[upload],submit_version_details->[_submit_details],upload->[handle_upload],upload_detail->[get_fileupload_by_uuid_or_404,json_upload_detail],submit_version_upload->[_submit_upload],submit_addon_theme_wizard->[_submit_upload],submit_version_auto->[_submit_uplo... | Get all activity log items for a given action. | I read this as the same scenario we were talking about on chat (that I thought you'd decided against): > So it wouldn't really be recent activity on the addons, it'd be activity on addons that have recently been updated. expect that now rather being add-ons that have been updated in the past 6 months, it's the last 100... |
@@ -0,0 +1,14 @@
+from django.db import models
+
+from ..account.models import User
+from . import JobStatus
+
+
+class Job(models.Model):
+ status = models.CharField(
+ max_length=50, choices=JobStatus.CHOICES, default=JobStatus.PENDING
+ )
+ user = models.ForeignKey(User, related_name="jobs", on_delet... | [No CFG could be retrieved] | No Summary Found. | `user` is not descriptive about what it is. `created_by` instead (I assume)? |
@@ -240,7 +240,9 @@ function print_left_auguria_menu($db,$menu_array_before,$menu_array_after,&$tabM
print '<div class="menu_titre" id="menu_titre_logo"></div>';
print '<div class="menu_top" id="menu_top_logo"></div>';
print '<div class="menu_contenu" id="menu_contenu_logo">';
- print '<div class="center"><im... | [print_text_menu_entry_auguria->[trans],print_left_auguria_menu->[free,query,trans,num_rows,fetch_object,menuLeftCharger,add],print_auguria_menu->[menuTopCharger,add]] | Print left Auguria menu Menu of Bank Account Entry in bank account and accountancy journal for each bank account Doleto de la lista de journals This function is used to dump the menu. This function is used to display a menu in GET url. | I'd have used "Company logo" for the alt since this is supposed to give the alternative representation of the image for accessibility purposes. Keep the title though, it's perfect to define the actual action. |
@@ -106,13 +106,10 @@
* Set a liberal script execution time limit
* ------------------------------------------------------
*/
- if (function_exists("set_time_limit") AND @ini_get("safe_mode") == 0)
+ if (function_exists('set_time_limit') AND @ini_get('safe_mode') == 0
+ AND php_sapi_name() !== 'cli') // Do not ... | [_set_routing,fetch_method,_assign_to_config,_display_cache,_display,_set_overrides,mark,_call_hook,_remap,fetch_class,close,fetch_directory] | ----------------------------------------------------- Set the subclass_prefix of the class if it is not set in the config Create a new config object. | Needs to be && not AND |
@@ -23,6 +23,11 @@
* amp-intersection-observer-polyfill extension.
*/
+/** @typedef {typeof IntersectionObserver} */
+let IntObsConstructorDef;
+/** @typedef {function(IntObsConstructorDef)} */
+let IntObsUpgraderDef;
+
const UPGRADERS = '_upgraders';
const NATIVE = '_native';
const STUB = '_stub';
| [No CFG could be retrieved] | Checks if a window has a specific and if so loads it if it is. Webkit interactivity observer. | IMHO, having `{typeof IntersectionObserver}` inlined where it is needed is preferable. It is not reused in enough places to warrant an extra layer of indirection |
@@ -77,6 +77,16 @@ module SubmodulesHelper
root_path: gobierto_people_statements_path,
layout_title: t('gobierto_people.layouts.menu_subsections.statements'),
controller_name: 'person_statements'
+ },
+ departments: {
+ root_path: gobierto_people_departments_path,
+ la... | [welcome_submodule_active?->[size],officials_submodule_active?->[include?],budgets_elaboration_active?->[settings,gobierto_budgets_settings],active_submodules->[module_submodules,gobierto_people_settings,submodules_enabled],available_submodules->[t],submodule_controller_for->[to_sym],budgets_receipt_active?->[settings,... | Available submodules are defined in the menu that are used by the user. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -394,6 +394,12 @@ func (sc *scaleCmd) run(cmd *cobra.Command, args []string) error {
templateJSON["variables"].(map[string]interface{})[sc.agentPool.Name+"VMNamePrefix"] = sc.containerService.Properties.GetAgentVMPrefix(sc.agentPool, winPoolIndex)
}
if orchestratorInfo.OrchestratorType == api.Kubernetes {
+ ... | [drainNodes->[Wrapf,SafelyDrainNode,Sprintf,Duration,Errorf,HasPrefix],saveAPIModel->[LoadContainerServiceFromFile,SerializeContainerService,Split,SaveFile],validate->[LoadTranslations,NormalizeAzureRegion,Infoln,New,Usage,Wrap],run->[PrettyPrintArmTemplate,drainNodes,Errorln,GetAvailabilitySetFaultDomainCount,Values,N... | run runs the scale command This function is used to initialize a new cluster with the given parameters. ScaleDownVMs scale down VMs in the specified resource group. This function is used to generate a template for a single agent This method is used to deploy the template to the API model. | since AKS won't call this path, how will AKS scale work with this change? |
@@ -0,0 +1,17 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System;
+using System.Runtime.CompilerServices;
+
+public class Runtime_61629
+{
+ public static int Main() =>
+ Test(100, 200.0) + Test(Math.PI... | [No CFG could be retrieved] | No Summary Found. | does this fail on current main branch? |
@@ -1480,9 +1480,9 @@ class Relation
. Util::backquote($foreign_table) . '.'
. Util::backquote($foreign_display);
- $f_query_limit = ! empty($foreign_limit) ? $foreign_limit : '';
+ $f_query_limit = $foreign_limit ?: '';
- if (! ... | [Relation->[canAccessStorageTable->[queryAsControlUser],renameSingleTable->[queryAsControlUser,getRelationParameters],createPmaDatabase->[checkRelationsParam],setHistory->[queryAsControlUser,getRelationParameters],getDbComments->[queryAsControlUser,getRelationParameters],fixPmaTables->[getRelationParameters,getDefaultP... | Get the foreign data from the table. Query for a count of missing keys in the table. get foreign data. | Removing the not empty and using no defined condition really triggers me Could you add a real condition ? |
@@ -277,12 +277,16 @@ static void pd_free(OSSL_PROPERTY_DEFINITION *pd)
/*
* Convert a stack of property definitions and queries into a fixed array.
* The items are sorted for efficient query. The stack is not freed.
+ * This function also checks for duplicated names and returns an error if
+ * any exist.
*/
s... | [No CFG could be retrieved] | Parse a stack of OSSL property definitions and queries into a fixed array. Reads an OSSL property definition from the given string. | Would a better name for the variable be `prev_idx`? |
@@ -180,7 +180,8 @@ class Mesa(AutotoolsPackage):
@property
def libs(self):
for dir in ['lib64', 'lib']:
- libs = find_libraries('libGL', join_path(self.prefix, dir),
+ libs = find_libraries(['libGL', 'libOSMesa'],
+ join_path(self.prefix, dir),
... | [Mesa->[libs->[join_path,find_libraries],autoreconf->[which],configure_args->[append,SpecError,extend,format,join],depends_on,any_combination_of,patch,startswith,version,provides,variant]] | Find all libraries in the library directory. | @adamjstewart @v-dobrev is it intentional to return `None` here instead of an empty list? This seams to be generally problematic when setting up the build environment for dependent packages, see the PR description error message. |
@@ -342,6 +342,16 @@ BE_GlobalData::parse_args(long& i, char** av)
}
break;
+ case 'F':
+ // strip leading directories from generated #include lines.
+ if (0 == ACE_OS::strcasecmp(av[i], "-FilenameOnlyIncludes")) {
+ filename_only_includes_ = true;
+ break;
+ } else {
+ invalid_opti... | [No CFG could be retrieved] | Parse command line arguments and set compile flags. Check if the user specified option is a valid n - code block. | Please use a long option for something like this: `--filename-only-includes`. See `case '-':` below. |
@@ -173,13 +173,7 @@ public class ExtractorsResource extends RestResource {
@Valid @NotNull CreateExtractorRequest cer) throws NotFoundException {
checkPermission(RestPermissions.INPUTS_EDIT, inputId);
- final MessageInput input = persistedInputs.get(inputId);
- ... | [ExtractorsResource->[order->[order],create->[create],list->[create],buildExtractorFromRequest->[order,loadConverters],toSummary->[create]]] | Updates a single missing - field extractor on this node. write a warning message and return a summary of missing missing data. | Same `null` check here |
@@ -173,6 +173,8 @@ class TestTransformer(TestParallelExecutorBase):
def test_main(self):
if core.is_compiled_with_cuda():
self.check_network_convergence(transformer, use_cuda=True)
+ self.check_network_convergence(
+ transformer, use_cuda=True, enable_sequential_exe... | [prepare_batch_input->[__pad_batch_data],TestTransformer->[setUpClass->[prepare_batch_input]],transformer->[transformer]] | Test main method. | need to test both false and true |
@@ -945,7 +945,8 @@ static const char *_profile_names[] =
N_("standard color matrix"),
N_("enhanced color matrix"),
N_("vendor color matrix"),
- N_("alternate color matrix")
+ N_("alternate color matrix"),
+ N_("Prophoto RGB"),
};
static dt_colorspaces_color_profile_t *_create_profile(dt_colorspaces_col... | [No CFG could be retrieved] | Returns NULL if no such object exists. - - - - - - - - - - - - - - - - - -. | Bear with me, I'm no expert. But is it ok to have a Prophoto RGB color space into the list of matrix? I mean we don't have Adobe RGB here for example. |
@@ -84,7 +84,7 @@ define([
if (intersectionPoint) {
var v = intersectionPoint.subtract(this.origin);
- return new Cartesian2(this.xAxis.dot(v), this.yAxis.dot(v));
+ return new Cartesian3(this.xAxis.dot(v), this.yAxis.dot(v));
}
}
... | [No CFG could be retrieved] | Creates a list of points on the plane and returns them on the ellipsoid. | Why change this? On the plane, the point is defined by just `x` and `y`. `z` is not needed. |
@@ -87,13 +87,14 @@ bqueue_enqueue(bqueue_t *q, void *data, uint64_t item_size)
void *
bqueue_dequeue(bqueue_t *q)
{
- void *ret;
+ void *ret = NULL;
uint64_t item_size;
mutex_enter(&q->bq_lock);
while (q->bq_size == 0) {
cv_wait(&q->bq_pop_cv, &q->bq_lock);
}
ret = list_remove_head(&q->bq_list);
+ ASSE... | [No CFG could be retrieved] | This function returns the first element on the queue or NULL if there are no elements on the. | This function supposedly waits for a new element. Under what circumstances would list_remove_head() return NULL here? Should it go back to waiting instead? |
@@ -15,6 +15,8 @@ class ClassifiedListingCategoryDashboard < Administrate::BaseDashboard
name: Field::String,
rules: Field::String,
slug: Field::String,
+ social_preview_description: Field::String,
+ social_preview_color: Field::String,
updated_at: Field::DateTime
}.freeze
| [ClassifiedListingCategoryDashboard->[freeze],require] | A hash that defines the type of each of the model s fields. This is used to displays a single ClassifiedListingCategory across all pages of the admin dashboard. | As social preview fields are not in the `FORM_ATTRIBUTES`, they won't appear in the form, so how will admins edit them? |
@@ -1137,6 +1137,7 @@ CELERY_TASK_ROUTES = {
'olympia.devhub.tasks.validate_file': {'queue': 'devhub'},
'olympia.devhub.tasks.validate_upload': {'queue': 'devhub'},
'olympia.files.tasks.repack_fileupload': {'queue': 'devhub'},
+ 'olympia.files.tasks.hide_disabled_files': {'queue': 'devhub'},
'oly... | [path->[join],get_raven_release->[fetch_git_sha,get,read,join,exists,open,loads],read_only_mode->[get,Exception],get_db_config->[update,db],,gethostname,join,env,dict,Env,r'^,bool,list,datetime,dirname,format,items,exists,float,read_env,Queue,path,keys,get,get_db_config,get_raven_release,lower] | The tasks collection for all of the tasks in the system. This function is used to register all of the tasks that are currently running on the devhub. | Use the `addons` queue and not `devhub` (Maybe we should rename it, the `devhub` queue is more intended for things to do with the submission process) |
@@ -47,8 +47,7 @@ public class DefaultHighlighting extends DefaultStorable implements NewHighlight
super(storage);
syntaxHighlightingRuleSet = Sets.newTreeSet(new Ordering<SyntaxHighlightingRule>() {
@Override
- public int compare(@Nullable SyntaxHighlightingRule left,
- @Nullable SyntaxHig... | [DefaultHighlighting->[doSave->[checkOverlappingBoudaries]]] | Compares two syntax highlighting rules. | All parameters are non null by default (see package_info.java), so no need for annotations @Nonnull. |
@@ -47,6 +47,8 @@ namespace System.Collections.Generic
public static TValue GetValueOrDefault<TKey, TValue>(this System.Collections.Generic.IReadOnlyDictionary<TKey, TValue> dictionary, TKey key, TValue defaultValue) { throw null; }
public static bool Remove<TKey, TValue>(this System.Collections.Gener... | [No CFG could be retrieved] | This method is used to remove and add items from a System. Collections. Generic. ID. | OK, so it looks like the issue stems from the fact that `S.C.O.ReadOnlyDictionary<TKey, TValue>` does not exist in System.Private.CoreLib but instead lives in the `System.ObjectModel` assembly (unlike `ReadOnlyCollection<T>`). I suspect this means that the particular API cannot be added unless we also move `ReadOnlyDic... |
@@ -551,6 +551,11 @@ namespace System.Net.Http
}
}
+ /// <summary>
+ /// Serializes the HTTP content to a memory stream.
+ /// </summary>
+ /// <param name="cancellationToken">The cancellation token to cancel the operation.</param>
+ /// <returns>The output mem... | [HttpContent->[CreateContentReadStreamAsync->[CreateContentReadStreamAsync],LoadIntoBuffer->[SerializeToStream],CopyTo->[SerializeToStream,TryGetBuffer],TryReadAsStream->[TryGetBuffer],Stream->[TryGetBuffer,LoadIntoBuffer],ReadBufferedContentAsString->[TryGetBuffer],LimitArrayPoolWriteStream->[WriteByte->[EnsureCapacit... | Load into buffer asynchronously. | Could you also add remarks similar to what the async version has? |
@@ -896,8 +896,9 @@ public class DefaultHttp2Connection implements Http2Connection {
Http2Exception.ShutdownHint.GRACEFUL_SHUTDOWN);
}
boolean isReserved = state == RESERVED_LOCAL || state == RESERVED_REMOTE;
- if (!isReserved && !canOpenStream() || isReserv... | [DefaultHttp2Connection->[forEachActiveStream->[forEachActiveStream],removeStream->[isStreamMapEmpty],isServer->[isServer],newKey->[newKey],closeStreamsGreaterThanLastKnownStreamId->[visit->[close],forEachActiveStream],ActiveStreams->[forEachActiveStream->[visit],size->[size],deactivate->[add],removeFromActiveStreams->... | Checks if a new stream is allowed. | Please use the previous style of if branch as it's much easier to read |
@@ -24,12 +24,6 @@ import java.time.Duration;
import org.ehcache.config.builders.*;
import org.ehcache.jsr107.Eh107Configuration;
- <%_ if (enableHibernateCache) { _%>
-import org.hibernate.cache.jcache.ConfigSettings;
- <%_ } _%>
-import io.github.jhipster.config.JHipsterProperties;
-
-<%_ } _%>
<%_ if (cac... | [No CFG could be retrieved] | Imports an object from the JHipster project. Imports all the required packages for JHipster. | From what I understand this block is part of the conditional block `if (cacheProvider === 'ehcache')`, and the other is part of the conditional block `if (cacheProvider === 'caffeine')`, so the imports wont be duplicated and if you use ehcache as cache provider, these imports will be missing. |
@@ -290,15 +290,15 @@ class FormRecognizerClientOperationsMixin:
Allowed values are: "application/pdf", "image/jpeg", "image/png", "image/tiff", "application/json".
:keyword callable cls: A custom type or function that will be passed the direct response
:keyword str continuation_token: A con... | [FormRecognizerClientOperationsMixin->[begin_copy_custom_model->[_copy_custom_model_initial],begin_analyze_receipt_async->[_analyze_receipt_async_initial],list_custom_models->[get_next->[prepare_request]],begin_analyze_layout_async->[_analyze_layout_async_initial],begin_analyze_with_custom_model->[_analyze_with_custom_... | Starts an asynchronous LRO analyze with a custom model. Get a single object from the LRO or polling service. | This is an interesting behavior change, I know it's coming from generated code, but just wondering if this will impact customers who were counting on the previous behavior? Mainly this is just curiosity on my end |
@@ -40,8 +40,10 @@ class Openblas(MakefilePackage):
variant('pic', default=True, description='Build position independent code')
variant('cpu_target', default='auto',
- description='Set CPU target architecture (leave empty for '
- 'autodetection; GENERIC, SSE_GENERIC, NEHALE... | [Openblas->[headers->[find_headers],check_install->[join_path,split,satisfies,dirname,compile_c_and_execute,compare_output_file],make_defs->[satisfies,append,Version,extend,sys_type,format],check_build->[make],install_targets->[format],check_compilers->[str,InstallError,satisfies],parallel->[Version],conflicts,run_befo... | Returns a list of version numbers. Create a list of variants that can be built by a single object. | these lines are too long for the flake8 tests |
@@ -378,12 +378,7 @@ public class TransactionTable {
* @return the LocalTransaction or null if not found
*/
public LocalTransaction getLocalTransaction(GlobalTransaction txId) {
- for (LocalTransaction localTx : localTransactions.values()) { //todo [anistor] optimize lookup!
- if (txId.equals... | [TransactionTable->[shutDownGracefully->[areTxsOnGoing],removeRemoteTransaction->[releaseResources],stop->[stop],start->[start],createRemoteTransaction->[createRemoteTransaction]]] | getLocalTransaction - get the local transaction with the given id. | I think if you remove the tx from the globalToLocalTransactions map first, you don't have to double-check here: you know that any tx that's in globalToLocalTransactions is in localTransactions as well. Actually the transaction might be removed from localTransactions but before you actually use the local tx anyway, so m... |
@@ -42,6 +42,10 @@ const (
maxBackoff = 30 * time.Second
)
+// AgentConfigMinVersion specifies the minimal required version of Kibana
+// that supports agent configuration management
+var AgentConfigMinVersion = common.MustNewVersion("7.5.0")
+
var errNotConnected = errors.New("unable to retrieve connection to K... | [GetVersion->[GetVersion],SupportsVersion->[SupportsVersion]] | END OF FUNCTIONS NewConnectingClient creates a new ConnectingClient. | I think this might fit better in `agentcfg`, keeping this package for more general Kibana-related things. |
@@ -48,9 +48,13 @@ type Provider struct {
Cache bool `description:"Use local agent caching for catalog reads." json:"cache,omitempty" toml:"cache,omitempty" yaml:"cache,omitempty" export:"true"`
ExposedByDefault bool `description:"Expose containers by default." json:"exposedByDefa... | [loadConfiguration->[buildConfiguration,getConsulServicesData],getConsulServicesData->[FromContext,Itoa,fetchServices,getConfiguration,Errorf,fetchService],SetDefaults->[SetDefaults,Duration],Init->[Errorf,MakeDefaultRuleTemplate],fetchServices->[FromContext,Str,MatchTags,Catalog,Errorf,Services,Debugf,With,Debug],fetc... | Prefix is a service tag prefix for Consul service tags. | Should we add that when in Consul Connect mode, we _only_ talk to the other connect aware nodes (and we ignore all others), or is that obvious to Consul users? |
@@ -345,6 +345,13 @@ AVAILABLE_CLI_OPTIONS = {
type=check_int_positive,
metavar='INT',
),
+ "new_pairs_days": Arg(
+ '--new-pairs-days',
+ help='Download data of new pairs for given number of days. Default: `%(default)s`.',
+ type=check_int_positive,
+ metavar='INT'... | [check_int_nonzero->[ArgumentTypeError,int],check_int_positive->[ArgumentTypeError,int],Arg,join] | Command line options for reading and writing exchange pair or market data. Storage format for downloaded candle trades. | instead of defining the default here - we should rather move this to `constants.py` and add the default in the json validation. This will allow providing this value via config as well - otherwise the "argument default" from the CLI will always overwrite what is in the config file |
@@ -39,9 +39,11 @@ public final class DeleteCommand
* @param folderName the folder where the emails are going to be fetched
* @param emailId an optional email number to look up in the folder.
*/
- public void delete(MuleMessage message, RetrieverConnection connection, String folderName, Integer ... | [DeleteCommand->[delete->[closeFolder,set],SetFlagCommand]] | Delete a message from a folder. | it doesn't make much sense to me to receive a list of emailIds. Most common case you just want to delete one. At most, there should be a delete-bulk operation. Also notice that you didn't change the jdocs accordingly |
@@ -101,11 +101,14 @@ func getTailLog(path string, tail int) ([]*LogLine, error) {
if err != nil {
if errors.Cause(err) == io.EOF {
inputs <- []string{leftover}
- close(inputs)
- break
+ } else {
+ logrus.Error(err)
}
- logrus.Error(err)
close(inputs)
+ if err := f.Close();... | [Since->[After],String->[Sprintf,Format],Wrapf,Join,Error,Cause,NewReverseReader,Close,Errorf,Open,Read,Partial,Parse,TailFile,Split] | getTailLog returns the tail of the log file at path and the tail of the log junk returns the next nll message in the log. | Is this close done somewhere else? Is it not needed? |
@@ -4,6 +4,7 @@ module.exports = (sequelize, DataTypes) => {
const GrowthReferral = sequelize.define(
'GrowthReferral',
{
+ id: { type: DataTypes.INTEGER, autoIncrement: true, primaryKey: true },
referrerEthAddress: { type: DataTypes.STRING, primaryKey: true },
refereeEthAddress: { type:... | [No CFG could be retrieved] | Create a Sequelize object for the GrowthReferral table. | referrerEthAddress on line down below should no longer be part of the primaryKey. otherwise we'll have a composite primary key on (id, referrerEthAddress). |
@@ -228,6 +228,16 @@ class Exchange:
"""exchange ccxt precisionMode"""
return self._api.precisionMode
+ def throw_exception_if_method_not_on_exchange(self, method_name: str):
+ """
+ Throws exception if method is implemented by the current exchange on ccxt
+ :param me... | [available_exchanges->[ccxt_exchanges],validate_exchanges->[available_exchanges,validate_exchange,ccxt_exchanges],Exchange->[fetch_ticker->[fetch_ticker,markets],validate_pairs->[markets,get_pair_quote_currency],fetch_order_or_stoploss_order->[fetch_order],_async_get_trade_history->[_async_get_trade_history_time,_async... | Return precision mode. | This already exists as `exchange_has()`, which however does not raise, but returns False. There's 2 applications for that - either check at startup to verify if a configuration is valid (check if certain special options exist - like `createMarketOrder`) - or to check during runtime and fall back to alternative means. N... |
@@ -445,10 +445,13 @@ class IntegrationFixture {
/** @override */
setup(env) {
- const body = this.spec.body;
+ const body = typeof this.spec.body == 'function' ?
+ this.spec.body() : this.spec.body;
+ const experiments = this.spec.experiments || [''];
return new Promise((resolve, reject)... | [RealWinFixture->[setup->[interceptEventListeners,AMP_TEST_IFRAME,onerror,onload,name,installRuntimeStylesPromise,testLocation,location,srcdoc,body,document,win,iframe,fakeRegisterElement,defineProperty,allowExternalResources,installCustomElements,resolve,ampCss,doNotLoadExternalResourcesInTest,contentWindow,createElem... | Setup the AMP environment. | no need to pass experiments over if there is none. |
@@ -234,7 +234,13 @@ function loadApplicationPackage (packagePath) {
packagePath = path.resolve(packagePath)
const packageJsonPath = path.join(packagePath, 'package.json')
if (fs.existsSync(packageJsonPath)) {
- const packageJson = JSON.parse(fs.readFileSync(packageJsonPath))
+ let packageJson
... | [No CFG could be retrieved] | Load an application package. Load the specified app and start it if it is not already running. | I don't think we should say `it contains errors` here since the error caught here could be thrown from both `JSON.parse` and `fs.readFileSync` so it might have failed to read but actually be valid JSON. |
@@ -274,7 +274,7 @@ public class SpdyHttpDecoder extends MessageToMessageDecoder<SpdyFrame> {
}
try {
- fullHttpMessage = createHttpResponse(ctx, spdyHeadersFrame, validateHeaders);
+ fullHttpMessage = createHttpResponse(spdyHeade... | [SpdyHttpDecoder->[decode->[putMessage,getMessage,removeMessage]]] | Decode a message that is not part of a message. This method is called when a request is received from the client and the client is not able This method is called when a SYN_REPLY frame is received. If the client This method checks if there is a message in the stream and if so adds it to the if message is in map discard... | catch `Throwable` below. |
@@ -317,6 +317,13 @@ describes.sandboxed('amp-ad-network-doubleclick-impl', {}, () => {
};
});
sandbox.stub(impl, 'getAmpDoc', () => {return document;});
+ // Reproduced from noopMethods in ads/google/a4a/test/test-utils.js,
+ // to fix failures when this is run after 'gulp buil... | [No CFG could be retrieved] | This example is to get the right URL of an AMP Ad. The tagForChildDirectedTreatment example. | Why these numbers? They look as though they can't be consistent. Unless I've misunderstood? |
@@ -8,6 +8,7 @@ namespace NServiceBus.Features
{
EnableByDefault();
Prerequisite(c => c.Settings.Get<TransportInfrastructure>().OutboundRoutingPolicy.Publishes == OutboundRoutingType.Multicast, "The transport does not support native pub sub");
+ Prerequisite(c => HybridSubs... | [NativePublishSubscribeFeature->[Setup->[SubscriptionManagerFactory,Register,Settings,ConfigureSubscriptionInfrastructure],Multicast,EnableByDefault,Prerequisite,Publishes]] | Setup method. | should we also add this check to the message driven implementation for completeness sake? This could prevent incorrect cases where someone would enable the hyrid mode with a transport not supporting native pubsub. In that case, it would just "silently" stick with message driven pubsub instead of failing. |
@@ -13,6 +13,7 @@ from conans.client.generators.cmake_multi import extend
class CMakeFindPackageMultiGenerator(CMakeFindPackageGenerator):
name = "cmake_find_package_multi"
_configurations = ["Release", "RelWithDebInfo", "MinSizeRel", "Debug"]
+ _configurations_upper = ["RELEASE", "RELWITHDEBINFO", "MINSI... | [CMakeFindPackageMultiGenerator->[_config->[find_transitive_dependencies,format,render,join],content->[_get_components,render,_config,_get_name,extend,str,_get_filename,_get_require_name,format,DepsCppCmake,join,reversed,_validate_components,lower,get_public_deps],Template,dedent]] | Creates a CMakeFindPackageMulti from a single CMake object. set properties - >. | Better remove this and do an ``.upper()`` call when necessary. |
@@ -105,9 +105,6 @@ public class Ovm3HypervisorGuru extends HypervisorGuruBase implements Hypervisor
EndPoint ep = endPointSelector.selectHypervisorHost(new ZoneScope(host.getDataCenterId()));
host = hostDao.findById(ep.getId());
hostDao.loadDetails(host);
... | [Ovm3HypervisorGuru->[implement->[setOs,findById,setBootloader,toVirtualMachineTO,getBootLoaderType,getGuestOSId,getDisplayName],getCommandHostDelegation->[getDataCenterId,ZoneScope,debug,getDataStore,selectHypervisorHost,getSrcTO,findById,setExecuteInSequence,getObjectType,getId,getDestTO,getClass,loadDetails,valueOf]... | This method is used to determine if a command should be delegated to a host. | as we never return anything but ew Pair<Boolean, Long>(Boolean.FALSE, Long.valueOf(hostId)) we might as well return it as the first line of the method. There is side effect in the code that is needed, so let's extract that to another (set of) private method(s). improves readability and thus maintainability of the code |
@@ -263,7 +263,11 @@ func (ht *HeadTracker) receiveHeaders() error {
}
}
-func (ht *HeadTracker) handleNewHead(bh gethTypes.Header) error {
+func (ht *HeadTracker) handleNewHead(bh *gethTypes.Header) error {
+ if bh == nil {
+ return nil
+ }
+
defer func(start time.Time, number int64) {
elapsed := time.Since... | [handleNewHead->[HighestSeenHead,Save],subscribeToHead->[connect],unsubscribeFromHead->[disconnect],backfillTimeBudget->[isKovan],callbackExecutionThreshold->[isKovan]] | receiveHeaders is a long running routine that receives all the headers from the head queue and processes Save the head in the database. | Why is this a pointer now? |
@@ -146,7 +146,7 @@ REQUIRED_PACKAGES = [
'grpcio>=1.29.0,<2',
'hdfs>=2.1.0,<3.0.0',
'httplib2>=0.8,<0.18.0',
- 'mock>=1.0.1,<3.0.0',
+ 'mock>=1.0.1,<5.0.0',
'numpy>=1.14.3,<1.21.0',
'pymongo>=3.8.0,<4.0.0',
'oauth2client>=2.0.1,<5',
| [mypy->[run->[get_project_path]],get_version,generate_protos_first] | Cython version of the package. Package names for all packages that are available on the system. | I think this should really be a test-only dependency, but it predates us separating those out. Would it also unblock you if we move this to `REQUIRED_TEST_PACKAGES` so it's not required by default? |
@@ -237,6 +237,10 @@ public class Controller {
return new File(appsDir, appName + ANCHOR_SUFFIX).exists();
}
+ protected boolean isUndeployed(String appName) {
+ return !(new File(appsDir, appName + ANCHOR_SUFFIX).exists() || new File(appsDir, appName).exists());
+ }
+
protected boolean isDomainDeploy... | [Controller->[addLibrary->[verify],isRunning->[status],restart->[restart],stop->[stop],start->[start],status->[status],deploy->[verify],getProcessId->[getProcessId],deployDomain->[verify],getMuleBin->[getMuleBin],redeploy->[validateApplicationExists],deployDomainBundle->[verify]]] | Check if the application or domain is deployed. | If an application folder exists, but the anchor file doesn't, this would return false, which is not true |
@@ -2652,9 +2652,9 @@ def img_pool_layer(input,
elif isinstance(pool_type, AvgPooling):
pool_type.name = 'avg'
- assert type(pool_type) in [AvgPooling, MaxPooling, CudnnAvgPooling,
+ assert type(pool_type) in [AvgPooling, MaxPooling, MaxWithMaskPooling, CudnnAvgPooling,
... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | Image pooling layer with maxpooling. Creates a LayerOutput object from a . A pool of pool layers. | add `,` before `MaxWithMaskPooling` |
@@ -147,6 +147,13 @@ export class AmpAutocomplete extends AMP.BaseElement {
`${TAG} should contain exactly one <input> child`);
this.inputElement_ = /** @type {!HTMLInputElement} */ (inputElements[0]);
+ this.formAncestor_ = closestAncestorElementBySelector(this.element, 'form');
+ userAssert(this... | [No CFG could be retrieved] | Private methods for building the AMP autocomplete menu. Reads the items data from the child element. | you should be able to reference the input element's form using the `this.element.form` property. |
@@ -93,7 +93,9 @@ public final class UdfUtil {
schema = GenericsUtil.generic(((TypeVariable) type).getName());
} else {
schema = typeToSchema.getOrDefault(type, () -> handleParametrizedType(type)).get();
- schema.name(name);
+ if (schema.name() == null) {
+ schema.name(name);
+ ... | [UdfUtil->[handleParametrizedType->[getSchemaFromType],getSchemaFromType->[getSchemaFromType]]] | Get schema from type. | Why is this change necessary? (Why would the schema already have a name at this point?) |
@@ -1331,6 +1331,11 @@ describe('input', function() {
expect(scope.name).toEqual('adam');
});
+ it('should not add the property to the scope if name is undefined', function() {
+ compileInput('<input type="text" ng-model="name" />');
+ expect(scope.form['undefined']).toBeUndefined();
+ });
+
descri... | [No CFG could be retrieved] | Checks that the input element has the required read - only property disabled and the input element has Adding a check for the input field that has the name attribute set to a and then changing. | I think what we should do though, is spy on the $addControl and $$renameControl methods of the form though... I think we'd have to rewrite it to not use `compileInput` to make that work |
@@ -12,6 +12,12 @@ import showModal from "discourse/lib/show-modal";
let _components = {};
+const pluginReviewableParams = [];
+
+export function addPluginReviewableParam(param) {
+ pluginReviewableParams.push(param);
+}
+
export default Component.extend({
adminTools: optionalService(),
tagName: "",
| [No CFG could be retrieved] | Creates a component that can be used to render a block of content. Check if a user has the required or optional relation. | This API should be specific to the type too. |
@@ -92,8 +92,15 @@ module.exports = JhipsterClientGenerator.extend({
defaults: 'jhi'
});
+ // This adds support for a `--skip-user-management` flag
+ this.option('skip-user-management', {
+ desc: 'Skip the user management module during app generation',
+ type:... | [No CFG could be retrieved] | This function provides the options for the given application. The main function that is called when the user is entering the configuration. | Its should be `||` instead of second `=` |
@@ -165,10 +165,13 @@ public class ScriptingManagerImpl implements ScriptingManager {
.orElseGet(() -> new SimpleBindings());
SimpleBindings systemBindings = new SimpleBindings();
- systemBindings.put(SystemBindings.CACHE_MANAGER.toString(), cacheManager);
+ DataTypedCacheManager cm = new D... | [ScriptingManagerImpl->[getScript->[containsScript,get,noNamedScript],addScript->[parse,noScriptEngineForScript,put,getEngineForScript],runScript->[TaskContext,fromDataType,runScript,getMarshaller,getScriptMetadata,isPresent,getAdvancedCache,checkPermission,thenApply,orElse,ifPresent,toString,getRunner,SimpleBindings,g... | Runs a script in the cache. | This calls `cm.getCacheConfiguration(cache.getName()).compatibility().enabled()` instead of `cache.getCacheConfiguration().compatibility().enabled()` because the latter requires ADMIN rights in secured caches whereas the former works. The bigger problem is that even if the cache is secured, we should be able to call wh... |
@@ -1827,13 +1827,15 @@ class TypeChecker(NodeVisitor[Type]):
def visit_except_handler_test(self, n: Node) -> Type:
"""Type check an exception handler test clause."""
type = self.accept(n)
- if isinstance(type, AnyType):
- return type
all_types = [] # type: List[Type... | [TypeChecker->[visit_op_expr->[visit_op_expr],visit_operator_assignment_stmt->[accept,check_indexed_assignment],visit_unicode_expr->[visit_unicode_expr],visit_yield_from_expr->[accept,get_generator_return_type,get_generator_yield_type],visit_func_expr->[visit_func_expr],check_override->[erase_override],visit_ellipsis->... | Type check an exception handler test clause. | You can just `return AnyType()` here instead. `UnionType.make_simplified_union` returns `AnyType` if any of the types passed to it are `AnyType` (as it should). |
@@ -439,11 +439,11 @@ public class KsqlParserTest {
}
@Test
- public void testShouldFailIfWrongKeyword() throws Exception {
+ public void testShouldFailIfWrongKeyword() {
try {
String simpleQuery = "SELLECT col0, col2, col3 FROM test1 WHERE col0 > 100;";
Statement statement = KSQL_PARSER.bu... | [KsqlParserTest->[testProjection->[assertTrue,getQueryBody,equalsIgnoreCase,size,get],testSelectHoppingWindow->[assertTrue,getQueryBody,size,isPresent,get,equalTo,toString,toUpperCase,instanceOf,assertThat],testBinaryExpression->[assertTrue,getQueryBody,equalsIgnoreCase,get],testLeftJoinWithFilter->[assertTrue,getQuery... | Test if there is a missing keyword in the query. | I know this was here before, but would be useful to have a reason why it failed |
@@ -470,6 +470,9 @@ func RunCmdRouter(f *clientcmd.Factory, cmd *cobra.Command, out io.Writer, cfg *
ContainerPort: cfg.StatsPort,
Protocol: kapi.ProtocolTCP,
}
+ if cfg.HostPorts {
+ port.HostPort = cfg.StatsPort
+ }
ports = append(ports, port)
}
| [StringVar,NewDefaultClientConfig,ConstraintAppliesTo,SecurityContextConstraints,AddPrinterFlags,Exit,Add,IntVar,LabelsFromSpec,Itoa,FormatBool,PrivateKeysFromPEM,GetFlagString,ConvertItemsForDisplayFromDefaultCommand,Errorf,Services,Namespace,PrinterForCommand,CheckErr,Bool,Clients,Create,Join,Contains,AddServices,Con... | finds the next negative integer in the system and returns it. nodeSelector returns a map of node ID to image ID. | doesn't this need to check `!cfg.HostNetwork`? the flag help seemed to indicate it only does something if HostNetwork is false |
@@ -25,7 +25,7 @@ import java.io.InputStream;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
-class ApiGatewayProxyRequestTest {
+public class ApiGatewayProxyRequestTest {
@AfterEach
void resetOpenTelemetry() {
| [ApiGatewayProxyRequestTest->[shouldCreateNoopRequestIfXRayPropagatorsSet->[forStream,build,mock,isEqualTo,set,isEmpty],resetOpenTelemetry->[build,set],shouldUseStreamMarkingIfHttpPropagatorsSet->[forStream,reset,willReturn,build,mock,isEqualTo,mark,set],shouldUseCopyIfMarkingNotAvailableAndHttpPropagatorsSet->[forStre... | Resets the OpenTelemetry SDK to the default OpenTelemetry SDK. | Nit: is this change necessary? |
@@ -68,6 +68,7 @@ def _suggest_donation_if_appropriate(config):
"Donating to EFF: https://eff.org/donate-le\n\n")
reporter_util.add_message(msg, reporter_util.LOW_PRIORITY)
+
def _report_successful_dry_run(config):
"""Reports on successful dry run
| [update_account->[_determine_account],enhance->[_init_le_client],revoke->[revoke,_delete_if_appropriate,_determine_account],renew_cert->[_init_le_client,_get_and_save_cert],_ask_user_to_confirm_new_names->[_format_list,_get_added_removed],install->[_init_le_client,_install_cert,_find_domains_or_certname],unregister->[_... | Potentially suggest a donation if appropriate. | This can go with the newline added above! |
@@ -172,7 +172,7 @@ void baseline_checks(const Encoding& encoding, const DataView& expected_cdr)
Type value;
EXPECT_EQ(serialized_size(encoding, value), expected_cdr.size);
// TODO(iguessthislldo): Does not work for XCDR1 and XCDR2 Mutable and XCDR2 Appendable
- /* EXPECT_EQ(max_serialized_size(encoding, valu... | [set_values->[set_values,set_base_values,amalgam_serializer_test],buffer->[set_values],amalgam_serializer_test->[set_values],assert_values->[expect_values_equal],set_values<AdditionalFieldMutableStruct>->[set_base_values],expect_values_equal->[expect_values_equal_base]] | Check if the given data view has a key in the expected data view. | I'm going to be fixing this in #1846 so please undo this to avoid a conflict. |
@@ -850,6 +850,11 @@ public abstract class View extends AbstractModelObject implements AccessControll
}
}
+ // for testing purpose
+ /*package*/ Set<User> getModified() {
+ return modified;
+ }
+
@Override protected synchronized JSON data() {
... | [View->[getQueueItems->[filterQueue,getItems],getActions->[getOwnerViewActions],getACL->[getACL],updateByXml->[save,checkPermission],getAllItems->[getItems,getAllItems],PropertyList->[onModified->[getOwner]],doChildrenContextMenu->[getItems,getDisplayName],rss->[getUrl,getDisplayName],getAbsoluteUrl->[getUrl],getWidget... | Computes the number of users that are required to run the given items. private JSONArray users = new JSONArray();. | As `data()` access `Stapler.getCurrentRequest()`, it is difficult to use in test codes. |
@@ -1667,6 +1667,10 @@ func (k *KubernetesConfig) validateNetworkPlugin(hasWindows bool) error {
return errors.Errorf("networkPlugin '%s' is not supporting windows agents", networkPlugin)
}
+ if networkPlugin == NetworkPluginKubenet && hasWindows {
+ log.Warnf("Windows + Kubenet is for development and testing o... | [validateCustomKubeComponent->[isUsingCustomKubeComponent],Validate->[validate,validateCustomCloudProfile]] | validateNetworkPlugin checks if the network plugin and network policy are valid. | Let's unit test this using the super cool `Example`-style UT. See `ExampleProperties_validateLocation` as an example in `validate_test.go`. |
@@ -84,6 +84,7 @@ namespace Dynamo.Wpf.UI.GuidedTour
GuideFlowEvents.GuidedTourNextStep += GuideFlowEvents_GuidedTourNextStep;
GuideFlowEvents.GuidedTourPrevStep += GuideFlowEvents_GuidedTourPrevStep;
GuideFlowEvents.UpdatePopupLocation += GuideFlowEvents_UpdatePopupLocation;
+ ... | [Guide->[ClearGuide->[SetLibraryViewVisible,UnsubscribeFlowEvents],CalculateStep->[SetLibraryViewVisible],Initialize->[SubscribeFlowEvents],GuideFlowEvents_GuidedTourNextStep->[NextStep],GuideFlowEvents_GuidedTourPrevStep->[PreviousStep]]] | SubscribeFlowEvents - Add all the events that are registered in the GUI. | We need to unsubscribe it later |
@@ -30,16 +30,7 @@ def verify_mozilla_trademark(name, user, form=None):
name = normalize_string(name, strip_punctuation=True).lower()
for symbol in amo.MOZILLA_TRADEMARK_SYMBOLS:
- if waffle.switch_is_active('content-optimization'):
- violates_trademark = symbol in name
-
-... | [get_addon_recommendations->[call_recommendation_server],build_webext_dictionary_from_legacy->[split,writestr,ZipFile,splitext,basename,splitted,endswith,SafeZip,replace,str,read,ValidationError,dumps,to_language],verify_mozilla_trademark->[_check->[ugettext,endswith,format,ValidationError,normalize_string,switch_is_ac... | Verify that a name is a valid Mozilla or Firefox trademark. | Should we have a migration to delete this waffle switch? |
@@ -128,7 +128,10 @@ public class ValueProviderExecutor extends AbstractParameterResolverExecutor {
return resultFrom(
withContextClassLoader(
extensionClassLoader,
- () -> valueProvider... | [ValueProviderExecutor->[getValueProviderModel->[getValueProviderModel],getConfigRef->[getConfigRef],resolveFieldValues->[resolveValues],resolveValues->[resolveValues]]] | Resolves the values of a value provider. This method is called when the value resolution is enabled. | I am worried of what will happen if the class needed is internal within the connector. Should we actually be able to find it? If that class is a parameter that should be configured externally, my gut tells me that it should be exported. But I actually don't know which is the expected behavior. What happens when POJOs a... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.