patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -685,6 +685,11 @@ class PipelineClientBase(object):
# type: (...) -> HttpRequest
"""Create HttpRequest object.
+ If content is not None, guesses will be used to set the right body:
+ - If content is an XML tree, will serialize as XML
+ - If content-type starts by "text/", set... | [_HttpClientTransportResponse->[__init__->[_case_insensitive_dict]],_deserialize_response->[BytesIOSocket],HttpRequest->[set_formdata_body->[_format_data],__deepcopy__->[HttpRequest],__init__->[_case_insensitive_dict],serialize->[_serialize_request],prepare_multipart_body->[prepare_multipart_body,set_bytes_body]],HttpT... | Create a HttpRequest object from the given parameters. | Why not put "If content-type starts by "text/", set the content as text" first? |
@@ -1048,7 +1048,7 @@ class JobServerOptions(PipelineOptions):
class FlinkRunnerOptions(PipelineOptions):
- PUBLISHED_FLINK_VERSIONS = ['1.7', '1.8', '1.9']
+ PUBLISHED_FLINK_VERSIONS = ['1.7', '1.8', '1.9', '1.10']
@classmethod
def _add_argparse_args(cls, parser):
| [PipelineOptions->[__getattr__->[_visible_option_list],__dir__->[_visible_option_list],__init__->[_BeamArgumentParser],__setattr__->[_visible_option_list],display_data->[get_all_options],get_all_options->[_BeamArgumentParser,_add_argparse_args],__str__->[_visible_option_list]],_BeamArgumentParser->[add_value_provider_a... | Adds arguments related to the Flink cluster. | Do we have a process to keep this list up to date? @mxm @ibzib |
@@ -2442,7 +2442,7 @@ class Diaspora {
*
* @return string the handle in the format user@domain.tld
*/
- private function my_handle($contact) {
+ private static function my_handle($contact) {
if ($contact["addr"] != "")
return $contact["addr"];
| [Diaspora->[receive_status_message->[children],message->[getName],verify_magic_envelope->[children,attributes],decode->[children,attributes],receive_request_make_friend->[get_hostname],transmit->[get_curl_code,get_curl_headers],valid_posting->[children,getName],dispatch->[getName]]] | This function handles the contact data. | Standards: Pleas add braces. |
@@ -1046,8 +1046,8 @@ public class SqlToJavaVisitorTest {
ArrayType.of(ParamTypes.DOUBLE),
ParamTypes.DOUBLE,
LambdaType.of(
- ImmutableList.of(ParamTypes.DOUBLE, ParamTypes.DOUBLE),
- ParamTypes.DOUBLE))
+ ImmutableList.of(ParamTypes.D... | [SqlToJavaVisitorTest->[shouldGenerateCorrectCodeForNestedLambdas->[FunctionCall,ArithmeticBinaryExpression,of,thenReturn,LambdaFunctionCall,mock,process,equalTo,givenUdf,LambdaVariable,IntegerLiteral,assertThat],shouldThrowOnSimpleCase->[of,process,empty,IntegerLiteral,WhenClause,SimpleCaseExpression,assertThrows,Stri... | Checks if the code for a missing missing value is generated for nested lambdas. No - op since it s not safe to call this method. | Not clear why we need such changes in this test? |
@@ -69,11 +69,11 @@ export default class WalletsList extends Component {
let noErr = true;
try {
let balanceStart = +new Date();
- await BlueApp.fetchWalletBalances(that.lastSnappedTo || 0);
+ await BlueApp.fetchWalletBalances();
let balanceEnd = +ne... | [No CFG could be retrieved] | Component that is the base class for all of the network network components. Function to refresh the screen of the object. | the meaning of this was to update only the wallet that is current. otherwise updatting all wallets and all their transactions might take looooong time |
@@ -213,7 +213,6 @@ class Trainer:
self._last_log = time.time()
batch_num = 0
- logger.info("Training")
for batch in train_generator_tqdm:
batch_num += 1
self._optimizer.zero_grad()
| [Trainer->[train->[_validation_loss,_update_learning_rate,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_validation_loss->[_get_metrics,_batch_loss],__init__->[TensorboardWriter],_metrics_to_tensorboard->[add_validation_scalar,add_train_scalar],_trai... | Trains one epoch and returns metrics. Adds the train loss and metrics to the tensorboard. | I would keep this here, as we have progress bars for training and validation separately, and this makes it more obvious which one is which. |
@@ -1,7 +1,5 @@
<?php
-if (!$os) {
- if (strstr($sysObjectId, '.1.3.6.1.4.1.11863.1.1')) {
- $os = 'tplink';
- }
+if (str_contains('.1.3.6.1.4.1.11863.1.1', $sysObjectId)) {
+ $os = 'tplink';
}
| [No CFG could be retrieved] | <?php if - >. | Wrong way round :) |
@@ -325,9 +325,9 @@ func (wh *webhook) mustInject(pod *corev1.Pod, namespace string) (bool, error) {
return false, nil
}
-func isAnnotatedForInjection(annotations map[string]string) (exists bool, enabled bool, err error) {
+func isAnnotatedForInjection(annotations map[string]string, objectKind string, objectName s... | [podCreationHandler->[getAdmissionReqResp],mustInject->[isNamespaceInjectable]] | mustInject checks if the pod is annotated for injection and if it is enabled for injection. | I don't know if it matters in terms of simplification, but we can get rid of this trace log. It isn't necessary given we have unit tests and log when this function returns an error. |
@@ -93,6 +93,7 @@ import io.quarkus.utilities.JavaBinFinder;
*/
@Mojo(name = "dev", defaultPhase = LifecyclePhase.PREPARE_PACKAGE, requiresDependencyResolution = ResolutionScope.COMPILE_PLUS_RUNTIME)
public class DevMojo extends AbstractMojo {
+ private static final String EXT_PROPERTIES_PATH = "META-INF/quarkus... | [DevMojo->[DevModeRunner->[prepare->[triggerCompile,getSourceEncoding,addToClassPaths,addProject],addQuarkusDevModeDeps->[addToClassPaths]]]] | Creates a new instance of DevMojo that runs a quarkus app in a fork Private static method to find the correct plugin group and artifact ID. | That's `io.quarkus.bootstrap.BootstrapConstants.DESCRIPTOR_PATH`, btw. |
@@ -101,7 +101,9 @@ Java_io_daos_obj_DaosObjClient_punchObject(JNIEnv *env, jobject clientObject,
if (rc) {
char *msg = "Failed to punch DAOS object";
- throw_exception_const_msg_object(env, msg, rc);
+ throw_const_obj(env,
+ msg,
+ rc);
}
}
| [No CFG could be retrieved] | region DAOS Object API private void punchObjectAkeys ;. | (style) code indent should use tabs where possible |
@@ -451,7 +451,6 @@ JhipsterGenerator.prototype.app = function app() {
this.template('src/main/java/package/aop/logging/_LoggingAspect.java', javaDir + 'aop/logging/LoggingAspect.java');
this.template('src/main/java/package/config/apidoc/_package-info.java', javaDir + 'config/apidoc/package-info.java');
- ... | [No CFG could be retrieved] | This method removes all files from the application. This method is used to generate the configuration files. | If you don't generate the file, can you also delete it? There's a section for removing files -> this is for people upgrading from an older version |
@@ -111,8 +111,8 @@ class DictionaryService(BaseService):
:param lang: language code
"""
model = {}
- lookup = {'$and': [{'language_id': lang}, {'is_active': {'$in': ['true', None]}}]}
- dicts = self.get(req=None, lookup=lookup)
+ dicts = self.get_dictionaries(lang)
+
... | [merge->[add_word],DictionaryService->[on_update->[add_words,merge,encode_dict,read_from_file],get_model_for_lang->[add_word,decode_dict],on_updated->[decode_dict],on_fetched->[decode_dict],find_one->[decode_dict],on_create->[merge,encode_dict,read_from_file]],add_words->[add_word,words],read_from_file->[read,train,wor... | Get model for given language. | I suggest caching dictionaries and models. This takes a lot of processing and the spelling suggestion requests should happen quite often. |
@@ -224,6 +224,14 @@ func (b *bufferedIdentifyUI) ReportTrackToken(t keybase1.TrackToken) error {
return b.raw.ReportTrackToken(t)
}
+func (b *bufferedIdentifyUI) Cancel() error {
+ b.Lock()
+ defer b.Unlock()
+
+ // Cancel should always go through to UI server
+ return b.raw.Cancel()
+}
+
func (b *bufferedIdenti... | [DisplayTLFCreateWithInvite->[DisplayTLFCreateWithInvite],DisplayCryptocurrency->[flush],DisplayKey->[flush],DisplayUserCard->[flush],FinishWebProofCheck->[flush],DisplayTrackStatement->[DisplayTrackStatement],Finish->[Finish,flush],FinishSocialProofCheck->[flush],ReportLastTrack->[flush],ReportTrackToken->[ReportTrack... | ReportTrackToken implements the keybase1. IdentifyUI interface for bufferedIdentifyUI. | This won't wind up being called in `Identify2WithUID`. I think that's fine but just double-checking with you. |
@@ -102,7 +102,7 @@ public class TestMiniOzoneCluster {
FileUtils.deleteQuietly(READ_TMP);
}
- @Test(timeout = 30000)
+ @Test(timeout = 60000)
public void testStartMultipleDatanodes() throws Exception {
final int numberOfNodes = 3;
cluster = MiniOzoneCluster.newBuilder(conf)
| [TestMiniOzoneCluster->[testDNstartAfterSCM->[getStorageContainerManager,getState,build,sleep,stop,getValues,getDatanodeStateMachine,waitForClusterToBeReady,restartHddsDatanode,restartStorageContainerManager,assertEquals],cleanup->[shutdown],afterClass->[deleteQuietly],testContainerRandomPort->[assertTrue,start,assertN... | This method creates a cluster and then connects to the container. | Does the new logic cause more timeout without increasing this? |
@@ -154,6 +154,12 @@ def make_app(build_dir: str = None, demo_db: Optional[DemoDatabase] = None) -> F
if request.method == "OPTIONS":
return Response(response="", status=200)
+ # Do log if no argument is specified
+ record_flag = not request.args.get("record", "true").lower() == "f... | [make_app->[predict->[_caching_prediction,ServerError],permadata->[ServerError],handle_invalid_usage->[to_dict]],ServerError->[__init__->[__init__]]] | Create a Flask application with a single object. This route handles the prediction of a single n - ary object. Get the n - node node id from the model. This action returns a list of all the verbs of a model that has semantic parses. | `!=` would be more idiomatic (and more readable) than `not ==` |
@@ -18,7 +18,7 @@
-%>
<div>
<h2>
- <span jhiTranslate="userManagement.home.title">Users</span>
+ <span class="userManagement-page-heading" jhiTranslate="userManagement.home.title">Users</span>
<button class="btn btn-primary float-right jh-create-entity" [routerLink]="['./new']">
... | [No CFG could be retrieved] | Displays a Bootstrap - styled list of all the user - managed records in the system. Returns the JHIS sorting information for a unique identifier. | use dash casing for ids and classes |
@@ -353,7 +353,7 @@ func getUpgradeCommand() string {
return "$ brew upgrade pulumi"
}
- if filepath.Dir(exe) != filepath.Join(curUser.HomeDir, ".pulumi", "bin") {
+ if filepath.Dir(exe) != filepath.Join(curUser.HomeDir, workspace.BookkeepingDir, "bin") {
return ""
}
| [StringVar,RawMessage,Dir,Colorize,Executable,Warningf,Now,Encode,HasPrefix,Add,IsTruthy,IgnoreClose,Flush,Stat,ParseTolerant,NewEncoder,New,RunFunc,Diag,StringVarP,NewClient,InitLogging,Run,After,Chdir,AddCommand,LookPath,GetCachedVersionFilePath,Bytes,TrimSpace,AssertNoError,InitProfiling,Join,Wrapf,Infof,Current,Eva... | getUpgradeMessage returns a message that will be used to upgrade from the current version to the isBrewInstall returns true if the current running executable is on macOS and has a. | Why bookkeepingdir here but homedir elsewhere? |
@@ -422,6 +422,14 @@ namespace Dynamo.Graph.Workspaces
OnConnectorAdded(connector); // Update view-model and view.
}
}
+ else if (typeName.Contains("ConnectorPinModel"))
+ {
+ var connectorPin = NodeGraph.LoadPinFromXml(modelData);
... | [WorkspaceModel->[ReloadModel->[Undo],SaveAndDeleteModels->[RecordAndDeleteModels],Undo->[Undo],Redo->[Redo],CreateModel->[Undo]]] | Creates a model from the given xml element. This function is called when a node type is not found in the model. It is called. | Feel free to use nameof(ConnectorPinModel) instead of hardcoded string, so in the future auto renamed type will still work. In general, we try to avoid hardcoded string, especially type names |
@@ -75,6 +75,7 @@ class PantsRunner:
# We enable logging here, and everything before it will be routed through regular
# Python logging.
setup_logging(global_bootstrap_options, stderr_logging=True)
+ ExceptionSink.set_logging_initialized()
if self._should_run_with_pantsd(glo... | [PantsRunner->[run->[run,_should_run_with_pantsd,scrub_pythonpath],_should_run_with_pantsd->[will_terminate_pantsd]]] | Runs the pants command. | We call `setup_logging` in a few different places (`pants_runner.py` `daemon_pants_runner.py` and `pants_daemon.py`) because we need to do slightly different things pertaining to logging setup depending on whether pantsd is or is not running. I'm concerned that if we call `set_logging_initialized` here, we won't handle... |
@@ -343,6 +343,17 @@ void ExtensionRunnerInterface::init(RouteUUID uuid, bool manager) {
server_->processor =
std::make_shared<extensions::ExtensionManagerProcessor>(handler);
}
+ // Set the global output function for thrift
+ GlobalOutput.setOutputFunction([](const char* message) -> void {
+ time... | [registerExtension->[registerExtension],ping->[ping,manager],deregisterExtension->[deregisterExtension,getUUID],shutdown->[shutdown,manager],stopServer->[waitUntilServerIsListening,reset],init->[setTimeouts,init],call->[call,manager],getQueryColumns->[getQueryColumns,getUUID],close->[close],extensions->[extensions],ser... | Initializes the extension manager and the thrift server. | I think we can skip the `dbgtime` output since GLOG will insert a timestamp itself. I am not aware of a reason we'd want both? |
@@ -6354,6 +6354,16 @@ namespace Js
return this->propertyStringMap;
}
+ EnumeratorCache* JavascriptLibrary::GetObjectAssignCache(Type* type)
+ {
+ if (this->cache.assignCache == nullptr)
+ {
+ this->cache.assignCache = AllocatorNewArrayZ(CacheAllocator, scriptContext->GetE... | [No CFG could be retrieved] | Checks if a type is not undefined and if so sets it to the object s type if InlineSlot cache 0x%p in CreateObject. | >AssignCacheSize [](start = 98, length = 15) Maybe we could add a static assertion that AssignCacheSize is a power of 2, to avoid surprising out-of-bounds behavior if someone tries tweaking the constant. |
@@ -13,6 +13,7 @@ class PyDnaio(PythonPackage):
url = "https://pypi.io/packages/source/d/dnaio/dnaio-0.3.tar.gz"
git = "https://github.com/marcelm/dnaio.git"
+ version('0.4.2', sha256='fa55a45bfd5d9272409b714158fb3a7de5dceac1034a0af84502c7f503ee84f8')
version('0.3', sha256='47e4449affad098... | [PyDnaio->[depends_on,version]] | Homepage and homepage for Dnaio. | Can you add a build dep on `py-setuptools-scm`? |
@@ -70,7 +70,8 @@ public class ExpressionLanguageAdaptorHandler implements ExtendedExpressionLangu
expressionLanguages.put(MEL_PREFIX, mvelExpressionLanguage);
}
- exprPrefixPattern = compile(EXPR_PREFIX_PATTERN_TEMPLATE.replaceAll("LANGS", join(expressionLanguages.keySet(), '|')));
+ exprPrefixPatt... | [ExpressionLanguageAdaptorHandler->[openSession->[close->[close],evaluateLogExpression->[evaluateLogExpression],evaluate->[evaluate],split->[split],openSession],addGlobalBindings->[addGlobalBindings],split->[split],validate->[validate],evaluateLogExpression->[evaluateLogExpression],toString->[toString],evaluate->[evalu... | Creates a handler which can be used to determine the expression language that should be used. | there is a general thing with your IDE against static imports it seems |
@@ -402,6 +402,9 @@ public class HiveJdbcCommon {
rowValues.add("");
}
break;
+ case SQLXML:
+ rowValues.add(StringEscapeUtils.escapeCsv(((java.sql.SQLXML) value).getString()));
+ ... | [HiveJdbcCommon->[createSchema->[createSchema],convertToAvroStream->[convertToAvroStream],convertToCsvStream->[convertToCsvStream]]] | Converts a ResultSet to a CSV stream. This method writes the row values and the values of the next row in the table if there. | Shouldn't we take care of null `value` here, too? |
@@ -547,6 +547,11 @@ func (mc *Cluster) GetMaxReplicas() int {
return mc.ScheduleOptions.GetMaxReplicas()
}
+// GetStoreLimitByType mocks method.
+func (mc *Cluster) GetStoreLimitByType(storeID uint64, typ storelimit.Type) float64 {
+ return mc.ScheduleOptions.GetStoreLimitByType(storeID, typ)
+}
+
// CheckLabelP... | [GetReplicaScheduleLimit->[GetReplicaScheduleLimit],UpdateStorageWrittenKeys->[GetStore],AllocPeer->[AllocID],RandHotRegionFromStore->[RandHotRegionFromStore],GetHotRegionScheduleLimit->[GetHotRegionScheduleLimit],UpdateStoreRegionWeight->[GetStore],PutStoreWithLabels->[AddLabelsStore],UpdateStorageReadStats->[GetStore... | GetMaxReplicas returns the maximum number of replicas that can be scheduled. | Do we need to emphasize `ByType`? |
@@ -114,6 +114,7 @@ import { mediaPermissionPromptVisibilityChanged } from './react/features/overlay
import { suspendDetected } from './react/features/power-monitor';
import { setSharedVideoStatus } from './react/features/shared-video';
import { endpointMessageReceived } from './react/features/subtitles';
+import { ... | [No CFG could be retrieved] | Imports a bunch of components that are used by the jitsi - meet library. The name of the room to use for the authentication. | style: sort alphabetically by path |
@@ -9,11 +9,13 @@
<button id="reaction-butt-readinglist" class="article-reaction-butt readinglist-reaction-button" data-category="readinglist" alt="unicorn-emoji" title="reading list">
<img alt="reading list" src="<%= asset_path("emoji/emoji-one-bookmark.png") %>" /><span class="reaction-number" id="reactio... | [No CFG could be retrieved] | Renders a hidden section of the page that contains a bunch of actions that can be performed on Renders a single - node . | unrelated, but I noticed this when opening the file to understand the HTML. Let me know if I should remove it We should "parameterize" the `#DEVcommunity` for twitter shares as well but it's outside the scope |
@@ -195,6 +195,7 @@ class AdSenseNetworkConfig {
return dict({
'type': 'adsense',
'data-ad-client': this.autoAmpAdsElement_.getAttribute('data-ad-client'),
+ 'data-ad-host': this.autoAmpAdsElement_.getAttribute('data-ad-host'),
});
}
| [No CFG could be retrieved] | A config for an AMP AMP network. A DoubleclickNetworkConfig class that provides a way to configure the network configuration of a double. | Could you modify the logic so that we only add this property into the dict if the data-ad-host attribute is present on this.autoAmpAdsElement_. The return type of this function (!JsonObject<string, string>) would imply that values can't be null. I know that it's not actually type-safe for data-ad-client, but that is a ... |
@@ -1017,7 +1017,7 @@ func (d *driver) deleteRepo(txnCtx *txnenv.TransactionContext, repo *pfs.Repo, f
// and traverse parent
curInfo := &pfs.CommitInfo{}
if err := d.commits(subv.Lower.Repo.Name).ReadWrite(txnCtx.Stm).Get(cur, curInfo); err != nil {
- return fmt.Errorf("error reading commitI... | [getTreeForOpenCommit->[scratchFilePrefix],finishOutputCommit->[checkIsAuthorizedInTransaction],upsertPutFileRecords->[scratchFilePrefix],deleteFile->[makeCommit,inspectCommit,checkIsAuthorized],listRepo->[getAccessLevel],scratchFilePrefix->[scratchCommitPrefix,checkFilePath],resolveCommitProvenance->[resolveCommit],ge... | deleteRepo deletes a repository commitInfo - proto. This function is called to get the current commit and traverse the tree of commits to find the delete all branches from the repository and all commits from the repository ErrNotActivated - Error not activated. | tangential, but this, L1050, and L1622 should use `%s@%s` |
@@ -4,6 +4,7 @@
# ------------------------------------
import logging
import os
+import six
from .._constants import EnvironmentVariables
from .._internal import get_default_authority, normalize_authority
| [DefaultAzureCredential->[get_token->[get_token]]] | Creates an access token object. | This is unused now |
@@ -1,3 +1,5 @@
-<a href="/code-of-conduct" class="crayons-link crayons-link--brand">Code of Conduct</a>
-<span class="opacity-25 px-2">•</span>
-<a href="/report-abuse" class="crayons-link crayons-link--brand">Report abuse</a>
+<p class="fs-s align-center">
+ <a href="/code-of-conduct" class="crayons-link crayon... | [No CFG could be retrieved] | Displays a list of all possible crayons for a given code of conduct. | There's probably a more semantic choice for this group of items. I'm thinking a `<nav>` with an aria-label on it like "Conduct controls" and/or wrapping these items in a UL and LI's. |
@@ -78,11 +78,10 @@ public class ReloadJobCommand extends CLICommand {
}
if(job == null) {
- // TODO: JENKINS-30785
- AbstractProject project = AbstractProject.findNearest(job_s);
+ AbstractItem project = Items.findNearest(Abst... | [ReloadJobCommand->[run->[findNearest,getFullName,IllegalArgumentException,getMessage,AbortException,getName,size,doReload,getActiveInstance,getItemByFullName,checkPermission,println,log,format,addAll],getShortDescription->[ReloadJobCommand_ShortDescription],getLogger,getName]] | Checks if a exists in the list of jobs. | Why not `Item` then? |
@@ -212,6 +212,10 @@ class SubmissionCollector < ActiveRecord::Base
grouping.save
new_submission = Submission.create_by_revision_number(grouping, rev_num)
+ if apply_late_penalty
+ new_submission = grouping.assignment.submission_rule
+ .apply_submission_rule(new_submiss... | [SubmissionCollector->[collect_next_submission->[instance,remove_grouping_from_queue],start_collection_process->[instance],manually_collect_submission->[start_collection_process,remove_grouping_from_queue]]] | This method is called by the child process when it is able to collect a specific from. | Useless assignment to variable - `new_submission`. |
@@ -20,15 +20,6 @@ namespace Dynamo.ViewModels
}
}
- [JsonIgnore]
- public bool IsPython2ObsoleteDebugModeEnabled
- {
- get
- {
- return DebugModes.IsEnabled("Python2ObsoleteMode");
- }
- }
-
/// <summary>
... | [ViewModelBase->[IsEnabled]] | - A base class for all of the events that are held by other references. | why is this removed? |
@@ -924,6 +924,11 @@ void kill_screen(const char* lcd_msg) {
return mesh_edit_value;
}
+ float lcd_manual_probe() {
+ lcd_goto_screen(_lcd_mesh_edit_NOP);
+ _lcd_manual_probe(PSTR("Z compensation"));
+ return mesh_edit_value;
+ }
void lcd_mesh_edit_setup(float initial) {
m... | [No CFG could be retrieved] | Menu that displays the LCD view when the user clicks on the LCD view. Menu item for LCD panel. | @Roxy-3D How does other code manage interaction with the LCD without requiring `_lcd_mesh_edit_NOP` and other hacks? Take a look at the methods used by `gcode_M600` to take over the controller for display and feedback purposes. Take a look at how `LCD_BED_LEVELING` does its UI as an LCD-initiated process. For U.B.L. I'... |
@@ -67,10 +67,8 @@ export class BaseCarousel extends AMP.BaseElement {
this.prevButton_ = this.element.ownerDocument.createElement('div');
this.prevButton_.classList.add('amp-carousel-button');
this.prevButton_.classList.add('amp-carousel-button-prev');
- this.prevButton_.setAttribute('role', 'button'... | [No CFG could be retrieved] | Initializes the carousel. This method is used to build the UI for the next item in the list. | I would use aria-hidden here to completely hide them from screen-readers. |
@@ -1,4 +1,4 @@
-import re
+import re, itertools,nltk, json
from collections import defaultdict
from typing import Any, DefaultDict, Dict, List, Tuple, Union, Set
| [TableQuestionKnowledgeGraph->[_get_cell_parts->[_normalize_string]]] | Imports all the modules that are imported from the allennlp. core. grammar. TableQuestionKnowledgeGraph represents the linkable entities in a table and a question. | Pylint is going to complain about this. You can run pylint locally with `./scripts/pylint.sh` (and mypy with `./scripts/mypy.sh`). I'll hold off on listing things that pylint would catch for you. If you have any questions about pylint or other test failures you're getting, just ask. |
@@ -628,8 +628,9 @@ function settings_post(&$a) {
if(($old_visibility != $net_publish) || ($page_flags != $old_page_flags)) {
// Update global directory in background
$url = $_SESSION['my_url'];
- if($url && strlen(get_config('system','directory')))
+ if ($url && strlen(get_config('system','directory'))) {
... | [settings_content->[get_baseurl,get_hostname,get_path],settings_post->[get_baseurl,discover]] | POST to the settings page Save or update a user s security token. This function is called from the user s administration screen. It sets the default configuration for inserts a new mailaccount into the db This function is called when the user is connected to the email account. | Standards: Could you please add a space after the `if`? |
@@ -27,6 +27,9 @@ def imp_url(
out = resolve_output(url, out)
path, wdir, out = resolve_paths(self, out)
+ if to_remote and no_exec:
+ raise ValueError("to-remote option can't be combined with no_exec")
+
# NOTE: when user is importing something from within their own repository
if (
... | [imp_url->[relpath,remove,abspath,OutputDuplicationError,create_stage,resolve_output,path_isin,restore_meta,Dvcfile,set,run,resolve_paths,exists,dump,check_modified_graph,ignore_outs]] | Imports a single from a URL. | We tend to use `InvalidArgumentError` for this. You can also call the options by their CLI names and then you won't really need same checks in CLI. E.g. see dvc/repo/run.py. |
@@ -95,12 +95,12 @@ void ProfilerGraph::draw(s32 x_left, s32 y_bottom, video::IVideoDriver *driver,
s32 texth = 15;
char buf[10];
- snprintf(buf, 10, "%.3g", show_max);
+ porting::mt_snprintf(buf, 10, "%.3g", show_max);
font->draw(utf8_to_wide(buf).c_str(),
core::rect<s32>(textx, y - graphh, textx2,
... | [draw->[draw,Meta,find,draw2DLine,utf8_to_wide,v2s32,end,snprintf],put->[begin,emplace_back,erase,size]] | Draw a graph of the content of a block of content. region Private functions This method is called from the main loop of the graph generation code. It is called by. | Looks like a superfluous change. The size of the resulting string is known and there are no `%1$s` replacements. |
@@ -44,6 +44,7 @@ from .linalg import cross # noqa: F401
from .linalg import cholesky # noqa: F401
from .linalg import bmm # noqa: F401
from .linalg import histogram # noqa: F401
+from .linalg import bincount # noqa: F401
from .linalg import mv # noqa: F401
from .linalg import eig # noqa: F401
from .linalg... | [No CFG could be retrieved] | Import all of the functions that are imported from the creation. This function imports the logic from the base class. | we shall also add bincount in tensor_method_func list below to get paddle.Tensor.bincount |
@@ -43,6 +43,13 @@ namespace Content.Server.GameObjects.Components.Metabolism
serializer.DataField(this, b => b.NeedsGases, "needsGases", new Dictionary<Gas, float>());
serializer.DataField(this, b => b.ProducesGases, "producesGases", new Dictionary<Gas, float>());
serializer.Data... | [MetabolismComponent->[ProcessGases->[NeedsAndDeficit,ClampDeficit,GasProduced],GasProduced->[GasProducedMultiplier],GasMixture->[Transfer],Update->[ProcessGases,ProcessNutrients],ExposeData->[ExposeData]]] | Override this method to add additional data to the need and deficit blocks. | Maybe you should give those default values some sane numbers other than 0, just in case someone forgets to set them |
@@ -1336,9 +1336,12 @@ int HTTPClient::handleHeaderResponse()
break; // We found a match, stop looking
}
}
+ continue;
}
- if(headerLine == "") {
+ headerLine.trim(); // remove \r
+
+ if (header... | [PUT->[PUT],setURL->[beginInternal,disconnect,clear],connected->[connected],connect->[setTimeout,connected,connect,verify,create],POST->[POST],writeToStream->[connected,disconnect],getStream->[connected],returnError->[errorToString,connected],sendRequest->[setURL,connected,sendRequest],errorToString->[String],handleHea... | Handle a response header. Check if there is a match in the headers. If there is a match return the next. | Is this continue correct? |
@@ -229,7 +229,8 @@ export class AmpAd3PImpl extends AMP.BaseElement {
// incrementLoadingAds().
this.emitLifecycleEvent('adRequestStart');
const iframe = getIframe(this.element.ownerDocument.defaultView,
- this.element, undefined, opt_context);
+ this.element, this.element.getAtt... | [No CFG could be retrieved] | Gets intersection element layout box. This method is called when the layout is complete. | this.element.getAttribute('type') gets called three times in this class. Can we store the type as an attribute directly on the class instead? |
@@ -17,6 +17,17 @@ import javax.sql.DataSource;
public abstract class AbstractConnectionFactory implements ConnectionFactory
{
+ /**
+ * Ensures DriverManager classloading takes place before any connection creation.
+ * It prevents a JDK deadlock that only occurs when two JDBC Connections of different DB... | [AbstractConnectionFactory->[create->[ConnectionCreationException,doCreateConnection]]] | Creates a connection with a sequence number that can be used to retrieve a connection from the database. | If I'm understanding this correctly, this static block will be executed the first time the AbstractConnectionFactory class is referenced. If there are two applications, each one having their own drivers, then the problem still exists as the initialization will occur during the first app deployment, but not in the secon... |
@@ -30,7 +30,7 @@ public class JmxAgentDefaultConfigurationWithRMITestCase extends FunctionalTestC
FixedHostRmiClientSocketFactory rmiSocketFactory = new FixedHostRmiClientSocketFactory();
try
{
- Socket socket = rmiSocketFactory.createSocket("localhost", 1099);
+ Socket... | [JmxAgentDefaultConfigurationWithRMITestCase->[testDefaultJmxAgent->[FixedHostRmiClientSocketFactory,createSocket,fail,close]]] | Test the default JMX agent. | why the +1? how do you know that port is not taken? |
@@ -34,9 +34,9 @@ To create a new application, you can use the example app source. Login to your s
run new-app:
$ %[1]s login
- $ %[1]s new-app openshift/ruby-20-centos7~https://github.com/openshift/ruby-hello-world.git
+ $ %[1]s new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-hello-world.git
... | [NewCmdEdit,UsageFunc,NewCmdRun,NewCmdScale,NewCmdReplace,NewCmdDeploy,NewCmdAnnotate,NewCmdWhoAmI,NewCmdDelete,NewCmdPatch,NewCmdAttach,NewCmdTag,NewCmdPolicy,NewCmdCancelBuild,NewCmdLogin,NewCmdConfig,NewCmdProxy,Add,NewCmdExport,Set,NewCmdRsh,GLog,NewCmdLogs,DefaultSubCommandRun,NewCmdRsync,NewCmdLogout,NewCmdExpose... | CLI CLI API NewCommandCLI creates a new command that can be used to create a new - app. | Just out of curiosity, are we planning to update those regularly? I understand that for tests the answer is - yes, unless we introduce global constants to simplify that process? Or this is just one time issue, again does not apply to tests. |
@@ -103,6 +103,18 @@ class Predictor(Registrable):
"""
raise NotImplementedError
+ def predictions_to_labels(self, instance: Instance, outputs: Dict[str, np.ndarray]) -> List[Instance]:
+ """
+ Adds labels to the :class:`~allennlp.data.instance.Instance`s passed in.
+
+ Raise... | [Predictor->[_batch_json_to_instances->[_json_to_instance],capture_model_internals->[add_output]]] | Converts a JSON object into an instance. | This needs a better name. I picked this name originally before we decided that the return value should just be a list of `Instances`. Maybe `predictions_to_labeled_instances`? |
@@ -19,6 +19,14 @@
<%= render "comments/comment_date", decorated_comment: comment.decorate %>
</div>
<div class="body">
+ <% if comment.decorate.display_edited? %>
+ <div class="comment-edited-notice comment-date">
+ Edited
+ <time datetime="<%= comment.decorate.edited_timestamp %>">
+ ... | [No CFG could be retrieved] | Show the . | since this is the same as the other maybe it can be put in a partial to avoid possible discrepancies over time |
@@ -17,3 +17,4 @@ from __future__ import print_function
from .program_utils import *
from .ufind import *
from .checkport import *
+from .vars_distributed import *
| [No CFG could be retrieved] | Imports the uind and checkport modules. | util functions in `io.py` also need same operations? |
@@ -37,8 +37,11 @@ final class ApiLoader extends Loader
{
const ROUTE_NAME_PREFIX = 'api_';
const DEFAULT_ACTION_PATTERN = 'api_platform.action.';
+ const SUBRESOURCE_SUFFIX = '_get_subresource';
private $fileLoader;
+ private $propertyNameCollectionFactory;
+ private $propertyMetadataFactory... | [ApiLoader->[addRoute->[add,resolveOperationPath,has],loadExternalFiles->[load,addCollection],load->[addResource,create,getItemOperations,getCollectionOperations,getShortName,loadExternalFiles,addRoute],__construct->[locateResource]]] | Loads a single API specification. The route collection. | Is this really necessary? To ease using API Platform as a standalone lib, it would be nice to be able to not provide those instance (and then loose subresource support) |
@@ -139,6 +139,17 @@ Status SQLiteDatabasePlugin::get(const std::string& domain,
return Status(1);
}
+Status SQLiteDatabasePlugin::get(const std::string& domain,
+ const std::string& key,
+ int& value) const {
+ std::string result;
+ auto s = this-... | [int->[],removeRange->[rand,Status,sqlite3_finalize,c_str,sqlite3_prepare_v2,tryVacuum,sqlite3_step,sqlite3_bind_text],get->[Status,size,c_str,sqlite3_free,sqlite3_exec],scan->[Status,c_str,push_back,sqlite3_free,sqlite3_exec],close->[sqlite3_close],remove->[rand,Status,sqlite3_finalize,c_str,sqlite3_prepare_v2,tryVacu... | Get the value of a key in a given domain. | Please use safeStringTo* here if possible |
@@ -780,6 +780,11 @@ func (g *generator) escapeString(v string) string {
if c == '"' || c == '\\' {
builder.WriteRune('\\')
}
+ if c == '\n' {
+ builder.WriteRune('\\')
+ builder.WriteRune('n')
+ continue
+ }
builder.WriteRune(c)
}
return builder.String()
| [GenFunctionCallExpression->[GenFunctionCallExpression],GenTemplateExpression->[GenLiteralValueExpression],genLiteralValueExpression->[genLiteralValueExpression],GenUnaryOpExpression->[GetPrecedence],GenBinaryOpExpression->[GetPrecedence],literalKey->[GenTemplateExpression,GenLiteralValueExpression],genStringLiteral->[... | escapeString escapes a string with double quotes. | It would be more idiomatic here to use raw string literals (which are escaped with `` ` ``) or to put each string literal on its own line and concatenate them, but what you have is simpler. You might file a follow-up issue to track generating the more idiomatic code. |
@@ -977,7 +977,12 @@ func (f5 *f5LTM) AddVtep(ipStr string) error {
Name: macAddr,
Endpoint: ipStr,
}
- return f5.post(url, payload, nil)
+ err = f5.post(url, payload, nil)
+ if err != nil && err.(F5Error).httpStatusCode != HTTP_CONFLICT_CODE {
+ // error HTTP_CONFLICT_CODE is fine, it just means the fdb e... | [restRequestPayload->[restRequest],ensureVserverHasIRule->[get,patch],InsecureRouteExists->[routeExists],DeletePassthroughRoute->[getPassthroughRoutes,updatePassthroughRoutes],deleteRoute->[delete],associateClientSslProfileWithVserver->[post],createClientSslProfile->[post],get->[restRequest],uploadCert->[post,buildSshA... | AddVtep adds a vtep to the F5 LTM. | We're sure it'll always be an F5Error type returned from f5.post()? Might be safer to check the cast and always return the error if !err.(F5Error) |
@@ -41,4 +41,9 @@ public interface StatusHistory {
* @return List of snapshots for a given component
*/
List<StatusSnapshot> getStatusSnapshots();
+
+ /**
+ * @return <code>true</code> if counter values are included in the Status History
+ */
+ boolean isIncludeCounters();
}
| [No CFG could be retrieved] | Get a list of all status snapshots. | If we're able to remove the flag from the `StatusHistoryDTO`, we may also be able to remove this one. |
@@ -101,13 +101,15 @@ describe Users::PasswordsController, devise: true do
stub_analytics
allow(@analytics).to receive(:track_event)
- params = { password: 'password', reset_password_token: 'foo' }
+ password = 'a really long passw0rd'
- user = instance_double('User', uuid: '1... | [redirect_to,context,to,describe,uuid,build_stubbed,render_template,get,receive,eq,instance_double,role,with,t,it,require,put,and_return] | user submits invalid new password and redirects to sign in page Describe the actions that can be performed on a user object. | is setting UUID necessary? |
@@ -916,9 +916,8 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
// no parameter provided; just use the original size of the volume
newSize = volume.getSize();
}
-
+ newSizeInGb = newSize >> 30;
newMinIops = cmd.g... | [VolumeApiServiceImpl->[handleVmWorkJob->[handleVmWorkJob],orchestrateExtractVolume->[orchestrateExtractVolume],attachVolumeToVmThroughJobQueue->[VmJobVolumeOutcome],createVolumeFromSnapshot->[createVolumeFromSnapshot],migrateVolumeThroughJobQueue->[VmJobVolumeOutcome],detachVolumeFromVmThroughJobQueue->[VmJobVolumeOut... | Resizes a volume. Get the next unused block of space to allocate. Returns a that can be used to find a new volume offering. This method checks if the volume is in a managed state and if so checks if there are This method is called when a volume is in the allocated state and if it is in the This method is called when a... | Let's not use bit shift here. It makes things harder to read and understand. The code is already convoluted enough |
@@ -482,6 +482,8 @@ class DistanceSpec(UnitsSpec):
class NullDistanceSpec(DistanceSpec):
+ _value_type = Nullable(Float)
+
def __init__(self, default=None, units_default="data", help=None) -> None:
super().__init__(default=default, units_default=units_default, help=help)
self._type = Null... | [field->[Field],value->[Value],expr->[Expr],UnitsSpec->[make_descriptors->[make_descriptors],to_serializable->[get_units]],ColorSpec->[to_serializable->[isconst],prepare_value->[is_color_tuple_shape]]] | Initialize a sequence with default units and default units. | @bryevdv, at this point, I'm not sure what to expect from this property type. Does it support `null` or `{value: null}` or both? |
@@ -969,8 +969,14 @@ int CRYPTO_gcm128_aad(GCM128_CONTEXT *ctx, const unsigned char *aad,
}
#endif
if (len) {
+ i = 0;
n = (unsigned int)len;
- for (i = 0; i < len; ++i)
+ if(len >= 8)
+ {
+ ctx->Xi.u[0] ^= *(u64*)(aad);
+ i=8;
+ }
+ for (; i... | [No CFG could be retrieved] | - 1 = no - match ; - 2 = no - match ; - 3 = no The function that implements the function of the gcm128_gcm128. n = 0 ;. | This makes an assumption that platform can tolerate unaligned references to memory. Even though most popular one does, it's not safe assumption to make. Because OpenSSL is multi-platform. |
@@ -32,6 +32,11 @@ import org.slf4j.LoggerFactory;
public class KsqlAuthorizationFilter implements ContainerRequestFilter {
private static final Logger log = LoggerFactory.getLogger(KsqlAuthorizationFilter.class);
+ private static final Set<String> UNAUTHORIZED_ENDPOINTS = ImmutableSet.of(
+ "/metadata",
+... | [KsqlAuthorizationFilter->[filter->[getMethod,getMessage,getUserPrincipal,getName,abortWith,accessDenied,checkEndpointAccess,format,warn,getPath],getLogger]] | Provides a filter which checks if a request is allowed to access the requested resource. | Would be good to pick these up from constants in `ServerMetadataResource`... |
@@ -645,7 +645,7 @@ func emailAddressProcessor(ctx *postProcessCtx, node *html.Node) {
// linkProcessor creates links for any HTTP or HTTPS URL not captured by
// markdown.
func linkProcessor(ctx *postProcessCtx, node *html.Node) {
- m := linkRegex.FindStringIndex(node.Data)
+ m := xurls.Strict().FindStringIndex(nod... | [visitNodeForShortLinks->[visitNodeForShortLinks],Error->[Error],visitNode->[visitNode]] | Processor creates a processor that creates a link to the SHA1 hash if it does not. | The result of `xurls.Strict()` should be cached - it compiles several regexps. |
@@ -91,10 +91,12 @@ public class SpringWebMvcTracer extends BaseTracer {
}
private void onRender(Span span, ModelAndView mv) {
- span.setAttribute("spring-webmvc.view.name", mv.getViewName());
- View view = mv.getView();
- if (view != null) {
- span.setAttribute("spring-webmvc.view.type", spanName... | [SpringWebMvcTracer->[startSpan->[startSpan],SpringWebMvcTracer]] | On render. | Why the hell anybody could want this?? |
@@ -1033,11 +1033,8 @@ class Installer
$package->setReplaces($newPackage->getReplaces());
}
- if ($task === 'force-updates' && $newPackage && (
- (($newPackage->getSourceReference() && $newPackage->getSourceReference() !== $packag... | [Installer->[whitelistUpdateDependencies->[packageNameToRegexp],disablePlugins->[disablePlugins],setClassMapAuthoritative->[setOptimizeAutoloader]]] | Process dev packages. Finds packages that are similar to the current one. get all packages that are not in the package list. | Are you sure about this change ? I don't think it is right regarding the operator precedence |
@@ -260,7 +260,8 @@ class RepoUnitAssociationManager(object):
importer_instance, plugin_config = plugin_api.get_importer_by_id(dest_repo_importer['importer_type_id'])
call_config = PluginCallConfiguration(plugin_config, dest_repo_importer['config'], import_config_override)
- conduit = ImportU... | [remove_from_importer->[create_transfer_units,calculate_associated_type_ids],RepoUnitAssociationManager->[associate_all_by_ids->[associate_unit_by_id]]] | Associate units from a source repository to a destination repository. This function returns a list of key types that can be imported by the source repository and the Import units from source repository to destination repository. | Is there a corresponding unittest to make sure the owner_type and owner_id are set correctly? |
@@ -748,6 +748,7 @@ def generate_package_index(cache_prefix):
# s = Spec.from_yaml(yaml_obj)
s = Spec.from_yaml(yaml_contents)
db.add(s, None)
+ db.mark(s, 'cache_exists', True)
except (URLError, web_util.SpackWebError) as url_err:
tty.error('Error... | [make_package_relative->[read_buildinfo_file],clear_spec_cache->[clear],update_cache_and_get_specs->[get_all_built_specs,update],push_keys->[generate_key_index],read_buildinfo_file->[buildinfo_file_name],write_buildinfo_file->[get_buildfile_manifest,buildinfo_file_name],check_specs_against_mirrors->[needs_rebuild],sele... | Create the build cache index page. Get a from the index. json and index. hash. | do we want a separate `mark()` routine or just an optional dictionary arg passed with `add()`? Asking b/c they're only used together right now, and this is two write transactions (if not nested in a larger one, which I believe this is). I think it will be easy to forget that lock/read/write/unlock twice, accidentally, ... |
@@ -355,6 +355,13 @@ pool_prop_default_copy(daos_prop_t *prop_def, daos_prop_t *prop)
entry_def->dpe_val = entry->dpe_val;
break;
case DAOS_PROP_PO_ACL:
+ if (entry->dpe_val_ptr != NULL) {
+ pool_prop_copy_ptr(entry_def, entry,
+ pool_prop_acl_get_length(entry));
+ if (entry_def->dpe_val_ptr == N... | [No CFG could be retrieved] | copy all the properties from one uuid pool to another Writes the values of the n - ary properties to the DAOS DAOS D. | [Style] No "{}", please? |
@@ -48,6 +48,9 @@ const TIMEOUT_LIMIT = 10000; // 10 seconds
/** @const {string} */
const GLASS_PANE_CLASS = 'i-amphtml-glass-pane';
+/** @const {string} */
+const DESKTOP_FULLBLEED_CLASS = 'i-amphtml-story-desktop-fullbleed';
+
/** @enum {string} */
const PageAttributes = {
LOADING: 'i-amphtml-loading',
| [No CFG could be retrieved] | Imports an object that can be used to create an AMPHTML page. A page that exports an individual . | Should we add another prefix to make it different from the class the AMP Story runtime uses? I'm afraid of CSS properties collisions eventually |
@@ -849,7 +849,7 @@ namespace System.Text.RegularExpressions
private static bool CharInCategory(char ch, string set, int start, int mySetLength, int myCategoryLength)
{
- UnicodeCategory chcategory = CharUnicodeInfo.GetUnicodeCategory(ch);
+ UnicodeCategory chcategory = char.Ge... | [RegexCharClass->[AddDigit->[AddCategoryFromName,AddSet],SetDescription->[SetDescription,IsNegated],AddLowercaseRange->[AddRange],ToStringClass->[ToStringClass],AddWord->[AddSet,AddCategory],AddCategoryFromName->[AddSet],CharInClassRecursive->[CharInClassRecursive],AddSpace->[AddSet,AddCategory]]] | check if ch is in the set of characters. | For my learning benefit - what's the difference here? is `char.GetUnicodeCategory` faster when the char is Latin1? |
@@ -54,6 +54,8 @@ type DeploymentStrategy struct {
CustomParams *CustomDeploymentStrategyParams `json:"customParams,omitempty"`
// RecreateParams are the input to the Recreate deployment strategy.
RecreateParams *RecreateDeploymentStrategyParams `json:"recreateParams,omitempty"`
+ // Compute resource requirements... | [No CFG could be retrieved] | DeploymentStrategy is a type that can be used to deploy a single container. | If `Resources` can be empty (and json omitted), shouldn't it be a pointer? |
@@ -347,6 +347,10 @@ module.exports = EntityGenerator.extend({
this.warning('service is missing in .jhipster/' + this.name + '.json, using no as fallback');
this.service = 'no';
}
+ if (_.isUndefined(this.entityTableName)) {
+ this.warning('entity... | [No CFG could be retrieved] | Private methods - Check if the entity is missing missing properties - Check if the entity is missing missing - data - relationships - fields - service - table - name - data - relationships -. | can we have message as `using entity name as fallback`? |
@@ -180,7 +180,14 @@ func (o *TagOptions) Complete(f *clientcmd.Factory, cmd *cobra.Command, args []s
sourceKind := o.sourceKind
if len(sourceKind) > 0 {
- sourceKind = determineSourceKind(f, sourceKind)
+ var err error
+ sourceKind, err = determineSourceKind(f, sourceKind)
+ if err != nil {
+ return... | [Validate->[String,New],Run->[NameString,Delete,RetryOnConflict,IsZero,SplitImageStreamTag,Exact,IsForbidden,Errorf,Create,Fprintln,JoinImageStreamTag,IsMethodNotSupported,Get,Update,Fprintf,ImageStreams,Sprintf,IsNotFound,ImageStreamTags],Complete->[DefaultNamespace,Has,Image,Join,Infof,ParseDockerImageReference,Get,I... | Complete takes a source and destination and options and completes the tag creation This function is only allowed when providing a Docker image Error is called when an invalid pull spec is used to tag an image stream. | You don't need this check, this is being checked outside of this condition, already. All in all, the current changes are only cosmetic, I'm not sure we need it. But thanks for the help :) |
@@ -178,6 +178,10 @@ function mapStateToProps(state, ownProps): Object {
const audioMediaState = getParticipantAudioMediaState(participant, _isAudioMuted, state);
const videoMediaState = getParticipantVideoMediaState(participant, _isVideoMuted, state);
const { disableModeratorIndicator } = state['feature... | [No CFG could be retrieved] | Maps the redux state of the component to the associated props for this component. | Why don't we just pass the `participant` object here? |
@@ -231,6 +231,7 @@ int SocketConnect(const char *host, const char *port,
{
Log(LOG_LEVEL_ERR, "Couldn't open a socket. (socket: %s)",
GetErrorStr());
+ ap = ap->ai_next;
}
else
{
| [ReceiveTransaction->[ConnectionInfoSocket,sscanf,ConnectionInfoProtocolVersion,TLSRecv,UnexpectedError,LogRaw,ProgrammingError,RecvSocketStream,Log,ConnectionInfoSSL],SetReceiveTimeout->[assert,Log,setsockopt],SendTransaction->[ConnectionInfoSocket,memcpy,ConnectionInfoProtocolVersion,SendSocketStream,TLSSend,strlen,L... | Connect to a socket and return the number of bytes transferred. Try to bind to the specified interface. | Identical to last line of the else clause; so it would be better to do this _after_ the branching, so both branches do it, without repeating the line of code. Will fix. |
@@ -97,7 +97,7 @@ func (mp *mockProvisionee) GetLogFactory() rpc.LogFactory {
var ErrHandleHello = errors.New("handle hello failure")
var ErrHandleDidCounterSign = errors.New("handle didCounterSign failure")
-var testTimeout = time.Duration(20) * time.Millisecond
+var testTimeout = time.Duration(50) * time.Millisec... | [HandleHello->[Sleep,HelloRes],HandleDidCounterSign->[Sleep],DeviceID,Error,UID,TODO,Background,New,WithCancel,Duration,Fatalf,Read,EncodeToString,Sleep,NewSimpleLogFactory,Verbose] | HandleHello implements the HandleHello interface for mockProvisionee. | Strictly to accommodate AppVeyor |
@@ -0,0 +1,13 @@
+package games.strategy.engine.lobby;
+
+import lombok.AllArgsConstructor;
+
+/** Simple value object to encapsulate a player name and provide strong typing. */
+@AllArgsConstructor(staticName = "of")
+public class PlayerName {
+ private final String name;
+
+ public String getValue() {
+ return n... | [No CFG could be retrieved] | No Summary Found. | Same here with the encapsulation. However I can't really think of any precodition we'd want to have on a playername, except maybe for name limitations? |
@@ -36,13 +36,14 @@ import {twitter} from './twitter';
import {register, run} from '../src/3p';
import {parseUrl} from '../src/url';
import {assert} from '../src/asserts';
+import {taboola} from '../ads/taboola';
/**
* Whether the embed type may be used with amp-embed tag.
* @const {!Object<string: boolean>}
... | [No CFG could be retrieved] | Provides a simple way to register all known ad network factories and execute a single . Draws a on the 3p context. | I added a mechanism to whitelist which embed types are allowed to use `amp-embed`. After rebasing add yourself to `AMP_EMBED_ALLOWED` in this file. |
@@ -1250,6 +1250,13 @@ public class DeckPicker extends NavigationDrawerActivity implements
});
}
+ public void doMigration(SupportSQLiteDatabase db, int oldVersion, int newVersion) {
+ Timber.d("doMigration() from %s to %s", oldVersion, newVersion);
+ if (oldVersion < 20900151 && newVer... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],mediaCheck->[onPostExecute->[showMediaCheckDialog]],updateDeckList->[onPostExecute->[showCollectionErrorDialog,scrollDecklistToDeck]],onDestroy->[onDestroy],onOptionsItemSelected->[onOptionsItemSelected],onCreate->[onCreate],openStudyOptions->[loadStudyOptionsFragm... | Launch a repair dialog and check if the lease is in the database. restart the app. | After all the infrastructure, this is where the rubber meets the road. For every delta between database versions, we get to inspect the delta and do the needful. Here I trigger the integrityCheck() we want for anyone crossing the line from before 2.9alpha51 to after it. If this works for you we just need to remove the ... |
@@ -29,3 +29,6 @@ myinstance = Instance("instance",
name="myvm",
value=pulumi.Output.secret("secret_value"))
invoke_result = do_invoke()
+
+
+pulumi.export("instance_public_ip", myinstance.public_ip)
| [Instance->[__init__->[dict,TypeError,super]],MyComponent->[__init__->[TypeError,super,from_input]],do_invoke->[invoke],Instance,secret,MyComponent,do_invoke] | This is the main entry point for the myvm module. It is the main entry point. | Uber-nit: two empty lines |
@@ -8,9 +8,10 @@ import java.util.Map;
* sends more than "N" messages will be filtered until the next time window begins.
*/
class ChatFloodControl {
- private static final int ONE_MINUTE = 60 * 1000;
static final int EVENTS_PER_WINDOW = 20;
+ private static final int ONE_MINUTE = 60 * 1000;
static final i... | [ChatFloodControl->[allow->[clear,containsKey,put,get],Object,currentTimeMillis]] | Chat flood control. | This is an exception to the decreasing order of accessibility rule. DeclarationOrder permits a field with higher accessibility to appear after a field with lower accessibility if the initialization of the former depends on the latter, as it does in this case. |
@@ -77,6 +77,14 @@ app.get('/accounts/:address', async (req, res) => {
address = Web3.utils.toChecksumAddress(address)
+ // If it's a proxy, make sure we're checking with the owner account address
+ if (await isContract(address)) {
+ console.log(`${address} is a proxy!`)
+ return res.status(400).send('In... | [No CFG could be retrieved] | List all network network network network network network network network network network network network network network network network check if the given has a signature and update it if it doesn t exist. | Would it make sense to put this kind of util functionality somewhere in a class. I expect this kind of `isContract` / `isProxyAddress` check will be performed on many places. |
@@ -77,6 +77,10 @@ std::string MassConservationCheckProcess::Initialize(){
double inter_area = 0.0;
const auto& r_comm = mrModelPart.GetCommunicator().GetDataCommunicator();
+ ModelPart& non_const_model_part = const_cast<ModelPart&>(mrModelPart);
+ auto nodal_h_process = FindNodalHProcess<false>(non_c... | [No CFG could be retrieved] | Parameters - related parameters - - - - - - - - - - - - - - - - - -. | I think this is a leftover from one of our preliminary experiments. |
@@ -127,7 +127,8 @@ class RegularizedEvolution(BaseStrategy):
def _submit_config(self, config, base_model, mutators):
_logger.debug('Model submitted to running queue: %s', config)
model = get_targeted_model(base_model, mutators, config)
- submit_models(model)
+ if filter_model(self.... | [RegularizedEvolution->[_move_succeeded_models_to_population->[Individual],run->[mutate,random,best_parent]]] | Submit a config to the running queue. | If a model is ignored here, should `_running_models` have this model? |
@@ -3707,6 +3707,7 @@ namespace System.Runtime.Intrinsics.X86
public static new bool IsSupported { get { throw null; } }
public static uint MultiplyNoFlags(uint left, uint right) { throw null; }
public unsafe static uint MultiplyNoFlags(uint left, uint right, uint* low) { throw null; }
+ ... | [No CFG could be retrieved] | This is a static helper method that can be used to perform multiplication on the uint values. | nit: changes in `/ref` are not required for `internal` APIs. |
@@ -646,12 +646,11 @@ MSG_PROCESS_RETURN tls_process_key_update(SSL *s, PACKET *pkt)
return MSG_PROCESS_FINISHED_READING;
}
-#ifndef OPENSSL_NO_NEXTPROTONEG
/*
* ssl3_take_mac calculates the Finished MAC for the handshakes messages seen
* to far.
*/
-static void ssl3_take_mac(SSL *s)
+void ssl3_take_mac(... | [No CFG could be retrieved] | This function takes a key from the packet and checks if it is a valid key update type change cipher spec. | Removed code was checking return value from final_finish_mac, this one doesn't. Is it checked elsewhere? |
@@ -999,7 +999,9 @@ public abstract class SeekableStreamSupervisor<PartitionIdType, SequenceOffsetTy
throws ExecutionException, InterruptedException, TimeoutException, JsonProcessingException
{
possiblyRegisterListener();
+ stateManager.setState(SeekableStreamSupervisorStateManager.State.CONNECTING_TO... | [SeekableStreamSupervisor->[possiblyRegisterListener->[statusChanged->[RunNotice]],stopTasksInGroup->[stopTask,killTask],buildRunTask->[RunNotice],tryInit->[toString,handle],generateSequenceName->[toString],getTaskLocation->[getTaskId],addTaskGroupToActivelyReadingTaskGroup->[TaskData,TaskGroup],makeSequenceNumber->[ma... | This method is called by the TaskManager when it is ready to run. | How about `maybeSetState` instead of `setState`, since the majority of the time the state doesn't actually change, but the method name gives the impression it cycles through the states on every run. |
@@ -471,11 +471,15 @@ def ast_to_func(ast_root, dyfunc, delete_on_exit=True):
else:
module = SourceFileLoader(module_name, f.name).load_module()
func_name = dyfunc.__name__
- if not hasattr(module, func_name):
+ if hasattr(module, '__impl__'):
+ callable_func = getattr(module, '__impl__'... | [parse_arg_and_kwargs->[getfullargspec],is_dygraph_api->[is_api_in_module],RenameTransformer->[visit_Attribute->[get_attribute_full_name],rename->[visit]],ast_to_func->[remove_if_exit],NameNodeReplaceTransformer->[__init__->[visit]],ForNodeVisitor->[_get_iter_var_name->[is_for_iter,is_for_enumerate_iter,is_for_range_it... | Transform modified AST of decorated function into python callable object. | if we can't avoid check `__impl__`, I think we can change `__impl__` to a a more complex name such as `__i_m_p_l__`to avoid error handling for user-defined `__impl__` method |
@@ -30,6 +30,7 @@ const (
SIG_ID_LEN = 32
SIG_ID_SUFFIX = 0x0f
SIG_SHORT_ID_BYTES = 27
+ SigIDQueryMin = 16
)
const (
| [ToShortIDString->[ToBytes],ToMediumID->[toBytes],NotEqual->[Equal],ToShortID->[toBytes],Match->[IsNil,String],Exists->[IsNil],MarshalJSON->[String],Eq->[Eq],GetKeyType->[ToBytes],ToJsonw->[IsNil],Error] | Invite - specific functions for reading and parsing keybase objects. KIDFromString returns a new KID based on the given string. | can we make this ~8 characters; or ~6 characters? something more akin to short git hashes. |
@@ -6,7 +6,8 @@ public class ConfigureEndpointInMemoryPersistence : IConfigureEndpointTestExecut
{
public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings, PublisherMetadata publisherMetadata)
{
- configuration.UsePersistence<InMemoryPersistence>();
+ ... | [ConfigureEndpointInMemoryPersistence->[Task->[configuration,FromResult]]] | Configure and cleanup the configuration. | unless necessary, I'd vote to not "randomly configure" this setting. |
@@ -222,14 +222,14 @@ public final class ReverseBuildTrigger extends Trigger<Job> implements Dependenc
}
@Extension public static final class RunListenerImpl extends RunListener<Run> {
- @Override public void onCompleted(Run r, TaskListener listener) {
+ @Override public void onCompleted(@Nonn... | [ReverseBuildTrigger->[start->[start],buildDependencyGraph->[shouldTriggerBuild->[shouldTrigger]],stop->[stop],RunListenerImpl->[onCompleted->[shouldTrigger]]]] | On completed. | violates the contract on the superclass (where ironically Run can be null :-) ) |
@@ -2009,7 +2009,7 @@ void wallet2::process_new_transaction(const crypto::hash &txid, const cryptonote
tpool.submit(&waiter, boost::bind(&wallet2::check_acc_out_precomp_once, this, std::cref(tx.vout[i]), std::cref(derivation), std::cref(additional_derivations), i,
std::cref(is_out_data_ptr), std... | [No CFG could be retrieved] | region Transaction functions check if the i - th transaction is a valid key in the miner. | The section above seems to lack indication of exception failure. |
@@ -22,6 +22,10 @@ export default class JitsiStreamBlurEffect {
_maskFrameTimerWorker: Worker;
_maskInProgress: boolean;
_outputCanvasElement: HTMLCanvasElement;
+ _outputCanvasCtx: Object;
+ _segmentationMaskCtx: Object;
+ _segmentationMask: Object;
+ _segmentationMaskCanvas: Object;
_r... | [No CFG could be retrieved] | The JitsiStreamBlurEffect class. Loop function to render the background mask. | Check if we are still using all of these variables, and let's drop the ones we don't. |
@@ -325,7 +325,8 @@ def install_req_from_req_string(
PyPI.file_storage_domain,
TestPyPI.file_storage_domain,
]
- if req.url and comes_from.link.netloc in domains_not_allowed:
+ if req.url and comes_from and comes_from.link and \
+ comes_from.link.netloc in domains_not_allowed:
... | [install_req_from_editable->[parse_editable],parse_editable->[_strip_extras],install_req_from_line->[deduce_helpful_msg,_strip_extras]] | Install a requirement from a string. | My preference would be to use implied line continuation with parentheses rather than backslash (as in PEP 8 as well). |
@@ -1905,10 +1905,12 @@ public final class OzoneManager extends ServiceRuntimeInfoImpl
@Override
public void createBucket(OmBucketInfo bucketInfo) throws IOException {
try {
- if(isAclEnabled) {
+ if (isAclEnabled) {
checkAcls(ResourceType.VOLUME, StoreType.OZONE, ACLType.CREATE,
... | [OzoneManager->[listS3Buckets->[buildAuditMessageForFailure,buildAuditMessageForSuccess,checkAcls,buildAuditMap,listBuckets],completeMultipartUpload->[buildAuditMessageForFailure,buildAuditMessageForSuccess,completeMultipartUpload],getVolumeInfo->[checkAcls,getVolumeInfo],loginOMUserIfSecurityEnabled->[loginOMUser],joi... | Creates a bucket. | For write requests, this code is no more used. These changes need to be done in OMBucketcreateRequest#preExecute and OMVolumeCreateRequest#preExecute and the same thing needs to be done in S3BucketCreateRequest |
@@ -110,6 +110,11 @@ public class UnpackContent extends AbstractProcessor {
public static final String OCTET_STREAM = "application/octet-stream";
+ public static final String FILE_INNER_PERMISSION = "file.inner.permission";
+ public static final String FILE_INNER_OWNER = "file.inner.owner";
+ public s... | [UnpackContent->[ZipUnpacker->[unpack->[process->[fileMatches]]],TarUnpacker->[unpack->[process->[fileMatches]]]]] | The UnpackContent processor automatically adds those extensions if it is used to rebuild the original FlowFile The relationship REL_SUCCESS relationship is a relationship with the NE. | In my opinion the regular `file.*` attributes should be used and there's no need to introduce the "inner" ones. The properties of the source tar file will be preserved on the flowfile transferred to the `original` relationship and I don't think they are needed on the unpacked files. |
@@ -921,8 +921,8 @@ class Harvester extends BaseAligner implements IHarvester<HarvestResult> {
}
ncDI.close();
} catch (Exception e) {
- log.info("Exception raised in netcdfDatasetInfo ops: " + e);
- e.p... | [Harvester->[getCollectionFragmentParams->[getUuid],processServices->[saveMetadata],getAtomicFragmentParams->[getUuid],crawlDatasets->[harvest,crawlDatasets],addKeywords->[addAfter],createDIFMetadata->[saveMetadata,getUri],createMetadataUsingFragments->[harvest,deleteExistingMetadata,getUri],datasetChanged->[getUri]]] | This method creates the missing metadata elements in the catalog and adds them to the missing metadata elements This method checks if the DDF metadata is complete and if so creates a new object with This method opens the dataset to get the coordinate systems of the dataset and creates the necessary elements This method... | why not `log.error("Exception raised in netcdfDatasetInfo ops: " + e, e);` --log.error(e)-- |
@@ -132,4 +132,13 @@ public class ServiceConfigKeys {
// Group Membership authentication service
public static final String GROUP_OWNERSHIP_SERVICE_CLASS = GOBBLIN_SERVICE_PREFIX + "groupOwnershipService.class";
public static final String DEFAULT_GROUP_OWNERSHIP_SERVICE = "org.apache.gobblin.service.NoopGroupO... | [No CFG could be retrieved] | region Group Owner Authentication Service. | @aplex @sv2000, I will add a check in compiler to not produce job names more than this limit in the separate PR. |
@@ -36,11 +36,16 @@ public class AvroDataTranslator implements DataTranslator {
private final Schema ksqlSchema;
private final Schema avroCompatibleSchema;
+
public AvroDataTranslator(final Schema ksqlSchema) {
+ this(ksqlSchema, new HashMap<String, String>());
+ }
+
+ public AvroDataTranslator(final Sc... | [AvroDataTranslator->[replaceSchema->[replaceSchema,name],toKsqlRow->[toKsqlRow],TypeNameGenerator->[with->[TypeNameGenerator]],toConnectRow->[toConnectRow],buildAvroCompatibleSchema->[avroCompatibleFieldName,with,name,buildAvroCompatibleSchema]]] | Convert an Avro row to a KSQL row. | I would think this should be removed as we'll always want the schema name to be customisable. |
@@ -309,6 +309,12 @@ public interface ActiveMQServerLogger extends BasicLogger {
@Message(id = 221052, value = "trying to deploy topic {0}", format = Message.Format.MESSAGE_FORMAT)
void deployTopic(SimpleString topicName);
+ @LogMessage(level = Logger.Level.INFO)
+ @Message(id = 221053,
+ value = "Di... | [getMessageLogger,getName] | This method is called when a topic is being deployed and has not been stopped. | What is the reason for adding a new message here (with different ID) vs just adding the change to the existing message? |
@@ -98,6 +98,12 @@
* <td>The Hot Rod {@link org.infinispan.client.hotrod.configuration.ConfigurationBuilder#version(org.infinispan.client.hotrod.ProtocolVersion) version}.</td>
* </tr>
* <tr>
+ * <td><b>infinispan.client.hotrod.transport_factory</b></td>
+ * <td>String</td>
... | [No CFG could be retrieved] | This method returns a list of possible values for the Hot Rod configuration object. This method is called when a connection is requested from a server s pool. It can be. | Probably should mention class name? |
@@ -971,6 +971,10 @@ class Document:
refs = r.references()
check_integrity(refs)
+ # Currently not sure how to access messages inside this function
+ if len(messages['error']) or (len(messages['warning']) and settings.strict()):
+ raise RuntimeError("Erro... | [Document->[set_select->[select],from_json->[add_root,Document],_wrap_with_self_as_curdoc->[wrapper->[_with_self_as_curdoc]],replace_with_json->[from_json],from_json_string->[from_json],to_json_string->[StaticSerializer],apply_json_patch->[add_root],select_one->[select],apply_json_patch_string->[apply_json_patch],_dest... | Checks that the modes in the document are correct. | `settings.strict()` corresponds to `BOKEH_STRICT` this needs to be updated to process the new `settings.validation_exceptions()` instead |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.