patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1353,7 +1353,7 @@ MSG_PROCESS_RETURN tls_process_client_hello(SSL *s, PACKET *pkt)
*/
if (SSL_get_options(s) & SSL_OP_COOKIE_EXCHANGE) {
if (clienthello->dtls_cookie_len == 0)
- return 1;
+ return MSG_PROCESS_FINISHED_READING;
... | [No CFG could be retrieved] | The server side of the handshake process. - The key block that we will use for SCTP - Auth. | Matt, could you double-verify this line? |
@@ -369,6 +369,12 @@ def distribute(processing_mode,
[0, 2, 3, 4]
```
+ NOTE: The dispatcher server in the above mentioned examples is hosted at
+ `grpc://localhost:5000` for demonstration purposes. However, the hostname
+ and port can be modified as per the configuration and availability of
+ resources. Al... | [register_dataset->[register_dataset,_parse_service],distribute->[_distribute],_DataServiceDatasetV1->[__init__->[_DataServiceDatasetV2]],from_dataset_id->[_from_dataset_id],_from_dataset_id->[validate,_parse_service],_distribute->[_apply_fn->[_from_dataset_id],validate]] | A transformation that moves dataset processing to the tf. data service. This function is called by all training workers and the training jobs to read the last n - This function is used to distribute a single dataset to a single worker or a shared job. | I don't think this note is necessary when we use port 0. Using a non-"grpc" protocol is too advanced for this guide. I would remove this note. |
@@ -159,6 +159,14 @@ class InstallCommand(RequirementCommand):
cmd_opts.add_option(cmdoptions.no_clean())
+ cmd_opts.add_option(
+ '--require-hashes',
+ dest='require_hashes',
+ action='store_true',
+ help='Perform a provably repeatable installation by req... | [InstallCommand->[__init__->[no_binary,only_binary,no_deps,no_clean,make_option_group,src,install_options,global_options,constraints,no_use_wheel,super,use_wheel,insert_option_group,add_option,build_dir,pre,editable,requirements],run->[populate_requirement_set,hasattr,attrgetter,mkdtemp,ensure_dir,_build_package_finder... | Initialize command line options. Adds options related to a specific to the command line. | Should this be for `pip install` only? Does it make sense to be able to mandate hashes for `pip download` or `pip wheel` as well? |
@@ -93,7 +93,7 @@ namespace Content.Shared.Actions
serializer.DataReadFunction("description", string.Empty,
s => Description = FormattedMessage.FromMarkup(s));
- serializer.DataField(this, x => x.Requires,"requires", null);
+ serializer.DataField(this, x => x.Requir... | [BaseActionPrototype->[ValidateBehaviorType->[ErrorS,Name],LoadFrom->[TargetEntity,IconOn,ToList,DataReadFunction,Empty,DataField,BehaviorType,Toggle,None,DeselectWhenEntityNotClicked,Repeat,TargetPoint,DeselectOnCooldown,Icon,Requires,Invalid,NewReader,ErrorS,FromMarkup],TargetPoint,TargetEntity]] | Loads the properties of the action from the given mapping node. DataReadFunction - Filters and Keywords are read from serializer. DataReadFunction - Key. | null! is suss and this should be handled. |
@@ -62,7 +62,7 @@
</center>
<div class="container">
<% @articles.each do |article| %>
- <% @rating_vote = article.rating_votes.where(user_id: current_user.id).first %>
+ <% @rating_vote = @rating_votes.where(article: article).first %>
<% if !@rating_vote || article.last_buffered.nil? %>
... | [No CFG could be retrieved] | Displays a hidden hidden input with the tag list of all tags that are tagged with the current Renders a hidden field with a hidden field with a text area and a submit button to show. | this trick is to avoid too many queries. In the controller we load all rating votes of the articles of interest for the user, and here we filter that query with the subset pertaining the article in the loop |
@@ -448,9 +448,9 @@ public class BreakpointManager
{
globalDisplay_.showYesNoMessage(
MessageDialog.QUESTION,
- "Clear All Breakpoints",
- "Are you sure you want to remove all the breakpoints in this " +
- "project?",
+ constants_.clearAllBreakpointsCa... | [BreakpointManager->[prepareAndSetFunctionBreakpoints->[onResponseReceived->[setFunctionBreakpoints],setFunctionBreakpoints],FileFunction->[compareTo->[compareTo]],activateTopLevelBreakpoints->[notifyBreakpointsSaved],updatePackageBreakpoints->[prepareAndSetFunctionBreakpoints,notifyBreakpointsSaved],setFunctionBreakpo... | Clear all the breakpoints in the project. | Use a single string, not two strings concatenated together. |
@@ -26,6 +26,14 @@ def lines_to_set(str_or_list):
return set(x for x in str(str_or_list).split('\n') if x)
+def create_file_in(worktree, path, content):
+ """Creates a file in the given worktree, and returns its path."""
+ write_path = os.path.join(worktree, path)
+ with safe_open(write_path, 'w') as f:
+ ... | [ChangedIntegrationTest->[test_changed_options_scope_shadowing->[mutated_working_copy,create_isolated_git_repo],test_list_changed->[create_isolated_git_repo],test_changed_with_changes_since_transitive->[assert_changed_new_equals_old],test_changed_with_deleted_source->[create_isolated_git_repo],test_changed_diffspec_and... | Given a list of files append whitespace to each of them to trigger a git diff - then. | could probably re-use `BaseTest.{create_file,create_workdir_file}` here instead? |
@@ -561,6 +561,9 @@ public class ExplodedGraphWalker {
case METHOD_REFERENCE:
programState = programState.stackValue(constraintManager.createSymbolicValue(tree));
break;
+ case ASSERT_STATEMENT:
+ executeAssertStatement(tree);
+ return;
default:
}
| [ExplodedGraphWalker->[throwTooManyBooleanStates->[MaximumStepsReachedException],throwMaxSteps->[MaximumStepsReachedException],clearStack->[clearStack],checkExplodedGraphTooBig->[ExplodedGraphTooBigException],handleEndOfExecutionPath->[setNode],executeMethodInvocation->[execute],cleanupCondition->[cleanupCondition],Exp... | Visits a node in the CFG. Checks if a node in the tree tree is a node that can be represented as a constraint. | not directly related to your change, but why `org.sonar.java.se.CheckerDispatcher#syntaxNode` is a field instead of just being a parameter of `org.sonar.java.se.CheckerDispatcher#addTransition` ? From the usage it seems it could have been just a parameter. |
@@ -21,6 +21,7 @@ namespace System.Globalization.Tests
/// There are some others that failed which have been commented out and marked in the dataset as "GETASCII DOES FAILS ON WINDOWS 8.1"
/// Same applies to Windows 10 >= 10.0.15063 in the IdnaTest_9.txt file
[Fact]
+ [ActiveIssue("ht... | [IdnMappingIdnaConformanceTests->[GetAscii_Invalid->[GetAscii,nameof,GetCodePoints,LineNumber,IsNotWindowsNanoServer,All,AssertExtensions,Where,Source,Success],GetCodePoints->[Select,ToString,Concat],EqualsTest->[True,Equal,GetHashCode,False,NotEqual,Equals],GetAscii_Success->[GetAscii,Value,Equal,GetCodePoints,LineNum... | Tests if the ASCII code points are mapped to the ASCII code. | how does this work? `PlatformDetection.IsBrowser` and `PlatformDetection.IsWindows` can't be both true at the same time. |
@@ -317,7 +317,7 @@ class HtmlReporter(Reporter):
output_files[path] = f
else:
f = output_files[path]
- f.write(self._htmlify_text(s).encode('utf-8'))
+ f.write(self._htmlify_text(s))
# We must flush in the same thread as the write.
f.flush()
| [HtmlReporter->[end_workunit->[render_cache_stats->[fix_detail_id],render_cache_stats,close,render_timings],handle_output->[open],_overwrite->[open],close->[close],open->[report_path,open]]] | Implementation of Reporter callback. | This reporter code is worth a sanity check. It seemed to be expecting unicode in most places, as Py3 yells about all the original uses of bytes. Using unicode works when testing locally for me, semi-tested because when this code was failing the output of Pants was unformatted until fixing this. |
@@ -333,6 +333,12 @@ class Executor(object):
fetch_var_name=fetch_var_name)
self._feed_data(program, feed, feed_var_name, scope)
+
+ # TODO(gongwb): does a program should be saved in run function?
+ if len(save_program_to_file) > 0:
+ with open(save_program_to_file, ... | [Executor->[_add_feed_fetch_ops->[has_feed_operators,has_fetch_operators],_feed_data->[as_lodtensor],run->[global_scope,get_program_cache_key,_get_program_cache,_add_program_cache,_add_feed_fetch_ops,run,as_numpy,_fetch_data,_feed_data],__init__->[Executor]],as_numpy->[as_numpy],fetch_var->[global_scope,as_numpy],scope... | Run a single n - node program by this Executor. Feed data by feed map and fetch Adds the necessary feed and fetch ops to the program. | I'm not sure we should do the save here... |
@@ -842,9 +842,18 @@ class FEMDEM_Solution:
ZeroVector3[0] = 0.0
ZeroVector3[1] = 0.0
ZeroVector3[2] = 0.0
+ ZeroVector6 = KratosMultiphysics.Vector(6)
+ ZeroVector6[0] = 0.0
+ ZeroVector6[1] = 0.0
+ ZeroVector6[2] = 0.0
+ ZeroVector6[3] = 0.0
+ ZeroV... | [FEMDEM_Solution->[CreateInitialSkinDEM->[GetNodeCoordinates],Initialize->[Initialize],InitializeDummyNodalForces->[GetMaximumConditionId],InitializeSolutionStep->[InitializeSolutionStep],UpdateDEMVariables->[GetNodeCoordinates],Finalize->[Finalize],GenerateDemAfterRemeshing->[GetNodeCoordinates]]] | Initialize MMGvariables. | Use the VariableUtils() |
@@ -476,7 +476,12 @@ def _download_pypi_sdk_package(temp_dir):
"""Downloads SDK package from PyPI and returns path to local path."""
# TODO(silviuc): Handle apache-beam versions when we have official releases.
import pkg_resources as pkg
- version = pkg.get_distribution(GOOGLE_PACKAGE_NAME).version
+ try:
+ ... | [stage_job_resources->[_stage_extra_packages],_stage_dataflow_sdk_tarball->[_dependency_file_download,_dependency_file_copy],_build_setup_package->[_get_python_executable],get_sdk_name_and_version->[get_required_container_version],_download_pypi_sdk_package->[_get_python_executable],_populate_requirements_cache->[_get_... | Downloads SDK package from PyPI and returns path to local path. | `--sdk_location command-line option` instead of just `--sdk_location`. Because this is how we refer to the same thing in a related error in this same file. |
@@ -325,8 +325,17 @@ def format_for_json(packages, options):
}
if options.verbose >= 1:
info['location'] = dist.location
+ info['installer'] = get_installer(dist)
if options.outdated:
info['latest_version'] = six.text_type(dist.latest_version)
... | [ListCommand->[output_legacy_latest->[output_legacy],iter_packages_latest_infos->[_build_package_finder],output_package_listing->[output_legacy,output_legacy_latest]]] | Format a list of packages into a JSON string. | This function should go to `pip.utils.packaging` |
@@ -121,6 +121,14 @@ func (gta *GlobalTSOAllocator) GenerateTSO(count uint32) (pdpb.Timestamp, error)
return pdpb.Timestamp{}, err
}
maxTSO.Logical += int64(count)
+ maxTSO.Logical = gta.timestampOracle.differentiateLogical(maxTSO.Logical)
+ // If the maxTSO's logical part is bigger than maxLogical, just add a u... | [Reset->[ResetTimestamp],SetTSO->[resetUserTimestamp],checkSyncedDCs->[NoneOf,Info,Strings],Initialize->[SyncTimestamp],IsInitialize->[isInitialized],getCurrentTSO->[FastGenByArgs,getTSO,GenerateTimestamp],UpdateTSO->[UpdateTimestamp],GetDcLocations->[GetClusterDCLocations],GenerateTSO->[getTS,resetUserTimestamp,Genera... | GenerateTSO generates a new global TSO with the given number of local TSOs. | we still need to sign the suffix here. |
@@ -69,7 +69,7 @@ public abstract class JobCatalogBase extends AbstractIdleService implements JobC
MetricContext realParentCtx =
parentMetricContext.or(Instrumented.getMetricContext(new org.apache.gobblin.configuration.State(), getClass()));
this.metricContext = realParentCtx.childBuilder(JobCa... | [JobCatalogBase->[registerWeakJobCatalogListener->[registerWeakJobCatalogListener],removeListener->[removeListener],addListener->[getJobsWithTimeUpdate,addListener]]] | A base class for all JobCatalog objects that implement the interface that is used to create and This method is called to get the list of jobs. | This one can call the new constructor with absent sysConfig. |
@@ -11,6 +11,9 @@ from ....core.models import ModelWithMetadata
from ....invoice.models import Invoice
from ...tests.utils import assert_no_permission, get_graphql_content
+pytest_plugins = ["saleor.graphql.meta.tests"]
+
+
PRIVATE_KEY = "private_key"
PRIVATE_VALUE = "private_vale"
| [test_delete_private_metadata_for_customer_as_app->[execute_clear_private_metadata_for_item,item_without_private_metadata],test_delete_public_metadata_for_voucher->[execute_clear_public_metadata_for_item,item_without_public_metadata],test_add_private_metadata_for_draft_order->[execute_update_private_metadata_for_item,i... | Execute a GraphQL update of public metadata for a single item. Update public metadata for a given item. | This will not be needed when you will put fixtures inside a conftest file. |
@@ -91,6 +91,11 @@
input.undo {
background: #ff0000; /* $red */
}
+
+ .adjustment-error {
+ text-align:center;
+ color:red;
+ }
</style>
<div class="container" style="text-align: center">
| [No CFG could be retrieved] | Displays a menu with the menu of menu items for the level - rating button. Renders a hidden nausea down element with a button to show the nausea down. | Probably for another PR, but we should start getting into the habit of putting these into SASS files and referencing the generated CSS file in backend templates. This way the styles are cached in the browser instead of being served up every time this template gets loaded. |
@@ -31,6 +31,8 @@ public class Jetty11HandlerAdvice {
context = tracer().startServerSpan(request);
scope = context.makeCurrent();
+
+ tracer().setAsyncListenerResponse(request, response);
}
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
| [Jetty11HandlerAdvice->[stopSpan->[tracer,stopSpan],onEnter->[startServerSpan,getServerContext,makeCurrent]]] | This method is invoked when a method enter or exit a nested span. | do we need to add calls to `setAsyncListenerResponse` in each app server instrumentation, or can we do it once in servlet instrumentation? |
@@ -212,13 +212,6 @@ def install(args, parser, command='install'):
raise CondaValueError("cannot mix specifications with conda package"
" filenames")
- # handle tar file containing conda packages
- if len(args.packages) == 1:
- tar_path = args.packages[0]
-... | [install->[get_revision,install,check_prefix,install_tar,print_activate,clone]] | Install a package. Find a in the context. Get a object from the command line. Checks if a package has a and if so checks if it is installed. Check if a package is installed on an anaconda. org and if so print it Checks if a node is locked and if not checks if it is then runs actions and writes. | I think this is all dead code. It's all completely untested at least by all of our integration tests. I don't know what code path would actually get to it. You'd need to `conda install my-package.tar` from the command line. Does anybody do that? |
@@ -0,0 +1,11 @@
+from setuptools import setup
+from setuptools import find_packages
+
+
+install_requires = ["mock<1.1.0",]
+
+setup(
+ name="letshelp-letsencrypt",
+ packages=find_packages(),
+ install_requires=install_requires,
+)
| [No CFG could be retrieved] | No Summary Found. | missing `entry_points={'console_scripts': [...]}`; see main `setup.py` for guidanance |
@@ -2812,6 +2812,7 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
}
@CLIMethod(name="quiet-down")
+ @RequirePOST
public HttpRedirect doQuietDown(
@Option(name="-block",usage="Block until the system really quiets down and no builds are running") @Quer... | [Jenkins->[getAllItems->[getAllItems],getUser->[get],getPlugin->[getPlugin],getViewActions->[getActions],getJDK->[getJDKs],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getViews->[getViews],doDoFingerprintCheck->[cleanUp,isUseCrumbs],checkJobName->[getItem,checkGoodName],deleteView->[deleteView],doConfigSu... | Block until the system really quiesies down and no builds are running. | I believe ManagementLink refers to this URL via GET, so that needs fixing. |
@@ -17,11 +17,17 @@ import (
"context"
"github.com/tikv/pd/server/core"
+ "go.uber.org/atomic"
)
// Denoising is an option to calculate flow base on the real heartbeats. Should
// only turned off by the simulator and the test.
-var Denoising = true
+var Denoising = atomic.NewBool(true)
+
+// SetDenoising set... | [CollectMetrics->[CollectMetrics],Update->[Update],HotRegionsFromStore->[RegionStats],updateItem->[Update],RegionStats->[RegionStats],GetFilledPeriod->[GetFilledPeriod]] | NewHotCache creates a new hot cache with the given parameters. ExpiredItems returns the items which have already expired. | I think it's unnecessary to use an atomic variable? |
@@ -276,6 +276,14 @@ class Conversations:
fle, _ = os.path.splitext(datapath)
return fle + '.jsonl'
+ @staticmethod
+ def _check_parent_dir_exits(datapath):
+ parent_dir = os.path.dirname(datapath)
+ if os.path.exists(parent_dir) and os.path.isdir(parent_dir):
+ return... | [Conversations->[_load_conversations->[read,Conversation],_load_metadata->[Metadata],read_rand_conv->[read_conv_idx],save_conversations->[_get_path,save_metadata]],Metadata->[save_metadata->[version,_get_path]],Conversation->[_build_turns->[Turn]]] | Get the path to a file containing the n - ary conversations. Save the last non - null in to_save to file. | needs to be migrated to pathmanager, thx |
@@ -1424,12 +1424,14 @@ class HogwildWorld(World):
"""
return self.inner_world.getID()
- @lru_cache(maxsize=1)
def num_examples(self):
"""
Return the number of examples.
"""
- return self.inner_world.num_examples()
+ if hasattr(self, '_num_examples'):... | [MultiWorld->[report->[report,getID],update_counters->[update_counters],share->[share],reset->[reset],reset_metrics->[reset_metrics],num_examples->[num_examples],num_episodes->[num_episodes],epoch_done->[epoch_done],display->[getID,display],parley->[parley_init,update_counters]],World->[reset->[reset],reset_metrics->[r... | Get the ID of the inner world. | i definitely prefer this logic anyway, the `lru_cache` seemed a little much for its purpose |
@@ -107,6 +107,17 @@ describe('amp-form', () => {
expect(() => new AmpForm(form)).to.not.throw;
});
+ it('should assert none of the inputs named __amp_source_origin', () => {
+ const form = getForm(document, true, false);
+ const illegalInput = document.createElement('input');
+ illegalInput.setAttr... | [No CFG could be retrieved] | This test tests for the AMP project. - nameInput - emailInput - amp - form. | FYI, you should be able to use the util method in `dom.js` `createElementWithAttributes`. |
@@ -13,7 +13,7 @@ module Telephony
'UNKNOWN_FAILURE' => UnknownFailureError,
}.freeze
- # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/BlockLength
+ # rubocop:disable Metrics/BlockLength
# @return [Response]
def send(message:, to:, country_code:, otp: nil)
... | [SmsSender->[send->[region,nil?,to_s,empty?,error,build_response,shortcode,extra,success?,application_id,now,send_messages,country_sender_ids,notify_pinpoint_failover,build_client,each,duration_ms,handle_pinpoint_error],error->[success?,delivery_status,new,status_code],handle_config_failure->[to_json,new,warn],build_re... | send a message to one of the sms channels. | There's a matching `# rubocop:enable ...` below. Should it be updated to the new set of enabled rules? |
@@ -480,16 +480,6 @@ func (pt *programTester) getPipenvBin() (string, error) {
return getCmdBin(&pt.pipenvBin, "pipenv", pt.opts.PipenvBin)
}
-// getPythonVersion returns the requested Python version to use when running this test.
-// Defaults to 3.6 if not specified.
-func (pt *programTester) getPythonVersion() s... | [testLifeCycleDestroy->[GetStackNameWithOwner,GetDebugUpdates,runPulumiCommand],testEdit->[previewAndUpdate],testPreviewUpdateAndEdits->[GetDebugUpdates,runPulumiCommand],prepareNodeJSProject->[runYarnCommand],pipenvCmd->[getPipenvBin],performExtraRuntimeValidation->[GetStackName,runPulumiCommand],copyTestToTemporaryDi... | getPipenvBin returns the pipenv binary and the command to use to run the command. | Should we also delete the `PythonVersion` member from from `ProgramTestOptions`? |
@@ -36,17 +36,6 @@ def get_pants_cachedir() -> str:
return os.path.expanduser(os.path.join(cache_home, "pants"))
-def get_pants_configdir() -> str:
- """Return the pants global config directory."""
- # TODO: Keep in alignment with rust `fs::default_config_path`. This method
- # is not used there direc... | [get_buildroot->[BuildRoot],get_pants_cachedir->[expanduser,get,join],get_pants_configdir->[expanduser,get,join],get_default_pants_config_file->[get_buildroot,join],get_git->[debug,isdir,Git,info,detect_worktree],getLogger] | Return the pants config directory. | This was only used to provide the default value for a now unused and deprecated global option. |
@@ -2422,7 +2422,6 @@ MSG_PROCESS_RETURN tls_process_new_session_ticket(SSL *s, PACKET *pkt)
|| (SSL_IS_TLS13(s)
&& (!PACKET_get_net_4(pkt, &age_add)
|| !PACKET_get_length_prefixed_1(pkt, &nonce)
- || PACKET_remaining(&nonce) == 0
|| !PACKET_memdup(... | [No CFG could be retrieved] | This function handles the case where we need to get the CA RDNs from the packet The main entry point for the protocol. | (PACKET_memdup() does not write to the data or length output parameters when PACKET_remaining(pkt) is zero. This is vaguely tolerable here because the session's extensions block is initialized to zero, but is vaguely disquieting.) |
@@ -1118,7 +1118,8 @@ evt_desc_log_del(struct evt_context *tcx, daos_epoch_t epoch,
}
static int
-evt_node_entry_free(struct evt_context *tcx, struct evt_node_entry *ne)
+evt_node_entry_free(struct evt_context *tcx, struct evt_node *nd,
+ struct evt_node_entry *ne)
{
struct evt_desc *desc;
struct evt_rect... | [No CFG could be retrieved] | finds the node in the event log that is associated with the given event. Return the address of the first child umem offset of the given node. | (style) 'nd' may be misspelled - perhaps 'and'? |
@@ -261,10 +261,6 @@ exports.rules = [
'extensions/amp-subscriptions-google/0.1/amp-subscriptions-google.js->extensions/amp-subscriptions/0.1/doc-impl.js',
'extensions/amp-subscriptions-google/0.1/amp-subscriptions-google.js->extensions/amp-subscriptions/0.1/entitlement.js',
'extensions/amp-subscri... | [No CFG could be retrieved] | Extension Functions - AMP Story Extension - specific functions. | This is disallowed, and requires explicit support in the build process. |
@@ -266,7 +266,7 @@ function get_device(Illuminate\Http\Request $request)
// find device matching the id
$device = device_by_id_cache($device_id);
- if (! $device) {
+ if (! $device || ! $device['type']) {
return api_error(404, "Device $hostname does not exist");
}
| [get_graphs->[route],search_ports->[route,get,isEmpty],edit_location->[route,getContent],update_device->[route,getContent],get_port_stack->[route,get],get_vlans->[route],get_vrf->[route],get_inventory_for_device->[route],get_device->[route],get_bill_history_graph->[route,get],get_devices_by_group->[toArray,route,get,is... | Get a single device matching the specified id. | Device_id would be the correct field to check |
@@ -214,9 +214,10 @@ type OffchainReportingOracleSpec struct {
ContractConfigTrackerPollIntervalEnv bool
ContractConfigConfirmations uint16 `toml:"contractConfigConfirmations"`
ContractConfigConfirmationsEnv bool
- EVMChainID *utils.Big `toml:"evmChainI... | [SetID->[ParseInt,ToInt64],GetID->[Sprintf],RightPadBytes,BytesToHash,String,Replace,Bytes] | GetID returns the ID of the OVS object. | Could this just be called `databaseTimeout` since it is already within the context of an OCR spec? |
@@ -162,7 +162,7 @@ func (a *openshiftAuthorizer) getEffectivePolicyRules(namespace string, user use
}
}
- return effectiveRules, nil
+ return effectiveRules, kerrors.NewAggregate(errs)
}
func (a *openshiftAuthorizer) Authorize(passedAttributes AuthorizationAttributes) (bool, string, error) {
| [authorizeWithNamespaceRules->[getEffectivePolicyRules],getEffectivePolicyRules->[getRole,getRoleBindings],getRole->[getPolicy],getRoleBindings->[getPolicyBindings]] | get effective policy rules. | returning items that are valid to use along with an error is weird enough that it merits a function godoc |
@@ -161,8 +161,15 @@ class OpenidConnectAuthorizeForm
end
def scopes
- return OpenidConnectAttributeScoper::VALID_SCOPES if ialmax_requested? || ial2_requested?
- OpenidConnectAttributeScoper::VALID_IAL1_SCOPES
+ values = if ialmax_requested? || ial2_requested?
+ OpenidConnectAttributeScoper::VALI... | [OpenidConnectAuthorizeForm->[validate_privileges->[ialmax_requested?,ial,ial2_requested?],scopes->[ialmax_requested?,ial2_requested?],check_for_unauthorized_scope->[ial2_requested?]]] | Check if the user has a scope that is not authorized by the current user. | `profile:verified_at` is a weird scope.... I could just add it to `VALID_IAL1_SCOPES` and be done with it? But we only want to expose it to SPs that are IAL2+.... I don't like how messy this is, very open to feedback |
@@ -92,6 +92,10 @@ public class HashedWheelTimer implements Timer {
private static final AtomicIntegerFieldUpdater<HashedWheelTimer> WORKER_STATE_UPDATER =
AtomicIntegerFieldUpdater.newUpdater(HashedWheelTimer.class, "workerState");
+ private static final ExecutorService DEFAULT_TIMER_TASK_EXECUT... | [HashedWheelTimer->[finalize->[finalize],newTimeout->[start],start->[start],HashedWheelBucket->[expireTimeouts->[remove,expire,isCancelled],clearTimeouts->[isExpired,isCancelled]],HashedWheelTimeout->[remove->[remove],expire->[compareAndSetState,run],isExpired->[state],toString->[toString,isCancelled],isCancelled->[sta... | Implementation of the HashedWheelTimer class. DownLatch is used to wait for a timeout. | Merge the latest 3.0 branch, using `GlobalResourcesRepository` to govermance this executor |
@@ -155,7 +155,7 @@ def send_expiration_notifications(exclude):
if (
notification_recipient
- and owner != notification_recipient
+ and owner not in notification_recipient # notification_recipient is a list
and security_email != notificatio... | [get_eligible_certificates->[get_certificates],send_expiration_notifications->[get_eligible_certificates,send_notification]] | This function will check for upcoming certificate expiration and send out notification emails at given intervals. | is `notification_recipient` always a list? if this is the case, we should also change the next line `and security_email != notification_recipient`. Otherwise, if `notification_recipient` is not always a list, and can also be just a string, we might run to some undesired side-effects. |
@@ -199,13 +199,14 @@ namespace Js
Utf8SourceInfo::Clone(ScriptContext* scriptContext, const Utf8SourceInfo* sourceInfo)
{
Utf8SourceInfo* newSourceInfo = Utf8SourceInfo::NewWithHolder(scriptContext, sourceInfo->GetSourceHolder()->Clone(scriptContext), sourceInfo->m_cchLength,
- SRCINFO::... | [No CFG could be retrieved] | Returns a new UTF8 string with all possible duplicate characters copied. This function is called to add a source holder to the stack. | this is not needed as the code below (setIndebugMode) will do that for you. |
@@ -89,7 +89,7 @@ class PavloviaMiniBrowser(wx.Dialog):
def login(self):
self._loggingIn = True
authURL, state = pavlovia.getAuthURL()
- self.browser.Bind(wx.html2.EVT_WEBVIEW_LOADED, self.checkForLoginURL)
+ self.browser.Bind(wx.html2.EVT_WEBVIEW_ERROR, self.checkForLoginURL)
... | [BaseFrame->[__init__->[__init__]],PavloviaMiniBrowser->[checkForLoginURL->[login],__init__->[__init__]]] | Login to pavlovia. | I'm pretty sure that removing this line will break successful login when the page *does* load |
@@ -56,6 +56,7 @@ class UserController extends Controller
return view('user.index', [
'users' => User::orderBy('username')->get(),
'multiauth' => User::query()->distinct('auth_type')->count('auth_type') > 1,
+ 'twofactor' => UserPref::get()->where('pref', 'twofactor')->keyB... | [UserController->[create->[authorize,canUpdatePasswords,get],show->[authorize],edit->[authorize,get],update->[isDirty,all,user,get,back,fill,has,setPassword,save,canSetPassword,updateDashboard],authlog->[authorize,get],store->[getUserid,get,back,only,setPassword,save,updateDashboard],destroy->[authorize,json,delete],in... | Display a list of users with a single auth_type. | Update this to: `'users' => User::with('preferences')->orderBy('username')->get(),` and delete the 'twofactor' line below. |
@@ -348,6 +348,7 @@ class BaseExecutor(ABC):
quiet=True,
allow_missing=True,
checkpoint_reset=checkpoint_reset,
+ recursive=kwargs.get("recursive", False),
)
checkpoint_func = partial(
| [BaseExecutor->[commit->[commit],_repro_args->[unpack_repro_args],reproduce->[_validate_remotes,ExecutorResult,hash_exp],_repro_dvc->[ExecutorInfo,to_dict],checkpoint_callback->[_auto_push,hash_exp]]] | Reproduce a single node in the system. Check - out a object. Return ExecutorResult object for a . | @pmrowla, Is it not possible to checkout as we go `run`-ing? This way, it may miss a lot of things. `foreach` based stages come to mind, as only `repro` supports them. Also, glob is not supported by checkout. |
@@ -108,10 +108,9 @@ func (m *Manager) CreateAndAttach(op trace.Operation, newDiskURI,
return nil, errors.Trace(err)
}
- d.setAttached(devicePath)
-
- if err := waitForPath(op, devicePath); err != nil {
- op.Infof("waitForPath failed for %s with %s", newDiskURI, errors.ErrorStack(err))
+ blockDev, err := waitFo... | [CreateAndAttach->[Infof,Begin,Detach,setAttached,End,Attach,devicePathByURI,Debugf,Trace,ErrorStack,createDiskSpec],Create->[CreateVirtualDisk,Infof,Begin,Vim25,End,NewVirtualDiskManager,Trace,Wait],Detach->[Unlock,Warnf,Reconfigure,Reference,WaitForResult,Error,unlock,End,Attached,Lock,Errorf,Trace,ErrorStack,Debugf,... | CreateAndAttach creates a new virtual disk and attaches it to the given parent. | It is still possible that this will be preempted by the switch-root that breaks the tether. I do not think we have removed the infinite loop there which spins waiting for devices to present. This could also help us determine if the vm is actually stuck in that state right? |
@@ -60,6 +60,7 @@ public class DicomIOReadIT {
client.deleteDicomStore(healthcareDataset + "/dicomStores/" + storeName);
}
+ @Ignore
@Test
public void testDicomMetadataRead() throws IOException {
String webPath =
| [DicomIOReadIT->[deleteDicomStore->[deleteDicomStore]]] | Delete a missing DicomStore. | Please create a JIRA to track the issue, and link it here. |
@@ -769,6 +769,9 @@ class Report(object):
warnings.warn('Could not import mayavi. Trying to render '
'`mayavi.core.scene.Scene` figure instances'
' will throw an error.')
+ if np.isscalar(scale) and scale < 1.:
+ raise ValueError('scal... | [_iterate_files->[_update_html],_iterate_mri_slices->[_build_image],_iterate_trans_views->[_fig_to_img],Report->[add_section->[_add_figs_to_section],_render_bem->[_get_id,_render_one_bem_axis,_render_image],_render_image->[_get_id,_render_array],add_bem_to_section->[_validate_input],_render_evoked->[_get_id,_fig_to_img... | Auxiliary method for add_section and add_figs_to_section. Add missing sectionnames and labels to self. | @agramfort better? It's not perfect because e.g. `np.isscalar('a') is True`, but it should work most of the time |
@@ -223,6 +223,13 @@ echo "%{_libdir}/daos_srv" > %{?buildroot}/%{_sysconfdir}/ld.so.conf.d/daos.conf
%{_bindir}/obj_ctl
%{_bindir}/daos_gen_io_conf
%{_bindir}/daos_run_io_conf
+# For avocado tests
+%dir %{_prefix}/lib
+%{_prefix}/lib/.build_vars.json
+%{_prefix}/lib/.build_vars.sh
+%dir %{_prefix}/etc
+%dir %{_pre... | [No CFG could be retrieved] | %{ name } - > string Add a file to the list of files that are related to a single sequence number. | (style) trailing whitespace |
@@ -141,9 +141,11 @@ static int raw_set_params(void *vobj, const OSSL_PARAM *params)
if (!TEST_ptr(obj->p4 = OPENSSL_strndup(params->data,
params->data_size)))
return 0;
+ obj->p4_l = strlen(obj->p4);
} else if (strcm... | [setup_tests->[OSSL_NELEM,ADD_ALL_TESTS],void->[OPENSSL_zalloc,OPENSSL_strdup,TEST_ptr,OPENSSL_free,strcpy,BN_hex2bn,BN_free,cleanup_object,TEST_true],int->[TEST_str_eq,OSSL_PARAM_get_double,OSSL_PARAM_allocate_from_text,init_app_variables,TEST_true,OSSL_PARAM_get_utf8_string,TEST_ptr,TEST_error,TEST_int_eq,OSSL_PARAM_... | raw_set_params - set raw parameters from params if there is no key in params. | Yeah, this needs to be either params->data_size - 1 or ideally min(params->data_size, sizeof(obj->p5) - 1) (and the strncpy above corrected as well. |
@@ -316,7 +316,8 @@ public class IndexerSQLMetadataStorageCoordinator implements IndexerMetadataStor
// Find which segments are used (i.e. not overshadowed).
final Set<DataSegment> usedSegments = Sets.newHashSet();
for (TimelineObjectHolder<String, DataSegment> holder : VersionedIntervalTimeline.forSegme... | [IndexerSQLMetadataStorageCoordinator->[announceHistoricalSegments->[announceHistoricalSegments],updateSegmentMetadata->[inTransaction],deleteSegments->[inTransaction],updateDataSourceMetadataWithHandle->[getDataSourceMetadataWithHandleAsBytes],allocatePendingSegment->[inTransaction->[getPendingSegmentsForIntervalWithH... | announce a set of segments with a specific sequence of data sources. This method is called when a segment is not yet used. It is called by the Segment. | formatting here looks weird? |
@@ -218,6 +218,12 @@ namespace System.Buffers
if (log.IsEnabled())
{
log.BufferReturned(array.GetHashCode(), array.Length, Id);
+ if (!(haveBucket & returned))
+ {
+ log.BufferDropped(array.GetHashCode(), array.Length, Id,
+ ... | [TlsOverPerCoreLockedStacksArrayPool->[PerCoreLockedStacks->[Trim->[Trim],TryPush->[TryPush],TryPop->[TryPop]],Gen2GcCallbackFunc->[Trim]]] | This method is called by the array allocator to write the array into the appropriate bucket. if this buffer was returned by the caller then it will be removed from the array. | perhaps we should have a style preference for `&` vs `&&` when both sides are booleans. It seems it makes the same IL. I always use `&&`. |
@@ -190,7 +190,10 @@ public class PhysicalPlanBuilder {
}
final QueryId queryId = sinkDataSource.getPersistentQueryId();
- final String applicationId = addTimeSuffix(serviceId + persistanceQueryPrefix + queryId);
+ String applicationId = serviceId + persistanceQueryPrefix + queryId;
+ if (addUnique... | [PhysicalPlanBuilder->[getBareQueryApplicationId->[nextLong,abs],buildPlanForStructuredOutputNode->[getPersistentQueryId,putTopic,getSchema,KsqlStream,getKafkaTopicName,getTimestampField,isWindowed,toString,getKeyField,KsqlTable,getTopic,buildStreams,getKsqlTopic,cloneWithTimeKeyColumns,getExecutionPlan,putSource,addTi... | Build plan for structured output node. | Actually addUniqueTimeSuffix will always be false here and will always be true for `buildPlanForBareQuery` method. Maybe we should remove this boolean all together. |
@@ -243,6 +243,11 @@ func DeactivateCmd() *cobra.Command {
return errors.Wrapf(err, "could not connect")
}
defer c.Close()
+
+ // Delete any data from the identity server
+ if _, err := c.IdentityAPIClient.DeleteAll(c.Ctx(), &identity.DeleteAllRequest{}); err != nil {
+ return grpcutil.ScrubGRPC(err... | [WhoAmI,StringVar,GetOIDCLogin,Authorize,StringSliceVar,Now,Duration,GetClusterRoleBinding,Close,Permission,SetConfiguration,Activate,SetAuthToken,ActivateAuth,Add,RunBoundedArgs,Deactivate,RunFixedArgs,Format,Seconds,GetRobotToken,Ctx,GetIdentityServerConfig,Errorf,ActiveContext,ActiveEnterpriseContext,TrimSpace,Wrapf... | DeactivateCmd returns a cobra command to delete all ACLs tokens and admins and expose all Long is the login to Pachyderm. Any resources that have been restricted. | Maybe this is too much of a corner case to worry about, but is there any risk that by doing `identity.DeleteAll()` before `auth.Deactivate()`, we could get the user's cluster stuck? I.e. they call `c.Deactivate()`, but because that call is restricted they need to re-auth, but they can no longer re-auth because the OIDC... |
@@ -204,7 +204,7 @@ def get_seo_description(content, locale=None, strip_markup=True):
# Try constraining the search for summary to an explicit "Summary"
# section, if any.
summary_section = (parse(content).extractSection('Summary')
- .serialize())
+ ... | [SectionEditLinkFilter->[__iter__->[__iter__],__init__->[__init__]],EditorSafetyFilter->[__iter__->[__iter__]],ContentSectionTool->[serialize->[_get_serializer],parse->[parse],__unicode__->[serialize],__init__->[parse]],SectionIDFilter->[__iter__->[__iter__,process_header,gen_id],process_header->[gen_id,slugify],__init... | Get the SEO description from a content string. Removes the n - ary seo summary from the seo summary. | Looks like pyflakes could use a few more rules to agree w/ your editor |
@@ -886,7 +886,7 @@ class PGBKCVOperation(Operation):
if windows is 0:
self.output(_globally_windowed_value.with_value((key, value)))
else:
- self.output(WindowedValue((key, value), windows[0].end, windows))
+ self.output(WindowedValue((key, value), windows[0].max_timestamp(), windows))
... | [SimpleMapTaskExecutor->[execute->[start,finish,create_operation]],ReadOperation->[start->[output]],SingletonConsumerSet->[try_split->[try_split],receive->[update_counters_finish,update_counters_start],current_element_progress->[current_element_progress]],Operation->[start->[setup],reset->[reset],setup->[create],output... | Outputs a key and value pair. | Would not this make the timestamp for the element incorrect? |
@@ -401,7 +401,11 @@ class TensorCache(MutableMapping[str, Tensor], ABC):
"""
def __init__(
- self, filename: Union[str, PathLike], *, map_size: int = 1024 * 1024 * 1024 * 1024
+ self,
+ filename: Union[str, PathLike],
+ *,
+ map_size: int = 1024 * 1024 * 1024 * 1024,
+ ... | [_s3_get->[_get_s3_resource,_split_s3_path],_s3_etag->[_get_s3_resource,_split_s3_path],json_lines_from_file->[text_lines_from_file],text_lines_from_file->[open_compressed],inspect_cache->[_find_entries],get_from_cache->[_s3_get,CacheFile,_s3_etag,_Meta,_resource_to_filename,_http_get,_find_latest_cached,to_file,_http_... | Initialize a cache from a file. | I have been wanting to make this change for a while. In fact, I think that when opening a cache file where the file's permissions make it read only, we should print a warning and open read-only, even if `read_only == False`. I think that'll make it much easier to share the feature caches. |
@@ -83,16 +83,14 @@ namespace NServiceBus
return serializer.Deserialize(jsonReader, manifest.SagaEntityType);
}
- static void WriteWithinLock(Action<JsonWriter, IContainSagaData> action, JsonWriter writer, string targetPath, DateTime lastModificationSeenAt, IContainSagaData sagaData = nul... | [SagaStorageFile->[TryOpen->[ReadWrite,Exists,Asynchronous,Open,GetFilePath],WriteWithinLock->[Write,ChangeExtension,DeleteOnClose,Flush,None,action,ThrowWhenModifiedSinceLastRead,CreateNew],Dispose->[Close,Delete,Name],ThrowWhenModifiedSinceLastRead->[GetLastWriteTimeUtc,Exists],Read->[SagaEntityType,Deserialize],Task... | Reads an object from the manifest. | To this change. The way it was before, we completely avoid having to close over any values, which should prevent the need for a per-call delegate allocation. |
@@ -31,7 +31,7 @@ module Idv
end
def applicant_from_params
- app_vars = applicant_params.delete_if { |_key, value| value.blank? }
+ app_vars = idv_params.merge(financial_params.delete_if { |_key, value| value.blank? })
Proofer::Applicant.new(app_vars)
end
| [SessionsController->[create->[redirect_to,t,success,init_questions_and_profile],pick_a_vendor->[test?,sample],applicant_from_params->[new,delete_if,blank?],available_vendors->[map],applicant_params->[slice],start_idv_session->[new,vendor,start,idv_applicant,proofing_requires_kbv?,idv_vendor],init_questions_and_profile... | This method is called when the user has requested to access the applicant object. | Could you please explain the reasoning behind extracting the financial_params out of the applicant_params? It seems like the only place the `financial_params` are used is here, to merge them back again with the applicant params. |
@@ -635,7 +635,8 @@ public final class FilePath implements Serializable {
}
}
- private void unzip(File dir, File zipFile) throws IOException {
+ private void unzip(@Nonnull File dir, File zipFile) throws IOException {
+ assert dir != null;
dir = dir.getAbsoluteFile(); // withou... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | Unzips a zip file into a directory. | second arg should be nonnull as well |
@@ -43,7 +43,8 @@ public abstract class AbstractGCPProcessor<
.Builder().name("gcp-project-id")
.displayName("Project ID")
.description("Google Cloud Project ID")
- .required(true)
+ .required(false)
+ .expressionLanguageSupported(ExpressionLanguag... | [AbstractGCPProcessor->[getGoogleCredentials->[getGoogleCredentials],onScheduled->[getGoogleCredentials]]] | Package private for testability. Required and optional. | in what case the project id could be null? |
@@ -58,9 +58,10 @@ public class DefaultAssigneeTest {
}
@Test
- public void default_assignee() {
+ public void set_default_assignee() {
settings.setProperty(CoreProperties.DEFAULT_ISSUE_ASSIGNEE, "erik");
- when(userIndex.getNullableByLogin("erik")).thenReturn(new UserDoc().setLogin("erik").setActive(... | [DefaultAssigneeTest->[configured_login_does_not_exist->[thenReturn,setProperty,isNull],before->[thenReturn,mock],default_assignee->[thenReturn,setProperty,setActive,isEqualTo],configured_login_is_disabled->[thenReturn,setProperty,setActive,isNull],no_default_assignee->[isNull],mock,MapSettings,DefaultAssignee]] | Default assignee. | out of scope: getLogin is misleading as it load data in a datastore (even once) |
@@ -789,5 +789,12 @@ export class SanitizerImpl {
AMP.extension(TAG, '0.1', function(AMP) {
AMP.registerServiceForDoc(TAG, AmpScriptService);
+ AMP.registerServiceForDoc('purifier-inplace', ampdoc => {
+ return new Purifier(
+ ampdoc.getRootNode(),
+ dict({'IN_PLACE': true}),
+ rewriteAttribute... | [No CFG could be retrieved] | Register AMP scripts with AMP. | please use normal function instead of arrow func, i believe this will be `new`d up at some point. did the linter catch this? edit: looks like it did ` 144:3 error registerService* methods should not use arrow functions as a constructor local/no-arrow-on-register-functions` |
@@ -1780,7 +1780,7 @@ bool marshal_generator::gen_struct(AST_Structure* node,
* size is hijacked for field sizes because of alignment resets.
*/
be_global->impl_ <<
- " size_t xcdr1_pl_running_total = 0;\n";
+ " size_t mutable_running_total = 0;\n";
}
if (may_be_delimi... | [No CFG could be retrieved] | Generate an array of functions for the given node. finds the size of the field in the tree. | In the line above this one get rid of "XCDR1". |
@@ -3400,7 +3400,6 @@ RtpsUdpDataLink::RtpsWriter::gather_nack_replies_i(MetaSubmessageVec& meta_subme
gaps.insert(seq);
} else {
// Non-directed gap.
- consolidated_recipients.insert(addrs.begin(), addrs.end());
consolidated_gaps.insert(seq);
}
}
| [No CFG could be retrieved] | This method is called from RTPSUdpSendStrategy and RTPSUdpSendStrategy This function is called from the udp_read_scan function. It is called from. | Why is there no update to the recipients here? |
@@ -32,8 +32,11 @@ public final class OAuthRegisteredService extends RegexRegisteredService {
private static final long serialVersionUID = 6784839055053605375L;
private String clientSecret;
+
private String clientId;
+ private Boolean bypassApprovalPrompt = false;
+
public String getClientId(... | [OAuthRegisteredService->[toString->[toString,getClientId]]] | get the clientId. | Shouldn't the `serialVersionUID` be changed? |
@@ -165,7 +165,10 @@ public class JsonElementConversionWithAvroSchemaFactory extends JsonElementConve
@Override
Object convertField(JsonElement value) {
- return new GenericData.EnumSymbol(this.schema, value.getAsString());
+ String valueString = value.getAsString();
+ Validate.isTrue(this.en... | [JsonElementConversionWithAvroSchemaFactory->[MapConverter->[schema->[schema],getConverter],ArrayConverter->[schema->[schema],getConverter],UnionConverter->[convertField->[getTargetType],getConverter]]] | Convert the field value to an enum symbol. | most of our check is done with guava `Preconditions`. Replace `Validate.isTrue` with `Preconditions` to be consistent and avoid introducing a new dependency? |
@@ -1,5 +1,5 @@
# -*- encoding : utf-8 -*-
-class RemoveRedundantRawEmailColumns < ActiveRecord::Migration
+class RemoveRedundantRawEmailColumns < !rails5? ? ActiveRecord::Migration : ActiveRecord::Migration[4.2] # 2.3
def self.up
remove_column :raw_emails, :data_text
remove_column :raw_emails, :data_bina... | [RemoveRedundantRawEmailColumns->[up->[remove_column]]] | Remove the missing and missing data - binary and text - text columns from the table. | Line is too long. [110/80] |
@@ -132,6 +132,7 @@ SingleSendBuffer::release_i(BufferMap::iterator buffer_iter)
}
}
+ destinations_.erase(buffer_iter->first);
buffers_.erase(buffer_iter);
}
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | Since release_i() and remove_i() clean this up now, I think you can get rid of remove destinations_.erase(it->first) in check_capacity_i() which calls remove_i right after. |
@@ -577,11 +577,9 @@ namespace DotNetNuke.UI.Modules
}
else
{
- if (!Globals.IsAdminControl() && ModulePermissionController.HasModuleAccess(SecurityAccessLevel.Admin, "DELETE,MANAGE", Configuration))
+ if (!Globals.IsAdminControl() && (ModulePermissio... | [ModuleInstanceContext->[LoadActions->[FilterUrl,AddPrintAction,AddMenuMoveActions,GetActionsCount,AddHelpActions,AddSyndicateAction],NavigateUrl->[NavigateUrl],GetActionsCount->[GetActionsCount],EditUrl->[EditUrl]]] | Load all actions from the module. Add a new action to the list of actions that can be performed on the module. Navigate to the next module in the system. Updates the global module control with the given configuration. | DELETE is removed from the list here, this would be a breaking change for others that expected this to behave as it does now. |
@@ -94,8 +94,8 @@ def test_plot_raw():
raw.annotations = annot
fig = plot_raw(raw, events=events, event_color={-1: 'r', 998: 'b'})
plt.close('all')
- for order in ['position', 'selection', range(len(raw.ch_names))[::-1],
- [1, 2, 4, 6]]:
+ for order in ['pos... | [test_plot_raw->[_get_raw,_get_events],test_plot_raw_filtered->[_get_raw],test_plot_raw_psd->[_get_raw],test_plot_sensors->[_get_raw]] | Test plotting of raw data. Plot a missing key missing key Plot the missing key in the data axis. | Maybe we can shave off a few ms testing time by cutting it to 2 or 3 chans ... |
@@ -291,7 +291,7 @@ export function getDevelopmentBootstrapBaseUrl(parentWindow, srcFileBasename) {
*/
function getAdsLocalhost(win) {
let adsUrl = urls.thirdParty; // local dev with a non-localhost server
- if (adsUrl.indexOf('ampproject.net') > -1) {
+ if (adsUrl.startsWith('https://3p.ampproject.net')) {
... | [No CFG could be retrieved] | Returns the development bootstrap base URL for the given window and file name. Get random number from windows. | I don't think this is correct, the domain uses a random subdomain every request. Eg, `d12342.3p.ampproject.net` |
@@ -442,3 +442,12 @@ ec_obj_update_encode(tse_task_t *task, daos_obj_id_t oid,
return rc;
}
+bool
+ec_mult_data_targets(uint32_t fw_cnt, daos_obj_id_t oid)
+{
+ struct daos_oclass_attr *oca = daos_oclass_attr_find(oid);
+
+ if (oca->ca_resil == DAOS_RES_EC && fw_cnt > oca->u.ec.e_p)
+ return true;
+ return false;... | [ec_obj_update_encode->[ec_set_head_params,ec_init_tgt_set,tse_task_register_comp_cb,ec_free_params,D_ASSERT,ec_has_full_stripe,dc_task_get_args,ec_array_encode,ec_init_params,ec_update_params,D_ALLOC_PTR],void->[D_ASSERT,memset,D_FREE],int->[ec_move_sgl_cursors,D_ALLOC,D_FREE,D_REALLOC_ARRAY,ec_free_params,D_ALLOC_ARR... | This function is called from the DAO to encode the object in the DAO object. Private functions - related to DAOS_ICB_DEBUG DAOS_IC - Callback for free - params - task - register component - free - params - cb -. | probably can pass in the oca rather than search it again every time. |
@@ -806,6 +806,14 @@ exec(compile(
self.install_succeeded = True
return
+ # Extend the list of global and install options passed on to
+ # the setup.py call with the ones from the requirements file.
+ # Options specified in requirements file override those
+ # spe... | [parse_editable->[_build_req_from_url,_strip_postfix,_build_editable_options],InstallRequirement->[from_path->[from_path],get_dist->[egg_info_path],install->[prepend_root],_correct_build_location->[build_location],move_wheel_files->[move_wheel_files],run_egg_info->[_correct_build_location],archive->[pkg_info],pkg_info-... | Installs a single version of the package. installs a new in the install record. | I recall this from the first go round I think : ) although, I can't find an example why this won't work, it's odd to see the resulting command using '-v' |
@@ -995,7 +995,7 @@ define([
* @exception {DeveloperError} The size in bytes must be greater than zero.
* @exception {DeveloperError} Invalid <code>usage</code>.
*
- * @see Context#createVertexArray
+ * @see VertexArray
* @see Context#createIndexBuffer
* @see {@link https://www.khr... | [No CFG could be retrieved] | Creates a new vertex buffer which is ready to be attached to a vertex array. Creates a vertex buffer for the specified vertex array. | Just remove this `@see` here and below. |
@@ -603,6 +603,7 @@ const (
// hot region.
defaultHotRegionCacheHitsThreshold = 3
defaultSchedulerMaxWaitingOperator = 3
+ defaultLeaderScoreStrategy = "balance-size"
)
func (c *ScheduleConfig) adjust(meta *configMetaData) error {
| [Parse->[Parse],IsDefined->[IsDefined],Adjust->[CheckUndecoded,Parse,IsDefined,Validate,Child],adjustLog->[IsDefined],adjust->[Validate,IsDefined],Parse] | adjust is used to set the default values for the schedule config This function is used to set the default configuration for a configuration object. | Can we just use `size` or `count`? |
@@ -31,6 +31,7 @@ class ResultTextsController < ApplicationController
def create
@result_text = ResultText.new(result_params[:result_text_attributes])
+ @result_text.text = parse_tiny_mce_asset_to_token(@result_text.text)
@result = Result.new(
user: current_user,
my_module: @my_module,
| [ResultTextsController->[new->[new],create->[new,create],update->[create]]] | create a new nag node with the given name. | If you added "# gerate a tag that replaces img tag in database" to `steps_controller.rb`, you should also add it here :). |
@@ -45,10 +45,10 @@ class AttributeSortField(graphene.Enum):
"Sort attributes by their position in storefront"
),
AttributeSortField.DASHBOARD_VARIANT_POSITION.name: (
- "Sort variant attributes by their position in dashboard."
+ "Deprecated: Sort... | [ProductOrderField->[description->[ValueError]],AttributeSortField->[description->[ValueError],sort_by_dashboard_product_position->[product_attributes_sorted],sort_by_dashboard_variant_position->[variant_attributes_sorted]],CategorySortField->[description->[ValueError,lower],sort_by_subcategory_count->[annotate],sort_b... | Description of the enumeration. | For any deprecation notice, we should say in which version something will be removed. Since we have now 2.9 and removed stuff 2 versions later, it should say: "DEPRECATED: Will be removed in Saleor 2.11." Same below. |
@@ -51,6 +51,8 @@ const CID_OPTOUT_STORAGE_KEY = 'amp-cid-optout';
const CID_OPTOUT_VIEWER_MESSAGE = 'cidOptOut';
+const AMP_CID_BACKUP_PREFIX = 'amp-cid-backup-';
+
/**
* Tag for debug logging.
* @const @private {string}
| [Cid->[constructor->[create],getExternalCid_->[setCidCookie,parseUrlDeprecated,isProxyOrigin,getOrCreateCookie,cookieName,OPT_OUT],getOptedInScopes_->[user,indexOf,trim,split],optOut->[optOutOfCid],get->[then,timerFor,isOptedOutOfCid,userAssert,cookieName,scope,rethrowAsync,test],scopeBaseCid_->[cryptoFor,getBaseCid,ge... | Package that contains persistent client identifiers for use in analytics and similar use cases. Assigns the given CID API key to the AMP - GA client - id -. | I realized that all AMP stored value in origin are stored under the same localstorage key already. `amp-store:${origin}`. How important it is for vendors to access the storage backup value? Shall we reuse the namespace? |
@@ -52,9 +52,10 @@ const WalletsImport = () => {
},
});
- const _setImportText = value => {
- const valueWithSingleWhitespace = value.replace(/^\s+|\s+$|\s+(?=\s)/g, '');
+ const onBlur = () => {
+ const valueWithSingleWhitespace = importText.replace(/^\s+|\s+$|(\r\n|\r|\n)|\s+(?=\s)/g, '');
setI... | [No CFG could be retrieved] | Create a style sheet for the menu item. Trigger an import button on the UI and navigate to the Wallet Discovery UI. | @marcosrdz I guess now SLIP39 wallet import is broken. It requires a few seeds divided by '\n' What is even this code for? It is better to have all text preparations in main import function and be tested. |
@@ -50,6 +50,7 @@ module GobiertoAttachments
after_create :add_item_to_collection
before_validation :update_file_attributes
+ after_restore :restore_slug
scope :inverse_sorted, -> { order(id: :asc) }
scope :sorted, -> { order(id: :desc) }
| [Attachment->[created_at->[created_at],content_type->[content_type],update_file_attributes->[file_digest]]] | Has paper trail This is a method to add the file_attachments_in_collections and attachments_in. | Why no set_slug instead of a new method that calls set_slug? |
@@ -56,6 +56,11 @@ public class ImageResizer extends MagickExecutor {
// hack to manage jpeg default background
if (outputFile.endsWith(JPEG_CONVERSATION_FORMAT)) {
commandName = "jpegResizer";
+ Point size = scaleToMax(targetWidth, targetHeight, MAX_JEPG_DIMENSION);
+ ... | [ImageResizer->[resize->[isSuccessful,getDefaultCmdParameters,getService,endsWith,getError,getInfo,getDepth,execCommand,exists,addNamedParameter,valueOf]]] | Resizes an image to the specified dimensions. | Do we have to create this huge target size (64k up to 4 billions pixels) each time ? this might impact image magic perf no? |
@@ -37,6 +37,11 @@ public interface Supervisor
SupervisorReport getStatus();
+ default Map<String, Object> getStats()
+ {
+ return null;
+ }
+
void reset(DataSourceMetadata dataSourceMetadata);
/**
| [No CFG could be retrieved] | Reset the status of the DataSource. | why not an empty map? |
@@ -689,6 +689,17 @@ namespace System.Net.Security
public override Task FlushAsync(CancellationToken cancellationToken) => InnerStream.FlushAsync(cancellationToken);
+ public virtual Task NegotiateClientCertificateAsync(CancellationToken cancellationToken = default)
+ {
+ ThrowIfEx... | [SslStream->[Flush->[Flush],ThrowIfExceptionalOrNotHandshake->[ThrowIfExceptional],Write->[Write],AuthenticateAsClient->[AuthenticateAsClient,SetAndVerifySelectionCallback,SetAndVerifyValidationCallback],AuthenticateAsServer->[AuthenticateAsServer,SetAndVerifyValidationCallback],ThrowIfExceptionalOrNotAuthenticated->[T... | Flushes the underlying stream and releases all resources. | Is this necessary? Could it return a completed task instead? What if NegotiateClientCertificateAsync had already been called and no certificate was available? We would not want to renegotiate again, a completed task would also be appropriate then. |
@@ -724,6 +724,15 @@ export class VideoDocking {
return {posY, posX: this.getRelativeX_()};
}
+ /**
+ * @return {boolean}
+ * @private
+ */
+ isValidScrollingDirection_() {
+ return this.currentlyDocked_ ||
+ this.scrollDirection_ == Direction.UP;
+ }
+
/**
* @param {!../../video-int... | [No CFG could be retrieved] | Replies the state of a docked video or potentially dockable video when it is docked Checks if a fixed slot layout box is present. | Now only allows scrolling up for docking, while scrolling down works to undock as well. |
@@ -4,11 +4,16 @@ class CastDecorator < ApplicationDecorator
def db_detail_link(options = {})
name = options.delete(:name).presence || name
path = if h.user_signed_in? && h.current_user.committer?
- h.edit_db_person_cast_path(person, self)
+ h.edit_db_work_cast_path(work, self)
else
- h... | [CastDecorator->[db_detail_link->[user_signed_in?,edit_db_person_cast_path,link_to,presence,new_db_person_draft_cast_path,committer?],include]] | Returns a link to the n - ary item in the DB. | Trailing whitespace detected. |
@@ -74,7 +74,7 @@ class WriteBundlesToFiles<DestinationT, ElementT>
* The result of the {@link WriteBundlesToFiles} transform. Corresponds to a single output file,
* and encapsulates the table it is destined to as well as the file byte size.
*/
- static final class Result<DestinationT> implements Serializa... | [WriteBundlesToFiles->[Result->[equals->[equals]],processElement->[createAndInsertWriter,of,toString],finishBundle->[toString],ResultCoder->[decode->[decode],encode->[encode]]]] | Creates a class which can be used to write a single element into a file. Returns a hash code for this object. | Open to use getter or use `@AutoValue` here |
@@ -29,9 +29,10 @@ class TotpVerificationForm
TwoFactorAuthenticatable::OTP_LENGTH
end
- def extra_analytics_attributes
+ def extra_analytics_attributes(cfg_id)
{
multi_factor_auth_method: 'totp',
+ mfa_id: cfg_id,
}
end
end
| [TotpVerificationForm->[valid_totp_code?->[call,match?],submit->[valid_totp_code?,new],attr_reader]] | missing - totp code length exception. | same, can we make this `totp_config_id` or prefix the value like `"totp-#{cfg_id}"` |
@@ -72,6 +72,11 @@ public enum RecordFieldType {
*/
DOUBLE("double", FLOAT),
+ /**
+ * A big decimal field type. Fields of this type use a {@code java.math.BigDecimal} value.
+ */
+ BIGDECIMAL("bigdecimal", FLOAT, DOUBLE),
+
/**
* A timestamp field type. Fields of this type use a {... | [getArrayDataType->[ArrayDataType],of->[get],isWiderThan->[contains],getDataType->[DataType],getChoiceDataType->[add,ChoiceDataType],getRecordDataType->[RecordDataType],getMapDataType->[MapDataType],RecordDataType,MapDataType,ArrayDataType,ChoiceDataType,DataType,unmodifiableSet,emptyList,put,asList,values,emptySet] | Enumerates all the fields of a record. Replies the fields of a type RECORD. | Maybe we should consider the following methods as well: `InferenceSchemaStrategy.convertSchema` `PutElasticsearchHttpRecord.writeValue` `PutHBaseRecord.asBytes` `AbstractKuduProcessor.toKuduType` `ResultSetRecordSet.getFieldType:382 case Types.JAVA_OBJECT` `DataTypeUtils.getWiderType:1744,1749 case FLOAT,case DOUBLE` `... |
@@ -225,7 +225,8 @@ func (client *client) SendTransaction(ctx context.Context, tx *types.Transaction
go func() {
err := client.SecondaryGethClient.SendTransaction(ctx, tx)
if err != nil {
- logger.Warnw("secondary eth client returned error", "err", err, "tx", tx)
+ // We don't care if it errors since t... | [TransactionReceipt->[TransactionReceipt],ChainID->[ChainID],EthSubscribe->[EthSubscribe],SendTransaction->[SendTransaction],CallContext->[CallContext],BlockByNumber->[BlockByNumber],FilterLogs->[FilterLogs],BalanceAt->[BalanceAt],SubscribeFilterLogs->[SubscribeFilterLogs],Call->[Call],PendingNonceAt->[PendingNonceAt]] | SendTransaction sends a transaction to the network. | TODO: Cast to sendError and check its not something expected like nonce too low. Also consider adding Trace logging |
@@ -61,7 +61,7 @@ namespace Internal.JitInterface
var _this = GetThis(thisHandle);
try
{
- return _this.getMethodInfo(ftn, info) ? 1 : 0;
+ return _this.getMethodInfo(ftn, info) ? (byte)1 : (byte)0;
}
catch (Exception ex)
... | [CorInfoImpl->[_getHeapClassSize->[GetThis,AllocException,getHeapClassSize],_getMethodHash->[GetThis,AllocException,getMethodHash],_getTypeInstantiationArgument->[GetThis,AllocException,getTypeInstantiationArgument],_getUnboxedEntry->[GetThis,AllocException,getUnboxedEntry],_mapMethodDeclToMethodImpl->[GetThis,mapMetho... | Private method for getting method info. | This is auto-generated file. Could you please also update the auto-generator (path to the auto-generator is at the top of the file)? |
@@ -119,9 +119,11 @@ def generate_order_lines_payload(lines: Iterable[OrderLine]):
lines,
fields=line_fields,
extra_dict_data={
+ "id": (lambda l: graphene.Node.to_global_id("OrderLine", l.pk)),
"total_price_net_amount": (lambda l: l.total_price.net.amount),
... | [generate_sample_payload->[generate_product_payload,_generate_sample_order_payload,_get_sample_object,generate_fulfillment_payload,generate_customer_payload,_remove_token_from_checkout,generate_page_payload,generate_checkout_payload],generate_product_payload->[serialize_product_channel_listing_payload],_generate_sample... | Generate order lines payload. | Make sure that you added prefetches for variant and product here. |
@@ -155,7 +155,8 @@ public class ComponentValueProviderTestCase extends DeclarationSessionTestCase {
.getDeclaration())
.getDeclaration();
validateValuesFailure(session, operationElementDeclaration, "anyParameter",
- "There is no extensionModel for extension: ... | [ComponentValueProviderTestCase->[configLessConnectionLessOnOperation->[configLessConnectionLessOPDeclaration,validateValuesSuccess],configLessConnectionLessOnOperationWithMissingConfigWorks->[configLessConnectionLessOPDeclaration,validateValuesSuccess],actingParameterOnOperation->[actingParameterOPDeclaration,validate... | Get values with wrong declaration. | Revert this as we need to understand why this error has changed. |
@@ -86,6 +86,7 @@ namespace Dynamo.PackageDependency
// TODO: Not ideal! O(N * M) complexicty, would like LoadedPackageDependencies to be a dictionary or something with constant package name search time
if (!matchFound)
{
+ MissingPackage = true;
... | [PackageDependencyView->[OnWorkspaceCleared->[Clear],OnWorkspaceChanged->[PropertyChanged,DependencyRegen],DependencyRegen->[Clear,LoadedPackageDependencies,Name,PackageDependencies,WarningColor,ToString,Add,Equals],OnWorkspacePropertyChanged->[DependencyRegen,PropertyName,PackageDependencies,nameof],InitializeComponen... | This method is called when a workspace has no dependencies. | I think the `DependencyRegen` method needs a unit test. |
@@ -125,7 +125,10 @@ public class CompositeSourcePolicy extends
*/
@Override
protected Publisher<CoreEvent> processPolicy(Policy policy, Processor nextProcessor, CoreEvent event) {
- return just(event).transform(sourcePolicyProcessorFactory.createSourcePolicy(policy, nextProcessor));
+ logPolicy(getCore... | [CompositeSourcePolicy->[processPolicy->[createSourcePolicy,transform],process->[just,orElse,left,onErrorResume,SourcePolicyFailureResult],processNextOperation->[getMessage,error,doOnError],concatMaps->[putAll],getLogger]] | Process the given policy with the given processor. | this "before" log should be done inside the publisher chain returned by this method |
@@ -39,14 +39,7 @@ abstract public class AbstractLauncher implements ILauncher {
if (!m_headless && !SwingUtilities.isEventDispatchThread()) {
throw new IllegalStateException("Wrong thread");
}
- final Runnable r = new Runnable() {
- @Override
- public void run() {
- // we don't wan... | [AbstractLauncher->[launch->[run->[clearNewGameChooserModel,launchInNewThread],IllegalStateException,Thread,setLocationRelativeTo,Runnable,start,setVisible,isEventDispatchThread,getFrameForComponent,showWait],getGameData,WaitWindow]] | Launch the new thread. | removed this one line, then collapsed into a one-line lambda |
@@ -1346,7 +1346,7 @@ class DistributeTranspiler(object):
for key in opt_op.input_names:
new_shape = None
- if key in ["Param", "Grad", "LearningRate", "Moment", "MeanSquare"]:
+ if key in ["Param", "Grad", "LearningRate"]:
continue
var = self.... | [DistributeTranspiler->[_append_pserver_ops->[_get_param_block->[same_or_split_var],_get_optimizer_input_shape,_get_param_block],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected],_orig_varname->[_get_varname_parts],_get_optimize_pass->[... | Append pserver ops to the optimizer block. add a to optimize_block. | glad to see these are gone. Can you briefly explain what it was added and why we don't need it anymore? |
@@ -454,12 +454,13 @@ namespace System.DirectoryServices.Protocols
IntPtr tmp = Marshal.AllocHGlobal(tempValue.Length);
Marshal.Copy(tempValue, 0, tmp, tempValue.Length);
HGlobalMemHandle memHandle = new HGlobalMemHandle(tmp);
-
- error = Wldap32.ber_pri... | [BerConverter->[DecodingByteArrayHelper->[Copy,bv_len,bv_val,WriteLine,ber_scanf_ptr,ber_bvfree,PtrToStructure,Zero],DecodingMultiByteArrayHelper->[Copy,Size,bv_len,bv_val,Count,WriteLine,ReadIntPtr,ber_scanf_ptr,ber_bvecfree,PtrToStructure,Zero,Add],EncodingByteArrayHelper->[Copy,ber_printf_bytearray,AllocHGlobal,Zero... | Helper method to encode a byte array. | >0 [](start = 50, length = 1) This looks strange :-) allocating 0 bytes and wrapping it inside safehandle. does the native call can grow the memory? |
@@ -1261,6 +1261,7 @@ resource "aws_ecs_service" "main" {
network_configuration {
security_groups = ["${aws_security_group.allow_all_a.id}", "${aws_security_group.allow_all_b.id}"]
subnets = ["${aws_subnet.main.*.id}"]
+ assign_public_ip = "ENABLED"
}
}
`, rName, rName)
| [Meta,Test,TestMatchResourceAttr,Sprintf,RandInt,TestCheckResourceAttr,RandString,RootModule,ComposeTestCheckFunc,DescribeServices,String,Errorf,Fatalf,RandomWithPrefix,MustCompile] | The number of network groups that are allowed in the network. | I am not sure if this is all I need to do for the test. Seems like I am missing something |
@@ -2040,3 +2040,15 @@ type LoginStateTimeoutError struct {
func (e LoginStateTimeoutError) Error() string {
return fmt.Sprintf("LoginState request timeout - attempted: %s, active request: %s, duration: %s", e.ActiveRequest, e.AttemptedRequest, e.Duration)
}
+
+type KBFSNotRunning struct{}
+
+func (e KBFSNotRunning... | [Error->[Join,Sprintf,Seqno,IsNil,String,EncodeToString],Sprintf,GetProofStatus,New,Error] | Error returns a string representation of the login state timeout error. | Can we rename this to have an `Error` suffix to be consistent with every other error type in this file? |
@@ -139,7 +139,6 @@ public class TestOzoneShellHA {
.setOMServiceId(omServiceId)
.setNumOfOzoneManagers(numOfOMs)
.build();
- conf.setQuietMode(false);
cluster.waitForClusterToBeReady();
}
| [TestOzoneShellHA->[testOzoneShCmdURIs->[getLeaderOMNodeId,execute,executeWithError],getHASetConfStrings->[getSetConfStringFromConf,generateSetConfString,getHASetConfStrings],shutdown->[shutdown],reset->[reset],testOzoneShCmdList->[reset,getNumOfBuckets,getNumOfKeys,execute,generateKeys,generateBuckets],testOzoneAdminC... | Initialize Ozone cluster. | the quiet mode was suppressed because Hadoop 3.3 expects hdfs-rbf-default.xml which we don't have. Another workaround proposed by @smengcl is to add a dummy hdfs-rbf-default.xml as a resource file. |
@@ -166,6 +166,14 @@ public class VirtManagerSalt implements VirtManager {
pillar.put("virt_entitled", minion.hasVirtualizationEntitlement());
saltApi.callSync(State.apply(Collections.singletonList("virt.engine-events"),
Optional.of(pillar)), minion.getMinionId());
+
+ if (mini... | [VirtManagerSalt->[getGuestDefinition->[of,parse,empty,callSync,put,map],getCapabilities->[empty,callSync],getNetworks->[toMap,of,getKey,orElse,empty,callSync,collect,getAsJsonObject],getPoolCapabilities->[empty,callSync],getVolumes->[of,orElse,empty,callSync,asList],getPools->[toMap,of,getKey,orElse,empty,callSync,col... | Update the libvirt engine. | why is this needed? |
@@ -262,9 +262,8 @@ public class DefaultExpressionManager implements ExtendedExpressionManager, Init
return success();
}
- protected static boolean isDwExpression(String expression) {
- //TODO: MULE-10410 - Remove once DW is the default language.
- return expression.startsWith(DEFAULT_EXPRESSION_PREFIX... | [DefaultExpressionManager->[evaluateBoolean->[evaluateBoolean],validate->[validate,parse],parse->[parse,evaluate],enrich->[enrich],transform->[transform],evaluate->[evaluate]]] | Validate the given expression. | would it be valid for the 'mel' token to be in the middle of an expression instead of at the start? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.